Context Navigation

← Previous Period
Next Period →

Timeline

Dec 31, 2012:

12:37 PM Changeset in webkit [138600] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Fullscreen Media Time Indicators Background Incorrect
https://bugs.webkit.org/show_bug.cgi?id=105888

Patch by Jeff Rogers <jrogers@rim.com> on 2012-12-31
Reviewed by George Staikos.

Internal PR 272699.
Update fullscreen media controls CSS to fix time container background
color. Also fix transparency to be 80% opaque to and the time
remaining text color to match the system player.

No new tests as there is no functionality change.

css/mediaControlsBlackBerryFullscreen.css:

(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-time-display-container):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-timeline-container):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-current-time-display):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-time-remaining-display):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-button-container, video:-webkit-full-screen::-webkit-media-controls-play-button-container):
(video:-webkit-full-screen::-webkit-media-controls-placeholder):

11:53 AM Changeset in webkit [138599] by weinig@apple.com

7 edits
1 add in trunk/Source/WebKit2

Add supplementability for WebContext
https://bugs.webkit.org/show_bug.cgi?id=105878

Reviewed by Dan Bernstein.

Add WebContextSupplement and convert WebApplicationCacheManagerProxy to it.

UIProcess/API/C/WKContext.cpp:

(WKContextGetApplicationCacheManager):

UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::supplementName):
(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::contextDestroyed):
(WebKit::WebApplicationCacheManagerProxy::processDidClose):
(WebKit::WebApplicationCacheManagerProxy::refWebContextSupplement):
(WebKit::WebApplicationCacheManagerProxy::derefWebContextSupplement):
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):

UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):

UIProcess/WebContext.h:

(WebKit::WebContext::supplement):
(WebKit::WebContext::addSupplement):

UIProcess/WebContextSupplement.h: Added.

(WebKit::WebContextSupplement::WebContextSupplement):
(WebKit::WebContextSupplement::~WebContextSupplement):
(WebKit::WebContextSupplement::ref):
(WebKit::WebContextSupplement::deref):
(WebKit::WebContextSupplement::context):
(WebKit::WebContextSupplement::clearContext):

WebKit2.xcodeproj/project.pbxproj:

8:56 AM Changeset in webkit [138598] by commit-queue@webkit.org

4 edits in trunk

[EFL][WebGL] Add compile time support for GLES2.
https://bugs.webkit.org/show_bug.cgi?id=105816

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-31
Reviewed by Kenneth Rohde Christiansen.

This patch adds build support for GLES2.
GLES2 support can be enabled during compile time by passing -DENABLE_GLES2=ON as
cmake config parameter. GLES2 options is not enabled by default. This patch doesn't
address all the build issues related to GLES2 but only adds the needed support in
OptionsEfl.cmake.

Source/cmake/OptionsEfl.cmake:

Source/WebCore:

PlatformEfl.cmake:

8:31 AM Changeset in webkit [138597] by Christophe Dumez

2 edits in trunk/Source/WebKit2

[EFL[WK2] Regression(r138574): Should not allocate memory in the fork
https://bugs.webkit.org/show_bug.cgi?id=105868

Reviewed by Kenneth Rohde Christiansen.

Store prefixed executable path in a CString before the fork to
avoid allocating memory in the fork by calling String::utf8().
Allocating memory in the fork may lead to deadlocks due to
FastMalloc and the fork not inheriting the threads.

UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess):

8:05 AM Changeset in webkit [138596] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] The HTML5 video fullscreen time indicator on the right cuts clipped when the video is longer than 1 hour
https://bugs.webkit.org/show_bug.cgi?id=105887

Patch by Andy Chen <andchen@rim.com> on 2012-12-31
Reviewed by George Staikos.

The width of the time part was fixed. Remove it.

No new test is required because no functionality change.

platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):

5:54 AM Changeset in webkit [138595] by commit-queue@webkit.org

4 edits
1 move
1 add
1 delete in trunk

[GTK] Move ImageDiff to the Tools directory root
https://bugs.webkit.org/show_bug.cgi?id=105421

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2012-12-31
Reviewed by Kenneth Rohde Christiansen.

GNUmakefile.am: Remove the old ImageDiff makefile include.

Tools:

DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
GNUmakefile.am:
ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.

5:25 AM Changeset in webkit [138594] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[EFL] css3/masking/clip-path-circle-relative-overflow.html needs expected results update after 97217
https://bugs.webkit.org/show_bug.cgi?id=105883

Unreviewed, EFL gardening.

Rebaseline css3/masking/clip-path-circle-relative-overflow.html because BUG 97217 has been resolved.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-31

platform/efl/TestExpectations:
platform/efl/css3/masking/clip-path-circle-relative-overflow-expected.png:

4:50 AM Changeset in webkit [138593] by Carlos Garcia Campos

12 edits in trunk/Source/WebKit2

[GTK] Add API to set a WebKitWebView in view source mode to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=99315

Reviewed by Martin Robinson.

Add a generic API to set/get a view mode. For now there are only
two modes, Web and Source, but the API can be extended if we
eventually support other view modes like Printing for example.

UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetProperty): Implement setter for view-mode
property.
(webkitWebViewGetProperty): Implement getter for view-mode
property.
(webkit_web_view_class_init): Add view-source property.
(webkit_web_view_set_view_mode): Public method to set the view
mode.
(webkit_web_view_get_view_mode): Public method to get the view
mode.

UIProcess/API/gtk/WebKitWebView.h: Add WebKitViewMode enum.
UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewMode):
(beforeAll):

UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::WebFrameProxy): Initialize
m_inViewSourceMode.
(WebKit::WebFrameProxy::setInViewSourceMode): Set
m_inViewSourceMode if it has changed and call
WebPageProxy::setFrameInViewSourceMode() to notify the WebProcess.

UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::inViewSourceMode): Return whether the
frame is currently in view source mode.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFrameInViewSourceMode): Send a message
to the WebProcess to set the given frame in view source mode or not.

UIProcess/WebPageProxy.h:

(WebPageProxy): Add setFrameInViewSourceMode().

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setFrameInViewSourceMode): Call
setInViewSourceMode for the main frame.

WebProcess/WebPage/WebPage.h:

(WebPage): Add setFrameInViewSourceMode().

WebProcess/WebPage/WebPage.messages.in: Add new message

SetFrameInViewSourceMode.

12:57 AM Changeset in webkit [138592] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark editing/spelling/spelling-insert-html.html as flaky
since it sometimes hits an assertion in RenderObject
destructor.

platform/efl/TestExpectations:

Dec 30, 2012:

11:57 PM Changeset in webkit [138591] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark fast/dom/Range/range-extract-contents.html as flaky
since it sometimes hits an assertion in
WebCore::endOfContinuations().

platform/efl/TestExpectations:

11:49 PM Changeset in webkit [138590] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark editing/pasteboard/4806874.html as flaky since
it sometimes hits an assertion in RenderObject
destructor.

platform/efl/TestExpectations:

11:41 PM Changeset in webkit [138589] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/js/global-constructors.html after
TEMPLATE_ELEMENT was enabled for EFL port in r138586.

platform/efl/fast/js/global-constructors-expected.txt:

11:33 PM Changeset in webkit [138588] by commit-queue@webkit.org

5 edits
2 moves in trunk

[EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector.
https://bugs.webkit.org/show_bug.cgi?id=105876

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-30
Reviewed by Kenneth Rohde Christiansen.

This is to sync the naming conventions of our classes in both EGL and GLX implementations.
In our GLX implementation, class responsible for the same functionality is named as GLXConfigSelector.
This patch renames EGLConfigHelper as EGLConfigSelector.

Source/cmake/OptionsEfl.cmake:

Source/WebCore:

PlatformEfl.cmake:
platform/graphics/surfaces/egl/EGLConfigSelector.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/egl/EGLConfigHelper.cpp.

(WebCore):
(WebCore::SharedEGLDisplay::deref):
(WebCore::SharedEGLDisplay::sharedEGLDisplay):
(WebCore::SharedEGLDisplay::SharedEGLDisplay):
(WebCore::SharedEGLDisplay::cleanup):
(WebCore::SharedEGLDisplay::~SharedEGLDisplay):
(WebCore::EGLConfigSelector::EGLConfigSelector):
(WebCore::EGLConfigSelector::~EGLConfigSelector):
(WebCore::EGLConfigSelector::display):
(WebCore::EGLConfigSelector::pBufferContextConfig):
(WebCore::EGLConfigSelector::surfaceContextConfig):
(WebCore::EGLConfigSelector::nativeVisualId):
(WebCore::EGLConfigSelector::reset):
(WebCore::EGLConfigSelector::createConfig):

platform/graphics/surfaces/egl/EGLConfigSelector.h: Renamed from Source/WebCore/platform/graphics/surfaces/egl/EGLConfigHelper.h.

(WebCore):
(SharedEGLDisplay):
(WebCore::SharedEGLDisplay::create):
(EGLConfigSelector):

platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::configuration):
(WebCore::EGLWindowTransportSurface::destroy):

platform/graphics/surfaces/egl/EGLSurface.h:

(EGLWindowTransportSurface):

11:12 PM Changeset in webkit [138587] by mkwst@chromium.org

3 edits in trunk/Tools

Add myself to watchlists for CSP and console logs.
https://bugs.webkit.org/show_bug.cgi?id=105874

Reviewed by Dirk Pranke.

Because I really, really, really need more email.

Scripts/webkitpy/common/config/committers.py:

Add mkwst+watchlist@chromium.org as a contributor.

Scripts/webkitpy/common/config/watchlist:

Create watchlist categories for 1) the various mechanisms used to
generate console messages, and 2) CSP usage and files.

8:44 PM Changeset in webkit [138586] by gyuyoung.kim@samsung.com

6 edits in trunk

.: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865

Reviewed by Laszlo Gombos.

Source/cmake/OptionsEfl.cmake: Add ENABLE_TEMPLATE_ELEMENT macro.

Tools: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865

Reviewed by Laszlo Gombos.

Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.

LayoutTests: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865

Reviewed by Laszlo Gombos.

platform/efl/TestExpectations: Unskip test cases for template element.

1:22 PM Changeset in webkit [138585] by Martin Robinson

2 edits in trunk/Websites/bugs.webkit.org

PrettyDiff.rb fails to render image diffs with Ruby 1.9.3p194
https://bugs.webkit.org/show_bug.cgi?id=104932

Reviewed by Eric Seidel.

Ruby 1.9 added the concept of string encodings, so the use of `match' with binary data
treats it as UTF-8. Forcing the png_bytes string to have the "binary" encoding avoids
this error.

PrettyPatch/PrettyPatch.rb: Use force_encoding.

9:51 AM Changeset in webkit [138584] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Add several webaudio tests to TestExpectations since
they sometimes hit !m_finishedNodes.size() assertion
in AudioContext destructor.

platform/efl/TestExpectations:

9:37 AM Changeset in webkit [138583] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip XSS Auditor test case that has been consistently
passing on EFL port for a while.

platform/efl/TestExpectations:

9:08 AM Changeset in webkit [138582] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip fast/dom/shadow/host-wrapper-reclaimed.html
since it is passing after r137978.

platform/efl/TestExpectations:

9:05 AM Changeset in webkit [138581] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Update expectations for 2 fast/dom test cases so
that they are not reported as unexpected passes.

Those tests are passing because their generated
expectations are wrong.

platform/efl/TestExpectations:

8:57 AM Changeset in webkit [138580] by Philippe Normand

4 edits in trunk

[GStreamer] webaudio/decode-audio-data-basic.html fails
https://bugs.webkit.org/show_bug.cgi?id=105298

Reviewed by Martin Robinson.

Source/WebCore:

platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus): Return a null pointer if an
error happened while processing a media file.

LayoutTests:

platform/efl/TestExpectations: Unflag fixed test.

8:55 AM Changeset in webkit [138579] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip text-decoration-style tests passing after
r126054 and r132076.

platform/efl/TestExpectations:

7:55 AM Changeset in webkit [138578] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip cairo-related tests that are now consistently
passing on both WK1 and WK2 EFL.

platform/efl/TestExpectations:

7:45 AM Changeset in webkit [138577] by Christophe Dumez

3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip several compositing test cases that are passing
consistently on EFL WK2.

platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:

6:57 AM Changeset in webkit [138576] by Christophe Dumez

3 edits in trunk/Source/WebCore

Regression(r138545): Makes WebAudio tests crash
https://bugs.webkit.org/show_bug.cgi?id=105869

Reviewed by Philippe Normand.

Stop using smart pointers and adoptGRef() for the
GstBus object and call gst_object_unref() manually.
This fixes assertions hits when calling adoptGRef()
since the GstBus object has a floating reference.

Alternatively, we could keep using smart pointers
and stop calling adoptGRef() so that
gst_object_ref_sink() is called and the floating
flag is cleared but I think it is clearer to do
it manually here.

No new tests, already covered by existing tests.

platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::messageCallback):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):