⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 1, 2013:

10:53 PM Changeset in webkit [138608] by Christophe Dumez
  • 6 edits in trunk

[WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
https://bugs.webkit.org/show_bug.cgi?id=105897

Reviewed by Alexey Proskuryakov.

Tools:

Dump in WebKitTestRunner the message that is expected by layout tests
when the missing plugin button is clicked.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::unavailablePluginButtonClicked):
(WTR):

  • WebKitTestRunner/TestController.h:

(TestController):

LayoutTests:

Unskip plugins/clicking-missing-plugin-fires-delegate.html for
WK2 now that WebKitTestRunner is dumping the expected text when
the missing plugin button is clicked.

  • platform/efl-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
8:19 PM Changeset in webkit [138607] by weinig@apple.com
  • 28 edits in trunk/Source/WebKit2

Convert more classes to be WebContextSupplements
https://bugs.webkit.org/show_bug.cgi?id=105890

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetCookieManager):
(WKContextGetDatabaseManager):
(WKContextGetGeolocationManager):
(WKContextGetKeyValueStorageManager):
(WKContextGetMediaCacheManager):
(WKContextGetNotificationManager):
(WKContextGetResourceCacheManager):

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::cookieManager):
(EwkContext::clearResourceCache):

  • UIProcess/API/efl/ewk_database_manager_private.h:

(EwkDatabaseManager::create):

  • UIProcess/API/efl/ewk_storage_manager_private.h:

(EwkStorageManager::create):

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(createDefaultWebContext):
(webkit_web_context_clear_cache):
(webkit_web_context_get_cookie_manager):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::supplementName):
(WebKit):
(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy):
(WebKit::WebNotificationManagerProxy::initializeProvider):
(WebKit::WebNotificationManagerProxy::contextDestroyed):
(WebKit::WebNotificationManagerProxy::processDidClose):
(WebKit::WebNotificationManagerProxy::refWebContextSupplement):
(WebKit::WebNotificationManagerProxy::derefWebContextSupplement):
(WebKit::WebNotificationManagerProxy::didReceiveMessage):
(WebKit::WebNotificationManagerProxy::providerDidShowNotification):
(WebKit::WebNotificationManagerProxy::providerDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
(WebKit::WebNotificationManagerProxy::providerDidUpdateNotificationPolicy):
(WebKit::WebNotificationManagerProxy::providerDidRemoveNotificationPolicies):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::removeNetworkProcessProxy):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):

  • UIProcess/WebContext.h:

(WebKit):
(WebContext):
(WebKit::WebContext::iconDatabase):

  • UIProcess/WebContextSupplement.h:

(WebKit):
(WebKit::WebContextSupplement::contextDestroyed):
(WebKit::WebContextSupplement::processDidClose):
(WebContextSupplement):
(WebKit::WebContextSupplement::shouldTerminate):
(WebKit::WebContextSupplement::ref):
(WebKit::WebContextSupplement::deref):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::supplementName):
(WebKit):
(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::initializeClient):
(WebKit::WebCookieManagerProxy::contextDestroyed):
(WebKit::WebCookieManagerProxy::processDidClose):
(WebKit::WebCookieManagerProxy::shouldTerminate):
(WebKit::WebCookieManagerProxy::refWebContextSupplement):
(WebKit::WebCookieManagerProxy::derefWebContextSupplement):
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):

  • UIProcess/WebCookieManagerProxy.h:

(WebCookieManagerProxy):

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::supplementName):
(WebKit):
(WebKit::WebDatabaseManagerProxy::WebDatabaseManagerProxy):
(WebKit::WebDatabaseManagerProxy::initializeClient):
(WebKit::WebDatabaseManagerProxy::contextDestroyed):
(WebKit::WebDatabaseManagerProxy::processDidClose):
(WebKit::WebDatabaseManagerProxy::refWebContextSupplement):
(WebKit::WebDatabaseManagerProxy::derefWebContextSupplement):
(WebKit::WebDatabaseManagerProxy::didReceiveMessage):
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):

  • UIProcess/WebDatabaseManagerProxy.h:

(WebDatabaseManagerProxy):

  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::supplementName):
(WebKit):
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::initializeProvider):
(WebKit::WebGeolocationManagerProxy::contextDestroyed):
(WebKit::WebGeolocationManagerProxy::processDidClose):
(WebKit::WebGeolocationManagerProxy::refWebContextSupplement):
(WebKit::WebGeolocationManagerProxy::derefWebContextSupplement):
(WebKit::WebGeolocationManagerProxy::didReceiveMessage):
(WebKit::WebGeolocationManagerProxy::providerDidChangePosition):
(WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition):

  • UIProcess/WebGeolocationManagerProxy.h:

(WebGeolocationManagerProxy):

  • UIProcess/WebKeyValueStorageManagerProxy.cpp:

(WebKit::WebKeyValueStorageManagerProxy::supplementName):
(WebKit):
(WebKit::WebKeyValueStorageManagerProxy::WebKeyValueStorageManagerProxy):
(WebKit::WebKeyValueStorageManagerProxy::contextDestroyed):
(WebKit::WebKeyValueStorageManagerProxy::processDidClose):
(WebKit::WebKeyValueStorageManagerProxy::refWebContextSupplement):
(WebKit::WebKeyValueStorageManagerProxy::derefWebContextSupplement):
(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):

  • UIProcess/WebKeyValueStorageManagerProxy.h:

(WebKeyValueStorageManagerProxy):

  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::supplementName):
(WebKit):
(WebKit::WebMediaCacheManagerProxy::WebMediaCacheManagerProxy):
(WebKit::WebMediaCacheManagerProxy::contextDestroyed):
(WebKit::WebMediaCacheManagerProxy::processDidClose):
(WebKit::WebMediaCacheManagerProxy::refWebContextSupplement):
(WebKit::WebMediaCacheManagerProxy::derefWebContextSupplement):
(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManagerProxy::clearCacheForHostname):
(WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames):

  • UIProcess/WebMediaCacheManagerProxy.h:

(WebMediaCacheManagerProxy):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showNotification):

  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::supplementName):
(WebKit):
(WebKit::WebResourceCacheManagerProxy::WebResourceCacheManagerProxy):
(WebKit::WebResourceCacheManagerProxy::contextDestroyed):
(WebKit::WebResourceCacheManagerProxy::processDidClose):
(WebKit::WebResourceCacheManagerProxy::refWebContextSupplement):
(WebKit::WebResourceCacheManagerProxy::derefWebContextSupplement):
(WebKit::WebResourceCacheManagerProxy::didReceiveMessage):
(WebKit::WebResourceCacheManagerProxy::getCacheOrigins):
(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):

  • UIProcess/WebResourceCacheManagerProxy.h:

(WebResourceCacheManagerProxy):

  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

8:18 PM Changeset in webkit [138606] by mitz@apple.com
  • 16 edits in trunk

<rdar://problem/12942239> Update copyright strings

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • Info.plist:

Source/WebCore:

  • Info.plist:

Source/WebKit/mac:

  • Info.plist:

Source/WebKit2:

  • Info.plist:
  • NetworkProcess/Info.plist:
  • PluginProcess/Info.plist:
  • SharedWorkerProcess/Info.plist:
  • WebProcess/Info.plist:
  • WebProcessService/Info.plist:
  • WebProcessServiceForWebKitDevelopment/Info.plist:

WebKitLibraries:

  • win/tools/scripts/COPYRIGHT-END-YEAR:
8:14 PM Changeset in webkit [138605] by commit-queue@webkit.org
  • 9 edits in trunk

[EFL] Enable MHTML feature
https://bugs.webkit.org/show_bug.cgi?id=105815

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-01-01
Reviewed by Laszlo Gombos.

.:

ENABLE_MHTML is now ON for EFL.

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Add application/x-mimearchive type to archive mime types.
Add mht and mhtml to extension map.

No new tests. Existing layout tests pass.

  • loader/archive/ArchiveFactory.cpp:

(WebCore::archiveMIMETypes):

  • platform/efl/MIMETypeRegistryEfl.cpp:

(WebCore):

Source/WebKit2:

Add missing include directory for ENABLE_MHTML.

  • CMakeLists.txt:

Tools:

Enable MHTML feature for EFL port by default.

  • Scripts/webkitperl/FeatureList.pm:
7:51 PM Changeset in webkit [138604] by barraclough@apple.com
  • 13 edits
    18 adds in trunk/Source

Objective-C API for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=105889

Reviewed by Filip Pizlo.

../JavaScriptCore:

For a detailed description of the API implemented here, see:

JSContext.h
APIJSValue.h
JSVirtualMachine.h
JSExport.h

Still to do -

(1) Shoud rename APIJSValue.h -> JSValue.h (but we'll have to rename JSValue.h first).
(2) Numerous FIXMEs, all with separate bugs filed.

  • API/APIJSValue.h: Added.
    • this Objective-C class is used to reference a JavaScript object.
  • API/JSBase.h:
    • added JS_OBJC_API_ENABLED macro to control ObjC API support.
  • API/JSBlockAdaptor.h: Added.
    • this Objective-C class is used in creating a special NSBlock proxying a JavaScript function.
  • API/JSBlockAdaptor.mm: Added.

(BlockArgument):
(BlockArgument::~BlockArgument):
(BlockArgumentBoolean):
(BlockArgumentBoolean::get):
(BlockArgumentNumeric):
(BlockArgumentNumeric::get):
(BlockArgumentId):
(BlockArgumentId::get):
(BlockArgumentStruct):
(BlockArgumentStruct::BlockArgumentStruct):
(BlockArgumentStruct::~BlockArgumentStruct):
(BlockArgumentStruct::get):

  • decoded arguent type information of a JSBlockAdaptor.

(BlockArgumentTypeDelegate):
(BlockArgumentTypeDelegate::typeInteger):
(BlockArgumentTypeDelegate::typeDouble):
(BlockArgumentTypeDelegate::typeBool):
(BlockArgumentTypeDelegate::typeVoid):
(BlockArgumentTypeDelegate::typeId):
(BlockArgumentTypeDelegate::typeOfClass):
(BlockArgumentTypeDelegate::typeBlock):
(BlockArgumentTypeDelegate::typeStruct):

  • delegate for use in conjunction with parseObjCType.

(BlockResult):
(BlockResult::~BlockResult):
(BlockResultVoid):
(BlockResultVoid::set):
(BlockResultInteger):
(BlockResultInteger::set):
(BlockResultDouble):
(BlockResultDouble::set):
(BlockResultBoolean):
(BlockResultBoolean::set):
(BlockResultStruct):
(BlockResultStruct::BlockResultStruct):
(BlockResultStruct::~BlockResultStruct):
(BlockResultStruct::set):

  • decoded result type information of a JSBlockAdaptor.

(buildBlockSignature):

  • partial step in constructing a signature with stack offset information from one without.

(-[JSBlockAdaptor initWithBlockSignatureFromProtocol:]):

  • constructor.

(-[JSBlockAdaptor blockMatchesSignature:]):

  • check whether signature strings match, where only one contains stack frame offsets.

(-[JSBlockAdaptor blockFromValue:inContext:withException:]):

  • use the adaptor to create a special forwarding block.
  • API/JSCallbackObjectFunctions.h:

(JSC::::inherits):

  • add missing braces to multiline for statement.
  • API/JSContext.h: Added.
    • this Objective-C class is used to reference a JavaScript context.
  • API/JSContext.mm: Added.

(-[JSContext init]):

  • constructor.

(-[JSContext initWithVirtualMachine:]):

  • construct in a given VM (JSGlobalData).

(-[JSContext evaluateScript:]):
(-[JSContext globalObject]):

  • evaluate a script, global object accessor.

(+[JSContext currentContext]):
(+[JSContext currentThis]):
(+[JSContext currentArguments]):

  • These methods obtain context, this, arguments from within a callback.

(-[JSContext virtualMachine]):

  • implementation for .virtualMachine property.

(-[JSContext objectForKeyedSubscript:]):
(-[JSContext setObject:forKeyedSubscript:]):

  • support for subscript property access.

(contextInternalContext):

  • internal accessor to m_context.

(-[JSContext dealloc]):

  • desctructor.

(-[JSContext notifyException:]):
(-[JSContext valueFromNotifyException:]):
(-[JSContext boolFromNotifyException:]):

  • internal method to record an exception was thrown.

(-[JSContext beginCallbackWithData:thisValue:argumentCount:arguments:]):
(-[JSContext endCallbackWithData:]):

  • internal methods to push/pop a callback record.

(-[JSContext protect:]):
(-[JSContext unprotect:]):

  • internal methods to add a value to a protect set (used to protect the internal property of JSValue).

(-[JSContext wrapperForObject:]):

  • internal method to create a wrapper object.

(WeakContextRef::WeakContextRef):
(WeakContextRef::~WeakContextRef):
(WeakContextRef::get):
(WeakContextRef::set):

  • Helper class to implement a weak reference to a JSContext.
  • API/JSContextInternal.h: Added.

(CallbackData):
(WeakContextRef):

  • see API/JSContext.mm for description of internal methods.
  • API/JSExport.h: Added.
    • Provides JSExport protocol & JSExportAs macro.
  • API/JSValue.mm: Added.

(+[JSValue valueWithObject:inContext:]):
(+[JSValue valueWithBool:inContext:]):
(+[JSValue valueWithDouble:inContext:]):
(+[JSValue valueWithInt32:inContext:]):
(+[JSValue valueWithUInt32:inContext:]):
(+[JSValue valueWithNewObjectInContext:]):
(+[JSValue valueWithNewArrayInContext:]):
(+[JSValue valueWithNewRegularExpressionFromPattern:flags:inContext:]):
(+[JSValue valueWithNewErrorFromMessage:inContext:]):
(+[JSValue valueWithNullInContext:]):
(+[JSValue valueWithUndefinedInContext:]):

  • Constructors.

(-[JSValue toObject]):
(-[JSValue toObjectOfClass:]):
(-[JSValue toBool]):
(-[JSValue toDouble]):
(-[JSValue toInt32]):
(-[JSValue toUInt32]):
(-[JSValue toNumber]):
(-[JSValue toString]):
(-[JSValue toDate]):
(-[JSValue toArray]):
(-[JSValue toDictionary]):

  • Conversion to Objective-C types.

(-[JSValue valueForProperty:]):
(-[JSValue setValue:forProperty:]):
(-[JSValue deleteProperty:]):
(-[JSValue hasProperty:]):
(-[JSValue defineProperty:descriptor:]):

  • Property access by property name.

(-[JSValue valueAtIndex:]):
(-[JSValue setValue:atIndex:]):

  • Property access by index.

(-[JSValue isUndefined]):
(-[JSValue isNull]):
(-[JSValue isBoolean]):
(-[JSValue isNumber]):
(-[JSValue isString]):
(-[JSValue isObject]):

  • Test JavaScript type.

(-[JSValue isEqualToObject:]):
(-[JSValue isEqualWithTypeCoercionToObject:]):
(-[JSValue isInstanceOf:]):

  • ===, ==, instanceof operators.

(-[JSValue callWithArguments:]):
(-[JSValue constructWithArguments:]):
(-[JSValue invokeMethod:withArguments:]):

  • Call & construct.

(-[JSValue context]):

  • implementation for .context property.

(-[JSValue toPoint]):
(-[JSValue toRange]):
(-[JSValue toRect]):
(-[JSValue toSize]):
(+[JSValue valueWithPoint:inContext:]):
(+[JSValue valueWithRange:inContext:]):
(+[JSValue valueWithRect:inContext:]):
(+[JSValue valueWithSize:inContext:]):

  • Support for NS struct types.

(-[JSValue objectForKeyedSubscript:]):
(-[JSValue objectAtIndexedSubscript:]):
(-[JSValue setObject:forKeyedSubscript:]):
(-[JSValue setObject:atIndexedSubscript:]):

  • support for subscript property access.

(isDate):
(isArray):

  • internal helper functions to check for instances of JS Date, Array types.

(JSContainerConvertor):
(Task):
(JSContainerConvertor::JSContainerConvertor):
(JSContainerConvertor::isWorkListEmpty):
(JSContainerConvertor::convert):
(JSContainerConvertor::add):
(JSContainerConvertor::take):

  • helper class for tracking state while converting to Array/Dictionary objects.

(valueToObjectWithoutCopy):
(containerValueToObject):
(valueToObject):
(valueToNumber):
(valueToString):
(valueToDate):
(valueToArray):
(valueToDictionary):

  • function for converting JavaScript values to Objective-C objects.

(ObjcContainerConvertor):
(ObjcContainerConvertor::ObjcContainerConvertor):
(ObjcContainerConvertor::isWorkListEmpty):
(ObjcContainerConvertor::convert):
(ObjcContainerConvertor::add):
(ObjcContainerConvertor::take):

  • helper class for tracking state while converting to Array/Dictionary values.

(objectToValueWithoutCopy):
(objectToValue):
(valueInternalValue):

  • function for converting Objective-C objects to JavaScript values.

(+[JSValue valueWithValue:inContext:]):
(-[JSValue initWithValue:inContext:]):

  • internal constructors.

(StructTagHandler):
(getStructTagHandler):
(+[JSValue selectorForStructToValue:]):
(+[JSValue selectorForValueToStruct:]):

  • methods to tracking struct types that support conversion to/from JSValue.

(-[JSValue dealloc]):

  • destructor.

(-[JSValue description]):

  • Objective-C to-NSString conversion.

(typeToValueInvocationFor):
(valueToTypeInvocationFor):

  • create invocation objects for conversion to/from JSValue.
  • API/JSValueInternal.h: Added.
    • see API/JSValue.mm for description of internal methods.
  • API/JSVirtualMachine.h: Added.
    • this Objective-C class is used to reference a JavaScript virtual machine (JSGlobalData).
  • API/JSVirtualMachine.mm: Added.

(-[JSVirtualMachine init]):
(-[JSVirtualMachine dealloc]):

  • constructor & destructor.

(getGroupFromVirtualMachine):

  • internal accessor for m_group property.
  • API/JSVirtualMachineInternal.h: Added.
    • see API/JSVirtualMachine.mm for description of internal methods.
  • API/JSWrapperMap.h: Added.
  • API/JSWrapperMap.mm: Added.

(wrapperClass):

  • singleton root for detction (& unwrapping) of wrapper objects.

(selectorToPropertyName):

  • default selector to property name conversion.

(createObjectWithCustomBrand):

  • creates a JSObject with a custom NativeBrand (class name).

(createRenameMap):

  • parse @optional properties of a JSExport protocol.

(putNonEnumerable):

  • property put with enumerable=false.

(copyMethodsToObject):

  • iterate methods in a protocol; add functions to a JSObject.

(parsePropertyAttributes):

  • examine protocol property metadata.

(makeSetterName):

  • "foo" -> "setFoo"

(copyPrototypeProperties):

  • create properties on a Protocol object reflecting the instance methods & properties of a protocol.

(-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]):
(-[JSObjCClassInfo dealloc]):
(-[JSObjCClassInfo wrapperForObject:]):
(-[JSObjCClassInfo constructor]):

  • cache the Protocol/Constructor objects for an Objective-C type.

(-[JSWrapperMap initWithContext:]):
(-[JSWrapperMap dealloc]):

  • constructor & desctructor.

(-[JSWrapperMap classInfoForClass:]):

  • maps Class -> JSObjCClassInfo.

(-[JSWrapperMap wrapperForObject:]):

  • cretae or retrieve a cached wrapper value for an object.

(tryUnwrapObjcObject):

  • check whether a value is a wrapper object; unwrap if so.
  • API/JavaScriptCore.h:
    • Added includes for new API headers.
  • API/ObjCCallbackFunction.h: Added.
    • this class is used to wrap Objective-C instance methods, class methods & blocks as JSFunction objects.
  • API/ObjCCallbackFunction.mm: Added.

(CallbackArgument):
(CallbackArgument::~CallbackArgument):
(CallbackArgumentBoolean):
(CallbackArgumentBoolean::set):
(CallbackArgumentInteger):
(CallbackArgumentInteger::set):
(CallbackArgumentDouble):
(CallbackArgumentDouble::set):
(CallbackArgumentJSValue):
(CallbackArgumentJSValue::set):
(CallbackArgumentId):
(CallbackArgumentId::set):
(CallbackArgumentOfClass):
(CallbackArgumentOfClass::CallbackArgumentOfClass):
(CallbackArgumentOfClass::~CallbackArgumentOfClass):
(CallbackArgumentOfClass::set):
(CallbackArgumentNSNumber):
(CallbackArgumentNSNumber::set):
(CallbackArgumentNSString):
(CallbackArgumentNSString::set):
(CallbackArgumentNSDate):
(CallbackArgumentNSDate::set):
(CallbackArgumentNSArray):
(CallbackArgumentNSArray::set):
(CallbackArgumentNSDictionary):
(CallbackArgumentNSDictionary::set):
(CallbackArgumentStruct):
(CallbackArgumentStruct::CallbackArgumentStruct):
(CallbackArgumentStruct::~CallbackArgumentStruct):
(CallbackArgumentStruct::set):
(CallbackArgumentBlockCallback):
(CallbackArgumentBlockCallback::CallbackArgumentBlockCallback):
(CallbackArgumentBlockCallback::~CallbackArgumentBlockCallback):
(CallbackArgumentBlockCallback::set):

  • decoded arguent type information of a ObjCCallbackFunction.

(ArgumentTypeDelegate):
(ArgumentTypeDelegate::typeInteger):
(ArgumentTypeDelegate::typeDouble):
(ArgumentTypeDelegate::typeBool):
(ArgumentTypeDelegate::typeVoid):
(ArgumentTypeDelegate::typeId):
(ArgumentTypeDelegate::typeOfClass):
(ArgumentTypeDelegate::typeBlock):
(ArgumentTypeDelegate::typeStruct):

  • delegate for use in conjunction with parseObjCType.

(CallbackResult):
(CallbackResult::~CallbackResult):
(CallbackResultVoid):
(CallbackResultVoid::get):
(CallbackResultId):
(CallbackResultId::get):
(CallbackResultNumeric):
(CallbackResultNumeric::get):
(CallbackResultBoolean):
(CallbackResultBoolean::get):
(CallbackResultStruct):
(CallbackResultStruct::CallbackResultStruct):
(CallbackResultStruct::~CallbackResultStruct):
(CallbackResultStruct::get):

  • decoded result type information of a ObjCCallbackFunction.

(ResultTypeDelegate):
(ResultTypeDelegate::typeInteger):
(ResultTypeDelegate::typeDouble):
(ResultTypeDelegate::typeBool):
(ResultTypeDelegate::typeVoid):
(ResultTypeDelegate::typeId):
(ResultTypeDelegate::typeOfClass):
(ResultTypeDelegate::typeBlock):
(ResultTypeDelegate::typeStruct):

  • delegate for use in conjunction with parseObjCType.

(ObjCCallbackFunction):
(ObjCCallbackFunction::ObjCCallbackFunction):
(ObjCCallbackFunction::~ObjCCallbackFunction):

  • constructor & destructor.

(ObjCCallbackFunction::context):

  • accessor.

(ObjCCallbackFunction::wrappedBlock):

  • attemmpt to unwrap a block object.

(objCCallbackFunctionFinalize):
(objCCallbackFunctionCallAsFunction):
(objCCallbackFunctionClass):

  • JSClassRef used to represent ObjCCallbackFunction objects.

(ObjCCallbackFunction::call):
(blockSignatureContainsClass):

  • helper function to determine if we're running on a recent Clang.

(skipNumber):

  • helper used in parsing signature strings.

(objCCallbackFunctionForInvocation):
(objCCallbackFunctionForMethod):
(objCCallbackFunctionForBlock):

  • functions to try to create ObjCCallbackFunction instances for methods/blocks.

(tryUnwrapBlock):

  • attemmpt to unwrap a block object.
  • API/ObjcRuntimeExtras.h: Added.

(protocolImplementsProtocol):
(forEachProtocolImplementingProtocol):
(forEachMethodInClass):
(forEachMethodInProtocol):
(forEachPropertyInProtocol):

  • functions used in reflecting on Objective-C types.

(skipPair):

  • parsing helper used by parseObjCType, scans for matching parentheses.

(StringRange):
(StringRange::StringRange):
(StringRange::~StringRange):
(StringRange::operator const char*):
(StringRange::get):

  • Helper class - create a c string copy of a range of an existing string.

(parseObjCType):

  • function to parse Objective-C type strings, makes callbacks to a deleagte.
  • API/tests/testapi.c:

(main):

  • added call to testObjectiveCAPI (in testapi.m).
  • API/tests/testapi.m: Added.

(+[ParentObject parentTest]):
(+[TestObject testObject]):
(+[TestObject classTest]):
(-[TestObject getString]):
(-[TestObject testArgumentTypesWithInt:double:boolean:string:number:array:dictionary:]):
(-[TestObject callback:]):
(-[TextXYZ test:]):

  • test object, used in various test vases.

(checkResult):

  • helper function.

(blockSignatureContainsClass):

  • helper function to determine if we're running on a recent Clang.

(testObjectiveCAPI):

  • new test cases.
  • JavaScriptCore.xcodeproj/project.pbxproj:
    • added new files.
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • added m_apiData - provide convenient storage for use by the API.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):

  • added m_apiData - provide convenient storage for use by the API.

../WTF:

  • wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):

  • wtf/WTFThreadData.h:

(WTFThreadData):

  • Added m_apiData - provide convenient storage for use by the API.
6:54 PM Changeset in webkit [138603] by commit-queue@webkit.org
  • 4 edits
    6 adds in trunk/Tools

sheriff-bot should know who the gardeners/sheriffs are
https://bugs.webkit.org/show_bug.cgi?id=105698

Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-01
Reviewed by Eric Seidel.

Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Current):
(Current._retrieve_webkit_sheriffs):
(Current.execute):

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_current):

  • Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
  • Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
  • Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
  • Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
  • Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
4:23 PM Changeset in webkit [138602] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK1] Skip some webaudio test cases due to lack of implementation
https://bugs.webkit.org/show_bug.cgi?id=105882

Unreviewed, EFL gardening.

Bunch of webaudio test cases need setAudioData implementation and DRT has not it.
So, skips those cases.

Patch by Kangil Han <kangil.han@samsung.com> on 2013-01-01

  • platform/efl-wk1/TestExpectations:
9:20 AM Changeset in webkit [138601] by mkwst@chromium.org
  • 4 edits
    3 adds in trunk

seamless iframes don't inherit styles when srcdoc is used
https://bugs.webkit.org/show_bug.cgi?id=103539

Reviewed by Eric Seidel.

Source/WebCore:

Seamless iframes populated via a 'srcdoc' attribute should always
inherit styles from their parent documents. At the moment, this is
only the case when they contain a stylesheet or some other markup
that forces a style recalculation on the document. Simple 'srcdoc'
attributes (e.g. "srcdoc='<p>This is a comment.</p>'") bail out of
recalculating style early, resulting in unstyled appearance.

This patch instructs WebCore to treat seamless documents as having an
updated StyleResolver regardless of what actions the parser takes,
which in turn ensures that the document's style is recalculated
correctly.

Test: fast/frames/seamless/seamless-srcdoc.html

  • dom/Document.cpp:

(WebCore::Document::finishedParsing):

If it's a seamless document, notify it that its StyleResolver isn't
what it might have expected.

LayoutTests:

  • fast/frames/seamless/resources/span.html: Added.
  • fast/frames/seamless/seamless-contenteditable-not-inherited-expected.txt:

Updating the previously FAILing expectation.

  • fast/frames/seamless/seamless-srcdoc-expected.txt: Added.
  • fast/frames/seamless/seamless-srcdoc.html: Added.

Exciting new test to ensure that this doesn't regress, neither
for totally simple srcdoc attriubtes, nor for slightly more
complex variations.

3:47 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Added web extensions, and updated target versions (diff)

Dec 31, 2012:

12:37 PM Changeset in webkit [138600] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fullscreen Media Time Indicators Background Incorrect
https://bugs.webkit.org/show_bug.cgi?id=105888

Patch by Jeff Rogers <jrogers@rim.com> on 2012-12-31
Reviewed by George Staikos.

Internal PR 272699.
Update fullscreen media controls CSS to fix time container background
color. Also fix transparency to be 80% opaque to and the time
remaining text color to match the system player.

No new tests as there is no functionality change.

  • css/mediaControlsBlackBerryFullscreen.css:

(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-time-display-container):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-timeline-container):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-current-time-display):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-time-remaining-display):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-button-container, video:-webkit-full-screen::-webkit-media-controls-play-button-container):
(video:-webkit-full-screen::-webkit-media-controls-placeholder):

11:53 AM Changeset in webkit [138599] by weinig@apple.com
  • 7 edits
    1 add in trunk/Source/WebKit2

Add supplementability for WebContext
https://bugs.webkit.org/show_bug.cgi?id=105878

Reviewed by Dan Bernstein.

Add WebContextSupplement and convert WebApplicationCacheManagerProxy to it.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetApplicationCacheManager):

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::supplementName):
(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::contextDestroyed):
(WebKit::WebApplicationCacheManagerProxy::processDidClose):
(WebKit::WebApplicationCacheManagerProxy::refWebContextSupplement):
(WebKit::WebApplicationCacheManagerProxy::derefWebContextSupplement):
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):

  • UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):

  • UIProcess/WebContext.h:

(WebKit::WebContext::supplement):
(WebKit::WebContext::addSupplement):

  • UIProcess/WebContextSupplement.h: Added.

(WebKit::WebContextSupplement::WebContextSupplement):
(WebKit::WebContextSupplement::~WebContextSupplement):
(WebKit::WebContextSupplement::ref):
(WebKit::WebContextSupplement::deref):
(WebKit::WebContextSupplement::context):
(WebKit::WebContextSupplement::clearContext):

  • WebKit2.xcodeproj/project.pbxproj:
8:56 AM Changeset in webkit [138598] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][WebGL] Add compile time support for GLES2.
https://bugs.webkit.org/show_bug.cgi?id=105816

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-31
Reviewed by Kenneth Rohde Christiansen.

.:

This patch adds build support for GLES2.
GLES2 support can be enabled during compile time by passing -DENABLE_GLES2=ON as
cmake config parameter. GLES2 options is not enabled by default. This patch doesn't
address all the build issues related to GLES2 but only adds the needed support in
OptionsEfl.cmake.

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

This patch adds build support for GLES2.
GLES2 support can be enabled during compile time by passing -DENABLE_GLES2=ON as
cmake config parameter. GLES2 options is not enabled by default. This patch doesn't
address all the build issues related to GLES2 but only adds the needed support in
PlatformEfl.cmake.

  • PlatformEfl.cmake:
8:31 AM Changeset in webkit [138597] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

[EFL[WK2] Regression(r138574): Should not allocate memory in the fork
https://bugs.webkit.org/show_bug.cgi?id=105868

Reviewed by Kenneth Rohde Christiansen.

Store prefixed executable path in a CString before the fork to
avoid allocating memory in the fork by calling String::utf8().
Allocating memory in the fork may lead to deadlocks due to
FastMalloc and the fork not inheriting the threads.

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess):

8:05 AM Changeset in webkit [138596] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] The HTML5 video fullscreen time indicator on the right cuts clipped when the video is longer than 1 hour
https://bugs.webkit.org/show_bug.cgi?id=105887

Patch by Andy Chen <andchen@rim.com> on 2012-12-31
Reviewed by George Staikos.

The width of the time part was fixed. Remove it.

No new test is required because no functionality change.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):

5:54 AM Changeset in webkit [138595] by commit-queue@webkit.org
  • 4 edits
    1 move
    1 add
    1 delete in trunk

[GTK] Move ImageDiff to the Tools directory root
https://bugs.webkit.org/show_bug.cgi?id=105421

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2012-12-31
Reviewed by Kenneth Rohde Christiansen.

.:

  • GNUmakefile.am: Remove the old ImageDiff makefile include.

Tools:

  • DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
  • GNUmakefile.am:
  • ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
5:25 AM Changeset in webkit [138594] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] css3/masking/clip-path-circle-relative-overflow.html needs expected results update after 97217
https://bugs.webkit.org/show_bug.cgi?id=105883

Unreviewed, EFL gardening.

Rebaseline css3/masking/clip-path-circle-relative-overflow.html because BUG 97217 has been resolved.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-31

  • platform/efl/TestExpectations:
  • platform/efl/css3/masking/clip-path-circle-relative-overflow-expected.png:
4:50 AM Changeset in webkit [138593] by Carlos Garcia Campos
  • 12 edits in trunk/Source/WebKit2

[GTK] Add API to set a WebKitWebView in view source mode to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=99315

Reviewed by Martin Robinson.

Add a generic API to set/get a view mode. For now there are only
two modes, Web and Source, but the API can be extended if we
eventually support other view modes like Printing for example.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetProperty): Implement setter for view-mode
property.
(webkitWebViewGetProperty): Implement getter for view-mode
property.
(webkit_web_view_class_init): Add view-source property.
(webkit_web_view_set_view_mode): Public method to set the view
mode.
(webkit_web_view_get_view_mode): Public method to get the view
mode.

  • UIProcess/API/gtk/WebKitWebView.h: Add WebKitViewMode enum.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewMode):
(beforeAll):

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::WebFrameProxy): Initialize
m_inViewSourceMode.
(WebKit::WebFrameProxy::setInViewSourceMode): Set
m_inViewSourceMode if it has changed and call
WebPageProxy::setFrameInViewSourceMode() to notify the WebProcess.

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::inViewSourceMode): Return whether the
frame is currently in view source mode.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFrameInViewSourceMode): Send a message
to the WebProcess to set the given frame in view source mode or not.

  • UIProcess/WebPageProxy.h:

(WebPageProxy): Add setFrameInViewSourceMode().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setFrameInViewSourceMode): Call
setInViewSourceMode for the main frame.

  • WebProcess/WebPage/WebPage.h:

(WebPage): Add setFrameInViewSourceMode().

  • WebProcess/WebPage/WebPage.messages.in: Add new message

SetFrameInViewSourceMode.

12:57 AM Changeset in webkit [138592] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark editing/spelling/spelling-insert-html.html as flaky
since it sometimes hits an assertion in RenderObject
destructor.

  • platform/efl/TestExpectations:
Note: See TracTimeline for information about the timeline view.