Timeline
Jan 5, 2013:
- 10:16 PM Changeset in webkit [138916] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION: [Mac] Intermittent crashes in AXObjectCache::notificationPostTimerFired
https://bugs.webkit.org/show_bug.cgi?id=106106
Reviewed by Eric Seidel.
The crash was cause by notification post timer firing after the object destruction had taken place.
Clear the timer so that this won't happen. Also make sure the document doesn't go away while we're
going through m_notificationsToPost.
No new tests since crashes have been caught by various layout tests, and we can't easily
create a deterministic layout test for this particular crash.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::notificationPostTimerFired):
- 6:59 PM Changeset in webkit [138915] by
-
- 2 edits in trunk/Source/JavaScriptCore
Data flow paths that carry non-numbers, non-undefined, non-null values should not cause subtractions and arithmetic additions (i.e. ++) to speculate double
https://bugs.webkit.org/show_bug.cgi?id=106190
Reviewed by Sam Weinig.
The problem is that the DFG logic for deciding when to speculate integer was
confusing the special case of ValueAdd (where non-numeric values should cause us
to not speculate integer, because we want to fall off into the generic case) with
the more normal case of ArithAdd and ArithSub (where we want to speculate integer
unless we have evidence that the operands are doubles, since the DFG doesn't have
generic handling of those operations). Prior to this change doing a - b where
either a or b were possibly non-numeric would always force the subtraction to be
done using doubles.
- dfg/DFGGraph.h:
(JSC::DFG::Graph::addSpeculationMode):
(Graph):
(JSC::DFG::Graph::valueAddSpeculationMode):
(JSC::DFG::Graph::arithAddSpeculationMode):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):
- 6:45 PM Changeset in webkit [138914] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Replace int64 with int64_t
https://bugs.webkit.org/show_bug.cgi?id=106189
Patch by Michael Pruett <michael@68k.org> on 2013-01-05
Reviewed by Sam Weinig.
Cleaning up coding inconsistencies, no change in behavior.
Tests: storage/indexeddb/*
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::GetOperation::create):
- 6:26 PM Changeset in webkit [138913] by
-
- 20 edits4 deletes in trunk/Source/WebKit2
Remove WebProcessInitialization and NetworkProcessInitialization by putting the rest of initialization in ChildProcess derived classes
https://bugs.webkit.org/show_bug.cgi?id=106163
Reviewed by Darin Adler.
Adds ChildProcess::initializeProcessName() and the catchall ChildProcess::initializeProcess()
as the last pieces to have all the initialization from WebProcessInitialization and NetworkProcessInitialization
captured in ChildProcess and derived classes.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeProcessName):
(WebKit::NetworkProcess::initializeSandbox):
- NetworkProcess/NetworkProcess.h:
(NetworkProcess):
- NetworkProcess/mac/NetworkProcessInitialization.h: Removed.
- NetworkProcess/mac/NetworkProcessInitialization.mm: Removed.
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::initializeProcessName):
(WebKit::NetworkProcess::initializeSandbox):
- NetworkProcess/mac/NetworkProcessMainMac.mm:
(WebKit::NetworkProcessMain):
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::initializeProcess):
- PluginProcess/PluginProcess.h:
(PluginProcess):
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::platformInitializeProcess):
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
- PluginProcess/qt/PluginProcessQt.cpp:
(WebKit::PluginProcess::platformInitializeProcess):
(WebKit::PluginProcess::platformInitializePluginProcess):
- PluginProcess/unix/PluginProcessUnix.cpp:
(WebKit::PluginProcess::platformInitializeProcess):
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::initialize):
(WebKit::ChildProcess::initializeProcess):
(WebKit::ChildProcess::initializeProcessName):
(WebKit::ChildProcess::initializeSandbox):
(WebKit::ChildProcess::initializeConnection):
- Shared/ChildProcess.h:
(ChildProcess):
- SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm:
(WebKit::SharedWorkerProcessMain):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeProcess):
(WebKit::WebProcess::initializeProcessName):
(WebKit::WebProcess::initializeSandbox):
- WebProcess/WebProcess.h:
(WebProcess):
- WebProcess/mac/WebProcessInitialization.h: Removed.
- WebProcess/mac/WebProcessInitialization.mm: Removed.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::initializeSandbox):
(WebKit::WebProcess::initializeProcessName):
(WebKit::WebProcess::platformInitializeProcess):
- WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
- WebProcess/mac/WebProcessServiceEntryPoints.mm:
(WebKit::WebProcessServiceEventHandler):
(initializeWebProcessForWebProcessServiceForWebKitDevelopment):
- 4:03 PM Changeset in webkit [138912] by
-
- 2 edits in trunk/LayoutTests
Add failing test expectations to some tile drawing tests on Mac WebKit2.
The failures are tracked by the bug 106187.
- platform/mac-wk2/TestExpectations:
- 3:55 PM Changeset in webkit [138911] by
-
- 2 edits in trunk/LayoutTests
Revert an erroneous change from r138874.
http/tests/misc/link-rel-icon-beforeload.html had been skipped prior to r138874
and it should continued to be.
- platform/mac-wk2/TestExpectations:
- 3:40 PM Changeset in webkit [138910] by
-
- 2 edits in trunk/LayoutTests
Add a flaky test expectation for the bug 106185.
- platform/mac/TestExpectations:
- 3:07 PM Changeset in webkit [138909] by
-
- 10 edits in trunk/Source/WebCore
Remove RenderObjectChildList::beforePseudoElementRenderer and afterPseudoElementRenderer
https://bugs.webkit.org/show_bug.cgi?id=106132
Reviewed by Abhishek Arya.
We no longer need the complicated traversals in beforePseudoElementRenderer
and afterPseudoElementRenderer since we can get the renderers of pseudo
elements through the node. This removes all that code and swaps it for
Element::pseudoElementRenderer.
This is possible now that r138850 removed all the now incorrect manual
management of pseudo element renderers from the render tree that was
left over from before the switch to DOM based pseudo elements.
No new tests, just refactoring.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- dom/Element.cpp:
(WebCore::Element::pseudoElementRenderer):
Added, gets the renderer of the pseudo element by PseudoId if it
exists.
- dom/Element.h:
(Element):
- dom/NodeRenderingTraversal.cpp:
(WebCore::NodeRenderingTraversal::nextSiblingSlow):
(WebCore::NodeRenderingTraversal::previousSiblingSlow):
- rendering/RenderCounter.cpp:
(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::nextInPreOrder):
- rendering/RenderObject.h:
(WebCore::RenderObject::lastChild):
- rendering/RenderObjectChildList.cpp:
- rendering/RenderObjectChildList.h:
(RenderObjectChildList):
- rendering/RenderTreeAsText.cpp:
(WebCore::counterValueForElement):
- 1:23 PM Changeset in webkit [138908] by
-
- 3 edits2 adds in trunk
Heap-use-after-free in WebCore::RenderBlock::insertIntoTrackedRendererMaps
https://bugs.webkit.org/show_bug.cgi?id=105654
Reviewed by Simon Fraser.
Source/WebCore:
As with position:relative, position:sticky does not apply to table sections.
Test: fast/block/sticky-position-containing-block-crash.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
LayoutTests:
- fast/block/sticky-position-containing-block-crash-expected.txt: Added.
- fast/block/sticky-position-containing-block-crash.html: Added.
- 1:20 PM Changeset in webkit [138907] by
-
- 7 edits1 add in trunk/LayoutTests
Deflaking http/tests/security/contentSecurityPolicy/report-uri-from-javascript.html
https://bugs.webkit.org/show_bug.cgi?id=106165
Reviewed by Adam Barth.
The original test chose its violation mechanism poorly. The existing injection file
injected two violations, which generated reports delivered in a random order. This
patch creates a new injection JavaScript file that injects a single image, generating
a single report. That should deflake the test.
- http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-javascript.html:
- http/tests/security/contentSecurityPolicy/resources/inject-image.js:
Adjusting the test to be deterministic.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
Unskipping test.
- 1:07 PM Changeset in webkit [138906] by
-
- 4 edits in trunk/Source/WebCore
Cleanup: mayDisplaySeamlessWithParent -> mayDisplaySeamless_ly_WithParent
https://bugs.webkit.org/show_bug.cgi?id=106169
Reviewed by Eric Seidel.
This patch renames SecurityContext's 'm_mayDisplaySeamlessWithParent' to
'm_mayDisplaySeamlesslyWithParent'. Because adverbs matter.
- dom/Document.cpp:
(WebCore::Document::initSecurityContext):
(WebCore::Document::shouldDisplaySeamlesslyWithParent):
- dom/SecurityContext.cpp:
(WebCore::SecurityContext::SecurityContext):
- dom/SecurityContext.h:
(SecurityContext):
- 1:02 PM Changeset in webkit [138905] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] SelectionHandler::selectAtPoint should use last fat finger result when it is a link
https://bugs.webkit.org/show_bug.cgi?id=106141
Patch by Andy Chen <andchen@rim.com> on 2013-01-05
Reviewed by Rob Buis.
If last fat finger result is a link, select it directly when
SelectionHandler::selectAtPoint is called.
PR 263449
Internally reviewed by Mike Fenton and Yongxin Dai.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectNodeIfFatFingersResultIsLink):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
- WebKitSupport/SelectionHandler.h:
(WebKit):
(SelectionHandler):
- 12:50 PM Changeset in webkit [138904] by
-
- 3 edits2 adds in trunk
seamless iframes don't take border into account properly and make the iframe too small.
https://bugs.webkit.org/show_bug.cgi?id=90827
Reviewed by Ojan Vafai.
Source/WebCore:
Seamless IFrames were incorrectly calculating their width; borders and
padding of the child document were accidentally left out of the end
result. This tiny patch adds the border/padding width to the calculated
width for the seamless IFrame, bringing things back into line with
expectations.
Test: fast/frames/seamless/seamless-border-padding.html
- rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::minPreferredLogicalWidth):
(WebCore::RenderIFrame::maxPreferredLogicalWidth):
Add borderAndPaddingLogicalWidth() to the result of both methods.
LayoutTests:
- fast/frames/seamless/seamless-border-padding-expected.txt: Added.
- fast/frames/seamless/seamless-border-padding.html: Added.
This test checks the IFrame's handling of borders and padding.
Things work correctly for width after this patch, but there are
still issues with padding and height, which will be fixed in
http://wkbug.com/106167
- 12:50 PM Changeset in webkit [138903] by
-
- 2 edits in trunk/Source/WTF
Only enable MinGW-w64 pow() workaround if needed
https://bugs.webkit.org/show_bug.cgi?id=106099
Patch by Jonathan Liu <net147@gmail.com> on 2013-01-05
Reviewed by Filip Pizlo.
The pow() workaround is no longer needed in the latest version
of MinGW-w64.
- wtf/MathExtras.h:
- 12:49 PM Changeset in webkit [138902] by
-
- 3 edits2 adds in trunk
MediaControls::show() should make controls opaque
https://bugs.webkit.org/show_bug.cgi?id=106034
Patch by Min Qin <qinmin@chromium.org> on 2013-01-05
Reviewed by Eric Carlson.
Source/WebCore:
When a video enters fullscreen, webkit starts a timer to make the control transparent when the timer expires.
If the user exits fullscreen while the timer expires, webkit will call mediaControls::show().
However, show() actually displays nothing as the control is transparent.
The user had to move his mouse outside the video rect and move it back in order to show the controls.
Simply clicking/moving the mouse inside the video rect will not make the control opaque.
Test: media/video-controls-visible-exiting-fullscreen.html
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::show):
LayoutTests:
Add tests to check that video controls are shown when exiting from fullscreen.
- media/video-controls-visible-exiting-fullscreen-expected.txt: Added.
- media/video-controls-visible-exiting-fullscreen.html: Added.
- 12:44 PM Changeset in webkit [138901] by
-
- 2 edits in trunk/LayoutTests
[WK2] Exclude IndexedDB tests which use eventSender.beginDragWithFiles()
https://bugs.webkit.org/show_bug.cgi?id=106138
Patch by Michael Pruett <michael@68k.org> on 2013-01-05
Reviewed by Alexey Proskuryakov.
- platform/wk2/TestExpectations:
- 12:42 PM Changeset in webkit [138900] by
-
- 24 edits in trunk
IndexedDB: Migrate backend ObjectStore calls to use transaction id
https://bugs.webkit.org/show_bug.cgi?id=102741
Reviewed by Tony Chang.
Source/WebCore:
Fully migrate 8 core data calls (get, put, setIndexKeys, setIndexesReady,
openCursor, count, deleteRange, and clear) into IDBDatabaseBackendImpl,
combining common code from IDBObjectStoreBackendImpl and IDBIndexBackendImpl
in order to simplify the backend interface. These calls are now
implemented in terms of an int64_t-based transactionId rather than
an IDBTransactionBackendInterface, which simplifies the ownership model
between the frontend and the backend.
In addition, remove references to IDBObjectStoreBackend* from IDBIndex,
as it is no longer needed.
A few duplicate IDB_TRACE methods have been removed from wrapper methods
that call another method that already have IDB_TRACE's.
Finally, IDBCursorBackendImpl now no longer holds onto an
IDBObjectStoreBackendImpl*, so its destruction and member variables are
simplified, and reordered to match proper destruction order.
- Modules/indexeddb/IDBCursorBackendImpl.cpp: Reordered to account for proper destruction.
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::deleteFunction):
- Modules/indexeddb/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
(IDBCursorBackendImpl):
- Modules/indexeddb/IDBDatabase.h:
(WebCore::IDBDatabase::backend):
(IDBDatabase):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(GetOperation): Combined from IDBObjectStoreBackendImpl/IDBIndexBackendImpl::*RetrievalOperation
(WebCore::GetOperation::create):
(WebCore::GetOperation::GetOperation):
(WebCore):
(PutOperation): Combined from IDBObjectStoreBackendImpl/IDBIndexBackendImpl::*StorageOperation.
(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):
(SetIndexesReadyOperation): Moved from IDBObjectStoreBackendImpl::IndexesReadyOperation
(WebCore::SetIndexesReadyOperation::create):
(WebCore::SetIndexesReadyOperation::SetIndexesReadyOperation):
(OpenCursorOperation): Combined from IDBObjectStoreBackendImpl/IDBIndexBackendImpl::Open*CursorOperation
(WebCore::OpenCursorOperation::create):
(WebCore::OpenCursorOperation::OpenCursorOperation):
(CountOperation): Combined from IDBObjectStoreBackendImpl/IDBIndexBackendImpl::CountOperation
(WebCore::CountOperation::create):
(WebCore::CountOperation::CountOperation):
(DeleteRangeOperation): Moved from IDBObjectStoreBackendImpl::DeleteOperation
(WebCore::DeleteRangeOperation::create):
(WebCore::DeleteRangeOperation::DeleteRangeOperation):
(ClearOperation): Moved from IDBObjectStoreBackendImpl::ClearOperation
(WebCore::ClearOperation::create):
(WebCore::ClearOperation::ClearOperation):
(WebCore::IDBDatabaseBackendImpl::get): Combined from IDBObjectStoreBackendImpl/IDBIndexBackendImpl::get*
(WebCore::GetOperation::perform):
(WebCore::IDBDatabaseBackendImpl::put): Moved from IDBObjectStoreBackendImpl::put
(WebCore::PutOperation::perform):
(WebCore::IDBDatabaseBackendImpl::setIndexKeys): Moved from IDBObjectStoreBackendImpl::setIndexKeys
(WebCore::IDBDatabaseBackendImpl::setIndexesReady):
(WebCore::SetIndexesReadyOperation::perform):
(WebCore::IDBDatabaseBackendImpl::openCursor):
(WebCore::IDBDatabaseBackendImpl::count):
(WebCore::CountOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteRange):
(WebCore::DeleteRangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::clear):
(WebCore::ClearOperation::perform):
(WebCore::OpenCursorOperation::perform):
- Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::IDBIndex):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
(WebCore::IDBIndex::backendDB):
(WebCore):
- Modules/indexeddb/IDBIndex.h:
(WebCore::IDBIndex::create):
(IDBIndex):
- Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
- Modules/indexeddb/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::create):
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
(IDBIndexBackendImpl):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):
(WebCore::IDBObjectStore::backendDB):
- Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::id):
(IDBObjectStore):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::generateKey):
(WebCore::IDBObjectStoreBackendImpl::updateKeyGenerator):
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::count):
(IDBObjectStoreBackendImpl):
- Modules/indexeddb/IDBTransactionBackendImpl.h:
(WebCore::IDBTransactionBackendImpl::database):
(IDBTransactionBackendImpl):
Source/WebKit/chromium:
Fix a bug where an array was initialized with a large empty buffer,
clean up whitespace, and update to match signatures that changed
in WebCore.
- public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::clear):
- src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::put):
- src/WebIDBIndexImpl.cpp:
- tests/IDBDatabaseBackendTest.cpp:
LayoutTests:
Add additional count() tests for multi-entry indexes, not previously
covered.
- storage/indexeddb/index-multientry-expected.txt:
- storage/indexeddb/resources/index-multientry.js:
(.transaction.oncomplete):
(verifyCount.request.onsuccess.request.onsuccess):
(verifyCount.request.onsuccess):
(verifyCount):
- 12:26 PM Changeset in webkit [138899] by
-
- 3 edits2 adds in trunk
Max width of a floated container with floated children calculated incorrectly
https://bugs.webkit.org/show_bug.cgi?id=47975
Source/WebCore:
Accumulate the width of child floats in the correct counter so that it gets reset
as expected when a subsequent sibling decides to clear it.
Reviewed by Levi Weintraub.
Test: fast/block/float/max-width-clear-float-with-overflow-hidden.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
LayoutTests:
Reviewed by Levi Weintraub.
- fast/block/float/max-width-clear-float-with-overflow-hidden-expected.html: Added.
- fast/block/float/max-width-clear-float-with-overflow-hidden.html: Added.
- 12:22 PM Changeset in webkit [138898] by
-
- 10 edits in trunk/Source
IndexedDB: Stub out IDBDatabaseBackendInterface::createIndex/deleteIndex
https://bugs.webkit.org/show_bug.cgi?id=106117
Reviewed by Adam Barth.
Source/WebCore:
No new tests, these are just stubs for refactoring.
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(WebCore::IDBDatabaseBackendImpl::createIndex):
(WebCore::IDBDatabaseBackendImpl::deleteIndex):
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
Source/WebKit/chromium:
Stubs for migration from WebIDBObjectStore.
- public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::createIndex):
(WebKit::WebIDBDatabase::deleteIndex):
(WebIDBDatabase):
- src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::createIndex):
(WebKit):
(WebKit::IDBDatabaseBackendProxy::deleteIndex):
- src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
- src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::createIndex):
(WebKit):
(WebKit::WebIDBDatabaseImpl::deleteIndex):
- src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
- tests/IDBDatabaseBackendTest.cpp:
- 12:11 PM Changeset in webkit [138897] by
-
- 4 edits2 adds in trunk
[Shadow DOM]: Some named elements in ShadowTree visible on nesting document level
https://bugs.webkit.org/show_bug.cgi?id=105617
Reviewed by Dimitri Glazkov.
Source/WebCore:
According to the shadow dom spec, the nodes and named elements are not
accessible using shadow host's document DOM tree accessors or with
Window object named properties. c.f.
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#upper-boundary-encapsulation
Test: fast/dom/shadow/element-name-in-shadow.html
- dom/Element.h:
(WebCore::Element::updateName):
Check whether the given element is in a shadow dom tree or not. If in
a shadow dom tree, don't register the name.
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::insertedInto):
(WebCore::HTMLIFrameElement::removedFrom):
(WebCore::HTMLIFrameElement::parseAttribute):
HTMLIFrameElement doesn't use updateName. Instead the element uses
addExtraNamedItem and removeExtraNameItem in HTMLIFrameElement.cpp.
LayoutTests:
- fast/dom/shadow/element-name-in-shadow-expected.txt: Added.
- fast/dom/shadow/element-name-in-shadow.html: Added.
- 12:05 PM Changeset in webkit [138896] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening
Skipping http/tests/multipart/multipart-wait-before-boundary.html for now,
the test is intermittently timing out on release builders despite being assigned
a SLOW expectation, thus unnecessarily painting bots red. A bug identifier is also
added for this test.
- platform/gtk/TestExpectations:
- 12:04 PM Changeset in webkit [138895] by
-
- 9 edits in trunk
Implement MediaStreamSource::setAudioFormat()
https://bugs.webkit.org/show_bug.cgi?id=106053
Reviewed by Kenneth Russell.
Source/Platform:
- chromium/public/WebAudioDestinationConsumer.h:
(WebAudioDestinationConsumer):
Source/WebCore:
MediaStreamAudioDestinationNode needs to be able to tell its associated
MediaStreamSource about the audio format (number of channels and sample-rate).
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
- platform/audio/AudioDestinationConsumer.h:
(AudioDestinationConsumer):
- platform/chromium/support/WebMediaStreamSource.cpp:
(ConsumerWrapper):
(WebKit::ConsumerWrapper::setFormat):
(WebKit):
- platform/mediastream/MediaStreamSource.cpp:
(WebCore::MediaStreamSource::setAudioFormat):
(WebCore):
- platform/mediastream/MediaStreamSource.h:
(MediaStreamSource):
- 12:02 PM Changeset in webkit [138894] by
-
- 2 edits in trunk/Source/WTF
Fix compilation of MathExtras.h with MinGW-w64
https://bugs.webkit.org/show_bug.cgi?id=106105
Patch by Jonathan Liu <net147@gmail.com> on 2013-01-05
Reviewed by Simon Hausmann.
The isfinite and isinf functions are required by wtf_pow but
not defined until after wtf_pow. Move wtf_pow to after
"using std::isfinite" and "using std::isinf" to fix compilation.
- wtf/MathExtras.h:
(wtf_pow):
- 12:01 PM Changeset in webkit [138893] by
-
- 4 edits in trunk/Source/WebKit/chromium
Add function to move caret selection towards a point
https://bugs.webkit.org/show_bug.cgi?id=105189
Patch by Chris Hopman <cjhopman@google.com> on 2013-01-05
Reviewed by Eric Seidel.
This function moves the selection to the corresponding point in the
rootEditableElement of the current selection. Used on Android for
the behavior of insertion handles (i.e. dragging the caret around).
- public/WebFrame.h:
(WebFrame):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
(WebKit):
- src/WebFrameImpl.h:
(WebFrameImpl):
- 7:15 AM Changeset in webkit [138892] by
-
- 7 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline several tests after r138838.
- platform/efl/fast/ruby/base-shorter-than-text-expected.png:
- platform/efl/fast/ruby/base-shorter-than-text-expected.txt:
- platform/efl/fast/table/038-vertical-expected.png:
- platform/efl/fast/table/038-vertical-expected.txt:
- platform/efl/fast/table/border-collapsing/004-vertical-expected.png:
- platform/efl/fast/table/border-collapsing/004-vertical-expected.txt:
- 5:52 AM Changeset in webkit [138891] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] TextureMapperGL should reset ARRAY_BUFFER after painting.
https://bugs.webkit.org/show_bug.cgi?id=106098
This fixes the issue of the address bar disappearing in
Qt/MiniBrowser after r138555.
Reviewed by Jocelyn Turcotte.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawEdgeTriangles):
(WebCore::TextureMapperGL::drawUnitRect):
- 1:24 AM AddingFeatures edited by
- Adjust the name of the file containing feature defines for the … (diff)
- 1:04 AM Changeset in webkit [138890] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG should trust array profiling over value profiling
https://bugs.webkit.org/show_bug.cgi?id=106155
Reviewed by Gavin Barraclough.
The real problem is that prediction propagation is not flow-sensitive. We had code
like:
var a = (some load from memory); returns either an array or false
if (a)
a[i] = v;
Because 'a' could be 'false', we were emitting a fully generic unoptimized PutByVal.
This patch changes ArrayMode to ignore the type of the base of an array access, if
array profiling tells us that the array access can be optimized.
In the future, we could probably make this work even better with some flow
sensitivity in the prediction propagator, but I also tend to think that this is a
more robust overall solution. If we ever did want to support array accesses on
array-or-false then we should change the array profiler to be able to tell us that
this is what is going on.
3.7% speed-up on V8/earley.
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
- 12:28 AM Changeset in webkit [138889] by
-
- 1 edit1 delete in trunk/Tools
Add svn:executable to a bunch of scripts in BuildSlaveSupport.
Also removed the empty mac directory.
- BuildSlaveSupport/built-product-archive: Added property svn:executable.
- BuildSlaveSupport/download-built-product: Added property svn:executable.
- BuildSlaveSupport/mac: Removed.
- BuildSlaveSupport/test-result-archive: Added property svn:executable.
- 12:20 AM Changeset in webkit [138888] by
-
- 2 edits1 add in trunk/Tools
Add a script to delete stale zero-byte build files
https://bugs.webkit.org/show_bug.cgi?id=106131
Reviewed by Tony Chang.
Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(DeleteStaleBuildFiles): Added.
(Factory.init): Add DeleteStaleBuildFiles step.
- BuildSlaveSupport/delete-stale-build-files: Added.
(main): Delete zero-byte files except ones intentionally generated by our build process.
(webkitBuildDirectory): Copied from build-product-archive.
Jan 4, 2013:
- 11:36 PM Changeset in webkit [138887] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectations for two CSS Regions tests added in r138854.
Modifying a failure expectation for a CSS Image Set test that now times out after r138857.
- platform/gtk/TestExpectations:
- 7:58 PM Changeset in webkit [138886] by
-
- 2 edits in trunk/LayoutTests
Remove a duplicate test expectation since the bug 106153 has been merged into the bug 106165.
- platform/chromium/TestExpectations:
- 7:55 PM Changeset in webkit [138885] by
-
- 5 edits in trunk/LayoutTests
Add a flaky failure expectation to a test added by r138834.
The failure is tracked by the bug 106165.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 7:53 PM Changeset in webkit [138884] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. fast/ruby/base-shorter-than-text.html is failing on
Lion and MountainLion.
- platform/chromium/TestExpectations:
- 7:50 PM Changeset in webkit [138883] by
-
- 2 edits in trunk/Source/WebKit2
Fix failing API test.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
(WebKit::WebProcess::initializeWebProcess):
The WebConnectionToUIProcess needs to be initialized before the injected bundle is,
so that if the user tries to use it, its there.
- 7:20 PM Changeset in webkit [138882] by
-
- 2 edits in trunk/Tools
[GTK] Fix build error on GTK due to r138836
https://bugs.webkit.org/show_bug.cgi?id=106154
Patch by Michael Pruett <michael@68k.org> on 2013-01-04
Reviewed by Kentaro Hara.
- GNUmakefile.am:
- 6:51 PM Changeset in webkit [138881] by
-
- 11 edits2 copies in trunk/Source/WebKit2
Consolidate all the one time initialization functions into a single InitializeWebKit2() super function
https://bugs.webkit.org/show_bug.cgi?id=106161
Reviewed by Simon Fraser.
Adds InitializeWebKit2 and uses it.
- CMakeLists.txt:
- GNUmakefile.list.am:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
- NetworkProcess/mac/NetworkProcessInitialization.mm:
(WebKit::initializeNetworkProcess):
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
- Shared/WebKit2Initialize.cpp: Copied from Source/WebKit2/NetworkProcess/mac/NetworkProcessInitialization.mm.
(WebKit::InitializeWebKit2):
- Shared/WebKit2Initialize.h: Copied from Source/WebKit2/NetworkProcess/mac/NetworkProcessInitialization.mm.
(WebKit):
- SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm:
(WebKit::SharedWorkerProcessMain):
- Target.pri:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/mac/WebProcessInitialization.mm:
(WebKit::initializeWebProcess):
- 6:08 PM Changeset in webkit [138880] by
-
- 2 edits in tags/Safari-537.24.1/Source/WebCore
Merged r138877.
- 6:05 PM Changeset in webkit [138879] by
-
- 3 edits in trunk/Source/WebCore
Chromium windows compile fails because of the assertion in NodeRareData
https://bugs.webkit.org/show_bug.cgi?id=106149
Reviewed by Andreas Kling.
MSVC adds padding between bitfields of different types for better alignment.
Since we care more about the memory usage, use unsigned for all bitfields to work around this behavior.
- dom/NodeRareData.cpp:
(SameSizeAsNodeRareData):
(WebCore):
- dom/NodeRareData.h:
(WebCore::NodeRareData::isWebVTTNode):
(WebCore::NodeRareData::isWebVTTFutureNode):
(NodeRareData):
- 5:59 PM Changeset in webkit [138878] by
-
- 2 edits in trunk/Source/WebCore
Updated the exports file.
Rubber-stamped by Andy Estes.
- WebCore.exp.in: Moved the DOMHTMLTableCellElement export out of the !PLATFORM(IOS) section.
- 5:54 PM Changeset in webkit [138877] by
-
- 2 edits in trunk/Source/WebCore
Update margin for label to 0
https://bugs.webkit.org/show_bug.cgi?id=106152
<rdar://problem/12961387>
Reviewed by Brian Weinstein.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore): Change the margin constant from 10 to 0.
- 5:53 PM Changeset in webkit [138876] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Test is flaky on Linux and Mac.
- platform/chromium/TestExpectations:
- 5:47 PM Changeset in webkit [138875] by
-
- 6 edits in trunk/Source/WebKit2
Follow up to https://bugs.webkit.org/show_bug.cgi?id=106144, fixing some
of Alexey's review comments.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::downloadProxyConnection):
(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::createWebProcessConnection):
(WebKit::PluginProcess::getSitesWithData):
(WebKit::PluginProcess::clearSiteData):
- Shared/ChildProcess.h:
(WebKit::ChildProcess::parentProcessConnection):
- SharedWorkerProcess/SharedWorkerProcess.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::downloadProxyConnection):
(WebKit::WebProcess::addVisitedLink):
(WebKit::WebProcess::removeWebFrame):
(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):
(WebKit::WebProcess::addPlugInAutoStartOrigin):
(WebKit::WebProcess::plugInDidReceiveUserInteraction):
(WebKit::WebProcess::getWebCoreStatistics):
- 5:38 PM Changeset in webkit [138874] by
-
- 3 edits in trunk/LayoutTests
Add a Mac test expectation for the test that has been intermittently failing on Mac Lion WebKit1.
The failure is tracked by the bug 106151.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 5:31 PM Changeset in webkit [138873] by
-
- 4 edits in tags/Safari-537.24.1/Source
Versioning.
- 5:29 PM Changeset in webkit [138872] by
-
- 1 copy in tags/Safari-537.24.1
New Tag.
- 5:28 PM Changeset in webkit [138871] by
-
- 8 edits in trunk/Source/JavaScriptCore
Rationalize exit site profiling for calls
https://bugs.webkit.org/show_bug.cgi?id=106150
Reviewed by Sam Weinig.
This adds two new exit kinds for calls: BadFunction and BadExecutable. The latter is not used
yet, but is already integrated with profiling. CheckFunction uses a BadFunction speculation
instead of BadCache, now. This allows CallLinkStatus to turn itself into a closure call status
if we had a BadFunction exit site but the CallLinkInfo told us to use a non-closure call. This
might happen if we had call unlinking that led to information loss along the way.
No performance impact. This is meant as another step towards inlining closure calls.
- bytecode/CallLinkStatus.cpp:
- bytecode/CallLinkStatus.h:
(JSC::CallLinkStatus::setIsProved):
(JSC::CallLinkStatus::setHasBadFunctionExitSite):
(CallLinkStatus):
(JSC::CallLinkStatus::setHasBadCacheExitSite):
(JSC::CallLinkStatus::setHasBadExecutableExitSite):
- bytecode/ExitKind.cpp:
(JSC::exitKindToString):
- bytecode/ExitKind.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 5:26 PM Changeset in webkit [138870] by
-
- 1 edit1 move4 deletes in trunk/LayoutTests
Remove superfluous chromium test baselines for the test added by r138862 after r138869.
- platform/chromium-linux-x86/fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt: Removed.
- platform/chromium-linux/fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt: Removed.
- platform/chromium-mac-lion/fast/js: Removed.
- platform/chromium-mac-lion/fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt: Removed.
- platform/chromium-mac/fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt: Removed.
- platform/chromium/fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt: Copied from LayoutTests/platform/chromium-linux-x86/fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt.
- 5:21 PM Changeset in webkit [138869] by
-
- 1 edit6 adds in trunk/LayoutTests
Unreviewed gardening. Adding new baselines for chromium.
- platform/chromium-linux-x86/fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt: Added.
- platform/chromium-linux/fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt: Added.
- platform/chromium-mac-lion/fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt: Added.
- platform/chromium-mac/fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt: Added.
- 5:19 PM Changeset in webkit [138868] by
-
- 31 edits in trunk/Source/WebKit2
Consolidate process initialization in ChildProcess
https://bugs.webkit.org/show_bug.cgi?id=106144
Reviewed by Alexey Proskuryakov.
Consolidate more functionality down into ChildProcess.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didReceiveMessage):
(WebKit::NetworkProcess::didReceiveSyncMessage):
(WebKit::NetworkProcess::downloadProxyConnection):
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
(WebKit::NetworkProcess::initializeSandbox):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/mac/NetworkProcessInitialization.h:
- NetworkProcess/mac/NetworkProcessInitialization.mm:
(WebKit::initializeNetworkProcess):
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
- NetworkProcess/mac/NetworkProcessMainMac.mm:
(WebKit::NetworkProcessMain):
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::PluginProcess):
(WebKit::PluginProcess::initializePluginProcess):
(WebKit::PluginProcess::createWebProcessConnection):
(WebKit::PluginProcess::getSitesWithData):
(WebKit::PluginProcess::clearSiteData):
- PluginProcess/PluginProcess.h:
(PluginProcess):
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::initializeShim):
(WebKit::initializeCocoaOverrides):
(WebKit::PluginProcess::platformInitialize):
(WebKit::PluginProcess::platformInitializePluginProcess):
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
- PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::PluginProcessMain):
- PluginProcess/qt/PluginProcessQt.cpp:
(WebKit::PluginProcess::platformInitializePluginProcess):
- PluginProcess/unix/PluginProcessMainUnix.cpp:
(WebKit::PluginProcessMainUnix):
- PluginProcess/unix/PluginProcessUnix.cpp:
(WebKit::PluginProcess::platformInitializePluginProcess):
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::ChildProcess):
(WebKit::watchdogCallback):
(WebKit::didCloseOnConnectionWorkQueue):
(WebKit::ChildProcess::initialize):
(WebKit::ChildProcess::initializeConnection):
(WebKit::ChildProcess::initializeSandbox):
(WebKit::ChildProcess::terminate):
- Shared/ChildProcess.h:
(ChildProcessInitializationParameters):
(ChildProcess):
(WebKit::ChildProcess::connection):
(WebKit::ChildProcess::destinationID):
(WebKit::ChildProcess::messageReceiverMap):
- SharedWorkerProcess/SharedWorkerProcess.cpp:
(WebKit::SharedWorkerProcess::initializeSharedWorkerProcess):
- SharedWorkerProcess/SharedWorkerProcess.h:
(SharedWorkerProcess):
- SharedWorkerProcess/mac/SharedWorkerProcessMac.mm:
(WebKit::SharedWorkerProcess::platformInitializeSharedWorkerProcess):
- SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm:
(WebKit::SharedWorkerProcessMain):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
(WebKit::WebProcess::downloadProxyConnection):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::terminate):
(WebKit::WebProcess::didReceiveSyncMessage):
(WebKit::WebProcess::didReceiveMessage):
(WebKit::WebProcess::removeWebFrame):
(WebKit::WebProcess::initializeSandbox):
- WebProcess/WebProcess.h:
- WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):
- WebProcess/mac/WebProcessInitialization.h:
- WebProcess/mac/WebProcessInitialization.mm:
(WebKit::initializeWebProcess):
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitialize):
- WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
- WebProcess/mac/WebProcessServiceEntryPoints.mm:
(WebKit::WebProcessServiceEventHandler):
(initializeWebProcessForWebProcessServiceForWebKitDevelopment):
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
- 4:55 PM Changeset in webkit [138867] by
-
- 2 edits in trunk/LayoutTests
Unreviewed cleanup. Remove media/track/ from Mac TestExpectations because
https://bugs.webkit.org/show_bug.cgi?id=105606 was fixed.
- platform/mac/TestExpectations:
- 4:34 PM Changeset in webkit [138866] by
-
- 3 edits in trunk/Source/WebCore
Optimize TransformationMatrix::multiply() for x86_64
https://bugs.webkit.org/show_bug.cgi?id=105719
Reviewed by Sam Weinig.
On x86_64, we have access to 16 XMM registers. This can hold 32 double values.
We can use that in two ways to optimize matrix multiplications:
-Keep the source matrix completely in registers. Write the result directly in
the source matrix's memory. This avoids the memcpy at the end of the multiplication
and various memory operations.
-Use SIMD with SSE to perform 2 operations at a time.
The parameter from the second matrix are loaded one by one in XMM registers.
Loading them with SSE then shuffling the values perform worse than loading
one by one.
This is only enabled on 64bits as x86 only has access to 8 XMM registers and
the function should be written differently.
On a i5, TransformationMatrix::multiply() perform about 3 times faster with the change.
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::multiply):
- platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix): Fix an incorrect comment. Unify the comment with the cpp file.
- 4:18 PM Changeset in webkit [138865] by
-
- 2 edits in trunk/Source/WebKit/win
Make private browsing work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=106032.
Reviewed by Alexey Proskuryakov.
Code path never called ensurePrivateBrowsingSession which is what starts up the private browsing session.
This was causing many tests to involving private browsing to fail.
- WebView.cpp:
(WebView::notifyPreferencesChanged):
- 3:57 PM Changeset in webkit [138864] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix Apple Win build following http://trac.webkit.org/changeset/138838
https://bugs.webkit.org/show_bug.cgi?id=105927
- WebCore.vcproj/WebCoreTestSupport.vcproj:
- 3:47 PM Changeset in webkit [138863] by
-
- 5 edits in trunk/Source/WebCore
Heap-use-after-free in WebCore::XMLDocumentParser::doEnd
https://bugs.webkit.org/show_bug.cgi?id=100152
Reviewed by Adam Barth.
XMLDocumentParser can be blown away inside document()->styleResolverChanged()
call. Protect it with a local RefPtr in Document::explitClose.
No new tests. The site specific dependencies are hard to minimize.
- dom/Document.cpp:
(WebCore::Document::explicitClose): RefPtr m_parser into a local, since
it can be detached and nulled out in DocumentWriter::end().
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::end): Bail out when we are detached.
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doEnd): Bail out when we are detached.
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::doEnd): Bail out when we are detached.
- 3:40 PM Changeset in webkit [138862] by
-
- 4 edits3 adds in trunk
DFG should not elide CheckStructure if it's needed to perform a cell check
https://bugs.webkit.org/show_bug.cgi?id=106074
Source/JavaScriptCore:
Reviewed by Ryosuke Niwa.
The problem here was that the constant folding phase was misinterpreting the meaning of the sets
in DFG::AbstractValue. AbstractValue describes a constraint on the values that a variable (i.e.
a DFG Node, or a virtual register, i.e. local or argument) may have. It does so by containing
four sets: the set of JSValues (either empty, the singleton set containing one JSValue, or the
set of all JSValues); the set of "current known" structures, i.e. the set of structures that you
already know that this value may have right now (also either empty, the singleton set, or the set
of all structures); the set of "future possible" structures, i.e. the set of structures that this
value could have in the future if none of the structure transition watchpoints for those
structures had fired (also empty, singleton, or all); and the set of types, which is a
SpeculatedType bitmask. The correct way to interpret the sets is to think of the AbstractValue as
the intersection of these three sets of values:
- The set of JSValues that have a type that belongs to the m_type set.
- If m_value is not the empty value then: the set of all JSValues that are == m_value;
else: the set of all JSValues.
where '==' is as defined by JSValue::operator==.
- Union of { the set of all cells that have a structure that belongs to m_currentKnownStructure }
and { the set of all JSValues that are not cells }.
You can then further intersect this set with the following set, if you guard the code with
watchpoints on all structures in the m_futurePossibleStructure:
- Union of { the set of all cells that have a structure that belongs to m_futurePossibleStructure }
and { the set of all JSValues that are not cells }.
One way to think of this is that m_currentKnownStructure is filtered by m_futurePossibleStructure
(i.e. is set to the intersection of m_currentKnownStructure and m_futurePossibleStructure), if the
code for which you're doing this is always preceded by watchpoints on all structures in
m_futurePossibleStructure, and is always before any side-effects that could change the structures
of objects.
The incorrect optimization related to CheckStructure. CheckStructure checks that the value is a
cell, and that it has a particular structure. It was incorrectly assuming that you could eliminate
the CheckStructure, if m_currentKnownStructure contained the structure that CheckStructure was
checking. But this is not the case, since m_currentKnownStructure does not prove that the value is
a cell with a particular structure; it only proves that if the value was a cell then it would have
a particular structure. Hence, to eliminate CheckStructure, it is also necessary to check that
AbstractValue::m_type contains only cells (i.e. isCellSpeculation(m_type) == true).
It wasn't doing that, and this changes makes sure that it does do that.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
LayoutTests:
Reviewed by Ryosuke Niwa.
- fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt: Added.
- fast/js/dfg-check-structure-elimination-for-non-cell.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-check-structure-elimination-for-non-cell.js: Added.
(foo):
(bar):
(baz):
- 3:39 PM Changeset in webkit [138861] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Temporarily skipping three tests
in webaudio/codec-tests/vorbis because they need a
special rebaseline.
- platform/chromium/TestExpectations:
- 3:36 PM Changeset in webkit [138860] by
-
- 5 edits in trunk
REGRESSION(r138394): platform/mac/accessibility/file-upload-button-subrole.html is failing
https://bugs.webkit.org/show_bug.cgi?id=105778
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Rename "file upload" to "file upload button".
- English.lproj/Localizable.strings:
- platform/LocalizedStrings.cpp:
LayoutTests:
Removed the old test expectations.
- platform/mac/TestExpectations:
- 3:21 PM Changeset in webkit [138859] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Remove WebWidget::layerTreeView(), ownership is the other way around
https://bugs.webkit.org/show_bug.cgi?id=106139
Reviewed by Adrienne Walker.
This was added with the thought that it would be useful for transitioning code for a world where the
WebLayerTreeView for a given widget was owned by the WebWidgetClient instead of the WebWidget, but as it turns
out we've transitioned without every adding any callers to this.
- public/WebWidget.h:
(WebWidget):
- src/WebViewImpl.cpp:
- 3:15 PM Changeset in webkit [138858] by
-
- 13 edits in trunk/Source
[wk2] Remove non-visible tiles from the layer tree
https://bugs.webkit.org/show_bug.cgi?id=106061
<rdar://problem/12761821>
Reviewed by Simon Fraser.
Unparenting tiles which aren't currently on-screen can allow underlying
frameworks to manage the layer's backing stores more effectively than we can.
In addition, add a setting (AggressiveTileRetentionEnabled) which keeps more
tiles around (we don't remove tiles in cohorts, nor when the TileCache moves
out of the window), which is off by default.
- WebCore.exp.in: Export Settings::setAggressiveTileRetentionEnabled.
- page/Settings.cpp:
(WebCore::Settings::Settings): Initialize m_aggressiveTileRetentionEnabled to false.
(WebCore::Settings::setAggressiveTileRetentionEnabled): Added.
- page/Settings.h:
(WebCore::Settings::aggressiveTileRetentionEnabled): Added.
- platform/graphics/TiledBacking.h: Add setter/getter to hand aggressivelyRetainsTiles through to TiledBackings.
- platform/graphics/ca/mac/TileCache.h:
(TileCache): Turn TileValidationPolicy into TileValidationPolicyFlags, and add
a flag for unparenting all tiles.
Implement aggressivelyRetainsTiles setter/getter.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache): Initialize m_aggressivelyRetainsTiles to false.
(WebCore::TileCache::setIsInWindow): Revalidate tiles immediately if the TileCache has just entered the window.
(WebCore::TileCache::tileRevalidationTimerFired):
This is called if coverage rect, tile cache layer bounds, or visibility changes. We will revalidate tiles:
- Removing all tiles from the layer tree for background tile caches.
- Not pruning old tiles if the aggressiveTileRetentionEnabled setting is on.
(WebCore::TileCache::revalidateTiles):
Adopt TileValidationPolicyFlags instead of the old enum, and use separate flags for foreground/background caches.
Unparent tiles when they move out of the tile coverage rect.
Only schedule the tile cohort removal timer if we're not aggressively keeping tiles around.
Ensure that tiles are re-added to the TileCache layer tree if they already exist.
Unparent all tiles if TileValidationPolicyFlags says to (from tileRevalidationTimerFired's background flags).
Only add new tiles to the TileCache's layer tree if we're currently in the window.
Don't prune secondary tiles if the visible rect changes; this will already occur because when the visibleRect
changes, we arrive via tileRevalidationTimerFired, which asks for PruneSecondaryTiles anyway (except if we're
aggressively retaining tiles). This prevents tiles from being deleted unexpectedly during rubber-banding or when zoomed (this part of the patch is thanks to Simon).
(WebCore::TileCache::ensureTilesForRect):
Don't ensure any tiles if the TileCache is offscreen.
Ensure that tiles are re-added to the TileCache layer tree if they already exist.
(WebCore::TileCache::drawTileMapContents):
Draw a thick purple border around tiles that have been unparented.
Add a setting to enable aggressive retention of TileCache tiles. If enabled,
TileCache will generally try to keep around all tiles. This setting is off by default.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAggressiveTileRetentionEnabled):
(WKPreferencesGetAggressiveTileRetentionEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences): Forward the setting to the TiledBacking.
- 2:45 PM Changeset in webkit [138857] by
-
- 4 edits1 add in trunk/LayoutTests
URL duplication in mouse cursor tests mean minor typos can cause flakiness
https://bugs.webkit.org/show_bug.cgi?id=104952
Patch by Rick Byers <rbyers@chromium.org> on 2013-01-04
Reviewed by Eric Seidel.
Replace the explicit list of images to preload with code that extracts
URLs from style definitions. Also move all this image preload code to
a common helper file so that it can easily be used by other tests.
- fast/events/mouse-cursor-image-set.html:
- fast/events/mouse-cursor-multiframecur.html:
- fast/events/mouse-cursor.html:
- fast/js/resources/image-preload-helper.js: Added.
(preloadImagesFromStyle):
(onComplete):
(imagesToLoad):
- 2:27 PM Changeset in webkit [138856] by
-
- 2 edits in trunk/LayoutTests
Unreviewd. Fix break caused by using old internals.settings.setEnableCompositingForFixedPosition
(has been renamed to setAcceleratedCompositingForFixedPositionEnabled).
- compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html:
- 2:18 PM Changeset in webkit [138855] by
-
- 2 edits in trunk/Source/WebCore
HTMLTreeBuilder should ASSERT that it is on the main thread before touching elements
https://bugs.webkit.org/show_bug.cgi?id=106128
Reviewed by Eric Seidel.
Even if we move the HTML parser onto a background thread, we're likely
to keep fragment parsing on the main thread. These code paths touch
elements (which only exist on the main thread) but are only used during
fragment parsing. This patch adds ASSERTs to document that invariant.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::closestFormAncestor):
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
- 2:01 PM Changeset in webkit [138854] by
-
- 4 edits4 adds in trunk
[CSS Regions] @region rules inside media queries are ignored
https://bugs.webkit.org/show_bug.cgi?id=102388
Reviewed by David Hyatt.
Using @region rules in media queries was ignored, but we should accept and apply it.
Source/WebCore:
Tests: fast/regions/region-rule-nested-region-rule.html
fast/regions/region-styling-mediaquery.html
- css/CSSGrammar.y.in: Add new ruleList for region rule to handle the media query case
and avoid using nested region rules.
- css/RuleSet.cpp:
(WebCore::RuleSet::addRulesFromSheet): Add case for region rules inside media queries.
LayoutTests:
- fast/regions/region-rule-nested-region-rule-expected.html: Added.
- fast/regions/region-rule-nested-region-rule.html: Added.
- fast/regions/region-styling-mediaquery-expected.html: Added.
- fast/regions/region-styling-mediaquery.html: Added.
- 1:48 PM Changeset in webkit [138853] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Last text input caret left visible when WebView entirely loses focus.
https://bugs.webkit.org/show_bug.cgi?id=106124
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2013-01-04
Reviewed by George Staikos.
Internal PR 248834
There are numerous code paths that lead to repainting of the focus node
when the focus moves to another node, but none seem to cover the case
of focus leaving the document when there are no DocumentMarkers present.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
- 1:48 PM Changeset in webkit [138852] by
-
- 3 edits1 add in branches/safari-536.28-branch/LayoutTests/platform/mac
Rebase svg tests.
- 1:39 PM Changeset in webkit [138851] by
-
- 5 edits2 adds in trunk
[mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
https://bugs.webkit.org/show_bug.cgi?id=106121
Reviewed by Adele Peterson.
Source/WebCore:
Test: TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm.
- bindings/objc/DOM.mm:
(-[DOMHTMLTableCellElement _cellAbove]): Added. Calls HTMLTableCellElement::cellAbove().
- bindings/objc/DOMPrivate.h: Added declaration of the above.
Tools:
Added test for -[DOMTHMLTableCellElement _cellAbove].
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
(-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::expectCellAboveCell):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
- 1:37 PM Changeset in webkit [138850] by
-
- 7 edits2 adds in trunk
Crash in WebCore::RenderBlock::willBeDestroyed
https://bugs.webkit.org/show_bug.cgi?id=103455
Reviewed by Eric Seidel.
Source/WebCore:
It is not required to set beforeChild to :after child since DOM is
now pseudo element aware. See trac.webkit.org/changeset/137336. We
were incorrectly placing the inline continuation before the :after
content.
Test: fast/multicol/continuation-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): remove beforeChild
setting to afterPseudoElementRenderer.
- rendering/RenderRuby.cpp:
(WebCore::RenderRubyAsInline::addChild): add missing beforeChild argument.
setting to afterPseudoElementRenderer.
(WebCore::RenderRubyAsBlock::addChild): add missing beforeChild argument.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild): remove beforeChild
setting to afterPseudoElementRenderer.
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild): remove beforeChild
setting to afterPseudoElementRenderer.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild): remove beforeChild
setting to afterPseudoElementRenderer.
LayoutTests:
- fast/multicol/continuation-crash-expected.txt: Added.
- fast/multicol/continuation-crash.html: Added.
- 1:33 PM Changeset in webkit [138849] by
-
- 21 edits3 copies3 adds2 deletes in trunk
Implement WebIDL-style string constants in WebAudio (part 2)
https://bugs.webkit.org/show_bug.cgi?id=105977
Reviewed by Kentaro Hara.
Source/WebCore:
See Deprecation Notes for more detail:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#DeprecationNotes
PannerNode, BiquadFilterNode, OscillatorNode constants must support WebIDL-style string constants.
Legacy support in the setters for the old integer values should be supported.
This patch handles the changes for BiquadFilterNode and PannerNode.
Test: webaudio/pannernode-basic.html
- GNUmakefile.list.am:
- Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::type):
(WebCore):
(WebCore::BiquadFilterNode::setType):
- Modules/webaudio/BiquadFilterNode.h:
(BiquadFilterNode):
- Modules/webaudio/BiquadFilterNode.idl:
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::panningModel):
(WebCore):
(WebCore::PannerNode::setPanningModel):
(WebCore::PannerNode::distanceModel):
(WebCore::PannerNode::setDistanceModel):
- Modules/webaudio/PannerNode.h:
(PannerNode):
- Modules/webaudio/PannerNode.idl:
- Target.pri:
- UseJSC.cmake:
- UseV8.cmake:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBiquadFilterNodeCustom.cpp: Copied from Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp.
(WebCore):
(WebCore::JSBiquadFilterNode::setType):
- bindings/js/JSPannerNodeCustom.cpp: Copied from Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp.
(WebCore):
(WebCore::JSPannerNode::setPanningModel):
(WebCore::JSPannerNode::setDistanceModel):
- bindings/v8/custom/V8BiquadFilterNodeCustom.cpp: Copied from Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp.
(WebCore):
(WebCore::V8BiquadFilterNode::typeAccessorSetter):
- bindings/v8/custom/V8PannerNodeCustom.cpp: Added.
(WebCore):
(WebCore::V8PannerNode::panningModelAccessorSetter):
(WebCore::V8PannerNode::distanceModelAccessorSetter):
LayoutTests:
- webaudio/audiopannernode-basic-expected.txt: Removed.
- webaudio/audiopannernode-basic.html: Removed.
- webaudio/biquad-getFrequencyResponse-expected.txt:
- webaudio/biquad-getFrequencyResponse.html:
- webaudio/biquadfilternode-basic-expected.txt:
- webaudio/biquadfilternode-basic.html:
- webaudio/pannernode-basic-expected.txt: Added.
- webaudio/pannernode-basic.html: Added.
- webaudio/resources/biquad-testing.js:
- webaudio/resources/distance-model-testing.js:
(createGraph):
(.return.renderedBuffer):
(checkDistanceResult):
- webaudio/resources/panner-model-testing.js:
(createGraph):
- 1:25 PM Changeset in webkit [138848] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] FCC will show up as you type if you tap on the same input bar twice before typing
https://bugs.webkit.org/show_bug.cgi?id=106116
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-01-04
Reviewed by Yong Li.
Internal reviewed by Gen Mak.
PR 267177
FCC is being invoked because the fatfinger result is no longer a reliable source
to tell whether the caret change is caused by user touch input. Instead, we recognize all
notifyCaretChange calls with userTouchInput as true except when caretPositionChanged is invoked
by SelectionHandler:inputHandlerDidFinishProcessingChange.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::inputHandlerDidFinishProcessingChange):
(BlackBerry::WebKit::SelectionHandler::notifyCaretPositionChangedIfNeeded):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- WebKitSupport/SelectionHandler.h:
(SelectionHandler):
- 1:25 PM Changeset in webkit [138847] by
-
- 2 edits in branches/safari-536.28-branch/LayoutTests
Update tests to use layoutTestController instead of testRunner.
- 1:23 PM Changeset in webkit [138846] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Cached frame shouldn't access the page when being destroyed
https://bugs.webkit.org/show_bug.cgi?id=105942
Reviewed by George Staikos.
Fix regression of previous patch. dispatchDidHandleOnloadEvents() can be called
after Frame has been detached.
RIM PR# 271237.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):
- 1:15 PM Changeset in webkit [138845] by
-
- 12 edits in trunk/Source/WebKit2
Make process initialization more uniform by renaming initialization methods and removing extraneous parameters
https://bugs.webkit.org/show_bug.cgi?id=106120
Reviewed by Brady Eidson.
Rename FooProcess::initialize() -> FooProcess::initializeConnection() and removes
the RunLoop parameter since it is always the same the as RunLoop::main().
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeConnection):
- NetworkProcess/NetworkProcess.h:
(NetworkProcess):
- NetworkProcess/mac/NetworkProcessInitialization.mm:
(WebKit::initializeNetworkProcess):
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::initializeConnection):
- PluginProcess/PluginProcess.h:
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
- PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::PluginProcessMain):
- PluginProcess/unix/PluginProcessMainUnix.cpp:
(WebKit::PluginProcessMainUnix):
- SharedWorkerProcess/SharedWorkerProcess.cpp:
(WebKit::SharedWorkerProcess::initializeConnection):
- SharedWorkerProcess/SharedWorkerProcess.h:
(SharedWorkerProcess):
- SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm:
(WebKit::SharedWorkerProcessMain):
- 1:15 PM Changeset in webkit [138844] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. The following two tests are flaky on XP:
svg/custom/feComponentTransfer-Table.svg
svg/custom/embedding-external-svgs.xhtml
- platform/chromium/TestExpectations:
- 1:12 PM Changeset in webkit [138843] by
-
- 11 edits in trunk
window.Touch and TouchList should exist when touch events are enabled
https://bugs.webkit.org/show_bug.cgi?id=96295
Patch by Rick Byers <rbyers@chromium.org> on 2013-01-04
Reviewed by Kentaro Hara.
Source/WebCore:
Add missing window.Touch and window.TouchList constructors under
ENABLE(TOUCH_EVENTS).
Make window.Touch, window.TouchList and window.TouchEvent enabled at runtime
under V8, to be consistent with all the other touch-related APIs.
Tests: fast/events/touch/document-create-touch-list.html
fast/js/global-constructors.html
- bindings/generic/RuntimeEnabledFeatures.h:
- dom/Document.idl:
- dom/Element.idl:
- page/DOMWindow.idl:
LayoutTests:
Add new expected constructors and instanceof checks.
- fast/events/touch/document-create-touch-list-expected.txt:
- fast/events/touch/script-tests/document-create-touch-list.js:
- platform/efl/fast/js/global-constructors-expected.txt:
- platform/qt-5.0/fast/js/global-constructors-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 1:04 PM Changeset in webkit [138842] by
-
- 1 edit2 adds in trunk/LayoutTests
Test compositing and slow scrolling behavior of fixed position elements under transformed elements
https://bugs.webkit.org/show_bug.cgi?id=103470
Reviewed by Simon Fraser.
Add test case for the behavior change about fixed position elements under transformed elements in bug 102543 by the way.
- compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt: Added.
- compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html: Added.
- 1:03 PM Changeset in webkit [138841] by
-
- 6 edits1 move1 add in trunk/Source/WebCore
[v8] Stop using an IDL to generate V8MutationCallback
https://bugs.webkit.org/show_bug.cgi?id=106122
Reviewed by Adam Barth.
The only real code in the generated V8MutationCallback.{h,cpp} files
were specifically written in CodeGeneratorV8 for its use. By instead
Using completely-hand-written versions of these files, the
CodeGenerator can be simplified (as can all generated Callbacks).
All the actually shared code is still shared via subclassing of
ActiveDOMCallback.
This introduces additional flexibility into the implementation of
MutationCallback which will be used when fixing the MutationObserver
memory leak (http://webkit.org/b/90661) for JSC.
No changes to JSC for now, just a FIXME in the IDL file.
No new tests, refactoringonly.
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
- bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::V8TestCallback):
- bindings/scripts/test/V8/V8TestCallback.h:
(WebCore::V8TestCallback::create):
(V8TestCallback):
- bindings/v8/V8MutationCallback.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MutationCallbackCustom.cpp.
(WebCore::V8MutationCallback::V8MutationCallback):
(WebCore::V8MutationCallback::handleEvent):
- bindings/v8/V8MutationCallback.h: Added.
(V8MutationCallback):
(WebCore::V8MutationCallback::create):
(WebCore::V8MutationCallback::weakCallback):
- dom/MutationCallback.idl:
- 12:51 PM Changeset in webkit [138840] by
-
- 28 edits in trunk
Remove some autogenerated settings from InternalSettings.idl
https://bugs.webkit.org/show_bug.cgi?id=106114
Reviewed by Ojan Vafai.
Source/WebCore:
Remove 6 methods that are now autogenerated.
setAcceleratedFiltersEnabled was never called.
AcceleratedCompositingForOverflowScrollEnabled was never backed up/restored.
setEnableCompositingForFixedPosition and setEnableCompositingForScrollableFrames
are renamed to match the name in Settings.in.
No new tests, there should be no change in behavior. This is covered by
existing tests in compositing and platform/chromium/compositing.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Remove code.
(WebCore::InternalSettings::Backup::restoreTo): Remove code.
- testing/InternalSettings.h:
(Backup): Remove member variables.
(InternalSettings):
- testing/InternalSettings.idl: Remove methods that are no longer used.
LayoutTests:
Rename setters to match the name in Settings.in
setEnableCompositingForFixedPosition -> setAcceleratedCompositingForFixedPositionEnabled
setEnableCompositingForScrollableFrames -> setAcceleratedCompositingForScrollableFramesEnabled
- compositing/absolute-inside-out-of-view-fixed.html:
- compositing/geometry/fixed-position-composited-page-scale-down.html:
- compositing/geometry/fixed-position-composited-page-scale-scroll.html:
- compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html:
- compositing/geometry/fixed-position-composited-page-scale.html:
- compositing/geometry/fixed-position-composited-switch.html:
- compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
- compositing/geometry/fixed-position-iframe-composited-page-scale.html:
- compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
- compositing/geometry/fixed-position-transform-composited-page-scale.html:
- compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html:
- compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html:
- compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html:
- compositing/layer-creation/fixed-position-out-of-view-scaled.html:
- compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html:
- compositing/layer-creation/fixed-position-out-of-view.html:
- compositing/overflow/automatically-opt-into-composited-scrolling.html:
- platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
- platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
- platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
- platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
- platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
- platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:
- 12:51 PM Changeset in webkit [138839] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Allow defaultTabEventHandler to trigger on tab
https://bugs.webkit.org/show_bug.cgi?id=106118
Reviewed by Yong Li.
In order to support tabbing through input elements, amongst
other things, we need to bipass the processing of the tab key as
'\t'. This will simply insert 4 spaces in the field. Remove tab
support from the key down map so that we don't translate it to
an editor command.
Internally reviewed by Mike Fenton.
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore):
- 12:45 PM Changeset in webkit [138838] by
-
- 23 edits2 adds in trunk
Vertical writing mode can overflow fixed size grandparent container
https://bugs.webkit.org/show_bug.cgi?id=93655
Reviewed by David Hyatt.
Source/WebCore:
Add a hook to RenderBox::availableHeight to exclude the containing block's
margin, border and padding. This is for auto-sizing perpendicular writing modes
to restrict to the minimum of the fill-available height and the viewport height.
This will be used in a future patch to implement "height: fill-available".
This behavior was recently specced in http://dev.w3.org/csswg/css3-sizing/#extrinsic-sizing.
Test: fast/writing-mode/auto-sizing-orthogonal-flows.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
- rendering/RenderBox.h:
(RenderBox):
(WebCore::RenderBox::availableWidth):
(WebCore::RenderBox::availableHeight):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::computeIntrinsicRatioInformation):
- rendering/RenderView.cpp:
(WebCore::RenderView::availableLogicalHeight):
- rendering/RenderView.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
LayoutTests:
- fast/writing-mode/auto-sizing-orthogonal-flows-expected.txt: Added.
- fast/writing-mode/auto-sizing-orthogonal-flows.html: Added.
- fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt:
- fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt:
- fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html:
- fast/writing-mode/percentage-height-orthogonal-writing-modes.html:
- fast/writing-mode/table-percent-width-quirk-expected.png:
- fast/writing-mode/table-percent-width-quirk-expected.txt:
This test now correctly uses the containing blocks's availableHeight instead of the
initial containing block's height to size the perpendicular child.
- platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.txt:
- platform/chromium-linux/fast/table/038-vertical-expected.png:
- platform/chromium-linux/fast/table/border-collapsing/004-vertical-expected.png:
The extra wrapping in this test is just because we subtract the body's margin when
computing the available height. If you force the table's container 16px smaller,
you get the same rendering at tip of tree WebKit.
- platform/chromium-win/fast/table/038-vertical-expected.txt:
- platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
Add tests that will need rebaseline once this patch lands.
- 12:43 PM Changeset in webkit [138837] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Enable Input Focus when handling touch events for JS
https://bugs.webkit.org/show_bug.cgi?id=106109
Reviewed by Yong Li.
PR 273325.
Toggle input mode active when a touch event is
received for JS processing to ensure state
is updated even when event is consumed.
Reviewed Internally by Gen Mak.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::touchEvent):
- 12:42 PM Changeset in webkit [138836] by
-
- 14 edits4 adds in trunk
Add tests for WebIDL type conversions
https://bugs.webkit.org/show_bug.cgi?id=105927
Reviewed by Adam Barth.
Source/WebCore:
Expose attributes of various WebIDL types for testing ECMAScript value conversion,
including edge cases such as NaNs, Infinities, etc. These attributes hang off
a TypeConversions object created via window.internals.typeConversions().
Test: fast/js/webidl-type-mapping.html
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.vcproj/WebCoreTestSupport.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- testing/Internals.cpp:
(WebCore::Internals::typeConversions):
(WebCore):
- testing/Internals.h:
(WebCore):
- testing/Internals.idl:
- testing/TypeConversions.h: Added.
(WebCore):
(TypeConversions):
(WebCore::TypeConversions::create):
(WebCore::TypeConversions::testLong):
(WebCore::TypeConversions::setTestLong):
(WebCore::TypeConversions::testUnsignedLong):
(WebCore::TypeConversions::setTestUnsignedLong):
(WebCore::TypeConversions::testLongLong):
(WebCore::TypeConversions::setTestLongLong):
(WebCore::TypeConversions::testUnsignedLongLong):
(WebCore::TypeConversions::setTestUnsignedLongLong):
(WebCore::TypeConversions::TypeConversions):
- testing/TypeConversions.idl: Added.
LayoutTests:
This currently fails long long conversions of non-finites (which should map to 0). Patch
in progress at: http://wkbug.com/96798
- fast/js/webidl-type-mapping-expected.txt: Added.
- fast/js/webidl-type-mapping.html: Added.
- 12:40 PM Changeset in webkit [138835] by
-
- 5 edits2 adds in trunk
Invalidation of some SVG filter attributes on HTML content doesn't work
https://bugs.webkit.org/show_bug.cgi?id=105635
Reviewed by Dirk Schulze.
Source/WebCore:
Since HTML elements with filters are only added to m_clientLayers, not
m_clients, and do not use the FilterInfo used by SVG filters on SVG
elements, they must be invalidated separately. Some filter attribute
invalidations call markAllClientsForInvalidation(), but some call
markClientForInvalidation() directly. These invaldations must also
invalidate m_clientLayers.
Test: css3/filters/reference-filter-update-on-attribute-change.html
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):
(WebCore::RenderSVGResourceContainer::markAllClientLayersForInvalidation):
- rendering/svg/RenderSVGResourceContainer.h:
Refactor client layer invalidation out into its own function.
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
Mark all client layers for invalidation when a filter primitve attribute is
changed.
LayoutTests:
New reftest to verify filter attribute change invalidations.
- css3/filters/reference-filter-update-on-attribute-change-expected.html: Added.
- css3/filters/reference-filter-update-on-attribute-change.html: Added.
- 12:38 PM Changeset in webkit [138834] by
-
- 3 edits4 adds in trunk
CSP 1.1: Experiment with adding line numbers to violation reports.
https://bugs.webkit.org/show_bug.cgi?id=105374
Reviewed by Adam Barth.
Source/WebCore:
Line numbers and URLs were added to the CSP 1.1 spec in
https://dvcs.w3.org/hg/content-security-policy/rev/e0270baace3d, and
already exist (and have for quite some time) in Firefox's
implementation. Based on developer feedback, it seems reasonable to
experiment a bit with adding them to WebKit's violation reports.
This patch generates a stack trace when constructing the violation
report object (iff a violation report object ought to be generated)
and adds a line number and URL to the object if possible.
Tests: http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript.html
http/tests/security/contentSecurityPolicy/report-uri-from-javascript.html
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
Generate a stack trace when building the violation report: if it
has relevant detail, add the line number and URL to the report
object.
LayoutTests:
- http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript.html: Added.
- http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-uri-from-javascript.html: Added.
- 12:32 PM Changeset in webkit [138833] by
-
- 3 edits4 adds in trunk
CSS3 calc: working with translate and scale transforms
https://bugs.webkit.org/show_bug.cgi?id=105985
Reviewed by Ojan Vafai.
Source/WebCore:
Allow convertTo[Float|Int]Length functions to process calculated values.
Tests: css3/calc/transforms-scale.html
css3/calc/transforms-translate.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::convertToIntLength):
(WebCore::StyleResolver::convertToFloatLength):
LayoutTests:
- css3/calc/transforms-scale-expected.html: Added.
- css3/calc/transforms-scale.html: Added.
- css3/calc/transforms-translate-expected.html: Added.
- css3/calc/transforms-translate.html: Added.
- 12:30 PM Changeset in webkit [138832] by
-
- 3 edits2 adds in trunk
PseudoElement should never dispatch events
https://bugs.webkit.org/show_bug.cgi?id=106048
Reviewed by Ojan Vafai.
Source/WebCore:
The new DOM based generated content can sometimes dispatch events
as a result of animations or transitions which is incorrect as it
exposes the PseudoElement to script. All event dispatch from a
PseudoElement should be ignored.
Per discussions with Tab Atkins in the future we might add support
by making events dispatched from a pseudo element fire with the
target as the parent element and add a new pseudo property to
events that has the value "before" or "after".
Test: fast/css-generated-content/pseudo-element-events.html
- dom/PseudoElement.h:
LayoutTests:
Add a test that events don't get dispatched from pseudo elements. The
only way right now to cause this is with transitions or animations.
- fast/css-generated-content/pseudo-element-events-expected.txt: Added.
- fast/css-generated-content/pseudo-element-events.html: Added.
- 12:25 PM Changeset in webkit [138831] by
-
- 13 edits in trunk/Source/Platform
[chromium] Remove static create functions from types WebCompositorSupport can construct
https://bugs.webkit.org/show_bug.cgi?id=99877
Patch by James Robinson <jamesr@chromium.org> on 2013-01-04
Reviewed by Adrienne Walker.
- chromium/public/WebAnimation.h:
- chromium/public/WebContentLayer.h:
- chromium/public/WebExternalTextureLayer.h:
- chromium/public/WebFloatAnimationCurve.h:
- chromium/public/WebIOSurfaceLayer.h:
- chromium/public/WebImageLayer.h:
- chromium/public/WebLayer.h:
- chromium/public/WebLayerTreeView.h:
- chromium/public/WebScrollbarLayer.h:
- chromium/public/WebSolidColorLayer.h:
- chromium/public/WebTransformAnimationCurve.h:
- chromium/public/WebVideoLayer.h:
- 12:25 PM Changeset in webkit [138830] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed gardening. Adding Lion image baseline for
fast/regions/full-screen-video-from-region.html
- platform/chromium-mac-lion/fast/regions/full-screen-video-from-region-expected.png: Added.
- 12:23 PM Changeset in webkit [138829] by
-
- 2 edits in trunk/Source/WebCore
WebKitCSSTransformValue::customCssText() should always allocate once
https://bugs.webkit.org/show_bug.cgi?id=105445
Reviewed by Alexis Menard.
When converting a WebKitCSSTransformValue to a String representation,
it was typically done with 2 memory allocations due to the string size in StringBuilder.
This patch changes the code to use the String Concatenate operations in order
to create the string at once.
The opening parenthesis is also moved in the prefix name in order to maximize
the range copied with memcopy.
- css/WebKitCSSTransformValue.cpp:
(WebCore::transformValueToCssString): New generic function for boxing values.
(WebCore::WebKitCSSTransformValue::customCssText):
(WebCore::WebKitCSSTransformValue::customSerializeResolvingVariables):
- 12:13 PM Changeset in webkit [138828] by
-
- 3 edits in trunk/LayoutTests
Add a crash test expectation for the crashing test on Mac WebKit1 after r138782,
which attempted to fix the crash but appears to did so only on WebKit2.
The failure is tracked by the bug 106123.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 12:06 PM Changeset in webkit [138827] by
-
- 2 edits in trunk/LayoutTests
The following two tests are starting to fail while on the verge of
timing out. Adding Failure to their modifiers.
fast/canvas/webgl/context-creation-and-destruction.html
platform/chromium/virtual/gpu/fast/canvas/webgl/context-creation-and-destruction.html
- platform/chromium/TestExpectations:
- 12:05 PM Changeset in webkit [138826] by
-
- 11 edits in trunk/Tools
FlakyTestReporter should be re-enabled and taught how to post patches
https://bugs.webkit.org/show_bug.cgi?id=103839
Reviewed by Adam Barth.
This moves LayoutTestResultsReader off of the DeprecatedPort object.
It also adds a real Port object to the EWS and CommitQueue objects
using a new PatchProcessingQueue superclass.
PatchProcessingQueue doesn't seem to be the cleanest insertion point
but works for this purpose.
I also moved _upload_results_archive_for_patch into PatchProcessingQueue
to resolve a FIXME.
This required some hacks/shiming between the non-specific "old"
port names which the EWS system is currently using, and the new
port objects. This shimming is done in PatchProcessingQueue._new_port_name_from_old.
Hopefully this will fix the flaky test reporter and results uploading.
Certainly it's another small step towards getting rid of the old ports.py
infrastructure and making the NRWT Port class common webkitpy infrastructure.
Now that DeprecatedPort is no longer used for the results directory
I removed all the explicit results-dir code which webkit-patch was using
in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.run_perl_unittests_command):
- Scripts/webkitpy/common/config/ports_mock.py:
(MockPort.name):
- Scripts/webkitpy/common/system/outputcapture.py:
(OutputCapture.assert_outputs):
- Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort.determine_full_port_name):
- Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
(LayoutTestResultsReader.init):
(LayoutTestResultsReader):
(LayoutTestResultsReader._read_file_contents):
(LayoutTestResultsReader._create_layout_test_results):
(LayoutTestResultsReader._create_unit_test_results):
(LayoutTestResultsReader.results):
(LayoutTestResultsReader.archive):
- Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_missing_layout_test_results):
(LayoutTestResultsReaderTest.test_create_unit_test_results):
(test_missing_unit_test_results_path):
(test_layout_test_results):
(test_archive_last_layout_test_results):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.init):
(AbstractEarlyWarningSystem.begin_work_queue):
(AbstractEarlyWarningSystem.run_command):
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractPatchQueue.work_item_log_path):
(PatchProcessingQueue):
(PatchProcessingQueue._new_port_name_from_old):
(PatchProcessingQueue.begin_work_queue):
(PatchProcessingQueue._upload_results_archive_for_patch):
(CommitQueue):
(CommitQueue.begin_work_queue):
(CommitQueue.run_command):
(AbstractReviewQueue):
(AbstractReviewQueue.init):
(AbstractReviewQueue.begin_work_queue):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(AbstractPatchQueueTest.test_next_patch):
(PatchProcessingQueueTest):
(PatchProcessingQueueTest.test_upload_results_archive_for_patch):
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
- 12:02 PM Changeset in webkit [138825] by
-
- 4 edits in trunk/Source
[chromium] WebTransformationMatrix shouldn't alias memory for TransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=106025
Patch by James Robinson <jamesr@chromium.org> on 2013-01-04
Reviewed by Adrienne Walker.
Source/Platform:
- chromium/public/WebTransformationMatrix.h:
(WebCore):
(WebKit::WebTransformationMatrix::~WebTransformationMatrix):
(WebTransformationMatrix):
Source/WebCore:
- platform/chromium/support/WebTransformationMatrix.cpp:
(WebKit::WebTransformationMatrix::WebTransformationMatrix):
(WebKit::WebTransformationMatrix::reset):
(WebKit):
(WebKit::WebTransformationMatrix::operator=):
(WebKit::WebTransformationMatrix::operator==):
(WebKit::WebTransformationMatrix::inverse):
(WebKit::WebTransformationMatrix::to2dTransform):
(WebKit::WebTransformationMatrix::multiply):
(WebKit::WebTransformationMatrix::makeIdentity):
(WebKit::WebTransformationMatrix::translate):
(WebKit::WebTransformationMatrix::translate3d):
(WebKit::WebTransformationMatrix::translateRight3d):
(WebKit::WebTransformationMatrix::scale):
(WebKit::WebTransformationMatrix::scaleNonUniform):
(WebKit::WebTransformationMatrix::scale3d):
(WebKit::WebTransformationMatrix::rotate):
(WebKit::WebTransformationMatrix::rotate3d):
(WebKit::WebTransformationMatrix::skewX):
(WebKit::WebTransformationMatrix::skewY):
(WebKit::WebTransformationMatrix::applyPerspective):
(WebKit::WebTransformationMatrix::blend):
(WebKit::WebTransformationMatrix::hasPerspective):
(WebKit::WebTransformationMatrix::isInvertible):
(WebKit::WebTransformationMatrix::isBackFaceVisible):
(WebKit::WebTransformationMatrix::isIdentity):
(WebKit::WebTransformationMatrix::isIdentityOrTranslation):
(WebKit::WebTransformationMatrix::isIntegerTranslation):
(WebKit::WebTransformationMatrix::m11):
(WebKit::WebTransformationMatrix::setM11):
(WebKit::WebTransformationMatrix::m12):
(WebKit::WebTransformationMatrix::setM12):
(WebKit::WebTransformationMatrix::m13):
(WebKit::WebTransformationMatrix::setM13):
(WebKit::WebTransformationMatrix::m14):
(WebKit::WebTransformationMatrix::setM14):
(WebKit::WebTransformationMatrix::m21):
(WebKit::WebTransformationMatrix::setM21):
(WebKit::WebTransformationMatrix::m22):
(WebKit::WebTransformationMatrix::setM22):
(WebKit::WebTransformationMatrix::m23):
(WebKit::WebTransformationMatrix::setM23):
(WebKit::WebTransformationMatrix::m24):
(WebKit::WebTransformationMatrix::setM24):
(WebKit::WebTransformationMatrix::m31):
(WebKit::WebTransformationMatrix::setM31):
(WebKit::WebTransformationMatrix::m32):
(WebKit::WebTransformationMatrix::setM32):
(WebKit::WebTransformationMatrix::m33):
(WebKit::WebTransformationMatrix::setM33):
(WebKit::WebTransformationMatrix::m34):
(WebKit::WebTransformationMatrix::setM34):
(WebKit::WebTransformationMatrix::m41):
(WebKit::WebTransformationMatrix::setM41):
(WebKit::WebTransformationMatrix::m42):
(WebKit::WebTransformationMatrix::setM42):
(WebKit::WebTransformationMatrix::m43):
(WebKit::WebTransformationMatrix::setM43):
(WebKit::WebTransformationMatrix::m44):
(WebKit::WebTransformationMatrix::setM44):
(WebKit::WebTransformationMatrix::a):
(WebKit::WebTransformationMatrix::setA):
(WebKit::WebTransformationMatrix::b):
(WebKit::WebTransformationMatrix::setB):
(WebKit::WebTransformationMatrix::c):
(WebKit::WebTransformationMatrix::setC):
(WebKit::WebTransformationMatrix::d):
(WebKit::WebTransformationMatrix::setD):
(WebKit::WebTransformationMatrix::e):
(WebKit::WebTransformationMatrix::setE):
(WebKit::WebTransformationMatrix::f):
(WebKit::WebTransformationMatrix::setF):
(WebKit::WebTransformationMatrix::toWebCoreTransform):
- 11:55 AM Changeset in webkit [138824] by
-
- 1 edit7 adds in trunk/LayoutTests
Add Mac baselines for subpixel tests added in r125794, r137945, and r138200.
https://bugs.webkit.org/show_bug.cgi?id=106070
Reviewed by Emil A Eklund.
Added baselines.
- platform/mac/fast/sub-pixel: Added.
- platform/mac/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.png: Added.
- platform/mac/fast/sub-pixel/sub-pixel-accumulates-to-layers-expected.txt: Added.
- platform/mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Added.
- platform/mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Added.
- platform/mac/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png: Added.
- platform/mac/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt: Added.
- 11:48 AM Changeset in webkit [138823] by
-
- 18 edits16 adds in trunk
CSS url() filters with forward references don't work
https://bugs.webkit.org/show_bug.cgi?id=90405
Based on a patch by Keyar Hood.
Reviewed by Dirk Schulze.
Source/WebCore:
In order for CSS to reference SVG filters that will occur later in
the document, or will be added at a future time, we need a way to
notify the target element (the one the filter style is applied to)
when the correct SVG filter is added to the DOM.
There is already code for SVG elements that handles this problem, in
SVGResourcesCache. This patch allows any element to have a reference to
an SVG element in SVGResourceCache.
Tests: css3/filters/effect-reference-after.html
css3/filters/effect-reference-delete-crash.html
css3/filters/effect-reference-delete.html
css3/filters/effect-reference-removed-while-pending-resources.html
css3/filters/effect-reference-rename.html
css3/filters/effect-reference-reset-style-delete-crash.html
svg/filters/filter-cycle.html
- dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::removedFrom):
When an Element is deleted or removed from its container, and it
has pending resources, remove it from the SVGResourceCache resources
on deletion or when removed from its container.
(WebCore::Element::hasPendingResources):
(WebCore::Element::setHasPendingResources):
(WebCore::Element::clearHasPendingResources):
Accessors for ElementRareData's new bit flag.
- dom/Element.h:
(WebCore::Element::buildPendingResource):
Virtual function to override for referenced elements (moved from SVGElement).
- dom/ElementRareData.h:
(WebCore::ElementRareData::hasPendingResources):
(WebCore::ElementRareData::setHasPendingResources):
(WebCore::ElementRareData::ElementRareData):
Add a new bit flag to indicate whether the element depends on pending resources or not, and accessors.
- dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(NodeRareData):
The actual flag bit lives in NodeRareData, so it compacts better with
other flags.
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):
Changed to the new function signature for FilterEffectRenderer::build().
- rendering/FilterEffectRenderer.cpp:
(WebCore::createCustomFilterEffect):
(WebCore::FilterEffectRenderer::buildReferenceFilter):
Changed signature to accept a RenderObject rather than a Document, so we know which node to notify when the SVG filter arrives. If the referenced filter cannot be found, add its id as a pending reference.
(WebCore::FilterEffectRenderer::build):
- rendering/FilterEffectRenderer.h:
Change to signatures of build() and buildReferenceFilter() to pass
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateOrRemoveFilterEffectRenderer):
Use the new semantics for FilterEffectRenderer::build().
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::registerResource):
Call clearHasPendingResourceIfPossible on the SVGDocumentExtensions, not
on the element, since we want to support generic Elements.
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::addResourcesFromRenderObject):
(WebCore::SVGResourcesCache::clientStyleChanged):
For non-SVG elements, set a synthetic style change when parent resources
are invalidated.
(WebCore::SVGResourcesCache::resourceDestroyed):
Add support for non-SVG Elements.
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::isElementPendingResource):
Changed to allow use of Element instead of SVGElement.
(WebCore::SVGDocumentExtensions::clearHasPendingResourcesIfPossible):
Moved from SVGElement, and made to work on any Element. This way,
we avoid adding this function to Element itself.
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResourcesForRemoval):
Changed to allow use of Element instead of SVGElement.
- svg/SVGDocumentExtensions.h:
SVGElement -> Element.
- svg/SVGElement.cpp:
(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::removedFrom):
Don't handle pending resource notifications (Element will do it).
- svg/SVGElement.h:
All functions moved to Element, except for clearHasPendingResourcesIfPossible() moved to SVGDocumentExtensions.
- svg/SVGElementRareData.h:
(WebCore::SVGElementRareData::SVGElementRareData):
m_hasPendingResources and accessors moved to ElementRareData.
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
SVGElement -> Element, and call SVGDocumentExtensions for
clearHasPendingResourcesIfPossible().
LayoutTests:
- css3/filters/effect-reference-after-expected.html: Added.
- css3/filters/effect-reference-after.html: Added.
- css3/filters/effect-reference-delete-crash.html: Added.
- css3/filters/effect-reference-delete-expected.html: Added.
- css3/filters/effect-reference-delete.html: Added.
- css3/filters/effect-reference-removed-while-pending-resources-expected.html: Added.
- css3/filters/effect-reference-removed-while-pending-resources.html: Added.
- css3/filters/effect-reference-rename-expected.html: Added.
- css3/filters/effect-reference-rename.html: Added.
- css3/filters/effect-reference-reset-style-delete-crash-expected.txt: Added.
- css3/filters/effect-reference-reset-style-delete-crash.html: Added.
- css3/filters/script-tests/effect-reference-delete-crash.js: Added.
- css3/filters/script-tests/effect-reference-reset-style-delete-crash.js: Added.
- svg/filters/filter-cycle-expected.html: Added.
- svg/filters/filter-cycle.html: Added.
- 11:36 AM Changeset in webkit [138822] by
-
- 3 edits2 deletes in trunk/Source/Platform
[chromium] Remove unneeded WebDelegatedRendererLayer and WebCompositorTransferableResourceList headers
https://bugs.webkit.org/show_bug.cgi?id=105263
Patch by James Robinson <jamesr@chromium.org> on 2013-01-04
Reviewed by Darin Fisher.
These aren't needed any more since the delegation will be set up on the chromium side.
- Platform.gypi:
- chromium/public/WebCompositorSupport.h:
(WebKit):
- chromium/public/WebCompositorTransferableResourceList.h: Removed.
- chromium/public/WebDelegatedRendererLayer.h: Removed.
- 11:34 AM Changeset in webkit [138821] by
-
- 5 edits in trunk/Source/WebCore
Clamp font sizes to valid range in RenderStyle::setFontSize
https://bugs.webkit.org/show_bug.cgi?id=106014
Patch by John Mellor <johnme@chromium.org> on 2013-01-04
Reviewed by Emil A Eklund.
There is a test-case attached to http://crbug.com/167443, but I can't
think of a good way of automatically testing this. Functionality
shouldn't change on normal pages.
- rendering/style/RenderStyleConstants.h:
Add constant for maximum allowed font size.
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyFontSize::applyValue):
Use constant from RenderStyleConstants.h instead of hardcoding.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::getComputedSizeFromSpecifiedSize):
Use constant from RenderStyleConstants.h instead of hardcoding.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setFontSize):
Clamp non-finite and out of range font sizes.
- 11:32 AM Changeset in webkit [138820] by
-
- 3 edits3 adds in trunk
CSP: Blocked 'track' sources should only log once to the console.
https://bugs.webkit.org/show_bug.cgi?id=106091
Reviewed by Eric Carlson.
Source/WebCore:
HTMLTrackElement posts a message to the console when track data is
blocked by Content Security Policy. Now that we're logging inside the
ContentSecurityPolicy object itself, there's no need for the
duplication. This patch drops the extra log message (and, as a
side-effect, adds a test that ensures that 'track' content is governed
by the 'media-src' directive).
Test: http/tests/security/contentSecurityPolicy/media-src-track-block.html
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::canLoadUrl):
LayoutTests:
- http/tests/security/contentSecurityPolicy/media-src-track-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/media-src-track-block.html: Added.
- http/tests/security/contentSecurityPolicy/resources/track.srt: Added.
- 11:26 AM BuildingQtOnWindows edited by
- Unindent Ruby from GnuWin32 tools (diff)
- 11:18 AM Changeset in webkit [138819] by
-
- 2 edits in trunk/Source/WebCore
Crash in media/unsupported-rtsp.html.
https://bugs.webkit.org/show_bug.cgi?id=106038
Reviewed by Eric Carlson.
Fixes media/unsupported-rtsp.html on Mac platforms which support AVAssetResourceLoadingRequest.
Check that the CachedResource passed in the notifyFinished method didn't fail or error before
passing its (possibly nil) contents to the AVAssetResourceLoadingRequest.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::notifyFinished):
(WebCore::WebCoreAVFResourceLoader::fulfillRequestWithResource):
- 11:13 AM Changeset in webkit [138818] by
-
- 4 edits2 adds in trunk
CSP: 'frame-src' should block redirects to invalid sources.
https://bugs.webkit.org/show_bug.cgi?id=106084
Reviewed by Adam Barth.
Source/WebCore:
The 'frame-src' CSP directive whitelists valid iframe targets, but
currently fails to correctly deal with redirection. As long as the
initial target is valid, any redirection goes through without
question. This patch moves the CSP check out of
SubframeLoader::loadSubframe, and into
PolicyChecker::checkNavigationPolicy. In the new location, the check
is well-positioned to check each URL in a redirect chain, as opposed
to checking only the initial target.
Test: http/tests/security/contentSecurityPolicy/frame-src-redirect-blocked.html
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadSubframe):
LayoutTests:
- http/tests/security/contentSecurityPolicy/frame-src-redirect-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/frame-src-redirect-blocked.html: Added.
- 11:09 AM Changeset in webkit [138817] by
-
- 11 edits2 adds in trunk
CSP: XHR from an isolated world should bypass a page's policy.
https://bugs.webkit.org/show_bug.cgi?id=104480
Reviewed by Adam Barth.
Source/WebCore:
Connections of various types are governed by the page's Content Security
Policy 'connect-src' directive. In the special case of connections
generated from an isolated world, we'd like to bypass these restrictions
in order to allow things like extensions to enjoy their uniquely high-
privilege lifestyle. This patch does just that.
We'll lock them down to their own policy in webkit.org/b/104520, but
that's a bit far away at the moment. Soon!
Test: http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr.html
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
- page/EventSource.cpp:
(WebCore::EventSource::create):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
Check whether or not code is running in an isolated world that has
its own Content Security Policy. If so, bypass the main world's CSP
checks. Isolated worlds gotta be free, man.
LayoutTests:
- http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr-expected.txt: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr.html: Added.
A new test! How wonderful!
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
Skipping the new test on ports that don't support it.
- 11:02 AM Changeset in webkit [138816] by
-
- 4 edits1 move in trunk
CSS3 calc: mixed percent/absolute for border-radius
https://bugs.webkit.org/show_bug.cgi?id=106046
Reviewed by Ojan Vafai.
Source/WebCore:
Add the calculation evaluation to the border radius code.
Test: css3/calc/border-radius.html
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyBorderRadius::applyValue):
LayoutTests:
- css3/calc/border-radius-expected.html: Renamed from LayoutTests/css3/calc/border-radius-expected-mismatch.html.
- css3/calc/border-radius.html:
- 10:44 AM Changeset in webkit [138815] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Again updating baseline for editing/deleting/delete-to-select-table.html.
- platform/gtk/editing/deleting/delete-to-select-table-expected.txt:
- 10:39 AM Changeset in webkit [138814] by
-
- 10 edits27 deletes in trunk
[chromium] Remove lost-compositor-context layout tests
https://bugs.webkit.org/show_bug.cgi?id=106089
Reviewed by James Robinson.
Source/Platform:
Mark the loseCompositorContext() test function for removal.
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
Source/WebKit/chromium:
Remove the loseCompositorContext() test function.
- public/WebView.h:
(WebView):
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
(WebViewImpl):
Tools:
Remove the loseCompositorContext() test function.
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
LayoutTests:
Better test coverage for these issues is now provided by the unit tests
in the compositor's cc/layer_tree_host_unittest_context.cc file.
- platform/chromium-linux-x86/platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Removed.
- platform/chromium-linux/platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-permanently-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-twice-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Removed.
- platform/chromium-mac/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Removed.
- platform/chromium/compositing/lost-compositor-context-expected.png: Removed.
- platform/chromium/compositing/lost-compositor-context-expected.txt: Removed.
- platform/chromium/compositing/lost-compositor-context-permanently-expected.png: Removed.
- platform/chromium/compositing/lost-compositor-context-permanently-expected.txt: Removed.
- platform/chromium/compositing/lost-compositor-context-permanently.html: Removed.
- platform/chromium/compositing/lost-compositor-context-twice-expected.png: Removed.
- platform/chromium/compositing/lost-compositor-context-twice-expected.txt: Removed.
- platform/chromium/compositing/lost-compositor-context-twice.html: Removed.
- platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Removed.
- platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.txt: Removed.
- platform/chromium/compositing/lost-compositor-context-with-rendersurface.html: Removed.
- platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Removed.
- platform/chromium/compositing/lost-compositor-context-with-video-expected.txt: Removed.
- platform/chromium/compositing/lost-compositor-context-with-video.html: Removed.
- platform/chromium/compositing/lost-compositor-context.html: Removed.
- platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Removed.
- platform/chromium/compositing/webgl-loses-compositor-context-expected.txt: Removed.
- platform/chromium/compositing/webgl-loses-compositor-context.html: Removed.
- 10:34 AM Changeset in webkit [138813] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. fast/repaint/japanese-rl-selection-repaint-in-regions.html
has image-only failures on SnowLeopard and Lion.
- platform/chromium/TestExpectations:
- 10:32 AM Changeset in webkit [138812] by
-
- 2 edits in trunk/Source/WebCore
Early out from FontCache::releaseFontData if cached font data not found.
https://bugs.webkit.org/show_bug.cgi?id=106104
Patch by John Mellor <johnme@chromium.org> on 2013-01-04
Reviewed by Abhishek Arya.
No tests, as no change in behavior.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::releaseFontData):
Early out in release builds if cached font data not found.
- 10:24 AM Changeset in webkit [138811] by
-
- 74 edits in trunk
Remove ENABLE_MUTATION_OBSERVERS #define
https://bugs.webkit.org/show_bug.cgi?id=105459
Reviewed by Ryosuke Niwa.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
The flag has been on by default for quite awhile now (nearly a year)
and the feature is a standardized part of DOM4.
The only place it was disabled was under "unstable" features for the
gtk port, but the fact that it's shipping in several major WebKit
browsers as well as Firefox suggests that it's not too unstable.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am: Removed ENABLE_MUTATION_OBSERVERS from the "unstable features" list.
- GNUmakefile.features.am.in:
- bindings/js/JSDictionary.cpp:
(WebCore):
(WebCore::JSDictionary::convertValue):
- bindings/js/JSDictionary.h:
- bindings/js/JSMainThreadExecState.cpp:
(WebCore::JSMainThreadExecState::didLeaveScriptContext):
- bindings/js/JSMutationCallbackCustom.cpp:
- bindings/js/JSMutationObserverCustom.cpp:
- bindings/v8/V8GCController.cpp:
- bindings/v8/V8RecursionScope.cpp:
(WebCore::V8RecursionScope::didLeaveScriptContext):
- bindings/v8/custom/V8MutationCallbackCustom.cpp:
- bindings/v8/custom/V8MutationObserverCustom.cpp:
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
- dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):
- dom/ChildListMutationScope.cpp:
- dom/ChildListMutationScope.h:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::willRemoveChild):
(WebCore::willRemoveChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::updateTreeAfterInsertion):
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(Document):
- dom/Element.cpp:
(WebCore::Element::willModifyAttribute):
- dom/MutationCallback.h:
- dom/MutationCallback.idl:
- dom/MutationObserver.cpp:
- dom/MutationObserver.h:
- dom/MutationObserver.idl:
- dom/MutationObserverInterestGroup.cpp:
- dom/MutationObserverInterestGroup.h:
- dom/MutationObserverRegistration.cpp:
- dom/MutationObserverRegistration.h:
- dom/MutationRecord.cpp:
- dom/MutationRecord.h:
- dom/MutationRecord.idl:
- dom/Node.cpp:
(WebCore::Node::clearRareData):
(WebCore::Node::setTextContent):
(WebCore::Node::didMoveToNewDocument):
(WebCore::Node::notifyMutationObserversNodeWillDetach):
- dom/Node.h:
(Node):
- dom/NodeRareData.cpp:
(SameSizeAsNodeRareData):
(WebCore::NodeRareData::reportMemoryUsage):
- dom/NodeRareData.h:
(NodeRareData):
(WebCore::NodeRareData::ensureTransientMutationObserverRegistry):
- editing/markup.cpp:
(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):
- page/DOMWindow.idl:
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/chromium:
- features.gypi:
- src/WebKit.cpp:
(WebKit::initialize):
(WebKit::shutdown):
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::deliverAllMutationsIfNecessary):
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::deliverAllMutationsIfNecessary):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
LayoutTests:
Remove references to ENABLE(MUTATION_OBSERVERS) from tests.
- fast/dom/MutationObserver/cross-document.html:
- fast/dom/MutationObserver/database-callback-delivery.html:
- fast/dom/MutationObserver/disconnect-cancel-pending.html:
- fast/dom/MutationObserver/filesystem-callback-delivery.html:
- fast/dom/MutationObserver/mutation-observer-constructor.html:
- fast/dom/MutationObserver/observe-attributes.html:
- fast/dom/MutationObserver/observe-characterdata.html:
- fast/dom/MutationObserver/observe-childList.html:
- fast/dom/MutationObserver/observe-exceptions.html:
- fast/dom/MutationObserver/observe-subtree.html:
- fast/dom/MutationObserver/takeRecords.html:
- 10:20 AM Changeset in webkit [138810] by
-
- 3 edits in trunk/Tools
Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
https://bugs.webkit.org/show_bug.cgi?id=106078
Reviewed by Tony Chang.
This patch updates values for individual iterations in dummy performance tests used in
perftest_unittest.py and perftest_integrationtest.py so that they match up with
statistics such as stdev and median reported in those tests. This change is required
to resolve the bug 97510.
This patch also refactors integration tests by extracting *TestData classes that
centralizes the definitions of each dummy performance test's text (DRT output),
runner output, and parsed results (JSON) so that we may share more data between
python tests.
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest._assert_results_are_correct): Extracted from test_parse_output.
Use self.assertAlmostEqual when comparing the standard deviation.
(MainTest.test_parse_output):
(test_parse_output_with_failing_line):
(test_parse_output_with_description): Use _assert_results_are_correct.
(test_parse_output_with_subtests): Ditto.
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(InspectorPassTestData): Extracted from tests below.
(EventTargetWrapperTestData): Ditto.
(SomeParserTestData): Ditto.
(MemoryTestData): Ditto.
(TestDriver.run_test): Moved test definitions out of the method.
(MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
(MainTest._load_output_json): Extracted from create_runner.
(MainTest.create_runner):
(MainTest.test_run_test_set_for_parser_tests):
(MainTest.test_run_memory_test):
(MainTest._test_run_with_json_output):
(MainTest.test_run_with_json_output):
(MainTest.test_run_with_description):
(MainTest.test_run_generates_json_by_default):
(MainTest.test_run_merges_output_by_default):
(MainTest.test_run_respects_reset_results):
(MainTest.test_run_generates_and_show_results_page):
(MainTest.test_run_with_slave_config_json):
(MainTest.test_run_with_multiple_repositories):
- 9:59 AM Changeset in webkit [138809] by
-
- 6 edits in trunk/Source/WebCore
Change RenderLayerBacking::nameForLayer() to RenderLayer::name()
https://bugs.webkit.org/show_bug.cgi?id=105648
Reviewed by Simon Fraser.
No new tests. For debugging only.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::name):
(WebCore):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::updateForegroundLayer):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
- 9:58 AM Changeset in webkit [138808] by
-
- 8 edits in trunk
Existence of window.Touch can break websites mobile device detection
https://bugs.webkit.org/show_bug.cgi?id=106071
Source/WebCore:
Patch by Rick Byers <rbyers@chromium.org> on 2013-01-04
Reviewed by Ojan Vafai.
Revert http://trac.webkit.org/changeset/135562 for now while I work
on a slightly safer version.
- page/DOMWindow.idl:
LayoutTests:
Revert http://trac.webkit.org/changeset/135562 for now while I work
on a slightly safer version.
Patch by Rick Byers <rbyers@chromium.org> on 2013-01-04
Reviewed by Ojan Vafai.
- fast/events/touch/document-create-touch-list-expected.txt:
- fast/events/touch/script-tests/document-create-touch-list.js:
- platform/efl/fast/js/global-constructors-expected.txt:
- platform/qt-5.0/fast/js/global-constructors-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 9:47 AM Changeset in webkit [138807] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening, unskip a now passing test.
- platform/qt-5.0-wk2/TestExpectations:
- 9:41 AM Changeset in webkit [138806] by
-
- 4 edits in trunk
[GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
https://bugs.webkit.org/show_bug.cgi?id=106045
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-01-04
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Be more selective about when to confirm WebKit compositions. If there is no current
preedit, reseting the GTK+ context shouldn't also do an empty confirmation in WebKit,
as this will trash the current selection. The second part of this patch also makes the
m_composingTextCurrently member more accurately reflect whether or not we are composing
text.
- platform/gtk/GtkInputMethodFilter.cpp:
(WebCore::GtkInputMethodFilter::notifyMouseButtonPress): Only confirm the current WebKit composition
if we have a preedit.
(WebCore::GtkInputMethodFilter::notifyFocusedOut): Ditto.
(WebCore::GtkInputMethodFilter::sendCompositionAndPreeditWithFakeKeyEvents): Don't clear the m_composingTextCurrently
member if we are not sending a confirmed composition.
Tools:
Update test results to confirm that compositions without preedits do not trigger
a composition confirmation.
- TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
(TestWebKitAPI::verifyCanceledComposition):
- 9:30 AM Changeset in webkit [138805] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Handle re-entrant destruction of MediaPlayerPrivate while a dialog is up
https://bugs.webkit.org/show_bug.cgi?id=105906
Patch by Max Feil <mfeil@rim.com> on 2013-01-04
Reviewed by George Staikos.
Now that dialogs are not truly modal anymore, we need to
handle the case where MediaPlayerPrivate gets destroyed by
re-entrant calls while a dialog is up. We do this by deferring
the destruction of MMRPlayer until the user dismisses the dialog.
No new tests because user dialog input is not yet part of the
layouttest framework.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
(WebCore::MediaPlayerPrivate::onShowErrorDialog):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
- 9:16 AM Changeset in webkit [138804] by
-
- 4 edits in trunk/Source
[Blackberry] Static code analysis warning fixes
https://bugs.webkit.org/show_bug.cgi?id=105679
Patch by Anthony Scian <ascian@rim.com> on 2013-01-04
Reviewed by Rob Buis.
Source/WebCore:
klocwork 1855: fixed by caching page, check against NULL and use cached value
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::determineFullScreenMultiplier):
Source/WebKit/blackberry:
Klocwork issue 959: check layer against NULL since it is used in both cases
of the subsequent if-stmt
- Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
- 9:14 AM Changeset in webkit [138803] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] [Gtk] crash when web inspector is attached, and window height is reduced.
https://bugs.webkit.org/show_bug.cgi?id=106052
Reviewed by Martin Robinson.
Do not allocate more size for the inspector view than its parent
size. Also make sure that the view size is always at least 1.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(resizeWebKitWebViewBaseFromAllocation):
- 8:58 AM Changeset in webkit [138802] by
-
- 3 edits in trunk/Source/WebCore
[CSS Exclusions] The ExclusionPolygon classes should allow more than one type of "Edge" class
https://bugs.webkit.org/show_bug.cgi?id=106026
Patch by Hans Muller <hmuller@adobe.com> on 2013-01-04
Reviewed by Dirk Schulze.
Refactored the ExclusionPolygonEdge class to pave the way for a similar
OffsetEdge class. The new VertexPair abstract base class provides the common
state and operations. ExclusionPolygonEdge now extends VertexPair and defines
ExclusionPolygon as a friend, since the ExclusionPolygon constructor initializes
its private state.
- rendering/ExclusionPolygon.cpp:
(WebCore::ExclusionPolygon::ExclusionPolygon): Use ExclusionPolygonEdge accessors instead of direct field access.
(WebCore::getVertexIntersectionVertices): Ditto.
- rendering/ExclusionPolygon.h:
(VertexPair): New abstract base class.
(WebCore::VertexPair::~VertexPair):
(WebCore::VertexPair::minX): This method was defined in ExclusionPolygonEdge.
(WebCore::VertexPair::minY): Ditto.
(WebCore::VertexPair::maxX): Ditto.
(WebCore::VertexPair::maxY): Ditto.
(ExclusionPolygonEdge): Now extends VertexPair.
(WebCore::ExclusionPolygonEdge::previousEdge): Refer to m_ private class fields, instead of public struct fields.
(WebCore::ExclusionPolygonEdge::nextEdge): Ditto.
(WebCore::ExclusionPolygonEdge::polygon): Ditto.
(WebCore::ExclusionPolygonEdge::vertexIndex1): Ditto.
(WebCore::ExclusionPolygonEdge::vertexIndex2): Ditto.
(WebCore::ExclusionPolygonEdge::edgeIndex): Ditto.
- 8:35 AM Changeset in webkit [138801] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip a new failing test.
- platform/qt/TestExpectations:
- 8:14 AM Changeset in webkit [138800] by
-
- 6 edits in trunk/Source/WebCore
Add 'float FloatPoint::slopeAngleRadians()'
https://bugs.webkit.org/show_bug.cgi?id=105997
Patch by Steve Block <steveblock@chromium.org> on 2013-01-04
Reviewed by Stephen White.
Refactoring only, no functional change.
- platform/graphics/FloatPoint.cpp:
(WebCore::FloatPoint::slopeAngleRadians):
(WebCore):
- platform/graphics/FloatPoint.h:
Add 'float FloatPoint::slopeAngleRadians() const'
- platform/graphics/PathTraversalState.cpp:
(WebCore::PathTraversalState::processSegment):
- rendering/svg/SVGMarkerData.h:
(WebCore::SVGMarkerData::currentAngle):
- svg/SVGPathParser.cpp:
(WebCore::SVGPathParser::decomposeArcToCubic):
- 7:55 AM Changeset in webkit [138799] by
-
- 2 edits3 adds in trunk/LayoutTests
Unreviewed gardening. New image baselines for test
fast/regions/full-screen-video-from-region.html
- platform/chromium-mac-snowleopard/fast/regions/full-screen-video-from-region-expected.png: Added.
- platform/chromium-mac/fast/regions/full-screen-video-from-region-expected.png:
- platform/chromium-win-xp/fast/regions/full-screen-video-from-region-expected.png: Added.
- 7:37 AM Changeset in webkit [138798] by
-
- 29 edits in trunk/Source/WebKit/chromium
[Chromium] Update some #includes to use headers in the new Platform directory
https://bugs.webkit.org/show_bug.cgi?id=106092
Reviewed by Kentaro Hara.
Working towards getting rid of legacy header files in
WebKit/chromium/public/ and WebKit/chromium/public/platform/
- src/AsyncFileSystemChromium.cpp:
- src/StorageAreaProxy.cpp:
- src/StorageNamespaceProxy.cpp:
- src/WebFileSystemCallbacksImpl.cpp:
- src/WebGraphicsContext3D.cpp:
- src/WebIDBCursorImpl.h:
- src/WebIDBDatabaseCallbacksImpl.cpp:
- src/WebIDBDatabaseCallbacksImpl.h:
- src/WebIDBDatabaseError.cpp:
- src/WebIDBDatabaseImpl.h:
- src/WebIDBIndexImpl.h:
- src/WebIDBKeyPath.cpp:
- src/WebIDBMetadata.cpp:
- src/WebIDBObjectStoreImpl.h:
- src/WebWorkerClientImpl.cpp:
- src/WebWorkerRunLoop.cpp:
- src/WorkerFileSystemCallbacksBridge.cpp:
- tests/AssociatedURLLoaderTest.cpp:
- tests/FrameTestHelpers.cpp:
- tests/PopupMenuTest.cpp:
- tests/URLTestHelpers.cpp:
- tests/WebFrameTest.cpp:
- tests/WebPageNewSerializerTest.cpp:
- tests/WebPageSerializerTest.cpp:
- tests/WebURLRequestTest.cpp:
- tests/WebURLResponseTest.cpp:
- tests/WebUnitTests.h:
- tests/WebViewTest.cpp:
- 7:25 AM Changeset in webkit [138797] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining an editing test after r138654.
Adding failure expectations for two tests added in r138632.
Add a temporary failure expectation for transitions/transitions-parsing.html,
the test is fixed but just requires a clean build. It shouldn't paint the bots
red until then.
- platform/gtk/TestExpectations:
- platform/gtk/editing/deleting/delete-to-select-table-expected.txt: Added.
- 6:43 AM WebKitGTK/WebKit2Roadmap edited by
- Add color chooser API (diff)
- 6:37 AM Changeset in webkit [138796] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-04
- DEPS:
- 6:15 AM Changeset in webkit [138795] by
-
- 6 edits in trunk
REGRESSION (r138184): transitions/transitions-parsing.html is failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=105522
Reviewed by Xan Lopez.
.:
Remove the configuration flag covering unprefixed CSS transition property names.
It does not introduce any dependency. The unprefixed property names should be
available by default.
- configure.ac:
Source/WebCore:
Remove the feature define overriding for the unprefixed CSS transition property names
define as it is not required.
No new tests - no new functionality.
- GNUmakefile.am:
LayoutTests:
Remove a failure expectation for a test that's now passing.
- platform/gtk/TestExpectations:
- 6:13 AM Changeset in webkit [138794] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip new failing tests introduced in r138632 and r138756.
- platform/efl/TestExpectations:
- 6:13 AM Changeset in webkit [138793] by
-
- 2 edits in trunk/Source/WebCore
[GObject bindings] Wrap event target interface code in feature define guards if necessary
https://bugs.webkit.org/show_bug.cgi?id=105743
Reviewed by Xan Lopez.
Wrap the event target interface implementation code in feature define guards if the interface
is guarded by a conditional. A warning is reported if these methods get called with the specific
feature being disabled.
This was spotted when building with the video track feature disabled was causing build failures.
No new tests - no new functionality. The bindings tests don't test event targets under conditionals.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateEventTargetIface):
- 6:03 AM Changeset in webkit [138792] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline editing/deleting/delete-to-select-table.html.
- platform/efl/editing/deleting/delete-to-select-table-expected.png:
- platform/efl/editing/deleting/delete-to-select-table-expected.txt: Added.
- 5:24 AM Changeset in webkit [138791] by
-
- 5 edits in trunk/Source/WebKit2
[GTK][Qt] Make compositing messages async again
https://bugs.webkit.org/show_bug.cgi?id=106082
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-01-04
Reviewed by Simon Hausmann.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::cancelComposition):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::confirmComposition):
(WebKit::WebPage::setComposition):
(WebKit::WebPage::cancelComposition):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/WebPage.messages.in:
- 4:50 AM Changeset in webkit [138790] by
-
- 2 edits in trunk/Source/WebKit2
Regression(r138728): Causes crashes on the build bots
https://bugs.webkit.org/show_bug.cgi?id=106083
Reviewed by Simon Hausmann.
Update encodeTimingFunction() to encode the x/y members only
if the bezierPreset is set to custom. This is needed because
decodeTimingFunction() only decodes x/y members if the
bezierPreset is set to custom.
This fixes assertion hits on the debug build bots.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::encodeTimingFunction):
- 4:09 AM Changeset in webkit [138789] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark test webaudio/codec-tests/mp3/128kbps-44khz.html as Missing.
- platform/efl/TestExpectations:
- 3:38 AM Changeset in webkit [138788] by
-
- 5 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline 2 media/track test cases after r138784.
- platform/efl/media/track/track-cue-rendering-horizontal-expected.png:
- platform/efl/media/track/track-cue-rendering-horizontal-expected.txt:
- platform/efl/media/track/track-cue-rendering-vertical-expected.png:
- platform/efl/media/track/track-cue-rendering-vertical-expected.txt:
- 2:19 AM Changeset in webkit [138787] by
-
- 4 edits in trunk
[Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
https://bugs.webkit.org/show_bug.cgi?id=105958
Patch by Sailesh Agrawal <sail@chromium.org> on 2013-01-04
Reviewed by Alexey Proskuryakov.
Tools:
Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
- WebKitTestRunner/mac/EventSenderProxy.mm:
(KeyMappingEntry):
(WTR):
(WTR::EventSenderProxy::keyDown): Added all numpad keys.
LayoutTests:
Fixed numpad-keycode-mapping.html failure in WebKitTestRunner.
- platform/mac-wk2/TestExpectations:
- 2:14 AM Changeset in webkit [138786] by
-
- 9 edits in trunk/Source/WebCore
[GStreamer] Port WebAudio backend to 1.0 APIs
https://bugs.webkit.org/show_bug.cgi?id=105293
Reviewed by Martin Robinson.
Port the AudioFileReader and AudioDestination to GStreamer 1.0
APIs. It would be preferable to rely on at least GStreamer 1.0.4
for this to work properly as that release contains two bug fixes
for the deinterleave and interleave elements.
- platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::reportMemoryUsage): Don't report GstFFTF32
structures anymore because they're opaque in GStreamer 1.0.
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
The wavparse element in 1.0 has no sometimes-pads anymore.
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(AudioFileReader): The decodebin2 element has been renamed to
decodebin in GStreamer 1.0.
(WebCore::getGStreamerAudioCaps): Audio caps description changed a
lot in GStreamer 1.0, the function now handles both APIs.
(WebCore::copyGstreamerBuffersToAudioChannel): Adapted to
GstBufferList and GstBuffer API changes.
(WebCore::onAppsinkPullRequiredCallback): Pull a sample or buffer,
depending on which API we use.
(WebCore::AudioFileReader::~AudioFileReader): Protect
GstBufferListIterators in 0.10-only code path.
(WebCore):
(WebCore::AudioFileReader::handleSample): Pull an audio sample
from appsink and insert it in the appropriate buffer list.
(WebCore::AudioFileReader::handleNewDeinterleavePad): Handle
appsink API changes from GStreamer 0.10 to 1.0.
(WebCore::AudioFileReader::decodeAudioForBusCreation): Create the
correct decodebin element.
(WebCore::AudioFileReader::createBus): Protect GstBufferListIterators
in 0.10-only code path.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(_WebKitWebAudioSourcePrivate): GstTask in GStreamer 1.0 uses a
GRecMutex instead of a (deprecated) GStaticRecMutex.
(getGStreamerMonoAudioCaps): Handle caps description changes
between GStreamer 0.10 and 1.0.
(webKitWebAudioGStreamerChannelPosition): POSITION_LFE in
GStreamer 1.0 is now POSITION_LFE1. Also map ChannelCenter to its
GStreamer equivalent.
(webkit_web_audio_src_class_init): Use generic setGstElementClassMetadata.
(webkit_web_audio_src_init): Handle GRecMutex initialisation.
(webKitWebAudioSrcConstructed): Set channel position on
capsfilter. This is done for GStreamer 1.0 code path only because
in 0.10 the caps have no way to store this information.
(webKitWebAudioSrcFinalize): Clear GRecMutex.
(webKitWebAudioSrcLoop): Handle GstBuffer API changes and add an
error check if buffers can't be chained to queue's source pad.
(webKitWebAudioSrcChangeState): As advised in the GStreamer docs,
fixup the state changes for this live source element: NO_PREROLL
in READY->PAUSED and start/stop the GstTask when going/coming
to/from PLAYING.
- 2:13 AM Changeset in webkit [138785] by
-
- 4 edits8 adds in trunk
[CSS Regions]Content overflowing last region displayed wrong
https://bugs.webkit.org/show_bug.cgi?id=105893
Reviewed by David Hyatt.
Source/WebCore:
For the last region in the region chain and flipped writing modes (horizontal-bt, vertical-rl),
the clipping rect should take overflow into account in the writing mode direction, which is
different in these cases than the direction for non-flipped writing modes.
Tests: fast/regions/overflow-last-region-horiz-bt.html
fast/regions/overflow-last-region-vert-lr.html
fast/regions/overflow-last-region-vert-rl.html
fast/regions/overflow-last-region.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeRegionClippingRect): Helper function used to compute region clipping rect
for paint and hitTest.
(WebCore):
(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
- rendering/RenderFlowThread.h:
LayoutTests:
Add tests for all writing modes with content overflowing the last region in chain.
Hit testing for content overflowing the last region is not yet supported, therefore tests
for that will be added in the future.
- fast/regions/overflow-last-region-expected.html: Added.
- fast/regions/overflow-last-region-horiz-bt-expected.html: Added.
- fast/regions/overflow-last-region-horiz-bt.html: Added.
- fast/regions/overflow-last-region-vert-lr-expected.html: Added.
- fast/regions/overflow-last-region-vert-lr.html: Added.
- fast/regions/overflow-last-region-vert-rl-expected.html: Added.
- fast/regions/overflow-last-region-vert-rl.html: Added.
- fast/regions/overflow-last-region.html: Added.
- 1:15 AM Changeset in webkit [138784] by
-
- 21 edits3 deletes in trunk
Implement :future pseudo class for the WebVTT ::cue pseudo element
https://bugs.webkit.org/show_bug.cgi?id=105473
Patch by Dima Gorbik <dgorbik@apple.com> on 2013-01-04
Reviewed by Antti Koivisto.
Source/WebCore:
This patch changes the approach of showing past/future node objects.
Before upper-level containers were used to put past and future nodes inside. Styles were applied
to containers. Now styles could be applied directly to nodes by using ::cue(:future).
That allows to style future/past WebVTT nodes even if they are nested.
Existing test was modified to cover new cases.
- css/CSSSelector.cpp: added :future pseudo class support.
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
- css/CSSSelector.h:
- css/SelectorChecker.cpp: ditto.
(WebCore::SelectorChecker::checkOneSelector):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement): define style sharing rules for WebVTT objects.
- css/mediaControls.css:
(video::-webkit-media-text-track-all-nodes):
(video::cue(:future)): added standard user-agent styles for the future nodes.
- dom/Element.cpp: setter functions don't have an argument now because WebVTT type enum was introduced and the right type is set
when the setter is being called.
(WebCore::Element::setIsWebVTTNode):
(WebCore):
(WebCore::Element::isWebVTTFutureNode):
(WebCore::Element::setIsWebVTTFutureNode):
- dom/Element.h:
(Element):
- dom/ElementRareData.h:
(ElementRareData):
- dom/NodeRareData.cpp:
(SameSizeAsNodeRareData): added a dummy enum value. Enum is integer type and is aligned in Windows when placed in the bitfield,
so it takes more space.
- dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::isWebVTTNode):
(WebCore::NodeRareData::setIsWebVTTNode):
(WebCore::NodeRareData::isWebVTTFutureNode):
(WebCore::NodeRareData::setIsWebVTTFutureNode):
(NodeRareData):
- html/shadow/MediaControlElements.cpp:
(WebCore):
- html/track/TextTrack.h: add a WebVTT node object type enum.
(TextTrack):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::allNodesShadowPseudoId):
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::getCueAsHTML):
(WebCore):
(WebCore::TextTrackCue::setNodeObjectFlags): determine if the node is future or past and mark as WebVTT node.
This combines the functionality related to marking nodes implemented before in updateDisplayTree and
markNodesAsWebVTTNodes.
(WebCore::TextTrackCue::updateDisplayTree):
(WebCore::TextTrackCue::getDisplayTree):
- html/track/TextTrackCue.h:
(TextTrackCue):
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken): no need to mark nodes as WebVTT nodes when parsing. This is done at the
rendering stage later.
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): the container name has changed.
LayoutTests:
Modified the track css matching test to cover :future pseudo-class case.
- media/track/captions-webvtt/captions-inner-timestamps.vtt: Removed.
- media/track/captions-webvtt/styling.vtt:
- media/track/track-css-matching-expected.txt:
- media/track/track-css-matching.html:
- media/track/track-cue-rendering-inner-timestamps-expected.txt: Removed.
- media/track/track-cue-rendering-inner-timestamps.html: The test was removed because it was based on the old
future/past nodes rendering logic.
- 1:07 AM Changeset in webkit [138783] by
-
- 10 edits in trunk/Source/WebKit2
[SOUP] Convert WebSoupRequestManagerProxy to be WebContextSupplement
https://bugs.webkit.org/show_bug.cgi?id=106012
Reviewed by Martin Robinson.
- UIProcess/API/C/soup/WKContextSoup.cpp:
(WKContextGetSoupRequestManager):
- UIProcess/API/gtk/WebKitWebContext.cpp:
(createDefaultWebContext):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::disconnectProcess):
- UIProcess/WebContext.h:
(WebKit):
(WebContext):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveURIRequest):
- UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- UIProcess/soup/WebSoupRequestManagerProxy.cpp:
(WebKit::WebSoupRequestManagerProxy::supplementName):
(WebKit):
(WebKit::WebSoupRequestManagerProxy::WebSoupRequestManagerProxy):
(WebKit::WebSoupRequestManagerProxy::initializeClient):
(WebKit::WebSoupRequestManagerProxy::contextDestroyed):
(WebKit::WebSoupRequestManagerProxy::processDidClose):
(WebKit::WebSoupRequestManagerProxy::refWebContextSupplement):
(WebKit::WebSoupRequestManagerProxy::derefWebContextSupplement):
(WebKit::WebSoupRequestManagerProxy::registerURIScheme):
(WebKit::WebSoupRequestManagerProxy::didHandleURIRequest):
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequestData):
- UIProcess/soup/WebSoupRequestManagerProxy.h:
(WebSoupRequestManagerProxy):
- 1:03 AM Changeset in webkit [138782] by
-
- 5 edits in trunk
REGRESSION (r138222?): Assertion failure on appcache/main-resource-redirect.html
https://bugs.webkit.org/show_bug.cgi?id=105591
Reviewed by Brady Eidson.
Source/WebCore:
Fixes crash in test http/tests/appcache/main-resource-redirect.html.
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::willSendRequest): In case of loading
substitute data from application cache host due to a redirect,
make sure the substitute data identifier is initialized.
LayoutTests:
Unskip http/tests/appcache/main-resource-redirect.html.
- platform/efl-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 12:29 AM Changeset in webkit [138781] by
-
- 3 edits in trunk/Tools
REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
https://bugs.webkit.org/show_bug.cgi?id=106073
Reviewed by Ryosuke Niwa.
Check that the element being compared to is not nil.
This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it
sometimes before on parallel WebKitTestRunner runs.
- DumpRenderTree/AccessibilityUIElement.cpp:
(AccessibilityUIElement::isEqual):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::isEqual):
- 12:04 AM Changeset in webkit [138780] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Remove unneeded EwkViewImpl::informLoadCommitted()
https://bugs.webkit.org/show_bug.cgi?id=106010
Reviewed by Gyuyoung Kim.
Removed EwkViewImpl::informLoadCommitted() method to simplify the code.
- UIProcess/API/efl/EwkViewImpl.cpp:
- UIProcess/API/efl/EwkViewImpl.h:
- UIProcess/efl/PageClientBase.h:
(PageClientBase):
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
