⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 10, 2013:

11:54 PM Changeset in webkit [139412] by g.czajkowski@samsung.com
  • 9 edits in trunk

On Linux, should be able to get spelling suggestions without selecting the misspelled word
​https://bugs.webkit.org/show_bug.cgi?id=103520

Reviewed by Ryosuke Niwa.

Source/WebCore:

Allow to get/insert spelling suggestions without selecting the misspelled word for
Linux WebKit ports. WebCore assumes that the misspelled word has to be selected
to get its suggestions.

In compliance with native application behaviour a new editing policy is introduced,
to do not highlight the misspelled word to just get its guesses.

No new tests, covered by context-menu-suggestions.html.

  • WebCore.exp.in:

Remove _ZN7WebCore6Editor21isSelectionMisspelledEv symbol as Mac port doesn't
need it any longer.

  • editing/EditingBehavior.h:

(EditingBehavior):
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
Add a new behavior for Linux, to allow spelling suggestions without selecting
the misspelled word.

  • editing/Editor.cpp:

(WebCore::Editor::isContinuousSpellCheckingEnabled):
Add missing const modifier, to use this method in 'misspelledWordAtCaretOrRange() const'.

(WebCore::Editor::misspelledWordAtCaretOrRange):
Allow to check spelling under the caret or selected word.
Does nothing for selection made on the multiple words.

(WebCore::Editor::misspelledSelectionString):
Return the misspelled selection.

(WebCore::Editor::guessesForMisspelledWord):
Remove 'Selection' from method name as it may return guesses without selection.

(WebCore::Editor::guessesForMisspelledOrUngrammatical):
Ditto.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
Select the word under caret to meet the conditions from misspelledWordAtCaretOrRange.

(WebCore::ContextMenuController::populate):
Update guessesForMisspelledOrUngrammatical call.

LayoutTests:

  • platform/efl/TestExpectations:

Unskip context-menu-suggestions.html for WebKit-EFL as it passes now.

  • platform/gtk/TestExpectations:

Update failing reason.

11:44 PM Changeset in webkit [139411] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Disable PNG and ICO image webkit-unit-tests after r139347
​https://bugs.webkit.org/show_bug.cgi?id=106631

Reviewed by Eric Seidel.

  • tests/WebImageTest.cpp:

(WebKit::TEST): Disable ICOImage and PNGImage tests on WIN and MAC to
green their respective webkit-unit-test bots. The tests still pass on
LINUX so keep test coverage there for now.

11:39 PM Changeset in webkit [139410] by morrita@google.com
  • 11 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=106283
[Shadow DOM] HTMLContentElement and HTMLShadowElement should be behind SHADOW_DOM

Reviewed by Kentaro Hara.

No new tests. Covered by existing tests.

This change moves <content> and <shadow> behind
ENABLE(SHADOW_DOM). Note that empty stub definitions are remaining
even after this change. They are for minimizing #if/#endif usage
and won't hurt code size.

  • WebCore.exp.in:
  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute):

  • html/shadow/HTMLContentElement.cpp:

(WebCore):
(WebCore::HTMLContentElement::create):
(WebCore::HTMLContentElement::HTMLContentElement):

  • html/shadow/HTMLContentElement.h:

(WebCore):
(HTMLContentElement):

  • html/shadow/HTMLShadowElement.cpp:
  • html/shadow/HTMLShadowElement.h:

(WebCore):
(WebCore::isHTMLShadowElement):
(WebCore::toHTMLShadowElement):

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::decorate):

  • testing/Internals.cpp:

(WebCore::Internals::createContentElement):
(WebCore::Internals::isValidContentSelect):

11:08 PM Changeset in webkit [139409] by tasak@google.com
  • 13 edits
    1 copy
    1 add in trunk/Source/WebCore

Implement CSSGroupingRule for @host @-rules and @supports.
​https://bugs.webkit.org/show_bug.cgi?id=106418

Reviewed by Antti Koivisto.

CSSGroupingRule is to share code between CSSMediaRule, CSSSupportsRule
and CSSHostRule. @supports and @host @-rules are dervied from
CSSGroupingRule:
​http://www.w3.org/TR/2012/WD-css3-conditional/#the-cssgroupingrule-interface
​https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#css-host-rule-interface
Since @media is also derived from CSSGroupingRule and @region has the
same interface as CSSGroupingRule, modify to use CSSGroupingRule:
​http://dev.w3.org/csswg/css3-regions/#the-at-region-style-rule

No new tests, because no new feature is implemented.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added CSSGroupingRule.h and CSSGroupingRule.cpp.

  • css/CSSAllInOne.cpp:

Modified to include CSSGroupingRule.cpp.

  • css/CSSGroupingRule.cpp: Added.

(WebCore):
(WebCore::CSSGroupingRule::CSSGroupingRule):
(WebCore::CSSGroupingRule::~CSSGroupingRule):
(WebCore::CSSGroupingRule::insertRule):
(WebCore::CSSGroupingRule::deleteRule):
(WebCore::CSSGroupingRule::appendCssTextForItems):
(WebCore::CSSGroupingRule::length):
(WebCore::CSSGroupingRule::item):
(WebCore::CSSGroupingRule::cssRules):
(WebCore::CSSGroupingRule::reattach):
(WebCore::CSSGroupingRule::reportMemoryUsage):
These codes are moved from CSSMediaRule and WebKitCSSRegionRule.

  • css/CSSGroupingRule.h:

(WebCore):
(CSSGroupingRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
Make CSSMediaRule inherit CSSGroupingRule.
(WebCore::CSSMediaRule::media):
(WebCore::CSSMediaRule::reattach):
Keep the code for updating media queries' CSSOMWrapper.
(WebCore::CSSMediaRule::reportMemoryUsage):
We need to report media queries' CSSOMWrapper memory usage.
(WebCore::CSSMediaRule::mediaQueries):
(WebCore::CSSMediaRule::cssText):

  • css/CSSMediaRule.h:
  • css/WebKitCSSRegionRule.cpp:

Make WebKitCSSRegionRule inherit CSSGroupingRule.
(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::cssText):

  • css/WebKitCSSRegionRule.h:
  • css/StyleRule.h:

Added inlined accessor to obtain StyleRuleMedia* and StyleRuleRegion*
from StyleRuleBlock*.

10:57 PM Changeset in webkit [139408] by aandrey@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: [Canvas] add an option to reload the page if there is an uninstrumented canvas
​https://bugs.webkit.org/show_bug.cgi?id=105822

Reviewed by Pavel Feldman.

Show in the front-end an option to reload the page if there is an uninstrumented canvas.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileType):
(WebInspector.CanvasProfileType.prototype.decorationElement):
(WebInspector.CanvasProfileType.prototype._updateDecorationElement):
(WebInspector.CanvasProfileType.prototype._onReloadPageButtonClick):

  • inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView.prototype.addProfileType):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.decorationElement):

10:22 PM Changeset in webkit [139407] by rniwa@webkit.org
  • 2 edits in trunk/Tools

kill-old-processes and delete-stale-build-files use CRLF linebreaks
​https://bugs.webkit.org/show_bug.cgi?id=106622

Reviewed by Simon Fraser.

Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
Also escape clang\+\+ correctly in kill-old-processes.

  • BuildSlaveSupport/delete-stale-build-files:
  • BuildSlaveSupport/kill-old-processes:
10:18 PM Changeset in webkit [139406] by Dimitri Glazkov
  • 7 edits in trunk/Source/WebCore

The word "selector" is somewhat redundant redundantly used in SelectorChecker.
​https://bugs.webkit.org/show_bug.cgi?id=106413

In ​https://bugs.webkit.org/show_bug.cgi?id=105864, Antti suggested reducing some of the redundant uses of the word
"selector" in SelectorChecker. Here's a start.

Reviewed by Antti Koivisto.

Simple renames, no change in behavior.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match): Renamed.
(WebCore):
(WebCore::SelectorChecker::fastCheck): Ditto,
(WebCore::SelectorChecker::checkOne): Ditto.

  • css/SelectorChecker.h:

(SelectorChecker):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use new name.
(WebCore::StyleResolver::ruleMatches): Renamed from checkSelector to better match argument and return value.
(WebCore::StyleResolver::checkRegionSelector): Changed to use new names.

  • css/StyleResolver.h:

(StyleResolver):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::matches): Ditto.
(WebCore::SelectorDataList::execute): Ditto.

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorChecker::checkContentSelector): Ditto.

10:17 PM Changeset in webkit [139405] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Web Inspector: Pass the script url to the script-preprocessor script
​https://bugs.webkit.org/show_bug.cgi?id=104384

Patch by John J. Barton <​johnjbarton@chromium.org> on 2013-01-10
Reviewed by Pavel Feldman.

Source/WebCore:

Add url argument to the script-preprocessor script in PageAgent.reload()

Test: inspector/debugger/debugger-script-preprocessor.html

  • bindings/v8/DebuggerScript.js:
  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptPreprocessor::ScriptPreprocessor):
(WebCore::ScriptDebugServer::ScriptPreprocessor::preprocessSourceCode):
(WebCore::ScriptDebugServer::handleV8DebugEvent):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):

LayoutTests:

Tests for Bug 80922 by Pavel Feldman <​pfeldman@chromium.org> that did not land somehow,
with additional test for Bug 104384

  • inspector/debugger/debugger-script-preprocessor-expected.txt: Added.
  • inspector/debugger/debugger-script-preprocessor.html: Added.
  • platform/chromium/inspector/debugger/debugger-script-preprocessor-expected.txt: Added.
9:49 PM Changeset in webkit [139404] by commit-queue@webkit.org
  • 7 edits in trunk

Web Inspector: DataGrid refactoring: make cell editing more generic.
​https://bugs.webkit.org/show_bug.cgi?id=105849

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-10
Reviewed by Pavel Feldman.

Source/WebCore:

Editing feature has been added to DataGrid to edit localStorage.
Column numbers (0 and 1) are hardcoded.

This patch makes column editing feature more generic: remove hardcoded
colums, take "editable" column property into account.

This patch is a prerequisite for cookie editing.

  • inspector/front-end/DOMStorageItemsView.js:

Use meaningful column names.

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._ondblclick): Check column editability.
(WebInspector.DataGrid.prototype._contextMenuInDataTable): Ditto.
(WebInspector.DataGridNode.prototype.createCell):
Supply cell element with column id.
(WebInspector.DataGrid.prototype.columnIdentifierFromNode):
Added utility method.
(WebInspector.DataGrid.prototype._nextEditableColumn): Ditto.
(WebInspector.DataGrid.prototype._keyDown): Calculate editable column.
(WebInspector.DataGrid.prototype._editingCommitted): Ditto.
(WebInspector.DataGrid.prototype._startEditing): Ditto.
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
Refined parameter type / name.
(WebInspector.DataGrid.prototype._resizerDragging):
Fix resizer index property names.
(WebInspector.DataGrid.prototype._startResizerDragging): Ditto.
(WebInspector.DataGrid.prototype._positionResizers): Ditto.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._updateDividersIfNeeded): Ditto.

LayoutTests:

  • inspector/storage-panel-dom-storage-update.html: Fix column names.
  • inspector/storage-panel-dom-storage.html: Ditto.
9:33 PM Changeset in webkit [139403] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix after r139357. It was missing a comma.

  • QueueStatusServer/model/queues.py:

(Queue):

8:46 PM Changeset in webkit [139402] by falken@chromium.org
  • 3 edits
    4 adds in trunk

Elements must be reattached when inserted/removed from top layer
​https://bugs.webkit.org/show_bug.cgi?id=105489

Reviewed by Julien Chaffraix.

Source/WebCore:

Ensure a reattach occurs when an element is inserted/removed from top layer, so its renderer can be inserted correctly:
as a child of RenderView in top layer sibling order if it's in the top layer, and in the usual place otherwise.

We previously relied on style recalc to catch when an element is inserted/removed from the top layer, because it
only happens on dialog.show/close which toggle display: none. But that is incorrect because, for example, close()
followed immediately by show() results in no style change.

Tests: fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html

fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html

  • dom/Element.cpp:

(WebCore::Element::removedFrom): Call Document::removeFromTopLayer to let the element be removed from the top layer vector.
removeFromTopLayer calls Element::setIsInTopLayer(false) itself if needed.
(WebCore::Element::setIsInTopLayer): Ensure a reattach occurs if the element is already attached.

LayoutTests:

  • fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html: Added.
  • fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html: Added.

This tests that a top layer element removed from the document does not reappear in the top layer if readded.
This test actually would pass before this patch, but just by good fortune (see bug).

  • fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html: Added.
  • fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html: Added.

This tests that top layer ordering is correct after removing and readding an element to the top layer.

8:44 PM Changeset in webkit [139401] by shinyak@chromium.org
  • 4 edits
    2 adds in trunk

When a selected node in nested ShadowDOM is deleted, selection have wrong range.
​https://bugs.webkit.org/show_bug.cgi?id=106526

Reviewed by Ryosuke Niwa.

Source/WebCore:

Since FrameSelection and htmlediting did not consider nested Shadow DOM, the FrameSelection still selects
removed elements if selected nodes in nested Shadow DOM are removed.

We have to use containsIncludingShadowDOM to handle with nested Shadow DOM correctly.

Test: fast/dom/shadow/selection-in-nested-shadow.html

  • editing/FrameSelection.cpp:

(WebCore::removingNodeRemovesPosition):

  • editing/htmlediting.cpp:

(WebCore::updatePositionForNodeRemoval):

LayoutTests:

  • fast/dom/shadow/selection-in-nested-shadow-expected.txt: Added.
  • fast/dom/shadow/selection-in-nested-shadow.html: Added.
8:00 PM Changeset in webkit [139400] by morrita@google.com
  • 10 edits in trunk/Source/WebCore

[Shadow DOM] Refactoring: InsertionPoint could simplify its subclass hooks
​https://bugs.webkit.org/show_bug.cgi?id=106614

Reviewed by Dimitri Glazkov.

This change simplifies InsertionPoint overrides and give some flexibility to it.

The change

  • Removes InsertionPoint::isSelectValid(). now ContentSelectorQuery parses given selector anyway. Invalid select attribute is handled by newly introduced matchTypeFor() method.
  • Introduces InsertionPoint::matchTypeFor() to give a chance each InsertionPoint to decide whether it accepts the given node as its distribution. Then it lets DetailsSummaryElement adopt it.
  • Pulls some HTMLShadowElement overrides up to InsertionPoint so that other upcoming InsertionPoint subclasses don't need to override them.

No new tests. Refactoring.

  • html/HTMLDetailsElement.cpp:

(WebCore::DetailsSummaryElement::DetailsSummaryElement):

  • Implemented matchTypeFor() to get rid of HTMLContentElement machinery which is compiled out in the upcoming change.

(DetailsSummaryElement):

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorQuery::ContentSelectorQuery):
(WebCore::ContentSelectorQuery::matches):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::matchTypeFor): Added.
(WebCore):

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):
(WebCore::isHTMLContentElement):

  • html/shadow/HTMLShadowElement.cpp:
  • html/shadow/HTMLShadowElement.h:

(HTMLShadowElement):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::emptySelectorList): Moved from HTMLShadowElement.
(WebCore):

  • html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::matchTypeFor): Added.
(WebCore::InsertionPoint::selectorList): Moved from HTMLShadowElement.
(InsertionPoint):

  • testing/Internals.cpp:

(WebCore::Internals::isValidContentSelect):

7:18 PM Changeset in webkit [139399] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Fixing AuthenticationError when running test-webkitpy as a non-committer.
​https://bugs.webkit.org/show_bug.cgi?id=106420

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.push_local_commits_to_server):

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVNRepository):
(SVNRepository.has_authorization_for_realm):

7:00 PM Changeset in webkit [139398] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/1364

Merge 138850
BUG=162622
Review URL: ​https://codereview.chromium.org/11856005

6:36 PM Changeset in webkit [139397] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/platform/graphics/FontCache.cpp

Merge 138812
BUG=167443
Review URL: ​https://codereview.chromium.org/11854003

6:30 PM Changeset in webkit [139396] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 138908
BUG=166324
Review URL: ​https://codereview.chromium.org/11853004

6:28 PM Changeset in webkit [139395] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 138908
BUG=166324
Review URL: ​https://codereview.chromium.org/11853003

6:19 PM Changeset in webkit [139394] by cevans@google.com
  • 2 edits in branches/chromium/1364/Source/WebCore/editing

Merge 138657
BUG=167827
Review URL: ​https://codereview.chromium.org/11851002

6:17 PM Changeset in webkit [139393] by cevans@google.com
  • 2 edits in branches/chromium/1312/Source/WebCore/editing

Merge 138657
BUG=167827
Review URL: ​https://codereview.chromium.org/11850002

6:01 PM Changeset in webkit [139392] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Plugin snapshot label should take device resolution and inset into account
​https://bugs.webkit.org/show_bug.cgi?id=106619

Reviewed by Simon Fraser.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paintLabel): Take into account the inset in the label image.
(WebCore::RenderSnapshottedPlugIn::tryToFitStartLabel): Look at the page's device scale, and adjust the label image accordingly.

5:54 PM Changeset in webkit [139391] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 139029
BUG=167868
Review URL: ​https://codereview.chromium.org/11840004

5:42 PM Changeset in webkit [139390] by cevans@google.com
  • 1 edit
    2 deletes in branches/chromium/1364

Merge 138974
BUG=166336
Review URL: ​https://codereview.chromium.org/11847002

5:30 PM Changeset in webkit [139389] by cevans@google.com
  • 2 edits in branches/chromium/1364/Source

Merge 138173
BUG=166627
Review URL: ​https://codereview.chromium.org/11828063

5:27 PM Changeset in webkit [139388] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1364

Merge 138131
BUG=166513
Review URL: ​https://codereview.chromium.org/11846002

5:21 PM Changeset in webkit [139387] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1364

Merge 138316
BUG=161420
Review URL: ​https://codereview.chromium.org/11845002

5:13 PM Changeset in webkit [139386] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1364

Merge 138460
BUG=167498
Review URL: ​https://codereview.chromium.org/11841005

4:07 PM Changeset in webkit [139385] by jamesr@google.com
  • 4 edits in trunk

[chromium] Store scrollable layer's contents size for coordinated scrollable layers
​https://bugs.webkit.org/show_bug.cgi?id=106518

Reviewed by Adrienne Walker.

Source/WebCore:

This stores a scrollable layer's contentsSize in the scroll layer's bounds, which is otherwise not useful. This
value is currently calculated based on fragile knowledge of the tree structure immediately beneath a scrollable
layer.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated):

LayoutTests:

  • platform/chromium/TestExpectations:
4:01 PM Changeset in webkit [139384] by commit-queue@webkit.org
  • 4 edits
    3 copies
    1 add in trunk/LayoutTests

IndexedDB: Update expected results for IndexedDB layout tests
​https://bugs.webkit.org/show_bug.cgi?id=106411

Patch by Michael Pruett <​michael@68k.org> on 2013-01-10
Reviewed by Tony Chang.

For IndexedDB layout tests whose output differs between V8 and
JSC, move V8 test output to platform/chromium and set expected
results to JSC test output.

  • platform/chromium/storage/indexeddb/exception-in-event-aborts-expected.txt: Copied from LayoutTests/storage/indexeddb/exception-in-event-aborts-expected.txt.
  • platform/chromium/storage/indexeddb/transaction-error-expected.txt: Copied from LayoutTests/storage/indexeddb/transaction-error-expected.txt.
  • platform/chromium/storage/indexeddb/version-change-abort-expected.txt: Copied from LayoutTests/storage/indexeddb/version-change-abort-expected.txt.
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/transaction-error-expected.txt:
  • storage/indexeddb/version-change-abort-expected.txt:
3:43 PM Changeset in webkit [139383] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Layout Test fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=106612

  • platform/chromium/TestExpectations: Marked as flake.
3:41 PM Changeset in webkit [139382] by cevans@google.com
  • 4 edits in branches/chromium/1364/Source/WebCore

Merge 138863
BUG=156906
Review URL: ​https://codereview.chromium.org/11830062

3:40 PM Changeset in webkit [139381] by cevans@google.com
  • 4 edits in branches/chromium/1312/Source/WebCore

Merge 138863
BUG=156906
Review URL: ​https://codereview.chromium.org/11833048

3:35 PM Changeset in webkit [139380] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][EFL] Rename from xxxContentsScale() to xxxScale() in PageViewportController.
​https://bugs.webkit.org/show_bug.cgi?id=106537

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

Rename 3 methods to match the terms of ViewportAttributes.

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::viewport):
(QWebKitTest::contentsScale):

  • UIProcess/PageViewportController.h:

(WebKit::PageViewportController::minimumScale):
(WebKit::PageViewportController::maximumScale):
(WebKit::PageViewportController::currentScale):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):

3:28 PM Changeset in webkit [139379] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebKit/chromium/public/WebInputEvent.h

Merge 138684
BUG=165836
Review URL: ​https://codereview.chromium.org/11817055

3:19 PM Changeset in webkit [139378] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 138918
BUG=167147
Review URL: ​https://codereview.chromium.org/11827065

3:18 PM Changeset in webkit [139377] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 138918
BUG=167147
Review URL: ​https://codereview.chromium.org/11786012

3:14 PM Changeset in webkit [139376] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test animations/fill-mode-iteration-count-non-integer.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=106609

  • platform/chromium/TestExpectations: Marked as failing.
3:11 PM Changeset in webkit [139375] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Adjust ref-test expectation to actual work.

  • platform/chromium/TestExpectations: Adjusted.
2:45 PM Changeset in webkit [139374] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline. Apple Windows port.

  • platform/win/fast/ruby/base-shorter-than-text-expected.txt:
2:42 PM Changeset in webkit [139373] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test fast/canvas/webgl/context-release-upon-reload.html is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=106606

  • platform/chromium/TestExpectations: Added.
2:40 PM Changeset in webkit [139372] by commit-queue@webkit.org
  • 20 edits
    5 adds in trunk

Implement AutocompleteErrorEvent#reason
​https://bugs.webkit.org/show_bug.cgi?id=105568

Source/WebCore:

Patch by Dan Beam <​dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

Test: fast/events/constructors/autocomplete-error-event-constructor.html

  • WebCore.gypi: Added AutocompleteErrorEvent.idl and AutocompleteErrorEvent.h for chromium port's build.
  • dom/AutocompleteErrorEvent.h: Added.

(WebCore): Added new type of error named AutocompleteErrorEvent.
(AutocompleteErrorEventInit): Added init params for AutocompleteErrorEvents (so initEvent() can be used).
(AutocompleteErrorEvent): Added a new error event that inherits from Event but also has a reason for failure.
(WebCore::AutocompleteErrorEvent::create): Factory function to create AutocompleteErrorEvents.
(WebCore::AutocompleteErrorEvent::reason): The reason why a requestAutocomplete() invocation failed. Can be

"disabled", "cancel", or "invalid".

(WebCore::AutocompleteErrorEvent::interfaceName): The name of the event's interface (for event.toString()).
(WebCore::AutocompleteErrorEvent::AutocompleteErrorEvent): Various ways of constructing the error event.

  • dom/AutocompleteErrorEvent.idl: Added.
  • dom/EventNames.in: Added AutocompleteError to this list, based on REQUEST_AUTOCOMPLETE conditional.
  • html/HTMLFormElement.cpp: Updated form elements to dispatch AutocompleteErrorEvents on errors and to give

more details (event.reason) when the request fails.

(WebCore::HTMLFormElement::requestAutocomplete): Changed to newly added failure type "disabled".
(WebCore::HTMLFormElement::finishRequestAutocomplete): Changed

  • html/HTMLFormElement.h: Added new results (ErrorDisabled, ErrorCancel, ErrorInvalid).
  • page/DOMWindow.idl: Added global event constructor for new AutocompleteErrorEvent() style event creation.

Source/WebKit/chromium:

Patch by Dan Beam <​dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

  • public/WebFormElement.h: Added matching enum values for public chromium WebKit API.
  • src/AssertMatchingEnums.cpp: Updated compile assert that WebKit and WebCore enums match.

LayoutTests:

Added tests to verify event creation and global event constructor existence of AutocompleteErrorEvent
and updated the existing tests to make sure errors received are of the right type and have the right reason.

Patch by Dan Beam <​dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

  • fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Added.
  • fast/events/constructors/autocomplete-error-event-constructor.html: Added.
  • fast/events/event-creation.html: Added new AutocompleteErrorEvent() test case.
  • fast/forms/form-request-autocomplete.html: Updated 'autocompleteerror' listeners to check event.reason.
  • fast/js/constructor-length.html: Added AutocompleteErrorEvent to list.
  • fast/js/script-tests/global-constructors.js: Added AutocompleteErrorEvent to list.
  • platform/blackberry/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
  • platform/chromium/fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Added.
  • platform/chromium/fast/forms/form-request-autocomplete-expected.txt: Updated passing expectations.
  • platform/chromium/fast/js/constructor-length-expected.txt: Added expected 0 length result.
  • platform/gtk/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
  • platform/mac/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
  • platform/qt/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
2:31 PM Changeset in webkit [139371] by yoli@rim.com
  • 2 edits in trunk/Source/WebCore

HTMLMediaElement::resume() should schedule a load rather than load immediately
​https://bugs.webkit.org/show_bug.cgi?id=106587

Reviewed by Eric Carlson.

It is not always safe to start the jobs at the time resume() is called. That is why the jobs are
suspended. It can also be suspended again right after being resumed.

No new tests as there is no visible functional change, also it is a theoretically good-to-have change
that doesn't fix any known cross-platform issue.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::resume): Replace load() with scheduleLoad().

2:31 PM Changeset in webkit [139370] by roger_fong@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed rebaselines. Apple Windows port.

  • platform/win/TestExpectations:
  • platform/win/fast/dom/window-load-crash-expected.txt: Added.
2:25 PM Changeset in webkit [139369] by commit-queue@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed, rolling out r139226.
​http://trac.webkit.org/changeset/139226
​https://bugs.webkit.org/show_bug.cgi?id=106602

re
baselines were premature (Requested by rfong on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-10

  • platform/win/accessibility/canvas-fallback-content-2-expected.txt:
  • platform/win/platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Removed.
  • platform/win/platform/win/accessibility/select-element-valuechange-event-expected.txt: Removed.
2:09 PM Changeset in webkit [139368] by roger_fong@apple.com
  • 2 edits in trunk/WebKitLibraries

Update WebkitSystemInterface lib for Windows port.
This hasn't been done in a while and the current one is out of date.
In addition I believe it will fix:
<rdar://problem/12990844>

Rubberstamped by Timothy Horton.

  • win/lib/WebKitSystemInterface.lib:
2:06 PM Changeset in webkit [139367] by abarth@webkit.org
  • 4 edits in trunk/Source

Add an ENABLE macro and a WebCore::Setting for the threaded parser
​https://bugs.webkit.org/show_bug.cgi?id=106595

Reviewed by Benjamin Poulain.

Source/WebCore:

This patch adds both a WebCore::Setting and an ENABLE macro for the
threaded parser. We plan to keep the ENABLE macro off by default for a
while. The runtime setting will let us more easily conduct A/B
experiments when the time arises.

  • page/Settings.in:

Source/WebKit/chromium:

Explicitly disable THREADED_HTML_PARSER for Chromium so that we can
more easily enable it locally.

  • features.gypi:
1:58 PM Changeset in webkit [139366] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test svg/dom/SVGScriptElement/script-onerror-bubbling.svg is a flaky timeout on all platforms.
​https://bugs.webkit.org/show_bug.cgi?id=106598

  • platform/chromium/TestExpectations: Expectatized.
1:52 PM Changeset in webkit [139365] by wangxianzhu@chromium.org
  • 2 edits in trunk/Source/WebCore

Regression(r129944): Heap-use-after-free in WebCore::computeNonFastScrollableRegion
​https://bugs.webkit.org/show_bug.cgi?id=99515

Reviewed by Simon Fraser.

The object used-after-freed is a destructed FrameView that is still in the m_scrollableAreas set of the parent FrameView. Actually it has been removed from m_scrollableAreas when setParent(0), but then is added back in updateScrollableAreaSet() because its frameViewParent() is still not 0 (though parent() is already 0).

No new tests. The heap-use-after-free doesn't always cause crash so it can't be stably tested with a test case. Memory analysis tools like asan discovered the heap-use-after-free and verified that the patch can fix the issue.

  • page/FrameView.cpp:

(WebCore::FrameView::parentFrameView): Checks if the FrameView has been removed from the parent.

1:49 PM Changeset in webkit [139364] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2] Set IndexedDB database path in WK2
​https://bugs.webkit.org/show_bug.cgi?id=106257

Patch by Michael Pruett <​michael@68k.org> on 2013-01-10
Reviewed by Benjamin Poulain.

  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::initialize):

  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.h:

(WebKeyValueStorageManager):
(WebKit::WebKeyValueStorageManager::indexedDBDatabaseDirectory):

  • WebProcess/WebPage/WebPageGroupProxy.cpp:

(WebKit::WebPageGroupProxy::WebPageGroupProxy):

1:47 PM Changeset in webkit [139363] by cevans@google.com
  • 6 edits
    15 copies
    4 deletes in branches/chromium/1364

Merge 138654
BUG=139321
Review URL: ​https://codereview.chromium.org/11823064

1:44 PM Changeset in webkit [139362] by cevans@google.com
  • 6 edits
    15 copies
    4 deletes in branches/chromium/1312

Merge 138654
BUG=139321
Review URL: ​https://codereview.chromium.org/11820059

1:44 PM Changeset in webkit [139361] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Expanding the timeout expectation for fast/css/user-drag-none.html, the test
times out on both debug and release builds.

  • platform/gtk/TestExpectations:
1:43 PM Changeset in webkit [139360] by Christophe Dumez
  • 2 edits in trunk/Tools

[EFL][jhbuild] Use tarballs for gstreamer instead of git
​https://bugs.webkit.org/show_bug.cgi?id=106552

Reviewed by Laszlo Gombos.

Use tarballs for gstreamer instead of git in EFL's jhbuild
to work around intermittent network issues on our build
bots. Tarballs are fully cached and require no network
operation if their checksum matches.

  • efl/jhbuild.modules:
1:37 PM Changeset in webkit [139359] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 138926
BUG=129890
Review URL: ​https://codereview.chromium.org/11819066

1:35 PM Changeset in webkit [139358] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1312

Merge 138926
BUG=129890
Review URL: ​https://codereview.chromium.org/11819065

1:27 PM Changeset in webkit [139357] by rniwa@webkit.org
  • 5 edits in trunk/Tools

Add Mac WK2 EWS bots
​https://bugs.webkit.org/show_bug.cgi?id=106590

Reviewed by Adam Barth.

Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
Also add a deprecated MacWK2Port class.

  • QueueStatusServer/model/queues.py:

(Queue):

  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
(MacWK2Port):
(MacWK2Port.run_webkit_tests_command):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(MacEWS):
(MacWK2EWS):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(_test_ewses):

1:10 PM Changeset in webkit [139356] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Fix scale of screen.width, window.outerWidth and @media device-width when page scale not applied in compositor.
​https://bugs.webkit.org/show_bug.cgi?id=106460

Patch by John Mellor <​johnme@chromium.org> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

screen.width, window.outerWidth and @media device-width should be in
density independent (UI) pixels, not physical screen pixels.

This already works on most ports (including iOS). However Chrome for
Android currently internally sizes its windows in physical screen pixels
instead of density independent pixels, and this leaks through in the
sizes provided to WebCore.

This patch scales these sizes appropriately before they reach JavaScript,
on platforms where the applyPageScaleFactorInCompositor setting is false
(i.e. just Chrome for Android). Once Chrome for Android switches over to
the same coordinate space, the applyPageScaleFactorInCompositor setting
will be removed, along with any code (such as this) that depends on it.

The effect of this patch on Chrome for Android when viewing a page with
a width=device-width viewport on a Galaxy Nexus (720x1280 @ dPR 2) is:

@media device-width changes from 720 to 360
screen.width changes from 720 to 360
screen.availWidth changes from 720 to 360
window.outerWidth changes from 720 to 360
window.innerWidth remains 360 (at overview zoom)
@media width remains 360
document.documentElement.clientWidth remains 360
document.documentElement.offsetWidth remains 360
document.documentElement.scrollWidth remains 360
document.body.clientWidth remains 360
document.body.offsetWidth remains 360
document.body.scrollWidth remains 360

And similarly for heights (though they are slightly less than 640, since
toolbars etc. get subtracted from the available height).

No new tests, as applyDeviceScaleFactorInCompositor appears to always be
true in DumpRenderTree, so this situation cannot occur there.

  • page/Settings.in:

Added applyDeviceScaleFactorInCompositor setting, which allows
detecting whether we need to normalize the scale.

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::toUserSpace):

Static function for normalizing screen rect scale.

(WebCore::screenRect):

Uses toUserSpace.

(WebCore::screenAvailableRect):

Uses toUserSpace.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processSubtree):

Use applyDeviceScaleFactorInCompositor instead of
applyPageScaleFactorInCompositor, to scale the window rect correctly
on platforms other than Chrome for Android.

Source/WebKit/chromium:

  1. Exposes the existing applyDeviceScaleFactorInCompositor from

WebSettings on Settings (and stores the value there instead), so it can
be accessed from WebCore.

  1. Changes ChromeClientImpl::windowRect to return values in density

independent (UI) pixels pixels instead of physical screen pixels (see
explanation in Source/WebCore/ChangeLog).

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::windowRect):

Normalizes window rect scale.

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setApplyDeviceScaleFactorInCompositor):
(WebKit::WebSettingsImpl::applyDeviceScaleFactorInCompositor):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

1:02 PM Changeset in webkit [139355] by commit-queue@webkit.org
  • 12 edits
    2 moves in trunk/Tools

[chromium] move webpermissionclient related methods to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=106548

Patch by Dan Carney <​dcarney@google.com> on 2013-01-10
Reviewed by Jochen Eisinger.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebKit):
(WebTestRunner::WebTestRunner::webPermissions):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setDelegate):
(WebTestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::webPermissions):
(WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
(WebTestRunner::TestRunner::setImagesAllowed):
(WebTestRunner::TestRunner::setScriptsAllowed):
(WebTestRunner::TestRunner::setStorageAllowed):
(WebTestRunner::TestRunner::setPluginsAllowed):
(WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
(WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.

(WebTestRunner):
(WebTestRunner::WebPermissions::WebPermissions):
(WebTestRunner::WebPermissions::~WebPermissions):
(WebTestRunner::WebPermissions::allowImage):
(WebTestRunner::WebPermissions::allowScriptFromSource):
(WebTestRunner::WebPermissions::allowStorage):
(WebTestRunner::WebPermissions::allowPlugins):
(WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
(WebTestRunner::WebPermissions::allowRunningInsecureContent):
(WebTestRunner::WebPermissions::setImagesAllowed):
(WebTestRunner::WebPermissions::setScriptsAllowed):
(WebTestRunner::WebPermissions::setStorageAllowed):
(WebTestRunner::WebPermissions::setPluginsAllowed):
(WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
(WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
(WebTestRunner::WebPermissions::setDelegate):
(WebTestRunner::WebPermissions::setDumpCallbacks):
(WebTestRunner::WebPermissions::reset):

  • DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.

(WebTestRunner):
(WebPermissions):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::resetTestController):
(TestShell::createNewWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::normalizeLayoutTestURL):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

1:01 PM Changeset in webkit [139354] by commit-queue@webkit.org
  • 3 edits
    2 copies
    1 move in trunk/Tools

Split EWS tool cold-boot.sh into modular components
​https://bugs.webkit.org/show_bug.cgi?id=106527

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
Updated GCE bot build scripts to match.
Unable to test scripts directly as they depend on being in the repository to work!

  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
  • EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
  • EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
12:51 PM Changeset in webkit [139353] by fmalita@chromium.org
  • 12 edits in trunk/Source/WebCore

Rename GraphicsContext::addRoundedRectClip
​https://bugs.webkit.org/show_bug.cgi?id=106581

Reviewed by Simon Fraser.

This patch renames GraphicsContext::addRoundedRectClip to clipRoundedRect for consistency
with the other GC clipping methods.

No new tests: no functional changes.

  • WebCore.order:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::clipRoundedRect):

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clipRoundedRect):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::pushContentsClip):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::clipRoundedInnerRect):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clipToRect):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):

  • rendering/RenderThemeMacShared.mm:

(WebCore::RenderThemeMacShared::paintMenuListButtonGradients):
(WebCore::RenderThemeMacShared::paintSliderTrack):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):

  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):

12:44 PM Changeset in webkit [139352] by tommyw@google.com
  • 13 edits in trunk/Source

MediaStream API: Adding the new id attribute to MediaStream and MediaStreamTrack
​https://bugs.webkit.org/show_bug.cgi?id=106564

Reviewed by Adam Barth.

Specification: ​http://dev.w3.org/2011/webrtc/editor/getusermedia.html
MediaStream looses its label attribute and instead gets an id attribute.
MediaStreamTrack gets an id attribute.

Source/Platform:

  • chromium/public/WebMediaStreamComponent.h:

(WebMediaStreamComponent):

  • chromium/public/WebMediaStreamDescriptor.h:

(WebMediaStreamDescriptor):

Source/WebCore:

Not testable yet, will add tests in a followup patch.

  • Modules/mediastream/MediaStream.h:

(WebCore::MediaStream::label):
(MediaStream):
(WebCore::MediaStream::id):

  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::id):
(WebCore):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.idl:
  • platform/chromium/support/WebMediaStreamComponent.cpp:

(WebKit::WebMediaStreamComponent::initialize):
(WebKit):
(WebKit::WebMediaStreamComponent::isEnabled):
(WebKit::WebMediaStreamComponent::id):
(WebKit::WebMediaStreamComponent::source):

  • platform/chromium/support/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::label):
(WebKit):
(WebKit::WebMediaStreamDescriptor::id):

  • platform/mediastream/MediaStreamComponent.h:

(WebCore::MediaStreamComponent::id):
(WebCore::MediaStreamComponent::MediaStreamComponent):
(MediaStreamComponent):

  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::id):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
(MediaStreamDescriptor):

12:32 PM Changeset in webkit [139351] by ojan@chromium.org
  • 9 edits
    2 adds in trunk

Flexboxes incorrectly add the scrollbar width to the intrinsic width of fixed-width items
​https://bugs.webkit.org/show_bug.cgi?id=106591

Reviewed by Levi Weintraub.

Source/WebCore:

The scrollbar width should only be added if the width of the flex item
is not fixed.

Test: fast/css/fixed-width-intrinsic-width-excludes-scrollbars.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):
Use shared helper method. This also happens to fix the vertical
writing-mode case.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::instrinsicScrollbarLogicalWidth):
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):
Add a method for determining the scrollbar's contribution to the boxes
intrinsic width.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
Use shared code for determining the scrollbar width and only add the
width when computing the intrinsic widths.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computePreferredLogicalWidths):\
Just adding a FIXME to account for scrollbar width.

LayoutTests:

  • fast/css/fixed-width-intrinsic-width-excludes-scrollbars-expected.txt: Added.
  • fast/css/fixed-width-intrinsic-width-excludes-scrollbars.html: Added.
  • fast/css/positioned-overflow-scroll.html:
12:21 PM Changeset in webkit [139350] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

Replace unnecessary null-checks with an assert in MainResourceLoader::continueAfterNavigationPolicy.
​https://bugs.webkit.org/show_bug.cgi?id=106476

Reviewed by Alexey Proskuryakov.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::continueAfterNavigationPolicy): Null-checks for resourceLoader were

added in an abundance of caution in r139150. Given that we know the load hasn't been cancelled,
resourceLoader can only be null if continueAfterNavigationPolicy() has already been called
before when m_substituteData is valid. continueAfterNavigationPolicy() is only called for redirects,
and SubstituteData doesn't support redirects, so it is correct to assert that resourceLoader is non-null.

12:14 PM Changeset in webkit [139349] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing a few crash expectations for tests that haven't crashed
for a long time. Hopefully the crash causes have been fixed.
Adding a flaky failure expectation for a CSS Regions reftest.

  • platform/gtk/TestExpectations:
11:52 AM Changeset in webkit [139348] by jparent@chromium.org
  • 2 edits in trunk/Tools

Dashboard Cleanup: Do not generate the page if we are about to reload.
​https://bugs.webkit.org/show_bug.cgi?id=106584

Reviewed by Dirk Pranke.

Move the logic to determine if we should generate the page into
parseParameters() since that is where we have the knowledge to
determine it, and return that value to handleLocationChange,
rather than passing the changed parameters back to handleLocationChange
and having it make the decision.

This is logically equivalent, save one case: when we are about to do
a reload, we know that there is no reason to generate the page. Old
code was causing an extra page generation in this case.

  • TestResultServer/static-dashboards/dashboard_base.js:

(parseParameters):
(handleLocationChange):

11:47 AM Changeset in webkit [139347] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-10

  • DEPS:
11:33 AM Changeset in webkit [139346] by leviw@chromium.org
  • 3 edits
    4 adds in trunk

ScrollingCoordinator touch event hit rects aren't converted to proper coordinates when in nested views
​https://bugs.webkit.org/show_bug.cgi?id=106383

Reviewed by James Robinson.

Source/WebCore:

ScrollingCoordinator uses clippedOverflowRectForRepaint(0) to generate the bounds for a renderer's hit
testing rect. The rect this returns is in the coordinates of its document. This change converts the
rect to the outermost view's coordinate system using convertToContainingView.

Tests: platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::accumulateRendererTouchEventTargetRects):

LayoutTests:

  • platform/chromium/fast/events/touch/resources: Added.
  • platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html: Added.
  • platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added.
  • platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html: Added.
11:29 AM Changeset in webkit [139345] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

Regression(r137939): Heap-use-after-free in WebCore::accumulateDocumentEventTargetRects
​https://bugs.webkit.org/show_bug.cgi?id=106454

Reviewed by James Robinson.

Source/WebCore:

Correctly removing child Documents from their parent's tracked touch handler maps when detaching and
when their last touch event handler is removed.

Test: fast/events/touch/nested-document-with-touch-handler-detached-crash.html

  • dom/Document.cpp:

(WebCore::Document::detach):
(WebCore::Document::didRemoveEventTargetNode):

LayoutTests:

  • fast/events/touch/nested-document-with-touch-handler-detached-crash.html: Added.
  • fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt: Added.
11:22 AM Changeset in webkit [139344] by ojan@chromium.org
  • 3 edits
    1 add
    16 deletes in trunk/LayoutTests

Convert fast/css/positioned-overflow-scroll.html to a check-layout.js test
​https://bugs.webkit.org/show_bug.cgi?id=106585

Reviewed by Tony Chang.

This is in preparation for adding more cases to this test.

  • fast/css/positioned-overflow-scroll-expected.txt: Added.
  • fast/css/positioned-overflow-scroll.html:
  • platform/chromium-android/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-android/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/chromium-linux/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-mac-lion/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-mac/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-win/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/efl/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/efl/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/gtk/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/gtk/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/mac/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/mac/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/qt/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/qt/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • resources/check-layout.js:
11:22 AM Changeset in webkit [139343] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

REGRESSION(r138222): WebDocumentLoaderMac-related leaks seen on Leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=106137

Reviewed by Brady Eidson.

Tested manually by comparing before and after leaks output for WK1-mac.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::receivedError): Call dispatchDidFailLoading() if

a SubstituteData load fails or is cancelled. Without this call, load counts
are not balanced on WebDocumentLoaderMac and it is retained forever.

(WebCore::MainResourceLoader::didFinishLoading):

11:11 AM Changeset in webkit [139342] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[jhbuild] Use the "configure" script to build glib
​https://bugs.webkit.org/show_bug.cgi?id=106569

Patch by Raphael Kubo da Costa <​raphael.kubo.da.costa@intel.com> on 2013-01-10
Reviewed by Martin Robinson.

So far both EFL and GTK have been using autogen.sh to build glib.
While that does work most of the time, it's not really needed since
we are downloading and building stable releases from tarballs.
Additionally, autogen.sh fails to work with automake 1.13 due to the
usage of some macros that have been removed (this has already been
fixed in glib master).

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:
10:44 AM Changeset in webkit [139341] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit2

Ensure that WebPageProxy's notion of pageScaleFactor is reset on didCommitLoad
​https://bugs.webkit.org/show_bug.cgi?id=103290
<rdar://problem/12752467>

Reviewed by Darin Adler.

When a standard main frame load is committed, we reset the WebPage's
pageScaleFactor, if it's not the default. However, if the previous
page had a full-main-frame plugin that was handling page scaling itself,
WebPageProxy can have a cached pageScaleFactor != 1, while WebPage
now (since the plugin that was overriding (set)pageScaleFactor is gone)
has a pageScaleFactor of 1, causing us to skip the call to reset the
WebPage's pageScaleFactor.

Therefore, when WebPageProxy is notified that a standard main-frame load
is committed, reset its cached notion of the pageScaleFactor.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame): Add a parameter which corresponds to FrameLoadType, so we can
determine whether a frame load is of FrameLoadTypeStandard (which matches the check to reset page scale in
WebFrameLoaderClient::didCommitLoad), so we can reset m_pageScaleFactor.

  • UIProcess/WebPageProxy.h:

(WebPageProxy): Add frameLoadType parameter to didCommitLoadForFrame.

  • UIProcess/WebPageProxy.messages.in: Add frameLoadType parameter to didCommitLoadForFrame.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad): Pass frameLoadType parameter to didCommitLoadForFrame.

10:42 AM Changeset in webkit [139340] by timothy_horton@apple.com
  • 6 edits in trunk/Source/WebKit2

PDFPlugin: Cmd-/+ should affect PDF page scale
​https://bugs.webkit.org/show_bug.cgi?id=103285
<rdar://problem/12710469>

Reviewed by Darin Adler.

Plugins which support handling page scale themselves should also handle
page zoom, as it is a very similar concept.

This patch disables text zoom in the case of a main-frame plugin which supports
page scale factor changes, as it is not needed in the PDFPlugin case
(we can't do text-only scale for PDF), but it could be added later if needed.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::pageZoomFactorDidChange):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:

Add WebPageProxy::pageZoomFactorDidChange, to notify WebPageProxy of
out-of-band page zoom factor changes (in this case, from PluginView).

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setPageScaleFactor):
Update WebPageProxy's notion of the current page zoom whenever PluginView
is notified of a page scale factor change.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setTextZoomFactor): We don't support text zoom in plugins, but
we also don't want it to silently act on the Frame if we have a plugin that
purports to handle page scale itself. Return early if this is the case.
(WebKit::WebPage::pageZoomFactor): For plugins that support page scale factor,
we equate page scale and page zoom. Return the PluginView's page scale factor
in place of the Frame's page zoom factor.
(WebKit::WebPage::setPageZoomFactor): Make page zoom changes in the aforementioned
case affect the PluginView's page scale.
(WebKit::WebPage::setPageAndTextZoomFactors): Ditto.

10:41 AM Changeset in webkit [139339] by rjkroege@chromium.org
  • 3 edits
    2 deletes in trunk

Manually revert ​http://trac.webkit.org/changeset/136012
​https://bugs.webkit.org/show_bug.cgi?id=106580

Reviewed by Dimitri Glazkov.

Source/WebCore:

136012 broke touch-scrolling of an overflow div in an iframe. Revert manually
to work around conflicts.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

LayoutTests:

  • fast/events/touch/gesture/touch-gesture-scroll-remove-node-expected.txt: Removed.
  • fast/events/touch/gesture/touch-gesture-scroll-remove-node.html: Removed.
10:41 AM Changeset in webkit [139338] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Changing tests to be consistent and use self.scm rather then recreating the scm object.
(Missed a couple)
​https://bugs.webkit.org/show_bug.cgi?id=106536

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
10:39 AM Changeset in webkit [139337] by robert@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r136967): margin-top + overflow:hidden causes incorrect layout for internal floated elements
​https://bugs.webkit.org/show_bug.cgi?id=106374

Reviewed by David Hyatt.

Source/WebCore:

r136397 treated any self-collapsing block that had a clearance delta as though it was clearing a float, but
blocks that avoid floats can get a clearance delta too. So just ensure there is clearance on the block when deciding
whether we need to add the margin back in before placing the float.

Test: fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-and-float-child.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

  • fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-and-float-child-expected.txt: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-and-float-child.html: Added.
10:39 AM Changeset in webkit [139336] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

PDFPlugin: Header cleanup
​https://bugs.webkit.org/show_bug.cgi?id=106540

Reviewed by Andreas Kling.

  • WebProcess/Plugins/PDF/PDFPlugin.mm: Remove some unneeded headers.
10:28 AM Changeset in webkit [139335] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Update expectations for fast/regions/selecting-text-through-different-region-flows.html.

  • platform/chromium-mac-lion/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
10:27 AM Changeset in webkit [139334] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Color picker in Styles pane shows wrong initial color
​https://bugs.webkit.org/show_bug.cgi?id=106567

Reviewed by Pavel Feldman.

The RGB's G value for "crimson" was wrong.

  • inspector/front-end/Color.js:
10:27 AM Changeset in webkit [139333] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Mark more inspector/geolocation* tests as flaky on Win.
​https://bugs.webkit.org/show_bug.cgi?id=106426

  • platform/chromium/TestExpectations: Marked.
10:25 AM Changeset in webkit [139332] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Web Inspector: Refactor InspectorTest to create output interface
​https://bugs.webkit.org/show_bug.cgi?id=106231

Patch by John J. Barton <​johnjbarton@chromium.org> on 2013-01-10
Reviewed by Pavel Feldman.

Refactor InspectorTest to extract InspectorTest.Output, the API
used between InspectorTest and the test output reciever (the
test-script page by default).

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.Output.testComplete):
(initialize_InspectorTest.InspectorTest.Output.addResult):
(initialize_InspectorTest.InspectorTest.Output.clearResults):
(initialize_InspectorTest.InspectorTest.completeTest):
(initialize_InspectorTest.InspectorTest.addResult):

10:25 AM Changeset in webkit [139331] by tony@chromium.org
  • 14 edits in trunk

Speed up supplemental dependency computation
​https://bugs.webkit.org/show_bug.cgi?id=106503

Reviewed by Adam Barth.

.:

  • Source/cmake/WebKitMacros.cmake: Add --idlAttributesFile to the binding generation step in cmake.

Source/WebCore:

On my machine, generating supplemental IDL dependencies was taking about 18s
because it has to run the C preprocessor on each IDL file. Avoid this by using
a regular expression to find the Supplemental= value in each IDL file rather than
doing a full parse. Now generating supplemental IDL dependencies is less than a
second.

preprocess-idls.pl used to also check IDL attributes against IDLAttributes.txt.
Move this code to run in generate-bindings.pl. This change revealed that
TestRunner.idl uses PassContext so add that to IDLAttributes.txt.

No new tests, this is a build refactor. EWS bots should be green.

  • DerivedSources.make: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • DerivedSources.pri: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • GNUmakefile.am: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • UseJSC.cmake: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • UseV8.cmake: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • WebCore.gyp/WebCore.gyp: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • bindings/scripts/IDLAttributes.txt: Add PassContext needed by TestRunner.idl.
  • bindings/scripts/generate-bindings.pl:

(loadIDLAttributes): Moved from preprocess-idls.pl.
(checkIDLAttributes): Moved from preprocess-idls.pl.
(checkIfIDLAttributesExists): Moved from preprocess-idls.pl.

  • bindings/scripts/preprocess-idls.pl:

(getSupplementalFromIDLFile): Helper method to get Supplemental=* quickly.

Tools:

Pass the IDL attributes file for generating the bindings in WebKitTestRunner.

  • WebKitTestRunner/CMakeLists.txt:
10:16 AM Changeset in webkit [139330] by mvujovic@adobe.com
  • 4 edits
    11 adds in trunk

[CSS Filters] RenderLayerCompositor::addToOverlapMap should take into account the filters outsets (ie. blur and drop-shadow)
​https://bugs.webkit.org/show_bug.cgi?id=94022

Reviewed by Simon Fraser.

Source/WebCore:

When a layer has a filter that moves pixels, we need to add its entire bounds, including its
outsets and children, to the overlap map. The filter can move the children's pixels
anywhere in the layer, so we can't rely on the children's bounds.

Eventually, we should avoid adding children to the overlap map if the parent's bounds used
for overlap testing already include the children. I've added a FIXME for this optimization.

Tests: compositing/filters/sw-layer-overlaps-hw-shadow.html

compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow.html
compositing/filters/sw-shadow-overlaps-hw-layer.html
compositing/filters/sw-shadow-overlaps-hw-shadow.html

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::overlapBounds):

If necessary, return the calculated layer bounds, including the children. Otherwise,
return the localBoundingBox.

(RenderLayer):
(WebCore::RenderLayer::overlapBoundsIncludeChildren):

If the layer has a filter that moves pixels, return true.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):

Add the overlapBounds instead of the localBoundingBox to the overlap map.

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

Use the overlapBounds instead of the localBoundingBox for overlap testing.

LayoutTests:

Add tests to check several combinations of software layer and composited layer overlap when
filter outsets are involved.

  • compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added.
  • compositing/filters/sw-layer-overlaps-hw-shadow.html: Added.
  • compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added.
  • compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow.html: Added.
  • compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added.
  • compositing/filters/sw-shadow-overlaps-hw-layer.html: Added.
  • compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added.
  • compositing/filters/sw-shadow-overlaps-hw-shadow.html: Added.
  • platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added.
  • platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added.
10:08 AM Changeset in webkit [139329] by ojan@chromium.org
  • 6 edits
    2 adds in trunk

intrinsic min-widths don't override width for file upload controls
​https://bugs.webkit.org/show_bug.cgi?id=106517

Reviewed by Tony Chang.

Source/WebCore:

Separate out computing intrinsic width from perferred width so that
we can use the intrinsic width correctly when applying min-width/max-width.
The preferred width is the width used in its container's computation
of its intrinsic width.

This is the first in a series of patches making this work across
the render tree.

Test: fast/forms/file/intrinsic-min-width-overrides-width.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::minIntrinsicLogicalWidth):
(WebCore):
(WebCore::RenderBox::maxIntrinsicLogicalWidth):
(WebCore::RenderBox::computeIntrinsicLogicalWidths):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderFileUploadControl.h:

(RenderFileUploadControl):

LayoutTests:

  • fast/forms/file/intrinsic-min-width-overrides-width-expected.html: Added.
  • fast/forms/file/intrinsic-min-width-overrides-width.html: Added.
9:56 AM Changeset in webkit [139328] by fmalita@chromium.org
  • 102 edits
    4 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining results after ​http://trac.webkit.org/changeset/138250.

  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-lion/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac-lion/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac-lion/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac-lion/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac/svg/custom/feDisplacementMap-01-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
  • platform/chromium-mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/chromium-mac/svg/filters/feImage-multiple-targets-id-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-position-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-mac/svg/filters/feImage-reference-invalidation-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-add-to-document-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-attribute-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-changes-id-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-id-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-inline-style-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-property-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-reappend-to-document-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-remove-from-document-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-style-change-expected.png:
  • platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/chromium/TestExpectations:
9:51 AM Changeset in webkit [139327] by zandobersek@gmail.com
  • 2 edits in trunk

[Autotools] Add the AM_WEBKIT_FEATURE_CONDITIONAL macro
​https://bugs.webkit.org/show_bug.cgi?id=106576

Reviewed by Martin Robinson.

Replace the AC_CHECK_WEBKIT_FEATURE_ENABLED with the new macro.
The former was executing actions based on the passed-in feature being
enabled in the (possibly overridden) GNUmakefile.features.am, the actions
usually affecting the Automake conditional value that was set up afterwards.
The new macro does this directly, setting up an Automake conditional of the
same name as the feature that was checked.

  • Source/autotools/webkitfeature.m4:
9:45 AM Changeset in webkit [139326] by victor@rosedu.org
  • 5 edits in trunk

media/video-controls-captions.html fails after fixing ​https://bugs.webkit.org/show_bug.cgi?id=105536
​https://bugs.webkit.org/show_bug.cgi?id=106230

Reviewed by Eric Carlson.

Source/WebCore:

Until Chromium has proper controls for lists of text tracks, the caption button
needs to preserve its functionality.

Updated TestExpectations to reactivate test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Added explicit call to updateTextTrackDisplay.
This enables hiding the tracks immediately.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Added extra check before rendering
that captions should actually be displayed.

LayoutTests:

  • platform/chromium/TestExpectations: Reactivated test.
9:44 AM Changeset in webkit [139325] by morrita@google.com
  • 18 edits
    2 adds in trunk/Source/WebCore

ComposedShadowTreeWalker shouldn't be exposed to non-ShadowDOM classes
​https://bugs.webkit.org/show_bug.cgi?id=106505

Reviewed by Dimitri Glazkov.

This change hides ComposedShadowTreeWalker from non-ShadowDOM classes by

  • introducing thin wrapper functions on NodeRenderingTraversal and relacing CSTW callsites with it,
  • replacing ComposedShadowTreeWalker usage with AncestorChainWalker if possible and
  • moving AncestorChainWalker to its own file and including it on files which needs only AncestorChainWalker. This eliminates ComposedShadowTreeWalker.h inclusions.

No new tests. No behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/AncestorChainWalker.cpp: Added. Extracted from ComposedShadowTreeWalker.cpp

(WebCore):
(WebCore::AncestorChainWalker::AncestorChainWalker):
(WebCore::AncestorChainWalker::parent):

  • dom/AncestorChainWalker.h: Added. Extracted from ComposedShadowTreeWalker.h

(WebCore):
(AncestorChainWalker):
(WebCore::AncestorChainWalker::get):
(WebCore::AncestorChainWalker::crossingInsertionPoint):

  • dom/ComposedShadowTreeWalker.cpp:
  • dom/ComposedShadowTreeWalker.h:
  • dom/DOMAllInOne.cpp:
  • dom/ElementShadow.h:

(WebCore::shadowOfParent):
(WebCore):

  • dom/EventDispatcher.cpp:
  • dom/Node.cpp:
  • dom/NodeRenderingTraversal.cpp:

(WebCore::NodeRenderingTraversal::nextInScope):
(NodeRenderingTraversal):
(WebCore::NodeRenderingTraversal::previousInScope): Added.
(WebCore::NodeRenderingTraversal::parentInScope): Added.
(WebCore::NodeRenderingTraversal::lastChildInScope): Added.

  • dom/NodeRenderingTraversal.h:

(NodeRenderingTraversal):

  • dom/TreeScope.cpp:
  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

  • page/EventHandler.cpp:
  • page/FocusController.cpp: Replacing CSTW with NRT

(WebCore):
(WebCore::FocusNavigationScope::focusNavigationScopeOf):
(WebCore::FocusController::findNodeWithExactTabIndex):
(WebCore::nextNodeWithGreaterTabIndex):
(WebCore::previousNodeWithLowerTabIndex):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

9:29 AM Changeset in webkit [139324] by zandobersek@gmail.com
  • 17 edits in trunk

Remove the ENABLE_ANIMATION_API feature define occurences
​https://bugs.webkit.org/show_bug.cgi?id=106544

Reviewed by Simon Fraser.

The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
feature define handling still lingers in various build systems and configurations
but is of no use, so it should be removed.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests - no new functionality.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.features.am.in:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:
9:27 AM Changeset in webkit [139323] by Dimitri Glazkov
  • 149 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r139227.
​http://trac.webkit.org/changeset/139227
​https://bugs.webkit.org/show_bug.cgi?id=106227

Broke Win component build.

  • public/WebAccessibilityObject.h:
  • public/WebAccessibilityRole.h:
  • public/WebActiveWheelFlingParameters.h:
  • public/WebAnimationController.h:
  • public/WebApplicationCacheHost.h:
  • public/WebApplicationCacheHostClient.h:
  • public/WebArrayBuffer.h:
  • public/WebAudioSourceProvider.h:
  • public/WebBatteryStatus.h:
  • public/WebBindings.h:
  • public/WebBlob.h:
  • public/WebCache.h:
  • public/WebCachedURLRequest.h:
  • public/WebColorChooser.h:
  • public/WebColorChooserClient.h:
  • public/WebColorName.h:
  • public/WebCommonWorkerClient.h:
  • public/WebCompositionUnderline.h:
  • public/WebCompositorInputHandler.h:
  • public/WebConsoleMessage.h:
  • public/WebContentDetectionResult.h:
  • public/WebContextMenuData.h:
  • public/WebCrossOriginPreflightResultCache.h:
  • public/WebCursorInfo.h:
  • public/WebDOMEvent.h:
  • public/WebDOMEventListener.h:
  • public/WebDOMStringList.h:
  • public/WebDataSource.h:
  • public/WebDatabase.h:
  • public/WebDateTimeChooserCompletion.h:
  • public/WebDateTimeChooserParams.h:
  • public/WebDeliveredIntentClient.h:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • public/WebDevToolsFrontend.h:
  • public/WebDeviceOrientationClient.h:
  • public/WebDeviceOrientationClientMock.h:
  • public/WebDeviceOrientationController.h:
  • public/WebDocument.h:
  • public/WebDraggableRegion.h:
  • public/WebExternalPopupMenuClient.h:
  • public/WebFileChooserCompletion.h:
  • public/WebFileChooserParams.h:
  • public/WebFileSystemCallbacks.h:
  • public/WebFileSystemEntry.h:
  • public/WebFileWriter.h:
  • public/WebFileWriterClient.h:
  • public/WebFindOptions.h:
  • public/WebFont.h:
  • public/WebFontCache.h:
  • public/WebFontDescription.h:
  • public/WebFormControlElement.h:
  • public/WebFormElement.h:
  • public/WebFrame.h:
  • public/WebFrameClient.h:
  • public/WebGeolocationClientMock.h:
  • public/WebGeolocationController.h:
  • public/WebGeolocationError.h:
  • public/WebGeolocationPermissionRequest.h:
  • public/WebGeolocationPermissionRequestManager.h:
  • public/WebGeolocationPosition.h:
  • public/WebGlyphCache.h:
  • public/WebHelperPlugin.h:
  • public/WebHistoryItem.h:
  • public/WebHitTestResult.h:
  • public/WebIDBCallbacks.h:
  • public/WebIDBCursor.h:
  • public/WebIDBDatabase.h:
  • public/WebIDBDatabaseCallbacks.h:
  • public/WebIDBDatabaseError.h:
  • public/WebIDBFactory.h:
  • public/WebIDBIndex.h:
  • public/WebIDBKey.h:
  • public/WebIDBKeyPath.h:
  • public/WebIDBKeyRange.h:
  • public/WebIDBMetadata.h:
  • public/WebIDBObjectStore.h:
  • public/WebIDBTransaction.h:
  • public/WebIDBTransactionCallbacks.h:
  • public/WebIconURL.h:
  • public/WebImageDecoder.h:
  • public/WebInputEvent.h:
  • public/WebIntent.h:
  • public/WebIntentRequest.h:
  • public/WebIntentServiceInfo.h:
  • public/WebMediaPlayer.h:
  • public/WebMediaStreamRegistry.h:
  • public/WebMenuItemInfo.h:
  • public/WebNetworkStateNotifier.h:
  • public/WebNode.h:
  • public/WebNodeCollection.h:
  • public/WebNodeList.h:
  • public/WebNotification.h:
  • public/WebNotificationPresenter.h:
  • public/WebOptionElement.h:
  • public/WebPageOverlay.h:
  • public/WebPagePopup.h:
  • public/WebPageSerializer.h:
  • public/WebPasswordFormData.h:
  • public/WebPerformance.h:
  • public/WebPlugin.h:
  • public/WebPluginContainer.h:
  • public/WebPluginParams.h:
  • public/WebPopupMenu.h:
  • public/WebPopupMenuInfo.h:
  • public/WebPrerendererClient.h:
  • public/WebPrintParams.h:
  • public/WebRange.h:
  • public/WebRegularExpression.h:
  • public/WebRuntimeFeatures.h:
  • public/WebScopedMicrotaskSuppression.h:
  • public/WebScopedUserGesture.h:
  • public/WebScriptController.h:
  • public/WebScriptSource.h:
  • public/WebSearchableFormData.h:
  • public/WebSecurityOrigin.h:
  • public/WebSecurityPolicy.h:
  • public/WebSelectElement.h:
  • public/WebSettings.h:
  • public/WebSharedWorker.h:
  • public/WebSharedWorkerRepository.h:
  • public/WebSpeechGrammar.h:
  • public/WebSpeechInputController.h:
  • public/WebSpeechInputResult.h:
  • public/WebSpeechRecognitionHandle.h:
  • public/WebSpeechRecognitionParams.h:
  • public/WebSpeechRecognitionResult.h:
  • public/WebSpeechRecognizer.h:
  • public/WebSpeechRecognizerClient.h:
  • public/WebSpellCheckClient.h:
  • public/WebStorageEventDispatcher.h:
  • public/WebSurroundingText.h:
  • public/WebTestingSupport.h:
  • public/WebTextCheckingCompletion.h:
  • public/WebTextCheckingResult.h:
  • public/WebTextFieldDecoratorClient.h:
  • public/WebTextInputInfo.h:
  • public/WebTextRun.h:
  • public/WebTimeRange.h:
  • public/WebTouchPoint.h:
  • public/WebUserMediaRequest.h:
  • public/WebView.h:
  • public/WebViewBenchmarkSupport.h:
  • public/WebViewClient.h:
  • public/WebWidget.h:
  • public/WebWidgetClient.h:
  • public/WebWindowFeatures.h:
  • public/WebWorkerInfo.h:
8:48 AM Changeset in webkit [139322] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Serialization of Gradients fails when PlatformContextSkia is not bitmap backed
​https://bugs.webkit.org/show_bug.cgi?id=106559

Patch by Robert Phillips <​robertphillips@chromium.org> on 2013-01-10
Reviewed by Stephen White.

This patch switches over from having platform/Skia improperly
crack open the device to find the bitmap configuration to just
specifying it directly.

No new tests. This bug is Chromium specific and only occurs in a
debugging tool (when serializing to a Skia-specific file format).

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::createCompatibleDevice):

8:27 AM Changeset in webkit [139321] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

The "outline-offset" property is not found in the computed style property list
​https://bugs.webkit.org/show_bug.cgi?id=106561

Reviewed by Alexis Menard.

Source/WebCore:

Listed CSSPropertyOutlineOffset in the CSSComputedStyleDeclaration's computedProperties[].

Test: fast/css/getComputedStyle/getComputedStyle-outline-offset.html

  • css/CSSComputedStyleDeclaration.cpp:

LayoutTests:

  • fast/css/getComputedStyle/getComputedStyle-outline-offset-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-outline-offset.html: Added.
8:20 AM WebKit Team edited by nghanavatian@rim.com
adding myself to committers list (diff)
7:53 AM Changeset in webkit [139320] by Lucas Forschler
  • 4 edits in tags/Safari-537.25.1/Source

Versioning.

7:51 AM Changeset in webkit [139319] by Lucas Forschler
  • 1 copy in tags/Safari-537.25.1

New Tag.

7:31 AM Changeset in webkit [139318] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

PluginPackage::freeLibraryTimerFired asserts if plugin got loaded again meanwhile
​https://bugs.webkit.org/show_bug.cgi?id=106463

Patch by David Faure <​faure@kde.org> on 2013-01-10
Reviewed by Simon Hausmann.

No new tests, this code path will be tested by bug 106140.

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::freeLibraryTimerFired): skip unloading if loaded again meanwhile.

7:13 AM Changeset in webkit [139317] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

CSSParser does not allow the absence of whitespace between "and" and "expression"
​https://bugs.webkit.org/show_bug.cgi?id=106458

Patch by Alexander Pavlov <​apavlov@chromium.org> on 2013-01-10
Reviewed by Antti Koivisto.

  • fast/css/media-rule-no-whitespace-expected.txt: Added.
  • fast/css/media-rule-no-whitespace.html: Added.
6:40 AM Changeset in webkit [139316] by apavlov@chromium.org
  • 4 edits
    2 adds in trunk

CSSParser does not allow the absence of whitespace between "and" and "expression"
​https://bugs.webkit.org/show_bug.cgi?id=106458

Reviewed by Antti Koivisto.

Source/WebCore:

The issue was that a construct similar to "and(max-width: 480px)" looks like a function call (token type FUNCTION), even though
it is actually a MEDIA_AND followed by a parenthesized expression.

Test: fast/css/media-rule-no-whitespace.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::detectFunctionTypeToken): Return if the detection has been successful.
(WebCore::CSSParser::realLex): Test for media query tokens if function type detection has failed.

  • css/CSSParser.h:

LayoutTests:

  • fast/css/media-rule-no-whitespace-expected.txt: Added.
  • fast/css/media-rule-no-whitespace.html: Added.
6:23 AM Changeset in webkit [139315] by fmalita@chromium.org
  • 162 edits
    1 move
    1 add in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining results after ​http://trac.webkit.org/changeset/139191.

  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-lion/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-mac-lion/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-lion/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac-lion/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-lion/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-mac-lion/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-lion/fast/regions/full-screen-video-from-region-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
  • platform/chromium-mac-lion/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-lion/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/chromium-mac-lion/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-lion/media/audio-repaint-expected.png:
  • platform/chromium-mac-lion/media/controls-after-reload-expected.png:
  • platform/chromium-mac-lion/media/controls-layout-direction-expected.png:
  • platform/chromium-mac-lion/media/controls-strict-expected.png:
  • platform/chromium-mac-lion/media/controls-styling-expected.png:
  • platform/chromium-mac-lion/media/controls-styling-strict-expected.png:
  • platform/chromium-mac-lion/media/controls-without-preload-expected.png:
  • platform/chromium-mac-lion/media/media-controls-clone-expected.png:
  • platform/chromium-mac-lion/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-lion/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-lion/media/video-display-toggle-expected.png:
  • platform/chromium-mac-lion/media/video-empty-source-expected.png:
  • platform/chromium-mac-lion/media/video-no-audio-expected.png:
  • platform/chromium-mac-lion/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-lion/media/video-zoom-controls-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-snowleopard/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/regions/full-screen-video-from-region-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-leakage-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-mac/fast/box-shadow/spread-expected.png:
  • platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-mac/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/regions/full-screen-video-from-region-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac/fast/transforms/shadows-expected.png:
  • platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-layout-direction-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-strict-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/media-controls-clone-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-win/fast/backgrounds/background-leakage-expected.png:
  • platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-expected.png:
  • platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win/fast/css/shadow-multiple-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fast/regions/full-screen-video-from-region-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-layout-direction-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-styling-strict-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/media-controls-clone-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl-wk2/media/video-zoom-controls-expected.png: Renamed from LayoutTests/platform/efl/media/video-zoom-controls-expected.png.
6:01 AM Changeset in webkit [139314] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/inspector.css

Merge 138166

Web Inspector: default font on mac is Monaco (should do be Menlo)
​https://bugs.webkit.org/show_bug.cgi?id=105435

Reviewed by Alexander Pavlov.

Regressed when I introduced mountain lion modifier in the inspector.css.

  • inspector/front-end/inspector.css:

(body.platform-mac .monospace, body.platform-mac .source-code):
(body.platform-mac.platform-mac-tiger .source-code):

TBR=​pfeldman@chromium.org
Review URL: ​https://codereview.chromium.org/11823053

5:46 AM Changeset in webkit [139313] by alexis@webkit.org
  • 4 edits
    2 adds in trunk

ASSERT_NOT_REACHED in StylePropertySet::fontValue when accessing font style property through JS after setting style font size.
​https://bugs.webkit.org/show_bug.cgi?id=88866

Reviewed by Alexander Pavlov.

Source/WebCore:

StylePropertySet::fontValue always assumed that it was called using
style.font after a subsequent call which set the shorthand font. The
ASSERT_NOT_REACHED assumed that all longhands of the font shorthand not
set by the shorthand itself were set to initial. While it's true when
we set the font shorthand (i.e all longhands are set to implicit initial)
it is not true when you set the longhands individually. For example setting
font-size will not set other font properties to initial. It is the behavior of all
other shorthands in WebKit. When reconstructing the shorthand other
properties tests whether the value of each longhands is initial or not
(if not then we omit the value, as we should always construct the
shortest shorthand possible) or if the value is set or not (if set then
we include it in the shorthand if not then we omit it). The comment
removed was also talking about invalid font property potentially built
by fontValue(). So far appendFontLonghandValueIfExplicit will always
construct a valid value as it takes care of adding ' ' or '/' when
needed, so the return value is parsable and correct.

Test: fast/css/font-shorthand-from-longhands.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::appendFontLonghandValueIfExplicit):
(WebCore::StylePropertySet::fontValue):

  • css/StylePropertySet.h:

LayoutTests:

Add tests to cover the bug.

  • fast/css/font-shorthand-from-longhands-expected.txt: Added.
  • fast/css/font-shorthand-from-longhands.html: Added.
5:37 AM Changeset in webkit [139312] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Contents gets blurry when page is scrolled down
​https://bugs.webkit.org/show_bug.cgi?id=106545

Reviewed by Kenneth Rohde Christiansen.

The bound values for scrolling also should be pixel aligned, otherwise
it leads to page contents blurriness when the page is scrolled down.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::pageDidRequestScroll):

4:28 AM Changeset in webkit [139311] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Marking one more flaky crasher due to gstreamer.

  • platform/efl/TestExpectations:
4:28 AM Changeset in webkit [139310] by loislo@chromium.org
  • 21 edits in trunk/Source/WebCore

Unreviewed, rolling out r139306.
​http://trac.webkit.org/changeset/139306
​https://bugs.webkit.org/show_bug.cgi?id=106550

it broke inspector-protocol/nmi-webaudio-leak-test.html
(Requested by loislo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-10

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reportMemoryUsage):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::reportMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/MediaList.cpp:

(WebCore::MediaList::reportMemoryUsage):

  • css/RuleSet.cpp:

(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::reportMemoryUsage):

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::reportMemoryUsage):

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::reportMemoryUsage):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::reportMemoryUsage):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):

  • page/Page.cpp:

(WebCore::Page::reportMemoryUsage):

4:25 AM Changeset in webkit [139309] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Marking three media tests as flaky crashers.

  • platform/efl/TestExpectations:
4:07 AM Changeset in webkit [139308] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed gardening, paint the bots green.

  • platform/qt/TestExpectations: Skip http/tests/security/isolatedWorld/* tests instead of marking them as failures. (r138817)
  • platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.png: Added after r139197.
  • platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.txt: Added after r139197.
3:49 AM Changeset in webkit [139307] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Fix ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.htm expectation lines

Unreviewed gardening.

  • platform/chromium/TestExpectations: Two bugs and expectation lines refer to this test, and one

expectation line overrides the other: assign to the earlier bug and ditch the redundant line.

3:31 AM Changeset in webkit [139306] by loislo@chromium.org
  • 21 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 2/N
​https://bugs.webkit.org/show_bug.cgi?id=106546

Reviewed by Vsevolod Vlasov.

Many nontrivial class members were instrumented in reportMemoryUsage methods.

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reportMemoryUsage):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::reportMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/MediaList.cpp:

(WebCore::MediaList::reportMemoryUsage):

  • css/RuleSet.cpp:

(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::reportMemoryUsage):

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::reportMemoryUsage):

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::reportMemoryUsage):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::reportMemoryUsage):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):

  • page/Page.cpp:

(WebCore::Page::reportMemoryUsage):

3:27 AM Changeset in webkit [139305] by commit-queue@webkit.org
  • 19 edits
    4 copies
    12 adds in trunk

[GTK] Add support for loading web process extensions
​https://bugs.webkit.org/show_bug.cgi?id=105631

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-01-10
Reviewed by Gustavo Noronha Silva.

.:

  • GNUmakefile.am: Add webkit2_web_extension_h_api.
  • Source/autotools/symbols.filter: Export WebGtkExtensionManager

symbols required by the injected bundle lib.

Source/WebKit2:

  • GNUmakefile.am: Link to libWebCoreDOM.la and build injected

bundle lib.

  • GNUmakefile.list.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(injectedBundleDirectory): Helper funtion to get the injected
bundle directory.
(injectedBundleFilename): Helper funtion to get the injected undle
library full path.
(createDefaultWebContext): Create the WebContext with an injected
bundle path.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_page_id): Return the identifier of the web
page associated to the web view.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new chapter for

web extensions.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Add new types.
  • UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/tests/TestMain.cpp:

(main):

  • UIProcess/API/gtk/tests/TestWebExtensions.cpp: Added.

(testWebExtension):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/tests/WebExtensionTest.cpp: Added.

(methodCallCallback):
(webkit_web_extension_initialize):

  • UIProcess/API/gtk/tests/WebKitTestBus.cpp: Added.

(WebKitTestBus::WebKitTestBus):
(WebKitTestBus::run):
(WebKitTestBus::~WebKitTestBus):
(WebKitTestBus::connection):
(onNameAppeared):
(WebKitTestBus::createProxy):

  • UIProcess/API/gtk/tests/WebKitTestBus.h: Added.

(WebKitTestBus):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp: Added.

(_WebKitWebExtensionPrivate):
(webkitWebExtensionPageCreated): Create a WebKitWebPage for the
newly crated page and emit WebKitWebExtension::page-created
signals.
(webkitWebExtensionPageDestroy): Remove the page from the map.
(didCreatePage): Call webkitWebExtensionPageCreated().
(willDestroyPage): Call webkitWebExtensionPageDestroy().
(webkitWebExtensionCreate): Create a new WebKitWebExtension and
initialize the injected bundle client.
(webkit_web_extension_get_page): Return the WebKitWebPage for the
given page identifier.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.h: Added.

(_WebKitWebExtension):
(_WebKitWebExtensionClass):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionDefines.h: Added.
  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionPrivate.h: Added.
  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp: Added.

(_WebKitWebPagePrivate):
(webkit_web_page_class_init):
(webkitWebPageCreate): Create a new WebKitWebPage.
(webkit_web_page_get_dom_document): Return the WebKitDOMDocument
loaded in the WebKitWebPage.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h: Added.

(_WebKitWebPage):
(_WebKitWebPageClass):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPagePrivate.h: Added.
  • WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h: Added.
  • WebProcess/gtk/WebGtkExtensionManager.cpp: Added.

(WebKit::WebGtkExtensionManager::shared): Return the global shared
instance.
(WebKit::WebGtkExtensionManager::WebGtkExtensionManager):
(WebKit::WebGtkExtensionManager::appendModuleDirectories): Add
directories to scan for modules.
(WebKit::WebGtkExtensionManager::scanModules): Scan for modules.
(WebKit::WebGtkExtensionManager::initialize): Load and initialize
the modules found.

  • WebProcess/gtk/WebGtkExtensionManager.h: Added.
  • WebProcess/gtk/WebGtkInjectedBundleMain.cpp: Added.

(WKBundleInitialize): Initialize WebGtkExtensionManager.

Tools:

  • MiniBrowser/gtk/GNUmakefile.am:
  • MiniBrowser/gtk/main.c:

(main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
bundle lib from build dir.

  • Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API

located in WebProcess/InjectedBundle/API/gtk.

  • gtk/generate-gtkdoc:

(get_webkit2_options): Scan also files in
WebProcess/InjectedBundle/API/gtk to generate API docs.
(get_webkit2_options.injected_bundle_src_path): Helper function to
build paths in WebProcess/InjectedBundle/API/gtk.

3:14 AM Changeset in webkit [139304] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Remove lost-compositor-context layout tests
​https://bugs.webkit.org/show_bug.cgi?id=106089

Unreviewed gardening.

  • platform/chromium/TestExpectations: Remove all references to the

lost-compositor-context test expectations after r138814.

3:04 AM Changeset in webkit [139303] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Tools

[EFL][WK2] Writing immediately to created windows (open) fails
​https://bugs.webkit.org/show_bug.cgi?id=105276

Reviewed by Kenneth Rohde Christiansen.

Do not reset 'about:blank' url for the new pages in mini browser.

  • MiniBrowser/efl/main.c:

(window_create):

2:52 AM Changeset in webkit [139302] by noel.gordon@gmail.com
  • 2 edits
    1 delete in trunk/LayoutTests

[chromium] Optimize expectations for fast/forms/button-inner-block-reuse.html

Unreviewed gardening.

  • platform/chromium-win-xp/fast/forms/button-inner-block-reuse-expected.png: Removed.
  • platform/chromium-win/fast/forms/button-inner-block-reuse-expected.png:
2:47 AM EFLWebKit edited by Christophe Dumez
Remove gstreamer from dependencies since it is in jhbuild now and add … (diff)
2:42 AM Changeset in webkit [139301] by noel.gordon@gmail.com
  • 2 edits
    1 delete in trunk/LayoutTests

[chromium] Optimize expectaions for fast/forms/button-generated-content.html

Unreviewed gardening.

  • platform/chromium-win-xp/fast/forms/button-generated-content-expected.png: Removed.
  • platform/chromium-win/fast/forms/button-generated-content-expected.png:
1:59 AM Changeset in webkit [139300] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r139189): pixel alignment must be performed in device units.
​https://bugs.webkit.org/show_bug.cgi?id=106504

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

After r139189, pixel alignment is performed in UI units. If deviceScaleFactor is
fractional number, adjusted scroll position can blur non-composited layer.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::pixelAlignedFloatPoint):

1:58 AM Changeset in webkit [139299] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Changing tests to be consistent and use self.scm rather then recreating the scm object.
​https://bugs.webkit.org/show_bug.cgi?id=106536

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1:35 AM Changeset in webkit [139298] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Marking a missing expectation for fast/repaint/caret-with-transformation.html

  • platform/efl/TestExpectations:
1:21 AM Changeset in webkit [139297] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing a few failure expectations that are no longer needed.
The tests the expectations were covering now pass.

  • platform/gtk/TestExpectations:
1:17 AM Changeset in webkit [139296] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a platform-specific baseline for a CSS Regions test.
Adding a missing expectation for the fast/repaint/caret-with-transformation.html layout test.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/regions/selecting-text-through-different-region-flows-expected.txt: Added.
1:15 AM Changeset in webkit [139295] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Handle the case that start/end position is out of unclipped selection region
​https://bugs.webkit.org/show_bug.cgi?id=106486

Patch by Yongxin Dai <​yodai@rim.com> on 2013-01-10
Reviewed by Rob Buis.

PR #270624
Unclipped selection region should cover start/end position of the selection.
Since we exclude hidden text when calculating unclipped selection region, the
start/end position can be out of unclipped selection region if it is for hidden
text. If that is the case, start/end handle will be invisible. To avoid invisible
handle, we take unclipped selection region as reference rectangle in the case.

Internally reviewed by Genevieve Mak, Mike Fenton

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::referencePoint):

1:06 AM Changeset in webkit [139294] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Converting to unittest2 so we can use assertItemsEqual, making tests
not dependent on order of items.
​https://bugs.webkit.org/show_bug.cgi?id=106532

Before:
Ran 1733 tests in 38.385s
FAILED (failures=1, errors=22)

After:
Ran 1733 tests in 32.298s
FAILED (failures=0, errors=22)

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_unittest2):

12:59 AM Changeset in webkit [139293] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] [Gtk] web inspector is not visible.
​https://bugs.webkit.org/show_bug.cgi?id=106050

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-01-10
Reviewed by Carlos Garcia Campos.

Use webkitWebViewBaseAddWebInspector when adding web inspector to
webview in order to make webview aware of its existence.

Use gtk_container_add when adding web inspector wiew to its own window
because m_inspectorWindow is not a WebKitWebViewBase.

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformAttach):

12:45 AM Changeset in webkit [139292] by Christophe Dumez
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Add platform expectation for new test added in r139197.

  • platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
  • platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.txt: Added.
12:42 AM Changeset in webkit [139291] by Christophe Dumez
  • 14 edits
    1 delete in trunk

[EFL] Add gstreamer 1.0.5 to jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=106178

Reviewed by Laszlo Gombos.

.:

Update EFL CMake configuration to require gstreamer
1.0.5.

  • Source/cmake/FindGStreamer.cmake:
  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Remove GSTREAMER_INTERFACES_LIBRARIES from EFL
CMake configuration.

No new tests, no behavior change for layout tests.

  • PlatformEfl.cmake:

Source/WebKit:

Remove GSTREAMER_INTERFACES_LIBRARIES from EFL
CMake configuration.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Fix compilation error when using gstreamer 1.0.

  • WebCoreSupport/FullscreenVideoControllerEfl.cpp:
  • WebCoreSupport/FullscreenVideoControllerEfl.h:

Tools:

Add gstreamer 1.0.5 to EFL's jhbuild configuration.

  • efl/jhbuild.modules:

LayoutTests:

Skip several media tests that are crashing with gstreamer 1.0.

  • platform/efl/TestExpectations:
  • platform/efl/media/sources-fallback-codecs-expected.txt: Removed.

Jan 9, 2013:

11:44 PM Changeset in webkit [139290] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r139266.

r139266 broke the debug build of the gstreamer backend due
to a missing header include.

No new tests, no behavior change.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
11:33 PM Changeset in webkit [139289] by alecflett@chromium.org
  • 25 edits
    2 deletes in trunk/Source

IndexedDB: Allow createIndex/createObjectStore to be asynchronous
​https://bugs.webkit.org/show_bug.cgi?id=106377

Reviewed by Tony Chang.

Source/WebCore:

Migrate implementations of createIndex/deleteIndex,
createObjectStore/deleteObjectStore over to IDBDatabaseBackendImpl,
so that they can be asynchronous in multi-process ports.

Has the side effect of removing the last consumers of
IDBIndexBackendImpl and IDBObjectStoreBackendImpl. The former
is removed complete and the latter becomes a temporary namespace
pending a further more mechanical code shuffle.

A key refactoring effect is that the IDBDatabaseBackendImpl
now contains the authoritative IDBDatabaseMetadata hierarchy,
and updates to it are consolidated in one place rather than
scattered across a parallel object tree.

No new tests as this is just refactoring.

  • Modules/indexeddb/IDBBackingStore.cpp: Simplify objectstore/index loading and propagate errors.

(WebCore::IDBBackingStore::getObjectStores):
(WebCore::IDBBackingStore::getIndexes):

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp: Dependency cleanup.
  • Modules/indexeddb/IDBCursorBackendImpl.h: Dependency cleanup.

(WebCore):

  • Modules/indexeddb/IDBDatabase.cpp: Frontend IDBObjectStores no longer hold onto backend objects.

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Add all create/deleteIndex operations from IDBIndexBackendImpl.

(WebCore::CreateObjectStoreOperation::create):
(WebCore::CreateObjectStoreOperation::CreateObjectStoreOperation):
(CreateObjectStoreOperation):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::DeleteObjectStoreOperation):
(DeleteObjectStoreOperation):
(WebCore::CreateObjectStoreAbortOperation::create):
(WebCore::CreateObjectStoreAbortOperation::CreateObjectStoreAbortOperation):
(CreateObjectStoreAbortOperation):
(WebCore::DeleteObjectStoreAbortOperation::create):
(WebCore::DeleteObjectStoreAbortOperation::DeleteObjectStoreAbortOperation):
(DeleteObjectStoreAbortOperation):
(CreateIndexOperation):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexOperation::CreateIndexOperation):
(WebCore):
(DeleteIndexOperation):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(CreateIndexAbortOperation):
(WebCore::CreateIndexAbortOperation::create):
(WebCore::CreateIndexAbortOperation::CreateIndexAbortOperation):
(DeleteIndexAbortOperation):
(WebCore::DeleteIndexAbortOperation::create):
(WebCore::DeleteIndexAbortOperation::DeleteIndexAbortOperation):
(WebCore::GetOperation::GetOperation):
(WebCore::IDBDatabaseBackendImpl::addObjectStore):
(WebCore::IDBDatabaseBackendImpl::removeObjectStore):
(WebCore::IDBDatabaseBackendImpl::addIndex):
(WebCore::IDBDatabaseBackendImpl::removeIndex):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::metadata):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::CreateObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::createIndex):
(WebCore::CreateIndexOperation::perform):
(WebCore::CreateIndexAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteIndex):
(WebCore::DeleteIndexOperation::perform):
(WebCore::DeleteIndexAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::get):
(WebCore::IDBDatabaseBackendImpl::put):
(WebCore::IDBDatabaseBackendImpl::setIndexKeys):
(WebCore::IDBDatabaseBackendImpl::count):
(WebCore::DeleteRangeOperation::perform):
(WebCore::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteDatabaseFinal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores): Load directly into metadata from backing store.
(WebCore::CreateObjectStoreAbortOperation::perform):
(WebCore::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore):
(IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp: Removed.
  • Modules/indexeddb/IDBIndexBackendImpl.h: Removed.
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::IDBObjectStore): Frontend IDBIndex objects no longer hold onto backend.
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::create):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore):
(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):

  • Modules/indexeddb/IDBTransaction.h:
  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:
  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore::IDBTransactionBackendImpl::objectStore):

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Remove this test as it makes no sense once the objectstore/index
hierarchy is gone.

  • tests/IDBDatabaseBackendTest.cpp:
11:26 PM Changeset in webkit [139288] by noel.gordon@gmail.com
  • 1 edit
    1 add in trunk/LayoutTests

New chromium-mac pixel baseline for gradient-background-leakage-hidpi.html
​https://bugs.webkit.org/show_bug.cgi?id=106373

Unreviewed gardening.

  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
11:07 PM Changeset in webkit [139287] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] Add guard around NativeWebTouchEvent
​https://bugs.webkit.org/show_bug.cgi?id=105846

Patch by Seokju Kwon <Seokju Kwon> on 2013-01-09
Reviewed by Benjamin Poulain.

Fix EFL build without TOUCH_EVENTS.

  • Shared/efl/NativeWebTouchEventEfl.cpp: Add TOUCH_EVENTS guard.
11:05 PM Changeset in webkit [139286] by noel.gordon@gmail.com
  • 1 edit
    1 move
    1 add
    1 delete in trunk/LayoutTests

Update expectations for fast/forms/button-generated-content.html

Unreviewed gardening.

  • fast/forms/button-generated-content-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/button-generated-content-expected.txt.
  • platform/chromium-win-xp/fast/forms/button-generated-content-expected.png: Added.
  • platform/mac/fast/forms/button-generated-content-expected.txt: Removed.
11:05 PM Changeset in webkit [139285] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Don't throw exceptions when we don't have a callstack
​https://bugs.webkit.org/show_bug.cgi?id=104849

Patch by John J. Barton <​johnjbarton@chromium.org> on 2013-01-09
Reviewed by Pavel Feldman.

Check array details.callFrames.length before accessing array;

No new tests, but this fix may help us find the cause of 'other' reasons.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._debuggerPaused):

10:52 PM Changeset in webkit [139284] by noel.gordon@gmail.com
  • 1 edit
    1 move
    1 add
    1 delete in trunk/LayoutTests

Update expectations for fast/forms/button-inner-block-reuse.html

Unreviewed gardening.

  • fast/forms/button-inner-block-reuse-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/button-inner-block-reuse-expected.txt.
  • platform/chromium-win-xp/fast/forms/button-inner-block-reuse-expected.png: Added.
  • platform/mac/fast/forms/button-inner-block-reuse-expected.txt: Removed.
10:28 PM Changeset in webkit [139283] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Network] Data grid header and content cells are misaligned.
​https://bugs.webkit.org/show_bug.cgi?id=105795

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-09
Reviewed by Pavel Feldman.

Header and content tables have different width -> same percent values
turn to different cell widths.

  • inspector/front-end/DataGrid.js: Add "corner" cell to all rows.
  • inspector/front-end/dataGrid.css: Apply "corner" rules to "td" nodes.

(.data-grid .data-container): Remove artificial padding.

10:23 PM Changeset in webkit [139282] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk

Make caret repainting container-aware
​https://bugs.webkit.org/show_bug.cgi?id=103955

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-01-09
Reviewed by Simon Fraser.

Source/WebCore:

Only invalidate local rects on the caret's repaint container,
instead of invalidating an absolute rect on the whole view.

Test: fast/repaint/caret-with-transformation.html

  • editing/FrameSelection.cpp:

(WebCore::caretRendersInsideNode):
(WebCore::caretRenderer):
(WebCore::FrameSelection::caretRenderer):
(WebCore::DragCaretController::caretRenderer):
(WebCore::repaintCaretForLocalRect):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::CaretBase::invalidateCaretRect):
(WebCore::FrameSelection::focusedOrActiveStateChanged):

  • editing/FrameSelection.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::repaintSelection):

  • rendering/RenderView.h:

LayoutTests:

The caret repaint padding has been removed. Needs rebaseline.
Added test that carets should be repainted correctly on a transformed element.

  • fast/repaint/caret-with-transformation.html: Added.
  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
9:57 PM Changeset in webkit [139281] by noel.gordon@gmail.com
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Add win mac expectations for r139256
​https://bugs.webkit.org/show_bug.cgi?id=106404

Unreviewed gardening.

  • platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png: Added.
  • platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png: Added.
9:53 PM Changeset in webkit [139280] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Rebaseline the binding test after r139278.

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::getOwnPropertySlot):

8:41 PM Changeset in webkit [139279] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Updated parameters in GCE build scripts so they now work.
​https://bugs.webkit.org/show_bug.cgi?id=106523

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-09
Reviewed by Adam Barth.

  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/cold-boot.sh:
7:55 PM Changeset in webkit [139278] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

[JSC] REGRESSION(r135093): A form control with name=length overrides length property on form.elements
​https://bugs.webkit.org/show_bug.cgi?id=105775

Reviewed by Sam Weinig.

Source/WebCore:

Fixed the bug by respecting properties on ancestor classes.

Test: fast/dom/collection-length-should-not-be-overridden.html

  • bindings/js/JSDOMBinding.h:

(WebCore::getStaticValueSlotEntryWithoutCaching): Added.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody): Use getStaticValueSlotEntryWithoutCaching to climb up the class
hierarchy.

LayoutTests:

Added a regression tests for all known HTMLCollection sublcasses except HTMLNameCollection,
which is used only to implement named getters on window and document objects and HTMLPropertiesCollection
since it's not enabled on all ports yet.

  • fast/dom/collection-length-should-not-be-overridden-expected.txt: Added.
  • fast/dom/collection-length-should-not-be-overridden.html: Added.
7:44 PM Changeset in webkit [139277] by pilgrim@chromium.org
  • 3 edits in trunk/Tools

[Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=106520

Reviewed by James Robinson.

Part of a larger refactoring series. See tracking bug 82948.

  • DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
7:42 PM Changeset in webkit [139276] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] [WebGL] Remove GLX dependencies from X11WindowResources..
​https://bugs.webkit.org/show_bug.cgi?id=106319

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2013-01-09
Reviewed by Kenneth Rohde Christiansen.

This patch removes GLX specific calls from X11WindowResources.
This class is shared by both GLX and EGL implementations.

  • platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore::GLXTransportSurface::setGeometry):

  • platform/graphics/surfaces/glx/X11WindowResources.cpp:

(WebCore::X11OffScreenWindow::reSizeWindow):

7:33 PM Changeset in webkit [139275] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Remove deviceScaleFactor argument in computeMinimumScaleFactorForContentContained().
​https://bugs.webkit.org/show_bug.cgi?id=106500

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-09
Reviewed by Kenneth Rohde Christiansen.

deviceScaleFactor argument is not used after r139189.

Source/WebCore:

No new tests. Refactoring only.

  • dom/ViewportArguments.cpp:

(WebCore::computeMinimumScaleFactorForContentContained):

  • dom/ViewportArguments.h:

(WebCore):

Source/WebKit2:

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::updateMinimumScaleToFit):

7:11 PM Changeset in webkit [139274] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[QT][EFL][WK2] Rename scale members in PageViewportController.
​https://bugs.webkit.org/show_bug.cgi?id=106499

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-09
Reviewed by Kenneth Rohde Christiansen.

Rename from m_contentsScale to m_pageScaleFactor and from devicePixelRatio() to
deviceScaleFactor() to match terms of WebCore.

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::devicePixelRatio):

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::deviceScaleFactor):
(WebKit::PageViewportController::pixelAlignedFloatPoint):
(WebKit::PageViewportController::boundContentsPosition):
(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::visibleContentsSize):
(WebKit::PageViewportController::applyScaleAfterRenderingContents):
(WebKit::PageViewportController::updateMinimumScaleToFit):

  • UIProcess/PageViewportController.h:

(PageViewportController):
(WebKit::PageViewportController::currentContentsScale):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::updateViewportSize):

6:51 PM Changeset in webkit [139273] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Node::containingShadowRoot should be constant time
​https://bugs.webkit.org/show_bug.cgi?id=106494

Patch by Elliott Sprehn <Elliott Sprehn> on 2013-01-09
Reviewed by Dimitri Glazkov.

There's no reason to traverse up the tree to find the containing
ShadowRoot when we already know if we're in a ShadowRoot by looking at
the treeScope().

No new tests, just refactoring.

  • dom/Node.cpp:

(WebCore::Node::containingShadowRoot):

6:50 PM Changeset in webkit [139272] by jparent@chromium.org
  • 2 edits in trunk/Tools

Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
​https://bugs.webkit.org/show_bug.cgi?id=106514

This is old code, as these can no longer get out of sync.
permmaLinkURLHash is generated from currentState, which is set only
from the location. The commment about how these can get out of sync
refers to a function that no longer exists.

Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/dashboard_base.js:

(handleLocationChange):

6:41 PM Changeset in webkit [139271] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

6:35 PM Changeset in webkit [139270] by jparent@chromium.org
  • 2 edits in trunk/Tools

Dashboard Cleanup: Reload the page as soon as we know we need to.
​https://bugs.webkit.org/show_bug.cgi?id=106515

No need to continue parsing all of the data once we know that
we need to do a reload.

Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/dashboard_base.js:

(parseParameters):

6:29 PM Changeset in webkit [139269] by morrita@google.com
  • 17 edits in trunk

[Shadow DOM] Distribution related code on ElementShadow should be minimized.
​https://bugs.webkit.org/show_bug.cgi?id=106294

Reviewed by Dimitri Glazkov.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

This change moves ElementShadow::m_selectFeatures,
m_shouldCollectSelectFeatureSet and related methods to
ContentDistributor.

There are also some renaming and small refactorings for better fit
on new place:

  • shouldCollectSelectFeatureSet is renamed needsSelectorRuleSet for conciseness.
  • setShouldCollectSelectFeatureSet() which used recursion morphed into iterative willAffectSelector().
  • ensureDistributionFromDocument() becomes a static method.

No new tests. Refactoring.

  • WebCore.exp.in:
  • dom/Element.cpp:

(WebCore::Element::shouldInvalidateDistributionWhenAttributeChanged):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::addShadowRoot):
(WebCore::ElementShadow::removeAllShadowRoots):

  • dom/ElementShadow.h:

(ElementShadow):
(WebCore::ElementShadow::invalidateDistribution):
(WebCore::ElementShadow::ensureDistribution):
(WebCore::ElementShadow::didAffectSelector):
(WebCore::ElementShadow::willAffectSelector):
(WebCore::ElementShadow::containingShadow):
(WebCore):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ScopeContentDistribution::registerInsertionPoint):
(WebCore::ScopeContentDistribution::unregisterInsertionPoint):
(WebCore::ContentDistributor::ContentDistributor):
(WebCore::ContentDistributor::ensureDistribution):
(WebCore):
(WebCore::ContentDistributor::ensureDistributionFromDocument):
(WebCore::ContentDistributor::invalidateDistribution):
(WebCore::ContentDistributor::ensureSelectFeatureSet):
(WebCore::ContentDistributor::collectSelectFeatureSetFrom):
(WebCore::ContentDistributor::didAffectSelector):
(WebCore::ContentDistributor::willAffectSelector):
(WebCore::ContentDistributor::didShadowBoundaryChange):

  • html/shadow/ContentDistributor.h:

(ScopeContentDistribution):
(WebCore::ContentDistributor::needsSelectFeatureSet):
(WebCore::ContentDistributor::setNeedsSelectFeatureSet):
(ContentDistributor):
(WebCore::ContentDistributor::setValidity):
(WebCore::ContentDistributor::needsInvalidation):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::parseAttribute):

  • html/shadow/HTMLContentElement.h:
  • html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::olderShadowRoot):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::getDistributedNodes):
(WebCore::InsertionPoint::insertedInto):
(WebCore::InsertionPoint::removedFrom):

  • html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::canAffectSelector):

  • testing/Internals.cpp:

(WebCore::Internals::hasSelectorForIdInShadow):
(WebCore::Internals::hasSelectorForClassInShadow):
(WebCore::Internals::hasSelectorForAttributeInShadow):
(WebCore::Internals::hasSelectorForPseudoClassInShadow):

Source/WebKit/win:

  • WebKit.vcproj/WebKit.def.in:
6:26 PM Changeset in webkit [139268] by Lucas Forschler
  • 1 copy in tags/Safari-537.25

New Tag.

6:24 PM Changeset in webkit [139267] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

Assert triggered in SelectorChecker::checkOneSelector when scrollbar (e.g. :horizontal) selector is specified.
​https://bugs.webkit.org/show_bug.cgi?id=106414

Reviewed by Dimitri Glazkov.

Source/WebCore:

In SelectorChecker::checkOneSelector, scrollbar related pseudoType (e.g. :horizontal) is not handled anywhere.
This caused ASSERT triggered. We have to check them.

Test: fast/css/scrollbar-crash.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

LayoutTests:

  • fast/css/scrollbar-crash-expected.txt: Added.
  • fast/css/scrollbar-crash.html: Added.
6:16 PM Changeset in webkit [139266] by fpizlo@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix build after ​http://trac.webkit.org/changeset/139262

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:
6:07 PM Changeset in webkit [139265] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Just move the JavaScriptCore exports file around in the vcproj to make things clearer.

5:59 PM Changeset in webkit [139264] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Dont use a node reference after appending to the graph.
​https://bugs.webkit.org/show_bug.cgi?id=103305
<rdar://problem/12753096>

Reviewed by Mark Hahnenberg.

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

5:56 PM Changeset in webkit [139263] by eric@webkit.org
  • 3 edits in trunk/Tools

run-perf-tests --chromium-android --profile should show symbols for the kernel
​https://bugs.webkit.org/show_bug.cgi?id=106498

Reviewed by Adam Barth.

Turns out this was easy, once I finally read the output from "perf report".
It appears there may be a bug in "perf record" on android, as it complains
about not being able to read from /proc/kallsyms even when
/proc/sys/kernel/kptr_restrict is 0. For now I've not bothered
to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
but rather just flip it to 0 long enough to grab the /proc/kallsyms
and then flip it back to whatever the device had.

/proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
on Linux. /proc/kallsyms contains a mapping of kernel addresses
to symbol names. Its world-readable, but will return all 0s if you
don't have permission to see the kernel symbols. kptr_restrict
supports values 0, 1, 2. Where 0 means "everyone can see the real symbols"
1 is only a specific group, and 2 is "no one, not even root".
By default kptr_restrict is 2 on Android it seems.
More kptr_restrict docs: ​http://lwn.net/Articles/420403/

I also took this opportunity to clean up how the perf record command
was built for use/display in AndroidPerf.profile_after_exit and
change to always using long-form names for the arguments (to hopefully help readability).

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(AndroidPerf.init):
(profile_after_exit):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._update_kallsyms_cache):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
5:40 PM Changeset in webkit [139262] by crogers@google.com
  • 14 edits in trunk/Source

Allow live/local audio input to be enabled only when needed
​https://bugs.webkit.org/show_bug.cgi?id=106490

Source/Platform:

Reviewed by Kenneth Russell.

  • chromium/public/Platform.h:

(Platform):
(WebKit::Platform::createAudioDevice):

Source/WebCore:

Reviewed by Kenneth Russell.

WebAudio can process live/local audio input using a MediaStreamAudioSourceNode.
But currently the audio back-end is not able to know when/if audio input will be
needed, so it needs to assume the worst and initialize the system to support potential
audio input in all cases. For some audio back-ends this can end up being less efficient
than initializing for audio output only. This patch adds the ability for the audio back-end
to be able to initialize itself for audio input later on, only when/if it's needed.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource):

  • Modules/webaudio/AudioDestinationNode.h:

(AudioDestinationNode):

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
(WebCore::DefaultAudioDestinationNode::initialize):
(WebCore::DefaultAudioDestinationNode::uninitialize):
(WebCore::DefaultAudioDestinationNode::createDestination):
(WebCore):
(WebCore::DefaultAudioDestinationNode::enableInput):

  • Modules/webaudio/DefaultAudioDestinationNode.h:

(DefaultAudioDestinationNode):

  • Modules/webaudio/OfflineAudioDestinationNode.h:

(OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::sampleRate):

  • platform/audio/AudioDestination.h:

(AudioDestination):

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestination::create):

  • platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestination::create):

Source/WebKit/chromium:

Reviewed by Kenneth Russell.

  • src/AudioDestinationChromium.cpp:

(WebCore):
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::render):

  • src/AudioDestinationChromium.h:

(AudioDestinationChromium):

5:33 PM Changeset in webkit [139261] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[WK2][soup] Get rid of LocalTerminationDisabler
​https://bugs.webkit.org/show_bug.cgi?id=106510

Unreviewed build fix.

With r139257(bug 106501), the LocalTerminationDisabler was removed from WebKit::ChildProcess.
So, it should be removed on setCookiePersistentStorage, too.

Patch by KyungTae Kim <​ktf.kim@samsung.com> on 2013-01-09

  • WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:

(WebKit::WebCookieManager::setCookiePersistentStorage):

5:33 PM Changeset in webkit [139260] by jparent@chromium.org
  • 2 edits in trunk/Tools

Dashboard cleanup: remove dead code.
​https://bugs.webkit.org/show_bug.cgi?id=106509

Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/dashboard_base.js:

(parseParameters):

5:00 PM Changeset in webkit [139259] by roger_fong@apple.com
  • 10 edits
    2 moves in trunk/Source

Rename export files to make them more easily findable.
​https://bugs.webkit.org/show_bug.cgi?id=98695.

Reviewed by Timothy Horton.

  • WebKit.vcproj/WebKit.def.in: Removed.
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitExportGenerator.vcproj:
  • WebKit.vcproj/WebKitExportGeneratorBuildCmd.cmd:
  • WebKit.vcproj/WebKitExportGeneratorPostBuild.cmd:
  • WebKit.vcproj/WebKitExportGeneratorPreBuild.cmd:
  • WebKit.vcproj/WebKitExports.def.in: Copied from Source/WebKit/win/WebKit.vcproj/WebKit.def.in.
  • WebKit.vcproj/WebKitLibCommon.vsprops:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def.
4:50 PM Changeset in webkit [139258] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Don't drop to huge tile mode if we're only slow-scrolling because of a page overlay
​https://bugs.webkit.org/show_bug.cgi?id=106502
<rdar://problem/12959143>

Reviewed by Simon Fraser.

We only use the MainThreadScrollingReason "ForcedOnMainThread" if WebKit2 installs
a page overlay (TiledCoreAnimationDrawingArea::didInstallPageOverlay), which clients
can cause arbitrarily.

We probably should still use default-sized tiles in this case (this will also
prevent us from falling into gigantic tiles for WebKit2 find-in-page, among other things).

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::adjustTileCacheCoverage):

4:46 PM Changeset in webkit [139257] by ap@apple.com
  • 9 edits in trunk/Source/WebKit2

[WK2] Get rid of LocalTerminationDisabler
​https://bugs.webkit.org/show_bug.cgi?id=106501

Reviewed by Anders Carlsson.

LocalTerminationDisabler is no-op - termination timer can't fire inside its scope
even if not stopped.

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::getSitesWithData): (WebKit::PluginProcess::clearSiteData):
  • Shared/ChildProcess.h:
  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: (WebKit::WebApplicationCacheManager::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManager::deleteAllEntries): (WebKit::WebApplicationCacheManager::setAppCacheMaximumSize):
  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp: (WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins): (WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin): (WebKit::WebKeyValueStorageManager::deleteAllEntries):
  • WebProcess/MediaCache/WebMediaCacheManager.cpp: (WebKit::WebMediaCacheManager::getHostnamesWithMediaCache): (WebKit::WebMediaCacheManager::clearCacheForHostname): (WebKit::WebMediaCacheManager::clearCacheForAllHostnames):
  • WebProcess/ResourceCache/WebResourceCacheManager.cpp: (WebKit::WebResourceCacheManager::getCacheOrigins): (WebKit::WebResourceCacheManager::clearCacheForOrigin): (WebKit::WebResourceCacheManager::clearCacheForAllOrigins):
  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp: (WebKit::WebDatabaseManager::getDatabasesByOrigin): (WebKit::WebDatabaseManager::getDatabaseOrigins): (WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin): (WebKit::WebDatabaseManager::deleteDatabasesForOrigin): (WebKit::WebDatabaseManager::deleteAllDatabases): (WebKit::WebDatabaseManager::setQuotaForOrigin):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::getSitesWithPluginData): (WebKit::WebProcess::clearPluginSiteData):
4:44 PM Changeset in webkit [139256] by tasak@google.com
  • 3 edits
    3 adds in trunk

border-radius with box-shadow is not rendered correctly
​https://bugs.webkit.org/show_bug.cgi?id=106404

Reviewed by Hajime Morita.

Source/WebCore:

RoundedRect::isRenderable is wrong. So RoundedRect::adjustRadii
is invoked for renderable RoundedRects.

Test: fast/borders/border-radius-with-box-shadow.html

  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::isRenderable):
Have to compare topLeft's height plus bottomLeft's height with
rect's height and to compare topRight's height plus bottomRight's
height with rect's height.

LayoutTests:

  • fast/borders/border-radius-with-box-shadow-expected.txt: Added.
  • fast/borders/border-radius-with-box-shadow.html: Added.
  • platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png: Added.
4:39 PM Changeset in webkit [139255] by andersca@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Update a test result.

  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
4:32 PM Changeset in webkit [139254] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

Rebaseline fast/inline/continuation-outlines-with-layers.html
​https://bugs.webkit.org/show_bug.cgi?id=106064.

Unreviewed.

Rebaseline after ​http://trac.webkit.org/changeset/139223.

  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
4:27 PM Changeset in webkit [139253] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Always enable autocomplete for password fields
​https://bugs.webkit.org/show_bug.cgi?id=104600

Patch by Yue Zhang <​zysxqn@google.com> on 2013-01-09
Reviewed by Darin Fisher.

Don't check autocomplete in webkit code. Rather, we check it in chrome code in the following way: if the password field is chrome generated password, we ignore autocomplete=off and always fill the password; otherwise, we respect the autocomplete set. Since this is a chrome only feature, we make it configurable (default to false but enable this in chrome code).

  • src/WebPasswordFormUtils.cpp:

(WebKit::findPasswordFormFields):

  • src/WebPasswordFormUtils.h:

(WebKit):
(WebKit::findPasswordFormFields):

4:18 PM Changeset in webkit [139252] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Add a notification when a WebWidget's WebLayerTreeView is about to go away
​https://bugs.webkit.org/show_bug.cgi?id=106495

Patch by James Robinson <​jamesr@chromium.org> on 2013-01-09
Reviewed by Adrienne Walker.

The WebWidget / WebLayerTreeView ownership is in a slightly awkward place. I'm moving the ownership
of the WebLayerTreeView to the WebWidgetClient, but to stage things sanely the WebLayerTreeView's
client is sill owned by the WebWidget implementation. Thus to shut down cleanly we need an explicit
notification to the WebWidget that the WebLayerTreeView is going to go away.

This API can go away once the WebWidget implementation does not provide the WebLayerTreeViewClient,
which will take a bit more refactoring.

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::willCloseLayerTreeView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::willCloseLayerTreeView):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

4:17 PM Changeset in webkit [139251] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Ascribe a bug to a crash..

  • platform/chromium/TestExpectations: Ascribed.
4:09 PM Changeset in webkit [139250] by commit-queue@webkit.org
  • 13 edits
    1 add
    1 delete in trunk

[GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
​https://bugs.webkit.org/show_bug.cgi?id=105638

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2013-01-09
Reviewed by Martin Robinson.

The test was failing for two reasons:

  • AccessibilityRenderObject::correspondingLabelForControlElement() was not ignoring the ARIA labelled-by property
  • AccessibilityController::accessibleElementById() was not implemented

Because getting an element by ID cannot be done in the UIProcess, the
decision was made to expose the element's ID as an accessible attribute
of the object.

In addition, fixing the bug in AccessibilityRenderObject made it possible
to eliminate the Gtk platform-specific expectations for another test.

Source/WebCore:

No new tests; instead, the failing test was unskipped and a proper baseline
provided.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):
Return null for objects where hasTextAlternative() is true.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes): Expose the element's ID as an accessible
attribute.

Tools:

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(childElementById): Added. Walks the tree looking for the AtkObject
Attribute which exposes the HTML element's ID.
(AccessibilityController::accessibleElementById): Implemented.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::title): Modified to print out "AXTitle: " even
when there is no title, as is done with the Mac port.

  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:

(WTR::childElementById): Added. Walks the tree looking for the AtkObject
Attribute which exposes the HTML element's ID.
(WTR):
(WTR::AccessibilityController::accessibleElementById): Implemented.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
even when there is no title, as is done with the Mac port.

LayoutTests:

  • accessibility/aria-labelledby-overrides-label-expected.txt: Added.
  • accessibility/radio-button-title-label-expected.txt: Modified based on

null check which was added and which gets included in the test output.

  • accessibility/radio-button-title-label.html: Check to see that we have

a titleUIElement before attempting to get its title.

  • platform/gtk/TestExpectations: Unskipped the previously failing test.
  • platform/gtk/accessibility/radio-button-title-label-expected.txt: Removed.
3:25 PM ExportingSymbols edited by roger_fong@apple.com
(diff)
3:19 PM Changeset in webkit [139249] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused includes from HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=106496

Reviewed by Levi Weintraub.

Noticed these while searching HTMLTreeBuilder for non-thread friendly deps.

No new tests because no new functionality.

  • html/parser/HTMLTreeBuilder.cpp:
3:13 PM Changeset in webkit [139248] by mvujovic@adobe.com
  • 6 edits
    3 adds in trunk

[CSS Shaders] Detached identifier after mesh box type is not applied
​https://bugs.webkit.org/show_bug.cgi?id=105321

Reviewed by Dean Jackson.

Source/WebCore:

Before this patch, if a "detached" identifier followed a mesh box type identifier, the
detached identifier was not applied. In other words, the mesh would still be attached.

For example:
-webkit-filter: custom(url(...) mix(url(...) normal source-atop), 1 1 border-box detached);

Although the mesh box type is being removed from the Filter Effects spec, for now, we
continue to accept the mesh box type in parsing because of existing content. Eventually,
custom filters will transition to an at-rule syntax, once it is defined.

Test: css3/filters/custom/custom-filter-detached-mesh-with-mesh-box-type.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCustomFilter):

In CSSParser, do not add the mesh box type identifier to the list that will be passed to
StyleResolver. StyleResolver is expecting a "detached" identifier in that position and
does not interpret mesh box types.

LayoutTests:

Add a test to verify that a "detached" identifier after a mesh box type identifier is
actually applied.

For example:
-webkit-filter: custom(url(...) mix(url(...) normal source-atop), 1 1 border-box detached);

Update parsing tests and expectations to expect that the mesh box type is not returned in
the cssText.

  • css3/filters/custom/custom-filter-detached-mesh-with-mesh-box-type-expected.html: Added.
  • css3/filters/custom/custom-filter-detached-mesh-with-mesh-box-type.html: Added.
  • css3/filters/custom/custom-filter-property-parsing-expected.txt:
  • css3/filters/script-tests/custom-filter-property-parsing.js:
  • css3/filters/resources/a-triangle-coord-defined.vs: Added.
  • platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:
3:13 PM Changeset in webkit [139247] by Gregg Tavares
  • 2 edits in trunk/Tools

Add Gregg Tavares as a committer
​https://bugs.webkit.org/show_bug.cgi?id=106492

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
3:12 PM Changeset in webkit [139246] by pilgrim@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove stray references to WebKitPlatformSupport.h
​https://bugs.webkit.org/show_bug.cgi?id=106493

Reviewed by James Robinson.

Part of a refactoring series. See tracking bug 82948.

  • src/SharedWorkerRepository.cpp:
  • tests/RunAllTests.cpp:
3:00 PM Changeset in webkit [139245] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

Proper version of ​http://trac.webkit.org/changeset/139221.
The problem was that there was line-wrapping due to form controls
being different sizes on different platforms, not that form
controls dump innerText differently.

  • fast/forms/min-content-form-controls-expected.txt:
  • fast/forms/min-content-form-controls.html:
2:57 PM Changeset in webkit [139244] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Device Proximity is not enabled/implemented on Windows.
Skipping related tests:

proximity/add-listener-from-callback.html
proximity/basic-operation.html
proximity/create-event.html
proximity/event-after-navigation.html
proximity/multiple-frames.html
proximity/no-page-cache.html
proximity/optional-event-properties.html
proximity/updates.html
proximity/window-property.html

  • platform/win/TestExpectations:
2:45 PM Changeset in webkit [139243] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Enable seamless iFrames for Windows DRT.
​https://bugs.webkit.org/show_bug.cgi?id=106468.

Rubberstamped by Timothy Horton.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

2:36 PM Changeset in webkit [139242] by Christophe Dumez
  • 10 edits in trunk

[WK2] Implement eventSender.scheduleAsynchronousKeyDown
​https://bugs.webkit.org/show_bug.cgi?id=93979

Reviewed by Benjamin Poulain.

Tools:

Implement eventSender.scheduleAsynchronousKeyDown() in
WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::createKeyDownMessageBody):
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::scheduleAsynchronousKeyDown):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:

(EventSendingController):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
(WTR::TestController::didReceiveMessageFromInjectedBundle):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/TestController.h:

(TestController):

LayoutTests:

Update WK2 expectations for tests requiring
eventSender.scheduleAsynchronousKeyDown now that it is
implemented in WebKitTestRunner.

  • platform/efl-wk2/TestExpectations:
  • platform/gtk-wk2/TestExpectations:
  • platform/wk2/TestExpectations:
2:30 PM Changeset in webkit [139241] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Add user defaults to override system proxy settings for NetworkProcess on Mac
​https://bugs.webkit.org/show_bug.cgi?id=104197

Patch by Kiran Muppala <​cmuppala@apple.com> on 2013-01-09
Reviewed by Brady Eidson.

For internal testing and debugging, it is useful to have a defaults write to set the HTTP and HTTPS proxy specific to a
WebKit2 client application and not affect the system proxy settings on Mac.

  • NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::overrideSystemProxies): Add helper method to parse proxy URLs and populate settings dictionary passed
to WKCFNetworkSetOverrideSystemProxySettings.
(WebKit::NetworkProcess::platformInitializeNetworkProcess): Call overrideSystemProxies if process creation parameters for
http proxy or https proxy is set.

  • Shared/Network/NetworkProcessCreationParameters.cpp: Add httpProxy and httpsProxy process creation parameters on Mac.

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

  • Shared/Network/NetworkProcessCreationParameters.h:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeNetworkProcess): Initialize httpProxy and httpsProxy process creation parameters
based on the value of WebKit2HTTPProxyDefaultsKey and WebKit2HTTPSProxyDefaultsKey user default respectively.

2:22 PM WebKit Team edited by gman@google.com
added gregg tavares as committer (diff)
2:12 PM Changeset in webkit [139240] by ap@apple.com
  • 4 edits
    1 move in trunk/Source/WebKit2

Local builds of NetworkProcess should have a process icon
​https://bugs.webkit.org/show_bug.cgi?id=106489

Reviewed by Mark Rowe.

  • Resources/WebKit.icns: Copied from Source/WebKit2/WebProcess/mac/WebKit.icns.
  • WebProcess/mac/WebKit.icns: Removed. Copied to a shared location. We don't have different icons, so just using WebKit one.
  • Configurations/NetworkProcess.xcconfig:
  • NetworkProcess/Info.plist:
  • WebKit2.xcodeproj/project.pbxproj: Same changes as for WebProcess.
2:03 PM Changeset in webkit [139239] by danw@gnome.org
  • 8 edits in trunk

[Soup] Handle redirection inside WebKit
​https://bugs.webkit.org/show_bug.cgi?id=61122
​https://bugs.webkit.org/show_bug.cgi?id=88961

Reviewed by Martin Robinson.

Source/WebCore:

Rather than using libsoup's built-in redirection handling (which
doesn't do everything exactly the way WebKit wants, and can't
handle redirects to non-http URIs anyway), process redirections
ourselves.

No new tests; unskips a few existing tests.

  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal):

  • platform/network/soup/ResourceError.h:

(ResourceError):

  • platform/network/soup/ResourceErrorSoup.cpp:

(WebCore::ResourceError::transportError):
(WebCore):
(WebCore::ResourceError::httpError):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore):
(WebCore::gotHeadersCallback):
(WebCore::restartedCallback):
(WebCore::shouldRedirect):
(WebCore::doRedirect):
(WebCore::redirectCloseCallback):
(WebCore::redirectSkipCallback):
(WebCore::cleanupSoupRequestOperation):
(WebCore::sendRequestCallback):
(WebCore::createSoupMessageForHandleAndRequest):
(WebCore::createSoupRequestAndMessageForHandle):
(WebCore::ResourceHandle::start):

LayoutTests:

Unskip some tests.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
2:01 PM Changeset in webkit [139238] by fmalita@chromium.org
  • 22 edits in trunk

[Skia] Implement GraphicsContext::addRoundedRectClip() using SkCanvas::clipRRect()
​https://bugs.webkit.org/show_bug.cgi?id=106461

Reviewed by Stephen White.

Source/WebCore:

This patch adds a Skia-specific version of GraphicsContext::addRoundedRectClip() to take
advantage of the SkCanvas::clipRRect() primitive.

As a minor cleanup, the anonymous namespace in GraphicsContextSkia.cpp is extended to cover
all the local helper functions.

No new tests: coverage provided by existing tests.

  • platform/graphics/GraphicsContext.cpp:

(WebCore):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore):
(WebCore::GraphicsContext::fillRoundedRect):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::clipRRect):
(WebCore):

LayoutTests:

  • platform/chromium-linux/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-inset-outset-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-wide-border-05-expected.png:
  • platform/chromium-linux/fast/borders/border-styles-split-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-linux/fast/css/background-clip-radius-values-expected.png:
  • platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
  • platform/chromium-linux/fast/writing-mode/border-styles-vertical-lr-expected.png:
  • platform/chromium-linux/fast/writing-mode/border-styles-vertical-rl-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium/TestExpectations:
1:55 PM Changeset in webkit [139237] by roger_fong@apple.com
  • 6 edits in trunk/Source/WebKit/win

Add WebPreferences for Seamless IFrames on Windows port.
​https://bugs.webkit.org/show_bug.cgi?id=106468.

Rubberstamped by Eric Seidel.

  • Interfaces/IWebPreferences.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::areSeamlessIFramesEnabled):
(WebPreferences::setSeamlessIFramesEnabled):

  • WebPreferences.h:

(WebPreferences):

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

1:51 PM Changeset in webkit [139236] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

SVG-as-image: Throw out cached bitmap renderings after they sit unused for some time.
<​http://webkit.org/b/106484>
<rdar://problem/12983216>

Reviewed by Antti Koivisto.

Add a one-shot timer to SVGImageCache to self-clear the bitmap cache 30 seconds after last access.
This prevents us from keeping huge ImageBuffers around in memory for the lifetime of the elements
referencing that particular SVG file. (The ownership model is actually a bit more complicated
but that's irrelevant to this issue.)

10234kB progression on Membuster3.

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::SVGImageCache):
(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::clearBitmapCache):
(WebCore::SVGImageCache::cacheClearTimerFired):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

1:48 PM Changeset in webkit [139235] by Dimitri Glazkov
  • 2 edits
    4 adds in trunk/LayoutTests

[Chromium] Land expectations for r139197.

  • platform/chromium-linux/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
  • platform/chromium-mac/fast/regions/selecting-text-through-different-region-flows-expected.png:
  • platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
  • platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.txt: Added.
1:44 PM Changeset in webkit [139234] by jochen@chromium.org
  • 11 edits in trunk/Tools

[chromium] move resource load callback dumping to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=106449

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebKit):
(WebTestRunner::WebTestDelegate::makeURLErrorDescription):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::assignIdentifierToRequest):
(WebTestRunner::WebTestProxy::willRequestResource):
(WebTestRunner::WebTestProxy::willSendRequest):
(WebTestRunner::WebTestProxy::didReceiveResponse):
(WebTestRunner::WebTestProxy::didFinishResourceLoad):
(WebTestRunner::WebTestProxy::didFailResourceLoad):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
(WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
(WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
(WebTestRunner):
(WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
(WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
(WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::reset):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
(WebTestRunner::WebTestProxyBase::willRequestResource):
(WebTestRunner::WebTestProxyBase::willSendRequest):
(WebTestRunner::WebTestProxyBase::didReceiveResponse):
(WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
(WebTestRunner::WebTestProxyBase::didFailResourceLoad):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::willSendRequest):
(WebViewHost::makeURLErrorDescription):
(WebViewHost::reset):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

1:44 PM Changeset in webkit [139233] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] inspector/geolocation-error.html is flaky in Win.
​https://bugs.webkit.org/show_bug.cgi?id=106487

  • platform/chromium/TestExpectations: Marked as flaky.
1:39 PM Changeset in webkit [139232] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Tweak webaduio test expectations once more.

  • platform/chromium/TestExpectations: Tweaked.
1:07 PM Changeset in webkit [139231] by commit-queue@webkit.org
  • 9 edits in trunk/Tools

[chromium] move dumpcreateview methods to testrunner library
​https://bugs.webkit.org/show_bug.cgi?id=106434

Patch by Dan Carney <​dcarney@google.com> on 2013-01-09
Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner::WebTestRunner::shouldDumpCreateView):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpCreateView):
(WebTestRunner):
(WebTestRunner::TestRunner::dumpCreateView):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

12:53 PM Changeset in webkit [139230] by ap@apple.com
  • 4 edits
    3 adds in trunk

Assertion failure in SubresourceLoader::didFail when reloading
​https://bugs.webkit.org/show_bug.cgi?id=101416

Reviewed by Nate Chapin.

Test: http/tests/cache/network-error-during-revalidation.html

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didFail): Handle revalidation.
12:46 PM Changeset in webkit [139229] by Alexandru Chiculita
  • 4 edits in trunk

Assertion Failure in WebCore::RenderLayerCompositor::updateCompositingLayers
​https://bugs.webkit.org/show_bug.cgi?id=106419

Reviewed by Simon Fraser.

Source/WebCore:

No new tests added, just un-skipped 3 existing tests.

RenderLayerCompositor::updateCompositingLayers is being called with a pending layout, so computing the
layers at that point would be useless & error-prone as they will be using incorrect layout values. If a layout is pending it means that
RenderLayerCompositor::updateCompositingLayers would get called again after the pending layout ends, so any values calculated at that point would be
overwritten immediately. This patch removes the old ASSERT and makes it a return instead.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):

LayoutTests:

Re-added skipped tests as this patch resolves the flakiness.

  • platform/mac/TestExpectations:
12:45 PM Changeset in webkit [139228] by roger_fong@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed. Changelog fix.

12:44 PM Changeset in webkit [139227] by pilgrim@chromium.org
  • 149 edits in trunk/Source/WebKit/chromium

[Chromium] Update some #includes in WebKit/chromium/public/ for new Platform directory
​https://bugs.webkit.org/show_bug.cgi?id=106227

Reviewed by Darin Fisher.

Part of a larger refactoring series. See tracking bug 82948.

  • public/WebAccessibilityObject.h:
  • public/WebAccessibilityRole.h:
  • public/WebActiveWheelFlingParameters.h:
  • public/WebAnimationController.h:
  • public/WebApplicationCacheHost.h:
  • public/WebApplicationCacheHostClient.h:
  • public/WebArrayBuffer.h:
  • public/WebAudioSourceProvider.h:
  • public/WebBatteryStatus.h:
  • public/WebBindings.h:
  • public/WebBlob.h:
  • public/WebCache.h:
  • public/WebCachedURLRequest.h:
  • public/WebColorChooser.h:
  • public/WebColorChooserClient.h:
  • public/WebColorName.h:
  • public/WebCommonWorkerClient.h:
  • public/WebCompositionUnderline.h:
  • public/WebCompositorInputHandler.h:
  • public/WebConsoleMessage.h:
  • public/WebContentDetectionResult.h:
  • public/WebContextMenuData.h:
  • public/WebCrossOriginPreflightResultCache.h:
  • public/WebCursorInfo.h:
  • public/WebDOMEvent.h:
  • public/WebDOMEventListener.h:
  • public/WebDOMStringList.h:
  • public/WebDataSource.h:
  • public/WebDatabase.h:
  • public/WebDateTimeChooserCompletion.h:
  • public/WebDateTimeChooserParams.h:
  • public/WebDeliveredIntentClient.h:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • public/WebDevToolsFrontend.h:
  • public/WebDeviceOrientationClient.h:
  • public/WebDeviceOrientationClientMock.h:
  • public/WebDeviceOrientationController.h:
  • public/WebDocument.h:
  • public/WebDraggableRegion.h:
  • public/WebExternalPopupMenuClient.h:
  • public/WebFileChooserCompletion.h:
  • public/WebFileChooserParams.h:
  • public/WebFileSystemCallbacks.h:
  • public/WebFileSystemEntry.h:
  • public/WebFileWriter.h:
  • public/WebFileWriterClient.h:
  • public/WebFindOptions.h:
  • public/WebFont.h:
  • public/WebFontCache.h:
  • public/WebFontDescription.h:
  • public/WebFormControlElement.h:
  • public/WebFormElement.h:
  • public/WebFrame.h:
  • public/WebFrameClient.h:
  • public/WebGeolocationClientMock.h:
  • public/WebGeolocationController.h:
  • public/WebGeolocationError.h:
  • public/WebGeolocationPermissionRequest.h:
  • public/WebGeolocationPermissionRequestManager.h:
  • public/WebGeolocationPosition.h:
  • public/WebGlyphCache.h:
  • public/WebHelperPlugin.h:
  • public/WebHistoryItem.h:
  • public/WebHitTestResult.h:
  • public/WebIDBCallbacks.h:
  • public/WebIDBCursor.h:
  • public/WebIDBDatabase.h:
  • public/WebIDBDatabaseCallbacks.h:
  • public/WebIDBDatabaseError.h:
  • public/WebIDBFactory.h:
  • public/WebIDBIndex.h:
  • public/WebIDBKey.h:
  • public/WebIDBKeyPath.h:
  • public/WebIDBKeyRange.h:
  • public/WebIDBMetadata.h:
  • public/WebIDBObjectStore.h:
  • public/WebIDBTransaction.h:
  • public/WebIDBTransactionCallbacks.h:
  • public/WebIconURL.h:
  • public/WebImageDecoder.h:
  • public/WebInputEvent.h:
  • public/WebIntent.h:
  • public/WebIntentRequest.h:
  • public/WebIntentServiceInfo.h:
  • public/WebMediaPlayer.h:
  • public/WebMediaStreamRegistry.h:
  • public/WebMenuItemInfo.h:
  • public/WebNetworkStateNotifier.h:
  • public/WebNode.h:
  • public/WebNodeCollection.h:
  • public/WebNodeList.h:
  • public/WebNotification.h:
  • public/WebNotificationPresenter.h:
  • public/WebOptionElement.h:
  • public/WebPageOverlay.h:
  • public/WebPagePopup.h:
  • public/WebPageSerializer.h:
  • public/WebPasswordFormData.h:
  • public/WebPerformance.h:
  • public/WebPlugin.h:
  • public/WebPluginContainer.h:
  • public/WebPluginParams.h:
  • public/WebPopupMenu.h:
  • public/WebPopupMenuInfo.h:
  • public/WebPrerendererClient.h:
  • public/WebPrintParams.h:
  • public/WebRange.h:
  • public/WebRegularExpression.h:
  • public/WebRuntimeFeatures.h:
  • public/WebScopedMicrotaskSuppression.h:
  • public/WebScopedUserGesture.h:
  • public/WebScriptController.h:
  • public/WebScriptSource.h:
  • public/WebSearchableFormData.h:
  • public/WebSecurityOrigin.h:
  • public/WebSecurityPolicy.h:
  • public/WebSelectElement.h:
  • public/WebSettings.h:
  • public/WebSharedWorker.h:
  • public/WebSharedWorkerRepository.h:
  • public/WebSpeechGrammar.h:
  • public/WebSpeechInputController.h:
  • public/WebSpeechInputResult.h:
  • public/WebSpeechRecognitionHandle.h:
  • public/WebSpeechRecognitionParams.h:
  • public/WebSpeechRecognitionResult.h:
  • public/WebSpeechRecognizer.h:
  • public/WebSpeechRecognizerClient.h:
  • public/WebSpellCheckClient.h:
  • public/WebStorageEventDispatcher.h:
  • public/WebSurroundingText.h:
  • public/WebTestingSupport.h:
  • public/WebTextCheckingCompletion.h:
  • public/WebTextCheckingResult.h:
  • public/WebTextFieldDecoratorClient.h:
  • public/WebTextInputInfo.h:
  • public/WebTextRun.h:
  • public/WebTimeRange.h:
  • public/WebTouchPoint.h:
  • public/WebUserMediaRequest.h:
  • public/WebView.h:
  • public/WebViewBenchmarkSupport.h:
  • public/WebViewClient.h:
  • public/WebWidget.h:
  • public/WebWidgetClient.h:
  • public/WebWindowFeatures.h:
  • public/WebWorkerInfo.h:
12:41 PM Changeset in webkit [139226] by roger_fong@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed. Rebaseline some accessibility test results on Win7 port.

  • platform/win/accessibility/canvas-fallback-content-2-expected.txt:
  • platform/win/platform/win/accessibility: Added.
  • platform/win/platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
  • platform/win/platform/win/accessibility/select-element-valuechange-event-expected.txt: Added.
12:41 PM Changeset in webkit [139225] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Useless if statement check
​https://bugs.webkit.org/show_bug.cgi?id=106113

Patch by Genevieve Mak <​gmak@rim.com> on 2013-01-09
Reviewed by Yong Li.

Remove stray ! in if statement which was mistakenly left in during
refactoring. Since Injected events are checked before they are sent to
webkit, it didn't have an effect on behaviour.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::touchEvent):

12:33 PM Changeset in webkit [139224] by Csaba Osztrogonác
  • 7 edits in trunk/Tools

webkitpy cleanup: Merge additional_comment_text into comment_text
​https://bugs.webkit.org/show_bug.cgi?id=106421

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/committervalidator.py:

(CommitterValidator.reject_patch_from_commit_queue):
(CommitterValidator.reject_patch_from_review_queue):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.set_flag_on_attachment):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzilla.set_flag_on_attachment):

  • Scripts/webkitpy/tool/bot/feeders_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem._post_reject_message_on_bug):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:
12:30 PM Changeset in webkit [139223] by robert@webkit.org
  • 5 edits in trunk

REGRESSION(r111439): Focus ring is rendered incorrectly in fast/inline/continuation-outlines-with-layers.html
​https://bugs.webkit.org/show_bug.cgi?id=106064

Reviewed by David Hyatt.

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject):

LayoutTests:

  • platform/chromium-linux/fast/inline/continuation-outlines-with-layers-expected.png:
12:27 PM Changeset in webkit [139222] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty

Change ARCHS to generic setting to work with multiple platforms.
​https://bugs.webkit.org/show_bug.cgi?id=106478

Patch by David Farler <​dfarler@apple.com> on 2013-01-09
Reviewed by Anders Carlsson.

  • gtest/xcode/Config/General.xcconfig: ARCHS = $(ARCHS_STANDARD_32_64_BIT);
12:24 PM Changeset in webkit [139221] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

fast/forms/min-content-form-controls.html fails on some platforms
​https://bugs.webkit.org/show_bug.cgi?id=106482

Reviewed by Eric Seidel.

The text dump for some form controls (menulists?) has different whitespace
output on different platforms. Remove the form controls to avoid adding
platform-specific expectations for this test.

  • fast/forms/min-content-form-controls-expected.txt:
  • fast/forms/min-content-form-controls.html:
  • platform/mac/TestExpectations:
12:19 PM Changeset in webkit [139220] by commit-queue@webkit.org
  • 20 edits
    3 adds in trunk

Add stub for CanvasProxy
​https://bugs.webkit.org/show_bug.cgi?id=106275

Patch by Gregg Tavares <​gman@google.com> on 2013-01-09
Reviewed by Dean Jackson.

No new tests as no new fuctionality exposed.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasProxy.cpp: Added.
  • html/canvas/CanvasProxy.h: Added.
  • html/canvas/CanvasProxy.idl: Added.
12:12 PM Changeset in webkit [139219] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

IndexedDB: Remove unnecessary tests from storage/indexeddb/key-type-array.html
​https://bugs.webkit.org/show_bug.cgi?id=106472

Patch by Michael Pruett <​michael@68k.org> on 2013-01-09
Reviewed by Tony Chang.

The tests which verify that JSON.stringify() throws an exception
for cyclic objects produce different error messages on JSC and
V8 and do nothing to test IndexedDB functionality. These tests
should be removed.

  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/resources/key-type-array.js:
12:08 PM Changeset in webkit [139218] by Antti Koivisto
  • 11 edits in trunk/Source

Source/WebCore: Release FastMalloc thread caches on memory warning
​https://bugs.webkit.org/show_bug.cgi?id=106471

Reviewed by Geoff Garen.

FastMalloc keeps some memory in per-thread caches (currently 2MB each). We currently flush these caches on memory warning
for the main thread only. We should do it for other WebKit threads that use FastMalloc too.

Call WTF::releaseFastMallocFreeMemory in a bunch of WebCore support threads on memory warning. Unfortunately we don't have
an uniform way of doing threads so this requires bunch of thread type specific code.

Looks to be ~1% progression in membuster3 final and maximum numbers.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::releaseMemory):

  • storage/StorageTask.cpp:

(WebCore::StorageTask::performTask):

  • storage/StorageTask.h:

(WebCore::StorageTask::createReleaseFastMallocFreeMemory):

  • storage/StorageThread.cpp:

(WebCore::storageThreads):
(WebCore):
(WebCore::StorageThread::StorageThread):
(WebCore::StorageThread::~StorageThread):
(WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThread):

  • storage/StorageThread.h:

(StorageThread):

  • workers/WorkerThread.cpp:

(WebCore::threadSetMutex):
(WebCore::workerThreads):
(WebCore::WorkerThread::workerThreadCount):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::~WorkerThread):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThread):
(WebCore):

  • workers/WorkerThread.h:

(WorkerThread):

Source/WTF: Release FastMalloc thread caches on memory warning
​https://bugs.webkit.org/show_bug.cgi?id=106471

Reviewed by Geoff Garen.

Use TCMalloc_ThreadCache::Cleanup() instead of calling Scavenge() twice. This releases all the memory
and looks nicer too.

  • wtf/FastMalloc.cpp:

(WTF::releaseFastMallocFreeMemory):

12:01 PM Changeset in webkit [139217] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r139141): Assertion failure in WebCore::HTMLConstructionSite::HTMLConstructionSite
​https://bugs.webkit.org/show_bug.cgi?id=106412

Reviewed by Darin Adler.

This corrects the assertion added in r139141. The assertion was designed to make sure that we are using the
HTMLDocument class. XHTML documents also use HTMLDocument.

No new tests because no new functionality.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::HTMLConstructionSite):

11:41 AM Changeset in webkit [139216] by ojan@chromium.org
  • 8 edits
    2 adds in trunk

min-content gets the wrong value if min-width is set on some form controls
​https://bugs.webkit.org/show_bug.cgi?id=106389

Reviewed by Tony Chang.

Source/WebCore:

Simplify the logic. The only exposed change in behavior is that
m_minPreferredLogicalWidth gets set to m_maxPreferredLogicalWidth
instead of 0 when min-width is set.

Test: fast/forms/min-content-form-controls.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computePreferredLogicalWidths):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::computePreferredLogicalWidths):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computePreferredLogicalWidths):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):

LayoutTests:

  • fast/forms/min-content-form-controls-expected.txt: Added.
  • fast/forms/min-content-form-controls.html: Added.
11:36 AM Changeset in webkit [139215] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Fix a typo in in the double-tap-to-zoom logic

Rubber-stamped by Csaba Osztrogonác.

The qMin for the upper boundary of the scale was accidentally
changed to qMax in r139189, change it back to fix the Qt API tests.

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):

11:36 AM Changeset in webkit [139214] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skipping 4 video controls tests on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=106477.

Skipped tests:
media/video-controls-captions-trackmenu-localized.html
media/video-controls-captions-trackmenu-sorted.html
media/video-controls-captions-trackmenu.html
media/video-controls-visible-exiting-fullscreen.html

  • platform/win/TestExpectations:
11:08 AM Changeset in webkit [139213] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

Mitigate out-of-bounds access in InlineIterator
​https://bugs.webkit.org/show_bug.cgi?id=104812

Reviewed by Levi Weintraub.

Share code between InlineIterator::current and InlineIterator::previousInSameNode,
thereby checking for access outside text renderer's length.

  • rendering/InlineIterator.h:

(InlineIterator):
(WebCore::InlineIterator::characterAt):
(WebCore):
(WebCore::InlineIterator::current):
(WebCore::InlineIterator::previousInSameNode):

11:06 AM Changeset in webkit [139212] by Dimitri Glazkov
  • 6 edits
    8 adds in trunk/LayoutTests

[Chromium] Rebaseline a few tests after r139191.

  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/video/video-controls-layer-creation-expected.png: Added.
10:58 AM Changeset in webkit [139211] by Dimitri Glazkov
  • 11 edits in trunk/LayoutTests

[Chromium] Rebaseline a few tests after r139201.

  • platform/chromium-mac-lion/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-lion/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac-lion/fast/repaint/control-clip-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/control-clip-expected.png:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac/fast/forms/select-empty-option-height-expected.png:
  • platform/chromium-mac/fast/repaint/control-clip-expected.png:
10:55 AM Changeset in webkit [139210] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html is a flaky crash.
​https://bugs.webkit.org/show_bug.cgi?id=106473

  • platform/chromium/TestExpectations: Marked.
10:52 AM Changeset in webkit [139209] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

If ImageLoader's loadEventSender or errorEventSender fires after document is detached, the document will be leaked.

​https://bugs.webkit.org/show_bug.cgi?id=106394

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2013-01-09
Reviewed by Alexey Proskuryakov.

ImageLoader's loadEventSender and errorEventSender schedule event dispatching in separate timers and refs
the Element in updatedHasPendingEvent. If the Document is detached before either eventSender dispatches,
we would leak the Document since we bail out early in dispatchPendingLoadEvent or dispatchPendingErrorEvent,
without deref-ing the Element itself.

No new tests. Verified manually by using heap tool to count the living HTMLDocuments.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingLoadEvent): also call updatedHasPendingEvent to deref the Element if

the document is detached.

(WebCore::ImageLoader::dispatchPendingErrorEvent): ditto.

10:50 AM Changeset in webkit [139208] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r139143.
​http://trac.webkit.org/changeset/139143
​https://bugs.webkit.org/show_bug.cgi?id=106135

Broke Chromium content_browsertests.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::openInMemory):

10:50 AM Changeset in webkit [139207] by mario@webkit.org
  • 2 edits in trunk/Tools

[GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
​https://bugs.webkit.org/show_bug.cgi?id=106464

Reviewed by Martin Robinson.

Current version in jhbuild.modules (2.26.0) is giving trouble to
when trying to build WebKitGTK from scratch, due to a segmentation
fault error in gdk-pixbuf-query-loader during the 'make'
phase. Raising the version to 2.26.5 fixes this issue.

  • gtk/jhbuild.modules: Version raised, checksums updated.
10:29 AM Changeset in webkit [139206] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Add Settings.in and make_settings.pl to the project.

Reviewed by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj:
10:22 AM Changeset in webkit [139205] by dbates@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Remove duplicate ChangeLog entry for ​https://bugs.webkit.org/show_bug.cgi?id=105035
that was inadvertently added in <​http://trac.webkit.org/changeset/139203>.

10:17 AM Changeset in webkit [139204] by junov@google.com
  • 1 edit
    1 add in trunk/LayoutTests

New chromium-win pixel baseline for gradient-background-leakage-hidpi.html
​https://bugs.webkit.org/show_bug.cgi?id=106373

Unreviewed.

  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
10:10 AM Changeset in webkit [139203] by ojan@chromium.org
  • 3 edits in trunk

Source/WebCore: marquee special-case in RenderBlock is not needed
​https://bugs.webkit.org/show_bug.cgi?id=106396

Reviewed by Simon Fraser.

This was added in ​http://trac.webkit.org/changeset/105772. The layout test
in that patch (which is disabled) works and the original site that was broken
also still works.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):

LayoutTests: Implement CSS computed style value for transition shorthand
​https://bugs.webkit.org/show_bug.cgi?id=105035

Patch by Alexis Menard <​alexis@webkit.org> on 2013-01-09
Reviewed by Dean Jackson.

Uncomment existing tests to cover the new feature.

  • transitions/transitions-parsing-expected.txt:
  • transitions/transitions-parsing.html:
10:07 AM Changeset in webkit [139202] by tony@chromium.org
  • 15 edits in trunk

Automatically generate Settings::unifiedTextCheckerEnabled
​https://bugs.webkit.org/show_bug.cgi?id=106382

Reviewed by Adam Barth.

Source/WebCore:

No new tests, no change in behavior. This is covered by existing editing/spelling tests.

  • page/Settings.cpp:

(WebCore): Move default value into a global so we can generate the initializer.
(WebCore::Settings::Settings): Remove initializer code that is now generated.

  • page/Settings.h:

(Settings): Remove getters and setters.

  • page/Settings.in: Add entry to be generated.
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup): Remove backup since the generated code does this.
(WebCore::InternalSettings::Backup::restoreTo): Remove restore code since the generated code does this.

  • testing/InternalSettings.h:

(InternalSettings): Remove member variable.

  • testing/InternalSettings.idl: The getter was unused so it's being removed. The setter is now generated.

LayoutTests:

The InternalSettings.idl method didn't match the Settings' getter/setter. Now
that we're using the generated version, make the tests use the same name.

  • editing/spelling/grammar-edit-word.html:
  • editing/spelling/spellcheck-async-mutation.html:
  • editing/spelling/spellcheck-async-remove-frame.html:
  • editing/spelling/spellcheck-async.html:
  • editing/spelling/spelling-marker-description.html:
  • editing/spelling/spelling-unified-emulation.html:
  • platform/chromium/editing/spelling/delete-misspelled-word.html:
10:04 AM Changeset in webkit [139201] by schenney@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Adjust Skia build flags to WebKit skia gyp

Unreviewed change to enable easy layout test rebaselining.

  • skia_webkit.gyp:
10:04 AM Changeset in webkit [139200] by alexis@webkit.org
  • 5 edits in trunk

Implement CSS computed style value for transition shorthand
​https://bugs.webkit.org/show_bug.cgi?id=105035

Reviewed by Dean Jackson.

Source/WebCore:

Implement support for query the transition and webkit-transition
shorthand from the computed style.

Test: transitions/transitions-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::createTransitionPropertyValue): Factor the code to create the
correct value into a function to reuse it for the shorthand.
(WebCore::getTransitionPropertyValue):
(WebCore::createTimingFunctionValue): Little refactor, the intermediate
local variables are not needed.
(WebCore::getTimingFunctionValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Uncomment existing tests to cover the new feature.

  • transitions/transitions-parsing-expected.txt:
  • transitions/transitions-parsing.html:
9:41 AM Changeset in webkit [139199] by morrita@google.com
  • 5 edits in trunk/Source/WebCore

Document::setActiveNode() should be Document::setActiveElement()
​https://bugs.webkit.org/show_bug.cgi?id=106437

Reviewed by Ojan Vafai.

No new tests. No functoinal change.

  • dom/Document.cpp:

(WebCore::Document::setActiveElement):
(WebCore::Document::updateHoverActiveState):

  • dom/Document.h:

(Document):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::innerElement):
(WebCore):

  • rendering/HitTestResult.h:

(HitTestResult):

9:34 AM Changeset in webkit [139198] by shinyak@chromium.org
  • 361 edits in trunk

Source/WebCore: [Shadow DOM]: ShadowRoot has wrong nodeName attribute
​https://bugs.webkit.org/show_bug.cgi?id=104995

Reviewed by Dimitri Glazkov.

According to the Shadow DOM spec, ShadowRoot.nodeName should return '#document-fragment' instead of '#shadow-root'.
We remove ShadowRoot::nodeName.

No new tests, covered by existing tests.

  • dom/ShadowRoot.cpp:
  • dom/ShadowRoot.h:

(ShadowRoot):

LayoutTests: [Shadow DOM]: ShadowRoot wrong nodeName attribute
​https://bugs.webkit.org/show_bug.cgi?id=104995

Reviewed by Dimitri Glazkov.

Converted #shadow-root to #document-fragment in LayoutTests files using sed.

  • editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • editing/deleting/delete-ligature-001-expected.txt:
  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/selection/select-all-textarea-expected.txt:
  • fast/dom/shadow/layout-tests-can-access-shadow-expected.txt:
  • fast/dom/shadow/layout-tests-can-access-shadow.html:
  • fast/dom/shadow/shadow-and-list-elements.html:
  • fast/events/5056619-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:
  • fast/forms/textfield-outline-expected.txt:
  • fast/html/details-add-summary-1-and-click-expected.txt:
  • fast/html/details-add-summary-10-and-click-expected.txt:
  • fast/html/details-add-summary-2-and-click-expected.txt:
  • fast/html/details-add-summary-3-and-click-expected.txt:
  • fast/html/details-add-summary-4-and-click-expected.txt:
  • fast/html/details-add-summary-5-and-click-expected.txt:
  • fast/html/details-add-summary-6-and-click-expected.txt:
  • fast/html/details-add-summary-7-and-click-expected.txt:
  • fast/html/details-add-summary-8-and-click-expected.txt:
  • fast/html/details-add-summary-9-and-click-expected.txt:
  • fast/html/details-remove-summary-1-and-click-expected.txt:
  • fast/html/details-remove-summary-2-and-click-expected.txt:
  • fast/html/details-remove-summary-3-and-click-expected.txt:
  • fast/html/details-remove-summary-4-and-click-expected.txt:
  • fast/html/details-remove-summary-5-and-click-expected.txt:
  • fast/html/details-remove-summary-6-and-click-expected.txt:
  • inspector/elements/shadow-dom-modify-chardata-expected.txt:
  • inspector/elements/shadow-root-expected.txt:
  • inspector/elements/shadow-root.html:
  • inspector/elements/update-shadowdom-expected.txt:
  • platform/chromium-android/fast/events/autoscroll-expected.txt:
  • platform/chromium-android/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-android/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-linux-x86/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac-lion/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-mac-lion/fast/forms/search-rtl-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/chromium-mac/fast/forms/search-rtl-expected.txt:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-win-xp/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • platform/chromium-win/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/chromium-win/editing/inserting/4960120-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/chromium/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/chromium/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/chromium/editing/inserting/4960120-1-expected.txt:
  • platform/chromium/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/chromium/editing/selection/4895428-3-expected.txt:
  • platform/chromium/editing/selection/4975120-expected.txt:
  • platform/chromium/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt:
  • platform/chromium/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt:
  • platform/chromium/fast/events/autoscroll-expected.txt:
  • platform/chromium/fast/events/context-no-deselect-expected.txt:
  • platform/chromium/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium/fast/forms/input-text-drag-down-expected.txt:
  • platform/chromium/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/chromium/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium/fast/forms/search-rtl-expected.txt:
  • platform/chromium/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium/fast/forms/textarea-scrollbar-expected.txt:
  • platform/chromium/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/chromium/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium/fast/forms/textfield-outline-expected.txt:
  • platform/chromium/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/efl/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/efl/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/efl/editing/inserting/4960120-1-expected.txt:
  • platform/efl/fast/events/autoscroll-expected.txt:
  • platform/efl/fast/events/context-no-deselect-expected.txt:
  • platform/efl/fast/forms/input-appearance-focus-expected.txt:
  • platform/efl/fast/forms/input-appearance-readonly-expected.txt:
  • platform/efl/fast/forms/input-appearance-selection-expected.txt:
  • platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/efl/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/efl/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/efl/fast/forms/input-text-click-inside-expected.txt:
  • platform/efl/fast/forms/input-text-double-click-expected.txt:
  • platform/efl/fast/forms/input-text-option-delete-expected.txt:
  • platform/efl/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/efl/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/efl/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/efl/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/efl/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/efl/fast/forms/textarea-scrollbar-expected.txt:
  • platform/efl/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/efl/fast/forms/textfield-focus-ring-expected.txt:
  • platform/efl/fast/forms/textfield-outline-expected.txt:
  • platform/efl/fast/forms/validation-message-appearance-expected.txt:
  • platform/efl/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/efl/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/efl/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/gtk/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/gtk/editing/inserting/4960120-1-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/gtk/editing/selection/4895428-3-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/context-no-deselect-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/forms/input-text-double-click-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/textfield-outline-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/forms/validation-message-appearance-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac-wk2/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/mac/editing/inserting/4960120-1-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt:
  • platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/textarea-scrollbar-expected.txt:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/qt/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/qt/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/qt/editing/inserting/4960120-1-expected.txt:
  • platform/qt/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/qt/editing/selection/4895428-3-expected.txt:
  • platform/qt/editing/selection/4975120-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/qt/fast/events/context-no-deselect-expected.txt:
  • platform/qt/fast/forms/input-appearance-focus-expected.txt:
  • platform/qt/fast/forms/input-appearance-readonly-expected.txt:
  • platform/qt/fast/forms/input-appearance-selection-expected.txt:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/qt/fast/forms/input-text-click-inside-expected.txt:
  • platform/qt/fast/forms/input-text-click-outside-expected.txt:
  • platform/qt/fast/forms/input-text-double-click-expected.txt:
  • platform/qt/fast/forms/input-text-option-delete-expected.txt:
  • platform/qt/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/qt/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/qt/fast/forms/plaintext-mode-2-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/qt/fast/forms/textarea-scrollbar-expected.txt:
  • platform/qt/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/qt/fast/forms/textfield-focus-ring-expected.txt:
  • platform/qt/fast/forms/textfield-outline-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-expected.txt:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/qt/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/win-wk2/fast/forms/textfield-overflow-expected.txt:
  • platform/win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • platform/win/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/win/fast/forms/input-text-drag-down-expected.txt:
9:29 AM Changeset in webkit [139197] by zoltan@webkit.org
  • 3 edits
    3 adds in trunk

[CSS Regions] Selecting text through nested regions causes weird and unclearable selection
​https://bugs.webkit.org/show_bug.cgi?id=105641

Reviewed by David Hyatt.

If you have a region with a nested region inside what is rendered below the base region and you are trying select text
starting from the base region and ending it in the nested region, firstly you got a weird selection, secondly you can't
clear the selection. We could prevent this strange behavior by preventing the selection through different region flows.

Source/WebCore:

Test: fast/regions/selecting-text-through-different-region-flows.html

  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection): Don't allow selection when trying to select different region flows.

LayoutTests:

  • fast/regions/selecting-text-through-different-region-flows-expected.txt: Added.
  • fast/regions/selecting-text-through-different-region-flows.html: Added.
  • platform/chromium-mac/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
9:00 AM Changeset in webkit [139196] by Hugo Parente Lima
  • 5 edits in trunk/Source/WebCore

Regression(r138681) : Add HAVE(ACCESSIBILITY) guard to atk files, fix for a fix.
​https://bugs.webkit.org/show_bug.cgi?id=106448

Reviewed by Gyuyoung Kim.

Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
the macro isn't enabled.

  • accessibility/atk/WebKitAccessibleHyperlink.h:
  • accessibility/atk/WebKitAccessibleInterfaceAction.h:
  • accessibility/atk/WebKitAccessibleInterfaceComponent.h:
  • accessibility/atk/WebKitAccessibleInterfaceHypertext.h:
7:55 AM Changeset in webkit [139195] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: native popup buttons should not use textUnderElement for their title
​https://bugs.webkit.org/show_bug.cgi?id=106349

Reviewed by Ryosuke Niwa.

Chromium relies on the older title() method to return its title. As a result, we also
need to handle the case of <select> element pop up buttons returning the textUnderElement().

No new tests. Fix existing break.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::title):

7:53 AM Changeset in webkit [139194] by János Badics
  • 16 edits in trunk/Tools

[Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
​https://bugs.webkit.org/show_bug.cgi?id=90968.

Reviewed by Csaba Osztrogonác.

Added functionality in DRT and WTR to use any timeout value while running
slow tests (eventually, any test). Now NRWT --time-out-ms determines the
timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
to indicate whether the current port supports setting timeout value
per test (it's False by default; I enabled it only on Qt).
Also corrected a typo in driver.py

  • DumpRenderTree/DumpRenderTree.h:

(TestCommand::TestCommand):
(TestCommand):

  • DumpRenderTree/DumpRenderTreeCommon.cpp:

(parseInputLine):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::processLine):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.supports_per_test_timeout):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.run_test):
(Driver._command_from_driver_input):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.supports_per_test_timeout):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setCustomTimeout):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

  • WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:

(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::getCustomTimeout):
(WTR):
(WTR::TestCommand::TestCommand):
(TestCommand):
(WTR::parseInputLine):
(WTR::TestController::runTest):
(WTR::TestController::runUntil):

  • WebKitTestRunner/TestController.h:

(TestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::setCustomTimeout):
(WTR):
(WTR::TestInvocation::invoke):

  • WebKitTestRunner/TestInvocation.h:

(TestInvocation):

7:38 AM Changeset in webkit [139193] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Remove ASSERTs that can't assert but result in compiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=106442

Patch by Jussi Kukkonen <​jussi.kukkonen@intel.com> on 2013-01-09
Reviewed by Kentaro Hara.

IDBLevelDBCoding::m_metaDataType has been changed to unsigned
so ASSERT(m_metaDataType >= 0) is no longer useful: the compiler
warnings however create build difficulties at least with EFL.

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):

7:02 AM Changeset in webkit [139192] by loislo@chromium.org
  • 14 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 1/N
​https://bugs.webkit.org/show_bug.cgi?id=106445

Reviewed by Vsevolod Vlasov.

The patch has almost mechanical changes.

  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8ValueCache.cpp:

(WTF):
(WebCore::StringCache::reportMemoryUsage):
(WebCore):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

  • dom/ElementRareData.cpp:

(WebCore::ElementRareData::reportMemoryUsage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

  • page/Frame.cpp:

(WebCore::Frame::reportMemoryUsage):

  • page/Page.cpp:

(WebCore::Page::reportMemoryUsage):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::reportMemoryUsage):

  • platform/network/FormData.cpp:

(WebCore::FormData::reportMemoryUsage):
(WebCore):
(WebCore::FormDataElement::reportMemoryUsage):

  • platform/network/FormData.h:

(FormDataElement):

  • rendering/RenderView.cpp:

(WebCore::RenderView::reportMemoryUsage):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::reportMemoryUsage):

6:53 AM BuildingGtk edited by calvaris@igalia.com
(diff)
6:31 AM Changeset in webkit [139191] by fmalita@chromium.org
  • 51 edits
    2 adds in trunk

[Skia] Implement GraphicsContext::fillRoundedRect() using SkCanvas::drawRRect()
​https://bugs.webkit.org/show_bug.cgi?id=106366

Reviewed by Stephen White.

Source/WebCore:

Skia provides rounded-rect primitives, so we can avoid degrading fillRoundedRect() to
drawPath().

Due to subtle pixel differences (not visually noticeable), switching from drawPath() to
drawRRect() requires rebaselining some of the existing results.

No new tests: coverage provided by existing tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::fillRoundedRect):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::drawRRect):
(WebCore):

LayoutTests:

  • platform/chromium-linux/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-linux/fast/backgrounds/background-leakage-expected.png:
  • platform/chromium-linux/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-expected.png:
  • platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-linux/fast/css/shadow-multiple-expected.png:
  • platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-linux/fast/layers/video-layer-expected.png:
  • platform/chromium-linux/fast/regions/full-screen-video-from-region-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-linux/fast/transforms/shadows-expected.png:
  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-layout-direction-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-styling-strict-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/media-controls-clone-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-playing-and-pause-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/chromium/TestExpectations:
6:13 AM Changeset in webkit [139190] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skipping failing tests after r139141, r139145.

  • platform/efl/TestExpectations:
5:59 AM Changeset in webkit [139189] by abecsi@webkit.org
  • 7 edits in trunk/Source/WebKit2

[Qt][EFL][WK2] Remove redundant device pixel ratio adjustment from PageViewportController
​https://bugs.webkit.org/show_bug.cgi?id=106355

Reviewed by Kenneth Rohde Christiansen.

Since r137597 Qt uses the device pixel ratio of the underlying
platform window as the device pixel ratio in WebCore.
The tiles are rendered with the effective scale (scale adjusted with
the device scale factor) and the projection matrix is also adjusted
with the device pixel ratio when painting.
As a result we can follow the same approach as QtQuick and all the
coordinates in PageViewportController need to be in device independent
pixels (UI pixels) thus we do no longer need to adjust with the device
pixel ratio when calculating the viewport attributes.
This simplifies the logic significantly and increases robustness,
but does not allow to set a custom device pixel ratio different from
the factor of the underlying platform (eg. for testing purposes).
This patch is conceptually a follow-up of r137597 and fixes layout
and canvas size on retina display.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::innerBoundedViewportScale):
(WebKit::PageViewportController::outerBoundedViewportScale):
(WebKit::PageViewportController::pixelAlignedFloatPoint):
(WebKit::PageViewportController::boundContentsPosition):
(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::pageTransitionViewportReady):
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::visibleContentsSize):
(WebKit::PageViewportController::applyScaleAfterRenderingContents):
(WebKit::PageViewportController::updateMinimumScaleToFit):

  • UIProcess/PageViewportController.h:

(WebKit::PageViewportController::currentContentsScale):
(PageViewportController):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::updateViewportSize):
Adjust the viewport size with the device pixel ratio to keep previous
behaviour.

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::focusEditableArea):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):

  • UIProcess/qt/QtWebPageSGNode.cpp:

(WebKit::ContentsSGNode::clipRect):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):

5:33 AM Changeset in webkit [139188] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: cannot undock inspector when window size is too small
​https://bugs.webkit.org/show_bug.cgi?id=106054

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-01-09
Reviewed by Pavel Feldman.

Consider dockingUnavailable flag only when dockSide is in undocked
state.

  • inspector/front-end/DockController.js:

(WebInspector.DockController.prototype._updateUI.get document):

5:32 AM Changeset in webkit [139187] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed: A trivial fix for WebFrameTest.DivAutoZoomParamsTest after r139177.

  • tests/WebFrameTest.cpp:
5:31 AM Changeset in webkit [139186] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] WebGL content is incomplete when using multiple canvas
​https://bugs.webkit.org/show_bug.cgi?id=106313

While we are using double buffering for WebGL,
we do not use a drawable that implements a mechanism
for swapping buffers.
Therefore we have to make sure that all GL commands
have been executed properly before copying the texture
onto the GraphicsSurface.

Reviewed by Simon Hausmann.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):

4:07 AM Changeset in webkit [139185] by mikhail.pozdnyakov@intel.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaselining of media/video-controls-captions.html.

  • platform/efl/media/video-controls-captions-expected.txt: Added.
4:03 AM Changeset in webkit [139184] by Carlos Garcia Campos
  • 8 edits in trunk/Source

Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add mips.rb to offlineasm_nosources.

Source/WebCore:

  • GNUmakefile.list.am: Add missing headers.

Source/WebKit2:

  • GNUmakefile.list.am: Add missing headers.

Source/WTF:

  • GNUmakefile.list.am: Add missing header.
3:53 AM Changeset in webkit [139183] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skipping failing tests after r139111, r139140.

  • platform/efl/TestExpectations:
3:25 AM Changeset in webkit [139182] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt][Mac] GraphicsSurface does not need glEnable/glDisable for texture targets.
​https://bugs.webkit.org/show_bug.cgi?id=106310

glEnable/glDisable for texture targets is only necessary
when using the fixed function pipeline.
Enabling or disabling the target might cause unexpected
behavior to texture bindings and is therefore considered harmful.

Reviewed by Noam Rosenthal.

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore::createTexture):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurface::platformCopyToGLTexture):

3:23 AM Changeset in webkit [139181] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/LayoutTests

EFL port gardening after r139145, r139002.

Unreviewed gardening.

  • platform/efl/TestExpectations:
3:15 AM Keeping the Tree Green edited by Christophe Dumez
Add link to EFL port gardening schedule (diff)
2:21 AM Changeset in webkit [139180] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/win

[WinCairo] Link fix after r138759
​https://bugs.webkit.org/show_bug.cgi?id=106323

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-01-09
Reviewed by Kentaro Hara.

  • WebKit.vcproj/WebKitLibDebugCairoCFLite.vsprops: Include WebKitCFLite.vsprops.
  • WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops: Include WebKitCFLite.vsprops.
2:18 AM Changeset in webkit [139179] by apavlov@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/SettingsScreen.js

Merge 138144

Web Inspector: [REGRESSION] The last remembered tab is not restored when the Settings dialog is opened
​https://bugs.webkit.org/show_bug.cgi?id=105414

Reviewed by Vsevolod Vlasov.

Do not force the "General" tab when opening settings upon the Cog button click.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsController.prototype._mouseUp):

TBR=​apavlov@chromium.org
Review URL: ​https://codereview.chromium.org/11819026

2:14 AM Changeset in webkit [139178] by apavlov@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/StylesSidebarPane.js

Merge 138022

Web Inspector: [Styles] Selector matches are not marked after property editing
​https://bugs.webkit.org/show_bug.cgi?id=105284

Reviewed by Vsevolod Vlasov.

Once a property edit is committed, the selector markup is reset and needs to be re-applied.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.update):

TBR=​apavlov@chromium.org
Review URL: ​https://codereview.chromium.org/11819025

1:37 AM Changeset in webkit [139177] by mnaganov@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] When viewport is disabled, use display width in DIP pixels for the fallback width
​https://bugs.webkit.org/show_bug.cgi?id=106021

This is to emulate 'UseWideViewport' setting of Android WebView properly.
'UseWideViewport' now corresponds to the 'viewportEnabled' setting.
When the value is false, "meta viewport" tag is ignored, and when calculating
layout width, display width in DIP pixels is used.

Reviewed by Adam Barth.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::dipSize):
(WebKit):

  • src/WebViewImpl.h:

(WebCore):
(WebViewImpl):

1:36 AM Changeset in webkit [139176] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Removed crash expectations from tests that have been passing per bugs 105566, 105567, and 105580.

  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
1:26 AM Changeset in webkit [139175] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] fast/frames/frame-limit.html can be slow in release
​https://bugs.webkit.org/show_bug.cgi?id=106126

Unreviewed gardening.

  • platform/chromium/TestExpectations: Add Slow expectation for Win and Linux.

[ Win Linux Release ] fast/frames/frame-limit.html [ Pass Slow ]

1:22 AM Changeset in webkit [139174] by commit-queue@webkit.org
  • 7 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: min/max attributes should not make all fields read-only
​https://bugs.webkit.org/show_bug.cgi?id=106422

Patch by Kunihiko Sakamoto <​ksakamoto@chromium.org> on 2013-01-09
Reviewed by Kent Tamura.

Source/WebCore:

Do not make day-field of date input and month-field of month input readonly
even if min and max are the same.

Tests: fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html

fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitField): Added check for date type.

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt:
  • fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html: Update expectations.
  • fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield-expected.txt:
  • fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html: Ditto.
1:20 AM Changeset in webkit [139173] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r139134.
​http://trac.webkit.org/changeset/139134
​https://bugs.webkit.org/show_bug.cgi?id=106424

WebGL tests still crash on EFL (Requested by MPozdnyakov on

#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-09

  • platform/efl/TestExpectations:
12:53 AM Changeset in webkit [139172] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of week field should respect min/max attributes
​https://bugs.webkit.org/show_bug.cgi?id=106416

Patch by Kunihiko Sakamoto <​ksakamoto@chromium.org> on 2013-01-09
Reviewed by Kent Tamura.

Source/WebCore:

Make step-up/-down of the week field respect the min/max attributes of the element.
Note that it still accepts any keyboard inputs (the element
becomes 'invalid' state when out-of-range values entered).

Tests: fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html

fast/forms/week-multiple-fields/week-multiple-fields-stepup-stepdown-from-renderer.html

  • css/html.css: Add a CSS rule for week field.
  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitField):
Compute minimum/maximum values of week field from the min/max parameters of the element.

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeWeekFieldElement::DateTimeWeekFieldElement): Add mininum/maximum arguments.
(WebCore::DateTimeWeekFieldElement::create): Ditto.
(WebCore::DateTimeWeekFieldElement::clampValueForHardLimits): Added.

  • html/shadow/DateTimeFieldElements.h:

(DateTimeWeekFieldElement): Add mininum/maximum arguments and declare clampValueForHardLimits.

LayoutTests:

  • fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-stepup-stepdown-from-renderer.html: Added.
12:32 AM Changeset in webkit [139171] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Tighten svg/custom/feComponentTransfer-Table.svg on windows
​https://bugs.webkit.org/show_bug.cgi?id=106126

Unreviewed gardening. Bot reports:

Regressions: Unexpected image-only failures (1)

svg/custom/feComponentTransfer-Table.svg [ ImageOnlyFailure ]

  • platform/chromium/TestExpectations: So change Failure -> ImageOnlyFailure

to silence the bot.

12:22 AM Changeset in webkit [139170] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a flaky timeout expectation for fast/workers/worker-close-more.html
that regressed with r139145.

  • platform/gtk/TestExpectations:
Note: See TracTimeline for information about the timeline view.