⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 12, 2013:

11:59 PM Changeset in webkit [139560] by thakis@chromium.org
  • 5 edits in trunk/Tools

nrwt/chromium: Don't prefer chromium over webkit build directories
​https://bugs.webkit.org/show_bug.cgi?id=105597

Reviewed by Dirk Pranke.

Rely on the new timestamp logic instead. Requested by dpranke in
​https://bugs.webkit.org/show_bug.cgi?id=105498

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._static_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_build_path):

8:30 PM Changeset in webkit [139559] by thakis@chromium.org
  • 3 edits in trunk/Tools

Use ninja by default on Linux for build-webkit --chromium, bot edition
​https://bugs.webkit.org/show_bug.cgi?id=104434

Reviewed by Eric Seidel.

r139557 changed update-webkit to pick ninja by default on linux, but
the bots run update-webkit-chromium directly so they didn't see this.
Move the default for ninja into update-webkit-chromium so that it's
picked up by the bots, and let update-webkit forward non-default
options to there.

This way, the default is in one place only and both developers (who
usually use update-webkit which then shells out to
updat-webkit-chromium) and bots (which use update-webkit-chromium
directly) see the same behavior.

  • Scripts/update-webkit:
  • Scripts/update-webkit-chromium:
6:43 PM Changeset in webkit [139558] by timothy_horton@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed build fix.

  • API/JSBlockAdaptor.mm:
  • API/JSContext.mm:
  • API/JSValue.mm:
6:08 PM Changeset in webkit [139557] by thakis@chromium.org
  • 2 edits in trunk/Tools

Make ninja the default build system on Linux for build-webkit --chromium
​https://bugs.webkit.org/show_bug.cgi?id=104434

Reviewed by Eric Seidel.

  • Scripts/update-webkit:
5:44 PM Changeset in webkit [139556] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Provide LevelDB with IDBEnv instead of Env::Default
​https://bugs.webkit.org/show_bug.cgi?id=106135

Reviewed by Tony Chang.

IDBEnv only changes the name of the histogram where errors are logged.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::destroy):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::openInMemory):

5:19 PM Changeset in webkit [139555] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Roll chromium DEPS to 176595.
​https://bugs.webkit.org/show_bug.cgi?id=106730

  • DEPS:
1:20 PM Changeset in webkit [139554] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking fast/images/zoomed-offset-size.html as slow on Debug Chromium bots.

  • platform/chromium/TestExpectations:
12:23 PM Changeset in webkit [139553] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

Use sync_add_and_fetch instead of gnu_cxx::exchange_and_add
​https://bugs.webkit.org/show_bug.cgi?id=106729

After r139514 we need atomicIncrement(int64_t volatile*) for all platform. Now the
GCC implementation of atomicIncrement() is based on gnu_cxx::exchange_and_add,
which doesn't support int64_t type, but sync_add_and_fetch does.

Reviewed by Benjamin Poulain.

  • wtf/Atomics.h:

(WTF::atomicIncrement):
(WTF::atomicDecrement):

12:16 PM Changeset in webkit [139552] by commit-queue@webkit.org
  • 4 edits
    1 copy in trunk/Tools

Migrate the remaining bots in EC2 to Google Compute Engine
​https://bugs.webkit.org/show_bug.cgi?id=106005

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-12
Reviewed by Eric Seidel.

Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.

  • EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
  • EWSTools/boot.sh:
  • EWSTools/build-repo.sh:
  • EWSTools/start-queue.sh:
10:05 AM Changeset in webkit [139551] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

Regression(r119759): Heap-use-after-free in webkit_glue::WebURLLoaderImpl::Context::OnReceivedResponse
​https://bugs.webkit.org/show_bug.cgi?id=103563

A subresource could receive a body on a 404 if its call to CachedResource::error() resulted in a nested message loop.
That caused a crash when data was received, as the Subresource was in the Finished state already. Now when receiving
data we ignore these bodies, avoiding the crash.

Reviewed by Nate Chapin.

No new tests in WebKit, since it required a nested message loop which isn't present in chromium DumpRender tree.
There's a Chrome side browser test, see ​https://codereview.chromium.org/11778083/

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):

6:53 AM Changeset in webkit [139550] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.11.4

Tagging the WebKitGTK+ 1.11.4 release

5:57 AM Changeset in webkit [139549] by jochen@chromium.org
  • 8 edits in trunk/Tools

[chromium] move inspector related methods to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=106654

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestRunner::WebTestDelegate::showDevTools):
(WebTestRunner::WebTestDelegate::closeDevTools):
(WebTestRunner::WebTestDelegate::evaluateInWebInspector):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::showWebInspector):
(WebTestRunner):
(WebTestRunner::TestRunner::closeWebInspector):
(WebTestRunner::TestRunner::evaluateInWebInspector):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::showDevTools):
(WebViewHost::closeDevTools):
(WebViewHost::evaluateInWebInspector):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

4:59 AM Changeset in webkit [139548] by robert@webkit.org
  • 3 edits
    4 adds in trunk

Available height should respect min and max height
​https://bugs.webkit.org/show_bug.cgi?id=106479

Source/WebCore:

Reviewed by Ojan Vafai.

When calculating a relative positioned block's offset as a percentage of its container, respect the min
and max height set on the container

Tests: fast/block/percent-top-respects-max-height.html

fast/block/percent-top-respects-min-height.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalHeight):

LayoutTests:

Reviewed by Ojan Vafai.

  • fast/block/percent-top-respects-max-height-expected.txt: Added.
  • fast/block/percent-top-respects-max-height.html: Added.
  • fast/block/percent-top-respects-min-height-expected.txt: Added.
  • fast/block/percent-top-respects-min-height.html: Added.
4:04 AM Changeset in webkit [139547] by victor@rosedu.org
  • 6 edits in trunk

CC Button doesn't always show up
​https://bugs.webkit.org/show_bug.cgi?id=106653

Reviewed by Eric Carlson.

Source/WebCore:

Added extra checks to existing test.

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::closedCaptionTracksChanged):
Enforced visibility of captions button whenever the track list changes.
(WebCore):

  • html/shadow/MediaControls.h:

(MediaControls):

LayoutTests:

  • media/video-controls-captions-expected.txt: Updated.
  • media/video-controls-captions.html: Added extra checks that fail

without the code changes.

1:33 AM Changeset in webkit [139546] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed 64 bit buildfix after r139496.

  • dfg/DFGOperations.cpp:

Jan 11, 2013:

11:03 PM Changeset in webkit [139545] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[clean up] Remove HTMLFormElement::AutocompleteResultError in favor of more specific Error reasons
​https://bugs.webkit.org/show_bug.cgi?id=106610

Patch by Dan Beam <​dbeam@chromium.org> on 2013-01-11
Reviewed by Darin Fisher.

Source/WebCore:

No new tests (none needed).

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::finishRequestAutocomplete): Removed handling of AutocompleteResultError.

  • html/HTMLFormElement.h: Removed HTMLFormElement::AutocompleteResultError in favor of more specific errors.

Source/WebKit/chromium:

  • public/WebFormElement.h: Removed WebFormElement::AutocompleteResultError in favor of more specific error reasons.
  • src/AssertMatchingEnums.cpp: Removed enum value from compile-time asserts.
9:20 PM Changeset in webkit [139544] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, speculative build fix.

  • API/JSWrapperMap.mm:
9:15 PM Changeset in webkit [139543] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Update platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling.html on win

Unreviewed w/end gardening.

  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
8:54 PM Changeset in webkit [139542] by fpizlo@apple.com
  • 4 edits in trunk/Source

Fix changelogs that got messed up in revision 139541

8:47 PM Changeset in webkit [139541] by fpizlo@apple.com
  • 187 edits
    1 add in trunk/Source

The JITThunks class should be in its own file, and doing so should not break the build
​https://bugs.webkit.org/show_bug.cgi?id=105696

Source/JavaScriptCore:

Rubber stamped by Sam Weinig and Geoffrey Garen.

This patch was supposed to just move JITThunks into its own file. But then I
realized that there is a horrible circular dependency chain between JSCell,
JSGlobalData, CallFrame, and Weak, which only works because of magical include
order in JITStubs.h, and the fact that JSGlobalData.h includes JITStubs.h
before it includes JSCell or JSValue.

I first tried to just get JITThunks.h to just magically do the same pointless
includes that JITStubs.h had, but then I decided to actually fix the underflying
problem, which was that JSCell needed CallFrame, CallFrame needed JSGlobalData,
JSGlobalData needed JITThunks, JITThunks needed Weak, and Weak needed JSCell.
Now, all of JSCell's outgoing dependencies are placed in JSCellInlines.h. This
also gave me an opportunity to move JSValue inline methods from JSCell.h into
JSValueInlines.h. But to make this really work, I needed to remove includes of
*Inlines.h from other headers (CodeBlock.h for example included JSValueInlines.h,
which defeats the whole entire purpose of having an Inlines.h file), and I needed
to add includes of *Inlines.h into a bunch of .cpp files. I did this mostly by
having .cpp files include Operations.h. In future, if you're adding a .cpp file
to JSC, you'll almost certainly have to include Operations.h unless you enjoy
link errors.

  • API/JSBase.cpp:
  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackObject.cpp:
  • API/JSClassRef.cpp:
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp:
  • API/JSScriptRef.cpp:
  • API/JSWeakObjectMapRefPrivate.cpp:
  • JSCTypedArrayStubs.h:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/ArrayAllocationProfile.cpp:
  • bytecode/CodeBlock.cpp:
  • bytecode/GetByIdStatus.cpp:
  • bytecode/LazyOperandValueProfile.cpp:
  • bytecode/ResolveGlobalStatus.cpp:
  • bytecode/SpeculatedType.cpp:
  • bytecode/UnlinkedCodeBlock.cpp:
  • bytecompiler/BytecodeGenerator.cpp:
  • debugger/Debugger.cpp:
  • debugger/DebuggerActivation.cpp:
  • debugger/DebuggerCallFrame.cpp:
  • dfg/DFGArgumentsSimplificationPhase.cpp:
  • dfg/DFGArrayMode.cpp:
  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGConstantFoldingPhase.cpp:
  • dfg/DFGDriver.cpp:
  • dfg/DFGFixupPhase.cpp:
  • dfg/DFGGraph.cpp:
  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGOSREntry.cpp:
  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(DFG):
(JSC::DFG::SpeculativeJIT::silentSavePlanForFPR):
(JSC::DFG::SpeculativeJIT::silentSpill):
(JSC::DFG::SpeculativeJIT::silentFill):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:
  • dfg/DFGSpeculativeJIT64.cpp:
  • dfg/DFGStructureCheckHoistingPhase.cpp:
  • dfg/DFGVariableEventStream.cpp:
  • heap/CopiedBlock.h:
  • heap/CopiedSpace.cpp:
  • heap/HandleSet.cpp:
  • heap/Heap.cpp:
  • heap/HeapStatistics.cpp:
  • heap/SlotVisitor.cpp:
  • heap/WeakBlock.cpp:
  • interpreter/CallFrame.cpp:
  • interpreter/CallFrame.h:
  • jit/ClosureCallStubRoutine.cpp:
  • jit/GCAwareJITStubRoutine.cpp:
  • jit/JIT.cpp:
  • jit/JITArithmetic.cpp:
  • jit/JITArithmetic32_64.cpp:
  • jit/JITCall.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITCode.h:
  • jit/JITExceptions.cpp:
  • jit/JITStubs.h:
  • jit/JITThunks.h:
  • jsc.cpp:
  • llint/LLIntExceptions.cpp:
  • profiler/LegacyProfiler.cpp:
  • profiler/ProfileGenerator.cpp:
  • profiler/ProfilerBytecode.cpp:
  • profiler/ProfilerBytecodeSequence.cpp:
  • profiler/ProfilerBytecodes.cpp:
  • profiler/ProfilerCompilation.cpp:
  • profiler/ProfilerCompiledBytecode.cpp:
  • profiler/ProfilerDatabase.cpp:
  • profiler/ProfilerOSRExit.cpp:
  • profiler/ProfilerOSRExitSite.cpp:
  • profiler/ProfilerOrigin.cpp:
  • profiler/ProfilerOriginStack.cpp:
  • profiler/ProfilerProfiledBytecodes.cpp:
  • runtime/ArgList.cpp:
  • runtime/Arguments.cpp:
  • runtime/ArrayConstructor.cpp:
  • runtime/BooleanConstructor.cpp:
  • runtime/BooleanObject.cpp:
  • runtime/BooleanPrototype.cpp:
  • runtime/CallData.cpp:
  • runtime/CodeCache.cpp:
  • runtime/Completion.cpp:
  • runtime/ConstructData.cpp:
  • runtime/DateConstructor.cpp:
  • runtime/DateInstance.cpp:
  • runtime/DatePrototype.cpp:
  • runtime/Error.cpp:
  • runtime/ErrorConstructor.cpp:
  • runtime/ErrorInstance.cpp:
  • runtime/ErrorPrototype.cpp:
  • runtime/ExceptionHelpers.cpp:
  • runtime/Executable.cpp:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionPrototype.cpp:
  • runtime/GetterSetter.cpp:
  • runtime/Identifier.cpp:
  • runtime/InternalFunction.cpp:
  • runtime/JSActivation.cpp:
  • runtime/JSBoundFunction.cpp:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:

(JSC):

  • runtime/JSCellInlines.h: Added.

(JSC):
(JSC::JSCell::JSCell):
(JSC::JSCell::finishCreation):
(JSC::JSCell::structure):
(JSC::JSCell::visitChildren):
(JSC::allocateCell):
(JSC::isZapped):
(JSC::JSCell::isObject):
(JSC::JSCell::isString):
(JSC::JSCell::isGetterSetter):
(JSC::JSCell::isProxy):
(JSC::JSCell::isAPIValueWrapper):
(JSC::JSCell::setStructure):
(JSC::JSCell::methodTable):
(JSC::JSCell::inherits):
(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSCell::fastGetOwnProperty):
(JSC::JSCell::toBoolean):

  • runtime/JSDateMath.cpp:
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:

(JSC):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSLock.cpp:
  • runtime/JSNameScope.cpp:
  • runtime/JSNotAnObject.cpp:
  • runtime/JSONObject.cpp:
  • runtime/JSObject.h:

(JSC):

  • runtime/JSProxy.cpp:
  • runtime/JSScope.cpp:
  • runtime/JSSegmentedVariableObject.cpp:
  • runtime/JSString.h:

(JSC):

  • runtime/JSStringJoiner.cpp:
  • runtime/JSSymbolTableObject.cpp:
  • runtime/JSValue.cpp:
  • runtime/JSValueInlines.h:

(JSC::JSValue::toInt32):
(JSC::JSValue::toUInt32):
(JSC):
(JSC::JSValue::isUInt32):
(JSC::JSValue::asUInt32):
(JSC::JSValue::asNumber):
(JSC::jsNaN):
(JSC::JSValue::JSValue):
(JSC::JSValue::encode):
(JSC::JSValue::decode):
(JSC::JSValue::operator bool):
(JSC::JSValue::operator==):
(JSC::JSValue::operator!=):
(JSC::JSValue::isEmpty):
(JSC::JSValue::isUndefined):
(JSC::JSValue::isNull):
(JSC::JSValue::isUndefinedOrNull):
(JSC::JSValue::isCell):
(JSC::JSValue::isInt32):
(JSC::JSValue::isDouble):
(JSC::JSValue::isTrue):
(JSC::JSValue::isFalse):
(JSC::JSValue::tag):
(JSC::JSValue::payload):
(JSC::JSValue::asInt32):
(JSC::JSValue::asDouble):
(JSC::JSValue::asCell):
(JSC::JSValue::isNumber):
(JSC::JSValue::isBoolean):
(JSC::JSValue::asBoolean):
(JSC::reinterpretDoubleToInt64):
(JSC::reinterpretInt64ToDouble):
(JSC::JSValue::isString):
(JSC::JSValue::isPrimitive):
(JSC::JSValue::isGetterSetter):
(JSC::JSValue::isObject):
(JSC::JSValue::getString):
(JSC::::getString):
(JSC::JSValue::getObject):
(JSC::JSValue::getUInt32):
(JSC::JSValue::toPrimitive):
(JSC::JSValue::getPrimitiveNumber):
(JSC::JSValue::toNumber):
(JSC::JSValue::toObject):
(JSC::JSValue::isFunction):
(JSC::JSValue::inherits):
(JSC::JSValue::toThisObject):
(JSC::JSValue::get):
(JSC::JSValue::put):
(JSC::JSValue::putByIndex):
(JSC::JSValue::structureOrUndefined):
(JSC::JSValue::equal):
(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqualSlowCaseInline):
(JSC::JSValue::strictEqual):

  • runtime/JSVariableObject.cpp:
  • runtime/JSWithScope.cpp:
  • runtime/JSWrapperObject.cpp:
  • runtime/LiteralParser.cpp:
  • runtime/Lookup.cpp:
  • runtime/NameConstructor.cpp:
  • runtime/NameInstance.cpp:
  • runtime/NamePrototype.cpp:
  • runtime/NativeErrorConstructor.cpp:
  • runtime/NativeErrorPrototype.cpp:
  • runtime/NumberConstructor.cpp:
  • runtime/NumberObject.cpp:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectPrototype.cpp:
  • runtime/Operations.h:

(JSC):

  • runtime/PropertySlot.cpp:
  • runtime/RegExp.cpp:
  • runtime/RegExpCache.cpp:
  • runtime/RegExpCachedResult.cpp:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpMatchesArray.cpp:
  • runtime/RegExpObject.cpp:
  • runtime/RegExpPrototype.cpp:
  • runtime/SmallStrings.cpp:
  • runtime/SparseArrayValueMap.cpp:
  • runtime/StrictEvalActivation.cpp:
  • runtime/StringConstructor.cpp:
  • runtime/StringObject.cpp:
  • runtime/StringRecursionChecker.cpp:
  • runtime/Structure.h:

(JSC):

  • runtime/StructureChain.cpp:
  • runtime/TimeoutChecker.cpp:
  • testRegExp.cpp:

Source/WebCore:

Rubber stamped by Sam Weinig.

All .cpp files that use the JSC internal API must now transitively include
Operations.h, and none of the major JSC headers do it for you to avoid
circularity. WebCore doesn't have to worry about circularity with JSC, so
this changes all of the major WebCore JSC base headers to include
Operations.h.

  • bindings/js/BindingState.h:
  • bindings/js/JSArrayBufferViewHelper.h:
  • bindings/js/JSCustomXPathNSResolver.h:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDictionary.h:
  • bindings/js/JSMessagePortCustom.h:
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/ScriptValue.h:
  • bindings/js/ScriptWrappable.h:
  • bindings/js/SerializedScriptValue.cpp:
  • bridge/c/c_utility.h:
  • bridge/jsc/BridgeJSC.h:
  • dom/Node.cpp:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLImageLoader.cpp:
  • plugins/efl/PluginViewEfl.cpp:
  • xml/XMLHttpRequest.cpp:
8:22 PM Changeset in webkit [139540] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

If you use Phantom to force something to be live across an OSR exit, you should put it after the OSR exit
​https://bugs.webkit.org/show_bug.cgi?id=106724

Reviewed by Oliver Hunt.

In cases where we were getting it wrong, I think it was benign because we would either already have an
OSR exit prior to there, or the operand would be a constant. But still, it's good to get this right.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

7:49 PM Changeset in webkit [139539] by noel.gordon@gmail.com
  • 2 edits
    2 deletes in trunk/LayoutTests

[chromium] fast/repaint/4776765.html passes on the chromium bots
​https://bugs.webkit.org/show_bug.cgi?id=103955

Unreviewed w/end gardening.

  • platform/chromium-linux-x86/fast/repaint/4776765-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/4776765-expected.png: Removed.
  • platform/chromium/TestExpectations:
7:39 PM Changeset in webkit [139538] by noel.gordon@gmail.com
  • 2 edits
    2 deletes in trunk/LayoutTests

[chromium] fast/repaint/4774354.html passes on the chromium bots
​https://bugs.webkit.org/show_bug.cgi?id=103955

Unreviewed w/end gardening.

  • platform/chromium-linux-x86/fast/repaint/4774354-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/4774354-expected.png: Removed.
  • platform/chromium/TestExpectations:
6:37 PM Changeset in webkit [139537] by eae@chromium.org
  • 5 edits
    2 adds in trunk

offsetWidth/height incorrect for images when zoomed
​https://bugs.webkit.org/show_bug.cgi?id=106624

Source/WebCore:

Reviewed by Levi Weintraub.

offsetWidth and height are incorrect for images at certain zoom
levels due to flooring the values ones adjusted for zoom.
By rounding the value instead we avoid the problem and return
the right size.

Test: fast/images/zoomed-offset-size.html

  • dom/Element.cpp:

(WebCore::Element::offsetWidth):
(WebCore::Element::offsetHeight):
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):
Change to round (as opposed to floor) the zoom adjusted value.

  • rendering/RenderObject.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):

  • rendering/style/RenderStyle.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):
Add LayoutUnit version of adjustForAbsoluteZoom to avoid float
conversion.

LayoutTests:

Reviewed by Levi Weintraub.

Add test for offsetWidth/Height for zoomed image.

  • fast/images/zoomed-offset-size-expected.txt: Added.
  • fast/images/zoomed-offset-size.html: Added.
6:29 PM Changeset in webkit [139536] by ojan@chromium.org
  • 8 edits
    2 adds in trunk

Fixed width overrides intrinsic min-width/max-width for text inputs and listboxes
​https://bugs.webkit.org/show_bug.cgi?id=106675

Reviewed by Emil A Eklund.

Source/WebCore:

Implement computeIntrinsicLogicalWidths so that RenderBox::computeLogicalWidthInRegionUsing
can get the correct intrinsic sizes instead of the preferred sizes.

Test: fast/forms/select/listbox-intrinsic-min-width-applies-with-fixed-width.html

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderListBox::computePreferredLogicalWidths):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderTextControl::computePreferredLogicalWidths):

  • rendering/RenderTextControl.h:

(RenderTextControl):

LayoutTests:

  • fast/forms/file/intrinsic-min-width-overrides-width-expected.html:
  • fast/forms/file/intrinsic-min-width-overrides-width.html:
  • fast/forms/select/listbox-intrinsic-min-width-applies-with-fixed-width-expected.html: Added.
  • fast/forms/select/listbox-intrinsic-min-width-applies-with-fixed-width.html: Added.
6:21 PM Changeset in webkit [139535] by ojan@chromium.org
  • 11 edits
    6 adds in trunk

Setting width overrides intrinsic min-width/max-width on flexboxes and their subclasses
​https://bugs.webkit.org/show_bug.cgi?id=106617

Reviewed by Tony Chang.

Source/WebCore:

Override computeIntrinsicLogicalWidths for all RenderFlexibleBox and RenderDeprecatedFlexibleBox
classes that override computePreferredLogicalWidths so that RenderBox can use
computeIntrinsicLogicalWidths in order to get the correct intrinsic values.

Tests: css3/flexbox/intrinsic-min-width-applies-with-fixed-width.html

fast/flexbox/intrinsic-min-width-applies-with-fixed-width.html
fast/forms/select/intrinsic-min-width-applies-with-fixed-width.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
fit-content needs to use the intrinsic sizes not the preferred sizes
since a fixed width overrides the preferred size.
As best I can tell, the sizesLogicalWidthToFitContent codepath can keep
using preferred widths, which are considerably faster, since that's only used
computing width values. Added a clause to that if-statement to make this more
explicit.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):

  • rendering/RenderDeprecatedFlexibleBox.h:

(RenderDeprecatedFlexibleBox):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):

  • rendering/RenderFlexibleBox.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderMenuList::computePreferredLogicalWidths):

  • rendering/RenderMenuList.h:

(RenderMenuList):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderSlider::computePreferredLogicalWidths):

  • rendering/RenderSlider.h:

(RenderSlider):
No logic changes in any of these computeIntrinsic methods. Just moving
the code over from the computePreferred methods.

LayoutTests:

  • css3/flexbox/intrinsic-min-width-applies-with-fixed-width-expected.txt: Added.
  • css3/flexbox/intrinsic-min-width-applies-with-fixed-width.html: Added.
  • fast/flexbox/intrinsic-min-width-applies-with-fixed-width-expected.txt: Added.
  • fast/flexbox/intrinsic-min-width-applies-with-fixed-width.html: Added.
  • fast/forms/select/intrinsic-min-width-applies-with-fixed-width-expected.html: Added.
  • fast/forms/select/intrinsic-min-width-applies-with-fixed-width.html: Added.
6:07 PM Changeset in webkit [139534] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

Need new accessibility layout test to verify levels of headings
​https://bugs.webkit.org/show_bug.cgi?id=106243

Patch by James Craig <​james@cookiecrook.com> on 2013-01-11
Reviewed by Chris Fleizach.

New layout test to verify accessibility API heading levels on implicit h1-h6 and explicit @aria-level.

  • accessibility/heading-level-expected.txt: Added.
  • accessibility/heading-level.html: Added.
  • platform/chromium/TestExpectations: Skip for Chromium due to webkit.org/b/106682
6:05 PM Changeset in webkit [139533] by tonyg@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

Move HTMLTokenTypes to its own file
​https://bugs.webkit.org/show_bug.cgi?id=106722

Reviewed by Levi Weintraub.

Also mark AtomicHTMLToken ctor as explicit.

No new tests because no new functionality.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/HTMLTokenTypes.h: Added.

(WebCore):
(HTMLTokenTypes):
(DoctypeData):
(WebCore::HTMLTokenTypes::DoctypeData::DoctypeData):

6:02 PM Changeset in webkit [139532] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

WebWidgetClient::didHandleGestureEvent needs to distinguish the case if the event is processed or swallowed
​https://bugs.webkit.org/show_bug.cgi?id=104427

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-01-11
Reviewed by Adam Barth.

When a gesture needs to be disambiguated, WebKit doesn't update cursor focus.
We added an extra status for didHandleGestureEvent(), so we can distinguish
the case whether the event is actually delivered to the web page or cancelled.

  • public/WebViewClient.h:
  • public/WebWidgetClient.h:

(WebKit):
(WebWidgetClient):
(WebKit::WebWidgetClient::didHandleGestureEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

  • tests/WebViewTest.cpp:
5:58 PM Changeset in webkit [139531] by commit-queue@webkit.org
  • 7 edits
    2 copies in trunk/Source/WebKit/chromium

[chromium] Add ContinuousPainter to call setNeedsDisplay on all layers recursively in continuous painting mode
​https://bugs.webkit.org/show_bug.cgi?id=105458

Patch by Eberhard Graether <​egraether@google.com> on 2013-01-11
Reviewed by James Robinson.

In continuous painting mode all layers are constantly repainted to allow for life measurements of page paint time,
while changing HTML and CSS using the WebInspector. This change adds the ContinuousPainter helper object, which
calls setNeedsDisplay() on all GraphicsLayers recursively in order to force all layers to repaint. PageOverlay
layers get excluded from being repainted, because their extra paint time is altering the page paint time metric.

  • WebKit.gyp:
  • src/PageOverlay.h:

(WebKit::PageOverlay::graphicsLayer):
(PageOverlay):

  • src/PageOverlayList.cpp:

(WebKit::PageOverlayList::findGraphicsLayer):
(WebKit):

  • src/PageOverlayList.h:

(WebCore):
(PageOverlayList):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::didBeginFrame):

  • src/WebViewImpl.h:
  • src/painting/ContinuousPainter.cpp: Copied from Source/WebKit/chromium/src/PageOverlay.h.

(WebKit):
(WebKit::ContinuousPainter::setNeedsDisplayRecursive):

  • src/painting/ContinuousPainter.h: Copied from Source/WebKit/chromium/src/PageOverlay.h.

(WebCore):
(WebKit):
(ContinuousPainter):

5:49 PM Changeset in webkit [139530] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Focus zoom animation doesn't occur on devices with physical keyboard
​https://bugs.webkit.org/show_bug.cgi?id=106719

Patch by Andrew Lo <​anlo@rim.com> on 2013-01-11
Reviewed by Yong Li.
Internally reviewed by Mike Fenton.

Internal PR 278687

Always ensureFocusTextElementVisible if an element is focused when
the device has a physical keyboard.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementFocused):

5:48 PM Changeset in webkit [139529] by esprehn@chromium.org
  • 2 edits in trunk/Source/WebCore

No need to initialize RefPtrs to 0 in ElementRareData
​https://bugs.webkit.org/show_bug.cgi?id=106717

Reviewed by Ryosuke Niwa.

RefPtrs initialize themself to null, so there's no reason
to do it manually. This was code leftover from when
PseudoElements were stored in bare ptrs instead of in
RefPtrs.

No new tests, just refactoring.

  • dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData):

5:43 PM Changeset in webkit [139528] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

Phantom(GetLocal) should be treated as relevant to OSR
​https://bugs.webkit.org/show_bug.cgi?id=106715

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performBlockCSE):

LayoutTests:

  • fast/js/dfg-phantom-get-local-expected.txt: Added.
  • fast/js/dfg-phantom-get-local.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-phantom-get-local.js: Added.

(foo):

5:40 PM Changeset in webkit [139527] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html
as slow on all Chromium platforms.

  • platform/chromium/TestExpectations:
5:35 PM Changeset in webkit [139526] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[TexMap] Rename current[Transform|Opacity|Filters] in TextureMapperLayer.
​https://bugs.webkit.org/show_bug.cgi?id=105760

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-11
Reviewed by Noam Rosenthal.

Source/WebCore:

TextureMapperLayer has two transform members: an original value and a
changeable value. The changeable value would be changed by animations.
This patch puts 'current' prefix on the changeable value to clarify
its purpose. Opacity and filters ditto.

No new tests. Refactoring only.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::paintSelfAndChildren):
(WebCore::TextureMapperLayer::intermediateSurfaceRect):
(WebCore::TextureMapperLayer::shouldPaintToIntermediateSurface):
(WebCore::TextureMapperLayer::isVisible):
(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::paintRecursive):
(WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):
(WebCore::TextureMapperLayer::syncAnimations):
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):

  • platform/graphics/texmap/TextureMapperLayer.h:

(WebCore::TextureMapperLayer::TextureMapperLayer):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::State::State):

Source/WebKit/qt:

TextureMapperLayerClientQt uses setTransform() and setOpacity() in
GraphicsLayer instead of TextureMapperLayer like LayerTreeRenderer.
This removes unnecessary public API for TextureMapperLayer.

  • WebCoreSupport/TextureMapperLayerClientQt.cpp:

(TextureMapperLayerClientQt::renderCompositedLayers):

5:32 PM Changeset in webkit [139525] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

Coordinated Graphics: Remove the dependency of WebCoordinatedSurface::Handle from Coordinated Graphics.
​https://bugs.webkit.org/show_bug.cgi?id=104347

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-11
Reviewed by Noam Rosenthal.

It is a preparation patch for Threaded Coordinated Graphics on WK1.

Currently, UpdateAtlas and CoordinatedImageBacking use
WebCoordinatedSurface::Handle, but WebCoordinatedSurface::Handle can be
used only IPC-based Coordinated Graphics. So this patch removes the
dependency of WebCoordinatedSurface::Handle from UpdateAtlas and
CoordinatedImageBacking. Now CoordinatedLayerTreeHost converts the
handle to a WebCoordinatedSurface.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp:

(WebKit::CoordinatedImageBacking::update):
(WebKit::CoordinatedImageBacking::releaseSurfaceIfNeeded):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h:

(Coordinator):
(CoordinatedImageBacking):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::updateImageBacking):
(WebKit::CoordinatedLayerTreeHost::createUpdateAtlas):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

(WebKit):
(CoordinatedLayerTreeHost):

  • WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::~UpdateAtlas):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):

  • WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:

(UpdateAtlasClient):
(UpdateAtlas):

5:28 PM Changeset in webkit [139524] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fixing the linux layout tests

Unreviewed test expectations update.

Some tests were apparently not rebaselined for linux.

  • platform/chromium/TestExpectations:
5:28 PM Changeset in webkit [139523] by tonyg@chromium.org
  • 6 edits in trunk/Source/WebCore

Move constructTreeFromHTMLToken into HTMLDocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=106694

Reviewed by Adam Barth.

This way it will sit parallel to a new constructTreeFromCompactHTMLToken method.

No new tests because no new functionality.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):
(WebCore):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLTreeBuilder.cpp:
  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

4:41 PM Changeset in webkit [139522] by jparent@chromium.org
  • 3 edits in trunk/Tools

Builder should not be a valid parameter for stats dashboard
​https://bugs.webkit.org/show_bug.cgi?id=106698

Reviewed by Dirk Pranke.

Since builder is a dashboard specific parameter, dashboard_base
should not be handling it in handleValidHashParameterWrapper, rather,
each specific dashboard should in its handleValidHashParameter function.

Note that the FIXME in dashboard_base about this was actually wrong -
we don't want to move it to g_crossDashboardState, because it isn't
actually cross dashboard state.

In fact, flakiness and treemap have the code in
handleValidHashParameter, but it is currently dead code because
dashboard_base gets to it first.

Added the proper handling to timeline_explorer, since builder is
valid there.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/timeline_explorer.html:
4:30 PM Changeset in webkit [139521] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fixing the 10.8 layout tests

Unreviewed test expectations update.

  • platform/chromium/TestExpectations:
4:19 PM Changeset in webkit [139520] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Explicitly set msvs_cygwin_shell to true for actions in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=106706

Patch by Robert Iannucci <​iannucci@chromium.org> on 2013-01-11
Reviewed by Tony Chang.

Currently, msvs_cygwin_shell is set to 1 by default. This patch
explicitly sets it on the actions which will break if msvs_cygwin_shell
were set to 0. This is in preparation for changing the default value of
msvs_cygwin_shell, which in turn is in preparation of the removal of
cygwin as a buld-system requirement.

Since this change will have no semantic effect, no new tests are
required.

  • WebCore.gyp/WebCore.gyp:
4:14 PM Changeset in webkit [139519] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Modifying the databaseQuota call to WebPageClient
​https://bugs.webkit.org/show_bug.cgi?id=106703

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2013-01-11
Reviewed by Yong Li.

The databaseQuota call in WebPageClientImpl is modified to take in
BP:Strings directly. Also, we want to use the origin URL from the security origin.
Not the database identifier.

  • Api/WebPageClient.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):

4:12 PM Changeset in webkit [139518] by jsbell@chromium.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: IDBTransaction should manage lifetime of IDBRequests
​https://bugs.webkit.org/show_bug.cgi?id=106678

Reviewed by Tony Chang.

Ensure reference count of IDBRequests don't bounce off zero if there are no script
references are while the events are arriving.

No new tests - no detectable behavior changes.

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::create): Register with transaction (which now takes a ref) here to...
(WebCore::IDBRequest::IDBRequest): ...avoid having to relax adoption requirements here.

  • Modules/indexeddb/IDBTransaction.cpp: Keep RefPtr<>s to outstanding requests.

(WebCore::IDBTransaction::~IDBTransaction):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):

  • Modules/indexeddb/IDBTransaction.h:
4:10 PM Changeset in webkit [139517] by schenney@chromium.org
  • 94 edits
    63 adds in trunk/LayoutTests

[Resource Timing] XMLHttpRequests should have initiator type 'xmlhttprequest'
​https://bugs.webkit.org/show_bug.cgi?id=106409

Patch by James Simonsen <​simonjam@chromium.org> on 2013-01-11
Reviewed by Nate Chapin.

  • http/tests/w3c/webperf/resources/all_resource_types.htm:
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt:
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html:
4:08 PM Changeset in webkit [139516] by ap@apple.com
  • 12 edits in trunk/Source/WebKit2

[WK2] Network process unblocks all waiting threads when any sync reply arrives
​https://bugs.webkit.org/show_bug.cgi?id=106713

Reviewed by Brady Eidson.

Switch to sending sync CoreIPC messages, which is now possible.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::didClose): We no longer have response maps.
  • NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::willSendRequest): Just send a sync message. (WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpace): Ditto. (WebKit::NetworkResourceLoader::didReceiveDataArray): Added an unrelated assertion.
  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/NetworkResourceLoader.messages.in: Removed no longer used reply messages and their handlers.
  • Shared/BlockingResponseMap.h: Removed a bool version, which was not perfectly safe, and only used in NetworkProcess. (BlockingResponseMap::didReceiveResponse): Updated a still valid FIXME to not refer to network process. (BlockingResponseMap::cancel): Ditto.
  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.cpp: (WebKit::NetworkProcessConnection::didReceiveSyncMessage): Plumbing to handle sync messages.
  • WebProcess/Network/WebResourceLoader.cpp: (WebKit::WebResourceLoader::willSendRequest): (WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace):
  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in: Updated (simplified) sync messages and their handlers.
4:04 PM Changeset in webkit [139515] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Make it possible to send sync messages from secondary threads
​https://bugs.webkit.org/show_bug.cgi?id=106708

Apply another review comment (overlooked a "ditto").

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage):
4:01 PM Changeset in webkit [139514] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

[WK2] Make it possible to send sync messages from secondary threads
​https://bugs.webkit.org/show_bug.cgi?id=106708

Reviewed by Anders Carlsson.

It is hugely beneficial to implement sync messages at Connection level, because
ad hoc code that blocks a thread and wakes it up when a reply arrives on main
thread can't be made equally performant. A CoreOPC MessageDecoder can be moved across
threads, which can't be done with a decoded argument passed by reference to client code.

Sync messages from secondary threads are tracked in much simpler data structure
than client thread ones, because we don't need to be concerned with incoming messages.

  • Platform/CoreIPC/Connection.cpp: (Connection::SecondaryThreadPendingSyncReply): (CoreIPC::Connection::SecondaryThreadPendingSyncReply::SecondaryThreadPendingSyncReply): (CoreIPC::Connection::createSyncMessageEncoder): (CoreIPC::Connection::sendSyncMessage): (CoreIPC::Connection::sendSyncMessageFromSecondaryThread): (CoreIPC::Connection::processIncomingSyncReply): (CoreIPC::Connection::connectionDidClose):
  • Platform/CoreIPC/Connection.h: Also corrected a misleading comment.
3:54 PM Changeset in webkit [139513] by simonjam@chromium.org
  • 10 edits in trunk

[Resource Timing] XMLHttpRequests should have initiator type 'xmlhttprequest'
​https://bugs.webkit.org/show_bug.cgi?id=106409

Reviewed by Nate Chapin.

Source/WebCore:

The initiator is passed through ThreadableLoaderOptions to the CachedResourceRequest. This is
optional, so other users of ThreadableLoader will have the default initiator of 'request'. Note
that synchronous XHRs don't show up in the Resource Timing buffer yet.

Test: http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/ThreadableLoader.h:

(ThreadableLoaderOptions):

  • loader/cache/CachedResourceRequestInitiators.cpp:

(WebCore::CachedResourceRequestInitiators::CachedResourceRequestInitiators):

  • loader/cache/CachedResourceRequestInitiators.h:

(CachedResourceRequestInitiators):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

LayoutTests:

  • http/tests/w3c/webperf/resources/all_resource_types.htm:
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt:
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html:
3:42 PM Changeset in webkit [139512] by schenney@chromium.org
  • 248 edits
    273 adds in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

New results for fast tests.

  • platform/chromium-linux-x86/fast/backgrounds/body-generated-image-propagated-to-root-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/gradient-background-leakage-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-linux-x86/fast/block/basic: Added.
  • platform/chromium-linux-x86/fast/block/basic/011-expected.png: Added.
  • platform/chromium-linux-x86/fast/block/float/float-avoidance-expected.png: Added.
  • platform/chromium-linux-x86/fast/block/margin-collapse: Added.
  • platform/chromium-linux-x86/fast/block/margin-collapse/103-expected.png: Added.
  • platform/chromium-linux-x86/fast/block/positioning/inline-block-relposition-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-massive-scale-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-outset-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-linux-x86/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-linux-x86/fast/borders/border-image-trumps-radius-expected.png: Added.
  • platform/chromium-linux-x86/fast/canvas/arc360-expected.png: Added.
  • platform/chromium-linux-x86/fast/canvas/canvas-incremental-repaint-expected.png: Added.
  • platform/chromium-linux-x86/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/chromium-linux-x86/fast/canvas/fillrect_gradient-expected.png: Added.
  • platform/chromium-linux-x86/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/margin-top-bottom-dynamic-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/non-standard-checkbox-size-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/rtl-ordering-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/square-button-appearance-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/text-transform-select-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/transformed-mask-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLTableColElement: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLTextAreaElement: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/001-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/003-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/004-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/HTMLOptionElement_label01-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/HTMLOptionElement_label02-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/HTMLOptionElement_label03-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/HTMLOptionElement_label04-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/HTMLOptionElement_label06-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/HTMLOptionElement_label07-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/basic-buttons-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/basic-inputs-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/basic-selects-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/blankbuttons-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/box-shadow-override-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-align-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-cannot-be-nested-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-generated-content-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-inner-block-reuse-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-positioned-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-sizes-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-style-color-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-table-styles-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-text-transform-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-white-space-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/control-clip-overflow-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/control-restrict-line-height-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/disabled-select-change-index-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/file: Added.
  • platform/chromium-linux-x86/fast/forms/file/file-input-direction-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/file/file-input-disabled-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/file/file-input-pressed-state-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/file/input-file-re-render-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/form-element-geometry-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/formmove-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/formmove2-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/formmove3-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/select: Added.
  • platform/chromium-linux-x86/fast/forms/select-size-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/select-style-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/select-visual-hebrew-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/select-writing-direction-natural-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/selectlist-minsize-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/stuff-on-my-optgroup-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/background-clipped-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/border-image-gradient-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-color-stop-units-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-radial-gradients-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-radial-gradients2-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-radial-gradients3-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-repeating-end-fill-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-linux-x86/fast/gradients/gradient-after-transparent-border-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/radial-centered-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-linux-x86/fast/gradients/zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/chromium-linux-x86/fast/hidpi: Added.
  • platform/chromium-linux-x86/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-linux-x86/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium-linux-x86/fast/html: Added.
  • platform/chromium-linux-x86/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-replace-text-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/keygen-expected.png: Added.
  • platform/chromium-linux-x86/fast/invalid: Added.
  • platform/chromium-linux-x86/fast/invalid/014-expected.png: Added.
  • platform/chromium-linux-x86/fast/parser/bad-xml-slash-expected.png: Added.
  • platform/chromium-linux-x86/fast/parser/document-write-option-expected.png: Added.
  • platform/chromium-linux-x86/fast/reflections: Added.
  • platform/chromium-linux-x86/fast/reflections/reflection-masks-expected.png: Added.
  • platform/chromium-linux-x86/fast/repaint/4774354-expected.png: Added.
  • platform/chromium-linux-x86/fast/repaint/4776765-expected.png: Added.
  • platform/chromium-linux-x86/fast/repaint/background-generated-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced/replaced-breaking-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced/replaced-breaking-mixture-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced/three-selects-break-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced/width100percent-button-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced/width100percent-menulist-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced/width100percent-radio-expected.png: Added.
  • platform/chromium-linux-x86/fast/selectors/064-expected.png: Added.
  • platform/chromium-linux-x86/fast/table: Added.
  • platform/chromium-linux-x86/fast/table/append-cells2-expected.png: Added.
  • platform/chromium-linux-x86/fast/table/remove-td-display-none-expected.png: Added.
  • platform/chromium-linux-x86/fast/text/international/bidi-menulist-expected.png: Added.
  • platform/chromium-linux-x86/fast/text/international/hindi-spacing-expected.png: Added.
  • platform/chromium-linux-x86/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/chromium-linux-x86/fast/text/stroking-decorations-expected.png: Added.
  • platform/chromium-linux-x86/fast/text/stroking-expected.png: Added.
  • platform/chromium-linux-x86/fast/text/textIteratorNilRenderer-expected.png: Added.
  • platform/chromium-linux-x86/fast/text/whitespace: Added.
  • platform/chromium-linux-x86/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
  • platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png:
  • platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium-linux/fast/backgrounds/gradient-background-leakage-hidpi-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/block/basic/011-expected.png:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-linux/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/chromium-linux/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-linux/fast/borders/border-image-outset-expected.png:
  • platform/chromium-linux/fast/borders/border-image-outset-in-shorthand-expected.png:
  • platform/chromium-linux/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-linux/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-linux/fast/borders/border-image-trumps-radius-expected.png: Added.
  • platform/chromium-linux/fast/canvas/arc360-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-linux/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-linux/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/chromium-linux/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/chromium-linux/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.png:
  • platform/chromium-linux/fast/css/rtl-ordering-expected.png:
  • platform/chromium-linux/fast/css/shadow-multiple-expected.png:
  • platform/chromium-linux/fast/css/square-button-appearance-expected.png:
  • platform/chromium-linux/fast/css/text-transform-select-expected.png:
  • platform/chromium-linux/fast/css/transformed-mask-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-linux/fast/forms/001-expected.png:
  • platform/chromium-linux/fast/forms/003-expected.png:
  • platform/chromium-linux/fast/forms/004-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.png:
  • platform/chromium-linux/fast/forms/basic-inputs-expected.png:
  • platform/chromium-linux/fast/forms/basic-selects-expected.png:
  • platform/chromium-linux/fast/forms/blankbuttons-expected.png:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/button-align-expected.png:
  • platform/chromium-linux/fast/forms/button-cannot-be-nested-expected.png:
  • platform/chromium-linux/fast/forms/button-generated-content-expected.png:
  • platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.png:
  • platform/chromium-linux/fast/forms/button-positioned-expected.png:
  • platform/chromium-linux/fast/forms/button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/button-style-color-expected.png:
  • platform/chromium-linux/fast/forms/button-table-styles-expected.png:
  • platform/chromium-linux/fast/forms/button-text-transform-expected.png:
  • platform/chromium-linux/fast/forms/button-white-space-expected.png:
  • platform/chromium-linux/fast/forms/control-clip-overflow-expected.png:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png:
  • platform/chromium-linux/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-linux/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-linux/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/formmove-expected.png:
  • platform/chromium-linux/fast/forms/formmove2-expected.png:
  • platform/chromium-linux/fast/forms/formmove3-expected.png:
  • platform/chromium-linux/fast/forms/select-size-expected.png:
  • platform/chromium-linux/fast/forms/select-style-expected.png:
  • platform/chromium-linux/fast/forms/select-visual-hebrew-expected.png:
  • platform/chromium-linux/fast/forms/select-writing-direction-natural-expected.png:
  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png:
  • platform/chromium-linux/fast/forms/selectlist-minsize-expected.png:
  • platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/chromium-linux/fast/gradients/background-clipped-expected.png:
  • platform/chromium-linux/fast/gradients/border-image-gradient-expected.png: Added.
  • platform/chromium-linux/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-color-stop-units-expected.png:
  • platform/chromium-linux/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-radial-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/css3-radial-gradients2-expected.png:
  • platform/chromium-linux/fast/gradients/css3-radial-gradients3-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-repeating-end-fill-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-repeating-radial-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-linux/fast/gradients/radial-centered-expected.png:
  • platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-linux/fast/html/details-replace-text-expected.png:
  • platform/chromium-linux/fast/html/keygen-expected.png:
  • platform/chromium-linux/fast/invalid/014-expected.png:
  • platform/chromium-linux/fast/parser/bad-xml-slash-expected.png:
  • platform/chromium-linux/fast/parser/document-write-option-expected.png:
  • platform/chromium-linux/fast/reflections/reflection-masks-expected.png: Added.
  • platform/chromium-linux/fast/repaint/4774354-expected.png:
  • platform/chromium-linux/fast/repaint/4776765-expected.png:
  • platform/chromium-linux/fast/repaint/background-generated-expected.png: Added.
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-linux/fast/replaced/three-selects-break-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-menulist-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-linux/fast/selectors/064-expected.png:
  • platform/chromium-linux/fast/table/append-cells2-expected.png:
  • platform/chromium-linux/fast/table/remove-td-display-none-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.png:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/chromium-linux/fast/text/stroking-decorations-expected.png:
  • platform/chromium-linux/fast/text/stroking-expected.png:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/gradient-background-leakage-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-mac-lion/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
  • platform/chromium-mac-lion/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-mac-lion/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-image-outset-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-scaled-gradient-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-trumps-radius-expected.png: Added.
  • platform/chromium-mac-lion/fast/canvas/arc360-expected.png:
  • platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-mac-lion/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-mac-lion/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-mac-lion/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac-lion/fast/css/transformed-mask-expected.png:
  • platform/chromium-mac-lion/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-mac-lion/fast/gradients/background-clipped-expected.png:
  • platform/chromium-mac-lion/fast/gradients/border-image-gradient-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-color-stop-units-expected.png:
  • platform/chromium-mac-lion/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-radial-gradients-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-radial-gradients2-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-radial-gradients3-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-repeating-end-fill-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-mac-lion/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-mac-lion/fast/gradients/radial-centered-expected.png:
  • platform/chromium-mac-lion/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-mac-lion/fast/gradients/zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/chromium-mac-lion/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-mac-lion/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
  • platform/chromium-mac-lion/fast/reflections/reflection-masks-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/4774354-expected.png:
  • platform/chromium-mac-lion/fast/repaint/4776765-expected.png:
  • platform/chromium-mac-lion/fast/repaint/background-generated-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/stroking-decorations-expected.png:
  • platform/chromium-mac-lion/fast/text/stroking-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/gradient-background-leakage-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-outset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-trumps-radius-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/arc360-expected.png:
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-incremental-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-mac-snowleopard/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-mac-snowleopard/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/transformed-mask-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-color-stop-units-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-radial-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-radial-gradients2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-radial-gradients3-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-end-fill-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/radial-centered-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/simple-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/4774354-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/4776765-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/background-generated-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/stroking-decorations-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/stroking-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png:
  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-hidpi-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-mac/fast/borders/border-image-outset-expected.png:
  • platform/chromium-mac/fast/borders/border-image-outset-in-shorthand-expected.png:
  • platform/chromium-mac/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-mac/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-mac/fast/borders/border-image-trumps-radius-expected.png: Added.
  • platform/chromium-mac/fast/canvas/arc360-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-mac/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-mac/fast/canvas/gradient-add-second-start-end-stop-expected.png:
  • platform/chromium-mac/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/chromium-mac/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac/fast/css/transformed-mask-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-mac/fast/gradients/background-clipped-expected.png:
  • platform/chromium-mac/fast/gradients/border-image-gradient-expected.png:
  • platform/chromium-mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
  • platform/chromium-mac/fast/gradients/css3-color-stop-units-expected.png:
  • platform/chromium-mac/fast/gradients/css3-color-stops-expected.png:
  • platform/chromium-mac/fast/gradients/css3-radial-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/css3-radial-gradients2-expected.png:
  • platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.png:
  • platform/chromium-mac/fast/gradients/css3-repeating-end-fill-expected.png: Added.
  • platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients2-expected.png:
  • platform/chromium-mac/fast/gradients/css3-repeating-radial-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-mac/fast/gradients/radial-centered-expected.png:
  • platform/chromium-mac/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/focus-rings-expected.png:
  • platform/chromium-mac/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-mac/fast/repaint/4774354-expected.png:
  • platform/chromium-mac/fast/repaint/4776765-expected.png:
  • platform/chromium-mac/fast/repaint/background-generated-expected.png:
  • platform/chromium-mac/fast/text/stroking-decorations-expected.png:
  • platform/chromium-mac/fast/text/stroking-expected.png:
  • platform/chromium-win-xp/fast/backgrounds/body-generated-image-propagated-to-root-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/gradient-background-leakage-2-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-massive-scale-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-outset-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-win-xp/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-win-xp/fast/borders/border-image-trumps-radius-expected.png: Added.
  • platform/chromium-win-xp/fast/canvas/arc360-expected.png: Added.
  • platform/chromium-win-xp/fast/canvas/canvas-incremental-repaint-expected.png: Added.
  • platform/chromium-win-xp/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/chromium-win-xp/fast/canvas/fillrect_gradient-expected.png: Added.
  • platform/chromium-win-xp/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/chromium-win-xp/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/chromium-win-xp/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-win-xp/fast/css/transformed-mask-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/background-clipped-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/border-image-gradient-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-color-stop-units-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-radial-gradients-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-radial-gradients2-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-radial-gradients3-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-repeating-end-fill-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/generated-gradients-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/gradient-after-transparent-border-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/radial-centered-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/simple-gradients-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/chromium-win-xp/fast/hidpi: Added.
  • platform/chromium-win-xp/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-win-xp/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium-win-xp/fast/reflections: Added.
  • platform/chromium-win-xp/fast/reflections/reflection-masks-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/4774354-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/4776765-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/background-generated-expected.png: Added.
  • platform/chromium-win-xp/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win-xp/fast/text/stroking-expected.png:
  • platform/chromium-win/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png:
  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-hidpi-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-win/fast/borders/border-image-outset-expected.png:
  • platform/chromium-win/fast/borders/border-image-outset-in-shorthand-expected.png:
  • platform/chromium-win/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png:
  • platform/chromium-win/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-win/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-win/fast/borders/border-image-trumps-radius-expected.png: Added.
  • platform/chromium-win/fast/canvas/arc360-expected.png:
  • platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-win/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-win/fast/canvas/gradient-add-second-start-end-stop-expected.png:
  • platform/chromium-win/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/chromium-win/fast/css/shadow-multiple-expected.png:
  • platform/chromium-win/fast/css/transformed-mask-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-win/fast/gradients/background-clipped-expected.png:
  • platform/chromium-win/fast/gradients/border-image-gradient-expected.png:
  • platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
  • platform/chromium-win/fast/gradients/css3-color-stop-units-expected.png:
  • platform/chromium-win/fast/gradients/css3-color-stops-expected.png:
  • platform/chromium-win/fast/gradients/css3-radial-gradients-expected.png:
  • platform/chromium-win/fast/gradients/css3-radial-gradients2-expected.png:
  • platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png:
  • platform/chromium-win/fast/gradients/css3-repeating-end-fill-expected.png: Added.
  • platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.png:
  • platform/chromium-win/fast/gradients/css3-repeating-linear-gradients2-expected.png:
  • platform/chromium-win/fast/gradients/css3-repeating-radial-gradients-expected.png:
  • platform/chromium-win/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-win/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-win/fast/gradients/radial-centered-expected.png:
  • platform/chromium-win/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-win/fast/gradients/zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/chromium-win/fast/hidpi/focus-rings-expected.png:
  • platform/chromium-win/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
  • platform/chromium-win/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-win/fast/repaint/4774354-expected.png:
  • platform/chromium-win/fast/repaint/4776765-expected.png:
  • platform/chromium-win/fast/repaint/background-generated-expected.png:
  • platform/chromium-win/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win/fast/text/stroking-expected.png:
  • platform/chromium/TestExpectations:
3:34 PM Changeset in webkit [139511] by tony@chromium.org
  • 2 edits
    2 adds in trunk/Source/WebKit/chromium

Unreviewed, revert r139157 to fix the chromium build.
These files were deleted in a follow up and since r139044 was reverted, we need to
add back these files.

  • WebKit.gyp:
  • src/DragScrollTimer.cpp: Added.

(WebKit):
(WebKit::distanceToRect):
(WebKit::DragScrollTimer::DragScrollTimer):
(WebKit::DragScrollTimer::~DragScrollTimer):
(WebKit::DragScrollTimer::stop):
(WebKit::DragScrollTimer::scroll):
(WebKit::DragScrollTimer::update):
(WebKit::DragScrollTimer::triggerScroll):
(WebKit::DragScrollTimer::scrollDistanceFor):

  • src/DragScrollTimer.h: Added.

(WebKit):
(DragScrollTimer):
(WebKit::DragScrollTimer::fired):
(WebKit::DragScrollTimer::shouldScroll):

3:32 PM Changeset in webkit [139510] by psolanki@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Fix function name typo ProgramExecutable::initalizeGlobalProperties()
​https://bugs.webkit.org/show_bug.cgi?id=106701

Reviewed by Geoffrey Garen.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • runtime/Executable.cpp:

(JSC::ProgramExecutable::initializeGlobalProperties):

  • runtime/Executable.h:
3:18 PM Changeset in webkit [139509] by simonjam@chromium.org
  • 7 edits
    3 adds in trunk

Restore old semantics to webkitRequestAnimationFrame callbacks
​https://bugs.webkit.org/show_bug.cgi?id=106697

Reviewed by James Robinson.

Source/WebCore:

Sites that use GWT <= 2.4 are buggy and rely on Date.now()-like callback values.
We'll restore that behavior to the prefixed version of webkitRequestAnimationFrame.
requestAnimationFrame will continue to follow the spec.

Test: fast/animation/request-animation-frame-prefix.html

  • dom/RequestAnimationFrameCallback.h:

(RequestAnimationFrameCallback):

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceScriptedAnimations):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::requestAnimationFrame):
(WebCore):
(WebCore::DOMWindow::webkitRequestAnimationFrame):

  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:

LayoutTests:

  • fast/animation/request-animation-frame-prefix-expected.txt: Added.
  • fast/animation/request-animation-frame-prefix.html: Added.
  • fast/animation/script-tests/request-animation-frame-prefix.js: Added.

(busyWait):
(window.webkitRequestAnimationFrame):

3:09 PM Changeset in webkit [139508] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

testapi is failing with a block-related error in the Objc API
​https://bugs.webkit.org/show_bug.cgi?id=106055

Reviewed by Filip Pizlo.

Same bug as in testapi.mm. We need to actually call the static block, rather than casting the block to a bool.

  • API/ObjCCallbackFunction.mm:

(blockSignatureContainsClass):

3:08 PM Changeset in webkit [139507] by rniwa@webkit.org
  • 1 copy in branches/safari-536.28-branch/Tools/BuildSlaveSupport/delete-stale-build-files

Copy delete-stable-build-files into this branch as needed.

3:04 PM Changeset in webkit [139506] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add a run-time option to print bytecode at DFG compile time
​https://bugs.webkit.org/show_bug.cgi?id=106704

Reviewed by Mark Hahnenberg.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • runtime/Options.h:

(JSC):

2:57 PM Changeset in webkit [139505] by rniwa@webkit.org
  • 3 edits in trunk/Tools

REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
​https://bugs.webkit.org/show_bug.cgi?id=106688

Reviewed by Eric Seidel.

Update the regular expression used to strip the garbage at the beginning.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.nrwt_log_message_regexp):

2:56 PM Changeset in webkit [139504] by kbr@google.com
  • 4 edits in trunk/LayoutTests

[Chromium] Layout Test fast/canvas/webgl/context-release-upon-reload.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=106606

Reviewed by Dimitri Glazkov.

Reduced number of iterations of test, and marked as slow. Changed
test's output and expectations so number of iterations can be
adjusted without rebaselining.

  • fast/canvas/webgl/context-release-upon-reload-expected.txt:
  • fast/canvas/webgl/context-release-upon-reload.html:
  • platform/chromium/TestExpectations:
2:52 PM Changeset in webkit [139503] by commit-queue@webkit.org
  • 16 edits
    2 deletes in trunk

Unreviewed, rolling out r139044.
​http://trac.webkit.org/changeset/139044
​https://bugs.webkit.org/show_bug.cgi?id=106702

Caused various scrolling anomolies on Mac with drag and drop
(Requested by smfr on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-11

Source/WebCore:

  • page/AutoscrollController.cpp:

(WebCore::AutoscrollController::AutoscrollController):
(WebCore::AutoscrollController::autoscrollTimerFired):

  • page/AutoscrollController.h:

(WebCore):
(AutoscrollController):

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateDragAndDrop):

  • rendering/RenderBox.cpp:

(WebCore):
(WebCore::RenderBox::autoscroll):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::autoscroll):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::autoscroll):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::autoscroll):

  • rendering/RenderTextControlSingleLine.h:

(RenderTextControlSingleLine):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::dragSourceEndedAt):
(WebKit::WebViewImpl::dragSourceMovedTo):
(WebKit::WebViewImpl::dragTargetDrop):
(WebKit::WebViewImpl::dragTargetDragEnterOrOver):

  • src/WebViewImpl.h:

(WebKit):

LayoutTests:

  • fast/events/drag-and-drop-autoscroll-expected.txt: Removed.
  • fast/events/drag-and-drop-autoscroll.html: Removed.
2:45 PM Changeset in webkit [139502] by rafaelw@chromium.org
  • 6 edits in trunk

Prevent HTMLPreloadScanner from fetching resources inside <template>
​https://bugs.webkit.org/show_bug.cgi?id=106687

Reviewed by Adam Barth.

Source/WebCore:

This patch adds a simple counter to the preload scanner which increments on template start
tag and decrements on template element. It only fetchs resources when the counter is at zero
(i.e. for elements not contained by a template element).

Test re-enabled within fast/dom/HTMLTemplateElement/inertContents.html

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::processToken):

  • html/parser/HTMLPreloadScanner.h:

(HTMLPreloadScanner):

LayoutTests:

  • fast/dom/HTMLTemplateElement/inertContents-expected.txt:
  • fast/dom/HTMLTemplateElement/inertContents.html:
2:42 PM Changeset in webkit [139501] by schenney@chromium.org
  • 72 edits
    45 adds in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

CSS and editing results for all outstanding platforms.

  • platform/chromium-linux-x86/css1/box_properties/acid_test-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/t09-c5526c-display-00-e-expected.png: Added.
  • platform/chromium-linux-x86/css3/images: Added.
  • platform/chromium-linux-x86/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-161-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-19b-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-25-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-64-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-70-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-161-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-25-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-64-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-70-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-161-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-19b-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-25-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-64-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-70-expected.png: Added.
  • platform/chromium-linux-x86/editing/pasteboard/4641033-expected.png: Added.
  • platform/chromium-linux-x86/editing/pasteboard/4944770-1-expected.png: Added.
  • platform/chromium-linux-x86/editing/pasteboard/4944770-2-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/3690703-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/3690719-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/4397952-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/5240265-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/caret-before-select-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/replaced-boundaries-3-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/select-box-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/select-element-paragraph-boundary-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/selection-button-text-expected.png: Added.
  • platform/chromium-linux-x86/editing/spelling: Added.
  • platform/chromium-linux-x86/editing/spelling/grammar-markers-hidpi-expected.png: Added.
  • platform/chromium-linux/css1/box_properties/acid_test-expected.png:
  • platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/chromium-linux/css3/images/cross-fade-overflow-position-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-70-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-70-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-70-expected.png:
  • platform/chromium-linux/editing/pasteboard/4641033-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-expected.png:
  • platform/chromium-linux/editing/selection/3690719-expected.png:
  • platform/chromium-linux/editing/selection/4397952-expected.png:
  • platform/chromium-linux/editing/selection/5240265-expected.png:
  • platform/chromium-linux/editing/selection/caret-before-select-expected.png:
  • platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-linux/editing/selection/select-box-expected.png:
  • platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-linux/editing/selection/selection-button-text-expected.png:
  • platform/chromium-linux/editing/spelling/grammar-markers-hidpi-expected.png:
  • platform/chromium-mac-lion/css3/images: Added.
  • platform/chromium-mac-lion/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/chromium-mac-lion/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690703-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690719-expected.png:
  • platform/chromium-mac-lion/editing/selection/4397952-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac-lion/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-box-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac-lion/editing/spelling/grammar-markers-hidpi-expected.png:
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-box-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/grammar-markers-hidpi-expected.png: Added.
  • platform/chromium-mac/css3/images/cross-fade-overflow-position-expected.png:
  • platform/chromium-mac/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac/editing/selection/select-box-expected.png:
  • platform/chromium-mac/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac/editing/spelling/grammar-markers-hidpi-expected.png:
  • platform/chromium-win-xp/css3/images: Added.
  • platform/chromium-win-xp/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/chromium-win-xp/editing/spelling: Added.
  • platform/chromium-win-xp/editing/spelling/grammar-markers-hidpi-expected.png: Added.
  • platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png:
  • platform/chromium-win/editing/spelling/grammar-markers-hidpi-expected.png:
  • platform/chromium/TestExpectations:
2:34 PM UsingGitHub edited by abarth@webkit.org
(diff)
2:34 PM Changeset in webkit [139500] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Exclude unused resources.

Reviewed by Darin Adler.

  • Configurations/WebKit2.xcconfig: Defined EXCLUDED_SOURCE_FILE_NAMES.
2:30 PM Changeset in webkit [139499] by schenney@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

Mac 10.6 and 10.7 results that are the last to be failing on those bots.

  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/fallback-traits-fixup-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/hidpi: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
2:26 PM Changeset in webkit [139498] by schenney@chromium.org
  • 427 edits in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

Mac 10.8 results that were not ready when the other mac results were updated.

  • platform/chromium-mac-lion/editing/selection/iframe-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/deleting/4922367-expected.png:
  • platform/chromium-mac/editing/deleting/5099303-expected.png:
  • platform/chromium-mac/editing/deleting/5126166-expected.png:
  • platform/chromium-mac/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac/editing/deleting/5272440-expected.png:
  • platform/chromium-mac/editing/deleting/5369009-expected.png:
  • platform/chromium-mac/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac/editing/deleting/5483370-expected.png:
  • platform/chromium-mac/editing/deleting/collapse-whitespace-3587601-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3608462-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-4083333-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-start-or-end-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-008-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-009-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-010-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-011-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-012-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-013-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-014-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-015-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-016-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-017-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac/editing/deleting/delete-character-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-leading-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-listitem-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-listitem-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-selection-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-004-expected.png:
  • platform/chromium-mac/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac/editing/deleting/non-smart-delete-expected.png:
  • platform/chromium-mac/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-001-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac/editing/execCommand/print-expected.png:
  • platform/chromium-mac/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac/editing/execCommand/selectAll-expected.png:
  • platform/chromium-mac/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
  • platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • platform/chromium-mac/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/chromium-mac/editing/inserting/12882-expected.png:
  • platform/chromium-mac/editing/inserting/4278698-expected.png:
  • platform/chromium-mac/editing/inserting/4840662-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac/editing/inserting/4959067-expected.png:
  • platform/chromium-mac/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac/editing/inserting/5002441-expected.png:
  • platform/chromium-mac/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac/editing/inserting/5418891-expected.png:
  • platform/chromium-mac/editing/inserting/5510537-expected.png:
  • platform/chromium-mac/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac/editing/inserting/6703873-expected.png:
  • platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3778059-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-after-delete-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-026-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac/editing/inserting/insert-space-in-empty-doc-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac/editing/inserting/line-break-expected.png:
  • platform/chromium-mac/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac/editing/inserting/redo-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac/editing/inserting/typing-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac/editing/inserting/typing-003-expected.png:
  • platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-around-image-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.png:
  • platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-4038267-fix-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-002-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-003-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-004-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-005-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-007-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-008-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-009-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-010-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-match-style-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-match-style-002-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-paste-007-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac/editing/selection/13804-expected.png:
  • platform/chromium-mac/editing/selection/4818145-expected.png:
  • platform/chromium-mac/editing/selection/4866671-expected.png:
  • platform/chromium-mac/editing/selection/4889598-expected.png:
  • platform/chromium-mac/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac/editing/selection/4947387-expected.png:
  • platform/chromium-mac/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac/editing/selection/5007143-expected.png:
  • platform/chromium-mac/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac/editing/selection/5057506-expected.png:
  • platform/chromium-mac/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac/editing/selection/5099303-expected.png:
  • platform/chromium-mac/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac/editing/selection/6476-expected.png:
  • platform/chromium-mac/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-002-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-003-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-004-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-005-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-006-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac/editing/selection/inline-table-expected.png:
  • platform/chromium-mac/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/move-between-blocks-no-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-004-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-005-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-6-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-002-expected.png:
  • platform/chromium-mac/editing/selection/move-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-mac/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac/editing/spelling/grammar-markers-expected.png:
  • platform/chromium-mac/editing/spelling/spelling-expected.png:
  • platform/chromium-mac/editing/style/4916887-expected.png:
  • platform/chromium-mac/editing/style/5017613-1-expected.png:
  • platform/chromium-mac/editing/style/5017613-2-expected.png:
  • platform/chromium-mac/editing/style/5046875-1-expected.png:
  • platform/chromium-mac/editing/style/5046875-2-expected.png:
  • platform/chromium-mac/editing/style/5065910-expected.png:
  • platform/chromium-mac/editing/style/5084241-expected.png:
  • platform/chromium-mac/editing/style/5228141-expected.png:
  • platform/chromium-mac/editing/style/5279521-expected.png:
  • platform/chromium-mac/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac/editing/style/highlight-expected.png:
  • platform/chromium-mac/editing/style/smoosh-styles-001-expected.png:
  • platform/chromium-mac/editing/style/smoosh-styles-003-expected.png:
  • platform/chromium-mac/editing/style/style-3681552-fix-001-expected.png:
  • platform/chromium-mac/editing/style/style-3681552-fix-002-expected.png:
  • platform/chromium-mac/editing/style/style-3998892-fix-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-001-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-002-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-003-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-004-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac/editing/style/typing-style-001-expected.png:
  • platform/chromium-mac/editing/style/typing-style-002-expected.png:
  • platform/chromium-mac/editing/style/unbold-in-bold-expected.png:
  • platform/chromium-mac/editing/undo/4063751-expected.png:
  • platform/chromium-mac/editing/undo/5378473-expected.png:
  • platform/chromium-mac/editing/undo/redo-typing-001-expected.png:
  • platform/chromium-mac/editing/undo/undo-combined-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-combined-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-forward-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-forward-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-misspellings-expected.png:
  • platform/chromium-mac/editing/undo/undo-typing-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/number/number-appearance-rtl-expected.png:
  • platform/chromium-mac/fast/forms/textarea/textarea-placeholder-paint-order-expected.png:
  • platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png:
2:20 PM Changeset in webkit [139497] by tonyg@chromium.org
  • 4 edits in trunk/Source/WebCore

We should be able to checkpoint and restore the HTMLTokenizer across threads
​https://bugs.webkit.org/show_bug.cgi?id=106597

Based on patch by Adam Barth.

This has the ability to create a checkpoint any time the parser is blocked on a script.
We clear m_appropriateEndTagName after each end tag is flushed so that the ASSERT in
canCreateCheckpoint() will pass.

Reviewed by Adam Barth.

No new tests because no new functionality.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/HTMLDocumentParser.h:

(WebCore):
(HTMLDocumentParser):

  • html/parser/HTMLTokenizer.cpp:

(WebCore):
(WebCore::HTMLTokenizer::canCreateCheckpoint):
(WebCore::HTMLTokenizer::createCheckpoint):
(WebCore::HTMLTokenizer::restoreFromCheckpoint):

  • html/parser/HTMLTokenizer.h:

(HTMLTokenizer):
(Checkpoint):
(WebCore::HTMLTokenizer::Checkpoint::Checkpoint):

  • xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::InputStreamPreprocessor):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::skipNextNewLine):
(InputStreamPreprocessor):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::reset):

2:18 PM Changeset in webkit [139496] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

It should be possible to enable verbose printing of each OSR exit at run-time (rather than compile-time) and it should print register state
​https://bugs.webkit.org/show_bug.cgi?id=106700

Reviewed by Mark Hahnenberg.

  • dfg/DFGAssemblyHelpers.h:

(DFG):
(JSC::DFG::AssemblyHelpers::debugCall):

  • dfg/DFGCommon.h:
  • dfg/DFGOSRExit.h:

(DFG):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • runtime/Options.h:

(JSC):

2:15 PM Changeset in webkit [139495] by dmazzoni@google.com
  • 1 edit
    162 deletes in trunk/LayoutTests

[Chromium] unnecessary expectations in platform/chromium/accessibility
​https://bugs.webkit.org/show_bug.cgi?id=106676

These files were copied from platform/mac/accessibility, but
all of the corresponding tests are either mac-specific, or
currently skipped on Chromium. There's no purpose to having
these expectations in platform/chromium/accessibility.

Reviewed by Chris Fleizach.

  • platform/chromium/accessibility/accesskey-expected.txt: Removed.
  • platform/chromium/accessibility/area-with-aria-label-expected.txt: Removed.
  • platform/chromium/accessibility/aria-alerts-expected.txt: Removed.
  • platform/chromium/accessibility/aria-checkbox-text-expected.txt: Removed.
  • platform/chromium/accessibility/aria-combobox-expected.txt: Removed.
  • platform/chromium/accessibility/aria-directory-expected.txt: Removed.
  • platform/chromium/accessibility/aria-divs-not-ignored-expected.txt: Removed.
  • platform/chromium/accessibility/aria-drag-drop-expected.txt: Removed.
  • platform/chromium/accessibility/aria-expanded-notifications-expected.txt: Removed.
  • platform/chromium/accessibility/aria-expanded-standard-items-expected.txt: Removed.
  • platform/chromium/accessibility/aria-flowto-expected.txt: Removed.
  • platform/chromium/accessibility/aria-grid-with-strange-hierarchy-expected.txt: Removed.
  • platform/chromium/accessibility/aria-grouping-roles-expected.txt: Removed.
  • platform/chromium/accessibility/aria-hidden-changes-for-non-ignored-elements-expected.txt: Removed.
  • platform/chromium/accessibility/aria-listbox-selectedchildren-change-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregion-marquee-default-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregion-on-image-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregions-addedelement-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregions-attributes-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregions-changedalt-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregions-changedtext-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregions-notifications-always-sent-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregions-notifications-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregions-removedelement-expected.txt: Removed.
  • platform/chromium/accessibility/aria-menu-role-descriptions-expected.txt: Removed.
  • platform/chromium/accessibility/aria-menubar-expected.txt: Removed.
  • platform/chromium/accessibility/aria-multiline-expected.txt: Removed.
  • platform/chromium/accessibility/aria-multiselectable-expected.txt: Removed.
  • platform/chromium/accessibility/aria-owns-expected.txt: Removed.
  • platform/chromium/accessibility/aria-popup-buttons-on-native-elements-expected.txt: Removed.
  • platform/chromium/accessibility/aria-radiobutton-text-expected.txt: Removed.
  • platform/chromium/accessibility/aria-radiogroup-expected.txt: Removed.
  • platform/chromium/accessibility/aria-range-expected.txt: Removed.
  • platform/chromium/accessibility/aria-range-value-expected.txt: Removed.
  • platform/chromium/accessibility/aria-required-expected.txt: Removed.
  • platform/chromium/accessibility/aria-slider-expected.txt: Removed.
  • platform/chromium/accessibility/aria-slider-value-change-expected.txt: Removed.
  • platform/chromium/accessibility/aria-sort-expected.txt: Removed.
  • platform/chromium/accessibility/aria-spinbutton-expected.txt: Removed.
  • platform/chromium/accessibility/aria-table-with-colspan-cells-expected.txt: Removed.
  • platform/chromium/accessibility/aria-tables-expected.txt: Removed.
  • platform/chromium/accessibility/aria-toolbar-expected.txt: Removed.
  • platform/chromium/accessibility/aria-tree-activedescendant-expected.txt: Removed.
  • platform/chromium/accessibility/aria-tree-expected.txt: Removed.
  • platform/chromium/accessibility/aria-tree-index-of-items-expected.txt: Removed.
  • platform/chromium/accessibility/aria-treegrid-expected.txt: Removed.
  • platform/chromium/accessibility/aria-valuetext-expected.txt: Removed.
  • platform/chromium/accessibility/attributed-string-includes-highlighting-expected.txt: Removed.
  • platform/chromium/accessibility/attributed-string-includes-misspelled-with-selection-expected.txt: Removed.
  • platform/chromium/accessibility/bounds-for-range-expected.txt: Removed.
  • platform/chromium/accessibility/button-shouldnot-have-axvalue-expected.txt: Removed.
  • platform/chromium/accessibility/canvas-expected.txt: Removed.
  • platform/chromium/accessibility/change-notification-on-scroll-expected.txt: Removed.
  • platform/chromium/accessibility/clipped-text-under-element-expected.txt: Removed.
  • platform/chromium/accessibility/content-editable-expected.txt: Removed.
  • platform/chromium/accessibility/content-editable-range-properties-expected.txt: Removed.
  • platform/chromium/accessibility/crash-in-element-for-text-marker-expected.txt: Removed.
  • platform/chromium/accessibility/crash-invalid-text-marker-node-expected.txt: Removed.
  • platform/chromium/accessibility/css-content-attribute-expected.txt: Removed.
  • platform/chromium/accessibility/css-speech-speak-expected.txt: Removed.
  • platform/chromium/accessibility/definition-list-term-expected.txt: Removed.
  • platform/chromium/accessibility/deleting-iframe-destroys-axcache-expected.txt: Removed.
  • platform/chromium/accessibility/div-containing-div-with-aria-expected.txt: Removed.
  • platform/chromium/accessibility/document-attributes-expected.txt: Removed.
  • platform/chromium/accessibility/document-links-expected.txt: Removed.
  • platform/chromium/accessibility/document-title-used-for-description-expected.txt: Removed.
  • platform/chromium/accessibility/double-title-expected.txt: Removed.
  • platform/chromium/accessibility/element-focus-expected.txt: Removed.
  • platform/chromium/accessibility/element-for-text-marker-expected.txt: Removed.
  • platform/chromium/accessibility/element-haspopup-expected.txt: Removed.
  • platform/chromium/accessibility/element-is-ignored-expected.txt: Removed.
  • platform/chromium/accessibility/element-level-expected.txt: Removed.
  • platform/chromium/accessibility/estimated-progress-expected.txt: Removed.
  • platform/chromium/accessibility/footer-expected.txt: Removed.
  • platform/chromium/accessibility/footer-roledescription-expected.txt: Removed.
  • platform/chromium/accessibility/form-control-value-settable-expected.txt: Removed.
  • platform/chromium/accessibility/frame-with-title-expected.txt: Removed.
  • platform/chromium/accessibility/header-expected.txt: Removed.
  • platform/chromium/accessibility/heading-clickpoint-expected.txt: Removed.
  • platform/chromium/accessibility/html-section-elements-expected.txt: Removed.
  • platform/chromium/accessibility/html-slider-indicator-expected.txt: Removed.
  • platform/chromium/accessibility/html-with-aria-label-expected.txt: Removed.
  • platform/chromium/accessibility/html5-input-number-expected.txt: Removed.
  • platform/chromium/accessibility/html5-required-attribute-expected.txt: Removed.
  • platform/chromium/accessibility/iframe-aria-hidden-expected.txt: Removed.
  • platform/chromium/accessibility/iframe-with-title-correct-hierarchy-expected.txt: Removed.
  • platform/chromium/accessibility/image-map2-expected.txt: Removed.
  • platform/chromium/accessibility/imagemap-hittest-expected.txt: Removed.
  • platform/chromium/accessibility/inherited-presentational-lists-expected.txt: Removed.
  • platform/chromium/accessibility/input-image-url-expected.txt: Removed.
  • platform/chromium/accessibility/input-slider-expected.txt: Removed.
  • platform/chromium/accessibility/internal-link-anchors-expected.txt: Removed.
  • platform/chromium/accessibility/internal-link-anchors2-expected.txt: Removed.
  • platform/chromium/accessibility/internal-link-when-document-has-fragment-expected.txt: Removed.
  • platform/chromium/accessibility/label-element-with-hidden-control-expected.txt: Removed.
  • platform/chromium/accessibility/list-items-ignored-expected.txt: Removed.
  • platform/chromium/accessibility/listbox-hit-test-expected.txt: Removed.
  • platform/chromium/accessibility/lists-expected.txt: Removed.
  • platform/chromium/accessibility/live-region-on-span-expected.txt: Removed.
  • platform/chromium/accessibility/math-alttext-expected.txt: Removed.
  • platform/chromium/accessibility/media-element-expected.txt: Removed.
  • platform/chromium/accessibility/misspelled-attributed-string-expected.txt: Removed.
  • platform/chromium/accessibility/mixed-checkbox-expected.txt: Removed.
  • platform/chromium/accessibility/native-vs-nonnative-checkboxes-expected.txt: Removed.
  • platform/chromium/accessibility/no-unknown-objects-when-title-attribute-present-expected.txt: Removed.
  • platform/chromium/accessibility/option-with-arialabel-expected.txt: Removed.
  • platform/chromium/accessibility/option-with-lang-expected.txt: Removed.
  • platform/chromium/accessibility/parent-of-table-row-is-table-expected.txt: Removed.
  • platform/chromium/accessibility/plugin-expected.txt: Removed.
  • platform/chromium/accessibility/popup-button-title-expected.txt: Removed.
  • platform/chromium/accessibility/progressbar-expected.txt: Removed.
  • platform/chromium/accessibility/radio-button-group-members-expected.txt: Removed.
  • platform/chromium/accessibility/range-alter-by-step-expected.txt: Removed.
  • platform/chromium/accessibility/range-for-line-textarea-expected.txt: Removed.
  • platform/chromium/accessibility/range-for-position-expected.txt: Removed.
  • platform/chromium/accessibility/removing-textarea-after-edit-crash-expected.txt: Removed.
  • platform/chromium/accessibility/scrollbars-expected.txt: Removed.
  • platform/chromium/accessibility/search-predicate-expected.txt: Removed.
  • platform/chromium/accessibility/search-subrole-expected.txt: Removed.
  • platform/chromium/accessibility/search-when-element-starts-in-table-expected.txt: Removed.
  • platform/chromium/accessibility/search-with-frames-expected.txt: Removed.
  • platform/chromium/accessibility/select-element-selection-with-optgroups-expected.txt: Removed.
  • platform/chromium/accessibility/selected-rows-table-expected.txt: Removed.
  • platform/chromium/accessibility/selected-tab-crash-expected.txt: Removed.
  • platform/chromium/accessibility/selected-text-range-for-empty-textarea-expected.txt: Removed.
  • platform/chromium/accessibility/selection-value-changes-for-aria-textbox-expected.txt: Removed.
  • platform/chromium/accessibility/slider-allows-title-ui-element-expected.txt: Removed.
  • platform/chromium/accessibility/slider-supports-actions-expected.txt: Removed.
  • platform/chromium/accessibility/stale-table-rows-expected.txt: Removed.
  • platform/chromium/accessibility/static-text-role-uses-text-under-element-expected.txt: Removed.
  • platform/chromium/accessibility/static-text-with-aria-label-expected.txt: Removed.
  • platform/chromium/accessibility/string-range-contains-listmarker-expected.txt: Removed.
  • platform/chromium/accessibility/submit-button-default-value-expected.txt: Removed.
  • platform/chromium/accessibility/supports-focus-setting-expected.txt: Removed.
  • platform/chromium/accessibility/table-attributes-expected.txt: Removed.
  • platform/chromium/accessibility/table-cell-spans-expected.txt: Removed.
  • platform/chromium/accessibility/table-cells-expected.txt: Removed.
  • platform/chromium/accessibility/table-detection-expected.txt: Removed.
  • platform/chromium/accessibility/table-multi-bodies-expected.txt: Removed.
  • platform/chromium/accessibility/table-one-cell-expected.txt: Removed.
  • platform/chromium/accessibility/table-sections-expected.txt: Removed.
  • platform/chromium/accessibility/table-updating-expected.txt: Removed.
  • platform/chromium/accessibility/table-with-aria-role-expected.txt: Removed.
  • platform/chromium/accessibility/table-with-row-col-of-headers-expected.txt: Removed.
  • platform/chromium/accessibility/table-with-rules-expected.txt: Removed.
  • platform/chromium/accessibility/table-with-zebra-rows-expected.txt: Removed.
  • platform/chromium/accessibility/text-marker-length-expected.txt: Removed.
  • platform/chromium/accessibility/textbox-role-reports-line-number-expected.txt: Removed.
  • platform/chromium/accessibility/textbox-role-reports-notifications-expected.txt: Removed.
  • platform/chromium/accessibility/textmarker-for-index-out-of-bounds-crash-expected.txt: Removed.
  • platform/chromium/accessibility/textmarker-routines-expected.txt: Removed.
  • platform/chromium/accessibility/title-attribute-not-used-as-axtitle-expected.txt: Removed.
  • platform/chromium/accessibility/title-attribute-used-as-last-resort-expected.txt: Removed.
  • platform/chromium/accessibility/unexpected-help-text-expected.txt: Removed.
  • platform/chromium/accessibility/unsupported-attribute-does-not-crash-expected.txt: Removed.
  • platform/chromium/accessibility/update-children-when-aria-role-changes-expected.txt: Removed.
  • platform/chromium/accessibility/updating-attribute-in-table-row-crash-expected.txt: Removed.
  • platform/chromium/accessibility/visible-position-crash-for-text-node-expected.txt: Removed.
  • platform/chromium/accessibility/webarea-can-set-focus-expected.txt: Removed.
  • platform/chromium/accessibility/webarea-size-equals-content-size-expected.txt: Removed.
  • platform/chromium/accessibility/webkit-scrollarea-expected.txt: Removed.
  • platform/chromium/accessibility/webkit-scrollarea-position-expected.txt: Removed.
2:08 PM Changeset in webkit [139494] by tony@chromium.org
  • 4 edits
    1 add in trunk/Source

[chromium] Don't regenerate all bindings when any idl file changes
​https://bugs.webkit.org/show_bug.cgi?id=106604

Reviewed by Kentaro Hara.

Source/WebCore:

Currently, every idl file is a dependency of generating the supplemental dependency map
and generating bindings is a dependency of the map. This means that touching any idl file
causes us to regenerate all the bindings.

Change it so that generating bindings only depends on the idl files that have Supplemental= in them.
We only have 24 idl files with Supplemental (3.7% of the 638 idl files in WebCore) so modifying
any of those will cause all bindings to be regenerated.

If you add or remove a new idl file, you have to rerun gyp which will fix up any dependencies.
If you edit an existing file and add Supplemental= to it, you will now need to rerun gyp_{webkit,chromium}.
I think that's a reasonable tradeoff since it seems highly unlikely that you would adding Supplemental=
to an existing file without renaming it. The bots will always be fine because they always run
gyp after updating.

No new tests, this is a build only change.

  • WebCore.gyp/WebCore.gyp: Remove <(SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp, which was causing

the full rebuild. The step to generate this file is still a hard dependency so it will still be generated and
used by generate-bindings.pl. Also remove <@(webcore_test_support_idl_files). This was saying we should regenerate
all bindings if a test idl file changed. That doesn't make sense.

  • WebCore.gyp/scripts/supplemental_idl_files.py: Added.

(DoMain):

Source/WebKit/chromium:

  • gyp_webkit: Add Source/WebCore/WebCore.gyp/scripts to the python import search path

so we can generate idl dependencies at gyp time.

2:05 PM Changeset in webkit [139493] by Alexandru Chiculita
  • 8 edits
    1 move
    7 adds
    1 delete in trunk

Element is displayed behind a composited layer when clipping is used on a previous element
​https://bugs.webkit.org/show_bug.cgi?id=104981

Reviewed by Simon Fraser.

Source/WebCore:

RenderLayerCompositor::computeCompositingRequirements uses the local bounding box of the layers to optimize the number of composited
layers that are created. That's needed in order to make sure that composited layers that are displayed behind non-composited
layers are correctly promoting the layers in front to be composited. Otherwise the non-composited layers are rendered
in the parent composited layer, displaying behind the other composited layers. That might be wrong as the correct paint order might not be
preserved.

In order to make animations work, there's a flag that will disable that optimization. That's because the animations run in the platform
layer and the platform layer doesn't know about the layers that are not promoted to composited layers. When the overlapping of the layers
is computed it just uses the start or the stop state, but no intermediate states. For that reason, all the 'top' layers in front of animated
elements will become composited.

When an animation has a clipping rectangle, then we know for sure that the animation is going to be contained inside the clip area, so WebKit
uses the bounding box of the clipping area to detect the overlapping layers, so there's no need to disable the optimization in that case.

However, if there is a different animation displaying behind the clipping container, we cannot safely disable that optimization anymore. That's
because we still don't know what are the intermediate states of that particular animated layer. The bug was that the optimization was re-enabled
anyway, even in this particular case.

In order to fix it, I changed the logic, so that instead of re-enabling the optimization after a clipping container, it will just avoid to propagate
the internal state to the following layers when there's no need to so.

Note that 3D transforms behave like animations for now and disable the optimization. Because of that some of the existing tests ended up
creating more layers than needed. That's because the tests had an overflow area that recreated the issue that this patch fixes, but with
3D transforms instead of animations. 3D transforms will be treated in a separate patch.

Tests: compositing/layer-creation/overlap-animation-clipping.html

compositing/layer-creation/overlap-animation-container.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

LayoutTests:

Updated existing test results and added two new tests to check that animations respect the correct paint order,
even though they are painted with composited layers.

Note that there are side effects of this patch that will be corrected in a following bug. 3D layers are treated like animations, so they
disable the overlapping optimizations. Because of that, some of the test results were updated to include the layers that, previously,
were not created as a result of being in front of a "clipping container".

  • compositing/geometry/foreground-layer-expected.txt:
  • compositing/layer-creation/overlap-animation-clipping-expected.txt: Added.
  • compositing/layer-creation/overlap-animation-clipping.html: Added. Checking that the animation inside a clipping container is not

affecting how we compute the animations outside the clipping container.

  • compositing/layer-creation/overlap-animation-container-expected.txt: Added.
  • compositing/layer-creation/overlap-animation-container.html: Added. Checking that we don't create unnecessary composited layers for layers inside

composited containers that draw in front of animated layers.

  • compositing/overflow/clip-descendents-expected.txt:
  • compositing/overflow/clip-descendents.html: Removed the text from the output, so that platforms can share the same expected result.
  • platform/chromium-win/compositing/overflow/clip-descendents-expected.txt: Removed. Not needed anymore, all Chromium platforms can share the same results now.
  • platform/chromium/compositing/geometry/foreground-layer-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt: Added.
  • platform/chromium/compositing/layer-creation/overlap-animation-container-expected.txt: Added.
  • platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt: Added.
  • platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
  • platform/chromium/compositing/overflow/clip-descendents-expected.txt: Renamed from LayoutTests/platform/chromium-mac/compositing/overflow/clip-descendents-expected.txt.
  • platform/qt/compositing/overflow/clip-descendents-expected.txt:
1:45 PM Changeset in webkit [139492] by schenney@chromium.org
  • 51 edits
    49 adds in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

Mozilla test cases for linux. Also re-adding hixie/perf/006.xml, which is failing

  • platform/chromium-linux-x86/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug1318-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug137388-2-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug138725-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug23235-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug2479-2-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug26178-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug28928-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug29326-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug33855-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug39209-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4093-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4382-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4429-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug44505-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug46368-1-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug46368-2-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug51037-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug51727-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug52505-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug52506-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug60749-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug68912-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug92647-2-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/collapsing_borders: Added.
  • platform/chromium-linux-x86/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/core: Added.
  • platform/chromium-linux-x86/tables/mozilla/core/margins-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/dom: Added.
  • platform/chromium-linux-x86/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/other: Added.
  • platform/chromium-linux-x86/tables/mozilla/other/move_row-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/chromium-linux-x86/transforms/2d/zoom-menulist-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug23235-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug52505-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug52506-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug68912-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-linux/tables/mozilla/core/margins-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-linux/transforms/2d/zoom-menulist-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-win-xp/tables/mozilla/bugs/bug137388-2-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug23235-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug4093-expected.png: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug23235-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium/TestExpectations:
1:33 PM Changeset in webkit [139491] by ggaren@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Removed getDirectLocation and offsetForLocation and all their uses
​https://bugs.webkit.org/show_bug.cgi?id=106692

Reviewed by Filip Pizlo.

getDirectLocation() and its associated offsetForLocation() relied on
detailed knowledge of the rules of PropertyOffset, JSObject, and
Structure, which is a hard thing to reverse-engineer reliably. Luckily,
it wasn't needed, and all clients either wanted a true value or a
PropertyOffset. So, I refactored accordingly.

  • dfg/DFGOperations.cpp: Renamed putDirectOffset to putDirect, to clarify

that we are not putting an offset.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertySlot): Get a value instead of a value
pointer, since we never wanted a pointer to begin with.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot): Use a PropertyOffset instead of a pointer,
so we don't have to reverse-engineer the offset from the pointer.

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::resetInheritorID):
(JSC::JSObject::inheritorID):
(JSC::JSObject::removeDirect):
(JSC::JSObject::fillGetterPropertySlot):
(JSC::JSObject::getOwnPropertyDescriptor): Renamed getDirectOffset and
putDirectOffset, as explaind above. We want to use the name "getDirectOffset"
for when the thing you're getting is the offset.

  • runtime/JSObject.h:

(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectOffset): Changed getDirectLocation to getDirectOffset,
since clients really wants PropertyOffsets and not locations.

(JSObject::offsetForLocation): Removed this function because it was hard
to get right.

(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectUndefined):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):

  • runtime/JSScope.cpp:

(JSC::executeResolveOperations):
(JSC::JSScope::resolvePut):

  • runtime/JSValue.cpp:

(JSC::JSValue::putToPrimitive): Updated for renames.

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot): Use a PropertyOffset instead of a pointer,
so we don't have to reverse-engineer the offset from the pointer.

  • runtime/Structure.cpp:

(JSC::Structure::flattenDictionaryStructure): Updated for renames.

1:30 PM Changeset in webkit [139490] by schenney@chromium.org
  • 115 edits
    73 adds in trunk/LayoutTests

Unreviewed gardening. r139445 triggered assertions in Skia on debug Chromium bots.
Marking them as crashing in TestExpectations.

Patch by Levi Weintraub <​leviw@chromium.org> on 2013-01-11

  • platform/chromium/TestExpectations:
1:20 PM Changeset in webkit [139489] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. r139445 triggered assertions in Skia on debug Chromium bots.
Marking them as crashing in TestExpectations.

  • platform/chromium/TestExpectations:
1:09 PM Changeset in webkit [139488] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Removed an unused version of getDirectLocation
​https://bugs.webkit.org/show_bug.cgi?id=106691

Reviewed by Gavin Barraclough.

getDirectLocation is a weird operation. Removing the unused version is
the easy part.

  • runtime/JSObject.h:

(JSObject):

1:08 PM Changeset in webkit [139487] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Add WTF_EXPORT_PRIVATE to printInternal() methods of PrintStream.h

Rubber stamped by Mark Hahnenberg.

This will make it easier to use dataLog() from WebCore.

  • wtf/PrintStream.h:

(WTF):

12:56 PM Changeset in webkit [139486] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Objective-C objects that are passed to JavaScript leak (until the JSContext is destroyed)
​https://bugs.webkit.org/show_bug.cgi?id=106056

Reviewed by Darin Adler.

  • API/APIJSValue.h:
  • API/JSValue.mm: Make the reference to the JSContext strong.

(-[JSValue context]):
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):

  • API/JSWrapperMap.mm: Make the reference back from wrappers to Obj-C objects weak instead of strong.

Also add an explicit WeakGCMap in the JSWrapperMap rather than using Obj-C associated object API which
was causing memory leaks.
(wrapperClass):
(-[JSObjCClassInfo wrapperForObject:]):
(-[JSWrapperMap initWithContext:]):
(-[JSWrapperMap dealloc]):
(-[JSWrapperMap wrapperForObject:]):

12:31 PM Changeset in webkit [139485] by schenney@chromium.org
  • 43 edits
    35 adds in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

These are a few files that had some platforms already failing, hence
requiring special care and attention.

  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-linux-x86/fast/speech: Added.
  • platform/chromium-linux-x86/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-linux-x86/fast/transforms: Added.
  • platform/chromium-linux-x86/fast/transforms/transformed-focused-text-input-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/batik/filters: Added.
  • platform/chromium-linux-x86/svg/batik/filters/feTile-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/js-late-gradient-creation-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/css3-linear-right-angle-gradients-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-mac-lion/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-lion/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-linear-right-angle-gradients-expected.png:
  • platform/chromium-mac-lion/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac-lion/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
  • platform/chromium-mac-lion/svg/batik/filters/feTile-expected.png: Added.
  • platform/chromium-mac-lion/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-mac-lion/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/css3-linear-right-angle-gradients-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
  • platform/chromium-mac/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients: Added.
  • platform/chromium-win-xp/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-win-xp/fast/speech: Added.
  • platform/chromium-win-xp/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-win-xp/svg/batik/filters: Added.
  • platform/chromium-win-xp/svg/batik/filters/feTile-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/js-late-gradient-creation-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png:
  • platform/chromium-win/fast/gradients/css3-linear-right-angle-gradients-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium/TestExpectations:
12:23 PM Changeset in webkit [139484] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Skip CachedImage::CreateImage if we don't have image data
​https://bugs.webkit.org/show_bug.cgi?id=106156

Reviewed by Nate Chapin.

This patch skips image creation if we do not have image data. This can occur during
cache revalidation when the revalidation request (304 not modified) comes back without
any content. In this revalidation case, the http spec requires that a mimetype not be set
on the response to prevent a cached resource from having a different mimetype
from the revalidated resource. Because revalidation requests do not have a mimetype,
CachedImage::CreateImage() will fail on SVG images. This patch prevents
CachedImage::CreateImage() from being called during revalidation.

No new tests as there are no observable changes from this patch.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::data):

12:21 PM Changeset in webkit [139483] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests.

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::TestExceptionV8Internal::nameAttrGetter):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):

12:20 PM Changeset in webkit [139482] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fixed some bogus PropertyOffset ASSERTs
​https://bugs.webkit.org/show_bug.cgi?id=106686

Reviewed by Gavin Barraclough.

The ASSERTs were passing a JSType instead of an inlineCapacity, due to
an incomplete refactoring.

The compiler didn't catch this because both types are int underneath.

  • runtime/JSObject.h:

(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::offsetForLocation):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransitionToExistingStructure): Validate against
our inline capacity, as we intended.

12:13 PM Changeset in webkit [139481] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Rename propertyOffsetFor => offsetForPropertyNumber
​https://bugs.webkit.org/show_bug.cgi?id=106685

Reviewed by Gavin Barraclough.

Since the argument is just a typedef and not an object, I wanted to clarify the meaning.

  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::nextOffset): Updated for rename.

  • runtime/PropertyOffset.h:

(JSC::offsetForPropertyNumber): Renamed. Also changed some PropertyOffset variables
to plain ints, because they're not actually on the PropertyOffsets number line.

  • runtime/Structure.cpp:

(JSC::Structure::flattenDictionaryStructure):

  • runtime/Structure.h:

(JSC::Structure::lastValidOffset): Updated for rename.

12:06 PM Changeset in webkit [139480] by schenney@chromium.org
  • 131 edits
    28 adds in trunk/LayoutTests

RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
​https://bugs.webkit.org/show_bug.cgi?id=106047

Patch by Levi Weintraub <​leviw@chromium.org> on 2013-01-11
Reviewed by Simon Fraser.

  • fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added.
  • fast/layers/geometry-map-transform-state-translation-mismatch.html: Added.
11:59 AM Changeset in webkit [139479] by leviw@chromium.org
  • 4 edits
    2 adds in trunk

RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
​https://bugs.webkit.org/show_bug.cgi?id=106047

Reviewed by Simon Fraser.

Source/WebCore:

Mirror RenderGeometryMap's optimization for integer-translated transforms in TransformState.
This avoids the current behavior where the two can disagree on mappings, since RenderGeometryMap
pixel-snapped later when a translation occurred between two sub-pixel containers.

Test: fast/layers/geometry-map-transform-state-translation-mismatch.html

  • platform/graphics/transforms/TransformState.h:

(WebCore::TransformState::setQuad): Clear accumulatedOffset when setting a new quad. Note: this
implementation only works properly when only tracking a quad.

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::applyTransform): apply integral translations to the accumulatedOffset
for performance and consistency with RenderGeometryMap.

LayoutTests:

  • fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added.
  • fast/layers/geometry-map-transform-state-translation-mismatch.html: Added.
11:58 AM Changeset in webkit [139478] by psolanki@apple.com
  • 2 edits in trunk/Tools

TestRunner leaks when running tests
​https://bugs.webkit.org/show_bug.cgi?id=106683

Reviewed by Simon Fraser.

Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
tests.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::makeWindowObject):

11:50 AM Changeset in webkit [139477] by andersca@apple.com
  • 2 edits in branches/safari-536.28-branch/Source/WebKit2

Merge r139464.

2013-01-11 Anders Carlsson <​andersca@apple.com>


Incoming synchronous messages can sometimes arrive out of order
​https://bugs.webkit.org/show_bug.cgi?id=106677
<rdar://problem/12889499>

Reviewed by Andreas Kling.

In cases where synchronous messages come in more than one connection at the same time, we can sometimes deliver
the synchronous messages before any pending asynchronous messages on that connection. This breaks FIFO ordering.

Fix this by separating the "dispatch all incoming synchronous messages" phase out into multiple phases, so we'll
schedule one call per connection instead of one call for all connections.

  • Platform/CoreIPC/Connection.cpp: (Connection::SyncMessageState): (CoreIPC::Connection::SyncMessageState::SyncMessageState): (CoreIPC::Connection::SyncMessageState::processIncomingMessage): (CoreIPC::Connection::SyncMessageState::dispatchMessages): (CoreIPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesForConnection): (CoreIPC::Connection::waitForSyncReply):
11:49 AM Changeset in webkit [139476] by kerz@chromium.org
  • 4 edits
    10 copies in branches/chromium/1364

Merge 138162

Text Autosizing: Work out what to do about form controls
​https://bugs.webkit.org/show_bug.cgi?id=102560

Patch by Tim Volodine <​timvolodine@chromium.org> on 2012-12-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Disallow autosizing of form input controls like buttons, text input fields, selection controls, radio buttons
and check boxes. This is a short term solution to avoid inconsistent autosizing of form controls (which is
worse than not autosizing at all).

Tests: fast/text-autosizing/form-controls-autosizing-button-input-elements.html

fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html
fast/text-autosizing/form-controls-autosizing-radio-input-element.html
fast/text-autosizing/form-controls-autosizing-select-element.html
fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html

  • rendering/TextAutosizer.cpp:

(WebCore):
(WebCore::formInputTags):
(WebCore::TextAutosizer::isAutosizingContainer):
(WebCore::TextAutosizer::contentHeightIsConstrained):
(WebCore::TextAutosizer::containerShouldBeAutosized):
(WebCore::TextAutosizer::containerContainsOneOfTags):

  • rendering/TextAutosizer.h:

LayoutTests:

Tests for form input elements autosizing. Added tests to check that various kinds of form elements
don't get autosized, i.e. buttons, textareas, check boxes, radio button and selection menus.

  • fast/text-autosizing/form-controls-autosizing-button-input-elements-expected.html: Added.
  • fast/text-autosizing/form-controls-autosizing-button-input-elements.html: Added.
  • fast/text-autosizing/form-controls-autosizing-checkbox-input-element-expected.html: Added.
  • fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html: Added.
  • fast/text-autosizing/form-controls-autosizing-radio-input-element-expected.html: Added.
  • fast/text-autosizing/form-controls-autosizing-radio-input-element.html: Added.
  • fast/text-autosizing/form-controls-autosizing-select-element-expected.html: Added.
  • fast/text-autosizing/form-controls-autosizing-select-element.html: Added.
  • fast/text-autosizing/form-controls-autosizing-textfield-input-elements-expected.html: Added.
  • fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html: Added.

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11858022

11:46 AM Changeset in webkit [139475] by schenney@chromium.org
  • 575 edits
    111 adds in trunk/LayoutTests

[Chromium] Mac editing test rebaseline

Unreviewed expectations update.

For whatever reason Mac 10.6 and 10.7 use Skia for drawing edit boxes.
They all needed rebaselining.

  • platform/chromium-mac-lion/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-trailing-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac-lion/editing/deleting/non-smart-delete-expected.png:
  • platform/chromium-mac-lion/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac-lion/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/print-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/selectAll-expected.png:
  • platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
  • platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/chromium-mac-lion/editing/inserting/12882-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4278698-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4840662-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4959067-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5002441-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5418891-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5510537-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac-lion/editing/inserting/6703873-expected.png:
  • platform/chromium-mac-lion/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-lion/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac-lion/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac-lion/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-3778059-fix-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-after-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-div-026-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-space-in-empty-doc-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac-lion/editing/inserting/line-break-expected.png:
  • platform/chromium-mac-lion/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/redo-expected.png:
  • platform/chromium-mac-lion/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-around-image-001-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/copy-standalone-image-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-4038267-fix-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-002-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-003-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-004-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-005-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-007-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-008-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-009-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-010-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-match-style-001-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-match-style-002-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/smart-paste-007-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac-lion/editing/selection/13804-expected.png:
  • platform/chromium-mac-lion/editing/selection/4818145-expected.png:
  • platform/chromium-mac-lion/editing/selection/4866671-expected.png:
  • platform/chromium-mac-lion/editing/selection/4889598-expected.png:
  • platform/chromium-mac-lion/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/4947387-expected.png:
  • platform/chromium-mac-lion/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5007143-expected.png:
  • platform/chromium-mac-lion/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5057506-expected.png:
  • platform/chromium-mac-lion/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/5099303-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac-lion/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/6476-expected.png:
  • platform/chromium-mac-lion/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac-lion/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac-lion/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac-lion/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac-lion/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac-lion/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac-lion/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac-lion/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-003-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-004-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-005-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-006-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac-lion/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac-lion/editing/selection/inline-table-expected.png:
  • platform/chromium-mac-lion/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-between-blocks-no-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-004-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-005-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-6-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-line-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-sentence-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-mac-lion/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac-lion/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac-lion/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-mac-lion/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac-lion/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac-lion/editing/spelling/grammar-markers-expected.png:
  • platform/chromium-mac-lion/editing/spelling/spelling-expected.png:
  • platform/chromium-mac-lion/editing/style/4916887-expected.png:
  • platform/chromium-mac-lion/editing/style/5017613-1-expected.png:
  • platform/chromium-mac-lion/editing/style/5017613-2-expected.png:
  • platform/chromium-mac-lion/editing/style/5046875-1-expected.png:
  • platform/chromium-mac-lion/editing/style/5046875-2-expected.png:
  • platform/chromium-mac-lion/editing/style/5065910-expected.png:
  • platform/chromium-mac-lion/editing/style/5084241-expected.png:
  • platform/chromium-mac-lion/editing/style/5228141-expected.png:
  • platform/chromium-mac-lion/editing/style/5279521-expected.png:
  • platform/chromium-mac-lion/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac-lion/editing/style/highlight-expected.png:
  • platform/chromium-mac-lion/editing/style/smoosh-styles-001-expected.png:
  • platform/chromium-mac-lion/editing/style/smoosh-styles-003-expected.png:
  • platform/chromium-mac-lion/editing/style/style-3681552-fix-001-expected.png:
  • platform/chromium-mac-lion/editing/style/style-3681552-fix-002-expected.png:
  • platform/chromium-mac-lion/editing/style/style-3998892-fix-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-001-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-002-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-003-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-004-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac-lion/editing/style/typing-style-001-expected.png:
  • platform/chromium-mac-lion/editing/style/typing-style-002-expected.png:
  • platform/chromium-mac-lion/editing/style/unbold-in-bold-expected.png:
  • platform/chromium-mac-lion/editing/undo/4063751-expected.png:
  • platform/chromium-mac-lion/editing/undo/5378473-expected.png: Added.
  • platform/chromium-mac-lion/editing/undo/redo-typing-001-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-combined-delete-boundary-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-combined-delete-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-delete-boundary-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-delete-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-forward-delete-boundary-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-forward-delete-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-misspellings-expected.png: Added.
  • platform/chromium-mac-lion/editing/undo/undo-typing-001-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/non-smart-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/smart-delete-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/smart-delete-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/print-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/selectAll-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/12882-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4278698-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4840662-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4959067-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5002441-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5510537-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/6703873-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-3775316-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-3778059-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-3800346-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-after-delete-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-at-tabspan-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-at-tabspan-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-at-tabspan-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-025-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-026-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-space-in-empty-doc-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-at-tabspan-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-at-tabspan-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-at-tabspan-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/line-break-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/redo-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-around-image-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-4035648-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-4038267-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-009-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-010-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-match-style-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-match-style-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-at-tabspan-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/13804-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4818145-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4866671-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4889598-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4947387-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5007143-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5057506-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5099303-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/6476-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-character-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-character-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-character-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-character-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-character-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-character-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-sentence-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-word-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/inline-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-between-blocks-no-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-6-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-line-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-sentence-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-word-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-past-trailing-space-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-missing-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/selection-3748164-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/grammar-markers-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/4916887-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5017613-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5017613-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5046875-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5046875-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5065910-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5084241-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5228141-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5279521-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/block-styles-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/highlight-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/smoosh-styles-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/smoosh-styles-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-3681552-fix-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-3681552-fix-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-3998892-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-boundary-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-boundary-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-boundary-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-boundary-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/typing-style-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/typing-style-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/unbold-in-bold-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/4063751-expected.png:
  • platform/chromium-mac-snowleopard/editing/undo/5378473-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/redo-typing-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-combined-delete-boundary-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-combined-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-delete-boundary-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-forward-delete-boundary-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-forward-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-misspellings-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-typing-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium/TestExpectations:
11:45 AM Changeset in webkit [139474] by kerz@chromium.org
  • 11 edits in branches/chromium/1364

Merge 139435

Text Autosizing - elements much narrower than its parent autosizing clusters should be autosized separately.
​https://bugs.webkit.org/show_bug.cgi?id=105188

Patch by Anton Vayvod <​avayvod@chromium.org> on 2013-01-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Some blocks of text might be narrower than their parent clusters and should be autosized separately.
This helps with autosizing for the pages implementing the sidebars as a narrow blocks of text with wide margins and
the main content being positioned atop this margin (or vice versa).

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::isContainerAutosizingCluster):

Returns true if the container is more than 200 pixels narrower than its parent cluster's lowest common
ancestor of all the text nodes.

LayoutTests:

Checked that a narrow autosizing container becomes an autosizing cluster.
Fixed other tests that used narrow descendant blocks.

  • fast/text-autosizing/cluster-narrow-in-wide-expected.html:
  • fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html:
  • fast/text-autosizing/cluster-narrow-in-wide-ohidden.html:
  • fast/text-autosizing/cluster-narrow-in-wide.html:
  • fast/text-autosizing/cluster-with-wide-lca-expected.html:
  • fast/text-autosizing/cluster-with-wide-lca.html:
  • fast/text-autosizing/narrow-child-expected.html:
  • fast/text-autosizing/narrow-child.html:

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11864024

11:43 AM Changeset in webkit [139473] by kerz@chromium.org
  • 10 edits in branches/chromium/1364

Merge 138111

Text Autosizing: containers wider than their enclosing clusters should be autosized as separate clusters
​https://bugs.webkit.org/show_bug.cgi?id=103627

Patch by Anton Vayvod <​avayvod@chromium.org> on 2012-12-18
Reviewed by Julien Chaffraix.

Source/WebCore:

Some blocks of texts might be wider than their parent clusters and need to be autosized separately.

isAutosizingCluster() now checks for the width of the container being greater than the width of the lowest
common ancestor of the text nodes of the enclosing cluster. This block containing all text is passed to all
tree traversal methods.
An overloaded version is added for cases when we don't have the lowest common ancestor yet.

The change fixes several cases covered by existing tests.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processSubtree):

Calls processCluster with a new number of arguments.

(WebCore::TextAutosizer::processCluster):

Passes block containing all text nodes into processContainer. Assertion removed since it can no longer be
checked without passing an additional parameter (the parent block containing all text) to the function
for the sake of this assertion only.

(WebCore::TextAutosizer::processContainer):

|parentBlockContainingAllText| parameter passed into isAutosizingCluster.

(WebCore::TextAutosizer::isAutosizingCluster(const RenderBlock*, const RenderBlock*)):

The overloaded method that is used when the render block checked is already known to be an autosizing
container and there's full information necessary to determine if it's a cluster like the parent block
containing all text within the enclosing cluster.
Considers a block a cluster if it is wider than its parent block containing all text within enclosing
cluster.

(WebCore::TextAutosizer::isAutosizingCluster(const RenderObject*)):

The overloaded method that checks for the given object to be an autosizing container first (for
convenience of the caller) and doesn't require information about the parent cluster. Used when such
information is not available, for example, in the process of retrieving the information for the parent
cluster or when looking for the root cluster in the tree.

(WebCore::TextAutosizer::clusterShouldBeAutosized):

Passes new parameter to measureDescendantTextWidth.

(WebCore::TextAutosizer::measureDescendantTextWidth):

Uses blockContainingAllText parameter to pass to isAutosizingCluster.

(WebCore::TextAutosizer::findDeepestBlockContainingAllText):

Assertion removed since it can no longer be checked without passing an additional parameter (the
parent block containing all text) to the function for the sake of this assertion only.

(WebCore::TextAutosizer::findFirstTextLeafNotInCluster):

Uses shorter isAutosizingCluster call.

LayoutTests:

Modified existing tests to reflect the new autosizing approach to handling of the elements that are
wider than the lowest common ancestor of the text nodes of the enclosing autosizing cluster.

  • fast/text-autosizing/cluster-wide-in-narrow-expected.html:
  • fast/text-autosizing/cluster-wide-in-narrow.html:
  • fast/text-autosizing/wide-child-expected.html:
  • fast/text-autosizing/wide-child.html:
  • fast/text-autosizing/wide-in-narrow-overflow-scroll-expected.html:
  • fast/text-autosizing/wide-in-narrow-overflow-scroll.html:

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11859014

11:41 AM Changeset in webkit [139472] by kerz@chromium.org
  • 8 edits in branches/chromium/1364/Source

Merge 139356

Fix scale of screen.width, window.outerWidth and @media device-width when page scale not applied in compositor.
​https://bugs.webkit.org/show_bug.cgi?id=106460

Patch by John Mellor <​johnme@chromium.org> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

screen.width, window.outerWidth and @media device-width should be in
density independent (UI) pixels, not physical screen pixels.

This already works on most ports (including iOS). However Chrome for
Android currently internally sizes its windows in physical screen pixels
instead of density independent pixels, and this leaks through in the
sizes provided to WebCore.

This patch scales these sizes appropriately before they reach JavaScript,
on platforms where the applyPageScaleFactorInCompositor setting is false
(i.e. just Chrome for Android). Once Chrome for Android switches over to
the same coordinate space, the applyPageScaleFactorInCompositor setting
will be removed, along with any code (such as this) that depends on it.

The effect of this patch on Chrome for Android when viewing a page with
a width=device-width viewport on a Galaxy Nexus (720x1280 @ dPR 2) is:

@media device-width changes from 720 to 360
screen.width changes from 720 to 360
screen.availWidth changes from 720 to 360
window.outerWidth changes from 720 to 360
window.innerWidth remains 360 (at overview zoom)
@media width remains 360
document.documentElement.clientWidth remains 360
document.documentElement.offsetWidth remains 360
document.documentElement.scrollWidth remains 360
document.body.clientWidth remains 360
document.body.offsetWidth remains 360
document.body.scrollWidth remains 360

And similarly for heights (though they are slightly less than 640, since
toolbars etc. get subtracted from the available height).

No new tests, as applyDeviceScaleFactorInCompositor appears to always be
true in DumpRenderTree, so this situation cannot occur there.

  • page/Settings.in:

Added applyDeviceScaleFactorInCompositor setting, which allows
detecting whether we need to normalize the scale.

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::toUserSpace):

Static function for normalizing screen rect scale.

(WebCore::screenRect):

Uses toUserSpace.

(WebCore::screenAvailableRect):

Uses toUserSpace.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processSubtree):

Use applyDeviceScaleFactorInCompositor instead of
applyPageScaleFactorInCompositor, to scale the window rect correctly
on platforms other than Chrome for Android.

Source/WebKit/chromium:

  1. Exposes the existing applyDeviceScaleFactorInCompositor from

WebSettings on Settings (and stores the value there instead), so it can
be accessed from WebCore.

  1. Changes ChromeClientImpl::windowRect to return values in density

independent (UI) pixels pixels instead of physical screen pixels (see
explanation in Source/WebCore/ChangeLog).

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::windowRect):

Normalizes window rect scale.

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setApplyDeviceScaleFactorInCompositor):
(WebKit::WebSettingsImpl::applyDeviceScaleFactorInCompositor):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11862015

11:39 AM Changeset in webkit [139471] by jparent@chromium.org
  • 4 edits in trunk/Tools

Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
​https://bugs.webkit.org/show_bug.cgi?id=106247

Old code nulled out the loader instance when it completed loading and
then later used the fact that it was null to determine if it had loaded
or not. This is not only unintuitive, but it also prevents using the
loader object later on.

Added new method, used it, added unit test for it.

Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/dashboard_base.js:

(resourceLoadingComplete):
(handleLocationChange):

  • TestResultServer/static-dashboards/loader.js:

(.):

  • TestResultServer/static-dashboards/loader_unittests.js:
11:35 AM Changeset in webkit [139470] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

Heap-use-after-free in WebCore::RenderText::computePreferredLogicalWidths
​https://bugs.webkit.org/show_bug.cgi?id=95901

Reviewed by Simon Fraser.

Prevent re-entrancy of view layout. Loading of SVG document during font load
causes it to re-enter layout and blowing the style away from underneath.

Test: Go to ​http://www.speckproducts.com and make sure crash does not happen.

  • dom/Document.cpp:

(WebCore::Document::updateLayout):

11:27 AM Changeset in webkit [139469] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

[V8] Do not create a local handle for a cached v8 string that is returned to V8 immediately
​https://bugs.webkit.org/show_bug.cgi?id=106557

Reviewed by Adam Barth.

Currently we are always creating a local handle for a cached
V8 string returned to V8:

Handle<Value> v8String(StringImpl* impl, Isolate* isolate) {

...;
return Local<String>::New(isolate, m_cachedString);

}

However, we don't need to create a local handle in a case
where it is guaranteed that no V8 object allocation is conducted
before a control flow returns back to V8. In particular, in a case
where a cached V8 string is immediately returned to V8, we don't
need to create a local handle:

Handle<Value> xxxxAttrGetter() {

...;
return v8String(imp->xxxx(), isolate); This can return a persistent handle safely.

}

This patch improves performance of div.id by 9.2%.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::TestExceptionV8Internal::nameAttrGetter):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):

  • bindings/v8/V8Binding.h:

(WebCore::v8String):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):

  • bindings/v8/V8ValueCache.cpp:

(WebCore::StringCache::v8ExternalStringSlow):

  • bindings/v8/V8ValueCache.h:

(WebCore::StringCache::v8ExternalString):
(StringCache):

11:21 AM Changeset in webkit [139468] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/hidpi/image-set-background-dynamic.html
as slow on Debug builds.

  • platform/chromium/TestExpectations:
11:20 AM Changeset in webkit [139467] by schenney@chromium.org
  • 94 edits
    62 adds in trunk/LayoutTests

[ Chromium ] New Mac rebaselines (some)

Unreviewed expectatiosn update after skia changes.

These are some of the Mac fixes, but mostly it addresses the issues
with TestExpectations, so hopefully we'll get green builds.

  • platform/chromium-mac-lion/editing/deleting/4922367-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5099303-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5126166-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5272440-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5369009-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5483370-expected.png:
  • platform/chromium-mac-lion/editing/deleting/collapse-whitespace-3587601-fix-expected.png: Added.
  • platform/chromium-mac-lion/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-3608462-fix-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-4083333-fix-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-start-or-end-expected.png: Added.
  • platform/chromium-mac-lion/editing/deleting/delete-block-contents-001-expected.png: Added.
  • platform/chromium-mac-lion/editing/deleting/delete-block-contents-002-expected.png: Added.
  • platform/chromium-mac-lion/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-005-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-006-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-007-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-008-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-009-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-010-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-011-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-012-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-013-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-014-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-015-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-016-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-017-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-006-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-007-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-character-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-image-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-image-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-image-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-image-004-expected.png: Added.
  • platform/chromium-mac-lion/editing/deleting/delete-leading-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-listitem-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-listitem-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-selection-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-tab-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/4922367-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5099303-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5126166-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5272440-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5369009-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5483370-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/collapse-whitespace-3587601-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-3608445-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-3608462-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-4083333-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-and-undo-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-009-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-010-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-011-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-start-or-end-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-009-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-010-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-011-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-012-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-013-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-014-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-015-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-016-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-017-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-character-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-image-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-image-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-image-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-image-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-leading-ws-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-listitem-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-listitem-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-selection-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/replaced-min-max-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium/TestExpectations:
11:14 AM Changeset in webkit [139466] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update NEWS and configure.ac for 1.11.4 release

.:

  • configure.ac: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.11.4.
11:11 AM Changeset in webkit [139465] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing header files.
11:08 AM Changeset in webkit [139464] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Incoming synchronous messages can sometimes arrive out of order
​https://bugs.webkit.org/show_bug.cgi?id=106677
<rdar://problem/12889499>

Reviewed by Andreas Kling.

In cases where synchronous messages come in more than one connection at the same time, we can sometimes deliver
the synchronous messages before any pending asynchronous messages on that connection. This breaks FIFO ordering.

Fix this by separating the "dispatch all incoming synchronous messages" phase out into multiple phases, so we'll
schedule one call per connection instead of one call for all connections.

  • Platform/CoreIPC/Connection.cpp:

(Connection::SyncMessageState):
(CoreIPC::Connection::SyncMessageState::SyncMessageState):
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
(CoreIPC::Connection::SyncMessageState::dispatchMessages):
(CoreIPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesForConnection):
(CoreIPC::Connection::waitForSyncReply):

11:07 AM Changeset in webkit [139463] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Skipping accessibility/corresponding-control-deleted-crash.html on Mac since
it fails without Shadow DOM enabled.

  • platform/mac/TestExpectations:
10:59 AM Changeset in webkit [139462] by leviw@chromium.org
  • 1 edit
    2 copies in branches/chromium/1364

Merge 139346

ScrollingCoordinator touch event hit rects aren't converted to proper coordinates when in nested views
​https://bugs.webkit.org/show_bug.cgi?id=106383

Reviewed by James Robinson.

Source/WebCore:

ScrollingCoordinator uses clippedOverflowRectForRepaint(0) to generate the bounds for a renderer's hit
testing rect. The rect this returns is in the coordinates of its document. This change converts the
rect to the outermost view's coordinate system using convertToContainingView.

Tests: platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::accumulateRendererTouchEventTargetRects):

LayoutTests:

  • platform/chromium/fast/events/touch/resources: Added.
  • platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html: Added.
  • platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added.
  • platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html: Added.

TBR=​leviw@chromium.org
Review URL: ​https://codereview.chromium.org/11865013

10:57 AM Changeset in webkit [139461] by wangxianzhu@chromium.org
  • 10 edits
    4 adds in trunk

RenderLayerCompositor should let ScrollingCoordinator update main thread scrolling reasons after change of layers
​https://bugs.webkit.org/show_bug.cgi?id=105652

Reviewed by Simon Fraser.

Source/WebCore:

Let ScrollingCoordinator know the change of ViewportConstrainedNotCompositedReason in time.
By the way moved RenderLayerCompositor::FixedPositionLayerNotCompositedReason to RenderLayer::ViewportConstrainedNotCompositedReason.

Tests: compositing/layer-creation/fixed-position-in-view-dynamic.html

compositing/layer-creation/fixed-position-out-of-view-dynamic.html

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects):
(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):
(WebCore::ScrollingCoordinator::mainThreadScrollingReasonsAsText):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(WebCore::ScrollingCoordinatorMac::hasVisibleSlowRepaintViewportConstrainedObjects):

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::logThreadedScrollingMode):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::paintLayer):

  • rendering/RenderLayer.h:

(RenderLayer): Moved RenderLayerCompositor::FixedPositionLayerNotCompositedReason to here and renamed it to ViewportConstrainedNotCompositedReason.
(WebCore::RenderLayer::setViewportConstrainedNotCompositedReason):
(WebCore::RenderLayer::viewportConstrainedNotCompositedReason):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::updateBacking): Now updates ViewportConstrainedNotCompositedReason here instead of in computeCompositingRequirements before so that the reason is updated in time.
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::needsToBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::reasonForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::reportMemoryUsage):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

LayoutTests:

Tests to ensure mainThreadScrollingReasons are correctly updated after a fixed element is dynamically inserted into the DOM tree.

  • compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Added.
  • compositing/layer-creation/fixed-position-in-view-dynamic.html: Added.
  • compositing/layer-creation/fixed-position-out-of-view-dynamic-expected.txt: Added.
  • compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Added.
10:39 AM Changeset in webkit [139460] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Try CRLF to LF change in r139407 again.

  • BuildSlaveSupport/delete-stale-build-files:

(main):
(webkitBuildDirectory):

  • BuildSlaveSupport/kill-old-processes:

(main):

10:39 AM Changeset in webkit [139459] by kbr@google.com
  • 5 edits in trunk

[Chromium] WebGL typed array constructor crashes on exception
​https://bugs.webkit.org/show_bug.cgi?id=106308

Reviewed by Kentaro Hara.

Source/WebCore:

Check for empty handles (indicating exception thrown) after calls
into V8 VM.

Added new case from Khronos typed array conformance tests to
fast/canvas/webgl/array-unit-tests.html.

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):

Check for empty handles after calls into V8 VM.

LayoutTests:

Updated typed array tests to latest version from Khronos repository.

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
10:37 AM Changeset in webkit [139458] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Slightly optimize getWrapperFast()
​https://bugs.webkit.org/show_bug.cgi?id=106667

Reviewed by Adam Barth.

This patch improves an if condition in getWrapperFast(),
as commented in DOMDataStore.h.

This patch improves performance of div.firstChild from
15.1 ns to 14.0 ns (+7.8%), although I couldn't observe
performance improvement in Dromaeo/dom-traverse.

No tests. No change in behavior.

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::getWrapperFast):

10:10 AM Changeset in webkit [139457] by fmalita@chromium.org
  • 3 edits
    2 adds in trunk

[SVG] Suppress resource rebuilding for unattached and shadow elements
​https://bugs.webkit.org/show_bug.cgi?id=106664

Reviewed by Dirk Schulze.

Source/WebCore:

SVGStyledElement::buildPendingResourcesIfNeeded() can be called while cloning a subtree
(as nodes are inserted into the clone, while still detached) or when elements are inserted
into the shadow tree. Both of these cases are problematic for SVGUseElement and can trigger
indirect recursion in SVGUseElement::buildPendingResource.

Since shadow and !inDocument() nodes are of no interest to ID dependents (they cannot be
found by ID in the document), the patch short-circuits buildPendingResource() for these
cases.

Test: svg/custom/use-rebuild-resources-crash.svg

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):

LayoutTests:

  • svg/custom/use-rebuild-resources-crash-expected.txt: Added.
  • svg/custom/use-rebuild-resources-crash.svg: Added.
10:06 AM Changeset in webkit [139456] by dmazzoni@google.com
  • 9 edits in trunk

AX: Computed hierarchical level is not consistent with aria-level
​https://bugs.webkit.org/show_bug.cgi?id=106638

Reviewed by Chris Fleizach.

Source/WebCore:

Make hierarchicalLevel computation 1-based to match the aria-level spec.

Extends an existing test: platform/mac/accessibility/aria-tree.html.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::hierarchicalLevel):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

Extend aria-tree.html to check the hierarchicalLevel automatically
computed when aria-level is not provided. Make sure they're consistent.
Now, the mac disclosureLevel will be one less than the web aria-level.

  • platform/mac/accessibility/aria-tree-expected.txt:
  • platform/mac/accessibility/aria-tree.html:
  • platform/mac/accessibility/aria-treegrid-expected.txt:
  • platform/mac/accessibility/aria-treegrid.html:
9:48 AM Changeset in webkit [139455] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test Expectations update after Skia flag changes.

Unreviewed test expectations update.

These are still failing, not sure why as some of them are already in expectations.
Test lint passes.

  • platform/chromium/TestExpectations:
9:31 AM Changeset in webkit [139454] by vsevik@chromium.org
  • 41 edits
    1 add in trunk

Web Inspector: Workspace should support several projects and should not have temporary UISourceCodes.
​https://bugs.webkit.org/show_bug.cgi?id=105856

Reviewed by Pavel Feldman.

Source/WebCore:

Workspace now supports several projects with the networkProject being a main one.
Replaced temporary UISourceCodes with specific projects (debugger and liveedit).
The concept of workspace reset on navigation is now replaced with project reset concept instead.
Introduced snippets project (that is not reset on navigation).
Script mappings are now reset on GlobalObjectCleared event.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._innerSetBreakpoint):
(WebInspector.BreakpointManager.prototype._filteredBreakpointLocations):
(WebInspector.BreakpointManager.prototype.toggleAllBreakpoints):
(WebInspector.BreakpointManager.prototype.removeAllBreakpoints):
(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype._inspectedURLChanged):
(WebInspector.CSSStyleModel.prototype._resetSourceMappings):
(WebInspector.CSSStyleModelResourceBinding):
(WebInspector.CSSStyleModelResourceBinding.prototype._viaInspectorResourceURL):
(WebInspector.CSSStyleModelResourceBinding.prototype._reset):

  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype._debuggerReset):

  • inspector/front-end/DebuggerScriptMapping.js:
  • inspector/front-end/DefaultScriptMapping.js:

(WebInspector.DefaultScriptMapping):
(WebInspector.DefaultScriptMapping.prototype.addScript):
(WebInspector.DefaultScriptMapping.prototype._debuggerReset):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onGetPageResources):

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.OpenResourceDialog.show):

  • inspector/front-end/LiveEditSupport.js:

(WebInspector.LiveEditSupport):
(WebInspector.LiveEditSupport.prototype.uiSourceCodeForLiveEdit):
(WebInspector.LiveEditSupport.prototype._debuggerReset):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._mainFrameNavigated):
(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.ResourceScriptMapping.prototype._debuggerReset):

  • inspector/front-end/RevisionHistoryView.js:

(WebInspector.RevisionHistoryView):
(WebInspector.RevisionHistoryView.prototype._projectWillReset):

  • inspector/front-end/SASSSourceMapping.js:

(_bindUISourceCode):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.reset):

  • inspector/front-end/ScriptsNavigator.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._removeUISourceCodes):
(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
(WebInspector.ScriptsPanel.prototype._debuggerReset):
(WebInspector.ScriptsPanel.prototype._projectWillReset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
(WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):

  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):

  • inspector/front-end/StylesSourceMapping.js:

(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype._projectWillReset):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype.reset):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.project):

  • inspector/front-end/Workspace.js:

(WebInspector.WorkspaceController):
(WebInspector.WorkspaceController.prototype._inspectedURLChanged):
(WebInspector.Project):
(WebInspector.Project.prototype.name):
(WebInspector.Project.prototype.isServiceProject):
(WebInspector.Project.prototype._reset):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
(WebInspector.Workspace.prototype.uiSourceCodeForURI):
(WebInspector.Workspace.prototype.addProject):
(WebInspector.Workspace.prototype.project):
(WebInspector.Workspace.prototype.projects):
(WebInspector.Workspace.prototype.uiSourceCodes):
(WebInspector.Workspace.prototype.projectForUISourceCode):
(WebInspector.Workspace.prototype.requestFileContent):
(WebInspector.Workspace.prototype.setFileContent):
(WebInspector.Workspace.prototype.searchInFileContent):

  • inspector/front-end/inspector.js:
  • inspector/front-end/utilities.js:

LayoutTests:

  • http/tests/inspector-enabled/dynamic-scripts.html:
  • http/tests/inspector/compiler-script-mapping.html:
  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/dynamic-scripts.html:
  • inspector/debugger/live-edit-breakpoints-expected.txt:
  • inspector/debugger/live-edit-breakpoints.html:
  • inspector/debugger/resource-script-mapping-expected.txt:
  • inspector/debugger/resource-script-mapping.html:
  • inspector/debugger/resources/edit-me-breakpoints.js: Added.

(f):

  • inspector/debugger/script-snippet-model-expected.txt:
  • inspector/debugger/script-snippet-model.html:
  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/watch-expressions-preserve-expansion-expected.txt:
  • inspector/debugger/watch-expressions-preserve-expansion.html:
  • inspector/uisourcecode-revisions.html:
9:28 AM Changeset in webkit [139453] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Disable the unit tests timeout when running from make check
​https://bugs.webkit.org/show_bug.cgi?id=106670

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-01-11
Reviewed by Philippe Normand.

  • GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
9:09 AM Changeset in webkit [139452] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Resources] Make grid columns set configurable.
​https://bugs.webkit.org/show_bug.cgi?id=105739

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-11
Reviewed by Pavel Feldman.

Added context menu on grid header to hide/show grid columns.
Hidden columns set is persisted.

  • inspector/front-end/DataGrid.js:

Fixed show/hide behavior, introduced weight control.

  • inspector/front-end/NetworkPanel.js:

Added member to track visibility of columns in detailerd mode. Added
context menu for grid header.

9:08 AM Changeset in webkit [139451] by sudarsana.nagineni@linux.intel.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed EFL gardening.

Remove unnecessary platform expectations for now-passing test.

  • platform/efl/media/video-controls-captions-expected.txt: Removed.
8:56 AM Changeset in webkit [139450] by fmalita@chromium.org
  • 41 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining results after ​http://trac.webkit.org/changeset/139238.

  • platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
  • platform/chromium-mac-lion/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-inset-outset-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-wide-border-05-expected.png:
  • platform/chromium-mac/fast/borders/border-styles-split-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png:
  • platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-win/fast/borders/border-radius-inset-outset-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-05-expected.png:
  • platform/chromium-win/fast/borders/border-styles-split-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-win/fast/writing-mode/border-styles-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/border-styles-vertical-rl-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium/TestExpectations:
8:49 AM Changeset in webkit [139449] by rakuco@webkit.org
  • 2 edits in trunk/Tools

Yet another unreviewed fix after r139431.

  • Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in

the correct order.

8:39 AM Changeset in webkit [139448] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test Expectations update after Skia flag changes.

Unreviewed test expectations update.

Apparently, we use Skia to draw some forms on Mac and Win, causing
failures not seen on Linux.

  • platform/chromium/TestExpectations:
8:34 AM Changeset in webkit [139447] by rjkroege@chromium.org
  • 1 edit
    2 deletes in branches/chromium/1364

Merge 139339

Manually revert ​http://trac.webkit.org/changeset/136012
​https://bugs.webkit.org/show_bug.cgi?id=106580

Reviewed by Dimitri Glazkov.

Source/WebCore:

136012 broke touch-scrolling of an overflow div in an iframe. Revert manually
to work around conflicts.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

LayoutTests:

  • fast/events/touch/gesture/touch-gesture-scroll-remove-node-expected.txt: Removed.
  • fast/events/touch/gesture/touch-gesture-scroll-remove-node.html: Removed.

TBR=​rjkroege@chromium.org

7:55 AM Changeset in webkit [139446] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix the build if libxslt is not available but libxml2 is
​https://bugs.webkit.org/show_bug.cgi?id=106661

Reviewed by Simon Hausmann.

On Linux building the xml parser sources fails if the needed libxslt
dependencies are not installed but libxml2 is.

  • WebCore.pri: add libxml2 to pkg-config if not on mac.
7:41 AM Changeset in webkit [139445] by schenney@chromium.org
  • 4 edits in trunk

Source/WebKit/chromium: Removing Skia flags that have been disabling oprtimizations and other improvements.

Unreviewed build fix.

These changes have been extensively tested by the Skia team, and
WebKit test result changes will be monitored.

  • skia_webkit.gyp:

LayoutTests: Unreviewed test expectations update.

All of the tests will be rebaselined by end of day.

  • platform/chromium/TestExpectations: Mark tests affected by Skia flag changes as expected to fail.
7:35 AM Changeset in webkit [139444] by schenney@chromium.org
  • 3 edits
    2 adds in trunk

Objects can be re-added to the AXObjectCache during removal
​https://bugs.webkit.org/show_bug.cgi?id=104171

Source/WebCore:

The problem occurs when a label's corresponding element is a sibling
that precedes it in the render tree, and the corresponding element is
removed. The corresponding element's AX render object is removed, but
then recreated when accessibilityIsIgnored() invokes correspondingControl()
on the label. The corresponding renderer then has an AX render object
that survives beyond the deleted renderer, leading to invalid memory
accesses.

The solution is to rearrange the calls to delete the renderer's AX
render object only when we are sure it will no longer be required.

Reviewed by Simon Fraser.

Test: accessibility/corresponding-control-deleted-crash.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed): Move the call to remove the
renderer from the AXCache to after the renderer is removed from the
render tree. This means that the AXObject still exists during renderer
removal, as we require.

LayoutTests:

Reviewed by Simon Fraser.

New test which asserts with !m_hasAXObject in RenderObject::~RenderObject without the patch. Requires Shadow DOM enabled.

  • accessibility/corresponding-control-deleted-crash-expected.txt: Added.
  • accessibility/corresponding-control-deleted-crash.html: Added.
7:33 AM Changeset in webkit [139443] by commit-queue@webkit.org
  • 8 edits in trunk/Tools

[chromium] move some whitespace and resize related methods to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=106655

Patch by Dan Carney <​dcarney@google.com> on 2013-01-11
Reviewed by Jochen Eisinger.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebKit):
(WebTestRunner::WebTestDelegate::setClientWindowRect):
(WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
(WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
(WebTestRunner):
(WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
(WebTestRunner::TestRunner::enableAutoResizeMode):
(WebTestRunner::TestRunner::disableAutoResizeMode):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::setClientWindowRect):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

7:33 AM Changeset in webkit [139442] by vsevik@chromium.org
  • 2 edits in branches/chromium/1364/Source/WebCore/inspector/front-end

Merge 138481

Unreviewed, rolling out r137905.
​http://trac.webkit.org/changeset/137905
​https://bugs.webkit.org/show_bug.cgi?id=105765

Popover does not disappear when hovering another identifier in
sources panel. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-12-26

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._innerShow):

  • inspector/front-end/popover.css:

(.popover):

TBR=​commit-queue@webkit.org
BUG=167597
Review URL: ​https://codereview.chromium.org/11860010

7:31 AM Changeset in webkit [139441] by mario@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Update my e-mail addresses.

  • Scripts/webkitpy/common/config/committers.py:
7:03 AM Changeset in webkit [139440] by dominicc@chromium.org
  • 1 edit
    3 copies in branches/chromium/1364

Merge 139256

border-radius with box-shadow is not rendered correctly
​https://bugs.webkit.org/show_bug.cgi?id=106404

Reviewed by Hajime Morita.

Source/WebCore:

RoundedRect::isRenderable is wrong. So RoundedRect::adjustRadii
is invoked for renderable RoundedRects.

Test: fast/borders/border-radius-with-box-shadow.html

  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::isRenderable):
Have to compare topLeft's height plus bottomLeft's height with
rect's height and to compare topRight's height plus bottomRight's
height with rect's height.

LayoutTests:

  • fast/borders/border-radius-with-box-shadow-expected.txt: Added.
  • fast/borders/border-radius-with-box-shadow.html: Added.
  • platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png: Added.

TBR=​tasak@google.com

6:43 AM Changeset in webkit [139439] by sudarsana.nagineni@linux.intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip new failing tests introduced in r139330 since
ENABLE_CSS_FILTERS flag is not enabled on EFL port.

  • platform/efl/TestExpectations:
6:40 AM Changeset in webkit [139438] by rakuco@webkit.org
  • 2 edits in trunk/Tools

Another unreviewed fix after r139431.

In a way, this is also a generic bug fix, since previously isEfl()
would fail when called from run-efl-tests and we thus did not use
jhbuild to run our tests. This now resulted in us calling
"jhbuild-wrapper run" without specifying a platform.

  • Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()

to work.

6:37 AM Changeset in webkit [139437] by allan.jensen@digia.com
  • 13 edits in trunk

[Qt][WK1] Web Audio support
​https://bugs.webkit.org/show_bug.cgi?id=106651

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Convert JavaScript Uint8Array to QByteArray. This conversion is necessary to support testRunner.setAudioData().

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::isJSUint8Array):
(Bindings):
(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariant):

Source/WebKit/qt:

Expose setting to enable WebAudio at runtime.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):

  • Api/qwebsettings.h:

Tools:

Implements support for dumping audio data in DumpRenderTree.

Adds WebAudio to toggleable features in QtTestBrowser.

Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::dump):

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::reset):
(TestRunner::overridePreference):
(TestRunner::setAudioData):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner::shouldDumpAsAudio):
(TestRunner::audioData):
(TestRunner):

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::applyPrefs):
(LauncherWindow::createChrome):
(LauncherWindow::toggleWebAudio):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):
(WindowOptions):
(LauncherWindow):

  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/features.pri:
6:34 AM Changeset in webkit [139436] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Build fix for the GTK debug builds of WebKit2 after r139415.

  • WebProcess/gtk/WebGtkExtensionManager.cpp:
5:56 AM Changeset in webkit [139435] by commit-queue@webkit.org
  • 11 edits in trunk

Text Autosizing - elements much narrower than its parent autosizing clusters should be autosized separately.
​https://bugs.webkit.org/show_bug.cgi?id=105188

Patch by Anton Vayvod <​avayvod@chromium.org> on 2013-01-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Some blocks of text might be narrower than their parent clusters and should be autosized separately.
This helps with autosizing for the pages implementing the sidebars as a narrow blocks of text with wide margins and
the main content being positioned atop this margin (or vice versa).

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::isContainerAutosizingCluster):

Returns true if the container is more than 200 pixels narrower than its parent cluster's lowest common
ancestor of all the text nodes.

LayoutTests:

Checked that a narrow autosizing container becomes an autosizing cluster.
Fixed other tests that used narrow descendant blocks.

  • fast/text-autosizing/cluster-narrow-in-wide-expected.html:
  • fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html:
  • fast/text-autosizing/cluster-narrow-in-wide-ohidden.html:
  • fast/text-autosizing/cluster-narrow-in-wide.html:
  • fast/text-autosizing/cluster-with-wide-lca-expected.html:
  • fast/text-autosizing/cluster-with-wide-lca.html:
  • fast/text-autosizing/narrow-child-expected.html:
  • fast/text-autosizing/narrow-child.html:
5:28 AM Changeset in webkit [139434] by rakuco@webkit.org
  • 2 edits in trunk/Tools

Unreviewed jhbuild-related fix after r139431.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.init): Pass a string to set_option_default(), since
shlex.split() will be called on it later.

5:18 AM Changeset in webkit [139433] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed typo fixes after r139431.

  • Scripts/run-javascriptcore-tests:
4:58 AM Changeset in webkit [139432] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unused CSSSelector(QualifiedName) constructor.
<​http://webkit.org/b/106652>

Reviewed by Antti Koivisto.

  • css/CSSSelector.h:

(CSSSelector):

4:50 AM Changeset in webkit [139431] by commit-queue@webkit.org
  • 6 edits
    2 deletes in trunk/Tools

[jhbuild] Remove the "run-with-jhbuild" scripts.
​https://bugs.webkit.org/show_bug.cgi?id=106572

Patch by Raphael Kubo da Costa <​raphael.kubo.da.costa@intel.com> on 2013-01-11
Reviewed by Martin Robinson.

Both ports which use jhbuild were mostly duplicating the
`run-with-jhbuild' script in their own directories for no clear reason.

The script itself was just a thin wrapper around the `jhbuild-wrapper',
so just start using that directly and get rid of a useless middle man.

Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
instead.

  • Scripts/run-javascriptcore-tests:
  • Scripts/run-launcher:
  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary):
(buildAutotoolsProject):
(jhbuildWrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):

  • Scripts/webkitpy/common/multiprocessing_bootstrap.py:

(run):

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.init):
(EflPort._image_diff_command):

  • efl/run-with-jhbuild: Removed.
  • gtk/run-with-jhbuild: Removed.
4:43 AM Changeset in webkit [139430] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] Disable the ENABLE_LEGACY_WEB_AUDIO feature define in release builds
​https://bugs.webkit.org/show_bug.cgi?id=106577

Reviewed by Philippe Normand.

The Web Audio feature is not enabled in the release builds, so there's
no need to enable the legacy Web Audio API either.

No new tests - no new functionality.

  • GNUmakefile.features.am.in:
4:28 AM Changeset in webkit [139429] by commit-queue@webkit.org
  • 7 edits
    4 adds in trunk

Web Inspector: Option+Click on Node Expander Doesn't Work the First Time
​https://bugs.webkit.org/show_bug.cgi?id=66868

Source/WebCore:

Up to now, the TreeElement.prototype.expandRecursively() method would correctly
expand children recursively based on the provided depth, but would not wait to
perform this task until all child nodes had been populated, which means that this
would only work incrementally with one additional level of child nodes being shown
expanded in the DOM tree upon alt+clicking a given node with a deep hierarchy.

In order to fix this, this patch adds a new optional argument to the DOMAgent's
requestChildNodes() methods to provide the depth at which we want to retrieve children
of a given node. The DOMAgent provides a new .getSubtree() method that calls
requestChildNodes() with the provided depth.

Then in ElementsTreeOutline, we subclass .expandRecursively() to first call DOMAgent's
new .getSubtree() method and then call the default implementation when all nodes
have been retrieved from the backend.

Patch by Antoine Quint <Antoine Quint> on 2013-01-11
Reviewed by Pavel Feldman.

Tests: inspector-protocol/dom-request-child-nodes-depth.html

inspector/elements/expand-recursively.html

  • inspector/Inspector.json: Add the new depth parameter to DOM.requestChildNodes().
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::pushChildNodesToFrontend): Add a new optional depth parameter
which defaults to 1.
(WebCore::InspectorDOMAgent::requestChildNodes): Add a new optional depth parameter
which defaults to 1 and allows -1 as an unbound value.

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.):
(WebInspector.DOMNode.prototype.getSubtree): New method allowing to specify at what depth
we want to retrieve children of a given node from the backend.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.expandRecursively): Override default implementation
to first obtain the deepest subtree for the current node so that deep expansion happens as expected.

LayoutTests:

Adding a new protocol test that covers the new depth parameter for the
requestChildNodes method and a new front-end method that tests correct
behavior of the expandRecursively() method.

Patch by Antoine Quint <Antoine Quint> on 2013-01-11
Reviewed by Pavel Feldman.

  • inspector-protocol/dom-request-child-nodes-depth-expected.txt: Added.
  • inspector-protocol/dom-request-child-nodes-depth.html: Added.
  • inspector/elements/expand-recursively-expected.txt: Added.
  • inspector/elements/expand-recursively.html: Added.
4:26 AM Changeset in webkit [139428] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Remove support for global extensions in WebKit2 GTK+
​https://bugs.webkit.org/show_bug.cgi?id=106646

Reviewed by Xan Lopez.

We have now API to set the web extensions directory. A global web
estensions directory doesn't make sense anymore.

  • WebProcess/gtk/WebGtkExtensionManager.cpp:

(WebKit::WebGtkExtensionManager::scanModules): Only scan the given
directory for modules.
(WebKit::WebGtkExtensionManager::initialize): Load modules found
in the given directory only.

  • WebProcess/gtk/WebGtkExtensionManager.h:

(WebGtkExtensionManager): Remove appendModuleDirectories().

4:15 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
web extensions done (diff)
4:09 AM Changeset in webkit [139427] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Elements] Search in the DOM tree does not scroll horizontally
​https://bugs.webkit.org/show_bug.cgi?id=106648

Reviewed by Vsevolod Vlasov.

Scroll into view the first match in every tree element, if needed.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult):

3:59 AM Changeset in webkit [139426] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] a minor follow-up to r137262
​https://bugs.webkit.org/show_bug.cgi?id=106644

Reviewed by Pavel Feldman.

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

3:44 AM Changeset in webkit [139425] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Add ImageOnlyFailure for fast/css/font-face-unicode-range.html on win
​https://bugs.webkit.org/show_bug.cgi?id=100806

Unreviewed gardening.

  • platform/chromium/TestExpectations:
3:24 AM Changeset in webkit [139424] by tkent@chromium.org
  • 7 edits in trunk/Source/WebCore

BaseDateAndTimeInputType should not inherit from TextFieldInputType
​https://bugs.webkit.org/show_bug.cgi?id=106306

Reviewed by Hajime Morita.

Date/time input types don't need text-field features at all.

No new tests. This should not make any behavior changes except reduction
of memory usage.

  • html/BaseDateAndTimeInputType.h:

Inherit InputType instead of TextFieldInputType.
(WebCore::BaseDateAndTimeInputType::BaseDateAndTimeInputType):
(BaseDateAndTimeInputType): Update function declarations.

  • html/BaseDateAndTimeInputType.cpp:

Remove handleKeydownEvent and convertFromVisibleValue, which are for
TextFieldInputType.
(WebCore::BaseDateAndTimeInputType::shouldRespectListAttribute):
Added. This is necessary for <datalist> support. TextFieldInputType has
the same code.
(WebCore::BaseDateAndTimeInputType::valueMissing):
Added. This is necessary for validity.valueMissing. TextFieldInputType
has the same code.

  • html/BaseChooserOnlyDateAndTimeInputType.cpp:

Remove unnecessary functions which cancel TextFieldInputType behavior.

  • html/BaseChooserOnlyDateAndTimeInputType.h:

(BaseChooserOnlyDateAndTimeInputType): Remove declarations for them.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

Remove unnecessary functions which cancel TextFieldInputType behavior.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType):
Add SpinButtonOwner interface. We didn't need it because
TextFieldInputType implements it.

3:12 AM Changeset in webkit [139423] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Enable concatenating headers with same field name
​https://bugs.webkit.org/show_bug.cgi?id=106625

Reviewed by Rob Buis.

RFC 2616 specifies that headers could concatenate with comma if they have
same field name. We should enable this if the header allows multiple values.

RIM PR# 275508, internally reviewed by Joe Mason

(WebCore):
(WebCore::isAppendableHeader):
(WebCore::NetworkJob::handleNotifyHeaderReceived):

2:31 AM Changeset in webkit [139422] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add ewk_view_page_contents_get() API
​https://bugs.webkit.org/show_bug.cgi?id=106440

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2013-01-11
Reviewed by Gyuyoung Kim.

Add ewk_view_page_contents_get() API for getting contents of the current page.
Currently, it supports only MHTML type.

  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_Page_Contents_Context):
(ewkViewPageContentsCallback):
(ewk_view_page_contents_get):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(PageContentsCallback):
(TEST_F):

2:30 AM Changeset in webkit [139421] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
​https://bugs.webkit.org/show_bug.cgi?id=106447

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-01-11
Reviewed by Andreas Kling.

Files do not have HAVE(ACCESSIBILITY) guards.
This is source of potential build breakes, when macro is not enabled.

  • WebProcess/WebPage/atk/WebPageAccessibilityObject.h:
  • WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
2:11 AM Changeset in webkit [139420] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
​https://bugs.webkit.org/show_bug.cgi?id=106636

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-11
Reviewed by Adam Barth.

This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.

  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/screen-config:
  • EWSTools/start-queue.sh:
2:07 AM Changeset in webkit [139419] by jochen@chromium.org
  • 4 edits
    2 adds in trunk

Connect UserGestureIndicator for mousedown and mouseup events
​https://bugs.webkit.org/show_bug.cgi?id=105138

Reviewed by Adam Barth.

Source/WebCore:

Ports that consume user gestures to prevent certain types of pop-ups
need to be able to connect mousedown and mouseup events, otherwise, a
single mouse click will allow for opening multiple pop-ups.

Note that a mousedown is not always followed by a mouseup and vice
versa, e.g. when the mousedown results in a context menu being shown, or
something is dragged into the page.

Test: platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

  • page/EventHandler.h:

LayoutTests:

  • platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt: Added.
  • platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html: Added.
2:06 AM Changeset in webkit [139418] by commit-queue@webkit.org
  • 7 edits in trunk

Web Inspector: [Resources] "Delete" cookie deletes all cookies with matching name.
​https://bugs.webkit.org/show_bug.cgi?id=105633

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-11
Reviewed by Pavel Feldman.

Source/WebCore:

"Delete" cookie deletes all cookies with matching name,
ignoring domain and path.

  • inspector/Inspector.json: Change argument "domain" to "url"
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::deleteCookie): Use url to delte cookies.

  • inspector/InspectorPageAgent.h: Adopt new signature.
  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView.prototype._deleteCookie): Ditto.

LayoutTests:

Adopt new signatures.

  • http/tests/inspector/resource-main-cookies.php:
1:53 AM Changeset in webkit [139417] by commit-queue@webkit.org
  • 18 edits in trunk/Source

[EFL] Fix unused parameter build error
​https://bugs.webkit.org/show_bug.cgi?id=106639

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2013-01-11
Reviewed by Kentaro Hara.

Use UNUSED_PARAM macro to fix build error.

Source/WebCore:

No new tests, no behavior change.

  • platform/efl/EflScreenUtilities.cpp:

(WebCore::isUsingEcoreX):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::supportsDataListUI):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::intentMessagePorts):

  • ewk/ewk_contextmenu.cpp:

(ewk_context_menu_destroy):
(ewk_context_menu_item_select):

  • ewk/ewk_file_chooser.cpp:

(ewk_file_chooser_capture_get):

  • ewk/ewk_frame.cpp:

(ewk_frame_feed_touch_event):

  • ewk/ewk_intent.cpp:

(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):

  • ewk/ewk_intent_request.cpp:

(ewk_intent_request_ref):
(ewk_intent_request_unref):
(ewk_intent_request_intent_get):

  • ewk/ewk_security_origin.cpp:

(ewk_security_origin_web_database_usage_get):
(ewk_security_origin_web_database_quota_get):

  • ewk/ewk_settings.cpp:

(ewk_settings_shadow_dom_enable_set):

  • ewk/ewk_view.cpp:

(ewk_view_context_menu_forward_event):
(ewk_view_setting_should_display_subtitles_get):
(ewk_view_setting_should_display_captions_get):
(ewk_view_setting_should_display_captions_set):
(ewk_view_setting_should_display_subtitles_set):
(ewk_view_setting_should_display_text_descriptions_get):
(ewk_view_setting_should_display_text_descriptions_set):

Source/WebKit2:

  • UIProcess/API/efl/ewk_color_picker.cpp:

(ewk_color_picker_color_set):
(ewk_color_picker_color_get):

  • UIProcess/API/efl/ewk_context.cpp:

(ewk_context_additional_plugin_path_set):

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_fullscreen_enabled_set):
(ewk_settings_fullscreen_enabled_get):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_intent_deliver):
(ewk_view_feed_touch_event):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):
(ewk_view_fullscreen_exit):

1:45 AM Changeset in webkit [139416] by pfeldman@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap
​https://bugs.webkit.org/show_bug.cgi?id=106555

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Wrong ::enable was made virtual in the InspectorDebuggerAgent.

Test: inspector/debugger/debugger-scripts-reload.html

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::enable):
(WebCore::PageDebuggerAgent::disable):

  • inspector/PageDebuggerAgent.h:

(PageDebuggerAgent):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/debugger-scripts-reload-expected.txt: Added.
  • inspector/debugger/debugger-scripts-reload.html: Added.
1:44 AM WK2-EFLTextCheckerApiTutorial edited by g.czajkowski@samsung.com
(diff)
1:39 AM WK2-EFLTextCheckerApiTutorial edited by g.czajkowski@samsung.com
apply Michal's Roj comments (diff)
12:42 AM Changeset in webkit [139415] by Carlos Garcia Campos
  • 10 edits in trunk

[GTK] Add API to set the web extensions directory to WebKit2 GTK+
​https://bugs.webkit.org/show_bug.cgi?id=106462

Reviewed by Xan Lopez.

.:

  • Source/autotools/symbols.filter: Update

WebGtkExtensionManager::initialize symbol.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_web_extensions_directory): Set
the given directory as injected bundle initialization user data.

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
  • UIProcess/API/gtk/tests/TestWebExtensions.cpp:

(beforeAll): Update the test to use
webkit_web_context_set_web_extensions_directory()
instead of setting the WEBKIT_WEB_EXTENSIONS_PATH env var.

  • WebProcess/gtk/WebGtkExtensionManager.cpp:

(WebKit::WebGtkExtensionManager::scanModules): Append the given
additional web extensions directory to the list of directories to
scan for modules.
(WebKit::WebGtkExtensionManager::initialize): Get the additional
web extensions directory from initialization user data and pass it
to scanModules().

  • WebProcess/gtk/WebGtkExtensionManager.h:

(WebGtkExtensionManager): Add userData parameter.

  • WebProcess/gtk/WebGtkInjectedBundleMain.cpp:

(WKBundleInitialize): Pass initialization user data to
WebGtkExtensionManager.

12:37 AM Changeset in webkit [139414] by vsevik@chromium.org
  • 15 edits
    1 move in trunk

Web Inspector: Refactoring, move NetworkWorkspaceProvider to NetworkUISourceCodeProvider.js and rename its parent to SimpleWorkspaceProvider.
​https://bugs.webkit.org/show_bug.cgi?id=106635

Reviewed by Pavel Feldman.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping):

  • inspector/front-end/DefaultScriptMapping.js:

(WebInspector.DefaultScriptMapping):
(WebInspector.DefaultScriptMapping.prototype.addScript):
(WebInspector.DebuggerWorkspaceProvider):
(WebInspector.DebuggerWorkspaceProvider.prototype.addDebuggerFile):

  • inspector/front-end/LiveEditSupport.js:

(WebInspector.LiveEditSupport):
(WebInspector.LiveEditSupport.prototype.uiSourceCodeForLiveEdit):
(WebInspector.LiveEditWorkspaceProvider):
(WebInspector.LiveEditWorkspaceProvider.prototype.addLiveEditFile):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkWorkspaceProvider):
(WebInspector.NetworkWorkspaceProvider.prototype.addNetworkFile):

  • inspector/front-end/SimpleWorkspaceProvider.js: Renamed from Source/WebCore/inspector/front-end/NetworkWorkspaceProvider.js.

(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.requestFileContent):
(WebInspector.SimpleWorkspaceProvider.prototype.setFileContent):
(WebInspector.SimpleWorkspaceProvider.prototype.searchInFileContent):
(WebInspector.SimpleWorkspaceProvider.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.prototype.uniqueURI):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • inspector/debugger/resource-script-mapping.html:
  • inspector/debugger/scripts-panel.html:
12:33 AM Changeset in webkit [139413] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector [chromium]: toolbar border is missing on non-Mac in docked-to-bottom mode
​https://bugs.webkit.org/show_bug.cgi?id=106560

Reviewed by Vsevolod Vlasov.

  • src/js/devTools.css:

(body.dock-to-bottom.platform-mac #toolbar):

Note: See TracTimeline for information about the timeline view.