⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 13, 2013:

11:18 PM Changeset in webkit [139588] by noel.gordon@gmail.com
  • 6 edits
    2 deletes in trunk/LayoutTests

[chromium] Optimize svg/W3C-SVG-1.1/animate-elem-80-t.svg everywhere

Unreviewed w/end gardening.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/chromium/TestExpectations:
11:01 PM Changeset in webkit [139587] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark accessibility/render-counter-text.html as flaky
on EFL port since it sometimes crashes.

  • platform/efl/TestExpectations:
10:58 PM Changeset in webkit [139586] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG phases that store per-node information should store it in Node itself rather than using a secondary vector
​https://bugs.webkit.org/show_bug.cgi?id=106753

Reviewed by Geoffrey Garen.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::dump):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::forNode):
(AbstractState):

  • dfg/DFGCFGSimplificationPhase.cpp:
  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::performSubstitution):
(JSC::DFG::CSEPhase::setReplacement):
(CSEPhase):

  • dfg/DFGNode.h:

(Node):

10:33 PM Changeset in webkit [139585] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Allow users to misspell the "sheriffs" command in sheriffbot
​https://bugs.webkit.org/show_bug.cgi?id=106628

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-13
Reviewed by Steve Block.

  • Scripts/webkitpy/tool/bot/irc_command.py:
10:28 PM Changeset in webkit [139584] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking media/track/track-css-cue-lifetime.html as a flaky timeout on Debug
Chromium bots.

  • platform/chromium/TestExpectations:
10:05 PM Changeset in webkit [139583] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [Chromium] DevToolsSanityTest.TestNoScriptDuplicatesOnPanelSwitch fails
​https://bugs.webkit.org/show_bug.cgi?id=106755

Reviewed by Alexander Pavlov.

  • src/js/Tests.js:

(.TestSuite.prototype.nonAnonymousUISourceCodes_.filterOutService):
(.TestSuite.prototype.nonAnonymousUISourceCodes_):

8:42 PM Changeset in webkit [139582] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add a public function WebPage::isLoading()
​https://bugs.webkit.org/show_bug.cgi?id=106751

PR 274392

Patch by Xiaobo Wang <​xbwang@torchmobile.com.cn> on 2013-01-13
Reviewed by George Staikos.

Need to get the load state in WebPageClient when resolving PR 274392.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::isLoading):
(WebKit):

  • Api/WebPage.h:
8:23 PM Changeset in webkit [139581] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Unreviewed build fix after r139541
​https://bugs.webkit.org/show_bug.cgi?id=106749

undefined reference to `JSC::JSCell::methodTable() const'

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2013-01-13

  • ewk/ewk_js.cpp:
  • ewk/ewk_view.cpp:
7:32 PM Changeset in webkit [139580] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Make "gardeners" an alias for "sheriffs" in sherrifbot
​https://bugs.webkit.org/show_bug.cgi?id=106627

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-13
Reviewed by Eric Seidel.

  • Scripts/webkitpy/tool/bot/irc_command.py:
6:22 PM Changeset in webkit [139579] by dpranke@chromium.org
  • 2 edits in trunk/Tools

[chromium] webkitpy-test: executive.py stringify_args error on the release test bot
​https://bugs.webkit.org/show_bug.cgi?id=105380

Reviewed by Eric Seidel.

Fix a regression introduced in r137692 where we were double-encoding
the arguments to popen(); this was only an issue on windows, where
we would try to encode something to mbcs, then try to encode it
to unicode as if the input as ascii.

  • Scripts/webkitpy/common/system/executive.py:

(Executive.run_command):

6:18 PM Changeset in webkit [139578] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

State who told sheriffbot to roll the Chromium deps and to what revision
​https://bugs.webkit.org/show_bug.cgi?id=106626

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-13
Reviewed by Eric Seidel.

Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(RollChromiumDEPS._expand_irc_nickname):
(RollChromiumDEPS.execute):

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_roll_chromium_deps):

  • Scripts/webkitpy/tool/bot/sheriff.py:

(Sheriff.post_chromium_deps_roll):

  • Scripts/webkitpy/tool/commands/roll.py:

(RollChromiumDEPS._prepare_state):
(PostChromiumDEPSRoll):
(PostChromiumDEPSRoll._prepare_state):

  • Scripts/webkitpy/tool/commands/roll_unittest.py:

(PostRollCommandsTest.test_prepare_state):

  • Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:

(PrepareChangeLogForDEPSRoll.run):

4:57 PM Changeset in webkit [139577] by kerz@chromium.org
  • 6 edits
    1 copy in branches/chromium/1364

Merge 139282

Make caret repainting container-aware
​https://bugs.webkit.org/show_bug.cgi?id=103955

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-01-09
Reviewed by Simon Fraser.

Source/WebCore:

Only invalidate local rects on the caret's repaint container,
instead of invalidating an absolute rect on the whole view.

Test: fast/repaint/caret-with-transformation.html

  • editing/FrameSelection.cpp:

(WebCore::caretRendersInsideNode):
(WebCore::caretRenderer):
(WebCore::FrameSelection::caretRenderer):
(WebCore::DragCaretController::caretRenderer):
(WebCore::repaintCaretForLocalRect):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::CaretBase::invalidateCaretRect):
(WebCore::FrameSelection::focusedOrActiveStateChanged):

  • editing/FrameSelection.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::repaintSelection):

  • rendering/RenderView.h:

LayoutTests:

The caret repaint padding has been removed. Needs rebaseline.
Added test that carets should be repainted correctly on a transformed element.

  • fast/repaint/caret-with-transformation.html: Added.
  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11886010

4:52 PM Changeset in webkit [139576] by kerz@chromium.org
  • 3 edits
    2 copies in branches/chromium/1364

Merge 138902

MediaControls::show() should make controls opaque
​https://bugs.webkit.org/show_bug.cgi?id=106034

Patch by Min Qin <​qinmin@chromium.org> on 2013-01-05
Reviewed by Eric Carlson.

Source/WebCore:

When a video enters fullscreen, webkit starts a timer to make the control transparent when the timer expires.
If the user exits fullscreen while the timer expires, webkit will call mediaControls::show().
However, show() actually displays nothing as the control is transparent.
The user had to move his mouse outside the video rect and move it back in order to show the controls.
Simply clicking/moving the mouse inside the video rect will not make the control opaque.
Test: media/video-controls-visible-exiting-fullscreen.html

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::show):

LayoutTests:

Add tests to check that video controls are shown when exiting from fullscreen.

  • media/video-controls-visible-exiting-fullscreen-expected.txt: Added.
  • media/video-controls-visible-exiting-fullscreen.html: Added.

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11875012

4:29 PM Changeset in webkit [139575] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add Alan Cutter as contributor
​https://bugs.webkit.org/show_bug.cgi?id=106747

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-13
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/config/committers.py:
4:16 PM Changeset in webkit [139574] by noel.gordon@gmail.com
  • 2 edits
    3 copies
    2 adds in trunk/LayoutTests

[chromium] Optimize svg/W3C-SVG-1.1/animate-elem-80-t.svg on linux and win

Unreviewed w/end gardening.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
1:48 PM Changeset in webkit [139573] by leviw@chromium.org
  • 7 edits
    2 deletes in trunk

Source/WebCore: Unreviewed gardening. Rolling out r139537. It broke platforms without sub-pixel layout.

  • dom/Element.cpp:

(WebCore::Element::offsetWidth):
(WebCore::Element::offsetHeight):
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):

  • rendering/RenderObject.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):

  • rendering/style/RenderStyle.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):

LayoutTests: Unreviewed gardening. Rolling out 139537. It broke platforms not using sub-
pixel layout.

  • fast/images/zoomed-offset-size.html: Removed.
  • fast/images/zoomed-offset-size-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/qt/TestExpectations
1:00 PM Changeset in webkit [139572] by Lucas Forschler
  • 4 edits in branches/safari-536.28-branch/Source

Versioning.

12:54 PM Changeset in webkit [139571] by Lucas Forschler
  • 1 copy in tags/Safari-536.28.9

New Tag.

9:18 AM Changeset in webkit [139570] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Fix CONFIG missing link_pkgconfig on Windows
​https://bugs.webkit.org/show_bug.cgi?id=106647

Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
properly on Windows because they are added to PKGCONFIG but
CONFIG does not contain link_pkgconfig.

This is because link_pkgconfig is added in unix/default_pre.prf
which is only used for UNIX platforms. To fix this, move it to
the general default_pre.prf.

Patch by Jonathan Liu <​net147@gmail.com> on 2013-01-13
Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/default_pre.prf:
  • qmake/mkspecs/features/unix/default_pre.prf:
7:24 AM Changeset in webkit [139569] by noel.gordon@gmail.com
  • 3 edits in trunk/LayoutTests

[chromium] Rebaseline svg/W3C-SVG-1.1/animate-elem-80-t.svg on linux

Unreviewed w/end gardening.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium/TestExpectations:
6:39 AM Changeset in webkit [139568] by noel.gordon@gmail.com
  • 3 edits in trunk/LayoutTests

[chromium] Rebaseline svg/W3C-SVG-1.1/animate-elem-80-t.svg on win

Unreviewed w/end gardening.

  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
5:13 AM Changeset in webkit [139567] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark 2 tests as failing on EFL port due to a regression in
r139537. Those tests started failing on GTK and Qt as well.

  • platform/efl/TestExpectations:
4:56 AM Changeset in webkit [139566] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark accessibility/heading-level.html as failing on EFL port.
This test was added in r139534.

  • platform/efl-wk2/TestExpectations:
4:49 AM Changeset in webkit [139565] by Christophe Dumez
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Add platform-specific baseline for fast/dom/HTMLTemplateElement/inertContents.html.
Our port and WKTR do not display the failing URL if it is null.

  • platform/efl/fast/dom/HTMLTemplateElement/inertContents-expected.txt: Added.
4:39 AM Changeset in webkit [139564] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark inspector/debugger/debugger-script-preprocessor.html as
flakey on EFL port since it gives a different output for
every run. This test was added in r139405.

  • platform/efl/TestExpectations:
4:27 AM Changeset in webkit [139563] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark media/video-controls-captions.html as failing on EFL port
due to additional checks added in r139547.

  • platform/efl/TestExpectations:
4:25 AM Changeset in webkit [139562] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Styling disappears from the cue that's being styled by ::cue pseudo element
​https://bugs.webkit.org/show_bug.cgi?id=106723

Patch by Dima Gorbik <​dgorbik@apple.com> on 2013-01-13
Reviewed by Antti Koivisto.

Source/WebCore:

Fixes a regression caused by r138966. Setting a pseudoId in TextTrackCue::updateDisplayTree for m_allDocumentNodes
was triggering recalculating styles the next run loop. Now when this was removed we append the WebVTT tree after its children have
been marked by markFutureAndPastNodes so that correct styles are set within this append call.

Test: media/track/track-css-cue-lifetime.html

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::markFutureAndPastNodes): changing the type of the first argument because DocumentFragment is not a subclass
of Element.
(WebCore::TextTrackCue::updateDisplayTree): appending the WebVTT rendering tree after its children have been marked properly.

  • html/track/TextTrackCue.h:

(TextTrackCue):

LayoutTests:

  • media/track/captions-webvtt/styling-lifetime.vtt: Added.
  • media/track/track-css-cue-lifetime-expected.txt: Added.
  • media/track/track-css-cue-lifetime.html: Added.
1:46 AM Changeset in webkit [139561] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, skip new failing tests to paint the bots green.

  • platform/qt/TestExpectations:

Jan 12, 2013:

11:59 PM Changeset in webkit [139560] by thakis@chromium.org
  • 5 edits in trunk/Tools

nrwt/chromium: Don't prefer chromium over webkit build directories
​https://bugs.webkit.org/show_bug.cgi?id=105597

Reviewed by Dirk Pranke.

Rely on the new timestamp logic instead. Requested by dpranke in
​https://bugs.webkit.org/show_bug.cgi?id=105498

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._static_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_build_path):

8:30 PM Changeset in webkit [139559] by thakis@chromium.org
  • 3 edits in trunk/Tools

Use ninja by default on Linux for build-webkit --chromium, bot edition
​https://bugs.webkit.org/show_bug.cgi?id=104434

Reviewed by Eric Seidel.

r139557 changed update-webkit to pick ninja by default on linux, but
the bots run update-webkit-chromium directly so they didn't see this.
Move the default for ninja into update-webkit-chromium so that it's
picked up by the bots, and let update-webkit forward non-default
options to there.

This way, the default is in one place only and both developers (who
usually use update-webkit which then shells out to
updat-webkit-chromium) and bots (which use update-webkit-chromium
directly) see the same behavior.

  • Scripts/update-webkit:
  • Scripts/update-webkit-chromium:
6:43 PM Changeset in webkit [139558] by timothy_horton@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed build fix.

  • API/JSBlockAdaptor.mm:
  • API/JSContext.mm:
  • API/JSValue.mm:
6:08 PM Changeset in webkit [139557] by thakis@chromium.org
  • 2 edits in trunk/Tools

Make ninja the default build system on Linux for build-webkit --chromium
​https://bugs.webkit.org/show_bug.cgi?id=104434

Reviewed by Eric Seidel.

  • Scripts/update-webkit:
5:44 PM Changeset in webkit [139556] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Provide LevelDB with IDBEnv instead of Env::Default
​https://bugs.webkit.org/show_bug.cgi?id=106135

Reviewed by Tony Chang.

IDBEnv only changes the name of the histogram where errors are logged.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::destroy):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::openInMemory):

5:19 PM Changeset in webkit [139555] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Roll chromium DEPS to 176595.
​https://bugs.webkit.org/show_bug.cgi?id=106730

  • DEPS:
1:20 PM Changeset in webkit [139554] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking fast/images/zoomed-offset-size.html as slow on Debug Chromium bots.

  • platform/chromium/TestExpectations:
12:23 PM Changeset in webkit [139553] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

Use sync_add_and_fetch instead of gnu_cxx::exchange_and_add
​https://bugs.webkit.org/show_bug.cgi?id=106729

After r139514 we need atomicIncrement(int64_t volatile*) for all platform. Now the
GCC implementation of atomicIncrement() is based on gnu_cxx::exchange_and_add,
which doesn't support int64_t type, but sync_add_and_fetch does.

Reviewed by Benjamin Poulain.

  • wtf/Atomics.h:

(WTF::atomicIncrement):
(WTF::atomicDecrement):

12:16 PM Changeset in webkit [139552] by commit-queue@webkit.org
  • 4 edits
    1 copy in trunk/Tools

Migrate the remaining bots in EC2 to Google Compute Engine
​https://bugs.webkit.org/show_bug.cgi?id=106005

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-12
Reviewed by Eric Seidel.

Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.

  • EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
  • EWSTools/boot.sh:
  • EWSTools/build-repo.sh:
  • EWSTools/start-queue.sh:
10:05 AM Changeset in webkit [139551] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

Regression(r119759): Heap-use-after-free in webkit_glue::WebURLLoaderImpl::Context::OnReceivedResponse
​https://bugs.webkit.org/show_bug.cgi?id=103563

A subresource could receive a body on a 404 if its call to CachedResource::error() resulted in a nested message loop.
That caused a crash when data was received, as the Subresource was in the Finished state already. Now when receiving
data we ignore these bodies, avoiding the crash.

Reviewed by Nate Chapin.

No new tests in WebKit, since it required a nested message loop which isn't present in chromium DumpRender tree.
There's a Chrome side browser test, see ​https://codereview.chromium.org/11778083/

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):

6:53 AM Changeset in webkit [139550] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.11.4

Tagging the WebKitGTK+ 1.11.4 release

5:57 AM Changeset in webkit [139549] by jochen@chromium.org
  • 8 edits in trunk/Tools

[chromium] move inspector related methods to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=106654

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestRunner::WebTestDelegate::showDevTools):
(WebTestRunner::WebTestDelegate::closeDevTools):
(WebTestRunner::WebTestDelegate::evaluateInWebInspector):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::showWebInspector):
(WebTestRunner):
(WebTestRunner::TestRunner::closeWebInspector):
(WebTestRunner::TestRunner::evaluateInWebInspector):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::showDevTools):
(WebViewHost::closeDevTools):
(WebViewHost::evaluateInWebInspector):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

4:59 AM Changeset in webkit [139548] by robert@webkit.org
  • 3 edits
    4 adds in trunk

Available height should respect min and max height
​https://bugs.webkit.org/show_bug.cgi?id=106479

Source/WebCore:

Reviewed by Ojan Vafai.

When calculating a relative positioned block's offset as a percentage of its container, respect the min
and max height set on the container

Tests: fast/block/percent-top-respects-max-height.html

fast/block/percent-top-respects-min-height.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalHeight):

LayoutTests:

Reviewed by Ojan Vafai.

  • fast/block/percent-top-respects-max-height-expected.txt: Added.
  • fast/block/percent-top-respects-max-height.html: Added.
  • fast/block/percent-top-respects-min-height-expected.txt: Added.
  • fast/block/percent-top-respects-min-height.html: Added.
4:04 AM Changeset in webkit [139547] by victor@rosedu.org
  • 6 edits in trunk

CC Button doesn't always show up
​https://bugs.webkit.org/show_bug.cgi?id=106653

Reviewed by Eric Carlson.

Source/WebCore:

Added extra checks to existing test.

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::closedCaptionTracksChanged):
Enforced visibility of captions button whenever the track list changes.
(WebCore):

  • html/shadow/MediaControls.h:

(MediaControls):

LayoutTests:

  • media/video-controls-captions-expected.txt: Updated.
  • media/video-controls-captions.html: Added extra checks that fail

without the code changes.

1:33 AM Changeset in webkit [139546] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed 64 bit buildfix after r139496.

  • dfg/DFGOperations.cpp:
Note: See TracTimeline for information about the timeline view.