Timeline
Jan 16, 2013:
- 11:35 PM Changeset in webkit [139969] by
-
- 4 edits in trunk/Tools
sheriffbot can't tell me who "kov" is
https://bugs.webkit.org/show_bug.cgi?id=106184
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-16
Reviewed by Eric Seidel.
Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
- Scripts/webkitpy/common/config/committers.py:
(Account.matches_glob):
(CommitterList.contributors_by_search_string):
- Scripts/webkitpy/common/config/committers_unittest.py:
(CommittersTest.test_committer_lookup):
- Scripts/webkitpy/tool/bot/irc_command.py:
(Whois):
- 11:35 PM Changeset in webkit [139968] by
-
- 2 edits in trunk/Source/WebKit2
Update sandbox rules after r128003
https://bugs.webkit.org/show_bug.cgi?id=106840
Reviewed by Darin Adler.
- WebProcess/com.apple.WebProcess.sb.in: Additional Lion only fixes.
- 11:23 PM Changeset in webkit [139967] by
-
- 10 edits in trunk/Source/WebCore
Update GraphicsContext to support winding rule in clip operator for Core Graphics
https://bugs.webkit.org/show_bug.cgi?id=106871
Patch by Rik Cabanier <cabanier@adobe.com> on 2013-01-16
Reviewed by Dirk Schulze.
Changed the interface to GraphicsContext so it's possible to pass the winding
rule to canvasClip() and clip().
No new tests, no change in functionality.
- WebCore.exp.in: Change signature of canvasClip function.
- platform/graphics/GraphicsContext.h: Change canvasClip and clip signature with default winding rule.
- platform/graphics/cairo/GraphicsContextCairo.cpp: Update interface with new signature so it still compiles.
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- platform/graphics/cg/GraphicsContextCG.cpp: Update interface with new signature and implement winding rules.
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- platform/graphics/openvg/GraphicsContextOpenVG.cpp: Update interface with new signature so it still compiles.
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- platform/graphics/qt/GraphicsContextQt.cpp: Update interface with new signature so it still compiles.
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- platform/graphics/skia/GraphicsContextSkia.cpp: Update interface with new signature so it still compiles.
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- platform/graphics/wince/GraphicsContextWinCE.cpp: Update interface with new signature so it still compiles.
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- platform/graphics/wx/GraphicsContextWx.cpp: Update interface with new signature so it still compiles.
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- 11:20 PM Changeset in webkit [139966] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed gardening.
Roll Chromium to 177350.
- DEPS:
- 9:31 PM Changeset in webkit [139965] by
-
- 2 edits in trunk/Tools
Use xcrun to find path to make for Mac port
<http://webkit.org/b/107091>
Reviewed by Dan Bernstein.
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._build_java_test_support): Call self.make_command().
(MacPort.make_command): Add. Call xcrun_find().
(MacPort.nm_command): Use self.xcrun_find().
(MacPort.xcrun_find): Add. Extract from nm_command().
- 9:25 PM Changeset in webkit [139964] by
-
- 3 edits2 adds in trunk
NoEventDispatchAssertion in ContainerNode::removeChildren is too strict
https://bugs.webkit.org/show_bug.cgi?id=106985
Reviewed by Ryosuke Niwa.
Source/WebCore:
This change narrowed the lifetime of NoEventDispatchAssertion in removeChildren().
It is as safe as other mutation method even after this change: childrenChanged() and
ChildNodeRemovalNotifier are used outside the assertion scope.
Test: svg/custom/use-mutation-crash.xhtml
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
LayoutTests:
- svg/custom/use-mutation-crash-expected.txt: Added.
- svg/custom/use-mutation-crash.xhtml: Added.
- 9:16 PM Changeset in webkit [139963] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix build break for Android webview.
https://bugs.webkit.org/show_bug.cgi?id=107072
Patch by Kristian Monsen <kristianm@google.com> on 2013-01-16
Reviewed by Steve Block.
Add extra guards when checking for OS=="Android" to make sure it is not included
for webview.
- WebKitUnitTests.gyp:
- 9:13 PM Changeset in webkit [139962] by
-
- 2 edits in trunk/Source/WebCore
[Refactoring] HTMLTextFormControlElement should use shadowHost instead of shadowAncestorNode
https://bugs.webkit.org/show_bug.cgi?id=106533
Reviewed by Kent Tamura.
Since Node::shadowAncestorNode() is deprecated, we would like to use Node::shadowHost().
No new tests, simple refactoring.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setSelectionRange): Here, startPosition and endPosition is in ShadowDOM,
converting shadowAncestorNode to shadowHost is safe.
(WebCore::enclosingTextFormControl): Actually ASSERT in this method is wrong since shadowAncestorNode() does not
return NULL. This should be shadowHost().
- 8:58 PM Changeset in webkit [139961] by
-
- 4 edits in trunk
Make debug-safari --target-web-process work again
https://bugs.webkit.org/show_bug.cgi?id=107088
Reviewed by Anders Carlsson.
Source/WebKit2:
--target-web-process was made harder to use during recent refactoring
by requiring users to pass a -ui-process-name parameter in addition to
the -client-executable. Instead, we should conjure up that name from
the information we already have at our disposal.
- WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMainDelegate::getConnectionIdentifier):
Simplify by making the non-client-executable path use the base
class implementation.
(WebKit::WebProcessMainDelegate::getClientIdentifier):
Ditto.
(WebKit::WebProcessMainDelegate::getClientProcessName):
Added. Create a client process name (its actually not too important what it is, as it
is only used to show a name in Activity Monitor) from the passed in client executable
path.
Tools:
- Scripts/webkitdirs.pm:
(execMacWebKitAppForDebugging):
The shim is now called SecItemShim.
- 8:52 PM Changeset in webkit [139960] by
-
- 2 edits in trunk/Source/WebKit2
Fix crashes on the bots.
The WebKit LoaderStrategy for loading synchronously was only implemented
for the case where you have a network process. When you don't, we should
be using the base implementation.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::loadResourceSynchronously):
- 8:35 PM Changeset in webkit [139959] by
-
- 4 edits in trunk/Source/WebCore
Disable an ASSERT for the threaded parser
https://bugs.webkit.org/show_bug.cgi?id=107087
Reviewed by Adam Barth.
Since tokenizing happens on the background thread, when the tree builder runs there isn't a valid tokenizer for which to check the state.
The background parser has minimal code to update its tokenizer's state properly.
No new tests because covered by existing fast/parser tests.
- html/parser/HTMLParserOptions.cpp:
(WebCore::HTMLParserOptions::HTMLParserOptions):
- html/parser/HTMLParserOptions.h:
(HTMLParserOptions):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTag):
- 8:22 PM Changeset in webkit [139958] by
-
- 5 edits2 adds in trunk
Attr.ownerDocument should change if its parent's owner did
https://bugs.webkit.org/show_bug.cgi?id=97644
Reviewed by Darin Adler.
Source/WebCore:
moveTreeToNewScope() didn't traverse its Attr instances. But it should.
Test: fast/dom/Attr/parent-adopt-node.html
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::getExistingAttrs):
(WebCore):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
LayoutTests:
- fast/dom/Attr/parent-adopt-node-expected.txt: Added.
- fast/dom/Attr/parent-adopt-node.html: Added.
- 8:00 PM Changeset in webkit [139957] by
-
- 4 edits in trunk/Tools
GCE build scripts don't take working directory into account when calling findzone.sh
https://bugs.webkit.org/show_bug.cgi?id=106962
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-16
Reviewed by Adam Barth.
- EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
- EWSTools/GoogleComputeEngine/build-commit-queue.sh:
- EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
- 7:59 PM Changeset in webkit [139956] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed gardening.
Roll Chromium to 177310.
- DEPS:
- 7:52 PM Changeset in webkit [139955] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Need to adjust the scale and scroll position after leaving fullscreen mode if there's
device rotation in fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=107085
Reviewed by George STaikos.
Also internally reviewed by Jacky Jiang.
We saved the scale and scroll position before entering full screen mode, so that we can restore
them after leaving fullscreen mode, because entering fullscreen mode automatically changes the
scale to make the video to fit to the viewport. But if there's device rotation during the fullscreen,
the scale and scroll position saved before may or may not apply anymore, we need to adjust the
scale and/or scroll position if needed to make sure no over-scale or over-scroll in the new orientation.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
- Api/WebPage_p.h:
(WebPagePrivate):
- 7:42 PM Changeset in webkit [139954] by
-
- 2 edits in trunk/Source/WebCore
Address tonyg's feedback on BackgroundHTMLParser
https://bugs.webkit.org/show_bug.cgi?id=107086
Reviewed by Tony Gentilcore.
As requested in https://bugs.webkit.org/show_bug.cgi?id=107083#c5
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(TokenDelivery):
(WebCore::TokenDelivery::TokenDelivery):
(WebCore::TokenDelivery::execute):
- 7:36 PM Changeset in webkit [139953] by
-
- 5 edits in trunk/Source/WebCore
Introduce a method to build the tree from a CompactHTMLToken
https://bugs.webkit.org/show_bug.cgi?id=107082
Reviewed by Adam Barth.
No new tests because covered by existing fast/parser tests.
- html/parser/HTMLDocumentParser.cpp:
(WebCore):
(WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLToken.h:
(AtomicHTMLToken):
(WebCore::AtomicHTMLToken::create):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(AtomicMarkupTokenBase):
- 7:25 PM Changeset in webkit [139952] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix following r139918.
Add speech synthesis to include path and WebCore vcproj file.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- 7:08 PM Changeset in webkit [139951] by
-
- 2 edits in trunk/Source/WebCore
Switch AudioDestinationChromium over to new createAudioDevice() method
https://bugs.webkit.org/show_bug.cgi?id=106816
Reviewed by James Robinson.
- platform/audio/chromium/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
- 6:55 PM Changeset in webkit [139950] by
-
- 9 edits2 adds in trunk/Source/WebCore
Introduce BackgroundHTMLParser for parsing HTML on a background thread
https://bugs.webkit.org/show_bug.cgi?id=107083
Reviewed by Eric Seidel.
This patch contains a basic version of an HTML parser that runs on a
background thread. The parser passes the majority of the tests in
fast/parser and a large number of the subtests in html5lib.
Notably absent from this early version of the parser is speculation
(which will eventually replace preload scanning) and atomization (which
we suspect will be important for performance). Our plan is to introduce
those elements in subsequent patches.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/BackgroundHTMLParser.cpp: Added.
(WebCore):
(WebCore::checkThatTokensAreSafeToSendToAnotherThread):
(WebCore::parserMap):
(WebCore::ParserMap::backgroundParsers):
(WebCore::ParserMap::mainThreadParsers):
(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::append):
(WebCore::BackgroundHTMLParser::continueParsing):
(WebCore::BackgroundHTMLParser::finish):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(TokenDelivery):
(WebCore::TokenDelivery::execute):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
(WebCore::BackgroundHTMLParser::createPartial):
(WebCore::BackgroundHTMLParser::stopPartial):
(WebCore::BackgroundHTMLParser::appendPartial):
(WebCore::BackgroundHTMLParser::continuePartial):
(WebCore::BackgroundHTMLParser::finishPartial):
- html/parser/BackgroundHTMLParser.h: Added.
(WebCore):
(BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::create):
(ParserMap):
(WebCore::ParserMap::identifierForParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore):
(WebCore::HTMLDocumentParser::didReceiveTokensFromBackgroundParser):
- html/parser/HTMLDocumentParser.h:
(WebCore):
(HTMLDocumentParser):
- 6:32 PM Changeset in webkit [139949] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG 32_64 backend doesn't check for hasArrayStorage() in NewArrayWithSize
https://bugs.webkit.org/show_bug.cgi?id=107081
Reviewed by Michael Saboff.
This bug led to the 32_64 backend emitting contiguous allocation code to allocate
ArrayStorage arrays. This then led to all manner of heap corruption, since
subsequent array accesses would be accessing the contiguous array "as if" it was
an arraystorage array.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 6:26 PM Changeset in webkit [139948] by
-
- 2 edits in trunk/Source/WebKit2
Update Owners file.
- Owners:
- 6:25 PM Changeset in webkit [139947] by
-
- 4 edits in trunk/Source/WebKit2
Remove unused AddLoadInProgress message
https://bugs.webkit.org/show_bug.cgi?id=107077
Reviewed by Dan Bernstein.
Dead code is dead.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- 6:20 PM Changeset in webkit [139946] by
-
- 2 edits in trunk/Source/WebCore
[soup] Fix build warning in ResourceHandleSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=107063
Patch by Donghyun Kim <dhkim715@hotmail.com> on 2013-01-16
Reviewed by Martin Robinson.
The restartedCallback has unused parameter 'message',
remove the parameter name to fix 'unused parameter' build warning.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::restartedCallback):
- 6:18 PM Changeset in webkit [139945] by
-
- 8 edits2 adds in trunk/Source/WebCore
Introduce a CompactHTMLToken for the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=107069
Reviewed by Adam Barth.
This class is used for transporting tokens from the parser thread to the main thread where they are fed to the tree builder.
No new tests because covered by existing fast/parser tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/CompactHTMLToken.cpp: Added.
(WebCore):
(WebCore::CompactHTMLToken::CompactHTMLToken):
(WebCore::isStringSafeToSendToAnotherThread):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):
- html/parser/CompactHTMLToken.h: Added.
(WebCore):
(CompactAttribute):
(WebCore::CompactAttribute::CompactAttribute):
(WebCore::CompactAttribute::name):
(WebCore::CompactAttribute::value):
(CompactHTMLToken):
(WebCore::CompactHTMLToken::type):
(WebCore::CompactHTMLToken::data):
(WebCore::CompactHTMLToken::selfClosing):
(WebCore::CompactHTMLToken::attributes):
(WebCore::CompactHTMLToken::publicIdentifier):
(WebCore::CompactHTMLToken::systemIdentifier):
- xml/parser/MarkupTokenBase.h:
(WebCore::MarkupTokenBase::data):
(MarkupTokenBase):
- 6:05 PM Changeset in webkit [139944] by
-
- 7 edits2 adds in trunk/Source/WebCore
Introduce HTMLParserThread to be able to parse on a background thread
https://bugs.webkit.org/show_bug.cgi?id=107071
Reviewed by Tony Gentilcore.
This patch introduces a simple thread class that we can use to parse
HTML. This patch is unlikely to be the final design because we'll
likely want to use libdispatch or some other platform-specific thread
pool. However, this implementation is enough to let us work on the
parser-specific aspects of this feature.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/HTMLParserThread.cpp: Added.
(WebCore):
(WebCore::HTMLParserThread::HTMLParserThread):
(WebCore::HTMLParserThread::~HTMLParserThread):
(WebCore::HTMLParserThread::start):
(WebCore::HTMLParserThread::stop):
(WebCore::HTMLParserThread::shared):
(WebCore::HTMLParserThread::postTask):
(WebCore::HTMLParserThread::threadStart):
(WebCore::HTMLParserThread::runLoop):
- html/parser/HTMLParserThread.h: Added.
(WebCore):
(HTMLParserThread):
(WebCore::HTMLParserThread::create):
(WebCore::HTMLParserThread::threadId):
- 5:57 PM Changeset in webkit [139943] by
-
- 2 edits in trunk/Source/WebKit2
Fix crash when destroying a plug-in with pending URL requests
https://bugs.webkit.org/show_bug.cgi?id=107075
<rdar://problem/12513871>
Reviewed by Sam Weinig.
In PluginView::destroyPluginAndReset, make sure to cancel any outstanding URL requests since the PluginView
object will stay around and would otherwise start loading URLs from stopped plug-ins.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::Stream::start):
Assert that the plug-in is alive.
(WebKit::PluginView::destroyPluginAndReset):
Empty out the pending URL requests vector and stop the timer.
- 5:38 PM Changeset in webkit [139942] by
-
- 2 edits in trunk/Source/WebCore
WebCore::ScriptRunner::timerFired() is reported to crash.
https://bugs.webkit.org/show_bug.cgi?id=92211
Reviewed by Darin Adler.
This is a speculative fix to address some crash reports.
Here is my rough guess.
The crash report says there is a PendingScript instance whose m_element is null.
- It happens only if the instance is created through the default constructor,
- that could happen if m_pendingAsyncScripts doesn't contains matched PendingScript in ScriptRunner::notifyScriptReady(),
- that could happen when notifyScriptReady() is called more than once.
- It turns out that the call site, ScriptElement::notifyFinished(), could be called multiple times since it doesn't remove itself from the CachedResource, which is done separately in ScriptElement::execute().
- So if notifyFinished() is called before execute(), it could happen
This change added a guard to prevent notifyFinished() from being invoked multiple times.
We should watch if these crash reports disappear.
No new tests. I couldn't create any repro for this.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::notifyFinished):
- 5:36 PM Changeset in webkit [139941] by
-
- 2 edits in trunk/Source/WebCore
Fix mac build system warnings introduced by r139866
https://bugs.webkit.org/show_bug.cgi?id=107056
Patch by Pablo Flouret <pablof@motorola.com> on 2013-01-16
Reviewed by Benjamin Poulain.
warning: no rule to process file '$(PROJECT_DIR)/css/CSSSupportsRule.h' of type sourcecode.c.h for architecture x86_64
warning: no rule to process file '$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSCSSSupportsRule.h' of type sourcecode.c.h for architecture x86_64
{JS,}CSSSupportsRule.h somehow ended up marked as sources in the XCode
project.
No new tests. Build warning fix.
- WebCore.xcodeproj/project.pbxproj:
- 5:32 PM Changeset in webkit [139940] by
-
- 3 edits in trunk/Source/WebCore
Merge RenderObjectChildList::appendChildNode and insertChildNode
https://bugs.webkit.org/show_bug.cgi?id=106392
Reviewed by Eric Seidel.
insertChildNode and appendChildNode are nearly identical methods and
we can combine them into insertChildNode and handle cases where the
renderer to insert before is null as if it was an append.
No new tests, just refactoring.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::insertChildNode):
- rendering/RenderObjectChildList.h:
(RenderObjectChildList):
(WebCore::RenderObjectChildList::appendChildNode):
Now inline and delegates to insertChildNode.
- 5:21 PM Changeset in webkit [139939] by
-
- 2 edits in trunk/Source/WebCore
Cursor stops blinking after clicking on scrollbar
https://bugs.webkit.org/show_bug.cgi?id=106470
Reviewed by Ojan Vafai.
Restore the caret blinking when doing a mouseup on a
scrollbar so scrolling a textarea doesn't cause the
caret to freeze.
No new tests, there doesn't seem to be any way to test
cursor blinking.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
- 5:18 PM Changeset in webkit [139938] by
-
- 3 edits in trunk/Source/WebCore
Teach HTMLParserOptions about Settings::threadedHTMLParser
https://bugs.webkit.org/show_bug.cgi?id=107068
Reviewed by Tony Gentilcore.
We use this option to enable the threaded HTML parser at runtime.
- html/parser/HTMLParserOptions.cpp:
(WebCore::HTMLParserOptions::HTMLParserOptions):
- html/parser/HTMLParserOptions.h:
(HTMLParserOptions):
- 5:11 PM Changeset in webkit [139937] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] PageUIClientEfl should keep in sync with WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=107060
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-01-16
Reviewed by Benjamin Poulain.
Rearrange the order of functions in PageUIClientEfl.
Rename closePage() to close().
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::close):
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::PageUIClientEfl):
(WebKit::PageUIClientEfl::close):
(WebKit::PageUIClientEfl::takeFocus):
(WebKit::PageUIClientEfl::focus):
(WebKit::PageUIClientEfl::unfocus):
(WebKit::PageUIClientEfl::getWindowFrame):
(WebKit::PageUIClientEfl::setWindowFrame):
(WebKit::PageUIClientEfl::createNewPage):
(WebKit::PageUIClientEfl::showColorPicker):
(WebKit::PageUIClientEfl::hideColorPicker):
- UIProcess/efl/PageUIClientEfl.h:
(PageUIClientEfl):
- 4:48 PM Changeset in webkit [139936] by
-
- 2 edits in trunk/Tools
start-queue.sh does not pass remaining parameters correctly
https://bugs.webkit.org/show_bug.cgi?id=107054
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-16
Reviewed by Adam Barth.
start-queue.sh now passes all remaining params to the webkit-patch command.
Previously only one additional queue parameter could be sent.
- EWSTools/start-queue.sh:
- 4:45 PM Changeset in webkit [139935] by
-
- 22 edits2 copies1 add in trunk/Source
Synchronous XMLHTTPRequests need to go to the NetworkProcess.
<rdar://problem/12951765> and https://bugs.webkit.org/show_bug.cgi?id=106826
Reviewed by Sam Weinig and Alexey Proskuryakov.
Source/WebCore:
No new tests (No changes to any config that is currently tested)
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously): Consult the LoaderStrategy when strategies are
being used.
- loader/LoaderStrategy.cpp:
(WebCore::LoaderStrategy::loadResourceSynchronously): Defaults to using ResourceHandle directly.
- loader/LoaderStrategy.h:
Break out the StoredCredentials enum to a new header:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleTypes.h:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::loadResourceSynchronously): Entry point for WebCore to get
synchronous requests to the NetworkProcess.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::performSynchronousLoad): Create a SyncNetworkResourceLoader
and schedule it.
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::scheduleSyncNetworkResourceLoader):
(WebKit::NetworkResourceLoadScheduler::servePendingRequestsForHost): Serve synchronous loaders
before async loaders.
- NetworkProcess/NetworkResourceLoadScheduler.h:
A class that encapsulates a synchronous load request and the CoreIPC reply to be made once it is complete:
- NetworkProcess/SyncNetworkResourceLoader.cpp: Added.
(WebKit::SyncNetworkResourceLoader::SyncNetworkResourceLoader):
(WebKit::SyncNetworkResourceLoader::start):
- NetworkProcess/SyncNetworkResourceLoader.h: Copied from Source/WebKit2/NetworkProcess/HostRecord.h.
(WebKit::SyncNetworkResourceLoader::create):
(WebKit::SyncNetworkResourceLoader::setIdentifier):
(WebKit::SyncNetworkResourceLoader::identifier):
(WebKit::SyncNetworkResourceLoader::loadParameters):
Add a second queue of sync loaders:
- NetworkProcess/HostRecord.h:
(WebKit::HostRecord::syncLoadersPending):
Add comments to explicitly spell out the current reliance on some messages that are currently synchronous:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::willSendRequest):
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpace):
- WebKit2.xcodeproj/project.pbxproj:
- 4:37 PM Changeset in webkit [139934] by
-
- 2 edits in trunk/Source/WebCore
Explicitly set msvs_cygwin_shell to true for bison rule
https://bugs.webkit.org/show_bug.cgi?id=107058
Patch by Robert Iannucci <iannucci@chromium.org> on 2013-01-16
Reviewed by Tony Chang.
Currently, msvs_cygwin_shell is set to 1 by default. This patch
explicitly sets it on the actions which will break if msvs_cygwin_shell
were set to 0. This is in preparation for changing the default value of
msvs_cygwin_shell, which in turn is in preparation of the removal of
cygwin as a buld-system requirement.
Since this change will have no semantic effect, no new tests are
required.
A previous instance of this bug is here:
https://bugs.webkit.org/show_bug.cgi?id=106706
- WebCore.gyp/WebCore.gyp:
- 4:05 PM Changeset in webkit [139933] by
-
- 2 edits in trunk/Source/WebCore
Fix the warning for the exported Objective-C binding of DOMCSSSupportsRule
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-01-16
Rubber-stamped by Simon Fraser.
- WebCore.exp.in: r139866 exported the Objective-C class DOMCSSSupportsRule
without #ifdefing the symbol between its feature flag.
- 3:57 PM Changeset in webkit [139932] by
-
- 4 edits2 adds in trunk
Cues not rendered when they should be
https://bugs.webkit.org/show_bug.cgi?id=106943
Patch by Victor Carbune <vcarbune@chromium.org> on 2013-01-16
Reviewed by Eric Carlson.
Source/WebCore:
Forced rendering update, even if the active set of cues didn't change.
Test: media/track/track-cue-rendering-mode-changed.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): If exiting early,
update the cues rendered by the text track container.
(WebCore::HTMLMediaElement::textTrackModeChanged): Trigger update of the
re-checking the active cues and render the ones not yet on screen.
LayoutTests:
- media/track/track-cue-rendering-mode-changed-expected.txt: Added.
- media/track/track-cue-rendering-mode-changed.html: Added.
- media/video-controls-captions-expected.txt: Updated.
- 3:23 PM Changeset in webkit [139931] by
-
- 3 edits in trunk/Source/WebKit2
WebProcess should not access ~/Library/Caches/com.apple.WebProcess
https://bugs.webkit.org/show_bug.cgi?id=107055
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb.in: Remove the rule allowing access.
- WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess): Use a correct cache directory even if NetworkProcess is in use. Not all loading has moved to this process yet.
- 3:15 PM Changeset in webkit [139930] by
-
- 2 edits in trunk/Source/WebCore
Force a rebuild of RenderObject
Unreviewed. One bot is using old object file. Change RenderObject.cpp to force it
to build the file again.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-01-16
- rendering/RenderObject.cpp:
(WebCore::addLayers):
(WebCore::RenderObject::findNextLayer):
- 3:11 PM Changeset in webkit [139929] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Possible null ScriptExecutionContext passed to callbacks during frame destruction
https://bugs.webkit.org/show_bug.cgi?id=107050
Reviewed by Tony Chang.
Temporary code to defend against null contexts. Will either refute a hypothesis, or we'll
need to make a more systemic fix elsewhere. Either way it will be removed in a few days.
We're unable to repro, but watching crash reports from users. One possible source is
that during page tear-down WorkerScriptController::controllerForContext() returns null
(there's a comment about that case) leading to a null context.
No new tests - this shouldn't be happening.
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
- 3:08 PM Changeset in webkit [139928] by
-
- 3 edits in trunk/Source/WebCore
Simplify validation and data copying in WebGLBuffer
https://bugs.webkit.org/show_bug.cgi?id=106975
Reviewed by Dean Jackson.
Re-landing after testing locally; was not able to reproduce the
crash seen once with the earlier patch.
No new tests; covered by existing tests. Ran WebGL layout tests and conformance tests.
- html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferDataImpl):
Take (void*, int) pair instead of ArrayBuffer and offset. Simplifies code significantly.
(WebCore::WebGLBuffer::associateBufferData):
Pass down base pointers and sizes rather than ArrayBuffer and optional offset.
(WebCore::WebGLBuffer::associateBufferSubDataImpl):
Take (void*, int) pair instead of ArrayBuffer and offset. Simplifies code significantly.
(WebCore::WebGLBuffer::associateBufferSubData):
Pass down base pointers and sizes rather than ArrayBuffer and optional offset.
- html/canvas/WebGLBuffer.h:
(WebGLBuffer):
Change signatures of associateBufferDataImpl and associateBufferSubDataImpl.
- 2:52 PM Changeset in webkit [139927] by
-
- 2 edits in trunk/Source/WebCore
Fix a crash when printing console messages to STDOUT.
https://bugs.webkit.org/show_bug.cgi?id=107039
Reviewed by Joseph Pecoraro.
- page/Console.cpp:
(WebCore::internalAddMessage): Don't release the RefPtr early. Also log the line number
and convert non-string arguments to strings when printing them.
- 2:39 PM Changeset in webkit [139926] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add missing sys/mman.h include on Mac
https://bugs.webkit.org/show_bug.cgi?id=98089
Patch by Jonathan Liu <net147@gmail.com> on 2013-01-16
Reviewed by Darin Adler.
The madvise function and MADV_FREE constant require sys/mman.h.
- jit/ExecutableAllocatorFixedVMPool.cpp:
- 2:31 PM Changeset in webkit [139925] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove bogus assert in GeolocationClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=105651
Patch by Joe Mason <jmason@rim.com> on 2013-01-16
Reviewed by Darin Adler.
GeolocationClientBlackBerry::cancelPermissionRequest contains an ASSERT that the origin is
in m_geolocationRequestMap. But it's perfectly valid for the origin to not be in the map -
for instance, if GeolocationClientBlackBerry::requestPermission returned immediately,
without putting it in the map, because geolocation was disabled. In this case the correct
thing to do is just return - there is nothing to be done to cancel the permission.
- WebCoreSupport/GeolocationClientBlackBerry.cpp:
(GeolocationClientBlackBerry::cancelPermissionRequest):
- 2:08 PM Changeset in webkit [139924] by
-
- 2 edits in trunk/Tools
check-webkit-style script cannot running in Chinese windows.
https://bugs.webkit.org/show_bug.cgi?id=87548
Patch by Xueqing Huang <huangxueqing@baidu.com> on 2013-01-16
Reviewed by Darin Adler.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo._win_version_tuple_from_cmd):
- 2:05 PM Changeset in webkit [139923] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r139914.
http://trac.webkit.org/changeset/139914
https://bugs.webkit.org/show_bug.cgi?id=106975
Caused crashes in compositing/visibility/visibility-simple-
webgl-layer.html
- html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferDataImpl):
(WebCore::WebGLBuffer::associateBufferData):
(WebCore::WebGLBuffer::associateBufferSubDataImpl):
(WebCore::WebGLBuffer::associateBufferSubData):
- html/canvas/WebGLBuffer.h:
(WebGLBuffer):
- 1:58 PM Changeset in webkit [139922] by
-
- 3 edits in trunk/Source/WebCore
Monitor usage of unprefixed and prefixed DOM events for CSS Transitions.
https://bugs.webkit.org/show_bug.cgi?id=107004
Reviewed by Adam Barth.
Monitor the usage of transitionEnd events as well as
webkitTransitionEnd events so we can know in the future how much the
prefixed version is used to remove it becomes irrelevant.
No new tests : no behavior changes, we're just adding monitoring.
- dom/EventTarget.cpp:
(WebCore):
(WebCore::EventTarget::fireEventListeners):
- page/FeatureObserver.h:
- 1:52 PM Changeset in webkit [139921] by
-
- 2 edits in trunk/Source/WTF
Use GCC's implementation of atomicIncrement/Decrement on Mac
https://bugs.webkit.org/show_bug.cgi?id=106976
Reviewed by Filip Pizlo.
- wtf/Atomics.h:
GCC and LLVM have builtin for atomic ADD and SUB: sync_add_and_fetch,
sync_sub_and_fetch.
Using them let the compiler just generate the atomic operations inline
instead of generating a function call to LibC. It also simplify the
code a bit.
- 1:50 PM Changeset in webkit [139920] by
-
- 102 edits in trunk/Source/WebCore
Tighten RenderLayerModelObject subclass constructors to operate on ContainerNodes.
https://bugs.webkit.org/show_bug.cgi?id=107041
Reviewed by Simon Fraser.
In rendering code only Nodes that are not ContainerNodes are used by RenderText. Tighter typing is better in general.
It also enables better code generation (especially with Document* moving from Node to ContainerNode).
This patch tightens constuctors for better static type checking. It also overrides node() with a covariant ContainerNode* return type
version in RenderLayerModelObject. RenderObject::createObject() is tightened to take Element*.
This patch does not change Node* usage in non-construction code (expect for the node() override).
With some further work it should be possible to tighten most of the rendering tree to operate on Elements for even less branchiness.
- dom/Document.cpp:
(WebCore::Document::attach):
- html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderThumb::RenderSliderThumb):
(WebCore::RenderSliderContainer::RenderSliderContainer):
- html/shadow/SliderThumbElement.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::RenderBox):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::RenderBoxModelObject):
- rendering/RenderBoxModelObject.h:
- rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton):
- rendering/RenderButton.h:
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
- rendering/RenderDeprecatedFlexibleBox.h:
- rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::RenderDetailsMarker):
- rendering/RenderDetailsMarker.h:
- rendering/RenderDialog.h:
(WebCore::RenderDialog::RenderDialog):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::RenderFieldset):
- rendering/RenderFieldset.h:
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
- rendering/RenderFlexibleBox.h:
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
- rendering/RenderFlowThread.h:
- rendering/RenderFullScreen.cpp:
(RenderFullScreen::RenderFullScreen):
- rendering/RenderFullScreen.h:
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::RenderGrid):
- rendering/RenderGrid.h:
- rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
- rendering/RenderImage.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
- rendering/RenderInline.h:
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::RenderLayerModelObject):
- rendering/RenderLayerModelObject.h:
(WebCore::RenderLayerModelObject::node):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::RenderListItem):
- rendering/RenderListItem.h:
- rendering/RenderMediaControlElements.cpp:
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
(WebCore::RenderTextTrackContainerElement::RenderTextTrackContainerElement):
- rendering/RenderMediaControlElements.h:
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
- rendering/RenderMultiColumnBlock.h:
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
- rendering/RenderMultiColumnFlowThread.h:
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
- rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
- rendering/RenderNamedFlowThread.h:
(RenderNamedFlowThread):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
- rendering/RenderObject.h:
(RenderObject):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
- rendering/RenderRegion.h:
(RenderRegion):
- rendering/RenderRegionSet.cpp:
(WebCore::RenderRegionSet::RenderRegionSet):
- rendering/RenderRegionSet.h:
(RenderRegionSet):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced):
- rendering/RenderReplaced.h:
(RenderReplaced):
- rendering/RenderReplica.cpp:
(WebCore::RenderReplica::RenderReplica):
(WebCore::RenderReplica::~RenderReplica):
- rendering/RenderReplica.h:
- rendering/RenderRuby.cpp:
(WebCore::RenderRubyAsInline::RenderRubyAsInline):
(WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
- rendering/RenderRuby.h:
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::RenderRubyBase):
- rendering/RenderRubyBase.h:
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::RenderRubyRun):
- rendering/RenderRubyRun.h:
(RenderRubyRun):
- rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::RenderRubyText):
- rendering/RenderRubyText.h:
(RenderRubyText):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::RenderScrollbarPart):
- rendering/RenderScrollbarPart.h:
(RenderScrollbarPart):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::RenderSearchField):
- rendering/RenderSearchField.h:
(RenderSearchField):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
- rendering/RenderTable.h:
(RenderTable):
- rendering/RenderTableCaption.cpp:
(WebCore::RenderTableCaption::RenderTableCaption):
- rendering/RenderTableCaption.h:
(RenderTableCaption):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell):
- rendering/RenderTableCell.h:
(RenderTableCell):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::RenderTableCol):
- rendering/RenderTableCol.h:
(RenderTableCol):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::RenderTableRow):
- rendering/RenderTableRow.h:
(RenderTableRow):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RenderTableSection):
- rendering/RenderTableSection.h:
(RenderTableSection):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
- rendering/RenderTextControlMultiLine.h:
(RenderTextControlMultiLine):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
- rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
- rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::RenderTextTrackCue):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
- rendering/RenderView.h:
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::RenderWidget):
- rendering/RenderWidget.h:
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
- rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLTable::RenderMathMLTable):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
- rendering/mathml/RenderMathMLOperator.h:
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::RenderMathMLRow):
- rendering/mathml/RenderMathMLRow.h:
(RenderMathMLRow):
(WebCore::RenderSVGInline::RenderSVGInline):
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGTSpan.cpp:
(WebCore::RenderSVGTSpan::RenderSVGTSpan):
- rendering/svg/RenderSVGTSpan.h:
- rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::RenderSVGTextPath):
- rendering/svg/RenderSVGTextPath.h:
- 1:47 PM Changeset in webkit [139919] by
-
- 5 edits1 delete in trunk/Source/WebKit2
Remove CoreIPCMessageKinds.h
https://bugs.webkit.org/show_bug.cgi?id=107048
Reviewed by Beth Dakin.
Use named IPC messages instead.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncReply):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::dispatchSyncMessage):
- Platform/CoreIPC/CoreIPCMessageKinds.h: Removed.
- Platform/CoreIPC/MessageID.h:
(MessageID):
(CoreIPC::MessageID::stripMostSignificantBit):
(CoreIPC::MessageID::operator==):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):
(CoreIPC::Connection::receiveSourceEventHandler):
- WebKit2.xcodeproj/project.pbxproj:
- 1:45 PM Changeset in webkit [139918] by
-
- 7 edits17 adds in trunk/Source/WebCore
Stub out WebSpeech synthesis
https://bugs.webkit.org/show_bug.cgi?id=106847
Reviewed by Adam Barth.
This adds in the necessary IDLs and stubs out the code for the WebSpeech
synthesis specification.
It does not turn on the feature in any platform, but it can be enabled
and built for Mac.
The feature flag is SPEECH_SYNTHESIS.
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- Modules/speech/DOMWindowSpeechSynthesis.cpp: Added.
(WebCore::DOMWindowSpeechSynthesis::DOMWindowSpeechSynthesis):
(WebCore::DOMWindowSpeechSynthesis::~DOMWindowSpeechSynthesis):
(WebCore::DOMWindowSpeechSynthesis::from):
(WebCore::DOMWindowSpeechSynthesis::speechSynthesis):
- Modules/speech/DOMWindowSpeechSynthesis.h: Added.
- Modules/speech/DOMWindowSpeechSynthesis.idl: Added.
- Modules/speech/SpeechSynthesis.cpp: Added.
(WebCore::SpeechSynthesis::create):
(WebCore::SpeechSynthesis::SpeechSynthesis):
- Modules/speech/SpeechSynthesis.h: Added.
(SpeechSynthesis):
(WebCore::SpeechSynthesis::getVoices):
- Modules/speech/SpeechSynthesis.idl: Added.
- Modules/speech/SpeechSynthesisEvent.cpp: Added.
(WebCore::SpeechSynthesisEvent::create):
(WebCore::SpeechSynthesisEvent::SpeechSynthesisEvent):
- Modules/speech/SpeechSynthesisEvent.h: Added.
(SpeechSynthesisEvent):
(WebCore::SpeechSynthesisEvent::charIndex):
(WebCore::SpeechSynthesisEvent::elapsedTime):
(WebCore::SpeechSynthesisEvent::name):
- Modules/speech/SpeechSynthesisEvent.idl: Added.
- Modules/speech/SpeechSynthesisUtterance.cpp: Added.
(WebCore::SpeechSynthesisUtterance::create):
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::scriptExecutionContext):
(WebCore::SpeechSynthesisUtterance::interfaceName):
- Modules/speech/SpeechSynthesisUtterance.h: Added.
(SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::voiceURI):
(WebCore::SpeechSynthesisUtterance::setVoiceURI):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
- Modules/speech/SpeechSynthesisUtterance.idl: Added.
- Modules/speech/SpeechSynthesisVoice.cpp: Added.
(WebCore::SpeechSynthesisVoice::create):
(WebCore::SpeechSynthesisVoice::SpeechSynthesisVoice):
- Modules/speech/SpeechSynthesisVoice.h: Added.
(SpeechSynthesisVoice):
(WebCore::SpeechSynthesisVoice::voiceURI):
(WebCore::SpeechSynthesisVoice::name):
(WebCore::SpeechSynthesisVoice::lang):
(WebCore::SpeechSynthesisVoice::localService):
(WebCore::SpeechSynthesisVoice::isDefault):
- Modules/speech/SpeechSynthesisVoice.idl: Added.
- Modules/speech/mac: Added.
- Modules/speech/mac/SpeechSynthesisMac.mm: Added.
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::speaking):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::speak):
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::pause):
(WebCore::SpeechSynthesis::resume):
- WebCore.xcodeproj/project.pbxproj:
- dom/EventNames.h:
- dom/EventNames.in:
- dom/EventTargetFactory.in:
- 1:33 PM Changeset in webkit [139917] by
-
- 10 edits1 delete in trunk
Unreviewed, rolling out r139853.
http://trac.webkit.org/changeset/139853
https://bugs.webkit.org/show_bug.cgi?id=107049
Broke the ChromeOS ppapi_unittests (Requested by leviw on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-16
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorInstrumentation.cpp:
(WebCore):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
- inspector/InspectorPageAgent.cpp:
- inspector/InspectorPageAgent.h:
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.PageDispatcher.prototype.frameDetached):
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::clear):
(WebCore::NavigationScheduler::timerFired):
(WebCore::NavigationScheduler::startTimer):
(WebCore::NavigationScheduler::cancel):
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
LayoutTests:
- inspector-protocol/page/frameScheduledNavigation-expected.txt: Removed.
- inspector-protocol/page/frameScheduledNavigation.html: Removed.
- inspector-protocol/page/frameStartedLoading-expected.txt: Removed.
- inspector-protocol/page/frameStartedLoading.html: Removed.
- 1:28 PM BuildingGtk edited by
- Add libwebp-dev to the list of packages to install (diff)
- 1:23 PM Changeset in webkit [139916] by
-
- 2 edits in trunk
[CMake] Report actual values for feature configuration (instead of the default)
https://bugs.webkit.org/show_bug.cgi?id=107010
Reviewed by Laszlo Gombos.
- Source/cmake/WebKitFeatures.cmake:
- 1:18 PM Changeset in webkit [139915] by
-
- 2 edits1 move2 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Adding results for platform/chromium/compositing/rounded-corners.html.
- platform/chromium-mac/platform/chromium/compositing/rounded-corners-expected.png: Added.
- platform/chromium-win/platform/chromium/compositing/rounded-corners-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/platform/chromium/compositing/rounded-corners-expected.txt: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt.
- 1:09 PM Changeset in webkit [139914] by
-
- 3 edits in trunk/Source/WebCore
Simplify validation and data copying in WebGLBuffer
https://bugs.webkit.org/show_bug.cgi?id=106975
Reviewed by Dean Jackson.
No new tests; covered by existing tests. Ran WebGL layout tests and conformance tests.
- html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferDataImpl):
Take (void*, int) pair instead of ArrayBuffer and offset. Simplifies code significantly.
(WebCore::WebGLBuffer::associateBufferData):
Pass down base pointers and sizes rather than ArrayBuffer and optional offset.
(WebCore::WebGLBuffer::associateBufferSubDataImpl):
Take (void*, int) pair instead of ArrayBuffer and offset. Simplifies code significantly.
(WebCore::WebGLBuffer::associateBufferSubData):
Pass down base pointers and sizes rather than ArrayBuffer and optional offset.
- html/canvas/WebGLBuffer.h:
(WebGLBuffer):
Change signatures of associateBufferDataImpl and associateBufferSubDataImpl.
- 12:58 PM Changeset in webkit [139913] by
-
- 2 edits in trunk/Tools
Delete an extraneous print statement.
https://bugs.webkit.org/show_bug.cgi?id=106562
Delete the extraneous print statement introduced in r139841.
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_found):
- 12:27 PM Changeset in webkit [139912] by
-
- 2 edits in trunk/Tools
Please reinstate --pixel
https://bugs.webkit.org/show_bug.cgi?id=101995
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-01-16
Reviewed by Dirk Pranke.
Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
Some developers are still used to these options that were available in the ORWT.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 12:25 PM Changeset in webkit [139911] by
-
- 10 edits2 adds in trunk
inconsistency in drawImage with target rect negative dimensions.
https://bugs.webkit.org/show_bug.cgi?id=100026
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-01-16
Reviewed by Dean Jackson.
PerformanceTests:
Create a drawImage performance test. There is no significative change
in performance: 27144.6851528 runs/s without the patch; 27153.517612
runs/s with the patch. Test is currently skipped.
- Canvas/drawimage.html: Added.
- Skipped:
Source/WebCore:
Remove -1, -1 special case in drawImage and drawImageBuffer. Replace
all -1 -1 arguments calls to with the correct rectangle dimensions.
Remove FloatRect(0, 0, -1, -1) default argument for srcRect, and
instead, add new overloaded functions to create a FloatRect from image
size.
Replace -1 -1 arguments calls in FEComposite::platformApplySoftware
with correct rectangle dimensions.
Replace ImageGStreamer rect method (which may return -1 -1 rectangle)
with cropRect method, and make caller check for rectangle emptiness.
- fast/canvas/drawImage-with-negative-source-destination-expected.txt:
- fast/canvas/drawImage-with-negative-source-destination.js:
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore):
(WebCore::GraphicsContext::drawImageBuffer):
- platform/graphics/GraphicsContext.h:
(GraphicsContext):
- platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::platformApplySoftware):
- platform/graphics/gstreamer/ImageGStreamer.h:
(WebCore::ImageGStreamer::rect):
LayoutTests:
Add a drawImage check for a destination rectangle with -1px
width/height. When drawing to (1, 1, -1, -1) rectangle, first
(top-left) pixel should have been and been the only one drawn into.
- fast/canvas/drawImage-with-negative-source-destination-expected.txt:
- fast/canvas/drawImage-with-negative-source-destination.js:
- 12:12 PM Changeset in webkit [139910] by
-
- 17 edits in tags/Safari-537.26.1/Source
Merged r139822. <rdar://problem/12843164>
- 12:04 PM Changeset in webkit [139909] by
-
- 4 edits in tags/Safari-537.26.1/Source
Versioning.
- 12:00 PM Changeset in webkit [139908] by
-
- 7 edits in trunk/Source/WebCore
Allow PaintInfo to carry all PaintBehavior flags
https://bugs.webkit.org/show_bug.cgi?id=106980
Reviewed by Sam Weinig.
PaintInfo has a single boolean for forceBlackText, but I'll be adding additional
paint behaviors that I'd like to access from PaintInfo, so it makes sense for
PaintInfo to just include the set of PaintBehavior flags.
Also add default values in the constructor arguments for rarely used parameters.
No behavior change, no tests.
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint): Use the forceBlackText() function.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Call forceBlackText().
- rendering/PaintInfo.h:
(WebCore::PaintInfo::PaintInfo): Pass PaintBehavior rather than a forceBlackText boolean.
(WebCore::PaintInfo::forceBlackText): Return true if the behavior flags contain PaintBehaviorForceBlackText.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended): Pass PaintBehaviorForceBlackText instead of 'true'
when painting for background-clip: text.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents): Pass PaintBehaviorNormal where we used to pass 'false',
and omit default 0 parameters.
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::renderSubtreeToImageBuffer): PaintBehaviorNormal and remove default params.
- 11:58 AM Changeset in webkit [139907] by
-
- 1 copy in tags/Safari-537.26.1
New Tag.
- 11:57 AM Changeset in webkit [139906] by
-
- 17 edits in tags/Safari-537.26/Source
Rollout r139905.
- 11:49 AM Changeset in webkit [139905] by
-
- 17 edits in tags/Safari-537.26/Source
Merge 139822. <rdar://problem/12843164>
- 11:48 AM Changeset in webkit [139904] by
-
- 5 edits in trunk
LinkHighlight should use touch adjustment to match active state on GestureTapDown.
https://bugs.webkit.org/show_bug.cgi?id=107032
Reviewed by Adam Barth.
Source/WebKit/chromium:
LinkHighlight node selection should produce results that match the node marked
active during GestureTapDown.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::bestTouchLinkNode):
- tests/LinkHighlightTest.cpp:
(WebCore::TEST):
LayoutTests:
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line.html:
- 11:26 AM Changeset in webkit [139903] by
-
- 2 edits in trunk/Source/WebCore
Add a missing #if to fix the Mac build sans ENABLE_CSS_FILTERS.
Rubber-stamped by Simon Fraser.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::cloneLayer):
- 11:25 AM Changeset in webkit [139902] by
-
- 4 edits in trunk
Remove --shark* support from sunspider/run-sunspider now that Shark is dead
https://bugs.webkit.org/show_bug.cgi?id=99512
Reviewed by Darin Adler.
PerformanceTests/SunSpider:
I tried to use --instruments, but that also seems broken (in the same way before/after this patch).
- sunspider:
(runTestsOnce):
Tools:
- Scripts/run-sunspider:
- 11:23 AM Changeset in webkit [139901] by
-
- 1 edit2 deletes in trunk/Tools
Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
https://bugs.webkit.org/show_bug.cgi?id=106036
Reviewed by Darin Adler.
- Scripts/webkitpy/webkitpy.pyproj: Removed.
- Scripts/webkitpy/webkitpy.sln: Removed.
- 11:21 AM Changeset in webkit [139900] by
-
- 34 edits in trunk/Source
[V8] Make a creationContext parameter of toV8() mandatory
https://bugs.webkit.org/show_bug.cgi?id=107020
Reviewed by Adam Barth.
Source/WebCore:
Currently a creationContext parameter of toV8() is optional:
Handle<Value> toV8(..., Handle<Object> creationContext = Handle<Object>(), ...) {
...;
}
On the other hand, looking at the implementation of
V8WrapperInstantiationScope:
explicit V8WrapperInstantiationScope(v8::Handle<v8::Object> creationContext)
: m_didEnterContext(false)
, m_context(v8::Context::GetCurrent())
{
if (creationContext.IsEmpty()) We do nothing for this case!
return;
v8::Handle<v8::Context> contextForWrapper = creationContext->CreationContext();
if (contextForWrapper == m_context)
return;
m_context = v8::Local<v8::Context>::New(contextForWrapper);
m_didEnterContext = true;
m_context->Enter();
}
we're assuming that a creationContext parameter is passed
to toV8() when a creationContext exists. In other words,
if we forget to pass a creationContext parameter, we will
end up with creating an object on the current context, which
is wrong. To avoid the mistake, we should make the
creationContext parameter mandatory. When we really do not
have a creationContext, we can pass Handle<Object>() explicitly.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestException.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::idbKeyToScriptValue):
- bindings/v8/ScriptController.cpp:
(WebCore::createScriptObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):
- bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::currentCallFrame):
- bindings/v8/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent):
(WebCore::V8AbstractEventListener::getReceiverObject):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::updateDocumentProperty):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::toObjectWrapper):
- bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::handleEvent):
- bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
- bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::handleEvent):
(WebCore::V8WorkerContextEventListener::getReceiverObject):
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8SQLStatementErrorCallback::handleEvent):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::nodeAsScriptValue):
- css/MediaQueryListListener.cpp:
(WebCore::MediaQueryListListener::queryChanged):
- testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::injectInternalsObject):
Source/WebKit/chromium:
We pass Handle<Object>() to a creationContext parameter of
toV8() when we do not have a creationContext.
No tests. No change in behavior.
- src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::windowObjectCleared):
- src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::toV8Value):
- src/WebBlob.cpp:
(WebKit::WebBlob::toV8Value):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createSerializableFileSystem):
(WebKit::WebFrameImpl::createFileEntry):
- 11:19 AM Changeset in webkit [139899] by
-
- 18 edits in trunk/Source
Add a Setting to disable QTKit media engine.
https://bugs.webkit.org/show_bug.cgi?id=106972
Reviewed by Eric Carlson.
Source/WebCore:
Allow the MediaPlayerPrivateQTKit engine to be disabled by adding a
runtime setting to Settings. Make the setting 'live' by requerying the
installed media engines when the setting changes.
- WebCore.exp.in: Add new symbols to export list.
- page/Settings.cpp: Add new gQTKitEnabled global.
(WebCore::Settings::setAVFoundationEnabled): Requery media engines.
(WebCore::Settings::setQTKitEnabled): Ditto. Setter for global setting variable.
- page/Settings.h:
(WebCore::Settings::isQTKitEnabled): Getter for same.
- platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Check isQTKitEnabled() before adding
MediaPlayerPrivateQTKit engine.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::requeryMediaEngines): Pass through to MediaPlayer.
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Take an optional requery options parameter.
(WebCore::MediaPlayer::requeryMediaEngines): Pass through to installedMediaEngines().
- platform/graphics/MediaPlayer.h:
Source/WebKit/mac:
Add WebKit API to set QTKit enabled setting from user defaults.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Set WebCore settings based on user defaults.
(-[WebPreferences setQTKitEnabled:]): Pass through to WebCore.
(-[WebPreferences isQTKitEnabled]): Ditto.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Synchronize WebKit/WebCore settings.
Source/WebKit2:
Add a WebKit2 API to access WebCore QTKitEnabled settings.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetQTKitEnabled): Pass through to WebCore.
(WKPreferencesGetQTKitEnabled): Ditto.
- UIProcess/API/C/WKPreferences.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Synchronize WebKit2/WebCore settings.
- 11:07 AM Changeset in webkit [139898] by
-
- 6 edits in branches/chromium/1364
Merge 138808
Existence of window.Touch can break websites mobile device detection
https://bugs.webkit.org/show_bug.cgi?id=106071
Source/WebCore:
Patch by Rick Byers <rbyers@chromium.org> on 2013-01-04
Reviewed by Ojan Vafai.
Revert http://trac.webkit.org/changeset/135562 for now while I work
on a slightly safer version.
- page/DOMWindow.idl:
LayoutTests:
Revert http://trac.webkit.org/changeset/135562 for now while I work
on a slightly safer version.
Patch by Rick Byers <rbyers@chromium.org> on 2013-01-04
Reviewed by Ojan Vafai.
- fast/events/touch/document-create-touch-list-expected.txt:
- fast/events/touch/script-tests/document-create-touch-list.js:
- platform/efl/fast/js/global-constructors-expected.txt:
- platform/qt-5.0/fast/js/global-constructors-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
TBR=rbyers@chromium.org
Review URL: https://codereview.chromium.org/11970016
- 11:04 AM Changeset in webkit [139897] by
-
- 4 edits2 copies in trunk/Source/WebKit/chromium
[Chromium] Move WebArrayBufferView and WebSerializedScriptValue out of public/platform/
https://bugs.webkit.org/show_bug.cgi?id=106863
Reviewed by Adam Barth.
These are not being moved into the new top-level Platform
directory, so into public they go.
- WebKit.gyp:
- public/WebArrayBufferView.h: Added.
(v8):
(WebKit):
(WebArrayBufferView):
(WebKit::WebArrayBufferView::~WebArrayBufferView):
(WebKit::WebArrayBufferView::WebArrayBufferView):
- public/WebSerializedScriptValue.h: Added.
(v8):
(WebKit):
(WebSerializedScriptValue):
(WebKit::WebSerializedScriptValue::~WebSerializedScriptValue):
(WebKit::WebSerializedScriptValue::WebSerializedScriptValue):
(WebKit::WebSerializedScriptValue::operator=):
(WebKit::WebSerializedScriptValue::isNull):
- public/platform/WebArrayBufferView.h:
- public/platform/WebSerializedScriptValue.h:
- 10:44 AM Changeset in webkit [139896] by
-
- 5 edits in trunk/Source/WebCore
[gstreamer] Some media tests occasionally crash with gstreamer 1.0 backend
https://bugs.webkit.org/show_bug.cgi?id=106551
Reviewed by Philippe Normand.
ImageGStreamerCairo was passing mapped memory to
cairo_image_surface_create_for_data() and then unmapping it straight
away even though the cairo_surface_t is still used. The cairo
documentation states:
"The output buffer must be kept around until the cairo_surface_t is
destroyed or cairo_surface_finish() is called on the surface."
This patch keeps the GstBuffer memory mapped until the ImageGStreamer
is destroyed so that the internal cairo_surface_t stays valid while
avoiding copying the image data.
No new tests, already covered by existing tests.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
(WTF):
(WTF::GstBuffer):
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
(WTF): Add support for using GRefPtr with GstBuffer.
- platform/graphics/gstreamer/ImageGStreamer.h:
(ImageGStreamer):
- platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer):
(ImageGStreamer::~ImageGStreamer):
- 10:37 AM Changeset in webkit [139895] by
-
- 5 edits in trunk
[Chromium] Remove hardcoded chromium_*.jar in gyp files
https://bugs.webkit.org/show_bug.cgi?id=104049
Patch by Chris Hopman <cjhopman@chromium.org> on 2013-01-16
Reviewed by Eric Seidel.
Targets with dependencies (direct/indirect) on a java target receive
the chromium_*.jar paths in the variable input_jars_paths. Targets
should use that rather than hardcoding where they think the jar will
be. These can be passed directly to ant as INPUT_JARS_PATHS rather
than as --jars to generate_native_test.py.
Source/WebKit/chromium:
- WebKitUnitTests.gyp:
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
- 10:32 AM Changeset in webkit [139894] by
-
- 2 edits in trunk/Source/WebCore
Use SkMatrix::I() when we need to pass identity, rather than constructing a new matrix.
https://bugs.webkit.org/show_bug.cgi?id=107016
Reviewed by James Robinson.
No new tests. existing tests exercise this code.
The default constructor is being deprecated, so this change is also part of that effort,
though it is a perf-improvement regardless, since we avoid making a new (temp) matrix.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
- 10:32 AM Changeset in webkit [139893] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Marking several tests as crashing on Debug builds following
r139853.
- platform/chromium/TestExpectations:
- 10:23 AM Changeset in webkit [139892] by
-
- 7 edits in trunk/LayoutTests
Unreveiwed gardening. Updating expectations following r139865.
- platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium/TestExpectations:
- 10:02 AM Changeset in webkit [139891] by
-
- 4 edits in trunk/Source/WebCore
RenderListMarker::computePreferredLogicalWidth should not be public
https://bugs.webkit.org/show_bug.cgi?id=106956
Reviewed by Tony Chang.
RenderListItem was calling computePreferredLogicalWidths for the side
effects of updating the marker content and margins. Instead, call
updateMarginsAndContent directly.
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateMarkerLocation):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
The isImage() codepath never calls computePreferredLogicalWidths, so we need to make
sure the content and margins are updated.
(WebCore::RenderListMarker::updateContent):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateMarginsAndContent):
- rendering/RenderListMarker.h:
- 10:00 AM Changeset in webkit [139890] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Safeguard against possible NULL-dereference
https://bugs.webkit.org/show_bug.cgi?id=104931
Patch by Claudio Saavedra <Claudio Saavedra> on 2013-01-16
Reviewed by Martin Robinson.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetIndexInParent): Move the NULL-safeguard to a
place where it actually makes sense.
- 9:49 AM Changeset in webkit [139889] by
-
- 2 edits in trunk/Source/WebCore
West-panning cursor does not match resize cursor, unlike all other directions
https://bugs.webkit.org/show_bug.cgi?id=89405
Patch by Avi Drissman <avi@google.com> on 2013-01-16
Reviewed by Alexey Proskuryakov.
Existing manual tests.
- platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor):
- 9:44 AM Changeset in webkit [139888] by
-
- 10 edits2 copies in trunk/Source/WebKit2
Groundwork to enable process suppression by default on Mac
https://bugs.webkit.org/show_bug.cgi?id=106513
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-01-16
Reviewed by Alexey Proskuryakov.
Process suppression has so far been controlled by a user default and
disabled by default. This patch provides the groundwork to enable it by
default and adds a private API to enable/disable it on a per-context
basis.
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::platformInitialize): Add comment about
initilization of application occlusion state.
- UIProcess/API/C/mac/WKContextPrivateMac.cpp: Added.
(WKContextGetProcessSuppressionEnabled):
(WKContextSetProcessSuppressionEnabled):
Add private API to enable/disable process suppression on a per-context
basis.
- UIProcess/API/C/mac/WKContextPrivateMac.h: Added.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didFinishLaunching): Check if owning
context has process suppression enabled before updating application
occlusion state.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didFinishLaunching): Ditto.
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching): Check if
process suppression is enabled for global child processes before
updating application occlusion state.
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:
(WebKit::SharedWorkerProcessProxy::didFinishLaunching): Ditto.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::create): Remove call to
initializeProcessSuppressionSupport, since platformInitialize has been
modified to perform initialization.
(WebKit::WebContext::WebContext): Initialize new member variable
m_processSuppressionEnabled to false.
- UIProcess/WebContext.h:
(WebKit::WebContext::processSuppressionEnabled): Remove "Support"
from the method name.
- UIProcess/mac/WebContextMac.mm:
(WebKit::updateGlobalChildProcessesApplicationOcclusionState):
(WebKit::applicationOcclusionStateChanged): Update the application
occlusion state of child processes having process suppresion enabled.
(WebKit::applicationBecameVisible):
(WebKit::applicationBecameOccluded):
Simplify by moving code to applicationOcclusionStateChanged.
(WebKit::registerOcclusionNotificationHandlers): Fix typos.
(WebKit::unregisterOcclusionNotificationHandlers): Add
method to unregister occlusion notification handlers when no context
has process suppression enabled.
(WebKit::enableOcclusionNotifications):
(WebKit::disableOcclusionNotifications):
(WebKit::enableProcessSuppressionForGlobalChildProcesses):
(WebKit::disableProcessSuppressionForGlobalChildProcesses):
(WebKit::processSuppressionIsEnabledForAnyContext):
(WebKit::processSuppressionIsEnabledForAllContexts):
(WebKit::WebContext::platformInitialize): Disable process suppression
for global child processes since process suppression is disabled for a
context on construction.
(WebKit::WebContext::setProcessSuppressionEnabled):
(WebKit::WebContext::updateChildProcessesApplicationOcclusionState):
(WebKit::WebContext::applicationIsOccluded):
(WebKit::WebContext::processSuppressionEnabledForGlobalChildProcesses):
(WebKit::WebContext::processSuppressionEnabledChanged): Update child
processes application occlusion state, enable/disable occlusion
notifications and enable/disable process suppression for global child
processes.
- WebKit2.xcodeproj/project.pbxproj:
- 8:56 AM Changeset in webkit [139887] by
-
- 5 edits in trunk
Web Inspector: array grouping does not work for float number keys
https://bugs.webkit.org/show_bug.cgi?id=106998
Reviewed by Pavel Feldman.
Source/WebCore:
Now we do the array index check according to the ECMAScript 5, section 15.4:
"A property name P (in the form of a String value) is an array index if and only if ToString(ToUint32(P)) is equal to P and ToUint32(P) is not equal to 232-1."
- inspector/front-end/ObjectPropertiesSection.js:
(.buildObjectFragment):
LayoutTests:
- inspector/console/console-big-array-expected.txt:
- inspector/console/console-big-array.html:
- 8:54 AM Changeset in webkit [139886] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Show formatted content of JSON request
https://bugs.webkit.org/show_bug.cgi?id=106900
Patch by Sergey Ryazanov <serya@chromium.org> on 2013-01-16
Reviewed by Vsevolod Vlasov.
"Request payload" section showed raw content for POST requests.
This change show it in structured format if it's JSON parsable.
Raw format is also available.
- inspector/front-end/RequestHeadersView.js:
(WebInspector.RequestHeadersView.prototype._refreshQueryString):
(WebInspector.RequestHeadersView.prototype._refreshFormData):
(WebInspector.RequestHeadersView.prototype.toggleViewSource):
(WebInspector.RequestHeadersView.prototype._refreshParams):
- 8:48 AM Changeset in webkit [139885] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: UISourceCode scriptFile / styleFile should be reset on navigation (debugger or css model reset).
https://bugs.webkit.org/show_bug.cgi?id=107008
Reviewed by Pavel Feldman.
ScriptFiles and styleFiles are now reset and disposed on UISourceCodes on corresponding models reset.
StyleSourceMapping now tries to setup mapping for newly added resource as well as for uiSourceCodes previously.
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype._mainFrameCreatedOrNavigated):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._unbindUISourceCodeFromScripts):
(WebInspector.ResourceScriptMapping.prototype._initialize):
(WebInspector.ResourceScriptMapping.prototype._debuggerReset):
(WebInspector.ResourceScriptFile.prototype.dispose):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._debuggerReset):
- inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype._resourceAdded):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.StylesSourceMapping.prototype._bindUISourceCode):
(WebInspector.StylesSourceMapping.prototype._projectWillReset):
(WebInspector.StylesSourceMapping.prototype._initialize):
(WebInspector.StylesSourceMapping.prototype._mainFrameCreatedOrNavigated):
(WebInspector.StyleFile.prototype.dispose):
- 8:26 AM Changeset in webkit [139884] by
-
- 7 edits in trunk/Source/WebCore
[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid copying
https://bugs.webkit.org/show_bug.cgi?id=105552
Reverting 139877. It made a couple of API tests fail.
- platform/graphics/gstreamer/GStreamerVersioning.cpp:
- platform/graphics/gstreamer/GStreamerVersioning.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient):
(_WebKitWebSrcPrivate):
(webKitWebSrcFinalize):
(webKitWebSrcStop):
(StreamingClient::didReceiveData):
- platform/network/ResourceHandleClient.h:
(ResourceHandleClient):
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::cleanupSoupRequestOperation):
(WebCore::nextMultipartResponsePartCallback):
(WebCore::sendRequestCallback):
(WebCore::readCallback):
- 8:00 AM Changeset in webkit [139883] by
-
- 5 edits in trunk
Web Inspector: cookies with empty value are parsed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=107012
Reviewed by Pavel Feldman.
Source/WebCore:
Require cookie value to be a string, not a non-empty string, before
employing legacy compatibility hack of treating bare token as value
for the cookie with an empty name.
- inspector/front-end/CookieParser.js:
(WebInspector.CookieParser.prototype._addCookie):
LayoutTests:
- inspector/cookie-parser-expected.txt:
- inspector/cookie-parser.html:
- 7:35 AM Changeset in webkit [139882] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed EFL build fix after r139877.
- platform/graphics/gstreamer/GStreamerVersioning.cpp:
(getGstBufferDataPointer): Add const modifier to webkitGstMapInfoQuarkString.
- 7:26 AM Changeset in webkit [139881] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: create helper InspectorTest method to dump editor HTML
https://bugs.webkit.org/show_bug.cgi?id=107007
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Pavel Feldman.
Add helper method to dump textEditor HTML.
- inspector/editor/editor-test.js:
(initialize_EditorTests.InspectorTest.dumpEditorHTML): Added.
- inspector/editor/text-editor-highlight-regexp.html:
- 7:20 AM Changeset in webkit [139880] by
-
- 5 edits in trunk
Web Inspector: [Extensions API] remove inspectedWindow.onReset event
https://bugs.webkit.org/show_bug.cgi?id=107009
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/ExtensionAPI.js:
(defineCommonExtensionSymbols):
(injectedExtensionAPI.InspectorExtensionAPI):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.initExtensions):
LayoutTests:
- inspector/extensions/extensions-api-expected.txt: removed webInspector.onReset.
- 7:13 AM Changeset in webkit [139879] by
-
- 5 edits in trunk
Web Inspector: fix text-editor-highlight-regexp test
https://bugs.webkit.org/show_bug.cgi?id=107006
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Use 'height: 100%' instead of pixel values on highlight spans to bring in some platform independency in test expectations.
No new tests: no changes in behaviour.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._measureRegex):
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
- inspector/front-end/textEditor.css:
(.text-editor-overlay-highlight):
(.webkit-line-content):
LayoutTests:
Fixing test expectations: no more height style.
- inspector/editor/text-editor-highlight-regexp-expected.txt:
- 7:06 AM Changeset in webkit [139878] by
-
- 6 edits in trunk/Source
[Qt] Use the shared HistoryItem serialization for QWebHistory
https://bugs.webkit.org/show_bug.cgi?id=106671
Reviewed by Allan Sandfeld Jensen.
Source/WebCore:
This allows a few things missing from the previous serialization code
to function while using commonly maintained code:
- The itemSequenceNumber and documentSequenceNumber that were needed to properly restore same-document navigations
- The form data
- The navigation hierarchy mapping the frame tree
- history/HistoryItem.h:
(HistoryItem):
- history/qt/HistoryItemQt.cpp:
(QDataStreamCoder):
(WebCore):
(WebCore::QDataStreamCoder::QDataStreamCoder):
(WebCore::QDataStreamCoder::encodeBytes):
(WebCore::QDataStreamCoder::encodeBool):
(WebCore::QDataStreamCoder::encodeUInt32):
(WebCore::QDataStreamCoder::encodeUInt64):
(WebCore::QDataStreamCoder::encodeInt32):
(WebCore::QDataStreamCoder::encodeInt64):
(WebCore::QDataStreamCoder::encodeFloat):
(WebCore::QDataStreamCoder::encodeDouble):
(WebCore::QDataStreamCoder::encodeString):
(WebCore::QDataStreamCoder::decodeBytes):
(WebCore::QDataStreamCoder::decodeBool):
(WebCore::QDataStreamCoder::decodeUInt32):
(WebCore::QDataStreamCoder::decodeUInt64):
(WebCore::QDataStreamCoder::decodeInt32):
(WebCore::QDataStreamCoder::decodeInt64):
(WebCore::QDataStreamCoder::decodeFloat):
(WebCore::QDataStreamCoder::decodeDouble):
(WebCore::QDataStreamCoder::decodeString):
(WebCore::HistoryItem::restoreState):
(WebCore::WebCore::HistoryItem::saveState):
Source/WebKit/qt:
Bump the serialization version and change the code to abort the
restore of a previous stream version rather than trying to keep the
support of restoring previous versions. This is mainly to simplify
things given that HistoryItem itself aborts in that case.
- Api/qwebhistory.cpp:
(operator<<):
(operator>>):
- tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::serialize_2): Modify the test to cover same-document navigations.
(tst_QWebHistory::restoreIncompatibleVersion1): Add a previous version
hard-coded stream to verify that the deserialization doesn't hang or
crash.
- 6:15 AM Changeset in webkit [139877] by
-
- 7 edits in trunk/Source/WebCore
[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid copying
https://bugs.webkit.org/show_bug.cgi?id=105552
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-01-15
Reviewed by Philippe Normand.
Makes it possible for the GStreamer media backend to provide the buffer to which
the Soup networking backend will use to download data to. This makes copying
memory unnecessary when ResourceHandle hands data over to the media player's
StreamingClient. Thanks to Dan Winship for help designing the interface.
No behaviour change, covered by existing tests.
- platform/graphics/gstreamer/GStreamerVersioning.cpp:
(getGstBufferSize): Abstract obtaining the size of the buffer, so the code
is cleaner while still working for both GST 0.10 and 1.0.
(setGstBufferSize): Ditto, but for setting the size.
(getGstBufferDataPointer): Ditto, but for grabbing the data pointer.
(mapGstBuffer): Convenience method to take care of mapping the buffer so that
we can provide the data pointer to ResourceHandle.
(unmapGstBuffer): Convenience method which takes care of unmapping the buffer
and properly freeing the GstMapInfo.
- platform/graphics/gstreamer/GStreamerVersioning.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient): New methods.
(_WebKitWebSrcPrivate): We now store the GstBuffer we provided the data pointer from
so we can later unmap it and push it to the pipeline.
(webKitWebSrcDispose): Deal with the GstBuffer in case it exists when the source is
destroyed.
(webKitWebSrcStop): Also clear the GstBuffer in this case.
(StreamingClient::didReceiveData): Handle the hand-over of the buffer.
(StreamingClient::getBuffer): Provide ResourceHandle with a new GstBuffer's data pointer.
- platform/network/ResourceHandleClient.h:
(ResourceHandleClient):
(WebCore::ResourceHandleClient::ResourceHandleClient): Constructor to initialize the buffer
member variable to 0.
(WebCore::ResourceHandleClient::~ResourceHandleClient): Destructor to free the buffer if it
has been allocated.
(WebCore::ResourceHandleClient::getBuffer): Default implementation which returns a
newly allocated char pointer.
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal): Store actual buffer size, which is no longer a constant.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::cleanupSoupRequestOperation): Clear the buffer pointer, the life-cycle of the
buffer is handled by the ResourceHandleClient.
(WebCore::nextMultipartResponsePartCallback): Get a new buffer from the client before reading.
(WebCore::sendRequestCallback): Ditto.
(WebCore::readCallback): Ditto.
- 5:55 AM Changeset in webkit [139876] by
-
- 5 edits in trunk/Source
[Qt] Crash in WebCore::CachedFrame::destroy
https://bugs.webkit.org/show_bug.cgi?id=104525
Reviewed by Adam Barth.
Source/WebCore:
Add an assert to increase the chances of catching this crash
early on in the future.
- dom/Document.cpp:
(WebCore::Document::takeDOMWindowFrom):
Source/WebKit/qt:
Remove the call to HistoryController::setCurrentItem which is ultimately
causing the initial empty document of a page to be added to the page cache.
This re-introduce the bug that was fixed by this line, which will be
properly fixed in a follow-up patch.
- Api/qwebhistory.cpp:
(operator>>):
- tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::saveAndRestore_crash_4): Cover the crash.
- 5:50 AM Changeset in webkit [139875] by
-
- 8 edits in trunk/Tools
[chromium] move setMockDeviceOrientation to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106895
Patch by Dan Carney <dcarney@google.com> on 2013-01-16
Reviewed by Jochen Eisinger.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebKit):
(WebTestRunner::WebTestDelegate::setDeviceOrientation):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setMockDeviceOrientation):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setDeviceOrientation):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 5:30 AM QtWebKitGardening edited by
- Add community support section (diff)
- 5:17 AM Changeset in webkit [139874] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Updating or removing a few stale expectations.
Adding two failure expectations for MicroData tests that are
failing after r139673.
- platform/gtk/TestExpectations:
- 5:11 AM Changeset in webkit [139873] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: fix Сlosure warnings in devTools front-end
https://bugs.webkit.org/show_bug.cgi?id=106993
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Vsevolod Vlasov.
Add missing annotations and rename Element.remove() method to avoid collision with HTMLSelectElement.remove() method.
No new tests: no change in behaviour.
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.hasChildNodes):
(WebInspector.DOMNode.prototype.getChildNodes):
- inspector/front-end/DOMExtension.js:
(Element.prototype.removeSelf):
(removeSubsequentNodes):
- inspector/front-end/DefaultTextEditor.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.OverridesSettingsTab):
- inspector/front-end/SourceTokenizer.js:
(WebInspector.SourceTokenizer):
- 4:41 AM Changeset in webkit [139872] by
-
- 8 edits in trunk/Tools
[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
https://bugs.webkit.org/show_bug.cgi?id=106904
Reviewed by Adam Barth.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::notifyDone):
(DRTTestRunner::reset):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
(WebTestRunner::WebTestDelegate::setFocus):
(WebTestRunner::WebTestDelegate::setAcceptAllCookies):
(WebTestRunner::WebTestDelegate::pathToLocalResource):
(WebTestRunner::WebTestDelegate::setLocale):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setAlwaysAcceptCookies):
(WebTestRunner):
(WebTestRunner::TestRunner::setWindowIsKey):
(WebTestRunner::TestRunner::pathToLocalResource):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::setPOSIXLocale):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::taskList):
(TestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setDeviceScaleFactor):
(WebViewHost::setFocus):
(WebViewHost::setAcceptAllCookies):
(WebViewHost::pathToLocalResource):
(WebViewHost::setLocale):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 4:16 AM Changeset in webkit [139871] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix backward compatibility issues with Element.remove() method
https://bugs.webkit.org/show_bug.cgi?id=106996
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Vsevolod Vlasov.
Add javascript implementations for CharacterData.prototype.remove and DocumentType.prototype.remove.
No new tests: no change in behaviour.
- inspector/front-end/DOMExtension.js:
- 4:13 AM Changeset in webkit [139870] by
-
- 2 edits in trunk/Source/WebCore
GraphicsSurfaceGLX is leaking an XWindow
https://bugs.webkit.org/show_bug.cgi?id=107002
The XWindow created as a backing surface for
the GraphicsSurfaceGLX needs to be destroyed
together with the GraphicsSurface.
Reviewed by Noam Rosenthal.
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::clear):
- 4:02 AM Changeset in webkit [139869] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Marking compositing/layer-creation/overlap-animation-container as failure
after it started failing in r139794, might just need a rebaseline but first let's have
someone familiar with AC look at it.
- platform/efl/TestExpectations:
- 4:00 AM Changeset in webkit [139868] by
-
- 2 edits in trunk/Tools
[GTK] build-webkit fails if the jhbuild wrapper is not used
https://bugs.webkit.org/show_bug.cgi?id=106769
Reviewed by Martin Robinson.
Return an empty array instead of "" in
jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
will not be recognized as a valid command when the returned array
is directly passed to perl's system() call.
- Scripts/webkitdirs.pm:
(jhbuildWrapperPrefixIfNeeded):
- 3:51 AM Changeset in webkit [139867] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
Doesn't build with GCC 4.7+
https://bugs.webkit.org/show_bug.cgi?id=106999
Reviewed by Csaba Osztrogonác.
Correct GNU_C_MINOR macro to GNUC_MINOR.
- src/compiler/preprocessor/ExpressionParser.y:
- 3:30 AM Changeset in webkit [139866] by
-
- 37 edits5 adds in trunk
Implement CSSSupportsRule
https://bugs.webkit.org/show_bug.cgi?id=104822
Patch by Pablo Flouret <pablof@motorola.com> on 2013-01-16
Reviewed by Allan Sandfeld Jensen.
Source/WebCore:
http://dev.w3.org/csswg/css3-conditional/#the-csssupportsrule-interface
Right now, @supports is not implemented as a proper CSSRule. Apart from
the CSSOM implications it gives wrong results when, for instance, an
@supports rule is nested inside a @media rule.
Test: css3/supports-cssom.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Add CSSSupportsRule.* and associated files.
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
- bindings/objc/DOMCSS.mm:
(kitClass):
- bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::wrap):
Create the correct wrappers for the rule.
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::createSupportsRule):
(WebCore::CSSParser::markSupportsRuleHeaderStart):
(WebCore::CSSParser::markSupportsRuleHeaderEnd):
- css/CSSParser.h:
Create the supports rule when parsing and add it where it corresponds,
instead of directly adding the child rules to the stylesheet.
- css/CSSPropertySourceData.h:
- css/CSSRule.h:
- css/CSSRule.idl:
Add SUPPORTS_RULE type to enums.
- css/CSSSupportsRule.cpp: Added.
(WebCore::CSSSupportsRule::CSSSupportsRule):
(WebCore::CSSSupportsRule::~CSSSupportsRule):
(WebCore::CSSSupportsRule::cssText):
(WebCore::CSSSupportsRule::conditionText):
- css/CSSSupportsRule.h: Added.
(WebCore::CSSSupportsRule::create):
- css/CSSSupportsRule.idl: Added.
DOM interface.
- css/RuleSet.cpp:
(WebCore::RuleSet::addChildRules):
Add rules included in the @supports rule.
- css/StyleResolver.cpp:
(WebCore::collectCSSOMWrappers):
Collect CSSSupportsRule wrappers.
- css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleSupports::StyleRuleSupports):
- css/StyleRule.h:
(StyleRuleBase):
(WebCore::StyleRuleBase::isSupportsRule):
(StyleRuleSupports):
(WebCore::StyleRuleSupports::create):
(WebCore::StyleRuleSupports::conditionText):
(WebCore::StyleRuleSupports::conditionIsSupported):
(WebCore::StyleRuleSupports::copy):
(WebCore::toStyleRuleSupports):
New subclass of StyleRuleBlock: StyleRuleSupports.
- css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):
- inspector/InspectorStyleSheet.cpp:
(flattenSourceData):
(WebCore::asCSSRuleList):
Handle @supports rules where needed.
LayoutTests:
- css3/supports-cssom-expected.txt: Added.
- css3/supports-cssom.html: Added.
- css3/supports-expected.txt:
- css3/supports.html:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 3:04 AM Changeset in webkit [139865] by
-
- 7 edits2 adds in trunk
INPUT_MULTIPLE_FIELDS_UI: Unable to edit a time field with step=86400, and confusing appearance
https://bugs.webkit.org/show_bug.cgi?id=106983
Reviewed by Kentaro Hara.
Source/WebCore:
For example, we show a read-only hour field and a read-only minutes
field for <input type=time min="17:00" step=86400> because the step
value is 24 hours and the hour field can be only 17. However, we need to
provide a way to clear the value of the time field in such case. We
shouldn't make the hour field read-only if no other fields are editable.
- We don't make hour fields read-only for input[type=time].
- We make hour fields read-only for input[type=datetime-local] only if year, month, or day field is editable. e.g. <input type=datetime-local min=2013-01-16T17:00 step=86400>:
The hour field is read-only, and year/month/day fields are editable.
<input type=datetime-local min=2013-01-16T17:00 max=2013-01-16T18:00 step=86400>:
The hour field is editable, and year/month/day fields are read-only.
Test: fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html
- html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Declare new functions.
(WebCore::DateTimeEditBuilder::getRangeOfDayOfMonthField):
Added a function by extracting some code from visitField.
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditBuilder::shouldDayOfMonthFieldReadOnly):
Added a function by extracting some code from visitField.
(WebCore::DateTimeEditBuilder::shouldHourFieldReadOnly):
If the type is "time", we don't make hour fields read-only.
Otherwise, we don't make hour fields read-only if year/month/day fields
are read-only. Note that we don't need to check read-only status of year
and month fields explicitly here because a day field can be read-only
only if the year field and the month field are read-only.
LayoutTests:
Note: We don't add tests for input[type=datetime] now because the WHATWG
specification might be changed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield-expected.txt: Added.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
Update test cases for new behavior. We should not make hour fields
read-only for input[type=time].
- platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png: Ditto.
- platform/chromium/TestExpectations: Add time-appearance-basic.html.
- 2:59 AM Changeset in webkit [139864] by
-
- 2 edits in trunk/Source/WebCore
[TexMap] Composited CSS shaders crash when using non-GL TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=106796
Reviewed by Noam Rosenthal.
Fail gracefully when FilterEffectRenderer fails to build the filter effects.
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):
- 2:47 AM Changeset in webkit [139863] by
-
- 3 edits6 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2013-01-16
- platform/qt-5.0-wk1/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added. Rebaseline after r139798.
- platform/qt-5.0-wk1/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added. Rebaseline after r139798.
- platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt: Added. Rebaseline after r139794.
- platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Rebaseline after r139798.
- platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Rebaseline after r139798.
- 2:43 AM Changeset in webkit [139862] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Store project UISourceCodes in a map with uri as a key for faster lookup.
https://bugs.webkit.org/show_bug.cgi?id=106911
Reviewed by Pavel Feldman.
- inspector/front-end/Workspace.js:
(WebInspector.Project):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype._reset):
(WebInspector.Project.prototype.uiSourceCodeForOriginURL):
(WebInspector.Project.prototype.uiSourceCodeForURI):
(WebInspector.Project.prototype.uiSourceCodes):
- 2:42 AM Changeset in webkit [139861] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Removed fast/events/drag-and-drop-autoscroll from Test expectations after rollout in r139503.
ScrollingCoordinator tests moved to TestExpectations after r139686.
Border size rendering change in r139798 requires a rebaseline for
svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm &
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
but they fail to generate pixel results - see bug 106992.
PropertyCollection tests skipped for now after r139756
- platform/efl/TestExpectations:
- 2:26 AM Changeset in webkit [139860] by
-
- 15 edits3 adds in trunk
Web Inspector: Introduce file mapping allowing to map network loaded scripts and stylesheets to file system files.
https://bugs.webkit.org/show_bug.cgi?id=106795
Reviewed by Pavel Feldman.
Source/WebCore:
Introduced file mapping for inspector.
FileMapping is essentially an array of MappingEntries where each MappingEntry is a pair of urlPrefix and pathPrefix.
When scripts and stylesheets are mapped to uiSourceCodes FileMapping methods are used to establish
prefix based matching with file system uiSourceCodes if possible.
Test: inspector/file-mapping.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.uiLocationToRawLocation):
(WebInspector.CompilerScriptMapping.prototype.get addScript.get this):
(WebInspector.CompilerScriptMapping.prototype.get addScript):
(WebInspector.CompilerScriptMapping.prototype._bindUISourceCode):
(WebInspector.CompilerScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
- inspector/front-end/FileMapping.js: Added.
(WebInspector.FileMapping):
(WebInspector.FileMapping.prototype.hasMappingForURL):
(WebInspector.FileMapping.prototype.uriForURL):
(WebInspector.FileMapping.prototype.urlForURI):
(WebInspector.FileMapping.prototype.setMappings):
(WebInspector.FileMapping.prototype.mappings):
(WebInspector.FileMapping.prototype._deserialize):
(WebInspector.FileMapping.prototype._serialize):
(WebInspector.FileMapping.MappingEntry):
(WebInspector.FileMapping.MappingEntry.deserialize):
(WebInspector.FileMapping.MappingEntry.prototype.matchesURL):
(WebInspector.FileMapping.MappingEntry.prototype.matchesURI):
(WebInspector.FileMapping.MappingEntry.prototype.uriForURL):
(WebInspector.FileMapping.MappingEntry.prototype.urlForURI):
(WebInspector.FileMapping.MappingEntry.prototype.serialize):
- inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._workspaceUISourceCodeForScript):
(WebInspector.ResourceScriptMapping.prototype._scriptsForUISourceCode):
- inspector/front-end/ResourceUtils.js:
(WebInspector.displayNameForURL):
- inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping):
(WebInspector.SASSSourceMapping.prototype._reloadCSS):
(_addURLMapping):
(rawLocationToUILocation):
(_reset):
(WebInspector.SASSSourceMapping.MappingEntry):
- inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.StylesSourceMapping.prototype._projectWillReset):
(WebInspector.StyleContentBinding.prototype.):
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/Workspace.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
LayoutTests:
- inspector/file-mapping-expected.txt: Added.
- inspector/file-mapping.html: Added.
- 2:19 AM Changeset in webkit [139859] by
-
- 36 edits in trunk
Web Inspector: Introduce UISourceCode.originURL().
https://bugs.webkit.org/show_bug.cgi?id=106909
Reviewed by Pavel Feldman.
Source/WebCore:
Introduced originURL on UISourceCode showing where UISourceCode in workspace was loaded from.
This is neeeded to distinguish it from network request url used by mappings.
- inspector/front-end/AdvancedSearchController.js:
(WebInspector.FileBasedSearchResultsPane.prototype._createAnchor):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints):
- inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.Placard.prototype._update):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._handleOpenURL):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
- inspector/front-end/Linkifier.js:
(WebInspector.Linkifier.prototype._updateAnchor):
(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorSourceTreeElement):
- inspector/front-end/SASSSourceMapping.js:
(uiLocationToRawLocation):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._showSourceLine):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes.comparator):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleWorkspaceProvider.prototype.addFile):
- inspector/front-end/StyleSheetOutlineDialog.js:
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems):
- inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping.prototype.uiLocationToRawLocation):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._tooltipForFile):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.originURL):
(WebInspector.UISourceCode.prototype.urlChanged):
(WebInspector.UISourceCode.prototype.contentURL):
(WebInspector.Revision.prototype.contentURL):
- inspector/front-end/Workspace.js:
(WebInspector.FileDescriptor):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype.uiSourceCodeForOriginURL):
(WebInspector.Workspace.prototype.uiSourceCodeForOriginURL):
LayoutTests:
- http/tests/inspector/compiler-script-mapping.html:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- http/tests/inspector/network/network-request-revision-content.html:
- http/tests/inspector/workspace-test.js:
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/dynamic-script-tag.html:
- inspector/debugger/linkifier.html:
- inspector/debugger/live-edit-breakpoints.html:
- inspector/debugger/script-snippet-model.html:
- inspector/debugger/scripts-file-selector.html:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting.html:
- inspector/debugger/source-frame-count.html:
- inspector/debugger/source-url-comment.html:
- inspector/debugger/ui-source-code-display-name.html:
- inspector/debugger/ui-source-code.html:
- inspector/styles/styles-history.html:
- inspector/uisourcecode-revisions.html:
- 2:16 AM Changeset in webkit [139858] by
-
- 4 edits94 moves23 adds in trunk
[EFL] Move 'DefaultTheme' folder to WebCore/platform/efl
https://bugs.webkit.org/show_bug.cgi?id=106969
Reviewed by Benjamin Poulain.
.:
- Source/PlatformEfl.cmake: Change DefaultTheme path.
- Source/cmake/OptionsEfl.cmake: ditto.
Source/WebCore:
DefaultTheme is used by both EFL WK1 and WK2 ports. So, WebCore/platform/efl is appropriate place for it.
- platform/efl/DefaultTheme/CMakeLists.txt: Renamed from Source/WebKit/efl/DefaultTheme/CMakeLists.txt.
- platform/efl/DefaultTheme/default.edc: Renamed from Source/WebKit/efl/DefaultTheme/default.edc.
- platform/efl/DefaultTheme/widget/button/button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/button.edc.
- platform/efl/DefaultTheme/widget/button/img_button_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/img_button_focus.png.
- platform/efl/DefaultTheme/widget/button/img_button_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/img_button_hover.png.
- platform/efl/DefaultTheme/widget/button/img_button_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/img_button_normal.png.
- platform/efl/DefaultTheme/widget/button/img_button_press.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/img_button_press.png.
- platform/efl/DefaultTheme/widget/check/check.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/check.edc.
- platform/efl/DefaultTheme/widget/check/img_check_bg_disabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_bg_disabled.png.
- platform/efl/DefaultTheme/widget/check/img_check_bg_enabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_bg_enabled.png.
- platform/efl/DefaultTheme/widget/check/img_check_off.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_off.png.
- platform/efl/DefaultTheme/widget/check/img_check_off_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_off_focus.png.
- platform/efl/DefaultTheme/widget/check/img_check_off_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_off_hover.png.
- platform/efl/DefaultTheme/widget/check/img_check_on.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_on.png.
- platform/efl/DefaultTheme/widget/check/img_check_on_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_on_focus.png.
- platform/efl/DefaultTheme/widget/check/img_check_on_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_on_hover.png.
- platform/efl/DefaultTheme/widget/combo/combo.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo.edc.
- platform/efl/DefaultTheme/widget/combo/combo_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_focus.png.
- platform/efl/DefaultTheme/widget/combo/combo_focus_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_focus_button.png.
- platform/efl/DefaultTheme/widget/combo/combo_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_hover.png.
- platform/efl/DefaultTheme/widget/combo/combo_hover_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_hover_button.png.
- platform/efl/DefaultTheme/widget/combo/combo_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_normal.png.
- platform/efl/DefaultTheme/widget/combo/combo_normal_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_normal_button.png.
- platform/efl/DefaultTheme/widget/combo/combo_press.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_press.png.
- platform/efl/DefaultTheme/widget/combo/combo_press_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_press_button.png.
- platform/efl/DefaultTheme/widget/combo/icon.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/icon.png.
- platform/efl/DefaultTheme/widget/entry/entry.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/entry/entry.edc.
- platform/efl/DefaultTheme/widget/entry/img_focused.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/entry/img_focused.png.
- platform/efl/DefaultTheme/widget/entry/img_hovered.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/entry/img_hovered.png.
- platform/efl/DefaultTheme/widget/entry/img_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/entry/img_normal.png.
- platform/efl/DefaultTheme/widget/file/file.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file.edc.
- platform/efl/DefaultTheme/widget/file/file_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file_focus.png.
- platform/efl/DefaultTheme/widget/file/file_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file_hover.png.
- platform/efl/DefaultTheme/widget/file/file_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file_normal.png.
- platform/efl/DefaultTheme/widget/file/file_press.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file_press.png.
- platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/enterfullscreenbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/enterfullscreenbutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/exitfullscreenbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/exitfullscreenbutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc.
- platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc.
- platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mutebutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/mutebutton/mutebutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/unmutebutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/mutebutton/unmutebutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/pausebutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/playpausebutton/pausebutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playbutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc.
- platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc.
- platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackwardbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackwardbutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc.
- platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforwardbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforwardbutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption.png.
- platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption_disabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption_disabled.png.
- platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc.
- platform/efl/DefaultTheme/widget/progressbar/bt_base.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/progressbar/bt_base.png.
- platform/efl/DefaultTheme/widget/progressbar/progressbar.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/progressbar/progressbar.edc.
- platform/efl/DefaultTheme/widget/progressbar/shelf_inset.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/progressbar/shelf_inset.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_bg_disabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_bg_disabled.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_bg_enabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_bg_enabled.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_off.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_off.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_off_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_off_focus.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_off_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_off_hover.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_on.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_on.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_on_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_on_focus.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_on_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_on_hover.png.
- platform/efl/DefaultTheme/widget/radio/radio.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/radio.edc.
- platform/efl/DefaultTheme/widget/scrollbar/scrollbar.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar.edc.
- platform/efl/DefaultTheme/widget/scrollbar/scrollbar_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_h.png.
- platform/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_h.png.
- platform/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_v.png.
- platform/efl/DefaultTheme/widget/scrollbar/scrollbar_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_v.png.
- platform/efl/DefaultTheme/widget/search/cancel/cancel_normal_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/cancel/cancel_normal_button.png.
- platform/efl/DefaultTheme/widget/search/cancel/cancel_normal_button2.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/cancel/cancel_normal_button2.png.
- platform/efl/DefaultTheme/widget/search/cancel/search_cancel.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/cancel/search_cancel.edc.
- platform/efl/DefaultTheme/widget/search/decoration/decoration_normal_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/decoration/decoration_normal_button.png.
- platform/efl/DefaultTheme/widget/search/decoration/search_decoration.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/decoration/search_decoration.edc.
- platform/efl/DefaultTheme/widget/search/field/field_focused.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/field/field_focused.png.
- platform/efl/DefaultTheme/widget/search/field/field_hovered.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/field/field_hovered.png.
- platform/efl/DefaultTheme/widget/search/field/field_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/field/field_normal.png.
- platform/efl/DefaultTheme/widget/search/field/search_field.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/field/search_field.edc.
- platform/efl/DefaultTheme/widget/slider/slider.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider.edc.
- platform/efl/DefaultTheme/widget/slider/slider_fill_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_fill_h.png.
- platform/efl/DefaultTheme/widget/slider/slider_fill_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_fill_v.png.
- platform/efl/DefaultTheme/widget/slider/slider_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_h.png.
- platform/efl/DefaultTheme/widget/slider/slider_thumb_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_thumb_h.png.
- platform/efl/DefaultTheme/widget/slider/slider_thumb_press_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_thumb_press_h.png.
- platform/efl/DefaultTheme/widget/slider/slider_thumb_press_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_thumb_press_v.png.
- platform/efl/DefaultTheme/widget/slider/slider_thumb_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_thumb_v.png.
- platform/efl/DefaultTheme/widget/slider/slider_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_v.png.
- platform/efl/DefaultTheme/widget/spinner/sp_bg.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_bg.png.
- platform/efl/DefaultTheme/widget/spinner/sp_down_default.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_down_default.png.
- platform/efl/DefaultTheme/widget/spinner/sp_down_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_down_hover.png.
- platform/efl/DefaultTheme/widget/spinner/sp_down_pressed.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_down_pressed.png.
- platform/efl/DefaultTheme/widget/spinner/sp_up_default.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_up_default.png.
- platform/efl/DefaultTheme/widget/spinner/sp_up_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_up_hover.png.
- platform/efl/DefaultTheme/widget/spinner/sp_up_pressed.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_up_pressed.png.
- platform/efl/DefaultTheme/widget/spinner/spinner.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/spinner.edc.
- 2:07 AM Changeset in webkit [139857] by
-
- 2 edits1 delete in trunk/LayoutTests
REGRESSION(r139835): fast/js/integer-division-neg2tothe32-by-neg1.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106991
Unreviewed gardening, updated expected file.
- fast/js/integer-division-neg2tothe32-by-neg1-expected.txt:
- platform/chromium/fast/js/integer-division-neg2tothe32-by-neg1-expected.txt: Removed.
- 2:06 AM Changeset in webkit [139856] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed gardening.
Roll Chromium to 177117.
- DEPS:
- 2:05 AM Changeset in webkit [139855] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding a failure expectation for fast/js/integer-division-neg2tothe32-by-neg1.html.
The test started failing after r139835.
- platform/gtk/TestExpectations:
- 2:02 AM Changeset in webkit [139854] by
-
- 7 edits in trunk/Source/WebCore
[V8] Make an Isolate parameter mandatory in SerializedScriptValue::deserialize()
https://bugs.webkit.org/show_bug.cgi?id=106916
Reviewed by Adam Barth.
This is one of steps to remove optional Isolate parameters.
No tests. No change in behavior.
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserialize):
(WebCore):
(WebCore::SerializedScriptValue::deserializeForInspector):
- bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
- bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
- 1:50 AM Changeset in webkit [139853] by
-
- 10 edits5 adds in trunk
[Inspector] Add events for tracking page loads and scheduled navigations.
https://bugs.webkit.org/show_bug.cgi?id=104168
Patch by Ken Kania <kkania@chromium.org> on 2013-01-16
Reviewed by Pavel Feldman.
These events are needed for clients who need to be aware of when a page is
navigating or about to navigate. Some clients may wish to prevent interaction
with the page during this time. Two of the new events track loading start and
stop, as measured by the ProgressTracker. The other two events track when a
page has a new scheduled navigation and when it no longer has a scheduled
navigation. These latter two events won't allow the client to determine if
a load is going to happen in all circumstances, but is sufficient for many cases.
Source/WebCore:
Tests: inspector-protocol/page/frameScheduledNavigation.html
inspector-protocol/page/frameStartedLoading.html
- inspector/Inspector.json:
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::frameStartedLoadingImpl):
(WebCore::InspectorInstrumentation::frameStoppedLoadingImpl):
(WebCore::InspectorInstrumentation::frameScheduledNavigationImpl):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigationImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore):
(WebCore::InspectorInstrumentation::frameStoppedLoading):
(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::frameStartedLoading):
(WebCore):
(WebCore::InspectorPageAgent::frameStoppedLoading):
(WebCore::InspectorPageAgent::frameScheduledNavigation):
(WebCore::InspectorPageAgent::frameClearedScheduledNavigation):
- inspector/InspectorPageAgent.h:
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.PageDispatcher.prototype.frameDetached):
(WebInspector.PageDispatcher.prototype.frameStartedLoading):
(WebInspector.PageDispatcher.prototype.frameStoppedLoading):
(WebInspector.PageDispatcher.prototype.frameScheduledNavigation):
(WebInspector.PageDispatcher.prototype.frameClearedScheduledNavigation):
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::clear):
(WebCore::NavigationScheduler::timerFired):
(WebCore::NavigationScheduler::startTimer):
(WebCore::NavigationScheduler::cancel):
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
LayoutTests:
- inspector-protocol/page/frameScheduledNavigation-expected.txt: Added.
- inspector-protocol/page/frameScheduledNavigation.html: Added.
- inspector-protocol/page/frameStartedLoading-expected.txt: Added.
- inspector-protocol/page/frameStartedLoading.html: Added.
- 1:47 AM Changeset in webkit [139852] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining after r139798.
- platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
- 1:45 AM Changeset in webkit [139851] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaseline this test on Linux after r139798:
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
- platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
- 1:42 AM Changeset in webkit [139850] by
-
- 8 edits in trunk/Tools
[chromium] add title text direction attribute to TestRunner
https://bugs.webkit.org/show_bug.cgi?id=106907
Reviewed by Adam Barth.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
- DumpRenderTree/chromium/DRTTestRunner.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::setTitleTextDirection):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setTitleTextDirection):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::didReceiveTitle):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didReceiveTitle):
- 1:34 AM Changeset in webkit [139849] by
-
- 8 edits in trunk
MediaStream API: Update MediaStreamTrack::readyState to match specification
https://bugs.webkit.org/show_bug.cgi?id=106781
Reviewed by Kentaro Hara.
Source/WebCore:
MediaStreamTrack::readyState now returns a string like the rest of the RTC classes.
Existing tests expanded to cover patch.
- Modules/mediastream/MediaStream.cpp:
(WebCore::processTrack):
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::readyState):
(WebCore::MediaStreamTrack::ended):
(WebCore):
- Modules/mediastream/MediaStreamTrack.h:
(MediaStreamTrack):
- Modules/mediastream/MediaStreamTrack.idl:
LayoutTests:
- fast/mediastream/MediaStreamTrack-expected.txt:
- fast/mediastream/MediaStreamTrack.html:
- 1:24 AM Changeset in webkit [139848] by
-
- 5 edits in trunk
Web Inspector: array grouping does not work for big and negative number keys
https://bugs.webkit.org/show_bug.cgi?id=106891
Reviewed by Pavel Feldman.
Source/WebCore:
Fixing array grouping for arrays that contain big or negative number representations as object keys.
- inspector/front-end/ObjectPropertiesSection.js:
(.buildObjectFragment):
LayoutTests:
- inspector/console/console-big-array-expected.txt:
- inspector/console/console-big-array.html:
- 1:13 AM Changeset in webkit [139847] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaseline this test after r139835:
fast/js/integer-division-neg2tothe32-by-neg1.html
- platform/chromium/fast/js/integer-division-neg2tothe32-by-neg1-expected.txt: Added.
- 1:07 AM Changeset in webkit [139846] by
-
- 8 edits in trunk/LayoutTests
Unreviewed gardening.
Adjusting failure expectations for fast/harness/sample-fail-mismatch-reftest.html
on all ports. The expectation for the test is now marked as a WontFix image failure.
r139786 reintroduced the possibility of running tests marked as WontFix if there is
another expectation (like Failure, ImageOnlyFailure) listed for the test.
This specific test tests that the harness correctly behaves in a case of a mismatch
reftest that matches with its baseline (i.e. that an image failure is reported). As
such every port should run it to ensure correct behavior of the ImageDiff tool in combination
with NRWT.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 1:01 AM Changeset in webkit [139845] by
-
- 8 edits2 moves26 adds4 deletes in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Baseline (and rebaseline on Linux) these tests introduced in
r139836:
fast/gradients/unprefixed-color-stop-units.html
fast/gradients/unprefixed-color-stops.html
fast/gradients/unprefixed-generated-gradients.html
fast/gradients/unprefixed-gradient-parsing.html
fast/gradients/unprefixed-linear-angle-gradients.html
fast/gradients/unprefixed-linear-right-angle-gradients.html
fast/gradients/unprefixed-list-item-gradient.html
fast/gradients/unprefixed-radial-gradients.html
fast/gradients/unprefixed-radial-gradients2.html
fast/gradients/unprefixed-radial-gradients3.html
fast/gradients/unprefixed-repeating-end-fill.html
fast/gradients/unprefixed-repeating-linear-gradient.html
fast/gradients/unprefixed-repeating-radial-gradients.html
fast/gradients/unprefixed-zero-range-repeating-gradient-hang.html
- platform/chromium-linux/fast/gradients/unprefixed-color-stop-units-expected.png:
- platform/chromium-linux/fast/gradients/unprefixed-color-stops-expected.png: Removed.
- platform/chromium-linux/fast/gradients/unprefixed-generated-gradients-expected.png: Removed.
- platform/chromium-linux/fast/gradients/unprefixed-linear-angle-gradients-expected.png:
- platform/chromium-linux/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png:
- platform/chromium-linux/fast/gradients/unprefixed-radial-gradients-expected.png:
- platform/chromium-linux/fast/gradients/unprefixed-radial-gradients2-expected.png:
- platform/chromium-linux/fast/gradients/unprefixed-radial-gradients3-expected.png: Removed.
- platform/chromium-linux/fast/gradients/unprefixed-repeating-linear-gradient-expected.png:
- platform/chromium-linux/fast/gradients/unprefixed-repeating-radial-gradients-expected.png:
- platform/chromium-linux/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Removed.
- platform/chromium-mac-lion/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-color-stops-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-generated-gradients-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-linear-angle-gradients-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-list-item-gradient-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-radial-gradients-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-radial-gradients2-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-radial-gradients3-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-repeating-end-fill-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-repeating-linear-gradient-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-repeating-radial-gradients-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-color-stops-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-generated-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-linear-angle-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-list-item-gradient-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/gradients/unprefixed-list-item-gradient-expected.png.
- platform/chromium-win/fast/gradients/unprefixed-radial-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-radial-gradients2-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-radial-gradients3-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-repeating-end-fill-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/gradients/unprefixed-repeating-end-fill-expected.png.
- platform/chromium-win/fast/gradients/unprefixed-repeating-linear-gradient-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-repeating-radial-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Added.
- 12:48 AM Changeset in webkit [139844] by
-
- 5 edits2 adds in trunk
Web Inspector: highlight regexp API for DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=106801
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Pavel Feldman.
Source/WebCore:
Add highlightRegexp and removeRegexpHighlight methods to DefaultTextEditor that highlight
all occurrences of given regexp in text with given css class.
Highlight is done via spans positioned absolutely over the regexp occurences in text.
Test: inspector/editor/text-editor-highlight-regexp.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.highlightRegex):
(WebInspector.DefaultTextEditor.prototype.removeRegexHighlight):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.highlightRegex):
(WebInspector.TextEditorMainPanel.prototype.removeRegexHighlight):
(WebInspector.TextEditorMainPanel.prototype._repaintVisibleChunks):
(WebInspector.TextEditorMainPanel.prototype._findRegexOccurrences):
(WebInspector.TextEditorMainPanel.prototype._measureRegex):
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
- inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.highlightRegex):
(WebInspector.TextEditor.prototype.removeRegexHighlight):
- inspector/front-end/textEditor.css:
(.text-editor-overlay-highlight):
(.debug-fadeout):
LayoutTests:
New layout test to verify DefaultTextEditor highlight regexp API.
- inspector/editor/text-editor-highlight-regexp-expected.txt: Added.
- inspector/editor/text-editor-highlight-regexp.html: Added.
- 12:23 AM Changeset in webkit [139843] by
-
- 2 edits2 copies in branches/chromium/1364
Merge 139419
Connect UserGestureIndicator for mousedown and mouseup events
https://bugs.webkit.org/show_bug.cgi?id=105138
Reviewed by Adam Barth.
Source/WebCore:
Ports that consume user gestures to prevent certain types of pop-ups
need to be able to connect mousedown and mouseup events, otherwise, a
single mouse click will allow for opening multiple pop-ups.
Note that a mousedown is not always followed by a mouseup and vice
versa, e.g. when the mousedown results in a context menu being shown, or
something is dragged into the page.
Test: platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html
- page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
- page/EventHandler.h:
LayoutTests:
- platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt: Added.
- platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html: Added.
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/11975006
- 12:05 AM Changeset in webkit [139842] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed gardening.
Roll Chromium to r177080.
- DEPS:
- 12:02 AM Changeset in webkit [139841] by
-
- 3 edits in trunk/Tools
NRWT still confused about test count with --repeat-each and --iterations
https://bugs.webkit.org/show_bug.cgi?id=106562
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2013-01-16
Reviewed by Dirk Pranke.
Fix the printed unique test count and skipped count. This
seems to have broken in r127688 ("NRWT lies about the number
of tests that it's skipping when used with --repeat-each").
Also add a test for print_found()
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_found):
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_details):
(Testprinter):
(Testprinter.test_found):
Jan 15, 2013:
- 11:53 PM Changeset in webkit [139840] by
-
- 2 edits in trunk/Tools
Unreviewed follow-up to r139769.
Note that omitting the WebKit1 code from the build now
works for GTK as well.
- Scripts/build-webkit:
- 11:36 PM Changeset in webkit [139839] by
-
- 7 edits in trunk/Source/WebCore
Get rid of Node::createRareData
https://bugs.webkit.org/show_bug.cgi?id=106981
Reviewed by Benjamin Poulain.
Deleted Node::createRareData. Node::ensureRareData() instantiates NodeRareData
or ElementRareData according to the node type. Also encapsulate new by create
functions in NodeRareData and ElementRareData.
- dom/Element.cpp:
(WebCore):
- dom/Element.h:
(Element):
- dom/ElementRareData.h:
(WebCore::ElementRareData::create):
(ElementRareData):
(WebCore::ElementRareData::ElementRareData):
- dom/Node.cpp:
(WebCore::Node::ensureRareData):
(WebCore):
- dom/Node.h:
(WebCore::NodeRareDataBase::NodeRareDataBase):
- dom/NodeRareData.h:
(NodeRareData):
(WebCore::NodeRareData::create):
(WebCore::NodeRareData::NodeRareData):
- 10:52 PM Changeset in webkit [139838] by
-
- 2 edits in trunk/Source/WebCore
GTK+ and Qt build fix after r139833.
Explicitly cast NodeRareDataBase to NodeRareData before deleting it.
- dom/Node.cpp:
(WebCore::Node::clearRareData):
- 10:46 PM Changeset in webkit [139837] by
-
- 2 edits in trunk/Source/WebCore
Remove extra space in CustomFilterRenderer.h
https://bugs.webkit.org/show_bug.cgi?id=105783
Patch by Qiankun Miao <qiankun.miao@intel.com> on 2013-01-15
Reviewed by Dean Jackson.
- platform/graphics/filters/CustomFilterRenderer.h:
(CustomFilterRenderer):
- 10:15 PM Changeset in webkit [139836] by
-
- 6 edits41 adds in trunk
Source/WebCore: Update CSS3 gradient support to the latest spec version and unprefix.
https://bugs.webkit.org/show_bug.cgi?id=67166
Patch by Tab Atkins <tabatkins@google.com> on 2013-01-15
Reviewed by Dean Jackson.
Tests: fast/gradients/unprefixed-color-stop-units.html
fast/gradients/unprefixed-color-stops.html
fast/gradients/unprefixed-generated-gradients.html
fast/gradients/unprefixed-gradient-parsing.html
fast/gradients/unprefixed-linear-angle-gradients.html
fast/gradients/unprefixed-linear-right-angle-gradients.html
fast/gradients/unprefixed-list-item-gradient.html
fast/gradients/unprefixed-radial-gradients.html
fast/gradients/unprefixed-radial-gradients2.html
fast/gradients/unprefixed-radial-gradients3.html
fast/gradients/unprefixed-repeating-end-fill.html
fast/gradients/unprefixed-repeating-linear-gradient.html
fast/gradients/unprefixed-repeating-radial-gradients.html
fast/gradients/unprefixed-zero-range-repeating-gradient-hang.html
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::computeEndPoint): Rename parameters to make more sense.
(WebCore::CSSLinearGradientValue::customCssText):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::customCssText):
(WebCore::CSSRadialGradientValue::createGradient):
- css/CSSGradientValue.h:
(CSSGradientValue):
(CSSRadialGradientValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::isGeneratedImageValue):
(WebCore::CSSParser::parseGeneratedImage):
- css/CSSParser.h:
LayoutTests: Update CSS3 gradient support to the latest spec version
https://bugs.webkit.org/show_bug.cgi?id=67166
Patch by Tab Atkins <jackalmage@gmail.com> on 2013-01-15
Reviewed by Dean Jackson.
- fast/gradients/unprefixed-color-stop-units-expected.txt: Added.
- fast/gradients/unprefixed-color-stop-units.html: Added.
- fast/gradients/unprefixed-color-stops-expected.txt: Added.
- fast/gradients/unprefixed-color-stops.html: Added.
- fast/gradients/unprefixed-generated-gradients-expected.txt: Added.
- fast/gradients/unprefixed-generated-gradients.html: Added.
- fast/gradients/unprefixed-gradient-parsing-expected.txt: Added.
- fast/gradients/unprefixed-gradient-parsing.html: Added.
- fast/gradients/unprefixed-linear-angle-gradients-expected.txt: Added.
- fast/gradients/unprefixed-linear-angle-gradients.html: Added.
- fast/gradients/unprefixed-linear-right-angle-gradients-expected.txt: Added.
- fast/gradients/unprefixed-linear-right-angle-gradients.html: Added.
- fast/gradients/unprefixed-list-item-gradient-expected.txt: Added.
- fast/gradients/unprefixed-list-item-gradient.html: Added.
- fast/gradients/unprefixed-radial-gradients-expected.txt: Added.
- fast/gradients/unprefixed-radial-gradients.html: Added.
- fast/gradients/unprefixed-radial-gradients2-expected.txt: Added.
- fast/gradients/unprefixed-radial-gradients2.html: Added.
- fast/gradients/unprefixed-radial-gradients3-expected.txt: Added.
- fast/gradients/unprefixed-radial-gradients3.html: Added.
- fast/gradients/unprefixed-repeating-end-fill-expected.txt: Added.
- fast/gradients/unprefixed-repeating-end-fill.html: Added.
- fast/gradients/unprefixed-repeating-linear-gradient-expected.txt: Added.
- fast/gradients/unprefixed-repeating-linear-gradient.html: Added.
- fast/gradients/unprefixed-repeating-radial-gradients-expected.txt: Added.
- fast/gradients/unprefixed-repeating-radial-gradients.html: Added.
- fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.txt: Added.
- fast/gradients/unprefixed-zero-range-repeating-gradient-hang.html: Added.
- platform/chromium-linux/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
- platform/chromium-linux/fast/gradients/unprefixed-color-stops-expected.png: Added.
- platform/chromium-linux/fast/gradients/unprefixed-generated-gradients-expected.png: Added.
- platform/chromium-linux/fast/gradients/unprefixed-linear-angle-gradients-expected.png: Added.
- platform/chromium-linux/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png: Added.
- platform/chromium-linux/fast/gradients/unprefixed-list-item-gradient-expected.png: Added.
- platform/chromium-linux/fast/gradients/unprefixed-radial-gradients-expected.png: Added.
- platform/chromium-linux/fast/gradients/unprefixed-radial-gradients2-expected.png: Added.
- platform/chromium-linux/fast/gradients/unprefixed-radial-gradients3-expected.png: Added.
- platform/chromium-linux/fast/gradients/unprefixed-repeating-end-fill-expected.png: Added.
- platform/chromium-linux/fast/gradients/unprefixed-repeating-linear-gradient-expected.png: Added.
- platform/chromium-linux/fast/gradients/unprefixed-repeating-radial-gradients-expected.png: Added.
- platform/chromium-linux/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Added.
- 9:47 PM Changeset in webkit [139835] by
-
- 5 edits in trunk
DFG X86: division in the used-as-int case doesn't correctly check for -231/-1
https://bugs.webkit.org/show_bug.cgi?id=106978
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Changed the numerator equal to -231 check to just return if we expect an integer
result, since the check is after we have determined that the denominator is -1.
The int result of -231 / -1 is -231, so just return the numerator as the result.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForX86):
LayoutTests:
Added a new DFG check for -231 / -1 when we expect and integer result.
- fast/js/integer-division-neg2tothe32-by-neg1-expected.txt:
- fast/js/script-tests/integer-division-neg2tothe32-by-neg1.js:
(myDivExpectingInt):
- 9:25 PM Changeset in webkit [139834] by
-
- 4 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaseline this test on Win after r139798:
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
- platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
- platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/chromium/TestExpectations:
- 9:23 PM Changeset in webkit [139833] by
-
- 7 edits in trunk/Source/WebCore
NodeRareData doesn't need to have a vtable pointer
https://bugs.webkit.org/show_bug.cgi?id=106965
Reviewed by Benjamin Poulain.
Made the destructor and reportMemoryUsage of NodeRareDataBase and NodeRareData
respectively and their subclasses non-virtual.
- dom/ElementRareData.cpp:
(SameSizeAsElementRareData): Added.
(WebCore): Added a compile assertion for the size of ElementRareData.
- dom/ElementRareData.h:
(ElementRareData):
- dom/Node.cpp:
(WebCore::Node::clearRareData): Explicitely delete NodeRareData or ElementRareData.
(WebCore::Node::reportMemoryUsage): Explicitely add NodeRareData or ElementRareData.
- dom/Node.h:
(NodeRareDataBase): Deleted the virtual destructor.
- dom/NodeRareData.cpp:
(SameSizeAsNodeRareData): Removed one pointer.
- dom/NodeRareData.h:
(NodeRareData): Removed the virtual destructor.
(NodeRareData::reportMemoryUsage): Made non-virtual.
- 9:10 PM Changeset in webkit [139832] by
-
- 7 edits1 move in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaseline this test after r139798:
svg/zoom/page/zoom-replaced-intrinsic-ratio-001.html
- platform/chromium-mac-lion/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Generalize LayoutTests/platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt.
- 8:44 PM Changeset in webkit [139831] by
-
- 2 edits in trunk/Tools
test-webkitpy: truncate output to the terminal width when necessary
https://bugs.webkit.org/show_bug.cgi?id=106973
Reviewed by Ojan Vafai.
this implements the same logic for test-webkitpy that we have
for run-webkit-tests (and ninja).
No tests written as this is exercised by running test-webkitpy itself.
- Scripts/webkitpy/test/printer.py:
(Printer.configure):
(Printer._test_line):
- 8:42 PM Changeset in webkit [139830] by
-
- 2 edits in trunk/Tools
remove extraneous output in test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=106971
Reviewed by Ojan Vafai.
We weren't ignoring or capturing the echoed output from
these two tests, and getting noise in the logs as a result.
- Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.test_auto_stringify_args):
(ExecutiveTest.test_popen_args):
- 8:36 PM Changeset in webkit [139829] by
-
- 12 edits in trunk/Source
[chromium] Create GraphicsLayerChromiums using a factory
https://bugs.webkit.org/show_bug.cgi?id=103635
Reviewed by James Robinson.
Refactor graphics layer creation for chromium to go through a factory.
Source/WebCore:
No new tests, no change in functionality.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayer::create):
Source/WebKit/chromium:
- src/ChromeClientImpl.cpp:
(WebCore):
(GraphicsLayerFactoryChromium):
(WebCore::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium):
(WebKit::ChromeClientImpl::ChromeClientImpl):
(WebKit::ChromeClientImpl::graphicsLayerFactory):
(WebKit):
- src/ChromeClientImpl.h:
(WebCore):
(ChromeClientImpl):
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
- src/NonCompositedContentHost.h:
(WebCore):
(WebKit::NonCompositedContentHost::create):
(NonCompositedContentHost):
- src/PageOverlay.cpp:
(WebKit::PageOverlay::update):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::graphicsLayerFactory):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
(WebCore):
(WebViewImpl):
- tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
- tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):
- 7:53 PM Changeset in webkit [139828] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] LayerRenderingResults doesn't need to maintain the hole punch rect
https://bugs.webkit.org/show_bug.cgi?id=106896
Reviewed by George Staikos.
Internally reviewed by Arvid Nilsson and John Griggs.
No new tests,clean up code which is not used anymore.
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::drawHolePunchRect):
- platform/graphics/blackberry/LayerRenderer.h:
(LayerRenderingResults):
- 7:44 PM Changeset in webkit [139827] by
-
- 2 edits in trunk/Tools
webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
https://bugs.webkit.org/show_bug.cgi?id=106974
Reviewed by Ryosuke Niwa.
I forgot to stub out the call to check to ensure that the ports were
available, so this test could fail if something was listening on 8000 or
8443 on the machine.
- Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
(TestHttpServer.test_win32_start_and_stop):
- 7:20 PM Changeset in webkit [139826] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Add expectations for this test:
scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
On the Chromium Mac Debug bot it is drawn with system scrollbars;
see <https://bugs.webkit.org/show_bug.cgi?id=106858>
- platform/chromium/TestExpectations:
- 7:12 PM Changeset in webkit [139825] by
-
- 4 edits2 deletes in trunk/Source/WebKit2
Merge LayerTreeHostCA and LayerTreeHostMac
https://bugs.webkit.org/show_bug.cgi?id=106967
Reviewed by Sam Weinig.
There's no need to have a LayerTreeHostCA base class anymore, just merge it into LayerTreeHostMac.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/ca/LayerTreeHostCA.cpp: Removed.
- WebProcess/WebPage/ca/LayerTreeHostCA.h: Removed.
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
(LayerTreeHostMac):
- WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::LayerTreeHostMac):
(WebKit::LayerTreeHostMac::~LayerTreeHostMac):
(WebKit::LayerTreeHostMac::layerTreeContext):
(WebKit::LayerTreeHostMac::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit):
(WebKit::LayerTreeHostMac::setRootCompositingLayer):
(WebKit::LayerTreeHostMac::invalidate):
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostMac::scrollNonCompositedContents):
(WebKit::LayerTreeHostMac::forceRepaint):
(WebKit::LayerTreeHostMac::sizeDidChange):
(WebKit::LayerTreeHostMac::deviceScaleFactorDidChange):
(WebKit::LayerTreeHostMac::didInstallPageOverlay):
(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostMac::pauseRendering):
(WebKit::LayerTreeHostMac::resumeRendering):
(WebKit::LayerTreeHostMac::setLayerHostingMode):
(WebKit::LayerTreeHostMac::notifyAnimationStarted):
(WebKit::LayerTreeHostMac::notifyFlushRequired):
(WebKit::LayerTreeHostMac::paintContents):
(WebKit::LayerTreeHostMac::deviceScaleFactor):
(WebKit::LayerTreeHostMac::flushLayers):
(WebKit::LayerTreeHostMac::initialize):
(WebKit::LayerTreeHostMac::performScheduledLayerFlush):
(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
(WebKit::LayerTreeHostMac::createPageOverlayLayer):
(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
- 7:02 PM Changeset in webkit [139824] by
-
- 3 edits2 adds in trunk
Fullscreen element should not share styles with it's siblings.
https://bugs.webkit.org/show_bug.cgi?id=106888
Reviewed by George Staikos.
Source/WebCore:
Test: fullscreen/full-screen-no-style-sharing.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
LayoutTests:
- fullscreen/full-screen-no-style-sharing-expected.txt: Added.
- fullscreen/full-screen-no-style-sharing.html: Added.
- 7:00 PM Changeset in webkit [139823] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaselining this test on Windows:
svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html
The Chromium XP and Win7 bots' results look consistent and the
spurious grey areas are already being tracked by bug 80517.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png:
- platform/chromium/TestExpectations:
- 6:51 PM Changeset in webkit [139822] by
-
- 17 edits in trunk/Source
Clamp TileCache visibleRect to WKView's visibleRect
https://bugs.webkit.org/show_bug.cgi?id=106601
<rdar://problem/12843164>
Reviewed by Simon Fraser.
Some clients expand the WKView to be much larger than what is visible on screen, and
control scrolling with their own view. Currently, we will create tiles for the entire
view, consuming a great deal of memory, and can sometimes factor scrollbars which can
never exist into layout. Piggyback on WKView SPI (the property minimumWidthForAutoLayout,
renamed from minimumLayoutWidth) to drop into a mode where we disable main frame scrolling
and respect the WKView's visibleRect when creating tiles.
- UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]): Update the page's viewExposedRect from our visibleRect.
(-[WKView _updateWindowAndViewFrames]): Update the page's viewExposedRect from our visibleRect.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): The main frame is scrollable by default.
(-[WKView enableFrameSizeUpdates]): If frame size updates become enabled, update the
page's viewExposedRect from our visibleRect.
(-[WKView setMinimumLayoutWidth:]): Rename minimumLayoutWidth property to minimumWidthForAutoLayout.
Warn once if the old one is used.
(-[WKView minimumWidthForAutoLayout]):
(-[WKView setMinimumWidthForAutoLayout:]): Adjust the minimum layout width, whether the main frame
is scrollable, and update the page's viewExposedRect if needed.
- UIProcess/API/mac/WKViewPrivate.h: Added minimumWidthForAutoLayout property.
- UIProcess/WebPageProxy.h:
(WebPageProxy): Add viewExposedRectChanged/setMainFrameIsScrollable.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::viewExposedRectChanged): Forward viewExposedRectChanged to WebPage.
(WebKit::WebPageProxy::setMainFrameIsScrollable): Forward setMainFrameIsScrollable to WebPage.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Disable scrollbars and scrolling if
main frame scrollability is disabled.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setExposedRect): Added empty default implementation.
(WebKit::DrawingArea::mainFrameScrollabilityChanged): Added empty default implementation.
(DrawingArea):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowAndViewFramesChanged): We don't need the WebCore:: namespace.
(WebKit::WebPage::viewExposedRectChanged): Forward exposed rect changes to DrawingArea (only TiledCoreAnimationDrawingArea cares, for now).
(WebKit::WebPage::setMainFrameIsScrollable): Forward scrollability changes to DrawingArea and the main FrameView.
(WebKit::WebPage::drawRectToImage): We don't need the WebCore:: namespace.
- WebProcess/WebPage/WebPage.h:
(WebPage): Add mainFrameIsScrollable, viewExposedRectChanged, setMainFrameIsScrollable, and storage for m_mainFrameIsScrollable.
(WebKit::WebPage::mainFrameIsScrollable):
- WebProcess/WebPage/WebPage.messages.in: Add ViewExposedRectChanged and SetMainFrameIsScrollable messages.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect): Forward new exposed rect to TiledBacking (only TileCache cares, for now).
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged): Ask TiledBacking to clip to the exposedRect if main frame scrolling is disabled.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry): Use size instead of viewSize in case we've changed it because of m_minimumLayoutWidth.
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer): Update exposedRect and clipsToExposedRect.
- platform/graphics/TiledBacking.h:
(TiledBacking): Add setExposedRect and setClipsToExposedRect.
- platform/graphics/ca/mac/TileCache.h:
(TileCache): Add setExposedRect, setClipsToExposedRect, and storage for their respective values.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache): Initialize m_clipsToExposedRect to false.
(WebCore::TileCache::setExposedRect): Update exposedRect and revalidate tiles.
(WebCore::TileCache::setClipsToExposedRect): Update clipsToExposedRect and revalidate tiles;
if we're going from unclipped to clipped, we already have tiles, so we can skip tile revalidation.
(WebCore::TileCache::computeTileCoverageRect): Intersect exisiting visible rect with
exposed rect to get the visible rect we actually care about.
(WebCore::TileCache::revalidateTiles): Ditto.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer): Don't create an overhang layer if the frame isn't scrollable.
(WebCore::RenderLayerCompositor::requiresContentShadowLayer): Don't create a shadow layer if the frame isn't scrollable.
- 6:39 PM Changeset in webkit [139821] by
-
- 9 edits in trunk
Unreviewed, rolling out r139792.
http://trac.webkit.org/changeset/139792
https://bugs.webkit.org/show_bug.cgi?id=106970
Broke the windows build.
Source/JavaScriptCore:
- bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.
Tools:
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::notifyDone):
(DRTTestRunner::reset):
(DRTTestRunner::setAlwaysAcceptCookies):
(DRTTestRunner::setWindowIsKey):
(DRTTestRunner::pathToLocalResource):
(DRTTestRunner::setPOSIXLocale):
(InvokeCallbackTask):
(InvokeCallbackTask::InvokeCallbackTask):
(InvokeCallbackTask::runIfValid):
(DRTTestRunner::setBackingScaleFactor):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
(DRTTestRunner::taskList):
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::setDatabaseQuota):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setDatabaseQuota):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setPendingExtraData):
(WebViewHost::setDeviceScaleFactor):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 6:38 PM Changeset in webkit [139820] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Add expectations for this test:
inspector/extensions/extensions-reload.html
This is flakily slow on the Chromium Win7 Release bot.
- platform/chromium/TestExpectations:
- 6:21 PM Changeset in webkit [139819] by
-
- 3 edits in trunk/Source/WebCore
Get rid of a straggling dependency on SafariThemeConstants in RenderThemeWin.
Rubberstamped by Timothy Horton.
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::supportsClosedCaptioning):
- rendering/RenderThemeWin.h:
- 6:12 PM Changeset in webkit [139818] by
-
- 2 edits in trunk/Tools
Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
- Scripts/webkitpy/common/config/ports.py:
(MacWK2Port):
- 6:06 PM Changeset in webkit [139817] by
-
- 3 edits in trunk/Source/WebCore
Group all request parameters which are used to match CSS Rules into a parameter object.
https://bugs.webkit.org/show_bug.cgi?id=106879
Reviewed by Dimitri Glazkov.
Introduces a MatchRequest which groups all request parameters to match CSS rules.
Factoring, no change in behavior.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
- css/StyleResolver.h:
(WebCore::StyleResolver::MatchRequest::MatchRequest):
(MatchRequest):
(StyleResolver):
- 6:02 PM Changeset in webkit [139816] by
-
- 2 edits in trunk/Source/WebKit/efl
Unreviewed. Fix build break by r139796.
- ewk/ewk_frame.cpp:
(ewk_frame_text_matches_mark):
- 6:01 PM Changeset in webkit [139815] by
-
- 4 edits in trunk/Source/WebCore
Add the ability for a RenderLayerBacking to have a layer that renders backgrounds.
https://bugs.webkit.org/show_bug.cgi?id=106961
Reviewed by Dean Jackson.
In some cases we need a compositing layer to render its background into
a separate GraphicsLayer (e.g. for background-attachment: fixed in some scenarios).
To support this, have RenderLayer optionally create a GraphicsLayer for the background.
Currently nothing causes background layers to get created.
Having a background layer requires that we add an additional containment layer
which encloses the background, primary and foreground layers, since the
background layer has to be composited behind the primary content. This containment
layer gets any transform, including page scale on the RenderView's layer.
No new tests; there's no way to create a background layer yet. This was tested during
development by forcing a background layer.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDebugIndicators): Show borders on both new layers
and repaint counters on the background layer.
(WebCore::RenderLayerBacking::destroyGraphicsLayers): Clear the two new layers.
(WebCore::RenderLayerBacking::updateTransform): If we have a containment layer, it
takes the transform (and clear the transform on the primary layer).
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Make the background
layer if we need one (currently never).
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Position and size
the containment layer if we have one. If we do, then the m_graphicsLayer will
be at 0,0 in that containment layer. The background layer is also sized similarly
to the foreground layer.
(WebCore::RenderLayerBacking::updateInternalHierarchy): Adapt to the new hierarchy
with containment and background layers if we have them.
(WebCore::RenderLayerBacking::updateBackgroundLayer): Here's where we create the background
and containment layers.
(WebCore::RenderLayerBacking::childForSuperlayers): If we have a containment layer, that's
what gets attached to our parent.
(WebCore::RenderLayerBacking::getCurrentTransform): The containment layer gets the transform
if we have one, so check that here.
(WebCore::RenderLayerBacking::backingStoreMemoryEstimate):
(WebCore::RenderLayerBacking::reportMemoryUsage):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::deviceOrPageScaleFactorChanged): We need to start notifying
about page/device scale on the containment layer if there is one (since it takes page scale), so
use childForSuperlayers() rather than just getting the primary layer.
- 5:48 PM Changeset in webkit [139814] by
-
- 9 edits in trunk/Source/WebCore
Remove Key3 and Challenge Response fields from Websocket implementation and Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=105738.
Patch by Pan Deng <pan.deng@intel.com> on 2013-01-15
Reviewed by Kent Tamura.
Key3 and Challenge Response fields were obsoleted in IETF websocket spec, this patch removes related
code in Websocket and Web Inspector
No new tests as no new functionality added.
- Modules/websockets/WebSocketHandshakeRequest.cpp: remove Key3 related code
- Modules/websockets/WebSocketHandshakeRequest.h:
(WebSocketHandshakeRequest):
- Modules/websockets/WebSocketHandshakeResponse.cpp: remove Challenge response related code
- Modules/websockets/WebSocketHandshakeResponse.h:
(WebSocketHandshakeResponse):
- inspector/Inspector.json: remove Key3 and Challenge response fields definition
- inspector/InspectorResourceAgent.cpp: remove Key3 and Challenge response field from inspector agent
(WebCore):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
- inspector/front-end/RequestHeadersView.js: remove Key3 and Challenge response item from front-end.
(WebInspector.RequestHeadersView.prototype._refreshRequestHeaders):
(WebInspector.RequestHeadersView.prototype._refreshResponseHeaders):
(WebInspector.RequestHeadersView.prototype._refreshHeaders):
- 5:38 PM Changeset in webkit [139813] by
-
- 4 edits in branches/chromium/1364/Source/WebKit/chromium
Merge 138893
Add function to move caret selection towards a point
https://bugs.webkit.org/show_bug.cgi?id=105189
Patch by Chris Hopman <cjhopman@google.com> on 2013-01-05
Reviewed by Eric Seidel.
This function moves the selection to the corresponding point in the
rootEditableElement of the current selection. Used on Android for
the behavior of insertion handles (i.e. dragging the caret around).
- public/WebFrame.h:
(WebFrame):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
(WebKit):
- src/WebFrameImpl.h:
(WebFrameImpl):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11931008
- 5:33 PM Changeset in webkit [139812] by
-
- 2 edits in trunk/Source/JavaScriptCore
Use MADV_FREE_REUSABLE to return JIT memory to OS
https://bugs.webkit.org/show_bug.cgi?id=106830
<rdar://problem/11437701>
Reviewed by Geoffrey Garen.
Use MADV_FREE_REUSABLE to return JIT memory on OSes that have the underlying madvise bug
fixed.
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::notifyPageIsFree):
- 5:07 PM Changeset in webkit [139811] by
-
- 2 edits in trunk/Source/WebCore
ASSERT(!m_queue.killed() && m_threadID) hit in StorageThread::scheduleTask on low memory warning
https://bugs.webkit.org/show_bug.cgi?id=106960
Reviewed by Mark Rowe.
We were scheduling a memory clearing task to terminated StorageThreads.
Remove thread from the active thread list when terminate is scheduled. Add when thread is started.
- storage/StorageThread.cpp:
(WebCore::activeStorageThreads):
(WebCore::StorageThread::StorageThread):
(WebCore::StorageThread::~StorageThread):
(WebCore::StorageThread::start):
(WebCore::StorageThread::terminate):
(WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads):
- 4:45 PM Changeset in webkit [139810] by
-
- 3 edits1 add2 deletes in trunk/LayoutTests
Unreviewed mac rebaseline for r139798.
- http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
- platform/mac-wk2/svg/zoom/page: Removed.
- platform/mac/TestExpectations:
- platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Removed.
- platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- 4:18 PM Changeset in webkit [139809] by
-
- 2 edits in trunk
Fix typos in WebKitFeatures.cmake
https://bugs.webkit.org/show_bug.cgi?id=106952
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-01-15
Reviewed by Martin Robinson.
- Source/cmake/WebKitFeatures.cmake:
Replace "Toogle" with "Toggle".
- 4:16 PM Changeset in webkit [139808] by
-
- 2 edits in trunk/Source/WebCore
Don't do indiscriminate cast & call in StylePropertySet::PropertyReference::cssName() on release builds.
https://bugs.webkit.org/show_bug.cgi?id=106867
Reviewed by Darin Adler.
Check CSSValue::isVariableValue() before casting to CSSVariableValue.
Covered by existing variables tests.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::PropertyReference::cssName):
- 4:14 PM Changeset in webkit [139807] by
-
- 4 edits2 adds in trunk
[Sub pixel layout] RTL cells with padding wraps
https://bugs.webkit.org/show_bug.cgi?id=106843
Source/WebCore:
Reviewed by Levi Weintraub.
At certain zoom levels table cells with padding wraps for rtl
content.
Test: fast/sub-pixel/table-rtl-padding.html
- rendering/RenderTable.h: Override paddingStart/End to return
integer values for padding as we do elsewhere in the table code.
LayoutTests:
Reviewed by Levi Weintraub.
Add test for rtl tables with padding.
- fast/sub-pixel/input-caret-on-subpixel-bound-expected.html:
- fast/sub-pixel/table-rtl-padding-expected.html: Added.
- fast/sub-pixel/table-rtl-padding.html: Added.
- 4:13 PM Changeset in webkit [139806] by
-
- 3 edits2 adds in trunk
Use-after-free in AXObjectCache::notificationPostTimerFired
https://bugs.webkit.org/show_bug.cgi?id=106106
Reviewed by Ryosuke Niwa.
Source/WebCore:
Fixes a crash that occurs when a Node is adopted by another document,
in particular one that isn't part of the page, and then deleted,
which wasn't triggering the code that removed the Node from
AXObjectCache. Now, a Node is removed from the AXObjectCache whenever
its Document changes.
Test: accessibility/crash-adopt-node-from-new-document.html
- dom/Node.cpp:
(WebCore::Node::didMoveToNewDocument):
LayoutTests:
Test that demonstrates the crash when a Node with an
AccessibilityObject changes its document and then isn't removed from
the AXObjectCache when it's deleted.
- accessibility/crash-adopt-node-from-new-document-expected.txt: Added.
- accessibility/crash-adopt-node-from-new-document.html: Added.
- 4:02 PM Changeset in webkit [139805] by
-
- 3 edits in trunk/Tools
Extend sheriffbot's "help" command to be able to get help on individual commands
https://bugs.webkit.org/show_bug.cgi?id=106629
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-15
Reviewed by Eric Seidel.
Added a help command to sheriffbot.
Fixed some style issues and ordered the commands alphabetically.
- Scripts/webkitpy/tool/bot/irc_command.py:
(IRCCommand):
(IRCCommand.execute):
(IRCCommand.usage):
(IRCCommand.help):
(CreateBug):
(CreateBug.execute):
(Help):
(Help.execute):
(Help._post_command_help):
(Hi):
(Hi.execute):
(Restart):
(RollChromiumDEPS):
(RollChromiumDEPS._parse_args):
(RollChromiumDEPS._expand_irc_nickname):
(RollChromiumDEPS.execute):
(Rollout):
(Rollout._extract_revisions):
(Rollout.execute):
(Sheriffs):
(Sheriffs.execute):
(Whois):
(Whois.execute):
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help):
- 3:58 PM Changeset in webkit [139804] by
-
- 7 edits2 adds in trunk
Add Canvas blend modes to Cairo
https://bugs.webkit.org/show_bug.cgi?id=105074
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-01-15
Reviewed by Martin Robinson.
Source/WebCore:
Blend mode implementation for cairo. If BlendMode is normal, use
CompositeOperator; otherwise, consider CompositeOperator is
source-over.
Add toCairoOperator(BlendMode) to translate BlendMode to matching
cairo_operator_t.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::draw):
- platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::toCairoOperator):
- platform/graphics/cairo/CairoUtilities.h:
(WebCore):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation):
LayoutTests:
Unskip fast/canvas/canvas-blend-image.html and
fast/canvas/canvas-blend-solid.html
Add platform specific expected files because currently, expected
results are not correct.
- platform/gtk/TestExpectations:
- platform/gtk/fast/canvas/canvas-blend-image-expected.txt: Added.
- platform/gtk/fast/canvas/canvas-blend-solid-expected.txt: Added.
- 3:49 PM Changeset in webkit [139803] by
-
- 8 edits in trunk
Implement matching by the voice attribute for WebVTT ::cue pseudo element
https://bugs.webkit.org/show_bug.cgi?id=106762
Patch by Dima Gorbik <dgorbik@apple.com> on 2013-01-15
Reviewed by Eric Carlson.
Source/WebCore:
Implemented matching cue WebVTT elements by a voice attribute by adding a WebVTT specific voice attribute.
For DOM trees title attribute is used instead as this is required by specs.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::copyWebVTTNodeToDOMTree): set a title argument instead of a voice attribute for the DOM tree.
- html/track/TextTrackCue.h:
(WebCore::TextTrackCue::voiceAttributeName):
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken):
LayoutTests:
- media/track/captions-webvtt/styling.vtt:
- media/track/track-css-matching-expected.txt:
- media/track/track-css-matching.html:
- 3:46 PM Changeset in webkit [139802] by
-
- 3 edits in trunk/Source/WebCore
Some ScrollingCoördinator-related cleanup in RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=106950
Reviewed by Beth Dakin.
Wrap up code that gets the ScrollingCoordinator into a utility function.
Pull code out of updateGraphicsLayerGeometry() that registers layers with
the ScrollingCoordinator, for cleanliness.
- rendering/RenderLayerBacking.cpp:
(WebCore::scrollingCoordinatorFromLayer):
(WebCore::RenderLayerBacking::adjustTileCacheCoverage):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::registerScrollingLayers):
(WebCore::RenderLayerBacking::attachToScrollingCoordinatorWithParent):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- 3:45 PM Changeset in webkit [139801] by
-
- 2 edits in trunk/Source/WebKit/win
Crash when saving history with no items in it.
https://bugs.webkit.org/show_bug.cgi?id=104261
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-01-15
Reviewed by Darin Adler.
- WebHistory.cpp:
(WebHistory::saveHistoryGuts): Added null pointer check
- 3:43 PM Changeset in webkit [139800] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=106940
Suspend CSS animations for background tabs
Reviewed by Simon Fraser.
- page/Page.cpp:
(WebCore::Page::setVisibilityState):
- 3:40 PM Changeset in webkit [139799] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r139790.
http://trac.webkit.org/changeset/139790
https://bugs.webkit.org/show_bug.cgi?id=106948
The patch is failing its own test.
Source/JavaScriptCore:
- bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.
Source/WebCore:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::parserAppendChild):
- html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):
(WebCore::HTMLScriptRunner::runScript):
LayoutTests:
- fast/dom/MutationObserver/parser-mutations-expected.txt: Removed.
- fast/dom/MutationObserver/parser-mutations.html: Removed.
- 3:21 PM Changeset in webkit [139798] by
-
- 7 edits2 adds in trunk
REGRESSION (r121599): incorrect border scaling when zoomed
https://bugs.webkit.org/show_bug.cgi?id=106944
Source/WebCore:
Reviewed by Levi Weintraub.
Fix bug in ApplyPropertyComputeLength::applyValue where zooming
of non-pixel values was incorrect.
Test: fast/sub-pixel/zoomed-em-border.html
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyComputeLength::applyValue):
LayoutTests:
Reviewed by Levi Weintraub.
Add test for zoomed em border and restore expectations for
zoom-replaced-intrinsic-ratio-001 to the pre r121599 state.
- fast/sub-pixel/zoomed-em-border-expected.html: Added.
- fast/sub-pixel/zoomed-em-border.html: Added.
- platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- 3:17 PM Changeset in webkit [139797] by
-
- 3 edits in trunk/Source/WebCore
Rename RenderLayerBacking's m_containmentLayer to m_childContainmentLayer to better describe its purpose
https://bugs.webkit.org/show_bug.cgi?id=106947
Reviewed by Dean Jackson.
Simple rename of m_containmentLayer to m_childContainmentLayer. I'll
be adding another "container" layer for background layers shortly,
and wanted to improve clarity.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::destroyGraphicsLayers):
(WebCore::RenderLayerBacking::updateInternalHierarchy):
(WebCore::RenderLayerBacking::updateClippingLayers):
(WebCore::RenderLayerBacking::parentForSublayers):
(WebCore::RenderLayerBacking::backingStoreMemoryEstimate):
(WebCore::RenderLayerBacking::reportMemoryUsage):
- rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::hasClippingLayer):
(WebCore::RenderLayerBacking::clippingLayer):
(WebCore::RenderLayerBacking::hasTileCacheFlatteningLayer):
(WebCore::RenderLayerBacking::tileCacheFlatteningLayer):
(RenderLayerBacking):
- 3:00 PM Changeset in webkit [139796] by
-
- 23 edits1 add in trunk
Add a new set of WebKit2 APIs for text search and
search results management.
https://bugs.webkit.org/show_bug.cgi?id=106834.
<rdar://problem/12597159>
Source/WebCore:
Reviewed by Simon Fraser.
Adding new API to perform text search in WebKit2 without using
the stock UI. The new interface provides all the information
necessary to write a custom UI for search.
Added new TextWebKitAPI test.
- WebCore.exp.in: Added new exported methods.
- editing/Editor.cpp:
(WebCore::Editor::countMatchesForText): Added new parameter to store
all the ranges relative to the matches found.
- editing/Editor.h: Modified the interface of countMatchesForText and removed
the other definition of countMatchesForText with a different signature.
- page/Page.cpp:
(WebCore::Page::findStringMatchingRanges): Added.
(WebCore::Page::markAllMatchesForText): Changed to use the new unified
countMatchesForText.
- page/Page.h:
Source/WebKit/mac:
Reviewed by Simon Fraser.
Adding new API to perform text search in WebKit2 without using
the stock UI. The new interface provides all the information
necessary to write a custom UI for search.
Added new TextWebKitAPI test.
- WebView/WebHTMLView.mm:
(-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]):
Modified to reflect the changes to Editor::countMatchesForText interface.
Source/WebKit2:
Reviewed by Simon Fraser.
Adding new API to perform text search in WebKit2 without using
the stock UI. The new interface provides all the information
necessary to write a custom UI for search. The main logic is
implemented in the new functions added to FindController.
Added new TextWebKitAPI test.
- UIProcess/API/C/WKPage.cpp:
(WKPageFindStringMatches): Added.
(WKPageGetImageForFindMatch): Added.
(WKPageSelectFindMatch): Added.
(WKPageSetPageFindMatchesClient): Added.
- UIProcess/API/C/WKPage.h: Added the new API definitions.
- UIProcess/WebFindClient.cpp: Added new client callbacks.
(WebKit::WebFindMatchesClient::didFindStringMatches):
(WebKit::WebFindMatchesClient::didGetImageForMatchResult):
- UIProcess/WebFindClient.h:
(WebFindMatchesClient): Added.
- UIProcess/WebPageProxy.cpp: Added proxy methods.
(WebKit::WebPageProxy::initializeFindMatchesClient):
(WebKit::WebPageProxy::findStringMatches):
(WebKit::WebPageProxy::getImageForFindMatch):
(WebKit::WebPageProxy::selectFindMatch):
(WebKit::WebPageProxy::didGetImageForFindMatch):
(WebKit::WebPageProxy::didFindStringMatches):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findStringMatches): Finds all the matching
text according to the find options. All the matching text ranges are
stored in a vector until the next call to findStringMatches or until
hideFindUI is called. The message that is sent back to the UI process
contains a vector containing an entry for each find match (i.e. for each
range) and each entry is represented by a vector of the corresponding
text rects. It also returns the index in the vector of matches corresponding
to the first match after the user selection.
If there is no selection the index is always 0 and if there are no
matches after the user selection, the index returned is -1.
(WebKit::FindController::getFindIndicatorBitmapAndRect): Helper function
to share code between updateFindIndicator and getImageForFindMatch.
(WebKit::FindController::getImageForFindMatch): Creates the image corresponding
to the text matched at the given match index.
(WebKit::FindController::selectFindMatch): creates a selection for the range
corresponding to the given match index.
(WebKit::FindController::hideFindUI): Added logic to clear the vector
of matched ranges.
(WebKit::FindController::updateFindIndicator): Updated to use the
new helper function getFindIndicatorBitmapAndRect.
- WebProcess/WebPage/FindController.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findStringMatches):
(WebKit::WebPage::getImageForFindMatch):
(WebKit::WebPage::selectFindMatch):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
Added new test for the new WebKit2 API for
text search.
Reviewed by Simon Fraser.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
- 2:46 PM Changeset in webkit [139795] by
-
- 8 edits in trunk/Tools
[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
https://bugs.webkit.org/show_bug.cgi?id=106904
Reverting 139794. It broke the build. It appears that a header file,
WebTextDirection.h, was left out.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner::setTitleTextDirection):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::didReceiveTitle):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didReceiveTitle):
- 2:30 PM Changeset in webkit [139794] by
-
- 21 edits5 adds2 deletes in trunk
[Compositor] Do not disable overlap testing for layers in front of 3D transformed layers
https://bugs.webkit.org/show_bug.cgi?id=106721
Reviewed by Simon Fraser.
Source/WebCore:
RenderLayerCompositor is checking for overlapping layers and tries to figure out all the layers that need
to be drawn using composited layers. It doesn't know anything about animations yet and it only works with "start"
and "end" states. However, it knows that animations might happen, so in that cases it will avoid to do any optimizations,
as layers might get moved.
The overlapping layers optimization was also disabled for 3D layers. However, 3D layers can be computed in WebKit and
can be checked for overlap using just the "start"/"stop" states. In this patch I enable that optimization for 3D layers, too.
The result is that more layers are drawn in software mode now, so I've updated a couple of test results.
Tests: compositing/layer-creation/overlap-transformed-3d.html
compositing/layer-creation/overlap-transformed-preserved-3d.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
LayoutTests:
Added two more tests for the case when 3D layers covered by a 2D layer in front. One is using flat style and the
other is using the preserve-3d mode.
Also, updated a couple of existing test results as some of the composited layers are not needed anymore.
- compositing/geometry/ancestor-overflow-change-expected.txt:
- compositing/geometry/clip-expected.txt:
- compositing/geometry/clip-inside-expected.txt:
- compositing/geometry/foreground-layer-expected.txt:
- compositing/layer-creation/overlap-animation-clipping-expected.txt:
- compositing/layer-creation/overlap-animation-container-expected.txt:
- compositing/layer-creation/overlap-transformed-3d-expected.txt: Added.
- compositing/layer-creation/overlap-transformed-3d.html: Added.
- compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt: Added.
- compositing/layer-creation/overlap-transformed-preserved-3d.html: Added.
- compositing/layer-creation/overlap-transforms-expected.txt:
- compositing/overflow/clip-descendents-expected.txt:
- css3/filters/filtered-compositing-descendant-expected.txt:
- platform/chromium-win/compositing/geometry/ancestor-overflow-change-expected.txt: Removed. There should be no difference now.
- platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Removed. There should be no difference now.
- platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt:
- platform/chromium/compositing/geometry/clip-expected.txt:
- platform/chromium/compositing/geometry/clip-inside-expected.txt:
- platform/chromium/compositing/geometry/foreground-layer-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-animation-container-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt: Added.
- platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
- platform/chromium/compositing/overflow/clip-descendents-expected.txt:
- platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt:
- 2:27 PM Changeset in webkit [139793] by
-
- 5 edits4 adds in trunk/LayoutTests
IndexedDB: Fix tests which depend upon V8 event listener behavior
https://bugs.webkit.org/show_bug.cgi?id=106731
Ensure consistent use of callback(evt) { preamble(evt); ... } pattern, which addresses
running in JSC and in V8 under Workers. Also add worker test wrappers.
Reviewed by Tony Chang.
- storage/indexeddb/cursor-advance-expected.txt:
- storage/indexeddb/cursor-advance-workers-expected.txt: Added.
- storage/indexeddb/cursor-advance-workers.html: Added.
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers-expected.txt: Added.
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers.html: Added.
- storage/indexeddb/resources/cursor-advance.js:
(prepareDatabase):
(testPrefetchInRange.prefetch):
(testPrefetchInRange):
(testPrefetchOutOfRange.prefetch):
(testPrefetchOutOfRange):
(testBadAdvance.advanceBadly):
(testBadAdvance):
(testEdges.request.onsuccess):
(testEdges):
(testDelete.deleteSecond):
(testDelete):
- storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js:
(onOpenSuccess):
- 2:21 PM Changeset in webkit [139792] by
-
- 8 edits in trunk/Tools
[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
https://bugs.webkit.org/show_bug.cgi?id=106904
Reviewed by Adam Barth.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::notifyDone):
(DRTTestRunner::reset):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
(WebTestRunner::WebTestDelegate::setFocus):
(WebTestRunner::WebTestDelegate::setAcceptAllCookies):
(WebTestRunner::WebTestDelegate::pathToLocalResource):
(WebTestRunner::WebTestDelegate::setLocale):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setAlwaysAcceptCookies):
(WebTestRunner):
(WebTestRunner::TestRunner::setWindowIsKey):
(WebTestRunner::TestRunner::pathToLocalResource):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::setPOSIXLocale):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::taskList):
(TestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setDeviceScaleFactor):
(WebViewHost::setFocus):
(WebViewHost::setAcceptAllCookies):
(WebViewHost::pathToLocalResource):
(WebViewHost::setLocale):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 2:20 PM Changeset in webkit [139791] by
-
- 3 edits2 moves in trunk/Source/WebKit2
Rename LayerTreeHostCAMac to LayerTreeHostMac.
Rubber-stamped by Deth Bakin.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/LayerTreeHost.cpp:
- WebProcess/WebPage/mac/LayerTreeHostMac.h: Renamed from Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h.
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: Renamed from Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm.
- 2:17 PM Changeset in webkit [139790] by
-
- 4 edits2 adds in trunk
HTML parser should queue MutationRecords for its operations
https://bugs.webkit.org/show_bug.cgi?id=89351
Patch by Elliott Sprehn <Elliott Sprehn> on 2013-01-15
Reviewed by Eric Seidel.
Source/WebCore:
Generate mutation records inside the parser. This is done by using a
ChildListMutationScope in the ContainerNode::parser* methods and then
adding delivery before each <script> element would be processed by
the parser.
Test: fast/dom/MutationObserver/parser-mutations.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::parserAppendChild):
- html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):
(WebCore::HTMLScriptRunner::runScript):
LayoutTests:
Add tests for parser generated mutations.
XXX: This needs a bunch more tests observing the adoption
agency algorithm to catch parserInsertBefore and parserRemoveChild
mutations.
- fast/dom/MutationObserver/parser-mutations-expected.txt: Added.
- fast/dom/MutationObserver/parser-mutations.html: Added.
- 2:15 PM Changeset in webkit [139789] by
-
- 3 edits2 adds in trunk
Unreviewed, rolling out r139782.
http://trac.webkit.org/changeset/139782
https://bugs.webkit.org/show_bug.cgi?id=106939
Source/WebCore:
Broke preferred widths on list markers.
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
LayoutTests:
- fast/lists/marker-preferred-margins-expected.txt: Added.
- fast/lists/marker-preferred-margins.html: Added.
Adding a new test to cover the case that broke.
- 2:14 PM Changeset in webkit [139788] by
-
- 3 edits2 adds in trunk
Heap-use-after-free in WebCore::RenderObject::willBeRemovedFromTree
https://bugs.webkit.org/show_bug.cgi?id=106384
Reviewed by Abhishek Arya.
Source/WebCore:
Always walk up from beforeChild until the parent() is the owner of the
child list, otherwise we can end up in situations where
newChild->parent() == owner but newChild->nextSibling()->parent() != owner
which is a recipe for security bugs. Previously we only walked up through
anonymous blocks, but missed anonymous inline blocks like those generated
by <ruby>.
Test: fast/css-generated-content/bug-106384.html
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::insertChildNode):
LayoutTests:
Add a test for <ruby> and generated content causing asserts and
crashes.
- fast/css-generated-content/bug-106384-expected.txt: Added.
- fast/css-generated-content/bug-106384.html: Added.
- 2:04 PM Changeset in webkit [139787] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Don't overwrite field dir with current locale.
https://bugs.webkit.org/show_bug.cgi?id=106932
Reviewed by Yong Li.
PR 212267.
Remove uncalled onInputLocaleChanged and stop re-writing the dir
on input focus which prevented RTL fields from rendering properly.
Reviewed Internally by Eli Fidler.
- Api/WebPage.cpp:
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- WebKitSupport/InputHandler.cpp:
- WebKitSupport/InputHandler.h:
(InputHandler):
- 2:03 PM Changeset in webkit [139786] by
-
- 3 edits in trunk/Tools
Tests with WontFix expectation are (indirectly) skipped
https://bugs.webkit.org/show_bug.cgi?id=105860
Reviewed by Dirk Pranke.
Only skip the WontFix expectation if there are no other layout test
expectations (like Failure, ImageOnlyFailure) listed for the test.
This makes it possible to run an expected failure for which there
is no reason or interest to fix. There are some ports that would like
to exercise this behavior as well as specific test cases that should use
such expectations.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
WONTFIX test if there are no expectations listed. The warning is adjusted
to reflect the new behavior.
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
and adjust test cases for these changes.
(ExpectationSyntaxTests.test_wontfix):
(SemanticTests.test_skip_and_wontfix):
- 2:01 PM Changeset in webkit [139785] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining after r139767 and r139768.
- platform/gtk/fast/dom/Window/window-properties-performance-expected.txt:
- platform/gtk/fast/media/w3c/test_media_queries-expected.txt:
- 1:49 PM Changeset in webkit [139784] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
BUILD FIX: Add SUPPORTED_PLATFORMS to Base.xcconfig
- Configurations/Base.xcconfig: Add SUPPORTED_PLATFORMS so that
Xcode knows we can build this project for all three platforms.
Previously the Mac OS X SDKs were missing in the scheme picker.
- 1:43 PM Changeset in webkit [139783] by
-
- 2 edits in trunk/Source/WebCore
Remove bogus assert added in http://trac.webkit.org/changeset/139772.
- rendering/RenderBox.h:
(WebCore::RenderBox::computePreferredLogicalWidths):
- 1:41 PM Changeset in webkit [139782] by
-
- 2 edits in trunk/Source/WebCore
Moving updating of margins from computePreferredLogicalWidths to layout
https://bugs.webkit.org/show_bug.cgi?id=106939
Reviewed by Levi Weintraub.
The margins don't affect it's preferred width. We should update them
during layout like we do in other classes (e.g. RenderBlock).
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
- 1:40 PM Changeset in webkit [139781] by
-
- 2 edits in trunk/Source/WebKit2
[CoordinatedGraphics] Deadlock when running abspos-child-container-changes-from-relative-to-static.html
https://bugs.webkit.org/show_bug.cgi?id=106884
Reviewed by Benjamin Poulain.
We need to return false if m_waitingForUIProcess is true since otherwise
we'll not really repaint in performScheduledLayerFlush() and the
UI process will wait forever. Returning false leads to executing the layer flush
synchronously and immediately, then acknowledging the
callback to the WebProcess - which resolves the deadlock.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::forceRepaintAsync): Return false in order to trigger a synchronous repaint if m_waitingForUIProcess is true.
- 1:35 PM Changeset in webkit [139780] by
-
- 10 edits1 add in trunk/Source
Generalize DocumentWeakReference into WTF::WeakPtr
https://bugs.webkit.org/show_bug.cgi?id=106854
Reviewed by Darin Adler.
Source/WebCore:
This patch replaces DocumentWeakReference with WeakPtr. There should be
no change in behavior.
- dom/Document.cpp:
(WebCore):
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::PerformTaskContext::PerformTaskContext):
(PerformTaskContext):
(WebCore::Document::didReceiveTask):
(WebCore::Document::postTask):
(WebCore::Document::reportMemoryUsage):
- dom/Document.h:
(WebCore):
(Document):
Source/WTF:
This patch adds a simple WeakPtr object to WTF. To use WeakPtr, objects
must hold a WeakPtrFactory member variable, which clears the WeakPtrs
when the object is destructed. The underlying storage is a
ThreadSafeRefCounted "WeakReference" object, which is shared by all the
WeakPtrs.
WeakPtr is a generalization of DocumentWeakReference, which is used to
check whether the Document object is alive when tasks arive on the main
thread from worker threads. We plan to use a similar pattern in the
threaded HTML parser, but we want to send tasks to objects other than
Document.
- GNUmakefile.list.am:
- WTF.gypi:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/WeakPtr.h: Added.
(WeakReference):
- The ThreadSafeRefCounted object shared by all the WeakPtr instances. This patch uses ThreadSafeRefCounted so that we can use WeakPtrs to cancel cross-thread messages.
(WTF::WeakReference::create):
(WTF::WeakReference::get):
(WTF::WeakReference::clear):
- When the object is destroyed, WeakPtrFactory calls this function to clear all the WeakPtrs.
(WTF::WeakReference::WeakReference):
(WTF::WeakPtr::WeakPtr):
(WTF::WeakPtr::get):
- We might want to add implicit conversions and Boolean operators in the future, but I've kept this class simple for now.
(WTF::WeakPtrFactory::WeakPtrFactory):
(WTF::WeakPtrFactory::~WeakPtrFactory):
(WTF::WeakPtrFactory::createWeakPtr):
- 1:34 PM Changeset in webkit [139779] by
-
- 8 edits in trunk/Tools
[chromium] add title text direction attribute to TestRunner
https://bugs.webkit.org/show_bug.cgi?id=106907
Reviewed by Adam Barth.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
- DumpRenderTree/chromium/DRTTestRunner.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::setTitleTextDirection):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setTitleTextDirection):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::didReceiveTitle):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didReceiveTitle):
- 1:04 PM Changeset in webkit [139778] by
-
- 3 edits in trunk/Tools
nrwt: change the default # of locked shards on chromium_win to 1
https://bugs.webkit.org/show_bug.cgi?id=106938
Reviewed by Eric Seidel.
It looks like LigHTTPd might be buggy or unstable if we are
running multiple http tests in parallel; see
http://code.google.com/p/chromium/issues/detail?id=169530 for more
context as well. This change will stop running http tests in parallel
and we can see if this fixes things.
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort.default_max_locked_shards):
- Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_path_to_image_diff):
(ChromiumWinTest):
(ChromiumWinTest.test_default_max_locked_shards):
- 12:57 PM Changeset in webkit [139777] by
-
- 5 edits in trunk
[User Timing] INVALID_ACCESS_ERR should be thrown if measuring from a 0 Nav Timing value
https://bugs.webkit.org/show_bug.cgi?id=106935
Reviewed by Tony Gentilcore.
Source/WebCore:
Test: http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception.html
- page/PerformanceUserTiming.cpp:
(WebCore::UserTiming::findExistingMarkStartTime):
LayoutTests:
- http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception-expected.txt:
- http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception.html:
- 12:49 PM Changeset in webkit [139776] by
-
- 8 edits in trunk/Tools
[chromium] move WebDatabase related methods to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106905
Reviewed by Adam Barth.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::clearAllDatabases):
(WebTestRunner::WebTestDelegate::setDatabaseQuota):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::clearAllDatabases):
(WebTestRunner):
(WebTestRunner::TestRunner::setDatabaseQuota):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::clearAllDatabases):
(WebViewHost::setDatabaseQuota):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 12:47 PM Changeset in webkit [139775] by
-
- 5 edits in trunk/Source/WebCore
MediaStream API: Rename the [add|remove]Track callbacks to [add|remove]RemoteTrack for clarity
https://bugs.webkit.org/show_bug.cgi?id=106791
Reviewed by Adam Barth.
No tests needed.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::addRemoteTrack):
(WebCore::MediaStream::removeRemoteTrack):
- Modules/mediastream/MediaStream.h:
- platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::addMediaStreamTrack):
(WebCore::MediaStreamCenter::removeMediaStreamTrack):
- platform/mediastream/MediaStreamDescriptor.h:
(MediaStreamDescriptorClient):
- 12:46 PM Changeset in webkit [139774] by
-
- 4 edits2 moves in trunk/Source
[Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=106899
Reviewed by Adam Barth.
Part of a larger refactoring series; see tracking bug 106829.
Source/WebCore:
- WebCore.gypi:
- platform/network/chromium/SocketStreamHandle.cpp: Copied from Source/WebKit/chromium/src/SocketStreamHandle.cpp.
(WebCore::SocketStreamHandleInternal::send):
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didSendData):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):
- platform/network/chromium/SocketStreamHandleInternal.h: Copied from Source/WebKit/chromium/src/SocketStreamHandleInternal.h.
Source/WebKit/chromium:
- WebKit.gyp:
- src/SocketStreamHandle.cpp: Removed.
- src/SocketStreamHandleInternal.h: Removed.
- 12:44 PM Changeset in webkit [139773] by
-
- 3 edits in trunk/Source/WebCore
RenderText::computePreferredLogicalWidths does not need to be public
https://bugs.webkit.org/show_bug.cgi?id=106934
Reviewed by Levi Weintraub.
- rendering/RenderCounter.h:
Add OVERRIDE keyword.
- rendering/RenderText.h:
Make protected.
- 12:39 PM Changeset in webkit [139772] by
-
- 5 edits in trunk/Source/WebCore
Cleanup visibility of some computePreferredLogicalWidths calls
https://bugs.webkit.org/show_bug.cgi?id=106933
Reviewed by Levi Weintraub.
No need for these to be public.
- rendering/RenderBox.h:
(WebCore::RenderBox::computePreferredLogicalWidths):
This should never get called in practice. Add an assert to that effect.
- rendering/RenderGrid.h:
(RenderGrid):
- rendering/RenderReplica.h:
(RenderReplica):
- rendering/RenderScrollbarPart.h:
(RenderScrollbarPart):
- 12:03 PM Changeset in webkit [139771] by
-
- 5 edits1 copy1 move in trunk/Tools
Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
functionality match the name.
https://bugs.webkit.org/show_bug.cgi?id=106870
Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-15
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/commands/download.py:
(Clean):
(Update):
(Build):
(BuildAndTest):
(CheckStyle):
(BuildAttachment):
(BuildAndTestAttachment):
(AbstractPatchApplyingCommand):
(ApplyWatchList):
(AbstractPatchLandingCommand):
(CreateRollout):
- Scripts/webkitpy/tool/steps/init.py:
- Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
(CleanWorkingDirectory.options):
(CleanWorkingDirectory.run):
- Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
- Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
- Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
- 12:02 PM Changeset in webkit [139770] by
-
- 17 edits in trunk
[CSS Filters] brightness() function doesn't work as specified
https://bugs.webkit.org/show_bug.cgi?id=106674
Source/WebCore:
Reviewed by Dean Jackson.
The brightness filter implementation modified the intercept instead of the slope on
the feComponentTransfer function. The passed amount acts as multiplier for each
color chanel now.
Existing tests cover the changes and were updated.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseBuiltinFilterArguments):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setFilters):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
LayoutTests:
Negative brightness values are possible but are meaningless. Modify the tests
to mainly use positive amounts for brightness tests.
Reviewed by Dean Jackson.
- css3/filters/effect-brightness-clamping-hw.html:
- css3/filters/effect-brightness-hw.html:
- css3/filters/effect-combined-hw.html:
- css3/filters/effect-combined.html:
- css3/filters/multiple-filters-invalidation.html:
- css3/filters/null-effect-check.html:
- css3/filters/script-tests/filter-property-parsing-invalid.js:
- css3/filters/script-tests/filter-property-parsing.js:
- 11:49 AM Changeset in webkit [139769] by
-
- 9 edits in trunk
[Autotools] Add support for WebKit2-only builds
https://bugs.webkit.org/show_bug.cgi?id=106889
Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-01-15
Reviewed by Gustavo Noronha Silva.
.:
- GNUmakefile.am: Only copy the WebKit1 documentation into the destination
directory if building WebKit1.
- configure.ac: Add a configuration option for disabling the WebKit1 build.
Only conditionally copy WebKit1-specific targets from the input files. Some
small style changes to the WebKit2 configuration flag included as well.
Source/WebKit/gtk:
- GNUmakefile.am: Only build the WebKit1-specific targets if actually
building WebKit1. This puts the libwebkitgtk library, the pkg-config file
and the WebKit1-specific unit tests under the ENABLE_WEBKIT1 Automake
conditional.
Tools:
- GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
- Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
building the GTK port through build-webkit.
- Scripts/webkitdirs.pm:
(buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
arguments when not building WebKit1.
(buildGtkProject): Pass along the information on whether to build WebKit1 when building
through the Autotools build system.
- 11:47 AM Changeset in webkit [139768] by
-
- 8 edits1 add in trunk
[GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
https://bugs.webkit.org/show_bug.cgi?id=106197
Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-01-15
Reviewed by Martin Robinson.
Source/WebCore:
No new tests - existing layout tests are being unskipped, only a few fail
(but their failures are of cross-platform nature).
- GNUmakefile.features.am.in: Add feature defines for all three features.
They are disabled by default for now.
- GNUmakefile.list.am: Add missing build targets.
- bindings/gobject/GNUmakefile.am: Ditto.
- bindings/js/JSPerformanceEntryCustom.cpp: Added the necessary custom bindings.
Mimics the custom V8 bindings.
(WebCore):
(WebCore::toJS):
Tools:
- Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
features. Enable them on GTK, meaning they will be enabled in development builds
(i.e. when building with build-webkit).
LayoutTests:
Unskip related tests, add a few expectations for still-failing tests.
- platform/gtk/TestExpectations:
- 11:46 AM Changeset in webkit [139767] by
-
- 4 edits in trunk
[GTK] Enable CSS Image Resolution feature
https://bugs.webkit.org/show_bug.cgi?id=99038
Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-01-15
Reviewed by Gustavo Noronha Silva.
Tools:
Enable the CSS Image Resolution feature for the development
builds of the GTK port.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Remove the failure expectation for the fast/css/image-resolution directory,
the single layout test inside it now passes.
- platform/gtk/TestExpectations:
- 11:42 AM Changeset in webkit [139766] by
-
- 2 edits in trunk/Tools
[GTK] Stop passing the unstable features flag to configure script when using build-webkit
https://bugs.webkit.org/show_bug.cgi?id=106579
Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-01-15
Reviewed by Gustavo Noronha Silva.
The --enable-unstable-features flag is not required to be passed anymore
to the configure script as it was removed in r138252.
- Scripts/webkitdirs.pm:
(buildAutotoolsProject):
- 11:41 AM Changeset in webkit [139765] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Autotools] Unify JavaScriptCore sources list, regardless of target OS
https://bugs.webkit.org/show_bug.cgi?id=106007
Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-01-15
Reviewed by Gustavo Noronha Silva.
Include the Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp target
in the general sources list as it is guarded by the ENABLE_EXECUTABLE_ALLOCATOR_FIXED
feature define. This define is only used on 64-bit architecture and indirectly depends
on enabling either JIT or YARR JIT feature. Both of these defines are disabled on
Windows OS when using 64-bit architecture so there's no need to add this target to
sources only when the target OS is Windows.
- GNUmakefile.list.am:
- 11:35 AM Changeset in webkit [139764] by
-
- 3 edits in trunk/Tools
[chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
- Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
- Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
(TestHttpServer.test_win32_start_and_stop):
- 11:25 AM Changeset in webkit [139763] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Remove a few failure expectations for tests that now pass.
- platform/gtk/TestExpectations:
- 11:17 AM Changeset in webkit [139762] by
-
- 8 edits4 adds in trunk
Unprefixed transitionend event doesn't seem to be implemented, which breaks many sites
https://bugs.webkit.org/show_bug.cgi?id=105647
Reviewed by Julien Chaffraix.
Source/WebCore:
Add support for transitionend event delivery as part as the unprefixing
work on CSS Transitions. This patch adds some code in EventTarget to
figure out if the current event to dispatch has a prefixed version or
not. Then from the list of listeners we deduce which event should be delivered
(prefixed or unprefixed).
In the case of the CSS Transitions, WebKit will now behave as follow :
if an event listener is attached to the prefixed version of the
transition end event then only the prefixed event will be send.
If an event listener is attached to the unprefixed version
of the transition end event then only the unprefixed event will be
send. If there are event listeners on both unprefixed and prefixed
events then only the unprefixed event will be send.
The behavior was discussed here :
http://lists.webkit.org/pipermail/webkit-dev/2013-January/023301.html.
Tests: transitions/transition-end-event-unprefixed-01.html
transitions/transition-end-event-unprefixed-02.html
- dom/Document.cpp:
(WebCore::Document::addListenerTypeIfNeeded): Register the prefixed
listener too as transitionend listeners so that we properly dispatch
events for them.
- dom/EventNames.h:
(WebCore): Add the new transitionend name.
- dom/EventTarget.cpp:
(WebCore::createMatchingPrefixedEvent):
(WebCore::prefixedType):
(WebCore::EventTarget::fireEventListeners): Find out if somebody is
listening for unprefixed events, if so we always send the unprefixed
event, if not then we create a prefixed event and send it.
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::sendTransitionEvent): Always create by
default unprefixed events.
LayoutTests:
Cover that event delivery is correct : we received unprefixed events.
- transitions/transition-end-event-helpers.js:
(recordTransitionEndEvent):
- transitions/transition-end-event-unprefixed-01-expected.txt: Added.
- transitions/transition-end-event-unprefixed-01.html: Added.
- transitions/transition-end-event-unprefixed-02-expected.txt: Added.
- transitions/transition-end-event-unprefixed-02.html: Added.
- 11:17 AM Changeset in webkit [139761] by
-
- 4 edits1 add in trunk/Source/ThirdParty/ANGLE
Upstream iOS changes for ANGLE project
<http://webkit.org/b/106913>
Reviewed by Joseph Pecoraro.
- ANGLE.xcodeproj/project.pbxproj:
- Use $(INSTALL_PATH_PREFIX) with CopyFiles build phase paths.
- Add iOS.xcconfig to project.
- Configurations/ANGLE.xcconfig:
- Use INSTALL_PATH_ACTUAL instead of INSTALL_PATH. (See below.)
- Use $(INSTALL_PATH_PREFIX) with PUBLIC_HEADERS_FOLDER_PATH.
- Configurations/Base.xcconfig:
- Include iOS.xcconfig.
- Add per-platform values for GCC_ENABLE_OBJC_GC and GCC_MODEL_TUNING.
- Define INSTALL_PATH when building for macosx SDK.
- Configurations/iOS.xcconfig: Add. Note that missing include
files are simply ignored without an error by Xcode.
- 11:06 AM Changeset in webkit [139760] by
-
- 4 edits in trunk/Source/WebCore
Make AtomicMarkupTokenBase use a bare UChar* for external characters
https://bugs.webkit.org/show_bug.cgi?id=106919
Reviewed by Eric Seidel.
This allows an arbitrary backing for external characters which is necessary for the threaded HTML parser.
No new tests because no new functionality.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):
- xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::characters):
(AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::charactersLength):
(WebCore::AtomicMarkupTokenBase::clearExternalCharacters):
- xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processCharacter):
- 11:00 AM Changeset in webkit [139759] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Manual zoom propagates to next page load
https://bugs.webkit.org/show_bug.cgi?id=106914
Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Yong Li.
Internally reviewed by Eli Fidler and Jakob Petsovits.
PR: 280481
During load committed, the web page scale was reset. However, UI thread
still kept the old scale in UserInterfaceViewportAccessor so that it
blitted the contents at the old scale although WebKit thread could
update the UI thread scale later when finished the load.
We should update the scale of the UI thread right after we reset it in
WebKit thread to keep them in sync.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::resetScales):
- 10:56 AM Changeset in webkit [139758] by
-
- 12 edits in trunk/Source/ThirdParty/ANGLE
ANGLE should build with -Wshorten-64-to-32
<http://webkit.org/b/106798>
<http://code.google.com/p/angleproject/issues/detail?id=396>
Reviewed by Kenneth Russell.
Most changes below are simply to document issues with #pragma
statements per request by upstream. The change to osinclude.h
is the only bug fix, which defines OS_TLSIndex in terms of
pthread_key_t instead of unsigned int since pthread_key_t is a
64-bit value on 64-bit Mac OS X.
- Configurations/Base.xcconfig: Enable -Wshorten-64-to-32 by
setting GCC_WARN_64_TO_32_BIT_CONVERSION to YES.
- src/compiler/Intermediate.cpp:
(TIntermTraverser::hash): Add #pragmas for clang to ignore
-Wshorten-64-to-32 warning.
- src/compiler/MapLongVariableNames.cpp:
(LongNameMap::Size): Ditto.
- src/compiler/ShaderLang.cpp:
(getVariableInfo): Ditto.
(ShGetInfo): Ditto.
- src/compiler/ValidateLimitations.cpp:
(ValidateLimitations::validateFunctionCall): Ditto.
- src/compiler/glslang.l: Ditto.
- src/compiler/glslang_lex.cpp: Ditto.
- src/compiler/osinclude.h: Change type of OS_TLSIndex to
pthread_key_t. Define OS_INVALID_TLS_INDEX by using
static_cast<OS_TLSIndex>(-1).
- src/compiler/preprocessor/Input.cpp:
(pp::Input::Input): Add #pragmas for clang to ignore
-Wshorten-64-to-32 warning.
- src/compiler/preprocessor/Tokenizer.cpp: Ditto.
- src/compiler/preprocessor/Tokenizer.l: Ditto.
- 10:54 AM Changeset in webkit [139757] by
-
- 2 edits3 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure/crash/missing expectations for accessibility tests after
r139444, r139534 and r139663.
Adding platform-specific baselines for two scrolling coordinator tests that are
required after r139686.
- platform/gtk/TestExpectations:
- platform/gtk/scrollingcoordinator: Added.
- platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
- platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
- 10:49 AM Changeset in webkit [139756] by
-
- 3 edits2 adds in trunk
Microdata: propertiesCollection[name] should return undefined if item doesn't have a property named 'name'
https://bugs.webkit.org/show_bug.cgi?id=106849
Reviewed by Kentaro Hara.
Source/WebCore:
We should return undefined if hasNamedItem() is false.
Test: fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::namedPropertyGetter):
LayoutTests:
- fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name-expected.txt: Added.
- fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html: Added.
- 10:34 AM Changeset in webkit [139755] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Fix build after r139665
https://bugs.webkit.org/show_bug.cgi?id=106917
Patch by Michael Pruett <michael@68k.org> on 2013-01-15
Reviewed by Dean Jackson.
- GNUmakefile.list.am:
- 10:26 AM Changeset in webkit [139754] by
-
- 4 edits in branches/chromium/1364/Source/WebCore
Merge 139691
Sometimes RenderLayer::updateNeedsCompositedScrolling is not called
https://bugs.webkit.org/show_bug.cgi?id=106271
Reviewed by Simon Fraser.
Source/WebCore:
- If a layer has no out-of-flow descendant, m_hasOutOfFlowPositionedDescendant won't change and won't trigger updateNeedsCompositedScrolling in updateDescendantDependentFlags. Set m_hasOutOfFlowPositionedDescendantDirty to true and call updateNeedsCompositedScrolling when the dirty flag becomes false from true.
- When the content size changes causing change of scrollable status, updateNeedsCompositedScrolling should also be called.
Test: compositing/overflow/dynamic-composited-scrolling-status.html
- page/FrameView.cpp:
(WebCore::FrameView::addScrollableArea): Returns whether the scrollable area has just been newly added.
(WebCore::FrameView::removeScrollableArea): Returns whether the scrollable area has just been removed.
- page/FrameView.h:
(FrameView):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer): Changed the initial value of m_hasOutOfFlowPositionedDescendantDirty to true to make sure m_hasOutOfFlowPositionedDescendant will be updated initially.
(WebCore::RenderLayer::updateDescendantDependentFlags): Call updateNeedsCompositedScrolling when m_hasOutOfFlowPositionedDescendantDirty is true.
(RenderLayer::updateScrollableAreaSet): Calls updateNeedsCompositedScrolling() when scrollable status changes.
- rendering/RenderLayer.h:
(RenderLayer):
LayoutTests:
- compositing/overflow/dynamic-composited-scrolling-status-expected.txt: Added.
- compositing/overflow/dynamic-composited-scrolling-status.html: Added.
- 10:22 AM Changeset in webkit [139753] by
-
- 4 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=106855
https://bugs.webkit.org/show_bug.cgi?id=106855
Reviewed by Levi Weintraub.
Speed up zoomed-offset-size.html test and remove SLOW modifier
from TestExpectations.
- fast/images/zoomed-offset-size-expected.txt:
- fast/images/zoomed-offset-size.html:
- platform/chromium/TestExpectations:
- 10:15 AM Changeset in webkit [139752] by
-
- 5 edits in branches/chromium/1364/Source
Merge 139026
Add a flag to control canvas antialiasing.
https://bugs.webkit.org/show_bug.cgi?id=106255
Reviewed by Darin Fisher.
Source/WebCore:
This flag is not exposed through TestRunner or DRT, so no testing is
possible yet.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
- page/Settings.in:
Source/WebKit/chromium:
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAntialiased2dCanvasEnabled):
- src/WebSettingsImpl.h:
- 10:11 AM Changeset in webkit [139751] by
-
- 7 edits in trunk/Source/WebCore
Move parent pointer from TreeShared to subclass
https://bugs.webkit.org/show_bug.cgi?id=106910
Reviewed by Darin Adler.
This simplifies both TreeShared and clients, and makes code dealing with parents more understandable in general.
- dom/Document.h:
(WebCore::Node::Node):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- dom/Node.h:
Add m_parentOrHostNode variable (matching the accessor names).
(Node):
(WebCore::Node::hasTreeSharedParent):
(WebCore::Node::parentNode):
(WebCore::Node::setParentOrHostNode):
(WebCore::Node::parentOrHostNode):
- platform/TreeShared.h:
(WebCore):
(WebCore::TreeShared::TreeShared):
(WebCore::TreeShared::deref):
Call subclass hasTreeSharedParent() to figure out if it is time to delete.
(TreeShared):
Remove parent pointer and accessors.
Remove ParentNodeType template parameter.
Remove now unnecessay reportMemoryUsage().
(WebCore::adopted):
- svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::SVGElementInstance):
- svg/SVGElementInstance.h:
Add m_parentInstance variable.
(WebCore::SVGElementInstance::setParentOrHostNode):
(WebCore::SVGElementInstance::parentNode):
(SVGElementInstance):
(WebCore::SVGElementInstance::hasTreeSharedParent):
- 10:10 AM Changeset in webkit [139750] by
-
- 7 edits in trunk/Source
Allow tiled WKViews to have transparent backgrounds
https://bugs.webkit.org/show_bug.cgi?id=106400
Source/WebCore:
Reviewed by Anders Carlsson.
When WKViews were set to have transparent backgrounds, they still
obscured content behind the view, for several reasons.
First, when in tiled scrolling mode, WKView set the background
of its layer to opaque white. Fix by using the clearColor (effectively
removing the background color) if the view has a non-opaque background.
Second, RenderLayerBacking just looked at FrameViews's isTransparent()
when deciding to make TileCache tiles non-opaque, but it also needs to
consider FrameViews with a non-opaque base background color. The
same logic was necessary to avoid setting an opaque white background
color on the TileCache layer.
Finally, for views with non-opaque backgrounds, we don't want to display
linen, so RenderLayerCompositor::requiresOverhangAreasLayer() was changed
to return false in that case.
View transparency is not testable in layout tests.
- page/FrameView.cpp:
(WebCore::FrameView::hasOpaqueBackground):
- page/FrameView.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::updateBackgroundColor):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):
Source/WebKit2:
Reviewed by Anders Carlsson.
When WKViews were set to have transparent backgrounds, they still
obscured content behind the view, for several reasons.
First, when in tiled scrolling mode, WKView set the background
of its layer to opaque white. Fix by using the clearColor (effectively
removing the background color) if the view has a non-opaque background.
Second, RenderLayerBacking just looked at FrameViews's isTransparent()
when deciding to make TileCache tiles non-opaque, but it also needs to
consider FrameViews with a non-opaque base background color. The
same logic was necessary to avoid setting an opaque white background
color on the TileCache layer.
Finally, for views with non-opaque backgrounds, we don't want to display
linen, so RenderLayerCompositor::requiresOverhangAreasLayer() was changed
to return false in that case.
- UIProcess/API/mac/WKView.mm:
(-[WKView updateLayer]):
- 9:54 AM Changeset in webkit [139749] by
-
- 4 edits in trunk/Source/WebCore
RenderView does not need to override computePreferredLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=106852
Reviewed by Levi Weintraub.
Calling minPreferredLogicalWidth calls computePreferredLogicalWidth,
which happens a few lines later in layoutWithFlattening. No need
to call it explicitly.
- rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening):
- rendering/RenderView.cpp:
- rendering/RenderView.h:
- 9:50 AM Changeset in webkit [139748] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Marking the deferred version of
fast/images/zoomed-offset-size.html as slow.
- platform/chromium/TestExpectations:
- 9:24 AM Changeset in webkit [139747] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding Michael Pruett as contributor.
- Scripts/webkitpy/common/config/committers.py:
- 9:13 AM Changeset in webkit [139746] by
-
- 1 edit1 delete in trunk/Source/WebCore
Unreviewed, remove file that was accidentally added to the wrong patch.
- inspector/front-end/FileSystemWorkspaceProvider.js: Removed.
- 8:57 AM Changeset in webkit [139745] by
-
- 6 edits3 adds in trunk
[Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect
https://bugs.webkit.org/show_bug.cgi?id=106898
Reviewed by Stephen White.
Source/WebCore:
Since drawRRect() doesn't cover the whole bounding rect, it needs to pass a didDrawBounded
notification down to the opaque region tracker (instead of didDrawRect as it currently
does).
Test: platform/chromium/compositing/rounded-corners.html
- platform/graphics/skia/PlatformContextSkia.h:
(WebCore::PlatformContextSkia::drawRRect):
Source/WebKit/chromium:
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
(WebCore):
LayoutTests:
- platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.png: Added.
- platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt: Added.
- platform/chromium/TestExpectations:
- platform/chromium/compositing/rounded-corners.html: Added.
- 8:35 AM Changeset in webkit [139744] by
-
- 2 edits in trunk/Tools
Unreviewed. Update my email addresses.
- Scripts/webkitpy/common/config/committers.py:
- 8:03 AM Changeset in webkit [139743] by
-
- 2 edits in trunk/Tools
[GTK] Waiting on the gdb process will lead to deadlock
https://bugs.webkit.org/show_bug.cgi?id=106906
Reviewed by Philippe Normand.
Use communicate() rather than wait() on the Popen object that's running the gdb
command. This avoids the deadlock that occurs on the GTK builders.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._get_gdb_output):
- 8:01 AM Changeset in webkit [139742] by
-
- 2 edits in trunk/Source/WebCore
[Qt] WebGL does not require accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=106892
Reviewed by Jocelyn Turcotte.
Allow the creation of WebGL canvas even when accelerated compositing is not enabled.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
- 7:57 AM Changeset in webkit [139741] by
-
- 2 edits in trunk/LayoutTests
Unreviewed failing test skip.
https://bugs.webkit.org/show_bug.cgi?id=106883
- platform/efl/TestExpectations:
- 7:50 AM Changeset in webkit [139740] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: refactor DefaultTextEditor's paintLine method
https://bugs.webkit.org/show_bug.cgi?id=106893
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-15
Reviewed by Pavel Feldman.
Move render ranges functionality out of paintLine method into separate subroutine.
No new tests: no change in behaviour.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._renderRanges): Added.
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
- 7:43 AM BuildingGtk edited by
- Add libopus-dev in the dependencies list, it will be needed after … (diff)
- 7:42 AM Changeset in webkit [139739] by
-
- 3 edits2 adds in trunk
display:inline's hover behavior is not applied to ::before and ::after pseudo elements
https://bugs.webkit.org/show_bug.cgi?id=91723
Patch by Elliott Sprehn <Elliott Sprehn> on 2013-01-15
Reviewed by Eric Seidel.
Source/WebCore:
When hovering over the anonymous text renderers inside :before and :after
we would correctly detect a hit in InlineTextBox::nodeAtPoint, but would
then fail to set the correct node for the hit test because in
RenderObject::updateHitTestResult node() is null. Instead we should walk
up the render tree to the PseudoElement and treat it as if we hit that.
Test: fast/css-generated-content/hover-inline.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::updateHitTestResult):
LayoutTests:
Add a test that hovering generated content inside an inline element causes
the element to become hovered.
- fast/css-generated-content/hover-inline-expected.txt: Added.
- fast/css-generated-content/hover-inline.html: Added.
- 7:41 AM Changeset in webkit [139738] by
-
- 4 edits in trunk/Source/WebCore
GraphicsSurface: Canvas with WebGL content is painted off by one pixel
https://bugs.webkit.org/show_bug.cgi?id=106446
When painting to TextureMapper the provided targetRect is in contents
coordinate system. This leads to an off by one pixel error when painting
outlines of 1px.
This needs to be taken into account in the transformation matrix
and in the TextureMapperGL::drawTexture call.
Test: fast/canvas/webgl/webgl-composite-modes.html
Reviewed by Noam Rosenthal.
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
- platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
- platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
- 7:12 AM Changeset in webkit [139737] by
-
- 3 edits in trunk/LayoutTests
[Chromium] media/track/track-css-cue-lifetime.html Win7 dbg times out since r139562
https://bugs.webkit.org/show_bug.cgi?id=106853
Patch by Dima Gorbik <dgorbik@apple.com> on 2013-01-15
Reviewed by Eric Carlson.
The amount of seeks may be reduced significantly since they may be slow.
- media/track/track-css-cue-lifetime-expected.txt:
- media/track/track-css-cue-lifetime.html:
- 7:10 AM Changeset in webkit [139736] by
-
- 2 edits in trunk/Tools
[GTK] Limit the number of frames printed out when backtracing with gdb
https://bugs.webkit.org/show_bug.cgi?id=106901
Reviewed by Philippe Normand.
Printing an unlimited number of frames when dumping the gdb backtracing
output can cause timeouts in the builders. This patch limits the number
of frames that are printed out to 1024.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._get_gdb_output):
- 5:49 AM Changeset in webkit [139735] by
-
- 3 edits in trunk/Source/WebCore
[V8] Make an Isolate parameter mandatory in SerializedScriptValue methods
https://bugs.webkit.org/show_bug.cgi?id=106800
Reviewed by Adam Barth.
SerializedScriptValue methods are used by both V8 bindings
and WebCore. So they should support both an Isolate-version
method and an non-Isolate version method.
There are two ways to accomplish that:
[1] Use an optional Isolate parameter.
[2] Implement two versions and delegate the non-Isolate
version method to the Isolate version method.
I would prefer the approach [2], because I'd like to statically
make sure that we never pass a 0 Isolate. If we take the approach
[1], we need to insert ASSERT(isolate) here and there.
This patch implements the approach [2].
No tests. No change in behavior.
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
(WebCore):
(WebCore::SerializedScriptValue::nullValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::SerializedScriptValue):
- bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):
- 5:31 AM Changeset in webkit [139734] by
-
- 6 edits in trunk/Source/WebCore
[CSS] Rename the enum, from "ETextAlignLast" to "TextAlignLast"
https://bugs.webkit.org/show_bug.cgi?id=106887
Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2013-01-15
Reviewed by Alexis Menard.
No new tests are added since there is no behavior changes.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextAlignLast):
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
- 3:29 AM Changeset in webkit [139733] by
-
- 1 edit in branches/chromium/1312/Source/WebCore/inspector/InspectorOverlayPage.html
Merge 135732
Not reviewed: follow up for r135720, fixing node highlight.
- inspector/InspectorOverlayPage.html:
TBR=pfeldman@chromium.org
BUG=169722
Review URL: https://codereview.chromium.org/11881050
- 2:45 AM Changeset in webkit [139732] by
-
- 4 edits in trunk
MediaStream API: Fixing crashing bug in MediaStream
https://bugs.webkit.org/show_bug.cgi?id=106886
Reviewed by Eric Seidel.
Source/WebCore:
Fixing crashing bug during destruction.
No new tests needed.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::contextDestroyed):
LayoutTests:
Removing obsolete exception.
- platform/chromium/TestExpectations:
- 2:01 AM Changeset in webkit [139731] by
-
- 3 edits in trunk/Source/WebCore
[Qt][CSS Shaders] Make custom filter render in Wk1 mode
https://bugs.webkit.org/show_bug.cgi?id=101532
Reviewed by Noam Rosenthal.
Handle ValidatedCustomFilterOperations which are used by WebKit1. To keep the cache of compiled programs working,
the cache has been updated to use CustomFilterProgramInfo as a hash key. CustomFilterProgramInfo is an existing
class specifically designed for this purpose.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::getPassesRequiredForFilter):
(WebCore::TextureMapperGL::removeCachedCustomFilterProgram):
(WebCore::TextureMapperGL::drawUsingCustomFilter):
(WebCore::BitmapTextureGL::applyFilters):
- platform/graphics/texmap/TextureMapperGL.h:
(TextureMapperGL):
- 1:51 AM Changeset in webkit [139730] by
-
- 2 edits5 adds in trunk/LayoutTests
[Qt] Gardening
Skip failing tests after r139609.
https://bugs.webkit.org/show_bug.cgi?id=104909
Skip failing inspector/editor/text-editor-formatter.html test.
https://bugs.webkit.org/show_bug.cgi?id=106883
Patch by Szilard Ledan <Szilárd LEDÁN> on 2013-01-15
Reviewed by Csaba Osztrogonác.
- platform/qt/TestExpectations:
- platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added after r139686.
- platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added after r139686.
- platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added after r139686.
- platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added after r139686.
- 1:46 AM Changeset in webkit [139729] by
-
- 6 edits in trunk
Web Inspector: [Canvas] introduce CallArgument type into the protocol
https://bugs.webkit.org/show_bug.cgi?id=106640
Reviewed by Yury Semikhatsky.
Source/WebCore:
CallArgument type abstraction to describe arguments of a canvas context call.
Drive-by: Introduce a CanvasContext to fix the wrong contextId value in the protocol.
The contextId should point to the Resource that represents a context (2D or 3D canvas).
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
- inspector/Inspector.json:
- inspector/front-end/CanvasProfileView.js:
LayoutTests:
Replaced hacky stub with actual Cache implementation.
- inspector/profiler/webgl/webgl-profiler-get-error.html:
- 1:42 AM Changeset in webkit [139728] by
-
- 2 edits in trunk/PerformanceTests
Allow zero values as results from the runFunction.
https://bugs.webkit.org/show_bug.cgi?id=102500
Reviewed by Kentaro Hara.
DOM/DOMWalk.js fails on the Chromium Win perf bot because one or
more parts of the test usually return zero at some point.
- resources/runner.js: Accept merely non-negative results.
- 1:33 AM Changeset in webkit [139727] by
-
- 2 edits in trunk/Tools
[Qt] Fix ImageDiff's image format conversion
https://bugs.webkit.org/show_bug.cgi?id=106880
Reviewed by Csaba Osztrogonác.
Besides actually doing the conversion this also silences the suspicious warning:
"ignoring return value of function declared with warn_unused_result attribute".
- ImageDiff/qt/ImageDiff.cpp:
(main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
copy of the image in the given format and does not alter the image itself.
- 1:06 AM Changeset in webkit [139726] by
-
- 19 edits3 adds in trunk/Source
Web Inspector: Support inspector file system access with isolated file system through InspectorFrontendHost.
https://bugs.webkit.org/show_bug.cgi?id=105727
Reviewed by Pavel Feldman.
Source/WebCore:
File system access through isolated file system is implemented in inspector.
File system access requests are sent through InspectorFrontendHost.
Introduced IsolatedFileSystemModel encapsulating file system access logic.
Introduced FileSystemMapping that provides mapping between workspace uris and file system pathes.
DOMFileSystem.createIsolatedFileSystem modified to accept optional registeredName parameter.
- Modules/filesystem/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::createIsolatedFileSystem):
- Modules/filesystem/DOMFileSystem.h:
(DOMFileSystem):
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
- inspector/InspectorFrontendClientLocal.h:
(WebCore::InspectorFrontendClientLocal::supportsFileSystems):
(WebCore::InspectorFrontendClientLocal::requestFileSystems):
(WebCore::InspectorFrontendClientLocal::addFileSystem):
(WebCore::InspectorFrontendClientLocal::removeFileSystem):
(InspectorFrontendClientLocal):
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::supportsFileSystems):
(WebCore):
(WebCore::InspectorFrontendHost::requestFileSystems):
(WebCore::InspectorFrontendHost::addFileSystem):
(WebCore::InspectorFrontendHost::removeFileSystem):
(WebCore::InspectorFrontendHost::isolatedFileSystem):
- inspector/InspectorFrontendHost.h:
(WebCore):
(InspectorFrontendHost):
- inspector/InspectorFrontendHost.idl:
- inspector/compile-front-end.py:
- inspector/front-end/FileSystemMapping.js: Added.
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.fileSystemsLoaded):
(InspectorFrontendAPI.fileSystemRemoved):
(InspectorFrontendAPI.fileSystemAdded):
- inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.supportsFileSystems):
(.WebInspector.InspectorFrontendHostStub.prototype.requestFileSystems):
(.WebInspector.InspectorFrontendHostStub.prototype.addFileSystem):
(.WebInspector.InspectorFrontendHostStub.prototype.removeFileSystem):
(.WebInspector.InspectorFrontendHostStub.prototype.isolatedFileSystem):
- inspector/front-end/IsolatedFileSystemModel.js: Added.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/externs.js:
(DOMFileSystem):
(InspectorFrontendHostAPI.prototype.supportsFileSystems):
(InspectorFrontendHostAPI.prototype.requestFileSystems):
(InspectorFrontendHostAPI.prototype.addFileSystem):
(InspectorFrontendHostAPI.prototype.removeFileSystem):
(InspectorFrontendHostAPI.prototype.isolatedFileSystem):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
Source/WebKit/chromium:
File system access methods plumbing made for Chromium.
- public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::requestFileSystems):
(WebKit::WebDevToolsFrontendClient::addFileSystem):
(WebKit::WebDevToolsFrontendClient::removeFileSystem):
(WebDevToolsFrontendClient):
- src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::supportsFileSystems):
(WebKit):
(WebKit::InspectorFrontendClientImpl::requestFileSystems):
(WebKit::InspectorFrontendClientImpl::addFileSystem):
(WebKit::InspectorFrontendClientImpl::removeFileSystem):
- src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):
- 12:56 AM Changeset in webkit [139725] by
-
- 2 edits in trunk/Source/WebCore
[EFL][WebGL] Add error handling to carefully manage Window backing pixmaps.
https://bugs.webkit.org/show_bug.cgi?id=106582
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-01-15
Reviewed by Kenneth Rohde Christiansen.
We use XCompositeNameWindowPixmap to create a pixmap that serves as a reference to
the off-screen storage for a Window Handle. We expect the Window to be valid and
the created glx pixmap to be a valid drawable. This may not be true always.
This patch adds support for X Error checks and handles the generated errors.
Covered by existing WebGL layout tests.
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore):
(WebCore::handleXPixmapCreationError):
(ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::~ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::isValidOperation):
Helper Class to catch XErrors.
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap): Added support to check and handle generated XErrors.
(WebCore::GraphicsSurfacePrivate::findFBConfigWithAlpha):
(WebCore::GraphicsSurfacePrivate::clear): Destroys GL Resources.
(GraphicsSurfacePrivate):
- 12:54 AM Changeset in webkit [139724] by
-
- 5 edits in trunk/Source/WebCore
[EFL] [WebGL] Minor cleanup in PlatformContext.
https://bugs.webkit.org/show_bug.cgi?id=106758
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-01-15
Reviewed by Kenneth Rohde Christiansen.
We currently have different implementations of CurrentContextWrapper for EGL and GLX.
This patch cleans up the code to use same implementation for both the backends.
- platform/graphics/opengl/GLPlatformContext.cpp:
(GLCurrentContextWrapper):
(WebCore::GLCurrentContextWrapper::GLCurrentContextWrapper):
(WebCore::GLCurrentContextWrapper::~GLCurrentContextWrapper):
Common implementation for both EGL and GLX.
(WebCore::createOffScreenContext):
(WebCore::GLPlatformContext::createContext):
- platform/graphics/surfaces/egl/EGLContext.cpp:
- platform/graphics/surfaces/egl/EGLContext.h:
- platform/graphics/surfaces/glx/GLXContext.h:
Removed code related to CurrentContextWrapper.
- 12:30 AM Changeset in webkit [139723] by
-
- 4 edits in trunk/Source/WebCore
platform/mac/accessibility/progressbar.html fails on Mac WK1 and WK2
https://bugs.webkit.org/show_bug.cgi?id=106850
Reviewed by Chris Fleizach.
The bug was caused by some callers of supportsFocus directly calling that of Node.
Fixed the bug by calling HTMLElement's so that the virtual function on Element gets
called as needed.
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::supportsFocus):
- html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::supportsFocus):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::supportsFocus):
- 12:19 AM Changeset in webkit [139722] by
-
- 6 edits in trunk/Tools
[chromium] move remaining methods that just set a boolean flag to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106823
Reviewed by Darin Fisher.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
(WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
(WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
(WebTestRunner::WebTestRunner::testRepaint):
(WebTestRunner::WebTestRunner::sweepHorizontally):
(WebTestRunner::WebTestRunner::isPrinting):
(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpBackForwardList):
(WebTestRunner):
(WebTestRunner::TestRunner::deferMainResourceDataLoad):
(WebTestRunner::TestRunner::shouldDumpSelectionRect):
(WebTestRunner::TestRunner::testRepaint):
(WebTestRunner::TestRunner::sweepHorizontally):
(WebTestRunner::TestRunner::isPrinting):
(WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
(WebTestRunner::TestRunner::dumpBackForwardList):
(WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
(WebTestRunner::TestRunner::dumpSelectionRect):
(WebTestRunner::TestRunner::repaintSweepHorizontally):
(WebTestRunner::TestRunner::setPrinting):
(WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
