⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 20, 2013:

11:59 PM Changeset in webkit [140307] by falken@chromium.org
  • 3 edits
    4 adds in trunk

Elements must be reattached when inserted/removed from top layer
​https://bugs.webkit.org/show_bug.cgi?id=105489

Relanding r139402 as rollout due to suspected perf regression did not help (bug 106726).

Reviewed by Julien Chaffraix.

Source/WebCore:

Ensure a reattach occurs when an element is inserted/removed from top layer, so its renderer can be inserted correctly:
as a child of RenderView in top layer sibling order if it's in the top layer, and in the usual place otherwise.

We previously relied on style recalc to catch when an element is inserted/removed from the top layer, because it
only happens on dialog.show/close which toggle display: none. But that is incorrect because, for example, close()
followed immediately by show() results in no style change.

Tests: fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html

fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html

  • dom/Element.cpp:

(WebCore::Element::removedFrom): Call Document::removeFromTopLayer to let the element be removed from the top layer vector.
removeFromTopLayer calls Element::setIsInTopLayer(false) itself if needed.
(WebCore::Element::setIsInTopLayer): Ensure a reattach occurs if the element is already attached.

LayoutTests:

  • fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html: Added.
  • fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html: Added.

This tests that a top layer element removed from the document does not reappear in the top layer if readded.
This test actually would pass before this patch, but just by good fortune (see bug).

  • fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html: Added.
  • fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html: Added.

This tests that top layer ordering is correct after removing and readding an element to the top layer.

11:50 PM Changeset in webkit [140306] by yurys@chromium.org
  • 6 edits in trunk

Web Inspector: change HeapSnapshotLoader to allow loading native heap snapshots
​https://bugs.webkit.org/show_bug.cgi?id=107282

Reviewed by Pavel Feldman.

Conctete heap snapshot constructor name is passed as a parameter to HeapSnapshotLoaderProxy and
propagated to HeapSnapshotLoader.buildSnapshot to support different types of heap snapshots.

Source/WebCore:

  • inspector/front-end/HeapSnapshotLoader.js:

(WebInspector.HeapSnapshotLoader.prototype.buildSnapshot):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker.prototype.createLoader):
(WebInspector.HeapSnapshotLoaderProxy):
(WebInspector.HeapSnapshotLoaderProxy.prototype.close):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapProfileHeader.prototype._setupWorker):

LayoutTests:

  • inspector/profiler/heap-snapshot-loader.html:
11:45 PM Changeset in webkit [140305] by haraken@chromium.org
  • 16 edits
    2 adds in trunk

Implement MediaStreamEvent constructor
​https://bugs.webkit.org/show_bug.cgi?id=107411

Reviewed by Adam Barth.

Spec: ​http://www.w3.org/TR/webrtc/#mediastreamevent

Test: fast/events/constructors/media-stream-event-constructor.html

Source/WebCore:

  • Modules/mediastream/MediaStreamEvent.cpp:

(WebCore::MediaStreamEventInit::MediaStreamEventInit):
(WebCore):
(WebCore::MediaStreamEvent::create):
(WebCore::MediaStreamEvent::MediaStreamEvent):

  • Modules/mediastream/MediaStreamEvent.h:

(MediaStreamEventInit):
(WebCore):
(MediaStreamEvent):

  • Modules/mediastream/MediaStreamEvent.idl:
  • bindings/js/JSDictionary.cpp:

(WebCore):
(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDictionary.h:

(WebCore):

  • bindings/v8/Dictionary.cpp:

(WebCore):
(WebCore::Dictionary::get):

  • bindings/v8/Dictionary.h:

(Dictionary):

LayoutTests:

  • fast/events/constructors/media-stream-event-constructor-expected.txt: Added.
  • fast/events/constructors/media-stream-event-constructor.html: Added.
  • platform/chromium-android/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
11:38 PM Changeset in webkit [140304] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Allow SplitView to change orientation after the construction.
​https://bugs.webkit.org/show_bug.cgi?id=107263

Added SplitView.prototype.setIsVertical to change the orientation on the fly.
Instead of passing default sidebar size to the constructor the client
may now pass separate defaults for the sidebar width and height. Passing
just one default works as before.

Patch by Vladislav Kaznacheev <​kaznacheev@chromium.org> on 2013-01-20
Reviewed by Pavel Feldman.

No new tests.

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView):
(WebInspector.SplitView.prototype.isVertical):
(WebInspector.SplitView.prototype.setIsVertical):
(WebInspector.SplitView.prototype._innerSetIsVertical):
(WebInspector.SplitView.prototype._updateLayout):
(WebInspector.SplitView.prototype.isSidebarSecond):
(WebInspector.SplitView.prototype.showBoth):
(WebInspector.SplitView.prototype._updateTotalSize):
(WebInspector.SplitView.prototype._innerSetSidebarSize):
(WebInspector.SplitView.prototype.wasShown):
(WebInspector.SplitView.prototype.onResize):
(WebInspector.SplitView.prototype.installResizer):
(WebInspector.SplitView.prototype._onDragStart):
(WebInspector.SplitView.prototype._sizeSetting):
(WebInspector.SplitView.prototype._lastSidebarSize):
(WebInspector.SplitView.prototype.get _saveSidebarSize):

11:27 PM Changeset in webkit [140303] by haraken@chromium.org
  • 10 edits in trunk/Source/WebCore

Add a [ConstructorConditional] IDL attribute
​https://bugs.webkit.org/show_bug.cgi?id=107407

Reviewed by Adam Barth.

Per discussion in webkit-dev, we need to implement DOM4 event constructors
under a enable flag. For that purpose, we implement a [ConstructorConditional]
IDL attribute.

Test: bindings/scripts/test/TestInterface.idl

  • bindings/scripts/CodeGenerator.pm:

(GenerateConstructorConditionalString):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore):

  • bindings/scripts/test/JS/JSTestInterface.h:

(JSTestInterfaceConstructor):

  • bindings/scripts/test/TestInterface.idl:
  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::ConfigureV8TestInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

11:18 PM Changeset in webkit [140302] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] We should set a class id for a NPObject wrapper
​https://bugs.webkit.org/show_bug.cgi?id=107249

Reviewed by Adam Barth.

This is one of steps to avoid hitting an ASSERT()
that will be added in ​https://bugs.webkit.org/show_bug.cgi?id=107137 .

No tests. No change in behavior.

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):
(WebCore::V8DOMWrapper::setWrapperClass):
(WebCore):

  • bindings/v8/V8NPObject.cpp:

(WebCore::createV8ObjectForNPObject):

11:10 PM Changeset in webkit [140301] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Extend diff_parser to support the --full-index output.
​https://bugs.webkit.org/show_bug.cgi?id=107408

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-01-20
Reviewed by Maciej Stachowiak.

  • Scripts/webkitpy/common/checkout/diff_parser.py:

(git_diff_to_svn_diff):

  • Scripts/webkitpy/common/checkout/diff_parser_unittest.py:

(DiffParserTest):
(DiffParserTest.test_git_diff_to_svn_diff):
(git_diff_to_svn_diff):

11:05 PM Changeset in webkit [140300] by mikelawther@chromium.org
  • 45 edits
    1 copy
    1 add in trunk

CSS3 calc: unprefix implementation
​https://bugs.webkit.org/show_bug.cgi?id=91951

Reviewed by Ojan Vafai.

Source/WebCore:

Add support for the unprefixed 'calc()' function, while retaining support for the prefixed version.

Test: css3/calc/simple-calcs-prefixed.html

  • css/CSSCalculationValue.cpp:

(WebCore::buildCssText):
(WebCore::CSSCalcValue::create):

  • css/CSSParser.cpp:

(WebCore::CSSParser::isCalculation):
(WebCore::CSSParser::detectFunctionTypeToken):

LayoutTests:

Changed all -webkit-calc() occurrences to calc().
Made a copy of the simplest test file so very basic tests for the prefixed version
are retained.

  • css3/calc/background-position-parsing.html:
  • css3/calc/block-mask-overlay-image-outset.html:
  • css3/calc/border-radius.html:
  • css3/calc/border.html:
  • css3/calc/box-reflect.html:
  • css3/calc/calc-errors.html:
  • css3/calc/color-hsl.html:
  • css3/calc/color-rgb.html:
  • css3/calc/css3-radial-gradients.html:
  • css3/calc/cssom-expected.txt:
  • css3/calc/cssom.html:
  • css3/calc/font-monospace.html:
  • css3/calc/font-size-fractional.html:
  • css3/calc/font-size.html:
  • css3/calc/font.html:
  • css3/calc/getComputedStyle-margin-percentage.html:
  • css3/calc/gradient-color-stops.html:
  • css3/calc/img-size.html:
  • css3/calc/line-height.html:
  • css3/calc/margin.html:
  • css3/calc/negative-padding.html:
  • css3/calc/padding.html:
  • css3/calc/reflection-computed-style-expected.txt:
  • css3/calc/reflection-computed-style.html:
  • css3/calc/regression-62276.html:
  • css3/calc/simple-calcs-prefixed-expected.txt: Added.
  • css3/calc/simple-calcs-prefixed.html: Copied from LayoutTests/css3/calc/simple-calcs.html.
  • css3/calc/simple-calcs.html:
  • css3/calc/simple-composited-mask.html:
  • css3/calc/table-border-spacing.html:
  • css3/calc/table-calcs.html:
  • css3/calc/table-empty-cells.html:
  • css3/calc/transforms-scale.html:
  • css3/calc/transforms-translate.html:
  • css3/calc/transition-crash.html:
  • css3/calc/transition-crash2.html:
  • css3/calc/transition-crash3.html:
  • css3/calc/transition-crash4.html:
  • css3/calc/transitions-dependent.html:
  • css3/calc/transitions.html:
  • css3/calc/vertical-align-expected.html:
  • css3/calc/vertical-align.html:
  • css3/calc/zoom-with-em.html:
10:59 PM Changeset in webkit [140299] by shinyak@chromium.org
  • 8 edits
    4 adds in trunk

Distribution state becomes inconsistent with content/shadow reprojection
​https://bugs.webkit.org/show_bug.cgi?id=106634

Reviewed by Hajime Morita.

Source/WebCore:

Distribution should be resolved from shallower ShadowDOM to deeper Shadow DOM. However, in the current implementation,
there is a case that distribution for deeper ShadowDOM happens to be resolved before distribution
for shallower ShadowDOM is resolved.

Here, we have 2 problems about distribution.
1) Invalidation state is not propagated to nested (= deeper) ShadowDOM.

  • This causes deeper ShadowDOM looks having a valid distribution though it should be invalid.

2) We are not resolving shallower ShadowDOM when deeper ShadowDOM's distribution is needed.

  • Because of (1), we have to check all the ancestor ShadowDOM.

For (1), we change invalidate() to invalidate nested ShadowDOM's distribution as well.
For (2), when resolving distribution, we will check the ancestor ShadowDOM's distribution state. If the ancestor's
distribution is not valid, we resolve it first.

For optimization of (1), actually we can skip invalidating distribution of some ShadowDOMs.
If ShadowRoot of deeper ShadowDOM does not have an InsertionPoint as children, we can skip invalidating
its distribution, because only children can be distributed to InsertionPoint.

Tests: fast/dom/shadow/distribution-crash.html

fast/dom/shadow/nested-reprojection-inconsistent.html

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::attach): Should resolve distribution from ancestor.

  • dom/ElementShadow.h:
  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute): Added ASSERT that the parent ShadowRoot's distribution is resolved.
(WebCore::ContentDistributor::invalidate): For each InsertionPoint, we have to invalidate
its parent element's distribution (if it has ElementShadow).
(WebCore::ContentDistributor::ensureDistribution):

  • html/shadow/ContentDistributor.h:

(WebCore::ContentDistributor::isValid):

  • html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::olderShadowRoot): Should resolve distribution from ancestor.

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach): ditto.
(WebCore::InsertionPoint::detach): ditto.
(WebCore::InsertionPoint::getDistributedNodes): ditto.
(WebCore::resolveReprojection): ditto.

LayoutTests:

  • fast/dom/shadow/distribution-crash-expected.txt: Added.
  • fast/dom/shadow/distribution-crash.html: Added.
  • fast/dom/shadow/nested-reprojection-inconsistent-expected.txt: Added.
  • fast/dom/shadow/nested-reprojection-inconsistent.html: Added.
10:48 PM Changeset in webkit [140298] by apavlov@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/StylesSidebarPane.js

Merge 139994

Web Inspector: [Spectrum] Color picker in CSS editor does not update textual color value
​https://bugs.webkit.org/show_bug.cgi?id=107110

Reviewed by Vsevolod Vlasov.

The Spectrum picker was never told to update the textual color upon user-initiated color changes.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

TBR=​apavlov@chromium.org
Review URL: ​https://codereview.chromium.org/12035003

10:13 PM Changeset in webkit [140297] by dmazzoni@google.com
  • 4 edits
    2 adds in trunk/Source

Make SpeechSynthesis compile in the Chromium port
​https://bugs.webkit.org/show_bug.cgi?id=107382

Reviewed by Adam Barth.

Source/WebCore:

Add stubs for the Chromium implementation of speech synthesis,
and add all source and header files to WebCore.gypi. Everything
is behind the ENABLE_SPEECH_SYNTHESIS flag.

  • Modules/speech/chromium/SpeechSynthesisChromium.cpp: Added.

(WebCore):
(WebCore::SpeechSynthesis::initializeVoiceList):
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::speaking):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::speak):
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::pause):
(WebCore::SpeechSynthesis::resume):

  • WebCore.gypi:

Source/WebKit/chromium:

Add ENABLE_SPEECH_SYNTHESIS to features.gypi, off by default.

  • features.gypi:
10:10 PM Changeset in webkit [140296] by tkent@chromium.org
  • 3 edits
    4 adds in trunk

Re-layout child blocks when border/padding of the box-sizing:border-box parent is updated
​https://bugs.webkit.org/show_bug.cgi?id=104997

Reviewed by Tony Chang.

Source/WebCore:

When padding or border is updated for a parent block with
box-sizing:border-box and width, the width of its child block was not
updated.

Tests: fast/css/box-sizing-border-box-dynamic-padding-border-update.html

fast/forms/text/text-padding-dynamic-change.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):
If box-sizing of the old style and/or the new style is border-box and
padding or border is changed, apply setChildNeedsLayout(true) for child
boxes.

LayoutTests:

  • fast/css/box-sizing-border-box-dynamic-padding-border-update-expected.txt: Added.
  • fast/css/box-sizing-border-box-dynamic-padding-border-update.html: Added.
  • fast/forms/text/text-padding-dynamic-change-expected.html: Added.
  • fast/forms/text/text-padding-dynamic-change.html: Added.
10:08 PM Changeset in webkit [140295] by haraken@chromium.org
  • 4 edits
    1 delete in trunk/Source/WebCore

[V8] Remove custom V8ScriptProfileCustom::toV8()
​https://bugs.webkit.org/show_bug.cgi?id=107246

Reviewed by Adam Barth.

V8ScriptProfileCustom::toV8() needs not to be custom.
Furthermore, the current custom toV8() is wrong in that
it doesn't use a creationContext and it doesn't set a
wrapper class id. This is one of steps to avoiding
ASSERT()s that will be added in
​https://bugs.webkit.org/show_bug.cgi?id=107137 .

No tests. No change in behavior.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/custom/V8ScriptProfileCustom.cpp: Removed.
  • inspector/ScriptProfile.idl:
9:42 PM Changeset in webkit [140294] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Remove support getting per-resource callbacks in the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=107405

Patch by Viatcheslav Ostapenko <​sl.ostapenko@samsung.com> on 2013-01-20
Reviewed by Sam Weinig.

EFL, GTK and Qt WebKit2 build fixes after r140285.
Remove from build WebResourceLoadClient.{cpp,h} deleted by r140285.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
9:23 PM Changeset in webkit [140293] by tkent@chromium.org
  • 3 edits
    4 deletes in trunk

Unreviewed, rolling out r140290.
​http://trac.webkit.org/changeset/140290
​https://bugs.webkit.org/show_bug.cgi?id=107412

Broke tests of inspector and calendar picker in debug build
(Requested by tkent on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-20

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

LayoutTests:

  • fast/css/box-sizing-border-box-dynamic-padding-border-update-expected.txt: Removed.
  • fast/css/box-sizing-border-box-dynamic-padding-border-update.html: Removed.
  • fast/forms/text/text-padding-dynamic-change-expected.html: Removed.
  • fast/forms/text/text-padding-dynamic-change.html: Removed.
9:12 PM Changeset in webkit [140292] by commit-queue@webkit.org
  • 3 edits
    7 adds in trunk

Dispatch LongPress to inner frames
​https://bugs.webkit.org/show_bug.cgi?id=106874

Patch by Yongsheng Zhu <​yongsheng.zhu@intel.com> on 2013-01-20
Reviewed by Antonio Gomes.

Source/WebCore:

Do check whether a LongPress gesture event should be passed
to inner frames. If needed, dispatch it.

Tests: fast/events/touch/gesture/long-press-on-draggable-element-in-iframe-triggers-drag.html

fast/events/touch/gesture/long-press-on-draggable-element-in-nested-iframes-triggers-drag.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureLongPress):

LayoutTests:

  • fast/events/touch/gesture/long-press-on-draggable-element-in-iframe-triggers-drag.html: Added.
  • fast/events/touch/gesture/long-press-on-draggable-element-in-nested-iframes-triggers-drag.html: Added.
  • fast/events/touch/gesture/resources/drag-inside-iframe2.html: Added.
  • fast/events/touch/gesture/resources/drag-inside-nested-iframes2.html: Added.
  • fast/events/touch/gesture/resources/drag-inside-nested-iframes3.html: Added.
  • platform/chromium/fast/events/touch/gesture/long-press-on-draggable-element-in-iframe-triggers-drag-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/long-press-on-draggable-element-in-nested-iframes-triggers-drag-expected.txt: Added.
7:52 PM Changeset in webkit [140291] by gyuyoung.kim@samsung.com
  • 21 edits in trunk/Source/WebCore

Clean up missing *explicit* keyword in ctors of WebCore/rendering.
​https://bugs.webkit.org/show_bug.cgi?id=107373

Reviewed by Darin Adler.

Need to add *explicit* keyword to avoid implicit type conversion.

  • rendering/RenderApplet.h:

(RenderApplet):

  • rendering/RenderArena.h:

(RenderArena):

  • rendering/RenderBR.h:

(RenderBR):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderDetailsMarker.h:

(RenderDetailsMarker):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

  • rendering/RenderFlowThread.h:
  • rendering/RenderFullScreen.h:

(RenderFullScreen):

  • rendering/RenderGeometryMap.h:

(WebCore::RenderGeometryMapStep::RenderGeometryMapStep):

  • rendering/RenderGrid.h:

(RenderGrid):

  • rendering/RenderImage.h:

(RenderImage):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

  • rendering/RenderLayerModelObject.h:

(RenderLayerModelObject):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderListMarker.h:

(RenderListMarker):

  • rendering/RenderMedia.h:

(RenderMedia):

  • rendering/RenderMeter.h:

(RenderMeter):

  • rendering/RenderMultiColumnBlock.h:

(RenderMultiColumnBlock):

  • rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):

  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderPart.h:

(RenderPart):

  • rendering/RenderProgress.h:

(RenderProgress):

  • rendering/RenderReplaced.h:

(RenderReplaced):

  • rendering/RenderReplica.h:

(RenderReplica):

  • rendering/RenderRuby.h:

(RenderRubyAsInline):

  • rendering/RenderRubyBase.h:

(RenderRubyBase):

  • rendering/RenderRubyRun.h:

(RenderRubyRun):

  • rendering/RenderRubyText.h:

(RenderRubyText):

  • rendering/RenderSearchField.h:

(RenderSearchField):

  • rendering/RenderSlider.h:

(RenderSlider):

  • rendering/RenderSnapshottedPlugIn.h:

(RenderSnapshottedPlugIn):

  • rendering/RenderTextControlMultiLine.h:

(RenderTextControlMultiLine):

  • rendering/RenderTextControlSingleLine.h:

(RenderTextControlSingleLine):

  • rendering/RenderView.h:

(RenderView):

  • rendering/RenderWidgetProtector.h:

(WebCore::RenderWidgetProtector::RenderWidgetProtector):

  • rendering/RootInlineBox.h:

(RootInlineBox): Remove meaningless parameter name.

  • rendering/TableLayout.h:

(WebCore::TableLayout::TableLayout):

6:40 PM Changeset in webkit [140290] by tkent@chromium.org
  • 3 edits
    5 adds in trunk

Re-layout child blocks when border/padding of the box-sizing:border-box parent is updated
​https://bugs.webkit.org/show_bug.cgi?id=104997

Reviewed by Tony Chang.

Source/WebCore:

When padding or border is updated for a parent block with
box-sizing:border-box and width, the width of its child block was not
updated.

Tests: fast/css/box-sizing-border-box-dynamic-padding-border-update.html

fast/forms/text/text-padding-dynamic-change.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):
If box-sizing of the old style and/or the new style is border-box and
padding or border is changed, apply setChildNeedsLayout(true) for child
boxes.

LayoutTests:

  • fast/css/box-sizing-border-box-dynamic-padding-border-update-expected.txt: Added.
  • fast/css/box-sizing-border-box-dynamic-padding-border-update.html: Added.
  • fast/forms/text/text-padding-dynamic-change-expected.html: Added.
  • fast/forms/text/text-padding-dynamic-change.html: Added.
6:31 PM Changeset in webkit [140289] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] some websites only takes half of the screen after rotating from landscape to portrait mode.
​https://bugs.webkit.org/show_bug.cgi?id=107103

Reviewed by George Staikos.
Internally reviewed by Jacky Jiang.

When the document size changes (by some javascript) which makes it too small to fit the viewport, we should
automatically zoom it to fit the viewport.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::layoutFinished):

6:29 PM Changeset in webkit [140288] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r140270.
​http://trac.webkit.org/changeset/140270
​https://bugs.webkit.org/show_bug.cgi?id=107253

Hit asserts in a debug build

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

6:24 PM Changeset in webkit [140287] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

[Shadow DOM] Specifying scrollbar style of an element having RenderLayer in ShadowDOM does not work.
​https://bugs.webkit.org/show_bug.cgi?id=107222

Reviewed by Simon Fraser.

Source/WebCore:

When specifying scrollbar style in ShadowDOM, it's not used. If the host element of ShadowDOM has scrollbar style,
it's used instead.

The root cause of this bug is that RenderLayer always see shadowAncestorNode's style. Some elements having
UserAgent ShadowDOM (e.g. <textarea>) should see host's style, but most of elements should see its style.

Test: fast/dom/shadow/scrollbar.html

  • rendering/RenderLayer.cpp:

(WebCore::rendererForScrollbar):
(WebCore):
(WebCore::RenderLayer::createScrollbar):
(WebCore::RenderLayer::updateScrollCornerStyle):
(WebCore::RenderLayer::updateResizerStyle):

LayoutTests:

  • fast/dom/shadow/scrollbar-expected.html: Added.
  • fast/dom/shadow/scrollbar.html: Added.
5:29 PM Changeset in webkit [140286] by yosin@chromium.org
  • 29 edits
    2 adds in trunk

Dragging over an element with scrollbars should scroll the element when dragging near edges
​https://bugs.webkit.org/show_bug.cgi?id=39725

Reviewed by Hajime Morita.

Source/WebCore:

This patch introduces auto scrolling functionality during drag-and-drop
when drop source is near edge of scrollable element.

When drop source is inside 20px of scrollable element more than 200ms,
scrollable element is automatically scrolled every 50ms toward drop
source position, e.g. vertically scroll up when drop source is in top
edge.

Test: fast/events/drag-and-drop-autoscroll.html

  • page/AutoscrollController.cpp:

(WebCore::AutoscrollController::AutoscrollController): Changed to initialize m_dragAndDropAutoscrollStartTime.
(WebCore::AutoscrollController::updateDragAndDrop): Added for start/stop autoscroll during drag-and-drop.
(WebCore::AutoscrollController::autoscrollTimerFired): Changed to add autoscroll for drag-and-drop, and to pass last know position to RenderBox::autoscroll().

  • page/AutoscrollController.h:

(AutoscrollController): Changed to add updateDragAndDrop() and m_dragAndDropAutoscrollReferencePosition and m_dragAndDropAutoscrollStartTime.

  • page/ChromeClient.h:

(WebCore::ChromeClient): Changed to add new function shouldAutoscrollForDragAndDrop().

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateDragAndDrop): Changed to call AutoscrollController::updateDragAndDrop().
(WebCore::EventHandler::clearDragState): Changed to call stopAutoscrollTimer().

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::autoscroll): Changed for new parameter position.
(WebCore::RenderBox::calculateAutoscrollDirection): Added for autoscroll.

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::autoscroll): Changed for new parameter position and move updateSelectionForMouseDrag() to AutoscrollController.

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::autoscroll): Changed for new parameter position.

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::autoscroll): Changed for new parameter position.

  • rendering/RenderTextControlSingleLine.h:

(RenderTextControlSingleLine):

Source/WebKit/chromium:

This patch removes DragScrollTimer used for automatic scrolling of main
frame drag-and-drop which is now implemented in EventHandler.

Another patch will remove DragScrollTimer.{cpp,h} and update GYP files to
make patch size small.

No tests. Existing test covers this change.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::shouldAutoscrollForDragAndDrop): Added.

  • src/ChromeClientImpl.h:

(ChromeClientImpl): Changed to add shouldAutoscrollForDragAndDrop().

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl): Changed to remove m_dragScrollTimer.
(WebKit::WebViewImpl::dragSourceEndedAt): ditto
(WebKit::WebViewImpl::dragSourceMovedTo): ditto
(WebKit::WebViewImpl::dragTargetDrop): ditto
(WebKit::WebViewImpl::dragTargetDragEnterOrOver): ditto

  • src/WebViewImpl.h:

(WebKit): Chagned to remove DragScrollTimer.

Tools:

This patch introduces canceling drag-and-drop by escape key for testing
behavior after cancellation drag-and-drop.

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::doMouseUp):
(WebTestRunner::EventSender::finishDragAndDrop):
(WebTestRunner::EventSender::keyDown):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(EventSender):

  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.

LayoutTests:

This patch adds new test for autoscroll during drag-and-drop.
This test is skipped other than Chromium ports.

  • fast/events/drag-and-drop-autoscroll-expected.txt: Added.
  • fast/events/drag-and-drop-autoscroll.html: Added.
  • platform/efl/TestExpectations: Changed to skip fast/events/drag-and-drop-autoscroll.html
  • platform/wincairo/TestExpectations: ditto.
  • platform/mac/TestExpectations: ditto.
  • platform/mac/TestExpectations: ditto.
  • platform/qt/TestExpectations: ditto.
  • platform/gtk/TestExpectations: ditto.
  • platform/win/TestExpectations: ditto.
  • platform/wk2/TestExpectations: ditto.
5:01 PM Changeset in webkit [140285] by weinig@apple.com
  • 8 edits
    2 deletes in trunk/Source/WebKit2

Remove support getting per-resource callbacks in the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=107405

Reviewed by Anders Carlsson.

Removes support for the WKPageResourceLoadClient. Access to per-resource
callbacks are still available in the bundle, and via the WebInspector.

  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Stop handling per-resource messages and forwarding them to the API.

  • UIProcess/WebResourceLoadClient.cpp: Removed.
  • UIProcess/WebResourceLoadClient.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:

Remove the files.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest):
(WebKit::WebFrameLoaderClient::dispatchWillSendRequest):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveResponse):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoading):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoading):
Stop sending per-resource messages to the UIProcess.

4:59 PM Changeset in webkit [140284] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Weak GC maps should be easier to use
​https://bugs.webkit.org/show_bug.cgi?id=107312

Reviewed by Sam Weinig.

Follow-up fix.

  • runtime/PrototypeMap.cpp:

(JSC::PrototypeMap::emptyObjectStructureForPrototype): Restored this
ASSERT, which was disabled because of a bug in WeakGCMap.

  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::add): We can't pass our passed-in value to add() because
a PassWeak() clears itself when passed to another function. So, we pass
nullptr instead, and fix things up afterwards.

4:11 PM Changeset in webkit [140283] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Simplify a list of negative PLATFORM() tests
​https://bugs.webkit.org/show_bug.cgi?id=107365

Patch by Laszlo Gombos <Laszlo Gombos> on 2013-01-20
Reviewed by Eric Seidel.

Simplify a list of negative PLATFORM() tests into a simpler list
of positive tests for better readability and maintenance.

No new tests as there is no new functionality.

  • config.h:
2:55 PM Changeset in webkit [140282] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Improve Fatfinger phase.
​https://bugs.webkit.org/show_bug.cgi?id=107403

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-01-20
Reviewed by Rob Buis.

RIM PR 219489
Internally reviewd by Mike Fenton & Gen Mak.

Treat ClickableByDefault and MadeClickableByTheWebpage elements as
same category. Avoid unnecessary nodes check step.

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::isElementClickable):
(BlackBerry::WebKit::FatFingers::FatFingers):
(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::getNodesFromRect):

  • WebKitSupport/FatFingers.h:
1:30 PM Changeset in webkit [140281] by jochen@chromium.org
  • 8 edits in trunk/Tools

[chromium] move frame generation related methods to TestRunner
​https://bugs.webkit.org/show_bug.cgi?id=107268

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::setWillSendRequestReturnsNull):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestRunner::WebTestDelegate::display):
(WebTestRunner::WebTestDelegate::displayInvalidatedRegion):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::display):
(WebTestRunner):
(WebTestRunner::TestRunner::displayInvalidatedRegion):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::display):
(WebViewHost::displayInvalidatedRegion):

  • DumpRenderTree/chromium/WebViewHost.h:
12:45 PM Changeset in webkit [140280] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Simple indentation fix.

  • GNUmakefile.am:
12:36 PM Changeset in webkit [140279] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Avoid filling a rounded rect when radii are zero
​https://bugs.webkit.org/show_bug.cgi?id=107402
<rdar://problem/12793315>

Reviewed by Sam Weinig.

It's more efficient to clip and fill rects than rounded rects,
so optimize for the case where rounded rect radii are zero.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::clipRoundedRect):
(WebCore::GraphicsContext::clipOutRoundedRect):
(WebCore::GraphicsContext::fillRoundedRect):

12:33 PM Changeset in webkit [140278] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2013-01-20 Geoffrey Garen <​ggaren@apple.com>

Unreviewed.

Temporarily disabling this ASSERT to get the bots green
while I investigate a fix.

  • runtime/PrototypeMap.cpp: (JSC::PrototypeMap::emptyObjectStructureForPrototype):
12:16 PM Changeset in webkit [140277] by jochen@chromium.org
  • 8 edits in trunk/Tools

[chromium] move speech related methods to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=107266

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::displayInvalidatedRegion):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):
(WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
(WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
(WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
(WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
(WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner):
(WebTestRunner::TestRunner::addMockSpeechInputResult):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
(WebTestRunner::TestRunner::setMockSpeechRecognitionError):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::addMockSpeechInputResult):
(WebViewHost::setMockSpeechInputDumpRect):
(WebViewHost::addMockSpeechRecognitionResult):
(WebViewHost::setMockSpeechRecognitionError):
(WebViewHost::wasMockSpeechRecognitionAborted):

  • DumpRenderTree/chromium/WebViewHost.h:
12:06 PM Changeset in webkit [140276] by fpizlo@apple.com
  • 1 edit
    245 adds in trunk/LayoutTests

Add more JavaScript tests.

Rubber stampted by Geoffrey Garen.

This adds my JSRegress suite to LayoutTests. This includes silly microbenchmarks that I've
used to test JSC's performance on various interesting cases. But it's also good at catching
bugs, so we might as well be running it as part of regression testing. All of these tests
are short-running, so it shouldn't get in the way of anyone.

  • fast/js/regress: Added.
  • fast/js/regress/Float32Array-matrix-mult-expected.txt: Added.
  • fast/js/regress/Float32Array-matrix-mult.html: Added.
  • fast/js/regress/Int16Array-bubble-sort-expected.txt: Added.
  • fast/js/regress/Int16Array-bubble-sort.html: Added.
  • fast/js/regress/Int16Array-load-int-mul-expected.txt: Added.
  • fast/js/regress/Int16Array-load-int-mul.html: Added.
  • fast/js/regress/Int8Array-load-expected.txt: Added.
  • fast/js/regress/Int8Array-load.html: Added.
  • fast/js/regress/adapt-to-double-divide-expected.txt: Added.
  • fast/js/regress/adapt-to-double-divide.html: Added.
  • fast/js/regress/aliased-arguments-getbyval-expected.txt: Added.
  • fast/js/regress/aliased-arguments-getbyval.html: Added.
  • fast/js/regress/allocate-big-object-expected.txt: Added.
  • fast/js/regress/allocate-big-object.html: Added.
  • fast/js/regress/arity-mismatch-inlining-expected.txt: Added.
  • fast/js/regress/arity-mismatch-inlining.html: Added.
  • fast/js/regress/array-access-polymorphic-structure-expected.txt: Added.
  • fast/js/regress/array-access-polymorphic-structure.html: Added.
  • fast/js/regress/array-with-double-add-expected.txt: Added.
  • fast/js/regress/array-with-double-add.html: Added.
  • fast/js/regress/array-with-double-increment-expected.txt: Added.
  • fast/js/regress/array-with-double-increment.html: Added.
  • fast/js/regress/array-with-double-mul-add-expected.txt: Added.
  • fast/js/regress/array-with-double-mul-add.html: Added.
  • fast/js/regress/array-with-double-sum-expected.txt: Added.
  • fast/js/regress/array-with-double-sum.html: Added.
  • fast/js/regress/array-with-int32-add-sub-expected.txt: Added.
  • fast/js/regress/array-with-int32-add-sub.html: Added.
  • fast/js/regress/array-with-int32-or-double-sum-expected.txt: Added.
  • fast/js/regress/array-with-int32-or-double-sum.html: Added.
  • fast/js/regress/big-int-mul-expected.txt: Added.
  • fast/js/regress/big-int-mul.html: Added.
  • fast/js/regress/boolean-test-expected.txt: Added.
  • fast/js/regress/boolean-test.html: Added.
  • fast/js/regress/cast-int-to-double-expected.txt: Added.
  • fast/js/regress/cast-int-to-double.html: Added.
  • fast/js/regress/cell-argument-expected.txt: Added.
  • fast/js/regress/cell-argument.html: Added.
  • fast/js/regress/cfg-simplify-expected.txt: Added.
  • fast/js/regress/cfg-simplify.html: Added.
  • fast/js/regress/cmpeq-obj-to-obj-other-expected.txt: Added.
  • fast/js/regress/cmpeq-obj-to-obj-other.html: Added.
  • fast/js/regress/constant-test-expected.txt: Added.
  • fast/js/regress/constant-test.html: Added.
  • fast/js/regress/direct-arguments-getbyval-expected.txt: Added.
  • fast/js/regress/direct-arguments-getbyval.html: Added.
  • fast/js/regress/double-pollution-getbyval-expected.txt: Added.
  • fast/js/regress/double-pollution-getbyval.html: Added.
  • fast/js/regress/double-pollution-putbyoffset-expected.txt: Added.
  • fast/js/regress/double-pollution-putbyoffset.html: Added.
  • fast/js/regress/external-arguments-getbyval-expected.txt: Added.
  • fast/js/regress/external-arguments-getbyval.html: Added.
  • fast/js/regress/external-arguments-putbyval-expected.txt: Added.
  • fast/js/regress/external-arguments-putbyval.html: Added.
  • fast/js/regress/fold-double-to-int-expected.txt: Added.
  • fast/js/regress/fold-double-to-int.html: Added.
  • fast/js/regress/function-dot-apply-expected.txt: Added.
  • fast/js/regress/function-dot-apply.html: Added.
  • fast/js/regress/function-test-expected.txt: Added.
  • fast/js/regress/function-test.html: Added.
  • fast/js/regress/get-by-id-chain-from-try-block-expected.txt: Added.
  • fast/js/regress/get-by-id-chain-from-try-block.html: Added.
  • fast/js/regress/indexed-properties-in-objects-expected.txt: Added.
  • fast/js/regress/indexed-properties-in-objects.html: Added.
  • fast/js/regress/inline-arguments-access-expected.txt: Added.
  • fast/js/regress/inline-arguments-access.html: Added.
  • fast/js/regress/inline-arguments-local-escape-expected.txt: Added.
  • fast/js/regress/inline-arguments-local-escape.html: Added.
  • fast/js/regress/inline-get-scoped-var-expected.txt: Added.
  • fast/js/regress/inline-get-scoped-var.html: Added.
  • fast/js/regress/inlined-put-by-id-transition-expected.txt: Added.
  • fast/js/regress/inlined-put-by-id-transition.html: Added.
  • fast/js/regress/int-or-other-abs-then-get-by-val-expected.txt: Added.
  • fast/js/regress/int-or-other-abs-then-get-by-val.html: Added.
  • fast/js/regress/int-or-other-abs-zero-then-get-by-val-expected.txt: Added.
  • fast/js/regress/int-or-other-abs-zero-then-get-by-val.html: Added.
  • fast/js/regress/int-or-other-add-expected.txt: Added.
  • fast/js/regress/int-or-other-add-then-get-by-val-expected.txt: Added.
  • fast/js/regress/int-or-other-add-then-get-by-val.html: Added.
  • fast/js/regress/int-or-other-add.html: Added.
  • fast/js/regress/int-or-other-div-then-get-by-val-expected.txt: Added.
  • fast/js/regress/int-or-other-div-then-get-by-val.html: Added.
  • fast/js/regress/int-or-other-max-then-get-by-val-expected.txt: Added.
  • fast/js/regress/int-or-other-max-then-get-by-val.html: Added.
  • fast/js/regress/int-or-other-min-then-get-by-val-expected.txt: Added.
  • fast/js/regress/int-or-other-min-then-get-by-val.html: Added.
  • fast/js/regress/int-or-other-mod-then-get-by-val-expected.txt: Added.
  • fast/js/regress/int-or-other-mod-then-get-by-val.html: Added.
  • fast/js/regress/int-or-other-mul-then-get-by-val-expected.txt: Added.
  • fast/js/regress/int-or-other-mul-then-get-by-val.html: Added.
  • fast/js/regress/int-or-other-neg-then-get-by-val-expected.txt: Added.
  • fast/js/regress/int-or-other-neg-then-get-by-val.html: Added.
  • fast/js/regress/int-or-other-neg-zero-then-get-by-val-expected.txt: Added.
  • fast/js/regress/int-or-other-neg-zero-then-get-by-val.html: Added.
  • fast/js/regress/int-or-other-sub-expected.txt: Added.
  • fast/js/regress/int-or-other-sub-then-get-by-val-expected.txt: Added.
  • fast/js/regress/int-or-other-sub-then-get-by-val.html: Added.
  • fast/js/regress/int-or-other-sub.html: Added.
  • fast/js/regress/int-overflow-local-expected.txt: Added.
  • fast/js/regress/int-overflow-local.html: Added.
  • fast/js/regress/integer-divide-expected.txt: Added.
  • fast/js/regress/integer-divide.html: Added.
  • fast/js/regress/make-indexed-storage-expected.txt: Added.
  • fast/js/regress/make-indexed-storage.html: Added.
  • fast/js/regress/method-on-number-expected.txt: Added.
  • fast/js/regress/method-on-number.html: Added.
  • fast/js/regress/new-array-buffer-dead-expected.txt: Added.
  • fast/js/regress/new-array-buffer-dead.html: Added.
  • fast/js/regress/new-array-buffer-push-expected.txt: Added.
  • fast/js/regress/new-array-buffer-push.html: Added.
  • fast/js/regress/new-array-dead-expected.txt: Added.
  • fast/js/regress/new-array-dead.html: Added.
  • fast/js/regress/new-array-push-expected.txt: Added.
  • fast/js/regress/new-array-push.html: Added.
  • fast/js/regress/number-test-expected.txt: Added.
  • fast/js/regress/number-test.html: Added.
  • fast/js/regress/object-closure-call-expected.txt: Added.
  • fast/js/regress/object-closure-call.html: Added.
  • fast/js/regress/object-test-expected.txt: Added.
  • fast/js/regress/object-test.html: Added.
  • fast/js/regress/poly-stricteq-expected.txt: Added.
  • fast/js/regress/poly-stricteq.html: Added.
  • fast/js/regress/polymorphic-structure-expected.txt: Added.
  • fast/js/regress/polymorphic-structure.html: Added.
  • fast/js/regress/polyvariant-monomorphic-get-by-id-expected.txt: Added.
  • fast/js/regress/polyvariant-monomorphic-get-by-id.html: Added.
  • fast/js/regress/rare-osr-exit-on-local-expected.txt: Added.
  • fast/js/regress/rare-osr-exit-on-local.html: Added.
  • fast/js/regress/register-pressure-from-osr-expected.txt: Added.
  • fast/js/regress/register-pressure-from-osr.html: Added.
  • fast/js/regress/resources: Added.
  • fast/js/regress/resources/regress-post.js: Added.
  • fast/js/regress/resources/regress-pre.js: Added.

(window.onerror):

  • fast/js/regress/script-tests: Added.
  • fast/js/regress/script-tests/Float32Array-matrix-mult.js: Added.

(makeEmptyMatrix):
(multiplyMatrices):
(checkMatricesEqual):
(parseMatrix.string.split.forEach):
(parseMatrix):
(printMatrix.pad):
(printMatrix):

  • fast/js/regress/script-tests/Int16Array-bubble-sort.js: Added.

(bubbleSort):
(myRandom):
(validateSort):

  • fast/js/regress/script-tests/Int16Array-load-int-mul.js: Added.

(stringHash):

  • fast/js/regress/script-tests/Int8Array-load.js: Added.

(adler32):

  • fast/js/regress/script-tests/adapt-to-double-divide.js: Added.

(foo):

  • fast/js/regress/script-tests/aliased-arguments-getbyval.js: Added.

(bar):

  • fast/js/regress/script-tests/allocate-big-object.js: Added.

(foo):

  • fast/js/regress/script-tests/arity-mismatch-inlining.js: Added.

(foo):

  • fast/js/regress/script-tests/array-access-polymorphic-structure.js: Added.

(foo):

  • fast/js/regress/script-tests/array-with-double-add.js: Added.

(foo):

  • fast/js/regress/script-tests/array-with-double-increment.js: Added.

(foo):

  • fast/js/regress/script-tests/array-with-double-mul-add.js: Added.

(foo):

  • fast/js/regress/script-tests/array-with-double-sum.js: Added.

(foo):

  • fast/js/regress/script-tests/array-with-int32-add-sub.js: Added.

(foo):

  • fast/js/regress/script-tests/array-with-int32-or-double-sum.js: Added.

(foo):

  • fast/js/regress/script-tests/big-int-mul.js: Added.

(stringHash):

  • fast/js/regress/script-tests/boolean-test.js: Added.

(foo):

  • fast/js/regress/script-tests/cast-int-to-double.js: Added.

(foo):

  • fast/js/regress/script-tests/cell-argument.js: Added.

(foo):

  • fast/js/regress/script-tests/cfg-simplify.js: Added.

(foo):

  • fast/js/regress/script-tests/cmpeq-obj-to-obj-other.js: Added.

(foo):
(bar):
(baz):
(dostuff):

  • fast/js/regress/script-tests/constant-test.js: Added.

(foo):

  • fast/js/regress/script-tests/direct-arguments-getbyval.js: Added.

(bar):

  • fast/js/regress/script-tests/double-pollution-getbyval.js: Added.

(foo):

  • fast/js/regress/script-tests/double-pollution-putbyoffset.js: Added.

(foo):

  • fast/js/regress/script-tests/external-arguments-getbyval.js: Added.

(foo):
(bar):

  • fast/js/regress/script-tests/external-arguments-putbyval.js: Added.

(foo):
(bar):

  • fast/js/regress/script-tests/fold-double-to-int.js: Added.

(Math.random):

  • fast/js/regress/script-tests/function-dot-apply.js: Added.

(thingy):
(doCall):
(foo):

  • fast/js/regress/script-tests/function-test.js: Added.

(foo):

  • fast/js/regress/script-tests/get-by-id-chain-from-try-block.js: Added.

(A):
(B):
(C):
(D):
(E):
(F):
(G):
(foo):

  • fast/js/regress/script-tests/indexed-properties-in-objects.js: Added.
  • fast/js/regress/script-tests/inline-arguments-access.js: Added.

(foo):
(bar):

  • fast/js/regress/script-tests/inline-arguments-local-escape.js: Added.

(foo):
(bar):

  • fast/js/regress/script-tests/inline-get-scoped-var.js: Added.

(foo.bar):
(foo):

  • fast/js/regress/script-tests/inlined-put-by-id-transition.js: Added.

(foo):
(Foo):

  • fast/js/regress/script-tests/int-or-other-abs-then-get-by-val.js: Added.

(foo):

  • fast/js/regress/script-tests/int-or-other-abs-zero-then-get-by-val.js: Added.

(foo):

  • fast/js/regress/script-tests/int-or-other-add-then-get-by-val.js: Added.

(foo):

  • fast/js/regress/script-tests/int-or-other-add.js: Added.

(foo):

  • fast/js/regress/script-tests/int-or-other-div-then-get-by-val.js: Added.

(foo):

  • fast/js/regress/script-tests/int-or-other-max-then-get-by-val.js: Added.

(foo):

  • fast/js/regress/script-tests/int-or-other-min-then-get-by-val.js: Added.

(foo):

  • fast/js/regress/script-tests/int-or-other-mod-then-get-by-val.js: Added.

(foo):

  • fast/js/regress/script-tests/int-or-other-mul-then-get-by-val.js: Added.

(foo):

  • fast/js/regress/script-tests/int-or-other-neg-then-get-by-val.js: Added.

(foo):

  • fast/js/regress/script-tests/int-or-other-neg-zero-then-get-by-val.js: Added.

(foo):

  • fast/js/regress/script-tests/int-or-other-sub-then-get-by-val.js: Added.

(foo):

  • fast/js/regress/script-tests/int-or-other-sub.js: Added.

(foo):

  • fast/js/regress/script-tests/int-overflow-local.js: Added.

(foo):

  • fast/js/regress/script-tests/integer-divide.js: Added.

(foo):
(bar):

  • fast/js/regress/script-tests/make-indexed-storage.js: Added.

(foo):
(sum):

  • fast/js/regress/script-tests/method-on-number.js: Added.

(foo):

  • fast/js/regress/script-tests/new-array-buffer-dead.js: Added.

(foo):
(bar):
(baz):
(thingy):

  • fast/js/regress/script-tests/new-array-buffer-push.js: Added.

(foo):
(bar):
(baz):
(thingy):

  • fast/js/regress/script-tests/new-array-dead.js: Added.

(foo):
(bar):

  • fast/js/regress/script-tests/new-array-push.js: Added.

(foo):

  • fast/js/regress/script-tests/number-test.js: Added.

(foo):

  • fast/js/regress/script-tests/object-closure-call.js: Added.

(makeObjectClosure.foo):
(makeObjectClosure):

  • fast/js/regress/script-tests/object-test.js: Added.

(foo):

  • fast/js/regress/script-tests/poly-stricteq.js: Added.
  • fast/js/regress/script-tests/polymorphic-structure.js: Added.

(foo):

  • fast/js/regress/script-tests/polyvariant-monomorphic-get-by-id.js: Added.

(foo):
(Foo):
(Bar):
(bar):

  • fast/js/regress/script-tests/rare-osr-exit-on-local.js: Added.

(foo):

  • fast/js/regress/script-tests/register-pressure-from-osr.js: Added.

(foo):

  • fast/js/regress/script-tests/simple-activation-demo.js: Added.

(foo):

  • fast/js/regress/script-tests/slow-array-profile-convergence.js: Added.

(foo):
(sum):

  • fast/js/regress/script-tests/slow-convergence.js: Added.

(foo):

  • fast/js/regress/script-tests/sparse-conditional.js: Added.

(foo):

  • fast/js/regress/script-tests/splice-to-remove.js: Added.
  • fast/js/regress/script-tests/string-hash.js: Added.

(stringHash):

  • fast/js/regress/script-tests/string-repeat-arith.js: Added.

(foo):

  • fast/js/regress/script-tests/string-sub.js: Added.

(foo):

  • fast/js/regress/script-tests/string-test.js: Added.

(foo):

  • fast/js/regress/script-tests/structure-hoist-over-transitions.js: Added.

(foo):

  • fast/js/regress/script-tests/tear-off-arguments-simple.js: Added.

(bar):

  • fast/js/regress/script-tests/tear-off-arguments.js: Added.

(bar):

  • fast/js/regress/script-tests/temporal-structure.js: Added.

(foo):

  • fast/js/regress/script-tests/to-int32-boolean.js: Added.

(foo):

  • fast/js/regress/script-tests/undefined-test.js: Added.

(foo):

  • fast/js/regress/simple-activation-demo-expected.txt: Added.
  • fast/js/regress/simple-activation-demo.html: Added.
  • fast/js/regress/slow-array-profile-convergence-expected.txt: Added.
  • fast/js/regress/slow-array-profile-convergence.html: Added.
  • fast/js/regress/slow-convergence-expected.txt: Added.
  • fast/js/regress/slow-convergence.html: Added.
  • fast/js/regress/sparse-conditional-expected.txt: Added.
  • fast/js/regress/sparse-conditional.html: Added.
  • fast/js/regress/splice-to-remove-expected.txt: Added.
  • fast/js/regress/splice-to-remove.html: Added.
  • fast/js/regress/string-hash-expected.txt: Added.
  • fast/js/regress/string-hash.html: Added.
  • fast/js/regress/string-repeat-arith-expected.txt: Added.
  • fast/js/regress/string-repeat-arith.html: Added.
  • fast/js/regress/string-sub-expected.txt: Added.
  • fast/js/regress/string-sub.html: Added.
  • fast/js/regress/string-test-expected.txt: Added.
  • fast/js/regress/string-test.html: Added.
  • fast/js/regress/structure-hoist-over-transitions-expected.txt: Added.
  • fast/js/regress/structure-hoist-over-transitions.html: Added.
  • fast/js/regress/tear-off-arguments-expected.txt: Added.
  • fast/js/regress/tear-off-arguments-simple-expected.txt: Added.
  • fast/js/regress/tear-off-arguments-simple.html: Added.
  • fast/js/regress/tear-off-arguments.html: Added.
  • fast/js/regress/temporal-structure-expected.txt: Added.
  • fast/js/regress/temporal-structure.html: Added.
  • fast/js/regress/to-int32-boolean-expected.txt: Added.
  • fast/js/regress/to-int32-boolean.html: Added.
  • fast/js/regress/undefined-test-expected.txt: Added.
  • fast/js/regress/undefined-test.html: Added.
11:29 AM Changeset in webkit [140275] by fpizlo@apple.com
  • 15 edits
    2 adds in trunk/Source/JavaScriptCore

Inserting a node into the DFG graph should not require five lines of code
​https://bugs.webkit.org/show_bug.cgi?id=107381

Reviewed by Sam Weinig.

This adds fairly comprehensive support for inserting a node into a DFG graph in one
method call. A common example of this is:

m_insertionSet.insertNode(indexInBlock, DontRefChildren, DontRefNode, SpecNone, ForceOSRExit, codeOrigin);

The arguments to insert() specify what reference counting you need to have happen
(RefChildren => recursively refs all children, RefNode => non-recursively refs the node
that was created), the prediction to set (SpecNone is a common default), followed by
the arguments to the Node() constructor. InsertionSet::insertNode() and similar methods
(Graph::addNode() and BasicBlock::appendNode()) all use a common variadic template
function macro from DFGVariadicFunction.h. Also, all of these methods will automatically
non-recursively ref() the node being created if the flags say NodeMustGenerate.

In all, this new mechanism retains the flexibility of the old approach (you get to
manage ref counts yourself, albeit in less code) while ensuring that most code that adds
nodes to the graph now needs less code to do it.

In the future, we should revisit the reference counting methodology in the DFG: we could
do like most compilers and get rid of it entirely, or we could make it automatic. This
patch doesn't attempt to make any such major changes, and only seeks to simplify the
technique we were already using (manual ref counting).

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/Operands.h:

(JSC::dumpOperands):

  • dfg/DFGAdjacencyList.h:

(AdjacencyList):
(JSC::DFG::AdjacencyList::kind):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGBasicBlock.h:

(DFG):
(BasicBlock):

  • dfg/DFGBasicBlockInlines.h: Added.

(DFG):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):

  • dfg/DFGCommon.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):
(JSC::DFG::ConstantFoldingPhase::paintUnreachableCode):
(ConstantFoldingPhase):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::FixupPhase):
(JSC::DFG::FixupPhase::fixupBlock):
(JSC::DFG::FixupPhase::fixupNode):
(FixupPhase):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::ref):
(Graph):

  • dfg/DFGInsertionSet.h:

(DFG):
(JSC::DFG::Insertion::Insertion):
(JSC::DFG::Insertion::element):
(Insertion):
(JSC::DFG::InsertionSet::InsertionSet):
(JSC::DFG::InsertionSet::insert):
(InsertionSet):
(JSC::DFG::InsertionSet::execute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(Node):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

  • dfg/DFGVariadicFunction.h: Added.
10:57 AM Changeset in webkit [140274] by ap@apple.com
  • 9 edits
    2 deletes in trunk/Source

Remove obsolete plug-in sandboxing code.
​https://bugs.webkit.org/show_bug.cgi?id=107362

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • plugins/npapi-sandbox.h: Removed.

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:
  • DerivedSources.make:
  • PluginProcess/mac/com.apple.WebKit.PluginProcess.sb.in: Removed.
  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::initializeSandbox): Fixed a memory leak in code that stays.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h:
  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:

Removed API related parts. Remaining code will move to a better place in a follow-up
patch, just keeping it here for easier reviewing.
(enterSandbox): Removed no longer used arguments.

10:18 AM Changeset in webkit [140273] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Make V8 LiveEdit API disabled by default
​https://bugs.webkit.org/show_bug.cgi?id=106668

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2013-01-20
Reviewed by Yury Semikhatsky.

Initialize method is patched accordingly.

  • bindings/v8/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::restart): missing enable/disable calls added for restart

  • bindings/v8/V8Initializer.cpp:

(WebCore::initializeV8Common): initializer method patched

3:36 AM Changeset in webkit [140272] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

[gstreamer] assertion in g_object_unref from _WebKitWebAudioSourcePrivate destructor
​https://bugs.webkit.org/show_bug.cgi?id=107374

Reviewed by Philippe Normand.

WebKitWebAudioSrc object gets unrefed one time too many in
_WebKitWebAudioSourcePrivate destructor, causing an assertion
in g_object_unref. This patch passes NULL instead of
g_object_unref to gst_task_new() so that the WebKitWebAudioSrc
object does not get unrefed when the GstTask is destroyed.

No new tests, already covered by webaudio tests.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webkit_web_audio_src_init):

2:50 AM Changeset in webkit [140271] by jochen@chromium.org
  • 8 edits in trunk/Tools

[chromium] move notification related methods to TestRunner
​https://bugs.webkit.org/show_bug.cgi?id=107269

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):
(WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
(WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner):
(WebTestRunner::TestRunner::grantWebNotificationPermission):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::grantWebNotificationPermission):
(WebViewHost::simulateLegacyWebNotificationClick):

  • DumpRenderTree/chromium/WebViewHost.h:
2:35 AM Changeset in webkit [140270] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Create a persistent wrapper for Window.prototype and innerGlobalObject
​https://bugs.webkit.org/show_bug.cgi?id=107253

Reviewed by Adam Barth.

This is one of steps to avoid hitting an ASSERT()
that will be added in ​https://bugs.webkit.org/show_bug.cgi?id=107137 .
We should have a persistent wrapper for all DOM objects
and set a class id on the wrapper.

No tests. No change in behavior.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

1:40 AM Changeset in webkit [140269] by jochen@chromium.org
  • 8 edits in trunk/Tools

[chromium] move geolocation related methods to TestRunner
​https://bugs.webkit.org/show_bug.cgi?id=107267

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
(WebTestRunner::WebTestDelegate::setGeolocationPermission):
(WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
(WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
(WebTestRunner):
(WebTestRunner::TestRunner::setGeolocationPermission):
(WebTestRunner::TestRunner::setMockGeolocationPosition):
(WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::numberOfPendingGeolocationPermissionRequests):
(WebViewHost::setGeolocationPermission):
(WebViewHost::setMockGeolocationPosition):
(WebViewHost::setMockGeolocationPositionUnavailableError):

  • DumpRenderTree/chromium/WebViewHost.h:

Jan 19, 2013:

11:14 PM Changeset in webkit [140268] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed build fix for Qt WK2 after r140258.
Use the size_t type instead of unsigned for the variable
which holds the position of the first null character in the
console message.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willAddMessageToConsole):

10:32 PM Changeset in webkit [140267] by pdr@google.com
  • 5 edits
    2 adds in trunk

Refactor SVGSVGElement to inherit from SVGStyledTransformableElement
​https://bugs.webkit.org/show_bug.cgi?id=107393

Reviewed by Dirk Schulze.

Source/WebCore:

This patch refactors SVGSVGElement to inherit from SVGStyledTransformableElement instead
of SVGStyledLocatableElement. In a followup patch, SVGStyledTransformableElement will
be refactored into SVGGraphicsElement which will match the spec:
​https://svgwg.org/svg2-draft/single-page.html#struct-InterfaceSVGSVGElement

Tests: svg/transforms/svgsvgelement-transform-expected.svg

svg/transforms/svgsvgelement-transform.svg

  • svg/SVGSVGElement.cpp:

(WebCore):
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::didMoveToNewDocument):
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):

  • svg/SVGSVGElement.h:

(SVGSVGElement):

  • svg/SVGSVGElement.idl:

LayoutTests:

  • svg/transforms/svgsvgelement-transform-expected.svg: Added.
  • svg/transforms/svgsvgelement-transform.svg: Added.
9:04 PM Changeset in webkit [140266] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk

Delete webkit-perf.appspot.com code from WebKit repository
​https://bugs.webkit.org/show_bug.cgi?id=107390

Reviewed by Adam Barth.

Delete webkit-perf.appspot.com code from WebKit repository since I maintain
and push the code via ​https://github.com/rniwa/webkit-perf now.

  • Websites/webkit-perf.appspot.com: Removed.
7:12 PM Changeset in webkit [140265] by pdr@google.com
  • 67 edits
    1 move
    2 deletes in trunk

Merge SVGStylable into SVGStyledElement
​https://bugs.webkit.org/show_bug.cgi?id=106877

.:

Reviewed by Dirk Schulze.

SVG2 changes element inheritance so all SVGElements are stylable. As a first-step towards a
cleaner class hierarchy, this patch moves SVGStylable into SVGStyledElement.

  • wscript:

Source/WebCore:

Reviewed by Dirk Schulze.

SVG2 changes element inheritance so all SVGElements are stylable. As a first-step towards a
cleaner class hierarchy, this patch moves SVGStylable into SVGStyledElement.

No new tests as this is just a refactoring.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMSVG.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • page/DOMWindow.idl:
  • svg/SVGAElement.idl:
  • svg/SVGAllInOne.cpp:
  • svg/SVGCircleElement.idl:
  • svg/SVGClipPathElement.idl:
  • svg/SVGDefsElement.idl:
  • svg/SVGDescElement.idl:
  • svg/SVGEllipseElement.idl:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFEComponentTransferElement.idl:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDiffuseLightingElement.idl:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEDropShadowElement.idl:
  • svg/SVGFEFloodElement.idl:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEImageElement.idl:
  • svg/SVGFEMergeElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFEOffsetElement.idl:
  • svg/SVGFESpecularLightingElement.idl:
  • svg/SVGFETileElement.idl:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGFilterElement.idl:
  • svg/SVGFilterPrimitiveStandardAttributes.idl:
  • svg/SVGForeignObjectElement.idl:
  • svg/SVGGElement.idl:
  • svg/SVGGlyphRefElement.idl:
  • svg/SVGGradientElement.idl:
  • svg/SVGImageElement.idl:
  • svg/SVGLineElement.idl:
  • svg/SVGMarkerElement.idl:
  • svg/SVGMaskElement.idl:
  • svg/SVGMissingGlyphElement.idl:
  • svg/SVGPathElement.idl:
  • svg/SVGPatternElement.idl:
  • svg/SVGPolygonElement.idl:
  • svg/SVGPolylineElement.idl:
  • svg/SVGRectElement.idl:
  • svg/SVGSVGElement.idl:
  • svg/SVGStopElement.idl:
  • svg/SVGStylable.cpp: Removed.
  • svg/SVGStylable.h: Removed.
  • svg/SVGStylable.idl: Removed.
  • svg/SVGStyledElement.h:

(WebCore):

  • svg/SVGStyledElement.idl: Added.
  • svg/SVGSwitchElement.idl:
  • svg/SVGSymbolElement.idl:
  • svg/SVGTextContentElement.idl:
  • svg/SVGTitleElement.idl:
  • svg/SVGUseElement.idl:

Source/WebKit/mac:

SVG2 changes element inheritance so all SVGElements are stylable. As a first-step towards a
cleaner class hierarchy, this patch moves SVGStylable into SVGStyledElement.

Reviewed by Dirk Schulze.

  • MigrateHeaders.make:
5:30 PM Changeset in webkit [140264] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r140260.
​http://trac.webkit.org/changeset/140260
​https://bugs.webkit.org/show_bug.cgi?id=107387

breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
nothing else) (Requested by thakis on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-19

  • Scripts/update-webkit-chromium:
5:00 PM Changeset in webkit [140263] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

CanvasRenderingContext2D::drawTextInternal should create a mask buffer compatible with that of the canvas
​https://bugs.webkit.org/show_bug.cgi?id=107372

Reviewed by Simon Fraser.

No new tests, just matching acceleration modes.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal): Create a buffer with the same acceleration mode as the canvas
instead of forcing the use of an accelerated buffer if we support acceleration; the canvas could be unaccelerated
even if USE(IOSURFACE_CANVAS_BACKING_STORE) is on.

4:10 PM Changeset in webkit [140262] by mikhail.pozdnyakov@intel.com
  • 7 edits in trunk

Delegated scrolling: Assertion on attempt to show a CSS sticky element
​https://bugs.webkit.org/show_bug.cgi?id=106890

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The problem was that frame view (when delegated scrolling enabled) calculated the positions of sticky elements for
a scroll event before sending scroll request. In case of multiple scroll events that caused assertion as the response
for previous scroll request was received after the expected sticky elements positions had been already updated for the following
scroll request.

No new tests. Covered by existing 'fast/css/sticky' tests.

  • page/FrameView.cpp:

(WebCore::FrameView::setFixedVisibleContentRect):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollTo):

Tools:

Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::shouldUseFixedLayout):
(WTR):
(WTR::updateLayoutType):

LayoutTests:

Skipped failing css/sticky tests on WK2 EFL.

  • platform/efl-wk2/TestExpectations:
4:05 PM Changeset in webkit [140261] by rakuco@webkit.org
  • 10 edits in trunk

Remove the `svn:executable' property from some EFL files.

2:44 PM Changeset in webkit [140260] by thakis@chromium.org
  • 2 edits in trunk/Tools

Make ninja the default build system for build-webkit --chromium on mac
​https://bugs.webkit.org/show_bug.cgi?id=106737

Reviewed by Eric Seidel.

  • Scripts/update-webkit-chromium:
1:47 PM Changeset in webkit [140259] by ggaren@apple.com
  • 16 edits
    2 adds in trunk/Source/JavaScriptCore

Track inheritance structures in a side table, instead of using a private
name in each prototype
​https://bugs.webkit.org/show_bug.cgi?id=107378

Reviewed by Sam Weinig and Phil Pizlo.

This is a step toward object size inference.

Using a side table frees us to use a more complex key (a pair of
prototype and expected inline capacity).

It also avoids ruining inline caches for prototypes. (Adding a new private
name for a new inline capacity would change the prototype's structure,
possibly firing watchpoints, making inline caches go polymorphic, and
generally causing us to have a bad time.)

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri: Buildage.
  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation): Updated to use new side table API.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::cacheInheritorID): Updated to use new side table API.

(JSC::JSFunction::visitChildren): Fixed a long-standing bug where JSFunction
forgot to visit one of its data members (m_cachedInheritorID). This
wasn't a user-visible problem before because JSFunction would always
visit its .prototype property, which visited its m_cachedInheritorID.
But now, function.prototype only weakly owns function.m_cachedInheritorID.

  • runtime/JSGlobalData.h:

(JSGlobalData): Added the map, taking care to make sure that its
destructor would run after the heap destructor.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset): Updated to use new side table API.

  • runtime/JSObject.cpp:

(JSC::JSObject::notifyPresenceOfIndexedAccessors):
(JSC::JSObject::setPrototype):

  • runtime/JSObject.h:

(JSObject): Updated to use new side table API, and removed lots of code
that used to manage the per-object private name.

  • runtime/JSProxy.cpp:

(JSC::JSProxy::setTarget):

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorCreate):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::finishCreation): Updated to use new side table API.

  • runtime/PrototypeMap.cpp: Added.

(JSC):
(JSC::PrototypeMap::addPrototype):
(JSC::PrototypeMap::emptyObjectStructureForPrototype):

  • runtime/PrototypeMap.h: Added.

(PrototypeMap):
(JSC::PrototypeMap::isPrototype):
(JSC::PrototypeMap::clearEmptyObjectStructureForPrototype): New side table.
This is a simple weak map, mapping an object to the structure you should
use when inheriting from that object. (In future, inline capacity will
be a part of the mapping.)

I used two maps to preserve existing behavior that allowed us to speculate
about an object becoming a prototype, even if it wasn't one at the moment.
However, I suspect that behavior can be removed without harm.

  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::contains):
(WeakGCMap): I would rate myself a 6 / 10 in C++.

1:11 PM Changeset in webkit [140258] by commit-queue@webkit.org
  • 5 edits in trunk

[WK2] svg/dom/fuzz-path-parser.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=107133

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2013-01-19
Reviewed by Alexey Proskuryakov.

Tools:

Console messages can contain null characters before the end of string.
Appending such message to the StringBuilder as a WTFString appends the
complete string, including the null character. This later cuts off everything
after the null character when the string is being printed out to the test
output.

To avoid this, truncate the string up to the first null character. This
preserves the newline character appended immediately after this and
stops giving incorrect output.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willAddMessageToConsole):

LayoutTests:

Unskip the now-passing test.

  • platform/gtk-wk2/TestExpectations:
  • platform/wk2/TestExpectations:
1:02 PM Changeset in webkit [140257] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/TestExpectations: sticky-top-zoomed.html marked as ImageOnlyFailure.
12:39 PM Changeset in webkit [140256] by dominik.rottsches@intel.com
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/TestExpectations: Accessibility test now marked as failing.
  • platform/efl/inspector/editor/text-editor-highlight-regexp-expected.txt: New baseline without warnings.
12:28 PM Changeset in webkit [140255] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Managing IndexedDB failures still lingering around after the IDB support was enabled.

  • platform/gtk/TestExpectations:
11:43 AM Changeset in webkit [140254] by dominik.rottsches@intel.com
  • 2 edits
    1 copy in trunk/LayoutTests

[EFL] Unreviewed gardening.

Revert accidental global expectation override.

Patch by Dominik Röttsches <Dominik Röttsches <​dominik.rottsches@intel.com>> on 2013-01-19

  • fast/css/css2-system-fonts-expected.txt: Reverted.
  • platform/efl/fast/css/css2-system-fonts-expected.txt: Copied from LayoutTests/fast/css/css2-system-fonts-expected.txt.
11:22 AM Changeset in webkit [140253] by dominik.rottsches@intel.com
  • 24 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

A couple of missing rebaselines after enabling subpixel layout and updating freetype.

Patch by Dominik Röttsches <Dominik Röttsches <​dominik.rottsches@intel.com>> on 2013-01-19

  • fast/css/css2-system-fonts-expected.txt:
  • platform/efl-wk2/editing/selection/move-by-character-6-expected.png:
  • platform/efl-wk2/editing/selection/move-by-character-6-expected.txt:
  • platform/efl/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/efl/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
  • platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
  • platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
  • platform/efl/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/efl/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/efl/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/efl/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/efl/fast/js/global-constructors-expected.txt:
  • platform/efl/fast/profiler/apply-expected.txt:
  • platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
  • platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
  • platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt:
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-expected.png:
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
  • platform/efl/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/efl/inspector/editor/text-editor-highlight-regexp-expected.txt:
9:15 AM Changeset in webkit [140252] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][WebGL] Regression: WebGL Content is not drawn after resizing the canvas.
​https://bugs.webkit.org/show_bug.cgi?id=107366

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2013-01-19
Reviewed by Kenneth Rohde Christiansen.

Window is shared between GraphicsSurface and its client.
Client doesn't own the Window. This patch ensures that client
doesn't delete the shared Window handle.

Covered by existing WebGL tests.

  • platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::clear):

8:23 AM Changeset in webkit [140251] by dominik.rottsches@intel.com
  • 3 edits
    43 adds in trunk/LayoutTests

[EFL] Unreviewed gardening.

Rebaseline after enabling subpixel layout and updating freetype (26/26).

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2013-01-19

  • platform/efl-wk2/TestExpectations:
  • platform/efl-wk2/media/
  • platform/efl-wk2/webaudio/
8:17 AM Changeset in webkit [140250] by dominik.rottsches@intel.com
  • 1 edit
    556 adds in trunk/LayoutTests

[EFL] Unreviewed gardening.

Rebaseline after enabling subpixel layout and updating freetype (25/26).

  • platform/efl/fast/css/
  • platform/efl/fast/css3-text/
  • platform/efl/fast/dom/
  • platform/efl/fast/encoding/
  • platform/efl/fast/events/
  • platform/efl/fast/flexbox/
  • platform/efl/fast/forms/
  • platform/efl/fast/frames/
  • platform/efl/fast/gradients/
  • platform/efl/fast/history/
  • platform/efl/fast/html/
  • platform/efl/fast/images/
  • platform/efl/fast/
  • platform/efl/fast/inline/
  • platform/efl/fast/layers/
  • platform/efl/fast/line-grid/
  • platform/efl/fast/lists/
  • platform/efl/fast/multicol/
  • platform/efl/fast/overflow/
  • platform/efl/fast/parser/
  • platform/efl/fast/profiler/
  • platform/efl/fast/reflections/
  • platform/efl/fast/regions/
  • platform/efl/fast/repaint/
  • platform/efl/fast/replaced/
  • platform/efl/fast/ruby/
  • platform/efl/fast/selectors/
  • platform/efl/fast/table/
  • platform/efl/fast/text/
  • platform/efl/fast/transforms/
  • platform/efl/fast/writing-mode/
  • platform/efl/http/
  • platform/efl/ietestcenter/
  • platform/efl/inspector/
  • platform/efl/svg/
  • platform/efl/tables/

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2013-01-19

7:55 AM Changeset in webkit [140249] by dominik.rottsches@intel.com
  • 231 edits
    2 copies
    274 adds in trunk/LayoutTests

[EFL] Unreviewed gardening.

Rebaseline after enabling subpixel layout and updating freetype (24/26).

  • platform/efl/accessibility/
  • platform/efl/animations/
  • platform/efl/compositing/
  • platform/efl/css1/
  • platform/efl/css2.1/
  • platform/efl/css3/
  • platform/efl/editing/
  • platform/efl/fast/
  • platform/efl/fast/backgrounds/
  • platform/efl/fast/block/
  • platform/efl/fast/borders/
  • platform/efl/fast/box-shadow/
  • platform/efl/fast/box-sizing/
  • platform/efl/fast/canvas/
  • platform/efl/fast/clip/
  • platform/efl/fast/compact/
  • platform/efl/fast/css-generated-content/
  • platform/efl/fast/css/
  • platform/efl/tables/
  • platform/efl/transforms/
  • platform/efl/transitions/

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2013-01-19

7:35 AM Changeset in webkit [140248] by dominik.rottsches@intel.com
  • 502 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Rebaseline after enabling subpixel layout and updating freetype (23/26).

  • platform/efl/tables/

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2013-01-19

7:17 AM Changeset in webkit [140247] by dominik.rottsches@intel.com
  • 502 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Rebaseline after enabling subpixel layout and updating freetype (22/26).

  • platform/efl/tables/

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2013-01-19

7:05 AM Changeset in webkit [140246] by dominik.rottsches@intel.com
  • 502 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Rebaseline after enabling subpixel layout and updating freetype (21/26).

  • platform/efl/tables/

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2013-01-19

6:54 AM Changeset in webkit [140245] by dominik.rottsches@intel.com
  • 502 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Rebaseline after enabling subpixel layout and updating freetype (20/26).

  • platform/efl/svg/dynamic-updates/
  • platform/efl/svg/filters/
  • platform/efl/svg/foreignObject/
  • platform/efl/svg/hixie/
  • platform/efl/svg/in-html/
  • platform/efl/svg/overflow/
  • platform/efl/svg/repaint/
  • platform/efl/svg/stroke/
  • platform/efl/svg/text/
  • platform/efl/svg/transforms/
  • platform/efl/svg/wicd/
  • platform/efl/svg/zoom/
  • platform/efl/tables/

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2013-01-19

6:34 AM Changeset in webkit [140244] by Antti Koivisto
  • 101 edits in trunk/Source

Make renderer constructors take Element where possible
​https://bugs.webkit.org/show_bug.cgi?id=107138

Reviewed by David Hyatt.

Tighter typing prevents bugs and enables optimizations.

The patch changes how anonymous rendererer are constructed. Previously Document* as the node parameter
indicated that the renderer was anonymous. This forced the code to operate on ContainerNodes (Document
is not an Element). Now anonymous renderers are constructed by passing null and the document is set by
separate setDocumentForAnonymous() call. The patch uses RenderFoo::createAnonymous() pattern consistently.

Most constructors are switched to take Element. RenderBlock still takes ContainerNode due to a few subclasses
(RenderView and RenderFlowThread) that pass in a Document.

  • page/FrameView.cpp:

(WebCore::FrameView::updateScrollCorner):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::createAnonymous):
(WebCore::RenderBlock::createReplacementRunIn):
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
(WebCore::RenderBlock::createAnonymousColumnsWithParentRenderer):
(WebCore::RenderBlock::createAnonymousColumnSpanWithParentRenderer):

  • rendering/RenderBlock.h:
  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
(WebCore::RenderDeprecatedFlexibleBox::createAnonymous):

  • rendering/RenderDeprecatedFlexibleBox.h:

(RenderDeprecatedFlexibleBox):

  • rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::RenderDetailsMarker):

  • rendering/RenderDetailsMarker.h:

(RenderDetailsMarker):

  • rendering/RenderDialog.h:

(WebCore::RenderDialog::RenderDialog):

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::RenderFieldset):

  • rendering/RenderFieldset.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::RenderFlexibleBox):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):

  • rendering/RenderFlowThread.h:
  • rendering/RenderFullScreen.cpp:

(RenderFullScreenPlaceholder::RenderFullScreenPlaceholder):
(RenderFullScreen::RenderFullScreen):
(RenderFullScreen::createAnonymous):
(RenderFullScreen::wrapRenderer):

  • rendering/RenderFullScreen.h:

(RenderFullScreen):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::RenderGrid):

  • rendering/RenderGrid.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::createAnonymous):

  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::RenderInline):
(WebCore::RenderInline::createAnonymous):
(WebCore::RenderInline::addChildIgnoringContinuation):

  • rendering/RenderInline.h:

(RenderInline):
(WebCore::RenderInline::node):

Add version with covariant Element return type.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollCornerStyle):
(WebCore::RenderLayer::updateResizerStyle):
(WebCore::RenderLayer::createReflection):
(WebCore::RenderListItem::RenderListItem):
(WebCore::RenderListItem::styleDidChange):

  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::RenderListMarker):
(WebCore::RenderListMarker::createAnonymous):

  • rendering/RenderListMarker.h:
  • rendering/RenderMediaControlElements.cpp:

(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
(WebCore::RenderTextTrackContainerElement::RenderTextTrackContainerElement):

  • rendering/RenderMediaControlElements.h:

(RenderMediaVolumeSliderContainer):
(RenderMediaControlTimeDisplay):
(RenderTextTrackContainerElement):

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::ensureColumnSets):

  • rendering/RenderMultiColumnBlock.h:
  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):

  • rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::createAnonymous):

  • rendering/RenderMultiColumnSet.h:

(RenderMultiColumnSet):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):

  • rendering/RenderNamedFlowThread.h:

(RenderNamedFlowThread):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):

  • rendering/RenderObject.h:


Passed in null node indicates that the renderer is anonymous. Remove now unnecessary setIsAnonymous() function.

(WebCore::RenderObject::isAnonymous):
(WebCore::RenderObject::setDocumentForAnonymous):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):

  • rendering/RenderRegion.h:
  • rendering/RenderRegionSet.cpp:

(WebCore::RenderRegionSet::RenderRegionSet):

  • rendering/RenderRegionSet.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::RenderReplaced):

  • rendering/RenderReplaced.h:
  • rendering/RenderReplica.cpp:

(WebCore::RenderReplica::RenderReplica):
(WebCore::RenderReplica::createAnonymous):

  • rendering/RenderReplica.h:

(RenderReplica):

  • rendering/RenderRuby.cpp:

(WebCore::createAnonymousRubyInlineBlock):
(WebCore::RenderRubyAsInline::RenderRubyAsInline):
(WebCore::RenderRubyAsBlock::RenderRubyAsBlock):

  • rendering/RenderRuby.h:

(RenderRubyAsInline):
(RenderRubyAsBlock):

  • rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::RenderRubyBase):
(WebCore::RenderRubyBase::createAnonymous):

  • rendering/RenderRubyBase.h:

(RenderRubyBase):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):

  • rendering/RenderRubyRun.h:
  • rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::RenderRubyText):

  • rendering/RenderRubyText.h:
  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::updateScrollbarPart):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::RenderScrollbarPart):
(WebCore::RenderScrollbarPart::createAnonymous):

  • rendering/RenderScrollbarPart.h:

(RenderScrollbarPart):

  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::RenderSearchField):

  • rendering/RenderSearchField.h:

(RenderSearchField):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::createAnonymousWithParentRenderer):

  • rendering/RenderTable.h:
  • rendering/RenderTableCaption.cpp:

(WebCore::RenderTableCaption::RenderTableCaption):

  • rendering/RenderTableCaption.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):
(WebCore::RenderTableCell::createAnonymousWithParentRenderer):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::RenderTableCol):

  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::RenderTableRow):
(WebCore::RenderTableRow::createAnonymousWithParentRenderer):

  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::createAnonymousWithParentRenderer):

  • rendering/RenderTableSection.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::RenderText):

Pass null and use setDocumentForAnonymous() if a RenderText is created with the Document as renderer
to keep them working. Text renderers should be factored similarly to the rest.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::RenderTextControl):

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):

  • rendering/RenderTextControlMultiLine.h:

(RenderTextControlMultiLine):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):

  • rendering/RenderTextControlSingleLine.h:

(RenderTextControlSingleLine):
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):

  • rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::RenderTextTrackCue):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::RenderWidget):

  • rendering/RenderWidget.h:
  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::createAnonymousMathMLBlock):

  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::createMathMLOperator):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createGlyph):

  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::RenderMathMLRow):
(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):

  • rendering/mathml/RenderMathMLRow.h:
  • rendering/style/ContentData.cpp:

(WebCore::ImageContentData::createRenderer):

  • rendering/svg/RenderSVGBlock.cpp:

(WebCore::RenderSVGBlock::RenderSVGBlock):

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::RenderSVGInline):

  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGTSpan.cpp:

(WebCore::RenderSVGTSpan::RenderSVGTSpan):

  • rendering/svg/RenderSVGTSpan.h:
  • rendering/svg/RenderSVGTextPath.cpp:

(WebCore::RenderSVGTextPath::RenderSVGTextPath):

  • rendering/svg/RenderSVGTextPath.h:
6:03 AM Changeset in webkit [140243] by dominik.rottsches@intel.com
  • 502 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Rebaseline after enabling subpixel layout and updating freetype (19/26).

  • platform/efl/svg/W3C-SVG-1.1/
  • platform/efl/svg/W3C-SVG-1.2-Tiny/
  • platform/efl/svg/as-background-image/
  • platform/efl/svg/as-border-image/
  • platform/efl/svg/as-image/
  • platform/efl/svg/as-object/
  • platform/efl/svg/batik/
  • platform/efl/svg/carto.net/
  • platform/efl/svg/clip-path/
  • platform/efl/svg/css/
  • platform/efl/svg/dom/
  • platform/efl/svg/dynamic-updates/

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2013-01-19

5:44 AM Changeset in webkit [140242] by dominik.rottsches@intel.com
  • 502 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Rebaseline after enabling subpixel layout and updating freetype (18/26).

  • platform/efl/svg/W3C-I18N/
  • platform/efl/svg/W3C-SVG-1.1-SE/
  • platform/efl/svg/W3C-SVG-1.1/

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2013-01-19

2:59 AM Changeset in webkit [140241] by eric@webkit.org
  • 2 edits in trunk/Tools

Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
​https://bugs.webkit.org/show_bug.cgi?id=107367

Reviewed by Ryosuke Niwa.

Using srcdoc instead of document.write changes the error output
ever so slightly. Clearly we were already trying to ignore these
messages, just not succeeding. This change makes this new test "pass" correctly.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest):

2:25 AM Applications using WebKit edited by zandobersek@gmail.com
Remove invalid content. (diff)
2:21 AM BadContent edited by zandobersek@gmail.com
Adding a spamming account. (diff)
2:10 AM Changeset in webkit [140240] by zandobersek@gmail.com
  • 3 edits
    2 adds in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for tests that regressed after r140202.
  • platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after IDB support was enabled.
  • platform/gtk/http/tests/cache: Added.
  • platform/gtk/http/tests/cache/cancel-multiple-post-xhrs-expected.txt: Added. Required after r140174,

only due to difference in the form of the errors being logged.

1:11 AM Changeset in webkit [140239] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix.

Add the build targets introduced in r140231 to the list.

  • GNUmakefile.list.am:
Note: See TracTimeline for information about the timeline view.