Timeline
Jan 21, 2013:
- 11:39 PM Changeset in webkit [140388] by
-
- 2 edits in trunk/Tools
[Mac] WK1 MiniBrowser should clear delegates before releasing webview
https://bugs.webkit.org/show_bug.cgi?id=107506
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-01-21
Reviewed by Dan Bernstein.
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController dealloc]):
- 11:33 PM Changeset in webkit [140387] by
-
- 2 edits in trunk/Source/WebCore
[V8] ScriptState::isolate() should use Context::GetIsolate()
https://bugs.webkit.org/show_bug.cgi?id=107490
Reviewed by Adam Barth.
Now V8 provides Context::GetIsolate(). We should use it
in ScriptState::isolate().
- bindings/v8/ScriptState.h:
(WebCore::ScriptState::isolate):
(ScriptState):
- 10:42 PM Changeset in webkit [140386] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Missing context menus strings
https://bugs.webkit.org/show_bug.cgi?id=107104
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-01-21
Reviewed by Kenneth Rohde Christiansen.
Add 5 missing localization strings for text direction context menus.
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::contextMenuItemTagRightToLeft):
(WebCore::contextMenuItemTagLeftToRight):
(WebCore::contextMenuItemTagWritingDirectionMenu):
(WebCore::contextMenuItemTagTextDirectionMenu):
(WebCore::contextMenuItemTagDefaultDirection):
- 10:17 PM Changeset in webkit [140385] by
-
- 5 edits4 adds in trunk
Date selection from calendar picker should dispatch 'input' event in addition to 'change' event
https://bugs.webkit.org/show_bug.cgi?id=107427
Reviewed by Kentaro Hara.
Source/WebCore:
According to the specification and Opera's behavior, we should dispatch
not only 'change' event but also 'input' event when a user chooses a
date from the calender picker.
When the user agent changes the element's value on behalf of the user
(e.g. as part of a form prefilling feature), the user agent must follow
these steps:
- If the input event applies, queue a task to fire a simple event
that bubbles named input at the input element.
- If the change event applies, queue a task to fire a simple event
that bubbles named change at the input element.
Tests: platform/chromium/fast/forms/calendar-picker/date-picker-events.html
platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events.html
- html/InputType.cpp:
(WebCore::InputType::setValue): Add DispatchInputAndChangeEvent support.
- html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::didChooseValue):
Use DispatchInputAndChangeEvent, not DispatchChangeEvent.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::pickerIndicatorChooseValue):
Ditto.
LayoutTests:
- platform/chromium/fast/forms/calendar-picker/date-picker-events-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/date-picker-events.html: Added.
- platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events.html: Added.
- 10:13 PM Changeset in webkit [140384] by
-
- 6 edits in trunk/Source
[CHROMIUM] Suppress c4267 build warnings for Win64 targets
https://bugs.webkit.org/show_bug.cgi?id=107499
Reviewed by Abhishek Arya.
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCore.gyp:
Source/Platform:
- Platform.gyp/Platform.gyp:
Source/WebCore:
No new tests. No code changes.
- WebCore.gyp/WebCore.gyp:
- 10:02 PM Changeset in webkit [140383] by
-
- 2 edits in trunk/Source/WebCore
CSSSelector::value() should assert that m_match != Tag.
<http://webkit.org/b/107500>
Reviewed by Anders Carlsson.
Add an assertion to catch anyone trying to extract a value() from a Tag selector.
- css/CSSSelector.h:
(CSSSelector):
(WebCore::CSSSelector::value):
- 9:07 PM Changeset in webkit [140382] by
-
- 4 edits in trunk/Source/WebCore
Move HTML Attribute case-sensitivity logic out of SelectorChecker to HTMLDocument.
https://bugs.webkit.org/show_bug.cgi?id=107460
The case-sensitivity of HTML attributes is defined in HTML spec and is only applicable in HTML documents,
so having this logic in HTMLDocument seems like a good thing.
Reviewed by Eric Seidel.
Refactoring, covered by existing tests.
- css/SelectorChecker.cpp:
(WebCore): Moved code out of here.
(WebCore::isFastCheckableMatch): Changed the callsite to use new location.
(WebCore::SelectorChecker::checkOne): Ditto.
- html/HTMLDocument.cpp:
(WebCore::addLocalNameToSet): Moved the code into here.
(WebCore): Ditto.
(WebCore::createHtmlCaseInsensitiveAttributesSet): Ditto.
(WebCore::HTMLDocument::isCaseSensitiveAttribute): Ditto.
- html/HTMLDocument.h:
(HTMLDocument): Added decl for the newly moved function.
- 9:04 PM Changeset in webkit [140381] by
-
- 2 edits in trunk/Source/WebCore
FrameSelection should use shadowHost instead of shadowAncestorNode
https://bugs.webkit.org/show_bug.cgi?id=107220
Reviewed by Kent Tamura.
shadowAncestorNode() is deprecated and we want to use shadowHost.
Here, all objects calling shadowAncestorNode() is in ShadowDOM, we can safely convert
the call to shadowHost().
No new tests, simple refactoring.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll):
- 7:29 PM Changeset in webkit [140380] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r177962. Requested by
"Yoshifumi Inoue" <yosin@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-21
- DEPS:
- 7:23 PM FeatureFlags edited by
- see r140377 (diff)
- 6:41 PM Changeset in webkit [140379] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] REGRESSION(r139347) roll chromium deps broke webkit-unit-tests
https://bugs.webkit.org/show_bug.cgi?id=106631
Reviewed by Kent Tamura.
Fixed in http://crrev.com/177931 and rolled. Renable these tests.
- tests/WebImageTest.cpp:
- 6:37 PM Changeset in webkit [140378] by
-
- 1 edit1 add in trunk/LayoutTests
[chromium] Update webaudio/realtimeanalyser-fft-sizing.html expectation on Win
Unreviewed gardening.
- platform/chromium-win-xp/webaudio/realtimeanalyser-fft-sizing-expected.txt: Added.
- 6:26 PM Changeset in webkit [140377] by
-
- 20 edits in trunk
Add build flag for Canvas's Path object (disabled by default)
https://bugs.webkit.org/show_bug.cgi?id=107473
Patch by Dirk Schulze <dschulze@adobe.com> on 2013-01-21
Reviewed by Dean Jackson.
.:
Add CANVAS_PATH build flag to build systems.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- configure.ac:
Source/JavaScriptCore:
Add CANVAS_PATH build flag to build systems.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Add CANVAS_PATH build flag to build systems.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
Source/WebKit/chromium:
Add CANVAS_PATH build flag to build systems.
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Add CANVAS_PATH build flag to build systems.
- Configurations/FeatureDefines.xcconfig:
Tools:
Add CANVAS_PATH build flag to build systems.
- Scripts/webkitperl/FeatureList.pm:
WebKitLibraries:
Add CANVAS_PATH build flag to build systems.
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 5:52 PM Changeset in webkit [140376] by
-
- 8 edits in trunk
[EFL][WK2] Add APIs to set/get view source mode
https://bugs.webkit.org/show_bug.cgi?id=106633
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-01-21
Reviewed by Gyuyoung Kim.
Source/WebKit2:
Added APIs to set/get view source mode for enabling to load
the source code of the web page.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_source_mode_set):
(ewk_view_source_mode_get):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setMainFrameInViewSourceMode):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::mainFrameInViewSourceMode):
(WebPageProxy):
Tools:
Added a shotcut 'F8' in Minibrowser to display a source code
of the web page in a new window.
- MiniBrowser/efl/main.c:
(on_key_down):
(on_window_create):
(window_create):
(elm_main):
- 5:44 PM Changeset in webkit [140375] by
-
- 2 edits in trunk/Tools
[chromium] Don't archive generated source files.
https://bugs.webkit.org/show_bug.cgi?id=106736
Reviewed by Eric Seidel.
They shouldn't be needed to run tests. They don't need a lot of space,
but add many lines to the "extracting" stdout. This attempts to reduce
that noise a bit.
- BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
- 5:39 PM Changeset in webkit [140374] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed gardening. Updating expectations for Mac platforms after r140370.
- platform/chromium-mac-snowleopard/platform/chromium/fast/events: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added.
- 5:04 PM Changeset in webkit [140373] by
-
- 3 edits1 move in trunk/LayoutTests
[chromium] Unreviewed, update baselines after r140358. See also bug 107476.
https://bugs.webkit.org/show_bug.cgi?id=107483
- platform/chromium-mac/fast/block/float/024-expected.txt:
- platform/chromium-mac/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
- platform/chromium/fast/block/float/024-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/block/float/024-expected.txt.
- 5:04 PM Changeset in webkit [140372] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Implement WebInspector::localizedStringsURL() on EFL
https://bugs.webkit.org/show_bug.cgi?id=107363
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-01-21
Reviewed by Benjamin Poulain.
Implement WebInspector::localizedStringsURL() method to return the
file URL of the localizedStrings.js.
This prevents printing warnings about "Localized string not found" in
the console and fixes Web inspector related failing tests on the bots.
- WebProcess/WebPage/efl/WebInspectorEfl.cpp:
(WebKit::WebInspector::localizedStringsURL):
- 4:45 PM Changeset in webkit [140371] by
-
- 20 edits in trunk/Source/WebCore
CSS: Make tag sub-selectors standalone CSSSelectors.
<http://webkit.org/b/107111>
Reviewed by Antti Koivisto.
TL;DR: Instead of storing a QualifiedName with every CSSSelector, special-case tag selectors
by promoting them to stand-alone CSSSelectors.
33% reduction in CSS selector memory usage, 4.77 MB progression on Membuster3.
Fixed some bugs in Shadow DOM that were exposed by these changes.
A selector like this:
div.tripp.trapp#trull { }
Would previously be represented by a chain of 3 CSSSelector objects like so:
[ Tag: "div", Type: Class, Value: "tripp" ]
[ Tag: *, Type: Class, Value: "trapp" ]
[ Tag: *, Type: ID, Value: "trull" ]
After this change, the memory layout becomes:
[ Type: Tag, Value: "div" ]
[ Type: Class, Value: "tripp" ]
[ Type: Class, Value: "trapp" ]
[ Type: ID, Value: "trull" ]
This is a huge net memory win since the majority of selectors don't even have a tag name
and those that do now have a flat cost of one more CSSSelector.
Traversal is also slightly cleaner since any tag name will now be in a predictable place.
- css/SelectorChecker.cpp:
(WebCore::isFastCheckableMatch):
- html/shadow/HTMLContentElement.cpp:
(WebCore::validateSubSelector):
Renamed CSSSelector::None to CSSSelector::Tag.
- css/SelectorChecker.h:
(WebCore::SelectorChecker::tagMatches):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::ruleMatches):
Changed SelectorChecker::tagMatches() to take a QualifiedName instead of a CSSSelector.
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::deref):
(WebCore::QualifiedName::QualifiedNameImpl::~QualifiedNameImpl):
- dom/QualifiedName.h:
(QualifiedNameImpl):
Give QualifiedNameImpl a destructor so it can remove itself from the global cache instead of
having QualifiedName do it. This makes it possible to participate in ownership of QualifiedNames
via a QualifiedNameImpl pointer, as used by the union member in CSSSelector.
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::createFloatingSelectorWithTagName):
(WebCore::CSSParser::updateSpecifiersWithNamespaceIfNeeded):
(WebCore::CSSParser::updateSpecifiersWithElementName):
- css/CSSParser.h:
- css/CSSParserValues.h:
(CSSParserSelector):
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::CSSParserSelector):
(WebCore::CSSParserSelector::prependTagSelector):
Make the CSS parser slap a CSSSelector with m_match=Tag at the head of all selectors that match
one or more of these criteria:
- The selector starts with a tag, e.g "div.foo" or just plain "span"
- There is a @namespace rule in effect, and the override namespace needs to be stored with the selector. These will have CSSSelectors::m_isTagForNamespaceRule set, this is only so that selector serialization can avoid outputting a '*' tag where we previously didn't.
(WebCore::CSSParserSelector::isSimple):
Merged the CSSSelector::isSimple() logic into CSSParserSelector, since it's only needed during parsing
to figure out if a selector is allowed within :not().
- css/CSSSelector.h:
(CSSSelector):
(WebCore::CSSSelector::setValue):
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
(WebCore::CSSSelector::tagQName):
- css/CSSSelector.cpp:
(WebCore::CSSSelector::createRareData):
(WebCore::CSSSelector::operator==):
Add a QualifiedNameImpl* m_tagQName member to the CSSSelector data union. This union pointer is used
if m_match == Tag. tagQName() is used to retrieve the tag (renamed from tag().)
(WebCore::CSSSelector::selectorText):
Only serialize Tag selector components that aren't namespace placeholders. This behavior is web-facing
so we make an effort to stay consistent.
(WebCore::CSSSelector::specificityForOneSelector):
(WebCore::CSSSelector::specificityForPage):
- css/CSSSelectorList.cpp:
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
- css/RuleSet.cpp:
(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
- css/SelectorFilter.cpp:
(WebCore::collectDescendantSelectorIdentifierHashes):
(WebCore::SelectorFilter::collectIdentifierHashes):
Adapt algorithms to having Tag selectors.
(WebCore::selectorListContainsUncommonAttributeSelector):
Loop through all selector components when looking for uncommon attributes.
(WebCore::determinePropertyWhitelistType):
Loop through all selector components when looking for ::cue().
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::findBestRuleSetAndAdd):
Break addRule into two methods to be able to peek ahead if the first selector is a Tag.
Otherwise we'd end up sticking most selectors in m_tagRules, breaking the class/ID/etc optimizations.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::fastCheck):
(WebCore::SelectorChecker::fastCheckSingleSelector):
It's no longer necessary to check the tagQName for every selector component, so don't.
Also simplified the signature of the template argument function.
(WebCore::SelectorChecker::fastCheckRightmostSelector):
Updated for Tag selectors.
(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::matches):
(WebCore::SelectorChecker::match):
Have match() take a SiblingTraversalStrategy so it can forward that to checkOne().
This is necessary for shadow DOM code that was incorrectly calling checkOne() instead of match().
- css/StyleResolver.cpp:
(WebCore::StyleResolver::ruleMatches):
The meaning of "single-part selector" changes a bit with this patch, and no longer includes "div.foo"
as that is now a Tag, followed by a Class. Given that, we can't assume the tag check is unnecessary
just because the rightmost descendant was found in one of the hashes.
(WebCore::StyleResolver::matchPageRulesForList):
Loop through all selector components when matching @page since pseudo types may not always be in
the first subselector now.
- html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::collectSelectFeatureSetFrom):
Collect feature information from subselectors to make sure nothing is missed. (This bug was exposed
by offsetting the subselectors.)
- html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorChecker::checkContentSelector):
Call SelectorChecker::match() instead of checkOne() to make subselector traversal work properly.
- 4:31 PM Changeset in webkit [140370] by
-
- 8 edits1 add in trunk
Event target rects on the top level document shouldn't be clipped.
https://bugs.webkit.org/show_bug.cgi?id=107339
Reviewed by James Robinson.
Source/WebCore:
clippedOverflowRectForRepaint clips the top-level RenderView to the viewport, which
is wrong for generating event target rects, as the result will not extend to the bounds
of the document on pages that scroll. Changing the top-level view to use documentRect
instead.
Tests updated to cover bug: platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html
platform/chromium/fast/events/touch/compositor-touch-hit-rects.html
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::accumulateRendererTouchEventTargetRects): Use converToRootView instead of
a loop around convertToContaining view. This is not a change in behavior.
(WebCore::accumulateDocumentEventTargetRects): Switch to use documentRect instead of
clippedOverflowRectForRepaint for the top-level Document, and use converToRootView
to put rects in the coordinates of the top-level document.
LayoutTests:
Updating existing tests to cover this issue.
- platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
- platform/chromium/fast/events/touch/compositor-touch-hit-rects.html:
- platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt:
- platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html:
- platform/chromium/fast/events/touch/resources/frame-with-document-touch-handler.html: Added.
- platform/chromium/TestExpectations:
- 4:27 PM Changeset in webkit [140369] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r177956. Requested by
thakis_ via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-21
- DEPS:
- 4:03 PM Changeset in webkit [140368] by
-
- 2 edits in trunk/LayoutTests
[chromium] Update expectations.
https://bugs.webkit.org/show_bug.cgi?id=107481
Unreviewed, expectations update.
After https://src.chromium.org/viewvc/chrome?view=rev&revision=177952,
these tests no longer fail on linux.
- platform/chromium/TestExpectations:
- 2:45 PM Changeset in webkit [140367] by
-
- 3 edits in trunk/Source/WebKit2
Enable process suppression by default on Mac
https://bugs.webkit.org/show_bug.cgi?id=106804
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-01-21
Reviewed by Alexey Proskuryakov.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Change initialized value of
m_processSuppressionEnabled from false to true.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitialize): Since process suppression
is no longer disabled on construction, do not disable it for global
child processes either. Instead enable occlusion notifications as
they are needed to trigger process suppression.
- 2:43 PM Changeset in webkit [140366] by
-
- 12 edits in trunk/Source
Add a USE() macro for content filtering code
https://bugs.webkit.org/show_bug.cgi?id=107098
Reviewed by Mark Rowe.
Source/WebCore:
- WebCore.exp.in: Use USE(CONTENT_FILTERING).
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::MainResourceLoader): Ditto.
(WebCore::MainResourceLoader::~MainResourceLoader): Ditto.
(WebCore::MainResourceLoader::cancel): Ditto.
(WebCore::MainResourceLoader::responseReceived): Ditto.
(WebCore::MainResourceLoader::dataReceived): Ditto.
(WebCore::MainResourceLoader::didFinishLoading): Ditto.
(WebCore::MainResourceLoader::notifyFinished): Ditto.
- loader/MainResourceLoader.h:
(MainResourceLoader): Ditto.
- platform/mac/WebCoreSystemInterface.h: Ditto.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Use USE(CONTENT_FILTERING).
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Use USE(CONTENT_FILTERING).
Source/WTF:
- wtf/Platform.h: Define WTF_USE_CONTENT_FILTERING on Mac platforms
more recent than Lion.
- 2:35 PM Changeset in webkit [140365] by
-
- 5 edits2 adds in trunk
[CSS Exclusions] shape-outside on floats for rectangle shapes positioning
https://bugs.webkit.org/show_bug.cgi?id=100399
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-01-21
Reviewed by David Hyatt.
Source/WebCore:
When a float has a shape-outside with non-zero x or y, the float's
exclusion behavior can happen at a completely different location than
where the float's content is painted. This patch brings initial
support for this behavior.
Test: fast/exclusions/shape-outside-floats/shape-outside-floats-positioning.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::flipFloatForWritingModeForChild): If called
during painting, make sure to pass that state down to the float
positioning so that it can use the proper position.
(WebCore::RenderBlock::paintFloats): Since this is concerned with
painting, use the position of the float, not the shape.
(WebCore::RenderBlock::positionNewFloats): Set the correct location
for the float, relative to the location of the shape.
(WebCore::RenderBlock::addOverhangingFloats): Add FIXME.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::xPositionForFloatIncludingMargin):
(WebCore::RenderBlock::yPositionForFloatIncludingMargin): Since the
position of the shape (FloatingObject) can be different from the
position of the float's box (RenderBox), the position needs to be
computed differently for painting than for determining layout.
(WebCore::RenderBlock::flipFloatForWritingModeForChild): Change
signature to take painting flag.
LayoutTests:
- fast/exclusions/shape-outside-floats/shape-outside-floats-positioning-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-positioning.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rectangle-horizontal-multiple.html:
This test had incorrect coordinates for some of the shapes, causing them to break now that x and y are supported for the shapes.
- 2:27 PM Changeset in webkit [140364] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, suppress tests requiring rebaseline after r140358
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 2:21 PM Changeset in webkit [140363] by
-
- 3 edits in trunk/LayoutTests
Unreviewed LayoutTests gardening.
Rebaseline fast/block/margin-collapse/empty-clear-blocks.html
and fast/block/float/024.html after r140358.
- platform/mac/fast/block/float/024-expected.txt:
- platform/mac/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
- 2:20 PM Changeset in webkit [140362] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, suppress tests requiring rebaseline after r140358
- platform/qt/TestExpectations:
- 2:12 PM Changeset in webkit [140361] by
-
- 2 edits in trunk/Tools
Mac DumpRenderTree's installSignalHandlers() is unreachable code
https://bugs.webkit.org/show_bug.cgi?id=107383
Reviewed by Sam Weinig.
The CrashHandler of DumpRenderTree were originally used for restoring
the color profile of the main display even if DRT crashes.
That feature was later limited to pixel tests only in r29999.
In r104351, the DRT was changed to use device color space. Making the crash
handlers useless, but they were left in the code since the error reporting
code was still reachable.
Later, r124581 refactored the code and dumpPixelsForCurrentTest
is being used before being assigned its value.
This did cause any regression because the code had become useless with the previous change.
- DumpRenderTree/mac/DumpRenderTree.mm:
Remove crashHandler() and installSignalHandlers() as they have become useless and
have been unreachable code for 6 months.
(dumpRenderTree):
Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
at those points.
- 2:04 PM Changeset in webkit [140360] by
-
- 2 edits in trunk/Tools
Make ninja the default build system for build-webkit --chromium on mac
https://bugs.webkit.org/show_bug.cgi?id=106737
Reviewed by Eric Seidel.
- Scripts/update-webkit-chromium:
- 2:02 PM Changeset in webkit [140359] by
-
- 21 edits2 adds in trunk/Source/WebCore
Support non-WebVTT cues from in-band text tracks
https://bugs.webkit.org/show_bug.cgi?id=107046
Reviewed by Sam Weinig.
- CMakeLists.txt: Add new files.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Pass video size to getDisplayTree.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::addGenericCue): New, create a generic cue if it doesn't already exist.
(WebCore::InbandTextTrack::addWebVTTCue): Renamed from addCue.
- html/track/InbandTextTrack.h:
- html/track/TextTrack.cpp:
(WebCore::TextTrack::hasCue): Moved from InbandTextTrack.cpp, use operator == instead of inline
comparison so derived TextTrackCues can be compared.
- html/track/TextTrack.h:
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCueBox::applyCSSProperties): Interface change.
(WebCore::TextTrackCue::TextTrackCue): Don't create the display tree in the constructor, it may
never be needed.
(WebCore::TextTrackCue::createDisplayTree): New, create the display tree.
(WebCore::TextTrackCue::displayTreeInternal): Display tree accessor, allows it to be created lazily.
(WebCore::TextTrackCue::setAlign): Alignment -> CueAlignment.
(WebCore::TextTrackCue::setIsActive): Use displayTreeInternal().
(WebCore::TextTrackCue::getDisplayTree): Use displayTreeInternal(), pass video size to applyCSSProperties.
(WebCore::TextTrackCue::removeDisplayTree): Use displayTreeInternal().
(WebCore::TextTrackCue::operator==): New.
- html/track/TextTrackCue.h:
(WebCore::TextTrackCue::getAlignment): Alignment -> CueAlignment.
(WebCore::TextTrackCue::operator!=): New.
(WebCore::TextTrackCue::cueType): New, cue type identified needed by operator==.
(WebCore::TextTrackCue::ownerDocument): New.
- html/track/TextTrackCueGeneric.cpp: Added.
(WebCore::TextTrackCueGenericBox::create):
(WebCore::TextTrackCueGenericBox::TextTrackCueGenericBox):
(WebCore::TextTrackCueGenericBox::applyCSSProperties):
(WebCore:::TextTrackCue):
(WebCore::TextTrackCueGeneric::createDisplayTree):
(WebCore::TextTrackCueGeneric::operator==):
- html/track/TextTrackCueGeneric.h: Added.
(WebCore::TextTrackCueGeneric::create):
(WebCore::TextTrackCueGeneric::~TextTrackCueGeneric):
(WebCore::TextTrackCueGeneric::baseFontSizeRelativeToVideoHeight):
(WebCore::TextTrackCueGeneric::setBaseFontSizeRelativeToVideoHeight):
(WebCore::TextTrackCueGeneric::fontSizeMultiplier):
(WebCore::TextTrackCueGeneric::setFontSizeMultiplier):
(WebCore::TextTrackCueGeneric::fontName):
(WebCore::TextTrackCueGeneric::setFontName):
(WebCore::TextTrackCueGeneric::operator!=):
(WebCore::TextTrackCueGeneric::cueType):
- platform/graphics/InbandTextTrackPrivateClient.h:
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes): Copy cue attributes into GenericCueData
struct instead of trying to convert to WebVTT settings string. Process font size,font base
size, font name, and vertical layout attributes,
(WebCore::InbandTextTrackPrivateAVF::processCue): Create separate cues for each attributed
string in the array because each one can be at a different screen location.
(WebCore::InbandTextTrackPrivateAVF::resetCueValues):
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
(InbandTextTrackPrivateAVF):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Reset any partially accumulated cues
delivered since the seek was started.
(WebCore::MediaPlayerPrivateAVFoundation::addGenericCue): Renamed from flushCurrentCue.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Whitespace cleanup.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Tell legible output to deliver cues
without any additional styling needed by the internal renderer.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Do nothing if asked to change
to the track that is already current.
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):
Check to make sure that the client callback isn't NULL.
- 1:58 PM Changeset in webkit [140358] by
-
- 5 edits2 adds in trunk
Misaligned logo on www.nzherald.co.nz possibly due to negative margin-top
https://bugs.webkit.org/show_bug.cgi?id=14664
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/block/float/clear-negative-margin-top.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseMargins): If a negative margin pulls a block up so that floats from
siblings overhang, then ensure addOverHangingFloats() uses the revised logical top position when
deciding whether a float does indeed overhang into the block after margin-collapsing.
(WebCore::RenderBlock::clearFloatsIfNeeded):
LayoutTests:
- fast/block/float/clear-negative-margin-top-expected.html: Added.
- fast/block/float/clear-negative-margin-top.html: Added.
- platform/chromium-win/fast/block/float/024-expected.txt:
- platform/chromium-win/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
- 1:31 PM Changeset in webkit [140357] by
-
- 2 edits in tags/Safari-537.26.3/Source/WebKit2
Merged r140351. <rdar://problem/13015294>
- 1:27 PM Changeset in webkit [140356] by
-
- 4 edits in tags/Safari-537.26.3/Source
Versioning.
- 1:26 PM Changeset in webkit [140355] by
-
- 6 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining a few media tests after r140339.
- platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
- platform/gtk/fast/layers/video-layer-expected.txt:
- platform/gtk/media/media-controls-clone-expected.txt:
- platform/gtk/media/video-empty-source-expected.txt:
- platform/gtk/media/video-no-audio-expected.txt:
- 1:26 PM Changeset in webkit [140354] by
-
- 1 copy in tags/Safari-537.26.3
New Tag.
- 1:07 PM Changeset in webkit [140353] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r177953. Requested by
thakis_ via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-21
- DEPS:
- 1:05 PM Changeset in webkit [140352] by
-
- 6 edits9 adds in trunk
Proposal: Add support for even-odd fill and clip to Canvas
https://bugs.webkit.org/show_bug.cgi?id=106188
Patch by Rik Cabanier <cabanier@adobe.com> on 2013-01-21
Reviewed by Dirk Schulze.
Source/WebCore:
This patch adds support for an optional winding rule to fill, clip
and isPointInPath in canvas 2d. By default, the fill is non-zero but
you can now pass in an optional winding rule string ("nonzero" or "evenodd")
to make an explicit choice.
Tests: fast/canvas/canvas-clip-rule.html
fast/canvas/canvas-fill-rule.html
fast/canvas/canvas-isPointInPath-winding.html
- html/canvas/CanvasRenderingContext2D.cpp: Change implementation so it sets the windig rule in the context.
(WebCore::parseWinding):
(WebCore):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::clip):
(WebCore::CanvasRenderingContext2D::isPointInPath):
- html/canvas/CanvasRenderingContext2D.h:
(CanvasRenderingContext2D):
- html/canvas/CanvasRenderingContext2D.idl: Change the idl so the new API is exposed to JavaScript.
- platform/graphics/cg/GraphicsContextCG.cpp: Fixes a bug where the wrong winding rule was set for clipping in Core Graphics.
(WebCore::GraphicsContext::clip):
LayoutTests:
Add tests to verify that the winding rule work as expected with clip, fill and isPointInPath
- fast/canvas/canvas-clip-rule-expected.txt: Added.
- fast/canvas/canvas-clip-rule.html: Added.
- fast/canvas/canvas-fill-rule-expected.txt: Added.
- fast/canvas/canvas-fill-rule.html: Added.
- fast/canvas/canvas-isPointInPath-winding-expected.txt: Added.
- fast/canvas/canvas-isPointInPath-winding.html: Added.
- fast/canvas/script-tests/canvas-clip-rule.js: Added.
(pixelDataAtPoint):
(checkResult):
(prepareTestScenario):
- fast/canvas/script-tests/canvas-fill-rule.js: Added.
(pixelDataAtPoint):
(checkResult):
(prepareTestScenario):
- fast/canvas/script-tests/canvas-isPointInPath-winding.js: Added.
(prepareTestScenario):
- 12:51 PM Changeset in webkit [140351] by
-
- 2 edits in trunk/Source/WebKit2
Don't null out the IPC connection in ChildProcess:terminate
https://bugs.webkit.org/show_bug.cgi?id=107469
<rdar://problem/13015294>
Reviewed by Dan Bernstein.
We already invalidate the connection, and Connection::sendMessage checks if a connection
is valid and bails if it isn't, so the only thing that nulling out the connection here does
is that it would force us to add random connection null checks everywhere.
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::terminate):
- 12:22 PM Changeset in webkit [140350] by
-
- 3 edits in trunk/Source/WebCore
[GTK][AC] setOpacity doesn't work for GraphicsLayerClutter
https://bugs.webkit.org/show_bug.cgi?id=105436
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-01-21
Reviewed by Gustavo Noronha Silva.
Implement GraphicsLayerClutter::setOpacity based on Mac's GraphicsLayer implementation.
No new tests since this patch can be covered by already existing gtk ac tests.
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::setOpacity):
(WebCore):
(WebCore::GraphicsLayerClutter::updateOpacityOnLayer):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
- platform/graphics/clutter/GraphicsLayerClutter.h:
- 11:46 AM Changeset in webkit [140349] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Skip spell checking on single character strings
https://bugs.webkit.org/show_bug.cgi?id=107463
Reviewed by Yong Li.
Check for a minimum string length when firing off spellcheck since we don't
want to mark single letter words.
Internally reviewed by Mike Fenton.
- WebKitSupport/InputHandler.cpp:
- WebKitSupport/SpellingHandler.cpp:
(BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
- 11:31 AM Changeset in webkit [140348] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] API unit tests are running extremely slow on the bots
https://bugs.webkit.org/show_bug.cgi?id=104665
Reviewed by Gyuyoung Kim.
Clear HTTP cache files before running the unit tests, which prevents
performance degradation due to so many cache files.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):
- 11:16 AM Changeset in webkit [140347] by
-
- 3 edits3 adds in trunk
[Texmap][GTK] The poster-circle doesn't appear.
https://bugs.webkit.org/show_bug.cgi?id=106672
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-01-21
Reviewed by Noam Rosenthal.
Source/WebCore:
We need to call setNeedsDisplay to redraw GraphicsLayer after we set drawsContent
a new value for the layer. Otherwise we can't get a chance for first drawing the layer.
Test: compositing/visibility/visibility-composited-animation.html
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):
LayoutTests:
A new pixel test is added. It tests if animated layer is drawn for the first scene.
- compositing/visibility/visibility-composited-animation-expected.png: Added.
- compositing/visibility/visibility-composited-animation-expected.txt: Added.
- compositing/visibility/visibility-composited-animation.html: Added.
- 11:03 AM Changeset in webkit [140346] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a test to ensure that content written into a seamless IFrame inherits style.
https://bugs.webkit.org/show_bug.cgi?id=99289
Reviewed by Eric Seidel.
This patch adds a single test to ensure that content written into a
seamless IFrame via 'contentDocument.write()' properly inherits style.
The root of the issue was fixed in wkbug.com/103539, so no code changes
are necesary, but that patch didn't test this particular edge case.
- fast/frames/seamless/seamless-document-write-expected.txt: Added.
- fast/frames/seamless/seamless-document-write.html: Added.
- 10:58 AM Changeset in webkit [140345] by
-
- 2 edits in branches/chromium/1364/Source/WebKit/chromium
[chromium] Unreviewed. Disable <iframe seamless> on the M25 branch.
- 10:44 AM Changeset in webkit [140344] by
-
- 2 edits in trunk/Tools
Regression(r140262): Causes a lot of flakiness
https://bugs.webkit.org/show_bug.cgi?id=107454
Reviewed by Alexey Proskuryakov.
r140262 introduced a lot of flakiness due to fixed layout mode
not getting disabled on the view after being enabled for
specific test cases. This patch makes sure fixed layout mode
properly gets reset in WebKitTestRunner to avoid flakiness.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::updateLayoutType):
- 10:26 AM Changeset in webkit [140343] by
-
- 2 edits1 move1 delete in trunk/LayoutTests
Consolidate and run ARIA-list-and-listitem accessibility test
https://bugs.webkit.org/show_bug.cgi?id=107283
Patch by Brian Holt <brian.holt@samsung.com> on 2013-01-21
Reviewed by Chris Fleizach.
After revision r131674 for bug 99640, the output from
AccessibilityUIElement::role() is consistent across most platforms,
therefore platform specific expections can be consolidated into a
generic expectation with a Mac exception and enabled.
- accessibility/aria-list-and-listitem-expected.txt: Renamed from LayoutTests/platform/chromium/accessibility/aria-list-and-listitem-expected.txt.
- platform/gtk/TestExpectations: Removed passing test.
- platform/gtk/accessibility/aria-list-and-listitem-expected.txt: Removed.
- 9:57 AM Changeset in webkit [140342] by
-
- 2 edits in trunk/Source/WebCore
[EFL][Qt][WebGl] Random crash in GraphicsContext3D::drawArrays
https://bugs.webkit.org/show_bug.cgi?id=107178
Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-01-21
Reviewed by Noam Rosenthal.
Workaround for the problem in mesa when internal llvm pipe object is deleted
later than the screen object. Screen object is deleted because the corresponding
X server display connection closed.
Keep X server display connection open until program shutdown.
OffScreenRootWindow::display is now static, so there is no need to create
OffScreenRootWindow object on client side.
Fixes crash that appears during run of fast/canavs/webgl tests.
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::DisplayConnection::DisplayConnection):
(DisplayConnection):
(WebCore::OffScreenRootWindow::DisplayConnection::~DisplayConnection):
(WebCore::OffScreenRootWindow::DisplayConnection::display):
(WebCore::OffScreenRootWindow::display):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::findFBConfigWithAlpha):
(WebCore::GraphicsSurfacePrivate::clear):
(GraphicsSurfacePrivate):
- 9:10 AM Changeset in webkit [140341] by
-
- 20 edits7 adds in trunk
Implement the HTML <main> element.
https://bugs.webkit.org/show_bug.cgi?id=103172
Patch by Michael[tm] Smith <sideshowbarker (Michael[tm] Smith)> on 2013-01-21
Reviewed by Chris Fleizach.
Source/WebCore:
Authored by Steve Faulkner <faulkner.steve@gmail.com>
<main> should behave the same as <nav>, <section>, and <article>, and <aside>.
<main> should expose AXLandmarkMain correctly on each platform.
Tests: fast/html/main-element.html
platform/chromium/accessibility/main-element.html
platform/mac/accessibility/main-element.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- css/html.css:
(article, aside, footer, header, hgroup, main, nav, section):
- editing/FormatBlockCommand.cpp:
(WebCore::isElementForFormatBlock):
- html/HTMLTagNames.in:
- html/parser/HTMLStackItem.h:
(WebCore::HTMLStackItem::isSpecialNode):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
LayoutTests:
<main> should behave the same as <nav>, <section>, <article>, and <aside>.
<main> has no specific parsing rules.
<main> should expose AXLandmarkMain correctly for each platform.
- editing/execCommand/query-format-block-expected.txt:
- editing/execCommand/remove-format-elements-expected.txt:
- editing/execCommand/remove-format-elements.html:
- editing/execCommand/script-tests/query-format-block.js:
- fast/block/child-not-removed-from-parent-lineboxes-crash.html:
- fast/dom/click-method-on-html-element-expected.txt:
- fast/dom/click-method-on-html-element.html:
- fast/dom/wrapper-classes-expected.txt:
- fast/dom/wrapper-classes.html:
- fast/forms/access-key-for-all-elements-expected.txt:
- fast/forms/access-key-for-all-elements.html:
- fast/html/main-element-expected.txt: Added.
- fast/html/main-element.html: Added.
- fast/html/script-tests/main-element.js: Added.
(getWeight):
- platform/chromium/accessibility/main-element-expected.txt: Added.
- platform/chromium/accessibility/main-element.html: Added.
- platform/chromium/fast/dom/wrapper-classes-expected.txt:
- platform/mac/accessibility/main-element-expected.txt: Added.
- platform/mac/accessibility/main-element.html: Added.
- 8:57 AM Changeset in webkit [140340] by
-
- 4 edits2 adds in trunk
Crash in AccessibilityTableCell::parentTable()
https://bugs.webkit.org/show_bug.cgi?id=107261
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2013-01-21
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/table-destroyed-crash.html
Getting the parent table in order to get the role value should not be
done when objects are being destroyed. Also, it does not seem safe to
assume we have an AXObjectCache.
Moving the logic from roleValue() to determineAccessibilityRole() has
the side effect of not being able to verify the cell is in an AXTable
when that AXTable has not yet been created. Therefore isTableCell()
should look to see if it is the descendant of an AXRow.
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::parentTable):
(WebCore::AccessibilityTableCell::isTableCell):
(WebCore::AccessibilityTableCell::determineAccessibilityRole):
- accessibility/AccessibilityTableCell.h:
(AccessibilityTableCell):
LayoutTests:
Getting the parent table in order to get the role value should not be
done when objects are being destroyed. Also, it does not seem safe to
assume we have an AXObjectCache.
- accessibility/table-destroyed-crash-expected.txt: Added.
- accessibility/table-destroyed-crash.html: Added.
- 8:39 AM Changeset in webkit [140339] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Volume button should not be shown for videos without audio
https://bugs.webkit.org/show_bug.cgi?id=106436
Patch by Halton Huo <halton.huo@intel.com> on 2013-01-21
Reviewed by Philippe Normand.
The volume control is no longer shown for videos with no audio.
No new tests, tested by media/video-no-audio.html.
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::hasOwnDisabledStateHandlingFor):
(WebCore):
- platform/gtk/RenderThemeGtk.h:
- 8:23 AM Changeset in webkit [140338] by
-
- 2 edits in trunk/Source/WebCore
[Soup] Work around a glib bug
https://bugs.webkit.org/show_bug.cgi?id=106789
Reviewed by Martin Robinson.
In glib <= 2.35.4, g_input_stream_skip_async() applied to a
libsoup response stream will do a synchronous skip() in another
thread, which libsoup isn't expecting and doesn't have proper
locking for. Work around this until the next time we bump the glib
requirement by using read_async() (and throwing away the result)
instead of skip_async().
No new tests; fixes a race condition in existing tests with older
glib
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::redirectSkipCallback):
(WebCore::sendRequestCallback):
- 8:17 AM Changeset in webkit [140337] by
-
- 5 edits2 deletes in trunk
REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
https://bugs.webkit.org/show_bug.cgi?id=107421
Source/WebKit2:
Unreviewed buildfix.
- GNUmakefile.list.am:
- UIProcess/API/gtk/WebKitResourceLoadClient.cpp: Removed.
- UIProcess/API/gtk/WebKitResourceLoadClient.h: Removed.
- UIProcess/API/gtk/WebKitWebView.cpp: No longer attach unexisting ResourceLoadClient.
(webkitWebViewConstructed):
Tools:
Unreviewed build fix.
- Scripts/run-gtk-tests:
(TestRunner): skip Resource tests.
- 8:14 AM Changeset in webkit [140336] by
-
- 2 edits in trunk/Source/WebKit/gtk
[Gtk] Dispatching event list into input element.
https://bugs.webkit.org/show_bug.cgi?id=107259
Patch by Oleg Smirnov <oleg.smirnov@lge.com> on 2013-01-21
Reviewed by Martin Robinson.
Clear pending command list after dispatching events.
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::handleKeyboardEvent):
- 8:07 AM Changeset in webkit [140335] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: data grid resize is slow
https://bugs.webkit.org/show_bug.cgi?id=107291
Reviewed by Pavel Feldman.
- avoid (most of) unnecessary relayouts and style recalculation when dragging data grid resizer.
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._positionResizers):
(WebInspector.DataGrid.prototype._resizerDragging):
- 7:33 AM Changeset in webkit [140334] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing test.
https://bugs.webkit.org/show_bug.cgi?id=105574.
- platform/qt/TestExpectations:
- 7:32 AM Changeset in webkit [140333] by
-
- 8 edits in trunk/Source/WebCore
[Inspector] Layout Elements panel in a single column when docked right.
https://bugs.webkit.org/show_bug.cgi?id=107129
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-01-21
Reviewed by Pavel Feldman.
If the Inspector is docked right, the style panes in the Elements panel
are put below the DOM tree pane, not to the right. This behavior
is experimental (hidden behind a new flag "elementsPanelSingleColumn").
No new tests.
- inspector/front-end/DockController.js:
(WebInspector.DockController.prototype.dockSide):
(WebInspector.DockController.prototype._updateUI):
(WebInspector.DockController.prototype._toggleDockState):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.onResize):
(WebInspector.ElementsPanel.prototype._onDockStateChanged):
(WebInspector.ElementsPanel.prototype._sidebarPosition):
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.createSidebarView):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SidebarView.js:
(WebInspector.SidebarView):
(WebInspector.SidebarView.prototype.get mainElement):
(WebInspector.SidebarView.prototype.get sidebarElement):
(WebInspector.SidebarView.prototype._setSidebarElementStyle):
(WebInspector.SidebarView.prototype.setSidebarPosition):
(WebInspector.SidebarView.prototype._innerSetSidebarPosition):
(WebInspector.SidebarView.prototype.setMinimumSidebarHeight):
(WebInspector.SidebarView.prototype.setMinimumMainHeightPercent):
(WebInspector.SidebarView.prototype.applyConstraints):
(WebInspector.SidebarView.prototype.hideMainElement):
(WebInspector.SidebarView.prototype.hideSidebarElement):
- inspector/front-end/SplitView.js:
(WebInspector.SplitView):
- inspector/front-end/splitView.css:
(.split-view-sidebar-top):
(.split-view-sidebar-top.maximized):
(.split-view-sidebar-bottom):
(.split-view-sidebar-bottom.maximized):
- 7:30 AM Changeset in webkit [140332] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: do not serialize native heap graph when collecting information about memory distribution
https://bugs.webkit.org/show_bug.cgi?id=107450
Reviewed by Pavel Feldman.
Native heap graph is not reported when we need to show only high-level memory distribution.
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemorySnapshotView):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
- 6:57 AM Changeset in webkit [140331] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [REGRESSION] Forced :visited pseudoclass has no effect on A elements
https://bugs.webkit.org/show_bug.cgi?id=107448
Reviewed by Antti Koivisto.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::sortAndTransferMatchedRules): Remove totally bad code.
(WebCore::StyleResolver::styleForElement):
Use InsideVisitedLink if PseudoVisited has been forced by Inspector.
- 6:28 AM Changeset in webkit [140330] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt][WK1] Permission request callbacks for non-legacy notifications
https://bugs.webkit.org/show_bug.cgi?id=107438
Reviewed by Jocelyn Turcotte.
Tracks the new callbacks the same way legacy callbacks are tracked.
No test affected yet as we are still lacking support for testing
feature permission callbacks.
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::allowNotificationForFrame):
- WebCoreSupport/NotificationPresenterClientQt.h:
(NotificationPresenterClientQt):
(CallbacksInfo):
- 6:16 AM Changeset in webkit [140329] by
-
- 8 edits in trunk
Web Inspector: modify generate_protocol_externs.py to generate JSON typedef's for @constructors
https://bugs.webkit.org/show_bug.cgi?id=107287
Reviewed by Pavel Feldman.
Source/WebCore:
Modify generate_protocol_externs.py to generate @typedefs instead of @constructors,
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
- inspector/InjectedScriptSource.js:
- inspector/compile-front-end.py:
- inspector/generate_protocol_externs.py:
(param_type):
LayoutTests:
- inspector/console/command-line-api-expected.txt:
- 6:11 AM Changeset in webkit [140328] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r139781.
http://trac.webkit.org/changeset/139781
https://bugs.webkit.org/show_bug.cgi?id=107443
This patch seems to cause flakiness on Qt (Requested by chris-
qBT_work on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-21
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::forceRepaintAsync):
- 5:55 AM Changeset in webkit [140327] by
-
- 2 edits in trunk/Tools
[EFL][WKTR] platformRunUntil() should keep the main loop running
https://bugs.webkit.org/show_bug.cgi?id=107442
Reviewed by Noam Rosenthal.
EFL's implementation of platformRunUntil() should keep the main loop
running and avoid calling sleep() between calls to
ecore_main_loop_iterate(). This call to sleep seems to be a source
of deadlocks (see Bug 106884).
- WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::TestController::platformRunUntil):
- 5:40 AM Changeset in webkit [140326] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Update the documentation about the storage of inspector settings
https://bugs.webkit.org/show_bug.cgi?id=106777
Reviewed by Allan Sandfeld Jensen.
Since r76770, QSettings isn't queried anymore to persist inspector
settings like whether or not the debugger is enabled by default.
It still seems to be used for the default attach height.
Update the documentation accordingly.
- WidgetApi/qwebinspector.cpp:
- 5:34 AM Changeset in webkit [140325] by
-
- 2 edits in trunk/Source/WebCore
[Gtk] [Cairo] Memory leak when is WebView destroy.
https://bugs.webkit.org/show_bug.cgi?id=107112
Patch by Oleg Smirnov <oleg.smirnov@lge.com> on 2013-01-21
Reviewed by Martin Robinson.
Make createSurfaceForBackingStore return a smart pointer in all supported
build configurations to avoid a memory leak.
No new tests. There is memory leak only.
- platform/cairo/WidgetBackingStoreCairo.cpp:
(WebCore::createSurfaceForBackingStore):
- 4:50 AM Changeset in webkit [140324] by
-
- 5 edits in trunk
INPUT_MULTIPLE_FIELDS_UI: should not dispatch 'input' events if the element value is not updated
https://bugs.webkit.org/show_bug.cgi?id=107429
Reviewed by Kentaro Hara.
Source/WebCore:
any time the user causes the element's value to change, the user agent
must queue a task to fire a simple event that bubbles named input at the
input element.
Tests:
fast/forms/time-multiple-fields/time-multiple-fields-keyboard-event.html
is updated to cover this change.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::editControlValueChanged):
If the new value is equivalent to the old value, don't dispatch events.
However we should recalculate validity and call notifyFormStateChanged
because input.validity.badInput state might be changed.
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
- 4:45 AM Changeset in webkit [140323] by
-
- 3 edits in trunk/Tools
QtTestBrowser should provide way to clear selected elements
https://bugs.webkit.org/show_bug.cgi?id=107437
Reviewed by Simon Hausmann.
Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
Invoke the clearSelection prior to highlighting new elements.
- QtTestBrowser/launcherwindow.cpp:
(ElementHighlight):
(LauncherWindow::createChrome):
(LauncherWindow::selectElements):
(LauncherWindow::clearSelection):
- QtTestBrowser/launcherwindow.h:
(LauncherWindow):
- 4:33 AM Changeset in webkit [140322] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Crash in gmail on enabling desktop notifications
https://bugs.webkit.org/show_bug.cgi?id=106699
Patch by David Rosca.
Reviewed by Jocelyn Turcotte.
Protect against callback that may be null. This also matches WebKit2 behaviour.
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::allowNotificationForFrame):
- 4:06 AM Changeset in webkit [140321] by
-
- 5 edits in trunk
Web Inspector: Do not dispatch mousemove when emulating touch event and no touch is active
https://bugs.webkit.org/show_bug.cgi?id=107419
Reviewed by Pavel Feldman.
Source/WebCore:
mousemove event should not be dispatched when emulating touch events and mouse button is not pressed
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
LayoutTests:
- fast/events/touch/emulate-touch-events.html: Test that mousemove is dispatched not more than once and reset the touch event emulation flag in window.internals.settings upon test completion.
- fast/events/touch/emulated-touch-iframe.html: Reset the touch event emulation flag in window.internals.settings upon test completion.
- 3:54 AM Changeset in webkit [140320] by
-
- 3 edits2 adds in trunk
Web Inspector: fix highlight bug in DTE.
https://bugs.webkit.org/show_bug.cgi?id=107433
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-21
Reviewed by Pavel Feldman.
Source/WebCore:
Do not re-create |state.ranges| array when it already contains highlight.
Test: inpector/editor/highlighter-chunk-limit.txt
- inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter.prototype._highlightLines):
LayoutTests:
Add a layout test to cover highlight bug specific situation.
- inspector/editor/highlighter-chunk-limit-expected.txt: Added.
- inspector/editor/highlighter-chunk-limit.html: Added.
- 3:33 AM Changeset in webkit [140319] by
-
- 6 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip some failing.
- platform/qt/TestExpectations:
- platform/qt/editing/input/caret-at-the-edge-of-contenteditable-expected.png: Update after r140202.
- platform/qt/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Update after r140202.
- platform/qt/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Update after r140202.
- platform/qt/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Update after r140202.
- 3:16 AM Changeset in webkit [140318] by
-
- 9 edits in trunk/Tools
[chromium] move methods interacting with willSendRequest to TestRunner
https://bugs.webkit.org/show_bug.cgi?id=107270
Reviewed by Kent Tamura.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::waitForPolicyDelegate):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
(WebTestRunner::WebTestRunner::httpHeadersToClear):
(WebTestRunner::WebTestRunner::shouldBlockRedirects):
(WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::httpHeadersToClear):
(WebTestRunner):
(WebTestRunner::TestRunner::shouldBlockRedirects):
(WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
(WebTestRunner::TestRunner::setWillSendRequestClearHeader):
(WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
(WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::willSendRequest):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::willSendRequest):
(WebViewHost::reset):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 3:10 AM Changeset in webkit [140317] by
-
- 3 edits in trunk/Tools
[GTK] Stop building WebKit2 on GTK EWSs
https://bugs.webkit.org/show_bug.cgi?id=107435
Reviewed by Philippe Normand.
The WebKit2 build of the GTK is at the moment not efficiently maintainable,
so stop building it on GTK EWSs.
- Scripts/webkitpy/common/config/ports.py:
(GtkPort.build_webkit_command):
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_gtk_port):
- 2:33 AM Changeset in webkit [140316] by
-
- 5 edits in trunk/Source/WebCore
[Refactoring] rename StyleRuleBlock -> StyleRuleGroup
https://bugs.webkit.org/show_bug.cgi?id=107415
Reviewed by Antti Koivisto.
StyleRuleBlock should be renamed StyleRuleGroup, because
CSSGroupingRule (not CSSBlockRule) is an interface for an at-rule that
contains other rules nested inside itself:
http://www.w3.org/TR/2012/WD-css3-conditional-20121213/#the-cssgroupingrule-interface
To match the name: CSSGroupingRule, StyleRuleGroup looks better.
No new tests, because just refactoring.
- css/CSSGroupingRule.cpp:
(WebCore::CSSGroupingRule::CSSGroupingRule):
(WebCore::CSSGroupingRule::reattach):
- css/CSSGroupingRule.h:
(CSSGroupingRule):
- css/StyleRule.cpp:
(WebCore::StyleRuleGroup::StyleRuleGroup):
(WebCore::StyleRuleGroup::wrapperInsertRule):
(WebCore::StyleRuleGroup::wrapperRemoveRule):
(WebCore::StyleRuleGroup::reportDescendantMemoryUsage):
(WebCore::StyleRuleMedia::StyleRuleMedia):
(WebCore::StyleRuleSupports::StyleRuleSupports):
(WebCore::StyleRuleRegion::StyleRuleRegion):
- css/StyleRule.h:
(StyleRuleGroup):
(WebCore::StyleRuleHost::StyleRuleHost):
(WebCore::toStyleRuleMedia):
(WebCore::toStyleRuleSupports):
(WebCore::toStyleRuleRegion):
Just replaced StyleRuleBlock with StyleRuleGroup.
- 2:12 AM Changeset in webkit [140315] by
-
- 3 edits in trunk/LayoutTests
Implement MediaStreamEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=107411
Reviewed by Hajime Morita.
Fixed wrong test cases.
- fast/events/constructors/media-stream-event-constructor-expected.txt:
- fast/events/constructors/media-stream-event-constructor.html:
- 1:53 AM Changeset in webkit [140314] by
-
- 5 edits in trunk
Web Inspector: refactoring to use string as argument for highlightRegex API
https://bugs.webkit.org/show_bug.cgi?id=107243
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-21
Reviewed by Pavel Feldman.
Source/WebCore:
Use string as argument for highlightRegex API instead of using regex object.
No new tests: no change in behaviour.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype.highlightRegex):
- inspector/front-end/TextEditor.js:
LayoutTests:
Correct test to correspond to refactoring changes.
- inspector/editor/text-editor-highlight-regexp.html:
- 1:33 AM Changeset in webkit [140313] by
-
- 4 edits in trunk
Unreviewed, rolling out r140311.
http://trac.webkit.org/changeset/140311
https://bugs.webkit.org/show_bug.cgi?id=107431
Broke selection-related tests (Requested by apavlov on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-21
Source/WebCore:
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
LayoutTests:
- fast/events/touch/emulate-touch-events.html:
- 1:11 AM Changeset in webkit [140312] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Build fix.
- bindings/v8/V8NPObject.cpp:
(WebCore::createV8ObjectForNPObject):
- 12:49 AM Changeset in webkit [140311] by
-
- 4 edits in trunk
Web Inspector: Do not dispatch mousemove when emulating touch event and no touch is active
https://bugs.webkit.org/show_bug.cgi?id=107419
Reviewed by Pavel Feldman.
Source/WebCore:
mousemove event should not be dispatched when emulating touch events and mouse button is not pressed
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
LayoutTests:
- fast/events/touch/emulate-touch-events.html: Test that mousemove is dispatched not more than once.
- 12:32 AM Changeset in webkit [140310] by
-
- 20 edits in trunk
MediaStream API: Update the RTCPeerConnection states to match the latest specification
https://bugs.webkit.org/show_bug.cgi?id=107120
Reviewed by Adam Barth.
Source/Platform:
Updating the chromium WebKit API for the new states.
- chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebKit::WebRTCPeerConnectionHandlerClient::~WebRTCPeerConnectionHandlerClient):
(WebRTCPeerConnectionHandlerClient):
(WebKit::WebRTCPeerConnectionHandlerClient::didChangeSignalingState):
(WebKit::WebRTCPeerConnectionHandlerClient::didChangeICEGatheringState):
(WebKit::WebRTCPeerConnectionHandlerClient::didChangeICEConnectionState):
(WebKit::WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel):
(WebKit::WebRTCPeerConnectionHandlerClient::didChangeReadyState):
(WebKit::WebRTCPeerConnectionHandlerClient::didChangeICEState):
Source/WebCore:
http://dev.w3.org/2011/webrtc/editor/webrtc.html#interface-definition
RTCPeerConnection::readyState and iceState are history and instead signalingState,
iceConnectionState and iceGatheringState have been introduced.
Existing tests updated to cover this patch.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):
(WebCore::RTCPeerConnection::updateIce):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::readyState):
(WebCore):
(WebCore::RTCPeerConnection::signalingState):
(WebCore::RTCPeerConnection::iceConnectionState):
(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::removeStream):
(WebCore::RTCPeerConnection::createDataChannel):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::didChangeSignalingState):
(WebCore::RTCPeerConnection::didChangeIceGatheringState):
(WebCore::RTCPeerConnection::didChangeIceConnectionState):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):
(WebCore::RTCPeerConnection::didAddRemoteDataChannel):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::changeSignalingState):
(WebCore::RTCPeerConnection::changeIceGatheringState):
(WebCore::RTCPeerConnection::changeIceConnectionState):
- Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
- Modules/mediastream/RTCPeerConnection.idl:
- platform/mediastream/RTCPeerConnectionHandlerClient.h:
(RTCPeerConnectionHandlerClient):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::didChangeSignalingState):
(WebCore::RTCPeerConnectionHandlerChromium::didChangeICEConnectionState):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):
Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp:
Tools:
Updating mock to use the new states.
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
(MockWebRTCPeerConnectionHandler::initialize):
(MockWebRTCPeerConnectionHandler::updateICE):
LayoutTests:
- fast/mediastream/RTCPeerConnection-datachannel-expected.txt:
- fast/mediastream/RTCPeerConnection-datachannel.html:
- fast/mediastream/RTCPeerConnection-ice-expected.txt:
- fast/mediastream/RTCPeerConnection-ice.html:
- fast/mediastream/RTCPeerConnection-state-expected.txt:
- fast/mediastream/RTCPeerConnection-state.html:
- 12:18 AM Changeset in webkit [140309] by
-
- 8 edits5 deletes in trunk/Source/WebKit2
REGRESSION (r140285): EFL uses WKPageResourceLoadClient which was removed
https://bugs.webkit.org/show_bug.cgi?id=107417
Reviewed by Gyuyoung Kim.
We had no choice but remove the ResourceLoadClientEfl after r140285
and thus our public API signals depending on it. The test_ewk2_auth_request
unit test was skipped because it depends these signals and will be fixed in a
different patch.
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/EwkViewCallbacks.h:
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
- UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
- UIProcess/API/efl/ewk_resource.cpp: Removed.
- UIProcess/API/efl/ewk_resource.h: Removed.
- UIProcess/API/efl/ewk_resource_private.h: Removed.
- UIProcess/API/efl/ewk_view.cpp:
- UIProcess/API/efl/ewk_view.h:
- UIProcess/efl/ResourceLoadClientEfl.cpp: Removed.
- UIProcess/efl/ResourceLoadClientEfl.h: Removed.
- 12:09 AM Changeset in webkit [140308] by
-
- 7 edits in trunk/Source/WebCore
Use ISO8601 date/time formats as fallbacks for date/time input types
https://bugs.webkit.org/show_bug.cgi?id=107418
Reviewed by Kentaro Hara.
We obtain date/time formats from OSes to build date/time input type
UIs. If something wrong happens in the code, fallback formats are
used. Such fallback formats should not be English formats in order that
we can find defects easily.
No new tests. These formats should not be used unless the current code
has defects.
- html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::setupLayoutParameters):
Use an ISO8601 format which is same as a format used in HTML5.
- html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::setupLayoutParameters): Ditto.
- html/MonthInputType.cpp:
(WebCore::MonthInputType::setupLayoutParameters): Ditto.
- html/WeekInputType.cpp:
(WebCore::WeekInputType::setupLayoutParameters): Ditto.
- platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::dateFormat): Ditto.
- platform/text/LocaleNone.cpp:
(WebCore::LocaleNone::dateFormat): Ditto.
(WebCore::LocaleNone::dateTimeFormatWithSeconds): Ditto.
(WebCore::LocaleNone::dateTimeFormatWithoutSeconds): Ditto.
Jan 20, 2013:
- 11:59 PM Changeset in webkit [140307] by
-
- 3 edits4 adds in trunk
Elements must be reattached when inserted/removed from top layer
https://bugs.webkit.org/show_bug.cgi?id=105489
Relanding r139402 as rollout due to suspected perf regression did not help (bug 106726).
Reviewed by Julien Chaffraix.
Source/WebCore:
Ensure a reattach occurs when an element is inserted/removed from top layer, so its renderer can be inserted correctly:
as a child of RenderView in top layer sibling order if it's in the top layer, and in the usual place otherwise.
We previously relied on style recalc to catch when an element is inserted/removed from the top layer, because it
only happens on dialog.show/close which toggle display: none. But that is incorrect because, for example, close()
followed immediately by show() results in no style change.
Tests: fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html
fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html
- dom/Element.cpp:
(WebCore::Element::removedFrom): Call Document::removeFromTopLayer to let the element be removed from the top layer vector.
removeFromTopLayer calls Element::setIsInTopLayer(false) itself if needed.
(WebCore::Element::setIsInTopLayer): Ensure a reattach occurs if the element is already attached.
LayoutTests:
- fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html: Added.
- fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html: Added.
This tests that a top layer element removed from the document does not reappear in the top layer if readded.
This test actually would pass before this patch, but just by good fortune (see bug).
- fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html: Added.
- fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html: Added.
This tests that top layer ordering is correct after removing and readding an element to the top layer.
- 11:50 PM Changeset in webkit [140306] by
-
- 6 edits in trunk
Web Inspector: change HeapSnapshotLoader to allow loading native heap snapshots
https://bugs.webkit.org/show_bug.cgi?id=107282
Reviewed by Pavel Feldman.
Conctete heap snapshot constructor name is passed as a parameter to HeapSnapshotLoaderProxy and
propagated to HeapSnapshotLoader.buildSnapshot to support different types of heap snapshots.
Source/WebCore:
- inspector/front-end/HeapSnapshotLoader.js:
(WebInspector.HeapSnapshotLoader.prototype.buildSnapshot):
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker.prototype.createLoader):
(WebInspector.HeapSnapshotLoaderProxy):
(WebInspector.HeapSnapshotLoaderProxy.prototype.close):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapProfileHeader.prototype._setupWorker):
LayoutTests:
- inspector/profiler/heap-snapshot-loader.html:
- 11:45 PM Changeset in webkit [140305] by
-
- 16 edits2 adds in trunk
Implement MediaStreamEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=107411
Reviewed by Adam Barth.
Spec: http://www.w3.org/TR/webrtc/#mediastreamevent
Test: fast/events/constructors/media-stream-event-constructor.html
Source/WebCore:
- Modules/mediastream/MediaStreamEvent.cpp:
(WebCore::MediaStreamEventInit::MediaStreamEventInit):
(WebCore):
(WebCore::MediaStreamEvent::create):
(WebCore::MediaStreamEvent::MediaStreamEvent):
- Modules/mediastream/MediaStreamEvent.h:
(MediaStreamEventInit):
(WebCore):
(MediaStreamEvent):
- Modules/mediastream/MediaStreamEvent.idl:
- bindings/js/JSDictionary.cpp:
(WebCore):
(WebCore::JSDictionary::convertValue):
- bindings/js/JSDictionary.h:
(WebCore):
- bindings/v8/Dictionary.cpp:
(WebCore):
(WebCore::Dictionary::get):
- bindings/v8/Dictionary.h:
(Dictionary):
LayoutTests:
- fast/events/constructors/media-stream-event-constructor-expected.txt: Added.
- fast/events/constructors/media-stream-event-constructor.html: Added.
- platform/chromium-android/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 11:38 PM Changeset in webkit [140304] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Allow SplitView to change orientation after the construction.
https://bugs.webkit.org/show_bug.cgi?id=107263
Added SplitView.prototype.setIsVertical to change the orientation on the fly.
Instead of passing default sidebar size to the constructor the client
may now pass separate defaults for the sidebar width and height. Passing
just one default works as before.
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-01-20
Reviewed by Pavel Feldman.
No new tests.
- inspector/front-end/SplitView.js:
(WebInspector.SplitView):
(WebInspector.SplitView.prototype.isVertical):
(WebInspector.SplitView.prototype.setIsVertical):
(WebInspector.SplitView.prototype._innerSetIsVertical):
(WebInspector.SplitView.prototype._updateLayout):
(WebInspector.SplitView.prototype.isSidebarSecond):
(WebInspector.SplitView.prototype.showBoth):
(WebInspector.SplitView.prototype._updateTotalSize):
(WebInspector.SplitView.prototype._innerSetSidebarSize):
(WebInspector.SplitView.prototype.wasShown):
(WebInspector.SplitView.prototype.onResize):
(WebInspector.SplitView.prototype.installResizer):
(WebInspector.SplitView.prototype._onDragStart):
(WebInspector.SplitView.prototype._sizeSetting):
(WebInspector.SplitView.prototype._lastSidebarSize):
(WebInspector.SplitView.prototype.get _saveSidebarSize):
- 11:27 PM Changeset in webkit [140303] by
-
- 10 edits in trunk/Source/WebCore
Add a [ConstructorConditional] IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=107407
Reviewed by Adam Barth.
Per discussion in webkit-dev, we need to implement DOM4 event constructors
under a enable flag. For that purpose, we implement a [ConstructorConditional]
IDL attribute.
Test: bindings/scripts/test/TestInterface.idl
- bindings/scripts/CodeGenerator.pm:
(GenerateConstructorConditionalString):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore):
- bindings/scripts/test/JS/JSTestInterface.h:
(JSTestInterfaceConstructor):
- bindings/scripts/test/TestInterface.idl:
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
- 11:18 PM Changeset in webkit [140302] by
-
- 3 edits in trunk/Source/WebCore
[V8] We should set a class id for a NPObject wrapper
https://bugs.webkit.org/show_bug.cgi?id=107249
Reviewed by Adam Barth.
This is one of steps to avoid hitting an ASSERT()
that will be added in https://bugs.webkit.org/show_bug.cgi?id=107137 .
No tests. No change in behavior.
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
(WebCore::V8DOMWrapper::setWrapperClass):
(WebCore):
- bindings/v8/V8NPObject.cpp:
(WebCore::createV8ObjectForNPObject):
- 11:10 PM Changeset in webkit [140301] by
-
- 3 edits in trunk/Tools
Extend diff_parser to support the --full-index output.
https://bugs.webkit.org/show_bug.cgi?id=107408
Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-20
Reviewed by Maciej Stachowiak.
- Scripts/webkitpy/common/checkout/diff_parser.py:
(git_diff_to_svn_diff):
- Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
(DiffParserTest):
(DiffParserTest.test_git_diff_to_svn_diff):
(git_diff_to_svn_diff):
- 11:05 PM Changeset in webkit [140300] by
-
- 45 edits1 copy1 add in trunk
CSS3 calc: unprefix implementation
https://bugs.webkit.org/show_bug.cgi?id=91951
Reviewed by Ojan Vafai.
Source/WebCore:
Add support for the unprefixed 'calc()' function, while retaining support for the prefixed version.
Test: css3/calc/simple-calcs-prefixed.html
- css/CSSCalculationValue.cpp:
(WebCore::buildCssText):
(WebCore::CSSCalcValue::create):
- css/CSSParser.cpp:
(WebCore::CSSParser::isCalculation):
(WebCore::CSSParser::detectFunctionTypeToken):
LayoutTests:
Changed all -webkit-calc() occurrences to calc().
Made a copy of the simplest test file so very basic tests for the prefixed version
are retained.
- css3/calc/background-position-parsing.html:
- css3/calc/block-mask-overlay-image-outset.html:
- css3/calc/border-radius.html:
- css3/calc/border.html:
- css3/calc/box-reflect.html:
- css3/calc/calc-errors.html:
- css3/calc/color-hsl.html:
- css3/calc/color-rgb.html:
- css3/calc/css3-radial-gradients.html:
- css3/calc/cssom-expected.txt:
- css3/calc/cssom.html:
- css3/calc/font-monospace.html:
- css3/calc/font-size-fractional.html:
- css3/calc/font-size.html:
- css3/calc/font.html:
- css3/calc/getComputedStyle-margin-percentage.html:
- css3/calc/gradient-color-stops.html:
- css3/calc/img-size.html:
- css3/calc/line-height.html:
- css3/calc/margin.html:
- css3/calc/negative-padding.html:
- css3/calc/padding.html:
- css3/calc/reflection-computed-style-expected.txt:
- css3/calc/reflection-computed-style.html:
- css3/calc/regression-62276.html:
- css3/calc/simple-calcs-prefixed-expected.txt: Added.
- css3/calc/simple-calcs-prefixed.html: Copied from LayoutTests/css3/calc/simple-calcs.html.
- css3/calc/simple-calcs.html:
- css3/calc/simple-composited-mask.html:
- css3/calc/table-border-spacing.html:
- css3/calc/table-calcs.html:
- css3/calc/table-empty-cells.html:
- css3/calc/transforms-scale.html:
- css3/calc/transforms-translate.html:
- css3/calc/transition-crash.html:
- css3/calc/transition-crash2.html:
- css3/calc/transition-crash3.html:
- css3/calc/transition-crash4.html:
- css3/calc/transitions-dependent.html:
- css3/calc/transitions.html:
- css3/calc/vertical-align-expected.html:
- css3/calc/vertical-align.html:
- css3/calc/zoom-with-em.html:
- 10:59 PM Changeset in webkit [140299] by
-
- 8 edits4 adds in trunk
Distribution state becomes inconsistent with content/shadow reprojection
https://bugs.webkit.org/show_bug.cgi?id=106634
Reviewed by Hajime Morita.
Source/WebCore:
Distribution should be resolved from shallower ShadowDOM to deeper Shadow DOM. However, in the current implementation,
there is a case that distribution for deeper ShadowDOM happens to be resolved before distribution
for shallower ShadowDOM is resolved.
Here, we have 2 problems about distribution.
1) Invalidation state is not propagated to nested (= deeper) ShadowDOM.
- This causes deeper ShadowDOM looks having a valid distribution though it should be invalid.
2) We are not resolving shallower ShadowDOM when deeper ShadowDOM's distribution is needed.
- Because of (1), we have to check all the ancestor ShadowDOM.
For (1), we change invalidate() to invalidate nested ShadowDOM's distribution as well.
For (2), when resolving distribution, we will check the ancestor ShadowDOM's distribution state. If the ancestor's
distribution is not valid, we resolve it first.
For optimization of (1), actually we can skip invalidating distribution of some ShadowDOMs.
If ShadowRoot of deeper ShadowDOM does not have an InsertionPoint as children, we can skip invalidating
its distribution, because only children can be distributed to InsertionPoint.
Tests: fast/dom/shadow/distribution-crash.html
fast/dom/shadow/nested-reprojection-inconsistent.html
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::attach): Should resolve distribution from ancestor.
- dom/ElementShadow.h:
- html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::distribute): Added ASSERT that the parent ShadowRoot's distribution is resolved.
(WebCore::ContentDistributor::invalidate): For each InsertionPoint, we have to invalidate
its parent element's distribution (if it has ElementShadow).
(WebCore::ContentDistributor::ensureDistribution):
- html/shadow/ContentDistributor.h:
(WebCore::ContentDistributor::isValid):
- html/shadow/HTMLShadowElement.cpp:
(WebCore::HTMLShadowElement::olderShadowRoot): Should resolve distribution from ancestor.
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::attach): ditto.
(WebCore::InsertionPoint::detach): ditto.
(WebCore::InsertionPoint::getDistributedNodes): ditto.
(WebCore::resolveReprojection): ditto.
LayoutTests:
- fast/dom/shadow/distribution-crash-expected.txt: Added.
- fast/dom/shadow/distribution-crash.html: Added.
- fast/dom/shadow/nested-reprojection-inconsistent-expected.txt: Added.
- fast/dom/shadow/nested-reprojection-inconsistent.html: Added.
- 10:48 PM Changeset in webkit [140298] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/StylesSidebarPane.js
Merge 139994
Web Inspector: [Spectrum] Color picker in CSS editor does not update textual color value
https://bugs.webkit.org/show_bug.cgi?id=107110
Reviewed by Vsevolod Vlasov.
The Spectrum picker was never told to update the textual color upon user-initiated color changes.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
TBR=apavlov@chromium.org
Review URL: https://codereview.chromium.org/12035003
- 10:13 PM Changeset in webkit [140297] by
-
- 4 edits2 adds in trunk/Source
Make SpeechSynthesis compile in the Chromium port
https://bugs.webkit.org/show_bug.cgi?id=107382
Reviewed by Adam Barth.
Source/WebCore:
Add stubs for the Chromium implementation of speech synthesis,
and add all source and header files to WebCore.gypi. Everything
is behind the ENABLE_SPEECH_SYNTHESIS flag.
- Modules/speech/chromium/SpeechSynthesisChromium.cpp: Added.
(WebCore):
(WebCore::SpeechSynthesis::initializeVoiceList):
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::speaking):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::speak):
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::pause):
(WebCore::SpeechSynthesis::resume):
- WebCore.gypi:
Source/WebKit/chromium:
Add ENABLE_SPEECH_SYNTHESIS to features.gypi, off by default.
- features.gypi:
- 10:10 PM Changeset in webkit [140296] by
-
- 3 edits4 adds in trunk
Re-layout child blocks when border/padding of the box-sizing:border-box parent is updated
https://bugs.webkit.org/show_bug.cgi?id=104997
Reviewed by Tony Chang.
Source/WebCore:
When padding or border is updated for a parent block with
box-sizing:border-box and width, the width of its child block was not
updated.
Tests: fast/css/box-sizing-border-box-dynamic-padding-border-update.html
fast/forms/text/text-padding-dynamic-change.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
If box-sizing of the old style and/or the new style is border-box and
padding or border is changed, apply setChildNeedsLayout(true) for child
boxes.
LayoutTests:
- fast/css/box-sizing-border-box-dynamic-padding-border-update-expected.txt: Added.
- fast/css/box-sizing-border-box-dynamic-padding-border-update.html: Added.
- fast/forms/text/text-padding-dynamic-change-expected.html: Added.
- fast/forms/text/text-padding-dynamic-change.html: Added.
- 10:08 PM Changeset in webkit [140295] by
-
- 4 edits1 delete in trunk/Source/WebCore
[V8] Remove custom V8ScriptProfileCustom::toV8()
https://bugs.webkit.org/show_bug.cgi?id=107246
Reviewed by Adam Barth.
V8ScriptProfileCustom::toV8() needs not to be custom.
Furthermore, the current custom toV8() is wrong in that
it doesn't use a creationContext and it doesn't set a
wrapper class id. This is one of steps to avoiding
ASSERT()s that will be added in
https://bugs.webkit.org/show_bug.cgi?id=107137 .
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/custom/V8ScriptProfileCustom.cpp: Removed.
- inspector/ScriptProfile.idl:
- 9:42 PM Changeset in webkit [140294] by
-
- 4 edits in trunk/Source/WebKit2
Remove support getting per-resource callbacks in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=107405
Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-01-20
Reviewed by Sam Weinig.
EFL, GTK and Qt WebKit2 build fixes after r140285.
Remove from build WebResourceLoadClient.{cpp,h} deleted by r140285.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- 9:23 PM Changeset in webkit [140293] by
-
- 3 edits4 deletes in trunk
Unreviewed, rolling out r140290.
http://trac.webkit.org/changeset/140290
https://bugs.webkit.org/show_bug.cgi?id=107412
Broke tests of inspector and calendar picker in debug build
(Requested by tkent on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-20
Source/WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
LayoutTests:
- fast/css/box-sizing-border-box-dynamic-padding-border-update-expected.txt: Removed.
- fast/css/box-sizing-border-box-dynamic-padding-border-update.html: Removed.
- fast/forms/text/text-padding-dynamic-change-expected.html: Removed.
- fast/forms/text/text-padding-dynamic-change.html: Removed.
- 9:12 PM Changeset in webkit [140292] by
-
- 3 edits7 adds in trunk
Dispatch LongPress to inner frames
https://bugs.webkit.org/show_bug.cgi?id=106874
Patch by Yongsheng Zhu <yongsheng.zhu@intel.com> on 2013-01-20
Reviewed by Antonio Gomes.
Source/WebCore:
Do check whether a LongPress gesture event should be passed
to inner frames. If needed, dispatch it.
Tests: fast/events/touch/gesture/long-press-on-draggable-element-in-iframe-triggers-drag.html
fast/events/touch/gesture/long-press-on-draggable-element-in-nested-iframes-triggers-drag.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureLongPress):
LayoutTests:
- fast/events/touch/gesture/long-press-on-draggable-element-in-iframe-triggers-drag.html: Added.
- fast/events/touch/gesture/long-press-on-draggable-element-in-nested-iframes-triggers-drag.html: Added.
- fast/events/touch/gesture/resources/drag-inside-iframe2.html: Added.
- fast/events/touch/gesture/resources/drag-inside-nested-iframes2.html: Added.
- fast/events/touch/gesture/resources/drag-inside-nested-iframes3.html: Added.
- platform/chromium/fast/events/touch/gesture/long-press-on-draggable-element-in-iframe-triggers-drag-expected.txt: Added.
- platform/chromium/fast/events/touch/gesture/long-press-on-draggable-element-in-nested-iframes-triggers-drag-expected.txt: Added.
- 7:52 PM Changeset in webkit [140291] by
-
- 21 edits in trunk/Source/WebCore
Clean up missing *explicit* keyword in ctors of WebCore/rendering.
https://bugs.webkit.org/show_bug.cgi?id=107373
Reviewed by Darin Adler.
Need to add *explicit* keyword to avoid implicit type conversion.
- rendering/RenderApplet.h:
(RenderApplet):
- rendering/RenderArena.h:
(RenderArena):
- rendering/RenderBR.h:
(RenderBR):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderDetailsMarker.h:
(RenderDetailsMarker):
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
- rendering/RenderFlowThread.h:
- rendering/RenderFullScreen.h:
(RenderFullScreen):
- rendering/RenderGeometryMap.h:
(WebCore::RenderGeometryMapStep::RenderGeometryMapStep):
- rendering/RenderGrid.h:
(RenderGrid):
- rendering/RenderImage.h:
(RenderImage):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- rendering/RenderLayerModelObject.h:
(RenderLayerModelObject):
- rendering/RenderListBox.h:
(RenderListBox):
- rendering/RenderListMarker.h:
(RenderListMarker):
- rendering/RenderMedia.h:
(RenderMedia):
- rendering/RenderMeter.h:
(RenderMeter):
- rendering/RenderMultiColumnBlock.h:
(RenderMultiColumnBlock):
- rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
- rendering/RenderObject.h:
(RenderObject):
- rendering/RenderPart.h:
(RenderPart):
- rendering/RenderProgress.h:
(RenderProgress):
- rendering/RenderReplaced.h:
(RenderReplaced):
- rendering/RenderReplica.h:
(RenderReplica):
- rendering/RenderRuby.h:
(RenderRubyAsInline):
- rendering/RenderRubyBase.h:
(RenderRubyBase):
- rendering/RenderRubyRun.h:
(RenderRubyRun):
- rendering/RenderRubyText.h:
(RenderRubyText):
- rendering/RenderSearchField.h:
(RenderSearchField):
- rendering/RenderSlider.h:
(RenderSlider):
- rendering/RenderSnapshottedPlugIn.h:
(RenderSnapshottedPlugIn):
- rendering/RenderTextControlMultiLine.h:
(RenderTextControlMultiLine):
- rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
- rendering/RenderView.h:
(RenderView):
- rendering/RenderWidgetProtector.h:
(WebCore::RenderWidgetProtector::RenderWidgetProtector):
- rendering/RootInlineBox.h:
(RootInlineBox): Remove meaningless parameter name.
- rendering/TableLayout.h:
(WebCore::TableLayout::TableLayout):
- 6:40 PM Changeset in webkit [140290] by
-
- 3 edits5 adds in trunk
Re-layout child blocks when border/padding of the box-sizing:border-box parent is updated
https://bugs.webkit.org/show_bug.cgi?id=104997
Reviewed by Tony Chang.
Source/WebCore:
When padding or border is updated for a parent block with
box-sizing:border-box and width, the width of its child block was not
updated.
Tests: fast/css/box-sizing-border-box-dynamic-padding-border-update.html
fast/forms/text/text-padding-dynamic-change.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
If box-sizing of the old style and/or the new style is border-box and
padding or border is changed, apply setChildNeedsLayout(true) for child
boxes.
LayoutTests:
- fast/css/box-sizing-border-box-dynamic-padding-border-update-expected.txt: Added.
- fast/css/box-sizing-border-box-dynamic-padding-border-update.html: Added.
- fast/forms/text/text-padding-dynamic-change-expected.html: Added.
- fast/forms/text/text-padding-dynamic-change.html: Added.
- 6:31 PM Changeset in webkit [140289] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] some websites only takes half of the screen after rotating from landscape to portrait mode.
https://bugs.webkit.org/show_bug.cgi?id=107103
Reviewed by George Staikos.
Internally reviewed by Jacky Jiang.
When the document size changes (by some javascript) which makes it too small to fit the viewport, we should
automatically zoom it to fit the viewport.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::layoutFinished):
- 6:29 PM Changeset in webkit [140288] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r140270.
http://trac.webkit.org/changeset/140270
https://bugs.webkit.org/show_bug.cgi?id=107253
Hit asserts in a debug build
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow):
- 6:24 PM Changeset in webkit [140287] by
-
- 3 edits2 adds in trunk
[Shadow DOM] Specifying scrollbar style of an element having RenderLayer in ShadowDOM does not work.
https://bugs.webkit.org/show_bug.cgi?id=107222
Reviewed by Simon Fraser.
Source/WebCore:
When specifying scrollbar style in ShadowDOM, it's not used. If the host element of ShadowDOM has scrollbar style,
it's used instead.
The root cause of this bug is that RenderLayer always see shadowAncestorNode's style. Some elements having
UserAgent ShadowDOM (e.g. <textarea>) should see host's style, but most of elements should see its style.
Test: fast/dom/shadow/scrollbar.html
- rendering/RenderLayer.cpp:
(WebCore::rendererForScrollbar):
(WebCore):
(WebCore::RenderLayer::createScrollbar):
(WebCore::RenderLayer::updateScrollCornerStyle):
(WebCore::RenderLayer::updateResizerStyle):
LayoutTests:
- fast/dom/shadow/scrollbar-expected.html: Added.
- fast/dom/shadow/scrollbar.html: Added.
- 5:29 PM Changeset in webkit [140286] by
-
- 29 edits2 adds in trunk
Dragging over an element with scrollbars should scroll the element when dragging near edges
https://bugs.webkit.org/show_bug.cgi?id=39725
Reviewed by Hajime Morita.
Source/WebCore:
This patch introduces auto scrolling functionality during drag-and-drop
when drop source is near edge of scrollable element.
When drop source is inside 20px of scrollable element more than 200ms,
scrollable element is automatically scrolled every 50ms toward drop
source position, e.g. vertically scroll up when drop source is in top
edge.
Test: fast/events/drag-and-drop-autoscroll.html
- page/AutoscrollController.cpp:
(WebCore::AutoscrollController::AutoscrollController): Changed to initialize m_dragAndDropAutoscrollStartTime.
(WebCore::AutoscrollController::updateDragAndDrop): Added for start/stop autoscroll during drag-and-drop.
(WebCore::AutoscrollController::autoscrollTimerFired): Changed to add autoscroll for drag-and-drop, and to pass last know position to RenderBox::autoscroll().
- page/AutoscrollController.h:
(AutoscrollController): Changed to add updateDragAndDrop() and m_dragAndDropAutoscrollReferencePosition and m_dragAndDropAutoscrollStartTime.
- page/ChromeClient.h:
(WebCore::ChromeClient): Changed to add new function shouldAutoscrollForDragAndDrop().
- page/EventHandler.cpp:
(WebCore::EventHandler::updateDragAndDrop): Changed to call AutoscrollController::updateDragAndDrop().
(WebCore::EventHandler::clearDragState): Changed to call stopAutoscrollTimer().
- rendering/RenderBox.cpp:
(WebCore::RenderBox::autoscroll): Changed for new parameter position.
(WebCore::RenderBox::calculateAutoscrollDirection): Added for autoscroll.
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::autoscroll): Changed for new parameter position and move updateSelectionForMouseDrag() to AutoscrollController.
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::autoscroll): Changed for new parameter position.
- rendering/RenderListBox.h:
(RenderListBox):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::autoscroll): Changed for new parameter position.
- rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
Source/WebKit/chromium:
This patch removes DragScrollTimer used for automatic scrolling of main
frame drag-and-drop which is now implemented in EventHandler.
Another patch will remove DragScrollTimer.{cpp,h} and update GYP files to
make patch size small.
No tests. Existing test covers this change.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::shouldAutoscrollForDragAndDrop): Added.
- src/ChromeClientImpl.h:
(ChromeClientImpl): Changed to add shouldAutoscrollForDragAndDrop().
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl): Changed to remove m_dragScrollTimer.
(WebKit::WebViewImpl::dragSourceEndedAt): ditto
(WebKit::WebViewImpl::dragSourceMovedTo): ditto
(WebKit::WebViewImpl::dragTargetDrop): ditto
(WebKit::WebViewImpl::dragTargetDragEnterOrOver): ditto
- src/WebViewImpl.h:
(WebKit): Chagned to remove DragScrollTimer.
Tools:
This patch introduces canceling drag-and-drop by escape key for testing
behavior after cancellation drag-and-drop.
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::doMouseUp):
(WebTestRunner::EventSender::finishDragAndDrop):
(WebTestRunner::EventSender::keyDown):
- DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(EventSender):
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
LayoutTests:
This patch adds new test for autoscroll during drag-and-drop.
This test is skipped other than Chromium ports.
- fast/events/drag-and-drop-autoscroll-expected.txt: Added.
- fast/events/drag-and-drop-autoscroll.html: Added.
- platform/efl/TestExpectations: Changed to skip fast/events/drag-and-drop-autoscroll.html
- platform/wincairo/TestExpectations: ditto.
- platform/mac/TestExpectations: ditto.
- platform/mac/TestExpectations: ditto.
- platform/qt/TestExpectations: ditto.
- platform/gtk/TestExpectations: ditto.
- platform/win/TestExpectations: ditto.
- platform/wk2/TestExpectations: ditto.
- 5:01 PM Changeset in webkit [140285] by
-
- 8 edits2 deletes in trunk/Source/WebKit2
Remove support getting per-resource callbacks in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=107405
Reviewed by Anders Carlsson.
Removes support for the WKPageResourceLoadClient. Access to per-resource
callbacks are still available in the bundle, and via the WebInspector.
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
Stop handling per-resource messages and forwarding them to the API.
- UIProcess/WebResourceLoadClient.cpp: Removed.
- UIProcess/WebResourceLoadClient.h: Removed.
- WebKit2.xcodeproj/project.pbxproj:
Remove the files.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest):
(WebKit::WebFrameLoaderClient::dispatchWillSendRequest):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveResponse):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoading):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoading):
Stop sending per-resource messages to the UIProcess.
- 4:59 PM Changeset in webkit [140284] by
-
- 3 edits in trunk/Source/JavaScriptCore
Weak GC maps should be easier to use
https://bugs.webkit.org/show_bug.cgi?id=107312
Reviewed by Sam Weinig.
Follow-up fix.
- runtime/PrototypeMap.cpp:
(JSC::PrototypeMap::emptyObjectStructureForPrototype): Restored this
ASSERT, which was disabled because of a bug in WeakGCMap.
- runtime/WeakGCMap.h:
(JSC::WeakGCMap::add): We can't pass our passed-in value to add() because
a PassWeak() clears itself when passed to another function. So, we pass
nullptr instead, and fix things up afterwards.
- 4:11 PM Changeset in webkit [140283] by
-
- 2 edits in trunk/Source/WebCore
Simplify a list of negative PLATFORM() tests
https://bugs.webkit.org/show_bug.cgi?id=107365
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-01-20
Reviewed by Eric Seidel.
Simplify a list of negative PLATFORM() tests into a simpler list
of positive tests for better readability and maintenance.
No new tests as there is no new functionality.
- config.h:
- 2:55 PM Changeset in webkit [140282] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Improve Fatfinger phase.
https://bugs.webkit.org/show_bug.cgi?id=107403
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-01-20
Reviewed by Rob Buis.
RIM PR 219489
Internally reviewd by Mike Fenton & Gen Mak.
Treat ClickableByDefault and MadeClickableByTheWebpage elements as
same category. Avoid unnecessary nodes check step.
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
(BlackBerry::WebKit::FatFingers::FatFingers):
(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::getNodesFromRect):
- WebKitSupport/FatFingers.h:
- 1:30 PM Changeset in webkit [140281] by
-
- 8 edits in trunk/Tools
[chromium] move frame generation related methods to TestRunner
https://bugs.webkit.org/show_bug.cgi?id=107268
Reviewed by Adam Barth.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::setWillSendRequestReturnsNull):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::display):
(WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::display):
(WebTestRunner):
(WebTestRunner::TestRunner::displayInvalidatedRegion):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::display):
(WebViewHost::displayInvalidatedRegion):
- DumpRenderTree/chromium/WebViewHost.h:
- 12:45 PM Changeset in webkit [140280] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Simple indentation fix.
- GNUmakefile.am:
- 12:36 PM Changeset in webkit [140279] by
-
- 2 edits in trunk/Source/WebCore
Avoid filling a rounded rect when radii are zero
https://bugs.webkit.org/show_bug.cgi?id=107402
<rdar://problem/12793315>
Reviewed by Sam Weinig.
It's more efficient to clip and fill rects than rounded rects,
so optimize for the case where rounded rect radii are zero.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::clipRoundedRect):
(WebCore::GraphicsContext::clipOutRoundedRect):
(WebCore::GraphicsContext::fillRoundedRect):
- 12:33 PM Changeset in webkit [140278] by
-
- 2 edits in trunk/Source/JavaScriptCore
2013-01-20 Geoffrey Garen <ggaren@apple.com>
Unreviewed.
Temporarily disabling this ASSERT to get the bots green
while I investigate a fix.
- runtime/PrototypeMap.cpp: (JSC::PrototypeMap::emptyObjectStructureForPrototype):
- 12:16 PM Changeset in webkit [140277] by
-
- 8 edits in trunk/Tools
[chromium] move speech related methods to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=107266
Reviewed by Adam Barth.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::displayInvalidatedRegion):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
(WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
(WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
(WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
(WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
(WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner):
(WebTestRunner::TestRunner::addMockSpeechInputResult):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
(WebTestRunner::TestRunner::setMockSpeechRecognitionError):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::addMockSpeechInputResult):
(WebViewHost::setMockSpeechInputDumpRect):
(WebViewHost::addMockSpeechRecognitionResult):
(WebViewHost::setMockSpeechRecognitionError):
(WebViewHost::wasMockSpeechRecognitionAborted):
- DumpRenderTree/chromium/WebViewHost.h:
- 12:06 PM Changeset in webkit [140276] by
-
- 1 edit245 adds in trunk/LayoutTests
Add more JavaScript tests.
Rubber stampted by Geoffrey Garen.
This adds my JSRegress suite to LayoutTests. This includes silly microbenchmarks that I've
used to test JSC's performance on various interesting cases. But it's also good at catching
bugs, so we might as well be running it as part of regression testing. All of these tests
are short-running, so it shouldn't get in the way of anyone.
- fast/js/regress: Added.
- fast/js/regress/Float32Array-matrix-mult-expected.txt: Added.
- fast/js/regress/Float32Array-matrix-mult.html: Added.
- fast/js/regress/Int16Array-bubble-sort-expected.txt: Added.
- fast/js/regress/Int16Array-bubble-sort.html: Added.
- fast/js/regress/Int16Array-load-int-mul-expected.txt: Added.
- fast/js/regress/Int16Array-load-int-mul.html: Added.
- fast/js/regress/Int8Array-load-expected.txt: Added.
- fast/js/regress/Int8Array-load.html: Added.
- fast/js/regress/adapt-to-double-divide-expected.txt: Added.
- fast/js/regress/adapt-to-double-divide.html: Added.
- fast/js/regress/aliased-arguments-getbyval-expected.txt: Added.
- fast/js/regress/aliased-arguments-getbyval.html: Added.
- fast/js/regress/allocate-big-object-expected.txt: Added.
- fast/js/regress/allocate-big-object.html: Added.
- fast/js/regress/arity-mismatch-inlining-expected.txt: Added.
- fast/js/regress/arity-mismatch-inlining.html: Added.
- fast/js/regress/array-access-polymorphic-structure-expected.txt: Added.
- fast/js/regress/array-access-polymorphic-structure.html: Added.
- fast/js/regress/array-with-double-add-expected.txt: Added.
- fast/js/regress/array-with-double-add.html: Added.
- fast/js/regress/array-with-double-increment-expected.txt: Added.
- fast/js/regress/array-with-double-increment.html: Added.
- fast/js/regress/array-with-double-mul-add-expected.txt: Added.
- fast/js/regress/array-with-double-mul-add.html: Added.
- fast/js/regress/array-with-double-sum-expected.txt: Added.
- fast/js/regress/array-with-double-sum.html: Added.
- fast/js/regress/array-with-int32-add-sub-expected.txt: Added.
- fast/js/regress/array-with-int32-add-sub.html: Added.
- fast/js/regress/array-with-int32-or-double-sum-expected.txt: Added.
- fast/js/regress/array-with-int32-or-double-sum.html: Added.
- fast/js/regress/big-int-mul-expected.txt: Added.
- fast/js/regress/big-int-mul.html: Added.
- fast/js/regress/boolean-test-expected.txt: Added.
- fast/js/regress/boolean-test.html: Added.
- fast/js/regress/cast-int-to-double-expected.txt: Added.
- fast/js/regress/cast-int-to-double.html: Added.
- fast/js/regress/cell-argument-expected.txt: Added.
- fast/js/regress/cell-argument.html: Added.
- fast/js/regress/cfg-simplify-expected.txt: Added.
- fast/js/regress/cfg-simplify.html: Added.
- fast/js/regress/cmpeq-obj-to-obj-other-expected.txt: Added.
- fast/js/regress/cmpeq-obj-to-obj-other.html: Added.
- fast/js/regress/constant-test-expected.txt: Added.
- fast/js/regress/constant-test.html: Added.
- fast/js/regress/direct-arguments-getbyval-expected.txt: Added.
- fast/js/regress/direct-arguments-getbyval.html: Added.
- fast/js/regress/double-pollution-getbyval-expected.txt: Added.
- fast/js/regress/double-pollution-getbyval.html: Added.
- fast/js/regress/double-pollution-putbyoffset-expected.txt: Added.
- fast/js/regress/double-pollution-putbyoffset.html: Added.
- fast/js/regress/external-arguments-getbyval-expected.txt: Added.
- fast/js/regress/external-arguments-getbyval.html: Added.
- fast/js/regress/external-arguments-putbyval-expected.txt: Added.
- fast/js/regress/external-arguments-putbyval.html: Added.
- fast/js/regress/fold-double-to-int-expected.txt: Added.
- fast/js/regress/fold-double-to-int.html: Added.
- fast/js/regress/function-dot-apply-expected.txt: Added.
- fast/js/regress/function-dot-apply.html: Added.
- fast/js/regress/function-test-expected.txt: Added.
- fast/js/regress/function-test.html: Added.
- fast/js/regress/get-by-id-chain-from-try-block-expected.txt: Added.
- fast/js/regress/get-by-id-chain-from-try-block.html: Added.
- fast/js/regress/indexed-properties-in-objects-expected.txt: Added.
- fast/js/regress/indexed-properties-in-objects.html: Added.
- fast/js/regress/inline-arguments-access-expected.txt: Added.
- fast/js/regress/inline-arguments-access.html: Added.
- fast/js/regress/inline-arguments-local-escape-expected.txt: Added.
- fast/js/regress/inline-arguments-local-escape.html: Added.
- fast/js/regress/inline-get-scoped-var-expected.txt: Added.
- fast/js/regress/inline-get-scoped-var.html: Added.
- fast/js/regress/inlined-put-by-id-transition-expected.txt: Added.
- fast/js/regress/inlined-put-by-id-transition.html: Added.
- fast/js/regress/int-or-other-abs-then-get-by-val-expected.txt: Added.
- fast/js/regress/int-or-other-abs-then-get-by-val.html: Added.
- fast/js/regress/int-or-other-abs-zero-then-get-by-val-expected.txt: Added.
- fast/js/regress/int-or-other-abs-zero-then-get-by-val.html: Added.
- fast/js/regress/int-or-other-add-expected.txt: Added.
- fast/js/regress/int-or-other-add-then-get-by-val-expected.txt: Added.
- fast/js/regress/int-or-other-add-then-get-by-val.html: Added.
- fast/js/regress/int-or-other-add.html: Added.
- fast/js/regress/int-or-other-div-then-get-by-val-expected.txt: Added.
- fast/js/regress/int-or-other-div-then-get-by-val.html: Added.
- fast/js/regress/int-or-other-max-then-get-by-val-expected.txt: Added.
- fast/js/regress/int-or-other-max-then-get-by-val.html: Added.
- fast/js/regress/int-or-other-min-then-get-by-val-expected.txt: Added.
- fast/js/regress/int-or-other-min-then-get-by-val.html: Added.
- fast/js/regress/int-or-other-mod-then-get-by-val-expected.txt: Added.
- fast/js/regress/int-or-other-mod-then-get-by-val.html: Added.
- fast/js/regress/int-or-other-mul-then-get-by-val-expected.txt: Added.
- fast/js/regress/int-or-other-mul-then-get-by-val.html: Added.
- fast/js/regress/int-or-other-neg-then-get-by-val-expected.txt: Added.
- fast/js/regress/int-or-other-neg-then-get-by-val.html: Added.
- fast/js/regress/int-or-other-neg-zero-then-get-by-val-expected.txt: Added.
- fast/js/regress/int-or-other-neg-zero-then-get-by-val.html: Added.
- fast/js/regress/int-or-other-sub-expected.txt: Added.
- fast/js/regress/int-or-other-sub-then-get-by-val-expected.txt: Added.
- fast/js/regress/int-or-other-sub-then-get-by-val.html: Added.
- fast/js/regress/int-or-other-sub.html: Added.
- fast/js/regress/int-overflow-local-expected.txt: Added.
- fast/js/regress/int-overflow-local.html: Added.
- fast/js/regress/integer-divide-expected.txt: Added.
- fast/js/regress/integer-divide.html: Added.
- fast/js/regress/make-indexed-storage-expected.txt: Added.
- fast/js/regress/make-indexed-storage.html: Added.
- fast/js/regress/method-on-number-expected.txt: Added.
- fast/js/regress/method-on-number.html: Added.
- fast/js/regress/new-array-buffer-dead-expected.txt: Added.
- fast/js/regress/new-array-buffer-dead.html: Added.
- fast/js/regress/new-array-buffer-push-expected.txt: Added.
- fast/js/regress/new-array-buffer-push.html: Added.
- fast/js/regress/new-array-dead-expected.txt: Added.
- fast/js/regress/new-array-dead.html: Added.
- fast/js/regress/new-array-push-expected.txt: Added.
- fast/js/regress/new-array-push.html: Added.
- fast/js/regress/number-test-expected.txt: Added.
- fast/js/regress/number-test.html: Added.
- fast/js/regress/object-closure-call-expected.txt: Added.
- fast/js/regress/object-closure-call.html: Added.
- fast/js/regress/object-test-expected.txt: Added.
- fast/js/regress/object-test.html: Added.
- fast/js/regress/poly-stricteq-expected.txt: Added.
- fast/js/regress/poly-stricteq.html: Added.
- fast/js/regress/polymorphic-structure-expected.txt: Added.
- fast/js/regress/polymorphic-structure.html: Added.
- fast/js/regress/polyvariant-monomorphic-get-by-id-expected.txt: Added.
- fast/js/regress/polyvariant-monomorphic-get-by-id.html: Added.
- fast/js/regress/rare-osr-exit-on-local-expected.txt: Added.
- fast/js/regress/rare-osr-exit-on-local.html: Added.
- fast/js/regress/register-pressure-from-osr-expected.txt: Added.
- fast/js/regress/register-pressure-from-osr.html: Added.
- fast/js/regress/resources: Added.
- fast/js/regress/resources/regress-post.js: Added.
- fast/js/regress/resources/regress-pre.js: Added.
(window.onerror):
- fast/js/regress/script-tests: Added.
- fast/js/regress/script-tests/Float32Array-matrix-mult.js: Added.
(makeEmptyMatrix):
(multiplyMatrices):
(checkMatricesEqual):
(parseMatrix.string.split.forEach):
(parseMatrix):
(printMatrix.pad):
(printMatrix):
- fast/js/regress/script-tests/Int16Array-bubble-sort.js: Added.
(bubbleSort):
(myRandom):
(validateSort):
- fast/js/regress/script-tests/Int16Array-load-int-mul.js: Added.
(stringHash):
- fast/js/regress/script-tests/Int8Array-load.js: Added.
(adler32):
- fast/js/regress/script-tests/adapt-to-double-divide.js: Added.
(foo):
- fast/js/regress/script-tests/aliased-arguments-getbyval.js: Added.
(bar):
- fast/js/regress/script-tests/allocate-big-object.js: Added.
(foo):
- fast/js/regress/script-tests/arity-mismatch-inlining.js: Added.
(foo):
- fast/js/regress/script-tests/array-access-polymorphic-structure.js: Added.
(foo):
- fast/js/regress/script-tests/array-with-double-add.js: Added.
(foo):
- fast/js/regress/script-tests/array-with-double-increment.js: Added.
(foo):
- fast/js/regress/script-tests/array-with-double-mul-add.js: Added.
(foo):
- fast/js/regress/script-tests/array-with-double-sum.js: Added.
(foo):
- fast/js/regress/script-tests/array-with-int32-add-sub.js: Added.
(foo):
- fast/js/regress/script-tests/array-with-int32-or-double-sum.js: Added.
(foo):
- fast/js/regress/script-tests/big-int-mul.js: Added.
(stringHash):
- fast/js/regress/script-tests/boolean-test.js: Added.
(foo):
- fast/js/regress/script-tests/cast-int-to-double.js: Added.
(foo):
- fast/js/regress/script-tests/cell-argument.js: Added.
(foo):
- fast/js/regress/script-tests/cfg-simplify.js: Added.
(foo):
- fast/js/regress/script-tests/cmpeq-obj-to-obj-other.js: Added.
(foo):
(bar):
(baz):
(dostuff):
- fast/js/regress/script-tests/constant-test.js: Added.
(foo):
- fast/js/regress/script-tests/direct-arguments-getbyval.js: Added.
(bar):
- fast/js/regress/script-tests/double-pollution-getbyval.js: Added.
(foo):
- fast/js/regress/script-tests/double-pollution-putbyoffset.js: Added.
(foo):
- fast/js/regress/script-tests/external-arguments-getbyval.js: Added.
(foo):
(bar):
- fast/js/regress/script-tests/external-arguments-putbyval.js: Added.
(foo):
(bar):
- fast/js/regress/script-tests/fold-double-to-int.js: Added.
(Math.random):
- fast/js/regress/script-tests/function-dot-apply.js: Added.
(thingy):
(doCall):
(foo):
- fast/js/regress/script-tests/function-test.js: Added.
(foo):
- fast/js/regress/script-tests/get-by-id-chain-from-try-block.js: Added.
(A):
(B):
(C):
(D):
(E):
(F):
(G):
(foo):
- fast/js/regress/script-tests/indexed-properties-in-objects.js: Added.
- fast/js/regress/script-tests/inline-arguments-access.js: Added.
(foo):
(bar):
- fast/js/regress/script-tests/inline-arguments-local-escape.js: Added.
(foo):
(bar):
- fast/js/regress/script-tests/inline-get-scoped-var.js: Added.
(foo.bar):
(foo):
- fast/js/regress/script-tests/inlined-put-by-id-transition.js: Added.
(foo):
(Foo):
- fast/js/regress/script-tests/int-or-other-abs-then-get-by-val.js: Added.
(foo):
- fast/js/regress/script-tests/int-or-other-abs-zero-then-get-by-val.js: Added.
(foo):
- fast/js/regress/script-tests/int-or-other-add-then-get-by-val.js: Added.
(foo):
- fast/js/regress/script-tests/int-or-other-add.js: Added.
(foo):
- fast/js/regress/script-tests/int-or-other-div-then-get-by-val.js: Added.
(foo):
- fast/js/regress/script-tests/int-or-other-max-then-get-by-val.js: Added.
(foo):
- fast/js/regress/script-tests/int-or-other-min-then-get-by-val.js: Added.
(foo):
- fast/js/regress/script-tests/int-or-other-mod-then-get-by-val.js: Added.
(foo):
- fast/js/regress/script-tests/int-or-other-mul-then-get-by-val.js: Added.
(foo):
- fast/js/regress/script-tests/int-or-other-neg-then-get-by-val.js: Added.
(foo):
- fast/js/regress/script-tests/int-or-other-neg-zero-then-get-by-val.js: Added.
(foo):
- fast/js/regress/script-tests/int-or-other-sub-then-get-by-val.js: Added.
(foo):
- fast/js/regress/script-tests/int-or-other-sub.js: Added.
(foo):
- fast/js/regress/script-tests/int-overflow-local.js: Added.
(foo):
- fast/js/regress/script-tests/integer-divide.js: Added.
(foo):
(bar):
- fast/js/regress/script-tests/make-indexed-storage.js: Added.
(foo):
(sum):
- fast/js/regress/script-tests/method-on-number.js: Added.
(foo):
- fast/js/regress/script-tests/new-array-buffer-dead.js: Added.
(foo):
(bar):
(baz):
(thingy):
- fast/js/regress/script-tests/new-array-buffer-push.js: Added.
(foo):
(bar):
(baz):
(thingy):
- fast/js/regress/script-tests/new-array-dead.js: Added.
(foo):
(bar):
- fast/js/regress/script-tests/new-array-push.js: Added.
(foo):
- fast/js/regress/script-tests/number-test.js: Added.
(foo):
- fast/js/regress/script-tests/object-closure-call.js: Added.
(makeObjectClosure.foo):
(makeObjectClosure):
- fast/js/regress/script-tests/object-test.js: Added.
(foo):
- fast/js/regress/script-tests/poly-stricteq.js: Added.
- fast/js/regress/script-tests/polymorphic-structure.js: Added.
(foo):
- fast/js/regress/script-tests/polyvariant-monomorphic-get-by-id.js: Added.
(foo):
(Foo):
(Bar):
(bar):
- fast/js/regress/script-tests/rare-osr-exit-on-local.js: Added.
(foo):
- fast/js/regress/script-tests/register-pressure-from-osr.js: Added.
(foo):
- fast/js/regress/script-tests/simple-activation-demo.js: Added.
(foo):
- fast/js/regress/script-tests/slow-array-profile-convergence.js: Added.
(foo):
(sum):
- fast/js/regress/script-tests/slow-convergence.js: Added.
(foo):
- fast/js/regress/script-tests/sparse-conditional.js: Added.
(foo):
- fast/js/regress/script-tests/splice-to-remove.js: Added.
- fast/js/regress/script-tests/string-hash.js: Added.
(stringHash):
- fast/js/regress/script-tests/string-repeat-arith.js: Added.
(foo):
- fast/js/regress/script-tests/string-sub.js: Added.
(foo):
- fast/js/regress/script-tests/string-test.js: Added.
(foo):
- fast/js/regress/script-tests/structure-hoist-over-transitions.js: Added.
(foo):
- fast/js/regress/script-tests/tear-off-arguments-simple.js: Added.
(bar):
- fast/js/regress/script-tests/tear-off-arguments.js: Added.
(bar):
- fast/js/regress/script-tests/temporal-structure.js: Added.
(foo):
- fast/js/regress/script-tests/to-int32-boolean.js: Added.
(foo):
- fast/js/regress/script-tests/undefined-test.js: Added.
(foo):
- fast/js/regress/simple-activation-demo-expected.txt: Added.
- fast/js/regress/simple-activation-demo.html: Added.
- fast/js/regress/slow-array-profile-convergence-expected.txt: Added.
- fast/js/regress/slow-array-profile-convergence.html: Added.
- fast/js/regress/slow-convergence-expected.txt: Added.
- fast/js/regress/slow-convergence.html: Added.
- fast/js/regress/sparse-conditional-expected.txt: Added.
- fast/js/regress/sparse-conditional.html: Added.
- fast/js/regress/splice-to-remove-expected.txt: Added.
- fast/js/regress/splice-to-remove.html: Added.
- fast/js/regress/string-hash-expected.txt: Added.
- fast/js/regress/string-hash.html: Added.
- fast/js/regress/string-repeat-arith-expected.txt: Added.
- fast/js/regress/string-repeat-arith.html: Added.
- fast/js/regress/string-sub-expected.txt: Added.
- fast/js/regress/string-sub.html: Added.
- fast/js/regress/string-test-expected.txt: Added.
- fast/js/regress/string-test.html: Added.
- fast/js/regress/structure-hoist-over-transitions-expected.txt: Added.
- fast/js/regress/structure-hoist-over-transitions.html: Added.
- fast/js/regress/tear-off-arguments-expected.txt: Added.
- fast/js/regress/tear-off-arguments-simple-expected.txt: Added.
- fast/js/regress/tear-off-arguments-simple.html: Added.
- fast/js/regress/tear-off-arguments.html: Added.
- fast/js/regress/temporal-structure-expected.txt: Added.
- fast/js/regress/temporal-structure.html: Added.
- fast/js/regress/to-int32-boolean-expected.txt: Added.
- fast/js/regress/to-int32-boolean.html: Added.
- fast/js/regress/undefined-test-expected.txt: Added.
- fast/js/regress/undefined-test.html: Added.
- 11:29 AM Changeset in webkit [140275] by
-
- 15 edits2 adds in trunk/Source/JavaScriptCore
Inserting a node into the DFG graph should not require five lines of code
https://bugs.webkit.org/show_bug.cgi?id=107381
Reviewed by Sam Weinig.
This adds fairly comprehensive support for inserting a node into a DFG graph in one
method call. A common example of this is:
m_insertionSet.insertNode(indexInBlock, DontRefChildren, DontRefNode, SpecNone, ForceOSRExit, codeOrigin);
The arguments to insert() specify what reference counting you need to have happen
(RefChildren => recursively refs all children, RefNode => non-recursively refs the node
that was created), the prediction to set (SpecNone is a common default), followed by
the arguments to the Node() constructor. InsertionSet::insertNode() and similar methods
(Graph::addNode() and BasicBlock::appendNode()) all use a common variadic template
function macro from DFGVariadicFunction.h. Also, all of these methods will automatically
non-recursively ref() the node being created if the flags say NodeMustGenerate.
In all, this new mechanism retains the flexibility of the old approach (you get to
manage ref counts yourself, albeit in less code) while ensuring that most code that adds
nodes to the graph now needs less code to do it.
In the future, we should revisit the reference counting methodology in the DFG: we could
do like most compilers and get rid of it entirely, or we could make it automatic. This
patch doesn't attempt to make any such major changes, and only seeks to simplify the
technique we were already using (manual ref counting).
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/Operands.h:
(JSC::dumpOperands):
- dfg/DFGAdjacencyList.h:
(AdjacencyList):
(JSC::DFG::AdjacencyList::kind):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGBasicBlock.h:
(DFG):
(BasicBlock):
- dfg/DFGBasicBlockInlines.h: Added.
(DFG):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
- dfg/DFGCommon.h:
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):
(JSC::DFG::ConstantFoldingPhase::paintUnreachableCode):
(ConstantFoldingPhase):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::FixupPhase):
(JSC::DFG::FixupPhase::fixupBlock):
(JSC::DFG::FixupPhase::fixupNode):
(FixupPhase):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
(Graph):
- dfg/DFGInsertionSet.h:
(DFG):
(JSC::DFG::Insertion::Insertion):
(JSC::DFG::Insertion::element):
(Insertion):
(JSC::DFG::InsertionSet::InsertionSet):
(JSC::DFG::InsertionSet::insert):
(InsertionSet):
(JSC::DFG::InsertionSet::execute):
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(Node):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- dfg/DFGVariadicFunction.h: Added.
- 10:57 AM Changeset in webkit [140274] by
-
- 9 edits2 deletes in trunk/Source
Remove obsolete plug-in sandboxing code.
https://bugs.webkit.org/show_bug.cgi?id=107362
Reviewed by Darin Adler.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- plugins/npapi-sandbox.h: Removed.
Source/WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
- DerivedSources.make:
- PluginProcess/mac/com.apple.WebKit.PluginProcess.sb.in: Removed.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::initializeSandbox): Fixed a memory leak in code that stays.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
- WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h:
- WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
Removed API related parts. Remaining code will move to a better place in a follow-up
patch, just keeping it here for easier reviewing.
(enterSandbox): Removed no longer used arguments.
- 10:18 AM Changeset in webkit [140273] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Make V8 LiveEdit API disabled by default
https://bugs.webkit.org/show_bug.cgi?id=106668
Patch by Peter Rybin <peter.rybin@gmail.com> on 2013-01-20
Reviewed by Yury Semikhatsky.
Initialize method is patched accordingly.
- bindings/v8/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::restart): missing enable/disable calls added for restart
- bindings/v8/V8Initializer.cpp:
(WebCore::initializeV8Common): initializer method patched
- 3:36 AM Changeset in webkit [140272] by
-
- 2 edits in trunk/Source/WebCore
[gstreamer] assertion in g_object_unref from _WebKitWebAudioSourcePrivate destructor
https://bugs.webkit.org/show_bug.cgi?id=107374
Reviewed by Philippe Normand.
WebKitWebAudioSrc object gets unrefed one time too many in
_WebKitWebAudioSourcePrivate destructor, causing an assertion
in g_object_unref. This patch passes NULL instead of
g_object_unref to gst_task_new() so that the WebKitWebAudioSrc
object does not get unrefed when the GstTask is destroyed.
No new tests, already covered by webaudio tests.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webkit_web_audio_src_init):
- 2:50 AM Changeset in webkit [140271] by
-
- 8 edits in trunk/Tools
[chromium] move notification related methods to TestRunner
https://bugs.webkit.org/show_bug.cgi?id=107269
Reviewed by Adam Barth.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
(WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
(WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner):
(WebTestRunner::TestRunner::grantWebNotificationPermission):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::grantWebNotificationPermission):
(WebViewHost::simulateLegacyWebNotificationClick):
- DumpRenderTree/chromium/WebViewHost.h:
- 2:35 AM Changeset in webkit [140270] by
-
- 2 edits in trunk/Source/WebCore
[V8] Create a persistent wrapper for Window.prototype and innerGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=107253
Reviewed by Adam Barth.
This is one of steps to avoid hitting an ASSERT()
that will be added in https://bugs.webkit.org/show_bug.cgi?id=107137 .
We should have a persistent wrapper for all DOM objects
and set a class id on the wrapper.
No tests. No change in behavior.
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow):
- 1:40 AM Changeset in webkit [140269] by
-
- 8 edits in trunk/Tools
[chromium] move geolocation related methods to TestRunner
https://bugs.webkit.org/show_bug.cgi?id=107267
Reviewed by Adam Barth.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
(WebTestRunner::WebTestDelegate::setGeolocationPermission):
(WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
(WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
(WebTestRunner):
(WebTestRunner::TestRunner::setGeolocationPermission):
(WebTestRunner::TestRunner::setMockGeolocationPosition):
(WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::numberOfPendingGeolocationPermissionRequests):
(WebViewHost::setGeolocationPermission):
(WebViewHost::setMockGeolocationPosition):
(WebViewHost::setMockGeolocationPositionUnavailableError):
- DumpRenderTree/chromium/WebViewHost.h:
