⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 26, 2013:

11:02 PM Changeset in webkit [140926] by ap@apple.com
  • 6 edits
    2 deletes in trunk/Source/WebKit2

Use shared ChildProcess code to enter plug-in sandbox.

Reviewed by Sam Weinig.

There is one known behavior change from this refactoring: getpwuid_r is used
instead of NSHomeDirectory for home directory, mathcing other client processes.

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::enterSandbox):
  • PluginProcess/PluginProcess.h: PluginProcess prevents ChildProcess attempt to enter the sandbox immediately on launch for now, because we don't have a sandbox profile directory path yet. It now keeps a copy of ChildProcessInitializationParameters, so that ChildProcess::initializeSandbox() could be called later.
  • PluginProcess/mac/PluginProcessMac.mm: (WebKit::PluginProcess::platformInitializeProcess): Store a copy of ChildProcessInitializationParameters for later. (WebKit::loadSandboxProfile): Build a sandbox profile from a common prefix and a plugin-specific part. (WebKit::PluginProcess::platformInitializePluginProcess): We can enter the sandbox now. (WebKit::PluginProcess::enterSandbox): Prepare SandboxInitializationParameters, and call ChildProcess::initializeSandbox().
  • Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::initializeSandbox): Actually handle system directory suffix from parameters.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h: Removed.
  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm: Removed.
10:39 PM Changeset in webkit [140925] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Don't use goma to preprocess bindings idl files
​https://bugs.webkit.org/show_bug.cgi?id=107984

Reviewed by Adam Barth.

On Linux and Mac, use a local gcc or clang to preprocess the bindings idl files.
On my machine, this drops the bindings generation from 137s to 24s when
using goma and -j400.

No new tests, this is a build change.

  • WebCore.gyp/WebCore.gyp: Force the use of the local gcc or clang for preprocessing.
9:32 PM Changeset in webkit [140924] by weinig@apple.com
  • 7 edits
    7 copies
    3 adds in trunk/Source/WebKit2

Add support for running the networking process as an XPCService
​https://bugs.webkit.org/show_bug.cgi?id=108025

Reviewed by Dan Bernstein.

  • Configurations/NetworkService.Development.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.Development.xcconfig.
  • Configurations/NetworkService.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.xcconfig.

Add configurations.

  • NetworkProcess/EntryPoint/mac/XPCService: Added.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService: Added.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development: Added.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/NetworkServiceMain.Development.mm: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm.

(initializeNetworkService):
Add entry points.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::serviceName):
(WebKit::connectToServiceForDevelopment):
(WebKit::createServiceForDevelopment):
(WebKit::createService):
(WebKit::createProcess):
(WebKit::ProcessLauncher::launchProcess):
Rework service creation to work for arbitrary services.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::~NetworkProcessProxy):
(WebKit::NetworkProcessProxy::getLaunchOptions):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Network/mac/NetworkProcessProxyMac.mm:

(WebKit::shouldUseXPC):
(WebKit::NetworkProcessProxy::platformGetLaunchOptions):
Opt into xpc using the same rules as the WebProcess.

  • WebKit2.xcodeproj/project.pbxproj:

Update files.

  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:

(initializeWebContentService):
Fix the comment to refer to the shim correctly.

8:30 PM Changeset in webkit [140923] by commit-queue@webkit.org
  • 31 edits
    3 deletes in trunk

Unreviewed, rolling out r140880.
​http://trac.webkit.org/changeset/140880
​https://bugs.webkit.org/show_bug.cgi?id=108023

Caused mathml/presentation and tests to crash and fail
(Requested by keishi on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-26

Source/WebCore:

  • mathml/MathMLTextElement.cpp:
  • mathml/MathMLTextElement.h:

(MathMLTextElement):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::computePreferredLogicalWidths):
(WebCore):
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
(WebCore::RenderMathMLBlock::preferredLogicalHeightAfterSizing):

  • rendering/mathml/RenderMathMLBlock.h:

(RenderMathMLBlock):
(WebCore::RenderMathMLBlock::isPreferredLogicalHeightDirty):
(WebCore::RenderMathMLBlock::preferredLogicalHeight):
(WebCore::RenderMathMLBlock::setPreferredLogicalHeight):

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::styleDidChange):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
(WebCore):
(WebCore::RenderMathMLOperator::glyphHeightForCharacter):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createGlyph):
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):

  • rendering/mathml/RenderMathMLOperator.h:

(RenderMathMLOperator):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::index):
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):
(WebCore):
(WebCore::RenderMathMLRoot::layout):

  • rendering/mathml/RenderMathMLRoot.h:

(RenderMathMLRoot):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::computePreferredLogicalWidths):
(WebCore::RenderMathMLRow::layout):

  • rendering/mathml/RenderMathMLRow.h:

(RenderMathMLRow):

LayoutTests:

  • mathml/differentiable-manifold.html: Removed.
  • platform/chromium-linux/mathml/differentiable-manifold-expected.png: Removed.
  • platform/chromium-linux/mathml/differentiable-manifold-expected.txt: Removed.
  • platform/chromium-linux/mathml/presentation/fenced-expected.txt:
  • platform/chromium-linux/mathml/presentation/fenced-mi-expected.png:
  • platform/chromium-linux/mathml/presentation/fenced-mi-expected.txt:
  • platform/chromium-linux/mathml/presentation/mo-expected.txt:
  • platform/chromium-linux/mathml/presentation/mo-stretch-expected.png:
  • platform/chromium-linux/mathml/presentation/mo-stretch-expected.txt:
  • platform/chromium-linux/mathml/presentation/over-expected.txt:
  • platform/chromium-linux/mathml/presentation/row-alignment-expected.txt:
  • platform/chromium-linux/mathml/presentation/row-expected.png:
  • platform/chromium-linux/mathml/presentation/row-expected.txt:
  • platform/chromium-linux/mathml/presentation/sub-expected.png:
  • platform/chromium-linux/mathml/presentation/sub-expected.txt:
  • platform/chromium-linux/mathml/presentation/subsup-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
5:36 PM Changeset in webkit [140922] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Simplify environment creation in XPC service re-exec
​https://bugs.webkit.org/show_bug.cgi?id=108017

Reviewed by Dan Bernstein.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h:

(WebKit::XPCServiceEventHandler):
There is no need to copy these strings.

5:01 PM Changeset in webkit [140921] by ap@apple.com
  • 24 edits
    1 delete in trunk/Source

Remove code for handling NetworkProcess authentication challenges in WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=108003

Reviewed by Sam Weinig.

4:53 PM Changeset in webkit [140920] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the development build.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h:

(WebKit::XPCServiceEventHandler):
Use the right stringizer.

4:40 PM Changeset in webkit [140919] by weinig@apple.com
  • 4 edits
    1 move
    2 adds
    1 delete in trunk/Source/WebKit2

Refactor XPCService initialization to make it easier to add more services
​https://bugs.webkit.org/show_bug.cgi?id=108015

Reviewed by Dan Bernstein.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h: Added.

(WebKit::XPCServiceEventHandler):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.h: Added.

(WebKit::XPCServiceEventHandler):
Move bootstrapping to Shared (like we have for the legacy process). For now, we use
a macro to define the actual initialization point function to use, in the future, we
could consider alternatives, such as getting the function name from the bundle.

  • WebKit2.xcodeproj/project.pbxproj:

Update files.

  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm:

Simplify to use the new XPCServiceBootstrapper.

  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm: Copied from Source/WebKit2/WebProcess/mac/WebProcessServiceEntryPoints.mm.

(initializeWebContentService):

  • WebProcess/mac/WebProcessServiceEntryPoints.h: Removed.
  • WebProcess/mac/WebProcessServiceEntryPoints.mm: Removed.

Move the entry point to where it belongs and extract the bootstrapping parts.

4:09 PM Changeset in webkit [140918] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the test for CHANNEL_MESSAGING in idl files
​https://bugs.webkit.org/show_bug.cgi?id=108006

Patch by Laszlo Gombos <Laszlo Gombos> on 2013-01-26
Reviewed by Alexey Proskuryakov.

No new tests, this is a build fix.

  • workers/WorkerContext.idl: Make sure ENABLE_CHANNEL_MESSAGING is

defined before using it to be consitent with other guards inside idl
files.

2:55 PM Changeset in webkit [140917] by abecsi@webkit.org
  • 2 edits in trunk/Source/WTF

Unreviewed fix after r140451 to make GIT-SVN repositories happy.

  • WTF.vcproj/WTF.sln:
2:24 PM Changeset in webkit [140916] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt]Qt build fix
​https://bugs.webkit.org/show_bug.cgi?id=108013

Changes on process initialization classes broke webkit building with Qt5. This
patch fix it.

Patch by Adenilson Cavalcanti <​cavalcantii@gmail.com> on 2013-01-26
Reviewed by Sam Weinig.

  • PluginProcess/qt/PluginProcessMainQt.cpp:
12:15 PM Changeset in webkit [140915] by weinig@apple.com
  • 6 edits in trunk/Source/WebKit2

Hoist command line parsing into ChildProcessMain
​https://bugs.webkit.org/show_bug.cgi?id=108010

Reviewed by Dan Bernstein.

  • NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMain.mm:

(NetworkProcessMain):

  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:

(PluginProcessMain):

  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.h:

(WebKit::ChildProcessMain):

  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMain.mm:

(SharedWorkerProcessMain):

  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:

(WebContentProcessMain):

11:44 AM Changeset in webkit [140914] by weinig@apple.com
  • 6 edits
    10 moves
    18 adds
    6 deletes in trunk/Source/WebKit2

Move LegacyProcess entry points into new EntryPoint directories
​https://bugs.webkit.org/show_bug.cgi?id=108008

Reviewed by Anders Carlsson.

Also refactors to remove the need for the overly general WebKitMain, by putting the
framework lazy loading into a helper function each legacy process can call (in ChildProcessMainBootstrapper.h)

  • Configurations/NetworkProcess.xcconfig:
  • Configurations/PluginProcess.xcconfig:
  • Configurations/SharedWorkerProcess.xcconfig:
  • Configurations/WebProcess.xcconfig:
  • NetworkProcess/EntryPoint: Added.
  • NetworkProcess/EntryPoint/mac: Added.
  • NetworkProcess/EntryPoint/mac/LegacyProcess: Added.
  • NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist: Copied from Source/WebKit2/NetworkProcess/Info.plist.
  • NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMain.mm: Copied from Source/WebKit2/NetworkProcess/mac/NetworkProcessMainMac.mm.

(NetworkProcessMain):

  • NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMainBootstrapper.cpp: Added.

(main):

  • NetworkProcess/Info.plist: Removed.
  • NetworkProcess/NetworkProcessMain.h: Removed.
  • NetworkProcess/mac/NetworkProcessMainMac.mm: Removed.
  • PluginProcess/EntryPoint: Added.
  • PluginProcess/EntryPoint/mac: Added.
  • PluginProcess/EntryPoint/mac/LegacyProcess: Added.
  • PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist: Copied from Source/WebKit2/PluginProcess/Info.plist.
  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm: Copied from Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm.

(PluginProcessMain):

  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMainBootstrapper.cpp: Added.

(main):

  • PluginProcess/Info.plist: Removed.
  • PluginProcess/PluginProcessMain.h: Removed.
  • PluginProcess/mac/PluginProcessMainMac.mm: Removed.
  • Shared/EntryPointUtilities: Added.
  • Shared/EntryPointUtilities/mac: Added.
  • Shared/EntryPointUtilities/mac/LegacyProcess: Added.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.h: Copied from Source/WebKit2/Shared/mac/ChildProcessMain.h.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm: Copied from Source/WebKit2/Shared/mac/ChildProcessMain.mm.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMainBootstrapper.h: Added.

(closeUnusedFileDescriptors):
(getBootstrapMainFunction):

  • Shared/EntryPointUtilities/mac/XPCService: Added.
  • Shared/mac/ChildProcessMain.h: Removed.
  • Shared/mac/ChildProcessMain.mm: Removed.
  • SharedWorkerProcess/EntryPoint: Added.
  • SharedWorkerProcess/EntryPoint/mac: Added.
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess: Added.
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/Info.plist: Copied from Source/WebKit2/SharedWorkerProcess/Info.plist.
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMain.mm: Copied from Source/WebKit2/SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm.

(SharedWorkerProcessMain):

  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMainBootstrapper.cpp: Added.

(main):

  • SharedWorkerProcess/Info.plist: Removed.
  • SharedWorkerProcess/SharedWorkerProcessMain.h: Removed.
  • SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/EntryPoint/mac/LegacyProcess/Info.plist: Copied from Source/WebKit2/WebProcess/Info.plist.
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm: Copied from Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm.

(WebKit::WebContentProcessMainDelegate::WebContentProcessMainDelegate):
(WebKit):
(WebContentProcessMain):

  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMainBootstrapper.cpp: Added.

(main):

  • WebProcess/Info.plist: Removed.
  • WebProcess/WebKitMain.cpp: Removed.
  • WebProcess/WebProcessMain.h: Removed.
  • WebProcess/mac/WebProcessMainMac.mm: Removed.
  • mac/MainMacProcess.cpp: Removed.
11:29 AM Changeset in webkit [140913] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Text Autosizing: simplify and clean-up preOrderTraversal skipping containers
​https://bugs.webkit.org/show_bug.cgi?id=107446

Patch by Tim Volodine <​timvolodine@chromium.org> on 2013-01-26
Reviewed by Julien Chaffraix.

Simplify nextInPreOrderSkippingDescendantsOfContainers implementation
using RenderObject tree traversal methods.

No new tests because functionality is unchanged.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::nextInPreOrderSkippingDescendantsOfContainers):

8:34 AM Changeset in webkit [140912] by commit-queue@webkit.org
  • 8 edits in trunk

.: Allow building with arbitrary SDK and ARCHS with make + Xcode
​https://bugs.webkit.org/show_bug.cgi?id=107863

Patch by David Farler <​dfarler@apple.com> on 2013-01-26
Reviewed by David Kilzer.

  • Makefile:

Removed references to legacy Xcode configurations.

  • Makefile.shared:

Added default ARCHS + SDK settings and parameterized xcodebuild calls.

  • Source/Makefile:

iOS does not build WebKit2.

Tools: Makefiles should work for arbitrary SDKs and architectures on Apple ports
​https://bugs.webkit.org/show_bug.cgi?id=107863

Patch by David Farler <​dfarler@apple.com> on 2013-01-26
Reviewed by David Kilzer.

  • Makefile:

Added temporary filters for projects not yet building on iOS.

  • DumpRenderTree/Makefile:

Building with iOS SDKs -> -target All-iOS

  • Scripts/webkitdirs.pm:

(determineConfiguration):
Added --configuration switch detection.
(determineArchitecture):
Added --architecture and ARCH=(.*) switch detection.
(argumentsForConfiguration):
(determineXcodeSDK):
Look for --device, --simulator, and --sdk switches.
(xcodeSDK):
Added.
(XcodeOptions):
Determine Xcode SDK and generate -arch switches.

8:08 AM Changeset in webkit [140911] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[v8] prepare SerializedScriptValue for transition to Latin-1
​https://bugs.webkit.org/show_bug.cgi?id=107655

Patch by Dan Carney <​dcarney@google.com> on 2013-01-26
Reviewed by Kentaro Hara.

No new tests. Covered by existing tests.

  • bindings/v8/SerializedScriptValue.cpp:
2:01 AM Changeset in webkit [140910] by jschuh@chromium.org
  • 4 edits in trunk/Source

[CHROMIUM] Suppress more c4267 build warnings for Win64 targets
​https://bugs.webkit.org/show_bug.cgi?id=107993

Source/WebCore:

No new tests. No behavior change.

Reviewed by Abhishek Arya.

  • WebCore.gyp/WebCore.gyp:

Source/WTF:

Reviewed by Abhishek Arya.

  • WTF.gyp/WTF.gyp:
1:51 AM Changeset in webkit [140909] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r139078.

  • WebCoreSupport/ChromeClientWinCE.h:

(ChromeClientWinCE):

1:51 AM Changeset in webkit [140908] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for USE(JSC) && !ENABLE(WORKERS) after r136686.

  • bindings/js/DOMRequestState.h:

(WebCore::DOMRequestState::DOMRequestState):

1:36 AM Changeset in webkit [140907] by robert@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION(r120616): Cell's logical height wrongly computed with vertical-align: baseline and rowspan
​https://bugs.webkit.org/show_bug.cgi?id=106571

Reviewed by Julien Chaffraix.

Source/WebCore:

When a cell spans multiple rows, its baseline is set on the first row it spans. r120616 contained a
couple of errors in its attempt to ensure the row height calculated in such cases was correct. When it
calculated the baseline on the first row in the span, it didn't ensure that the row height was increased
if necessary. It also suffered from allowing the baseline descent calculated on a rowspan to affect the
height of the other cells in the first row of the span.

Fix both of these errors in calcRowLogicalHeight() and refactor the calculation of the baseline and baseline
descent so that it is freestanding (rather than depending on the height of the section so far).

Tests: fast/css/vertical-align-baseline-rowspan-010.html

fast/css/vertical-align-baseline-rowspan-011.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

  • fast/css/vertical-align-baseline-rowspan-010-expected.html: Added.
  • fast/css/vertical-align-baseline-rowspan-010.html: Added.
  • fast/css/vertical-align-baseline-rowspan-011-expected.html: Added.
  • fast/css/vertical-align-baseline-rowspan-011.html: Added.
12:13 AM Changeset in webkit [140906] by simonjam@chromium.org
  • 6 edits in trunk/Source

[chromium] Export ResourceRequest's priority through WebURLRequest
​https://bugs.webkit.org/show_bug.cgi?id=107985

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebURLRequest.h:

(WebURLRequest):

Source/WebCore:

No new tests.

  • platform/chromium/support/WebURLRequest.cpp:

(WebKit::WebURLRequest::priority):
(WebKit):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:

Jan 25, 2013:

11:59 PM Changeset in webkit [140905] by Christophe Dumez
  • 6 edits in trunk/Source/WebKit2

[EFL][WK2] Use C API inside ewk_database_manager and ewk_storage_manager
​https://bugs.webkit.org/show_bug.cgi?id=107920

Reviewed by Benjamin Poulain.

Use C API inside ewk_database_manager and ewk_storage_manager instead
of accessing internal C++ classes directly, to avoid violating API
layering.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):

  • UIProcess/API/efl/ewk_database_manager.cpp:

(EwkDatabaseManager::EwkDatabaseManager):
(EwkDatabaseManager::getDatabaseOrigins):

  • UIProcess/API/efl/ewk_database_manager_private.h:

(EwkDatabaseManager::create):
(EwkDatabaseManager):

  • UIProcess/API/efl/ewk_storage_manager.cpp:

(EwkStorageManager::EwkStorageManager):
(EwkStorageManager::getStorageOrigins):

  • UIProcess/API/efl/ewk_storage_manager_private.h:

(EwkStorageManager::create):
(EwkStorageManager):

10:07 PM Changeset in webkit [140904] by fpizlo@apple.com
  • 16 edits
    1 add in trunk/Source/JavaScriptCore

DFG variable event stream shouldn't use NodeIndex
​https://bugs.webkit.org/show_bug.cgi?id=107996

Reviewed by Oliver Hunt.

Introduce the notion of a DFG::MinifiedID, which is just a unique ID of a DFG Node.
Internally it currently uses a NodeIndex, but we could change this without having
to recode all of the users of MinifiedID. This effectively decouples the OSR exit
compiler's way of identifying nodes from the speculative JIT's way of identifying
nodes, and should make it easier to make changes to the speculative JIT's internals
in the future.

Also changed variable event stream logging to exclude information about births and
deaths of constants, since the OSR exit compiler never cares about which register
holds a constant; if a value is constant then the OSR exit compiler can reify it.

Also changed the variable event stream's value recovery computation to use a
HashMap keyed by MinifiedID rather than a Vector indexed by NodeIndex.

This appears to be performance-neutral. It's primarily meant as a small step
towards ​https://bugs.webkit.org/show_bug.cgi?id=106868.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::GenerationInfo):
(JSC::DFG::GenerationInfo::initConstant):
(JSC::DFG::GenerationInfo::initInteger):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initCell):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::initDouble):
(JSC::DFG::GenerationInfo::initStorage):
(JSC::DFG::GenerationInfo::noticeOSRBirth):
(JSC::DFG::GenerationInfo::use):
(JSC::DFG::GenerationInfo::appendFill):
(JSC::DFG::GenerationInfo::appendSpill):
(GenerationInfo):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGMinifiedGraph.h:

(JSC::DFG::MinifiedGraph::at):
(MinifiedGraph):

  • dfg/DFGMinifiedID.h: Added.

(DFG):
(MinifiedID):
(JSC::DFG::MinifiedID::MinifiedID):
(JSC::DFG::MinifiedID::operator!):
(JSC::DFG::MinifiedID::nodeIndex):
(JSC::DFG::MinifiedID::operator==):
(JSC::DFG::MinifiedID::operator!=):
(JSC::DFG::MinifiedID::operator<):
(JSC::DFG::MinifiedID::operator>):
(JSC::DFG::MinifiedID::operator<=):
(JSC::DFG::MinifiedID::operator>=):
(JSC::DFG::MinifiedID::hash):
(JSC::DFG::MinifiedID::dump):
(JSC::DFG::MinifiedID::isHashTableDeletedValue):
(JSC::DFG::MinifiedID::invalidID):
(JSC::DFG::MinifiedID::otherInvalidID):
(JSC::DFG::MinifiedID::fromBits):
(JSC::DFG::MinifiedIDHash::hash):
(JSC::DFG::MinifiedIDHash::equal):
(MinifiedIDHash):
(WTF):

  • dfg/DFGMinifiedNode.cpp:

(JSC::DFG::MinifiedNode::fromNode):

  • dfg/DFGMinifiedNode.h:

(JSC::DFG::MinifiedNode::id):
(JSC::DFG::MinifiedNode::child1):
(JSC::DFG::MinifiedNode::getID):
(JSC::DFG::MinifiedNode::compareByNodeIndex):
(MinifiedNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::setNodeIndexForOperand):

  • dfg/DFGValueSource.cpp:

(JSC::DFG::ValueSource::dump):

  • dfg/DFGValueSource.h:

(JSC::DFG::ValueSource::ValueSource):
(JSC::DFG::ValueSource::isSet):
(JSC::DFG::ValueSource::kind):
(JSC::DFG::ValueSource::id):
(ValueSource):
(JSC::DFG::ValueSource::idFromKind):
(JSC::DFG::ValueSource::kindFromID):

  • dfg/DFGVariableEvent.cpp:

(JSC::DFG::VariableEvent::dump):
(JSC::DFG::VariableEvent::dumpFillInfo):
(JSC::DFG::VariableEvent::dumpSpillInfo):

  • dfg/DFGVariableEvent.h:

(JSC::DFG::VariableEvent::fillGPR):
(JSC::DFG::VariableEvent::fillPair):
(JSC::DFG::VariableEvent::fillFPR):
(JSC::DFG::VariableEvent::spill):
(JSC::DFG::VariableEvent::death):
(JSC::DFG::VariableEvent::movHint):
(JSC::DFG::VariableEvent::id):
(VariableEvent):

  • dfg/DFGVariableEventStream.cpp:

(DFG):
(JSC::DFG::VariableEventStream::tryToSetConstantRecovery):
(JSC::DFG::VariableEventStream::reconstruct):

  • dfg/DFGVariableEventStream.h:

(VariableEventStream):

9:47 PM FeatureFlags edited by Laszlo Gombos
Remove XHR_RESPONSE_BLOB -- see r120574 (diff)
9:42 PM Changeset in webkit [140903] by akling@apple.com
  • 4 edits in trunk/Source/WebKit2

[Mac] Defer loading the Web Inspector bundle until it's necessary.
<​http://webkit.org/b/107999>
<rdar://problem/13091861>

Reviewed by Anders Carlsson.

Don't instantiate an NSBundle for the Web Inspector before it's needed.
1.51MB progression on Membuster3.

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::WebInspector):

  • WebProcess/WebPage/WebInspector.h:

(WebInspector):

  • WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::WebInspector::setInspectorUsesWebKitUserInterface):
(WebKit::WebInspector::localizedStringsURL):

9:23 PM Changeset in webkit [140902] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix build break after r140891.

Unreviewed build fix. SerializedScriptValue needs to use PassRefPtr in WK2 as well.

  • Shared/WebSerializedScriptValue.h:

(WebKit::WebSerializedScriptValue::create):

8:06 PM Changeset in webkit [140901] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Don't crash when the WKBundlePageUIClient doesn't implement createPlugInExtraStyleSheet.

Reviewed by Dean Jackson.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::plugInExtraStyleSheet): Check that createPlugInExtraStyleSheet
is provided before calling it.

7:50 PM Changeset in webkit [140900] by roger_fong@apple.com
  • 5 edits
    1 move in trunk/Source

Unreviewed. Rename LLInt projects folder and make appropriate changes to solutions.

  • JavaScriptCore.vcxproj/JavaScriptCore.sln:
  • JavaScriptCore.vcxproj/LLInt: Copied from JavaScriptCore.vcxproj/LLInt.vcproj.
  • JavaScriptCore.vcxproj/LLInt.vcproj: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntAssembly: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntAssembly/LLIntAssembly.make: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntAssembly/LLIntAssembly.vcxproj: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntAssembly/LLIntAssembly.vcxproj.user: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntAssembly/build-LLIntAssembly.sh: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntDesiredOffsets: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.make: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj.user: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntDesiredOffsets/build-LLIntDesiredOffsets.sh: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj.user: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.props: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebug.props: Removed.
  • JavaScriptCore.vcxproj/LLInt.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorRelease.props: Removed.
  • WebKit.vcxproj/WebKit.sln:
6:58 PM Changeset in webkit [140899] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix. All it wanted was one more line.

  • css/plugIns.css:
6:13 PM Changeset in webkit [140898] by Lucas Forschler
  • 4 edits in tags/Safari-537.28.1/Source

Versioning.

6:11 PM Changeset in webkit [140897] by Lucas Forschler
  • 1 copy in tags/Safari-537.28.1

New Tag.

6:11 PM Changeset in webkit [140896] by joone.hur@intel.com
  • 4 edits in trunk/Source

[GTK][AC] Use new Clutter APIs instead of deprecated APIs
​https://bugs.webkit.org/show_bug.cgi?id=105736

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

ClutterCairoTexture class and several APIs have been deprecated since version 1.10,
so ClutterCanvas and ClutterContent should be used instead of ClutterCairoTexture.
clutter_actor_add_child should be used instead of clutter_actor_set_parent and clutter_container_add_clutter.

  • platform/graphics/clutter/GraphicsLayerActor.cpp:

(_GraphicsLayerActorPrivate):
(graphics_layer_actor_init):
(graphicsLayerActorDispose):
(graphicsLayerActorAllocate):
(graphicsLayerActorPaint):
(graphicsLayerActorDraw):
(graphicsLayerActorUpdateTexture):
(graphicsLayerActorNew):
(graphicsLayerActorRemoveAll):
(graphicsLayerActorInvalidateRectangle):
(graphicsLayerActorInsertSublayer):
(graphicsLayerActorSetSublayers):

Source/WebKit/gtk:

Use clutter_actor_set_background_color instead of clutter_stage_set_color.
Use clutter_actor_add_child instead of clutter_container_add_actor.
Remove clutter_actor_show_all because Actors are visible by default.

  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp:

(WebKit::AcceleratedCompositingContext::setRootCompositingLayer):

6:03 PM Changeset in webkit [140895] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for Windows.

  • css/plugIns.css:

(p):

5:52 PM Changeset in webkit [140894] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Share code between the different min-content / max-content code paths
​https://bugs.webkit.org/show_bug.cgi?id=107740

Reviewed by Tony Chang.

This change enables sharing between the different content based computations
by using function pointers to specialize the behavior as needed.

Refactoring, covered by existing tests.

  • rendering/RenderGrid.cpp:

(WebCore::GridTrack::growUsedBreadth):
(WebCore::GridTrack::usedBreadth):
(WebCore::GridTrack::growMaxBreadth):
Added the previous getters / setters that will be passed to resolveContentBasedTrackSizingFunctionsForItems.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
Updated to reuse resolveContentBasedTrackSizingFunctionsForItems instead of duplicating code.
One change is that now, we properly apply the min on all branches, which was an oversight of
the previous patches.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Added this function as the core content-sized resolution function. For now, we pass the
current track by direction & index to be able to filter grid items.

  • rendering/RenderGrid.h:

Added resolveContentBasedTrackSizingFunctionsForItems and the function pointers typedef's.

5:42 PM Changeset in webkit [140893] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove InjectedScript::wrapSerializedObject()
​https://bugs.webkit.org/show_bug.cgi?id=107906

Reviewed by Abhishek Arya.

InjectedScript::wrapSerializedObject() is unused.
(This is one of steps to remove raw pointers of SerializedScriptValue*,
which can be a security concern.)

  • inspector/InjectedScript.cpp:
  • inspector/InjectedScript.h:

(InjectedScript):

5:38 PM Changeset in webkit [140892] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

Keep a RefPtr<SerializedScriptValue*> when we call serialize()/deserialize() in code generators
​https://bugs.webkit.org/show_bug.cgi?id=107902

Reviewed by Abhishek Arya.

If you use a raw SerializedScriptValue* for serialize()/deserialize(),
it can potentially cause a use-after-free. This is because serialize()/
deserialize() can destruct a RefPtr of the SerializedScriptValue*,
depending on data that is serialized/deserialized. So we should keep a
RefPtr<SerializedScriptValue*> when we call serialize()/deserialize().
(See ​https://bugs.webkit.org/show_bug.cgi?id=107792 for more details.)

No tests. This is just a just-in-case fix.

  • Modules/intents/Intent.h:

(WebCore::Intent::data):

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::postResult):
(WebCore::IntentRequest::postFailure):

  • Modules/intents/IntentRequest.h:

(IntentRequest):

  • Modules/intents/IntentResultCallback.h:

(IntentResultCallback):

  • bindings/scripts/CodeGeneratorJS.pm:

(GetNativeTypeForCallbacks):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GetNativeTypeForCallbacks):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):

  • dom/MessagePortChannel.h:

(WebCore::MessagePortChannel::EventData::message):

5:36 PM Changeset in webkit [140891] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Keep a RefPtr<SerializedScriptValue*> when we call serialize()/deserialize() for MessageEvent
​https://bugs.webkit.org/show_bug.cgi?id=107900

Reviewed by Abhishek Arya.

If you use a raw SerializedScriptValue* for serialize()/deserialize(),
it can potentially cause a use-after-free. This is because serialize()/
deserialize() can destruct a RefPtr of the SerializedScriptValue*,
depending on data that is serialized/deserialized. So we should keep a
RefPtr<SerializedScriptValue*> when we call serialize()/deserialize().
(See ​https://bugs.webkit.org/show_bug.cgi?id=107792 for more details.)

No tests. This is just a just-in-case fix. I couldn't find any bug
even in an ASAN build.

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):

  • dom/MessageEvent.h:

(WebCore::MessageEvent::dataAsSerializedScriptValue):

5:32 PM Changeset in webkit [140890] by Lucas Forschler
  • 4 edits in tags/Safari-537.28/Source

Versioning.

5:32 PM Changeset in webkit [140889] by jochen@chromium.org
  • 10 edits in trunk/Tools

[chromium] move tracking of the top loading frame to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=107948

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::WorkQueue::processWorkSoon):
(DRTTestRunner::WorkQueue::processWork):
(DRTTestRunner::completeNotifyDone):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestProxyBase):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner::WebTestRunner::setTopLoadingFrame):
(WebTestRunner::WebTestRunner::topLoadingFrame):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setTopLoadingFrame):
(WebTestRunner):
(WebTestRunner::TestRunner::topLoadingFrame):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):
(WebTestRunner::TestRunner::locationChangeDone):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didFailLoad):
(WebTestRunner::WebTestProxyBase::didFinishLoad):
(WebTestRunner::WebTestProxyBase::locationChangeDone):
(WebTestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::reset):
(WebViewHost::updateURL):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

5:29 PM Changeset in webkit [140888] by Lucas Forschler
  • 1 copy in tags/Safari-537.28

New Tag.

5:28 PM Changeset in webkit [140887] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Keep a RefPtr<SerializedScriptValue*> when we call serialize()/deserialize() (part 1)
​https://bugs.webkit.org/show_bug.cgi?id=107891

Reviewed by Abhishek Arya.

If you use a raw SerializedScriptValue* for serialize()/deserialize(),
it can potentially cause a use-after-free. This is because serialize()/
deserialize() can destruct a RefPtr of the SerializedScriptValue*,
depending on data that is serialized/deserialized. So we should keep a
RefPtr<SerializedScriptValue*> when we call serialize()/deserialize().
(See ​https://bugs.webkit.org/show_bug.cgi?id=107792 for more details.)

No tests. This is just a just-in-case fix. I couldn't find any bug
even in an ASAN build.

  • bindings/v8/custom/V8CustomEventCustom.cpp:

(WebCore::V8CustomEvent::detailAccessorGetter):

5:26 PM Changeset in webkit [140886] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Keep a RefPtr<SerializedScriptValue*> when we call serialize()/deserialize() in PopStateEvent
​https://bugs.webkit.org/show_bug.cgi?id=107904

Reviewed by Abhishek Arya.

If you use a raw SerializedScriptValue* for serialize()/deserialize(),
it can potentially cause a use-after-free. This is because serialize()/
deserialize() can destruct a RefPtr of the SerializedScriptValue*,
depending on data that is serialized/deserialized. So we should keep a
RefPtr<SerializedScriptValue*> when we call serialize()/deserialize().
(See ​https://bugs.webkit.org/show_bug.cgi?id=107792 for more details.)

No tests. This is just a just-in-case fix.

  • dom/PopStateEvent.h:

(WebCore::PopStateEvent::serializedState):

  • page/History.cpp:

(WebCore::History::isSameAsCurrentState):

  • page/History.h:

(History):

5:13 PM Changeset in webkit [140885] by esprehn@chromium.org
  • 2 edits in trunk/LayoutTests

Make unload-reparent-sibling-frame.html wait for completion
​https://bugs.webkit.org/show_bug.cgi?id=107987

Reviewed by Ojan Vafai.

While this test runs fine locally and in the cr-linux EWS it
appears to be flaky on many of the other bots because it doesn't
wait for the test to complete. Instead make the waiting in the test
explicit.

  • fast/frames/unload-reparent-sibling-frame.html:
5:05 PM Changeset in webkit [140884] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Rename CodeGenerator::IsSubType() to CodeGenerator::InheritsInterface()
​https://bugs.webkit.org/show_bug.cgi?id=107874

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(InheritsInterface):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GetInternalFields):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateFunctionCallback):
(GenerateImplementationIndexer):
(GenerateToV8Converters):

4:57 PM Changeset in webkit [140883] by haraken@chromium.org
  • 17 edits in trunk/Source/WebCore

[V8] Pass an Isolate to GetRawTemplate()
​https://bugs.webkit.org/show_bug.cgi?id=107927

Reviewed by Adam Barth.

This is one of steps to kill an optional Isolate parameter of GetRawTemplate().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateImplementation):
(CreateCustomSignature):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::createContext):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAccessorGetter):
(WebCore::V8Location::replaceAccessorGetter):
(WebCore::V8Location::assignAccessorGetter):

4:54 PM Changeset in webkit [140882] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Source/WebCore: [User Timing]Change class name that presented in Javascript for user timing entry.
​https://bugs.webkit.org/show_bug.cgi?id=107925.

Patch by Pan Deng <​pan.deng@intel.com> on 2013-01-25
Reviewed by Tony Gentilcore.

In current implementation, class type of user timing entries are PerformanceEntry, according
to W3C spec, they should be PerformanceMark and PerformanceMeasure.

Test: http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type.html

  • bindings/v8/custom/V8PerformanceEntryCustom.cpp:

(WebCore::wrap):

  • page/PerformanceEntry.h:

(WebCore::PerformanceEntry::isMark):
(WebCore::PerformanceEntry::isMeasure):

  • page/PerformanceMark.h:

(WebCore::PerformanceMark::isMark):
(PerformanceMark):

  • page/PerformanceMeasure.h:

(WebCore::PerformanceMeasure::isMeasure):
(PerformanceMeasure):

LayoutTests: [User Timing] Class name of user timing entries should be PerformanceMark/PerformanceMeasure.
​https://bugs.webkit.org/show_bug.cgi?id=107925.

Patch by Pan Deng <​pan.deng@intel.com> on 2013-01-25
Reviewed by Tony Gentilcore.

  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type-expected.txt: Added.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type.html: Added.
4:47 PM Changeset in webkit [140881] by roger_fong@apple.com
  • 8 edits
    1 add in trunk/Source/WebCore

Updated WebCore property sheets and added a WebCore solution file.
​https://bugs.webkit.org/show_bug.cgi?id=106988.

Rubberstamped by Brent Fulgham.

  • WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj:
  • WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj.filters:
  • WebCore.vcxproj/QTMovieWin/QTMovieWinCommon.props:
  • WebCore.vcxproj/WebCore.sln: Added.
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.vcxproj/WebCoreDebug.props:
4:40 PM Changeset in webkit [140880] by ojan@chromium.org
  • 31 edits
    3 adds in trunk

MathML preferred widths should not depend on layout information
​https://bugs.webkit.org/show_bug.cgi?id=107353

Reviewed by Levi Weintraub.

Source/WebCore:

  • mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::attach):
(WebCore::MathMLTextElement::childrenChanged):

  • mathml/MathMLTextElement.h:

Need to update the render tree when the text of a <mo> changes.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::RenderMathMLBlock):

  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::styleDidChange):
Need to update the rendertree to apply operator stretching.

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::glyphHeightForCharacter):
(WebCore::RenderMathMLOperator::widthForCharacter):
(WebCore::RenderMathMLOperator::computeIntrinsicLogicalWidths):
(WebCore::RenderMathMLOperator::stretchDisabledByMarkup):
(WebCore::RenderMathMLOperator::firstTextCharacter):
(WebCore::RenderMathMLOperator::stretchyCharacterIndex):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
-Make the preferred widths of operators the max of all possible
characters to be used in the operator and center the operator in that width.
-For stretching where we don't use multiple glyphs, use transforms
instead of font-size. This both looks better and avoids affecting the width.
-Now that preferred widths don't depends on height, we don't need to
override computePreferredLogicalWidths at all in MathML code.

  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::index):
Tighten up the type.

(WebCore::RenderMathMLRoot::layout):
Move the laying out of children to the layout method.

  • rendering/mathml/RenderMathMLRoot.h:
  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::logicalHeightExcludingOperators):
(WebCore::RenderMathMLRow::stretchOperatorsAndLayout):
(WebCore::RenderMathMLRow::layout):
Move the laying out of children and the subsequent setting of stretchHeight
to the layout method.

  • rendering/mathml/RenderMathMLRow.h:

LayoutTests:

  • mathml/differentiable-manifold.html: Added.
  • platform/chromium-linux/mathml/differentiable-manifold-expected.png: Added.
  • platform/chromium-linux/mathml/differentiable-manifold-expected.txt: Added.
  • platform/chromium-linux/mathml/presentation/fenced-expected.txt:
  • platform/chromium-linux/mathml/presentation/fenced-mi-expected.png:
  • platform/chromium-linux/mathml/presentation/fenced-mi-expected.txt:
  • platform/chromium-linux/mathml/presentation/mo-expected.txt:
  • platform/chromium-linux/mathml/presentation/mo-stretch-expected.png:
  • platform/chromium-linux/mathml/presentation/mo-stretch-expected.txt:
  • platform/chromium-linux/mathml/presentation/over-expected.txt:
  • platform/chromium-linux/mathml/presentation/row-alignment-expected.txt:
  • platform/chromium-linux/mathml/presentation/row-expected.png:
  • platform/chromium-linux/mathml/presentation/row-expected.txt:
  • platform/chromium-linux/mathml/presentation/sub-expected.png:
  • platform/chromium-linux/mathml/presentation/sub-expected.txt:
  • platform/chromium-linux/mathml/presentation/subsup-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
4:36 PM Changeset in webkit [140879] by Raymond Toy
  • 2 edits in trunk/Source/WebCore

Don't subtract too much from nonSilentFramesToProcess
​https://bugs.webkit.org/show_bug.cgi?id=107966

Reviewed by Kenneth Russell.

No new tests.

  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):

4:24 PM Changeset in webkit [140878] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Windows build fix by Dean.

  • css/plugIns.css:

(object):

4:20 PM Changeset in webkit [140877] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Support language WebVTT Nodes
​https://bugs.webkit.org/show_bug.cgi?id=107907

Patch by Dima Gorbik <​dgorbik@apple.com> on 2013-01-25
Reviewed by Eric Carlson.

Source/WebCore:

Language stack and WebVTT language nodes are added as
required by specs.

Test: media/track/track-css-matching-lang.html

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::copyWebVTTNodeToDOMTree): WebVTT language nodes should be
spans in DOM and the lang attribute should be set for all nodes if applicable.

  • html/track/TextTrackCue.h:

(WebCore::TextTrackCue::langElementTagName):
(TextTrackCue):
(WebCore::TextTrackCue::langAttributeName):

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::createDocumentFragmentFromCueText): clear the language stack in case
we use the same parser object for multiple cues that have incorrect syntax.
(WebCore::isLangToken):
(WebCore):
(WebCore::WebVTTParser::constructTreeFromToken): parse lang WebVTT objects.

  • html/track/WebVTTParser.h:

(WebVTTParser):

LayoutTests:

  • media/track/captions-webvtt/styling-lang.vtt: Added.
  • media/track/track-css-matching-lang-expected.txt: Added.
  • media/track/track-css-matching-lang.html: Added.
4:19 PM Changeset in webkit [140876] by aestes@apple.com
  • 4 edits in trunk/WebKitLibraries

Update WKSI header and libraries after r140875.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
4:10 PM Changeset in webkit [140875] by aestes@apple.com
  • 11 edits
    2 adds in trunk/Source

Wrap content filtering code in an object
​https://bugs.webkit.org/show_bug.cgi?id=107914

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Content filtering code currently requires explicit and somewhat complex
lifetime management of the WebFilterEvaluator object for correct
behavior. Simplify this by wrapping WebFilterEvaluator in an object and
have MainResourceLoader implicitly manage its lifetime by holding it in
an OwnPtr.

This change has benefits other than the simplified lifetime management.
It removes direct calls into WebKitSystemInterface from the loader, and
it allows us to keep a strong reference to the replacement data
returned from wkFilterAddData() and wkFilterDataComplete() rather than
relying on it being autoreleased.

  • WebCore.exp.in: Updated to match changes in WebCoreSystemInterface.
  • WebCore.xcodeproj/project.pbxproj: Added new files.
  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::MainResourceLoader): Removed unneeded initialization.
(WebCore::MainResourceLoader::~MainResourceLoader): Removed an unneeded ASSERT().
(WebCore::MainResourceLoader::cancel): Removed unneeded wkFilterRelease().
(WebCore::MainResourceLoader::responseReceived): Created a
ContentFilter object rather than calling wkFilterCreateInstance().
(WebCore::MainResourceLoader::dataReceived): Rewrote content filtering
logic in terms of the wrapper object. Removed any explicit lifetime
management.
(WebCore::MainResourceLoader::didFinishLoading): Ditto.
(WebCore::MainResourceLoader::notifyFinished): Removed unneeded wkFilterRelease().

  • loader/MainResourceLoader.h:
  • platform/ContentFilter.h: Added.
  • platform/mac/ContentFilterMac.mm: Added.

(WebCore::ContentFilter::create):
(WebCore::ContentFilter::ContentFilter):
(WebCore::ContentFilter::isEnabled): Returned the result of wkFilterIsManagedSession().
(WebCore::ContentFilter::addData): Called wkFilterAddData() and stored
the resulting NSData in m_replacementData.
(WebCore::ContentFilter::finishedAddingData): Called wkFilterDataComplete()
and stored the resulting NSData in m_replacementData.
(WebCore::ContentFilter::needsMoreData): Returned the result of wkFilterIsBuffering().
(WebCore::ContentFilter::didBlockData): Returned the result of wkFilterWasBlocked().
(WebCore::ContentFilter::getReplacementData): Returned the data stored in m_replacementData.

  • platform/mac/WebCoreSystemInterface.h: Updated to reflect changes in WKSI.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::~MainResourceLoader):
(WebCore::MainResourceLoader::cancel):
(WebCore::MainResourceLoader::responseReceived):
(WebCore::MainResourceLoader::dataReceived):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::notifyFinished):

  • loader/MainResourceLoader.h:

(MainResourceLoader):

  • platform/ContentFilter.h: Added.

(WebCore):
(ContentFilter):

  • platform/mac/ContentFilterMac.mm: Added.

(WebCore):
(WebCore::ContentFilter::create):
(WebCore::ContentFilter::ContentFilter):
(WebCore::ContentFilter::isEnabled):
(WebCore::ContentFilter::addData):
(WebCore::ContentFilter::finishedAddingData):
(WebCore::ContentFilter::needsMoreData):
(WebCore::ContentFilter::didBlockData):
(WebCore::ContentFilter::getReplacementData):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Updated to reflect changes in WKSI.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Updated to reflect changes in WKSI.

4:03 PM Changeset in webkit [140874] by beidson@apple.com
  • 20 edits in trunk/Source/WebKit2

HTTP Authentication should be directly between the NetworkProcess and the UIProcess
<rdar://problem/13074829> and ​https://bugs.webkit.org/show_bug.cgi?id=107974

Reviewed by Alexey Proskuryakov.

Some of this patch is refactoring to enable more flexibility in the authentication mechanism
and the rest is actually implementing Network->UI process authentication.

Expose the same AuthenticationManager to anyone in the NetworkProcess asking for it:

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::authenticationManager):
(WebKit::NetworkProcess::downloadsAuthenticationManager):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveAuthenticationChallenge): Instead of messaging to

the WebProcess, tell the NetworkProcess AuthenticationManager.

Add WebPageID and WebFrameID members to SchedulableLoader that they receive from

  • NetworkProcess/SchedulableLoader.cpp:
  • NetworkProcess/SchedulableLoader.h:

(WebKit::SchedulableLoader::webPageID):
(WebKit::SchedulableLoader::webFrameID):

Add a 3rd form of "didReceiveAuthenticationChallenge" for NetworkProcess use:

  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::mapChallengeToIdentifier):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):

  • Shared/Authentication/AuthenticationManager.h:
  • Shared/Authentication/mac/AuthenticationManager.mac.mm:

(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge): Remove a now obsolete comment

Include the WebPage and WebFrame ID for the originator of this request in case it results in a challenge:

  • Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):

  • Shared/Network/NetworkResourceLoadParameters.h:

(WebKit::NetworkResourceLoadParameters::webPageID):
(WebKit::NetworkResourceLoadParameters::webFrameID):

Create a AuthenticationChallengeProxy pointing back to the NetworkProcess (instead of a WebProcess),
and send the challenge to the appropriate WebPageProxy:

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didReceiveAuthenticationChallenge):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.messages.in:

Refactor didReceiveAuthenticationChallenge so an outsider can directly hand over an AuthenticationChallengeProxy:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):
(WebKit::WebPageProxy::didReceiveAuthenticationChallengeProxy):

  • UIProcess/WebPageProxy.h:

Add a global WebPageID -> WebPageProxy map so parties with an ID don't need to know which process it belongs to:

  • UIProcess/WebProcessProxy.cpp:

(WebKit::globalPageMap):
(WebKit::WebProcessProxy::webPage):
(WebKit::WebProcessProxy::createWebPage):
(WebKit::WebProcessProxy::addExistingWebPage):
(WebKit::WebProcessProxy::removeWebPage):

  • UIProcess/WebProcessProxy.h:
  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::loadResourceSynchronously): Pass 0 for WebFrameID and WebPageID since synchronous

loads don't go through "normal" authentication channels and don't need them. Yet.

3:56 PM Changeset in webkit [140873] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

When the FrameView has a non-opaque background color, make sure the TileCache tiles are not opaque
​https://bugs.webkit.org/show_bug.cgi?id=107989

Reviewed by Dean Jackson.

If a WKView was told to draw a transparent background, make sure that we
set the TileCache tiles to be non-opaque.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateRootLayerConfiguration):

3:44 PM Changeset in webkit [140872] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13089261> Crash in WKSandboxExtensionGetSerializedFormat when opening Web Inspector

Reviewed by Brady Eidson.

  • WebProcess/com.apple.WebProcess.sb.in: Should be able to issue extensions for Inspector files.
3:35 PM Changeset in webkit [140871] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the debug build.

  • WebKit2.xcodeproj/project.pbxproj:
3:22 PM Changeset in webkit [140870] by weinig@apple.com
  • 4 edits
    2 copies
    2 moves
    4 adds
    2 deletes in trunk/Source/WebKit2

Move the WebContentServices to WebProcess/EntryPoint/mac/XPCService/.

Reviewed by Anders Carlsson.

  • Configurations/WebContentService.Development.xcconfig:
  • Configurations/WebContentService.xcconfig:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/EntryPoint: Added.
  • WebProcess/EntryPoint/mac: Added.
  • WebProcess/EntryPoint/mac/LegacyProcess: Added.
  • WebProcess/EntryPoint/mac/XPCService: Added.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService: Copied from WebProcessService.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development: Copied from WebProcessServiceForWebKitDevelopment.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm: Copied from WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebProcessServiceForWebKitDevelopmentMain.mm: Removed.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm: Copied from WebProcessService/WebProcessServiceMain.mm.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/WebProcessServiceMain.mm: Removed.
  • WebProcessService: Removed.
  • WebProcessService/Info.plist: Removed.
  • WebProcessService/WebProcessServiceMain.mm: Removed.
  • WebProcessServiceForWebKitDevelopment: Removed.
  • WebProcessServiceForWebKitDevelopment/Info.plist: Removed.
  • WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm: Removed.
3:02 PM Changeset in webkit [140869] by aelias@chromium.org
  • 6 edits in trunk/Source

Call FrameView::contentsResized() when setting fixed layout size
​https://bugs.webkit.org/show_bug.cgi?id=107922

Reviewed by James Robinson.

In fixed layout mode, we should be calling contentsResized() when the
fixed layout size is changed; on the other hand, we don't need to layout
when the visible contents size changes.

This fixes test WebFrameTest::FixedLayoutInitializeAtMinimumPageScale.

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::visibleContentsResized):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setFixedLayoutSize):
(WebCore::ScrollView::setUseFixedLayout):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::computePageScaleFactorLimits):

  • tests/WebFrameTest.cpp:
2:45 PM Changeset in webkit [140868] by eae@chromium.org
  • 1 edit
    9 adds in trunk/LayoutTests

Unreviewed chromium svg rebaseline.

  • platform/chromium-linux-x86/svg/hixie/viewbox: Added.
  • platform/chromium-linux-x86/svg/hixie/viewbox/002-expected.txt: Added.
  • platform/chromium-linux-x86/svg/hixie/viewbox/003-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/viewbox/002-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/viewbox/003-expected.txt: Added.
  • platform/chromium-win-xp/svg/hixie/viewbox/002-expected.txt: Added.
  • platform/chromium-win-xp/svg/hixie/viewbox/003-expected.txt: Added.
  • platform/chromium-win/svg/hixie/viewbox/002-expected.txt: Added.
  • platform/chromium-win/svg/hixie/viewbox/003-expected.txt: Added.
2:35 PM Changeset in webkit [140867] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix an ASSERT in BackgroundHTMLParser::appendPartial
​https://bugs.webkit.org/show_bug.cgi?id=107983

Reviewed by Eric Seidel.

The complier may create a temporary for the isolatedCopy of the source string. This could cause the refCount of the
StringImpl to be greater than one when appendPartial is invoked on the background thread.
This patch ensures the temporary is gone by that time which fixes the ASSERT in numerous layout tests.

No new tests because covered by existing tests.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::append):

2:28 PM Changeset in webkit [140866] by leviw@chromium.org
  • 8 edits
    1 delete in trunk/LayoutTests

Unreviewed gardening. Updating baselines following r140192.

  • platform/chromium-mac-lion/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/chromium-mac-snowleopard/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
  • platform/chromium-win-xp/fast/regions: Removed.
  • platform/chromium-win/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
2:22 PM Changeset in webkit [140865] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

Prepend common plugin sandbox profile to specific per-plugin one.
<rdar://problem/13044349>

Reviewed by Alexey Proskuryakov.

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::initializeSandbox):

1:59 PM Changeset in webkit [140864] by eae@chromium.org
  • 3 edits
    2 copies in branches/chromium/1364

Merge 139659

offsetWidth/height incorrect for images when zoomed
​https://bugs.webkit.org/show_bug.cgi?id=106624

Source/WebCore:

Reviewed by Levi Weintraub.

offsetWidth and height are incorrect for images at certain zoom
levels due to flooring the values ones adjusted for zoom.
By rounding the value instead we avoid the problem and return
the right size.

Test: fast/images/zoomed-offset-size.html

  • dom/Element.cpp:

(WebCore::Element::offsetWidth):
(WebCore::Element::offsetHeight):
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):
Change to round (as opposed to floor) the zoom adjusted value.

  • rendering/RenderObject.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):

  • rendering/style/RenderStyle.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):
Add LayoutUnit version of adjustForAbsoluteZoom to avoid float
conversion.

LayoutTests:

Reviewed by Levi Weintraub.

Add test for offsetWidth/Height for zoomed image.

  • fast/images/zoomed-offset-size-expected.txt: Added.
  • fast/images/zoomed-offset-size.html: Added.

TBR=​eae@chromium.org
Review URL: ​https://codereview.chromium.org/11953117

1:54 PM Changeset in webkit [140863] by dino@apple.com
  • 17 edits
    1 add in trunk/Source

Add a user agent stylesheet for plugins
​https://bugs.webkit.org/show_bug.cgi?id=107890

Reviewed by Alexey Proskuryakov.

Source/WebCore:

As a step along the way to providing a Shadow DOM for plug-in elements, add a
User Agent stylesheet that is loaded when an embed or object element is
in the document. At the moment the stylesheet is empty.

The stylesheet can be overridden by the RenderTheme or the ChromeClient, allowing
ports to provide a custom appearance. This involved hooking up some virtual methods
on ChromeClient, the stubs of which are already implemented in WK2.
As a drive-by, since snapshotted plugins will need some localization I've also
exposed the ChromeClient methods to get text labels.

  • CMakeLists.txt: Add plugIns.css.
  • DerivedSources.make: Ditto.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gyp/WebCore.gyp: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditoo.
  • css/StyleResolver.cpp:

(WebCore::ensureDefaultStyleSheetsForElement): Load and inject new plugInsStyleSheet if there is an object or embed element.

  • css/plugIns.css: Added. Empty for now.
  • page/ChromeClient.h: New methods for querying the client.

(WebCore::ChromeClient::plugInStartLabelTitle):
(WebCore::ChromeClient::plugInStartLabelSubtitle):
(WebCore::ChromeClient::plugInExtraStyleSheet):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::extraPlugInsStyleSheet): Allow the theme to provide an extra stylesheet.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Rename client callbacks

to have a "create" prefix, making it clear that these generate new Strings.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Actually call into

the injected bundle to retrieve any custom stylesheet for plugins.
(WebKit::InjectedBundlePageUIClient::plugInExtraStyleSheet):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient): Add override keyword onto virtual functions now
that the base class has implementations.

1:39 PM Changeset in webkit [140862] by eric.carlson@apple.com
  • 4 edits
    2 adds in trunk

Adding a text track should not make controls visible
​https://bugs.webkit.org/show_bug.cgi?id=107956

Source/WebCore:

Reviewed by Dean Jackson.

Test: media/media-captions-no-controls.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Call updateTextTrackDisplay.
(WebCore::HTMLMediaElement::updateTextTrackDisplay): New, call mediaControls->updateTextTrackDisplay()

if we have controls.

(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Call updateTextTrackDisplay.
(WebCore::HTMLMediaElement::createMediaControls): Hide controls if they should not be

visible. Minor drive by cleanup.

(WebCore::HTMLMediaElement::configureTextTrackDisplay): Drive by cleanup, pull the three lines

from updateClosedCaptionsControls inline and delete it because this was the only caller.

  • html/HTMLMediaElement.h:

LayoutTests:

Reviewed by Dean Jackson.

  • media/media-captions-no-controls-expected.txt: Added.
  • media/media-captions-no-controls.html: Added.
1:13 PM Changeset in webkit [140861] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

NetworkProcess cannot load files with non-ASCII names
​https://bugs.webkit.org/show_bug.cgi?id=107977

Reviewed by Brady Eidson.

  • Shared/Network/NetworkResourceLoadParameters.cpp: (WebKit::NetworkResourceLoadParameters::encode): Use the correct path accessor.
12:59 PM Changeset in webkit [140860] by arv@chromium.org
  • 5 edits
    2 moves
    1 delete in trunk/LayoutTests

Unreviewed Chromium rebaseline.

Rebaseline several tests on Chromium after r140728.

  • platform/chromium-linux/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/chromium-win/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
  • platform/chromium-win/svg/text/font-size-below-point-five-expected.txt:
  • platform/chromium-win/svg/text/text-viewbox-rescale-expected.png:
  • platform/chromium/svg/hixie/viewbox/002-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/hixie/viewbox/002-expected.txt.
  • platform/chromium/svg/hixie/viewbox/003-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/hixie/viewbox/003-expected.txt.
12:41 PM Changeset in webkit [140859] by roger_fong@apple.com
  • 12 edits
    21 adds in trunk/Source/JavaScriptCore

VS2010 JavascriptCore: Clean up property sheets, add a JSC solution, add testRegExp and testAPI projects.
​https://bugs.webkit.org/show_bug.cgi?id=106987

Reviewed by Brent Fulgham.

12:19 PM Changeset in webkit [140858] by eae@chromium.org
  • 2 edits
    1 move
    1 delete in trunk/LayoutTests

Change svg/text/text-rect-precision.html to pass on non-subpixel platforms and add results
​https://bugs.webkit.org/show_bug.cgi?id=107972

Reviewed by Levi Weintraub.

  • platform/chromium-linux/svg/text/text-rect-precision-expected.txt: Removed.
  • platform/chromium-mac/svg/text/text-rect-precision-expected.txt: Removed.
  • svg/text/text-rect-precision.html:
  • svg/text/text-rect-precision-expected.txt: Added
12:18 PM Changeset in webkit [140857] by eric@webkit.org
  • 2 edits in trunk/Source/WTF

Support 4 and 5 argument bound static functions
​https://bugs.webkit.org/show_bug.cgi?id=107973

Reviewed by Anders Carlsson.

Yummy copy/paste template code!
I'm about to use this in a BackgroundHTMLParser patch, but figured this should be landed separately.

  • wtf/Functional.h:

(WTF):
(WTF::R):

12:13 PM Changeset in webkit [140856] by esprehn@chromium.org
  • 4 edits
    2 adds in trunk

Consider all ancestors not just parentElement when disconnecting frames
​https://bugs.webkit.org/show_bug.cgi?id=107769

Reviewed by Eric Seidel.

Source/WebCore:

Previous we only used the parentElement of the frame owner to decide if
we should disconnect the frame, but this means if you reparent a subtree
that contains multiple frames from inside an unload handler we'll disconnect
the subframes even though they're now in a different part of the document.

We can fix this by using containsIncludingShadowDOM, and also simplify the
code by removing ChildFrameDisconnector::Target.

Test: fast/frames/unload-reparent-sibling-frame.html

  • dom/ContainerNodeAlgorithms.cpp:
  • dom/ContainerNodeAlgorithms.h:

(ChildFrameDisconnector):
(ChildFrameDisconnector::Target): Removed.
(WebCore::ChildFrameDisconnector::collectFrameOwners):
(WebCore::ChildFrameDisconnector::disconnectCollectedFrameOwners):

LayoutTests:

Add a test for moving frames around inside unload handlers.

  • fast/frames/unload-reparent-sibling-frame-expected.txt: Added.
  • fast/frames/unload-reparent-sibling-frame.html: Added.
12:07 PM CoordinatedGraphicsSystem edited by Helder Correia
(diff)
11:54 AM Changeset in webkit [140855] by leviw@chromium.org
  • 5 edits in branches/chromium/1364

Merge 140370

Event target rects on the top level document shouldn't be clipped.
​https://bugs.webkit.org/show_bug.cgi?id=107339

Reviewed by James Robinson.

Source/WebCore:

clippedOverflowRectForRepaint clips the top-level RenderView to the viewport, which
is wrong for generating event target rects, as the result will not extend to the bounds
of the document on pages that scroll. Changing the top-level view to use documentRect
instead.

Tests updated to cover bug: platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html

platform/chromium/fast/events/touch/compositor-touch-hit-rects.html

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::accumulateRendererTouchEventTargetRects): Use converToRootView instead of
a loop around convertToContaining view. This is not a change in behavior.
(WebCore::accumulateDocumentEventTargetRects): Switch to use documentRect instead of
clippedOverflowRectForRepaint for the top-level Document, and use converToRootView
to put rects in the coordinates of the top-level document.

LayoutTests:

Updating existing tests to cover this issue.

  • platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
  • platform/chromium/fast/events/touch/compositor-touch-hit-rects.html:
  • platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt:
  • platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html:
  • platform/chromium/fast/events/touch/resources/frame-with-document-touch-handler.html: Added.
  • platform/chromium/TestExpectations:

TBR=​leviw@chromium.org

11:51 AM Changeset in webkit [140854] by tony@chromium.org
  • 3 edits
    6 adds in trunk

Re-layout child blocks when border/padding of the box-sizing:border-box parent is updated
​https://bugs.webkit.org/show_bug.cgi?id=104997

Reviewed by Ojan Vafai.

Source/WebCore:

Original patch by Kent Tamura:
When padding or border is updated for a parent block with
box-sizing:border-box and width, the width of its child block was not
updated.

The change is to look at border width specifically, not all changes to the border style
since changes to border color should not trigger a relayout.

Tests: fast/css/box-sizing-border-box-dynamic-padding-border-update.html

fast/forms/border-color-relayout.html
fast/forms/text/text-padding-dynamic-change.html

  • rendering/RenderBox.cpp:

(WebCore::borderWidthChanged): Helper method to compare border widths.
(WebCore::RenderBox::styleDidChange):
If box-sizing of the old style and/or the new style is border-box and
padding or border is changed, apply setChildNeedsLayout(true) for child
boxes.

LayoutTests:

border-color-relayout.html tests that we handle border color style changes properly.

  • fast/css/box-sizing-border-box-dynamic-padding-border-update-expected.txt: Added.
  • fast/css/box-sizing-border-box-dynamic-padding-border-update.html: Added.
  • fast/forms/border-color-relayout-expected.html: Added.
  • fast/forms/border-color-relayout.html: Added.
  • fast/forms/text/text-padding-dynamic-change-expected.html: Added.
  • fast/forms/text/text-padding-dynamic-change.html: Added.
11:46 AM Changeset in webkit [140853] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION: System directory prefix doesn't have a "+"
​https://bugs.webkit.org/show_bug.cgi?id=107971

Reviewed by Brady Eidson.

  • Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::initializeSandbox): Re-added the "+".
11:45 AM Changeset in webkit [140852] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

New NetworkProcess can ASSERT after old NetworkProcess crashes
​https://bugs.webkit.org/show_bug.cgi?id=107970

Reviewed by Alexey Proskuryakov.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier): Don't tell the scheduler

to remove a loader that doesn't exist, as we might be recovering from a crash.

11:20 AM Changeset in webkit [140851] by commit-queue@webkit.org
  • 52 edits in trunk

Move WebGLErrorsToConsole page setting to window.internals.settings
​https://bugs.webkit.org/show_bug.cgi?id=107218

Source/WebCore:

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-01-25
Reviewed by Kenneth Russell.

Define webGLErrorsToConsoleEnabled as true by default. Also,
WebGLRenderingContext::m_synthesizedErrorsToConsole is true by default
and can be disabled by settings.

Add a ConsoleDisplayPreference parameter to synthesizeGLError
(defaults to DisplayInConsole). When called with DontDisplayInConsole,
an error message will not be displayed (even if
m_synthesizedErrorsToConsole is true).

Call synthesizeGLError with DontDisplayInConsole in case of synthetic
context lost.

No new tests: covered by existing tests.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::setupFlags):
(WebCore::WebGLRenderingContext::validateRenderingState):
(WebCore::WebGLRenderingContext::loseContextImpl):
(WebCore::WebGLRenderingContext::synthesizeGLError):

  • html/canvas/WebGLRenderingContext.h:
  • page/Settings.in:

LayoutTests:

Set WebGLErrorsToConsoleEnabled to false for WebGL tests which have
errors. Some WebGL error messages depend on OpenGL implementations, so
logging error messages would lead to platform specific output.

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-01-25
Reviewed by Kenneth Russell.

  • fast/canvas/webgl/attrib-location-length-limits.html:
  • fast/canvas/webgl/bad-arguments-test.html:
  • fast/canvas/webgl/buffer-bind-test.html:
  • fast/canvas/webgl/buffer-data-array-buffer.html:
  • fast/canvas/webgl/compressed-tex-image.html:
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
  • fast/canvas/webgl/context-lost-restored.html:
  • fast/canvas/webgl/context-lost.html:
  • fast/canvas/webgl/draw-arrays-out-of-bounds.html:
  • fast/canvas/webgl/draw-elements-out-of-bounds.html:
  • fast/canvas/webgl/error-reporting.html:
  • fast/canvas/webgl/framebuffer-object-attachment.html:
  • fast/canvas/webgl/framebuffer-test.html:
  • fast/canvas/webgl/get-active-test.html:
  • fast/canvas/webgl/gl-bind-attrib-location-test.html:
  • fast/canvas/webgl/gl-enable-enum-test.html:
  • fast/canvas/webgl/gl-enum-tests.html:
  • fast/canvas/webgl/gl-object-get-calls.html:
  • fast/canvas/webgl/gl-uniform-arrays.html:
  • fast/canvas/webgl/gl-uniformmatrix4fv.html:
  • fast/canvas/webgl/gl-vertexattribpointer.html:
  • fast/canvas/webgl/glsl-conformance.html:
  • fast/canvas/webgl/incorrect-context-object-behaviour.html:
  • fast/canvas/webgl/index-validation-copies-indices.html:
  • fast/canvas/webgl/index-validation-verifies-too-many-indices.html:
  • fast/canvas/webgl/index-validation.html:
  • fast/canvas/webgl/invalid-passed-params.html:
  • fast/canvas/webgl/null-object-behaviour.html:
  • fast/canvas/webgl/object-deletion-behaviour.html:
  • fast/canvas/webgl/program-test.html:
  • fast/canvas/webgl/read-pixels-pack-alignment.html:
  • fast/canvas/webgl/read-pixels-test.html:
  • fast/canvas/webgl/script-tests/texImageTest.js:
  • fast/canvas/webgl/shader-deleted-by-accessor.html:
  • fast/canvas/webgl/shader-precision-format.html:
  • fast/canvas/webgl/tex-input-validation.html:
  • fast/canvas/webgl/tex-sub-image-2d-bad-args.html:
  • fast/canvas/webgl/texture-complete.html:
  • fast/canvas/webgl/texture-npot.html:
  • fast/canvas/webgl/type-conversion-test.html:
  • fast/canvas/webgl/uniform-location-length-limits.html:
  • fast/canvas/webgl/uniform-location.html:
  • fast/canvas/webgl/webgl-depth-texture.html:
  • fast/canvas/webgl/webgl-specific.html:
  • fast/canvas/webgl/webgl-texture-binding-preserved.html:
  • inspector/profiler/webgl/webgl-profiler-api-changes.html:
  • inspector/profiler/webgl/webgl-profiler-get-error.html:
11:05 AM Changeset in webkit [140850] by alecflett@chromium.org
  • 14 edits in trunk/Source

IndexedDB: Move TaskType enum to IDBDatabaseBackendInterface
​https://bugs.webkit.org/show_bug.cgi?id=107960

Reviewed by Tony Chang.

Source/WebCore:

The IDBTransactionBackendInterface class is going away,
this is an easy search-and-replace patch to keep these
changes out of more complex patches.

No new tests, just part of a refactor.

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):

  • Modules/indexeddb/IDBCursorBackendImpl.h:

(WebCore::IDBCursorBackendImpl::create):
(IDBCursorBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setIndexesReady):
(WebCore::OpenCursorOperation::perform):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::openCursor):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::create):
(WebCore::IDBRequest::IDBRequest):

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):
(WebCore::IDBRequest::taskType):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::scheduleTask):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore::IDBTransactionBackendImpl::scheduleTask):
(IDBTransactionBackendImpl):

  • Modules/indexeddb/IDBTransactionBackendInterface.h:

Source/WebKit/chromium:

Update asserts to reflect new enum location.

  • src/AssertMatchingEnums.cpp:
11:00 AM Changeset in webkit [140849] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Pop-up WebViews should not take ownership of the backing store.
​https://bugs.webkit.org/show_bug.cgi?id=107957

Patch by Andrew Lo <​anlo@rim.com> on 2013-01-25
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

Internal PR 274581.
Add web setting for whether a WebPage should take the backing store.
Prevent pop-up WebView from taking ownership of the backing
store when it becomes visible.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setVisible):

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::isBackingStoreEnabled):
(BlackBerry::WebKit::WebSettings::setBackingStoreEnabled):

  • Api/WebSettings.h:
  • WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::PagePopupBlackBerry::PagePopupBlackBerry):
(WebCore::PagePopupBlackBerry::init):

10:45 AM Changeset in webkit [140848] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Regression(r139836): Crash in WTF::equalIgnoringCase
​https://bugs.webkit.org/show_bug.cgi?id=107703

Reviewed by Eric Seidel.

Source/WebCore:

Check |a| is a CSS_IDENT before considering it a string and
calling equalIgnoringCase on it. To avoid future mistakes like
this, add a function override for equalIgnoringCase that takes
CSSParserValue as a parameter and ASSERTs if that CSSParserValue
is not a CSS_STRING/CSS_IDENT.

Test: fast/gradients/parse-radial-gradient-crash.html

  • css/CSSParser.cpp:

(WebCore):
(WebCore::equalIgnoringCase):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::parseDeprecatedGradientPoint):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):

LayoutTests:

  • fast/gradients/parse-radial-gradient-crash-expected.txt: Added.
  • fast/gradients/parse-radial-gradient-crash.html: Added.
10:33 AM Changeset in webkit [140847] by sudarsana.nagineni@linux.intel.com
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaselining after r140448, r140459, r140493 and 140593.

  • platform/efl/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt: Added.
  • platform/efl/fast/dom/constructed-objects-prototypes-expected.txt: Added.
  • platform/efl/fast/js/global-constructors-expected.txt:
10:19 AM Changeset in webkit [140846] by sudarsana.nagineni@linux.intel.com
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed EFL gardening.

Remove unnecessary platform expectations for now-passing test.

  • platform/efl/inspector/editor/text-editor-highlight-regexp-expected.txt: Removed.
  • platform/efl/media/media-can-play-ogg-expected.txt: Removed.
10:11 AM Changeset in webkit [140845] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Build broken when svg is disabled.
​https://bugs.webkit.org/show_bug.cgi?id=92393.

Unreviewed build fix.

Patch by Chang Shu <​cshu@webkit.org> on 2013-01-25

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):

10:08 AM Changeset in webkit [140844] by arv@chromium.org
  • 4 edits
    1 copy
    8 deletes in trunk/LayoutTests

Unreviewed Chromium rebaseline.

Rebaseline svg/batik tests.

  • platform/chromium-mac-lion/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textLayout-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/batik/text/textLayout-expected.png.
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac/svg/batik/text/textLayout-expected.png:
  • platform/chromium-win-xp/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.txt: Removed.
  • platform/chromium-win-xp/svg/batik/text/textLayout2-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/textLength-expected.png: Removed.
  • platform/efl/svg/batik/text/textFeatures-expected.png: Removed.
  • platform/efl/svg/batik/text/textLayout-expected.png: Removed.
  • platform/efl/svg/batik/text/textLayout2-expected.png: Removed.
10:07 AM Changeset in webkit [140843] by ap@apple.com
  • 9 edits in trunk/Source/WebKit2

Send sandbox extensions for local files to NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=107872

Reviewed by Brady Eidson.

Send sandbox extensions in NetworkResourceLoadParameters, and consume/invalidate
them during loading. Changed NetworkProcess code to only use that class for IPC,
not for actual implementation.

  • NetworkProcess/HostRecord.cpp: (WebKit::HostRecord::scheduleResourceLoader):
  • NetworkProcess/NetworkResourceLoadScheduler.cpp: (WebKit::NetworkResourceLoadScheduler::scheduleLoader): (WebKit::NetworkResourceLoadScheduler::removeLoader): (WebKit::NetworkResourceLoadScheduler::receivedRedirect):
  • NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::destinationID): (WebKit::NetworkResourceLoader::start): (WebKit::NetworkResourceLoader::resourceHandleStopped): (WebKit::NetworkResourceLoader::didReceiveResponse): (WebKit::NetworkResourceLoader::didFinishLoading): (WebKit::NetworkResourceLoader::didFail): (WebKit::NetworkResourceLoader::shouldUseCredentialStorage):
  • NetworkProcess/SchedulableLoader.cpp: (WebKit::SchedulableLoader::SchedulableLoader): (WebKit::SchedulableLoader::consumeSandboxExtensions): (WebKit::SchedulableLoader::invalidateSandboxExtensions):
  • NetworkProcess/SchedulableLoader.h: (WebKit::SchedulableLoader::identifier): (WebKit::SchedulableLoader::request): (WebKit::SchedulableLoader::priority): (WebKit::SchedulableLoader::contentSniffingPolicy): (WebKit::SchedulableLoader::allowStoredCredentials): (WebKit::SchedulableLoader::inPrivateBrowsingMode): (SchedulableLoader):
  • NetworkProcess/SyncNetworkResourceLoader.cpp: (WebKit::SyncNetworkResourceLoader::start):
  • Shared/Network/NetworkResourceLoadParameters.cpp: (WebKit::NetworkResourceLoadParameters::encode): (WebKit::NetworkResourceLoadParameters::decode):
  • Shared/Network/NetworkResourceLoadParameters.h: (WebKit::NetworkResourceLoadParameters::requestBodyExtensions): (WebKit::NetworkResourceLoadParameters::resourceSandboxExtension):
10:04 AM Changeset in webkit [140842] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

Abort parsing when pending location change for threaded HTML parser
​https://bugs.webkit.org/show_bug.cgi?id=107876

Reviewed by Eric Seidel.

The main thread parser does this in canTakeNextToken. Adding this check to the threaded parser causes us to pass
fast/loader/location-change-aborts-parsing.html.

No new tests because covered by existing tests.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processTokensFromBackgroundParser):

10:02 AM Changeset in webkit [140841] by sudarsana.nagineni@linux.intel.com
  • 180 edits
    7 adds in trunk/LayoutTests

Unreviewed EFL rebaseline.

Rebaseline several tests on EFL port after r140728.

  • platform/efl/svg/carto.net/button-expected.png:
  • platform/efl/svg/carto.net/button-expected.txt:
  • platform/efl/svg/carto.net/colourpicker-expected.png:
  • platform/efl/svg/carto.net/colourpicker-expected.txt:
  • platform/efl/svg/carto.net/combobox-expected.png:
  • platform/efl/svg/carto.net/combobox-expected.txt:
  • platform/efl/svg/carto.net/scrollbar-expected.png:
  • platform/efl/svg/carto.net/scrollbar-expected.txt:
  • platform/efl/svg/carto.net/selectionlist-expected.png:
  • platform/efl/svg/carto.net/selectionlist-expected.txt:
  • platform/efl/svg/carto.net/tabgroup-expected.png:
  • platform/efl/svg/carto.net/tabgroup-expected.txt:
  • platform/efl/svg/carto.net/textbox-expected.png:
  • platform/efl/svg/carto.net/textbox-expected.txt: Added.
  • platform/efl/svg/carto.net/window-expected.png:
  • platform/efl/svg/carto.net/window-expected.txt:
  • platform/efl/svg/clip-path/clip-path-pixelation-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-pixelation-expected.txt:
  • platform/efl/svg/css/group-with-shadow-expected.png:
  • platform/efl/svg/css/group-with-shadow-expected.txt:
  • platform/efl/svg/hixie/perf/003-expected.png:
  • platform/efl/svg/hixie/perf/003-expected.txt:
  • platform/efl/svg/hixie/text/001-expected.txt:
  • platform/efl/svg/hixie/text/003-expected.png:
  • platform/efl/svg/hixie/text/003-expected.txt:
  • platform/efl/svg/hixie/text/003a-expected.png:
  • platform/efl/svg/hixie/text/003a-expected.txt:
  • platform/efl/svg/hixie/text/003b-expected.png:
  • platform/efl/svg/hixie/text/003b-expected.txt:
  • platform/efl/svg/hixie/viewbox/002-expected.txt: Added.
  • platform/efl/svg/hixie/viewbox/003-expected.txt: Added.
  • platform/efl/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
  • platform/efl/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/efl/svg/hixie/viewbox/preserveAspectRatio/002-expected.png:
  • platform/efl/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
  • platform/efl/svg/text/append-text-node-to-tspan-expected.png:
  • platform/efl/svg/text/append-text-node-to-tspan-expected.txt:
  • platform/efl/svg/text/bidi-reorder-value-lists-expected.png:
  • platform/efl/svg/text/bidi-reorder-value-lists-expected.txt:
  • platform/efl/svg/text/bidi-text-anchor-direction-expected.png:
  • platform/efl/svg/text/bidi-text-anchor-direction-expected.txt:
  • platform/efl/svg/text/bidi-text-query-expected.png:
  • platform/efl/svg/text/bidi-text-query-expected.txt:
  • platform/efl/svg/text/bidi-tspans-expected.png:
  • platform/efl/svg/text/bidi-tspans-expected.txt:
  • platform/efl/svg/text/font-size-below-point-five-2-expected.png: Added.
  • platform/efl/svg/text/font-size-below-point-five-2-expected.txt:
  • platform/efl/svg/text/font-size-below-point-five-expected.png:
  • platform/efl/svg/text/font-size-below-point-five-expected.txt:
  • platform/efl/svg/text/modify-text-node-in-tspan-expected.png:
  • platform/efl/svg/text/modify-text-node-in-tspan-expected.txt:
  • platform/efl/svg/text/remove-text-node-from-tspan-expected.png:
  • platform/efl/svg/text/remove-text-node-from-tspan-expected.txt:
  • platform/efl/svg/text/remove-tspan-from-text-expected.png:
  • platform/efl/svg/text/remove-tspan-from-text-expected.txt:
  • platform/efl/svg/text/scaled-font-expected.png: Added.
  • platform/efl/svg/text/scaled-font-expected.txt:
  • platform/efl/svg/text/scaling-font-with-geometric-precision-expected.png:
  • platform/efl/svg/text/scaling-font-with-geometric-precision-expected.txt:
  • platform/efl/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/efl/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/efl/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/efl/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/efl/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/efl/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/efl/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/efl/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/efl/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/efl/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/efl/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/efl/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/efl/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/efl/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/efl/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/efl/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/efl/svg/text/select-x-list-1-expected.png:
  • platform/efl/svg/text/select-x-list-1-expected.txt:
  • platform/efl/svg/text/select-x-list-2-expected.png:
  • platform/efl/svg/text/select-x-list-2-expected.txt:
  • platform/efl/svg/text/select-x-list-3-expected.png:
  • platform/efl/svg/text/select-x-list-3-expected.txt:
  • platform/efl/svg/text/select-x-list-4-expected.png:
  • platform/efl/svg/text/select-x-list-4-expected.txt:
  • platform/efl/svg/text/select-x-list-with-tspans-1-expected.png:
  • platform/efl/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/efl/svg/text/select-x-list-with-tspans-2-expected.png:
  • platform/efl/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/efl/svg/text/select-x-list-with-tspans-3-expected.png:
  • platform/efl/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/efl/svg/text/select-x-list-with-tspans-4-expected.png:
  • platform/efl/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/efl/svg/text/selection-doubleclick-expected.png:
  • platform/efl/svg/text/selection-doubleclick-expected.txt:
  • platform/efl/svg/text/small-fonts-2-expected.png:
  • platform/efl/svg/text/small-fonts-2-expected.txt:
  • platform/efl/svg/text/small-fonts-3-expected.png:
  • platform/efl/svg/text/small-fonts-3-expected.txt:
  • platform/efl/svg/text/small-fonts-expected.png:
  • platform/efl/svg/text/small-fonts-expected.txt: Added.
  • platform/efl/svg/text/small-fonts-in-html5-expected.png:
  • platform/efl/svg/text/small-fonts-in-html5-expected.txt:
  • platform/efl/svg/text/text-align-01-b-expected.png:
  • platform/efl/svg/text/text-align-01-b-expected.txt:
  • platform/efl/svg/text/text-align-02-b-expected.png:
  • platform/efl/svg/text/text-align-02-b-expected.txt:
  • platform/efl/svg/text/text-align-03-b-expected.png:
  • platform/efl/svg/text/text-align-03-b-expected.txt:
  • platform/efl/svg/text/text-align-04-b-expected.png:
  • platform/efl/svg/text/text-align-04-b-expected.txt:
  • platform/efl/svg/text/text-align-05-b-expected.png:
  • platform/efl/svg/text/text-align-05-b-expected.txt:
  • platform/efl/svg/text/text-align-06-b-expected.png:
  • platform/efl/svg/text/text-align-06-b-expected.txt:
  • platform/efl/svg/text/text-altglyph-01-b-expected.png:
  • platform/efl/svg/text/text-altglyph-01-b-expected.txt:
  • platform/efl/svg/text/text-deco-01-b-expected.png:
  • platform/efl/svg/text/text-deco-01-b-expected.txt:
  • platform/efl/svg/text/text-fonts-01-t-expected.png:
  • platform/efl/svg/text/text-fonts-01-t-expected.txt:
  • platform/efl/svg/text/text-hkern-expected.txt:
  • platform/efl/svg/text/text-path-01-b-expected.png:
  • platform/efl/svg/text/text-path-01-b-expected.txt:
  • platform/efl/svg/text/text-path-middle-align-expected.png:
  • platform/efl/svg/text/text-path-middle-align-expected.txt:
  • platform/efl/svg/text/text-spacing-01-b-expected.png:
  • platform/efl/svg/text/text-spacing-01-b-expected.txt:
  • platform/efl/svg/text/text-text-01-b-expected.png:
  • platform/efl/svg/text/text-text-01-b-expected.txt:
  • platform/efl/svg/text/text-text-03-b-expected.png:
  • platform/efl/svg/text/text-text-03-b-expected.txt:
  • platform/efl/svg/text/text-text-04-t-expected.png:
  • platform/efl/svg/text/text-text-04-t-expected.txt:
  • platform/efl/svg/text/text-text-05-t-expected.png:
  • platform/efl/svg/text/text-text-05-t-expected.txt:
  • platform/efl/svg/text/text-text-06-t-expected.png:
  • platform/efl/svg/text/text-text-06-t-expected.txt:
  • platform/efl/svg/text/text-text-07-t-expected.png:
  • platform/efl/svg/text/text-text-07-t-expected.txt:
  • platform/efl/svg/text/text-tref-01-b-expected.png:
  • platform/efl/svg/text/text-tref-01-b-expected.txt:
  • platform/efl/svg/text/text-tselect-01-b-expected.png:
  • platform/efl/svg/text/text-tselect-01-b-expected.txt:
  • platform/efl/svg/text/text-tselect-02-f-expected.png:
  • platform/efl/svg/text/text-tselect-02-f-expected.txt:
  • platform/efl/svg/text/text-tspan-01-b-expected.png:
  • platform/efl/svg/text/text-tspan-01-b-expected.txt:
  • platform/efl/svg/text/text-ws-01-t-expected.png:
  • platform/efl/svg/text/text-ws-01-t-expected.txt:
  • platform/efl/svg/text/text-ws-02-t-expected.png:
  • platform/efl/svg/text/text-ws-02-t-expected.txt:
  • platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/efl/svg/wicd/rightsizing-grid-expected.png:
  • platform/efl/svg/wicd/rightsizing-grid-expected.txt:
  • platform/efl/svg/wicd/sizing-flakiness-expected.png:
  • platform/efl/svg/wicd/sizing-flakiness-expected.txt:
  • platform/efl/svg/wicd/test-rightsizing-b-expected.png:
  • platform/efl/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/efl/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/efl/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/efl/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/efl/svg/zoom/text/zoom-foreignObject-expected.txt:
9:52 AM Changeset in webkit [140840] by wangxianzhu@chromium.org
  • 2 edits in trunk/LayoutTests

debugger-terminate-dedicated-worker-while-paused.html is flaky on chromium-ews
​https://bugs.webkit.org/show_bug.cgi?id=107953

First mark flakyness for it in platform/chromium/TestExpectations.

Reviewed by Ojan Vafai.

  • platform/chromium/TestExpectations:
9:48 AM Changeset in webkit [140839] by mkwst@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: ScriptController::executeIfJavaScriptURL incorrectly checks viewsource mode.
incorrectly blocks execution based on the frame's viewsource state.
​https://bugs.webkit.org/show_bug.cgi?id=101683

Reviewed by Adam Barth.

ScriptController::executeIfJavaScriptURL currently checks whether the
frame in which a 'javascript:' URL might be executed is in viewsource
mode. This incorrectly handles the case where the viewsource attribute
is added after a document loads: the _frame_ is in viewsource mode, the
_document_ is not. The latter should control execution, not the former.

This patch drops the inViewSourceMode check from executeIfJavaScriptURL
entirely, as the document's viewsource state is checked in
canExecuteScripts, which is already called when the 'javascript:' URL is
passed to executeScript. The checks should remain centralized there.

Test: http/tests/security/view-source-javascript-url-in-document.html

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

Drop the incorrect check against the Frame's viewsource mode. The
correct check against the Document's viewsource mode is performed
in canExecuteScripts (which is called via executeScript).

LayoutTests: Merge isViewSource checks in ScriptController::executeIfJavaScriptURL and ScriptController::canExecuteScripts.
​https://bugs.webkit.org/show_bug.cgi?id=101683

Reviewed by Adam Barth.

  • http/tests/security/view-source-javascript-url-in-document-expected.txt: Added.
  • http/tests/security/view-source-javascript-url-in-document.html: Added.
9:37 AM Changeset in webkit [140838] by arv@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed Chromium rebaseline.

Rebaseline tests on Chromium port after r140749.

  • platform/chromium-win/fast/css/resize-corner-tracking-expected.png:
  • platform/chromium/TestExpectations:
9:23 AM Changeset in webkit [140837] by sudarsana.nagineni@linux.intel.com
  • 82 edits
    31 adds in trunk/LayoutTests

Unreviewed EFL rebaseline.

Rebaseline several tests on EFL port after r140728.

  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
  • platform/efl/svg/batik/filters/feTile-expected.png:
  • platform/efl/svg/batik/filters/feTile-expected.txt:
  • platform/efl/svg/batik/masking/maskRegions-expected.png:
  • platform/efl/svg/batik/masking/maskRegions-expected.txt:
  • platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/efl/svg/batik/paints/patternRegionA-expected.png:
  • platform/efl/svg/batik/paints/patternRegionA-expected.txt:
  • platform/efl/svg/batik/text/smallFonts-expected.png: Added.
  • platform/efl/svg/batik/text/smallFonts-expected.txt:
  • platform/efl/svg/batik/text/textAnchor-expected.png:
  • platform/efl/svg/batik/text/textAnchor-expected.txt:
  • platform/efl/svg/batik/text/textAnchor3-expected.png:
  • platform/efl/svg/batik/text/textAnchor3-expected.txt:
  • platform/efl/svg/batik/text/textDecoration-expected.png: Added.
  • platform/efl/svg/batik/text/textDecoration-expected.txt:
  • platform/efl/svg/batik/text/textDecoration2-expected.png:
  • platform/efl/svg/batik/text/textDecoration2-expected.txt:
  • platform/efl/svg/batik/text/textEffect-expected.png: Added.
  • platform/efl/svg/batik/text/textEffect-expected.txt:
  • platform/efl/svg/batik/text/textEffect2-expected.png: Added.
  • platform/efl/svg/batik/text/textEffect2-expected.txt:
  • platform/efl/svg/batik/text/textEffect3-expected.png:
  • platform/efl/svg/batik/text/textEffect3-expected.txt:
  • platform/efl/svg/batik/text/textFeatures-expected.png: Added.
  • platform/efl/svg/batik/text/textFeatures-expected.txt:
  • platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/efl/svg/batik/text/textLayout-expected.png: Added.
  • platform/efl/svg/batik/text/textLayout-expected.txt:
  • platform/efl/svg/batik/text/textLayout2-expected.png: Added.
  • platform/efl/svg/batik/text/textLayout2-expected.txt:
  • platform/efl/svg/batik/text/textLength-expected.png:
  • platform/efl/svg/batik/text/textLength-expected.txt:
  • platform/efl/svg/batik/text/textOnPath-expected.png:
  • platform/efl/svg/batik/text/textOnPath-expected.txt:
  • platform/efl/svg/batik/text/textOnPath3-expected.png:
  • platform/efl/svg/batik/text/textOnPath3-expected.txt:
  • platform/efl/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/efl/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/efl/svg/batik/text/textPCDATA-expected.png:
  • platform/efl/svg/batik/text/textPCDATA-expected.txt:
  • platform/efl/svg/batik/text/textPosition-expected.png:
  • platform/efl/svg/batik/text/textPosition-expected.txt:
  • platform/efl/svg/batik/text/textPosition2-expected.png:
  • platform/efl/svg/batik/text/textPosition2-expected.txt:
  • platform/efl/svg/batik/text/textProperties-expected.png:
  • platform/efl/svg/batik/text/textProperties-expected.txt:
  • platform/efl/svg/batik/text/textProperties2-expected.png: Added.
  • platform/efl/svg/batik/text/textProperties2-expected.txt:
  • platform/efl/svg/batik/text/textStyles-expected.png:
  • platform/efl/svg/batik/text/textStyles-expected.txt:
  • platform/efl/svg/batik/text/verticalText-expected.png:
  • platform/efl/svg/batik/text/verticalText-expected.txt:
  • platform/efl/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/efl/svg/batik/text/verticalTextOnPath-expected.txt:
9:06 AM Changeset in webkit [140836] by kov@webkit.org
  • 3 edits in trunk/Source/WebCore

[Soup] Streamline cancellation and client checks
​https://bugs.webkit.org/show_bug.cgi?id=107808

Reviewed by Martin Robinson.

Covered by existing tests.

  • platform/network/ResourceHandle.h:

(ResourceHandle):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::cancelledOrClientless): new method to check for cancellation and lack of client.
(WebCore):
(WebCore::gotHeadersCallback): use the new method.
(WebCore::restartedCallback): ditto.
(WebCore::redirectCloseCallback): ditto.
(WebCore::redirectSkipCallback): ditto.
(WebCore::wroteBodyDataCallback): ditto.
(WebCore::nextMultipartResponsePartCallback): ditto.
(WebCore::sendRequestCallback): ditto.
(WebCore::networkEventCallback): ditto.
(WebCore::ResourceHandle::platformSetDefersLoading): ditto.
(WebCore::readCallback): ditto.

9:03 AM Changeset in webkit [140835] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] LDFLAGS are being incorrectly used at compile time (rather than linking)
​https://bugs.webkit.org/show_bug.cgi?id=100616

Unreviewed, since this is just a build fix.

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-01-25

  • GNUmakefile.am: use PACKAGE_CFLAGS instead of PACKAGE_LIBS when appending pkg-config

variables to build target _CFLAGS.

8:58 AM Changeset in webkit [140834] by vcarbune@chromium.org
  • 4 edits
    2 adds in trunk

Heap-use-after-free in WebCore::TextTrackCue::isActive
​https://bugs.webkit.org/show_bug.cgi?id=104594

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-remove-active-cue-crash.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::textTrackAddCue):
(WebCore::HTMLMediaElement::textTrackRemoveCue): Remove the cue
from the active cue set as well.

  • html/HTMLMediaElement.h:

(WebCore):

LayoutTests:

  • media/track/track-remove-active-cue-crash-expected.txt: Added.
  • media/track/track-remove-active-cue-crash.html: Added.
8:57 AM Changeset in webkit [140833] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove stale class include
​https://bugs.webkit.org/show_bug.cgi?id=107945

Patch by Claudio Saavedra <Claudio Saavedra> on 2013-01-25
Reviewed by Andreas Kling.

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h:

GeolocationPermissionRequestProxy has nothing to do here.

8:55 AM Changeset in webkit [140832] by sudarsana.nagineni@linux.intel.com
  • 177 edits
    2 copies
    24 adds in trunk/LayoutTests

Unreviewed EFL rebaseline.

Rebaseline several tests on EFL port after r140728.

  • platform/efl/svg/W3C-SVG-1.1/animate-elem-04-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt: Copied from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-05-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-07-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-11-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Copied from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/struct-use-03-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/styling-css-05-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/text-align-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/text-align-02-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/text-align-05-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/text-align-06-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/text-align-08-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/text-text-06-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Added.
  • platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
8:54 AM Changeset in webkit [140831] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed.

Now searching for *.messages.in in Source/WebKit2/WebProcess/Storage
instead of Source/WebKit2/WebProcess/KeyValueStorage after the
WebKeyValueStorageManager.messages.in was moved there.

  • GNUmakefile.am:
8:31 AM Changeset in webkit [140830] by mkwst@chromium.org
  • 5 edits in trunk

Web Inspector: Cleanup console.* API MessageSource/Levels.
​https://bugs.webkit.org/show_bug.cgi?id=107946

Reviewed by Pavel Feldman.

Source/WebCore:

This patch does some light cleanup on sources and levels of console.*
messages as part of a broader effort to offer better filtering options
in the console. Specifically:

  • console.timeEnd and console.count now come from

ConsoleAPIMessageSource.

  • console.count is now DebugMessageLevel (to match console.timeEnd).
  • console.profile and console.profileEnd now comr from

ConsoleAPIMessageSource, and are DebugMessageLevel.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::count):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):

LayoutTests:

  • inspector/console/console-tests-expected.txt:
8:22 AM Changeset in webkit [140829] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed.

Reincluding the input file for WebKeyValueStorageManager IPC messages
into the extra distribution list after the file was moved.

  • GNUmakefile.am:
8:22 AM Changeset in webkit [140828] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Web Inspector: highlight occurences of word in DefaultTextEditor
​https://bugs.webkit.org/show_bug.cgi?id=105523

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-25
Reviewed by Pavel Feldman.

Source/WebCore:

Highlight occurrences of selected word in DefaultTextEditor by the means of new highlight regex API.

Test: inspector/editor/text-editor-highlight-token.html

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._handleSelectionChange):
(WebInspector.TextEditorMainPanel.TokenHighlighter): Added.
(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype.handleSelectionChange):
(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._regexString):
(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._highlight):
(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._removeHighlight):
(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._isWord):

  • inspector/front-end/textEditor.css:

(.text-editor-token-highlight):

LayoutTests:

Add new test to verify token highlightning functionality.

  • inspector/editor/editor-test.js:

(initialize_EditorTests.InspectorTest.createTestEditor): Added optional TextEditorDelegate argument.

  • inspector/editor/text-editor-highlight-token-expected.txt: Added.
  • inspector/editor/text-editor-highlight-token.html: Added.
7:56 AM Changeset in webkit [140827] by zandobersek@gmail.com
  • 2 edits
    11 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining failing SVG tests after r140728.

  • platform/gtk/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • platform/gtk/svg/custom/glyph-setting-d-attribute-expected.txt: Added.
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt: Added.
  • platform/gtk/svg/hixie/viewbox/002-expected.txt: Added.
  • platform/gtk/svg/hixie/viewbox/003-expected.txt: Added.
  • platform/gtk/svg/text/text-viewbox-rescale-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-zoom-coords-expected.txt:
6:56 AM Changeset in webkit [140826] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fixing expectation entry for selection-clear.html.

Unreviewed. Gardening.

  • platform/chromium/TestExpectations:
6:39 AM Changeset in webkit [140825] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[TexMap] Flickering after transitions on Apple HTML5 demo
​https://bugs.webkit.org/show_bug.cgi?id=102501

Patch by Alexander Paschenko <​alexander.pashenko@lge.com> on 2013-01-25
Reviewed by Noam Rosenthal.

The problem is caused by inconsistent state of TextureMapperLayer's transformation matrix
and opacity data during and after the end of animation.
This patch solves the problem by introducing three additional private flags
to TextureMapperLayer:
m_shouldUpdateCurrentTransformFromGraphicsLayer,
m_shouldUpdateCurrentOpacityFromGraphicsLayer, and
m_shouldUpdateCurrentFiltersFromGraphicsLayer.
The latter has been introduced in order to avoid similar future problems
with m_currentFilters.
On these flags' basis, TextureMapperLayer is able to decide whether to update
its inner state or not.
These flags themselves are set based on GraphicsLayerTextureMapper's changeMask
which indicates what details of the state have been changed since the last sync.

No new tests - this doesn't expose any testable surface.
Eyes-only check has been made to ensure that the problem is gone now.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::setAnimatedTransform):
sets m_shouldUpdateCurrentTransformFromGraphicsLayer to false and
updates m_currentTransform based on the updated state from GraphicsLayerAnimation.
(WebCore):
(WebCore::TextureMapperLayer::setAnimatedOpacity):
sets m_shouldUpdateCurrentOpacityFromGraphicsLayer to false and
updates m_currentOpacity based on the updated state from GraphicsLayerAnimation.
(WebCore::TextureMapperLayer::setAnimatedFilters):
sets m_shouldUpdateCurrentFiltersFromGraphicsLayer to false and
updates m_currentFilters based on the updated state from GraphicsLayerAnimation.
(WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):
sets m_shouldUpdateCurrent* flags based on GLTM's changeMask. Also illegal modification
of m_currentTransform that caused flickering has been removed from this method.
(WebCore::TextureMapperLayer::syncAnimations): updates m_currentTransform and/or
m_currentOpacity and/or m_currentFilters if corresponding flags allow to do so.

  • platform/graphics/texmap/TextureMapperLayer.h:

(WebCore::TextureMapperLayer::TextureMapperLayer): aforementioned flags
get initialized in ctor.
(TextureMapperLayer): aforementioned flags are declared in the class.

6:38 AM Changeset in webkit [140824] by sudarsana.nagineni@linux.intel.com
  • 83 edits in trunk/LayoutTests

Unreviewed EFL rebaseline.

Rebaseline several tests on EFL port after r140728.

  • platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
6:37 AM Changeset in webkit [140823] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Refactor InspectorMemoryAgent: memory data as a map.

​https://bugs.webkit.org/show_bug.cgi?id=107938

Patch by Marja Hölttä <​marja@chromium.org> on 2013-01-25
Reviewed by Yury Semikhatsky.

No new tests (no functional changes, only refactoring).

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::getProcessMemoryDistribution):
(WebCore):

  • inspector/InspectorController.h:

(WebCore):
(InspectorController):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::addPlatformComponentsInfo):
(WebCore):
(WebCore::addMemoryInstrumentationDebugData):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
(WebCore::InspectorMemoryAgent::reportMemoryUsage):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionAsMap):

  • inspector/InspectorMemoryAgent.h:

(InspectorMemoryAgent):

6:30 AM Changeset in webkit [140822] by keishi@webkit.org
  • 3 edits
    2 deletes in trunk/LayoutTests

[Chromium] Fixing expectations for textLayout.svg.

Unreviewed. Gardening.

  • platform/chromium-mac-lion/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac-mountainlion/svg/batik/text/textLayout-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/batik/text/textLayout-expected.png: Removed.
  • platform/chromium-mac/svg/batik/text/textLayout-expected.png:
5:50 AM Changeset in webkit [140821] by commit-queue@webkit.org
  • 15 edits in trunk/Source/WebCore

[Texmap] Refactor code related to debug border and repaint count.
​https://bugs.webkit.org/show_bug.cgi?id=105787

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-25
Reviewed by Noam Rosenthal.

Currently, TextureMapperBackingStore, CoordinatedBackingStore and
GraphicsLayerTextureMapper have duplicated code to draw debug border or
repaint count. This patch refactors that all platform layers draw debug
border and repaint count in the consistent way:
TextureMapper::drawBorder() and TextureMapper::drawRepaintCounter().

There are three big changes:

  1. TextureMapperLayer has the debug visuals like GraphicsLayer.

Both debug border and repaint count are called as the debug visuals.

  1. We use the same color and width to Mac port because we get that info using

GraphicsLayer::updateDebugIndicators().

  1. Draw borders for background color, backing store and contents layer,

while drawing repaint count only for backing store.

No new tests. This functionality is for debugging, so we cannot test using DRT.

  • platform/graphics/cairo/GraphicsContext3DPrivate.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setShowDebugBorder):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::setShowRepaintCounter):
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::updateDebugBorderAndRepaintCountIfNeeded):
(WebCore::GraphicsLayerTextureMapper::setDebugBorder):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):
(WebCore::GraphicsLayerTextureMapper::prepareBackingStore):
(WebCore::GraphicsLayerTextureMapper::setRepaintCount):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::debugBorderColor):
(WebCore::GraphicsLayerTextureMapper::debugBorderWidth):

  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTiledBackingStore::adjustedTransformForRect):
(WebCore):
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper):
(WebCore::TextureMapperTiledBackingStore::drawBorder):

Override TextureMapperPlatformLayer::drawBorder() to draw the border
for each tile.

(WebCore::TextureMapperTiledBackingStore::drawRepaintCounter):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

(WebCore::TextureMapperBackingStore::drawRepaintCounter):
(TextureMapperBackingStore):
(TextureMapperTiledBackingStore):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawRepaintCounter):

  • platform/graphics/texmap/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::TextureMapperImageBuffer::drawBorder):
(WebCore):
(WebCore::TextureMapperImageBuffer::drawRepaintCounter):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(TextureMapperImageBuffer):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):

  • platform/graphics/texmap/TextureMapperLayer.h:

(State):
(WebCore::TextureMapperLayer::State::State):

  • platform/graphics/texmap/TextureMapperPlatformLayer.h:

(WebCore::TextureMapperPlatformLayer::drawBorder):

5:40 AM Changeset in webkit [140820] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for !ENABLE(DRAG_SUPPORT) after r140286.

  • page/AutoscrollController.cpp:

(WebCore::AutoscrollController::autoscrollTimerFired):

5:27 AM Changeset in webkit [140819] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Resolving duplicate expectation entries.

Unreviewed. Gardening.

  • platform/chromium/TestExpectations:
5:10 AM Changeset in webkit [140818] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Move dispatchMouseEvent optional params after x,y
​https://bugs.webkit.org/show_bug.cgi?id=107828

Patch by Ken Kania <​kkania@chromium.org> on 2013-01-25
Reviewed by Pavel Feldman.

No new tests, as this just rearranges the order of arguments to make
JSCompiler happy. The params were rearranged in r140649 to match
dispatchKeyEvent's params.

  • inspector/Inspector.json:
  • inspector/InspectorInputAgent.cpp:

(WebCore::InspectorInputAgent::dispatchMouseEvent):

  • inspector/InspectorInputAgent.h:

(InspectorInputAgent):

5:07 AM Changeset in webkit [140817] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [Styles] Editing a property value containing a trimmed data: URL breaks the style
​https://bugs.webkit.org/show_bug.cgi?id=107936

Reviewed by Yury Semikhatsky.

Source/WebCore:

Restore the original CSS property value before editing.

Test: inspector/styles/edit-value-with-trimmed-url.html

  • inspector/front-end/StylesSidebarPane.js:

LayoutTests:

  • inspector/styles/edit-value-with-trimmed-url-expected.txt: Added.
  • inspector/styles/edit-value-with-trimmed-url.html: Added.
5:05 AM Changeset in webkit [140816] by anilsson@rim.com
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] AC layers appear in the wrong place on RTL page
​https://bugs.webkit.org/show_bug.cgi?id=107930

Reviewed by George Staikos.

The public API of the BlackBerry port always reports a minimum scroll
position of (0, 0), even on RTL pages with left overflow. We
accomplish this by translating the WebCore scroll position by an
amount equal in size to the minimum scroll position, to obtain the API
scroll position reported to the API client.

This means the API client will ask us to render a rect that needs to
be corrected for the minimum scroll position, or we'll render the wrong
part. This is done for BackingStore, but not for WebPageCompositor.

WebPageCompositor was rendering the wrong part of the web page when
the minimum scroll position was non-zero. Fixed by communicating the
minimum scroll position to the WebPageCompositor, and accounting for it
when interpreting the requested content rectangle to render.

PR 280229.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):

  • Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::layoutRect):
(BlackBerry::WebKit::WebPageCompositorPrivate::setLayoutRect):
(BlackBerry::WebKit::WebPageCompositorPrivate::documentRect):
(BlackBerry::WebKit::WebPageCompositorPrivate::setDocumentRect):
(WebPageCompositorPrivate):

  • Api/WebPage_p.h:

(WebPagePrivate):

4:59 AM Changeset in webkit [140815] by keishi@webkit.org
  • 1 edit
    4 adds
    1 delete in trunk/LayoutTests

[Chromium] Rebaselining textLayout.svg.

Unreviewed. Gardening.

  • platform/chromium-mac-mountainlion/svg/batik/text/textLayout-expected.png: Added.
  • platform/chromium-win-xp/svg/batik/text/textLayout-expected.png: Removed.
4:57 AM Changeset in webkit [140814] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [Network] Use DataGrid column alignment instead of custom styling.
​https://bugs.webkit.org/show_bug.cgi?id=107935

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-25
Reviewed by Pavel Feldman.

On Network Panel column alignment is specified both in
column descriptors and in CSS stylesheet.

Only one alignment specifier should last.

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGridNode.prototype.createTD): Extracted common code.
(WebInspector.DataGridNode.prototype.createCell): Use "createTD".

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._createDivInTD): Ditto.

  • inspector/front-end/networkLogView.css: Remove exheberant rules.
  • inspector/front-end/networkPanel.css: Fix whitespaces.
4:36 AM Changeset in webkit [140813] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Add explanation for Console object expansion behaviour
​https://bugs.webkit.org/show_bug.cgi?id=107793

Patch by Sergey Ryazanov <​serya@chromium.org> on 2013-01-25
Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArrayOrObject):

  • inspector/front-end/inspector.css:

(.object-info-state-note):
(.object-info-state-note::before):
(.object-info-state-note:hover):
(.section.expanded .object-info-state-note):
(.section.expanded .properties, .event-bar.expanded .event-properties):
(.pane.expanded .properties, .event-bar .event-properties):

4:32 AM Changeset in webkit [140812] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Missing files in GNUmakefile.list.am for Notifications support
​https://bugs.webkit.org/show_bug.cgi?id=107934

Patch by Claudio Saavedra <Claudio Saavedra> on 2013-01-25
Reviewed by Philippe Normand.

  • GNUmakefile.list.am: Add DOMWindowNotifications.idl and

WorkerContextNotifications.idl to dom_binding_idls and
JSNotificationCustom.{cpp,h} to webcore_sources, since without
this the Notifications will be broken.

3:48 AM Changeset in webkit [140811] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Further GTK build fixing.
Adding Source/WebKit2/WebProcess/Storage to the list of directories
to be searched for header inclusion.

  • GNUmakefile.am:
3:38 AM Changeset in webkit [140810] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix.
Adjusting the build targets after WebKeyValueStorageManager.cpp was moved
to a different directory.

  • GNUmakefile.list.am:
3:14 AM Changeset in webkit [140809] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: implement search for workspace sources
​https://bugs.webkit.org/show_bug.cgi?id=107814

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-25
Reviewed by Pavel Feldman.

Implement generic WebInspector.ContentProvider.performSearchInContent method and use it in both
StaticContentProvider and fileSystemWorkspaceProvider.

No new tests.

  • inspector/front-end/ContentProvider.js:

(WebInspector.ContentProvider.performSearchInContent): Added.

  • inspector/front-end/ContentProviders.js:

(WebInspector.StaticContentProvider.prototype.):
(WebInspector.StaticContentProvider.prototype.searchInContent):

  • inspector/front-end/FileSystemWorkspaceProvider.js:

(WebInspector.FileSystemWorkspaceProvider.prototype.contentCallback):
(WebInspector.FileSystemWorkspaceProvider.prototype.searchInFileContent):

3:03 AM Changeset in webkit [140808] by commit-queue@webkit.org
  • 6 edits in trunk

Unreviewed, rolling out r140774.
​http://trac.webkit.org/changeset/140774
​https://bugs.webkit.org/show_bug.cgi?id=107932

Tests ScrollingCoordinatorChromiumTest.fastScrollingByDefault

and fastScrollingForFixedPosition are failing (Requested by
keishi on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-25

Source/WebKit/chromium:

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::isInputThrottled):
(WebKit::WebWidget::renderingStats):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::~WebViewImpl):
(WebKit::WebViewImpl::renderingStats):
(WebKit):
(WebKit::WebViewImpl::setCompositorSurfaceReady):
(WebKit::WebViewImpl::isInputThrottled):
(WebKit::WebViewImpl::setIsTransparent):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::initializeLayerTreeView):
(WebViewHost::setWebWidget):

2:48 AM Changeset in webkit [140807] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Assert the connectedSubframeCount is consistent and fix over counting
​https://bugs.webkit.org/show_bug.cgi?id=107302

Patch by Elliott Sprehn <Elliott Sprehn> on 2013-01-25
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Add a debug assertion that walks the subtree during frame disconnection
and manually counts the number of connected subframes to assert that the
value from Node::connectedSubframeCount() is the same as if we traversed
through the tree.

In fixing the places where this assertion failed I made document destruction
faster by not walking the entire document looking for frames if the entire
frame tree has been destroyed by way of FrameLoader::detachChildren().
I had inadvertently introduced this improvement in r133933, but then I
regressed it in r140090 when we switched to counting because I didn't
realize we destroy the frame tree separate of frame disconnection on
document unload so all frames could have been destroyed but the counts
left on the ancestors.

I also fixed another overcounting case where the adoption agency algorithm
may call ContainerNode::takeAllChildrenFrom() which in turn calls
ContainerNode::removeAllChildren() and could have left a connected subframe
count on the node even though all the frames had been removed.

This assertion did not uncover any cases of undercounting the number of
frames.

This also fixes a rare edge case where removeChild of an iframe that
was already being unloaded would not unload the frame until the top level
unload was done, and a reparenting of the iframe would not cause it to load.

Test: fast/frames/reparent-in-unload-contentdocument.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeAllChildren):
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::parserAppendChild):

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore):
(WebCore::assertConnectedSubframeCountIsConsistent):

  • dom/ContainerNodeAlgorithms.h:

(WebCore):
(WebCore::ChildFrameDisconnector::disconnect):

  • dom/Node.cpp:

(WebCore::Node::updateAncestorConnectedSubframeCountForRemoval):
(WebCore):
(WebCore::Node::updateAncestorConnectedSubframeCountForInsertion):

  • dom/Node.h:

(Node):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::clearContentFrame):
(WebCore):
(WebCore::HTMLFrameOwnerElement::disconnectContentFrame):

  • html/HTMLFrameOwnerElement.h:

(HTMLFrameOwnerElement):

LayoutTests:

Add a test that removing an iframe in the middle of unload causes the
contentDocument to become immediately inaccessible.

  • fast/frames/reparent-in-unload-contentdocument-expected.txt: Added.
  • fast/frames/reparent-in-unload-contentdocument.html: Added.
2:45 AM Changeset in webkit [140806] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] PagePolicyClientEfl should be based on C WK2 API
​https://bugs.webkit.org/show_bug.cgi?id=107854

Reviewed by Benjamin Poulain.

PagePolicyClientEfl should be based on C WK2 API in order not to
break API layering.

  • UIProcess/efl/PagePolicyClientEfl.cpp:

(WebKit::PagePolicyClientEfl::decidePolicyForResponseCallback):

2:24 AM Changeset in webkit [140805] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: inspector slows down pages with many anonymous scripts.
​https://bugs.webkit.org/show_bug.cgi?id=107928

Reviewed by Alexander Pavlov.

The problem was that workspace code introduced n2 complexity for unique URI calculation.

  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.prototype.uniqueURI):

2:18 AM Changeset in webkit [140804] by commit-queue@webkit.org
  • 4 edits in trunk

[CMake][EFL] Build ThirdParty/leveldb when IndexedDB is enabled
​https://bugs.webkit.org/show_bug.cgi?id=106443

Patch by Jussi Kukkonen <​jussi.kukkonen@intel.com> on 2013-01-25
Reviewed by Laszlo Gombos.

LevelDB is now included in ThirdParty. Use it when IndexDB is
enabled for EFL.

.:

  • Source/cmake/OptionsEfl.cmake:

Set WTF_USE_LEVELDB when IndexedDB is enabled

Source/WebCore:

  • CMakeLists.txt:

Build ThirdParty/leveldb when WTF_USE_LEVELDB is set

2:10 AM Changeset in webkit [140803] by tkent@chromium.org
  • 12 edits
    1 add in trunk

INPUT_MULTIPLE_FIELDS_UI: Inconsistent value of aria-valuetext attribute
​https://bugs.webkit.org/show_bug.cgi?id=107897

Reviewed by Kentaro Hara.

Source/WebCore:

aria-valuetext and aria-valuenow attributes had inconsistent values in
a case of initial empty state and a case that a user clears a field.

  • aria-valuetext attribute should have "blank" message in the initial empty state.
  • aria-valuenow attribute should be removed in the cleared empty state.

Also, we have a bug that aira-valuenow had a symbolic value such as "AM"
"January". It should always have a numeric value according to the
specification.
​http://www.w3.org/TR/wai-aria/states_and_properties#aria-valuenow

No new tests. Updates fast/forms/*-multiple-fields/*-multiple-fields-ax-aria-attributes.html.

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::DateTimeFieldElement):
Set "blank" message to aria-valuetext attribute.
(WebCore::DateTimeFieldElement::updateVisibleValue):
aria-valuenow attribute should be a numeric value. Apply String::number
to the return value of valueForARIAValueNow.
Remove aria-valuenow attribute if nothing is selected.
(WebCore::DateTimeFieldElement::valueForARIAValueNow):
Added.

  • html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement): Declare valueForARIAValueNow.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::valueForARIAValueNow):
Added. Returns 1 + internal selection index.
For example, the function returns 1 for January.

  • html/shadow/DateTimeSymbolicFieldElement.h:

(DateTimeSymbolicFieldElement): Declare valueForARIAValueNow.

LayoutTests:

Fix existing tests to show aria-valuenow attribute values.

  • fast/forms/resources/multiple-fields-ax-aria-attributes.js: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes-expected.txt:
  • fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes.html:

Use multiple-fields-ax-aria-attributes.js.
Add tests for initial empty-value state.

  • fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes-expected.txt:
  • fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes.html:

Use multiple-fields-ax-aria-attributes.js.

  • fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html:

Use multiple-fields-ax-aria-attributes.js.

2:08 AM Changeset in webkit [140802] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][Gtk] build fix after r140752.
​https://bugs.webkit.org/show_bug.cgi?id=107908

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-25
Reviewed by Kentaro Hara.

Build break after r140752.

Move Authentication and Downloads to Shared.

  • DerivedSources.pri:
  • GNUmakefile.am:
  • WebKit2.pri:
1:56 AM Changeset in webkit [140801] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Quick fix for Chromium EWS bots running out of space due to a tmp file leak
​https://bugs.webkit.org/show_bug.cgi?id=107905

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-25
Reviewed by Eric Seidel.

Added line to EWS loop to clear /tmp of known Chromium test leak.
Directories named ".org.chromium.Chromium.XXXXXX" not getting cleaned up.

  • EWSTools/start-queue.sh:
1:35 AM Changeset in webkit [140800] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

Disable Clang's -Wreturn-type-c-linkage for Source/WebCore/bindings/v8/
​https://bugs.webkit.org/show_bug.cgi?id=107845

Reviewed by Adam Barth.

A recent version of Clang started warning about code in
Source/WebCore/bindings/v8/npruntime.cpp.

In this case it is warning about an 'extern "c"' function returning a
non-POD type. But because the function has internal linkage, the
warning doesn't really apply.

This change suppresses the warning in the meantime.

Tested by building with Clang r172454.

  • WebCore.gyp/WebCore.gyp:
1:24 AM Changeset in webkit [140799] by keishi@webkit.org
  • 33 edits
    17 deletes in trunk/LayoutTests

[Chromium] Rebaseline for r140728.

Unreviewed. Gardening.

  • platform/chromium-linux-x86/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/batik/filters/feTile-expected.png: Removed.
  • platform/chromium-linux-x86/svg/carto.net/tabgroup-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/custom/js-late-gradient-creation-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/js-late-pattern-and-object-creation-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/chromium-linux-x86/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/chromium-linux-x86/svg/text/bidi-tspans-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-linux/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-linux/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-mac/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-mac/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-mac/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
  • platform/chromium-win-xp/svg/batik/filters/feTile-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/filters/filterRegions-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/paints/gradientLimit-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/smallFonts-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/textAnchor-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/textOnPath-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/textOnPathSpaces-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/textOnPathSpaces-expected.txt: Removed.
  • platform/chromium-win-xp/svg/batik/text/textProperties-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/textStyles-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/verticalTextOnPath-expected.png: Removed.
  • platform/chromium-win/svg/text/small-fonts-2-expected.png:
1:03 AM Changeset in webkit [140798] by commit-queue@webkit.org
  • 17 edits in trunk/Source

Web Inspector: add checkbox for continuous painting to the inspector's settings
​https://bugs.webkit.org/show_bug.cgi?id=107352

Patch by Eberhard Graether <​egraether@google.com> on 2013-01-25
Reviewed by Pavel Feldman.

This change adds a checkbox to activate continuous painting to the WebInspector's
rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The
setting is visible if InspectorClient::canContinuouslyPaint() returns true.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):
(WebKit::WebLayerTreeView::setContinuousPaintingEnabled):

Source/WebCore:

No new tests.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::canContinuouslyPaint):
(WebCore::InspectorClient::setContinuousPaintingEnabled):
(InspectorClient):

  • inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canContinuouslyPaint):
(WebCore):
(WebCore::InspectorPageAgent::setContinuousPaintingEnabled):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _continuousPaintingChanged):

  • inspector/front-end/inspector.js:

(WebInspector.doLoadedDone):

Source/WebKit/chromium:

  • public/WebView.h:

(WebView):

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::canContinuouslyPaint):
(WebKit):
(WebKit::InspectorClientImpl::setContinuousPaintingEnabled):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setContinuousPaintingEnabled):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
12:55 AM Changeset in webkit [140797] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Update Anne's email address
​https://bugs.webkit.org/show_bug.cgi?id=107866

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/committers.py:
12:46 AM Changeset in webkit [140796] by rniwa@webkit.org
  • 1 edit
    1 add
    4 deletes in trunk/LayoutTests

Mac WK1 rebaselines for r140728.

  • platform/chromium-mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Removed.
  • platform/mac-wk2/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
12:28 AM Changeset in webkit [140795] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking resize-corner-tracking*.html as failing.

Unreviewed. Gardening.

  • platform/chromium/TestExpectations:
12:23 AM Changeset in webkit [140794] by dmazzoni@google.com
  • 4 edits in trunk

REGRESSION (r140658): Multiple accessibility failures on GTK
​https://bugs.webkit.org/show_bug.cgi?id=107832

Reviewed by Chris Fleizach.

Source/WebCore:

In the ATK accessibility implementation, attachWrapper
might create a different object depending on the role of
the WebCore AccessibilityObject, whereas on other platforms
attachWrapper doesn't care. Calling init before attachWrapper
solves the problem.

Re-enables 7 skipped tests.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

LayoutTests:

Re-enable accessibility tests that were skipped when they started
failing.

  • platform/gtk/TestExpectations:
12:21 AM Changeset in webkit [140793] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

WebNavigationData does not distinguish between an empty title and a missing title
​https://bugs.webkit.org/show_bug.cgi?id=107917

Reviewed by Andy Estes.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(nilOrNSString): Added this helper function.
(WebFrameLoaderClient::updateGlobalHistory): Initialize the WebNavigationData with a nil
title, rather than the empty string, if the document does not have a title.

12:12 AM Changeset in webkit [140792] by rniwa@webkit.org
  • 17 edits
    17 adds
    32 deletes in trunk/LayoutTests

(Hopefully) Final Mac rebaselines for r140728.

  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Removed.
  • platform/chromium-mac/svg/batik/paints/patternRegions-expected.txt: Removed.
  • platform/chromium-mac/svg/batik/text/textAnchor3-expected.txt: Removed.
  • platform/chromium-mac/svg/batik/text/textDecoration-expected.txt: Removed.
  • platform/chromium-mac/svg/batik/text/textLayout-expected.txt: Removed.
  • platform/mac-lion/svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Removed.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:
  • platform/mac/svg/batik/paints/gradientLimit-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt: Removed.
  • platform/mac/svg/batik/text/textAnchor3-expected.txt: Removed.
  • platform/mac/svg/batik/text/textDecoration-expected.txt: Removed.
  • platform/mac/svg/batik/text/textLayout-expected.txt: Removed.
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/mac/svg/custom/font-face-cascade-order-expected.txt:
  • platform/mac/svg/custom/marker-default-width-height-expected.txt:
  • platform/mac/svg/custom/text-hit-test-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Added.
  • svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
  • svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Added.
  • svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Added.
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Added.
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Added.
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Added.
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
  • svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Added.
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Added.
  • svg/batik/paints/patternRegions-expected.txt: Added.
  • svg/batik/text/textAnchor3-expected.txt: Added.
  • svg/batik/text/textDecoration-expected.txt: Added.
  • svg/batik/text/textLayout-expected.txt: Added.
Note: See TracTimeline for information about the timeline view.