⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 27, 2013:

11:24 PM Changeset in webkit [140948] by mihnea@adobe.com
  • 8 edits in trunk/Source/WebCore

[CSSRegions] RenderFlowThread should keep a count of auto height regions
​https://bugs.webkit.org/show_bug.cgi?id=105185

Reviewed by Julien Chaffraix.

Keep the count of auto height regions on the flow thread instead of flow thread controller.
This way, we can streamline the operations associated with the two-pass layout only to those
flow threads that have auto height regions associated.
The flow thread controller will keep a count of flow thread with auto height regions instead.
This is a performance refactoring without an expected change in behavior, therefore no new tests were added.

  • rendering/FlowThreadController.cpp: Keep a count of flow threads with auto logical height regions.

(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads): Check the count of auto height regions for all the flow threads.
(WebCore::FlowThreadController::isAutoLogicalHeightRegionsCountConsistent):
Make sure that we call these methods only when we have auto logical height regions.
(WebCore::FlowThreadController::resetRegionsOverrideLogicalContentHeight):
(WebCore::FlowThreadController::markAutoLogicalHeightRegionsForLayout):

  • rendering/FlowThreadController.h:

(WebCore::FlowThreadController::hasFlowThreadsWithAutoLogicalHeightRegions):
(WebCore::FlowThreadController::incrementFlowThreadsWithAutoLogicalHeightRegions):
(WebCore::FlowThreadController::decrementFlowThreadsWithAutoLogicalHeightRegions):

  • rendering/RenderFlowThread.cpp: Keep a count of auto logical height regions.

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::isAutoLogicalHeightRegionsCountConsistent):
(WebCore::RenderFlowThread::resetRegionsOverrideLogicalContentHeight): Iterate the region chain only if the region chain has auto height regions.
(WebCore::RenderFlowThread::initializeRegionsOverrideLogicalContentHeight): Ditto.
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout): Ditto.
(WebCore::RenderFlowThread::incrementAutoLogicalHeightRegions):
(WebCore::RenderFlowThread::decrementAutoLogicalHeightRegions):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp: Add increment/decrementAutoLogicalHeightCount to increase/decrease

the counter inside the flow thread and use them throughout the code as needed.
(WebCore::RenderRegion::incrementAutoLogicalHeightCount):
(WebCore::RenderRegion::decrementAutoLogicalHeightCount):
(WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::detachRegion):

  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::checkTwoPassLayoutForAutoHeightRegions): Use the count of flow threads with auto height regions
instead of the count of auto height regions when deciding whether we should attempt the 2 pass layout for auto height regions.

10:46 PM Changeset in webkit [140947] by akling@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

JSC: FunctionParameters are memory hungry.
<​http://webkit.org/b/108033>
<rdar://problem/13094803>

Reviewed by Sam Weinig.

Instead of inheriting from Vector<Identifier>, make FunctionParameters a simple fixed-size array
with a custom-allocating create() function. Removes one step of indirection and cuts memory usage
roughly in half.

2.73 MB progression on Membuster3.

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::paramString):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • parser/Nodes.cpp:

(JSC::FunctionParameters::create):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionParameters::~FunctionParameters):

  • parser/Nodes.h:

(FunctionParameters):
(JSC::FunctionParameters::size):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::identifiers):

10:38 PM Changeset in webkit [140946] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking two fast/forms tests as slow on debug mac.

Unreviewed. Gardening.

  • platform/chromium/TestExpectations:
10:34 PM Changeset in webkit [140945] by akling@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

JSC: SourceProviderCache is memory hungry.
<​http://webkit.org/b/108029>
<rdar://problem/13094806>

Reviewed by Sam Weinig.

Use fixed-size arrays for SourceProviderCacheItem's lists of captured variables.
Since the lists never change after the object is created, there's no need to keep them in Vectors
and we can instead create the whole cache item in a single allocation.

13.37 MB progression on Membuster3.

  • parser/Parser.cpp:

(JSC::::parseFunctionInfo):

  • parser/Parser.h:

(JSC::Scope::copyCapturedVariablesToVector):
(JSC::Scope::fillParametersForSourceProviderCache):
(JSC::Scope::restoreFromSourceProviderCache):

  • parser/SourceProviderCacheItem.h:

(SourceProviderCacheItemCreationParameters):
(SourceProviderCacheItem):
(JSC::SourceProviderCacheItem::approximateByteSize):
(JSC::SourceProviderCacheItem::usedVariables):
(JSC::SourceProviderCacheItem::writtenVariables):
(JSC::SourceProviderCacheItem::~SourceProviderCacheItem):
(JSC::SourceProviderCacheItem::create):
(JSC::SourceProviderCacheItem::SourceProviderCacheItem):

10:15 PM Changeset in webkit [140944] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

[Shadow DOM] Selecting a node to another node in ShadowDOM fires 'click' event unexpectedly
​https://bugs.webkit.org/show_bug.cgi?id=107233

Reviewed by Dimitri Glazkov.

Source/WebCore:

When selecting from a node to another node in ShadowDOM, 'click' event is unexpectedly fired.

The root cause of the bug is using shadow ancestor nodes for checking the node mouse is pressed on
and the node mouse is released on is the same. This was introduced to fire a click event for a slider
in <input> or etc.

However, we don't need to check shadow ancestor if we're in Author ShadowDOM.

Test: fast/dom/shadow/selecting-anchor.html

  • page/EventHandler.cpp:

(WebCore::mouseIsReleasedOnPressedElement):
(WebCore):
(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

  • fast/dom/shadow/select-in-shadowdom-expected.txt: Added.
  • fast/dom/shadow/select-in-shadowdom.html: Added.
9:24 PM Changeset in webkit [140943] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking storage/indexeddb tests as crashing.

Unreviewed. Gardening.

  • platform/chromium/TestExpectations:
9:15 PM Changeset in webkit [140942] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[ANDROID] Fix a typo
​https://bugs.webkit.org/show_bug.cgi?id=108046

Patch by Laszlo Gombos <Laszlo Gombos> on 2013-01-27
Reviewed by Adam Barth.

HAVE_NMAP -> HAVE_MMAP.

  • wtf/Platform.h:
9:10 PM Changeset in webkit [140941] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking media/track tests as crashing.

Unreviewed. Gardening.

  • platform/chromium/TestExpectations:
9:02 PM Changeset in webkit [140940] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix location of sandbox profiles in built products
​https://bugs.webkit.org/show_bug.cgi?id=108026

Reviewed by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj: Sandbox profiles go into WebKit2 framework resources.
8:22 PM Changeset in webkit [140939] by commit-queue@webkit.org
  • 8 edits in trunk

REGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=108028

Patch by David Farler <​dfarler@apple.com> on 2013-01-27
Reviewed by Dan Bernstein.

.:

  • Makefile: Reverted.
  • Makefile.shared: Reverted.
  • Source/Makefile: Reverted.

Tools:

  • DumpRenderTree/Makefile: Reverted.
  • Makefile: Reverted.
  • Scripts/webkitdirs.pm: Reverted.
8:06 PM Changeset in webkit [140938] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

An [ActiveDOMObject] IDL attribute should be inherited
​https://bugs.webkit.org/show_bug.cgi?id=107877

Reviewed by Adam Barth.

Now we support IDL attribute inheritance. We can remove
[ActiveDOMObject] from subclasses.

No tests. No change in behavior.

  • Modules/indexeddb/IDBOpenDBRequest.idl:
  • Modules/webaudio/OfflineAudioContext.idl:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • workers/SharedWorker.idl:
  • workers/Worker.idl:
7:08 PM Changeset in webkit [140937] by commit-queue@webkit.org
  • 28 edits
    3 copies in trunk

Unreviewed, rolling out r140602.
​http://trac.webkit.org/changeset/140602
​https://bugs.webkit.org/show_bug.cgi?id=108045

Caused 8 indexed tests to crash. (Requested by keishi on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-27

Source/WebCore:

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBCallbacks.h:

(WebCore::IDBCallbacks::onBlocked):

  • Modules/indexeddb/IDBDatabase.cpp:
  • Modules/indexeddb/IDBDatabase.h:

(WebCore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::deleteDatabase):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):

  • Modules/indexeddb/IDBFactory.h:

(WebCore):
(IDBFactory):

  • Modules/indexeddb/IDBFactory.idl:
  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::dispatchEvent):

  • Modules/indexeddb/IDBOpenDBRequest.h:

(IDBOpenDBRequest):

  • Modules/indexeddb/IDBVersionChangeRequest.cpp: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.

(WebCore):
(WebCore::IDBVersionChangeRequest::create):
(WebCore::IDBVersionChangeRequest::IDBVersionChangeRequest):
(WebCore::IDBVersionChangeRequest::~IDBVersionChangeRequest):
(WebCore::IDBVersionChangeRequest::interfaceName):
(WebCore::IDBVersionChangeRequest::onBlocked):

  • Modules/indexeddb/IDBVersionChangeRequest.h: Copied from Source/WebCore/Modules/indexeddb/IDBFactory.idl.

(WebCore):
(IDBVersionChangeRequest):

  • Modules/indexeddb/IDBVersionChangeRequest.idl: Copied from Source/WebCore/Modules/indexeddb/IDBFactory.idl.
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventTarget.h:

(WebCore):

  • dom/EventTargetFactory.in:

Source/WebKit/chromium:

  • public/WebIDBCallbacks.h:
  • src/IDBCallbacksProxy.cpp:

(WebKit::IDBCallbacksProxy::onBlocked):
(WebKit):

  • src/IDBCallbacksProxy.h:

(IDBCallbacksProxy):

  • src/WebIDBCallbacksImpl.cpp:

(WebKit::WebIDBCallbacksImpl::onBlocked):
(WebKit):

  • src/WebIDBCallbacksImpl.h:

(WebIDBCallbacksImpl):

  • tests/IDBAbortOnCorruptTest.cpp:

(WebCore::MockIDBCallbacks::onBlocked):

  • tests/IDBDatabaseBackendTest.cpp:

LayoutTests:

  • storage/indexeddb/intversion-long-queue-expected.txt:
  • storage/indexeddb/intversion-upgrades-expected.txt:
6:47 PM Changeset in webkit [140936] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

Disabled input/textarea doesn't trigger selection change
​https://bugs.webkit.org/show_bug.cgi?id=85244

Reviewed by Ryosuke Niwa.

Source/WebCore:

Only rootEditableNode is there in <input> or <textarea>, 'select' event is fired.
Since readonly or disabled input/textarea element does not have editable element,
'select' event was not fired.

We don't need the check.

Test: fast/forms/input-readonly-select.html

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::notifyRendererOfSelectionChange):

LayoutTests:

  • fast/forms/input-readonly-select-expected.txt: Added.
  • fast/forms/input-readonly-select.html: Added.
6:32 PM Changeset in webkit [140935] by keishi@webkit.org
  • 14 edits in trunk/Source

Unreviewed, rolling out r140850.
​http://trac.webkit.org/changeset/140850
​https://bugs.webkit.org/show_bug.cgi?id=107960

r14602 caused 8 indexed tests to crash.

Source/WebCore:

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):

  • Modules/indexeddb/IDBCursorBackendImpl.h:

(WebCore::IDBCursorBackendImpl::create):
(IDBCursorBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setIndexesReady):
(WebCore::OpenCursorOperation::perform):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::openCursor):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::create):
(WebCore::IDBRequest::IDBRequest):

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):
(WebCore::IDBRequest::taskType):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::scheduleTask):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore::IDBTransactionBackendImpl::scheduleTask):
(IDBTransactionBackendImpl):

  • Modules/indexeddb/IDBTransactionBackendInterface.h:

(IDBTransactionBackendInterface):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:
6:20 PM Changeset in webkit [140934] by commit-queue@webkit.org
  • 31 edits
    3 copies
    3 deletes in trunk

Unreviewed, rolling out r140741.
​http://trac.webkit.org/changeset/140741
​https://bugs.webkit.org/show_bug.cgi?id=108044

Caused 8 indexed tests to fail on Mac and Win. (Requested by
keishi on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-27

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::onVersionChange):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::deleteDatabase):

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::onBlocked):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):

  • Modules/indexeddb/IDBUpgradeNeededEvent.cpp: Copied from Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.cpp.

(WebCore):
(WebCore::IDBUpgradeNeededEvent::create):
(WebCore::IDBUpgradeNeededEvent::IDBUpgradeNeededEvent):
(WebCore::IDBUpgradeNeededEvent::~IDBUpgradeNeededEvent):
(WebCore::IDBUpgradeNeededEvent::oldVersion):
(WebCore::IDBUpgradeNeededEvent::newVersion):
(WebCore::IDBUpgradeNeededEvent::interfaceName):

  • Modules/indexeddb/IDBUpgradeNeededEvent.h: Copied from Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.h.

(WebCore):
(IDBUpgradeNeededEvent):

  • Modules/indexeddb/IDBUpgradeNeededEvent.idl: Copied from Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.idl.
  • Modules/indexeddb/IDBVersionChangeEvent.cpp:

(WebCore::IDBVersionChangeEvent::create):
(WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
(WebCore::IDBVersionChangeEvent::version):
(WebCore):

  • Modules/indexeddb/IDBVersionChangeEvent.h:

(WebCore):
(IDBVersionChangeEvent):

  • Modules/indexeddb/IDBVersionChangeEvent.idl:
  • WebCore.gypi:
  • dom/EventNames.in:

LayoutTests:

  • storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:
  • storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-expected.txt:
  • storage/indexeddb/deletedatabase-blocked-expected.txt:
  • storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
  • storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers-expected.txt:
  • storage/indexeddb/deletedatabase-delayed-by-versionchange-expected.txt:
  • storage/indexeddb/deletedatabase-not-blocked-expected.txt:
  • storage/indexeddb/events-expected.txt: Removed.
  • storage/indexeddb/events.html: Removed.
  • storage/indexeddb/intversion-gated-on-delete-expected.txt:
  • storage/indexeddb/intversion-long-queue-expected.txt:
  • storage/indexeddb/removed-expected.txt:
  • storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js:

(versionChangeCallback):

  • storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js:

(versionChangeCallback):

  • storage/indexeddb/resources/deletedatabase-blocked.js:

(test.request.onsuccess.openOnSuccess.h.onversionchange):

  • storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js:

(prepareDatabase.h.onversionchange):

  • storage/indexeddb/resources/deletedatabase-delayed-by-versionchange.js:

(h1OpenSuccess.h1.onversionchange):
(h1OpenSuccess.request.onsuccess.h2OpenSuccess.h2.onversionchange):

  • storage/indexeddb/resources/deletedatabase-not-blocked.js:

(test.request.onsuccess.openOnSuccess.h.onversionchange):

  • storage/indexeddb/resources/events.js: Removed.
  • storage/indexeddb/resources/intversion-gated-on-delete.js:

(firstSuccessCallback):
(connection1VersionChangeCallback):

  • storage/indexeddb/resources/intversion-long-queue.js:

(connection1VersionChangeCallback):
(deleteDatabaseBlockedCallback):
(deleteDatabaseSuccessCallback):
(connection2VersionChangeEvent):

  • storage/indexeddb/resources/removed.js:

(test):

6:08 PM Changeset in webkit [140933] by keishi@webkit.org
  • 9 edits
    2 moves in trunk/LayoutTests

[Chromium] Rebaselining overflow-size-change* tests.

Unreviewed. Gardening.

  • platform/chromium-mac-lion/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
  • platform/chromium-mac-lion/fast/regions/overflow-size-change-with-stacking-context-expected.png:
  • platform/chromium-mac-snowleopard/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
  • platform/chromium-mac-snowleopard/fast/regions/overflow-size-change-with-stacking-context-expected.png:
  • platform/chromium-mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
  • platform/chromium-mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Renamed from LayoutTests/platform/chromium/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt.
  • platform/chromium-mac/fast/regions/overflow-size-change-with-stacking-context-expected.png:
  • platform/chromium-mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Renamed from LayoutTests/platform/chromium/fast/regions/overflow-size-change-with-stacking-context-expected.txt.
  • platform/chromium-win/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
  • platform/chromium-win/fast/regions/overflow-size-change-with-stacking-context-expected.png:
6:00 PM Changeset in webkit [140932] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Attempt to fix expectation entry.

Unreviewed. Gardening.

  • platform/chromium/TestExpectations:
5:55 PM Changeset in webkit [140931] by falken@chromium.org
  • 3 edits
    4 adds in trunk

Elements must be reattached when inserted/removed from top layer
​https://bugs.webkit.org/show_bug.cgi?id=105489

Relanding r139402 as the apparent perf regression has been explained as not real (bug 106726).

Reviewed by Julien Chaffraix.

Source/WebCore:

Ensure a reattach occurs when an element is inserted/removed from top layer, so its renderer can be inserted correctly:
as a child of RenderView in top layer sibling order if it's in the top layer, and in the usual place otherwise.

We previously relied on style recalc to catch when an element is inserted/removed from the top layer, because it
only happens on dialog.show/close which toggle display: none. But that is incorrect because, for example, close()
followed immediately by show() results in no style change.

Tests: fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html

fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html

  • dom/Element.cpp:

(WebCore::Element::removedFrom): Call Document::removeFromTopLayer to let the element be removed from the top layer vector.
removeFromTopLayer calls Element::setIsInTopLayer(false) itself if needed.
(WebCore::Element::setIsInTopLayer): Ensure a reattach occurs if the element is already attached.

LayoutTests:

  • fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html: Added.
  • fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html: Added.

This tests that a top layer element removed from the document does not reappear in the top layer if readded.
This test actually would pass before this patch, but just by good fortune (see bug).

  • fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html: Added.
  • fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html: Added.

This tests that top layer ordering is correct after removing and readding an element to the top layer.

4:26 PM Changeset in webkit [140930] by commit-queue@webkit.org
  • 15 edits in trunk

Fixing atomicIncrement implementation for Windows by dropping support before XP SP2.
​https://bugs.webkit.org/show_bug.cgi?id=106740

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2013-01-27
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

  • config.h:

Source/WebCore:

  • WebCorePrefix.h:
  • config.h:

Source/WebKit/win:

  • WebKitPrefix.h:

Source/WebKit2:

  • config.h:

Source/WTF:

Adding int64_t type atomicIncrement and atomicDecrement implementations for Windows
into Atomics.h required by WebKit2 after r139514. Separating WinCE implementation
that does not support WebKit2 and has no support for 64 bit interlocked methods.

Increasing WINVER and _WIN32_WINNT to XP SP2, because the 64 bit type interlocked methods
are not supported on previous versions on 32 bit target.

  • config.h:
  • wtf/Atomics.h:

(WTF):
(WTF::atomicIncrement):
(WTF::atomicDecrement):

Tools:

  • DumpRenderTree/config.h:
  • WinLauncher/stdafx.h:
1:53 PM Changeset in webkit [140929] by weinig@apple.com
  • 4 edits
    8 copies
    6 adds in trunk/Source/WebKit2

Add support for launching WebKit2 plugins using XPC
​https://bugs.webkit.org/show_bug.cgi?id=108040

Reviewed by Dan Bernstein.

  • Configurations/PluginService.32.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.xcconfig.
  • Configurations/PluginService.64.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.xcconfig.
  • Configurations/PluginService.Development.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.xcconfig.

Add configurations.

  • PluginProcess/EntryPoint/mac/XPCService: Added.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32: Added.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32/PluginService.32.Main.mm: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64: Added.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64/PluginService.64.Main.mm: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development: Added.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist: Added.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/PluginService.Development.Main.mm: Added.

(main):

  • PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm.

(initializePluginService):
Add entry points.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::serviceName):
Add plugin process service names and move into correct #ifdef.

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::shouldUseXPC):
(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
Opt into xpc using the same rules as the WebProcess.

  • WebKit2.xcodeproj/project.pbxproj:

Add files.

1:04 PM Changeset in webkit [140928] by jochen@chromium.org
  • 4 edits
    2 adds in trunk

[chromium] add missing plumbing for Notification.requestPermission
​https://bugs.webkit.org/show_bug.cgi?id=108012

Reviewed by Adam Barth.

Source/WebKit/chromium:

  • src/NotificationPresenterImpl.cpp:

(WebKit):
(WebKit::VoidCallbackClient::VoidCallbackClient):
(NotificationPermissionCallbackClient):
(WebKit::NotificationPermissionCallbackClient::NotificationPermissionCallbackClient):
(WebKit::NotificationPermissionCallbackClient::permissionRequestComplete):
(WebKit::NotificationPermissionCallbackClient::~NotificationPermissionCallbackClient):
(WebKit::NotificationPresenterImpl::requestPermission):

  • src/NotificationPresenterImpl.h:

(NotificationPresenterImpl):

LayoutTests:

  • fast/notifications/notifications-constructor-request-permission-expected.txt: Added.
  • fast/notifications/notifications-constructor-request-permission.html: Added.
6:12 AM EFLWebKit edited by dchris@gmail.com
(diff)
6:08 AM EFLWebKit edited by dchris@gmail.com
(diff)
5:53 AM EFLWebKit edited by dchris@gmail.com
(diff)
5:30 AM EFLWebKit edited by dchris@gmail.com
Add g++ to dependencies (diff)
2:58 AM Changeset in webkit [140927] by jochen@chromium.org
  • 3 edits
    4 adds in trunk

Check notification permissions in the show() method
​https://bugs.webkit.org/show_bug.cgi?id=108009

Reviewed by Adam Barth.

Source/WebCore:

Tests: fast/notifications/notifications-constructor-with-permission.html

fast/notifications/notifications-constructor-without-permission.html

  • Modules/notifications/Notification.cpp:

(WebCore::Notification::show):
(WebCore::Notification::taskTimerFired):

LayoutTests:

  • fast/notifications/notifications-constructor-with-permission-expected.txt: Added.
  • fast/notifications/notifications-constructor-with-permission.html: Added.
  • fast/notifications/notifications-constructor-without-permission-expected.txt: Added.
  • fast/notifications/notifications-constructor-without-permission.html: Added.

Jan 26, 2013:

11:02 PM Changeset in webkit [140926] by ap@apple.com
  • 6 edits
    2 deletes in trunk/Source/WebKit2

Use shared ChildProcess code to enter plug-in sandbox.

Reviewed by Sam Weinig.

There is one known behavior change from this refactoring: getpwuid_r is used
instead of NSHomeDirectory for home directory, mathcing other client processes.

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::enterSandbox):
  • PluginProcess/PluginProcess.h: PluginProcess prevents ChildProcess attempt to enter the sandbox immediately on launch for now, because we don't have a sandbox profile directory path yet. It now keeps a copy of ChildProcessInitializationParameters, so that ChildProcess::initializeSandbox() could be called later.
  • PluginProcess/mac/PluginProcessMac.mm: (WebKit::PluginProcess::platformInitializeProcess): Store a copy of ChildProcessInitializationParameters for later. (WebKit::loadSandboxProfile): Build a sandbox profile from a common prefix and a plugin-specific part. (WebKit::PluginProcess::platformInitializePluginProcess): We can enter the sandbox now. (WebKit::PluginProcess::enterSandbox): Prepare SandboxInitializationParameters, and call ChildProcess::initializeSandbox().
  • Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::initializeSandbox): Actually handle system directory suffix from parameters.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h: Removed.
  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm: Removed.
10:39 PM Changeset in webkit [140925] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Don't use goma to preprocess bindings idl files
​https://bugs.webkit.org/show_bug.cgi?id=107984

Reviewed by Adam Barth.

On Linux and Mac, use a local gcc or clang to preprocess the bindings idl files.
On my machine, this drops the bindings generation from 137s to 24s when
using goma and -j400.

No new tests, this is a build change.

  • WebCore.gyp/WebCore.gyp: Force the use of the local gcc or clang for preprocessing.
9:32 PM Changeset in webkit [140924] by weinig@apple.com
  • 7 edits
    7 copies
    3 adds in trunk/Source/WebKit2

Add support for running the networking process as an XPCService
​https://bugs.webkit.org/show_bug.cgi?id=108025

Reviewed by Dan Bernstein.

  • Configurations/NetworkService.Development.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.Development.xcconfig.
  • Configurations/NetworkService.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.xcconfig.

Add configurations.

  • NetworkProcess/EntryPoint/mac/XPCService: Added.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService: Added.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development: Added.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/NetworkServiceMain.Development.mm: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm.

(initializeNetworkService):
Add entry points.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::serviceName):
(WebKit::connectToServiceForDevelopment):
(WebKit::createServiceForDevelopment):
(WebKit::createService):
(WebKit::createProcess):
(WebKit::ProcessLauncher::launchProcess):
Rework service creation to work for arbitrary services.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::~NetworkProcessProxy):
(WebKit::NetworkProcessProxy::getLaunchOptions):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Network/mac/NetworkProcessProxyMac.mm:

(WebKit::shouldUseXPC):
(WebKit::NetworkProcessProxy::platformGetLaunchOptions):
Opt into xpc using the same rules as the WebProcess.

  • WebKit2.xcodeproj/project.pbxproj:

Update files.

  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:

(initializeWebContentService):
Fix the comment to refer to the shim correctly.

8:30 PM Changeset in webkit [140923] by commit-queue@webkit.org
  • 31 edits
    3 deletes in trunk

Unreviewed, rolling out r140880.
​http://trac.webkit.org/changeset/140880
​https://bugs.webkit.org/show_bug.cgi?id=108023

Caused mathml/presentation and tests to crash and fail
(Requested by keishi on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-26

Source/WebCore:

  • mathml/MathMLTextElement.cpp:
  • mathml/MathMLTextElement.h:

(MathMLTextElement):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::computePreferredLogicalWidths):
(WebCore):
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
(WebCore::RenderMathMLBlock::preferredLogicalHeightAfterSizing):

  • rendering/mathml/RenderMathMLBlock.h:

(RenderMathMLBlock):
(WebCore::RenderMathMLBlock::isPreferredLogicalHeightDirty):
(WebCore::RenderMathMLBlock::preferredLogicalHeight):
(WebCore::RenderMathMLBlock::setPreferredLogicalHeight):

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::styleDidChange):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
(WebCore):
(WebCore::RenderMathMLOperator::glyphHeightForCharacter):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createGlyph):
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):

  • rendering/mathml/RenderMathMLOperator.h:

(RenderMathMLOperator):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::index):
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):
(WebCore):
(WebCore::RenderMathMLRoot::layout):

  • rendering/mathml/RenderMathMLRoot.h:

(RenderMathMLRoot):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::computePreferredLogicalWidths):
(WebCore::RenderMathMLRow::layout):

  • rendering/mathml/RenderMathMLRow.h:

(RenderMathMLRow):

LayoutTests:

  • mathml/differentiable-manifold.html: Removed.
  • platform/chromium-linux/mathml/differentiable-manifold-expected.png: Removed.
  • platform/chromium-linux/mathml/differentiable-manifold-expected.txt: Removed.
  • platform/chromium-linux/mathml/presentation/fenced-expected.txt:
  • platform/chromium-linux/mathml/presentation/fenced-mi-expected.png:
  • platform/chromium-linux/mathml/presentation/fenced-mi-expected.txt:
  • platform/chromium-linux/mathml/presentation/mo-expected.txt:
  • platform/chromium-linux/mathml/presentation/mo-stretch-expected.png:
  • platform/chromium-linux/mathml/presentation/mo-stretch-expected.txt:
  • platform/chromium-linux/mathml/presentation/over-expected.txt:
  • platform/chromium-linux/mathml/presentation/row-alignment-expected.txt:
  • platform/chromium-linux/mathml/presentation/row-expected.png:
  • platform/chromium-linux/mathml/presentation/row-expected.txt:
  • platform/chromium-linux/mathml/presentation/sub-expected.png:
  • platform/chromium-linux/mathml/presentation/sub-expected.txt:
  • platform/chromium-linux/mathml/presentation/subsup-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
5:36 PM Changeset in webkit [140922] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Simplify environment creation in XPC service re-exec
​https://bugs.webkit.org/show_bug.cgi?id=108017

Reviewed by Dan Bernstein.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h:

(WebKit::XPCServiceEventHandler):
There is no need to copy these strings.

5:01 PM Changeset in webkit [140921] by ap@apple.com
  • 24 edits
    1 delete in trunk/Source

Remove code for handling NetworkProcess authentication challenges in WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=108003

Reviewed by Sam Weinig.

4:53 PM Changeset in webkit [140920] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the development build.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h:

(WebKit::XPCServiceEventHandler):
Use the right stringizer.

4:40 PM Changeset in webkit [140919] by weinig@apple.com
  • 4 edits
    1 move
    2 adds
    1 delete in trunk/Source/WebKit2

Refactor XPCService initialization to make it easier to add more services
​https://bugs.webkit.org/show_bug.cgi?id=108015

Reviewed by Dan Bernstein.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h: Added.

(WebKit::XPCServiceEventHandler):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.h: Added.

(WebKit::XPCServiceEventHandler):
Move bootstrapping to Shared (like we have for the legacy process). For now, we use
a macro to define the actual initialization point function to use, in the future, we
could consider alternatives, such as getting the function name from the bundle.

  • WebKit2.xcodeproj/project.pbxproj:

Update files.

  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm:

Simplify to use the new XPCServiceBootstrapper.

  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm: Copied from Source/WebKit2/WebProcess/mac/WebProcessServiceEntryPoints.mm.

(initializeWebContentService):

  • WebProcess/mac/WebProcessServiceEntryPoints.h: Removed.
  • WebProcess/mac/WebProcessServiceEntryPoints.mm: Removed.

Move the entry point to where it belongs and extract the bootstrapping parts.

4:09 PM Changeset in webkit [140918] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the test for CHANNEL_MESSAGING in idl files
​https://bugs.webkit.org/show_bug.cgi?id=108006

Patch by Laszlo Gombos <Laszlo Gombos> on 2013-01-26
Reviewed by Alexey Proskuryakov.

No new tests, this is a build fix.

  • workers/WorkerContext.idl: Make sure ENABLE_CHANNEL_MESSAGING is

defined before using it to be consitent with other guards inside idl
files.

2:55 PM Changeset in webkit [140917] by abecsi@webkit.org
  • 2 edits in trunk/Source/WTF

Unreviewed fix after r140451 to make GIT-SVN repositories happy.

  • WTF.vcproj/WTF.sln:
2:24 PM Changeset in webkit [140916] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt]Qt build fix
​https://bugs.webkit.org/show_bug.cgi?id=108013

Changes on process initialization classes broke webkit building with Qt5. This
patch fix it.

Patch by Adenilson Cavalcanti <​cavalcantii@gmail.com> on 2013-01-26
Reviewed by Sam Weinig.

  • PluginProcess/qt/PluginProcessMainQt.cpp:
12:15 PM Changeset in webkit [140915] by weinig@apple.com
  • 6 edits in trunk/Source/WebKit2

Hoist command line parsing into ChildProcessMain
​https://bugs.webkit.org/show_bug.cgi?id=108010

Reviewed by Dan Bernstein.

  • NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMain.mm:

(NetworkProcessMain):

  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:

(PluginProcessMain):

  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.h:

(WebKit::ChildProcessMain):

  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMain.mm:

(SharedWorkerProcessMain):

  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:

(WebContentProcessMain):

11:44 AM Changeset in webkit [140914] by weinig@apple.com
  • 6 edits
    10 moves
    18 adds
    6 deletes in trunk/Source/WebKit2

Move LegacyProcess entry points into new EntryPoint directories
​https://bugs.webkit.org/show_bug.cgi?id=108008

Reviewed by Anders Carlsson.

Also refactors to remove the need for the overly general WebKitMain, by putting the
framework lazy loading into a helper function each legacy process can call (in ChildProcessMainBootstrapper.h)

  • Configurations/NetworkProcess.xcconfig:
  • Configurations/PluginProcess.xcconfig:
  • Configurations/SharedWorkerProcess.xcconfig:
  • Configurations/WebProcess.xcconfig:
  • NetworkProcess/EntryPoint: Added.
  • NetworkProcess/EntryPoint/mac: Added.
  • NetworkProcess/EntryPoint/mac/LegacyProcess: Added.
  • NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist: Copied from Source/WebKit2/NetworkProcess/Info.plist.
  • NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMain.mm: Copied from Source/WebKit2/NetworkProcess/mac/NetworkProcessMainMac.mm.

(NetworkProcessMain):

  • NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMainBootstrapper.cpp: Added.

(main):

  • NetworkProcess/Info.plist: Removed.
  • NetworkProcess/NetworkProcessMain.h: Removed.
  • NetworkProcess/mac/NetworkProcessMainMac.mm: Removed.
  • PluginProcess/EntryPoint: Added.
  • PluginProcess/EntryPoint/mac: Added.
  • PluginProcess/EntryPoint/mac/LegacyProcess: Added.
  • PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist: Copied from Source/WebKit2/PluginProcess/Info.plist.
  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm: Copied from Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm.

(PluginProcessMain):

  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMainBootstrapper.cpp: Added.

(main):

  • PluginProcess/Info.plist: Removed.
  • PluginProcess/PluginProcessMain.h: Removed.
  • PluginProcess/mac/PluginProcessMainMac.mm: Removed.
  • Shared/EntryPointUtilities: Added.
  • Shared/EntryPointUtilities/mac: Added.
  • Shared/EntryPointUtilities/mac/LegacyProcess: Added.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.h: Copied from Source/WebKit2/Shared/mac/ChildProcessMain.h.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm: Copied from Source/WebKit2/Shared/mac/ChildProcessMain.mm.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMainBootstrapper.h: Added.

(closeUnusedFileDescriptors):
(getBootstrapMainFunction):

  • Shared/EntryPointUtilities/mac/XPCService: Added.
  • Shared/mac/ChildProcessMain.h: Removed.
  • Shared/mac/ChildProcessMain.mm: Removed.
  • SharedWorkerProcess/EntryPoint: Added.
  • SharedWorkerProcess/EntryPoint/mac: Added.
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess: Added.
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/Info.plist: Copied from Source/WebKit2/SharedWorkerProcess/Info.plist.
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMain.mm: Copied from Source/WebKit2/SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm.

(SharedWorkerProcessMain):

  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMainBootstrapper.cpp: Added.

(main):

  • SharedWorkerProcess/Info.plist: Removed.
  • SharedWorkerProcess/SharedWorkerProcessMain.h: Removed.
  • SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/EntryPoint/mac/LegacyProcess/Info.plist: Copied from Source/WebKit2/WebProcess/Info.plist.
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm: Copied from Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm.

(WebKit::WebContentProcessMainDelegate::WebContentProcessMainDelegate):
(WebKit):
(WebContentProcessMain):

  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMainBootstrapper.cpp: Added.

(main):

  • WebProcess/Info.plist: Removed.
  • WebProcess/WebKitMain.cpp: Removed.
  • WebProcess/WebProcessMain.h: Removed.
  • WebProcess/mac/WebProcessMainMac.mm: Removed.
  • mac/MainMacProcess.cpp: Removed.
11:29 AM Changeset in webkit [140913] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Text Autosizing: simplify and clean-up preOrderTraversal skipping containers
​https://bugs.webkit.org/show_bug.cgi?id=107446

Patch by Tim Volodine <​timvolodine@chromium.org> on 2013-01-26
Reviewed by Julien Chaffraix.

Simplify nextInPreOrderSkippingDescendantsOfContainers implementation
using RenderObject tree traversal methods.

No new tests because functionality is unchanged.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::nextInPreOrderSkippingDescendantsOfContainers):

8:34 AM Changeset in webkit [140912] by commit-queue@webkit.org
  • 8 edits in trunk

.: Allow building with arbitrary SDK and ARCHS with make + Xcode
​https://bugs.webkit.org/show_bug.cgi?id=107863

Patch by David Farler <​dfarler@apple.com> on 2013-01-26
Reviewed by David Kilzer.

  • Makefile:

Removed references to legacy Xcode configurations.

  • Makefile.shared:

Added default ARCHS + SDK settings and parameterized xcodebuild calls.

  • Source/Makefile:

iOS does not build WebKit2.

Tools: Makefiles should work for arbitrary SDKs and architectures on Apple ports
​https://bugs.webkit.org/show_bug.cgi?id=107863

Patch by David Farler <​dfarler@apple.com> on 2013-01-26
Reviewed by David Kilzer.

  • Makefile:

Added temporary filters for projects not yet building on iOS.

  • DumpRenderTree/Makefile:

Building with iOS SDKs -> -target All-iOS

  • Scripts/webkitdirs.pm:

(determineConfiguration):
Added --configuration switch detection.
(determineArchitecture):
Added --architecture and ARCH=(.*) switch detection.
(argumentsForConfiguration):
(determineXcodeSDK):
Look for --device, --simulator, and --sdk switches.
(xcodeSDK):
Added.
(XcodeOptions):
Determine Xcode SDK and generate -arch switches.

8:08 AM Changeset in webkit [140911] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[v8] prepare SerializedScriptValue for transition to Latin-1
​https://bugs.webkit.org/show_bug.cgi?id=107655

Patch by Dan Carney <​dcarney@google.com> on 2013-01-26
Reviewed by Kentaro Hara.

No new tests. Covered by existing tests.

  • bindings/v8/SerializedScriptValue.cpp:
2:01 AM Changeset in webkit [140910] by jschuh@chromium.org
  • 4 edits in trunk/Source

[CHROMIUM] Suppress more c4267 build warnings for Win64 targets
​https://bugs.webkit.org/show_bug.cgi?id=107993

Source/WebCore:

No new tests. No behavior change.

Reviewed by Abhishek Arya.

  • WebCore.gyp/WebCore.gyp:

Source/WTF:

Reviewed by Abhishek Arya.

  • WTF.gyp/WTF.gyp:
1:51 AM Changeset in webkit [140909] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r139078.

  • WebCoreSupport/ChromeClientWinCE.h:

(ChromeClientWinCE):

1:51 AM Changeset in webkit [140908] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for USE(JSC) && !ENABLE(WORKERS) after r136686.

  • bindings/js/DOMRequestState.h:

(WebCore::DOMRequestState::DOMRequestState):

1:36 AM Changeset in webkit [140907] by robert@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION(r120616): Cell's logical height wrongly computed with vertical-align: baseline and rowspan
​https://bugs.webkit.org/show_bug.cgi?id=106571

Reviewed by Julien Chaffraix.

Source/WebCore:

When a cell spans multiple rows, its baseline is set on the first row it spans. r120616 contained a
couple of errors in its attempt to ensure the row height calculated in such cases was correct. When it
calculated the baseline on the first row in the span, it didn't ensure that the row height was increased
if necessary. It also suffered from allowing the baseline descent calculated on a rowspan to affect the
height of the other cells in the first row of the span.

Fix both of these errors in calcRowLogicalHeight() and refactor the calculation of the baseline and baseline
descent so that it is freestanding (rather than depending on the height of the section so far).

Tests: fast/css/vertical-align-baseline-rowspan-010.html

fast/css/vertical-align-baseline-rowspan-011.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

  • fast/css/vertical-align-baseline-rowspan-010-expected.html: Added.
  • fast/css/vertical-align-baseline-rowspan-010.html: Added.
  • fast/css/vertical-align-baseline-rowspan-011-expected.html: Added.
  • fast/css/vertical-align-baseline-rowspan-011.html: Added.
12:13 AM Changeset in webkit [140906] by simonjam@chromium.org
  • 6 edits in trunk/Source

[chromium] Export ResourceRequest's priority through WebURLRequest
​https://bugs.webkit.org/show_bug.cgi?id=107985

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebURLRequest.h:

(WebURLRequest):

Source/WebCore:

No new tests.

  • platform/chromium/support/WebURLRequest.cpp:

(WebKit::WebURLRequest::priority):
(WebKit):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:
Note: See TracTimeline for information about the timeline view.