⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 1, 2013:

11:40 PM Changeset in webkit [141684] by simonjam@chromium.org
  • 10 edits in trunk/Source

Add didChangePriority() to ResourceHandle
​https://bugs.webkit.org/show_bug.cgi?id=107995

Reviewed by Darin Fisher.

Source/Platform:

  • chromium/public/WebURLLoader.h:

(WebKit):
(WebURLLoader):
(WebKit::WebURLLoader::didChangePriority): Added.

Source/WebCore:

For PLT, it's important that preloads remain a lower priority than parser requested resources.
This can lead to a 5% improvement.

The plan is to use this plumbing to expose the desired behavior. This patch simply allows a
resource's priority to change and have it propagate to the network layer. An upcoming patch will
lower the priority of preloads and then increase the priority when the parser officially requests
it.

No new tests. No visible change, because priority doesn't change yet.

  • loader/cache/CachedResource.cpp:

(WebCore):
(WebCore::CachedResource::setLoadPriority):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource): Allow loads to modify priority.

  • loader/cache/CachedResourceRequest.h:

(WebCore::CachedResourceRequest::setPriority): Notify when priority changes.

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::didChangePriority): Added.
(WebCore):

  • platform/network/ResourceHandle.h:

(ResourceHandle):

  • platform/network/chromium/ResourceHandle.cpp:

(WebCore::ResourceHandleInternal::didChangePriority):
(WebCore):
(WebCore::ResourceHandle::didChangePriority):

  • platform/network/chromium/ResourceHandleInternal.h:

(ResourceHandleInternal):

10:26 PM Changeset in webkit [141683] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Building fails in an armv5tel board
​https://bugs.webkit.org/show_bug.cgi?id=108083

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2013-02-01
Reviewed by Martin Robinson.

In some systems in which $architecture is filled-in from "uname -m"
the value may not start with "arm-", but with "armvN", where "N" is
an architecture version number. The regexp in isARM() is modified
so it covers these kind of cases.

  • Scripts/webkitdirs.pm:

(isARM):

10:18 PM Changeset in webkit [141682] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r141648.

  • GNUmakefile.am: Add UIProcess/Storage to the list of paths that

should be searched for *.messages.in files.

7:57 PM Changeset in webkit [141681] by mhahnenberg@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Structure::m_enumerationCache should be moved to StructureRareData
​https://bugs.webkit.org/show_bug.cgi?id=108723

Reviewed by Oliver Hunt.

m_enumerationCache is only used by objects whose properties are iterated over, so not every Structure needs this
field and it can therefore be moved safely to StructureRareData to help with memory savings.

  • runtime/JSPropertyNameIterator.h:

(JSPropertyNameIterator):
(JSC::Register::propertyNameIterator):
(JSC::StructureRareData::enumerationCache): Add to JSPropertyNameIterator.h so that it can see the correct type.
(JSC::StructureRareData::setEnumerationCache): Ditto.

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyWithoutTransition): Use the enumerationCache() getter rather than accessing the field.
(JSC::Structure::removePropertyWithoutTransition): Ditto.
(JSC::Structure::visitChildren): We no longer have to worry about marking the m_enumerationCache field.

  • runtime/Structure.h:

(JSC::Structure::setEnumerationCache): Move the old accessors back since we don't have to have any knowledge of
the JSPropertyNameIterator type.
(JSC::Structure::enumerationCache): Ditto.

  • runtime/StructureRareData.cpp:

(JSC::StructureRareData::visitChildren): Mark the new m_enumerationCache field.

  • runtime/StructureRareData.h: Add new functions/fields.

(StructureRareData):

7:40 PM Changeset in webkit [141680] by commit-queue@webkit.org
  • 6 edits
    1 move
    5 adds
    1 delete in trunk/LayoutTests

Rebaseline tests after bug 9221
​https://bugs.webkit.org/show_bug.cgi?id=108712

Unreviewed rebaseline of test expectations.

Patch by Christian Biesinger <​cbiesinger@chromium.org> on 2013-02-01

  • fast/css/resize-corner-tracking-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/resize-corner-tracking-expected.txt.
  • platform/chromium-mac-lion/fast/css/resize-corner-tracking-expected.png:
  • platform/chromium-mac-lion/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
  • platform/chromium-mac/fast/css/resize-corner-tracking-expected.png:
  • platform/chromium-mac/fast/css/resize-corner-tracking-transformed-iframe-expected.png:
  • platform/chromium-mac/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
  • platform/chromium-win/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/css/resize-corner-tracking-expected.txt: Removed.
6:54 PM Changeset in webkit [141679] by roger_fong@apple.com
  • 6 edits
    1 delete in trunk/Source/WebCore

Unreviewed. Clean up WebCore VS2010 project.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.vcxproj/WebCoreCommon.props:
  • WebCore.vcxproj/WebCoreGenerated.make:
  • WebCore.vcxproj/WebCorePreLink.cmd: Removed.
  • WebCore.vcxproj/build-generated-files.sh:
6:53 PM Changeset in webkit [141678] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Don't use deprecated method -[NSImage dissolveToPoint:fraction:]
<rdar://problem/11723792>
​https://bugs.webkit.org/show_bug.cgi?id=108739

Reviewed by Anders Carlsson.

  • platform/mac/DragImageMac.mm:

(WebCore::dissolveDragImageToFraction):
Remove use of deprecated NSImage methods and simplify a bit.

6:51 PM Changeset in webkit [141677] by roger_fong@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Unreviewed. JavaScriptCore VS2010 project cleanup.

6:48 PM Changeset in webkit [141676] by roger_fong@apple.com
  • 3 edits
    1 delete in trunk/Source/WTF

Unreviewed. WTF VS2010 project cleanup.

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.vcxproj/WTFPreLink.cmd: Removed.
6:36 PM Changeset in webkit [141675] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r180221. Requested by
"Nico Weber" <​thakis@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-01

  • DEPS:
6:35 PM Changeset in webkit [141674] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r141662.
​http://trac.webkit.org/changeset/141662
​https://bugs.webkit.org/show_bug.cgi?id=108738

it's an incorrect change since processPhiStack will
dereference dangling BasicBlock pointers (Requested by pizlo
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-01

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

6:17 PM Changeset in webkit [141673] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix "DOM Exception 8" when deleting lines containing decoration in DTE.
​https://bugs.webkit.org/show_bug.cgi?id=108689

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-02-01
Reviewed by Alexander Pavlov.

Add a check that decoration element is still added to the line before trying to delete it. This
won't be true if the whole line is deleted in contentEditable,
and this is the reason for the exception to be thrown.

No new tests.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):

6:16 PM Changeset in webkit [141672] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Update LayoutTests scripts to skip webgl folder on ports
​https://bugs.webkit.org/show_bug.cgi?id=108705

Patch by Gregg Tavares <​gman@google.com> on 2013-02-01
Reviewed by Dirk Pranke.

I'm working on checking in the WebGL Conformance Tests
as layout tests into LayoutTests/webgl. For ports
that do not have WebGL enabled this changes will
skip tests in the "webgl" folder.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._missing_symbol_to_skipped_tests):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_skipped_directories_for_symbols):

5:35 PM Changeset in webkit [141671] by roger_fong@apple.com
  • 3 edits in trunk/Tools

Unreviewed. Fix for webkitpy tests.

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
5:27 PM Changeset in webkit [141670] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r141669.
​http://trac.webkit.org/changeset/141669
​https://bugs.webkit.org/show_bug.cgi?id=108728

Broke the windows build. (Requested by leviw on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-01

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

5:10 PM Changeset in webkit [141669] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove duplicate code in RenderBoxModelObject::computedCSSPadding*
​https://bugs.webkit.org/show_bug.cgi?id=108707

Reviewed by Levi Weintraub.

The computedCSSPaddingTop/Bottom/... methods in
RenderBoxModelObject all do pretty much exactly the same thing
yet share no code.

Break out shared code into computedCSSPadding method and have
the top/bottom/left/right/... ones call it with the appropriate
length value.

No new tests, no change in functionality.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computedCSSPadding):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
(RenderBoxModelObject):

5:05 PM Changeset in webkit [141668] by mark.lam@apple.com
  • 14 edits in trunk/Source/WebCore

Replace ExceptionCode with DatabaseError in the openDatabase() code path.
​https://bugs.webkit.org/show_bug.cgi?id=108724.

Reviewed by Alexey Proskuryakov.

Also made DatabaseBackend::performOpenAndVerify() a little more
straightforward and less repetitive.

No new tests.

  • Modules/webdatabase/DOMWindowWebDatabase.cpp:

(WebCore::DOMWindowWebDatabase::openDatabase):

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::performOpenAndVerify):

  • Modules/webdatabase/Database.h:

(Database):

  • Modules/webdatabase/DatabaseBackend.cpp:

(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::openSucceeded):
(WebCore::DatabaseBackend::performOpenAndVerify):

  • Modules/webdatabase/DatabaseBackend.h:
  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):

  • Modules/webdatabase/DatabaseManager.h:

(DatabaseManager):

  • Modules/webdatabase/DatabaseSync.cpp:

(WebCore::DatabaseSync::openAndVerifyVersion):

  • Modules/webdatabase/DatabaseSync.h:

(DatabaseSync):

  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):

  • Modules/webdatabase/DatabaseTask.h:

(WebCore::Database::DatabaseOpenTask::create):
(Database::DatabaseOpenTask):

  • Modules/webdatabase/WorkerContextWebDatabase.cpp:

(WebCore::WorkerContextWebDatabase::openDatabase):
(WebCore::WorkerContextWebDatabase::openDatabaseSync):

  • WebCore.gypi:
4:58 PM Changeset in webkit [141667] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Document is never released if an image's src attribute is changed to a url blocked by content-security-policy.
​https://bugs.webkit.org/show_bug.cgi?id=108545

Source/WebCore:

If we just scheduled an error event due to an null newImage, we should not cancel it when newImage and oldImage
is not the same. Otherwise we will ref the sourceElement in updateHasPendingEvent (m_hasPendingErrorEvent is true)
but never deref it since we already cancelled the error event.

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2013-02-01
Reviewed by Alexey Proskuryakov.

Test: fast/images/image-error-event-not-firing.html

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement): don't cancel error event if newImage is null, we want the

error event to fire.

LayoutTests:

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2013-02-01
Reviewed by Alexey Proskuryakov.

Add a test to verify the error event is fired when image's src attribute is changed to a url
but the url blocked by content-security-policy.

  • fast/images/image-error-event-not-firing-expected.txt: Added.
  • fast/images/image-error-event-not-firing.html: Added.
4:51 PM Changeset in webkit [141666] by jer.noble@apple.com
  • 2 edits in trunk/Tools

LLDB: add synthetic provider for WTF::HashTable
​https://bugs.webkit.org/show_bug.cgi?id=108718

Reviewed by Darin Adler.

Add a synthetic provider which will emit the contents of a given
WTF::HashTable. This allows clients using Xcode/lldb to enumerate
the hash contents.

  • lldb/lldb_webkit.py:

(lldb_init_module):
(lldb_init_module.lldb_webkit):
(WTFHashTable_SummaryProvider):
(WTFVectorProvider.has_children):
(WTFHashTableProvider):
(WTFHashTableProvider.init):
(WTFHashTableProvider.num_children):
(WTFHashTableProvider.get_child_index):
(WTFHashTableProvider.get_child_at_index):
(WTFHashTableProvider.tableSize):
(WTFHashTableProvider.keyCount):
(WTFHashTableProvider.update):
(WTFHashTableProvider.has_children):

4:51 PM Changeset in webkit [141665] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r141648

Needs to add StorageManager.messages.in to CMakeLists.txt.

  • CMakeLists.txt:
4:50 PM Changeset in webkit [141664] by fmalita@chromium.org
  • 2 edits
    3 copies
    3 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaseline after ​http://trac.webkit.org/changeset/141634

  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
  • platform/chromium-win/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
4:33 PM Changeset in webkit [141663] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Build fix for CustomProtocolManagerMac after r141658.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-02-01

  • Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::supplementName): I accidentally typed "const" twice twice.

4:26 PM Changeset in webkit [141662] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Eliminate dead blocks sooner in the DFG::ByteCodeParser to make clear that you don't need to hold onto them during Phi construction
​https://bugs.webkit.org/show_bug.cgi?id=108717

Reviewed by Mark Hahnenberg.

I think this makes the code clearer. It doesn't change behavior.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

4:25 PM Changeset in webkit [141661] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

The assertions in updateLayerPositionsAfterScroll were commented out in r141278, so stop
expecting http/tests/inspector/resource-har-pages.html to assert in debug builds.
(see ​https://bugs.webkit.org/show_bug.cgi?id=103432).

  • platform/mac/TestExpectations:
4:19 PM Changeset in webkit [141660] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r180186. Requested by
"Nico Weber" <​thakis@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-01

  • DEPS:
4:14 PM Changeset in webkit [141659] by ojan@chromium.org
  • 5 edits
    3 deletes in trunk/LayoutTests

Make svg-fonts-in-text-controls.html have the same results across platforms
​https://bugs.webkit.org/show_bug.cgi?id=108676

Reviewed by Dirk Pranke.

Mac uses a different default font-size for form controls and Windows
uses different padding for textareas/inputs. Override these so
this test doesn't need platform specific expectations.

  • platform/chromium/TestExpectations:
  • platform/gtk/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
  • platform/qt/svg/custom/svg-fonts-in-text-controls-expected.png: Removed.
  • platform/qt/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
  • svg/custom/script-tests/svg-fonts-in-text-controls.js:
  • svg/custom/svg-fonts-in-text-controls-expected.txt:
  • svg/custom/svg-fonts-in-text-controls.html:

These dummy elements aren't needed anymore. js-test-pre.js inserts them.

4:10 PM Changeset in webkit [141658] by benjamin@webkit.org
  • 42 edits in trunk/Source/WebKit2

[WK2] Use light supplement names instead of static AtomicStrings
​https://bugs.webkit.org/show_bug.cgi?id=108570

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-02-01
Reviewed by Anders Carlsson.

Since all the supplement names are just string literals and are all different,
we can just use their pointer as the key in the supplement hashmaps.

This is lighter and faster than using AtomicString. WebCore already moved to this
in Supplementable.

  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::addSupplement):
(NetworkProcess):

  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::supplementName):

  • Shared/Authentication/AuthenticationManager.h:

(AuthenticationManager):

  • Shared/Network/CustomProtocols/CustomProtocolManager.h:

(CustomProtocolManager):

  • Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::supplementName):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::supplementName):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::supplementName):

  • UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::supplementName):

  • UIProcess/WebCookieManagerProxy.h:

(WebCookieManagerProxy):

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::supplementName):

  • UIProcess/WebDatabaseManagerProxy.h:

(WebDatabaseManagerProxy):

  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::supplementName):

  • UIProcess/WebGeolocationManagerProxy.h:

(WebGeolocationManagerProxy):

  • UIProcess/WebKeyValueStorageManagerProxy.cpp:

(WebKit::WebKeyValueStorageManagerProxy::supplementName):

  • UIProcess/WebKeyValueStorageManagerProxy.h:

(WebKeyValueStorageManagerProxy):

  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::supplementName):

  • UIProcess/WebMediaCacheManagerProxy.h:

(WebMediaCacheManagerProxy):

  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::supplementName):

  • UIProcess/WebResourceCacheManagerProxy.h:

(WebResourceCacheManagerProxy):

  • UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::supplementName):

  • UIProcess/soup/WebSoupRequestManagerProxy.h:

(WebSoupRequestManagerProxy):

  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:

(WebKit::WebApplicationCacheManager::supplementName):

  • WebProcess/ApplicationCache/WebApplicationCacheManager.h:

(WebApplicationCacheManager):

  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::supplementName):

  • WebProcess/Cookies/WebCookieManager.h:

(WebCookieManager):

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::supplementName):

  • WebProcess/Geolocation/WebGeolocationManager.h:

(WebGeolocationManager):

  • WebProcess/MediaCache/WebMediaCacheManager.cpp:

(WebKit::WebMediaCacheManager::supplementName):

  • WebProcess/MediaCache/WebMediaCacheManager.h:

(WebMediaCacheManager):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::supplementName):

  • WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::supplementName):

  • WebProcess/ResourceCache/WebResourceCacheManager.h:

(WebResourceCacheManager):

  • WebProcess/Storage/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::supplementName):

  • WebProcess/Storage/WebKeyValueStorageManager.h:

(WebKeyValueStorageManager):

  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::supplementName):

  • WebProcess/WebCoreSupport/WebDatabaseManager.h:

(WebDatabaseManager):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::addSupplement):
(WebProcess):

3:59 PM Changeset in webkit [141657] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] WebWidget::selectionBounds should return the bounds in document space
​https://bugs.webkit.org/show_bug.cgi?id=108386

Patch by Chris Hopman <​cjhopman@chromium.org> on 2013-02-01
Reviewed by James Robinson.

When in applyPageScaleFactorInCompositor mode, selectionBounds needs
to scale the anchor/focus window points by the pageScaleFactor.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::selectionBounds):
(WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):

3:55 PM Changeset in webkit [141656] by benjamin@webkit.org
  • 14 edits in trunk

Clean the String->AtomicString conversion for AnimationController::pauseAnimationAtTime
​https://bugs.webkit.org/show_bug.cgi?id=108558

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-02-01
Reviewed by Dean Jackson.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

This is a step torward killing the implicit conversion from String to AtomicString.

The animation name are AtomicString. The API is changed all the way to the callers
to take an AtomicString. When needed, we use explicit conversion.

  • WebCore.exp.in:
  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationController::pauseAnimationAtTime):

  • page/animation/AnimationController.h:

(AnimationController):

  • page/animation/AnimationControllerPrivate.h:

(AnimationControllerPrivate):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::pauseAnimationAtTime):
We should not null check the name. Getting a null name from the HashMap would be
an error from the tests, and the HashMap would never return a value anyway.

  • testing/Internals.cpp:

(WebCore::Internals::pauseAnimationAtTimeOnPseudoElement):

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFramePauseAnimationOnElementWithId):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::pauseAnimationOnElementWithId):

  • WebProcess/WebPage/WebFrame.h:

(WebFrame):

3:50 PM Changeset in webkit [141655] by dmazzoni@google.com
  • 9 edits in trunk/Source

AX: memoize expensive computation during blocks where tree doesn't change
​https://bugs.webkit.org/show_bug.cgi?id=106497

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add a cache for computed attributes of AXObjects.
The cache can be enabled at the start of a batch of
read-only operations on the accessibility tree, and
it's cleared automatically when the tree mutates.
Currently accessibilityIsIgnored is cached, since it's
frequently called and relatively expensive to compute.

No new tests.

  • accessibility/AXObjectCache.cpp:

(WebCore):
(WebCore::AXComputedObjectAttributeCache::getIgnored):
(WebCore::AXComputedObjectAttributeCache::setIgnored):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::nodeTextChangeNotification):
(WebCore::AXObjectCache::handleScrollbarUpdate):
(WebCore::AXObjectCache::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):

  • accessibility/AXObjectCache.h:

(AXComputedObjectAttributeCache):
(WebCore::AXComputedObjectAttributeCache::create):
(WebCore::AXComputedObjectAttributeCache::AXComputedObjectAttributeCache):
(WebCore::AXComputedObjectAttributeCache::CachedAXObjectAttributes::CachedAXObjectAttributes):
(CachedAXObjectAttributes):
(WebCore):
(WebCore::AXObjectCache::computedObjectAttributeCache):
(AXObjectCache):
(WebCore::AXComputedObjectAttributeCache::getIgnored):
(WebCore::AXComputedObjectAttributeCache::setIgnored):
(WebCore::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::stopCachingComputedObjectAttributes):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::findMatchingObjects):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

Source/WebKit/chromium:

Expose two methods to enable and disable caching of
computed WebAccessibilityObject attributes, to speed up
batch read-only operations.

  • public/WebAccessibilityObject.h:

(WebAccessibilityObject):

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::startCachingComputedObjectAttributesUntilTreeMutates):
(WebKit):
(WebKit::WebAccessibilityObject::stopCachingComputedObjectAttributes):

3:46 PM Changeset in webkit [141654] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • Modules/webdatabase/DatabaseBackend.cpp: (DoneCreatingDatabaseOnExitCaller): Don't fail because of an unused member variable in cross-plaform code path.
3:30 PM Changeset in webkit [141653] by fsamuel@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Expose WebNode::shadowHost()
​https://bugs.webkit.org/show_bug.cgi?id=108681

Reviewed by Dimitri Glazkov.

BrowserPlugin needs to be able to check the event listeners attached to
<webview> and so we expose shadowHost to permit it to poke at the webview
node.

  • public/WebNode.h:
  • src/WebNode.cpp:

(WebKit::WebNode::shadowHost):
(WebKit):

3:23 PM Changeset in webkit [141652] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Fat scrollbars on Windows in high-DPI mode.
​https://bugs.webkit.org/show_bug.cgi?id=108637

Updates mechanism for retrieving scrollbar metrics on the
Windows port of Chromium. Previously, GetSystemMetrics calls
were used, which fetches prescaled sizes in pixel rather than
logical units, resulting in a double scaling when a device
scale factor is set. With the patch, the size is retrieved
from the theme engine in DIP.

Patch by Kevin Ellis <​kevers@chromium.org> on 2013-02-01
Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/win/WebThemeEngine.h:

(WebThemeEngine):

Source/WebCore:

No new tests.

  • platform/chromium/ScrollbarThemeChromiumWin.cpp:

(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::menuListButtonWidth):

3:10 PM Changeset in webkit [141651] by mhahnenberg@apple.com
  • 18 edits
    3 adds in trunk/Source/JavaScriptCore

Structure should have a StructureRareData field to save space
​https://bugs.webkit.org/show_bug.cgi?id=108659

Reviewed by Oliver Hunt.

Many of the fields in Structure are used in a subset of all total Structures; however, all Structures must
pay the memory cost of those fields, regardless of whether they use them or not. Since we can have potentially
many Structures on a single page (e.g. bing.com creates ~1500 Structures), it would be profitable to
refactor Structure so that not every Structure has to pay the memory costs for these infrequently used fields.

To accomplish this, we can create a new StructureRareData class to house these seldom used fields which we
can allocate on demand whenever a Structure requires it. This StructureRareData can itself be a JSCell, and
can do all the marking of the fields for the Structure. The StructureRareData field will be part of a union
with m_previous to minimize overhead. We'll add a new field to JSTypeInfo to indicate that the Structure has
a StructureRareData field. During transitions, a Structure will clone its previous Structure's StructureRareData
if it has one. There could be some potential for optimizing this process, but the initial implementation will
be dumb since we'd be paying these overhead costs for each Structure anyways.

Initially we'll only put two fields in the StructureRareData to avoid a memory regression. Over time we'll
continue to move fields from Structure to StructureRareData. Optimistically, this could potentially reduce our
Structure memory footprint by up to around 75%. It could also clear the way for removing destructors from
Structures (and into StructureRareData).

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGRepatch.cpp: Includes for linking purposes.
  • jit/JITStubs.cpp:
  • jsc.cpp:
  • llint/LLIntSlowPaths.cpp:
  • runtime/JSCellInlines.h: Added ifdef guards.
  • runtime/JSGlobalData.cpp: New Structure for StructureRareData class.

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSGlobalObject.h:
  • runtime/JSTypeInfo.h: New flag to indicate whether or not a Structure has a StructureRareData field.

(JSC::TypeInfo::flags):
(JSC::TypeInfo::structureHasRareData):

  • runtime/ObjectPrototype.cpp:
  • runtime/Structure.cpp: We use a combined WriteBarrier<JSCell> field m_previousOrRareData to avoid compiler issues.

(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::pin):
(JSC::Structure::allocateRareData): Handles allocating a brand new StructureRareData field.
(JSC::Structure::cloneRareDataFrom): Handles cloning a StructureRareData field from another. Used during Structure
transitions.
(JSC::Structure::visitChildren): We no longer have to worry about marking m_objectToStringValue.

  • runtime/Structure.h:

(JSC::Structure::previousID): Checks the structureHasRareData flag to see where it should get the previous Structure.
(JSC::Structure::objectToStringValue): Reads the value from the StructureRareData. If it doesn't exist, returns 0.
(JSC::Structure::setObjectToStringValue): Ensures that we have a StructureRareData field, then forwards the function
call to it.
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::setPreviousID): Checks for StructureRareData and forwards if necessary.
(Structure):
(JSC::Structure::clearPreviousID): Ditto.
(JSC::Structure::create):

  • runtime/StructureRareData.cpp: Added. All of the basic functionality of a JSCell with the fields that we've moved

from Structure and the functions required to access/modify those fields as Structure would have done.
(JSC):
(JSC::StructureRareData::createStructure):
(JSC::StructureRareData::create):
(JSC::StructureRareData::clone):
(JSC::StructureRareData::StructureRareData):
(JSC::StructureRareData::visitChildren):

  • runtime/StructureRareData.h: Added.

(JSC):
(StructureRareData):

  • runtime/StructureRareDataInlines.h: Added.

(JSC):
(JSC::StructureRareData::previousID):
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::clearPreviousID):
(JSC::Structure::previous): Handles the ugly casting to get the value of the right type of m_previousOrRareData.
(JSC::Structure::rareData): Ditto.
(JSC::StructureRareData::objectToStringValue):
(JSC::StructureRareData::setObjectToStringValue):

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGRepatch.cpp:
  • jit/JITStubs.cpp:
  • jsc.cpp:
  • llint/LLIntSlowPaths.cpp:
  • runtime/JSCellInlines.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSGlobalObject.h:
  • runtime/JSTypeInfo.h:

(JSC):
(JSC::TypeInfo::flags):
(JSC::TypeInfo::structureHasRareData):

  • runtime/ObjectPrototype.cpp:
  • runtime/Structure.cpp:

(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::pin):
(JSC::Structure::allocateRareData):
(JSC):
(JSC::Structure::cloneRareDataFrom):
(JSC::Structure::visitChildren):

  • runtime/Structure.h:

(JSC::Structure::previousID):
(JSC::Structure::objectToStringValue):
(JSC::Structure::setObjectToStringValue):
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::setPreviousID):
(Structure):
(JSC::Structure::clearPreviousID):
(JSC::Structure::previous):
(JSC::Structure::rareData):
(JSC::Structure::create):

  • runtime/StructureRareData.cpp: Added.

(JSC):
(JSC::StructureRareData::createStructure):
(JSC::StructureRareData::create):
(JSC::StructureRareData::clone):
(JSC::StructureRareData::StructureRareData):
(JSC::StructureRareData::visitChildren):

  • runtime/StructureRareData.h: Added.

(JSC):
(StructureRareData):

  • runtime/StructureRareDataInlines.h: Added.

(JSC):
(JSC::StructureRareData::previousID):
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::clearPreviousID):
(JSC::StructureRareData::objectToStringValue):
(JSC::StructureRareData::setObjectToStringValue):

3:03 PM Changeset in webkit [141650] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebKit/chromium: [Chromium] Ignore punctuation in spellcheck
​https://bugs.webkit.org/show_bug.cgi?id=108511

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-02-01
Reviewed by Tony Chang.

  • src/ContextMenuClientImpl.cpp:

(WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
(WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.

LayoutTests: [Chromium] Expect spellcheck to ignore punctuation
​https://bugs.webkit.org/show_bug.cgi?id=108511

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-02-01
Reviewed by Tony Chang.

  • platform/chromium/TestExpectations: Expect spellcheck to ignore punctuation.
3:03 PM Changeset in webkit [141649] by mark.lam@apple.com
  • 13 edits in trunk/Source/WebCore

Clean up calls to DatabaseTracker::add/removeOpenDatabase().
​https://bugs.webkit.org/show_bug.cgi?id=108431

Reviewed by Geoffrey Garen.

Also adapted the chromium port to work with this new code.
Chromium parts reviewed by Michael Nordman and David Levin.

This is part of the webdatabase refactoring effort.

No new tests.

  • Modules/webdatabase/AbstractDatabaseServer.h:

(AbstractDatabaseServer):

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::close):

  • Modules/webdatabase/DatabaseBackend.cpp:

(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::closeDatabase):
(DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(WebCore::DatabaseBackend::performOpenAndVerify):

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):

  • Modules/webdatabase/DatabaseManager.h:

(DatabaseManager):

  • Modules/webdatabase/DatabaseServer.cpp:
  • Modules/webdatabase/DatabaseServer.h:
  • Modules/webdatabase/DatabaseSync.cpp:

(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::openAndVerifyVersion):
(WebCore::DatabaseSync::closeImmediately):

  • Modules/webdatabase/DatabaseSync.h:

(DatabaseSync):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):

  • Modules/webdatabase/DatabaseTracker.h:

(DatabaseTracker):

  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::prepareToOpenDatabase):
(WebCore::DatabaseTracker::failedToOpenDatabase):

2:56 PM Changeset in webkit [141648] by andersca@apple.com
  • 7 edits
    1 add in trunk/Source/WebKit2

More work on UI side storage
​https://bugs.webkit.org/show_bug.cgi?id=108700

Reviewed by Sam Weinig.

  • DerivedSources.make:

Add StorageManager.messages.in.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add new overload.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):
Call the right function.

(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):
Add stubs.

  • UIProcess/Storage/StorageManager.messages.in: Added.

Add new messages files.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::~StorageAreaProxy):
Add another FIXME.

(WebKit::StorageAreaProxy::canAccessStorage):
(WebKit::StorageAreaProxy::incrementAccessCount):
(WebKit::StorageAreaProxy::decrementAccessCount):
Implement these.

2:55 PM Changeset in webkit [141647] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: remove extra padding around overlay highlight.
​https://bugs.webkit.org/show_bug.cgi?id=108679

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-02-01
Reviewed by Alexander Pavlov.

Source/WebCore:

No new tests: no change in behaviour.

Remove extraWidth from overlay highlight spans.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):

LayoutTests:

Update layout test expectations to correspond to updated overlay highlight style.

  • inspector/editor/text-editor-highlight-api-expected.txt:
  • inspector/editor/text-editor-highlight-token-expected.txt:
2:46 PM Changeset in webkit [141646] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

Allow prettify.rb to be run from any directory, and don't hard-code the system ruby path
​https://bugs.webkit.org/show_bug.cgi?id=108569

Patch by Nathan de Vries <​ndevries@apple.com> on 2013-02-01
Reviewed by Joseph Pecoraro.

  • PrettyPatch/prettify.rb:
2:38 PM Changeset in webkit [141645] by pdr@google.com
  • 8 edits
    3 adds in trunk

Prevent skipped repaints for children of inner SVG elements
​https://bugs.webkit.org/show_bug.cgi?id=108429

Reviewed by Eric Seidel.

Source/WebCore:

This patch fixes a bug caused by r108699 and r133786 where we would not repaint children
of inner SVG elements because "m_didTransformToRootUpdate" was never reset on viewport
containers. The stale m_didTransformToRootUpdate variable caused us to skip child repaints.

I verified that the Robohornet SVG benchmark performance gains in r133786 are not regressed
with this patch.

Test: svg/repaint/svgsvgelement-repaint-children.html

  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::calcViewport):

This can be removed because setNeedsTransformUpdate() will set m_needsTransformUpdate.

(WebCore::RenderSVGViewportContainer::calculateLocalTransform):

This change is straightforward and is similar to the equivalent assignment in
RenderSVGTransformableContainer::calculateLocalTransform().

LayoutTests:

Need to update expectations for a single file (just a 1px difference).

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
  • svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
  • svg/repaint/svgsvgelement-repaint-children.html: Added.
2:24 PM Changeset in webkit [141644] by pdr@google.com
  • 4 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening of two svg/zoom/page tests.

This change rebaselines two tests for WK108108.

Unreviewed update of test expectations.

  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium/TestExpectations:
2:10 PM Changeset in webkit [141643] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Fix webkitpy tests since a build_style is not specified in some cases.

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

2:00 PM Changeset in webkit [141642] by fmalita@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Skip a test added in r14618 that uses setAutomaticLinkDetectionEnabled.

  • platform/chromium/TestExpectations:
2:00 PM Changeset in webkit [141641] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

offlineasm BaseIndex handling is broken on ARM due to MIPS changes
​https://bugs.webkit.org/show_bug.cgi?id=108261

Patch by Balazs Kilvady <​kilvadyb@homejinni.com> on 2013-02-01
Reviewed by Filip Pizlo.

offlineasm BaseIndex handling fix on MIPS.

  • offlineasm/mips.rb:
  • offlineasm/risc.rb:
1:56 PM Changeset in webkit [141640] by caio.oliveira@openbossa.org
  • 5 edits in trunk/Source/WebKit2

[Gtk] [WK2] Fix build after r141619
​https://bugs.webkit.org/show_bug.cgi?id=108687

Reviewed by Benjamin Poulain.

Take a reference instead of a pointer for decoding functions.

  • Platform/gtk/SharedMemoryGtk.cpp:

(WebKit::SharedMemory::Handle::decode):

  • Shared/gtk/ArgumentCodersGtk.cpp:

(CoreIPC::decodeImage):
(CoreIPC::decodeDataObject):
(CoreIPC::::decode):
(CoreIPC::decodeGKeyFile):
(CoreIPC::decode):

  • Shared/gtk/ArgumentCodersGtk.h:
  • Shared/gtk/LayerTreeContextGtk.cpp:

(WebKit::LayerTreeContext::decode):

1:40 PM Changeset in webkit [141639] by caio.oliveira@openbossa.org
  • 10 edits in trunk/Source/WebKit2

[EFL] [WK2] Fix build after r141619
​https://bugs.webkit.org/show_bug.cgi?id=108683

Reviewed by Benjamin Poulain.

Take a reference instead of a pointer for decoding functions.

  • Shared/WebBatteryStatus.cpp:

(WebKit::WebBatteryStatus::Data::decode):

  • Shared/WebBatteryStatus.h:

(Data):

  • Shared/WebNetworkInfo.cpp:

(WebKit::WebNetworkInfo::Data::decode):

  • Shared/WebNetworkInfo.h:

(Data):

  • Shared/cairo/LayerTreeContextCairo.cpp:

(WebKit::LayerTreeContext::decode):

  • Shared/efl/LayerTreeContextEfl.cpp:

(WebKit::LayerTreeContext::decode):

  • Shared/soup/PlatformCertificateInfo.cpp:

(WebKit::PlatformCertificateInfo::decode):

  • Shared/soup/PlatformCertificateInfo.h:

(PlatformCertificateInfo):

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::decodePlatformData):

1:34 PM Changeset in webkit [141638] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Mac] Layout test fast/parser/parser-yield-timing.html is flaky on debug bots
​https://bugs.webkit.org/show_bug.cgi?id=108677

Patch by David Farler <​dfarler@apple.com> on 2013-02-01
Reviewed by Tim Horton.

  • platform/mac/TestExpectations:

Mark fast/parser/parser-yield-timing.html as [ Pass Failure ]

1:31 PM Changeset in webkit [141637] by pdr@google.com
  • 45 edits
    1 add in trunk

Change hasAlpha to isKnownToBeOpaque and correct the return value for SVG images.
​https://bugs.webkit.org/show_bug.cgi?id=106966

Reviewed by Stephen White.

Source/WebCore:

Previously, Image::currentFrameHasAlpha's default implementation returned false so SVG
images always returned false for currentFrameHasAlpha. Additionally, currentFrameHasAlpha
was treated as returning whether the frame had alpha when it would actually conservatively
return true.

This patch renames hasAlpha and currentFrameHasAlpha to isKnownToBeOpaque and
currentFrameIsKnownToBeOpaque, respectively. This rename better describes the actual
functionality. This patch also makes Image::isKnownToBeOpaque a pure virtual function and
correctly implements it for SVG images.

All users of isKnownToBeOpaque access SVG images using CachedImage::imageForRenderer which
currently returns a cached bitmap image. Therefore, this patch will not affect existing
functionality. A regression test has been added that will catch if this changes in the
future (e.g., WK106159 which proposes not returning cached bitmaps). The now unnecessary
isBitmapImage() calls have been removed in this patch.

image-box-shadow.html has been modified to test SVG images.

  • css/CSSCrossfadeValue.cpp:

(WebCore::subimageKnownToBeOpaque):
(WebCore::CSSCrossfadeValue::knownToBeOpaque):

Mostly straightforward rename but note the logic has been slightly altered: AND -> OR.

  • css/CSSCrossfadeValue.h:

(CSSCrossfadeValue):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::knownToBeOpaque):

  • css/CSSGradientValue.h:

(CSSGradientValue):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::knownToBeOpaque):

  • css/CSSImageGeneratorValue.h:

(CSSImageGeneratorValue):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::knownToBeOpaque):

  • css/CSSImageValue.h:

(CSSImageValue):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::currentFrameKnownToBeOpaque):

  • loader/cache/CachedImage.h:

(CachedImage):

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::currentFrameKnownToBeOpaque):

  • platform/graphics/BitmapImage.h:

(BitmapImage):

  • platform/graphics/GeneratedImage.h:

(GeneratedImage):

  • platform/graphics/Image.h:

Note: now a pure virtual function!

(Image):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::updateTextureContentsIfNeeded):

Removed unnecessary isBitmapImage() checks.

  • platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

Removed unnecessary isBitmapImage() checks.

  • platform/graphics/cg/PDFDocumentImage.h:

(PDFDocumentImage):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

Removed unnecessary isBitmapImage() checks.

(WebCore::GraphicsLayerChromium::setContentsToImage):

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::currentFrameKnownToBeOpaque):

  • platform/graphics/qt/StillImageQt.h:

(StillImage):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.cpp:

(WebCore::BitmapImageSingleFrameSkia::currentFrameKnownToBeOpaque):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(BitmapImageSingleFrameSkia):

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContents):

  • platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:

(WebCore::CoordinatedImageBacking::update):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::backgroundIsObscured):

Removed unnecessary isBitmapImage() checks and slightly reworked the logic.

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::hasOpaqueImage):

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::knownToBeOpaque):

  • rendering/style/StyleCachedImage.h:

(StyleCachedImage):

  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::knownToBeOpaque):

  • rendering/style/StyleCachedImageSet.h:

(StyleCachedImageSet):

  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::knownToBeOpaque):

  • rendering/style/StyleGeneratedImage.h:

(StyleGeneratedImage):

  • rendering/style/StyleImage.h:

(StyleImage):

  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::knownToBeOpaque):

  • svg/graphics/SVGImage.h:

(SVGImage):

Source/WebKit/chromium:

  • tests/DragImageTest.cpp:

(WebCore::TestImage::currentFrameKnownToBeOpaque):
(TestImage):

  • tests/ImageLayerChromiumTest.cpp:

(WebCore::TestImage::currentFrameKnownToBeOpaque):

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

An SVG image has been added to this test to check for regressions.

  • fast/box-shadow/image-box-shadow-expected.html:
  • fast/box-shadow/image-box-shadow.html:

Add an SVG image and correct a small mistake in the test that used values of 256
instead of 255.

  • fast/box-shadow/resources/green.svg: Added.
1:26 PM Changeset in webkit [141636] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK TestExpectations update.

  • platform/gtk/TestExpectations: Flag some new media tests

crashing until a fix is figured out.

1:18 PM Changeset in webkit [141635] by beidson@apple.com
  • 8 edits in trunk/Source

Clean up WebArchive loading with the NetworkProcess
<rdar://problem/12695840> and ​https://bugs.webkit.org/show_bug.cgi?id=108673

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests (No change in WebCore behavior).

Remove a now unneeded function and add a needed export.

  • WebCore.exp.in:
  • loader/ResourceLoadScheduler.cpp:
  • loader/ResourceLoadScheduler.h:

Source/WebKit2:

  • NetworkProcess/HostRecord.cpp:

(WebKit::HostRecord::servePendingRequestsForQueue): Add new logging.
(WebKit::HostRecord::servePendingRequests): Tweak existing logging.

  • NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::servePendingRequests): Tweak existing logging.

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad): Handle archive resource scheduling better,

and add new logging to better explore archive loading behavior in the future.

1:16 PM Changeset in webkit [141634] by alokp@chromium.org
  • 405 edits in trunk

Print GraphicsLayer::m_contentsOpaque if non-default (true)
​https://bugs.webkit.org/show_bug.cgi?id=108354

Reviewed by Simon Fraser.

Source/WebCore:

No new tests. This change facilitates testing of GraphicsLayer opaqueness.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::dumpProperties):

LayoutTests:

  • compositing/absolute-inside-out-of-view-fixed-expected.txt:
  • compositing/backing/no-backing-for-clip-expected.txt:
  • compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/bounds-in-flipped-writing-mode-expected.txt:
  • compositing/clip-child-by-non-stacking-ancestor-expected.txt:
  • compositing/columns/composited-in-paginated-expected.txt:
  • compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
  • compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
  • compositing/geometry/ancestor-overflow-change-expected.txt:
  • compositing/geometry/bounds-clipped-composited-child-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-expected.txt:
  • compositing/geometry/clip-expected.txt:
  • compositing/geometry/clip-inside-expected.txt:
  • compositing/geometry/composited-in-columns-expected.txt:
  • compositing/geometry/fixed-position-composited-switch-expected.txt:
  • compositing/geometry/flipped-writing-mode-expected.txt:
  • compositing/geometry/foreground-layer-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
  • compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/become-composited-nested-iframes-expected.txt:
  • compositing/iframes/become-overlapped-iframe-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/iframe-size-from-zero-expected.txt:
  • compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • compositing/iframes/overlapped-nested-iframes-expected.txt:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/images/clip-on-directly-composited-image-expected.txt:
  • compositing/layer-creation/animation-overlap-with-children-expected.txt:
  • compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt:
  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/layer-creation/overlap-animation-clipping-expected.txt:
  • compositing/layer-creation/overlap-animation-container-expected.txt:
  • compositing/layer-creation/overlap-animation-expected.txt:
  • compositing/layer-creation/overlap-child-layer-expected.txt:
  • compositing/layer-creation/overlap-clipping-expected.txt:
  • compositing/layer-creation/overlap-transformed-3d-expected.txt:
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
  • compositing/layer-creation/overlap-transforms-expected.txt:
  • compositing/layer-creation/rotate3d-overlap-expected.txt:
  • compositing/layer-creation/scroll-partial-update-expected.txt:
  • compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
  • compositing/layer-creation/translatez-overlap-expected.txt:
  • compositing/masks/mask-layer-size-expected.txt:
  • compositing/overflow-trumps-transform-style-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
  • compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
  • compositing/overflow/content-gains-scrollbars-expected.txt:
  • compositing/overflow/content-loses-scrollbars-expected.txt:
  • compositing/overflow/overflow-auto-with-touch-expected.txt:
  • compositing/overflow/overflow-auto-with-touch-toggle-expected.txt:
  • compositing/overflow/overflow-overlay-with-touch-expected.txt:
  • compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • compositing/overflow/resize-painting-expected.txt:
  • compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
  • compositing/overflow/scrolling-without-painting-expected.txt:
  • compositing/overflow/textarea-scroll-touch-expected.txt:
  • compositing/overflow/updating-scrolling-content-expected.txt:
  • compositing/plugins/no-backing-store-expected.txt:
  • compositing/plugins/small-to-large-composited-plugin-expected.txt:
  • compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • compositing/repaint/resize-repaint-expected.txt:
  • compositing/rtl/rtl-absolute-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-fixed-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-relative-expected.txt:
  • compositing/rtl/rtl-relative-expected.txt:
  • compositing/tiled-layers-hidpi-expected.txt:
  • compositing/tiling/backface-preserve-3d-tiled-expected.txt:
  • compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • compositing/tiling/huge-layer-expected.txt:
  • compositing/tiling/huge-layer-img-expected.txt:
  • compositing/tiling/huge-layer-resize-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • compositing/tiling/rotated-tiled-clamped-expected.txt:
  • compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
  • compositing/tiling/tile-cache-zoomed-expected.txt:
  • compositing/tiling/tiled-layer-resize-expected.txt:
  • compositing/visibility/layer-visible-content-expected.txt:
  • compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/iframe-no-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • css3/compositing/should-have-compositing-layer-expected.txt:
  • css3/filters/filtered-compositing-descendant-expected.txt:
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt:
  • platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/chromium-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium-mac/css3/filters/composited-during-animation-layertree-expected.txt:
  • platform/chromium-mac/css3/filters/composited-during-transition-layertree-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • platform/chromium-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
  • platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt:
  • platform/chromium-win/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-resize-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/chromium-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium-win/css3/filters/composited-during-animation-layertree-expected.txt:
  • platform/chromium-win/css3/filters/composited-during-transition-layertree-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/chromium/compositing/canvas/accelerated-canvas-compositing-expected.txt:
  • platform/chromium/compositing/columns/composited-in-paginated-expected.txt:
  • platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
  • platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
  • platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt:
  • platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer-expected.txt:
  • platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer-expected.txt:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing-expected.txt:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer-expected.txt:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing-expected.txt:
  • platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt:
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium/compositing/geometry/clip-expected.txt:
  • platform/chromium/compositing/geometry/clip-inside-expected.txt:
  • platform/chromium/compositing/geometry/composited-in-columns-expected.txt:
  • platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt:
  • platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt:
  • platform/chromium/compositing/geometry/foreground-layer-expected.txt:
  • platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt:
  • platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
  • platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/chromium/compositing/iframes/iframe-resize-expected.txt:
  • platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
  • platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt:
  • platform/chromium/compositing/iframes/resizer-expected.txt:
  • platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-animation-container-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-animation-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
  • platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt:
  • platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt:
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
  • platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt:
  • platform/chromium/compositing/overflow-trumps-transform-style-expected.txt:
  • platform/chromium/compositing/overflow/clip-descendents-expected.txt:
  • platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt:
  • platform/chromium/compositing/overflow/content-loses-scrollbars-expected.txt:
  • platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/chromium/compositing/overflow/resize-painting-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • platform/chromium/compositing/rtl/rtl-fixed-expected.txt:
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium/compositing/rtl/rtl-relative-expected.txt:
  • platform/chromium/compositing/tiling/huge-layer-img-expected.txt:
  • platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt:
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/content-gains-scrollbars-expected.txt:
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt:
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/resize-painting-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/content-gains-scrollbars-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/resize-painting-expected.txt:
  • platform/efl/compositing/geometry/foreground-layer-expected.txt:
  • platform/efl/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
  • platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
  • platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
  • platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
  • platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
  • platform/mac/TestExpectations:
  • platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt:
  • platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
  • platform/mac/compositing/iframes/resizer-expected.txt:
  • platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
  • platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt:
  • platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-img-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-resize-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
  • platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
  • platform/mac/compositing/tiling/tiled-layer-resize-expected.txt:
  • platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/mac/css3/filters/composited-during-animation-layertree-expected.txt:
  • platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
  • platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/leave-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt:
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/qt-5.0-wk2/css3/filters/composited-during-animation-layertree-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt:
  • platform/qt/compositing/overflow/clip-descendents-expected.txt:
  • platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
  • platform/qt/css3/compositing/should-have-compositing-layer-expected.txt:
  • platform/qt/css3/filters/composited-during-transition-layertree-expected.txt:
  • platform/win/compositing/iframes/composited-iframe-expected.txt:
  • platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt:
  • platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
1:13 PM Changeset in webkit [141633] by tonyg@chromium.org
  • 3 edits in trunk/Source/WebCore

Continue making XSSAuditor thread safe: Remove dependency on parser's Document URL
​https://bugs.webkit.org/show_bug.cgi?id=108655

Reviewed by Adam Barth.

No new tests because no new functionality.

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::isLikelySafeResource):

  • html/parser/XSSAuditor.h:
1:08 PM Changeset in webkit [141632] by caio.oliveira@openbossa.org
  • 15 edits in trunk/Source/WebKit2

[Qt] [WK2] Fix build after r141619
​https://bugs.webkit.org/show_bug.cgi?id=108680

Reviewed by Benjamin Poulain.

Take a reference instead of a pointer for decoding functions.

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::Handle::decode):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::decode):
(CoreIPC::decodeTimingFunction):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:

(WebKit::WebCoordinatedSurface::Handle::decode):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.h:

(Handle):

  • Shared/qt/ArgumentCodersQt.cpp:

(CoreIPC::::decode):

  • Shared/qt/ArgumentCodersQt.h:

(CoreIPC):

  • Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::decode):

  • Shared/qt/PlatformCertificateInfo.h:

(WebKit::PlatformCertificateInfo::decode):

  • Shared/qt/QtNetworkReplyData.cpp:

(WebKit::QtNetworkReplyData::decode):

  • Shared/qt/QtNetworkReplyData.h:

(QtNetworkReplyData):

  • Shared/qt/QtNetworkRequestData.cpp:

(WebKit::QtNetworkRequestData::decode):

  • Shared/qt/QtNetworkRequestData.h:

(QtNetworkRequestData):

  • Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::::decodePlatformData):

12:46 PM Changeset in webkit [141631] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Re-try enabling Win-EWS tests for the third time.
​https://bugs.webkit.org/show_bug.cgi?id=107968

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

12:44 PM Changeset in webkit [141630] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r141281): Navigating to this HTTP Live Streaming (application/vnd.apple.mpegurl) URL downloads a file instead of playing it in the browser
​https://bugs.webkit.org/show_bug.cgi?id=108674
<rdar://problem/13133595>

Reviewed by Eric Carlson.

When passed a HashSet of available MIME types to fill out, QTKit was overwriting the contents, which were
AVFoundation's supported types. Instead, it should be appending to the list of supported types.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::concatenateHashSets): Added static utility function.
(WebCore::MediaPlayerPrivateQTKit::getSupportedTypes): Concatenate instead of overwriting the passed in MIME types.

12:43 PM Changeset in webkit [141629] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip more test in preparation for Win EWS bots (round 2).
​https://bugs.webkit.org/show_bug.cgi?id=108249

  • platform/win/TestExpectations:
12:36 PM Changeset in webkit [141628] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Fix test scripts for EWS bots to get them running once and for all.
​https://bugs.webkit.org/show_bug.cgi?id=108422

Reviewed by Timothy Horton.

Disabling --quiet option on Windows for now because that fails when we try to use /dev/null.
runtests.py was not passing in a configuration to run-webkit-tests which causes DRT to build in release by default.
However, we build in Debug only on the EWS Windows bots, which caused the build to fail.

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.options):
(RunTests.run):

12:27 PM Changeset in webkit [141627] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WTR needs an implementation of setAutomaticLinkDetectionEnabled
​https://bugs.webkit.org/show_bug.cgi?id=87162

Skip a test on wk2 added in r14618 that uses setAutomaticLinkDetectionEnabled.

  • platform/wk2/TestExpectations:
12:21 PM Changeset in webkit [141626] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Zooming in during page load of non-scalable webpage results in fixed magnification
​https://bugs.webkit.org/show_bug.cgi?id=108252

Patch by Jacky Jiang <​zhajiang@rim.com>.
Reviewed by Yong Li.
Internally reviewed by Konrad Piascik.

PR: 284828
We got float layoutSize(342.284122, 521.448467) and
m_maximumScale(2.243750) after computing viewport meta based on the
device pixel ratio and laid out the contents at IntSize(342, 521).
Therefore, zoomToFitScale(2.245681) would be a bit larger than
m_maximumScale based on that contents size and resulted in
maximumScale()!=minimumScale(), which made the non-scalable page
scalable.
Return zoomToFitScale for maximumScale() in such kind of case.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::maximumScale):

12:13 PM Changeset in webkit [141625] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Another speculative windows build fix.

  • platform/ScrollAnimator.h:
12:11 PM Changeset in webkit [141624] by krit@webkit.org
  • 9 edits
    3 adds in trunk

[canvas] Add more constructors to Path
​https://bugs.webkit.org/show_bug.cgi?id=108587

Patch by Dirk Schulze <​krit@webkit.org> on 2013-01-31
Reviewed by Dean Jackson.

Source/WebCore:

Add more constructors to Path object to make it possible
to copy Path objects and parse SVG strings into a Path
object that can be used on the canvas context afterwards.

Test: fast/canvas/canvas-path-constructors.html

  • html/canvas/DOMPath.h: New constructors for Path.

(WebCore::DOMPath::create):
(WebCore::DOMPath::DOMPath):

  • html/canvas/DOMPath.idl: Ditto.

LayoutTests:

Add tests for new constructors of Path objects.
Since the feature is behind a flag, the test is skipped on
all platforms for now.

  • fast/canvas/canvas-path-constructors-expected.txt: Added.
  • fast/canvas/canvas-path-constructors.html: Added.
  • fast/canvas/script-tests/canvas-path-constructors.js: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
12:11 PM Changeset in webkit [141623] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] InputHandler status is not restored when page history goes back
​https://bugs.webkit.org/show_bug.cgi?id=108448

Patch by Sean Wang <​Xuewen.Wang@torchmobile.com.cn> on 2013-02-01
Reviewed by Yong Li.

PR288406 Internally reviewed by Mike Fenton

When webpage goes back, it restores the old frame's selection and focused node,
but we don't save the InputHandler's status, it becomes non-input mode when page
goes back. When it restores the focus, since the new focus node is same as the old
document focused node, webcore will not notify client to update the input handler.

This patch updates the input handler's status by notifying it focus node changed.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::restoreViewState):
(WebKit):

  • WebKitSupport/InputHandler.h:

(InputHandler):

12:06 PM Changeset in webkit [141622] by zandobersek@gmail.com
  • 9 edits in trunk

[GTK] Add WTFURL source files to the build
​https://bugs.webkit.org/show_bug.cgi?id=108215

Reviewed by Benjamin Poulain.

.:

  • Source/autotools/symbols.filter: Force the export of the KURL::string() symbol.

This is required when using the WTFURL backend but otherwise doesn't affect the build.

Source/WebCore:

  • platform/KURLWTFURL.cpp:

(WebCore): Only use the stub implementation of the fileSystemPath method for the
Apple ports, other ports should for now still rely on their platform-specific implementations.

Source/WTF:

The WTFURL implementation sources are all still guarded by the USE(WTFURL) guard,
meaning that the GTK port still uses the default KURL backend. To use the WTFURL
backend instead, one would have to define WTF_USE_WTFURL in Platform.h.

  • GNUmakefile.am: List the directories from which source headers will be included.

Plenty of WTFURL code currently just includes the required header by name rather
than specifying the header path as relative to Source/WTF. In the future all the inclusions
should probaby be changed to include the header through the path relative to Source/WTF.

  • GNUmakefile.list.am: Add build targets for the WTFURL source files.
  • wtf/url/api/ParsedURL.cpp: Specify the complete path to the required headers and

reorder the inclusions.

  • wtf/url/src/URLCanon.h: Ditto.
11:58 AM Changeset in webkit [141621] by mkwst@chromium.org
  • 13 edits in trunk

Remove call to SecurityOrigin::canAccessDatabase from IDB constructor.
​https://bugs.webkit.org/show_bug.cgi?id=108477

Reviewed by Adam Barth.

Source/WebCore:

This change removes the 'SecurityOrigin::canAccessDatabase' check from
the constructor for the 'indexedDB' property on both DOMWindow and
WorkerContext. After the patch for ​http://wkbug.com/94171 this check
is redundant, as all the entry points to IDB are now gated on access
being granted.

As a side-effect, dropping the check in WorkerContextIndexedDatabase
allows us to stop holding a pointer to the ScriptExecutionContext we're
extending, which can only be a good thing.

The tests in storage/indexeddb should continue to pass.

  • Modules/indexeddb/DOMWindowIndexedDatabase.cpp:

(WebCore::DOMWindowIndexedDatabase::indexedDB):

Drop the SecurityOrigin::canAccessDatabase check.

  • Modules/indexeddb/WorkerContextIndexedDatabase.cpp:

(WebCore::WorkerContextIndexedDatabase::WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::from):

Drop the ScriptExecutionContext parameter from the class's
constructor and callsites.

(WebCore::WorkerContextIndexedDatabase::indexedDB):

Drop the SecurityOrigin::canAccessDatabase check.

  • Modules/indexeddb/WorkerContextIndexedDatabase.h:

(WorkerContextIndexedDatabase):

Drop the stored pointer to ScriptExecutionContext, as we no longer
need it in ::indexedDB.

LayoutTests:

  • http/tests/security/no-indexeddb-from-sandbox-expected.txt:
  • http/tests/security/no-indexeddb-from-sandbox.html:

This test expected the 'webkitIndexedDB' property to be missing
entirely inside a sandbox. The expectation has been updated to
expect 'webkitIndexedDB.open()' to throw a SECURITY_ERR.

  • platform/efl/TestExpectations:
  • platform/mac-snowleopard/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:

This test was accidentally passing on a variety of platforms that
don't yet implement IndexedDB. Now that failure is distinguishable
we should skip it on a variety of platforms.

11:54 AM Changeset in webkit [141620] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Speculative Windows build fix.

  • platform/ScrollAnimator.h:

(WebCore):

11:53 AM Changeset in webkit [141619] by andersca@apple.com
  • 109 edits in trunk/Source/WebKit2

Message decoding functions should take a MessageDecoder reference
​https://bugs.webkit.org/show_bug.cgi?id=108669

Reviewed by Andreas Kling.

Message encoding functions already take a reference instead of a pointer, so
make the decoding functions take a reference as well.

  • Platform/CoreIPC/ArgumentCoder.h:

(CoreIPC::ArgumentCoder::decode):

  • Platform/CoreIPC/ArgumentCoders.cpp:

(CoreIPC::::decode):
(CoreIPC::decodeStringText):

  • Platform/CoreIPC/ArgumentCoders.h:

(CoreIPC::SimpleArgumentCoder::decode):

  • Platform/CoreIPC/ArgumentDecoder.h:

(CoreIPC::ArgumentDecoder::decode):

  • Platform/CoreIPC/Arguments.h:

(CoreIPC::Arguments0::decode):
(CoreIPC::Arguments1::decode):
(CoreIPC::Arguments2::decode):
(CoreIPC::Arguments3::decode):
(CoreIPC::Arguments4::decode):
(CoreIPC::Arguments5::decode):
(CoreIPC::Arguments6::decode):
(CoreIPC::Arguments7::decode):
(CoreIPC::Arguments8::decode):
(CoreIPC::Arguments10::decode):

  • Platform/CoreIPC/Attachment.cpp:

(CoreIPC::Attachment::decode):

  • Platform/CoreIPC/Attachment.h:

(Attachment):

  • Platform/CoreIPC/DataReference.cpp:

(CoreIPC::DataReference::decode):

  • Platform/CoreIPC/DataReference.h:

(DataReference):

  • Platform/CoreIPC/StringReference.cpp:

(CoreIPC::StringReference::decode):

  • Platform/CoreIPC/StringReference.h:

(StringReference):

  • Platform/CoreIPC/mac/MachPort.h:

(CoreIPC::MachPort::decode):

  • Platform/SharedMemory.h:

(Handle):

  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::decode):

  • PluginProcess/PluginCreationParameters.cpp:

(WebKit::PluginCreationParameters::decode):

  • PluginProcess/PluginCreationParameters.h:

(PluginCreationParameters):

  • Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::decode):

  • Shared/DictionaryPopupInfo.h:

(DictionaryPopupInfo):

  • Shared/EditorState.cpp:

(WebKit::EditorState::decode):

  • Shared/EditorState.h:

(EditorState):

  • Shared/FontInfo.cpp:

(WebKit::FontInfo::decode):

  • Shared/FontInfo.h:

(FontInfo):

  • Shared/LayerTreeContext.h:

(LayerTreeContext):

  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::decode):

  • Shared/Network/NetworkProcessCreationParameters.h:

(NetworkProcessCreationParameters):

  • Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::decode):

  • Shared/Network/NetworkResourceLoadParameters.h:

(NetworkResourceLoadParameters):

  • Shared/OriginAndDatabases.cpp:

(WebKit::OriginAndDatabases::decode):

  • Shared/OriginAndDatabases.h:

(OriginAndDatabases):

  • Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::decode):

  • Shared/PlatformPopupMenuData.h:

(PlatformPopupMenuData):

  • Shared/Plugins/NPIdentifierData.cpp:

(WebKit::NPIdentifierData::decode):

  • Shared/Plugins/NPIdentifierData.h:

(NPIdentifierData):

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::decode):

  • Shared/Plugins/NPVariantData.h:

(NPVariantData):

  • Shared/Plugins/PluginProcessCreationParameters.cpp:

(WebKit::PluginProcessCreationParameters::decode):

  • Shared/Plugins/PluginProcessCreationParameters.h:

(PluginProcessCreationParameters):

  • Shared/PrintInfo.cpp:

(WebKit::PrintInfo::decode):

  • Shared/PrintInfo.h:

(PrintInfo):

  • Shared/SandboxExtension.h:

(Handle):
(HandleArray):
(WebKit::SandboxExtension::Handle::decode):
(WebKit::SandboxExtension::HandleArray::decode):

  • Shared/SecurityOriginData.cpp:

(WebKit::SecurityOriginData::decode):

  • Shared/SecurityOriginData.h:

(SecurityOriginData):

  • Shared/SessionState.cpp:

(WebKit::SessionState::decode):

  • Shared/SessionState.h:

(SessionState):

  • Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::Handle::decode):

  • Shared/ShareableBitmap.h:

(Handle):

  • Shared/ShareableResource.cpp:

(WebKit::ShareableResource::Handle::decode):

  • Shared/ShareableResource.h:

(Handle):

  • Shared/SharedWorkerProcessCreationParameters.cpp:

(WebKit::SharedWorkerProcessCreationParameters::decode):

  • Shared/SharedWorkerProcessCreationParameters.h:

(SharedWorkerProcessCreationParameters):

  • Shared/StatisticsData.cpp:

(WebKit::StatisticsData::decode):

  • Shared/StatisticsData.h:

(StatisticsData):

  • Shared/StringPairVector.h:

(WebKit::StringPairVector::decode):

  • Shared/UpdateInfo.cpp:

(WebKit::UpdateInfo::decode):

  • Shared/UpdateInfo.h:

(UpdateInfo):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::decode):

  • Shared/WebContextMenuItemData.h:

(WebContextMenuItemData):

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::decode):
(CoreIPC::decodeImage):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebEvent.cpp:

(WebKit::WebEvent::decode):

  • Shared/WebEvent.h:

(WebEvent):
(WebMouseEvent):
(WebWheelEvent):
(WebKeyboardEvent):
(WebGestureEvent):
(WebPlatformTouchPoint):
(WebTouchEvent):

  • Shared/WebGeolocationPosition.cpp:

(WebKit::WebGeolocationPosition::Data::decode):

  • Shared/WebGeolocationPosition.h:

(Data):

  • Shared/WebGestureEvent.cpp:

(WebKit::WebGestureEvent::decode):

  • Shared/WebHitTestResult.cpp:

(WebKit::WebHitTestResult::Data::decode):

  • Shared/WebHitTestResult.h:

(Data):

  • Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::decode):

  • Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::decode):

  • Shared/WebNavigationDataStore.h:

(WebKit::WebNavigationDataStore::decode):

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:

(WebPageCreationParameters):

  • Shared/WebPageGroupData.cpp:

(WebKit::WebPageGroupData::decode):

  • Shared/WebPageGroupData.h:

(WebPageGroupData):

  • Shared/WebPlatformTouchPoint.cpp:

(WebKit::WebPlatformTouchPoint::decode):

  • Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::decode):

  • Shared/WebPopupItem.h:
  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::decode):

  • Shared/WebPreferencesStore.h:

(WebPreferencesStore):

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • Shared/WebTouchEvent.cpp:

(WebKit::WebTouchEvent::decode):

  • Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::decode):

  • Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::decode):

  • Shared/cf/ArgumentCodersCF.h:

(CoreIPC):

  • Shared/mac/ArgumentCodersMac.h:

(CoreIPC):

  • Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::decode):

  • Shared/mac/AttributedString.h:

(AttributedString):

  • Shared/mac/AttributedString.mm:

(WebKit::AttributedString::decode):

  • Shared/mac/ColorSpaceData.h:

(ColorSpaceData):

  • Shared/mac/ColorSpaceData.mm:

(WebKit::ColorSpaceData::decode):

  • Shared/mac/LayerTreeContextMac.mm:

(WebKit::LayerTreeContext::decode):

  • Shared/mac/ObjCObjectGraphCoders.h:

(WebContextObjCObjectGraphDecoder):
(InjectedBundleObjCObjectGraphDecoder):

  • Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::ObjCObjectGraphDecoder::baseDecode):
(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
(WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode):
(WebKit::WebContextObjCObjectGraphDecoder::decode):
(WebKit::InjectedBundleObjCObjectGraphDecoder::decode):

  • Shared/mac/PlatformCertificateInfo.h:

(PlatformCertificateInfo):

  • Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::decode):

  • Shared/mac/RemoteLayerTreeTransaction.h:

(LayerProperties):
(RemoteLayerTreeTransaction):

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::decode):

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::Handle::decode):
(WebKit::SandboxExtension::HandleArray::decode):

  • Shared/mac/SecItemRequestData.cpp:

(WebKit::SecItemRequestData::decode):

  • Shared/mac/SecItemRequestData.h:
  • Shared/mac/SecItemResponseData.cpp:

(WebKit::SecItemResponseData::decode):

  • Shared/mac/SecItemResponseData.h:

(SecItemResponseData):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::decodePlatformData):
(CoreIPC::::decode):

  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageDecoder::decode):

  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageDecoder::decode):

  • WebProcess/Plugins/Plugin.cpp:

(WebKit::Plugin::Parameters::decode):

  • WebProcess/Plugins/Plugin.h:

(Parameters):

11:44 AM Changeset in webkit [141618] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Smart link can erroneously move caret after an URL when typing immediately before it
​https://bugs.webkit.org/show_bug.cgi?id=92812

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by smart link being triggered even when a user finished typing a word
immediately before an URL. We already had a logic to avoid smart-linking an URL when the caret
was after the URL but we were missing a check for when the caret is before the URL.

Fixed the bug by adding this check.

Test: editing/inserting/smart-link-when-caret-is-moved-before-URL.html

  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):

LayoutTests:

Add a regression for typing immediately before an URL while smart link is enabled.
WebKit should not be moving the caret erroneously.

  • editing/inserting/smart-link-when-caret-is-moved-before-URL-expected.txt: Added.
  • editing/inserting/smart-link-when-caret-is-moved-before-URL.html: Added.
11:40 AM Changeset in webkit [141617] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Windows build fix. FloatSize.cpp was not included in the project.

  • WebCore.vcproj/WebCore.vcproj:
11:29 AM Changeset in webkit [141616] by jchaffraix@webkit.org
  • 4 edits
    2 adds in trunk

[CSS Grid Layout] computePreferredLogicalWidths doesn't handle minmax tracks
​https://bugs.webkit.org/show_bug.cgi?id=108403

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-preferred-logical-widths.html

The code before this change was only handling minmax() with 2 fixed widths.
The new code was updated to remove this artificial limitation and we now
support all combination of minmax().

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computePreferredLogicalWidths):
Updated to use computePreferredTrackWidth..

(WebCore::RenderGrid::computePreferredTrackWidth):
Added this helper function that implements the core of the preferred width
computation.

  • rendering/RenderGrid.h: Added computePreferredTrackWidth.

LayoutTests:

  • fast/css-grid-layout/grid-preferred-logical-widths-expected.txt: Added.
  • fast/css-grid-layout/grid-preferred-logical-widths.html: Added.
11:25 AM Changeset in webkit [141615] by Nate Chapin
  • 5 edits
    3 adds in trunk

Cached main resources report a zero identifer on 304s
​https://bugs.webkit.org/show_bug.cgi?id=108402

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/cache/iframe-304-crash.html

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::responseReceived): Throughout, check m_identifierForLoadWithoutResourceLoader

instead of !loader() to determine whether MainResourceLoader needs to synthesize resource load callbacks.

(WebCore::MainResourceLoader::dataReceived):
(WebCore::MainResourceLoader::didFinishLoading):

LayoutTests:

  • http/tests/cache/iframe-304-crash-expected.txt: Added.
  • http/tests/cache/iframe-304-crash.html: Added.
  • http/tests/cache/resources/iframe304.php: Added.
  • platform/chromium/TestExpectations: New test requires main resource caching, which isn't supported on chromium at the moment.
  • platform/mac/TestExpectations: New test requires main resource caching, which isn't supported on mac at the moment.
11:14 AM Changeset in webkit [141614] by thakis@chromium.org
  • 11 edits in trunk

[chromium] Build webkit with enable_web_intents set to 0.
​https://bugs.webkit.org/show_bug.cgi?id=108408

Reviewed by Tony Chang.

I'll then make chromium build fine with that, then switch
enable_web_intents to 0, roll that into webkit, and then
actually remove the code hidden behind this flag.

Source/WebCore:

  • bindings/v8/custom/V8IntentCustom.cpp:

Source/WebKit/chromium:

The features.gypi bit depends on ​https://codereview.chromium.org/12143002/
and will disable web intents support on android. Since common.gypi
sets enable_web_intents to 0 explicitly, it seems this is currently on
by accident anyway.

While it looks like this CL just removes ENABLE_WEB_INTENTS=1 from
features.gypi completely, it's still set further down the file if
enable_web_intents is on.

  • WebKit.gyp:
  • features.gypi:
  • src/WebFrameImpl.cpp:

Tools:

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):

  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

11:07 AM Changeset in webkit [141613] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: make console object state hint non-active
​https://bugs.webkit.org/show_bug.cgi?id=108642

Reviewed by Vsevolod Vlasov.

Otherwise it seems like an active element user could click.

  • inspector/front-end/inspector.css:

(.object-info-state-note):

11:04 AM Changeset in webkit [141612] by commit-queue@webkit.org
  • 3 edits
    18 adds in trunk

Zero size gradient should paint nothing on canvas
​https://bugs.webkit.org/show_bug.cgi?id=102654

Patch by Rashmi Shyamasundar <​rashmi.s2@samsung.com> on 2013-02-01
Reviewed by Dirk Schulze.

Source/WebCore:

The functions fill(), fillText(), stroke(), strokeRect() and strokeText()
should paint nothing on canvas when the canvas fillStyle/strokeStyle
is set to a zero size gradient.

Tests: fast/canvas/canvas-fill-zeroSizeGradient.html

fast/canvas/canvas-fillRect-zeroSizeGradient.html
fast/canvas/canvas-fillText-zeroSizeGradient.html
fast/canvas/canvas-stroke-zeroSizeGradient.html
fast/canvas/canvas-strokeRect-zeroSizeGradient.html
fast/canvas/canvas-strokeText-zeroSizeGradient.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::strokeRect):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

The functions fill(), fillText(), stroke(), strokeRect() and strokeText()
should paint nothing on canvas when the canvas fillStyle/strokeStyle
is set to a zero size gradient.

  • fast/canvas/canvas-fill-zeroSizeGradient-expected.txt: Added.
  • fast/canvas/canvas-fill-zeroSizeGradient.html: Added.
  • fast/canvas/canvas-fillRect-zeroSizeGradient-expected.txt: Added.
  • fast/canvas/canvas-fillRect-zeroSizeGradient.html: Added.
  • fast/canvas/canvas-fillText-zeroSizeGradient-expected.txt: Added.
  • fast/canvas/canvas-fillText-zeroSizeGradient.html: Added.
  • fast/canvas/canvas-stroke-zeroSizeGradient-expected.txt: Added.
  • fast/canvas/canvas-stroke-zeroSizeGradient.html: Added.
  • fast/canvas/canvas-strokeRect-zeroSizeGradient-expected.txt: Added.
  • fast/canvas/canvas-strokeRect-zeroSizeGradient.html: Added.
  • fast/canvas/canvas-strokeText-zeroSizeGradient-expected.txt: Added.
  • fast/canvas/canvas-strokeText-zeroSizeGradient.html: Added.
  • fast/canvas/script-tests/canvas-fill-zeroSizeGradient.js: Added.
  • fast/canvas/script-tests/canvas-fillRect-zeroSizeGradient.js: Added.
  • fast/canvas/script-tests/canvas-fillText-zeroSizeGradient.js: Added.
  • fast/canvas/script-tests/canvas-stroke-zeroSizeGradient.js: Added.
  • fast/canvas/script-tests/canvas-strokeRect-zeroSizeGradient.js: Added.
  • fast/canvas/script-tests/canvas-strokeText-zeroSizeGradient.js: Added.
11:00 AM Changeset in webkit [141611] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

HRTFElevation segfault if a null AudioBus is returned by loadPlatformResource
​https://bugs.webkit.org/show_bug.cgi?id=108504

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2013-02-01
Reviewed by Kenneth Russell.

Fixed a segfault by checking if the returned AudioBus is null or not.
If it is, we should early return in the same way it was being done already
in HRTFElevation::calculateKernelsForAzimuthElevation();

No new tests, covered by existing tests.

  • platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):

10:59 AM Changeset in webkit [141610] by Beth Dakin
  • 8 edits in trunk/Source/WebCore

ScrollAnimatorMac should adopt contentAreaScrolledInDirection
​https://bugs.webkit.org/show_bug.cgi?id=108647
-and corresponding-
<rdar://problem/12434779>

Reviewed by Anders Carlsson.

This patch makes notifyContentAreaScrolled() and notifyPositionChanged() take a
FloatSize parameter that represents the scroll delta so that it can be passed
along to contentAreaScrolledInDirection:.

Pass along the scroll delta.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):

The delta is not needed in this base-class implementation. It will only be needed
in the ScrollAnimatorMac override.
(WebCore::ScrollAnimator::notifyPositionChanged):

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::notifyContentAreaScrolled):

Pass along the delta.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollPositionChanged):

Add contentAreaScrolledInDirection: to the NSScrollerImpDetails.

  • platform/mac/NSScrollerImpDetails.h:

New member variable m_contentAreaScrolledTimerScrollDelta stores the current
scroll delta while we are waiting for m_sendContentAreaScrolledTimer to fire.

  • platform/mac/ScrollAnimatorMac.h:

We need this so that we can call just contentAreaScrolled if
contentAreaScrolledInDirection: is not available.

  • platform/mac/ScrollAnimatorMac.mm:

(supportsContentAreaScrolledInDirection):

Pass along the delta.
(WebCore::ScrollAnimatorMac::immediateScrollTo):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::immediateScrollBy):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledSoon):

If contentAreaScrolledInDirection: is available, call it with the delta, and then
reset our delta. Otherwise, still call contentAreaScrolled.
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

10:56 AM Changeset in webkit [141609] by leviw@chromium.org
  • 2 edits
    2 copies in branches/chromium/1364

Merge 141357

[Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
​https://bugs.webkit.org/show_bug.cgi?id=108381

Reviewed by James Robinson.

Source/WebKit/chromium:

WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
touch events. Some plugins make this request more than once, leading to an imbalance in Document's
touch event handler map, and a stale node pointer when the plugin is destroyed. This change
has WebPluginContainerImpl only add one ref for the plugin at a time.

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::requestTouchEventType):

Tools:

  • DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Adding an attribute that

tickles the case in WebPluginContainerImpl that imbalanced touch handler refs in Document.

LayoutTests:

  • platform/chromium/plugins/re-request-touch-events-crash-expected.txt: Added.
  • platform/chromium/plugins/re-request-touch-events-crash.html: Added.

TBR=​leviw@chromium.org
Review URL: ​https://codereview.chromium.org/12088115

10:55 AM Changeset in webkit [141608] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebKit/chromium: [Chromium] Ignore whitespace in spellcheck
​https://bugs.webkit.org/show_bug.cgi?id=108510

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-02-01
Reviewed by Ryosuke Niwa.

  • src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspellingAsync): Ignore whitespace when selecting the misspelling.

LayoutTests: [Chromium] Expect spellcheck to ignore whitespace
​https://bugs.webkit.org/show_bug.cgi?id=108510

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-02-01
Reviewed by Ryosuke Niwa.

  • platform/chromium/TestExpectations: Expect spellcheck to ignore whitespace.
10:49 AM Changeset in webkit [141607] by pfeldman@chromium.org
  • 4 edits in trunk

Web Inspector: [file selector dialog] for mixed case queries, score uppercase letters only when assessing camelcase.
​https://bugs.webkit.org/show_bug.cgi?id=108639

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):

LayoutTests:

  • inspector/filtered-item-selection-dialog-filtering-expected.txt:
10:45 AM Changeset in webkit [141606] by robert@webkit.org
  • 3 edits
    4 adds in trunk

Padding in a parent inline preceding an empty inline child should be counted towards width
​https://bugs.webkit.org/show_bug.cgi?id=108226

Reviewed by Levi Weintraub.

Source/WebCore:

Add the border/padding/margin from an empty inline's parent inline if it is the first or last
child of the inline.

Tests: fast/inline/parent-inline-element-padding-contributes-width.html

fast/inline/positioned-element-padding-contributes-width.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/inline/parent-inline-element-padding-contributes-width-expected.txt: Added.
  • fast/inline/parent-inline-element-padding-contributes-width.html: Added.
  • fast/inline/positioned-element-padding-contributes-width-expected.txt: Added.
  • fast/inline/positioned-element-padding-contributes-width.html: Added.
10:40 AM Changeset in webkit [141605] by tonyg@chromium.org
  • 4 edits in trunk/Source/WebCore

Continue making XSSAuditor thread safe: Remove dependencies on m_parser from init()
​https://bugs.webkit.org/show_bug.cgi?id=108531

Reviewed by Adam Barth.

The threaded HTML parser will create and init() the XSSAuditor on the main thread, but filterToken() will be called on the background.

No new tests because no change in functionality.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h:

(WebCore):
(XSSAuditor):

10:32 AM Changeset in webkit [141604] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Removed an unused function: JSGlobalObject::createFunctionExecutableFromGlobalCode
​https://bugs.webkit.org/show_bug.cgi?id=108657

Reviewed by Anders Carlsson.

  • runtime/JSGlobalObject.cpp:

(JSC):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):

10:31 AM Changeset in webkit [141603] by beidson@apple.com
  • 4 edits in trunk/Source/WebCore

Remove unnecessary parameter from DocumentLoader::scheduleArchiveLoad
​https://bugs.webkit.org/show_bug.cgi?id=108654

Reviewed by Alexey Proskuryakov.

No new tests (No behavior change.)

Remove the KURL parameter parameter from this method which, in practice,
is always the same as the url of the ResourceRequest parameter.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::scheduleArchiveLoad):

  • loader/DocumentLoader.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::start):

10:18 AM Changeset in webkit [141602] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

Set the GTK 64-bit Debug builder to build and test only WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=108648

Reviewed by Philippe Normand.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Change the builder name, type and

build directory to note that the builder builds and tests only the WebKit1 port on the GTK platform.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit1Only): Add the new build class that builds only the WebKit1 port of the builder's platform.
(BuildAndTestWebKit1OnlyFactory): Add the new factory that uses the CompileWebKit1Only build class
for building and testing only WebKit1 on the builder's platform.

9:49 AM Changeset in webkit [141601] by Lucas Forschler
  • 2 edits in tags/Safari-537.26.5/Source/WebKit2

Merged r141180. <rdar://problem/13047398>

9:46 AM Changeset in webkit [141600] by Lucas Forschler
  • 29 edits in tags/Safari-537.26.5/Source/WebKit2

Merged r141167. <rdar://problem/13047398>

9:18 AM Changeset in webkit [141599] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Adapt WorkQueueGtk to the latest changes in WebKit2 after r141497
​https://bugs.webkit.org/show_bug.cgi?id=108607

Reviewed by Anders Carlsson.

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::EventSource::executeEventSource): Remove the is valid
work queue check.
(WorkQueue::EventSource): WorkQueue is now refcounted, so keep a
reference when a new job is scheduled and unref it when it
finishes.

8:34 AM Changeset in webkit [141598] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Make QWebHistory unit tests more robust

Reviewed by Jocelyn Turcotten.

The tests were using a QEventLoop::exec() call to verify the emission
of the loadFinished() signal after calling for example back() or forward().
However sometimes the call to back() may emit the signal immediately and
sometimes async, causing instabilities in test runs. The call to exec()
also means that if there was a bug then the rest would hang forever because
exec() has no timeout.

This patch introduces a simple SignalBarrier class that solves both issues:

(1) ensureSignalEmitted() supports the immediate signal emission case as well
as the async one.

(2) Through the use of QSignalSpy's wait() there's an actual timeout.

  • tests/qwebhistory/tst_qwebhistory.cpp:

(tst_QWebHistory::init):
(tst_QWebHistory::cleanup):
(tst_QWebHistory::back):
(tst_QWebHistory::forward):
(tst_QWebHistory::goToItem):
(tst_QWebHistory::serialize_2):

  • tests/util.h:

(waitForSignal):
(SignalBarrier):
(SignalBarrier::SignalBarrier):
(SignalBarrier::ensureSignalEmitted):

8:14 AM Changeset in webkit [141597] by Philippe Normand
  • 2 edits in trunk/Source/WebKit/gtk/po

Unreviewed, GTK build fix after r141566.

  • POTFILES.in: The FullscreenVideoController moved to WebCore.
8:02 AM Changeset in webkit [141596] by jochen@chromium.org
  • 18 edits
    1 add
    1 delete in trunk/Tools

[chromium] move ownership of TestRunner object to TestInterfaces
​https://bugs.webkit.org/show_bug.cgi?id=108464

Reviewed by Adam Barth.

Before, TestShell owned the class. This also removes the last include
from DumpRenderTree to TestRunner/src.

This also deletes TestDelegate and uses WebTestDelegate everywhere
instead.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebTestInterfaces):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebKit):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:

(WebTestRunner):
(WebTestRunner::AccessibilityController::setDelegate):
(AccessibilityController):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::makeMenuItemStringsFor):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(WebTestRunner):
(WebTestRunner::EventSender::setDelegate):
(EventSender):

  • DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:

(WebTestRunner::GamepadController::setDelegate):

  • DumpRenderTree/chromium/TestRunner/src/GamepadController.h:

(WebTestRunner):
(GamepadController):

  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::~TestInterfaces):
(WebTestRunner::TestInterfaces::setWebView):
(WebTestRunner::TestInterfaces::setDelegate):
(WebTestRunner::TestInterfaces::bindTo):
(WebTestRunner::TestInterfaces::resetAll):
(WebTestRunner):
(WebTestRunner::TestInterfaces::setTestIsRunning):
(WebTestRunner::TestInterfaces::testRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(WebTestRunner):
(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebKit):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::Internal::testRunner):
(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::Internal):
(WebTestRunner::WebTestInterfaces::Internal::setDelegate):
(WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):

  • DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Added.

(WebTestRunner):
(WebTestRunner::WebTestRunner::WebTestRunner):
(WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpAsText):
(WebTestRunner::WebTestRunner::setShouldDumpAsText):
(WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
(WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
(WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
(WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
(WebTestRunner::WebTestRunner::shouldDumpAsAudio):
(WebTestRunner::WebTestRunner::audioData):
(WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
(WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
(WebTestRunner::WebTestRunner::shouldDumpCreateView):
(WebTestRunner::WebTestRunner::canOpenWindows):
(WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
(WebTestRunner::WebTestRunner::webPermissions):
(WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
(WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
(WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
(WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
(WebTestRunner::WebTestRunner::testRepaint):
(WebTestRunner::WebTestRunner::sweepHorizontally):
(WebTestRunner::WebTestRunner::isPrinting):
(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
(WebTestRunner::WebTestRunner::setTitleTextDirection):
(WebTestRunner::WebTestRunner::httpHeadersToClear):
(WebTestRunner::WebTestRunner::shouldBlockRedirects):
(WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
(WebTestRunner::WebTestRunner::setTopLoadingFrame):
(WebTestRunner::WebTestRunner::topLoadingFrame):
(WebTestRunner::WebTestRunner::policyDelegateDone):
(WebTestRunner::WebTestRunner::policyDelegateEnabled):
(WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
(WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
(WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
(WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
(WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::runFileTest):
(TestShell::resetTestController):
(TestShell::dump):
(TestShell::bindJSObjectsToWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::testRunner):
(TestShell):

7:58 AM Changeset in webkit [141595] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r180131. Requested by
"Florin Malita" <​fmalita@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-01

  • DEPS:
7:46 AM Changeset in webkit [141594] by pfeldman@chromium.org
  • 6 edits in trunk

Web Inspector: relax goto file matching again.
​https://bugs.webkit.org/show_bug.cgi?id=108346

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change brings back behavior introduced in r116244.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegex):
(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems.compareFunction):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
(WebInspector.FilteredItemSelectionDialog.prototype.itemElement):
(WebInspector.OpenResourceDialog):

  • inspector/front-end/utilities.js:

(String.regexSpecialCharacters):
(String.prototype.escapeForRegExp):

LayoutTests:

  • inspector/filtered-item-selection-dialog-filtering-expected.txt:
  • inspector/filtered-item-selection-dialog-filtering.html:
7:43 AM Changeset in webkit [141593] by vsevik@chromium.org
  • 8 edits in trunk

Web Inspector: Navigator should not create tree elements for uiSourceCodes unless neededm should populate folders on expand only.
​https://bugs.webkit.org/show_bug.cgi?id=108601

Reviewed by Pavel Feldman.

Source/WebCore:

Tree elememnts for uiSourceCodes are not created until really needed anymore.
They are now created when parent folder tree elememnts are expanded or when uiSourceCode is revealed in navigator.

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype.addUISourceCode):
(WebInspector.NavigatorView.prototype._getOrCreateScriptTreeElement):
(WebInspector.NavigatorView.prototype._getScriptTreeElement):
(WebInspector.NavigatorView.prototype._createScriptTreeElement):
(WebInspector.NavigatorView.prototype._removeScriptTreeElement):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype.isScriptSourceAdded):
(WebInspector.NavigatorView.prototype.revealUISourceCode):
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorView.prototype.reset):
(WebInspector.NavigatorView.prototype.createFolderTreeElement):
(WebInspector.NavigatorView.prototype._populateFolderTreeElement):
(WebInspector.NavigatorView.prototype._addScriptTreeElement):
(WebInspector.NavigatorView.prototype._adoptUISourceCode):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.onpopulate):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest.):
(initialize_DebuggerTest):

  • inspector/debugger/scripts-file-selector-expected.txt:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
7:40 AM Changeset in webkit [141592] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, flagging more fullscreen tests in GTK due to bug 108363.

  • platform/gtk/TestExpectations:
7:32 AM Changeset in webkit [141591] by loislo@chromium.org
  • 9 edits in trunk/Source/WTF

Web Inspector: Native Memory Instrumentation: provide edge names and class names for WTF containers and strings
​https://bugs.webkit.org/show_bug.cgi?id=107303

Reviewed by Yury Semikhatsky.

I'd like to use ValueType[] as className for the container data members
because class names of template parameters already present in the container class names.

  • wtf/MemoryInstrumentationArrayBufferView.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashCountedSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashMap.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationListHashSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationSequence.h:
  • wtf/MemoryInstrumentationString.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationVector.h:

(WTF::reportMemoryUsage):

7:27 AM Changeset in webkit [141590] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

PatchLog process durations are increasing linearly with time (faulty data logging)
​https://bugs.webkit.org/show_bug.cgi?id=108621

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-02-01
Reviewed by Eric Seidel.

Added a check to prevent a stop event from happening to the same patch multiple times.

  • QueueStatusServer/loggers/recordpatchevent.py:

(RecordPatchEvent.stopped):

7:27 AM Changeset in webkit [141589] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: TabbedEditorContainer.History performance optimization.
​https://bugs.webkit.org/show_bug.cgi?id=108581

Introduced history items indexing by url.

Reviewed by Pavel Feldman.

Covered by existing test.

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.History):
(WebInspector.TabbedEditorContainer.History.prototype.index):
(WebInspector.TabbedEditorContainer.History.prototype._rebuildItemIndex):
(WebInspector.TabbedEditorContainer.History.prototype.update):
(WebInspector.TabbedEditorContainer.History.prototype.remove):

7:01 AM Changeset in webkit [141588] by ggaren@apple.com
  • 6 edits
    1 add in trunk/Source

Added TriState to WTF and started using it in one place
​https://bugs.webkit.org/show_bug.cgi?id=108628

Reviewed by Beth Dakin.

../JavaScriptCore:

  • runtime/PrototypeMap.h:

(JSC::PrototypeMap::isPrototype): Use TriState instead of boolean. In
response to review feedback, this is an attempt to clarify that our
'true' condition is actually just a 'maybe'.

  • runtime/PrototypeMap.h:

(PrototypeMap):
(JSC::PrototypeMap::isPrototype):

../WebCore:

  • editing/EditingStyle.h:

(WebCore): Moved TriState to WTF so it can be used in more places.

../WTF:

Useful for expressing "maybe" conditions in a boolean context.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/TriState.h: Added.

(WTF):

6:17 AM Changeset in webkit [141587] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r141319.
​http://trac.webkit.org/changeset/141319
​https://bugs.webkit.org/show_bug.cgi?id=108629

This patch is causing the UIProcess to hang on GTK port when
loading plugins (Requested by chris-qBT_laptop on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-01

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

6:12 AM Changeset in webkit [141586] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Build fix for WinCE after r137709
​https://bugs.webkit.org/show_bug.cgi?id=105767

Do not pass functions as const references to
templated arguments to make the compiler happy.

  • wtf/StdLibExtras.h:

(WTF::binarySearch):
(WTF::tryBinarySearch):
(WTF::approximateBinarySearch):

6:11 AM Changeset in webkit [141585] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK][WK2] MiniBrowser fullscreen signals support
​https://bugs.webkit.org/show_bug.cgi?id=108005

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-01
Reviewed by Carlos Garcia Campos.

Shows a label for 2 seconds using overlay (if GTK >= 3.2.0) and hides
the toolbar when entering fullscreen. When leaving fullscreen the
label is hidden (if it's not hidden yet) and the toolbar is shown again.

  • MiniBrowser/gtk/BrowserWindow.c:

(_BrowserWindow):
(fullScreenMessageTimeoutCallback):
(webViewEnterFullScreen):
(webViewLeaveFullScreen):
(browserWindowFinalize):
(browserWindowConstructed):

5:42 AM Changeset in webkit [141584] by sudarsana.nagineni@linux.intel.com
  • 4 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip some failing tests on EFL bots after r141459 and r141310.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/fast/js/global-constructors-expected.txt: Revert change from r141573.
5:08 AM Changeset in webkit [141583] by mikhail.pozdnyakov@intel.com
  • 6 edits in trunk/Source/WebKit2

[EFL][WK2] EwkContext should be based on C WK2 API
​https://bugs.webkit.org/show_bug.cgi?id=107666

Reviewed by Andreas Kling.

EwkContext should be based on C WK2 API so that API layering is not violated.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):
(EwkContext::create):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):
(EwkContext::setAdditionalPluginPath):
(EwkContext::clearResourceCache):

  • UIProcess/API/efl/ewk_context_private.h:

(EwkContext):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_base_add):

5:00 AM Changeset in webkit [141582] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix hanging deleteQWebViewTwice test

Reviewed by Allan Sandfeld Jensen.

Don't use QCoreApplication::instance()->exec(), because in case of a bug
that never finishes. Instead use waitForSignal() which has the concept of
a timeout.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::deleteQWebViewTwice):

4:56 AM Changeset in webkit [141581] by Christophe Dumez
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Use C API inside ewk_auth_request
​https://bugs.webkit.org/show_bug.cgi?id=107806

Reviewed by Andreas Kling.

Use C API inside ewk_auth_request instead of accessing C++ internal
classes directly, to avoid violating layering.

  • UIProcess/API/efl/ewk_auth_request.cpp:

(EwkAuthRequest::EwkAuthRequest):
(EwkAuthRequest::suggestedUsername):
(EwkAuthRequest::realm):
(EwkAuthRequest::host):
(EwkAuthRequest::continueWithoutCredential):
(EwkAuthRequest::authenticate):
(EwkAuthRequest::isRetrying):
(ewk_auth_request_authenticate):

  • UIProcess/API/efl/ewk_auth_request_private.h:

(EwkAuthRequest::create):
(EwkAuthRequest):

  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didReceiveAuthenticationChallengeInFrame):

4:54 AM Changeset in webkit [141580] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Gtk][WK2] Fix build after recent WebKit2 changes
​https://bugs.webkit.org/show_bug.cgi?id=108588

Patch by Seulgi Kim <​seulgikim@company100.net> on 2013-02-01
Reviewed by Andreas Kling.

Don't remove WorkQueue during execution.
Following the logic on ​https://bugs.webkit.org/show_bug.cgi?id=108544

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::EventSource::~EventSource):
(WorkQueue::EventSource::executeEventSource):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
(WorkQueue::dispatchOnTermination):

4:23 AM Changeset in webkit [141579] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Follow up to r141260: fixing renamed style.
Not reviewed.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._onClick):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):

4:16 AM Changeset in webkit [141578] by alexis@webkit.org
  • 32 edits in trunk

Enable unprefixed CSS transitions by default.
​https://bugs.webkit.org/show_bug.cgi?id=108216

Reviewed by Dean Jackson.

.:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations. Remove the
various #ifdefs and conditional generations.

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • GNUmakefile.features.am.in:
  • css/CSSPropertyNames.in:
  • dom/EventNames.in:
  • dom/TransitionEvent.cpp:
  • dom/TransitionEvent.h:
  • dom/TransitionEvent.idl:
  • page/DOMWindow.idl:
  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):

Source/WebKit/chromium:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

  • features.gypi:

Source/WebKit/mac:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Unskip the tests by default as now unprefixed CSS Transitions are
enabled by default.

  • fast/events/event-creation-expected.txt:
  • fast/events/event-creation.html: Add the test that was commented out

before.

  • platform/chromium/TestExpectations:
3:49 AM Changeset in webkit [141577] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r141548.
​http://trac.webkit.org/changeset/141548
​https://bugs.webkit.org/show_bug.cgi?id=108579

userscript-plugin-document.html is flaky

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapperInObject):

  • bindings/v8/V8GCController.cpp:

(WebCore):
(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):

  • bindings/v8/V8GCController.h:

(V8GCController):

3:39 AM Changeset in webkit [141576] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipped some failing tests.

  • platform/qt/TestExpectations:
3:27 AM Changeset in webkit [141575] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Skip hanging WebGL software fallback tests

Reviewed by Allan Sandfeld Jensen.

See also ​https://bugs.webkit.org/show_bug.cgi?id=105820.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
(tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):

3:26 AM Changeset in webkit [141574] by aandrey@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: fix jscompiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=108604

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleGroup.prototype.addMessage):

  • inspector/front-end/ContextMenu.js:

(WebInspector.ContextSubMenuItem):

  • inspector/front-end/ImageView.js:

(WebInspector.ImageView.prototype._copyImageURL):
(WebInspector.ImageView.prototype._openInNewTab):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._clearBrowserCache):
(WebInspector.NetworkLogView.prototype._clearBrowserCookies):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.IDBDatabaseTreeElement.prototype._refreshIndexedDB):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRenameSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar.prototype._isDockedToBottom):

3:22 AM Changeset in webkit [141573] by sudarsana.nagineni@linux.intel.com
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed EFL gardening.

Update platform expectations for failing tests after the
WEB_INTENTS flag turned off for EFL port in r141439

  • platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
  • platform/efl/fast/js/global-constructors-expected.txt:
3:00 AM Changeset in webkit [141572] by sudarsana.nagineni@linux.intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Renamed inspector/editor/text-editor-ctrl-movements.html to
inspector/editor/text-editor-word-jumps.html after r141399.

  • platform/efl/TestExpectations:
2:51 AM Changeset in webkit [141571] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Coordinated Graphics : Sort Target.pri and class declarations in alphabetical order.
​https://bugs.webkit.org/show_bug.cgi?id=108590

Patch by Jae Hyun Park <​jae.park@company100.net> on 2013-02-01
Reviewed by Noam Rosenthal.

Source/WebCore:

Sort CoordinatedGraphics files in Target.pri in alphabetical order.

No new tests. No change in behavior.

  • Target.pri:

Source/WebKit2:

Sort class declarations in alphabetical order.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:

(WebCore):

2:42 AM Changeset in webkit [141570] by loislo@chromium.org
  • 173 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: provide edge names to class members in all WebCore instrumented classes.
​https://bugs.webkit.org/show_bug.cgi?id=107369

Reviewed by Yury Semikhatsky.

It is almost mechanical change generated by a script.
Late I'll implement name to edge name consistency check in clang plugin.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::reportMemoryUsage):

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::reportMemoryUsage):

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::reportMemoryUsage):

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):

  • bindings/v8/V8ValueCache.cpp:

(WebCore::StringCache::reportMemoryUsage):

  • css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):

  • css/CSSCalculationValue.cpp:
  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):

  • css/CSSCharsetRule.cpp:

(WebCore::CSSCharsetRule::reportMemoryUsage):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::reportMemoryUsage):

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):

  • css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):

  • css/CSSGroupingRule.cpp:

(WebCore::CSSGroupingRule::reportMemoryUsage):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::reportDescendantMemoryUsage):

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::reportMemoryUsage):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reportMemoryUsage):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::reportMemoryUsage):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::reportMemoryUsage):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::reportDescendantMemoryUsage):

  • css/CSSRule.cpp:

(WebCore::CSSRule::reportMemoryUsage):

  • css/CSSRuleList.cpp:

(WebCore::StaticCSSRuleList::reportMemoryUsage):

  • css/CSSRuleList.h:
  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::reportMemoryUsage):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::reportMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/CSSValue.cpp:

(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::reportDescendantMemoryUsage):

  • css/CSSVariableValue.h:

(WebCore::CSSVariableValue::reportDescendantMemoryUsage):

  • css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::reportDescendantMemoryUsage):

  • css/FontValue.cpp:

(WebCore::FontValue::reportDescendantMemoryUsage):

  • css/MediaList.cpp:

(WebCore::MediaQuerySet::reportMemoryUsage):
(WebCore::MediaList::reportMemoryUsage):

  • css/MediaQuery.cpp:

(WebCore::MediaQuery::reportMemoryUsage):

  • css/MediaQueryExp.cpp:

(WebCore::MediaQueryExp::reportMemoryUsage):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):

  • css/RuleFeature.cpp:

(WebCore::RuleFeatureSet::reportMemoryUsage):

  • css/RuleSet.cpp:

(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):

  • css/ShadowValue.cpp:

(WebCore::ShadowValue::reportDescendantMemoryUsage):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::reportMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchedProperties::reportMemoryUsage):
(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::MediaQueryResult::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleRule.cpp:

(WebCore::StyleRule::reportDescendantMemoryUsage):
(WebCore::StyleRulePage::reportDescendantMemoryUsage):
(WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
(WebCore::StyleRuleGroup::reportDescendantMemoryUsage):
(WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
(WebCore::StyleRuleRegion::reportDescendantMemoryUsage):
(WebCore::StyleRuleViewport::reportDescendantMemoryUsage):

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::reportDescendantMemoryUsage):

  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::reportMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reportMemoryUsage):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportMemoryUsage):

  • css/WebKitCSSSVGDocumentValue.cpp:

(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):

  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):

  • css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::reportMemoryUsage):

  • dom/Attribute.h:

(WebCore::Attribute::reportMemoryUsage):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::reportMemoryUsage):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::reportMemoryUsage):

  • dom/ContainerNode.h:

(ContainerNode):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::reportMemoryUsage):

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::reportMemoryUsage):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

  • dom/Element.cpp:

(WebCore::Element::reportMemoryUsage):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::reportMemoryUsage):

  • dom/ElementRareData.cpp:

(WebCore::ElementRareData::reportMemoryUsage):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::reportMemoryUsage):

  • dom/Event.cpp:

(WebCore::Event::reportMemoryUsage):

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeListBase::reportMemoryUsage):

  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • dom/NodeRareData.cpp:

(WebCore::NodeListsNodeData::reportMemoryUsage):
(WebCore::NodeRareData::reportMemoryUsage):

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::reportMemoryUsage):
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::reportMemoryUsage):

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::reportMemoryUsage):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::reportMemoryUsage):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::reportMemoryUsage):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reportMemoryUsage):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::reportMemoryUsage):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::reportMemoryUsage):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::reportMemoryUsage):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::reportMemoryUsage):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::reportMemoryUsage):

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::reportMemoryUsage):

  • inspector/HeapGraphSerializer.h:

(HeapGraphSerializer):

  • inspector/InspectorBaseAgent.cpp:

(WebCore::InspectorBaseAgentInterface::reportMemoryUsage):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::reportMemoryUsage):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):

  • inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::reportMemoryUsage):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::reportMemoryUsage):
(WebCore::ScriptDebugListener::Script::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::reportMemoryUsage):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::reportMemoryUsage):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::reportMemoryUsage):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):
(WebCore::MemoryInstrumentationImpl::reportMemoryUsage):

  • inspector/NetworkResourcesData.cpp:

(WebCore::XHRReplayData::reportMemoryUsage):
(WebCore::NetworkResourcesData::ResourceData::reportMemoryUsage):
(WebCore::NetworkResourcesData::reportMemoryUsage):

  • loader/CachedMetadata.cpp:

(WebCore::CachedMetadata::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::reportMemoryUsage):

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::reportMemoryUsage):

  • loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::reportMemoryUsage):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::reportMemoryUsage):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::reportMemoryUsage):

  • loader/SubstituteData.cpp:

(WebCore::SubstituteData::reportMemoryUsage):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::reportMemoryUsage):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::reportMemoryUsage):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

  • loader/cache/CachedResourceHandle.cpp:

(WebCore::CachedResourceHandleBase::reportMemoryUsage):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::reportMemoryUsage):

  • loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::reportMemoryUsage):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::reportMemoryUsage):

  • loader/cache/CachedShader.cpp:

(WebCore::CachedShader::reportMemoryUsage):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::reportMemoryUsage):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::reportMemoryUsage):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::reportMemoryUsage):

  • page/Frame.cpp:

(WebCore::Frame::reportMemoryUsage):

  • page/Page.cpp:

(WebCore::Page::reportMemoryUsage):

  • platform/KURL.cpp:

(WebCore::KURL::reportMemoryUsage):

  • platform/KURLGoogle.cpp:

(WebCore::KURLGooglePrivate::reportMemoryUsage):

  • platform/KURLWTFURLImpl.h:

(WebCore::KURLWTFURLImpl::reportMemoryUsage):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::reportMemoryUsage):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::reportMemoryUsage):

  • platform/audio/AudioArray.h:

(WebCore::AudioArray::reportMemoryUsage):

  • platform/audio/FFTFrame.cpp:

(WebCore::FFTFrame::reportMemoryUsage):

  • platform/audio/HRTFDatabase.cpp:

(WebCore::HRTFDatabase::reportMemoryUsage):

  • platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::HRTFDatabaseLoader::reportMemoryUsage):

  • platform/audio/HRTFElevation.cpp:

(WebCore::HRTFElevation::reportMemoryUsage):

  • platform/audio/HRTFKernel.cpp:

(WebCore::HRTFKernel::reportMemoryUsage):

  • platform/audio/ffmpeg/FFTFrameFFMPEG.cpp:

(reportMemoryUsage):

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::reportMemoryUsage):
(WebCore::FrameData::reportMemoryUsage):

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::reportMemoryUsage):

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::reportMemoryUsage):

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::reportMemoryUsage):

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::reportMemoryUsage):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::reportMemoryUsage):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBufferData::reportMemoryUsage):

  • platform/graphics/skia/MemoryInstrumentationSkia.cpp:

(reportMemoryUsage):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::reportMemoryUsage):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageFrame::reportMemoryUsage):
(WebCore):
(WebCore::ImageDecoder::reportMemoryUsage):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::ImageFrame::reportMemoryUsage):

  • platform/network/FormData.cpp:

(WebCore::FormData::reportMemoryUsage):
(WebCore::FormDataElement::reportMemoryUsage):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::reportMemoryUsageBase):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::reportMemoryUsage):

  • platform/network/chromium/ResourceRequest.cpp:

(WebCore::ResourceRequest::reportMemoryUsage):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::reportMemoryUsage):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::reportMemoryUsage):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::reportMemoryUsage):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::reportMemoryUsage):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::reportMemoryUsage):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::reportMemoryUsage):
(WebCore::RenderFrameSet::GridAxis::reportMemoryUsage):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::reportMemoryUsage):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::reportMemoryUsage):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::reportMemoryUsage):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::reportMemoryUsage):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::reportMemoryUsage):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::reportMemoryUsage):

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::reportMemoryUsage):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::reportMemoryUsage):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::reportMemoryUsage):
(WebCore::RenderTableSection::RowStruct::reportMemoryUsage):
(WebCore::RenderTableSection::CellStruct::reportMemoryUsage):

  • rendering/RenderText.cpp:

(WebCore::RenderText::reportMemoryUsage):

  • rendering/RenderView.cpp:

(WebCore::RenderView::reportMemoryUsage):

  • rendering/style/DataRef.h:

(WebCore::DataRef::reportMemoryUsage):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::reportMemoryUsage):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::reportMemoryUsage):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::reportMemoryUsage):

  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::reportDescendantMemoryUsage):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::reportMemoryUsage):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::reportMemoryUsage):

2:40 AM Changeset in webkit [141569] by pierre.rossi@gmail.com
  • 1 edit in trunk/Source/WebKit/qt/ChangeLog

[Qt] visibility of embedded widget
​https://bugs.webkit.org/show_bug.cgi?id=108327

Rubber-stamped by Simon Hausmann.

In overriding Widget::hide in QtPluginWidget, we forgot to call the
parent implementation, which as it turns, out does sensible stuff.

  • WebCoreSupport/FrameLoaderClientQt.cpp:
2:37 AM Changeset in webkit [141568] by mihnea@adobe.com
  • 4 edits
    2 adds
    32 deletes in trunk/LayoutTests

[CSS Regions] Convert fast/regions/region-overflow-auto-overflow* to reftests
​https://bugs.webkit.org/show_bug.cgi?id=108333

Reviewed by Tony Chang.

Add reftests, cleanup existing tests.

  • fast/regions/region-overflow-auto-overflow-hidden-expected.html: Added.
  • fast/regions/region-overflow-auto-overflow-hidden.html:
  • fast/regions/region-overflow-auto-overflow-visible-expected.html: Added.
  • fast/regions/region-overflow-auto-overflow-visible.html:
  • platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/chromium-mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/chromium-mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/chromium/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
2:35 AM Changeset in webkit [141567] by pierre.rossi@gmail.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] visibility of embedded widget
​https://bugs.webkit.org/show_bug.cgi?id=108327

Rubber-stamped by Simon Hausmann.

In overriding Widget::show in QtPluginWidget, we forgot to call the
parent implementation, which as it turns, out does sensible stuff.

  • WebCoreSupport/FrameLoaderClientQt.cpp:
2:25 AM Changeset in webkit [141566] by Philippe Normand
  • 12 edits
    2 moves in trunk/Source

[GTK][GStreamer] FullscreenVideoControllerGtk implementation
​https://bugs.webkit.org/show_bug.cgi?id=107398

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

NATIVE_FULLSCREEN_VIDEO support for the GTK port. The previous
FullscreenVideoController implementation was refactored as a
sub-class of FullscreenVideoControllerGStreamer and hooked in the
MediaPlayerPrivateGStreamer backend.

  • GNUmakefile.list.am:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gtk/FullscreenVideoControllerGtk.cpp: Renamed from Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp.
  • platform/graphics/gtk/FullscreenVideoControllerGtk.h: Renamed from Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.h.

Source/WebKit/gtk:

Remove the FullscreenVideoController as it moved to
FullscreenVideoControllerGStreamer and its Gtk subclass in
WebCore. Hook in NATIVE_FULLSCREEN_VIDEO in the ChromeClient in
the two possible scenarios, wether FULLSCREEN_API is enabled or not.

  • GNUmakefile.am: Remove FullscreenVideoController.
  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit):
(WebKit::ChromeClient::enterFullscreenForNode): Hook
NATIVE_FULLSCREEN_VIDEO support.
(WebKit::ChromeClient::exitFullscreenForNode): Ditto
(WebKit::ChromeClient::enterFullScreenForElement): Ditto
(WebKit::ChromeClient::exitFullScreenForElement): Ditto

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

  • WebCoreSupport/FullscreenVideoController.cpp: Removed.
  • WebCoreSupport/FullscreenVideoController.h: Removed.
  • webkit/webkitwebview.cpp: Remove FullscreenVideoController support.
  • webkit/webkitwebviewprivate.h: Ditto
2:11 AM Changeset in webkit [141565] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: fix cursor location in Source Frame
​https://bugs.webkit.org/show_bug.cgi?id=108592

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-02-01
Reviewed by Pavel Feldman.

Normalize range before computing amount of lines in
_updateSourcePosition.

No new tests.

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._updateSourcePosition): Normalize text range.

  • inspector/front-end/inspector.css: Slightly bigger left padding for the text.

(.source-frame-position):

2:09 AM Changeset in webkit [141564] by haraken@chromium.org
  • 15 edits in trunk/Source/WebCore

Unreviewed build fix after r141553.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::HasInstance):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::HasInstance):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::HasInstance):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::HasInstance):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::HasInstance):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::HasInstance):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::HasInstance):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::HasInstance):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::HasInstance):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

2:07 AM Changeset in webkit [141563] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Sources panel navigator reveal and expand fixes.
​https://bugs.webkit.org/show_bug.cgi?id=108584

Reviewed by Pavel Feldman.

Navigator folders are not expanded by default anymore.
Made domain folder expanded for inspected page main frame domain.
UISourceCodes are now added to navigator before editor container
so that they could be revealed if editor container decides to show them.

  • inspector/front-end/NavigatorView.js:

(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._addUISourceCode):

2:06 AM Changeset in webkit [141562] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] MiniBrowser segfaults on loading google.com
​https://bugs.webkit.org/show_bug.cgi?id=108597

Patch by Gwang Yoon Hwang <​ryumiel@company100.net> on 2013-02-01
Reviewed by Andreas Kling.

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::processMessage):
oolMessageBody should be properly initialized before it is used.

This patch also adds omitted break statement.

1:52 AM Changeset in webkit [141561] by aandrey@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend
​https://bugs.webkit.org/show_bug.cgi?id=108591

Reviewed by Pavel Feldman.

Send a dropTraceLog command to the backend when deleting a profile header from the sidebar.
Before we were sending the command only upon deleting an existing view of a profile, so we would not
sent the command if the view was not created or if a profile header was removed via context menu (the ondelete() method).
Drive-by: fixed an odd formatting of property functions.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileHeader.prototype.reset):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileHeader.prototype.reset):
(WebInspector.ProfileHeader.prototype.load):
(WebInspector.ProfileHeader.prototype.canSaveToFile):
(WebInspector.ProfileHeader.prototype.saveToFile):
(WebInspector.ProfileHeader.prototype.loadFromFile):
(WebInspector.ProfileHeader.prototype.fromFile):
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):

1:32 AM Changeset in webkit [141560] by Chris Fleizach
  • 5 edits
    2 adds in trunk

AX: when aria-activedescendant is used with a ComboBox role, focus should not be changed
​https://bugs.webkit.org/show_bug.cgi?id=108596

Reviewed by Ryosuke Niwa.

Source/WebCore:

Normally, an aria-activedescendant change causes a focus change to be triggered.
However, when used in conjunction with a combo box, this causes problems for screen readers.
Namely, the user expects focus to remain in the text field so that the user can keep typing.
If focus moves to an item in the combobox list, it is not possible to keep typing.

The solution is to not trigger a focus change in this case and instead use a selected children change notification.

Test: platform/mac/accessibility/combobox-activedescendant-notifications.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::shouldNotifyActiveDescendant):
(WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

  • platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt: Added.
  • platform/mac/accessibility/combobox-activedescendant-notifications.html: Added.
1:17 AM Changeset in webkit [141559] by Chris Fleizach
  • 4 edits in trunk

Source/WebCore: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion=
​https://bugs.webkit.org/show_bug.cgi?id=108291

Reviewed by Ryosuke Niwa.

This accounts for differences in what AppKit gives for accessibility role descriptions between platforms
when the subrole is not recognized, and standardizes it for WebKit.

Unskip a failing Lion test

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper roleDescription]):

LayoutTests: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion
​https://bugs.webkit.org/show_bug.cgi?id=108291

Reviewed by Ryosuke Niwa.

  • platform/mac/TestExpectations:
1:06 AM Changeset in webkit [141558] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Replace localeCompare in NavigatorView with compareTo.
​https://bugs.webkit.org/show_bug.cgi?id=108585

Reviewed by Pavel Feldman.

Replaced String.prototype.localeCompare with String.prototype.compareTo
in NavigatorView to improve performance.

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorTreeOutline._treeElementsCompare):

12:57 AM Changeset in webkit [141557] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: File system pending requests list is not cleared after processing.
​https://bugs.webkit.org/show_bug.cgi?id=108573

Reviewed by Pavel Feldman.

  • inspector/front-end/IsolatedFileSystemModel.js:

(WebInspector.IsolatedFileSystemModel.prototype._processPendingFileSystemRequests):

12:52 AM Changeset in webkit [141556] by tsepez@chromium.org
  • 5 edits in trunk/Source/WebCore

Dubious cast from HTMLCollection to HTMLAllCollection
​https://bugs.webkit.org/show_bug.cgi?id=108538

Reviewed by Adam Barth.

Patch is tested by enabling V8 binding integrity on HTMLAllCollection and
running the existing tests without introducing new crashes.

  • dom/Document.cpp:

(WebCore::Document::all):
Pass correct type to template.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::HTMLAllCollection):

  • html/HTMLAllCollection.h:

(HTMLAllCollection):
Make create() method arguments compatible with template above.

  • html/HTMLAllCollection.idl:

Enable binding integrity.

12:50 AM Changeset in webkit [141555] by commit-queue@webkit.org
  • 16 edits
    2 adds in trunk

Web Inspector: Add support for handling modal dialogs
​https://bugs.webkit.org/show_bug.cgi?id=107883

Patch by Ken Kania <​kkania@chromium.org> on 2013-02-01
Reviewed by Pavel Feldman.

Introduce support for being notified when a JavaScript modal dialog
is opening and closing, as well as a new command for accepting or
dismissing the dialog.

Source/WebCore:

Test: inspector-protocol/page/willRunJavaScriptDialog.html

  • inspector/Inspector.json:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::handleJavaScriptDialog):
(InspectorClient):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialogImpl):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialogImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialog):
(WebCore):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialog):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::willRunJavaScriptDialog):
(WebCore):
(WebCore::InspectorPageAgent::didRunJavaScriptDialog):
(WebCore::InspectorPageAgent::handleJavaScriptDialog):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.PageDispatcher.prototype.frameStartedLoading):
(WebInspector.PageDispatcher.prototype.frameStoppedLoading):
(WebInspector.PageDispatcher.prototype.frameScheduledNavigation):
(WebInspector.PageDispatcher.prototype.frameClearedScheduledNavigation):
(WebInspector.PageDispatcher.prototype.javascriptDialogOpening):
(WebInspector.PageDispatcher.prototype.javascriptDialogClosed):

  • page/Chrome.cpp:

(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):

Source/WebKit/chromium:

  • public/WebDevToolsAgent.h:
  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::handleJavaScriptDialog):
(WebKit):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(BrowserDataHintStringValues):
(WebKit::WebDevToolsAgentImpl::captureScreenshot):
(WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
(WebKit):
(WebKit::browserHintToString):
(WebKit::browserHintFromString):
(WebKit::WebDevToolsAgent::patchWithBrowserData):

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

LayoutTests:

  • inspector-protocol/page/javascriptDialogEvents-expected.txt: Added.
  • inspector-protocol/page/javascriptDialogEvents.html: Added.
12:48 AM Changeset in webkit [141554] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source

Touch disambiguation blacklist is not being queried properly
​https://bugs.webkit.org/show_bug.cgi?id=108222

Patch by Dan Alcantara <​dfalcantara@chromium.org> on 2013-02-01
Reviewed by Adam Barth.

TEST=WebFrameTest::DisambiguationPopupBlacklist

Source/WebCore:

Fix the blacklist so that we check it for the right nodes.
Add a chromium test to check that the blacklist is being built and used
correctly. Also update the other DisambiguationPopup tests to
use the new page scale method.

  • page/TouchDisambiguation.cpp:

(WebCore::findGoodTouchTargets):

Source/WebKit/chromium:

Fix the blacklist so that we check it for the right nodes.
Add a test to check that the blacklist is being built and used
correctly. Also update the other DisambiguationPopup tests to
use the new page scale method.

  • tests/WebFrameTest.cpp:
  • tests/data/disambiguation_popup_blacklist.html: Added.
12:45 AM Changeset in webkit [141553] by haraken@chromium.org
  • 28 edits in trunk/Source/WebCore

[V8] Add a temporary optional Isolate parameter to HasInstance()
​https://bugs.webkit.org/show_bug.cgi?id=108567

Reviewed by Adam Barth.

The optional Isolate parameter will be removed once all call sites have an Isolate.
It will require several patches.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::HasInstance):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::HasInstance):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::HasInstance):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::HasInstance):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::HasInstance):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::HasInstance):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::HasInstance):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
(WebCore::V8TestObj::HasInstance):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructorCallback):
(WebCore::V8TestOverloadedConstructors::HasInstance):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

12:44 AM Changeset in webkit [141552] by morrita@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking table-section-overflow-clip-crash.html failed.

  • platform/chromium/TestExpectations:
12:44 AM Changeset in webkit [141551] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[CPP,GObject,ObjC] Add 'static' skip to CodeGenerator{CPP,GObject,ObjC}.pm
​https://bugs.webkit.org/show_bug.cgi?id=108578

Patch by Nils Barth <​nbarth@google.com> on 2013-02-01
Reviewed by Kentaro Hara.

Since CPP/GObject/ObjC code generators (CodeGenerator{CPP,GObject,ObjC}.pm)
do not support static attributes, add test to skip these.
This lets us remove #if macro from static in test files and not need
these in future.

Test: bindings/scripts/test/TestObj.idl (run-bindings-test)
Test: bindings/scripts/test/TestSupplemental.idl (run-bindings-test)

  • bindings/scripts/CodeGeneratorCPP.pm:

(SkipAttribute):

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute):

  • bindings/scripts/CodeGeneratorObjC.pm:

(SkipAttribute):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestSupplemental.idl:
12:37 AM Changeset in webkit [141550] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] only show checkboxes for FPS meter and continuous painting when compositing mode is forced
​https://bugs.webkit.org/show_bug.cgi?id=108236

Patch by Eberhard Graether <​egraether@google.com> on 2013-02-01
Reviewed by Pavel Feldman.

This change hides the checkboxes for FPS meter and continuous painting if compositing mode is not forced.
This way the checkboxes only show up for users that can make use of these features.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::canShowFPSCounter):
(WebKit::InspectorClientImpl::canContinuouslyPaint):

12:30 AM Changeset in webkit [141549] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaselining a result.

  • platform/chromium/fast/js/kde/inbuilt_function_tostring-expected.txt:
12:27 AM Changeset in webkit [141548] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Remove V8GCController::m_edenNodes
​https://bugs.webkit.org/show_bug.cgi?id=108579

Reviewed by Adam Barth.

Currently V8GCController::m_edenNodes stores a list of nodes whose
wrappers have been created since the latest GC. The reason why we
needed m_edenNodes is that there was no way to know a list of wrappers
in the new space of V8. By using m_edenNodes, we had been approximating
'wrappers in the new space' by 'wrappers that have been created since
the latest GC'.

Now V8 provides VisitHandlesForPartialDependence(), with which WebKit
can know a list of wrappers in the new space. By using the API, we can
remove V8GCController::m_edenNodes. The benefit is that (1) we no longer
need to keep m_edenNodes and that (2) it enables more precise minor
DOM GC (Remember that m_edenNodes was just an approximation).

Performance benchmark: ​https://bugs.webkit.org/attachment.cgi?id=185940
The benchmark runs 300 iterations, each of which creates 100000 elements.
The benchmark measures average, min, median, max and stdev of execution times
of the 300 iterations. This will tell us the worst-case overhead of this change.

Before:

mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms

After:

mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms

As shown above, I couldn't observe any performance regression.

No tests. No change in behavior.

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapperInObject):

  • bindings/v8/V8GCController.cpp:

(WebCore::gcTree):
(WebCore):
(MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::notifyFinished):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):

  • bindings/v8/V8GCController.h:

(V8GCController):

12:19 AM Changeset in webkit [141547] by vsevik@chromium.org
  • 8 edits in trunk

Web Inspector: Use String.prototype.startsWith instead of String.prototype.indexOf when possible
​https://bugs.webkit.org/show_bug.cgi?id=108575

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/FileMapping.js:

(WebInspector.FileMapping.prototype._entryMatchesURL):
(WebInspector.FileMapping.prototype.urlForURI):

  • inspector/front-end/FileSystemMapping.js:

(get WebInspector.FileSystemMappingImpl.prototype.fileForURI):
(get WebInspector.FileSystemMappingImpl.prototype.uriForPath):

LayoutTests:

  • http/tests/inspector/console-cd-completions.html:
  • http/tests/inspector/console-cd.html:
  • http/tests/inspector/indexeddb/indexeddb-test.js:

(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer.consoleMessageOverride):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer):

  • inspector/network-status-non-http.html:
12:02 AM Changeset in webkit [141546] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Add MessageFlags.h in Target.pri
​https://bugs.webkit.org/show_bug.cgi?id=108583

Patch by Jae Hyun Park <​jae.park@company100.net> on 2013-01-31
Reviewed by Kentaro Hara.

Since MessageDecoder and MessageEncoder include MessageFlags.h, it
should be included in Target.pri.

  • Target.pri:

Jan 31, 2013:

11:43 PM Changeset in webkit [141545] by commit-queue@webkit.org
  • 16 edits in trunk

Editor::m_compositionNode not updated on HTMLInputElement::setValue()
​https://bugs.webkit.org/show_bug.cgi?id=107737

Patch by Aurimas Liutikas <​aurimas@chromium.org> on 2013-01-31
Reviewed by Ryosuke Niwa.

Source/WebCore:

Chromium has a bug where the IME composition did not get cancelled on JavaScript changes
to the focused editing field. Most of other WebKit ports were already doing this check
in their EditorClient::respondToChangedSelection. I took that logic and moved it to the
Editor so every port and use the same code.

An existing test editing/input/setting-input-value-cancel-ime-composition.html covers this change.
This test used to have an expectation to fail on Chromium and after this patch it will start passing.

  • editing/Editor.cpp:

(WebCore::Editor::cancelCompositionIfSelectionIsInvalid):

Adding a call that can be used by any the port to cancel the composition if it's no longer valid.

(WebCore):

  • editing/Editor.h:

(Editor):

Source/WebKit/chromium:

  • public/WebViewClient.h:

(WebKit::WebViewClient::didCancelCompositionOnSelectionChange):

Adding a callback to let the WebViewClient know that the composition has been cancelled.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::respondToChangedSelection):

Adding a call composition if it is no longer valid.

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::respondToChangedSelection):

Adding a call to the newly refactored method.

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::respondToChangedSelection):

Adding a call to the newly refactored Editor method.

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateSelectionForInputManager]):

Source/WebKit/win:

  • WebView.cpp:

(WebView::updateSelectionForIME):

Adding a call to the newly refactored method.

LayoutTests:

11:40 PM Changeset in webkit [141544] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG::CFGSimplificationPhase::keepOperandAlive() conflates liveness and availability
​https://bugs.webkit.org/show_bug.cgi?id=108580

Reviewed by Oliver Hunt.

This is a harmless bug in that it only results in us keeping a bit too many things
for OSR. But it's worth fixing so that the code is consistent.

keepOperandAlive() is called when block A has a branch to blocks B and C, but the
A->B edge is proven to never be taken and we want to optimize the code to have A
unconditionally jump to C. In that case, for the purposes of OSR, we need to
preserve the knowledge that the state that B expected to be live incoming from A
ought still to be live up to the point of where the A->B,C branch used to be. The
way we keep things alive is by using the variablesAtTail of A (i.e., we use the
knowledge of in what manner A made state available to B and C). The way we choose
which state should be kept alive ought to be chosen by the variablesAtHead of B
(i.e. the things B says it needs from its predecessors, including A), except that
keepOperandAlive() was previously just using variablesAtTail of A for this
purpose.

The fix is to have keepOperandAlive() use both liveness and availability in its
logic. It should use liveness (i.e. B->variablesAtHead) to decide what to keep
alive, and it should use availability (i.e. A->variablesAtTail) to decide how to
keep it alive.

This might be a microscopic win on some programs, but it's mainly intended to be
a code clean-up so that I don't end up scratching my head in confusion the next
time I look at this code.

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(JSC::DFG::CFGSimplificationPhase::jettisonBlock):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

11:32 PM Changeset in webkit [141543] by commit-queue@webkit.org
  • 25 edits
    20 moves
    1 add in trunk/Source

Coordinated Graphics : Move CoordinatedGraphics related files to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=108149

Patch by Jae Hyun Park <​jae.park@company100.net> on 2013-01-31
Reviewed by Noam Rosenthal.

This patch moves Coordinated Graphics related code to WebCore. To
implement Threaded Coordinated Graphics, most of Coordianted Graphics
code should be shared. Therefore, they should reside in WebCore instead of
WebKit2.

When moving to WebCore, two renamings have been done.

  1. Rename LayerTreeRenderer to CoordinatedGraphicsScene.
  1. Rename WebCustomFilterProgram and WebCustomFilterOperation to

CoordinatedCustomFilterProgram and CoordinatedCustomFilterOperation,
respectively.

No new tests, covered by existing tests.

Source/WebCore:

  • CMakeLists.txt:
  • Target.pri:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • platform/graphics/texmap/coordinated/AreaAllocator.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp.
  • platform/graphics/texmap/coordinated/AreaAllocator.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.h.
  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp.
  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h.
  • platform/graphics/texmap/coordinated/CoordinatedCustomFilterOperation.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/WebCustomFilterOperation.h.
  • platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/WebCustomFilterProgram.h.
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp.
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h.
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp.
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.h.
  • platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp.
  • platform/graphics/texmap/coordinated/CoordinatedImageBacking.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h.
  • platform/graphics/texmap/coordinated/CoordinatedLayerInfo.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedLayerInfo.h.
  • platform/graphics/texmap/coordinated/CoordinatedSurface.cpp: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedSurface.cpp.
  • platform/graphics/texmap/coordinated/CoordinatedSurface.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedSurface.h.
  • platform/graphics/texmap/coordinated/CoordinatedTile.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp.
  • platform/graphics/texmap/coordinated/CoordinatedTile.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h.
  • platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/SurfaceUpdateInfo.h.
  • platform/graphics/texmap/coordinated/UpdateAtlas.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp.
  • platform/graphics/texmap/coordinated/UpdateAtlas.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h.

Source/WebKit2:

  • CMakeLists.txt:
  • Scripts/webkit2/messages.py:
  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
  • Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
  • Target.pri:
  • UIProcess/API/efl/EwkView.cpp:
  • UIProcess/API/efl/EwkView.h:
  • UIProcess/API/qt/qquickwebpage.cpp:
  • UIProcess/API/qt/raw/qrawwebview.cpp:
  • UIProcess/API/qt/raw/qrawwebview_p.h:
  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
  • UIProcess/efl/PageClientBase.cpp:
  • UIProcess/efl/PageViewportControllerClientEfl.cpp:
  • UIProcess/qt/QtWebPageSGNode.cpp:
  • UIProcess/qt/QtWebPageSGNode.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
11:26 PM Changeset in webkit [141542] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk

[Qt] Add support for text decoration "wavy" style
​https://bugs.webkit.org/show_bug.cgi?id=93507

Patch by Lamarque V. Souza <​Lamarque.Souza@basyskom.com> on 2013-01-31
Reviewed by Simon Hausmann.

Source/WebCore:

Add support for text decoration "wavy" style for Qt platform.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::toQPenStyle):
Remove FIXME comments obsoleted by this patch.
(WebCore::GraphicsContext::drawLine):
Implement wavy style line tracer.

LayoutTests:

Add pixel-test expected results for CSS3 text decoration tests for Qt port.

  • platform/qt-5.0-wk1/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style-expected.png: Added.
  • platform/qt-5.0-wk1/fast/css3-text/css3-text-decoration/text-decoration-style-expected.png: Added.
11:07 PM Changeset in webkit [141541] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[CPP,GObject,ObjC] Add 'enum' skip to CodeGenerator{CPP,GObject,ObjC}.pm
​https://bugs.webkit.org/show_bug.cgi?id=108565

Patch by Nils Barth <​nbarth@google.com> on 2013-01-31
Reviewed by Kentaro Hara.

Since legacy code generators (CodeGenerator{CPP,GObject,ObjC}.pm)
do not support enumerations, add test to skip attributes of enum type.
This lets us remove #if macro from enum in test file and not need
these in future.
Also minor associated code cleaning:

auxiliary variable: $type = $attribute->signature->type.

Test: bindings/scripts/test/TestObj.idl (run-bindings-test)

  • bindings/scripts/CodeGeneratorCPP.pm:

(SkipAttribute):

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute):

  • bindings/scripts/CodeGeneratorObjC.pm:

(SkipAttribute):

  • bindings/scripts/test/TestObj.idl: remove #if macro
10:56 PM Changeset in webkit [141540] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
​https://bugs.webkit.org/show_bug.cgi?id=108543

Patch by Aurimas Liutikas <​aurimas@chromium.org> on 2013-01-31
Reviewed by Ryosuke Niwa.

Fixing a bug that was uncovered after fixing ​http://trac.webkit.org/changeset/141479

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setCompositionFromExistingText):

  • tests/WebViewTest.cpp:

Re-enabling the test

10:52 PM Changeset in webkit [141539] by loislo@chromium.org
  • 3 edits in trunk/Source/WTF

Web Inspector: Native Memory Instrumentation: replace nodeName argument with className
​https://bugs.webkit.org/show_bug.cgi?id=107278

Reviewed by Yury Semikhatsky.

I replaced nodeName with className because we newer report node name for private and raw buffers
but need to report their class names.

  • wtf/MemoryInstrumentation.cpp:

(WTF::MemoryInstrumentation::reportLinkToBuffer):
(WTF::MemoryClassInfo::addRawBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):

  • wtf/MemoryInstrumentation.h:

(WTF::MemoryInstrumentation::addRawBuffer):
(MemoryClassInfo):

10:36 PM Changeset in webkit [141538] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, followup fix for r141535.

  • tests/WebFrameTest.cpp:
10:28 PM Changeset in webkit [141537] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r180023. Requested by
thakis_ via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-31

  • DEPS:
9:54 PM Changeset in webkit [141536] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r141192): Crash beneath cti_op_get_by_id_generic @ discussions.apple.com
​https://bugs.webkit.org/show_bug.cgi?id=108576

Reviewed by Filip Pizlo.

This was a long-standing bug. The DFG would destructively reuse a register
in op_convert_this, but:

  • The bug only presented during speculation failure for type Other
  • The bug presented by removing the low bits of a pointer, which used to be harmless, since all objects were so aligned anyway.
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Don't reuse our this register as
our scratch register. The whole point of our scratch register is to
avoid destructively modifying our this register. I'm pretty sure this
was a copy-paste error.

9:37 PM Changeset in webkit [141535] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, disabling failing test.

  • tests/WebFrameTest.cpp:
9:01 PM Changeset in webkit [141534] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Provide a sensible default architecture when building on iOS SDKs
​https://bugs.webkit.org/show_bug.cgi?id=108395

Patch by David Farler <​dfarler@apple.com> on 2013-01-31
Reviewed by Anders Carlsson.

  • Scripts/webkitdirs.pm:

(determineArchitecture): Anchor SDK regex matches at the beginning.

8:25 PM Changeset in webkit [141533] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

Refactoring: Remove the default argument value for Node::setFocus
​https://bugs.webkit.org/show_bug.cgi?id=108554

Reviewed by Kentaro Hara.

There is no code to use the default argument.
No new tests. Just a refactoring.

  • dom/Node.h: Remove default argument value for setFocus.
  • dom/ContainerNode.h:

(ContainerNode): Ditto.

  • html/HTMLAreaElement.h:

(HTMLAreaElement): Add OVERRIDE to setFocus.

  • html/HTMLFrameElementBase.h:

(HTMLFrameElementBase): Ditto.

8:20 PM Changeset in webkit [141532] by morrita@google.com
  • 1 edit
    5 adds in trunk/LayoutTests

[Chromium] Unreviewed, rebaselining expectations.

  • platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-e-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-n-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-s-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-w-expected.txt: Added.
8:03 PM Changeset in webkit [141531] by vcarbune@chromium.org
  • 7 edits in trunk

[Track] Closed Caption button shouldn't be visible if all the track resources have failed loading
​https://bugs.webkit.org/show_bug.cgi?id=106285

Reviewed by Eric Carlson.

Source/WebCore:

Updated existing test cases.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTracksAreReady): Checked whether there are tracks not loaded
when the algorithm began.
(WebCore::HTMLMediaElement::textTrackReadyStateChanged): If the ready state changed to
FailedToLoad the media controls should check whether there are other caption tracks
and hide the button if not.
(WebCore::HTMLMediaElement::didAddTrack): Added trigger to closedCaptionsTrackChanged.
(WebCore::HTMLMediaElement::hasClosedCaptions): Updated check to skip tracks that
failed to load.

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::reset): Used the newly added method.
(WebCore::MediaControls::refreshClosedCaptionsButtonVisibility): Added container method for
default behaviour for refreshing the visibility of the caption button.
(WebCore::MediaControls::closedCaptionTracksChanged): Used the newly added method.
(WebCore):

  • html/shadow/MediaControls.h:

(MediaControls):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTracksAreReady):
(WebCore::HTMLMediaElement::textTrackReadyStateChanged):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::didAddTrack):
(WebCore::HTMLMediaElement::hasClosedCaptions):

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::reset):
(WebCore::MediaControls::refreshClosedCaptionsButtonVisibility):
(WebCore::MediaControls::closedCaptionTracksChanged):
(WebCore):

  • html/shadow/MediaControls.h:

(MediaControls):

LayoutTests:

Updated tests to include improved behavior.

  • media/video-controls-captions-expected.txt: Updated.
  • media/video-controls-captions.html: Updated.
8:01 PM Changeset in webkit [141530] by rniwa@webkit.org
  • 3 edits
    4 moves in trunk/Tools

buildbot should not rely on webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=107379

Reviewed by Eric Seidel.

Move all Python files used in buildbot configuration into BuildSlaveSupport directory.
Once this patch is landed, we can stop restarting the master on webkitpy changes.

  • BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
  • BuildSlaveSupport/build.webkit.org-config/htdigestparser.py: Copied from Tools/Scripts/webkitpy/common/net/htdigestparser.py.
  • BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py: Copied from Tools/Scripts/webkitpy/common/net/htdigestparser_unittest.py.
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • BuildSlaveSupport/build.webkit.org-config/wkbuild.py: Copied from Tools/Scripts/webkitpy/common/config/build.py.
  • BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/build_unittest.py.

(ShouldBuildTest.test_should_build):

  • Scripts/webkitpy/common/config/build.py: Removed.
  • Scripts/webkitpy/common/config/build_unittest.py: Removed.
  • Scripts/webkitpy/common/net/htdigestparser.py: Removed.
  • Scripts/webkitpy/common/net/htdigestparser_unittest.py: Removed.
7:57 PM Changeset in webkit [141529] by commit-queue@webkit.org
  • 10 edits in trunk

REGRESSION(r140231): media track layout tests crashing
​https://bugs.webkit.org/show_bug.cgi?id=107579

Patch by Dima Gorbik <​dgorbik@apple.com> on 2013-01-31
Reviewed by Eric Carlson.

Source/WebCore:

We were using non-standard element names with HTMLElement, which made v8 try to cast
WebVTTElements to HTMLUnknownElements which was not possible. Subclassing Element instead
of HTMLElement, though this requires building HTMLElements from WebVTTElements for creating
a DOM tree. The code has been refactored to move WebVTT node type to QuialifiedName mappings
inside the WebVTTElement class. All WebVTTElements in the shadow dom tree now are in the
namespace defined by 'NullAtom'. This prevents regular styles from being applied to <b>, <i>
and similar tags. Those have to be styled separately without reusing existing QualifiedNames
and their styles. ​https://bugs.webkit.org/show_bug.cgi?id=107214

Unskipping tests to cover this.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::canShareStyleWithElement):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::copyWebVTTNodeToDOMTree):
(WebCore::TextTrackCue::getCueAsHTML):
(WebCore::TextTrackCue::createCueRenderingTree):
(WebCore::TextTrackCue::markFutureAndPastNodes):

  • html/track/TextTrackCue.h:

(WebCore::TextTrackCue::cueShadowPseudoId):

  • html/track/WebVTTElement.cpp:

(WebCore::nodeTypeToTagName): get a QualifiedName to use in the shadow DOM tree.
(WebCore::WebVTTElement::WebVTTElement):
(WebCore::WebVTTElement::create):
(WebCore::WebVTTElement::cloneElementWithoutAttributesAndChildren):
(WebCore::WebVTTElement::createEquivalentHTMLElement): create an HTMLElement to use in the DOM tree.

  • html/track/WebVTTElement.h:

(WebCore::WebVTTElement::setWebVTTNodeType):
(WebCore::WebVTTElement::webVTTNodeType):
(WebCore::WebVTTElement::isPastNode):
(WebCore::WebVTTElement::setIsPastNode):
(WebCore::WebVTTElement::voiceAttributeName):

  • html/track/WebVTTParser.cpp:

(WebCore::tokenToNodeType): determine a WebVTT node type for the token.
(WebCore::WebVTTParser::constructTreeFromToken):

LayoutTests:

  • platform/chromium/TestExpectations:
7:52 PM Changeset in webkit [141528] by rafael.lobo@openbossa.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Another attempt to fix build after recent WebKit2 changes
​https://bugs.webkit.org/show_bug.cgi?id=108548

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::processMessage): Change Deque to Vector and do similar
logic as on patch for ​https://bugs.webkit.org/show_bug.cgi?id=108517
(CoreIPC::Connection::open):
(CoreIPC::Connection::setShouldCloseConnectionOnProcessTermination):

  • Platform/qt/WorkQueueQt.cpp: Reflect changes on Qt WorkQueue to increase ref

count when the execution is started and decrease it when the work item is deleted,
following the logic on ​https://bugs.webkit.org/show_bug.cgi?id=108544
(WorkQueue::WorkItemQt::~WorkItemQt):
(WorkQueue::WorkItemQt::execute):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getPluginPath): This function was moved from WebProcessProxy but
mac specific code was not protected properly: ​https://bugs.webkit.org/show_bug.cgi?id=108407

7:51 PM Changeset in webkit [141527] by morrita@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking a failing test.

  • platform/chromium/TestExpectations:
7:28 PM Changeset in webkit [141526] by tkent@chromium.org
  • 13 edits
    2 copies in branches/chromium/1364

Merge 141195

INPUT_MULTIPLE_FIELDS_UI: The content should not overflow the <input> boundary
​https://bugs.webkit.org/show_bug.cgi?id=108069

Reviewed by Hajime Morita.

Source/WebCore:

To avoid the overflow, we do:
A) Specify overflow:hidden to <input>.

However, we need to make sub-fields and buttons workable even if the
width is smaller than the intrinsic size. So, we do:
B) Make DateTimeEditElement shrinkable, and
C) Make the sub-fields scrollable horizontally like input[type=text].

To achieve B, we need to remove -webkit-date-and-time-container (D)
because width property for <input> can shrink only the direct child
elements.

Tests: fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html
and new test cases in fast/forms/date/date-appearance-basic.html.

  • css/html.css:

(input[type="date"]):
Change -webkit-align-items value. (D)
Specify overflow:hidden. (A)
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input::-webkit-datetime-edit):
Add min-width:0 (B), and overflow:hidden. (C)
Remove unnecessary white-space:pre because of white-space:nowrap below.
(input::-webkit-datetime-edit-fields-wrapper):
Added. This is the child of -webkit-datetime-edit, and contains
sub-fields. (C)

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
Remove -webkit-date-and-time-container, and append DateTimeEditElement,
spin button, and picker indicator element to the ShadowRoot. (D)
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldApplyLocaleDirection):
<input> for multiple fields UI should have the direction of the browser
locale. This is a replacement of the code for dir attribute in
updateInnerTextValue below. (D)
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue):
Remove the code to set dir= to -webkit-date-and-time-container.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType):
Declare shouldApplyLocaleDirection. (D)

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
Calls setHasCustomCallbacks for customStyleForRenderer. (D)
(WebCore::HTMLInputElement::customStyleForRenderer):
Set direction to RenderStyle if shouldApplyLocaleDirection is true. This
is a replacement of the dir setting code in
BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue. (D)

  • html/HTMLInputElement.h:

(HTMLInputElement): Declare customStyleForRenderer. (D)

  • html/InputType.cpp:

(WebCore::InputType::shouldApplyLocaleDirection):
Add default implmentation of shouldApplyLocaleDirection. (D)

  • html/InputType.h:

(InputType): Declare shouldApplyLocaleDirection. (D)

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitLiteral):
Add elements to -webkit-datetime-edit-fields-wrapper element. (C)
(WebCore::DateTimeEditElement::fieldsWrapperElement):
A helper to get -webkit-datetime-edit-fields-wrapper element. (C)
(WebCore::DateTimeEditElement::addField):
Add elements to -webkit-datetime-edit-fields-wrapper element. (C)
(WebCore::DateTimeEditElement::customStyleForRenderer):

  • Iterate over children of -webkit-datetime-edit-fields-wrapper element. (C)
  • Set width property instead of min-width. (B)

(WebCore::DateTimeEditElement::layout):

  • Prepare -webkit-datetime-edit-fields-wrapper element. (C)
  • Handle children of -webkit-datetime-edit-fields-wrapper element. (C)
  • Need to do style recalc because child structure is changed. (C)
  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Declare fieldsWrapperElement. (C)

LayoutTests:

  • fast/forms/date/date-appearance-basic-expected.txt:
  • fast/forms/date/date-appearance-basic.html:

Add test cases for small width and small height.

  • fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html:

Update the code because of shadow tree structure change.

  • fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html:

Added.

  • fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll-expected.txt:

Added.

  • platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
  • platform/chromium/TestExpectations:
    • date-appearance-basic.html: New test cases are added.
    • *-appearance-pseudo-element.html: :before :after position is slightly changed because of the -webkit-align-items change.
    • suggestion-picker/*.html: RTL behavior is changed. The direction of suggestion pickers matches to the direction of the input content (browser locale).

TBR=​tkent@chromium.org
BUG=crbug.com/172029
Review URL: ​https://codereview.chromium.org/12159003

7:20 PM Changeset in webkit [141525] by commit-queue@webkit.org
  • 16 edits in trunk

Unreviewed, rolling out r141479.
​http://trac.webkit.org/changeset/141479
​https://bugs.webkit.org/show_bug.cgi?id=108564

breaks chromium test (Requested by morrita on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-31

Source/WebCore:

  • editing/Editor.cpp:
  • editing/Editor.h:

(Editor):

Source/WebKit/chromium:

  • public/WebViewClient.h:
  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::respondToChangedSelection):

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::respondToChangedSelection):

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::respondToChangedSelection):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateSelectionForInputManager]):

Source/WebKit/win:

  • WebView.cpp:

(WebView::updateSelectionForIME):

LayoutTests:

  • platform/chromium/TestExpectations:
7:17 PM Changeset in webkit [141524] by commit-queue@webkit.org
  • 43 edits in trunk/Source

Rename from parentOrHost* to parentOrShadowHost* in Node.h.
​https://bugs.webkit.org/show_bug.cgi?id=108308

Source/WebCore:

Patch by Changhun Kang <​temoochin@company100.net> on 2013-01-31
Reviewed by Dimitri Glazkov.

No new tests. No change in behavior.

Source/WebKit2:

Patch by Changhun Kang <​temoochin@company100.net> on 2013-01-31
Reviewed by Dimitri Glazkov.

7:01 PM Changeset in webkit [141523] by alecflett@chromium.org
  • 25 edits
    12 deletes in trunk/Source

IndexedDB: remove old transaction backend bootstrap code
​https://bugs.webkit.org/show_bug.cgi?id=103923

Reviewed by Dimitri Glazkov.

Source/WebCore:

Finally remove all leftover code from the IndexedDB "giant
async refactor of 2012." This includes removal of all
IDBTransaction* interfaces that were shared between
the frontend and backend and a few straggling methods
like onUpgradeNeeded and onSuccess that were left from
the last stage of refactoring.

  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore):
(WebCore::IDBDatabaseBackendImpl::metadata):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(WebCore):
(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore):

  • Modules/indexeddb/IDBTransaction.h:

(WebCore):
(IDBTransaction):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore):
(IDBTransactionBackendImpl):

  • Modules/indexeddb/IDBTransactionBackendInterface.h: Removed.
  • Modules/indexeddb/IDBTransactionCallbacks.h: Removed.
  • Modules/indexeddb/IDBTransactionCoordinator.h:

(WebCore):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Remove all deprecated WebKit APIs from
the IDB backend.

  • WebKit.gyp:
  • public/WebIDBCallbacks.h:

(WebKit):

  • public/WebIDBDatabase.h:

(WebKit):

  • public/WebIDBTransaction.h: Removed.
  • public/WebIDBTransactionCallbacks.h: Removed.
  • src/AssertMatchingEnums.cpp:
  • src/IDBCallbacksProxy.cpp:
  • src/IDBDatabaseBackendProxy.cpp:
  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/IDBTransactionBackendProxy.cpp: Removed.
  • src/IDBTransactionBackendProxy.h: Removed.
  • src/IDBTransactionCallbacksProxy.cpp: Removed.
  • src/IDBTransactionCallbacksProxy.h: Removed.
  • src/WebIDBCallbacksImpl.cpp:
  • src/WebIDBDatabaseImpl.cpp:

(WebKit):

  • src/WebIDBDatabaseImpl.h:

(WebKit):
(WebIDBDatabaseImpl):

  • src/WebIDBTransactionCallbacksImpl.cpp: Removed.
  • src/WebIDBTransactionCallbacksImpl.h: Removed.
  • src/WebIDBTransactionImpl.cpp: Removed.
  • src/WebIDBTransactionImpl.h: Removed.
  • tests/IDBAbortOnCorruptTest.cpp:
  • tests/IDBDatabaseBackendTest.cpp:
6:44 PM Changeset in webkit [141522] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r141349.
​http://trac.webkit.org/changeset/141349
​https://bugs.webkit.org/show_bug.cgi?id=108422

"yet another windows ews fix needed" (Requested by lforschler
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-31

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

6:42 PM Changeset in webkit [141521] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Windows build fix.

6:41 PM Changeset in webkit [141520] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Use TouchEvent.targetTouches rather than TouchEvent.touches since the order of Touches in TouchList is not guaranteed.
​https://bugs.webkit.org/show_bug.cgi?id=108426

Reviewed by Dimitri Glazkov.

Neat fix for LayoutTest in ​http://trac.webkit.org/changeset/141054.

In this LayoutTest context, the length of touchEvent.touches is 2.
The Touch order in TouchList is not guaranteed. Therefore
touchEvent.touches[0] can be another touch. Rather, we should use
touchEvent.targetTouches here since its length is 1 in this context.

  • fast/dom/shadow/touch-event.html:
6:05 PM Changeset in webkit [141519] by commit-queue@webkit.org
  • 10 edits in trunk

Source/WebKit/chromium: [Chromium] Select multi-word misspelling on context click
​https://bugs.webkit.org/show_bug.cgi?id=108509

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-01-31
Reviewed by Tony Chang.

  • src/ContextMenuClientImpl.cpp:

(WebKit):
(WebKit::selectMisspellingAsync): Added utility function to get the misspelling for asynchronous spellcheck.
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Select multi-word misspelling on context click.

Tools: [Chromium] Suggest 'uppercase' for multi-word misspelling 'upper case'
​https://bugs.webkit.org/show_bug.cgi?id=108509

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-01-31
Reviewed by Tony Chang.

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(append): Added utility function to append WebString to WebVector.
(MockSpellCheck::fillSuggestionList): Suggest 'uppercase' for misspelling 'upper case'.

LayoutTests: [Chromium] Expect spellcheck to select multi-word misspelling on context click
​https://bugs.webkit.org/show_bug.cgi?id=108509

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-01-31
Reviewed by Tony Chang.

  • editing/spelling/spelling-exactly-selected-multiple-words.html: Check spelling suggestion for multi-word misspelling.
  • editing/spelling/spelling-should-select-multiple-words.html: Check spelling suggestion for multi-word misspelling.
  • editing/spelling/spelling-exactly-selected-multiple-words-expected.txt:
  • editing/spelling/spelling-should-select-multiple-words-expected.txt:
  • platform/chromium/TestExpectations: Expect spellcheck to select multi-word misspelling on context click
5:57 PM Changeset in webkit [141518] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r141502.
​http://trac.webkit.org/changeset/141502
​https://bugs.webkit.org/show_bug.cgi?id=108441

Hit assert in SVGElementInstance

  • bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):

  • dom/EventTarget.idl:
  • svg/SVGElementInstance.idl:
5:48 PM Changeset in webkit [141517] by ojan@chromium.org
  • 7 edits in trunk/Source/WebCore

Assert that computePreferredLogicalWidths never calls setNeedsLayout
​https://bugs.webkit.org/show_bug.cgi?id=108539

Reviewed by Tony Chang.

computePreferredLogicalWidths should only set m_minPreferredLogicalWidth
and m_maxPreferredLogicalWidth. It shouldn't have other side-effects.
This is take 2 after this was rolled out because it was missing the guards
in RenderCounter/RenderQuote.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::minPreferredLogicalWidth):
(WebCore::RenderBox::maxPreferredLogicalWidth):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::computePreferredLogicalWidths):

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::computePreferredLogicalWidths):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::computePreferredLogicalWidths):

5:39 PM Changeset in webkit [141516] by inferno@chromium.org
  • 25 edits in trunk/Source/WebCore

Use ASSERT_WITH_SECURITY_IMPLICATION to catch bad casts in DOM
​https://bugs.webkit.org/show_bug.cgi?id=108490

Reviewed by Eric Seidel.

  • dom/ContainerNode.h:

(WebCore::toContainerNode):

  • dom/Element.h:

(WebCore::toElement):

  • dom/ShadowRoot.h:

(WebCore::toShadowRoot):

  • dom/Text.h:

(WebCore::toText):

  • html/HTMLElement.h:

(HTMLElement):
(WebCore::toHTMLElement):

  • html/HTMLFrameOwnerElement.h:

(WebCore::toFrameOwnerElement):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::hasMediaControls):

  • html/HTMLTemplateElement.cpp:

(WebCore::toHTMLTemplateElement):

  • html/HTMLUnknownElement.h:

(WebCore::toHTMLUnknownElement):

  • html/shadow/InsertionPoint.h:

(WebCore::toInsertionPoint):

  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::mediaControlElementType):

  • html/shadow/MediaControls.h:

(WebCore::toMediaControls):

  • html/shadow/SliderThumbElement.h:

(WebCore::toSliderThumbElement):

  • html/shadow/TextControlInnerElements.h:

(WebCore::toInputFieldSpeechButtonElement):

  • html/shadow/TextFieldDecorationElement.h:

(WebCore::toTextFieldDecorationElement):

  • html/track/WebVTTElement.h:

(WebCore::toWebVTTElement):

  • mathml/MathMLElement.h:

(WebCore::toMathMLElement):

  • page/scrolling/ScrollingStateFixedNode.h:

(WebCore::toScrollingStateFixedNode):

  • page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::toScrollingStateScrollingNode):

  • page/scrolling/ScrollingStateStickyNode.h:

(WebCore::toScrollingStateStickyNode):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

  • rendering/svg/SVGResources.cpp:

(WebCore::registerPendingResource):
(WebCore::SVGResources::buildCachedResources):

  • svg/SVGElement.h:

(WebCore::toSVGElement):

  • svg/SVGStyledElement.h:

(WebCore::toSVGStyledElement):

5:34 PM Changeset in webkit [141515] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Provide a sensible default architecture when building on iOS SDKs
​https://bugs.webkit.org/show_bug.cgi?id=108395

Patch by David Farler <​dfarler@apple.com> on 2013-01-31
Reviewed by Joseph Pecoraro.

  • Scripts/webkitdirs.pm:

(determineArchitecture):
Check for iphoneos and iphonesimulator SDKs for a default arch.
(determineXcodeSDK): Added.
(xcodeSDK): Added.
(XcodeOptions): Add ARCHS= if defined.

5:32 PM Changeset in webkit [141514] by commit-queue@webkit.org
  • 6 edits
    12 adds in trunk

Fix rubber-band effect on non-scrollable pages
​https://bugs.webkit.org/show_bug.cgi?id=107611

Source/WebCore:

Patch by Christopher Cameron <​ccameron@chromium.org> on 2013-01-31
Reviewed by Antonio Gomes.

Handle a FrameView's wheel event even if it is not scrollable
because Chrome relies on handling these wheel events for the
over-scroll rubber-band effect.

This had been removed in r138378
[EFL][WK2] Never create WebCore scrollbars for EFL/WK2
by ​kenneth@chromium.org

Tests: platform/chromium/rubberbanding/wheelevent-overhang-e.html

platform/chromium/rubberbanding/wheelevent-overhang-n.html
platform/chromium/rubberbanding/wheelevent-overhang-s.html
platform/chromium/rubberbanding/wheelevent-overhang-w.html

  • page/FrameView.cpp:

(WebCore::FrameView::wheelEvent):

Tools:

Add mouseWheelBegin function to EventSender to allow
event-based rubber-banding tests.

Patch by Christopher Cameron <​ccameron@chromium.org> on 2013-01-31
Reviewed by Antonio Gomes.

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::mouseDragBegin):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(EventSender):

LayoutTests:

Patch by Christopher Cameron <​ccameron@chromium.org> on 2013-01-31
Reviewed by Antonio Gomes.

  • platform/chromium/rubberbanding/event-overhang-e-expected.png: Added.
  • platform/chromium/rubberbanding/event-overhang-e-expected.txt: Added.
  • platform/chromium/rubberbanding/event-overhang-e.html: Added.
  • platform/chromium/rubberbanding/event-overhang-n-expected.png: Added.
  • platform/chromium/rubberbanding/event-overhang-n-expected.txt: Added.
  • platform/chromium/rubberbanding/event-overhang-n.html: Added.
  • platform/chromium/rubberbanding/event-overhang-s-expected.png: Added.
  • platform/chromium/rubberbanding/event-overhang-s-expected.txt: Added.
  • platform/chromium/rubberbanding/event-overhang-s.html: Added.
  • platform/chromium/rubberbanding/event-overhang-w-expected.png: Added.
  • platform/chromium/rubberbanding/event-overhang-w-expected.txt: Added.
  • platform/chromium/rubberbanding/event-overhang-w.html: Added.
5:25 PM Changeset in webkit [141513] by enrica@apple.com
  • 5 edits in trunk/Source

Mac: Editor::baseWritingDirectionForSelectionStart should return WritingDirection instead of NSWritingDirection.
​https://bugs.webkit.org/show_bug.cgi?id=108519.

Reviewed by Sam Weinig.

Source/WebCore:

No new tests, no change in behavior.

There is no need to use AppKit types here.
baseWritingDirectionForSelectionStart now returns WritingDirection and
WebHTMLView toggleWritingDirection has been modified accordingly.

  • editing/Editor.h:
  • editing/mac/EditorMac.mm:

(WebCore::Editor::baseWritingDirectionForSelectionStart):

Source/WebKit/mac:

There is no need to use AppKit types here.
baseWritingDirectionForSelectionStart now returns WritingDirection and
WebHTMLView toggleWritingDirection has been modified accordingly.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView toggleBaseWritingDirection:]):

5:23 PM Changeset in webkit [141512] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[chromium] Notify the WebWidget when the WebViewHost is about to tear down compositing support
​https://bugs.webkit.org/show_bug.cgi?id=108518

Patch by James Robinson <​jamesr@chromium.org> on 2013-01-31
Reviewed by Adrienne Walker.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::shutdown):

5:21 PM Changeset in webkit [141511] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Pass an Isolate to GetTemplate() in CodeGeneratorV8.pm
​https://bugs.webkit.org/show_bug.cgi?id=108445

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateNormalAttrGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::TestActiveDOMObjectV8Internal::TestActiveDOMObjectDomainSafeFunctionSetter):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):

5:16 PM Changeset in webkit [141510] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

StorageManager should be ref-counted
​https://bugs.webkit.org/show_bug.cgi?id=108553

Reviewed by Beth Dakin.

It's likely we'd want to have the storage manager outlive its context at times, so make it
reference counted.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::create):
(WebKit):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/WebContext.h:

(WebContext):

5:12 PM Changeset in webkit [141509] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Clean up Dictionary::get() by removing redundant FindInstanceInPrototypeChain()
​https://bugs.webkit.org/show_bug.cgi?id=108443

Reviewed by Adam Barth.

In Dictionary::get(), wrapper->FindInstanceInPrototypeChain(V8XXX::GetTemplate())
is unnecessary for DOM wrappers other than DOMWindow. For wrappers other than
DOMWindow, we can simply use V8XXX::HasInstance(wrapper).

Tests: fast/events/constructors/*

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

5:10 PM Changeset in webkit [141508] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r141136): Apple's internal PLT test suite doesn't finish
​https://bugs.webkit.org/show_bug.cgi?id=108380

Mark another test whose results depend on main resource caching being enabled as failing until
main resource caching can be re-enabled on mac.

  • platform/mac/TestExpectations:
5:05 PM Changeset in webkit [141507] by jamesr@google.com
  • 2 edits in branches/chromium/1364/Source/WebCore

Merge 141226

Scrollbar and scroll corner composited layers positioned incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=108255

Patch by James Robinson <​jamesr@chromium.org> on 2013-01-29
Reviewed by Simon Fraser.

ScrollView::updateScrollbars() needs to update the overflow controls composited layers if scrollbars are added
or removed. It was doing this by recording on entry to the function if it had horizontal or vertical scrollbars
and then comparing that to m_horizontal/verticalScrollbar on exit. Unfortunately updateScrollbars is recursive
and exits without running the postamble code when nested on the callstack. As a result, scrollbars may be
added or removed several times during the recursion, possibly leaving the overflow control layers in an
inconsistent state, while ending up with the same set of scrollbars.

This changes the "has anything changed" logic to only compare local state (hasXXXScrollbar vs
newHasXXXScrollbar) so changes in recursive calls are not considered.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

TBR=​jamesr@chromium.org
BUG=170264
Review URL: ​https://codereview.chromium.org/12084101

4:52 PM Changeset in webkit [141506] by timothy_horton@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Land failing baselines for Lion after r141333. Unreviewed.
​https://bugs.webkit.org/show_bug.cgi?id=108523

  • platform/mac-lion/fast/canvas/canvas-composite-alpha-expected.txt: Added.
4:48 PM Changeset in webkit [141505] by jchaffraix@webkit.org
  • 5 edits
    4 adds in trunk

[CSS Grid Layout] Support implicit rows and columns
​https://bugs.webkit.org/show_bug.cgi?id=103573

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/css-grid-layout/implicit-columns-auto-resolution.html

fast/css-grid-layout/implicit-rows-auto-resolution.html

This change makes us properly initialize our GridTrack vectors's size
so that we can safely query any items during layout.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::gridTrackSize):
Added this helper function to return the track size from the grid
element's columns' / rows' definitions or the default value.

(WebCore::RenderGrid::maximumIndexInDirection):
Added this helper function to get the maximum index in a direction
taking grid item's implicit indexes into account.

(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Changed the funtion to not append the new tracks as we are properly
sized now.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):
Updated these functions to use the new helper functions.

(WebCore::RenderGrid::layoutGridItems):
Changed this function to size both vectors when initializing them.
Also removed an unneeded bounds check as it shouldn't be needed anymore.

  • rendering/RenderGrid.h:

Added the new helper functions.

  • rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::GridTrackSize):
Added a constructor taking a LengthType.

LayoutTests:

  • fast/css-grid-layout/implicit-columns-auto-resolution-expected.txt: Added.
  • fast/css-grid-layout/implicit-columns-auto-resolution.html: Added.
  • fast/css-grid-layout/implicit-rows-auto-resolution-expected.txt: Added.
  • fast/css-grid-layout/implicit-rows-auto-resolution.html: Added.
4:37 PM Changeset in webkit [141504] by jberlin@webkit.org
  • 7 edits in trunk/Source

Rolling out r141407 because it is causing crashes under
WTF::TCMalloc_Central_FreeList::FetchFromSpans() in Release builds.

Source/JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

Source/WTF:

  • wtf/Deque.h:

(WTF::::expandCapacity):

  • wtf/FastMalloc.cpp:
  • wtf/FastMalloc.h:

(WTF):

  • wtf/Vector.h:

(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):

4:37 PM Changeset in webkit [141503] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] fast/css/relative-positioned-block-crash.html is intermittently crashing
​https://bugs.webkit.org/show_bug.cgi?id=108200

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2013-01-31
Reviewed by Martin Robinson.

Source/WebCore:

Getting the Position of a PseudoElement now triggers an assertion.
This can occur when clicking on empty space in a render block.
Looking to the unignored parent's node (and passing that accessible
object on in a signal to Assistive Technologies) seems like the most
reasonable thing to do here.

No new tests; instead skipping two tests that were crashing as a result.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(objectFocusedAndCaretOffsetUnignored):

LayoutTests:

Unskip two crashing tests having fixed the underlying bug.

  • platform/gtk/TestExpectations:
4:25 PM Changeset in webkit [141502] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Simplify CodeGeneratorV8.pm by using InheritsExtendedAttribute("EventTarget")
​https://bugs.webkit.org/show_bug.cgi?id=108441

Reviewed by Adam Barth.

A complicated condition in GetInternalFields() can be simplified
by using InheritsExtendedAttribute("EventTarget").

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):

  • dom/EventTarget.idl: Added [EventTarget] which should have been added.
  • svg/SVGElementInstance.idl: Ditto.
3:59 PM Changeset in webkit [141501] by ojan@chromium.org
  • 3 edits
    2 moves
    2 deletes in trunk/LayoutTests

Rebaseline after r141459.

  • fast/multicol/shrink-to-column-height-for-pagination-expected.png: Renamed from LayoutTests/platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.png.
  • fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Renamed from LayoutTests/platform/chromium/fast/multicol/shrink-to-column-height-for-pagination-expected.txt.
  • platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
  • platform/gtk/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Removed.
  • platform/gtk/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
  • platform/qt/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Removed.
3:51 PM Changeset in webkit [141500] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

Source/WebCore: Quadratic and bezier curves with coincident endpoints rendered incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=105650

Patch by Youenn Fablet <​youennf@gmail.com> on 2013-01-31
Reviewed by Kenneth Russell.

Tests: fast/canvas/canvas-bezier-same-endpoint.html

fast/canvas/canvas-quadratic-same-endpoint.html

  • html/canvas/CanvasPathMethods.cpp:

(WebCore::CanvasPathMethods::quadraticCurveTo):
(WebCore::CanvasPathMethods::bezierCurveTo):

LayoutTests: Quadratic and bezier curves with coincident endpoints rendered incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=105650
Modified TestExpectations for Mac, efl and Qt platforms as quadratic curves
may not be rendered correctly
(see ​https://bugs.webkit.org/show_bug.cgi?id=107118)

Patch by Youenn Fablet <​youennf@gmail.com> on 2013-01-31
Reviewed by Kenneth Russell.

  • fast/canvas/canvas-bezier-same-endpoint-expected.txt: Added.
  • fast/canvas/canvas-bezier-same-endpoint.html: Added.
  • fast/canvas/canvas-quadratic-same-endpoint-expected.txt: Added.
  • fast/canvas/canvas-quadratic-same-endpoint.html: Added.
  • platform/efl/TestExpectations: Skipped quad test
  • platform/mac/TestExpectations: Skipped quad test
  • platform/qt/TestExpectations: Skipped quad test
3:49 PM Changeset in webkit [141499] by mark.lam@apple.com
  • 4 edits
    1 move in trunk/Source

Abstraction for hiding enum class.
​https://bugs.webkit.org/show_bug.cgi?id=108533

Reviewed by Anders Carlsson.

../WebCore:

No new tests.

  • Modules/webdatabase/DatabaseError.h:

(WebCore::ENUM_CLASS_BEGIN):

../WTF:

  • wtf/Compiler.h:
  • wtf/EnumClass.h: Copied from Source/WTF/wtf/TypeSafeEnum.h.

(WTF::EnumClass::EnumClass):
(WTF::EnumClass::operator==):
(WTF::EnumClass::operator!=):
(WTF::EnumClass::operator<):
(WTF::EnumClass::operator<=):
(WTF::EnumClass::operator>):
(WTF::EnumClass::operator>=):

  • wtf/TypeSafeEnum.h: Removed.
3:46 PM Changeset in webkit [141498] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Gtk] drag and drop has black background without composition
​https://bugs.webkit.org/show_bug.cgi?id=108376

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-01-31
Reviewed by Martin Robinson.

Use gtk_drag_set_icon_surface (or gtk_drag_set_icon_pixbuf) when the
screen is not composited. That way, drag window will be decomposited
and rendered transparent with Xshape.

To determine which parts of the window must be transparent, gtk checks
if a pixel is more than 50% opaque. With dissolveDragImageToFraction,
all pixels are made 25% transparent. With antialiasing, opacity goes
below the threshold for some pixels, which makes the resulting image
messy. So, we need to skip dissolveDragImageToFraction when we use
gtk_drag_set_icon_surface.

  • platform/gtk/DragIcon.cpp:

(WebCore::DragIcon::DragIcon):
(WebCore::DragIcon::~DragIcon):
(WebCore::DragIcon::setImage):
(WebCore::DragIcon::useForDrag):

  • platform/gtk/DragIcon.h:

(DragIcon):

  • platform/gtk/DragImageGtk.cpp:

(WebCore::dissolveDragImageToFraction):

3:43 PM Changeset in webkit [141497] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

WorkQueue should be a ref-counted class
​https://bugs.webkit.org/show_bug.cgi?id=108544

Reviewed by Sam Weinig.

Make WorkQueue a ref-counted class that's implicitly ref()'d when dispatching a function to it, and then
implicitly deref()'d when the function is done executing. This matches the behavior of dispatch queues,
and ensures that the WorkQueue object won't go away while dispatched functions are running.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::Connection):
(CoreIPC::Connection::~Connection):
(CoreIPC::Connection::addQueueClient):
(CoreIPC::Connection::removeQueueClient):
(CoreIPC::Connection::invalidate):
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
(CoreIPC::Connection::connectionDidClose):

  • Platform/CoreIPC/Connection.h:

(Connection):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::createDataAvailableSource):
(CoreIPC::Connection::open):
(CoreIPC::Connection::initializeDeadNameSource):

  • Platform/WorkQueue.cpp:

(WorkQueue::create):
(WorkQueue::WorkQueue):
(WorkQueue::~WorkQueue):

  • Platform/WorkQueue.h:

(WorkQueue):

  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):

  • Shared/ChildProcess.cpp:

(WebKit::didCloseOnConnectionWorkQueue):

  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::processLauncherWorkQueue):
(WebKit::ProcessLauncher::ProcessLauncher):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::pluginWorkQueue):
(WebKit::WebProcessProxy::getPlugins):

3:38 PM Changeset in webkit [141496] by fmalita@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed gardening.

WebViewTest.SetCompositionFromExistingText failing after r141479.

  • tests/WebViewTest.cpp:
3:26 PM Changeset in webkit [141495] by rafael.lobo@openbossa.org
  • 7 edits in trunk/Source/WebKit2

[Qt][WK2] Fix build after removal of MessageID.h
​https://bugs.webkit.org/show_bug.cgi?id=108534

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::MessageInfo::MessageInfo):
(CoreIPC::MessageInfo::setMessageBodyIsOutOfLine):
(CoreIPC::MessageInfo::isMessageBodyIsOutOfLine):
(MessageInfo):
(CoreIPC::Connection::processMessage):
(CoreIPC::Connection::sendOutgoingMessage):

  • Target.pri:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
  • UIProcess/DrawingAreaProxy.cpp:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
  • WebProcess/soup/WebSoupRequestManager.cpp:
3:18 PM Changeset in webkit [141494] by tonyg@chromium.org
  • 14 edits
    2 adds in trunk/Source/WebCore

Begin to make XSSAuditor thread aware
​https://bugs.webkit.org/show_bug.cgi?id=108394

Reviewed by Adam Barth.

This patch moves the parts of filterToken() that depend on Frame, Document, etc. to a delegate class.
The new didBlockScript delegate method is invoked with the resulting DidBlockScriptRequest which will
be owned by the CompactHTMLToken in the threaded case.

This is just the first step as there is more to do to make XSSAuditor thread safe.

No new tests because covered by existing tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::pumpTokenizer):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::processTokensFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h:

(WebCore):
(XSSAuditor):

  • html/parser/XSSAuditorDelegate.cpp: Added.

(WebCore):
(WebCore::XSSAuditorDelegate::XSSAuditorDelegate):
(WebCore::XSSAuditorDelegate::didBlockScript):

  • html/parser/XSSAuditorDelegate.h: Added.

(WebCore):
(DidBlockScriptRequest):
(WebCore::DidBlockScriptRequest::create):
(WebCore::DidBlockScriptRequest::DidBlockScriptRequest):
(XSSAuditorDelegate):

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::pumpTokenizer):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h:

(WebCore):
(XSSAuditor):

  • html/parser/XSSAuditorDelegate.cpp: Added.

(WebCore):
(WebCore::XSSAuditorDelegate::XSSAuditorDelegate):
(WebCore::XSSAuditorDelegate::didBlockScript):

  • html/parser/XSSAuditorDelegate.h: Added.

(WebCore):
(DidBlockScriptRequest):
(WebCore::DidBlockScriptRequest::create):
(WebCore::DidBlockScriptRequest::DidBlockScriptRequest):
(XSSAuditorDelegate):

3:13 PM Changeset in webkit [141493] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Assertion failure in WebResourceLoadScheduler::remove when loading .webarchives
<rdar://problem/12888145> and ​https://bugs.webkit.org/show_bug.cgi?id=108520

Reviewed by Alexey Proskuryakov.

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad): Even if it isn't to be scheduled with the

NetworkProcess, still add this ResourceLoader to the scheduler's records.

3:12 PM Changeset in webkit [141492] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

CSS3's vh attribute is not adjusting while browser resizes
​https://bugs.webkit.org/show_bug.cgi?id=86418

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-01-31
Reviewed by Antti Koivisto.

Source/WebCore:

Elements with viewport percentage units needs layout whenever
viewport size changes. Check for viewport percentage unit
was missing for height.

Test: css3/viewport-percentage-lengths/vh-resize.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateBlockChildDirtyBitsBeforeLayout):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::hasViewportPercentageLogicalHeight): Check if style
is specified in viewport percentage units.
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout): Elements with viewport percentage units
needs relayout when viewport size changes.

LayoutTests:

Added test to check element with vh units gets resized when
viewport height is increased or decreased.

  • css3/viewport-percentage-lengths/vh-resize-expected.html: Added.
  • css3/viewport-percentage-lengths/vh-resize.html: Added.
2:56 PM Changeset in webkit [141491] by psolanki@apple.com
  • 2 edits in trunk/Tools

DumpRenderTree should put NSSound calls inside USE(APPKIT)
​https://bugs.webkit.org/show_bug.cgi?id=108499

Reviewed by Andy Estes.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree):

2:38 PM CoordinatedGraphicsSystem edited by luxtella@company100.net
(diff)
2:36 PM CoordinatedGraphicsSystem edited by luxtella@company100.net
(diff)
2:33 PM Changeset in webkit [141490] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Objective-C API: JSContext exception property causes reference cycle
​https://bugs.webkit.org/show_bug.cgi?id=107778

Reviewed by Darin Adler.

JSContext has a (retain) JSValue * exception property which, when non-null, creates a
reference cycle (since the JSValue * holds a strong reference back to the JSContext *).

  • API/JSContext.mm: Instead of JSValue *, we now use a plain JSValueRef, which eliminates the reference cycle.

(-[JSContext initWithVirtualMachine:]):
(-[JSContext setException:]):
(-[JSContext exception]):

2:31 PM Changeset in webkit [141489] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

TextAutosizing: refactor the cluster related method parameters into a single struct.
​https://bugs.webkit.org/show_bug.cgi?id=108384

This anticipates adding more cluster related information in the following patches.

Patch by Anton Vayvod <​avayvod@chromium.org> on 2013-01-31
Reviewed by Kenneth Rohde Christiansen.

Just a refactoring so no new tests.

  • rendering/TextAutosizer.cpp: define the new struct and pass it to every method instead of

a cluster and its descendant block containing all text.

  • rendering/TextAutosizer.h: change method prototypes to receive the new struct

as a parameter defining an autosizing cluster.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizingClusterInfo::TextAutosizingClusterInfo):
(TextAutosizingClusterInfo):
(WebCore):
(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::isAutosizingCluster):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):

  • rendering/TextAutosizer.h:

(WebCore):

2:28 PM Changeset in webkit [141488] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

Unreviewed trivial Unix build fix.

Use Vector<> instead of Deque<> when iterating
over m_attachments in the USE(UNIX_DOMAIN_SOCKETS)
case.

  • Platform/CoreIPC/ArgumentDecoder.cpp:
2:23 PM Changeset in webkit [141487] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline after r141459.

  • platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
2:17 PM Changeset in webkit [141486] by bweinstein@apple.com
  • 16 edits in trunk

Add a call to the page UI client to determine if a plug-in should load
​https://bugs.webkit.org/show_bug.cgi?id=108407
<rdar://problem/13066332>

Source/WebKit2:

Reviewed by Anders Carlsson.

This patch adds a client call to the WKPageUIClient to be called to determine
whether or not a plug-in should load.

  • UIProcess/API/C/WKPage.h: Add shouldLoadPlugin.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getPluginPath): Moved from WebProcessProxy, and added a call to

m_uiClient.shouldInstantiatePlugin.

  • UIProcess/WebPageProxy.h:
  • UIProcss/WebPageProxy.messages.in: Moved GetPluginPath from WebProcessProxy to WebPageProxy.
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPluginPath): Moved to WebPageProxy.

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::shouldInstantiatePlugin): Return that we should load the plug-in if

the client function isn't defined, and call the function if it is.

  • UIProcess/WebUIClient.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Add an entry for the new

client function.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Send the message to the WebPageProxy, not the WebProcessProxy.
(WebKit::WebPage::canPluginHandleResponse): Made a member function, so it can call sendSync, and

send the message to the WebPageProxy, not the WebProcessProxy.

  • WebProcess/WebPage/WebPage.h:

Tools:

Add entries for the new function in the necessary structs.

Reviewed by Anders Carlsson.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):

2:13 PM Changeset in webkit [141485] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix. Win7 port.

2:12 PM Changeset in webkit [141484] by andersca@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Tweak ChangeLog.

2:02 PM Changeset in webkit [141483] by aelias@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

[chromium] Rework page scale factor limits initialization
​https://bugs.webkit.org/show_bug.cgi?id=108446

Reviewed by James Robinson.

When loading a page with viewportEnabled, both the limits
specified by the viewport tag and the content width need to be
considered before we initialize the minimum page scale (and
pageScaleFactor itself usually to the same value). The timing has
proven tricky to get correct.

This patch simplifies the flow by computing the
limits only at the end of layouts and at no other time. In combination
with ​https://bugs.webkit.org/show_bug.cgi?id=107922 which sets
needsLayout() appropriately, this results in a more robust and easy
to understand sequence.

Fixes FixedLayoutInitializeAtMinimumPageScale test.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::layoutUpdated):
(WebKit::WebViewImpl::didChangeContentsSize):

  • src/WebViewImpl.h:

(WebKit::WebViewImpl::setInitialPageScaleFactor):
(WebViewImpl):

  • tests/WebFrameTest.cpp:
2:00 PM Changeset in webkit [141482] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Use a Vector for IPC attachments
​https://bugs.webkit.org/show_bug.cgi?id=108517

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::create):
(CoreIPC::ArgumentDecoder::ArgumentDecoder):
(CoreIPC::ArgumentDecoder::removeAttachment):

  • Platform/CoreIPC/ArgumentDecoder.h:

(ArgumentDecoder):

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/MessageDecoder.cpp:

(CoreIPC::MessageDecoder::create):
(CoreIPC::MessageDecoder::MessageDecoder):

  • Platform/CoreIPC/MessageDecoder.h:

(MessageDecoder):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::createMessageDecoder):

1:57 PM Changeset in webkit [141481] by zhajiang@rim.com
  • 7 edits in trunk/Source

[BlackBerry] Bing Images viewport causes layout "fun"
​https://bugs.webkit.org/show_bug.cgi?id=108393

Patch by Jacky Jiang <​zhajiang@rim.com>.
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson and partially reviewed by Konrad Piascik.

Source/WebCore:

PR: 277855
On bing.com image search page, JS generated styles for the divs which
contained images based on the window.screen and window.innerWidth.
Unfortunately the styles for the divs weren't good enough on our device
which resulted in three images being overlapped in the same viewport.
On our port, we calculate the screen rect base on the physical screen
pixels. However, iOS and lastest Android Chrome port already changed it
to density-independent (logical) pixels. And also to my knowledge that
some websites would generate bad styles for us as well through
@media device-width/device-height.
To be consistent and fix such kinds of issues, we should use
density-independent pixels instead of physical screen pixels. Mainly
ported from Chrome port change r139356. The patch will affect
screen.width/height, window.outerWidth/outerHeight and
@media device-width/device-height.

  • platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore):
(WebCore::toUserSpace):
(WebCore::screenAvailableRect):
(WebCore::screenRect):

Source/WebKit/blackberry:

PR: 277855
Set applyPageScaleFactorInCompositor settting to false by default.
Scale down chrome window rect to density-independent pixels.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::applyDeviceScaleFactorInCompositor):
(BlackBerry::WebKit::WebSettings::setApplyPageScaleFactorInCompositor):

  • Api/WebSettings.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::windowRect):

1:52 PM Changeset in webkit [141480] by mvujovic@adobe.com
  • 7 edits
    8 adds in trunk

[CSS Shaders] Parse custom filter function with the at-rule reference syntax
​https://bugs.webkit.org/show_bug.cgi?id=108351

Reviewed by Dean Jackson.

Source/WebCore:

This patch implements the parsing for the new custom filter function "at-rule reference"
syntax. It does not implement the style resolution yet.

The custom function syntax has changed in the spec. Instead of including all of the custom
filter information inline, the custom function can now reference an @filter rule by name.
The custom function can still accept a list of parameters.

The syntax is defined as the following, where IDENT is the name of the @filter rule:
filter: custom(IDENT [, <param>]*)

In practice, it can look like this:
filter: custom(page-curl, direction 90, amount 0.5);

Spec: ​https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#customident-ltparamgt

Tests: css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid.html

css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCustomFilterParameters):

Factor out a new function that just parses custom filter parameters. This is used by the
previous inline syntax and the new at-rule reference syntax.

(WebCore):
(WebCore::CSSParser::parseCustomFilterFunctionWithAtRuleReferenceSyntax):

This method parses the new at-rule reference syntax. When we remove the inline syntax,
we can rename this method to "parseCustomFilterFunction" and call it directly.

(WebCore::CSSParser::parseCustomFilterFunctionWithInlineSyntax):

Move the previous inline syntax parsing code into a new function.

(WebCore::CSSParser::parseCustomFilterFunction):

This method looks ahead in the CSS parser values and decides whether to parse the custom
function with the previous inline syntax or with the new at-rule reference syntax.

(WebCore::CSSParser::parseFilter):

I renamed the "parseCustomFilter" method to "parseCustomFilterFunction" to be more
explicit. Here, we update the name in the call site.

  • css/CSSParser.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::createCustomFilterOperationWithAtRuleReferenceSyntax):

This is a stub method. In the future, style resolution for the at-rule reference
syntax will happen here. When we remove the inline syntax, we can rename this method

(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):

This method contains the previous inline syntax style resolution code.

(WebCore):
(WebCore::StyleResolver::createCustomFilterOperation):

This method decides which syntax we should use to resolve the style.

  • css/StyleResolver.h:

(StyleResolver):

LayoutTests:

Add positive and negative parsing tests for the new custom function syntax.

Add a new folder "css3/filters/custom-with-at-rule-syntax". This will contain all the tests
using the new custom filters at-rule syntax. We will gradually copy tests in
"css3/filters/custom" over to "css3/filters/custom-with-at-rule-syntax" and modify them to
use the new at-rule syntax. When all of the tests have been replicated using the new syntax,
we will remove the previous syntax and the tests in "css3/filters/custom".

  • css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid-expected.txt: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid.html: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid-expected.txt: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid.html: Added.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-invalid.js: Added.

(testInvalidFilterRule):

  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-valid.js: Added.

(testFilterProperty):

  • css3/filters/script-tests/custom-filter-parsing-common.js:

(heading):

New function to print a heading to make groups of related parsing tests easier to see.

(shouldHaveConstructor):

New function to check the JS type of an object on JSC as well as V8. This is intended to
eventually replace shouldBeType, which works differently on V8 vs. JSC and requires us
to create Chromium-specific expectations for the custom filters parsing tests.

1:50 PM Changeset in webkit [141479] by commit-queue@webkit.org
  • 16 edits in trunk

Editor::m_compositionNode not updated on HTMLInputElement::setValue()
​https://bugs.webkit.org/show_bug.cgi?id=107737

Patch by Aurimas Liutikas <​aurimas@chromium.org> on 2013-01-31
Reviewed by Ryosuke Niwa.

Source/WebCore:

Chromium has a bug where the IME composition did not get cancelled on JavaScript changes
to the focused editing field. Most of other WebKit ports were already doing this check
in their EditorClient::respondToChangedSelection. I took that logic and moved it to the
Editor so every port and use the same code.

An existing test editing/input/setting-input-value-cancel-ime-composition.html covers this change.
This test used to have an expectation to fail on Chromium and after this patch it will start passing.

  • editing/Editor.cpp:

(WebCore::Editor::cancelCompositionIfSelectionIsInvalid):

Adding a call that can be used by any the port to cancel the composition if it's no longer valid.

(WebCore):

  • editing/Editor.h:

(Editor):

Source/WebKit/chromium:

  • public/WebViewClient.h:

(WebKit::WebViewClient::didCancelCompositionOnSelectionChange):

Adding a callback to let the WebViewClient know that the composition has been cancelled.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::respondToChangedSelection):

Adding a call composition if it is no longer valid.

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::respondToChangedSelection):

Adding a call to the newly refactored method.

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::respondToChangedSelection):

Adding a call to the newly refactored Editor method.

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateSelectionForInputManager]):

Source/WebKit/win:

  • WebView.cpp:

(WebView::updateSelectionForIME):

Adding a call to the newly refactored method.

LayoutTests:

1:47 PM Changeset in webkit [141478] by fmalita@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Unreviewed gardening.

Win build fix after ​http://trac.webkit.org/changeset/141471.

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(MockSpellCheck::spellCheckWord):

1:42 PM Changeset in webkit [141477] by Joseph Pecoraro
  • 8 edits in trunk/Source

Disable ENABLE_FULLSCREEN_API on iOS
​https://bugs.webkit.org/show_bug.cgi?id=108250

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
1:25 PM Changeset in webkit [141476] by kerz@chromium.org
  • 2 edits in branches/chromium/1364/Source/WebKit/chromium

Merge 141454

WebFrameTest.DisambiguationPopup is failing
​https://bugs.webkit.org/show_bug.cgi?id=108160

Patch by Dan Alcantara <​dfalcantara@chromium.org> on 2013-01-31
Reviewed by Adam Barth.

Fix the unit test so that it is using the right HTML file.

  • tests/WebFrameTest.cpp:

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/12087118

1:24 PM Changeset in webkit [141475] by kerz@chromium.org
  • 4 edits
    1 copy in branches/chromium/1364/Source/WebKit/chromium

Merge 141019

[Chromium, Mobile] Do not show disambiguation pop up in mobile sites
​https://bugs.webkit.org/show_bug.cgi?id=107607

Patch by Dan Alcantara <​dfalcantara@chromium.org> on 2013-01-28
Reviewed by Adam Barth.

Add a check before showing the disambiguation popup to prevent it from appearing
on mobile sites. Makes a similar test to the current disambiguation popup test
that expects the popup to never appear.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit):
(WebKit::WebViewImpl::isLikelyMobileSite):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/WebFrameTest.cpp:
  • tests/data/disambiguation_popup_mobile_site.html: Added.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit):
(WebKit::WebViewImpl::shouldDisableDesktopWorkarounds):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/WebFrameTest.cpp:
  • tests/data/disambiguation_popup_mobile_site.html: Added.

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/12086096

1:18 PM Changeset in webkit [141474] by pilgrim@chromium.org
  • 4 edits
    1 move in trunk/Source

[Chromium] Move LocalizedStrings to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=108488

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

  • WebCore.gypi:
  • platform/chromium/LocalizedStringsChromium.cpp: Copied from Source/WebKit/chromium/src/LocalizedStrings.cpp.

(WebCore::imageTitle):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/LocalizedStrings.cpp: Removed.
1:14 PM Changeset in webkit [141473] by enrica@apple.com
  • 49 edits
    11 adds in trunk

WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
​https://bugs.webkit.org/show_bug.cgi?id=108396.
<rdar://problem/12920461>

Source/WebCore:

Reviewed by Alexey Proskuryakov.

Adds support in WebCore to new EditorClient methods to support the modified
client bundle API in WebKit2.

  • WebCore.exp.in:
  • editing/Editor.cpp:

(WebCore::Editor::cut): Added call to willWriteSelectionToPasteboard.
(WebCore::Editor::copy): Ditto.
(WebCore::Editor::willWriteSelectionToPasteboard): Added.

  • editing/Editor.h:
  • loader/EmptyClients.h: Added empty client implementation

for the new methods.
(WebCore::EmptyEditorClient::willWriteSelectionToPasteboard):
(WebCore::EmptyEditorClient::getClientPasteboardDataForRange):

  • page/EditorClient.h:
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelectionForTypes): Added call to getClientPasteboardDataForRange.

Source/WebKit/blackberry:

Reviewed by Alexey Proskuryakov.

Adds stub implementation for WebKit of the new EditorClient methods.

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::willWriteSelectionToPasteboard):
(WebCore::EditorClientBlackBerry::getClientPasteboardDataForRange):

  • WebCoreSupport/EditorClientBlackBerry.h:

Source/WebKit/chromium:

Reviewed by Alexey Proskuryakov.

Adds stub implementation for WebKit of the new EditorClient methods.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::willWriteSelectionToPasteboard):
(WebKit::EditorClientImpl::getClientPasteboardDataForRange):

  • src/EditorClientImpl.h:

Source/WebKit/efl:

Reviewed by Alexey Proskuryakov.

Adds stub implementation for WebKit of the new EditorClient methods.

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::willWriteSelectionToPasteboard):
(WebCore::EditorClientEfl::getClientPasteboardDataForRange):

  • WebCoreSupport/EditorClientEfl.h:

Source/WebKit/gtk:

Reviewed by Alexey Proskuryakov.

Adds stub implementation for WebKit of the new EditorClient methods.

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::willWriteSelectionToPasteboard):
(WebKit::EditorClient::getClientPasteboardDataForRange):

  • WebCoreSupport/EditorClientGtk.h:

Source/WebKit/mac:

Reviewed by Alexey Proskuryakov.

Adds stub implementation for WebKit of the new EditorClient methods.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::willWriteSelectionToPasteboard):
(WebEditorClient::getClientPasteboardDataForRange):

Source/WebKit/qt:

Reviewed by Alexey Proskuryakov.

Adds stub implementation for WebKit of the new EditorClient methods.

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::willWriteSelectionToPasteboard):
(WebCore::EditorClientQt::getClientPasteboardDataForRange):

  • WebCoreSupport/EditorClientQt.h:

Source/WebKit/win:

Reviewed by Alexey Proskuryakov.

Adds stub implementation for WebKit of the new EditorClient methods.

  • WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::willWriteSelectionToPasteboard):
(WebEditorClient::getClientPasteboardDataForRange):

  • WebCoreSupport/WebEditorClient.h:

Source/WebKit/wince:

Reviewed by Alexey Proskuryakov.

Adds stub implementation for WebKit of the new EditorClient methods.

  • WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::willWriteSelectionToPasteboard):
(WebKit::EditorClientWinCE::getClientPasteboardDataForRange):

  • WebCoreSupport/EditorClientWinCE.h:

Source/WebKit/wx:

Reviewed by Alexey Proskuryakov.

Adds stub implementation for WebKit of the new EditorClient methods.

  • WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::willWriteSelectionToPasteboard):
(WebCore::EditorClientWx::getClientPasteboardDataForRange):

  • WebKitSupport/EditorClientWx.h:

Source/WebKit2:

Reviewed by Alexey Proskuryakov.

This patch adds new bundle client API to receive notifications
relative the pasteboard activity. There are 2 new API added to
InjectedBundleEditorClient, to receive notification before and
after the pasteboard content is added and one API to provide
additional content to add to the pasteboard.
In order to create content to add to the pasteboard, WKWebArchiveRef
and WKWebArchiveResourcesRef have been added to the set of API level
object.
This work is a joint effort with Sam Weinig who contributed the
support for WKWebArchiveRef, WKWebArchiveResourcesRef and related
files. Sam is the author of the first chunk of changes listed below.

  • Shared/API/c/WKBase.h:
  • Shared/API/c/WKSharedAPICast.h:
  • Shared/API/c/mac/WKWebArchive.cpp: Added.

(WKWebArchiveGetTypeID):
(WKWebArchiveCreate):
(WKWebArchiveCreateWithData):
(WKWebArchiveCreateFromRange):
(WKWebArchiveCopyMainResource):
(WKWebArchiveCopySubresources):
(WKWebArchiveCopySubframeArchives):
(WKWebArchiveCopyData):

  • Shared/API/c/mac/WKWebArchive.h: Added.
  • Shared/API/c/mac/WKWebArchiveResource.cpp: Added.

(WKWebArchiveResourceGetTypeID):
(WKWebArchiveResourceCreate):
(WKWebArchiveResourceCopyData):
(WKWebArchiveResourceCopyURL):
(WKWebArchiveResourceCopyMIMEType):
(WKWebArchiveResourceCopyTextEncoding):

  • Shared/API/c/mac/WKWebArchiveResource.h: Added.
  • Shared/APIObject.h:
  • Shared/WebArchive.cpp: Added.

(WebKit::WebArchive::create):
(WebKit::WebArchive::WebArchive):
(WebKit::WebArchive::~WebArchive):
(WebKit::WebArchive::mainResource):
(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):
(WebKit::releaseCFData):
(WebKit::WebArchive::data):
(WebKit::WebArchive::coreLegacyWebArchive):

  • Shared/WebArchive.h: Added.

(WebKit::WebArchive::type):

  • Shared/WebArchiveResource.cpp: Added.

(WebKit::WebArchiveResource::create):
(WebKit::WebArchiveResource::WebArchiveResource):
(WebKit::WebArchiveResource::~WebArchiveResource):
(WebKit::releaseCFData):
(WebKit::WebArchiveResource::data):
(WebKit::WebArchiveResource::URL):
(WebKit::WebArchiveResource::MIMEType):
(WebKit::WebArchiveResource::textEncoding):
(WebKit::WebArchiveResource::coreArchiveResource):

  • Shared/WebArchiveResource.h: Added.

(WebKit::WebArchiveResource::type):

  • WebKit2.xcodeproj/project.pbxproj:


  • Shared/APIClientTraits.cpp: Added versioning to InjectedBundlePageEditorClient.
  • Shared/APIClientTraits.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::willWriteToPasteboard): Added.
(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange): Added.
(WebKit::InjectedBundlePageEditorClient::didWriteToPasteboard): Added.

  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::didWriteSelectionToPasteboard):
(WebKit::WebEditorClient::willWriteSelectionToPasteboard):
(WebKit::WebEditorClient::getClientPasteboardDataForRange):

  • WebProcess/WebCoreSupport/WebEditorClient.h:

Tools:

Reviewed by Alexey Proskuryakov.

Adding new WebKit2 test with relevant bundle, to test the new APIs.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::setInjectedBundleClient):

  • TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp: Added.

(PasteboardNotificationsTest):
(TestWebKitAPI::willWriteToPasteboard):
(TestWebKitAPI::getPasteboardDataForRange):
(TestWebKitAPI::didWriteToPasteboard):
(TestWebKitAPI::PasteboardNotificationsTest::PasteboardNotificationsTest):
(TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):

  • TestWebKitAPI/Tests/WebKit2/execCopy.html: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Updated to reflect

changes in InjectedBundleEditorClient.
(WTR::InjectedBundlePage::InjectedBundlePage):

1:03 PM Changeset in webkit [141472] by andersca@apple.com
  • 25 edits
    2 deletes in trunk/Source/WebKit2

Remove MessageID.h
​https://bugs.webkit.org/show_bug.cgi?id=108516

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::sendOutgoingMessages):
(CoreIPC::Connection::dispatchSyncMessage):
(CoreIPC::Connection::dispatchMessage):

  • Platform/CoreIPC/Connection.h:

(CoreIPC):
(Connection):

  • Platform/CoreIPC/MessageID.h: Removed.
  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::Connection::receiveSourceEventHandler):

  • Shared/CoreIPCSupport/WebConnectionMessageKinds.h: Removed.
  • Shared/CoreIPCSupport/WebContextMessageKinds.h:
  • UIProcess/DrawingAreaProxy.h:

(CoreIPC):

  • UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
  • UIProcess/WebApplicationCacheManagerProxy.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):

  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebFrameProxy.h:

(CoreIPC):

  • UIProcess/WebFullScreenManagerProxy.h:

(CoreIPC):

  • UIProcess/WebIconDatabase.h:

(CoreIPC):

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:

(CoreIPC):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/FullScreen/WebFullScreenManager.cpp:
  • WebProcess/FullScreen/WebFullScreenManager.h:

(CoreIPC):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(CoreIPC):

  • WebProcess/WebPage/DrawingArea.h:

(CoreIPC):

  • WebProcess/WebPage/LayerTreeHost.h:

(CoreIPC):

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:

(CoreIPC):

  • WebProcess/WebPage/WebPageGroupProxy.h:

(CoreIPC):

12:58 PM Changeset in webkit [141471] by commit-queue@webkit.org
  • 5 edits in trunk

Tools: [Chromium] Add two-word misspelling to mock spellchecker
​https://bugs.webkit.org/show_bug.cgi?id=108498

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-01-31
Reviewed by Tony Chang.

Some layout tests verify spellcheck behavior when multiple words are
marked as a single misspelling. This change adds a two-word misspelling
'upper case' to the mock spellchecker used by layout tests.

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(MockSpellCheck::spellCheckWord): Modified to handle spaces in misspellings.
(MockSpellCheck::initializeIfNeeded): Modified to use a vector instead of a hash table.

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck): Changed misspellings container from hash table to vector.

LayoutTests: [Chromium] Expect spellcheck to work for exactly-selected multi-word misspellings
​https://bugs.webkit.org/show_bug.cgi?id=108498

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-01-31
Reviewed by Tony Chang.

  • platform/chromium/TestExpectations: Update spellcheck tests expectations.
12:55 PM Changeset in webkit [141470] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Make selection handling work in applyPageScaleInCompositor mode
​https://bugs.webkit.org/show_bug.cgi?id=107831

Patch by Chris Hopman <​cjhopman@chromium.org> on 2013-01-31
Reviewed by Ryosuke Niwa.

These functions expect a window point. When in
applyPageScaleFactorInCompositor mode, the points need to be unscaled
by the page scale factor.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::selectRange):
(WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):

12:55 PM Changeset in webkit [141469] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r141136): Apple's internal PLT test suite doesn't finish
​https://bugs.webkit.org/show_bug.cgi?id=108380

Mark some tests whose results depend on main resource caching being enabled as failing until
main resource caching can be re-enabled on mac.

  • platform/mac/TestExpectations:
12:52 PM Changeset in webkit [141468] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Use OS() and PLATFORM() macros in WebCorePrefix.h for readability
<​http://webkit.org/b/108374>

Reviewed by Laszlo Gombos.

  • WebCorePrefix.h: Replaced all possible checks with OS() or

PLATFORM() macros other than APPLE.

12:51 PM Changeset in webkit [141467] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Prospective build fix.

Reviewed by Jocelyn Turcotte.

Don't create .prl files for intermediate libs as their contents get
injected within -Wl,-whole-archive -lFoo -wl,-no-whole-archive.

  • qmake/mkspecs/features/default_post.prf:
12:48 PM Changeset in webkit [141466] by mkwst@chromium.org
  • 7 edits in trunk/Source

Cleanup: Use ScriptExecutionContext::topOrigin when relevant.
​https://bugs.webkit.org/show_bug.cgi?id=108476

Source/WebCore:

Reviewed by Jochen Eisinger.

Rather than diving through 'frame()->top()' or 'topDocument()' to get
the SecurityOrigin of the top-level document in a frame, we can now
directly grab the 'topOrigin()' off of a ScriptExecutionContext. This
patch adjusts a few callsites to use the new hotness rather than the
old brokenness.

This is a pure refactoring: No web-visible changes should result.

  • Modules/webdatabase/DOMWindowWebDatabase.cpp:

(WebCore::DOMWindowWebDatabase::openDatabase):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):

Source/WebKit2:

Reviewed by Anders Carlsson.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::storageBlockingStateChanged):
(WebKit::PluginView::isPrivateBrowsingEnabled):

12:47 PM Changeset in webkit [141465] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Get rid of IncomingMessage
​https://bugs.webkit.org/show_bug.cgi?id=108514

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:

(Connection::SyncMessageState):
(ConnectionAndIncomingMessage):
(CoreIPC::Connection::SyncMessageState::~SyncMessageState):
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
(CoreIPC::Connection::SyncMessageState::dispatchMessages):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::enqueueIncomingMessage):
(CoreIPC::Connection::dispatchMessage):
(CoreIPC::Connection::dispatchOneMessage):

  • Platform/CoreIPC/Connection.h:

(Connection):

12:44 PM Changeset in webkit [141464] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Curl] There is no way for a WebKit client to set the Curl cookie jar path
​https://bugs.webkit.org/show_bug.cgi?id=107692

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-01-31
Reviewed by Brent Fulgham.

Set default cookie jar path.
Get the cookie jar path for Curl from the environment variable CURL_COOKIE_JAR_PATH.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::cookieJarPath): Added helper function to set cookie jar path.
(WebCore::ResourceHandleManager::ResourceHandleManager): Call helper function.

12:41 PM Changeset in webkit [141463] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit2

Remove PLATFORM(WIN_CAIRO) from NetscapePluginX11.cpp
​https://bugs.webkit.org/show_bug.cgi?id=108439

Reviewed by Brent Fulgham.

PLATFORM(WIN_CAIRO) is Windows only, where no X11 exists.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
12:38 PM Changeset in webkit [141462] by mjs@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r138962): Fails to show "confirm form resubmission", hangs browser
​https://bugs.webkit.org/show_bug.cgi?id=108214

Reviewed by Adam Barth.

Attempt a workaround suggested by Nate Chapin by putting some code
in #ifdef !PLATFORM(CHROMIUM).

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::notifyFinished):

12:24 PM Changeset in webkit [141461] by tsepez@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[v8] Enable binding integrity on mac
​https://bugs.webkit.org/show_bug.cgi?id=108500

Reviewed by Adam Barth.

Patch is correct if existing tests pass without new crashes.

  • features.gypi:

Set ENABLE_BINDING_INTEGRITY=1 when OS=="mac"

12:02 PM Changeset in webkit [141460] by jchaffraix@webkit.org
  • 1 edit in branches/chromium/1364/Source/WebCore/rendering/RenderBlockLineLayout.cpp

Merge 141009

Crash inside RenderBlock::layoutRunsAndFloatsInRange in the widow code
​https://bugs.webkit.org/show_bug.cgi?id=108084

Reviewed by Dean Jackson.

This is a blind fix based on the code and Chromium's stack-traces.

Unfortunately no new test as I couldn't get a local reproduction.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
Added a missing NULL-check: the previous 'while' finish if |lineBox|
is NULL and we don't want to crash in this case.

TBR=​jchaffraix@webkit.org
Review URL: ​https://codereview.chromium.org/12084093

12:00 PM Changeset in webkit [141459] by ojan@chromium.org
  • 7 edits
    6 adds in trunk

REGRESSION(r128517): Percentage heights in quirks mode collapse when printing
​https://bugs.webkit.org/show_bug.cgi?id=108382

Reviewed by David Hyatt.

Source/WebCore:

r128517 clean up our containing block finding logic, but broke percentage
heights in quirks mode during printing since the RenderView would have 0 height.
Turns out we already had a long-standing bug where we'd incorrectly
treat collapse percentage heights on the body when printing as well.

Fix both bugs by changing the way we grab the logical height on the RenderView.
RenderView::computeLogicalHeight returns 0 when printing. For the purposes of
stretching and percentage heights, we instead need to return the pageLogicalHeight.

Tests: printing/quirks-percentage-height-body.html

printing/quirks-percentage-height.html
printing/standards-percentage-heights.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):
This FIXME is outdated and already fixed. Also, call viewLogicalHeightForPercentages
which does the same logic except also correctly handles column RenderViews.
(WebCore::RenderBox::viewLogicalHeightForPercentages):
(WebCore::RenderBox::computePercentageLogicalHeight):

  • rendering/RenderBox.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::viewLogicalHeightForPercentages):
(WebCore):
(WebCore::RenderBox::computePercentageLogicalHeight):

  • rendering/RenderBox.h:

(RenderBox):

LayoutTests:

  • platform/chromium/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:

We're just clipping more content that you can't scroll to anyways. This looks
like an improvement to me.

  • printing/css2.1/page-break-inside-000-expected.txt:

We pass this test now!

  • printing/quirks-percentage-height-body-expected.html: Added.
  • printing/quirks-percentage-height-body.html: Added.
  • printing/quirks-percentage-height-expected.html: Added.
  • printing/quirks-percentage-height.html: Added.
  • printing/standards-percentage-heights-expected.html: Added.
  • printing/standards-percentage-heights.html: Added.
11:56 AM Changeset in webkit [141458] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

inspector/editor/text-editor-ctrl-movements.html was renamed to
inspector/editor/text-editor-word-jumps.html in r141399. Update the TestExpectations file.

  • platform/mac/TestExpectations:
11:56 AM Changeset in webkit [141457] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: m_clipRectsCache->m_respectingOverflowClip[clipRectsType] == (clipRectsContext.respectOverflowClip == RespectOverflowClip) in RenderLayer.
​https://bugs.webkit.org/show_bug.cgi?id=108257

  • platform/mac/TestExpectations:

Mark the tests as "crashing" in debug.

11:46 AM Changeset in webkit [141456] by krit@webkit.org
  • 14 edits
    3 adds in trunk

[canvas] Implement currentPath to get and set the current path of the context
​https://bugs.webkit.org/show_bug.cgi?id=108246

Patch by Dirk Schulze <​krit@webkit.org> on 2013-01-31
Reviewed by Dean Jackson.

Source/WebCore:

Add currentPath attribute to CanvasRenderingContext2d interface. This allows
setting the current context path by an existing Path object as well as getting
the current context path as new Path object. The returned and the set Paths
are not live.

This feature is behind the CANVAS_PATH compiler flag which is disabled by
default for now.

Test: fast/canvas/canvas-currentPath.html

  • html/canvas/CanvasPathMethods.cpp: Rename transformIsInvertible to

isTransformInvertible for harmonizing naming schema.

(WebCore::CanvasPathMethods::moveTo): Ditto.
(WebCore::CanvasPathMethods::lineTo): Ditto.
(WebCore::CanvasPathMethods::quadraticCurveTo): Ditto.
(WebCore::CanvasPathMethods::bezierCurveTo): Ditto.
(WebCore::CanvasPathMethods::arcTo): Ditto.
(WebCore::CanvasPathMethods::arc): Ditto.
(WebCore::CanvasPathMethods::rect): Ditto.

  • html/canvas/CanvasPathMethods.h: Ditto.

(CanvasPathMethods):
(WebCore::CanvasPathMethods::isTransformInvertible):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore):
(WebCore::CanvasRenderingContext2D::currentPath): Getter for currentPath.
(WebCore::CanvasRenderingContext2D::setCurrentPath): Setter for currentPath.

  • html/canvas/CanvasRenderingContext2D.h:

(WebCore):
(CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::isTransformInvertible):

  • html/canvas/CanvasRenderingContext2D.idl: Add currentPath attribute.
  • html/canvas/DOMPath.h: Add new constructor and getter for Path object.

(WebCore::DOMPath::create): New static function for new ctor.
(DOMPath):
(WebCore::DOMPath::path): Getter for Path object.
(WebCore::DOMPath::DOMPath):

LayoutTests:

Added tests for canvas.currentPath in various combinations of the context state.

  • fast/canvas/canvas-currentPath-expected.txt: Added.
  • fast/canvas/canvas-currentPath.html: Added.
  • fast/canvas/script-tests/canvas-currentPath.js: Added.

(testPointCollection):

  • platform/chromium/TestExpectations: Skip test until enabling CANVAS_PATH.
  • platform/efl/TestExpectations: Ditto.
  • platform/gtk/TestExpectations: Ditto.
  • platform/mac/TestExpectations: Ditto.
  • platform/qt/TestExpectations: Ditto.
11:42 AM Changeset in webkit [141455] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix: Remove Web Intents files from
the Qt build system.

  • Target.pri:
11:40 AM Changeset in webkit [141454] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

WebFrameTest.DisambiguationPopup is failing
​https://bugs.webkit.org/show_bug.cgi?id=108160

Patch by Dan Alcantara <​dfalcantara@chromium.org> on 2013-01-31
Reviewed by Adam Barth.

Fix the unit test so that it is using the right HTML file.

  • tests/WebFrameTest.cpp:
11:37 AM Changeset in webkit [141453] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] webkit_unit_tests should depend on base/allocator for ASAN
​https://bugs.webkit.org/show_bug.cgi?id=108497

Reviewed by James Robinson.

  • WebKitUnitTests.gyp:
11:35 AM Changeset in webkit [141452] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix.
Removing build targets for Web Intents files that were removed in r141448.

  • GNUmakefile.list.am:
11:34 AM Changeset in webkit [141451] by commit-queue@webkit.org
  • 7 edits
    2 copies in trunk/Tools

EWS graphs have unusual data for patch waiting times
​https://bugs.webkit.org/show_bug.cgi?id=108427

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-31
Reviewed by Eric Seidel.

The max_patches_waiting QueueLog property may have missed recording patches waiting in idle times when no events are fired to update it. I added a cron job to take care of this issue.
The patch wait duration in PatchLogs was being incorrectly updated after a patch expired and was picked up again from the queue. That period should really count towards the processing time instead.
Added a WarningLog to record if any erroneous situations occur due to invalid contents in the datastore. These basically highlight if any "impossible" execution paths get executed.

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/cron.yaml:
  • QueueStatusServer/handlers/syncqueuelogs.py: Copied from Tools/QueueStatusServer/model/patchlog.py.

(SyncQueueLogs):
(SyncQueueLogs.get):

  • QueueStatusServer/loggers/recordpatchevent.py:

(RecordPatchEvent.added):
(RecordPatchEvent.retrying):
(RecordPatchEvent.started):
(RecordPatchEvent.stopped):
(RecordPatchEvent.updated):

  • QueueStatusServer/main.py:
  • QueueStatusServer/model/patchlog.py:

(PatchLog.lookup):
(PatchLog):
(PatchLog.lookup_if_exists):
(PatchLog.calculate_process_duration):
(PatchLog._generate_key):

  • QueueStatusServer/model/queuelog.py:

(QueueLog.update_max_patches_waiting):
(QueueLog._get_or_create_txn):
(QueueLog):
(QueueLog._get_patches_waiting):

  • QueueStatusServer/model/warninglog.py: Copied from Tools/QueueStatusServer/model/patchlog.py.

(WarningLog):
(WarningLog.record):

11:25 AM Changeset in webkit [141450] by aelias@chromium.org
  • 5 edits in trunk/Source

Call FrameView::contentsResized() when setting fixed layout size
​https://bugs.webkit.org/show_bug.cgi?id=107922

Reviewed by James Robinson.

In fixed layout mode, we should be calling contentsResized() when the
fixed layout size is changed, but not laying out when the visible
content rect changes.

Previously landed as r140869 but was reverted due to a bug in bundled
Chromium-specific code. This patch includes just the minimum needed in
WebCore.

New WebFrameTest: FrameViewNeedsLayoutOnFixedLayoutResize. Some
flaky and obsolete tests for the old page scale mode are also deleted.

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::visibleContentsResized):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setFixedLayoutSize):
(WebCore::ScrollView::setUseFixedLayout):

Source/WebKit/chromium:

  • tests/WebFrameTest.cpp:
11:16 AM Changeset in webkit [141449] by tony@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Unreviewed, update expectation after the order of elements was codified.
​https://bugs.webkit.org/show_bug.cgi?id=98686

Also delete the Qt result since this test is skipped on Qt.

  • editing/pasteboard/data-transfer-items-expected.txt:
  • platform/qt/editing/pasteboard/data-transfer-items-expected.txt: Removed.
11:11 AM Changeset in webkit [141448] by andersca@apple.com
  • 35 edits
    20 deletes in trunk

Remove Web Intents code from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=108506

Reviewed by Simon Fraser.

Source/WebKit2:

Since nobody builds with Web Intents enabled anymore, and since the code is going to
be removed from WebCore, remove it from WebKit2.

  • Shared/API/c/WKBase.h:
  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIObject.h:
  • Shared/IntentData.cpp: Removed.
  • Shared/IntentData.h: Removed.
  • Shared/IntentServiceInfo.cpp: Removed.
  • Shared/IntentServiceInfo.h: Removed.
  • Shared/WebIntentServiceInfo.cpp: Removed.
  • Shared/WebIntentServiceInfo.h: Removed.
  • UIProcess/API/C/WKAPICast.h:

(WebKit):

  • UIProcess/API/C/WKIntentData.cpp: Removed.
  • UIProcess/API/C/WKIntentData.h: Removed.
  • UIProcess/API/C/WKIntentServiceInfo.cpp: Removed.
  • UIProcess/API/C/WKIntentServiceInfo.h: Removed.
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebIntentData.cpp: Removed.
  • UIProcess/WebIntentData.h: Removed.
  • UIProcess/WebLoaderClient.cpp:
  • UIProcess/WebLoaderClient.h:

(WebKit):
(WebLoaderClient):

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:

(WebKit):
(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebProcessProxy.cpp:
  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit):

  • WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundleIntent.h: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundleIntentRequest.cpp: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundleIntentRequest.h: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundleIntent.cpp: Removed.
  • WebProcess/InjectedBundle/InjectedBundleIntent.h: Removed.
  • WebProcess/InjectedBundle/InjectedBundleIntentRequest.cpp: Removed.
  • WebProcess/InjectedBundle/InjectedBundleIntentRequest.h: Removed.
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

(WebKit):
(InjectedBundlePageLoaderClient):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

  • WebProcess/WebPage/WebFrame.cpp:
  • WebProcess/WebPage/WebFrame.h:

(WebCore):
(WebKit):
(WebFrame):

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:

(WebCore):
(WebKit):
(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebProcess.cpp:
  • WebProcess/WebProcess.h:

(WebCore):
(WebProcess):

  • WebProcess/WebProcess.messages.in:

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

11:06 AM Changeset in webkit [141447] by beidson@apple.com
  • 4 edits in trunk/Source

Lack of a log level string should not obliterate compiled in logging channel state.
​https://bugs.webkit.org/show_bug.cgi?id=108502

Reviewed by Alexey Proskuryakov and Sam Weinig.

Source/WebKit/mac:

  • Misc/WebKitLogging.m: If there's no log level string, leave the channel state alone.

Source/WebKit2:

  • Platform/mac/Logging.mac.mm:

(WebKit::initializeLogChannel): If there's no log level string, leave the channel state alone.

11:06 AM Changeset in webkit [141446] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] CookieParser should ignore invalid/unsupported attributes instead of ignoring the cookie
​https://bugs.webkit.org/show_bug.cgi?id=108494

PR 287832
Patch by Otto Derek Cheung <​otcheung@rim.com> on 2013-01-31
Reviewed by Rob Buis.
Internally Reviewed by Liam Quinn.

A short-term fix for CookieParser to not blow up when a Set-Cookie header has an invalid
or unsupported cookie attribute.

We will ignore the attribute only, not the entire cookie.

Also, making sure the parser won't replace values of valid attributes when evaluating an unsupported
cookie with the same length and same first character as a supported attribute.

Tested using opera cookie and browser.swlab.rim.net cookies test suite. Tested using regular sites that
has a login mechanism.

  • platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::parseOneCookie):

11:05 AM Changeset in webkit [141445] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

WebProcess sandbox profile overhaul.

Reviewed by Sam Weinig.

Moves some rules together by susbystem for easier maintenance.

Addresses <rdar://problem/9276393>, <rdar://problem/10844321>, <rdar://problem/12408537>,
<rdar://problem/12558524>.

  • WebProcess/com.apple.WebProcess.sb.in:
11:01 AM Changeset in webkit [141444] by tommyw@google.com
  • 27 edits
    1 copy
    3 adds
    2 deletes in trunk

[chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
​https://bugs.webkit.org/show_bug.cgi?id=108458

Source/Platform:

Only renames, no other code changes.

Reviewed by Adam Barth.

  • Platform.gypi:
  • chromium/public/WebMediaStream.h: Copied from Source/Platform/chromium/public/WebMediaStreamDescriptor.h.

(WebCore):
(WebKit):
(WebMediaStream):
(ExtraData):
(WebKit::WebMediaStream::ExtraData::~ExtraData):
(WebKit::WebMediaStream::WebMediaStream):
(WebKit::WebMediaStream::~WebMediaStream):
(WebKit::WebMediaStream::operator=):
(WebKit::WebMediaStream::isNull):

  • chromium/public/WebMediaStreamCenter.h:

(WebKit):
(WebMediaStreamCenter):
(WebKit::WebMediaStreamCenter::didAddMediaStreamTrack):
(WebKit::WebMediaStreamCenter::didRemoveMediaStreamTrack):

  • chromium/public/WebMediaStreamCenterClient.h:

(WebKit):
(WebMediaStreamCenterClient):

  • chromium/public/WebMediaStreamComponent.h:
  • chromium/public/WebMediaStreamDescriptor.h:
  • chromium/public/WebMediaStreamTrack.h: Added.

(WebCore):
(WebKit):
(WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::~WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::operator=):
(WebKit::WebMediaStreamTrack::isNull):

  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCPeerConnectionHandlerClient.h:

(WebKit):
(WebRTCPeerConnectionHandlerClient):

  • chromium/public/WebRTCStatsRequest.h:

(WebKit):
(WebRTCStatsRequest):

Source/WebCore:

Reviewed by Adam Barth.

Only renames, no other code changes.

  • WebCore.gypi:
  • platform/chromium/support/WebMediaStream.cpp: Added.

(WebKit::WebMediaStream::WebMediaStream):
(WebKit):
(WebKit::WebMediaStream::reset):
(WebKit::WebMediaStream::label):
(WebKit::WebMediaStream::id):
(WebKit::WebMediaStream::extraData):
(WebKit::WebMediaStream::setExtraData):
(WebKit::WebMediaStream::audioSources):
(WebKit::WebMediaStream::videoSources):
(WebKit::WebMediaStream::operator=):
(WebKit::WebMediaStream::operator PassRefPtr<WebCore::MediaStreamDescriptor>):
(WebKit::WebMediaStream::operator WebCore::MediaStreamDescriptor*):
(WebKit::WebMediaStream::initialize):
(WebKit::WebMediaStream::assign):

  • platform/chromium/support/WebMediaStreamComponent.cpp: Removed.
  • platform/chromium/support/WebMediaStreamDescriptor.cpp: Removed.
  • platform/chromium/support/WebMediaStreamTrack.cpp: Added.

(WebKit):
(WebKit::WebMediaStreamTrack::WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::operator=):
(WebKit::WebMediaStreamTrack::initialize):
(WebKit::WebMediaStreamTrack::reset):
(WebKit::WebMediaStreamTrack::operator PassRefPtr<MediaStreamComponent>):
(WebKit::WebMediaStreamTrack::operator MediaStreamComponent*):
(WebKit::WebMediaStreamTrack::isEnabled):
(WebKit::WebMediaStreamTrack::id):
(WebKit::WebMediaStreamTrack::stream):
(WebKit::WebMediaStreamTrack::source):
(WebKit::WebMediaStreamTrack::assign):

  • platform/chromium/support/WebRTCStatsRequest.cpp:

(WebKit::WebRTCStatsRequest::stream):
(WebKit::WebRTCStatsRequest::component):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenterChromium::didCreateMediaStream):
(WebCore::MediaStreamCenterChromium::stopLocalMediaStream):
(WebCore::MediaStreamCenterChromium::addMediaStreamTrack):
(WebCore::MediaStreamCenterChromium::removeMediaStreamTrack):

  • platform/mediastream/chromium/MediaStreamCenterChromium.h:

(WebKit):
(MediaStreamCenterChromium):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::didAddRemoteStream):
(WebCore::RTCPeerConnectionHandlerChromium::didRemoveRemoteStream):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(WebKit):
(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

Reviewed by Adam Barth.

Only renames, no other code changes.

  • public/WebMediaStreamRegistry.h:

(WebKit):
(WebMediaStreamRegistry):

  • public/WebUserMediaRequest.h:

(WebKit):
(WebUserMediaRequest):

  • src/WebMediaStreamRegistry.cpp:

(WebKit::WebMediaStreamRegistry::lookupMediaStreamDescriptor):

  • src/WebUserMediaRequest.cpp:

(WebKit::WebUserMediaRequest::requestSucceeded):

Tools:

Reviewed by Adam Barth.

Only renames, no other code changes.

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:

(MockWebMediaStreamCenter::didEnableMediaStreamTrack):
(MockWebMediaStreamCenter::didDisableMediaStreamTrack):
(MockWebMediaStreamCenter::didAddMediaStreamTrack):
(MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
(MockWebMediaStreamCenter::didStopLocalMediaStream):
(MockWebMediaStreamCenter::didCreateMediaStream):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.h:

(MockWebMediaStreamCenter):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::addStream):
(MockWebRTCPeerConnectionHandler::removeStream):
(MockWebRTCPeerConnectionHandler::getStats):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

  • DumpRenderTree/chromium/WebUserMediaClientMock.cpp:

(UserMediaRequestTask::UserMediaRequestTask):
(WebUserMediaClientMock::requestUserMedia):

10:54 AM Changeset in webkit [141443] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Objective-C API: Fix insertion of values greater than the max index allowed by the spec
​https://bugs.webkit.org/show_bug.cgi?id=108264

Reviewed by Oliver Hunt.

Fixed a bug, added a test to the API tests, cleaned up some code.

  • API/JSValue.h: Changed some of the documentation on setValue:atIndex: to indicate that

setting values at indices greater than UINT_MAX - 1 wont' affect the length of JS arrays.

  • API/JSValue.mm:

(-[JSValue valueAtIndex:]): We weren't returning when we should have been.
(-[JSValue setValue:atIndex:]): Added a comment about why we do the early check for being larger than UINT_MAX.
(objectToValueWithoutCopy): Removed two redundant cases that were already checked previously.

  • API/tests/testapi.mm:
10:54 AM Changeset in webkit [141442] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit2

Unreviewed trivial build fix: Pre C++11 the use of

in nested templates is ambiguous in the grammar and

requires the insertion of a space here. Since these files are
not Mac specific we don't require C++11 yet and a space
fixes the build.

  • Platform/CoreIPC/Connection.h:

(Connection):

  • Shared/ChildProcessProxy.h:

(ChildProcessProxy):

10:50 AM Changeset in webkit [141441] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

REGRESSION (r141402): incorrectly set injected bundle path when running GTK unit tests
​https://bugs.webkit.org/show_bug.cgi?id=108496

Reviewed by Philippe Normand.

  • Scripts/run-gtk-tests:

(TestRunner.init): Add the build type as a member on the TestRunner interface.
(TestRunner._setup_testing_environment): Use the build type member to determine correct path
to the injected bundle.

10:46 AM Changeset in webkit [141440] by fmalita@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
10:43 AM Changeset in webkit [141439] by commit-queue@webkit.org
  • 29 edits
    14 deletes in trunk

[EFL] Disable Web Intents
​https://bugs.webkit.org/show_bug.cgi?id=108457

Patch by Christophe Dumez <​dchris@gmail.com> on 2013-01-31
Reviewed by Alexey Proskuryakov.

.:

Turn off WEB_INTENTS flag in EFL CMake project.

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit:

Remove intents files from EFL CMake project.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Remove code related to Web Intents from EFL
WebKit.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:
  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

  • ewk/EWebKit.h:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_frame.h:
  • ewk/ewk_frame_private.h:
  • ewk/ewk_intent.cpp: Removed.
  • ewk/ewk_intent.h: Removed.
  • ewk/ewk_intent_private.h: Removed.
  • ewk/ewk_intent_request.cpp: Removed.
  • ewk/ewk_intent_request.h: Removed.

Source/WebKit2:

Remove code related to Web Intents from EFL
WebKit2.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/EwkViewCallbacks.h:
  • UIProcess/API/efl/ewk_intent.cpp: Removed.
  • UIProcess/API/efl/ewk_intent.h: Removed.
  • UIProcess/API/efl/ewk_intent_private.h: Removed.
  • UIProcess/API/efl/ewk_intent_service.cpp: Removed.
  • UIProcess/API/efl/ewk_intent_service.h: Removed.
  • UIProcess/API/efl/ewk_intent_service_private.h: Removed.
  • UIProcess/API/efl/ewk_view.cpp:
  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/resources/intent-request.html: Removed.
  • UIProcess/API/efl/tests/resources/intent-service.html: Removed.
  • UIProcess/API/efl/tests/test_ewk2_intents.cpp: Removed.
  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::PageLoadClientEfl):

  • UIProcess/efl/PageLoadClientEfl.h:

(PageLoadClientEfl):

Tools:

Remove EFL DRT code related to Web intents.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
(DumpRenderTreeChrome::onFrameCreated):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::sendWebIntentResponse):
(TestRunner::deliverWebIntent):

  • Scripts/webkitperl/FeatureList.pm: Turn off WEB_INTENTS flag

for EFL port.

LayoutTests:

Skip webintents/ test cases for EFL port now that
the feature is disabled.

  • platform/efl/TestExpectations:
10:39 AM Changeset in webkit [141438] by alecflett@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

IndexedDB: Remove WebKit API for old onSuccess/onUpgradeNeeded
​https://bugs.webkit.org/show_bug.cgi?id=108399

Reviewed by Dimitri Glazkov.

Cleanup now that chromium proxies the new signatures through.

  • src/IDBCallbacksProxy.cpp:

(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):

  • src/IDBCallbacksProxy.h:

(IDBCallbacksProxy):

  • src/WebIDBCallbacksImpl.cpp:
  • src/WebIDBCallbacksImpl.h:

(WebIDBCallbacksImpl):

10:38 AM Changeset in webkit [141437] by tony@chromium.org
  • 118 edits
    1 delete in trunk/LayoutTests

[chromium] Unreviewed, land baselines with textarea resizer enabled.
​https://bugs.webkit.org/show_bug.cgi?id=108383

  • platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.png: Removed.
  • platform/chromium-mac-lion/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac-lion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac-lion/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac-lion/fast/forms/basic-textareas-quirks-expected.png:
  • platform/chromium-mac-lion/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-lion/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/chromium-mac-lion/fast/forms/negativeLineHeight-expected.png:
  • platform/chromium-mac-lion/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-lion/fast/forms/textAreaLineHeight-expected.png:
  • platform/chromium-mac-lion/fast/forms/textarea-align-expected.png:
  • platform/chromium-mac-lion/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-lion/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/chromium-mac-lion/fast/forms/textarea-scroll-height-expected.png:
  • platform/chromium-mac-lion/fast/forms/textarea-scrollbar-expected.png:
  • platform/chromium-mac-lion/fast/forms/textarea-scrolled-type-expected.png:
  • platform/chromium-mac-lion/fast/forms/textarea-setinnerhtml-expected.png:
  • platform/chromium-mac-lion/fast/forms/textarea-width-expected.png:
  • platform/chromium-mac-lion/fast/overflow/overflow-x-y-expected.png:
  • platform/chromium-mac-lion/fast/parser/entity-comment-in-textarea-expected.png:
  • platform/chromium-mac-lion/fast/parser/open-comment-in-textarea-expected.png:
  • platform/chromium-mac-lion/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-mac-lion/fast/table/003-expected.png:
  • platform/chromium-mac-lion/fast/text/international/rtl-white-space-pre-wrap-expected.png:
  • platform/chromium-mac-lion/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug194024-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug30559-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug30692-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-quirks-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/negativeLineHeight-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textAreaLineHeight-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textarea-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textarea-scroll-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textarea-scrollbar-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textarea-scrolled-type-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textarea-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/overflow/overflow-x-y-expected.png:
  • platform/chromium-mac-snowleopard/fast/parser/entity-comment-in-textarea-expected.png:
  • platform/chromium-mac-snowleopard/fast/parser/open-comment-in-textarea-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/003-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/rtl-white-space-pre-wrap-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug194024-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug30559-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug30692-expected.png:
  • platform/chromium-mac/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/chromium-mac/fast/forms/negativeLineHeight-expected.png:
  • platform/chromium-mac/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/chromium-mac/fast/forms/textarea-align-expected.png:
  • platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/chromium-mac/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/chromium-mac/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/chromium-mac/fast/forms/textarea-scroll-height-expected.png:
  • platform/chromium-mac/fast/forms/textarea-scrollbar-expected.png:
  • platform/chromium-mac/fast/forms/textarea-scrolled-type-expected.png:
  • platform/chromium-mac/fast/forms/textarea-setinnerhtml-expected.png:
  • platform/chromium-mac/fast/forms/textarea-width-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-x-y-expected.png:
  • platform/chromium-mac/fast/parser/entity-comment-in-textarea-expected.png:
  • platform/chromium-mac/fast/parser/open-comment-in-textarea-expected.png:
  • platform/chromium-mac/fast/repaint/textarea-set-disabled-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-mac/fast/table/003-expected.png:
  • platform/chromium-mac/fast/text/international/rtl-white-space-pre-wrap-expected.png:
  • platform/chromium-mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug194024-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug30692-expected.png:
  • platform/chromium-win/editing/inserting/4960120-1-expected.png:
  • platform/chromium-win/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-win/fast/block/float/overhanging-tall-block-expected.png:
  • platform/chromium-win/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-win/fast/forms/basic-textareas-expected.png:
  • platform/chromium-win/fast/forms/basic-textareas-quirks-expected.png:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-win/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/chromium-win/fast/forms/negativeLineHeight-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.png:
  • platform/chromium-win/fast/forms/textAreaLineHeight-expected.png:
  • platform/chromium-win/fast/forms/textarea-align-expected.png:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/chromium-win/fast/forms/textarea-scroll-height-expected.png:
  • platform/chromium-win/fast/forms/textarea-scrollbar-expected.png:
  • platform/chromium-win/fast/forms/textarea-scrolled-type-expected.png:
  • platform/chromium-win/fast/forms/textarea-setinnerhtml-expected.png:
  • platform/chromium-win/fast/forms/textarea-width-expected.png:
  • platform/chromium-win/fast/overflow/overflow-x-y-expected.png:
  • platform/chromium-win/fast/parser/entity-comment-in-textarea-expected.png:
  • platform/chromium-win/fast/parser/open-comment-in-textarea-expected.png:
  • platform/chromium-win/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-win/fast/table/003-expected.png:
  • platform/chromium-win/fast/text/international/rtl-white-space-pre-wrap-expected.png:
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug194024-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug30559-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug30692-expected.png:
  • platform/chromium/TestExpectations:
10:34 AM Changeset in webkit [141436] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: searching for <u> in elements panel finds all tags containing "u"
​https://bugs.webkit.org/show_bug.cgi?id=108176

Patch by Dmitry Zvorygin <​zvorygin@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.

When searching for tag name check that tag name must either start from
search query, or must end with it.

Source/WebCore:

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

LayoutTests:

  • inspector/elements/elements-panel-search-expected.txt:
  • inspector/elements/elements-panel-search.html:
10:32 AM Changeset in webkit [141435] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Disable force_static_libs_as_shared in developer builds if wk2 is enabled

Reviewed by Jocelyn Turcotte.

This is a temporary workaround during the development of #108471, where we move files around
but some link time dependencies might remain.

  • qmake/mkspecs/features/default_post.prf:
10:24 AM Changeset in webkit [141434] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a flaky crasher expectation for fast/css-generated-content/block-and-box-hit-testing.html.
Removing failure expectations for SVGViewSpec tests.

  • platform/gtk-wk1/TestExpectations:
  • platform/gtk/TestExpectations:
10:22 AM Changeset in webkit [141433] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/12695827> PPT: Make loading file URLs work with a sandboxed NetworkProcess

Address review comments.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
10:18 AM Changeset in webkit [141432] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Stop using OutgoingMessage
​https://bugs.webkit.org/show_bug.cgi?id=108495

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::sendOutgoingMessages):

  • Platform/CoreIPC/Connection.h:

(Connection):

  • Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::~ChildProcessProxy):
(WebKit::ChildProcessProxy::sendMessage):
(WebKit::ChildProcessProxy::didFinishLaunching):

  • Shared/ChildProcessProxy.h:

(ChildProcessProxy):

10:12 AM Changeset in webkit [141431] by mark.lam@apple.com
  • 4 edits in trunk/Source/WebCore

DatabaseContext needs to outlive the ScriptExecutionContext.
​https://bugs.webkit.org/show_bug.cgi?id=108355.

Reviewed by Geoffrey Garen.

Added a RefPtr<DatabaseContext> in ScriptExecutionContext to keep the
DatabaseContext alive until after ScriptExecutionContext destructs.

No new tests.

  • Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::DatabaseContext):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::setDatabaseContext):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

10:04 AM Changeset in webkit [141430] by Simon Hausmann
  • 8 edits
    1 copy
    1 add in trunk

[Qt] Make it possible to compile WebKit2 Qt related files without access to internal WK2 C++ API
​https://bugs.webkit.org/show_bug.cgi?id=108472

Reviewed by Andreas Kling.

.:

When linking WebKit2, also link the WebKit2QML module.

  • Source/api.pri:

Source/WebKit2:

Add a new module to the qmake build system that represents the part of the WebKit2 Qt integration
that doesn't depend on WebKit2 internals.

Changed qwebnavigationhistory.cpp to not use any internal headers and compile it as part of the
internals-free module.

  • Target.pri:
  • UIProcess/API/qt/qwebnavigationhistory.cpp:
  • WebKit2.pro:
  • WebKit2QML.pri: Added.

Tools:

Add a new module to the qmake build system that represents the part of the WebKit2 Qt integration
that doesn't depend on WebKit2 internals.

  • qmake/mkspecs/features/webkit_modules.prf:
  • qmake/mkspecs/modules/webkit2qml.prf: Copied from Source/WebKit2/WebKit2.pro.
9:59 AM Changeset in webkit [141429] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebCore

On Linux, can't get spelling suggestions without selection when unified text checker is enabled
​https://bugs.webkit.org/show_bug.cgi?id=107684

Reviewed by Ryosuke Niwa.

No new tests, covered by context-menu-suggestions.html.

  • editing/Editor.cpp:

(WebCore::Editor::guessesForMisspelledOrUngrammatical):
For Linux, extend selection range to the closest word to get
the spelling suggestions when unified text checker is enabled.

9:44 AM Changeset in webkit [141428] by commit-queue@webkit.org
  • 7 edits in trunk

[chromium] Remove dead transitional code from WebViewImpl
​https://bugs.webkit.org/show_bug.cgi?id=107889

Patch by James Robinson <​jamesr@chromium.org> on 2013-01-31
Reviewed by Adam Barth.

Source/WebKit/chromium:

The chromium side of this landed at r178256 and seems stable.

  • public/WebWidget.h:

(WebKit::WebWidget::setCompositorSurfaceReady):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::~WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::setIsTransparent):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::FakeWebViewClient::initializeLayerTreeView):
(FakeWebViewClient):
(WebKit::FakeWebViewClient::layerTreeView):
(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(ScrollingCoordinatorChromiumTest):

Tools:

ScrollingCoordinatorChromiumTests need to initialize compositing, so its implementation of
WebWidgetClient has to support the new compositor initialization path.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::initializeLayerTreeView):
(WebViewHost::setWebWidget):

9:36 AM Changeset in webkit [141427] by fmalita@chromium.org
  • 2 edits in trunk/Source/WebCore

[Skia] Update SkiaImageFilterBuilder's brightness matrix to match Chromium's implementation
​https://bugs.webkit.org/show_bug.cgi?id=107841

Reviewed by Stephen White.

Update Skia's brightness filter to match the spec after ​http://trac.webkit.org/changeset/139770.

No new tests: covered by existing tests (currently disabled pending rebaseline).

  • platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp:
9:17 AM Changeset in webkit [141426] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: show cursor location in DTE
​https://bugs.webkit.org/show_bug.cgi?id=108478

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.

Add a new status bar element to SourceFrame to display current
DefaultTextEditor cursor position.

No new tests.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype.copyRange):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.statusBarItems):
(WebInspector.SourceFrame.prototype.selectionChanged):
(WebInspector.SourceFrame.prototype._updateSourcePosition):

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.copyRange):

  • inspector/front-end/inspector.css:

(.source-frame-position):

8:45 AM Changeset in webkit [141425] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs an implementation of eventSender.beginDragWithFiles
​https://bugs.webkit.org/show_bug.cgi?id=64285

  • platform/wk2/TestExpectations:

Skip another test that uses eventSender.beginDragWithFiles.

8:33 AM Changeset in webkit [141424] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: overlay highlight in DTE gets messed up when zoom factor changes.
​https://bugs.webkit.org/show_bug.cgi?id=108486

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.

Repaint overlay highlight when zoom factor changes.

No new tests.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype.highlightRegex):
(WebInspector.TextEditorMainPanel.prototype.removeHighlight):
(WebInspector.TextEditorMainPanel.prototype.highlightRange):
(WebInspector.TextEditorMainPanel.prototype._repaintLineRowsAffectedByHighlightDescriptors):
(WebInspector.TextEditorMainPanel.prototype.resize):

8:13 AM Changeset in webkit [141423] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a failing test after r141269.
​https://bugs.webkit.org/show_bug.cgi?id=108481.
Renamed inspector/editor/text-editor-ctrl-movements.html after r141399.

  • platform/qt/TestExpectations:
7:48 AM PortIntegrationArchitectureIssues edited by Noam Rosenthal
(diff)
7:40 AM PortIntegrationArchitectureIssues created by Noam Rosenthal
7:16 AM Changeset in webkit [141422] by Lucas Forschler
  • 1 copy in tags/Safari-537.29

New Tag.

7:16 AM Changeset in webkit [141421] by Lucas Forschler
  • 1 delete in tags/Safari-537.29

Remove Tag.

7:07 AM Changeset in webkit [141420] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Fix minor memory leak in slot execution

Reviewed by Allan Sandfeld Jensen.

Don't leak the "length" string when executing a slot in JavaScript.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtConnectionObject::execute):

6:59 AM Changeset in webkit [141419] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

Unreviewed trivial build fix: Add missing virtual destructor to
LayerTreeRendererClient. Otherwise the build with -Werror breaks, which
complains (rightly so) that we're deleting a sub-class where the super class
doesn't have a virtual destructor.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(WebKit::LayerTreeRendererClient::~LayerTreeRendererClient):

6:57 AM Changeset in webkit [141418] by mkwst@chromium.org
  • 13 edits
    12 adds in trunk

Allow blocking of IndexedDB in third-party contexts
​https://bugs.webkit.org/show_bug.cgi?id=94171

Reviewed by Jochen Eisinger.

Source/WebCore:

This patch ensures that the origin of the top window is passed into
SecurityOrigin::canAccessDatabase when working with IndexedDB. Giving
SecurityOrigin access to this data means that it can properly check
whether the database is being opened in a third-party context, and
therefore properly enforce the third-party access checks that were
added in ​http://trac.webkit.org/changeset/125736.

Third-party checks are added to IDBFactory::open,
IDBFactory::deleteDatabase, and IDBFactory::getDatabaseNames; each will
now throw a SECURITY_ERR exception when access in a third-party context
if third-party access checks are enabled.

To make this process slightly more clear, and avoid some ugly casting
logic, this patch adds a 'topOrigin' method to ScriptExecutionContext,
and implements it on both WorkerContext and Document.

Tests: http/tests/security/cross-origin-indexeddb-allowed.html

http/tests/security/cross-origin-indexeddb.html
http/tests/security/cross-origin-worker-indexeddb-allowed.html
http/tests/security/cross-origin-worker-indexeddb.html

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):

Grab the SecurityOrigin of the current context's top-level origin,
and pass it to SecurityOrigin::canAccessDatabase to ensure that
access checks are properly applied to these three methods.

  • dom/Document.cpp:

(WebCore::Document::topOrigin):
(WebCore):

  • dom/Document.h:

(Document):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

Add a topOrigin() method to ScriptExecutionContext, and implement it
on Document in order to give callers access to the top document's
SecurityOrigin without casting ScriptExecutionContext.

  • workers/WorkerContext.h:

Change the existing topOrigin() method to override the new method
on ScriptExecutionContext.

LayoutTests:

Add tests to ensure that IndexedDB can be blocked in a third-party
context in both normal documents and in workers. These tests are
modeled after the existing cross-origin-websql* tests; it might be
possible to reuse some code in the future.

  • http/tests/security/cross-origin-indexeddb-allowed-expected.txt: Added.
  • http/tests/security/cross-origin-indexeddb-allowed.html: Added.
  • http/tests/security/cross-origin-indexeddb-expected.txt: Added.
  • http/tests/security/cross-origin-indexeddb.html: Added.
  • http/tests/security/cross-origin-worker-indexeddb-allowed-expected.txt: Added.
  • http/tests/security/cross-origin-worker-indexeddb-allowed.html: Added.
  • http/tests/security/cross-origin-worker-indexeddb-expected.txt: Added.
  • http/tests/security/cross-origin-worker-indexeddb.html: Added.
  • http/tests/security/resources/cross-origin-iframe-for-indexeddb.html: Added.
  • http/tests/security/resources/cross-origin-iframe-for-worker-indexeddb.html: Added.
  • http/tests/security/resources/document-for-cross-origin-worker-indexeddb.html: Added.
  • http/tests/security/resources/worker-for-indexeddb.js: Added.

(self.onmessage):

Add exciting new tests, with more boilerplate than I expected!

  • platform/efl/TestExpectations:
  • platform/mac-snowleopard/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:

Skip these IndexedDB tests on platforms where the feature isn't
enabled.

6:52 AM Changeset in webkit [141417] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Network] Add cookie column to show presence of request/response cookies.
​https://bugs.webkit.org/show_bug.cgi?id=107441

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.

In some use cases only responses that contain "set-cookie" headers
are interesting.

  • English.lproj/localizedStrings.js: Added "Set-Cookies" string.
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createTable): Added columns.
(WebInspector.NetworkLogView.prototype._createSortingFunctions): Ditto.
(WebInspector.NetworkDataGridNode.prototype.createCells): Ditto.
(WebInspector.NetworkDataGridNode.prototype.refreshRequest): Ditto.
(WebInspector.NetworkDataGridNode.prototype._refreshCookiesCell): Added.
(WebInspector.NetworkDataGridNode.prototype._refreshSetCookiesCell): Added.
(WebInspector.NetworkDataGridNode.RequestCookiesCountComparator): Added.
(WebInspector.NetworkDataGridNode.ResponseCookiesCountComparator): Added.

6:30 AM Changeset in webkit [141416] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip two compositing tests, because They hit assertion fail after 140999.
​https://bugs.webkit.org/show_bug.cgi?id=108257.

  • platform/qt/TestExpectations:
6:15 AM Changeset in webkit [141415] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Exception in HeapSnapshotView.js
​https://bugs.webkit.org/show_bug.cgi?id=108456

Reviewed by Yury Semikhatsky.

Listen "profile added" events in the HeapSnapshotView targeted only to the Heap Snapshot type.

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype._onProfileHeaderAdded):

6:10 AM Changeset in webkit [141414] by commit-queue@webkit.org
  • 7 edits in trunk

Web Inspector: do not set any textContent in overlay highlight spans
​https://bugs.webkit.org/show_bug.cgi?id=108460

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.

Source/WebCore:

Do not set any text content for overlay highlight spans to implicitly
set its height. Instead, measure its height in the same manner as its
done for "width" and "left" and set it explicitly.

No new tests: no change in behaviour.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
(WebInspector.TextEditorMainPanel.ElementMetrics):

  • inspector/front-end/textEditor.css:

(.text-editor-token-highlight): Update highlight to correspond to
slightly different elements height.

LayoutTests:

Replace "height" pixel value with "<number>" to avoid difference in
test expectations on varioius platforms and correct test expectations.

  • inspector/editor/editor-test.js:

(initialize_EditorTests.InspectorTest.dumpEditorHTML):

  • inspector/editor/text-editor-highlight-api-expected.txt:
  • inspector/editor/text-editor-highlight-token-expected.txt:
6:07 AM Changeset in webkit [141413] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Box shadows on a transparency layer is very slow
​https://bugs.webkit.org/show_bug.cgi?id=107547

Reviewed by Noam Rosenthal.

Include the window boundaries in the clip returned by GraphicsContext,
since QPainter may remember clips larger than the destination, but
ShadowBlur uses the clipBounds to determine the size of the shadow layer.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::clipBounds):

6:07 AM Changeset in webkit [141412] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: view the debug border/repaint count of the non composited layer.
​https://bugs.webkit.org/show_bug.cgi?id=108401

Patch by Seulgi Kim <​seulgikim@company100.net> on 2013-01-31
Reviewed by Noam Rosenthal.

Make non-compositing layer draw debug border and show repaint counter
accroding to settings.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):

6:05 AM Changeset in webkit [141411] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: highlight backend languages as scripts
​https://bugs.webkit.org/show_bug.cgi?id=108336

Reviewed by Vsevolod Vlasov.

Most languages have structure similar to js, so enabling default highlighter for them won't hurt.

  • inspector/front-end/FileSystemWorkspaceProvider.js:

(WebInspector.FileSystemWorkspaceProvider.prototype._contentTypeForPath):

5:58 AM EFLWebKitBuildBots edited by dchris@gmail.com
(diff)
5:57 AM EFLWebKitBuildBots edited by dchris@gmail.com
(diff)
5:56 AM WebKit Team edited by dchris@gmail.com
Update my affiliation. (diff)
5:48 AM Changeset in webkit [141410] by akling@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Unjumble ChangeLog authors after r141407.

5:42 AM Changeset in webkit [141409] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Profiles] show launcher view upon deleting last profile type's header
​https://bugs.webkit.org/show_bug.cgi?id=108468

Reviewed by Pavel Feldman.

We should show launcher view and hide profile type sidebar section upon deleting last profile type's header from the sidebar.
Right now we only show launcher view upon deleting the last profile header (of any profile type).

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._removeProfileHeader):

5:39 AM Changeset in webkit [141408] by fmalita@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png:
5:34 AM Changeset in webkit [141407] by akling@apple.com
  • 7 edits in trunk/Source

Vector should consult allocator about ideal size when choosing capacity.
<​http://webkit.org/b/108410>
<rdar://problem/13124002>

Source/JavaScriptCore:

Patch by Filip Pizlo <​fpizlo@apple.com> on 2013-01-30
Reviewed by Benjamin Poulain.

Remove assertion about Vector capacity that won't hold anymore since capacity()
may not be what you passed to reserveCapacity().

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

Source/WTF:

Reviewed by Benjamin Poulain.

Added WTF::fastMallocGoodSize(), a workalike/wrapper for OS X's malloc_good_size().
It returns the actual size of the block that will get allocated for a given byte size.

Vector's internal buffer now checks with the allocator if the resulting allocation
could actually house more objects and updates its capacity to make use of the space.

  • wtf/Deque.h:

(WTF::::expandCapacity):

  • wtf/FastMalloc.cpp:

(WTF::fastMallocGoodSize):

  • wtf/FastMalloc.h:
  • wtf/Vector.h:

(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):

5:25 AM Changeset in webkit [141406] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Network] Columns are misaligned as first row goes out of sight.
​https://bugs.webkit.org/show_bug.cgi?id=107933

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.

For some reason if "td" elements in first table row have "display: none"
style, then column width calculation breaks.

  • inspector/front-end/networkLogView.css:

(.network-log-grid.data-grid tr.offscreen > td > div):
Hide content instead of "td" element itself.

5:01 AM Changeset in webkit [141405] by Vineet
  • 5 edits
    2 adds in trunk

formMethod to have empty string as default value and 'get' as invalid.
​https://bugs.webkit.org/show_bug.cgi?id=108263

Reviewed by Kent Tamura.

The spec says formmethod should only have an invalid value default, not a missing value default.
Spec: ​http://www.whatwg.org/specs/web-apps/current-work/#form-submission-0

​http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-formmethod

Source/WebCore:

Test: fast/forms/formmethod-attribute-test.html

  • html/HTMLFormControlElement.cpp: For the missing formMethod attr return empty string.

(WebCore::HTMLFormControlElement::formMethod):

LayoutTests:

  • fast/forms/formmethod-attribute-test-expected.txt: Added.
  • fast/forms/formmethod-attribute-test.html: Added.
  • fast/forms/submit-form-attributes-expected.txt:
  • fast/forms/submit-form-attributes.html: Modified test to behave as expected.
4:47 AM Changeset in webkit [141404] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source/WebCore

[Efl][WebGL] Add better support to track and free XResources.
​https://bugs.webkit.org/show_bug.cgi?id=107397

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2013-01-20
Reviewed by Noam Rosenthal.

We leak Memory during config selection as we dont free temporary
allocated visuals, config etc. This patch ensures that we dont leak any
memory.

Covered by existing WebGL tests.

  • platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):

  • platform/graphics/surfaces/glx/GLXConfigSelector.h:

(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::visualInfo):
(WebCore::GLXConfigSelector::pBufferContextConfig):
(WebCore::GLXConfigSelector::surfaceContextConfig):
(WebCore::GLXConfigSelector::createSurfaceConfig):
(GLXConfigSelector):
Removed XVisualInfo as member variable. Fixed memory leaks.

  • platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore::GLXTransportSurface::GLXTransportSurface):

  • platform/graphics/surfaces/glx/OwnPtrX11.h: Added.

(OwnPtrX11):
(WebCore::OwnPtrX11::OwnPtrX11):
(WebCore::OwnPtrX11::~OwnPtrX11):
(WebCore::OwnPtrX11::operator=):
(WebCore::OwnPtrX11::operator T*):
(WebCore::OwnPtrX11::operator->):
(WebCore::OwnPtrX11::get):
Calls XFree on pointer to memory allocated by X when the class goes out of scope.
OwnPtr cannot be used here as GLXFBConfig is a pointer to an array of pointers.

  • platform/graphics/surfaces/glx/X11WindowResources.cpp:

(WebCore::X11OffScreenWindow::X11OffScreenWindow):
(WebCore::X11OffScreenWindow::~X11OffScreenWindow):
(WebCore):
(WebCore::X11OffScreenWindow::createOffScreenWindow):
(WebCore::X11OffScreenWindow::destroyWindow):
(WebCore::X11OffScreenWindow::nativeSharedDisplay):

  • platform/graphics/surfaces/glx/X11WindowResources.h:

(X11OffScreenWindow):
Removed unused code. Fixed memory leaks.

4:45 AM Changeset in webkit [141403] by aandrey@chromium.org
  • 11 edits in trunk

Web Inspector: [Canvas] remove invalid canvas profile trace logs upon frame navigation
​https://bugs.webkit.org/show_bug.cgi?id=108454

Reviewed by Pavel Feldman.

Source/WebCore:

When canvas profile trace logs stored in the backend get destroyed (for example, on frame navigation), send an event to frontend and update the UI.
Drive-by: replace String types to corresponding TypeBuilder::Canvas::* typedefs.

  • inspector/InjectedScriptCanvasModule.cpp:

(WebCore::InjectedScriptCanvasModule::captureFrame):
(WebCore::InjectedScriptCanvasModule::startCapturing):
(WebCore::InjectedScriptCanvasModule::callStartCapturingFunction):
(WebCore::InjectedScriptCanvasModule::stopCapturing):
(WebCore::InjectedScriptCanvasModule::dropTraceLog):
(WebCore::InjectedScriptCanvasModule::callVoidFunctionWithTraceLogIdArgument):
(WebCore::InjectedScriptCanvasModule::traceLog):
(WebCore::InjectedScriptCanvasModule::replayTraceLog):
(WebCore::InjectedScriptCanvasModule::resourceInfo):
(WebCore::InjectedScriptCanvasModule::resourceState):

  • inspector/InjectedScriptCanvasModule.h:

(InjectedScriptCanvasModule):

  • inspector/Inspector.json:
  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::dropTraceLog):
(WebCore::InspectorCanvasAgent::stopCapturing):
(WebCore::InspectorCanvasAgent::getTraceLog):
(WebCore::InspectorCanvasAgent::replayTraceLog):
(WebCore::InspectorCanvasAgent::getResourceInfo):
(WebCore::InspectorCanvasAgent::getResourceState):
(WebCore::InspectorCanvasAgent::frameNavigated):

  • inspector/InspectorCanvasAgent.h:

(InspectorCanvasAgent):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::hasIdForFrame):
(WebCore):

  • inspector/InspectorPageAgent.h:

(InspectorPageAgent):

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileType.prototype._runSingleFrameCapturing):
(WebInspector.CanvasProfileType.prototype._startFrameCapturing):
(WebInspector.CanvasProfileType.prototype._didStartCapturingFrame):
(WebInspector.CanvasProfileType.prototype._traceLogsRemoved):
(WebInspector.CanvasDispatcher.prototype.contextCreated):
(WebInspector.CanvasDispatcher.prototype.traceLogsRemoved):
(WebInspector.CanvasProfileHeader):
(WebInspector.CanvasProfileHeader.prototype.frameId):

LayoutTests:

  • inspector/profiler/canvas-profiler-test.js:

(initialize_CanvasWebGLProfilerTest.InspectorTest.enableCanvasAgent.InspectorBackend.registerCanvasDispatcher):

4:43 AM Changeset in webkit [141402] by kov@webkit.org
  • 3 edits in trunk/Tools

[GTK] run-gtk-tests does not respect the -d argument
​https://bugs.webkit.org/show_bug.cgi?id=107822

Reviewed by Philippe Normand.

  • Scripts/run-gtk-tests:

(TestRunner.init): use the value for the debug option to decide what
build_type to request a path for.

  • gtk/common.py:

(get_build_path): now accepts a build_type argument instead of trying both
Release and Debug in order, defaults to release.
(build_path): takes and passes a build_type argument, no default value.

4:04 AM Changeset in webkit [141401] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: DTE doesn't highlight words if the selected one is the last in the line
​https://bugs.webkit.org/show_bug.cgi?id=108344

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.

Source/WebCore:

Fix error in _isWord function which made an erroneous line-end check.

Improved test: inspector/editor/text-editor-highlight-token.html

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._isWord):

LayoutTests:

Add a test to cover specific case which caused the bug.

  • inspector/editor/text-editor-highlight-token-expected.txt:
  • inspector/editor/text-editor-highlight-token.html:
4:01 AM Changeset in webkit [141400] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

InjectedBundle is being built even with --disable-webkit2
​https://bugs.webkit.org/show_bug.cgi?id=108364

Patch by Paweł Forysiuk <​tuxator@o2.pl> on 2013-01-31
Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am: Wrap Injected bundle with ENABLE_WEBKIT2 condition
4:01 AM Changeset in webkit [141399] by commit-queue@webkit.org
  • 2 edits
    2 moves in trunk/LayoutTests

Web Inspector: text-editor-ctrl-movements.html timeouts on mac
​https://bugs.webkit.org/show_bug.cgi?id=108440

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.

Use "alt-arrows" key shortcuts to jump over words instead of
"ctrl-arrows" on Mac platform.

  • inspector/editor/text-editor-word-jumps-expected.txt: Renamed from LayoutTests/inspector/editor/text-editor-ctrl-movements-expected.txt.
  • inspector/editor/text-editor-word-jumps.html: Renamed from LayoutTests/inspector/editor/text-editor-ctrl-movements.html.
  • platform/chromium/TestExpectations: Do not skip this test anymore.
3:44 AM Changeset in webkit [141398] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, Qt build fix after r141265.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

Avoid uninitialized variable error when NATIVE_FULLSCREEN_VIDEO is disabled.

3:44 AM Changeset in webkit [141397] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Tools

Update Christophe Dumez's email address
​https://bugs.webkit.org/show_bug.cgi?id=108453

Patch by Christophe Dumez <​dchris@gmail.com> on 2013-01-31
Reviewed by Kenneth Rohde Christiansen.

Update my email address in committers.py.

  • Scripts/webkitpy/common/config/committers.py:
3:25 AM Changeset in webkit [141396] by yurys@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Web Inspector: test that references from DOM nodes to event listeners are presented in heap snapshots
​https://bugs.webkit.org/show_bug.cgi?id=108322

Reviewed by Vsevolod Vlasov.

Test that links from DOM node wrappers to event listener functions are presented
in heap snapshots.

  • inspector-protocol/heap-profiler/heap-snapshot-with-event-listener-expected.txt: Added.
  • inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html: Added.
3:17 AM Changeset in webkit [141395] by tkent@chromium.org
  • 13 edits
    2 adds in trunk

Click on a label element won't select input[type=date]
​https://bugs.webkit.org/show_bug.cgi?id=108428

Reviewed by Kentaro Hara.

Source/WebCore:

date/time input types with INPUT_MULTIPLE_FIELDS_UI are not
mouse-focusable. <input> as a shadow host never gets focus and
sub-fields in its shadow tree are focusable. Howevever, the click
handling of <label> checked isMouseFocusable. We introduce new function
isFocusableByClickOnLabel to HTMLElement. It's default implementation is
same as isMouseFocusable, and we add special handling for
BaseMultipleFieldsDateAndTimeInputType::isFocusableByClickOnLabel.

Also, date/time input types without INPUT_MULTIPLE_FIELDS_UI were not
mouse-focusable by a mistake. It should be mouse-focusable.

Test: fast/forms/date/date-click-on-label.html

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::isFocusableByClickOnLabel):
Added. Just calls isMouseFocusable.

  • html/HTMLElement.h:

(HTMLElement): Declare isFocusableByClickOnLabel.

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::defaultEventHandler):
Calls isFocusableByClickOnLabel instead of isMouseFocusable.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isFocusableByClickOnLabel):
Delegate to InputType::isFocusableByClickOnLabel.

  • html/HTMLInputElement.h:

(HTMLInputElement): Declare isFocusableByClickOnLabel.

  • html/InputType.cpp:

(WebCore::InputType::isFocusableByClickOnLabel):
Added. Calls isMouseFocusable.

  • html/InputType.h:

(InputType): Declare isFocusableByClickOnLabel.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::isFocusableByClickOnLabel):
Added. Use the same logic with textfields.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Declare isFocusableByClickOnLabel.

  • html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::isMouseFocusable):
Added. Use the same logic with textfields.

  • html/BaseChooserOnlyDateAndTimeInputType.h:

(BaseChooserOnlyDateAndTimeInputType): Declare isMouseFocusable.

LayoutTests:

  • fast/forms/date/date-click-on-label-expected.txt: Added.
  • fast/forms/date/date-click-on-label.html: Added.
3:10 AM Changeset in webkit [141394] by haraken@chromium.org
  • 6 edits in trunk/Source

Rename WheelEvent::Granularity to WheelEvent::DeltaMode
​https://bugs.webkit.org/show_bug.cgi?id=108434

Reviewed by Ryosuke Niwa.

Per the spec, WheelEvent::Granularity should be renamed to WheelEvent::DeltaMode.

Spec: ​http://www.w3.org/TR/DOM-Level-3-Events/#events-WheelEvent
​https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent

No tests. No change in behavior.

Source/WebCore:

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::deltaMode):
(WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):

  • dom/WheelEvent.h:

(WebCore::WheelEvent::create):
(WebCore::WheelEvent::deltaMode):
(WheelEvent):

  • page/EventHandler.cpp:

(WebCore::wheelGranularityToScrollGranularity):
(WebCore::EventHandler::defaultWheelEventHandler):

Source/WebKit/chromium:

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):

2:52 AM Changeset in webkit [141393] by yurys@chromium.org
  • 4 edits
    3 adds in trunk

Web Inspector: test that nodes from the same detached DOM tree will get into one group in heap snapshot
​https://bugs.webkit.org/show_bug.cgi?id=108202

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html

  • inspector/front-end/JSHeapSnapshot.js:

(WebInspector.JSHeapSnapshotNode.prototype.className): removed unnecessary i18n.

LayoutTests:

Test that JS wrappers for all DOM nodes from the same detached DOM tree will get into
single "Detached DOM Tree" entry in the JS heap snapshot.

  • http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorTest.importScript):

  • inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree-expected.txt: Added.
  • inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html: Added. I started

with writing simplified version of WebInspector.JSHeapSnapshot just for tests
but it soon it became clear that we would need to reimplement too much functionality
of WebInspector.JSHeapSnapshot so I decided not to reinvent the wheel and just import
original heap snapshot model.

  • inspector-protocol/heap-profiler/resources/heap-snapshot-common.js: Added.

(InspectorTest.takeHeapSnapshot):

2:02 AM Changeset in webkit [141392] by jochen@chromium.org
  • 5 edits in trunk/Tools

[chromium] move runModalBeforeUnloadDialog to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=108442

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):

  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
1:46 AM Changeset in webkit [141391] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Bump Chromium dependency to 179332

  • DEPS:
12:52 AM Changeset in webkit [141390] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Trace not only major DOM GCs but also minor DOM GCs
​https://bugs.webkit.org/show_bug.cgi?id=108436

Reviewed by Adam Barth.

Currently only major DOM GCs are traced.
We should also trace minor DOM GCs.

No tests. No change in behavior.

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::minorGCEpilogue):

12:49 AM Changeset in webkit [141389] by mikhail.pozdnyakov@intel.com
  • 8 edits in trunk/Source/WebKit2

[EFL][WK2] RequestManagerClientEfl, DownloadManagerEfl and ContextHistoryClientEfl should be based on C API
​https://bugs.webkit.org/show_bug.cgi?id=107685

Reviewed by Benjamin Poulain.

RequestManagerClientEfl, DownloadManagerEfl and ContextHistoryClientEfl
should be based on C API so that API layering is not violated.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):

  • UIProcess/efl/ContextHistoryClientEfl.cpp:

(WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):
(WebKit::ContextHistoryClientEfl::~ContextHistoryClientEfl):

  • UIProcess/efl/ContextHistoryClientEfl.h:

(WebKit::ContextHistoryClientEfl::create):
(ContextHistoryClientEfl):

  • UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::DownloadManagerEfl):
(WebKit::DownloadManagerEfl::~DownloadManagerEfl):

  • UIProcess/efl/DownloadManagerEfl.h:

(WebKit::DownloadManagerEfl::create):
(DownloadManagerEfl):

  • UIProcess/efl/RequestManagerClientEfl.cpp:

(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):

  • UIProcess/efl/RequestManagerClientEfl.h:

(WebKit::RequestManagerClientEfl::create):
(RequestManagerClientEfl):

12:45 AM Changeset in webkit [141388] by yurys@chromium.org
  • 8 edits in trunk

Layout Test inspector-protocol/take-heap-snapshot.html crashes in the Debug mode
​https://bugs.webkit.org/show_bug.cgi?id=104800

Reviewed by Jochen Eisinger.

Source/WebCore:

The test crashed because during snapshot generation Profiler.reportHeapSnapshotProgress
events were sent to the inspector front-end, then parsed and dispatched there.
Since in case of layout tests the front-end resides in the same process
as the inspected page parsing the event broke an assumption that there are
no JS heap allocations while heap snapshot is being taken.

I added optional boolean parameter 'reportProgress' to Profiler.takeHeapSnapshot
command so that the protocol client can control whether progress events should
be sent during snapshot generation. The protocol test is not interested in the
progress events and sets reportProgress to false.

Test: inspector-protocol/heap-profiler/take-heap-snapshot.html

  • inspector/Inspector.json:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::takeHeapSnapshot):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):

LayoutTests:

Marked the test as not crashing in the debug mode.

  • inspector-protocol/heap-profiler/take-heap-snapshot.html:
  • platform/chromium/TestExpectations:
12:38 AM Changeset in webkit [141387] by commit-queue@webkit.org
  • 10 edits in trunk

Unreviewed, rolling out r141110.
​http://trac.webkit.org/changeset/141110
​https://bugs.webkit.org/show_bug.cgi?id=108349

This patch broke WK2-EFL unit tests (Requested by grzegorz on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-31

Source/WebCore:

  • platform/text/TextChecking.h:

(WebCore):

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.h:

Source/WebKit2:

  • UIProcess/efl/TextCheckerEfl.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:

LayoutTests:

  • platform/efl-wk2/TestExpectations:
12:33 AM Changeset in webkit [141386] by haraken@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

Add composition-event-constructor.html, which I forgot to add in r141028
​https://bugs.webkit.org/show_bug.cgi?id=107919

Reviewed by Adam Barth.

r141028 implemented a CompositionEvent constructor, but I forgot to add a test
when I landed the patch manually. This patch adds the test.

  • fast/events/constructors/composition-event-constructor-expected.txt: Added.
  • fast/events/constructors/composition-event-constructor.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
12:30 AM Changeset in webkit [141385] by jochen@chromium.org
  • 4 edits in trunk/Tools

[chromium] move postMessage related methods to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=108343

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::willCheckAndDispatchMessageEvent):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::willCheckAndDispatchMessageEvent):
(WebTestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::willCheckAndDispatchMessageEvent):

12:29 AM Changeset in webkit [141384] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source/WebKit2

Coordinated Graphics : Remove WebCoordinatedSurface dependency from CoordinatedSurface
​https://bugs.webkit.org/show_bug.cgi?id=108259

Patch by Jae Hyun Park <​jae.park@company100.net> on 2013-01-31
Reviewed by Noam Rosenthal.

This is a preparation patch for Threaded Coordinated Graphics.

WebCoordinatedSurface dependency should be removed from
CoordinatedSurface so as to share CoordinatedSurface between
WebCoordinatedSurface and CoordinatedSurface of WebKit1, which will be
implemented for Threaded Coordinated Graphics.

This patch introduces CoordinatedSurface::Factory, which is a function
pointer that creates CoordinatedSurfaces. CoordinatedLayerTreeHost sets
static CoordinatedSurface::Factory member variable. Classes that use
CoordinatedSurface, which are CoordinatedImageBacking and UpdateAtlas,
create CoordinatedSurfaces by calling CoordinatedSurface::create, which
will call the function set by CoordinatedLayerTreeHost.

This way, we can remove the WebCoordinatedSurface dependency from
CoordinatedSurface and be able to share the code in Threaded Coordinated
Graphics.

No new tests. No change in behavior.

  • CMakeLists.txt:
  • Shared/CoordinatedGraphics/CoordinatedSurface.cpp: Added.

(WebKit):
(WebKit::CoordinatedSurface::setFactory):
(WebKit::CoordinatedSurface::create):

  • Shared/CoordinatedGraphics/CoordinatedSurface.h:

(CoordinatedSurface):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
  • Target.pri:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::createCoordinatedSurface):
(WebKit):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
12:12 AM Changeset in webkit [141383] by haraken@chromium.org
  • 5 edits in trunk

[V8] 'new MouseEvent("click", {relatedTarget: window}).window' should return window
​https://bugs.webkit.org/show_bug.cgi?id=108432

Reviewed by Adam Barth.

In V8 'new MouseEvent("click", {relatedTarget: window}).window'
returns null. JSC returns window, which is a correct behavior.
V8 should also return window.

Source/WebCore:

The point is that we need to handle a DOMWindow wrapper specially
before converting it to an EventTarget object. A wrapper returned by
Dictionary::get("relatedTarget") is not an expected DOMWindow wrapper.
To get the expected DOMWindow wrapper, we need to look up a prototype
chain of the DOMWindow wrapper.

In JSC, this special handling is done by JSEventTargetCustom::toEventTarget().

Test: fast/events/constructors/mouse-event-constructor.html

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

LayoutTests:

  • fast/events/constructors/mouse-event-constructor-expected.txt:
  • fast/events/constructors/mouse-event-constructor.html:
12:05 AM Changeset in webkit [141382] by pilgrim@chromium.org
  • 6 edits
    1 move in trunk/Source

[Chromium] Move MediaPlayerPrivateChromium to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=108415

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/MediaPlayerPrivateChromium.cpp: Added.

(WebCore):
(WebCore::MediaPlayerPrivate::registerMediaEngine): call
registerMediaEngine through static function pointer that was set
during WebKit initializeWithoutV8
(WebCore::MediaPlayerPrivate::setMediaEngineRegisterSelfFunction):
new setter function that takes a function pointer that is used by registerMediaEngine

  • platform/graphics/chromium/MediaPlayerPrivateChromium.h:

(WebCore):
(MediaPlayerPrivate):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/MediaPlayerPrivateChromium.cpp: Removed.
  • src/WebKit.cpp:

(WebKit::initializeWithoutV8): call new setter function in
WebCore::MediaPlayerPrivate

12:00 AM Changeset in webkit [141381] by jochen@chromium.org
  • 6 edits in trunk/Tools

[chromium] move remaining resource load related methods to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=108334

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestRunner::WebTestDelegate::allowExternalPages):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::canHandleRequest):
(WebTestRunner::WebTestProxy::cannotHandleRequestError):
(WebTestRunner::WebTestProxy::didCreateDataSource):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::canHandleRequest):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::cannotHandleRequestError):
(WebTestRunner::WebTestProxyBase::didCreateDataSource):
(WebTestRunner::WebTestProxyBase::willSendRequest):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::canHandleRequest):
(WebViewHost::didCreateDataSource):
(WebViewHost::willSendRequest):
(WebViewHost::allowExternalPages):

  • DumpRenderTree/chromium/WebViewHost.h:
Note: See TracTimeline for information about the timeline view.