Timeline
Feb 2, 2013:
- 10:12 PM Changeset in webkit [141712] by
-
- 4 edits in trunk/Source
[chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.
This patch just alters the WebKitAPI in advance of coding to the new API in chromium and webkit
sources, defining two new virtual methods (unimplemented and uncalled). The existing API remains
in place and in use.
https://bugs.webkit.org/show_bug.cgi?id=108736
Reviewed by Darin Fisher.
Source/Platform:
- chromium/public/WebFileSystem.h:
(WebFileSystem):
(WebKit::WebFileSystem::createSnapshotFileAndReadMetadata):
Source/WebKit/chromium:
- public/WebFileSystemCallbacks.h:
(WebFileSystemCallbacks):
(WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):
- 5:14 PM Changeset in webkit [141711] by
-
- 24 edits in trunk/Source/WebKit2
Remove more LegacyReceivers
https://bugs.webkit.org/show_bug.cgi?id=108758
Reviewed by Anders Carlsson.
- UIProcess/Downloads/DownloadProxy.cpp:
- UIProcess/Downloads/DownloadProxy.messages.in:
- UIProcess/WebApplicationCacheManagerProxy.cpp:
- UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
- UIProcess/WebApplicationCacheManagerProxy.messages.in:
- UIProcess/WebCookieManagerProxy.cpp:
- UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
- UIProcess/WebCookieManagerProxy.messages.in:
- UIProcess/WebDatabaseManagerProxy.cpp:
- UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
- UIProcess/WebDatabaseManagerProxy.messages.in:
- UIProcess/mac/RemoteLayerTreeHost.h:
(RemoteLayerTreeHost):
- UIProcess/mac/RemoteLayerTreeHost.messages.in:
- UIProcess/mac/RemoteLayerTreeHost.mm:
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
(WebApplicationCacheManager):
- WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in:
- WebProcess/Cookies/WebCookieManager.cpp:
- WebProcess/Cookies/WebCookieManager.h:
(WebCookieManager):
- WebProcess/Cookies/WebCookieManager.messages.in:
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebDatabaseManager):
- WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
- 5:11 PM Changeset in webkit [141710] by
-
- 10 edits in trunk/Source/WebKit2
Convert CustomProtocolManagerProxy, CustomProtocolManager and AuthenticationManager to be non-LegacyReceivers
https://bugs.webkit.org/show_bug.cgi?id=108757
Reviewed by Anders Carlsson.
- Shared/Authentication/AuthenticationManager.cpp:
- Shared/Authentication/AuthenticationManager.h:
(AuthenticationManager):
- Shared/Authentication/AuthenticationManager.messages.in:
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
- Shared/Network/CustomProtocols/CustomProtocolManager.messages.in:
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
(CustomProtocolManagerProxy):
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in:
- UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:
- 4:14 PM Changeset in webkit [141709] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API inside ewk_file_chooser_request
https://bugs.webkit.org/show_bug.cgi?id=107811
Reviewed by Sam Weinig.
Use C API inside ewk_file_chooser_request instead of
accessing the internal C++ classes directly, to
avoid violating API layering.
- UIProcess/API/efl/ewk_file_chooser_request.cpp:
(EwkFileChooserRequest::EwkFileChooserRequest):
(EwkFileChooserRequest::~EwkFileChooserRequest):
(EwkFileChooserRequest::allowMultipleFiles):
(EwkFileChooserRequest::acceptedMIMETypes):
(EwkFileChooserRequest::cancel):
(EwkFileChooserRequest::chooseFiles):
(ewk_file_chooser_request_accepted_mimetypes_get):
(ewk_file_chooser_request_files_choose):
(ewk_file_chooser_request_file_choose):
- UIProcess/API/efl/ewk_file_chooser_request_private.h:
(EwkFileChooserRequest::create):
(EwkFileChooserRequest):
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::runOpenPanel):
- 3:50 PM Changeset in webkit [141708] by
-
- 10 edits in trunk/Source/WebKit2
Stop keeping a frame tree in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=81728
Reviewed by Oliver Hunt.
This patch removes the parent/child relationships of WebFrameProxys
in the UIProcess
- UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyChildFrames):
(WKFrameGetParentFrame):
- UIProcess/API/C/WKFrame.h:
Null out the implementations of WKFrameCopyChildFrames and WKFrameGetParentFrame,
but keep them around as their symbols are still needed for nightlies.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::disconnect):
- UIProcess/WebFrameProxy.h:
Remove parent/child connections.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCreateSubframe):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didSaveToPageCache):
(WebKit::WebFrameLoaderClient::didRestoreFromPageCache):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createSubframe):
Remove/Update messages that only served to update the parent/child connection.
- 3:01 PM Changeset in webkit [141707] by
-
- 2 edits in trunk/Tools
Add Antoine Quint to the list of committers
https://bugs.webkit.org/show_bug.cgi?id=108750
No review necessary.
- Scripts/webkitpy/common/config/committers.py:
- 2:32 PM Changeset in webkit [141706] by
-
- 2 edits in trunk/Source/WebCore
Optimize some operations for float type in texture format conversions of WebGL
https://bugs.webkit.org/show_bug.cgi?id=107526
Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-02-02
Reviewed by Darin Adler.
Some small changes are made to optimize the operations for float type in the texture format conversion of WebGL to improve performance.
Already covered by current tests.
- platform/graphics/GraphicsContext3D.cpp:
(WebCore):
- 2:26 PM Changeset in webkit [141705] by
-
- 5 edits in trunk/Source/WebKit2
Make it possible to modify the connection from ChildProcessProxy subclasses.
Reviewed by Anders Carlsson.
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::ChildProcessProxy):
(WebKit::ChildProcessProxy::didFinishLaunching):
(WebKit::ChildProcessProxy::clearConnection):
(WebKit::ChildProcessProxy::connectionWillOpen):
(WebKit::ChildProcessProxy::connectionWillClose):
- Shared/ChildProcessProxy.h:
(ChildProcessProxy):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::connectionWillClose):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- 1:04 PM Changeset in webkit [141704] by
-
- 16 edits in trunk/Source/WebCore
Clean up the storage of dirty bits on nodes in the scrolling state tree
https://bugs.webkit.org/show_bug.cgi?id=108744
Reviewed by Sam Weinig.
ScrollingStateNode and its subclasses used different techniques for
tracking which properties changed. ScrollingStateNode tracked its layers
via a bool member and some layer-specific methods, but also had virtual
methods to allow subclasses to track properties via a bit mask.
Clean this up by having the base class store the bit mask, and use
enums to specify bits for the various properties. All properties are thus
tracked in the same way. Bits are read and written through non-virtual member
functions on ScrollingStateNode. All bit checking is done via hasChangedProperty().
- page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode): m_changedProperties is now on the base class.
(WebCore::ScrollingStateFixedNode::updateConstraints): Use setPropertyChanged()
- page/scrolling/ScrollingStateFixedNode.h: Remove overrides that are no longer needed.
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode): Initialize m_changedProperties,
m_scrollLayerDidChange no longer tracked separately.
(WebCore::ScrollingStateNode::cloneAndReset):
- page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::hasChangedProperties):
(WebCore::ScrollingStateNode::hasChangedProperty): Tests the bit.
(WebCore::ScrollingStateNode::resetChangedProperties): Set all bits to 0.
(WebCore::ScrollingStateNode::setPropertyChanged): Set the bit.
(WebCore::ScrollingStateNode::changedProperties): Private to discourage incorrect usage
(changeProperties() & foo).
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): Base class does the copying now.
(WebCore::ScrollingStateScrollingNode::setViewportRect): Use setPropertyChanged().
(WebCore::ScrollingStateScrollingNode::setContentsSize): Ditto.
(WebCore::ScrollingStateScrollingNode::setFrameScaleFactor): Etc.
(WebCore::ScrollingStateScrollingNode::setNonFastScrollableRegion):
(WebCore::ScrollingStateScrollingNode::setWheelEventHandlerCount):
(WebCore::ScrollingStateScrollingNode::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollElasticity):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollElasticity):
(WebCore::ScrollingStateScrollingNode::setHasEnabledHorizontalScrollbar):
(WebCore::ScrollingStateScrollingNode::setHasEnabledVerticalScrollbar):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollbarMode):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollbarMode):
(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):
(WebCore::ScrollingStateScrollingNode::setScrollOrigin):
- page/scrolling/ScrollingStateScrollingNode.h:
(ScrollingStateScrollingNode):
- page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::ScrollingStateStickyNode):
(WebCore::ScrollingStateStickyNode::updateConstraints):
- page/scrolling/ScrollingStateStickyNode.h:
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::update):
- page/scrolling/mac/ScrollingStateNodeMac.mm:
(WebCore::ScrollingStateNode::setScrollLayer):
- page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
(WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer):
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::update):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::update):
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::update):
- 1:03 PM Changeset in webkit [141703] by
-
- 12 edits in trunk/Source/WebCore
Fixed and sticky nodes have no nodeID set
https://bugs.webkit.org/show_bug.cgi?id=108734
Reviewed by Sam Weinig.
Push ScrollingNodeIDs onto scrolling nodes at construction time, and thereafter
treat them as readonly. Previously, only the root scrolling node would have a node ID.
Node IDs aren't actually used by the scrolling tree yet, but are useful for debugging.
Not testable since we only dump the scrolling state tree, not the scrolling
node tree in tests.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree): No longer create the root node here;
we can only create it when we know what its ID will be.
(WebCore::ScrollingTree::updateTreeFromStateNode): Create the root node if
necessary. Pass node IDs into create methods.
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::ScrollingTreeNode):
- page/scrolling/ScrollingTreeNode.h:
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
- page/scrolling/ScrollingTreeScrollingNode.h:
- page/scrolling/mac/ScrollingTreeFixedNode.h:
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::create):
(WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNode::create):
(WebCore::ScrollingTreeScrollingNodeMac::ScrollingTreeScrollingNodeMac):
- page/scrolling/mac/ScrollingTreeStickyNode.h:
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::create):
(WebCore::ScrollingTreeStickyNode::ScrollingTreeStickyNode):
- 12:59 PM Changeset in webkit [141702] by
-
- 5 edits2 deletes in trunk
[CMake] Adopt the WinCE port to new CMake
https://bugs.webkit.org/show_bug.cgi?id=108754
Reviewed by Laszlo Gombos.
.:
Remove the entry point hack which isn't required in the new
CMake version with offical WindowsCE support.
- Source/cmake/OptionsWindows.cmake:
Source/JavaScriptCore:
- os-win32/WinMain.cpp: Removed.
- shell/PlatformWinCE.cmake: Removed.
Tools:
- WinCELauncher/CMakeLists.txt: Mark WinCELauncher
as WIN32 target to use the correct entry point.
- 12:55 PM Changeset in webkit [141701] by
-
- 3 edits2 adds in trunk
Making -webkit-image-set() the first value of background property causes crash.
https://bugs.webkit.org/show_bug.cgi?id=108409
Reviewed by Beth Dakin.
Source/WebCore:
CSSParser::addFillValue should use lval->isBaseValueList() instead
of lval->isValueList(). If lval is -webkit-image-set, rval is appended
to -webkit-image-set.
Test: fast/css/image-set-value-crash-in-fillImageSet.html
- css/CSSParser.cpp:
(WebCore::CSSParser::addFillValue):
If lval is not a value list, lval is initialized by using
CSSValueList::createCommaSeparated(). So we have to check whether
lval is created by CSSValueList::createCommaSeparated() or not.
LayoutTests:
- fast/css/image-set-value-crash-in-fillImageSet-expected.txt: Added.
- fast/css/image-set-value-crash-in-fillImageSet.html: Added.
- 12:25 PM Changeset in webkit [141700] by
-
- 5 edits in trunk/Source
<http://webkit.org/b/108745> WTF shouldn't use a script build phase to detect the presence of headers when the compiler can do it for us
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- DerivedSources.make: Remove an obsolete Makefile rule. This should have been removed when the use
of the generated file moved to WTF.
Source/WTF:
- WTF.xcodeproj/project.pbxproj: Remove the script phase that used to generate a header file
containing information about whether certain header files exist on the system.
- wtf/FastMalloc.cpp: Use Clang's has_include to detect whether the header exists before including it.
- 11:02 AM Changeset in webkit [141699] by
-
- 8 edits in trunk/Source
Upstream iOS FeatureDefines
<http://webkit.org/b/108753>
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.
- 9:31 AM Changeset in webkit [141698] by
-
- 2 edits in trunk/Tools
One is not allowed to use commit-queue to make oneself a committer.
- Scripts/webkitpy/common/config/committers.py: Rolled out r141693. Also, changed e-mail order for Yongjun Zhang, so that Bugzilla autocomplete works.
- 8:41 AM Changeset in webkit [141697] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Media tests fix after r141695.
Rubber-stamped by Martin Robinson.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setPlaybinURL): Remove
both fragment and query string for file:// uris before loading.
- 8:12 AM Changeset in webkit [141696] by
-
- 2 edits in trunk/Source/WebCore
Build fix for WinCE after r141637.
- platform/graphics/wince/ImageBufferWinCE.cpp:
- 8:00 AM Changeset in webkit [141695] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] webkitwebsrc is exposed to application-side
https://bugs.webkit.org/show_bug.cgi?id=108088
Reviewed by Martin Robinson.
Switch the webkitwebsrc to handle webkit+http(s) uris so it is now
explicit that this element is meant to be used preferrably inside
WebKit. This change is internal to the player.
No new tests, covered by existing http/tests/media tests.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setPlaybinURL):
(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::load):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcGetProtocols):
(webKitWebSrcSetUri):
- 7:27 AM Changeset in webkit [141694] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed trivial prospective build fix for A17n disabled
configurations.
The dummy computed object attriute cache control functions need to be defined
as being member functions of AXObjectCache, because that's where they are
declared.
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):
- 6:09 AM Changeset in webkit [141693] by
-
- 2 edits in trunk/Tools
Add Antoine Quint to the list of committers
https://bugs.webkit.org/show_bug.cgi?id=108750
Reviewed by Dean Jackson.
- Scripts/webkitpy/common/config/committers.py:
- 5:55 AM Changeset in webkit [141692] by
-
- 3 edits in trunk/Source/WebCore
Creating a WebInspector.ContextMenu without an event crashes WebCore when calling .show()
https://bugs.webkit.org/show_bug.cgi?id=108636
Reviewed by Pavel Feldman.
Return early if InspectorFrontendHost::showContextMenu() is called without an event and
assert in ContextMenuController::createContextMenu() in case no event was provided.
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::showContextMenu):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::createContextMenu):
- 5:05 AM Changeset in webkit [141691] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Improper initialization of ANGLEResources
https://bugs.webkit.org/show_bug.cgi?id=101489
Patch by Jonathan Feldstein <jfeldstein@rim.com> on 2013-02-02
Reviewed by Antonio Gomes.
MaxDrawBuffers, OES_standard_derivatives, OES_EGL_image_external and ARB_texture_rectangle have already been initialized through ShBuiltInResources function and these fields do not need to be set again in GraphicsContext3dBlackBerry.cpp. In addition, the extension flags cannot be set to true without getExtension having been called (Khronos WebGL specs, section 5.14.14.). Thus these lines need to be removed.
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 4:54 AM Changeset in webkit [141690] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Refactor InspectorDOMStorageAgent::getDOMStorageEntries to report the error messages
https://bugs.webkit.org/show_bug.cgi?id=108611
Reviewed by Pavel Feldman.
Added reporting of various error messages. Moved the modification of output
parameter at a later stage when there are no errors reported.
No new tests as code refactoring.
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::hadException):
(WebCore):
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
- 3:58 AM Changeset in webkit [141689] by
-
- 5 edits in trunk
Web Inspector: fix bug in highlighting single chars via highlightRange API of DTE
https://bugs.webkit.org/show_bug.cgi?id=108685
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-02
Reviewed by Pavel Feldman.
Source/WebCore:
Use Math.min instead of Math.max in rangesForLine method.
Updated test: text-editor-highlight-api.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.RangeHighlightDescriptor.prototype.rangesForLine):
LayoutTests:
Updated layout test to cover specific bug case.
- inspector/editor/text-editor-highlight-api-expected.txt:
- inspector/editor/text-editor-highlight-api.html:
- 1:43 AM Changeset in webkit [141688] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations:
- platform/gtk/svg/custom/text-ctm-expected.txt:
- platform/gtk/svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
- 1:01 AM Changeset in webkit [141687] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Unreviewed buildfix after r141648.
- DerivedSources.pri:
- 12:25 AM Changeset in webkit [141686] by
-
- 5 edits in trunk/Source/WebCore
Continue making XSSAuditor thread safe: Remove unsafe AtomicString compares
https://bugs.webkit.org/show_bug.cgi?id=108557
Reviewed by Adam Barth.
Unfortunately HTMLNames comparisons will always be false on a non-main thread
with our current design, so we have to use some "threadSafeMatch" helpers written
for the HTMLBackgroundParser.
Also factor out threadSafeMatch() methods to HTMLParserIdioms.
No new tests because no new functionality.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore):
- html/parser/HTMLParserIdioms.cpp:
(WebCore::threadSafeEqual):
(WebCore):
(WebCore::threadSafeMatch):
- html/parser/HTMLParserIdioms.h:
(WebCore):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::eraseAttributeIfInjected):
- 12:04 AM Changeset in webkit [141685] by
-
- 2 edits in trunk/Source/WebKit2
Follow-up to r141682. Adding build targets for the files that should be generated from the new message.in file.
Unreviewed.
- GNUmakefile.list.am:
Feb 1, 2013:
- 11:40 PM Changeset in webkit [141684] by
-
- 10 edits in trunk/Source
Add didChangePriority() to ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=107995
Reviewed by Darin Fisher.
Source/Platform:
- chromium/public/WebURLLoader.h:
(WebKit):
(WebURLLoader):
(WebKit::WebURLLoader::didChangePriority): Added.
Source/WebCore:
For PLT, it's important that preloads remain a lower priority than parser requested resources.
This can lead to a 5% improvement.
The plan is to use this plumbing to expose the desired behavior. This patch simply allows a
resource's priority to change and have it propagate to the network layer. An upcoming patch will
lower the priority of preloads and then increase the priority when the parser officially requests
it.
No new tests. No visible change, because priority doesn't change yet.
- loader/cache/CachedResource.cpp:
(WebCore):
(WebCore::CachedResource::setLoadPriority):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource): Allow loads to modify priority.
- loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::setPriority): Notify when priority changes.
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::didChangePriority): Added.
(WebCore):
- platform/network/ResourceHandle.h:
(ResourceHandle):
- platform/network/chromium/ResourceHandle.cpp:
(WebCore::ResourceHandleInternal::didChangePriority):
(WebCore):
(WebCore::ResourceHandle::didChangePriority):
- platform/network/chromium/ResourceHandleInternal.h:
(ResourceHandleInternal):
- 10:26 PM Changeset in webkit [141683] by
-
- 2 edits in trunk/Tools
[GTK] Building fails in an armv5tel board
https://bugs.webkit.org/show_bug.cgi?id=108083
Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2013-02-01
Reviewed by Martin Robinson.
In some systems in which $architecture is filled-in from "uname -m"
the value may not start with "arm-", but with "armvN", where "N" is
an architecture version number. The regexp in isARM() is modified
so it covers these kind of cases.
- Scripts/webkitdirs.pm:
(isARM):
- 10:18 PM Changeset in webkit [141682] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix after r141648.
- GNUmakefile.am: Add UIProcess/Storage to the list of paths that
should be searched for *.messages.in files.
- 7:57 PM Changeset in webkit [141681] by
-
- 6 edits in trunk/Source/JavaScriptCore
Structure::m_enumerationCache should be moved to StructureRareData
https://bugs.webkit.org/show_bug.cgi?id=108723
Reviewed by Oliver Hunt.
m_enumerationCache is only used by objects whose properties are iterated over, so not every Structure needs this
field and it can therefore be moved safely to StructureRareData to help with memory savings.
- runtime/JSPropertyNameIterator.h:
(JSPropertyNameIterator):
(JSC::Register::propertyNameIterator):
(JSC::StructureRareData::enumerationCache): Add to JSPropertyNameIterator.h so that it can see the correct type.
(JSC::StructureRareData::setEnumerationCache): Ditto.
- runtime/Structure.cpp:
(JSC::Structure::addPropertyWithoutTransition): Use the enumerationCache() getter rather than accessing the field.
(JSC::Structure::removePropertyWithoutTransition): Ditto.
(JSC::Structure::visitChildren): We no longer have to worry about marking the m_enumerationCache field.
- runtime/Structure.h:
(JSC::Structure::setEnumerationCache): Move the old accessors back since we don't have to have any knowledge of
the JSPropertyNameIterator type.
(JSC::Structure::enumerationCache): Ditto.
- runtime/StructureRareData.cpp:
(JSC::StructureRareData::visitChildren): Mark the new m_enumerationCache field.
- runtime/StructureRareData.h: Add new functions/fields.
(StructureRareData):
- 7:40 PM Changeset in webkit [141680] by
-
- 6 edits1 move5 adds1 delete in trunk/LayoutTests
Rebaseline tests after bug 9221
https://bugs.webkit.org/show_bug.cgi?id=108712
Unreviewed rebaseline of test expectations.
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-01
- fast/css/resize-corner-tracking-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/resize-corner-tracking-expected.txt.
- platform/chromium-mac-lion/fast/css/resize-corner-tracking-expected.png:
- platform/chromium-mac-lion/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-expected.png:
- platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
- platform/chromium-mac/fast/css/resize-corner-tracking-expected.png:
- platform/chromium-mac/fast/css/resize-corner-tracking-transformed-iframe-expected.png:
- platform/chromium-mac/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
- platform/chromium-win/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/fast/css/resize-corner-tracking-expected.txt: Removed.
- 6:54 PM Changeset in webkit [141679] by
-
- 6 edits1 delete in trunk/Source/WebCore
Unreviewed. Clean up WebCore VS2010 project.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.vcxproj/WebCoreCommon.props:
- WebCore.vcxproj/WebCoreGenerated.make:
- WebCore.vcxproj/WebCorePreLink.cmd: Removed.
- WebCore.vcxproj/build-generated-files.sh:
- 6:53 PM Changeset in webkit [141678] by
-
- 2 edits in trunk/Source/WebCore
Don't use deprecated method -[NSImage dissolveToPoint:fraction:]
<rdar://problem/11723792>
https://bugs.webkit.org/show_bug.cgi?id=108739
Reviewed by Anders Carlsson.
- platform/mac/DragImageMac.mm:
(WebCore::dissolveDragImageToFraction):
Remove use of deprecated NSImage methods and simplify a bit.
- 6:51 PM Changeset in webkit [141677] by
-
- 5 edits in trunk/Source/JavaScriptCore
Unreviewed. JavaScriptCore VS2010 project cleanup.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
- JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
- 6:48 PM Changeset in webkit [141676] by
-
- 3 edits1 delete in trunk/Source/WTF
Unreviewed. WTF VS2010 project cleanup.
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.vcxproj/WTFPreLink.cmd: Removed.
- 6:36 PM Changeset in webkit [141675] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r180221. Requested by
"Nico Weber" <thakis@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01
- DEPS:
- 6:35 PM Changeset in webkit [141674] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r141662.
http://trac.webkit.org/changeset/141662
https://bugs.webkit.org/show_bug.cgi?id=108738
it's an incorrect change since processPhiStack will
dereference dangling BasicBlock pointers (Requested by pizlo
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
- 6:17 PM Changeset in webkit [141673] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix "DOM Exception 8" when deleting lines containing decoration in DTE.
https://bugs.webkit.org/show_bug.cgi?id=108689
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-01
Reviewed by Alexander Pavlov.
Add a check that decoration element is still added to the line before trying to delete it. This
won't be true if the whole line is deleted in contentEditable,
and this is the reason for the exception to be thrown.
No new tests.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):
- 6:16 PM Changeset in webkit [141672] by
-
- 3 edits in trunk/Tools
Update LayoutTests scripts to skip webgl folder on ports
https://bugs.webkit.org/show_bug.cgi?id=108705
Patch by Gregg Tavares <gman@google.com> on 2013-02-01
Reviewed by Dirk Pranke.
I'm working on checking in the WebGL Conformance Tests
as layout tests into LayoutTests/webgl. For ports
that do not have WebGL enabled this changes will
skip tests in the "webgl" folder.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port._missing_symbol_to_skipped_tests):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_skipped_directories_for_symbols):
- 5:35 PM Changeset in webkit [141671] by
-
- 3 edits in trunk/Tools
Unreviewed. Fix for webkitpy tests.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
- 5:27 PM Changeset in webkit [141670] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r141669.
http://trac.webkit.org/changeset/141669
https://bugs.webkit.org/show_bug.cgi?id=108728
Broke the windows build. (Requested by leviw on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
- 5:10 PM Changeset in webkit [141669] by
-
- 3 edits in trunk/Source/WebCore
Remove duplicate code in RenderBoxModelObject::computedCSSPadding*
https://bugs.webkit.org/show_bug.cgi?id=108707
Reviewed by Levi Weintraub.
The computedCSSPaddingTop/Bottom/... methods in
RenderBoxModelObject all do pretty much exactly the same thing
yet share no code.
Break out shared code into computedCSSPadding method and have
the top/bottom/left/right/... ones call it with the appropriate
length value.
No new tests, no change in functionality.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computedCSSPadding):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
(RenderBoxModelObject):
- 5:05 PM Changeset in webkit [141668] by
-
- 14 edits in trunk/Source/WebCore
Replace ExceptionCode with DatabaseError in the openDatabase() code path.
https://bugs.webkit.org/show_bug.cgi?id=108724.
Reviewed by Alexey Proskuryakov.
Also made DatabaseBackend::performOpenAndVerify() a little more
straightforward and less repetitive.
No new tests.
- Modules/webdatabase/DOMWindowWebDatabase.cpp:
(WebCore::DOMWindowWebDatabase::openDatabase):
- Modules/webdatabase/Database.cpp:
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::performOpenAndVerify):
- Modules/webdatabase/Database.h:
(Database):
- Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::openSucceeded):
(WebCore::DatabaseBackend::performOpenAndVerify):
- Modules/webdatabase/DatabaseBackend.h:
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
- Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
- Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::openAndVerifyVersion):
- Modules/webdatabase/DatabaseSync.h:
(DatabaseSync):
- Modules/webdatabase/DatabaseTask.cpp:
(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):
- Modules/webdatabase/DatabaseTask.h:
(WebCore::Database::DatabaseOpenTask::create):
(Database::DatabaseOpenTask):
- Modules/webdatabase/WorkerContextWebDatabase.cpp:
(WebCore::WorkerContextWebDatabase::openDatabase):
(WebCore::WorkerContextWebDatabase::openDatabaseSync):
- WebCore.gypi:
- 4:58 PM Changeset in webkit [141667] by
-
- 3 edits2 adds in trunk
Document is never released if an image's src attribute is changed to a url blocked by content-security-policy.
https://bugs.webkit.org/show_bug.cgi?id=108545
Source/WebCore:
If we just scheduled an error event due to an null newImage, we should not cancel it when newImage and oldImage
is not the same. Otherwise we will ref the sourceElement in updateHasPendingEvent (m_hasPendingErrorEvent is true)
but never deref it since we already cancelled the error event.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-02-01
Reviewed by Alexey Proskuryakov.
Test: fast/images/image-error-event-not-firing.html
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement): don't cancel error event if newImage is null, we want the
error event to fire.
LayoutTests:
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-02-01
Reviewed by Alexey Proskuryakov.
Add a test to verify the error event is fired when image's src attribute is changed to a url
but the url blocked by content-security-policy.
- fast/images/image-error-event-not-firing-expected.txt: Added.
- fast/images/image-error-event-not-firing.html: Added.
- 4:51 PM Changeset in webkit [141666] by
-
- 2 edits in trunk/Tools
LLDB: add synthetic provider for WTF::HashTable
https://bugs.webkit.org/show_bug.cgi?id=108718
Reviewed by Darin Adler.
Add a synthetic provider which will emit the contents of a given
WTF::HashTable. This allows clients using Xcode/lldb to enumerate
the hash contents.
- lldb/lldb_webkit.py:
(lldb_init_module):
(lldb_init_module.lldb_webkit):
(WTFHashTable_SummaryProvider):
(WTFVectorProvider.has_children):
(WTFHashTableProvider):
(WTFHashTableProvider.init):
(WTFHashTableProvider.num_children):
(WTFHashTableProvider.get_child_index):
(WTFHashTableProvider.get_child_at_index):
(WTFHashTableProvider.tableSize):
(WTFHashTableProvider.keyCount):
(WTFHashTableProvider.update):
(WTFHashTableProvider.has_children):
- 4:51 PM Changeset in webkit [141665] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after r141648
Needs to add StorageManager.messages.in to CMakeLists.txt.
- CMakeLists.txt:
- 4:50 PM Changeset in webkit [141664] by
-
- 2 edits3 copies3 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaseline after http://trac.webkit.org/changeset/141634
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
- platform/chromium-win/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
- 4:33 PM Changeset in webkit [141663] by
-
- 2 edits in trunk/Source/WebKit2
Build fix for CustomProtocolManagerMac after r141658.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-01
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::supplementName): I accidentally typed "const" twice twice.
- 4:26 PM Changeset in webkit [141662] by
-
- 2 edits in trunk/Source/JavaScriptCore
Eliminate dead blocks sooner in the DFG::ByteCodeParser to make clear that you don't need to hold onto them during Phi construction
https://bugs.webkit.org/show_bug.cgi?id=108717
Reviewed by Mark Hahnenberg.
I think this makes the code clearer. It doesn't change behavior.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
- 4:25 PM Changeset in webkit [141661] by
-
- 2 edits in trunk/LayoutTests
The assertions in updateLayerPositionsAfterScroll were commented out in r141278, so stop
expecting http/tests/inspector/resource-har-pages.html to assert in debug builds.
(see https://bugs.webkit.org/show_bug.cgi?id=103432).
- platform/mac/TestExpectations:
- 4:19 PM Changeset in webkit [141660] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r180186. Requested by
"Nico Weber" <thakis@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01
- DEPS:
- 4:14 PM Changeset in webkit [141659] by
-
- 5 edits3 deletes in trunk/LayoutTests
Make svg-fonts-in-text-controls.html have the same results across platforms
https://bugs.webkit.org/show_bug.cgi?id=108676
Reviewed by Dirk Pranke.
Mac uses a different default font-size for form controls and Windows
uses different padding for textareas/inputs. Override these so
this test doesn't need platform specific expectations.
- platform/chromium/TestExpectations:
- platform/gtk/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
- platform/qt/svg/custom/svg-fonts-in-text-controls-expected.png: Removed.
- platform/qt/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
- svg/custom/script-tests/svg-fonts-in-text-controls.js:
- svg/custom/svg-fonts-in-text-controls-expected.txt:
- svg/custom/svg-fonts-in-text-controls.html:
These dummy elements aren't needed anymore. js-test-pre.js inserts them.
- 4:10 PM Changeset in webkit [141658] by
-
- 42 edits in trunk/Source/WebKit2
[WK2] Use light supplement names instead of static AtomicStrings
https://bugs.webkit.org/show_bug.cgi?id=108570
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-01
Reviewed by Anders Carlsson.
Since all the supplement names are just string literals and are all different,
we can just use their pointer as the key in the supplement hashmaps.
This is lighter and faster than using AtomicString. WebCore already moved to this
in Supplementable.
- NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::addSupplement):
(NetworkProcess):
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::supplementName):
- Shared/Authentication/AuthenticationManager.h:
(AuthenticationManager):
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::supplementName):
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::supplementName):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
- UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::supplementName):
- UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
- UIProcess/WebContext.h:
(WebContext):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::supplementName):
- UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::supplementName):
- UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
- UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::supplementName):
- UIProcess/WebGeolocationManagerProxy.h:
(WebGeolocationManagerProxy):
- UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::WebKeyValueStorageManagerProxy::supplementName):
- UIProcess/WebKeyValueStorageManagerProxy.h:
(WebKeyValueStorageManagerProxy):
- UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::supplementName):
- UIProcess/WebMediaCacheManagerProxy.h:
(WebMediaCacheManagerProxy):
- UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::supplementName):
- UIProcess/WebResourceCacheManagerProxy.h:
(WebResourceCacheManagerProxy):
- UIProcess/soup/WebSoupRequestManagerProxy.cpp:
(WebKit::WebSoupRequestManagerProxy::supplementName):
- UIProcess/soup/WebSoupRequestManagerProxy.h:
(WebSoupRequestManagerProxy):
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::supplementName):
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
(WebApplicationCacheManager):
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::supplementName):
- WebProcess/Cookies/WebCookieManager.h:
(WebCookieManager):
- WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::supplementName):
- WebProcess/Geolocation/WebGeolocationManager.h:
(WebGeolocationManager):
- WebProcess/MediaCache/WebMediaCacheManager.cpp:
(WebKit::WebMediaCacheManager::supplementName):
- WebProcess/MediaCache/WebMediaCacheManager.h:
(WebMediaCacheManager):
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::supplementName):
- WebProcess/Notifications/WebNotificationManager.h:
(WebNotificationManager):
- WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::supplementName):
- WebProcess/ResourceCache/WebResourceCacheManager.h:
(WebResourceCacheManager):
- WebProcess/Storage/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::supplementName):
- WebProcess/Storage/WebKeyValueStorageManager.h:
(WebKeyValueStorageManager):
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::supplementName):
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebDatabaseManager):
- WebProcess/WebProcess.h:
(WebKit::WebProcess::addSupplement):
(WebProcess):
- 3:59 PM Changeset in webkit [141657] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] WebWidget::selectionBounds should return the bounds in document space
https://bugs.webkit.org/show_bug.cgi?id=108386
Patch by Chris Hopman <cjhopman@chromium.org> on 2013-02-01
Reviewed by James Robinson.
When in applyPageScaleFactorInCompositor mode, selectionBounds needs
to scale the anchor/focus window points by the pageScaleFactor.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::selectionBounds):
(WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):
- 3:55 PM Changeset in webkit [141656] by
-
- 14 edits in trunk
Clean the String->AtomicString conversion for AnimationController::pauseAnimationAtTime
https://bugs.webkit.org/show_bug.cgi?id=108558
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-01
Reviewed by Dean Jackson.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
This is a step torward killing the implicit conversion from String to AtomicString.
The animation name are AtomicString. The API is changed all the way to the callers
to take an AtomicString. When needed, we use explicit conversion.
- WebCore.exp.in:
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationController::pauseAnimationAtTime):
- page/animation/AnimationController.h:
(AnimationController):
- page/animation/AnimationControllerPrivate.h:
(AnimationControllerPrivate):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::pauseAnimationAtTime):
We should not null check the name. Getting a null name from the HashMap would be
an error from the tests, and the HashMap would never return a value anyway.
- testing/Internals.cpp:
(WebCore::Internals::pauseAnimationAtTimeOnPseudoElement):
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFramePauseAnimationOnElementWithId):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::pauseAnimationOnElementWithId):
- WebProcess/WebPage/WebFrame.h:
(WebFrame):
- 3:50 PM Changeset in webkit [141655] by
-
- 9 edits in trunk/Source
AX: memoize expensive computation during blocks where tree doesn't change
https://bugs.webkit.org/show_bug.cgi?id=106497
Reviewed by Ryosuke Niwa.
Source/WebCore:
Add a cache for computed attributes of AXObjects.
The cache can be enabled at the start of a batch of
read-only operations on the accessibility tree, and
it's cleared automatically when the tree mutates.
Currently accessibilityIsIgnored is cached, since it's
frequently called and relatively expensive to compute.
No new tests.
- accessibility/AXObjectCache.cpp:
(WebCore):
(WebCore::AXComputedObjectAttributeCache::getIgnored):
(WebCore::AXComputedObjectAttributeCache::setIgnored):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::nodeTextChangeNotification):
(WebCore::AXObjectCache::handleScrollbarUpdate):
(WebCore::AXObjectCache::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):
- accessibility/AXObjectCache.h:
(AXComputedObjectAttributeCache):
(WebCore::AXComputedObjectAttributeCache::create):
(WebCore::AXComputedObjectAttributeCache::AXComputedObjectAttributeCache):
(WebCore::AXComputedObjectAttributeCache::CachedAXObjectAttributes::CachedAXObjectAttributes):
(CachedAXObjectAttributes):
(WebCore):
(WebCore::AXObjectCache::computedObjectAttributeCache):
(AXObjectCache):
(WebCore::AXComputedObjectAttributeCache::getIgnored):
(WebCore::AXComputedObjectAttributeCache::setIgnored):
(WebCore::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::stopCachingComputedObjectAttributes):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::findMatchingObjects):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
Source/WebKit/chromium:
Expose two methods to enable and disable caching of
computed WebAccessibilityObject attributes, to speed up
batch read-only operations.
- public/WebAccessibilityObject.h:
(WebAccessibilityObject):
- src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::startCachingComputedObjectAttributesUntilTreeMutates):
(WebKit):
(WebKit::WebAccessibilityObject::stopCachingComputedObjectAttributes):
- 3:46 PM Changeset in webkit [141654] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- Modules/webdatabase/DatabaseBackend.cpp: (DoneCreatingDatabaseOnExitCaller): Don't fail because of an unused member variable in cross-plaform code path.
- 3:30 PM Changeset in webkit [141653] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Expose WebNode::shadowHost()
https://bugs.webkit.org/show_bug.cgi?id=108681
Reviewed by Dimitri Glazkov.
BrowserPlugin needs to be able to check the event listeners attached to
<webview> and so we expose shadowHost to permit it to poke at the webview
node.
- public/WebNode.h:
- src/WebNode.cpp:
(WebKit::WebNode::shadowHost):
(WebKit):
- 3:23 PM Changeset in webkit [141652] by
-
- 5 edits in trunk/Source
[chromium] Fat scrollbars on Windows in high-DPI mode.
https://bugs.webkit.org/show_bug.cgi?id=108637
Updates mechanism for retrieving scrollbar metrics on the
Windows port of Chromium. Previously, GetSystemMetrics calls
were used, which fetches prescaled sizes in pixel rather than
logical units, resulting in a double scaling when a device
scale factor is set. With the patch, the size is retrieved
from the theme engine in DIP.
Patch by Kevin Ellis <kevers@chromium.org> on 2013-02-01
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/win/WebThemeEngine.h:
(WebThemeEngine):
Source/WebCore:
No new tests.
- platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
- rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::menuListButtonWidth):
- 3:10 PM Changeset in webkit [141651] by
-
- 18 edits3 adds in trunk/Source/JavaScriptCore
Structure should have a StructureRareData field to save space
https://bugs.webkit.org/show_bug.cgi?id=108659
Reviewed by Oliver Hunt.
Many of the fields in Structure are used in a subset of all total Structures; however, all Structures must
pay the memory cost of those fields, regardless of whether they use them or not. Since we can have potentially
many Structures on a single page (e.g. bing.com creates ~1500 Structures), it would be profitable to
refactor Structure so that not every Structure has to pay the memory costs for these infrequently used fields.
To accomplish this, we can create a new StructureRareData class to house these seldom used fields which we
can allocate on demand whenever a Structure requires it. This StructureRareData can itself be a JSCell, and
can do all the marking of the fields for the Structure. The StructureRareData field will be part of a union
with m_previous to minimize overhead. We'll add a new field to JSTypeInfo to indicate that the Structure has
a StructureRareData field. During transitions, a Structure will clone its previous Structure's StructureRareData
if it has one. There could be some potential for optimizing this process, but the initial implementation will
be dumb since we'd be paying these overhead costs for each Structure anyways.
Initially we'll only put two fields in the StructureRareData to avoid a memory regression. Over time we'll
continue to move fields from Structure to StructureRareData. Optimistically, this could potentially reduce our
Structure memory footprint by up to around 75%. It could also clear the way for removing destructors from
Structures (and into StructureRareData).
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGRepatch.cpp: Includes for linking purposes.
- jit/JITStubs.cpp:
- jsc.cpp:
- llint/LLIntSlowPaths.cpp:
- runtime/JSCellInlines.h: Added ifdef guards.
- runtime/JSGlobalData.cpp: New Structure for StructureRareData class.
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/JSGlobalObject.h:
- runtime/JSTypeInfo.h: New flag to indicate whether or not a Structure has a StructureRareData field.
(JSC::TypeInfo::flags):
(JSC::TypeInfo::structureHasRareData):
- runtime/ObjectPrototype.cpp:
- runtime/Structure.cpp: We use a combined WriteBarrier<JSCell> field m_previousOrRareData to avoid compiler issues.
(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::pin):
(JSC::Structure::allocateRareData): Handles allocating a brand new StructureRareData field.
(JSC::Structure::cloneRareDataFrom): Handles cloning a StructureRareData field from another. Used during Structure
transitions.
(JSC::Structure::visitChildren): We no longer have to worry about marking m_objectToStringValue.
- runtime/Structure.h:
(JSC::Structure::previousID): Checks the structureHasRareData flag to see where it should get the previous Structure.
(JSC::Structure::objectToStringValue): Reads the value from the StructureRareData. If it doesn't exist, returns 0.
(JSC::Structure::setObjectToStringValue): Ensures that we have a StructureRareData field, then forwards the function
call to it.
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::setPreviousID): Checks for StructureRareData and forwards if necessary.
(Structure):
(JSC::Structure::clearPreviousID): Ditto.
(JSC::Structure::create):
- runtime/StructureRareData.cpp: Added. All of the basic functionality of a JSCell with the fields that we've moved
from Structure and the functions required to access/modify those fields as Structure would have done.
(JSC):
(JSC::StructureRareData::createStructure):
(JSC::StructureRareData::create):
(JSC::StructureRareData::clone):
(JSC::StructureRareData::StructureRareData):
(JSC::StructureRareData::visitChildren):
- runtime/StructureRareData.h: Added.
(JSC):
(StructureRareData):
- runtime/StructureRareDataInlines.h: Added.
(JSC):
(JSC::StructureRareData::previousID):
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::clearPreviousID):
(JSC::Structure::previous): Handles the ugly casting to get the value of the right type of m_previousOrRareData.
(JSC::Structure::rareData): Ditto.
(JSC::StructureRareData::objectToStringValue):
(JSC::StructureRareData::setObjectToStringValue):
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGRepatch.cpp:
- jit/JITStubs.cpp:
- jsc.cpp:
- llint/LLIntSlowPaths.cpp:
- runtime/JSCellInlines.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/JSGlobalObject.h:
- runtime/JSTypeInfo.h:
(JSC):
(JSC::TypeInfo::flags):
(JSC::TypeInfo::structureHasRareData):
- runtime/ObjectPrototype.cpp:
- runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::pin):
(JSC::Structure::allocateRareData):
(JSC):
(JSC::Structure::cloneRareDataFrom):
(JSC::Structure::visitChildren):
- runtime/Structure.h:
(JSC::Structure::previousID):
(JSC::Structure::objectToStringValue):
(JSC::Structure::setObjectToStringValue):
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::setPreviousID):
(Structure):
(JSC::Structure::clearPreviousID):
(JSC::Structure::previous):
(JSC::Structure::rareData):
(JSC::Structure::create):
- runtime/StructureRareData.cpp: Added.
(JSC):
(JSC::StructureRareData::createStructure):
(JSC::StructureRareData::create):
(JSC::StructureRareData::clone):
(JSC::StructureRareData::StructureRareData):
(JSC::StructureRareData::visitChildren):
- runtime/StructureRareData.h: Added.
(JSC):
(StructureRareData):
- runtime/StructureRareDataInlines.h: Added.
(JSC):
(JSC::StructureRareData::previousID):
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::clearPreviousID):
(JSC::StructureRareData::objectToStringValue):
(JSC::StructureRareData::setObjectToStringValue):
- 3:03 PM Changeset in webkit [141650] by
-
- 4 edits in trunk
Source/WebKit/chromium: [Chromium] Ignore punctuation in spellcheck
https://bugs.webkit.org/show_bug.cgi?id=108511
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Tony Chang.
- src/ContextMenuClientImpl.cpp:
(WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
(WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.
LayoutTests: [Chromium] Expect spellcheck to ignore punctuation
https://bugs.webkit.org/show_bug.cgi?id=108511
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Tony Chang.
- platform/chromium/TestExpectations: Expect spellcheck to ignore punctuation.
- 3:03 PM Changeset in webkit [141649] by
-
- 13 edits in trunk/Source/WebCore
Clean up calls to DatabaseTracker::add/removeOpenDatabase().
https://bugs.webkit.org/show_bug.cgi?id=108431
Reviewed by Geoffrey Garen.
Also adapted the chromium port to work with this new code.
Chromium parts reviewed by Michael Nordman and David Levin.
This is part of the webdatabase refactoring effort.
No new tests.
- Modules/webdatabase/AbstractDatabaseServer.h:
(AbstractDatabaseServer):
- Modules/webdatabase/Database.cpp:
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::close):
- Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::closeDatabase):
(DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(WebCore::DatabaseBackend::performOpenAndVerify):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
- Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
- Modules/webdatabase/DatabaseServer.cpp:
- Modules/webdatabase/DatabaseServer.h:
- Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::openAndVerifyVersion):
(WebCore::DatabaseSync::closeImmediately):
- Modules/webdatabase/DatabaseSync.h:
(DatabaseSync):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):
- Modules/webdatabase/DatabaseTracker.h:
(DatabaseTracker):
- Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::prepareToOpenDatabase):
(WebCore::DatabaseTracker::failedToOpenDatabase):
- 2:56 PM Changeset in webkit [141648] by
-
- 7 edits1 add in trunk/Source/WebKit2
More work on UI side storage
https://bugs.webkit.org/show_bug.cgi?id=108700
Reviewed by Sam Weinig.
- DerivedSources.make:
Add StorageManager.messages.in.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add new overload.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):
Call the right function.
(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):
Add stubs.
- UIProcess/Storage/StorageManager.messages.in: Added.
Add new messages files.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::~StorageAreaProxy):
Add another FIXME.
(WebKit::StorageAreaProxy::canAccessStorage):
(WebKit::StorageAreaProxy::incrementAccessCount):
(WebKit::StorageAreaProxy::decrementAccessCount):
Implement these.
- 2:55 PM Changeset in webkit [141647] by
-
- 5 edits in trunk
Web Inspector: remove extra padding around overlay highlight.
https://bugs.webkit.org/show_bug.cgi?id=108679
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-01
Reviewed by Alexander Pavlov.
Source/WebCore:
No new tests: no change in behaviour.
Remove extraWidth from overlay highlight spans.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
LayoutTests:
Update layout test expectations to correspond to updated overlay highlight style.
- inspector/editor/text-editor-highlight-api-expected.txt:
- inspector/editor/text-editor-highlight-token-expected.txt:
- 2:46 PM Changeset in webkit [141646] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
Allow prettify.rb to be run from any directory, and don't hard-code the system ruby path
https://bugs.webkit.org/show_bug.cgi?id=108569
Patch by Nathan de Vries <ndevries@apple.com> on 2013-02-01
Reviewed by Joseph Pecoraro.
- PrettyPatch/prettify.rb:
- 2:38 PM Changeset in webkit [141645] by
-
- 8 edits3 adds in trunk
Prevent skipped repaints for children of inner SVG elements
https://bugs.webkit.org/show_bug.cgi?id=108429
Reviewed by Eric Seidel.
Source/WebCore:
This patch fixes a bug caused by r108699 and r133786 where we would not repaint children
of inner SVG elements because "m_didTransformToRootUpdate" was never reset on viewport
containers. The stale m_didTransformToRootUpdate variable caused us to skip child repaints.
I verified that the Robohornet SVG benchmark performance gains in r133786 are not regressed
with this patch.
Test: svg/repaint/svgsvgelement-repaint-children.html
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::calcViewport):
This can be removed because setNeedsTransformUpdate() will set m_needsTransformUpdate.
(WebCore::RenderSVGViewportContainer::calculateLocalTransform):
This change is straightforward and is similar to the equivalent assignment in
RenderSVGTransformableContainer::calculateLocalTransform().
LayoutTests:
Need to update expectations for a single file (just a 1px difference).
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
- svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
- svg/repaint/svgsvgelement-repaint-children.html: Added.
- 2:24 PM Changeset in webkit [141644] by
-
- 4 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening of two svg/zoom/page tests.
This change rebaselines two tests for WK108108.
Unreviewed update of test expectations.
- platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
- platform/chromium/TestExpectations:
- 2:10 PM Changeset in webkit [141643] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix webkitpy tests since a build_style is not specified in some cases.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- 2:00 PM Changeset in webkit [141642] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Skip a test added in r14618 that uses setAutomaticLinkDetectionEnabled.
- platform/chromium/TestExpectations:
- 2:00 PM Changeset in webkit [141641] by
-
- 3 edits in trunk/Source/JavaScriptCore
offlineasm BaseIndex handling is broken on ARM due to MIPS changes
https://bugs.webkit.org/show_bug.cgi?id=108261
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-02-01
Reviewed by Filip Pizlo.
offlineasm BaseIndex handling fix on MIPS.
- offlineasm/mips.rb:
- offlineasm/risc.rb:
- 1:56 PM Changeset in webkit [141640] by
-
- 5 edits in trunk/Source/WebKit2
[Gtk] [WK2] Fix build after r141619
https://bugs.webkit.org/show_bug.cgi?id=108687
Reviewed by Benjamin Poulain.
Take a reference instead of a pointer for decoding functions.
- Platform/gtk/SharedMemoryGtk.cpp:
(WebKit::SharedMemory::Handle::decode):
- Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::decodeImage):
(CoreIPC::decodeDataObject):
(CoreIPC::::decode):
(CoreIPC::decodeGKeyFile):
(CoreIPC::decode):
- Shared/gtk/ArgumentCodersGtk.h:
- Shared/gtk/LayerTreeContextGtk.cpp:
(WebKit::LayerTreeContext::decode):
- 1:40 PM Changeset in webkit [141639] by
-
- 10 edits in trunk/Source/WebKit2
[EFL] [WK2] Fix build after r141619
https://bugs.webkit.org/show_bug.cgi?id=108683
Reviewed by Benjamin Poulain.
Take a reference instead of a pointer for decoding functions.
- Shared/WebBatteryStatus.cpp:
(WebKit::WebBatteryStatus::Data::decode):
- Shared/WebBatteryStatus.h:
(Data):
- Shared/WebNetworkInfo.cpp:
(WebKit::WebNetworkInfo::Data::decode):
- Shared/WebNetworkInfo.h:
(Data):
- Shared/cairo/LayerTreeContextCairo.cpp:
(WebKit::LayerTreeContext::decode):
- Shared/efl/LayerTreeContextEfl.cpp:
(WebKit::LayerTreeContext::decode):
- Shared/soup/PlatformCertificateInfo.cpp:
(WebKit::PlatformCertificateInfo::decode):
- Shared/soup/PlatformCertificateInfo.h:
(PlatformCertificateInfo):
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(CoreIPC::::decodePlatformData):
- 1:34 PM Changeset in webkit [141638] by
-
- 2 edits in trunk/LayoutTests
[Mac] Layout test fast/parser/parser-yield-timing.html is flaky on debug bots
https://bugs.webkit.org/show_bug.cgi?id=108677
Patch by David Farler <dfarler@apple.com> on 2013-02-01
Reviewed by Tim Horton.
- platform/mac/TestExpectations:
Mark fast/parser/parser-yield-timing.html as [ Pass Failure ]
- 1:31 PM Changeset in webkit [141637] by
-
- 45 edits1 add in trunk
Change hasAlpha to isKnownToBeOpaque and correct the return value for SVG images.
https://bugs.webkit.org/show_bug.cgi?id=106966
Reviewed by Stephen White.
Source/WebCore:
Previously, Image::currentFrameHasAlpha's default implementation returned false so SVG
images always returned false for currentFrameHasAlpha. Additionally, currentFrameHasAlpha
was treated as returning whether the frame had alpha when it would actually conservatively
return true.
This patch renames hasAlpha and currentFrameHasAlpha to isKnownToBeOpaque and
currentFrameIsKnownToBeOpaque, respectively. This rename better describes the actual
functionality. This patch also makes Image::isKnownToBeOpaque a pure virtual function and
correctly implements it for SVG images.
All users of isKnownToBeOpaque access SVG images using CachedImage::imageForRenderer which
currently returns a cached bitmap image. Therefore, this patch will not affect existing
functionality. A regression test has been added that will catch if this changes in the
future (e.g., WK106159 which proposes not returning cached bitmaps). The now unnecessary
isBitmapImage() calls have been removed in this patch.
image-box-shadow.html has been modified to test SVG images.
- css/CSSCrossfadeValue.cpp:
(WebCore::subimageKnownToBeOpaque):
(WebCore::CSSCrossfadeValue::knownToBeOpaque):
Mostly straightforward rename but note the logic has been slightly altered: AND -> OR.
- css/CSSCrossfadeValue.h:
(CSSCrossfadeValue):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::knownToBeOpaque):
- css/CSSGradientValue.h:
(CSSGradientValue):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::knownToBeOpaque):
- css/CSSImageGeneratorValue.h:
(CSSImageGeneratorValue):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::knownToBeOpaque):
- css/CSSImageValue.h:
(CSSImageValue):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::currentFrameKnownToBeOpaque):
- loader/cache/CachedImage.h:
(CachedImage):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::currentFrameKnownToBeOpaque):
- platform/graphics/BitmapImage.h:
(BitmapImage):
- platform/graphics/GeneratedImage.h:
(GeneratedImage):
- platform/graphics/Image.h:
Note: now a pure virtual function!
(Image):
- platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
Removed unnecessary isBitmapImage() checks.
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
Removed unnecessary isBitmapImage() checks.
- platform/graphics/cg/PDFDocumentImage.h:
(PDFDocumentImage):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
Removed unnecessary isBitmapImage() checks.
(WebCore::GraphicsLayerChromium::setContentsToImage):
- platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::currentFrameKnownToBeOpaque):
- platform/graphics/qt/StillImageQt.h:
(StillImage):
- platform/graphics/skia/BitmapImageSingleFrameSkia.cpp:
(WebCore::BitmapImageSingleFrameSkia::currentFrameKnownToBeOpaque):
- platform/graphics/skia/BitmapImageSingleFrameSkia.h:
(BitmapImageSingleFrameSkia):
- platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContents):
- platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
(WebCore::CoordinatedImageBacking::update):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::backgroundIsObscured):
Removed unnecessary isBitmapImage() checks and slightly reworked the logic.
- rendering/style/FillLayer.cpp:
(WebCore::FillLayer::hasOpaqueImage):
- rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::knownToBeOpaque):
- rendering/style/StyleCachedImage.h:
(StyleCachedImage):
- rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::knownToBeOpaque):
- rendering/style/StyleCachedImageSet.h:
(StyleCachedImageSet):
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::knownToBeOpaque):
- rendering/style/StyleGeneratedImage.h:
(StyleGeneratedImage):
- rendering/style/StyleImage.h:
(StyleImage):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::knownToBeOpaque):
- svg/graphics/SVGImage.h:
(SVGImage):
Source/WebKit/chromium:
- tests/DragImageTest.cpp:
(WebCore::TestImage::currentFrameKnownToBeOpaque):
(TestImage):
- tests/ImageLayerChromiumTest.cpp:
(WebCore::TestImage::currentFrameKnownToBeOpaque):
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
LayoutTests:
An SVG image has been added to this test to check for regressions.
- fast/box-shadow/image-box-shadow-expected.html:
- fast/box-shadow/image-box-shadow.html:
Add an SVG image and correct a small mistake in the test that used values of 256
instead of 255.
- fast/box-shadow/resources/green.svg: Added.
- 1:26 PM Changeset in webkit [141636] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK TestExpectations update.
- platform/gtk/TestExpectations: Flag some new media tests
crashing until a fix is figured out.
- 1:18 PM Changeset in webkit [141635] by
-
- 8 edits in trunk/Source
Clean up WebArchive loading with the NetworkProcess
<rdar://problem/12695840> and https://bugs.webkit.org/show_bug.cgi?id=108673
Reviewed by Alexey Proskuryakov.
Source/WebCore:
No new tests (No change in WebCore behavior).
Remove a now unneeded function and add a needed export.
- WebCore.exp.in:
- loader/ResourceLoadScheduler.cpp:
- loader/ResourceLoadScheduler.h:
Source/WebKit2:
- NetworkProcess/HostRecord.cpp:
(WebKit::HostRecord::servePendingRequestsForQueue): Add new logging.
(WebKit::HostRecord::servePendingRequests): Tweak existing logging.
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::servePendingRequests): Tweak existing logging.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad): Handle archive resource scheduling better,
and add new logging to better explore archive loading behavior in the future.
- 1:16 PM Changeset in webkit [141634] by
-
- 405 edits in trunk
Print GraphicsLayer::m_contentsOpaque if non-default (true)
https://bugs.webkit.org/show_bug.cgi?id=108354
Reviewed by Simon Fraser.
Source/WebCore:
No new tests. This change facilitates testing of GraphicsLayer opaqueness.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):
LayoutTests:
- compositing/absolute-inside-out-of-view-fixed-expected.txt:
- compositing/backing/no-backing-for-clip-expected.txt:
- compositing/backing/no-backing-for-clip-overlap-expected.txt:
- compositing/backing/no-backing-for-perspective-expected.txt:
- compositing/bounds-in-flipped-writing-mode-expected.txt:
- compositing/clip-child-by-non-stacking-ancestor-expected.txt:
- compositing/columns/composited-in-paginated-expected.txt:
- compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
- compositing/geometry/ancestor-overflow-change-expected.txt:
- compositing/geometry/bounds-clipped-composited-child-expected.txt:
- compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt:
- compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- compositing/geometry/bounds-ignores-hidden-expected.txt:
- compositing/geometry/clip-expected.txt:
- compositing/geometry/clip-inside-expected.txt:
- compositing/geometry/composited-in-columns-expected.txt:
- compositing/geometry/fixed-position-composited-switch-expected.txt:
- compositing/geometry/flipped-writing-mode-expected.txt:
- compositing/geometry/foreground-layer-expected.txt:
- compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
- compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
- compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
- compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
- compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- compositing/geometry/limit-layer-bounds-positioned-expected.txt:
- compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
- compositing/geometry/limit-layer-bounds-transformed-expected.txt:
- compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
- compositing/geometry/preserve-3d-switching-expected.txt:
- compositing/iframes/become-composited-nested-iframes-expected.txt:
- compositing/iframes/become-overlapped-iframe-expected.txt:
- compositing/iframes/composited-parent-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- compositing/iframes/connect-compositing-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe2-expected.txt:
- compositing/iframes/connect-compositing-iframe3-expected.txt:
- compositing/iframes/enter-compositing-iframe-expected.txt:
- compositing/iframes/iframe-resize-expected.txt:
- compositing/iframes/iframe-size-from-zero-expected.txt:
- compositing/iframes/invisible-nested-iframe-hide-expected.txt:
- compositing/iframes/invisible-nested-iframe-show-expected.txt:
- compositing/iframes/overlapped-iframe-expected.txt:
- compositing/iframes/overlapped-iframe-iframe-expected.txt:
- compositing/iframes/overlapped-nested-iframes-expected.txt:
- compositing/iframes/page-cache-layer-tree-expected.txt:
- compositing/iframes/scrolling-iframe-expected.txt:
- compositing/images/clip-on-directly-composited-image-expected.txt:
- compositing/layer-creation/animation-overlap-with-children-expected.txt:
- compositing/layer-creation/fixed-position-and-transform-expected.txt:
- compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- compositing/layer-creation/fixed-position-under-transform-expected.txt:
- compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt:
- compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- compositing/layer-creation/overflow-scroll-overlap-expected.txt:
- compositing/layer-creation/overlap-animation-clipping-expected.txt:
- compositing/layer-creation/overlap-animation-container-expected.txt:
- compositing/layer-creation/overlap-animation-expected.txt:
- compositing/layer-creation/overlap-child-layer-expected.txt:
- compositing/layer-creation/overlap-clipping-expected.txt:
- compositing/layer-creation/overlap-transformed-3d-expected.txt:
- compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
- compositing/layer-creation/overlap-transformed-layer-expected.txt:
- compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
- compositing/layer-creation/overlap-transforms-expected.txt:
- compositing/layer-creation/rotate3d-overlap-expected.txt:
- compositing/layer-creation/scroll-partial-update-expected.txt:
- compositing/layer-creation/spanOverlapsCanvas-expected.txt:
- compositing/layer-creation/stacking-context-overlap-expected.txt:
- compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
- compositing/layer-creation/translatez-overlap-expected.txt:
- compositing/masks/mask-layer-size-expected.txt:
- compositing/overflow-trumps-transform-style-expected.txt:
- compositing/overflow/clip-descendents-expected.txt:
- compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- compositing/overflow/content-gains-scrollbars-expected.txt:
- compositing/overflow/content-loses-scrollbars-expected.txt:
- compositing/overflow/overflow-auto-with-touch-expected.txt:
- compositing/overflow/overflow-auto-with-touch-toggle-expected.txt:
- compositing/overflow/overflow-overlay-with-touch-expected.txt:
- compositing/overflow/overflow-scrollbar-layers-expected.txt:
- compositing/overflow/resize-painting-expected.txt:
- compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
- compositing/overflow/scrolling-without-painting-expected.txt:
- compositing/overflow/textarea-scroll-touch-expected.txt:
- compositing/overflow/updating-scrolling-content-expected.txt:
- compositing/plugins/no-backing-store-expected.txt:
- compositing/plugins/small-to-large-composited-plugin-expected.txt:
- compositing/repaint/invalidations-on-composited-layers-expected.txt:
- compositing/repaint/resize-repaint-expected.txt:
- compositing/rtl/rtl-absolute-expected.txt:
- compositing/rtl/rtl-absolute-overflow-expected.txt:
- compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-fixed-expected.txt:
- compositing/rtl/rtl-fixed-overflow-expected.txt:
- compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-absolute-expected.txt:
- compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-fixed-expected.txt:
- compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
- compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-relative-expected.txt:
- compositing/rtl/rtl-relative-expected.txt:
- compositing/tiled-layers-hidpi-expected.txt:
- compositing/tiling/backface-preserve-3d-tiled-expected.txt:
- compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- compositing/tiling/huge-layer-add-remove-child-expected.txt:
- compositing/tiling/huge-layer-expected.txt:
- compositing/tiling/huge-layer-img-expected.txt:
- compositing/tiling/huge-layer-resize-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- compositing/tiling/rotated-tiled-clamped-expected.txt:
- compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- compositing/tiling/tile-cache-zoomed-expected.txt:
- compositing/tiling/tiled-layer-resize-expected.txt:
- compositing/visibility/layer-visible-content-expected.txt:
- compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- compositing/visible-rect/2d-transformed-expected.txt:
- compositing/visible-rect/3d-transform-style-expected.txt:
- compositing/visible-rect/3d-transformed-expected.txt:
- compositing/visible-rect/animated-expected.txt:
- compositing/visible-rect/animated-from-none-expected.txt:
- compositing/visible-rect/clipped-by-viewport-expected.txt:
- compositing/visible-rect/clipped-visible-rect-expected.txt:
- compositing/visible-rect/iframe-and-layers-expected.txt:
- compositing/visible-rect/iframe-no-layers-expected.txt:
- compositing/visible-rect/nested-transform-expected.txt:
- compositing/visible-rect/scrolled-expected.txt:
- css3/compositing/should-have-compositing-layer-expected.txt:
- css3/filters/filtered-compositing-descendant-expected.txt:
- platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt:
- platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/chromium-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/chromium-mac/css3/filters/composited-during-animation-layertree-expected.txt:
- platform/chromium-mac/css3/filters/composited-during-transition-layertree-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- platform/chromium-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
- platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt:
- platform/chromium-win/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-resize-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/chromium-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/chromium-win/css3/filters/composited-during-animation-layertree-expected.txt:
- platform/chromium-win/css3/filters/composited-during-transition-layertree-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/backing/no-backing-for-clip-expected.txt:
- platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/chromium/compositing/canvas/accelerated-canvas-compositing-expected.txt:
- platform/chromium/compositing/columns/composited-in-paginated-expected.txt:
- platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt:
- platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer-expected.txt:
- platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer-expected.txt:
- platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing-expected.txt:
- platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer-expected.txt:
- platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing-expected.txt:
- platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt:
- platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium/compositing/geometry/clip-expected.txt:
- platform/chromium/compositing/geometry/clip-inside-expected.txt:
- platform/chromium/compositing/geometry/composited-in-columns-expected.txt:
- platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt:
- platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt:
- platform/chromium/compositing/geometry/foreground-layer-expected.txt:
- platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
- platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt:
- platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/chromium/compositing/iframes/iframe-resize-expected.txt:
- platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
- platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt:
- platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
- platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt:
- platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt:
- platform/chromium/compositing/iframes/resizer-expected.txt:
- platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt:
- platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-animation-container-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-animation-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
- platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt:
- platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
- platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt:
- platform/chromium/compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
- platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt:
- platform/chromium/compositing/overflow-trumps-transform-style-expected.txt:
- platform/chromium/compositing/overflow/clip-descendents-expected.txt:
- platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt:
- platform/chromium/compositing/overflow/content-loses-scrollbars-expected.txt:
- platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt:
- platform/chromium/compositing/overflow/resize-painting-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium/compositing/rtl/rtl-relative-expected.txt:
- platform/chromium/compositing/tiling/huge-layer-img-expected.txt:
- platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt:
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/content-gains-scrollbars-expected.txt:
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt:
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scrollbar-layers-expected.txt:
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/resize-painting-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/content-gains-scrollbars-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/overflow-scrollbar-layers-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/resize-painting-expected.txt:
- platform/efl/compositing/geometry/foreground-layer-expected.txt:
- platform/efl/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
- platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt:
- platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
- platform/mac/compositing/iframes/resizer-expected.txt:
- platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt:
- platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/mac/compositing/tiling/huge-layer-expected.txt:
- platform/mac/compositing/tiling/huge-layer-img-expected.txt:
- platform/mac/compositing/tiling/huge-layer-resize-expected.txt:
- platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
- platform/mac/compositing/tiling/tiled-layer-resize-expected.txt:
- platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/mac/css3/filters/composited-during-animation-layertree-expected.txt:
- platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
- platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/leave-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt:
- platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
- platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/qt-5.0-wk2/css3/filters/composited-during-animation-layertree-expected.txt:
- platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
- platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt:
- platform/qt/compositing/overflow/clip-descendents-expected.txt:
- platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/qt/css3/compositing/should-have-compositing-layer-expected.txt:
- platform/qt/css3/filters/composited-during-transition-layertree-expected.txt:
- platform/win/compositing/iframes/composited-iframe-expected.txt:
- platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
- platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- 1:13 PM Changeset in webkit [141633] by
-
- 3 edits in trunk/Source/WebCore
Continue making XSSAuditor thread safe: Remove dependency on parser's Document URL
https://bugs.webkit.org/show_bug.cgi?id=108655
Reviewed by Adam Barth.
No new tests because no new functionality.
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::isLikelySafeResource):
- html/parser/XSSAuditor.h:
- 1:08 PM Changeset in webkit [141632] by
-
- 15 edits in trunk/Source/WebKit2
[Qt] [WK2] Fix build after r141619
https://bugs.webkit.org/show_bug.cgi?id=108680
Reviewed by Benjamin Poulain.
Take a reference instead of a pointer for decoding functions.
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::Handle::decode):
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::decodeTimingFunction):
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
- Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::Handle::decode):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
(Handle):
- Shared/qt/ArgumentCodersQt.cpp:
(CoreIPC::::decode):
- Shared/qt/ArgumentCodersQt.h:
(CoreIPC):
- Shared/qt/LayerTreeContextQt.cpp:
(WebKit::LayerTreeContext::decode):
- Shared/qt/PlatformCertificateInfo.h:
(WebKit::PlatformCertificateInfo::decode):
- Shared/qt/QtNetworkReplyData.cpp:
(WebKit::QtNetworkReplyData::decode):
- Shared/qt/QtNetworkReplyData.h:
(QtNetworkReplyData):
- Shared/qt/QtNetworkRequestData.cpp:
(WebKit::QtNetworkRequestData::decode):
- Shared/qt/QtNetworkRequestData.h:
(QtNetworkRequestData):
- Shared/qt/WebCoreArgumentCodersQt.cpp:
(CoreIPC::::decodePlatformData):
- 12:46 PM Changeset in webkit [141631] by
-
- 2 edits in trunk/Tools
Unreviewed. Re-try enabling Win-EWS tests for the third time.
https://bugs.webkit.org/show_bug.cgi?id=107968
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 12:44 PM Changeset in webkit [141630] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r141281): Navigating to this HTTP Live Streaming (application/vnd.apple.mpegurl) URL downloads a file instead of playing it in the browser
https://bugs.webkit.org/show_bug.cgi?id=108674
<rdar://problem/13133595>
Reviewed by Eric Carlson.
When passed a HashSet of available MIME types to fill out, QTKit was overwriting the contents, which were
AVFoundation's supported types. Instead, it should be appending to the list of supported types.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::concatenateHashSets): Added static utility function.
(WebCore::MediaPlayerPrivateQTKit::getSupportedTypes): Concatenate instead of overwriting the passed in MIME types.
- 12:43 PM Changeset in webkit [141629] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip more test in preparation for Win EWS bots (round 2).
https://bugs.webkit.org/show_bug.cgi?id=108249
- platform/win/TestExpectations:
- 12:36 PM Changeset in webkit [141628] by
-
- 2 edits in trunk/Tools
Fix test scripts for EWS bots to get them running once and for all.
https://bugs.webkit.org/show_bug.cgi?id=108422
Reviewed by Timothy Horton.
Disabling --quiet option on Windows for now because that fails when we try to use /dev/null.
runtests.py was not passing in a configuration to run-webkit-tests which causes DRT to build in release by default.
However, we build in Debug only on the EWS Windows bots, which caused the build to fail.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.options):
(RunTests.run):
- 12:27 PM Changeset in webkit [141627] by
-
- 2 edits in trunk/LayoutTests
WTR needs an implementation of setAutomaticLinkDetectionEnabled
https://bugs.webkit.org/show_bug.cgi?id=87162
Skip a test on wk2 added in r14618 that uses setAutomaticLinkDetectionEnabled.
- platform/wk2/TestExpectations:
- 12:21 PM Changeset in webkit [141626] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Zooming in during page load of non-scalable webpage results in fixed magnification
https://bugs.webkit.org/show_bug.cgi?id=108252
Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Yong Li.
Internally reviewed by Konrad Piascik.
PR: 284828
We got float layoutSize(342.284122, 521.448467) and
m_maximumScale(2.243750) after computing viewport meta based on the
device pixel ratio and laid out the contents at IntSize(342, 521).
Therefore, zoomToFitScale(2.245681) would be a bit larger than
m_maximumScale based on that contents size and resulted in
maximumScale()!=minimumScale(), which made the non-scalable page
scalable.
Return zoomToFitScale for maximumScale() in such kind of case.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::maximumScale):
- 12:13 PM Changeset in webkit [141625] by
-
- 2 edits in trunk/Source/WebCore
Another speculative windows build fix.
- platform/ScrollAnimator.h:
- 12:11 PM Changeset in webkit [141624] by
-
- 9 edits3 adds in trunk
[canvas] Add more constructors to Path
https://bugs.webkit.org/show_bug.cgi?id=108587
Patch by Dirk Schulze <krit@webkit.org> on 2013-01-31
Reviewed by Dean Jackson.
Source/WebCore:
Add more constructors to Path object to make it possible
to copy Path objects and parse SVG strings into a Path
object that can be used on the canvas context afterwards.
Test: fast/canvas/canvas-path-constructors.html
- html/canvas/DOMPath.h: New constructors for Path.
(WebCore::DOMPath::create):
(WebCore::DOMPath::DOMPath):
- html/canvas/DOMPath.idl: Ditto.
LayoutTests:
Add tests for new constructors of Path objects.
Since the feature is behind a flag, the test is skipped on
all platforms for now.
- fast/canvas/canvas-path-constructors-expected.txt: Added.
- fast/canvas/canvas-path-constructors.html: Added.
- fast/canvas/script-tests/canvas-path-constructors.js: Added.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 12:11 PM Changeset in webkit [141623] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] InputHandler status is not restored when page history goes back
https://bugs.webkit.org/show_bug.cgi?id=108448
Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-01
Reviewed by Yong Li.
PR288406 Internally reviewed by Mike Fenton
When webpage goes back, it restores the old frame's selection and focused node,
but we don't save the InputHandler's status, it becomes non-input mode when page
goes back. When it restores the focus, since the new focus node is same as the old
document focused node, webcore will not notify client to update the input handler.
This patch updates the input handler's status by notifying it focus node changed.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::restoreViewState):
(WebKit):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 12:06 PM Changeset in webkit [141622] by
-
- 9 edits in trunk
[GTK] Add WTFURL source files to the build
https://bugs.webkit.org/show_bug.cgi?id=108215
Reviewed by Benjamin Poulain.
.:
- Source/autotools/symbols.filter: Force the export of the KURL::string() symbol.
This is required when using the WTFURL backend but otherwise doesn't affect the build.
Source/WebCore:
- platform/KURLWTFURL.cpp:
(WebCore): Only use the stub implementation of the fileSystemPath method for the
Apple ports, other ports should for now still rely on their platform-specific implementations.
Source/WTF:
The WTFURL implementation sources are all still guarded by the USE(WTFURL) guard,
meaning that the GTK port still uses the default KURL backend. To use the WTFURL
backend instead, one would have to define WTF_USE_WTFURL in Platform.h.
- GNUmakefile.am: List the directories from which source headers will be included.
Plenty of WTFURL code currently just includes the required header by name rather
than specifying the header path as relative to Source/WTF. In the future all the inclusions
should probaby be changed to include the header through the path relative to Source/WTF.
- GNUmakefile.list.am: Add build targets for the WTFURL source files.
- wtf/url/api/ParsedURL.cpp: Specify the complete path to the required headers and
reorder the inclusions.
- wtf/url/src/URLCanon.h: Ditto.
- 11:58 AM Changeset in webkit [141621] by
-
- 13 edits in trunk
Remove call to SecurityOrigin::canAccessDatabase from IDB constructor.
https://bugs.webkit.org/show_bug.cgi?id=108477
Reviewed by Adam Barth.
Source/WebCore:
This change removes the 'SecurityOrigin::canAccessDatabase' check from
the constructor for the 'indexedDB' property on both DOMWindow and
WorkerContext. After the patch for http://wkbug.com/94171 this check
is redundant, as all the entry points to IDB are now gated on access
being granted.
As a side-effect, dropping the check in WorkerContextIndexedDatabase
allows us to stop holding a pointer to the ScriptExecutionContext we're
extending, which can only be a good thing.
The tests in storage/indexeddb should continue to pass.
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::indexedDB):
Drop the SecurityOrigin::canAccessDatabase check.
- Modules/indexeddb/WorkerContextIndexedDatabase.cpp:
(WebCore::WorkerContextIndexedDatabase::WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::from):
Drop the ScriptExecutionContext parameter from the class's
constructor and callsites.
(WebCore::WorkerContextIndexedDatabase::indexedDB):
Drop the SecurityOrigin::canAccessDatabase check.
- Modules/indexeddb/WorkerContextIndexedDatabase.h:
(WorkerContextIndexedDatabase):
Drop the stored pointer to ScriptExecutionContext, as we no longer
need it in ::indexedDB.
LayoutTests:
- http/tests/security/no-indexeddb-from-sandbox-expected.txt:
- http/tests/security/no-indexeddb-from-sandbox.html:
This test expected the 'webkitIndexedDB' property to be missing
entirely inside a sandbox. The expectation has been updated to
expect 'webkitIndexedDB.open()' to throw a SECURITY_ERR.
- platform/efl/TestExpectations:
- platform/mac-snowleopard/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
This test was accidentally passing on a variety of platforms that
don't yet implement IndexedDB. Now that failure is distinguishable
we should skip it on a variety of platforms.
- 11:54 AM Changeset in webkit [141620] by
-
- 2 edits in trunk/Source/WebCore
Speculative Windows build fix.
- platform/ScrollAnimator.h:
(WebCore):
- 11:53 AM Changeset in webkit [141619] by
-
- 109 edits in trunk/Source/WebKit2
Message decoding functions should take a MessageDecoder reference
https://bugs.webkit.org/show_bug.cgi?id=108669
Reviewed by Andreas Kling.
Message encoding functions already take a reference instead of a pointer, so
make the decoding functions take a reference as well.
- Platform/CoreIPC/ArgumentCoder.h:
(CoreIPC::ArgumentCoder::decode):
- Platform/CoreIPC/ArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::decodeStringText):
- Platform/CoreIPC/ArgumentCoders.h:
(CoreIPC::SimpleArgumentCoder::decode):
- Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::decode):
- Platform/CoreIPC/Arguments.h:
(CoreIPC::Arguments0::decode):
(CoreIPC::Arguments1::decode):
(CoreIPC::Arguments2::decode):
(CoreIPC::Arguments3::decode):
(CoreIPC::Arguments4::decode):
(CoreIPC::Arguments5::decode):
(CoreIPC::Arguments6::decode):
(CoreIPC::Arguments7::decode):
(CoreIPC::Arguments8::decode):
(CoreIPC::Arguments10::decode):
- Platform/CoreIPC/Attachment.cpp:
(CoreIPC::Attachment::decode):
- Platform/CoreIPC/Attachment.h:
(Attachment):
- Platform/CoreIPC/DataReference.cpp:
(CoreIPC::DataReference::decode):
- Platform/CoreIPC/DataReference.h:
(DataReference):
- Platform/CoreIPC/StringReference.cpp:
(CoreIPC::StringReference::decode):
- Platform/CoreIPC/StringReference.h:
(StringReference):
- Platform/CoreIPC/mac/MachPort.h:
(CoreIPC::MachPort::decode):
- Platform/SharedMemory.h:
(Handle):
- Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::Handle::decode):
- PluginProcess/PluginCreationParameters.cpp:
(WebKit::PluginCreationParameters::decode):
- PluginProcess/PluginCreationParameters.h:
(PluginCreationParameters):
- Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::decode):
- Shared/DictionaryPopupInfo.h:
(DictionaryPopupInfo):
- Shared/EditorState.cpp:
(WebKit::EditorState::decode):
- Shared/EditorState.h:
(EditorState):
- Shared/FontInfo.cpp:
(WebKit::FontInfo::decode):
- Shared/FontInfo.h:
(FontInfo):
- Shared/LayerTreeContext.h:
(LayerTreeContext):
- Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::decode):
- Shared/Network/NetworkProcessCreationParameters.h:
(NetworkProcessCreationParameters):
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::decode):
- Shared/Network/NetworkResourceLoadParameters.h:
(NetworkResourceLoadParameters):
- Shared/OriginAndDatabases.cpp:
(WebKit::OriginAndDatabases::decode):
- Shared/OriginAndDatabases.h:
(OriginAndDatabases):
- Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::decode):
- Shared/PlatformPopupMenuData.h:
(PlatformPopupMenuData):
- Shared/Plugins/NPIdentifierData.cpp:
(WebKit::NPIdentifierData::decode):
- Shared/Plugins/NPIdentifierData.h:
(NPIdentifierData):
- Shared/Plugins/NPVariantData.cpp:
(WebKit::NPVariantData::decode):
- Shared/Plugins/NPVariantData.h:
(NPVariantData):
- Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::decode):
- Shared/Plugins/PluginProcessCreationParameters.h:
(PluginProcessCreationParameters):
- Shared/PrintInfo.cpp:
(WebKit::PrintInfo::decode):
- Shared/PrintInfo.h:
(PrintInfo):
- Shared/SandboxExtension.h:
(Handle):
(HandleArray):
(WebKit::SandboxExtension::Handle::decode):
(WebKit::SandboxExtension::HandleArray::decode):
- Shared/SecurityOriginData.cpp:
(WebKit::SecurityOriginData::decode):
- Shared/SecurityOriginData.h:
(SecurityOriginData):
- Shared/SessionState.cpp:
(WebKit::SessionState::decode):
- Shared/SessionState.h:
(SessionState):
- Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::Handle::decode):
- Shared/ShareableBitmap.h:
(Handle):
- Shared/ShareableResource.cpp:
(WebKit::ShareableResource::Handle::decode):
- Shared/ShareableResource.h:
(Handle):
- Shared/SharedWorkerProcessCreationParameters.cpp:
(WebKit::SharedWorkerProcessCreationParameters::decode):
- Shared/SharedWorkerProcessCreationParameters.h:
(SharedWorkerProcessCreationParameters):
- Shared/StatisticsData.cpp:
(WebKit::StatisticsData::decode):
- Shared/StatisticsData.h:
(StatisticsData):
- Shared/StringPairVector.h:
(WebKit::StringPairVector::decode):
- Shared/UpdateInfo.cpp:
(WebKit::UpdateInfo::decode):
- Shared/UpdateInfo.h:
(UpdateInfo):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::decode):
- Shared/WebContextMenuItemData.h:
(WebContextMenuItemData):
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::decodeImage):
- Shared/WebCoreArgumentCoders.h:
- Shared/WebEvent.cpp:
(WebKit::WebEvent::decode):
- Shared/WebEvent.h:
(WebEvent):
(WebMouseEvent):
(WebWheelEvent):
(WebKeyboardEvent):
(WebGestureEvent):
(WebPlatformTouchPoint):
(WebTouchEvent):
- Shared/WebGeolocationPosition.cpp:
(WebKit::WebGeolocationPosition::Data::decode):
- Shared/WebGeolocationPosition.h:
(Data):
- Shared/WebGestureEvent.cpp:
(WebKit::WebGestureEvent::decode):
- Shared/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::Data::decode):
- Shared/WebHitTestResult.h:
(Data):
- Shared/WebKeyboardEvent.cpp:
(WebKit::WebKeyboardEvent::decode):
- Shared/WebMouseEvent.cpp:
(WebKit::WebMouseEvent::decode):
- Shared/WebNavigationDataStore.h:
(WebKit::WebNavigationDataStore::decode):
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
(WebPageCreationParameters):
- Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::decode):
- Shared/WebPageGroupData.h:
(WebPageGroupData):
- Shared/WebPlatformTouchPoint.cpp:
(WebKit::WebPlatformTouchPoint::decode):
- Shared/WebPopupItem.cpp:
(WebKit::WebPopupItem::decode):
- Shared/WebPopupItem.h:
- Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::decode):
- Shared/WebPreferencesStore.h:
(WebPreferencesStore):
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
- Shared/WebTouchEvent.cpp:
(WebKit::WebTouchEvent::decode):
- Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::decode):
- Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode):
- Shared/cf/ArgumentCodersCF.h:
(CoreIPC):
- Shared/mac/ArgumentCodersMac.h:
(CoreIPC):
- Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::decode):
- Shared/mac/AttributedString.h:
(AttributedString):
- Shared/mac/AttributedString.mm:
(WebKit::AttributedString::decode):
- Shared/mac/ColorSpaceData.h:
(ColorSpaceData):
- Shared/mac/ColorSpaceData.mm:
(WebKit::ColorSpaceData::decode):
- Shared/mac/LayerTreeContextMac.mm:
(WebKit::LayerTreeContext::decode):
- Shared/mac/ObjCObjectGraphCoders.h:
(WebContextObjCObjectGraphDecoder):
(InjectedBundleObjCObjectGraphDecoder):
- Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::ObjCObjectGraphDecoder::baseDecode):
(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
(WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode):
(WebKit::WebContextObjCObjectGraphDecoder::decode):
(WebKit::InjectedBundleObjCObjectGraphDecoder::decode):
- Shared/mac/PlatformCertificateInfo.h:
(PlatformCertificateInfo):
- Shared/mac/PlatformCertificateInfo.mm:
(WebKit::PlatformCertificateInfo::decode):
- Shared/mac/RemoteLayerTreeTransaction.h:
(LayerProperties):
(RemoteLayerTreeTransaction):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::decode):
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::Handle::decode):
(WebKit::SandboxExtension::HandleArray::decode):
- Shared/mac/SecItemRequestData.cpp:
(WebKit::SecItemRequestData::decode):
- Shared/mac/SecItemRequestData.h:
- Shared/mac/SecItemResponseData.cpp:
(WebKit::SecItemResponseData::decode):
- Shared/mac/SecItemResponseData.h:
(SecItemResponseData):
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::decodePlatformData):
(CoreIPC::::decode):
- UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageDecoder::decode):
- WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageDecoder::decode):
- WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Parameters::decode):
- WebProcess/Plugins/Plugin.h:
(Parameters):
- 11:44 AM Changeset in webkit [141618] by
-
- 3 edits2 adds in trunk
Smart link can erroneously move caret after an URL when typing immediately before it
https://bugs.webkit.org/show_bug.cgi?id=92812
Reviewed by Enrica Casucci.
Source/WebCore:
The bug was caused by smart link being triggered even when a user finished typing a word
immediately before an URL. We already had a logic to avoid smart-linking an URL when the caret
was after the URL but we were missing a check for when the caret is before the URL.
Fixed the bug by adding this check.
Test: editing/inserting/smart-link-when-caret-is-moved-before-URL.html
- editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):
LayoutTests:
Add a regression for typing immediately before an URL while smart link is enabled.
WebKit should not be moving the caret erroneously.
- editing/inserting/smart-link-when-caret-is-moved-before-URL-expected.txt: Added.
- editing/inserting/smart-link-when-caret-is-moved-before-URL.html: Added.
- 11:40 AM Changeset in webkit [141617] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Windows build fix. FloatSize.cpp was not included in the project.
- WebCore.vcproj/WebCore.vcproj:
- 11:29 AM Changeset in webkit [141616] by
-
- 4 edits2 adds in trunk
[CSS Grid Layout] computePreferredLogicalWidths doesn't handle minmax tracks
https://bugs.webkit.org/show_bug.cgi?id=108403
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/css-grid-layout/grid-preferred-logical-widths.html
The code before this change was only handling minmax() with 2 fixed widths.
The new code was updated to remove this artificial limitation and we now
support all combination of minmax().
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computePreferredLogicalWidths):
Updated to use computePreferredTrackWidth..
(WebCore::RenderGrid::computePreferredTrackWidth):
Added this helper function that implements the core of the preferred width
computation.
- rendering/RenderGrid.h: Added computePreferredTrackWidth.
LayoutTests:
- fast/css-grid-layout/grid-preferred-logical-widths-expected.txt: Added.
- fast/css-grid-layout/grid-preferred-logical-widths.html: Added.
- 11:25 AM Changeset in webkit [141615] by
-
- 5 edits3 adds in trunk
Cached main resources report a zero identifer on 304s
https://bugs.webkit.org/show_bug.cgi?id=108402
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/cache/iframe-304-crash.html
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::responseReceived): Throughout, check m_identifierForLoadWithoutResourceLoader
instead of !loader() to determine whether MainResourceLoader needs to synthesize resource load callbacks.
(WebCore::MainResourceLoader::dataReceived):
(WebCore::MainResourceLoader::didFinishLoading):
LayoutTests:
- http/tests/cache/iframe-304-crash-expected.txt: Added.
- http/tests/cache/iframe-304-crash.html: Added.
- http/tests/cache/resources/iframe304.php: Added.
- platform/chromium/TestExpectations: New test requires main resource caching, which isn't supported on chromium at the moment.
- platform/mac/TestExpectations: New test requires main resource caching, which isn't supported on mac at the moment.
- 11:14 AM Changeset in webkit [141614] by
-
- 11 edits in trunk
[chromium] Build webkit with enable_web_intents set to 0.
https://bugs.webkit.org/show_bug.cgi?id=108408
Reviewed by Tony Chang.
I'll then make chromium build fine with that, then switch
enable_web_intents to 0, roll that into webkit, and then
actually remove the code hidden behind this flag.
Source/WebCore:
- bindings/v8/custom/V8IntentCustom.cpp:
Source/WebKit/chromium:
The features.gypi bit depends on https://codereview.chromium.org/12143002/
and will disable web intents support on android. Since common.gypi
sets enable_web_intents to 0 explicitly, it seems this is currently on
by accident anyway.
While it looks like this CL just removes ENABLE_WEB_INTENTS=1 from
features.gypi completely, it's still set further down the file if
enable_web_intents is on.
- WebKit.gyp:
- features.gypi:
- src/WebFrameImpl.cpp:
Tools:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 11:07 AM Changeset in webkit [141613] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: make console object state hint non-active
https://bugs.webkit.org/show_bug.cgi?id=108642
Reviewed by Vsevolod Vlasov.
Otherwise it seems like an active element user could click.
- inspector/front-end/inspector.css:
(.object-info-state-note):
- 11:04 AM Changeset in webkit [141612] by
-
- 3 edits18 adds in trunk
Zero size gradient should paint nothing on canvas
https://bugs.webkit.org/show_bug.cgi?id=102654
Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-02-01
Reviewed by Dirk Schulze.
Source/WebCore:
The functions fill(), fillText(), stroke(), strokeRect() and strokeText()
should paint nothing on canvas when the canvas fillStyle/strokeStyle
is set to a zero size gradient.
Tests: fast/canvas/canvas-fill-zeroSizeGradient.html
fast/canvas/canvas-fillRect-zeroSizeGradient.html
fast/canvas/canvas-fillText-zeroSizeGradient.html
fast/canvas/canvas-stroke-zeroSizeGradient.html
fast/canvas/canvas-strokeRect-zeroSizeGradient.html
fast/canvas/canvas-strokeText-zeroSizeGradient.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::strokeRect):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
LayoutTests:
The functions fill(), fillText(), stroke(), strokeRect() and strokeText()
should paint nothing on canvas when the canvas fillStyle/strokeStyle
is set to a zero size gradient.
- fast/canvas/canvas-fill-zeroSizeGradient-expected.txt: Added.
- fast/canvas/canvas-fill-zeroSizeGradient.html: Added.
- fast/canvas/canvas-fillRect-zeroSizeGradient-expected.txt: Added.
- fast/canvas/canvas-fillRect-zeroSizeGradient.html: Added.
- fast/canvas/canvas-fillText-zeroSizeGradient-expected.txt: Added.
- fast/canvas/canvas-fillText-zeroSizeGradient.html: Added.
- fast/canvas/canvas-stroke-zeroSizeGradient-expected.txt: Added.
- fast/canvas/canvas-stroke-zeroSizeGradient.html: Added.
- fast/canvas/canvas-strokeRect-zeroSizeGradient-expected.txt: Added.
- fast/canvas/canvas-strokeRect-zeroSizeGradient.html: Added.
- fast/canvas/canvas-strokeText-zeroSizeGradient-expected.txt: Added.
- fast/canvas/canvas-strokeText-zeroSizeGradient.html: Added.
- fast/canvas/script-tests/canvas-fill-zeroSizeGradient.js: Added.
- fast/canvas/script-tests/canvas-fillRect-zeroSizeGradient.js: Added.
- fast/canvas/script-tests/canvas-fillText-zeroSizeGradient.js: Added.
- fast/canvas/script-tests/canvas-stroke-zeroSizeGradient.js: Added.
- fast/canvas/script-tests/canvas-strokeRect-zeroSizeGradient.js: Added.
- fast/canvas/script-tests/canvas-strokeText-zeroSizeGradient.js: Added.
- 11:00 AM Changeset in webkit [141611] by
-
- 2 edits in trunk/Source/WebCore
HRTFElevation segfault if a null AudioBus is returned by loadPlatformResource
https://bugs.webkit.org/show_bug.cgi?id=108504
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-02-01
Reviewed by Kenneth Russell.
Fixed a segfault by checking if the returned AudioBus is null or not.
If it is, we should early return in the same way it was being done already
in HRTFElevation::calculateKernelsForAzimuthElevation();
No new tests, covered by existing tests.
- platform/audio/HRTFElevation.cpp:
(WebCore::getConcatenatedImpulseResponsesForSubject):
- 10:59 AM Changeset in webkit [141610] by
-
- 8 edits in trunk/Source/WebCore
ScrollAnimatorMac should adopt contentAreaScrolledInDirection
https://bugs.webkit.org/show_bug.cgi?id=108647
-and corresponding-
<rdar://problem/12434779>
Reviewed by Anders Carlsson.
This patch makes notifyContentAreaScrolled() and notifyPositionChanged() take a
FloatSize parameter that represents the scroll delta so that it can be passed
along to contentAreaScrolledInDirection:.
Pass along the scroll delta.
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
The delta is not needed in this base-class implementation. It will only be needed
in the ScrollAnimatorMac override.
(WebCore::ScrollAnimator::notifyPositionChanged):
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::notifyContentAreaScrolled):
Pass along the delta.
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollPositionChanged):
Add contentAreaScrolledInDirection: to the NSScrollerImpDetails.
- platform/mac/NSScrollerImpDetails.h:
New member variable m_contentAreaScrolledTimerScrollDelta stores the current
scroll delta while we are waiting for m_sendContentAreaScrolledTimer to fire.
- platform/mac/ScrollAnimatorMac.h:
We need this so that we can call just contentAreaScrolled if
contentAreaScrolledInDirection: is not available.
- platform/mac/ScrollAnimatorMac.mm:
(supportsContentAreaScrolledInDirection):
Pass along the delta.
(WebCore::ScrollAnimatorMac::immediateScrollTo):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::immediateScrollBy):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledSoon):
If contentAreaScrolledInDirection: is available, call it with the delta, and then
reset our delta. Otherwise, still call contentAreaScrolled.
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):
- 10:56 AM Changeset in webkit [141609] by
-
- 2 edits2 copies in branches/chromium/1364
Merge 141357
[Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
https://bugs.webkit.org/show_bug.cgi?id=108381
Reviewed by James Robinson.
Source/WebKit/chromium:
WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
touch events. Some plugins make this request more than once, leading to an imbalance in Document's
touch event handler map, and a stale node pointer when the plugin is destroyed. This change
has WebPluginContainerImpl only add one ref for the plugin at a time.
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::requestTouchEventType):
Tools:
- DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Adding an attribute that
tickles the case in WebPluginContainerImpl that imbalanced touch handler refs in Document.
LayoutTests:
- platform/chromium/plugins/re-request-touch-events-crash-expected.txt: Added.
- platform/chromium/plugins/re-request-touch-events-crash.html: Added.
TBR=leviw@chromium.org
Review URL: https://codereview.chromium.org/12088115
- 10:55 AM Changeset in webkit [141608] by
-
- 4 edits in trunk
Source/WebKit/chromium: [Chromium] Ignore whitespace in spellcheck
https://bugs.webkit.org/show_bug.cgi?id=108510
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Ryosuke Niwa.
- src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspellingAsync): Ignore whitespace when selecting the misspelling.
LayoutTests: [Chromium] Expect spellcheck to ignore whitespace
https://bugs.webkit.org/show_bug.cgi?id=108510
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Ryosuke Niwa.
- platform/chromium/TestExpectations: Expect spellcheck to ignore whitespace.
- 10:49 AM Changeset in webkit [141607] by
-
- 4 edits in trunk
Web Inspector: [file selector dialog] for mixed case queries, score uppercase letters only when assessing camelcase.
https://bugs.webkit.org/show_bug.cgi?id=108639
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):
LayoutTests:
- inspector/filtered-item-selection-dialog-filtering-expected.txt:
- 10:45 AM Changeset in webkit [141606] by
-
- 3 edits4 adds in trunk
Padding in a parent inline preceding an empty inline child should be counted towards width
https://bugs.webkit.org/show_bug.cgi?id=108226
Reviewed by Levi Weintraub.
Source/WebCore:
Add the border/padding/margin from an empty inline's parent inline if it is the first or last
child of the inline.
Tests: fast/inline/parent-inline-element-padding-contributes-width.html
fast/inline/positioned-element-padding-contributes-width.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/inline/parent-inline-element-padding-contributes-width-expected.txt: Added.
- fast/inline/parent-inline-element-padding-contributes-width.html: Added.
- fast/inline/positioned-element-padding-contributes-width-expected.txt: Added.
- fast/inline/positioned-element-padding-contributes-width.html: Added.
- 10:40 AM Changeset in webkit [141605] by
-
- 4 edits in trunk/Source/WebCore
Continue making XSSAuditor thread safe: Remove dependencies on m_parser from init()
https://bugs.webkit.org/show_bug.cgi?id=108531
Reviewed by Adam Barth.
The threaded HTML parser will create and init() the XSSAuditor on the main thread, but filterToken() will be called on the background.
No new tests because no change in functionality.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
- html/parser/XSSAuditor.h:
(WebCore):
(XSSAuditor):
- 10:32 AM Changeset in webkit [141604] by
-
- 3 edits in trunk/Source/JavaScriptCore
Removed an unused function: JSGlobalObject::createFunctionExecutableFromGlobalCode
https://bugs.webkit.org/show_bug.cgi?id=108657
Reviewed by Anders Carlsson.
- runtime/JSGlobalObject.cpp:
(JSC):
- runtime/JSGlobalObject.h:
(JSGlobalObject):
- 10:31 AM Changeset in webkit [141603] by
-
- 4 edits in trunk/Source/WebCore
Remove unnecessary parameter from DocumentLoader::scheduleArchiveLoad
https://bugs.webkit.org/show_bug.cgi?id=108654
Reviewed by Alexey Proskuryakov.
No new tests (No behavior change.)
Remove the KURL parameter parameter from this method which, in practice,
is always the same as the url of the ResourceRequest parameter.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):
- loader/DocumentLoader.h:
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::start):
- 10:18 AM Changeset in webkit [141602] by
-
- 3 edits in trunk/Tools
Set the GTK 64-bit Debug builder to build and test only WebKit1
https://bugs.webkit.org/show_bug.cgi?id=108648
Reviewed by Philippe Normand.
- BuildSlaveSupport/build.webkit.org-config/config.json: Change the builder name, type and
build directory to note that the builder builds and tests only the WebKit1 port on the GTK platform.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit1Only): Add the new build class that builds only the WebKit1 port of the builder's platform.
(BuildAndTestWebKit1OnlyFactory): Add the new factory that uses the CompileWebKit1Only build class
for building and testing only WebKit1 on the builder's platform.
- 9:49 AM Changeset in webkit [141601] by
-
- 2 edits in tags/Safari-537.26.5/Source/WebKit2
Merged r141180. <rdar://problem/13047398>
- 9:46 AM Changeset in webkit [141600] by
-
- 29 edits in tags/Safari-537.26.5/Source/WebKit2
Merged r141167. <rdar://problem/13047398>
- 9:18 AM Changeset in webkit [141599] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Adapt WorkQueueGtk to the latest changes in WebKit2 after r141497
https://bugs.webkit.org/show_bug.cgi?id=108607
Reviewed by Anders Carlsson.
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::EventSource::executeEventSource): Remove the is valid
work queue check.
(WorkQueue::EventSource): WorkQueue is now refcounted, so keep a
reference when a new job is scheduled and unref it when it
finishes.
- 8:34 AM Changeset in webkit [141598] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] Make QWebHistory unit tests more robust
Reviewed by Jocelyn Turcotten.
The tests were using a QEventLoop::exec() call to verify the emission
of the loadFinished() signal after calling for example back() or forward().
However sometimes the call to back() may emit the signal immediately and
sometimes async, causing instabilities in test runs. The call to exec()
also means that if there was a bug then the rest would hang forever because
exec() has no timeout.
This patch introduces a simple SignalBarrier class that solves both issues:
(1) ensureSignalEmitted() supports the immediate signal emission case as well
as the async one.
(2) Through the use of QSignalSpy's wait() there's an actual timeout.
- tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::init):
(tst_QWebHistory::cleanup):
(tst_QWebHistory::back):
(tst_QWebHistory::forward):
(tst_QWebHistory::goToItem):
(tst_QWebHistory::serialize_2):
- tests/util.h:
(waitForSignal):
(SignalBarrier):
(SignalBarrier::SignalBarrier):
(SignalBarrier::ensureSignalEmitted):
- 8:14 AM Changeset in webkit [141597] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
Unreviewed, GTK build fix after r141566.
- POTFILES.in: The FullscreenVideoController moved to WebCore.
- 8:02 AM Changeset in webkit [141596] by
-
- 18 edits1 add1 delete in trunk/Tools
[chromium] move ownership of TestRunner object to TestInterfaces
https://bugs.webkit.org/show_bug.cgi?id=108464
Reviewed by Adam Barth.
Before, TestShell owned the class. This also removes the last include
from DumpRenderTree to TestRunner/src.
This also deletes TestDelegate and uses WebTestDelegate everywhere
instead.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebTestInterfaces):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebKit):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
- DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
(WebTestRunner):
(WebTestRunner::AccessibilityController::setDelegate):
(AccessibilityController):
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::makeMenuItemStringsFor):
- DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(WebTestRunner):
(WebTestRunner::EventSender::setDelegate):
(EventSender):
- DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:
(WebTestRunner::GamepadController::setDelegate):
- DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
(WebTestRunner):
(GamepadController):
- DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::~TestInterfaces):
(WebTestRunner::TestInterfaces::setWebView):
(WebTestRunner::TestInterfaces::setDelegate):
(WebTestRunner::TestInterfaces::bindTo):
(WebTestRunner::TestInterfaces::resetAll):
(WebTestRunner):
(WebTestRunner::TestInterfaces::setTestIsRunning):
(WebTestRunner::TestInterfaces::testRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebTestRunner):
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebKit):
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::Internal::testRunner):
(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::Internal):
(WebTestRunner::WebTestInterfaces::Internal::setDelegate):
(WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
- DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Added.
(WebTestRunner):
(WebTestRunner::WebTestRunner::WebTestRunner):
(WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpAsText):
(WebTestRunner::WebTestRunner::setShouldDumpAsText):
(WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
(WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
(WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
(WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
(WebTestRunner::WebTestRunner::shouldDumpAsAudio):
(WebTestRunner::WebTestRunner::audioData):
(WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
(WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
(WebTestRunner::WebTestRunner::shouldDumpCreateView):
(WebTestRunner::WebTestRunner::canOpenWindows):
(WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
(WebTestRunner::WebTestRunner::webPermissions):
(WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
(WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
(WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
(WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
(WebTestRunner::WebTestRunner::testRepaint):
(WebTestRunner::WebTestRunner::sweepHorizontally):
(WebTestRunner::WebTestRunner::isPrinting):
(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
(WebTestRunner::WebTestRunner::setTitleTextDirection):
(WebTestRunner::WebTestRunner::httpHeadersToClear):
(WebTestRunner::WebTestRunner::shouldBlockRedirects):
(WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
(WebTestRunner::WebTestRunner::setTopLoadingFrame):
(WebTestRunner::WebTestRunner::topLoadingFrame):
(WebTestRunner::WebTestRunner::policyDelegateDone):
(WebTestRunner::WebTestRunner::policyDelegateEnabled):
(WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
(WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
(WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
(WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
(WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::runFileTest):
(TestShell::resetTestController):
(TestShell::dump):
(TestShell::bindJSObjectsToWindow):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::testRunner):
(TestShell):
- 7:58 AM Changeset in webkit [141595] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r180131. Requested by
"Florin Malita" <fmalita@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01
- DEPS:
- 7:46 AM Changeset in webkit [141594] by
-
- 6 edits in trunk
Web Inspector: relax goto file matching again.
https://bugs.webkit.org/show_bug.cgi?id=108346
Reviewed by Vsevolod Vlasov.
Source/WebCore:
This change brings back behavior introduced in r116244.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegex):
(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems.compareFunction):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
(WebInspector.FilteredItemSelectionDialog.prototype.itemElement):
(WebInspector.OpenResourceDialog):
- inspector/front-end/utilities.js:
(String.regexSpecialCharacters):
(String.prototype.escapeForRegExp):
LayoutTests:
- inspector/filtered-item-selection-dialog-filtering-expected.txt:
- inspector/filtered-item-selection-dialog-filtering.html:
- 7:43 AM Changeset in webkit [141593] by
-
- 8 edits in trunk
Web Inspector: Navigator should not create tree elements for uiSourceCodes unless neededm should populate folders on expand only.
https://bugs.webkit.org/show_bug.cgi?id=108601
Reviewed by Pavel Feldman.
Source/WebCore:
Tree elememnts for uiSourceCodes are not created until really needed anymore.
They are now created when parent folder tree elememnts are expanded or when uiSourceCode is revealed in navigator.
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype.addUISourceCode):
(WebInspector.NavigatorView.prototype._getOrCreateScriptTreeElement):
(WebInspector.NavigatorView.prototype._getScriptTreeElement):
(WebInspector.NavigatorView.prototype._createScriptTreeElement):
(WebInspector.NavigatorView.prototype._removeScriptTreeElement):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype.isScriptSourceAdded):
(WebInspector.NavigatorView.prototype.revealUISourceCode):
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorView.prototype.reset):
(WebInspector.NavigatorView.prototype.createFolderTreeElement):
(WebInspector.NavigatorView.prototype._populateFolderTreeElement):
(WebInspector.NavigatorView.prototype._addScriptTreeElement):
(WebInspector.NavigatorView.prototype._adoptUISourceCode):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.onpopulate):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.):
(initialize_DebuggerTest):
- inspector/debugger/scripts-file-selector-expected.txt:
- inspector/debugger/scripts-file-selector.html:
- inspector/debugger/scripts-sorting-expected.txt:
- inspector/debugger/scripts-sorting.html:
- 7:40 AM Changeset in webkit [141592] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, flagging more fullscreen tests in GTK due to bug 108363.
- platform/gtk/TestExpectations:
- 7:32 AM Changeset in webkit [141591] by
-
- 9 edits in trunk/Source/WTF
Web Inspector: Native Memory Instrumentation: provide edge names and class names for WTF containers and strings
https://bugs.webkit.org/show_bug.cgi?id=107303
Reviewed by Yury Semikhatsky.
I'd like to use ValueType[] as className for the container data members
because class names of template parameters already present in the container class names.
- wtf/MemoryInstrumentationArrayBufferView.h:
(WTF::reportMemoryUsage):
- wtf/MemoryInstrumentationHashCountedSet.h:
(WTF::reportMemoryUsage):
- wtf/MemoryInstrumentationHashMap.h:
(WTF::reportMemoryUsage):
- wtf/MemoryInstrumentationHashSet.h:
(WTF::reportMemoryUsage):
- wtf/MemoryInstrumentationListHashSet.h:
(WTF::reportMemoryUsage):
- wtf/MemoryInstrumentationSequence.h:
- wtf/MemoryInstrumentationString.h:
(WTF::reportMemoryUsage):
- wtf/MemoryInstrumentationVector.h:
(WTF::reportMemoryUsage):
- 7:27 AM Changeset in webkit [141590] by
-
- 3 edits in trunk/Tools
PatchLog process durations are increasing linearly with time (faulty data logging)
https://bugs.webkit.org/show_bug.cgi?id=108621
Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-01
Reviewed by Eric Seidel.
Added a check to prevent a stop event from happening to the same patch multiple times.
- QueueStatusServer/loggers/recordpatchevent.py:
(RecordPatchEvent.stopped):
- 7:27 AM Changeset in webkit [141589] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: TabbedEditorContainer.History performance optimization.
https://bugs.webkit.org/show_bug.cgi?id=108581
Introduced history items indexing by url.
Reviewed by Pavel Feldman.
Covered by existing test.
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.History):
(WebInspector.TabbedEditorContainer.History.prototype.index):
(WebInspector.TabbedEditorContainer.History.prototype._rebuildItemIndex):
(WebInspector.TabbedEditorContainer.History.prototype.update):
(WebInspector.TabbedEditorContainer.History.prototype.remove):
- 7:01 AM Changeset in webkit [141588] by
-
- 6 edits1 add in trunk/Source
Added TriState to WTF and started using it in one place
https://bugs.webkit.org/show_bug.cgi?id=108628
Reviewed by Beth Dakin.
- runtime/PrototypeMap.h:
(JSC::PrototypeMap::isPrototype): Use TriState instead of boolean. In
response to review feedback, this is an attempt to clarify that our
'true' condition is actually just a 'maybe'.
- runtime/PrototypeMap.h:
(PrototypeMap):
(JSC::PrototypeMap::isPrototype):
../WebCore:
- editing/EditingStyle.h:
(WebCore): Moved TriState to WTF so it can be used in more places.
../WTF:
Useful for expressing "maybe" conditions in a boolean context.
- WTF.xcodeproj/project.pbxproj:
- wtf/TriState.h: Added.
(WTF):
- 6:17 AM Changeset in webkit [141587] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r141319.
http://trac.webkit.org/changeset/141319
https://bugs.webkit.org/show_bug.cgi?id=108629
This patch is causing the UIProcess to hang on GTK port when
loading plugins (Requested by chris-qBT_laptop on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):
- 6:12 AM Changeset in webkit [141586] by
-
- 2 edits in trunk/Source/WTF
Build fix for WinCE after r137709
https://bugs.webkit.org/show_bug.cgi?id=105767
Do not pass functions as const references to
templated arguments to make the compiler happy.
- wtf/StdLibExtras.h:
(WTF::binarySearch):
(WTF::tryBinarySearch):
(WTF::approximateBinarySearch):
- 6:11 AM Changeset in webkit [141585] by
-
- 2 edits in trunk/Tools
[GTK][WK2] MiniBrowser fullscreen signals support
https://bugs.webkit.org/show_bug.cgi?id=108005
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-01
Reviewed by Carlos Garcia Campos.
Shows a label for 2 seconds using overlay (if GTK >= 3.2.0) and hides
the toolbar when entering fullscreen. When leaving fullscreen the
label is hidden (if it's not hidden yet) and the toolbar is shown again.
- MiniBrowser/gtk/BrowserWindow.c:
(_BrowserWindow):
(fullScreenMessageTimeoutCallback):
(webViewEnterFullScreen):
(webViewLeaveFullScreen):
(browserWindowFinalize):
(browserWindowConstructed):
- 5:42 AM Changeset in webkit [141584] by
-
- 4 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip some failing tests on EFL bots after r141459 and r141310.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/fast/js/global-constructors-expected.txt: Revert change from r141573.
- 5:08 AM Changeset in webkit [141583] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] EwkContext should be based on C WK2 API
https://bugs.webkit.org/show_bug.cgi?id=107666
Reviewed by Andreas Kling.
EwkContext should be based on C WK2 API so that API layering is not violated.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
(EwkContext::create):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):
(EwkContext::setAdditionalPluginPath):
(EwkContext::clearResourceCache):
- UIProcess/API/efl/ewk_context_private.h:
(EwkContext):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):
- 5:00 AM Changeset in webkit [141582] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix hanging deleteQWebViewTwice test
Reviewed by Allan Sandfeld Jensen.
Don't use QCoreApplication::instance()->exec(), because in case of a bug
that never finishes. Instead use waitForSignal() which has the concept of
a timeout.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::deleteQWebViewTwice):
- 4:56 AM Changeset in webkit [141581] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API inside ewk_auth_request
https://bugs.webkit.org/show_bug.cgi?id=107806
Reviewed by Andreas Kling.
Use C API inside ewk_auth_request instead of accessing C++ internal
classes directly, to avoid violating layering.
- UIProcess/API/efl/ewk_auth_request.cpp:
(EwkAuthRequest::EwkAuthRequest):
(EwkAuthRequest::suggestedUsername):
(EwkAuthRequest::realm):
(EwkAuthRequest::host):
(EwkAuthRequest::continueWithoutCredential):
(EwkAuthRequest::authenticate):
(EwkAuthRequest::isRetrying):
(ewk_auth_request_authenticate):
- UIProcess/API/efl/ewk_auth_request_private.h:
(EwkAuthRequest::create):
(EwkAuthRequest):
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didReceiveAuthenticationChallengeInFrame):
- 4:54 AM Changeset in webkit [141580] by
-
- 2 edits in trunk/Source/WebKit2
[Gtk][WK2] Fix build after recent WebKit2 changes
https://bugs.webkit.org/show_bug.cgi?id=108588
Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-01
Reviewed by Andreas Kling.
Don't remove WorkQueue during execution.
Following the logic on https://bugs.webkit.org/show_bug.cgi?id=108544
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::EventSource::~EventSource):
(WorkQueue::EventSource::executeEventSource):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
(WorkQueue::dispatchOnTermination):
- 4:23 AM Changeset in webkit [141579] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Follow up to r141260: fixing renamed style.
Not reviewed.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._onClick):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
- 4:16 AM Changeset in webkit [141578] by
-
- 32 edits in trunk
Enable unprefixed CSS transitions by default.
https://bugs.webkit.org/show_bug.cgi?id=108216
Reviewed by Dean Jackson.
.:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations. Remove the
various #ifdefs and conditional generations.
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- GNUmakefile.features.am.in:
- css/CSSPropertyNames.in:
- dom/EventNames.in:
- dom/TransitionEvent.cpp:
- dom/TransitionEvent.h:
- dom/TransitionEvent.idl:
- page/DOMWindow.idl:
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):
Source/WebKit/chromium:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.
- features.gypi:
Source/WebKit/mac:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.
- Configurations/FeatureDefines.xcconfig:
Tools:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
LayoutTests:
Unskip the tests by default as now unprefixed CSS Transitions are
enabled by default.
- fast/events/event-creation-expected.txt:
- fast/events/event-creation.html: Add the test that was commented out
before.
- platform/chromium/TestExpectations:
- 3:49 AM Changeset in webkit [141577] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r141548.
http://trac.webkit.org/changeset/141548
https://bugs.webkit.org/show_bug.cgi?id=108579
userscript-plugin-document.html is flaky
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
- bindings/v8/V8GCController.cpp:
(WebCore):
(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
- bindings/v8/V8GCController.h:
(V8GCController):
- 3:39 AM Changeset in webkit [141576] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipped some failing tests.
- platform/qt/TestExpectations:
- 3:27 AM Changeset in webkit [141575] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Skip hanging WebGL software fallback tests
Reviewed by Allan Sandfeld Jensen.
See also https://bugs.webkit.org/show_bug.cgi?id=105820.
- tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
(tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
- 3:26 AM Changeset in webkit [141574] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: fix jscompiler warnings
https://bugs.webkit.org/show_bug.cgi?id=108604
Reviewed by Pavel Feldman.
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleGroup.prototype.addMessage):
- inspector/front-end/ContextMenu.js:
(WebInspector.ContextSubMenuItem):
- inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._copyImageURL):
(WebInspector.ImageView.prototype._openInNewTab):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._clearBrowserCache):
(WebInspector.NetworkLogView.prototype._clearBrowserCookies):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.IDBDatabaseTreeElement.prototype._refreshIndexedDB):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRenameSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet):
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.prototype._isDockedToBottom):
- 3:22 AM Changeset in webkit [141573] by
-
- 2 edits1 delete in trunk/LayoutTests
Unreviewed EFL gardening.
Update platform expectations for failing tests after the
WEB_INTENTS flag turned off for EFL port in r141439
- platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
- platform/efl/fast/js/global-constructors-expected.txt:
- 3:00 AM Changeset in webkit [141572] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Renamed inspector/editor/text-editor-ctrl-movements.html to
inspector/editor/text-editor-word-jumps.html after r141399.
- platform/efl/TestExpectations:
- 2:51 AM Changeset in webkit [141571] by
-
- 4 edits in trunk/Source
Coordinated Graphics : Sort Target.pri and class declarations in alphabetical order.
https://bugs.webkit.org/show_bug.cgi?id=108590
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-02-01
Reviewed by Noam Rosenthal.
Source/WebCore:
Sort CoordinatedGraphics files in Target.pri in alphabetical order.
No new tests. No change in behavior.
- Target.pri:
Source/WebKit2:
Sort class declarations in alphabetical order.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
(WebCore):
- 2:42 AM Changeset in webkit [141570] by
-
- 173 edits in trunk/Source/WebCore
Web Inspector: Native Memory Instrumentation: provide edge names to class members in all WebCore instrumented classes.
https://bugs.webkit.org/show_bug.cgi?id=107369
Reviewed by Yury Semikhatsky.
It is almost mechanical change generated by a script.
Late I'll implement name to edge name consistency check in clang plugin.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::reportMemoryUsage):
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::reportMemoryUsage):
- bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
- bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::reportMemoryUsage):
- bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
- bindings/v8/V8ValueCache.cpp:
(WebCore::StringCache::reportMemoryUsage):
- css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):
- css/CSSCalculationValue.cpp:
- css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
- css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::reportMemoryUsage):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):
- css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):
- css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::reportMemoryUsage):
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
- css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):
- css/CSSGroupingRule.cpp:
(WebCore::CSSGroupingRule::reportMemoryUsage):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::reportDescendantMemoryUsage):
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::reportMemoryUsage):
- css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::reportMemoryUsage):
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::reportMemoryUsage):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::reportMemoryUsage):
- css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::reportDescendantMemoryUsage):
- css/CSSRule.cpp:
(WebCore::CSSRule::reportMemoryUsage):
- css/CSSRuleList.cpp:
(WebCore::StaticCSSRuleList::reportMemoryUsage):
- css/CSSRuleList.h:
- css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::reportMemoryUsage):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::reportMemoryUsage):
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
- css/CSSValue.cpp:
(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
- css/CSSValueList.cpp:
(WebCore::CSSValueList::reportDescendantMemoryUsage):
- css/CSSVariableValue.h:
(WebCore::CSSVariableValue::reportDescendantMemoryUsage):
- css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::reportDescendantMemoryUsage):
- css/FontValue.cpp:
(WebCore::FontValue::reportDescendantMemoryUsage):
- css/MediaList.cpp:
(WebCore::MediaQuerySet::reportMemoryUsage):
(WebCore::MediaList::reportMemoryUsage):
- css/MediaQuery.cpp:
(WebCore::MediaQuery::reportMemoryUsage):
- css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::reportMemoryUsage):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):
- css/RuleFeature.cpp:
(WebCore::RuleFeatureSet::reportMemoryUsage):
- css/RuleSet.cpp:
(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):
- css/ShadowValue.cpp:
(WebCore::ShadowValue::reportDescendantMemoryUsage):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::reportMemoryUsage):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::MatchedProperties::reportMemoryUsage):
(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::MediaQueryResult::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):
- css/StyleRule.cpp:
(WebCore::StyleRule::reportDescendantMemoryUsage):
(WebCore::StyleRulePage::reportDescendantMemoryUsage):
(WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
(WebCore::StyleRuleGroup::reportDescendantMemoryUsage):
(WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
(WebCore::StyleRuleRegion::reportDescendantMemoryUsage):
(WebCore::StyleRuleViewport::reportDescendantMemoryUsage):
- css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::reportDescendantMemoryUsage):
- css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::reportMemoryUsage):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reportMemoryUsage):
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportMemoryUsage):
- css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
- css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
- css/WebKitCSSViewportRule.cpp:
(WebCore::WebKitCSSViewportRule::reportMemoryUsage):
- dom/Attribute.h:
(WebCore::Attribute::reportMemoryUsage):
- dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::reportMemoryUsage):
- dom/ContainerNode.h:
(ContainerNode):
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::reportMemoryUsage):
- dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::reportMemoryUsage):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):
- dom/Element.cpp:
(WebCore::Element::reportMemoryUsage):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::reportMemoryUsage):
- dom/ElementRareData.cpp:
(WebCore::ElementRareData::reportMemoryUsage):
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::reportMemoryUsage):
- dom/Event.cpp:
(WebCore::Event::reportMemoryUsage):
- dom/LiveNodeList.cpp:
(WebCore::LiveNodeListBase::reportMemoryUsage):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- dom/NodeRareData.cpp:
(WebCore::NodeListsNodeData::reportMemoryUsage):
(WebCore::NodeRareData::reportMemoryUsage):
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::reportMemoryUsage):
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::reportMemoryUsage):
- dom/SecurityContext.cpp:
(WebCore::SecurityContext::reportMemoryUsage):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::reportMemoryUsage):
- dom/TreeScope.cpp:
(WebCore::TreeScope::reportMemoryUsage):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reportMemoryUsage):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::reportMemoryUsage):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::reportMemoryUsage):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::reportMemoryUsage):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::reportMemoryUsage):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::reportMemoryUsage):
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::reportMemoryUsage):
- inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
- inspector/InspectorBaseAgent.cpp:
(WebCore::InspectorBaseAgentInterface::reportMemoryUsage):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::reportMemoryUsage):
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):
- inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::reportMemoryUsage):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::reportMemoryUsage):
(WebCore::ScriptDebugListener::Script::reportMemoryUsage):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::reportMemoryUsage):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::reportMemoryUsage):
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::reportMemoryUsage):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::reportMemoryUsage):
- inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):
(WebCore::MemoryInstrumentationImpl::reportMemoryUsage):
- inspector/NetworkResourcesData.cpp:
(WebCore::XHRReplayData::reportMemoryUsage):
(WebCore::NetworkResourcesData::ResourceData::reportMemoryUsage):
(WebCore::NetworkResourcesData::reportMemoryUsage):
- loader/CachedMetadata.cpp:
(WebCore::CachedMetadata::reportMemoryUsage):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::reportMemoryUsage):
- loader/Prerenderer.cpp:
(WebCore::Prerenderer::reportMemoryUsage):
- loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::reportMemoryUsage):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::reportMemoryUsage):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::reportMemoryUsage):
- loader/SubstituteData.cpp:
(WebCore::SubstituteData::reportMemoryUsage):
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::reportMemoryUsage):
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::reportMemoryUsage):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::reportMemoryUsage):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
- loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::reportMemoryUsage):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::reportMemoryUsage):
- loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::reportMemoryUsage):
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::reportMemoryUsage):
- loader/cache/CachedShader.cpp:
(WebCore::CachedShader::reportMemoryUsage):
- loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::reportMemoryUsage):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::reportMemoryUsage):
- page/DOMTimer.cpp:
(WebCore::DOMTimer::reportMemoryUsage):
- page/Frame.cpp:
(WebCore::Frame::reportMemoryUsage):
- page/Page.cpp:
(WebCore::Page::reportMemoryUsage):
- platform/KURL.cpp:
(WebCore::KURL::reportMemoryUsage):
- platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::reportMemoryUsage):
- platform/KURLWTFURLImpl.h:
(WebCore::KURLWTFURLImpl::reportMemoryUsage):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::reportMemoryUsage):
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
- platform/audio/AudioArray.h:
(WebCore::AudioArray::reportMemoryUsage):
- platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::reportMemoryUsage):
- platform/audio/HRTFDatabase.cpp:
(WebCore::HRTFDatabase::reportMemoryUsage):
- platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::reportMemoryUsage):
- platform/audio/HRTFElevation.cpp:
(WebCore::HRTFElevation::reportMemoryUsage):
- platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::reportMemoryUsage):
- platform/audio/ffmpeg/FFTFrameFFMPEG.cpp:
(reportMemoryUsage):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::reportMemoryUsage):
(WebCore::FrameData::reportMemoryUsage):
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::reportMemoryUsage):
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::reportMemoryUsage):
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::reportMemoryUsage):
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::reportMemoryUsage):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::reportMemoryUsage):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBufferData::reportMemoryUsage):
- platform/graphics/skia/MemoryInstrumentationSkia.cpp:
(reportMemoryUsage):
- platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::reportMemoryUsage):
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::reportMemoryUsage):
(WebCore):
(WebCore::ImageDecoder::reportMemoryUsage):
- platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::reportMemoryUsage):
- platform/network/FormData.cpp:
(WebCore::FormData::reportMemoryUsage):
(WebCore::FormDataElement::reportMemoryUsage):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsageBase):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::reportMemoryUsage):
- platform/network/chromium/ResourceRequest.cpp:
(WebCore::ResourceRequest::reportMemoryUsage):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::reportMemoryUsage):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::reportMemoryUsage):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::reportMemoryUsage):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::reportMemoryUsage):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::reportMemoryUsage):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::reportMemoryUsage):
(WebCore::RenderFrameSet::GridAxis::reportMemoryUsage):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::reportMemoryUsage):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::reportMemoryUsage):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::reportMemoryUsage):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reportMemoryUsage):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::reportMemoryUsage):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::reportMemoryUsage):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::reportMemoryUsage):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::reportMemoryUsage):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::reportMemoryUsage):
(WebCore::RenderTableSection::RowStruct::reportMemoryUsage):
(WebCore::RenderTableSection::CellStruct::reportMemoryUsage):
- rendering/RenderText.cpp:
(WebCore::RenderText::reportMemoryUsage):
- rendering/RenderView.cpp:
(WebCore::RenderView::reportMemoryUsage):
- rendering/style/DataRef.h:
(WebCore::DataRef::reportMemoryUsage):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::reportMemoryUsage):
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::reportMemoryUsage):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
- svg/SVGPaint.cpp:
(WebCore::SVGPaint::reportDescendantMemoryUsage):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::reportMemoryUsage):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::reportMemoryUsage):
- 2:40 AM Changeset in webkit [141569] by
-
- 1 edit in trunk/Source/WebKit/qt/ChangeLog
[Qt] visibility of embedded widget
https://bugs.webkit.org/show_bug.cgi?id=108327
Rubber-stamped by Simon Hausmann.
In overriding Widget::hide in QtPluginWidget, we forgot to call the
parent implementation, which as it turns, out does sensible stuff.
- WebCoreSupport/FrameLoaderClientQt.cpp:
- 2:37 AM Changeset in webkit [141568] by
-
- 4 edits2 adds32 deletes in trunk/LayoutTests
[CSS Regions] Convert fast/regions/region-overflow-auto-overflow* to reftests
https://bugs.webkit.org/show_bug.cgi?id=108333
Reviewed by Tony Chang.
Add reftests, cleanup existing tests.
- fast/regions/region-overflow-auto-overflow-hidden-expected.html: Added.
- fast/regions/region-overflow-auto-overflow-hidden.html:
- fast/regions/region-overflow-auto-overflow-visible-expected.html: Added.
- fast/regions/region-overflow-auto-overflow-visible.html:
- platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
- platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
- platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/chromium-mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/chromium-mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/chromium/TestExpectations:
- platform/chromium/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/chromium/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
- platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
- platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
- platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
- platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
- platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
- platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- 2:35 AM Changeset in webkit [141567] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] visibility of embedded widget
https://bugs.webkit.org/show_bug.cgi?id=108327
Rubber-stamped by Simon Hausmann.
In overriding Widget::show in QtPluginWidget, we forgot to call the
parent implementation, which as it turns, out does sensible stuff.
- WebCoreSupport/FrameLoaderClientQt.cpp:
- 2:25 AM Changeset in webkit [141566] by
-
- 12 edits2 moves in trunk/Source
[GTK][GStreamer] FullscreenVideoControllerGtk implementation
https://bugs.webkit.org/show_bug.cgi?id=107398
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
NATIVE_FULLSCREEN_VIDEO support for the GTK port. The previous
FullscreenVideoController implementation was refactored as a
sub-class of FullscreenVideoControllerGStreamer and hooked in the
MediaPlayerPrivateGStreamer backend.
- GNUmakefile.list.am:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gtk/FullscreenVideoControllerGtk.cpp: Renamed from Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp.
- platform/graphics/gtk/FullscreenVideoControllerGtk.h: Renamed from Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.h.
Source/WebKit/gtk:
Remove the FullscreenVideoController as it moved to
FullscreenVideoControllerGStreamer and its Gtk subclass in
WebCore. Hook in NATIVE_FULLSCREEN_VIDEO in the ChromeClient in
the two possible scenarios, wether FULLSCREEN_API is enabled or not.
- GNUmakefile.am: Remove FullscreenVideoController.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit):
(WebKit::ChromeClient::enterFullscreenForNode): Hook
NATIVE_FULLSCREEN_VIDEO support.
(WebKit::ChromeClient::exitFullscreenForNode): Ditto
(WebKit::ChromeClient::enterFullScreenForElement): Ditto
(WebKit::ChromeClient::exitFullScreenForElement): Ditto
- WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):
- WebCoreSupport/FullscreenVideoController.cpp: Removed.
- WebCoreSupport/FullscreenVideoController.h: Removed.
- webkit/webkitwebview.cpp: Remove FullscreenVideoController support.
- webkit/webkitwebviewprivate.h: Ditto
- 2:11 AM Changeset in webkit [141565] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: fix cursor location in Source Frame
https://bugs.webkit.org/show_bug.cgi?id=108592
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-01
Reviewed by Pavel Feldman.
Normalize range before computing amount of lines in
_updateSourcePosition.
No new tests.
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._updateSourcePosition): Normalize text range.
- inspector/front-end/inspector.css: Slightly bigger left padding for the text.
(.source-frame-position):
- 2:09 AM Changeset in webkit [141564] by
-
- 15 edits in trunk/Source/WebCore
Unreviewed build fix after r141553.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::HasInstance):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::HasInstance):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::HasInstance):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::HasInstance):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::HasInstance):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::HasInstance):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::HasInstance):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::HasInstance):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::HasInstance):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::HasInstance):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::HasInstance):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::HasInstance):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
- 2:07 AM Changeset in webkit [141563] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Sources panel navigator reveal and expand fixes.
https://bugs.webkit.org/show_bug.cgi?id=108584
Reviewed by Pavel Feldman.
Navigator folders are not expanded by default anymore.
Made domain folder expanded for inspected page main frame domain.
UISourceCodes are now added to navigator before editor container
so that they could be revealed if editor container decides to show them.
- inspector/front-end/NavigatorView.js:
(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
- 2:06 AM Changeset in webkit [141562] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] MiniBrowser segfaults on loading google.com
https://bugs.webkit.org/show_bug.cgi?id=108597
Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-02-01
Reviewed by Andreas Kling.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::processMessage):
oolMessageBody should be properly initialized before it is used.
This patch also adds omitted break statement.
- 1:52 AM Changeset in webkit [141561] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend
https://bugs.webkit.org/show_bug.cgi?id=108591
Reviewed by Pavel Feldman.
Send a dropTraceLog command to the backend when deleting a profile header from the sidebar.
Before we were sending the command only upon deleting an existing view of a profile, so we would not
sent the command if the view was not created or if a profile header was removed via context menu (the ondelete() method).
Drive-by: fixed an odd formatting of property functions.
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileHeader.prototype.reset):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader.prototype.reset):
(WebInspector.ProfileHeader.prototype.load):
(WebInspector.ProfileHeader.prototype.canSaveToFile):
(WebInspector.ProfileHeader.prototype.saveToFile):
(WebInspector.ProfileHeader.prototype.loadFromFile):
(WebInspector.ProfileHeader.prototype.fromFile):
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
- 1:32 AM Changeset in webkit [141560] by
-
- 5 edits2 adds in trunk
AX: when aria-activedescendant is used with a ComboBox role, focus should not be changed
https://bugs.webkit.org/show_bug.cgi?id=108596
Reviewed by Ryosuke Niwa.
Source/WebCore:
Normally, an aria-activedescendant change causes a focus change to be triggered.
However, when used in conjunction with a combo box, this causes problems for screen readers.
Namely, the user expects focus to remain in the text field so that the user can keep typing.
If focus moves to an item in the combobox list, it is not possible to keep typing.
The solution is to not trigger a focus change in this case and instead use a selected children change notification.
Test: platform/mac/accessibility/combobox-activedescendant-notifications.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::shouldNotifyActiveDescendant):
(WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
- platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt: Added.
- platform/mac/accessibility/combobox-activedescendant-notifications.html: Added.
- 1:17 AM Changeset in webkit [141559] by
-
- 4 edits in trunk
Source/WebCore: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion=
https://bugs.webkit.org/show_bug.cgi?id=108291
Reviewed by Ryosuke Niwa.
This accounts for differences in what AppKit gives for accessibility role descriptions between platforms
when the subrole is not recognized, and standardizes it for WebKit.
Unskip a failing Lion test
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper roleDescription]):
LayoutTests: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=108291
Reviewed by Ryosuke Niwa.
- platform/mac/TestExpectations:
- 1:06 AM Changeset in webkit [141558] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Replace localeCompare in NavigatorView with compareTo.
https://bugs.webkit.org/show_bug.cgi?id=108585
Reviewed by Pavel Feldman.
Replaced String.prototype.localeCompare with String.prototype.compareTo
in NavigatorView to improve performance.
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorTreeOutline._treeElementsCompare):
- 12:57 AM Changeset in webkit [141557] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: File system pending requests list is not cleared after processing.
https://bugs.webkit.org/show_bug.cgi?id=108573
Reviewed by Pavel Feldman.
- inspector/front-end/IsolatedFileSystemModel.js:
(WebInspector.IsolatedFileSystemModel.prototype._processPendingFileSystemRequests):
- 12:52 AM Changeset in webkit [141556] by
-
- 5 edits in trunk/Source/WebCore
Dubious cast from HTMLCollection to HTMLAllCollection
https://bugs.webkit.org/show_bug.cgi?id=108538
Reviewed by Adam Barth.
Patch is tested by enabling V8 binding integrity on HTMLAllCollection and
running the existing tests without introducing new crashes.
- dom/Document.cpp:
(WebCore::Document::all):
Pass correct type to template.
- html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::HTMLAllCollection):
- html/HTMLAllCollection.h:
(HTMLAllCollection):
Make create() method arguments compatible with template above.
- html/HTMLAllCollection.idl:
Enable binding integrity.
- 12:50 AM Changeset in webkit [141555] by
-
- 16 edits2 adds in trunk
Web Inspector: Add support for handling modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=107883
Patch by Ken Kania <kkania@chromium.org> on 2013-02-01
Reviewed by Pavel Feldman.
Introduce support for being notified when a JavaScript modal dialog
is opening and closing, as well as a new command for accepting or
dismissing the dialog.
Source/WebCore:
Test: inspector-protocol/page/willRunJavaScriptDialog.html
- inspector/Inspector.json:
- inspector/InspectorClient.h:
(WebCore::InspectorClient::handleJavaScriptDialog):
(InspectorClient):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialogImpl):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialogImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialog):
(WebCore):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialog):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::willRunJavaScriptDialog):
(WebCore):
(WebCore::InspectorPageAgent::didRunJavaScriptDialog):
(WebCore::InspectorPageAgent::handleJavaScriptDialog):
- inspector/InspectorPageAgent.h:
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.PageDispatcher.prototype.frameStartedLoading):
(WebInspector.PageDispatcher.prototype.frameStoppedLoading):
(WebInspector.PageDispatcher.prototype.frameScheduledNavigation):
(WebInspector.PageDispatcher.prototype.frameClearedScheduledNavigation):
(WebInspector.PageDispatcher.prototype.javascriptDialogOpening):
(WebInspector.PageDispatcher.prototype.javascriptDialogClosed):
- page/Chrome.cpp:
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
Source/WebKit/chromium:
- public/WebDevToolsAgent.h:
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::handleJavaScriptDialog):
(WebKit):
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebDevToolsAgentImpl.cpp:
(BrowserDataHintStringValues):
(WebKit::WebDevToolsAgentImpl::captureScreenshot):
(WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
(WebKit):
(WebKit::browserHintToString):
(WebKit::browserHintFromString):
(WebKit::WebDevToolsAgent::patchWithBrowserData):
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
LayoutTests:
- inspector-protocol/page/javascriptDialogEvents-expected.txt: Added.
- inspector-protocol/page/javascriptDialogEvents.html: Added.
- 12:48 AM Changeset in webkit [141554] by
-
- 4 edits1 add in trunk/Source
Touch disambiguation blacklist is not being queried properly
https://bugs.webkit.org/show_bug.cgi?id=108222
Patch by Dan Alcantara <dfalcantara@chromium.org> on 2013-02-01
Reviewed by Adam Barth.
TEST=WebFrameTest::DisambiguationPopupBlacklist
Source/WebCore:
Fix the blacklist so that we check it for the right nodes.
Add a chromium test to check that the blacklist is being built and used
correctly. Also update the other DisambiguationPopup tests to
use the new page scale method.
- page/TouchDisambiguation.cpp:
(WebCore::findGoodTouchTargets):
Source/WebKit/chromium:
Fix the blacklist so that we check it for the right nodes.
Add a test to check that the blacklist is being built and used
correctly. Also update the other DisambiguationPopup tests to
use the new page scale method.
- tests/WebFrameTest.cpp:
- tests/data/disambiguation_popup_blacklist.html: Added.
- 12:45 AM Changeset in webkit [141553] by
-
- 28 edits in trunk/Source/WebCore
[V8] Add a temporary optional Isolate parameter to HasInstance()
https://bugs.webkit.org/show_bug.cgi?id=108567
Reviewed by Adam Barth.
The optional Isolate parameter will be removed once all call sites have an Isolate.
It will require several patches.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::HasInstance):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::HasInstance):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::HasInstance):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::HasInstance):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::HasInstance):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::HasInstance):
- bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::HasInstance):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::HasInstance):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::HasInstance):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::HasInstance):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
(WebCore::V8TestObj::HasInstance):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructorCallback):
(WebCore::V8TestOverloadedConstructors::HasInstance):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
- 12:44 AM Changeset in webkit [141552] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, marking table-section-overflow-clip-crash.html failed.
- platform/chromium/TestExpectations:
- 12:44 AM Changeset in webkit [141551] by
-
- 6 edits in trunk/Source/WebCore
[CPP,GObject,ObjC] Add 'static' skip to CodeGenerator{CPP,GObject,ObjC}.pm
https://bugs.webkit.org/show_bug.cgi?id=108578
Patch by Nils Barth <nbarth@google.com> on 2013-02-01
Reviewed by Kentaro Hara.
Since CPP/GObject/ObjC code generators (CodeGenerator{CPP,GObject,ObjC}.pm)
do not support static attributes, add test to skip these.
This lets us remove #if macro from static in test files and not need
these in future.
Test: bindings/scripts/test/TestObj.idl (run-bindings-test)
Test: bindings/scripts/test/TestSupplemental.idl (run-bindings-test)
- bindings/scripts/CodeGeneratorCPP.pm:
(SkipAttribute):
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute):
- bindings/scripts/CodeGeneratorObjC.pm:
(SkipAttribute):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/TestSupplemental.idl:
- 12:37 AM Changeset in webkit [141550] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] only show checkboxes for FPS meter and continuous painting when compositing mode is forced
https://bugs.webkit.org/show_bug.cgi?id=108236
Patch by Eberhard Graether <egraether@google.com> on 2013-02-01
Reviewed by Pavel Feldman.
This change hides the checkboxes for FPS meter and continuous painting if compositing mode is not forced.
This way the checkboxes only show up for users that can make use of these features.
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canShowFPSCounter):
(WebKit::InspectorClientImpl::canContinuouslyPaint):
- 12:30 AM Changeset in webkit [141549] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebaselining a result.
- platform/chromium/fast/js/kde/inbuilt_function_tostring-expected.txt:
- 12:27 AM Changeset in webkit [141548] by
-
- 4 edits in trunk/Source/WebCore
[V8] Remove V8GCController::m_edenNodes
https://bugs.webkit.org/show_bug.cgi?id=108579
Reviewed by Adam Barth.
Currently V8GCController::m_edenNodes stores a list of nodes whose
wrappers have been created since the latest GC. The reason why we
needed m_edenNodes is that there was no way to know a list of wrappers
in the new space of V8. By using m_edenNodes, we had been approximating
'wrappers in the new space' by 'wrappers that have been created since
the latest GC'.
Now V8 provides VisitHandlesForPartialDependence(), with which WebKit
can know a list of wrappers in the new space. By using the API, we can
remove V8GCController::m_edenNodes. The benefit is that (1) we no longer
need to keep m_edenNodes and that (2) it enables more precise minor
DOM GC (Remember that m_edenNodes was just an approximation).
Performance benchmark: https://bugs.webkit.org/attachment.cgi?id=185940
The benchmark runs 300 iterations, each of which creates 100000 elements.
The benchmark measures average, min, median, max and stdev of execution times
of the 300 iterations. This will tell us the worst-case overhead of this change.
Before:
mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms
After:
mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms
As shown above, I couldn't observe any performance regression.
No tests. No change in behavior.
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
- bindings/v8/V8GCController.cpp:
(WebCore::gcTree):
(WebCore):
(MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::notifyFinished):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
- bindings/v8/V8GCController.h:
(V8GCController):
- 12:19 AM Changeset in webkit [141547] by
-
- 8 edits in trunk
Web Inspector: Use String.prototype.startsWith instead of String.prototype.indexOf when possible
https://bugs.webkit.org/show_bug.cgi?id=108575
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/FileMapping.js:
(WebInspector.FileMapping.prototype._entryMatchesURL):
(WebInspector.FileMapping.prototype.urlForURI):
- inspector/front-end/FileSystemMapping.js:
(get WebInspector.FileSystemMappingImpl.prototype.fileForURI):
(get WebInspector.FileSystemMappingImpl.prototype.uriForPath):
LayoutTests:
- http/tests/inspector/console-cd-completions.html:
- http/tests/inspector/console-cd.html:
- http/tests/inspector/indexeddb/indexeddb-test.js:
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer.consoleMessageOverride):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer):
- inspector/network-status-non-http.html:
- 12:02 AM Changeset in webkit [141546] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Add MessageFlags.h in Target.pri
https://bugs.webkit.org/show_bug.cgi?id=108583
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-01-31
Reviewed by Kentaro Hara.
Since MessageDecoder and MessageEncoder include MessageFlags.h, it
should be included in Target.pri.
- Target.pri:
