Timeline
Feb 3, 2013:
- 11:44 PM Changeset in webkit [141745] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] Mark fast/dom/DOMImplementation/createDocument-with-used-doctype.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=108793
Unreviewed EFL gardening.
Mark fast/dom/DOMImplementation/createDocument-with-used-doctype.html as
flaky due to Bug 108058. It sometimes crashes on the bots.
Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03
- platform/efl-wk2/TestExpectations:
- 11:16 PM Changeset in webkit [141744] by
-
- 8 edits in trunk/Source
Upstream ENABLE_PDFKIT_PLUGIN settting
<http://webkit.org/b/108792>
Reviewed by Tim Horton.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN
on iOS since PDFKit is a Mac-only framework.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN
on iOS since PDFKit is a Mac-only framework.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN
on iOS since PDFKit is a Mac-only framework.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN
on iOS since PDFKit is a Mac-only framework.
- 11:14 PM Changeset in webkit [141743] by
-
- 2 edits in trunk/Source/WebKit2
Silently block one more directory needed for NSApplication initialization.
Reviewed by Sam Weinig.
- WebProcess/com.apple.WebProcess.sb.in:
- 11:02 PM Changeset in webkit [141742] by
-
- 4 edits in trunk/Source/WebCore
Split per-resolve logic out from StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=96421
Reviewed by Eric Seidel.
Implemented class StyleResolver::State and added m_state to
StyleResolver. All member variables used for per-resolve logic are
moved into the state class.
No new tests, because just refactoring.
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::initForStyleResolve):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::cacheBorderAndBackground):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::useSVGZoomRules):
(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackMinMax):
(WebCore::createGridTrackGroup):
(WebCore::createGridTrackList):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
(WebCore::StyleResolver::reportMemoryUsage):
- css/StyleResolver.h:
(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::setWritingMode):
(WebCore::StyleResolver::setTextOrientation):
(WebCore::StyleResolver::hasParentNode):
(WebCore::StyleResolver::addMatchedRule):
(StyleResolver):
(State):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
Added "m_state." to access member variables used for per-resolve logic.
- 10:58 PM Changeset in webkit [141741] by
-
- 4 edits in trunk
Support setLangAttributeAwareFormControlUIEnabled on Chromium Windows XP
https://bugs.webkit.org/show_bug.cgi?id=108791
Reviewed by Kentaro Hara.
Source/WebCore:
We didn't support setLangAttributeAwareFormControlUIEnabled(true) on
Chromium Windows XP because of lack of LocaleNameToLCID API. This change
add manual mapping from locale names to LCIDs for Windows XP.
No new tests. This doesn't make any behavior changes in products, and
this improves some test results.
- platform/text/win/LocaleWin.cpp:
(WebCore): Define NameToLCIDMap.
(WebCore::removeLastComponent):
Remove the last component separated with '-'.
(WebCore::ensureNameToLCIDMap):
Add locale names used in layout tests.
(WebCore::convertLocaleNameToLCID):
Find an appropriate LCID longest matching with the specified locale name.
(WebCore::LCIDFromLocale):
Use convertLocaleNameToLCID if LocaleNameToLCID is not available.
LayoutTests:
- platform/chromium/TestExpectations:
Mark affected tests failure.
Actually we should be able to remove XP-specific test results for
them. We just mark them in this patch just in case, and do rebaseline
later.
- 10:17 PM Changeset in webkit [141740] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, marking some as timing out.
- platform/chromium/TestExpectations:
- 10:16 PM Changeset in webkit [141739] by
-
- 3 edits in trunk/Tools
PatchLogs are not getting created on QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=108593
Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-03
Reviewed by Eric Seidel.
Added missing "added" patch event to submit-to-ews handler.
- QueueStatusServer/app.yaml:
- QueueStatusServer/handlers/submittoews.py:
(SubmitToEWS._add_attachment_to_ews_queues):
- 10:11 PM Changeset in webkit [141738] by
-
- 24 edits in trunk/Source/WebCore
Add FocusDirection argument to HTMLTextFormControlElement::handleFocusEvent
https://bugs.webkit.org/show_bug.cgi?id=108775
Reviewed by Hajime Morita.
We'd like to add a FocusDirection argument to
HTMLTextFormControlElement::handleFocusEvent in order to fix Bug
- This is a preparation for it.
We need to add FocusDirection arguments to some focus-related functions
to pass it correctly when TAB or Shift+TAB is pressed.
No new tests. This doesn't make any behavior changes.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
To pass the FocusDirection argument to handleFocusEvent, we need to add
it to dispatchFocusEvent too.
- html/HTMLTextFormControlElement.h:
(HTMLTextFormControlElement):
Add FocusDirection arugment to dispatchFocusEvent.
(WebCore::HTMLTextFormControlElement::handleFocusEvent):
Add FocusDirection argument.
- dom/Node.cpp:
(WebCore::Node::dispatchFocusEvent): Add FocusDirection argument.
- dom/Node.h:
(Node): Ditto.
- dom/Document.cpp:
(WebCore::Document::setFocusedNode): Add FocusDirection argument in
order to pass it to Node::dispatchFocusEvent.
- dom/Document.h:
(Document): Ditto.
- page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedNode):
Adjust Node::dispatchFocusEvent argument.
(WebCore::FocusController::advanceFocusInDocumentOrder):
Pass FocusDirectio to Element::focus.
(WebCore::FocusController::setFocusedNode):
Add FocusDirection argument in order to pass it to Document::setFocusedNode.
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
Pass FocusDirectio to Element::focus.
- page/FocusController.h:
(FocusController): Add FocusDirection argument to setFocusedNode.
- dom/Element.cpp:
(WebCore::Element::focus):
Add FocusDirection argument to pass it to FocusController::setFocusedNode.
- dom/Element.h:
(Element): Ditto.
- WebCore.exp.in:
Update FocusController::setFocusedNode and Document::setFocusedNode.
- html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::focus): Adjust FocusDirection argument.
- html/HTMLLabelElement.h:
(HTMLLabelElement): Ditto.
- html/HTMLLegendElement.cpp:
(WebCore::HTMLLegendElement::focus): Ditto.
- html/HTMLLegendElement.h:
(HTMLLegendElement): Ditto.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::dispatchFocusEvent): Ditto.
- html/HTMLSelectElement.h:
(HTMLSelectElement): Ditto.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultFocus):
Add FocusDirection argument in order to pass it from
HTMLInputElement::focus() to HTMLTextFormControlElement::focus().
(WebCore::HTMLInputElement::focus):
Pass the FocusDirection argument to InputType::focus. See above.
(WebCore::HTMLInputElement::handleFocusEvent):
Adjust FocusDirection argument.
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
(WebCore::InputType::focus): Add FocusDirection argument.
- html/InputType.h:
(InputType): Ditto.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::focus):
Add FocusDirection argument to follow InputType.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Ditto.
- 10:02 PM Changeset in webkit [141737] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, marking terminate-during-sync-operation.html as timing out.
- platform/chromium/TestExpectations:
- 9:59 PM Changeset in webkit [141736] by
-
- 16 edits in trunk/Source/WebKit
Fix build warning after r141473
https://bugs.webkit.org/show_bug.cgi?id=108782
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-03
Reviewed by Kentaro Hara.
Fix -Wunused-parameter build warning.
Source/WebKit/blackberry:
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::getClientPasteboardDataForRange):
Source/WebKit/chromium:
- src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::getClientPasteboardDataForRange):
Source/WebKit/efl:
- WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::getClientPasteboardDataForRange):
Source/WebKit/gtk:
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::getClientPasteboardDataForRange):
Source/WebKit/qt:
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::getClientPasteboardDataForRange):
Source/WebKit/win:
- WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::getClientPasteboardDataForRange):
Source/WebKit/wince:
- WebCoreSupport/EditorClientWinCE.cpp:
(WebKit::EditorClientWinCE::getClientPasteboardDataForRange):
Source/WebKit/wx:
- WebKitSupport/EditorClientWx.cpp:
(WebCore::EditorClientWx::getClientPasteboardDataForRange):
- 9:11 PM Changeset in webkit [141735] by
-
- 8 edits1 add in trunk/Source/WebCore
Adds usage instrumentation for indexedDB
Includes new header file in project files
https://bugs.webkit.org/show_bug.cgi?id=107772
Patch by Kassy Coan <kassycoan@chromium.org> on 2013-02-03
Reviewed by Tony Chang.
Currently untestable. Has zero effect apart from histogramming.
- GNUmakefile.list.am:
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
- Modules/indexeddb/IDBHistograms.h: Added.
(WebCore):
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- 8:54 PM Changeset in webkit [141734] by
-
- 3 edits in trunk/Tools
Unreviewed. Add dstockwell as a contributor in comitters.py and to the watchlist for animation
https://bugs.webkit.org/show_bug.cgi?id=108777
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-02-03
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/watchlist:
- 8:53 PM Changeset in webkit [141733] by
-
- 8 edits2 adds in trunk/Source/WebCore
Split default style-sheet statics out from StyleResolver into its own class
https://bugs.webkit.org/show_bug.cgi?id=107780
Reviewed by Dimitri Glazkov.
Factored static variables and logic about default style sheets out from StyleResolver into its own class
CSSDefaultStyleSheets. This is a following patch after r141373.
No new tests, refactoring only.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/CSSDefaultStyleSheets.cpp: Added.
(WebCore):
(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::screenEval):
(WebCore::printEval):
(WebCore::parseUASheet):
(WebCore::CSSDefaultStyleSheets::initDefaultStyle):
(WebCore::CSSDefaultStyleSheets::loadFullDefaultStyle):
(WebCore::CSSDefaultStyleSheets::loadSimpleDefaultStyle):
(WebCore::CSSDefaultStyleSheets::viewSourceStyle):
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
- css/CSSDefaultStyleSheets.h: Added.
(WebCore):
(CSSDefaultStyleSheets):
- css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::reportMemoryUsage):
- 8:27 PM FeatureFlags edited by
- Rename CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to … (diff)
- 8:25 PM Changeset in webkit [141732] by
-
- 2 edits in trunk/Source/WebKit2
Fix build warning after r141648
https://bugs.webkit.org/show_bug.cgi?id=108784
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-03
Reviewed by Kentaro Hara.
Fix -Wunused-parameter build warning.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):
- 8:04 PM Changeset in webkit [141731] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Do not call m_widgetClient->show() for WebHelperPlugin.
https://bugs.webkit.org/show_bug.cgi?id=108740
Patch by David Dorwin <ddorwin@chromium.org> on 2013-02-03
Reviewed by Kent Tamura.
The calls to m_widgetClient->show() and setFocus() do not appear to be
necessary, and the former causes problems on at least on platform.
- src/WebHelperPluginImpl.cpp:
(WebKit::WebHelperPluginImpl::initialize): Removed calls to m_widgetClient->show() and setFocus().
(WebKit::WebHelperPluginImpl::setFocus): Should never be called.
- 7:22 PM Changeset in webkit [141730] by
-
- 5 edits in trunk/Source/WebCore
[V8] Simplify CodeGeneratorV8.pm by using InheritsExtendedAttribute("EventTarget")
https://bugs.webkit.org/show_bug.cgi?id=108441
Reviewed by Adam Barth.
A complicated condition in GetInternalFields() can be simplified
by using InheritsExtendedAttribute("EventTarget").
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
- dom/EventTarget.idl: Added [EventTarget] which should have been added.
- svg/SVGElementInstance.idl: Ditto.
- 7:09 PM Changeset in webkit [141729] by
-
- 2 edits in trunk/Tools
Fix failing test.
- TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
(TestWebKitAPI::didFinishLoadForFrame):
- 6:55 PM Changeset in webkit [141728] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Unreviewed rebaselining.
- platform/chromium-mac-lion/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
- 6:16 PM Changeset in webkit [141727] by
-
- 2 edits in trunk/Source/WebCore
[Soup] Do not use local variables for the client
https://bugs.webkit.org/show_bug.cgi?id=108714
Reviewed by Martin Robinson.
Covered by existing tests, refactoring code only.
We have had problems in the past with the client being destroyed or
changed inside a method or function, and we ended up with a stale
pointer, leading to crashes. This refactoring is an effort to minimize
the possibility of hitting that same issue in the future.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::redirectSkipCallback): no longer use a local variable to hold
the client.
(WebCore::wroteBodyDataCallback): ditto.
(WebCore::nextMultipartResponsePartCallback): ditto.
(WebCore::sendRequestCallback): ditto.
(WebCore::closeCallback): ditto.
(WebCore::readCallback): ditto.
- 6:15 PM Changeset in webkit [141726] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, marking grid-preferred-logical-widths.html as a fail.
- platform/chromium/TestExpectations:
- 5:54 PM Changeset in webkit [141725] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, marking block-test.html as a fail.
- platform/chromium/TestExpectations:
- 5:37 PM Changeset in webkit [141724] by
-
- 2 edits in trunk/LayoutTests
[chromium] Skip editing/inserting/smart-link-when-caret-is-moved-before-URL.html
https://bugs.webkit.org/show_bug.cgi?id=85463
Test added in http://trac.webkit.org/changeset/141618 - requires that DRT or WKTR
implement setAutomaticLinkDetectionEnabled().
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 5:03 PM Changeset in webkit [141723] by
-
- 3 edits in trunk/Tools
Make ChangeLogEntry detect annotations by prepare-ChangeLog (Added/Removed/Copied from/Renamed from) as clean.
https://bugs.webkit.org/show_bug.cgi?id=108433
Patch by Timothy Loh <timloh@chromium.com> on 2013-02-03
Reviewed by Eric Seidel.
PrepareChangeLog is supposed to update the file/function list if we
haven't touched it, but the existing regex doesn't handle the
annotations prepare-ChangeLog adds (e.g. "Added.")
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry.is_touched_files_text_clean):
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_is_touched_files_text_clean):
- 4:47 PM Changeset in webkit [141722] by
-
- 3 edits in trunk/LayoutTests
calendar-picker-key-operations.html is failing
https://bugs.webkit.org/show_bug.cgi?id=108566
Reviewed by Kentaro Hara.
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
Month.createFromDate supports only UTC Date. Use the Month constructor
with local year and local month.
- 4:43 PM Changeset in webkit [141721] by
-
- 18 edits in trunk/Source/WebCore
[V8] Pass an Isolate to HasInstance() (part 1)
https://bugs.webkit.org/show_bug.cgi?id=108617
Reviewed by Adam Barth.
This is one of efforts to pass an Isolate to GetTemplate().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(JSValueToNative):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooCallback):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
- bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::visitNodeWrappers):
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):
- bindings/v8/V8Binding.cpp:
(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):
- bindings/v8/V8GCController.cpp:
(WebCore::WrapperVisitor::WrapperVisitor):
(WrapperVisitor):
(WebCore::V8GCController::majorGCPrologue):
- bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
- bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
- 4:01 PM Changeset in webkit [141720] by
-
- 4 edits in trunk/Source
[GTK] Make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=108756
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2013-02-03
Reviewed by Kentaro Hara.
Source/WebCore:
- GNUmakefile.list.am: Remove header files which no longer exist;
correct one which got added incorrectly.
Source/WebKit2:
- GNUmakefile.list.am: Remove header files which no longer exist
- 3:53 PM Changeset in webkit [141719] by
-
- 5 edits in trunk/Source/WebCore
[V8] Pass an Isolate to HasInstance() (part 3)
https://bugs.webkit.org/show_bug.cgi?id=108622
Reviewed by Adam Barth.
This is one of efforts to pass an Isolate to GetTemplate().
No tests. No change in behavior.
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
(WebCore::V8InjectedScriptHost::typeCallback):
(WebCore::V8InjectedScriptHost::getEventListenersCallback):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendCallback):
- 3:26 PM Changeset in webkit [141718] by
-
- 13 edits in trunk/Source/WebCore
[V8] Pass an Isolate to HasInstance() (part 2)
https://bugs.webkit.org/show_bug.cgi?id=108620
Reviewed by Adam Barth.
This is one of efforts to pass an Isolate to GetTemplate().
No tests. No change in behavior.
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):
- bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallbackCustom):
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toCanvasStyle):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorSetter):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::setDragImageCallback):
- bindings/v8/custom/V8CryptoCustom.cpp:
(WebCore::V8Crypto::getRandomValuesCallback):
- bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallbackCustom):
(WebCore::V8DOMFormData::appendCallback):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallbackCustom):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
- bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
(WebCore::V8HTMLMediaElement::controllerAccessorSetter):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addCallback):
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::removeElement):
- 10:35 AM Changeset in webkit [141717] by
-
- 2 edits in trunk/Source/WebCore
Cleanup: 'ExceptionCode& ec', not 'ExceptionCode &ec'.
https://bugs.webkit.org/show_bug.cgi?id=108769
Reviewed by Eric Seidel.
Does what it says on the tin: reference parameters should read
'type& name', and this patch fixes the two occurances of 'type &name'
that cropped up for ExceptionCode.
Pure style change; no effect on behavior.
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
- 5:37 AM Changeset in webkit [141716] by
-
- 8 edits in trunk/Source
Vector should consult allocator about ideal size when choosing capacity.
<http://webkit.org/b/108410>
<rdar://problem/13124002>
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
Remove assertion about Vector capacity that won't hold anymore since capacity()
may not be what you passed to reserveCapacity().
Also export WTF::fastMallocGoodSize() for Windows builds.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
Source/WTF:
Added WTF::fastMallocGoodSize(), a workalike/wrapper for OS X's malloc_good_size().
It returns the actual size of the block that will get allocated for a given byte size.
Vector's internal buffer now checks with the allocator if the resulting allocation
could actually house more objects and updates its capacity to make use of the space.
- wtf/Deque.h:
(WTF::::expandCapacity):
- wtf/FastMalloc.cpp:
(WTF::fastMallocGoodSize):
- wtf/FastMalloc.h:
- wtf/Vector.h:
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):
- 4:17 AM Changeset in webkit [141715] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark inspector/debugger/source-frame-count.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=108768
Unreviewed EFL gardening.
Mark inspector/debugger/source-frame-count.html as flaky as it sometimes
crashes due to Bug 81574.
Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03
- platform/efl-wk2/TestExpectations:
- 2:48 AM Changeset in webkit [141714] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark a few more media tests as flaky due to gstreamer 1.0
https://bugs.webkit.org/show_bug.cgi?id=108765
Unreviewed EFL gardening.
Mark 2 more media tests as flaky since the update to gstreamer 1.0.
They sometimes crash in MediaPlayerPrivateGStreamer dtor.
Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03
- platform/efl/TestExpectations:
- 2:42 AM Changeset in webkit [141713] by
-
- 1 edit2 adds in trunk/LayoutTests
[EFL] svg/custom/text-ctm.svg needs a baseline
https://bugs.webkit.org/show_bug.cgi?id=108764
Unreviewed EFL gardening.
Add baseline for svg/custom/text-ctm.svg that was added in r17879.
Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03
- platform/efl/svg/custom/text-ctm-expected.png: Added.
- platform/efl/svg/custom/text-ctm-expected.txt: Added.
Feb 2, 2013:
- 10:12 PM Changeset in webkit [141712] by
-
- 4 edits in trunk/Source
[chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.
This patch just alters the WebKitAPI in advance of coding to the new API in chromium and webkit
sources, defining two new virtual methods (unimplemented and uncalled). The existing API remains
in place and in use.
https://bugs.webkit.org/show_bug.cgi?id=108736
Reviewed by Darin Fisher.
Source/Platform:
- chromium/public/WebFileSystem.h:
(WebFileSystem):
(WebKit::WebFileSystem::createSnapshotFileAndReadMetadata):
Source/WebKit/chromium:
- public/WebFileSystemCallbacks.h:
(WebFileSystemCallbacks):
(WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):
- 5:14 PM Changeset in webkit [141711] by
-
- 24 edits in trunk/Source/WebKit2
Remove more LegacyReceivers
https://bugs.webkit.org/show_bug.cgi?id=108758
Reviewed by Anders Carlsson.
- UIProcess/Downloads/DownloadProxy.cpp:
- UIProcess/Downloads/DownloadProxy.messages.in:
- UIProcess/WebApplicationCacheManagerProxy.cpp:
- UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
- UIProcess/WebApplicationCacheManagerProxy.messages.in:
- UIProcess/WebCookieManagerProxy.cpp:
- UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
- UIProcess/WebCookieManagerProxy.messages.in:
- UIProcess/WebDatabaseManagerProxy.cpp:
- UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
- UIProcess/WebDatabaseManagerProxy.messages.in:
- UIProcess/mac/RemoteLayerTreeHost.h:
(RemoteLayerTreeHost):
- UIProcess/mac/RemoteLayerTreeHost.messages.in:
- UIProcess/mac/RemoteLayerTreeHost.mm:
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
(WebApplicationCacheManager):
- WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in:
- WebProcess/Cookies/WebCookieManager.cpp:
- WebProcess/Cookies/WebCookieManager.h:
(WebCookieManager):
- WebProcess/Cookies/WebCookieManager.messages.in:
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebDatabaseManager):
- WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
- 5:11 PM Changeset in webkit [141710] by
-
- 10 edits in trunk/Source/WebKit2
Convert CustomProtocolManagerProxy, CustomProtocolManager and AuthenticationManager to be non-LegacyReceivers
https://bugs.webkit.org/show_bug.cgi?id=108757
Reviewed by Anders Carlsson.
- Shared/Authentication/AuthenticationManager.cpp:
- Shared/Authentication/AuthenticationManager.h:
(AuthenticationManager):
- Shared/Authentication/AuthenticationManager.messages.in:
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
- Shared/Network/CustomProtocols/CustomProtocolManager.messages.in:
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
(CustomProtocolManagerProxy):
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in:
- UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:
- 4:14 PM Changeset in webkit [141709] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API inside ewk_file_chooser_request
https://bugs.webkit.org/show_bug.cgi?id=107811
Reviewed by Sam Weinig.
Use C API inside ewk_file_chooser_request instead of
accessing the internal C++ classes directly, to
avoid violating API layering.
- UIProcess/API/efl/ewk_file_chooser_request.cpp:
(EwkFileChooserRequest::EwkFileChooserRequest):
(EwkFileChooserRequest::~EwkFileChooserRequest):
(EwkFileChooserRequest::allowMultipleFiles):
(EwkFileChooserRequest::acceptedMIMETypes):
(EwkFileChooserRequest::cancel):
(EwkFileChooserRequest::chooseFiles):
(ewk_file_chooser_request_accepted_mimetypes_get):
(ewk_file_chooser_request_files_choose):
(ewk_file_chooser_request_file_choose):
- UIProcess/API/efl/ewk_file_chooser_request_private.h:
(EwkFileChooserRequest::create):
(EwkFileChooserRequest):
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::runOpenPanel):
- 3:50 PM Changeset in webkit [141708] by
-
- 10 edits in trunk/Source/WebKit2
Stop keeping a frame tree in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=81728
Reviewed by Oliver Hunt.
This patch removes the parent/child relationships of WebFrameProxys
in the UIProcess
- UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyChildFrames):
(WKFrameGetParentFrame):
- UIProcess/API/C/WKFrame.h:
Null out the implementations of WKFrameCopyChildFrames and WKFrameGetParentFrame,
but keep them around as their symbols are still needed for nightlies.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::disconnect):
- UIProcess/WebFrameProxy.h:
Remove parent/child connections.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCreateSubframe):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didSaveToPageCache):
(WebKit::WebFrameLoaderClient::didRestoreFromPageCache):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createSubframe):
Remove/Update messages that only served to update the parent/child connection.
- 3:01 PM Changeset in webkit [141707] by
-
- 2 edits in trunk/Tools
Add Antoine Quint to the list of committers
https://bugs.webkit.org/show_bug.cgi?id=108750
No review necessary.
- Scripts/webkitpy/common/config/committers.py:
- 2:32 PM Changeset in webkit [141706] by
-
- 2 edits in trunk/Source/WebCore
Optimize some operations for float type in texture format conversions of WebGL
https://bugs.webkit.org/show_bug.cgi?id=107526
Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-02-02
Reviewed by Darin Adler.
Some small changes are made to optimize the operations for float type in the texture format conversion of WebGL to improve performance.
Already covered by current tests.
- platform/graphics/GraphicsContext3D.cpp:
(WebCore):
- 2:26 PM Changeset in webkit [141705] by
-
- 5 edits in trunk/Source/WebKit2
Make it possible to modify the connection from ChildProcessProxy subclasses.
Reviewed by Anders Carlsson.
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::ChildProcessProxy):
(WebKit::ChildProcessProxy::didFinishLaunching):
(WebKit::ChildProcessProxy::clearConnection):
(WebKit::ChildProcessProxy::connectionWillOpen):
(WebKit::ChildProcessProxy::connectionWillClose):
- Shared/ChildProcessProxy.h:
(ChildProcessProxy):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::connectionWillClose):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- 1:04 PM Changeset in webkit [141704] by
-
- 16 edits in trunk/Source/WebCore
Clean up the storage of dirty bits on nodes in the scrolling state tree
https://bugs.webkit.org/show_bug.cgi?id=108744
Reviewed by Sam Weinig.
ScrollingStateNode and its subclasses used different techniques for
tracking which properties changed. ScrollingStateNode tracked its layers
via a bool member and some layer-specific methods, but also had virtual
methods to allow subclasses to track properties via a bit mask.
Clean this up by having the base class store the bit mask, and use
enums to specify bits for the various properties. All properties are thus
tracked in the same way. Bits are read and written through non-virtual member
functions on ScrollingStateNode. All bit checking is done via hasChangedProperty().
- page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode): m_changedProperties is now on the base class.
(WebCore::ScrollingStateFixedNode::updateConstraints): Use setPropertyChanged()
- page/scrolling/ScrollingStateFixedNode.h: Remove overrides that are no longer needed.
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode): Initialize m_changedProperties,
m_scrollLayerDidChange no longer tracked separately.
(WebCore::ScrollingStateNode::cloneAndReset):
- page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::hasChangedProperties):
(WebCore::ScrollingStateNode::hasChangedProperty): Tests the bit.
(WebCore::ScrollingStateNode::resetChangedProperties): Set all bits to 0.
(WebCore::ScrollingStateNode::setPropertyChanged): Set the bit.
(WebCore::ScrollingStateNode::changedProperties): Private to discourage incorrect usage
(changeProperties() & foo).
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): Base class does the copying now.
(WebCore::ScrollingStateScrollingNode::setViewportRect): Use setPropertyChanged().
(WebCore::ScrollingStateScrollingNode::setContentsSize): Ditto.
(WebCore::ScrollingStateScrollingNode::setFrameScaleFactor): Etc.
(WebCore::ScrollingStateScrollingNode::setNonFastScrollableRegion):
(WebCore::ScrollingStateScrollingNode::setWheelEventHandlerCount):
(WebCore::ScrollingStateScrollingNode::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollElasticity):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollElasticity):
(WebCore::ScrollingStateScrollingNode::setHasEnabledHorizontalScrollbar):
(WebCore::ScrollingStateScrollingNode::setHasEnabledVerticalScrollbar):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollbarMode):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollbarMode):
(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):
(WebCore::ScrollingStateScrollingNode::setScrollOrigin):
- page/scrolling/ScrollingStateScrollingNode.h:
(ScrollingStateScrollingNode):
- page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::ScrollingStateStickyNode):
(WebCore::ScrollingStateStickyNode::updateConstraints):
- page/scrolling/ScrollingStateStickyNode.h:
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::update):
- page/scrolling/mac/ScrollingStateNodeMac.mm:
(WebCore::ScrollingStateNode::setScrollLayer):
- page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
(WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer):
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::update):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::update):
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::update):
- 1:03 PM Changeset in webkit [141703] by
-
- 12 edits in trunk/Source/WebCore
Fixed and sticky nodes have no nodeID set
https://bugs.webkit.org/show_bug.cgi?id=108734
Reviewed by Sam Weinig.
Push ScrollingNodeIDs onto scrolling nodes at construction time, and thereafter
treat them as readonly. Previously, only the root scrolling node would have a node ID.
Node IDs aren't actually used by the scrolling tree yet, but are useful for debugging.
Not testable since we only dump the scrolling state tree, not the scrolling
node tree in tests.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree): No longer create the root node here;
we can only create it when we know what its ID will be.
(WebCore::ScrollingTree::updateTreeFromStateNode): Create the root node if
necessary. Pass node IDs into create methods.
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::ScrollingTreeNode):
- page/scrolling/ScrollingTreeNode.h:
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
- page/scrolling/ScrollingTreeScrollingNode.h:
- page/scrolling/mac/ScrollingTreeFixedNode.h:
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::create):
(WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNode::create):
(WebCore::ScrollingTreeScrollingNodeMac::ScrollingTreeScrollingNodeMac):
- page/scrolling/mac/ScrollingTreeStickyNode.h:
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::create):
(WebCore::ScrollingTreeStickyNode::ScrollingTreeStickyNode):
- 12:59 PM Changeset in webkit [141702] by
-
- 5 edits2 deletes in trunk
[CMake] Adopt the WinCE port to new CMake
https://bugs.webkit.org/show_bug.cgi?id=108754
Reviewed by Laszlo Gombos.
.:
Remove the entry point hack which isn't required in the new
CMake version with offical WindowsCE support.
- Source/cmake/OptionsWindows.cmake:
Source/JavaScriptCore:
- os-win32/WinMain.cpp: Removed.
- shell/PlatformWinCE.cmake: Removed.
Tools:
- WinCELauncher/CMakeLists.txt: Mark WinCELauncher
as WIN32 target to use the correct entry point.
- 12:55 PM Changeset in webkit [141701] by
-
- 3 edits2 adds in trunk
Making -webkit-image-set() the first value of background property causes crash.
https://bugs.webkit.org/show_bug.cgi?id=108409
Reviewed by Beth Dakin.
Source/WebCore:
CSSParser::addFillValue should use lval->isBaseValueList() instead
of lval->isValueList(). If lval is -webkit-image-set, rval is appended
to -webkit-image-set.
Test: fast/css/image-set-value-crash-in-fillImageSet.html
- css/CSSParser.cpp:
(WebCore::CSSParser::addFillValue):
If lval is not a value list, lval is initialized by using
CSSValueList::createCommaSeparated(). So we have to check whether
lval is created by CSSValueList::createCommaSeparated() or not.
LayoutTests:
- fast/css/image-set-value-crash-in-fillImageSet-expected.txt: Added.
- fast/css/image-set-value-crash-in-fillImageSet.html: Added.
- 12:25 PM Changeset in webkit [141700] by
-
- 5 edits in trunk/Source
<http://webkit.org/b/108745> WTF shouldn't use a script build phase to detect the presence of headers when the compiler can do it for us
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- DerivedSources.make: Remove an obsolete Makefile rule. This should have been removed when the use
of the generated file moved to WTF.
Source/WTF:
- WTF.xcodeproj/project.pbxproj: Remove the script phase that used to generate a header file
containing information about whether certain header files exist on the system.
- wtf/FastMalloc.cpp: Use Clang's has_include to detect whether the header exists before including it.
- 11:02 AM Changeset in webkit [141699] by
-
- 8 edits in trunk/Source
Upstream iOS FeatureDefines
<http://webkit.org/b/108753>
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.
- 9:31 AM Changeset in webkit [141698] by
-
- 2 edits in trunk/Tools
One is not allowed to use commit-queue to make oneself a committer.
- Scripts/webkitpy/common/config/committers.py: Rolled out r141693. Also, changed e-mail order for Yongjun Zhang, so that Bugzilla autocomplete works.
- 8:41 AM Changeset in webkit [141697] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Media tests fix after r141695.
Rubber-stamped by Martin Robinson.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setPlaybinURL): Remove
both fragment and query string for file:// uris before loading.
- 8:12 AM Changeset in webkit [141696] by
-
- 2 edits in trunk/Source/WebCore
Build fix for WinCE after r141637.
- platform/graphics/wince/ImageBufferWinCE.cpp:
- 8:00 AM Changeset in webkit [141695] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] webkitwebsrc is exposed to application-side
https://bugs.webkit.org/show_bug.cgi?id=108088
Reviewed by Martin Robinson.
Switch the webkitwebsrc to handle webkit+http(s) uris so it is now
explicit that this element is meant to be used preferrably inside
WebKit. This change is internal to the player.
No new tests, covered by existing http/tests/media tests.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setPlaybinURL):
(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::load):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcGetProtocols):
(webKitWebSrcSetUri):
- 7:27 AM Changeset in webkit [141694] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed trivial prospective build fix for A17n disabled
configurations.
The dummy computed object attriute cache control functions need to be defined
as being member functions of AXObjectCache, because that's where they are
declared.
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):
- 6:09 AM Changeset in webkit [141693] by
-
- 2 edits in trunk/Tools
Add Antoine Quint to the list of committers
https://bugs.webkit.org/show_bug.cgi?id=108750
Reviewed by Dean Jackson.
- Scripts/webkitpy/common/config/committers.py:
- 5:55 AM Changeset in webkit [141692] by
-
- 3 edits in trunk/Source/WebCore
Creating a WebInspector.ContextMenu without an event crashes WebCore when calling .show()
https://bugs.webkit.org/show_bug.cgi?id=108636
Reviewed by Pavel Feldman.
Return early if InspectorFrontendHost::showContextMenu() is called without an event and
assert in ContextMenuController::createContextMenu() in case no event was provided.
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::showContextMenu):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::createContextMenu):
- 5:05 AM Changeset in webkit [141691] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Improper initialization of ANGLEResources
https://bugs.webkit.org/show_bug.cgi?id=101489
Patch by Jonathan Feldstein <jfeldstein@rim.com> on 2013-02-02
Reviewed by Antonio Gomes.
MaxDrawBuffers, OES_standard_derivatives, OES_EGL_image_external and ARB_texture_rectangle have already been initialized through ShBuiltInResources function and these fields do not need to be set again in GraphicsContext3dBlackBerry.cpp. In addition, the extension flags cannot be set to true without getExtension having been called (Khronos WebGL specs, section 5.14.14.). Thus these lines need to be removed.
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 4:54 AM Changeset in webkit [141690] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Refactor InspectorDOMStorageAgent::getDOMStorageEntries to report the error messages
https://bugs.webkit.org/show_bug.cgi?id=108611
Reviewed by Pavel Feldman.
Added reporting of various error messages. Moved the modification of output
parameter at a later stage when there are no errors reported.
No new tests as code refactoring.
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::hadException):
(WebCore):
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
- 3:58 AM Changeset in webkit [141689] by
-
- 5 edits in trunk
Web Inspector: fix bug in highlighting single chars via highlightRange API of DTE
https://bugs.webkit.org/show_bug.cgi?id=108685
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-02
Reviewed by Pavel Feldman.
Source/WebCore:
Use Math.min instead of Math.max in rangesForLine method.
Updated test: text-editor-highlight-api.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.RangeHighlightDescriptor.prototype.rangesForLine):
LayoutTests:
Updated layout test to cover specific bug case.
- inspector/editor/text-editor-highlight-api-expected.txt:
- inspector/editor/text-editor-highlight-api.html:
- 1:43 AM Changeset in webkit [141688] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations:
- platform/gtk/svg/custom/text-ctm-expected.txt:
- platform/gtk/svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
- 1:01 AM Changeset in webkit [141687] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Unreviewed buildfix after r141648.
- DerivedSources.pri:
- 12:25 AM Changeset in webkit [141686] by
-
- 5 edits in trunk/Source/WebCore
Continue making XSSAuditor thread safe: Remove unsafe AtomicString compares
https://bugs.webkit.org/show_bug.cgi?id=108557
Reviewed by Adam Barth.
Unfortunately HTMLNames comparisons will always be false on a non-main thread
with our current design, so we have to use some "threadSafeMatch" helpers written
for the HTMLBackgroundParser.
Also factor out threadSafeMatch() methods to HTMLParserIdioms.
No new tests because no new functionality.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore):
- html/parser/HTMLParserIdioms.cpp:
(WebCore::threadSafeEqual):
(WebCore):
(WebCore::threadSafeMatch):
- html/parser/HTMLParserIdioms.h:
(WebCore):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::eraseAttributeIfInjected):
- 12:04 AM Changeset in webkit [141685] by
-
- 2 edits in trunk/Source/WebKit2
Follow-up to r141682. Adding build targets for the files that should be generated from the new message.in file.
Unreviewed.
- GNUmakefile.list.am:
