Timeline

Feb 4, 2013:

11:39 PM Changeset in webkit [141862] by haraken@chromium.org

• 31 edits in trunk/Source/WebCore

[V8] Pass an Isolate to V8DOMConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=108900

Reviewed by Adam Barth.

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateToV8Converters):

• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::createWrapper):

• bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::V8Float64Array::installPerContextProperties):

• bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::createWrapper):

• bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::V8TestActiveDOMObject::installPerContextProperties):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::createWrapper):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::V8TestCustomNamedGetter::installPerContextProperties):

• bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::createWrapper):

• bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::V8TestEventConstructor::installPerContextProperties):

• bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::createWrapper):

• bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::V8TestEventTarget::installPerContextProperties):

• bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::createWrapper):

• bindings/scripts/test/V8/V8TestException.h:

(WebCore::V8TestException::installPerContextProperties):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::createWrapper):

• bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::installPerContextProperties):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::createWrapper):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::installPerContextProperties):

• bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::createWrapper):

• bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::V8TestNamedConstructor::installPerContextProperties):

• bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::createWrapper):

• bindings/scripts/test/V8/V8TestNode.h:

(WebCore::V8TestNode::installPerContextProperties):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
(WebCore::V8TestObj::createWrapper):

• bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::createWrapper):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(WebCore::V8TestOverloadedConstructors::installPerContextProperties):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::createWrapper):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::installPerContextProperties):

• bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureAttributes):
(WebCore::V8DOMConfiguration::batchConfigureConstants):
(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):

• bindings/v8/V8DOMConfiguration.h:

(V8DOMConfiguration):
(WebCore::V8DOMConfiguration::configureAttribute):

• bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

11:28 PM Changeset in webkit [141861] by morrita@google.com

• 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, skipping heap-snapshot-with-detached-dom-tree.html

• platform/chromium/TestExpectations:

10:53 PM Changeset in webkit [141860] by haraken@chromium.org

• 2 edits in trunk/Source/WebCore

[V8] Clean up CodeGeneratorV8.pm by introducing HasCustom{Getter,Setter,Method}
​https://bugs.webkit.org/show_bug.cgi?id=108896

Reviewed by Adam Barth.

No tests. No change in generated code.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(HasCustomGetter):
(HasCustomSetter):
(HasCustomMethod):
(GetFunctionTemplateCallbackName):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(RequiresCustomSignature):

10:35 PM Changeset in webkit [141859] by morrita@google.com

• 1 edit
  6 adds in trunk/LayoutTests

[Chromium] Unreviewed rebaselining.

• platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt: Added.
• platform/chromium-linux/compositing/overflow/updating-scrolling-content-expected.txt: Added.
• platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt: Added.
• platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt: Added.
• platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/scrolling-without-painting-expected.txt: Added.
• platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/updating-scrolling-content-expected.txt: Added.

10:20 PM Changeset in webkit [141858] by tkent@chromium.org

• 3 edits
  2 adds in trunk

Fix crash by <select> type change on focus
​https://bugs.webkit.org/show_bug.cgi?id=108830

Reviewed by Abhishek Arya.

Source/WebCore:

Test: fast/forms/select/select-change-type-on-focus.html

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
focus() calls may change the renderer type.

LayoutTests:

• fast/forms/select/select-change-type-on-focus-expected.txt: Added.
• fast/forms/select/select-change-type-on-focus.html: Added.

10:08 PM Changeset in webkit [141857] by haraken@chromium.org

• 6 edits in trunk/Source/WebCore

[V8] Pass an Isolate to opaqueRootForGC()
​https://bugs.webkit.org/show_bug.cgi?id=108886

Reviewed by Adam Barth.

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateOpaqueRootForGC):
(GenerateHeader):

• bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::opaqueRootForGC):

• bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WebCore::WrapperTypeInfo::opaqueRootForGC):

• bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

9:56 PM Changeset in webkit [141856] by haraken@chromium.org

• 7 edits in trunk/LayoutTests

Add missing tests for default values of event constructors
​https://bugs.webkit.org/show_bug.cgi?id=108885

Reviewed by Adam Barth.

Spec: ​https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-keyboardevent

• fast/events/constructors/keyboard-event-constructor-expected.txt:
• fast/events/constructors/keyboard-event-constructor.html:
• fast/events/constructors/mouse-event-constructor-expected.txt:
• fast/events/constructors/mouse-event-constructor.html:
• fast/events/constructors/wheel-event-constructor-expected.txt:
• fast/events/constructors/wheel-event-constructor.html:

9:22 PM Changeset in webkit [141855] by Gregg Tavares

• 1 edit
  65 adds in trunk/LayoutTests

Add Support Files for WebGL Conformance Tests
​https://bugs.webkit.org/show_bug.cgi?id=108731

Reviewed by Kenneth Russell.

These are the 'resource' files for the WebGL
Conformance Tests. Other CLs will add the
actual tests.

• webgl/resources/webgl_test_files/conformance/resources/3x3.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/blue-1x1.jpg: Added.
• webgl/resources/webgl_test_files/conformance/resources/boolUniformShader.vert: Added.
• webgl/resources/webgl_test_files/conformance/resources/bug-32888-texture.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/floatUniformShader.vert: Added.
• webgl/resources/webgl_test_files/conformance/resources/fragmentShader.frag: Added.
• webgl/resources/webgl_test_files/conformance/resources/glsl-conformance-test.js: Added.

(GLSLConformanceTester):

• webgl/resources/webgl_test_files/conformance/resources/glsl-feature-tests.css: Added.

(canvas):
(.shader-source):
(.shader-source li:nth-child(odd)):
(.shader-source li:nth-child(even)):
(.testimages):
(.testimages br):
(.testimages > div):
(IMG):

• webgl/resources/webgl_test_files/conformance/resources/glsl-generator.js: Added.

(GLSLGenerator.):
(GLSLGenerator):

• webgl/resources/webgl_test_files/conformance/resources/gray-ramp-256-with-128-alpha.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/gray-ramp-256.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/gray-ramp-default-gamma.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma0.1.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma1.0.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma2.0.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma4.0.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma9.0.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/gray-ramp.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/green-2x2-16bit.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/intArrayUniformShader.vert: Added.
• webgl/resources/webgl_test_files/conformance/resources/intUniformShader.vert: Added.
• webgl/resources/webgl_test_files/conformance/resources/matUniformShader.vert: Added.
• webgl/resources/webgl_test_files/conformance/resources/noopUniformShader.frag: Added.
• webgl/resources/webgl_test_files/conformance/resources/noopUniformShader.vert: Added.
• webgl/resources/webgl_test_files/conformance/resources/npot-video.mp4: Added.
• webgl/resources/webgl_test_files/conformance/resources/npot-video.theora.ogv: Added.
• webgl/resources/webgl_test_files/conformance/resources/npot-video.webmvp8.webm: Added.
• webgl/resources/webgl_test_files/conformance/resources/ogles-tests.css: Added.

(canvas):
(.shader-source):
(.shader-source li:nth-child(odd)):
(.shader-source li:nth-child(even)):
(.testimages):
(.testimages br):
(.testimages > div):
(IMG):

• webgl/resources/webgl_test_files/conformance/resources/pnglib.js: Added.

(.):

• webgl/resources/webgl_test_files/conformance/resources/red-green.mp4: Added.
• webgl/resources/webgl_test_files/conformance/resources/red-green.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/red-green.theora.ogv: Added.
• webgl/resources/webgl_test_files/conformance/resources/red-green.webmvp8.webm: Added.
• webgl/resources/webgl_test_files/conformance/resources/red-indexed.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/samplerUniformShader.frag: Added.
• webgl/resources/webgl_test_files/conformance/resources/small-square-with-cie-rgb-profile.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/small-square-with-colormatch-profile.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/small-square-with-colorspin-profile.jpg: Added.
• webgl/resources/webgl_test_files/conformance/resources/small-square-with-colorspin-profile.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/small-square-with-e-srgb-profile.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/small-square-with-smpte-c-profile.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/small-square-with-srgb-iec61966-2.1-profile.png: Added.
• webgl/resources/webgl_test_files/conformance/resources/structUniformShader.vert: Added.
• webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-canvas.js: Added.

(.init):
(.setCanvasToRedGreen):
(.drawTextInCanvas):
(.setCanvasTo257x257):
(.setCanvasTo1x2):
(.else):
(.runOneIteration):
(.runTest.runNextTest):
(.runTest):
(generateTest):

• webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-image-data.js: Added.

(.init):
(.runOneIteration):
(.runTest):
(generateTest):

• webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-image.js: Added.

(.init):
(.runOneIteration):
(.runTestOnImage):
(.runTest.newImage.onload):
(.runTest):
(.runTest2.newImage.onload):
(.runTest2):
(.runTest3):
(generateTest):

• webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-video.js: Added.

(debug):
(.init):
(.runOneIteration):
(.runTest):

• webgl/resources/webgl_test_files/conformance/resources/vertexShader.vert: Added.
• webgl/resources/webgl_test_files/conformance/resources/webgl-test-utils.js: Added.

(WebGLTestUtils):
(WebGLTestUtils.):

• webgl/resources/webgl_test_files/conformance/resources/webgl-test.js: Added.

(webglTestLog):
(getGLErrorAsString):
(shouldGenerateGLError):
(glErrorShouldBe):

• webgl/resources/webgl_test_files/conformance/resources/zero-alpha.png: Added.
• webgl/resources/webgl_test_files/resources/desktop-gl-constants.js: Added.
• webgl/resources/webgl_test_files/resources/js-test-post.js: Added.
• webgl/resources/webgl_test_files/resources/js-test-pre.js: Added.

(.):
(reportTestResultsToHarness):
(notifyFinishedToHarness):
(description):
(debug):
(escapeHTML):
(testPassed):
(testFailed):
(areArraysEqual):
(isMinusZero):
(isResultCorrect):
(stringify):
(evalAndLog):
(shouldBe):
(shouldNotBe):
(shouldBeTrue):
(shouldBeFalse):
(shouldBeNaN):
(shouldBeNull):
(shouldBeEqualToString):
(shouldEvaluateTo):
(shouldBeNonZero):
(shouldBeNonNull):
(shouldBeUndefined):
(shouldBeDefined):
(shouldBeGreaterThanOrEqual):
(expectTrue):
(shouldThrow):
(assertMsg):
(gc.gcRec):
(gc):
(finishTest.epilogue.onload):
(finishTest):

• webgl/resources/webgl_test_files/resources/js-test-style.css: Added.

(.pass):
(.fail):
(#console):

• webgl/resources/webgl_test_files/resources/test-eval.js: Added.

(TestEval):

• webgl/resources/webgl_test_files/resources/webgl-logo.png: Added.
• webgl/resources/webgl_test_files/resources/webgl-test-harness.js: Added.

(WebGLTestHarnessModule.log):
(WebGLTestHarnessModule.try.request.onreadystatechange):
(WebGLTestHarnessModule.loadTextFileAsynchronous):
(WebGLTestHarnessModule.greaterThanOrEqualToVersion):
(WebGLTestHarnessModule.copyObject):
(WebGLTestHarnessModule.toCamelCase):
(WebGLTestHarnessModule.):
(WebGLTestHarnessModule.getFileListImpl):
(WebGLTestHarnessModule.var):
(WebGLTestHarnessModule.getFileList):
(WebGLTestHarnessModule.FilterURL):
(WebGLTestHarnessModule.TestFile):
(WebGLTestHarnessModule.Test):
(WebGLTestHarnessModule.TestHarness):
(WebGLTestHarnessModule.TestHarness.prototype.addFiles_):
(WebGLTestHarnessModule.TestHarness.prototype.runTests):
(WebGLTestHarnessModule.TestHarness.prototype.setTimeout):
(WebGLTestHarnessModule.TestHarness.prototype.clearTimeout):
(WebGLTestHarnessModule.TestHarness.prototype.startNextTest):
(WebGLTestHarnessModule.TestHarness.prototype.startTest):
(WebGLTestHarnessModule.TestHarness.prototype.getTest):
(WebGLTestHarnessModule.TestHarness.prototype.reportResults):
(WebGLTestHarnessModule.TestHarness.prototype.dequeTest):
(WebGLTestHarnessModule.TestHarness.prototype.notifyFinished):
(WebGLTestHarnessModule.TestHarness.prototype.timeout):
(WebGLTestHarnessModule.TestHarness.prototype.setTimeoutDelay):
(WebGLTestHarnessModule):

• webgl/resources/webkit-webgl-test-harness.js: Added.

(.):

9:11 PM Changeset in webkit [141854] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r180583. Requested by
"Mark Pilgrim" <​pilgrim@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-04

• DEPS:

8:45 PM Changeset in webkit [141853] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Coordinated Graphics : disconnectCustomFilterProgram does not do anything.
​https://bugs.webkit.org/show_bug.cgi?id=108807

Patch by Gwang Yoon Hwang <​ryumiel@company100.net> on 2013-02-04
Reviewed by Anders Carlsson.

We need to add newly created WebCustomFilterProgramProxy to a hashset to
disconnect when CoordinatedLayerTreeHost gets destructed.

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):

8:40 PM Changeset in webkit [141852] by morrita@google.com

• 4 edits
  4 copies
  2 moves
  5 adds in trunk/LayoutTests

[Chromium] Unreviewed rebaselining for r141769.

• platform/chromium-mac-lion/compositing/overflow/nested-scrolling-expected.png:
• platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling-expected.png: Added.
• platform/chromium-mac-snowleopard/compositing/overflow/nested-scrolling-expected.png:
• platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling-expected.png: Added.
• platform/chromium-mac/compositing/overflow/nested-scrolling-expected.png:
• platform/chromium-mac/compositing/overflow/textarea-scroll-touch-expected.txt: Added.
• platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling-expected.png: Added.
• platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt: Added.
• platform/chromium/compositing/overflow/scrolling-without-painting-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt.
• platform/chromium/compositing/overflow/updating-scrolling-content-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt.
• platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt.
• platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt.
• platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/scrolling-without-painting-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt.
• platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/updating-scrolling-content-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt.

8:30 PM Changeset in webkit [141851] by james.wei@intel.com

• 2 edits in trunk/Source/WebCore

Heap-buffer-overflow in WebCore::AudioBufferSourceNode::process
​https://bugs.webkit.org/show_bug.cgi?id=108515

After calling setBuffer() with a buffer having a different number of
channels, there can in rare cases be a slight delay before the output
bus is updated to the new number of channels because of use of
tryLocks() in the context's updating system.
In this case, if the the buffer has just been changed and we're
not quite ready yet then just output silence.

Reviewed by Chris Rogers.

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::renderFromBuffer):

8:23 PM Changeset in webkit [141850] by simonjam@chromium.org

• 8 edits in trunk/Source

[Chromium] Add a signal for when the body is inserted in the document
​https://bugs.webkit.org/show_bug.cgi?id=108725

Reviewed by Adam Barth.

Source/WebCore:

This is an important signal for resource scheduling. We know we have enough to paint something,
so we can start kicking off image preloads.

Test: Chromium webkit_unit_tests

• html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLBodyElement):

• loader/FrameLoaderClient.h:

(FrameLoaderClient):
(WebCore::FrameLoaderClient::dispatchWillInsertBody):

Source/WebKit/chromium:

• public/WebFrameClient.h:

(WebFrameClient):
(WebKit::WebFrameClient::willInsertBody):

• src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchWillInsertBody):
(WebKit):

• src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

• tests/WebFrameTest.cpp:

8:21 PM Changeset in webkit [141849] by benjamin@webkit.org

• 47 edits in trunk

Kill suspendAnimation(), resumeAnimation() and numberOfActiveAnimations() from DRT/WTR; use Internals
​https://bugs.webkit.org/show_bug.cgi?id=108741

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-02-04
Reviewed by Tony Chang.

.:

• Source/autotools/symbols.filter:

Source/WebCore:

Move suspendAnimations and resumeAnimations to group all the animation related
code together.

Add support for numberOfActiveAnimations, similarily to the feature previously defined
in TestRunner.

• testing/Internals.cpp:

(WebCore::Internals::numberOfActiveAnimations):
(WebCore):
(WebCore::Internals::suspendAnimations):
(WebCore::Internals::resumeAnimations):

• testing/Internals.h:

(Internals):

• testing/Internals.idl:

Source/WebKit/efl:

• WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
• WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
• WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

• WebView/WebFrame.mm:
• WebView/WebFramePrivate.h:

Source/WebKit/qt:

• WebCoreSupport/DumpRenderTreeSupportQt.cpp:
• WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

• WebKit.vcproj/WebKitExports.def.in:

Source/WebKit2:

Suspending and resuming application has been useless for a one. Someone just
"forgot" WebKit2.

• WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
• WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
• WebProcess/WebPage/WebFrame.cpp:
• WebProcess/WebPage/WebFrame.h:

(WebFrame):

Tools:

Remove all support for suspendAnimation(), resumeAnimation() and numberOfActiveAnimations().

• DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

• DumpRenderTree/TestRunner.h:

(TestRunner):

• DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
• DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

• DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

• DumpRenderTree/efl/TestRunnerEfl.cpp:
• DumpRenderTree/gtk/TestRunnerGtk.cpp:
• DumpRenderTree/mac/TestRunnerMac.mm:
• DumpRenderTree/qt/TestRunnerQt.cpp:
• DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

• DumpRenderTree/win/TestRunnerWin.cpp:
• DumpRenderTree/wx/TestRunnerWx.cpp:
• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:
• WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Update the tests to use WebCore Internals instead of the TestRunner.

• animations/animation-controller-drt-api.html:
• transitions/hang-with-bad-transition-list.html:
• transitions/remove-transition-style.html:
• transitions/repeated-firing-background-color.html:
• transitions/zero-duration-with-non-zero-delay-end.html:

8:02 PM Changeset in webkit [141848] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

[EFL][WK2] Implement runBeforeUnloadConfirmPanel on EFL
​https://bugs.webkit.org/show_bug.cgi?id=106979

Patch by Jaehun Lim <​ljaehun.lim@samsung.com> on 2013-02-04
Reviewed by Benjamin Poulain.

Implement runBeforeUnloadConfirmPanel() to support window.onbeforeunload.
We can show confirmation window when beforeunload event is fired.

• UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::PageUIClientEfl):
(WebKit::PageUIClientEfl::runBeforeUnloadConfirmPanel):
(WebKit):

• UIProcess/efl/PageUIClientEfl.h:

(PageUIClientEfl):

7:42 PM Changeset in webkit [141847] by thakis@chromium.org

• 3 edits in trunk/Tools

[chromium] Try to get WebKit building with enable_web_intents set to 0 on Windows too.
​https://bugs.webkit.org/show_bug.cgi?id=108887

Reviewed by Kentaro Hara.

This is a follow-up to ​http://trac.webkit.org/changeset/141614. The
Mac and Linux linkers didn't complain about the reference to
WebIntent in that function for some reason (probably because it's
a dead function that's stripped).

• DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner):

• DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

7:30 PM Changeset in webkit [141846] by nayankk@motorola.com

• 6 edits in trunk/Source/WebCore

[WEBGL] Rename WEBKIT_WEBGL_compressed_texture_s3tc to WEBGL_compressed_texture_s3tc
​https://bugs.webkit.org/show_bug.cgi?id=108866

Reviewed by Kenneth Russell.

WEBGL_compressed_texture_s3tc is one of the community approved WebGL extension.
Hence remove the vendor prefix from WEBKIT_WEBGL_compressed_texture_s3tc.
Specification: ​http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_s3tc/

No tests currently present to test WEBKIT_WEBGL_compressed_texture_s3tc.

• bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

• bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

• html/canvas/WebGLCompressedTextureS3TC.cpp:

(WebCore::WebGLCompressedTextureS3TC::getName):

• html/canvas/WebGLExtension.h:
• html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension):

7:28 PM Changeset in webkit [141845] by nayankk@motorola.com

• 18 edits in trunk

[WEBGL] Rename WEBKIT_WEBGL_lose_context to WEBGL_lose_context.
​https://bugs.webkit.org/show_bug.cgi?id=108694

Reviewed by Kenneth Russell.

WEBGL_lose_context is one of the community approved WebGL extension.
Hence remove the vendor prefix from WEBKIT_WEBGL_lose_context extension.
Spefication: ​http://www.khronos.org/registry/webgl/extensions/WEBGL_lose_context/

Source/WebCore:

Tests already exists, modified them to verify the change in extension name.

• bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

• bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

• html/canvas/WebGLExtension.h:
• html/canvas/WebGLLoseContext.cpp:

(WebCore::WebGLLoseContext::getName):

• html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

LayoutTests:

• fast/canvas/webgl/WebGLContextEvent.html:
• fast/canvas/webgl/context-destroyed-crash.html:
• fast/canvas/webgl/context-lost-expected.txt:
• fast/canvas/webgl/context-lost-restored.html:
• fast/canvas/webgl/context-lost.html:
• platform/chromium-linux-x86/fast/canvas/webgl/context-lost-expected.txt:
• platform/chromium-linux/fast/canvas/webgl/context-lost-expected.txt:
• platform/chromium-mac/fast/canvas/webgl/context-lost-expected.txt:
• platform/chromium-win-xp/fast/canvas/webgl/context-lost-expected.txt:
• platform/chromium-win/fast/canvas/webgl/context-lost-expected.txt:
• platform/chromium/platform/chromium/virtual/gpu/fast/canvas/webgl/context-lost-expected.txt:

6:57 PM Changeset in webkit [141844] by dino@apple.com

• 4 edits in trunk/Source/WebCore

Default element styles are not always collected for sharing detection
​https://bugs.webkit.org/show_bug.cgi?id=108404

Reviewed by Antti Koivisto.

The method ensureDefaultStyleSheetsForElement is run as we add elements
to the document. This may update the defaultStyle of the document, but
does not recollect any changes into the StyleResolver. This means that
style sharing might be overly ambitious, thinking it can share a style
for an element which was matched in the new rules. This showed up most
often in the Shadow Root for media elements, which would add a set of
style rules, but the shadow children would sometimes share styles even
when they shouldn't.

The fix is to detect if we need to collect after adding a
style for an element. This might cause a little more work, but
in my testing it doesn't happen very often.

Unfortunately it is hard to get a reproducible test for this.

• css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement): As we load in

styles, keep track of whether or not we change the default style.

• css/CSSDefaultStyleSheets.h:

(CSSDefaultStyleSheets): New boolean parameter indicating if the style has changed.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement): Collect features if the element

caused the default style to update.

(WebCore::StyleResolver::collectFeatures): Protect for null in updates.

6:25 PM Changeset in webkit [141843] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Fix the issue that some possible source formats are ignored for float textures in texture packing for CG port
​https://bugs.webkit.org/show_bug.cgi?id=108812

Patch by Jun Jiang <​jun.a.jiang@intel.com> on 2013-02-04
Reviewed by Kenneth Russell.

Already covered by latest WebGL conformance test.

• platform/graphics/GraphicsContext3D.cpp:

(WebCore):

6:12 PM Changeset in webkit [141842] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Source/WebCore

[EFL] Remove needless local variables in LocalizedStringsEfl.cpp
​https://bugs.webkit.org/show_bug.cgi?id=108869

Reviewed by Kentaro Hara.

fromUTF8() returns static String. So, we don't need to use needless local variables.

• platform/efl/LocalizedStringsEfl.cpp:

(WebCore::contextMenuItemTagCopy):
(WebCore::contextMenuItemTagDelete):
(WebCore::contextMenuItemTagSelectAll):
(WebCore::contextMenuItemTagGoBack):
(WebCore::contextMenuItemTagGoForward):
(WebCore::contextMenuItemTagStop):
(WebCore::contextMenuItemTagCut):
(WebCore::contextMenuItemTagPaste):
(WebCore::contextMenuItemTagBold):
(WebCore::contextMenuItemTagItalic):
(WebCore::contextMenuItemTagUnderline):

6:11 PM Changeset in webkit [141841] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

WebGL: Move the format conversion for 16-bit per channel formats into Core Graphics port only
​https://bugs.webkit.org/show_bug.cgi?id=108304

Patch by Jun Jiang <​jun.a.jiang@intel.com> on 2013-02-04
Reviewed by Kenneth Russell.

Since the 16-bit per channel formats are only used for Core Graphics port in WebGL and not a standard to represent any file format that is widely used
for each platform, it is better to limit and hide this kinds of information and processing in CG specific code only.
It can make the code more clear and reduce the binary size for both CG port and non-CG port.

Already covered by current tests.

• platform/graphics/GraphicsContext3D.cpp:

(WebCore):

• platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D):
(WebCore::GraphicsContext3D::srcFormatComeFromDOMElementOrImageData):
(ImageExtractor):

• platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

6:01 PM Changeset in webkit [141840] by dino@apple.com

• 3 edits in trunk/Source/WebCore

Allow TextTracks to be marked as closed captions
​https://bugs.webkit.org/show_bug.cgi?id=108856

Reviewed by Darin Adler.

While this isn't exposed directly in markup, some platform media frameworks can
provide indication that a caption track is a closed caption. Expose such a flag
on TextTrack and platforms can show a different UI if they want to.

No tests - this isn't used elsewhere yet, nor exposed to the DOM.

• html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Initialise new member.

• html/track/TextTrack.h:

(WebCore::TextTrack::isClosedCaptions): New member variable.
(WebCore::TextTrack::setIsClosedCaptions):

5:46 PM Changeset in webkit [141839] by jparent@chromium.org

• 6 edits in trunk/Tools

Dashboard cleanup: Make builder a real dashboardSpecificParameter.
​https://bugs.webkit.org/show_bug.cgi?id=108706

Reviewed by Dirk Pranke.

Add builder to g_defaultDashboardSpecificParameter maps for the
dashboards where it is used (flakiness, timeline, treemap).
Default it to null, and then update reads of it to check the
builder group's default if one is not set, rather than trying to
set and track this everywhere.
This allows us to remove tons of special-casing of builder parsing,
including where we used to add it to the query string even when the
user did not specify it.

• TestResultServer/static-dashboards/dashboard_base.js:

(parseParameters):

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(generatePage):
(handleQueryParameterChange):

• TestResultServer/static-dashboards/loader.js:

(.):

• TestResultServer/static-dashboards/timeline_explorer.html:
• TestResultServer/static-dashboards/treemap.html:

5:30 PM Changeset in webkit [141838] by jparent@chromium.org

• 2 edits in trunk/Tools

Setting tests on flakiness dashboard should invalidate builder.
​https://bugs.webkit.org/show_bug.cgi?id=108521

Reviewed by Dirk Pranke.

When you move into a cross builder view, builder should not still be
set. Currently, it is deleted from the internal state, but still shows
up in the url, causing the current state and the hash to not match.

To see this in action, load the flakiness dashboard, select a builder,
and then click on an individual test, to get into individual test view.
The url will still have the builder you selected listed, even though it
is cleared in the UI.

The fix is to consider 'tests' to be a parameter that invalidates builder.

• TestResultServer/static-dashboards/flakiness_dashboard.js:

5:27 PM Changeset in webkit [141837] by commit-queue@webkit.org

• 34 edits
  1 add in trunk

Make moveCaretTowardsWindowPoint not snap to the beginning/end when moved above/below editable
​https://bugs.webkit.org/show_bug.cgi?id=107850

Patch by Chris Hopman <​cjhopman@chromium.org> on 2013-02-04
Reviewed by Ojan Vafai.

Source/WebCore:

On Android, EditingBehavior::shouldMoveCaret[...] controls the
behavior of insertion handles. This change adds a new Android specific
editing behavior type.

The new EditingBehavior is the same as EditingUnixBehavior except for
EditingBehavior::shouldMoveCaret[...]. This new behavior fixes
WebFrame::moveCaretTowardsWindowPoint to not span to the
beginning/end.

• editing/EditingBehavior.h:

(WebCore::EditingBehavior::shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom):
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
(WebCore::EditingBehavior::shouldNavigateBackOnBackspace):

• editing/EditingBehaviorTypes.h:
• page/Settings.cpp:

(WebCore):
(WebCore::editingBehaviorTypeForPlatform):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::setEditingBehavior):

Source/WebKit/chromium:

On Android, EditingBehavior::shouldMoveCaret[...] controls the
behavior of insertion handles. This change adds a new Android specific
editing behavior type so that we can change these settings independent
of behavior for other platforms.

• public/WebSettings.h:
• src/AssertMatchingEnums.cpp:

Just add the corresponding assertion for the new editing behavior.

• public/WebSettings.h:
• src/AssertMatchingEnums.cpp:

• tests/WebFrameTest.cpp:
• tests/data/move_caret.html: Added.

Add a test that moveCaretTowardsWindowPoint works as expected on
Android.

LayoutTests:

Test the new "android" editing behavior in the following tests:

• editing/deleting/delete-ligature-003-expected.txt:
• editing/deleting/delete-ligature-003.html:
• editing/deleting/paragraph-in-preserveNewline-expected.txt:
• editing/deleting/paragraph-in-preserveNewline.html:
• editing/deleting/whitespace-pre-1-expected.txt:
• editing/deleting/whitespace-pre-1.html:
• editing/execCommand/script-tests/toggle-compound-styles.js:
• editing/execCommand/toggle-compound-styles-expected.txt:
• editing/selection/5354455-1-expected.txt:
• editing/selection/5354455-1.html:
• editing/selection/click-in-margins-inside-editable-div-expected.txt:
• editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
• editing/selection/context-menu-text-selection-expected.txt:
• editing/selection/context-menu-text-selection.html:
• editing/selection/extend-after-mouse-selection-expected.txt:
• editing/selection/extend-after-mouse-selection.html:
• editing/selection/programmatic-selection-on-mac-is-directionless-expected.txt:
• editing/selection/programmatic-selection-on-mac-is-directionless.html:
• editing/selection/rtl-move-selection-right-left-expected.txt:
• editing/selection/rtl-move-selection-right-left.html:
• editing/selection/script-tests/click-in-margins-inside-editable-div.js:
• editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js:
• editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt:
• editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:

5:20 PM Changeset in webkit [141836] by kenneth@webkit.org

• 16 edits
  2 adds in trunk

[EFL][WK2] Introduce a WebView class as counterpart for WKViewRef
​https://bugs.webkit.org/show_bug.cgi?id=107931

Reviewed by Anders Carlsson.

Source/WebKit2:

This is just one step of the new plan for the EFL API.

The plan is to move the public EFL-like API on top of the shared
WK2 C API, plus a few EFL extensions (WKView class mostly).

The EFL-like API can be seen as a convenience API which ties
well into EFL and which makes it easy to add web experiences
to existing and new EFL applications. It provides a smart object
like API and a Evas_Object based view.

For more advanced use cases, such as browser and runtime, it is
possible to use the WK* C API, which is gives more flexibility
while being more low level.

The idea is that the WKView class will not depend on Evas_Object
and X11 (future plan) unlike the current EFL-like API. This should
make it possible to use it for cases where none of these are
available.

This patch introduces the WebView class which serves as our
counterpart for the WKView class, and adds a few needed methods.

The EwkView owns the WebView class (and will be constructing it
in the near future when the EwkView class has been changed to
handle all smart object related code)

The clean up of the smart object related code as the proper
construction of EwkView and WebView will be done in follow-up
patches.

• UIProcess/API/C/efl/WKAPICastEfl.h:

(WebKit):

The WKView API is not based on WebView and not Evas_Object*

• UIProcess/API/C/efl/WKView.cpp:

(WKViewCreate):
(WKViewCreateWithFixedLayout):
(WKViewInitialize):
(WKViewGetPage):
(WKViewSetThemePath):
(WKViewSuspendActiveDOMObjectsAndAnimations):
(WKViewResumeActiveDOMObjectsAndAnimations):
(WKViewGetEvasObject):
(WKViewCreateSnapshot):

Add a few new WKView EFL C methods, and update existing
methods to reflect that the WKViewRef is now a WebView*

The construction methods will be rewritten when the smart
object construction has been solved.

• UIProcess/API/C/efl/WKView.h:
• UIProcess/efl/WebView.cpp: Added.

(WebKit):
(WebKit::WebView::WebView):
(WebKit::WebView::~WebView):
(WebKit::WebView::initialize):
(WebKit::WebView::setThemePath):
(WebKit::WebView::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebView::resumeActiveDOMObjectsAndAnimations):

• UIProcess/efl/WebView.h: Added.

(WebKit):
(WebView):
(WebKit::WebView::pageRef):
(WebKit::WebView::evasObject):
(WebKit::WebView::page):
(WebKit::WebView::type):

Add a new WebKit::WebView class for EFL.

• UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::~EwkView):
(EwkView::wkPage):
(EwkView::setThemePath):
(EwkView::createGLSurface):

Base methods on C API instead of internal API as much
as currently possible.

• UIProcess/API/efl/EwkView.h:

(WebKit):
(WebView):
(EwkView):
(EwkView::wkView):
(EwkView::page):

• UIProcess/API/efl/ewk_view.cpp:

(createEwkView):
(ewk_view_base_add):
(ewk_view_smart_add):

Modify to return the EwkView class for now.

• UIProcess/API/efl/ewk_view_private.h:
• UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Updated due to changed API.

Tools:

Change platformView to be a WKView and use WKViewGetEvasObject
for the places where an Evas_Object is needed.

Instead of extracting the Ecore_Evas* from the m_view we use
the m_window instead, which actually holds the it.

• TestWebKitAPI/PlatformWebView.h:
• TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
(TestWebKitAPI::PlatformWebView::simulateRightClick):

• WebKitTestRunner/PlatformWebView.h:
• WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR::EventSenderProxy::sendTouchEvent):
(WTR::EventSenderProxy::setTouchModifier):

• WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::resizeTo):
(WTR::PlatformWebView::page):
(WTR::PlatformWebView::focus):
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
(WTR::PlatformWebView::windowSnapshotImage):

5:17 PM Changeset in webkit [141835] by tkent@chromium.org

• 13 edits
  2 adds in trunk

INPUT_MULTIPLE_FIELDS_UI: Focus order is not controllable by tabIndex attribute on <input>
​https://bugs.webkit.org/show_bug.cgi?id=108447

Reviewed by Hajime Morita.

Source/WebCore:

We make <input> elements with the multiple-fields UI focusable.

• However, we don't want to change the existing focus behavior for multiple-fields <input>. We'd like to focus on the last sub-field of an<input> with Shift + TAB focus navigation, and focus on the first sub-field of the <input> otherwise. So, we move focus immediately after the <input> gets focus.
• We don't need the isFocusableByClickOnLabel hack any more. <input> elements with the multiple-fields UI are mouse-focusable.

Test: fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html

• html/InputType.h:

(InputType): Add FocusDirection argument to handleFocusEvent, and remove
unnecessary isFocusableByClickOnLabel and focus.

• html/InputType.cpp:

(WebCore::InputType::handleFocusEvent): Ditto.

• html/PasswordInputType.cpp:

(WebCore::PasswordInputType::handleFocusEvent): Follow the argument change.

• html/PasswordInputType.h:

(PasswordInputType): Ditto.

• html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleFocusEvent):
If this element gets focus by FocusDirectionBackward (it means the focus
is moved from the first sub-field of the element,) move the focus
backward once more. Otherwise, we focus on the first sub-filed of the
element.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isKeyboardFocusable):
Make this keyboard-focusable. We have a wrong test to ensure read-only
input does NOT get focus. We'll address it later.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isMouseFocusable):
Make this mouse-focusable.

• html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType):

• html/HTMLInputElement.h:

(HTMLInputElement): Remove defaultFocus, focus, and isFocusableByClickOnLabel.
Add missing OVERRIDE to handleFocusEvent.

• html/HTMLInputElement.cpp: Remove unnecessary functions.

(WebCore::HTMLInputElement::handleFocusEvent):
Pass FocusDirection value to InputTYpe::handleFocusEvent.

• html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::defaultEventHandler):
Use isMouseFocusable().

• html/HTMLElement.cpp: Remove unnecessary isFocusableByClickOnLabel.
• html/HTMLElement.h: Ditto.

LayoutTests:

• fast/forms/time-multiple-fields/time-multiple-fields-tabindex-expected.txt: Added.
• fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html: Added.

5:13 PM Changeset in webkit [141834] by andersca@apple.com

• 6 edits in trunk/Source/WebKit2

Set up the storage manager as a connection queue
​https://bugs.webkit.org/show_bug.cgi?id=108879

Reviewed by Sam Weinig.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::processWillOpenConnection):
Add the storage manager as a connection queue client.

(WebKit::StorageManager::processWillCloseConnection):
Remove the storage manager.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::processWillOpenConnection):
Call the storage manager.

(WebKit::WebContext::processWillCloseConnection):
Call the storage manager.

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connectionWillOpen):
Call the context.

(WebKit::WebProcessProxy::connectionWillClose):
Call the context.

(WebKit::WebProcessProxy::didFinishLaunching):
Remove a comment.

4:54 PM Changeset in webkit [141833] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Coordinated Graphics: crash in TiledBackingStore::adjustForContentsRect
​https://bugs.webkit.org/show_bug.cgi?id=107639

Patch by Seulgi Kim <​seulgikim@company100.net> on 2013-02-04
Reviewed by Kenneth Rohde Christiansen.

In TiledBackingStore::adjustForContentsRect method, inflating is not
needed when there is no intersections between the cover/keep rect and
the content rect.

No new tests, no change in functionality.

• platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::adjustForContentsRect):

4:46 PM Changeset in webkit [141832] by senorblanco@chromium.org

• 3 edits in trunk/Source/WebCore

[skia] Remove use of SkSingleInputImageFilter.
​https://bugs.webkit.org/show_bug.cgi?id=108867

Reviewed by James Robinson.

This class is but a hollow shell of its former self, and has
been removed in Skia.

Covered by existing tests in css3/filters.

• platform/graphics/filters/skia/DropShadowImageFilter.cpp:

(WebCore::DropShadowImageFilter::DropShadowImageFilter):
(WebCore::DropShadowImageFilter::onFilterImage):

• platform/graphics/filters/skia/DropShadowImageFilter.h:

4:39 PM Changeset in webkit [141831] by jberlin@webkit.org

• 2 edits in trunk/LayoutTests

REGRESSION (r129478-r129480): http/tests/loading/text-content-type-with-binary-extension.html failing on Apple MountainLion Debug WK2 (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=98527

The bug was fixed but the test was never removed from the Mac WK2 TestExpectations file.
Remove it now.

• platform/mac-wk2/TestExpectations:

4:34 PM Changeset in webkit [141830] by andersca@apple.com

• 6 edits in trunk/Source/WebKit2

Send message when creating and destroying StorageAreaProxy objects
​https://bugs.webkit.org/show_bug.cgi?id=108874

Reviewed by Sam Weinig.

• Shared/SecurityOriginData.cpp:

(WebKit::SecurityOriginData::fromSecurityOrigin):

• Shared/SecurityOriginData.h:

(SecurityOriginData):
Add helper function for creating a SecurityOriginData object given a WebCore::SecurityOrigin object.

• WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::generateStorageAreaID):
New function to create a unique storage area ID.

(WebKit::StorageAreaProxy::StorageAreaProxy):
Send a CreateStorageArea message.

(WebKit::StorageAreaProxy::~StorageAreaProxy):
Send a DestroyStorageArea message.

(WebKit::StorageAreaProxy::contains):
Remove this assertion for now, it fires too often.

• WebProcess/Storage/StorageNamespaceProxy.h:

(WebKit::StorageNamespaceProxy::storageNamespaceID):
Add getter.

4:30 PM Changeset in webkit [141829] by commit-queue@webkit.org

• 7 edits in trunk/Tools

Don't update author info in PrepareChangeLog and allow users to skip the PrepareChangeLog step entirely.
​https://bugs.webkit.org/show_bug.cgi?id=108788

Patch by Timothy Loh <​timloh@chromium.com> on 2013-02-04
Reviewed by Ryosuke Niwa.

As per discussion in Bug 74358, it's probably preferable to remove the
behaviour of updating the author details in a ChangeLog entry. We also
want to be able to skip preparing change logs (e.g. rebaselining many
tests), so a --no-prepare-changelogs option is added to webkit-patch.

• Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry._parse_entry):
(ChangeLogEntry.date): Added

• Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_parse_log_entries_from_changelog):

• Scripts/webkitpy/tool/commands/commandtest.py:

(CommandsTest.assert_execute_outputs):

• Scripts/webkitpy/tool/steps/options.py:

(Options): Added --no-prepare-changelogs

• Scripts/webkitpy/tool/steps/preparechangelog.py:

(PrepareChangeLog.options):
(PrepareChangeLog._merge_entries): date_line() gets the entire line, including
the author's name and email, but we only want to replace the date.
(PrepareChangeLog.run):

• Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:

(PrepareChangeLogTest.test_resolve_existing_entry): Added tests for changed
authors. Removed unneeded variable.

4:28 PM Changeset in webkit [141828] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

[ Linux ] Mark media/track/track-cues-cuechange.html and media/track/track-cues-enter-exit.html as slow
​https://bugs.webkit.org/show_bug.cgi?id=108876

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-02-04
Reviewed by Dirk Pranke.

Tests take ~5.4 seconds to run locally.
Timing out on the EWS bots but passing on the Webkit buildbots.
Marked tests as slow in TestExpectations.

• platform/chromium/TestExpectations:

3:57 PM Changeset in webkit [141827] by kenneth@webkit.org

• 3 edits in trunk/Source/WebKit2

[EFL][WK2] Use C API inside EwkView
​https://bugs.webkit.org/show_bug.cgi?id=108825

Reviewed by Anders Carlsson.

A straight-forward port towards the C API.

• UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView): Use C API for common default preferences.
(EwkView::wkPage): Make it const and remove useless comment.
(EwkView::deviceScaleFactor):
(EwkView::title):
(EwkView::customTextEncodingName):
(EwkView::setCustomTextEncodingName):
(EwkView::informURLChange):

• UIProcess/API/efl/EwkView.h:

(EwkView):

3:55 PM Changeset in webkit [141826] by haraken@chromium.org

• 10 edits in trunk

Implement WheelEvent::deltaMode
​https://bugs.webkit.org/show_bug.cgi?id=108455

Reviewed by Adam Barth.

Source/WebCore:

Per the spec, WheelEvent::deltaMode should return
DOM_DELTA_PIXEL or DOM_DELTA_LINE or DOM_DELTA_PAGE.

Spec: ​http://www.w3.org/TR/DOM-Level-3-Events/#events-wheelevents
​https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent

Test: fast/event/wheel-event-constructor.html

• dom/WheelEvent.cpp:

(WebCore::WheelEventInit::WheelEventInit):
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::deltaMode):

• dom/WheelEvent.h:

(WheelEventInit):
(WebCore::WheelEvent::create):
(WebCore::WheelEvent::deltaMode):
(WheelEvent):

• dom/WheelEvent.idl:
• page/EventHandler.cpp:

(WebCore::wheelGranularityToScrollGranularity):

Source/WebKit/chromium:

• src/WebInputEventConversion.cpp:

(WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):

LayoutTests:

Per the spec, WheelEvent::deltaMode should return
DOM_DELTA_PIXEL or DOM_DELTA_LINE or DOM_DELTA_PAGE.

Spec: ​http://www.w3.org/TR/DOM-Level-3-Events/#events-wheelevents
​https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent

• fast/events/constructors/wheel-event-constructor-expected.txt:
• fast/events/constructors/wheel-event-constructor.html:

3:54 PM Changeset in webkit [141825] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

Remove an unnecessary sandbox rule.

Reviewed by Sam Weinig.

• WebProcess/com.apple.WebProcess.sb.in: We already have a file-read rule for /Library/Managed Preferences, no need for another rule for something inside it.

3:24 PM Changeset in webkit [141824] by beidson@apple.com

• 5 edits in trunk/Source/WebKit2

WebProcess crashes handling repeated NetworkProcess crashes.
<rdar://problem/13049867> and ​https://bugs.webkit.org/show_bug.cgi?id=108861

Reviewed by Alexey Proskuryakov.

• Rename the concept of "unschedulable loader" to "internally failed loader"
• When the NetworkProcess crashes, add all outstanding ResourceLoaders into the unschedulable pile.
• WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::WebResourceLoadScheduler):
(WebKit::WebResourceLoadScheduler::scheduleLoad):
(WebKit::WebResourceLoadScheduler::scheduleInternallyFailedLoad):
(WebKit::WebResourceLoadScheduler::internallyFailedLoadTimerFired):
(WebKit::WebResourceLoadScheduler::remove): Also remove a non-helpful, out of date comment.
(WebKit::WebResourceLoadScheduler::networkProcessCrashed):

• WebProcess/Network/WebResourceLoadScheduler.h:

WebResourceLoader no longer responds to crashes directly, but now exposes its WebCore ResourceLoader:

• WebProcess/Network/WebResourceLoader.cpp:
• WebProcess/Network/WebResourceLoader.h:

(WebKit::WebResourceLoader::resourceLoader):

3:23 PM Changeset in webkit [141823] by jochen@chromium.org

• 14 edits
  5 deletes in trunk/Tools

[chromium] Remove WebEventSender and WebAccessibilityController from public TestRunner API
​https://bugs.webkit.org/show_bug.cgi?id=108467

Reviewed by Adam Barth.

• DumpRenderTree/DumpRenderTree.gypi:
• DumpRenderTree/chromium/TestRunner/public/WebAccessibilityController.h: Removed.
• DumpRenderTree/chromium/TestRunner/public/WebEventSender.h: Removed.
• DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebTestRunner):
(WebTestInterfaces):

• DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner):
(WebTestProxyBase):

• DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner):

• DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):

• DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::setWebView):
(WebTestRunner::TestInterfaces::webView):
(WebTestRunner):

• DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

• DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

• DumpRenderTree/chromium/TestRunner/src/WebAccessibilityController.cpp: Removed.
• DumpRenderTree/chromium/TestRunner/src/WebEventSender.cpp: Removed.
• DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::setWebView):
(WebTestRunner::WebTestInterfaces::setDelegate):
(WebTestRunner::WebTestInterfaces::bindTo):
(WebTestRunner::WebTestInterfaces::resetAll):
(WebTestRunner::WebTestInterfaces::setTestIsRunning):
(WebTestRunner::WebTestInterfaces::webView):
(WebTestRunner::WebTestInterfaces::testRunner):
(WebTestRunner::WebTestInterfaces::testInterfaces):

• DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::setInterfaces):

• DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Removed.
• DumpRenderTree/chromium/TestShell.h:
• DumpRenderTree/chromium/WebViewHost.cpp:
• DumpRenderTree/chromium/WebViewHost.h:

3:19 PM Changeset in webkit [141822] by kov@webkit.org

• 2 edits in trunk/Source/WebCore

[Soup] Remove duplicate setting of first party for cookies
​https://bugs.webkit.org/show_bug.cgi?id=108814

Reviewed by Martin Robinson.

Covered by existing tests.

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::createSoupMessageForHandleAndRequest): there is no need to set
the first party for cookies here, since that is already done in
ResourceRequest::updateSoupMessage, which is called a few lines before.

3:18 PM Changeset in webkit [141821] by kov@webkit.org

• 7 edits in trunk/Source/WebCore

[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid copying
​https://bugs.webkit.org/show_bug.cgi?id=105552

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-02-04
Reviewed by Philippe Normand.

Makes it possible for the GStreamer media backend to provide the buffer to which
the Soup networking backend will use to download data to. This makes copying
memory unnecessary when ResourceHandle hands data over to the media player's
StreamingClient. Thanks to Dan Winship for help designing the interface.

No behaviour change, covered by existing tests.

• platform/graphics/gstreamer/GStreamerVersioning.cpp:

(createGstBufferForData): New helper to create a GstBuffer when
we have a data pointer and a length.
(getGstBufferSize): Abstract obtaining the size of the buffer, so the code
is cleaner while still working for both GST 0.10 and 1.0.
(setGstBufferSize): Ditto, but for setting the size.
(getGstBufferDataPointer): Ditto, but for grabbing the data pointer.
(mapGstBuffer): Convenience method to take care of mapping the buffer so that
we can provide the data pointer to ResourceHandle.
(unmapGstBuffer): Convenience method which takes care of unmapping the buffer
and properly freeing the GstMapInfo.

• platform/graphics/gstreamer/GStreamerVersioning.h:
• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient): New methods.
(_WebKitWebSrcPrivate): We now store the GstBuffer we provided the data pointer from
so we can later unmap it and push it to the pipeline.
(webKitWebSrcDispose): Deal with the GstBuffer in case it exists when the source is
destroyed.
(webKitWebSrcStop): Also clear the GstBuffer in this case.
(StreamingClient::didReceiveData): Handle the hand-over of the buffer.
(StreamingClient::getBuffer): Provide ResourceHandle with a new GstBuffer's data pointer.

• platform/network/ResourceHandleClient.h:

(ResourceHandleClient):
(WebCore::ResourceHandleClient::ResourceHandleClient): Constructor to initialize the buffer
member variable to 0.
(WebCore::ResourceHandleClient::~ResourceHandleClient): Destructor to free the buffer if it
has been allocated.
(WebCore::ResourceHandleClient::getBuffer): Default implementation which returns a
newly allocated char pointer.

• platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal): Store actual buffer size, which is no longer a constant.

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::cleanupSoupRequestOperation): Clear the buffer pointer, the life-cycle of the
buffer is handled by the ResourceHandleClient.
(WebCore::nextMultipartResponsePartCallback): Get a new buffer from the client before reading.
(WebCore::sendRequestCallback): Ditto.
(WebCore::readCallback): Ditto.

3:07 PM Changeset in webkit [141820] by andersca@apple.com

• 15 edits in trunk/Source/WebKit2

Update message generation to use the new queue client semantics
​https://bugs.webkit.org/show_bug.cgi?id=108865

Reviewed by Andreas Kling.

• Scripts/webkit2/messages.py:

(connection_work_queue_message_statement):
(async_message_statement):
(generate_message_handler):

• Scripts/webkit2/messages_unittest.py:
• Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):

• Shared/mac/SecItemShim.h:

(SecItemShim):

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):

• UIProcess/Storage/StorageManager.h:

(StorageManager):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):

• UIProcess/WebProcessProxy.h:

(WebProcessProxy):

• UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):

• UIProcess/mac/SecItemShimProxy.h:

(SecItemShimProxy):

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::didReceiveMessageOnConnectionWorkQueue):

• WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):

• WebProcess/WebProcess.h:

(WebProcess):

3:01 PM Changeset in webkit [141819] by benjamin@webkit.org

• 2 edits in trunk/Source/WTF

Build fix for AtomicString on iOS

Unreviewed. The commit r141812 rely on isUIThread(), there is no such things
in the tree right now. Use pthread_main_np() until more thread handling is upstreamed.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-02-04

• wtf/text/AtomicString.cpp:

(WTF::AtomicStringTable::create):

2:49 PM Changeset in webkit [141818] by pilgrim@chromium.org

• 6 edits
  1 move
  2 adds in trunk/Source

[Chromium] Move WorkerContextProxy to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=108847

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

• WebCore.gyp/WebCore.gyp:
• WebCore.gypi:
• workers/chromium: Added.
• workers/chromium/WorkerContextProxyChromium.cpp: Added.

(WebCore):
(WebCore::setWorkerContextProxyCreateFunction):
(WebCore::WorkerContextProxy::create):

• workers/chromium/WorkerContextProxyChromium.h: Added.

(WebCore):

Source/WebKit/chromium:

• WebKit.gyp:
• src/WebKit.cpp:

(WebKit::initializeWithoutV8):

• src/WorkerContextProxy.cpp: Removed.

2:39 PM Changeset in webkit [141817] by commit-queue@webkit.org

• 3 edits
  3 adds in trunk

WebVTT <i>, <b> and <u> elements should have default styles
​https://bugs.webkit.org/show_bug.cgi?id=107214

Patch by Dima Gorbik <​dgorbik@apple.com> on 2013-02-04
Reviewed by Darin Adler.

Source/WebCore:

Added default styles for basic webvtt object types.

Test: media/track/track-css-matching-default.html

• css/mediaControls.css:

(video::-webkit-media-text-track-container b):
(video::-webkit-media-text-track-container u):
(video::-webkit-media-text-track-container i):

LayoutTests:

• media/track/captions-webvtt/styling-default.vtt: Added.
• media/track/track-css-matching-default-expected.txt: Added.
• media/track/track-css-matching-default.html: Added.

2:36 PM Changeset in webkit [141816] by inferno@chromium.org

• 47 edits in trunk/Source

Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
​https://bugs.webkit.org/show_bug.cgi?id=108668

Reviewed by Eric Seidel.

Source/WebCore:

• bindings/v8/SerializedScriptValue.cpp:
• css/CSSCalculationValue.cpp:

(WebCore::CSSCalcExpressionNodeParser::parseCalc):

• css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet):
(WebCore::CSSImageSetValue::customCssText):

• css/CSSParserValues.h:

(WebCore::CSSParserString::operator[]):

• css/CSSValueList.h:

(WebCore::CSSValueListInspector::item):

• css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::ruleAt):
(WebCore::StyleSheetContents::wrapperInsertRule):
(WebCore::StyleSheetContents::wrapperDeleteRule):

• dom/Document.cpp:

(WebCore::Document::processArguments):

• dom/Element.cpp:

(WebCore::Element::removeAttributeInternal):

• dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::removeAttribute):

• dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::attributeItem):

• dom/SpaceSplitString.h:

(WebCore::SpaceSplitStringData::operator[]):
(WebCore::SpaceSplitString::operator[]):

• editing/TextIterator.cpp:

(WebCore::TextIterator::characterAt):

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::removeFormElement):

• html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

• html/canvas/WebGLRenderingContext.cpp:

(WebCore):

• html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::swapTo):

• inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle):

• inspector/InspectorStyleTextEditor.cpp:

(WebCore::InspectorStyleTextEditor::replaceProperty):

• inspector/InspectorValues.cpp:

(WebCore::InspectorArrayBase::get):

• page/WindowFeatures.cpp:

(WebCore::WindowFeatures::WindowFeatures):

• platform/audio/AudioArray.h:

(WebCore::AudioArray::at):

• platform/audio/AudioFIFO.cpp:

(WebCore::AudioFIFO::findWrapLengths):

• platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::glyphAt):
(WebCore::GlyphPage::setGlyphDataForIndex):

• platform/graphics/TextRun.h:

(WebCore::TextRun::operator[]):
(WebCore::TextRun::data8):
(WebCore::TextRun::data16):

• platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::setDrawRange):

• platform/graphics/openvg/TiledImageOpenVG.cpp:

(WebCore::TiledImageOpenVG::setTile):
(WebCore::TiledImageOpenVG::tile):

• platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::imageTypeAtIndex):

• platform/text/QuotedPrintable.cpp:

(WebCore::lengthOfLineEndingAtIndex):

• platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::advance):

• platform/win/WebCoreTextRenderer.cpp:

(WebCore::doDrawTextAtPoint):

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):

Source/WebKit/chromium:

• src/ContextFeaturesClientImpl.cpp:

(WebKit::ContextFeaturesCache::entryFor):

• src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::selectFindMatch):

Source/WebKit2:

• Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::HandleArray::operator[]):

Source/WTF:

• wtf/AVLTree.h:

(WTF::AVLTreeDefaultBSet::operator[]):

• wtf/BitArray.h:

(WTF::BitArray::set):
(WTF::BitArray::get):

• wtf/FastBitVector.h:

(WTF::FastBitVector::set):
(WTF::FastBitVector::clear):
(WTF::FastBitVector::get):

• wtf/FixedArray.h:

(WTF::FixedArray::operator[]):

• wtf/RefCountedArray.h:

(WTF::RefCountedArray::at):

• wtf/TypedArrayBase.h:

(WTF::TypedArrayBase::item):

• wtf/text/StringBuffer.h:

(WTF::StringBuffer::operator[]):

• wtf/text/StringBuilder.h:

(WTF::StringBuilder::operator[]):

• wtf/text/StringImpl.h:

(WTF::StringImpl::operator[]):

2:35 PM Changeset in webkit [141815] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r141809.
​http://trac.webkit.org/changeset/141809
​https://bugs.webkit.org/show_bug.cgi?id=108860

ARC isn't supported on 32-bit. (Requested by mhahnenberg on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-04

• API/tests/testapi.mm:

(+[TestObject testObject]):
(testObjectiveCAPI):

• JavaScriptCore.xcodeproj/project.pbxproj:

2:33 PM Changeset in webkit [141814] by andersca@apple.com

• 15 edits in trunk/Source/WebKit2

Change didReceiveMessageOnConnectionWorkQueue semantics
​https://bugs.webkit.org/show_bug.cgi?id=108859

Reviewed by Sam Weinig.

Change didReceiveMessageOnConnectionWorkQueue to take a reference to an
OwnPtr<MessageDecoder>. This lets queue clients handle a message later, on a different
work queue for example. Also, get rid of the didHandleMessage boolean, since taking ownership
of the decoder implicitly means that the message was handled.

• Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):

• Platform/CoreIPC/Connection.h:

(QueueClient):

• Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):

• Shared/mac/SecItemShim.h:

(SecItemShim):

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageManager):
(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):

• UIProcess/Storage/StorageManager.h:

(WebKit):
(StorageManager):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):

• UIProcess/WebProcessProxy.h:

(WebProcessProxy):

• UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):

• UIProcess/mac/SecItemShimProxy.h:

(SecItemShimProxy):

• WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::didReceiveMessageOnConnectionWorkQueue):

• WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):

• WebProcess/WebProcess.h:

(WebProcess):

2:28 PM Changeset in webkit [141813] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/12884778> Sandbox violation due to MediaAccessibility code trying to access ~/Library/Preferences/com.apple.mediaaccessibility.plist

Reviewed by Sam Weinig.

• WebProcess/com.apple.WebProcess.sb.in:

2:20 PM Changeset in webkit [141812] by benjamin@webkit.org

• 3 edits in trunk/Source/WTF

Upstream iOS's AtomicString
​https://bugs.webkit.org/show_bug.cgi?id=108139

Reviewed by David Kilzer.

On iOS, WebCore can be executed from two different threads. To maintain consistency,
a few changes had been made:
-The main UI thread and the WebThread share the same AtomicStringTable.
-A spin lock is needed before any access to prevent any concurrent modification of the string table.

The spin lock also prevent race on the static initialization of the shared table.

• wtf/Platform.h:

Introduce a new USE(WEB_THREAD) to scope changes related to iOS Web Thread.

• wtf/text/AtomicString.cpp:

(AtomicStringTableLocker):
(WTF::AtomicStringTableLocker::AtomicStringTableLocker):
(WTF::AtomicStringTableLocker::~AtomicStringTableLocker):
(WTF::AtomicStringTable::create):
wtfThreadData() is not necessarily inlined on ARM. When it is not inlined, the old code
causes two call to the function. Instead, we can keep the value in register and pass it
to AtomicStringTable::create().
(WTF::stringTable):
(WTF::addToStringTable):
(WTF::AtomicString::addSlowCase):
(WTF::AtomicString::find):
(WTF::AtomicString::remove):

2:19 PM Changeset in webkit [141811] by Nate Chapin

• 2 edits in trunk/Source/WebCore

REGRESSION (r137607): Loading of archives as substitute data is broken
​https://bugs.webkit.org/show_bug.cgi?id=108589

Reviewed by Alexey Proskuryakov.

• loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::resourceData): Return the content from

SubstituteData as mainResourceData if present.

2:18 PM Changeset in webkit [141810] by jchaffraix@webkit.org

• 3 edits
  2 adds in trunk

[CSS Grid Layout] Heap-buffer-overflow in std::sort
​https://bugs.webkit.org/show_bug.cgi?id=108834

Reviewed by Abhishek Arya.

Source/WebCore:

Test: fast/css-grid-layout/grid-strict-ordering-crash.html

• rendering/RenderGrid.cpp:

(WebCore::sortByGridTrackGrowthPotential):
The std::sort documentation says that this function should define a *strict* weak ordering. Fixed the strict
part of the ordering. Also moved the function definition next to where it is needed and made the GridTrack
argument const (as it shouldn't modify them or std::sort will misbehave).

• rendering/RenderGrid.cpp:

(WebCore::sortByGridTrackGrowthPotential):
(WebCore):

LayoutTests:

• fast/css-grid-layout/grid-strict-ordering-crash-expected.txt: Added.
• fast/css-grid-layout/grid-strict-ordering-crash.html: Added.

The test requires a column / row index above the Vector inline capacity to work (which is currently 16).
The values are much higher in case we decide to bump the inline capacity.

2:13 PM Changeset in webkit [141809] by mhahnenberg@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Objective-C API: testapi.mm should use ARC
​https://bugs.webkit.org/show_bug.cgi?id=107838

Reviewed by Oliver Hunt.

In ToT testapi.mm uses the Obj-C garbage collector, which hides a lot of our object lifetime bugs.
We should enable ARC, since that is what most of our clients will be using.

• API/tests/testapi.mm:

(-[TestObject init]):
(-[TestObject dealloc]):
(+[TestObject testObject]):
(testObjectiveCAPI):

• JavaScriptCore.xcodeproj/project.pbxproj:

2:02 PM Changeset in webkit [141808] by Bruno de Oliveira Abinader

• 2 edits in trunk/Tools

[EFL] Add "full screen" parameter to MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=108850

Reviewed by Antonio Gomes.

Implements the {-F,--full-screen}={true,false} parameter to WebKit EFL's
MiniBrowser.

• MiniBrowser/efl/main.c:

(window_create):
(elm_main):
Added '-F/--full-screen' parameter functionality.

1:49 PM Changeset in webkit [141807] by igor.o@sisa.samsung.com

• 2 edits in trunk/Source/WebCore

[Texmap] Implement BGRA swizzling detection
​https://bugs.webkit.org/show_bug.cgi?id=81103

For OpenGLES if the extension EXT_texture_format_BGRA8888 is supported
the internal and external formats need to be BGRA.

Reviewed by Noam Rosenthal.

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore):
(WebCore::driverSupportsExternalTextureBGRA):
(WebCore::driverSupportsSubImage):
(WebCore::BitmapTextureGL::didReset):

1:45 PM Changeset in webkit [141806] by commit-queue@webkit.org

• 5 edits in trunk

class="cue" is getting some default style
​https://bugs.webkit.org/show_bug.cgi?id=108752

Source/WebCore:

Patch by Dima Gorbik <​dgorbik@apple.com> on 2013-02-04
Reviewed by Dean Jackson.

The value variable inside the selector is used to store different information depending on the
type of the selector so we have to check explicitly that the selector we apply filtering to
matches a pseudo element.

Existing tests modified to cover this case.

• css/RuleSet.cpp:

(WebCore::determinePropertyWhitelistType):

LayoutTests:

Patch by Dima Gorbik <​dgorbik@apple.com> on 2013-02-04
Reviewed by Dean Jackson.

• media/track/track-css-property-whitelist-expected.txt:
• media/track/track-css-property-whitelist.html:

1:37 PM Changeset in webkit [141805] by mhahnenberg@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Objective-C API: ObjCCallbackFunction should retain the target of its NSInvocation
​https://bugs.webkit.org/show_bug.cgi?id=108843

Reviewed by Darin Adler.

Currently, ObjCCallbackFunction doesn't retain the target of its NSInvocation. It needs to do
this to prevent crashes when trying to invoke a callback later on.

• API/ObjCCallbackFunction.mm:

(ObjCCallbackFunction::ObjCCallbackFunction):
(ObjCCallbackFunction::~ObjCCallbackFunction):

1:34 PM Changeset in webkit [141804] by andersca@apple.com

• 15 edits in trunk/Source/WebKit2

Add didCloseOnConnectionWorkQueue to Connection::QueueClient
​https://bugs.webkit.org/show_bug.cgi?id=108853

Reviewed by Andreas Kling.

• Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::connectionDidClose):

• Platform/CoreIPC/Connection.h:

(QueueClient):

• Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::didCloseOnConnectionWorkQueue):

• Shared/mac/SecItemShim.h:

(SecItemShim):

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::didCloseOnConnectionWorkQueue):
(WebKit):

• UIProcess/Storage/StorageManager.h:

(StorageManager):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didCloseOnConnectionWorkQueue):
(WebKit):

• UIProcess/WebProcessProxy.h:

(WebProcessProxy):

• UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::didCloseOnConnectionWorkQueue):

• UIProcess/mac/SecItemShimProxy.h:

(SecItemShimProxy):

• WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::didCloseOnConnectionWorkQueue):
(WebKit):

• WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didCloseOnConnectionWorkQueue):
(WebKit):

• WebProcess/WebProcess.h:

(WebProcess):

1:31 PM Changeset in webkit [141803] by tsepez@chromium.org

• 2 edits in trunk/Source/WebCore

[V8] Binding Integrity crash in V8HTMLEmbedElement::createWrapper
​https://bugs.webkit.org/show_bug.cgi?id=108841

Reviewed by Adam Barth.

• html/HTMLEmbedElement.idl:

Quick change to IDL to disable binding check for now.

1:29 PM Changeset in webkit [141802] by jberlin@webkit.org

• 2 edits in trunk/LayoutTests

[WK2] [Mac] Support drag in mouse events for WebKit2 EventSender
​https://bugs.webkit.org/show_bug.cgi?id=68552

Skip another test that depends on setting eventSender.dragMode.

• platform/wk2/TestExpectations:

1:29 PM Changeset in webkit [141801] by jberlin@webkit.org

• 2 edits in trunk/LayoutTests

Out-of-view check of fixed position element in frame might still be incorrect on Mac when
page is scaled
​https://bugs.webkit.org/show_bug.cgi?id=105049

These tests have started passing all the time on all the Lion and Mountain Lion Debug and
Release WK1 and WK2 testers. Remove the failing expectation.

• platform/mac/TestExpectations:

1:28 PM Changeset in webkit [141800] by Martin Robinson

• 9 edits in trunk/Source

Fix GTK+ 'make dist' in preparation for the 1.11.5 release.

Source/JavaScriptCore:

• GNUmakefile.list.am: Update the source lists.

Source/WebCore:

• GNUmakefile.list.am:

Source/WebKit2:

• GNUmakefile.am:
• GNUmakefile.list.am:

Source/WTF:

• GNUmakefile.list.am:

1:22 PM Changeset in webkit [141799] by enrica@apple.com

• 11 edits in trunk/Source

Add specific EditActions for Bold and Italic commands.
​https://bugs.webkit.org/show_bug.cgi?id=108842.
<rdar://problem/13098252>

Source/WebCore:

This change is required on iOS where we need to
identify the command in order to display the correct
message in the undo popup. It is also in line with
what we do for underline, which already has its own
separate EditAction.

Reviewed by Ryosuke Niwa.

No new tests. No behavior change.

• editing/EditAction.h:
• editing/EditorCommand.cpp:

(WebCore::executeToggleBold):
(WebCore::executeToggleItalic):

Source/WebKit/mac:

Reviewed by Ryosuke Niwa.

• WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):

Source/WebKit/qt:

Reviewed by Ryosuke Niwa.

• WebCoreSupport/UndoStepQt.cpp:

(undoNameForEditAction):

Source/WebKit/win:

Reviewed by Ryosuke Niwa.

• WebCoreSupport/WebEditorClient.cpp:

(undoNameForEditAction):

Source/WebKit2:

Reviewed by Ryosuke Niwa.

• UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::nameForEditAction):

1:15 PM Changeset in webkit [141798] by cevans@google.com

• 2 edits
  2 copies in branches/chromium/1364

Merge 141127
BUG=172814
Review URL: ​https://codereview.chromium.org/12183027

1:12 PM Changeset in webkit [141797] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry]Adjust fatfinger detection rect size
​https://bugs.webkit.org/show_bug.cgi?id=108678

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-02-04
Reviewed by Antonio Gomes.
RIM Bug 246976

We still need to clip the fatfinger detection rect to the viewport to
avoid wrong hitTest result.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::mouseEvent):

• WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getNodesFromRect):

1:11 PM Changeset in webkit [141796] by andersca@apple.com

• 4 edits in trunk/Source/WebKit2

Use a separate queue for the connection watchdog callback in the web process
​https://bugs.webkit.org/show_bug.cgi?id=108844

Reviewed by Andreas Kling.

Don't pass the connection work queue to the didCloseOnConnectionWorkQueue callback.
Instead, create a new, temporary work queue where the exit call will be dispatched to.

• Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::connectionDidClose):

• Platform/CoreIPC/Connection.h:

(Connection):

• Shared/ChildProcess.cpp:

(WebKit::didCloseOnConnectionWorkQueue):

1:00 PM Changeset in webkit [141795] by commit-queue@webkit.org

• 6 edits in trunk

Implemet :lang() pseudo class support for the WebVTT ::cue pseudo element
​https://bugs.webkit.org/show_bug.cgi?id=105478

Patch by Dima Gorbik <​dgorbik@apple.com> on 2013-02-04
Reviewed by Antti Koivisto.

Source/WebCore:

In WebVTT lang is preprocessed and stored in the lang attribute of the element,
so we access it instead of walking up the tree the way it is done in HTML.

Existing tests were modified to cover this case.

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

LayoutTests:

• media/track/captions-webvtt/styling-lang.vtt:
• media/track/track-css-matching-lang-expected.txt:
• media/track/track-css-matching-lang.html:

12:40 PM Changeset in webkit [141794] by cevans@google.com

• 2 edits
  2 copies in branches/chromium/1364

Merge 140975
BUG=167728
Review URL: ​https://codereview.chromium.org/12194024

12:37 PM Changeset in webkit [141793] by cevans@google.com

• 2 edits
  2 copies in branches/chromium/1364

Merge 141198
BUG=171830
Review URL: ​https://codereview.chromium.org/12178024

12:30 PM Changeset in webkit [141792] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Disable autoscrolling the main frame if main frame scrolling is disabled
​https://bugs.webkit.org/show_bug.cgi?id=108848
<rdar://problem/13004059>

Reviewed by Simon Fraser.

Ensure that the main frame can scroll at all before allowing an autoscroll.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::canAutoscroll):

11:48 AM Changeset in webkit [141791] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

XSS Auditor bypass via svg tags and xlink:href
​https://bugs.webkit.org/show_bug.cgi?id=84158

Source/WebCore:

This patch adds a test for the xlink:href attribute inside of
script tokens. The test is complicated by the namespacing; the
xlink hrefAttr qualified name does not contain a literal "xlink"
prefix but only the URI of the namespace.

Patch by Tom Sepez <​tsepez@chromiium.org> on 2013-02-04
Reviewed by Adam Barth.

Test: http/tests/security/xssAuditor/svg-script-tag.html

• html/parser/XSSAuditor.cpp:

(WebCore::findAttributeWithName):
(WebCore::XSSAuditor::filterScriptToken):

LayoutTests:

Patch by Tom Sepez <​tsepez@chromiium.org> on 2013-02-04
Reviewed by Adam Barth.

• http/tests/security/xssAuditor/svg-script-tag-expected.txt: Added.
• http/tests/security/xssAuditor/svg-script-tag.html: Added.

11:39 AM Changeset in webkit [141790] by eric.carlson@apple.com

• 10 edits in trunk/Source/WebCore

Update CaptionUserPreferences
​https://bugs.webkit.org/show_bug.cgi?id=108783

Reviewed by Dean Jackson.

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Mark font size as important

when necessary.

• page/CaptionUserPreferences.h:

(WebCore::CaptionUserPreferences::setUserPrefersCaptions): New, allow a port to remember that

the user has chosen to see captions.

(WebCore::CaptionUserPreferences::setPreferredLanguage): New, allow a port to remember the

user's preferred caption language.

(WebCore::CaptionUserPreferences::preferredLanguages): New, return a Vector of the user's

preferred caption languages.

• page/CaptionUserPreferencesMac.h:
• page/CaptionUserPreferencesMac.mm:
• page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferences):
(WebCore::PageGroup::captionFontSizeScale):

• page/PageGroup.h:
• platform/Language.cpp:

(WebCore::userPreferredLanguagesOverride): New, return the user preferred languages override

used during testing.

• platform/Language.h:
• platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::kind):

11:26 AM Changeset in webkit [141789] by timothy_horton@apple.com

• 6 edits in trunk/Source

Allow TiledCoreAnimationDrawingArea overlay layers to become tiled
​https://bugs.webkit.org/show_bug.cgi?id=108729
<rdar://problem/13047546>

Reviewed by Anders Carlsson.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea): Add didCommitChangesForLayer and storage for the
current PlatformLayer corresponding to m_pageOverlayLayer.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers): Update the TileCache's visible rect.
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect): Forward exposed rect changes to the page overlay layer, if it's tiled.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged): Forward scrollability changes to the page overlay layer, if it's tiled.
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer): Allow the page overlay layer to become tiled. Update its exposed rect and whether or not it respects the exposed rect if it's tiled upon creation.
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer): If a GraphicsLayer's platform layer changes (because it switched to or from a tiled layer), reparent it. If it's switching to a tiled layer, update the exposed rect and whether or not it should respect the exposed rect.

• WebCore.exp.in:
• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly): The "for this layer only" variant
of flushCompositingState wasn't informing its client that it committed changes for the layer.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): We now explicitly want to be able to have a
GraphicsLayerCA switch into or out of tiling while being unparented (we'll get a client callback and
swap out its parent ourselves).

11:18 AM Changeset in webkit [141788] by msaboff@apple.com

• 7 edits in trunk/Source/JavaScriptCore

For ARMv7s use integer divide instruction for divide and modulo when possible
​https://bugs.webkit.org/show_bug.cgi?id=108840

Reviewed in person by Filip Pizlo.

Added ARMv7s integer divide path for ArithDiv and ArithMod where operands and results are integer.
This is patterned after the similar code for X86. Also added modulo power of 2 optimization
that uses logical and. Added sdiv and udiv to the ARMv7 disassembler. Put all the changes
behind #if CPU(APPLE_ARMV7S).

• assembler/ARMv7Assembler.h:

(ARMv7Assembler):
(JSC::ARMv7Assembler::sdiv):
(JSC::ARMv7Assembler::udiv):

• dfg/DFGCommon.h:

(JSC::DFG::isARMv7s):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForARMv7s):

• dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:14 AM Changeset in webkit [141787] by jchaffraix@webkit.org

• 13 edits
  2 adds in trunk

[CSS Grid Layout] Add parsing for grid-auto-flow
​https://bugs.webkit.org/show_bug.cgi?id=108397

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-auto-flow-get-set.html

This change adds the parsing, application and conversion back through getComputedStyle
for the new property -webkit-grid-auto-flow, which accpets the following:

-webkit-grid-auto-flow: none | rows | columns

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Added code to convert the RenderStyle information back into a CSS value.

• css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
Implemented parsing for -webkit-grid-auto-flow.

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator GridAutoFlow):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Added the conversion operators, used for parsing and getComputedStyle.

• css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):
Added -webkit-grid-auto-flow to the list of the not inherited properties.

• css/CSSPropertyNames.in:

Added the new value and keywords.

• css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):
Added a handler for the new CSS property.

• rendering/style/RenderStyle.h:

Added the usual getter / setter / initial function.

• rendering/style/RenderStyleConstants.h:

Added a new enum GridAutoFlow to hold the parsed value.

• rendering/style/StyleGridData.cpp:

(WebCore::StyleGridData::StyleGridData):

• rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator==):
Updated after adding a new field for the GridAutoFlow value.

LayoutTests:

• fast/css-grid-layout/grid-auto-flow-get-set-expected.txt: Added.
• fast/css-grid-layout/grid-auto-flow-get-set.html: Added.
• fast/css-grid-layout/resources/grid.css:

(.gridAutoFlowNone):
(.gridAutoFlowColumn):
(.gridAutoFlowRow):
Added these new classes to our common style.

11:01 AM Changeset in webkit [141786] by ddkilzer@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Check PrivateHeaders/JSBasePrivate.h for inappropriate macros
<​http://webkit.org/b/108749>

Reviewed by Joseph Pecoraro.

• JavaScriptCore.xcodeproj/project.pbxproj: Add

PrivateHeaders/JSBasePrivate.h to list of headers to check in
"Check for Inappropriate Macros in External Headers" build phase
script.

10:59 AM Changeset in webkit [141785] by jochen@chromium.org

• 5 edits
  1 move
  1 add
  1 delete in trunk/Tools

[chromium] remove WebTestPlugin from the public TestRunner API
​https://bugs.webkit.org/show_bug.cgi?id=108467

Reviewed by Adam Barth.

• DumpRenderTree/DumpRenderTree.gypi:
• DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h: Removed.
• DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::createPlugin):

• DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp.

(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner):
(WebTestRunner::TestPlugin::~TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::updateGeometry):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::parseOpacity):
(WebTestRunner::TestPlugin::parseBoolean):
(WebTestRunner::TestPlugin::initScene):
(WebTestRunner::TestPlugin::drawScene):
(WebTestRunner::TestPlugin::destroyScene):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleInputEvent):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
(WebTestRunner::TestPlugin::create):
(WebTestRunner::TestPlugin::mimeType):

• DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Added.

(WebTestRunner):
(TestPlugin):
(WebTestRunner::TestPlugin::scriptableObject):
(WebTestRunner::TestPlugin::canProcessDrag):
(WebTestRunner::TestPlugin::paint):
(WebTestRunner::TestPlugin::updateFocus):
(WebTestRunner::TestPlugin::updateVisibility):
(WebTestRunner::TestPlugin::acceptsInputEvents):
(WebTestRunner::TestPlugin::didReceiveResponse):
(WebTestRunner::TestPlugin::didReceiveData):
(WebTestRunner::TestPlugin::didFinishLoading):
(WebTestRunner::TestPlugin::didFailLoading):
(WebTestRunner::TestPlugin::didFinishLoadingFrameRequest):
(WebTestRunner::TestPlugin::didFailLoadingFrameRequest):
(WebTestRunner::TestPlugin::isPlaceholder):
(WebTestRunner::TestPlugin::prepareTexture):
(WebTestRunner::TestPlugin::context):
(Scene):
(WebTestRunner::TestPlugin::Scene::Scene):

• DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::createPlugin):
(WebTestRunner):

• DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createPlugin):

10:52 AM Changeset in webkit [141784] by pilgrim@chromium.org

• 8 edits
  1 copy
  1 move
  1 add in trunk/Source

[Chromium] Move IDBFactoryBackendInterface to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=108638

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

• Modules/indexeddb/chromium: Added.
• Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp: Added.

(WebCore):
(WebCore::setIDBFactoryBackendInterfaceCreateFunction):
(WebCore::IDBFactoryBackendInterface::create):

• Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h: Added.

(WebCore):

• WebCore.gyp/WebCore.gyp:
• WebCore.gypi:

Source/WebKit/chromium:

• WebKit.gyp:
• src/AssertMatchingEnums.cpp:
• src/IDBFactoryBackendInterface.cpp: Removed.
• src/IDBFactoryBackendProxy.h:
• src/WebKit.cpp:

(WebKit::initializeWithoutV8):

10:43 AM Changeset in webkit [141783] by inferno@chromium.org

• 45 edits in trunk/Source

Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
​https://bugs.webkit.org/show_bug.cgi?id=108688

Reviewed by Eric Seidel.

Source/WebCore:

• Modules/notifications/Notification.cpp:

(WebCore::Notification::Notification):
(WebCore::Notification::permission):
(WebCore::Notification::requestPermission):

• Modules/speech/SpeechGrammar.cpp:

(WebCore::SpeechGrammar::setSrc):

• Modules/speech/SpeechGrammarList.cpp:

(WebCore::SpeechGrammarList::addFromUri):

• Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::create):

• accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):

• accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::cellForColumnAndRow):

• css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::reattach):

• css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet):

• css/CSSPageRule.cpp:

(WebCore::CSSPageRule::reattach):

• css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::reattach):

• css/StyleBuilder.cpp:

(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):

• css/StyleResolver.cpp:

(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):

• css/WebKitCSSFilterRule.cpp:

(WebCore::WebKitCSSFilterRule::reattach):

• css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::reattach):

• css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::reattach):

• editing/EditCommand.h:

(WebCore::toSimpleEditCommand):

• editing/visible_units.cpp:

(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

• html/HTMLCollection.cpp:

(WebCore::LiveNodeListBase::setItemCache):

• loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):

• loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):

• page/Frame.cpp:

(WebCore::Frame::frameForWidget):

• platform/RefCountedSupplement.h:

(WebCore::RefCountedSupplement::from):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::firstLineBlock):

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::createLineBoxes):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

• rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::positionForPoint):

• rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):

• testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::resetInternalsObject):

• testing/v8/WebCoreTestSupport.cpp:

(WebCoreTestSupport::resetInternalsObject):

• workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::addToWorkerDocuments):
(WebCore::SharedWorkerConnectTask::performTask):

• workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

• workers/WorkerContext.cpp:

(WebCore::CloseWorkerContextTask::performTask):

• workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerContextTask::performTask):
(WebCore::connectToWorkerContextInspectorTask):
(WebCore::disconnectFromWorkerContextInspectorTask):
(WebCore::dispatchOnInspectorBackendTask):

• workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadSynchronously):

• workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):

Source/WebKit/blackberry:

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):

• WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):

Source/WebKit/chromium:

• src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIndexedDB):
(WebKit::getWebFrame):

• src/LocalFileSystemChromium.cpp:

(WebCore::LocalFileSystem::deleteFileSystem):

• src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::connectTask):
(WebKit::resumeWorkerContextTask):
(WebKit::connectToWorkerContextInspectorTask):
(WebKit::reconnectToWorkerContextInspectorTask):
(WebKit::disconnectFromWorkerContextInspectorTask):
(WebKit::dispatchOnInspectorBackendTask):

Source/WebKit/qt:

• WebCoreSupport/FrameLoaderClientQt.cpp:

10:35 AM Changeset in webkit [141782] by kov@webkit.org

• 2 edits in trunk/Source/WebKit/gtk

Made the documentation on the confirmed argument for the
WebView::script-confirm signal clearer about its type.

Reviewed by Martin Robinson.

• webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

10:34 AM Changeset in webkit [141781] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Use UNUSED_PARAM instead of C style comments.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::createStorageArea):

10:32 AM Changeset in webkit [141780] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] Stop using libsoup in ewk_url_scheme_request
​https://bugs.webkit.org/show_bug.cgi?id=108816

Patch by Christophe Dumez <​dchris@gmail.com> on 2013-02-04
Reviewed by Anders Carlsson.

As we are trying to minimize use of external dependencies in our WK2 EFL
API implementation, we should stop using libsoup in
ewk_url_scheme_request and use the WK2 C API instead.

• UIProcess/API/efl/ewk_url_scheme_request.cpp:

(EwkUrlSchemeRequest::EwkUrlSchemeRequest):

10:29 AM Changeset in webkit [141779] by kov@webkit.org

• 3 edits in trunk/Tools

Add a new method for obtaining a build-type-dependent path,
instead of modifying all call sites to pass it in.

Reviewed by Martin Robinson.

• Scripts/run-gtk-tests:

(TestRunner.init): use the new method, which takes a tuple.
(TestRunner._setup_testing_environment): ditto.

• gtk/common.py:

(get_build_path): accept a tuple that may include Release and
Debug as build types, for searching.
(build_path_for_build_types): new method that finds the path when
it is dependent on the build type.
(build_path): restore its original behaviour.

10:22 AM WebKitGTK/1.10.x edited by jdiggs@igalia.com

Add a new proposed item for 1.10.3 (diff)

10:21 AM Changeset in webkit [141778] by dominik.rottsches@intel.com

• 2 edits in trunk/Source/WebCore

[Skia] Argument to HarfBuzzShaper::offsetForPosition unnecessarily truncated
​https://bugs.webkit.org/show_bug.cgi?id=108479

Reviewed by Emil A Eklund.

Remove a FIXME that intended to solve the value truncation.
Should positively affect SVG text positioning.

No new tests, partially covered by manual test
ManualTests/harfbuzz-mouse-selection-crash.html.

• platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::Font::offsetForPositionForComplexText):

10:19 AM Changeset in webkit [141777] by commit-queue@webkit.org

• 26 edits in trunk

Web Inspector: Create a container class for SidebarPane instances
​https://bugs.webkit.org/show_bug.cgi?id=108183

Source/WebCore:

Patch by Vladislav Kaznacheev <​kaznacheev@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

SidebarPaneStack is responsible for pane title bar and expand/collapse behavior (previously handled by SidebarPane).
SidebarPanes are inserted into DOM lazily and can belong to more than one container.
SidebarPane is ready to be displayed in other types of containers (such as tabbed pane as requested in ​https://bugs.webkit.org/show_bug.cgi?id=107552).
There should be no visible changes except for one: DOM breakpoint pane expand/collapse state is no longer
shared between Elements and Sources sidebars.

• inspector/front-end/AuditResultView.js:

(WebInspector.AuditResultView):

• inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._addBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint):

• inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint):

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype.updateStyles):
(WebInspector.ElementsPanel.prototype.updateMetrics):
(WebInspector.ElementsPanel.prototype.updateProperties):
(WebInspector.ElementsPanel.prototype.updateEventListeners):

• inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionSidebarPane):

• inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.wasShown):

• inspector/front-end/SidebarPane.js:

(WebInspector.SidebarPane):
(WebInspector.SidebarPane.prototype.title):
(WebInspector.SidebarPane.prototype.prepareContent):
(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.onContentReady):
(WebInspector.SidebarPane.prototype.setExpandCallback):
(WebInspector.SidebarPane.prototype.setShowCallback):
(WebInspector.SidebarPane.prototype.wasShown):
(WebInspector.SidebarPaneStack):
(WebInspector.SidebarPaneStack.prototype.wasShown):
(WebInspector.SidebarPaneStack.prototype.addPane):
(WebInspector.SidebarPaneStack.prototype._addTitle):
(WebInspector.SidebarPaneStack.prototype._attachToPane):
(WebInspector.SidebarPaneStack.prototype._isExpanded):
(WebInspector.SidebarPaneStack.prototype._setExpanded):
(WebInspector.SidebarPaneStack.prototype._onPaneExpanded):
(WebInspector.SidebarPaneStack.prototype._collapsePane):
(WebInspector.SidebarPaneStack.prototype._togglePane):
(WebInspector.SidebarPaneStack.prototype._onTitleKeyDown):

• inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype.set _createNewRule):
(WebInspector.ComputedStyleSidebarPane.prototype.prepareContent):

• inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSidebarPane):
(WebInspector.WatchExpressionsSidebarPane.prototype.wasShown):
(WebInspector.WatchExpressionsSidebarPane.prototype.addExpression):
(WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):

• inspector/front-end/inspector.css:

(.pane-title + .pane-title, .pane:not(.visible) + .pane-title, .pane-title:first-of-type):
(.pane-title):
(.pane-title:active):
(.pane-title::before):
(.pane-title.expanded::before):
(.pane-title > select):
(.pane-title > select:hover):
(.pane-title > select:active):
(.pane-title > select.select-settings):
(.pane-title > select.select-filter):
(.pane-title > select > option, .pane-title > select > hr):
(.pane-title > .pane-title-button):
(.pane-title > .pane-title-button:hover):
(.pane-title > .pane-title-button:active, .pane-title > .pane-title-button.toggled):
(.pane-title > .pane-title-button.add):
(.pane-title > .pane-title-button.element-state):
(.pane-title > .pane-title-button.refresh):
(.pane.visible > .body):
(.pane.visible:nth-last-of-type(1)):
(.panel-enabler-view button:not(.status-bar-item), .pane-title-button, button.show-all-nodes):
(.panel-enabler-view button:active:not(.status-bar-item), .pane-title-button:active, button.show-all-nodes:active):
(body.inactive .panel-enabler-view button:not(.status-bar-item), .panel-enabler-view button:disabled:not(.status-bar-item), body.inactive .pane-title-button, .pane-title-button:disabled, body.inactive button.show-all-nodes):

LayoutTests:

Patch by Vladislav Kaznacheev <​kaznacheev@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

• http/tests/inspector/elements-test.js:

(initialize_ElementTest.stylesCallback):
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed):

• inspector/audits/audits-panel-functional-expected.txt:
• inspector/audits/audits-panel-noimages-functional-expected.txt:
• inspector/debugger/error-in-watch-expressions.html:
• inspector/debugger/properties-special.html:
• inspector/debugger/watch-expressions-panel-switch.html:
• inspector/debugger/watch-expressions-preserve-expansion.html:
• inspector/extensions/extensions-audits-api-expected.txt:
• inspector/extensions/extensions-audits-content-script-expected.txt:
• inspector/extensions/extensions-audits-expected.txt:
• inspector/extensions/extensions-events.html:
• inspector/extensions/extensions-sidebar.html:
• inspector/styles/lazy-computed-style.html:

10:14 AM Changeset in webkit [141776] by kadam@inf.u-szeged.hu

• 4 edits in trunk/LayoutTests

[Qt][Wk2] Unreviewed gardnening. Skip failing tests.

• platform/qt-5.0-wk2/TestExpectations:
• platform/qt-5.0-wk2/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Update after r141459.
• platform/qt-5.0-wk2/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Update after r141459.

9:45 AM Changeset in webkit [141775] by eae@chromium.org

• 5 edits in trunk/Source/WebCore

Remove duplicate code in RenderBoxModelObject::computedCSSPadding*
​https://bugs.webkit.org/show_bug.cgi?id=108707

Reviewed by Eric Seidel.

The computedCSSPaddingTop/Bottom/... methods in
RenderBoxModelObject all do pretty much exactly the same thing
yet share no code.

Break out shared code into computedCSSPadding method and have
the top/bottom/left/right/... ones call it with the appropriate
length value.

No new tests, no change in functionality.

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computedCSSPadding):

• rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
(RenderBoxModelObject):

9:42 AM Changeset in webkit [141774] by commit-queue@webkit.org

• 8 edits in trunk

Web Inspector: add round braces to javascript tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=108692

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

Source/WebCore:

Change SourceJavascriptTokenizer.re2js file to produce "brace-start"
and "brace-end" tokens for round braces.
Regenerate SourceJavascriptTokenizer.js according to new re2js file.

No new tests: no change in behaviour.

• inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):

• inspector/front-end/SourceJavaScriptTokenizer.re2js:

LayoutTests:

Updated test expectations to correspond to new tokens "brace-start"
and "brace-end" in javascript tokenizer.

• inspector/editor/highlighter-basics-expected.txt:
• inspector/editor/text-editor-long-line-expected.txt:
• inspector/syntax-highlight-html-expected.txt:
• inspector/syntax-highlight-javascript-expected.txt:

9:38 AM Changeset in webkit [141773] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Needs one-shot drawing synchronization flag should be set before rendering when resuming the backing store
​https://bugs.webkit.org/show_bug.cgi?id=108760

Patch by Andrew Lo <​anlo@rim.com> on 2013-02-04
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.

Internal PR 286218.
When acquiring the backing store ownership in WebPagePrivate::resumeBackingStore
we need to set the needs one-shot drawing synchronization flag
before rendering, so that when the render is completed we
commit the root layer.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):

8:42 AM Changeset in webkit [141772] by pfeldman@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: take page scale factor into account when updating overlay.
​https://bugs.webkit.org/show_bug.cgi?id=108831

Reviewed by Vsevolod Vlasov.

Otherwise, the ports that use page scale factor have broken overlay.

• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

7:56 AM Changeset in webkit [141771] by commit-queue@webkit.org

• 17 edits in trunk/Source/WebCore

[v8] explicit isolate parameter for MakeWeak calls
​https://bugs.webkit.org/show_bug.cgi?id=108818

Patch by Dan Carney <​dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

• bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::weakCallback):

• bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapper):
(WebCore::DOMDataStore::set):
(WebCore::DOMDataStore::setWrapperInObject):
(DOMDataStore):

• bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::DOMWrapperMap):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::defaultWeakCallback):
(DOMWrapperMap):

• bindings/v8/DOMWrapperWorld.cpp:

(WebCore::isolatedWorldWeakCallback):
(WebCore::DOMWrapperWorld::makeContextWeak):

• bindings/v8/ScriptState.cpp:

(WebCore::ScriptState::ScriptState):
(WebCore::ScriptState::weakReferenceCallback):

• bindings/v8/ScriptState.h:

(ScriptState):

• bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::weakEventListenerCallback):
(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::setListenerObject):

• bindings/v8/V8AbstractEventListener.h:

(V8AbstractEventListener):

• bindings/v8/V8EventListener.cpp:

(WebCore::V8EventListener::V8EventListener):

• bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):

• bindings/v8/V8MutationCallback.cpp:

(WebCore::V8MutationCallback::V8MutationCallback):

• bindings/v8/V8MutationCallback.h:

(WebCore::V8MutationCallback::create):
(WebCore::V8MutationCallback::weakCallback):

• bindings/v8/V8NPObject.cpp:

(WebCore::V8NPTemplateMap::set):
(WebCore::V8NPTemplateMap::sharedInstance):
(WebCore::V8NPTemplateMap::V8NPTemplateMap):
(V8NPTemplateMap):
(WebCore::V8NPTemplateMap::weakCallback):
(WebCore::npObjectGetProperty):
(WebCore):
(WebCore::staticNPObjectMap):
(WebCore::weakNPObjectCallback):

• bindings/v8/V8ValueCache.cpp:

(WebCore::cachedStringCallback):
(WebCore::StringCache::v8ExternalStringSlow):

• bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::WeakReferenceCallback):
(WebCore::createInjectedScriptHostV8Wrapper):

• bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallbackCustom):

7:00 AM Changeset in webkit [141770] by mikhail.pozdnyakov@intel.com

• 2 edits in trunk/Source/WebKit2

[WK2][EFL] Weird stripe at the end of the page
​https://bugs.webkit.org/show_bug.cgi?id=108820

Reviewed by Noam Rosenthal.

The page scroll bound was artificially enlarged by one causing the artifact appearance.

• UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::boundContentsPositionAtScale):

6:45 AM Changeset in webkit [141769] by commit-queue@webkit.org

• 15 edits
  1 move
  7 deletes in trunk

Disable -webkit-overflow-scrolling CSS attribute on Chromium
​https://bugs.webkit.org/show_bug.cgi?id=108020

Patch by Sami Kyostila <​skyostil@chromium.org> on 2013-02-04
Reviewed by James Robinson.

Now that we can automatically promote overflow elements to accelerated
scrolling layers there is no use for the -webkit-overflow-scrolling CSS
attribute any longer on Chromium.

Source/WebKit/chromium:

This patch enables composited overflow scrolling in
ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
in non-fast-scrollable.html to become composited, we also need to modify that
test to opt it out of composited scrolling.

• features.gypi:
• tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::TEST_F):

• tests/data/non-fast-scrollable.html:
• tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.

LayoutTests:

The following tests using -webkit-overflow-scroll are modified to also call
setAcceleratedCompositingForOverflowScrollEnabled(). This makes them test
meaningful things on also on platforms that do not support that CSS attribute.

• compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html:
• compositing/overflow/iframe-inside-overflow-clipping.html:
• compositing/overflow/nested-scrolling.html:
• compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html:
• compositing/overflow/scrolling-content-clip-to-viewport.html:
• compositing/overflow/scrolling-without-painting.html:
• compositing/overflow/textarea-scroll-touch.html:
• compositing/overflow/updating-scrolling-content.html:
• platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt: Removed.
• platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html: Removed.
• platform/chromium-linux/compositing/overflow/nested-scrolling-expected.png:
• platform/chromium/TestExpectations:
• platform/chromium/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.
• platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png: Removed.
• platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt: Removed.
• platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html: Removed.
• platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.

6:43 AM Changeset in webkit [141768] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Web Inspector: Allow user to change dock side by dragging toolbar
​https://bugs.webkit.org/show_bug.cgi?id=108073

Dragging toolbar to the right/bottom will change the dock side accordingly
instead of changing the inspector window height (if dock to right is available).

Patch by Dmitry Gozman <​dgozman@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

No new tests, because of pure inspector UI change.

• inspector/front-end/DockController.js:

(WebInspector.DockController.prototype.dockSide):

• inspector/front-end/Toolbar.js:

(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._isDockedToBottom):
(WebInspector.Toolbar.prototype._isUndocked):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDragEnd):
(WebInspector.Toolbar.prototype._toolbarDrag):
(WebInspector.Toolbar.prototype._toolbarDragMoveWindow):
(WebInspector.Toolbar.prototype._toolbarDragChangeDocking):
(WebInspector.Toolbar.prototype._toolbarDragChangeHeight):

• inspector/front-end/UIUtils.js:

(WebInspector._elementDragStart):
(WebInspector._elementDragMove):
(WebInspector._cancelDragEvents):
(WebInspector._elementDragEnd):

6:35 AM Changeset in webkit [141767] by kadam@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipping failing tests.

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2013-02-04

• platform/qt/TestExpectations:

6:23 AM Changeset in webkit [141766] by caseq@chromium.org

• 4 edits in trunk

Web Inspector: sync list of console API methods to that used by auto-complete
​https://bugs.webkit.org/show_bug.cgi?id=108804

Reviewed by Pavel Feldman.

• push new method names from InjectedScriptSource to RuntimeModel;
• add a comment to InjectedScriptSource noting the necessity of keeping lists in sync.

• inspector/InjectedScriptSource.js:
• inspector/front-end/RuntimeModel.js:

(WebInspector.RuntimeModel.prototype.receivedPropertyNames):
(WebInspector.RuntimeModel.prototype._completionsForExpression):

6:08 AM Changeset in webkit [141765] by caseq@chromium.org

• 3 edits in trunk/Source/WebCore

Web Inspector: [Network] Minor refactorings.
​https://bugs.webkit.org/show_bug.cgi?id=108162

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-02-04
Reviewed by Vsevolod Vlasov.

Apply minor refactorings to NetworkPanel.js
Add hint to statusbar selector buttons.

• English.lproj/localizedStrings.js: Added hint string.
• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createStatusBarItems): Ditto.
(WebInspector.NetworkLogView.prototype._makeHeaderFragment):
Applied minor refactoring.
(WebInspector.NetworkLogView.prototype._createStatusBarItems.createFilterElement):
Ditto.
(WebInspector.NetworkLogView.prototype._updateOffscreenRows): Ditto.
(WebInspector.NetworkPanel.prototype._onRowSizeChanged): Ditto.

5:55 AM Changeset in webkit [141764] by caseq@chromium.org

• 6 edits in trunk/Source/WebCore

Web Inspector: [CPU Profile] Apply minor refactorings and add JSDocs.
​https://bugs.webkit.org/show_bug.cgi?id=108437

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

CPU Profile code has obsolete inline-comments to clarify types.
Currently we use JSDocs to specify types.

Also applied some minor refactorings.

• inspector/front-end/BottomUpProfileDataGridTree.js:

(WebInspector.BottomUpProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
Added JSDocs.
(WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
Ditto.
(WebInspector.BottomUpProfileDataGridNode.prototype._merge):
Ditto.
(WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
Do not pass profileView to constructor.
(WebInspector.BottomUpProfileDataGridTree):
Added JSDocs. Renamed parameters.
(WebInspector.BottomUpProfileDataGridTree.prototype.focus):
Added JSDocs.
(WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
Ditto.

• inspector/front-end/CPUProfileView.js: Removed unused getter/setter.

(WebInspector.CPUProfileView.prototype._getCPUProfileCallback):
Un-nested. Added JSDocs.
(WebInspector.CPUProfileView.prototype._getBottomUpProfileDataGridTree):
Added JSDocs. Turned to method from getter. Simplified.
(WebInspector.CPUProfileView.prototype._getTopDownProfileDataGridTree):
Added JSDocs. Turned to method from getter.
(WebInspector.CPUProfileView.prototype._assignParentsInProfile):
Optimized.

• inspector/front-end/DataGrid.js: Added JSDocs.
• inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.ProfileDataGridNode.prototype.createCell): Added JSDocs.
(WebInspector.ProfileDataGridNode.prototype.sort): Ditto.
(WebInspector.ProfileDataGridNode.prototype.insertChild): Ditto.
(WebInspector.ProfileDataGridNode.prototype.removeChild): Ditto.
(WebInspector.ProfileDataGridNode.prototype.removeChildren):
Added JSDocs. Removed parameter.
(WebInspector.ProfileDataGridNode.prototype.findChild): Added JSDocs.
(WebInspector.ProfileDataGridTree): Added JSDocs. Renamed parameter.

• inspector/front-end/TopDownProfileDataGridTree.js:

(WebInspector.TopDownProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
Do not pass profileView to constructor.
(WebInspector.TopDownProfileDataGridTree):
Added JSDocs. Renamed parameter.
(WebInspector.TopDownProfileDataGridTree.prototype.focus):
Added JSDocs.
(WebInspector.TopDownProfileDataGridTree.prototype.exclude):
Ditto.

5:48 AM Changeset in webkit [141763] by commit-queue@webkit.org

• 24 edits in trunk/Source/WebCore

[v8] use toV8Fast in hand coded callbacks
​https://bugs.webkit.org/show_bug.cgi?id=108817

Patch by Dan Carney <​dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

• bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):

• bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

• bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):

• bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):

• bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAccessorGetter):

• bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore):
(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
(WebCore::V8HTMLAllCollection::itemCallback):
(WebCore::V8HTMLAllCollection::namedItemCallback):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):

• bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

• bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

• bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::V8HTMLElement::itemValueAccessorGetter):

• bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:

(WebCore):
(WebCore::getNamedItems):
(WebCore::V8HTMLFormControlsCollection::namedPropertyGetter):
(WebCore::V8HTMLFormControlsCollection::namedItemCallback):

• bindings/v8/custom/V8HTMLFormElementCustom.cpp:

(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):

• bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

• bindings/v8/custom/V8HTMLLinkElementCustom.cpp:

(WebCore::V8HTMLLinkElement::sizesAccessorGetter):

• bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore):
(WebCore::getNamedItems):
(WebCore::V8HTMLOptionsCollection::namedPropertyGetter):
(WebCore::V8HTMLOptionsCollection::namedItemCallback):
(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):

• bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::indexedPropertyGetter):

• bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):

• bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):

• bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

• bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter):

• bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

• bindings/v8/custom/V8StyleSheetListCustom.cpp:

(WebCore::V8StyleSheetList::namedPropertyGetter):

• bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAccessorGetter):

• bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseAccessorGetter):

4:44 AM Changeset in webkit [141762] by ddkilzer@apple.com

• 2 edits in trunk/Tools

Remove duplicate entry from DumpRenderTree Xcode project

$ uniq Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj | diff -u - Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj | patch -p0 -R
patching file Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Remove duplicate.

4:41 AM Changeset in webkit [141761] by ddkilzer@apple.com

• 2 edits in trunk/Tools

Sort TestWebKitAPI Xcode project file

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

4:36 AM Changeset in webkit [141760] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebKit2

Sort WebKit2 Xcode project file

• WebKit2.xcodeproj/project.pbxproj:

4:32 AM Changeset in webkit [141759] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

Remove duplicate entry from WebCore Xcode project

$ uniq Source/WebCore/WebCore.xcodeproj/project.pbxproj | diff -u - Source/WebCore/WebCore.xcodeproj/project.pbxproj | patch -p0 -R
patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj

• WebCore.xcodeproj/project.pbxproj: Remove duplicate.

4:30 AM Changeset in webkit [141758] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

Sort WebCore Xcode project file

• WebCore.xcodeproj/project.pbxproj:

4:26 AM Changeset in webkit [141757] by ddkilzer@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Remove duplicate entries from JavaScriptCore Xcode project

$ uniq Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj | diff -u - Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj | patch -p0 -R
patching file Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

• JavaScriptCore.xcodeproj/project.pbxproj: Remove duplicates.

4:21 AM Changeset in webkit [141756] by Simon Hausmann

• 3 edits in trunk/Source/WebKit2

[WK2][Qt] Replace WebPageGroup usage for user scripts with WKPageGroupRef
​https://bugs.webkit.org/show_bug.cgi?id=108651

Reviewed by Sam Weinig.

It's straight-forward port towards the C API.

• UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(readUserScript):
(QQuickWebViewPrivate::updateUserScripts):

• UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

4:21 AM Changeset in webkit [141755] by ddkilzer@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Sort JavaScriptCore Xcode project file

• JavaScriptCore.xcodeproj/project.pbxproj:

4:14 AM Changeset in webkit [141754] by ddkilzer@apple.com

• 2 edits in trunk/Source/WTF

Sort WTF Xcode project file

• WTF.xcodeproj/project.pbxproj:

4:13 AM Changeset in webkit [141753] by ddkilzer@apple.com

• 2 edits in trunk/Source/ThirdParty/ANGLE

Sort ANGLE Xcode project file.

• ANGLE.xcodeproj/project.pbxproj:

3:34 AM Changeset in webkit [141752] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[v8] disable ascii check once latin-1 is enabled in v8
​https://bugs.webkit.org/show_bug.cgi?id=108805

Patch by Dan Carney <​dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

• bindings/v8/V8ValueCache.cpp:

(WebCore::makeExternalString):

2:46 AM Changeset in webkit [141751] by pfeldman@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: make tabbed pane header a relayout boundary.
​https://bugs.webkit.org/show_bug.cgi?id=108650

Reviewed by Alexander Pavlov.

Otherwise, its measure width routine causes total reflow.

• inspector/front-end/tabbedPane.css:

(.tabbed-pane-header):

2:27 AM Changeset in webkit [141750] by hayato@chromium.org

• 9 edits
  2 adds in trunk/Source/WebCore

Split InspectorCSSOMWrappers out from StyleResolver.h into its own file.
​https://bugs.webkit.org/show_bug.cgi?id=108797

Reviewed by Hajime Morita.

This is a following patch after r141373. Now we can have
InspectorCSSOMWrappers in its own file since CSSDefaultStyleSheets
was factored out from StyleResolver.cpp in r141733.

WebCore/inspector/ directory is used for basic inspector
functionalities. Therefore, I've put
InspectorCSSOMWrappers.{h,cpp} in WebCore/css/ rather than
WebCore/inspector/.

No new tests, refactoring only.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gypi:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSAllInOne.cpp:
• css/InspectorCSSOMWrappers.cpp: Added.

(WebCore):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetIfNeeded):
(WebCore::InspectorCSSOMWrappers::collect):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets):
(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
(WebCore::InspectorCSSOMWrappers::reportMemoryUsage):

• css/InspectorCSSOMWrappers.h: Added.

(WebCore):
(InspectorCSSOMWrappers):

• css/StyleResolver.cpp:
• css/StyleResolver.h:

1:33 AM Changeset in webkit [141749] by kbalazs@webkit.org

• 21 edits
  1 add in trunk/Source

[Soup] Wrap SoupSession by NetworkStorageSession
​https://bugs.webkit.org/show_bug.cgi?id=108615

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Implement NetworkStorageSession for ports using soup. It has been
separated from NetworkingContext, so now we have a default storage
session, which is the same as before but now wrapped with NetworkStorageSession,
and it can be overridden by the networking context.

No change in behavior so no new tests.

• CMakeLists.txt:
• GNUmakefile.list.am:
• PlatformBlackBerry.cmake:
• PlatformEfl.cmake:
• loader/CookieJar.cpp:

(WebCore):
Now we also get the storage session from the networking context
and not the other way.

• platform/network/NetworkStorageSession.h:

(NetworkStorageSession):
(WebCore::NetworkStorageSession::setSoupSession):
(WebCore::NetworkStorageSession::soupSession):
Hold a SoupSession pointer for ports using soup. Added a setter because it is
necessary for API's that allow it to be specified per page, like EFL WK1.

• platform/network/NetworkingContext.h:

(NetworkingContext):

• platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookieJarForSession):

• platform/network/soup/NetworkStorageSessionSoup.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp.

(WebCore::NetworkStorageSession::NetworkStorageSession):
(WebCore::NetworkStorageSession::defaultStorageSession):
(WebCore::NetworkStorageSession::createDefaultSession):
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sessionFromContext):

• CMakeLists.txt:
• GNUmakefile.list.am:
• PlatformBlackBerry.cmake:
• PlatformEfl.cmake:
• loader/CookieJar.cpp:

(WebCore):

• platform/network/NetworkStorageSession.h:

(NetworkStorageSession):
(WebCore::NetworkStorageSession::setSoupSession):
(WebCore::NetworkStorageSession::soupSession):

• platform/network/NetworkingContext.h:

(NetworkingContext):

• platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookieJarForSession):

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sessionFromContext):

Source/WebKit/efl:

Changed to hold the SoupSession pointer in a NetworkStorageSession
so we can pass it to WebCore. _Ewk_View_Private_Data has to be
changed for that reason.

• WebCoreSupport/FrameNetworkingContextEfl.cpp:

(WebCore::FrameNetworkingContextEfl::storageSession):

• WebCoreSupport/FrameNetworkingContextEfl.h:

(FrameNetworkingContextEfl):

• ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):
(EWKPrivate::storageSession):
(EWKPrivate):

• ewk/ewk_view_private.h:

(EWKPrivate):

Source/WebKit/gtk:

• WebCoreSupport/FrameNetworkingContextGtk.cpp:

(WebKit::FrameNetworkingContextGtk::storageSession):

• WebCoreSupport/FrameNetworkingContextGtk.h:

(FrameNetworkingContextGtk):

Source/WebKit2:

• WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::storageSession):

• WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext):

1:08 AM Changeset in webkit [141748] by tkent@chromium.org

• 16 edits
  3 deletes in trunk/LayoutTests

[Chromium] Rebaseline for r141741
​https://bugs.webkit.org/show_bug.cgi?id=108791

• platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
• platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
• platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
• platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
• platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
• platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: Removed.
• platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
• platform/chromium-win-xp/fast/forms/datetime/datetime-appearance-l10n-expected.png:
• platform/chromium-win-xp/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt: Removed.
• platform/chromium-win-xp/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
• platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
• platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Removed.
• platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
• platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
• platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
• platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
• platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
• platform/chromium/TestExpectations:

1:01 AM Changeset in webkit [141747] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Web Inspector: source location in statusbar has few bugs in it
​https://bugs.webkit.org/show_bug.cgi?id=108748

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-02-04
Reviewed by Vsevolod Vlasov.

Call super method statusBarItems in SnippetJavaScriptSourceFrame class
and merge its results. Fix css styles for source location in statusbar
and rename its css class into a less confusing name.

No new test: no change in behaviour.

• inspector/front-end/SnippetJavaScriptSourceFrame.js:

(WebInspector.SnippetJavaScriptSourceFrame.prototype.statusBarItems):

• inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):

• inspector/front-end/inspector.css:

(.source-frame-cursor-position):

12:26 AM Changeset in webkit [141746] by mkwst@chromium.org

• 2 edits in trunk/Source/WebCore

Cleanup: Normalize usage of ExceptionCode in ContainerNode::checkXxxChild()
​https://bugs.webkit.org/show_bug.cgi?id=108766

Reviewed by Kentaro Hara.

This patch refactors checkAddChild and checkReplaceChild to remove the
creation of an extra ExceptionCode that's not necessary for the
desired behavior, and to bring the ExceptionCode usage into line with
the rest of WebKit (this was the only case where ExceptionCode was
assigned inside an 'if' statement's condition).

After this patch, 'ec' will always be assigned a value, even if the
result of 'checkAcceptChild' is 0. This would only change behavior if
'ec' was non-zero coming into the function, and 'checkAcceptChild'
returned 0. Since every callsite is either directly after an explicit
zeroing of 'ec', or after an 'if (ec)' clause, that case should never
appear. This patch, therefore, shouldn't visibly change WebKit's
behavior.

• dom/ContainerNode.cpp:

(WebCore::checkAddChild):
(WebCore::checkReplaceChild):

Feb 3, 2013:

11:44 PM Changeset in webkit [141745] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL][WK2] Mark fast/dom/DOMImplementation/createDocument-with-used-doctype.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=108793

Unreviewed EFL gardening.

Mark fast/dom/DOMImplementation/createDocument-with-used-doctype.html as
flaky due to Bug 108058. It sometimes crashes on the bots.

Patch by Christophe Dumez <​dchris@gmail.com> on 2013-02-03

• platform/efl-wk2/TestExpectations:

11:16 PM Changeset in webkit [141744] by ddkilzer@apple.com

• 8 edits in trunk/Source

Upstream ENABLE_PDFKIT_PLUGIN settting
<​http://webkit.org/b/108792>

Reviewed by Tim Horton.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN

on iOS since PDFKit is a Mac-only framework.

Source/WebCore:

• Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN

on iOS since PDFKit is a Mac-only framework.

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN

on iOS since PDFKit is a Mac-only framework.

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN

on iOS since PDFKit is a Mac-only framework.

11:14 PM Changeset in webkit [141743] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

Silently block one more directory needed for NSApplication initialization.

Reviewed by Sam Weinig.

• WebProcess/com.apple.WebProcess.sb.in:

11:02 PM Changeset in webkit [141742] by tasak@google.com

• 4 edits in trunk/Source/WebCore

Split per-resolve logic out from StyleResolver.
​https://bugs.webkit.org/show_bug.cgi?id=96421

Reviewed by Eric Seidel.

Implemented class StyleResolver::State and added m_state to
StyleResolver. All member variables used for per-resolve logic are
moved into the state class.

No new tests, because just refactoring.

• css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

• css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::initForStyleResolve):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::cacheBorderAndBackground):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::useSVGZoomRules):
(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackMinMax):
(WebCore::createGridTrackGroup):
(WebCore::createGridTrackList):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
(WebCore::StyleResolver::reportMemoryUsage):

• css/StyleResolver.h:

(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::setWritingMode):
(WebCore::StyleResolver::setTextOrientation):
(WebCore::StyleResolver::hasParentNode):
(WebCore::StyleResolver::addMatchedRule):
(StyleResolver):
(State):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
Added "m_state." to access member variables used for per-resolve logic.

10:58 PM Changeset in webkit [141741] by tkent@chromium.org

• 4 edits in trunk

Support setLangAttributeAwareFormControlUIEnabled on Chromium Windows XP
​https://bugs.webkit.org/show_bug.cgi?id=108791

Reviewed by Kentaro Hara.

Source/WebCore:

We didn't support setLangAttributeAwareFormControlUIEnabled(true) on
Chromium Windows XP because of lack of LocaleNameToLCID API. This change
add manual mapping from locale names to LCIDs for Windows XP.

No new tests. This doesn't make any behavior changes in products, and
this improves some test results.

• platform/text/win/LocaleWin.cpp:

(WebCore): Define NameToLCIDMap.
(WebCore::removeLastComponent):
Remove the last component separated with '-'.
(WebCore::ensureNameToLCIDMap):
Add locale names used in layout tests.
(WebCore::convertLocaleNameToLCID):
Find an appropriate LCID longest matching with the specified locale name.
(WebCore::LCIDFromLocale):
Use convertLocaleNameToLCID if LocaleNameToLCID is not available.

LayoutTests:

• platform/chromium/TestExpectations:

Mark affected tests failure.
Actually we should be able to remove XP-specific test results for
them. We just mark them in this patch just in case, and do rebaseline
later.

10:17 PM Changeset in webkit [141740] by morrita@google.com

• 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking some as timing out.

• platform/chromium/TestExpectations:

10:16 PM Changeset in webkit [141739] by commit-queue@webkit.org

• 3 edits in trunk/Tools

PatchLogs are not getting created on QueueStatusServer
​https://bugs.webkit.org/show_bug.cgi?id=108593

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-02-03
Reviewed by Eric Seidel.

Added missing "added" patch event to submit-to-ews handler.

• QueueStatusServer/app.yaml:
• QueueStatusServer/handlers/submittoews.py:

(SubmitToEWS._add_attachment_to_ews_queues):

10:11 PM Changeset in webkit [141738] by tkent@chromium.org

• 24 edits in trunk/Source/WebCore

Add FocusDirection argument to HTMLTextFormControlElement::handleFocusEvent
​https://bugs.webkit.org/show_bug.cgi?id=108775

Reviewed by Hajime Morita.

We'd like to add a FocusDirection argument to
HTMLTextFormControlElement::handleFocusEvent in order to fix Bug

108447. This is a preparation for it.

We need to add FocusDirection arguments to some focus-related functions
to pass it correctly when TAB or Shift+TAB is pressed.

No new tests. This doesn't make any behavior changes.

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
To pass the FocusDirection argument to handleFocusEvent, we need to add
it to dispatchFocusEvent too.

• html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):
Add FocusDirection arugment to dispatchFocusEvent.
(WebCore::HTMLTextFormControlElement::handleFocusEvent):
Add FocusDirection argument.

• dom/Node.cpp:

(WebCore::Node::dispatchFocusEvent): Add FocusDirection argument.

• dom/Node.h:

(Node): Ditto.

• dom/Document.cpp:

(WebCore::Document::setFocusedNode): Add FocusDirection argument in
order to pass it to Node::dispatchFocusEvent.

• dom/Document.h:

(Document): Ditto.

• page/FocusController.cpp:

(WebCore::dispatchEventsOnWindowAndFocusedNode):
Adjust Node::dispatchFocusEvent argument.
(WebCore::FocusController::advanceFocusInDocumentOrder):
Pass FocusDirectio to Element::focus.
(WebCore::FocusController::setFocusedNode):
Add FocusDirection argument in order to pass it to Document::setFocusedNode.
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
Pass FocusDirectio to Element::focus.

• page/FocusController.h:

(FocusController): Add FocusDirection argument to setFocusedNode.

• dom/Element.cpp:

(WebCore::Element::focus):
Add FocusDirection argument to pass it to FocusController::setFocusedNode.

• dom/Element.h:

(Element): Ditto.

• WebCore.exp.in:

Update FocusController::setFocusedNode and Document::setFocusedNode.

• html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::focus): Adjust FocusDirection argument.

• html/HTMLLabelElement.h:

(HTMLLabelElement): Ditto.

• html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::focus): Ditto.

• html/HTMLLegendElement.h:

(HTMLLegendElement): Ditto.

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::dispatchFocusEvent): Ditto.

• html/HTMLSelectElement.h:

(HTMLSelectElement): Ditto.

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultFocus):
Add FocusDirection argument in order to pass it from
HTMLInputElement::focus() to HTMLTextFormControlElement::focus().
(WebCore::HTMLInputElement::focus):
Pass the FocusDirection argument to InputType::focus. See above.
(WebCore::HTMLInputElement::handleFocusEvent):
Adjust FocusDirection argument.

• html/HTMLInputElement.h:

(HTMLInputElement):

• html/InputType.cpp:

(WebCore::InputType::focus): Add FocusDirection argument.

• html/InputType.h:

(InputType): Ditto.

• html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::focus):
Add FocusDirection argument to follow InputType.

• html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Ditto.

10:02 PM Changeset in webkit [141737] by morrita@google.com

• 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking terminate-during-sync-operation.html as timing out.

• platform/chromium/TestExpectations:

9:59 PM Changeset in webkit [141736] by commit-queue@webkit.org

• 16 edits in trunk/Source/WebKit

Fix build warning after r141473
​https://bugs.webkit.org/show_bug.cgi?id=108782

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2013-02-03
Reviewed by Kentaro Hara.

Fix -Wunused-parameter build warning.

Source/WebKit/blackberry:

• WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::getClientPasteboardDataForRange):

Source/WebKit/chromium:

• src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::getClientPasteboardDataForRange):

Source/WebKit/efl:

• WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::getClientPasteboardDataForRange):

Source/WebKit/gtk:

• WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::getClientPasteboardDataForRange):

Source/WebKit/qt:

• WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::getClientPasteboardDataForRange):

Source/WebKit/win:

• WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::getClientPasteboardDataForRange):

Source/WebKit/wince:

• WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::getClientPasteboardDataForRange):

Source/WebKit/wx:

• WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::getClientPasteboardDataForRange):

9:11 PM Changeset in webkit [141735] by commit-queue@webkit.org

• 8 edits
  1 add in trunk/Source/WebCore

Adds usage instrumentation for indexedDB
Includes new header file in project files

​https://bugs.webkit.org/show_bug.cgi?id=107772

Patch by Kassy Coan <​kassycoan@chromium.org> on 2013-02-03
Reviewed by Tony Chang.

Currently untestable. Has zero effect apart from histogramming.

• GNUmakefile.list.am:
• Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

• Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):

• Modules/indexeddb/IDBHistograms.h: Added.

(WebCore):

• Target.pri:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:

8:54 PM Changeset in webkit [141734] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Unreviewed. Add dstockwell as a contributor in comitters.py and to the watchlist for animation
​https://bugs.webkit.org/show_bug.cgi?id=108777

Patch by Douglas Stockwell <​dstockwell@chromium.org> on 2013-02-03

• Scripts/webkitpy/common/config/committers.py:
• Scripts/webkitpy/common/config/watchlist:

8:53 PM Changeset in webkit [141733] by hayato@chromium.org

• 8 edits
  2 adds in trunk/Source/WebCore

Split default style-sheet statics out from StyleResolver into its own class
​https://bugs.webkit.org/show_bug.cgi?id=107780

Reviewed by Dimitri Glazkov.

Factored static variables and logic about default style sheets out from StyleResolver into its own class
CSSDefaultStyleSheets. This is a following patch after r141373.

No new tests, refactoring only.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gypi:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSAllInOne.cpp:
• css/CSSDefaultStyleSheets.cpp: Added.

(WebCore):
(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::screenEval):
(WebCore::printEval):
(WebCore::parseUASheet):
(WebCore::CSSDefaultStyleSheets::initDefaultStyle):
(WebCore::CSSDefaultStyleSheets::loadFullDefaultStyle):
(WebCore::CSSDefaultStyleSheets::loadSimpleDefaultStyle):
(WebCore::CSSDefaultStyleSheets::viewSourceStyle):
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

• css/CSSDefaultStyleSheets.h: Added.

(WebCore):
(CSSDefaultStyleSheets):

• css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::reportMemoryUsage):

8:27 PM FeatureFlags edited by tkent@chromium.org

Rename CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to … (diff)

8:25 PM Changeset in webkit [141732] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Fix build warning after r141648
​https://bugs.webkit.org/show_bug.cgi?id=108784

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2013-02-03
Reviewed by Kentaro Hara.

Fix -Wunused-parameter build warning.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):

8:04 PM Changeset in webkit [141731] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

[chromium] Do not call m_widgetClient->show() for WebHelperPlugin.
​https://bugs.webkit.org/show_bug.cgi?id=108740

Patch by David Dorwin <​ddorwin@chromium.org> on 2013-02-03
Reviewed by Kent Tamura.

The calls to m_widgetClient->show() and setFocus() do not appear to be
necessary, and the former causes problems on at least on platform.

• src/WebHelperPluginImpl.cpp:

(WebKit::WebHelperPluginImpl::initialize): Removed calls to m_widgetClient->show() and setFocus().
(WebKit::WebHelperPluginImpl::setFocus): Should never be called.

7:22 PM Changeset in webkit [141730] by haraken@chromium.org

• 5 edits in trunk/Source/WebCore

[V8] Simplify CodeGeneratorV8.pm by using InheritsExtendedAttribute("EventTarget")
​https://bugs.webkit.org/show_bug.cgi?id=108441

Reviewed by Adam Barth.

A complicated condition in GetInternalFields() can be simplified
by using InheritsExtendedAttribute("EventTarget").

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):

• dom/EventTarget.idl: Added [EventTarget] which should have been added.
• svg/SVGElementInstance.idl: Ditto.

7:09 PM Changeset in webkit [141729] by weinig@apple.com

• 2 edits in trunk/Tools

Fix failing test.

• TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:

(TestWebKitAPI::didFinishLoadForFrame):

6:55 PM Changeset in webkit [141728] by morrita@google.com

• 1 edit
  1 add in trunk/LayoutTests

[Chromium] Unreviewed rebaselining.

• platform/chromium-mac-lion/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.

6:16 PM Changeset in webkit [141727] by kov@webkit.org

• 2 edits in trunk/Source/WebCore

[Soup] Do not use local variables for the client
​https://bugs.webkit.org/show_bug.cgi?id=108714

Reviewed by Martin Robinson.

Covered by existing tests, refactoring code only.

We have had problems in the past with the client being destroyed or
changed inside a method or function, and we ended up with a stale
pointer, leading to crashes. This refactoring is an effort to minimize
the possibility of hitting that same issue in the future.

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::redirectSkipCallback): no longer use a local variable to hold
the client.
(WebCore::wroteBodyDataCallback): ditto.
(WebCore::nextMultipartResponsePartCallback): ditto.
(WebCore::sendRequestCallback): ditto.
(WebCore::closeCallback): ditto.
(WebCore::readCallback): ditto.

6:15 PM Changeset in webkit [141726] by morrita@google.com

• 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking grid-preferred-logical-widths.html as a fail.

• platform/chromium/TestExpectations:

5:54 PM Changeset in webkit [141725] by morrita@google.com

• 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking block-test.html as a fail.

• platform/chromium/TestExpectations:

5:37 PM Changeset in webkit [141724] by noel.gordon@gmail.com

• 2 edits in trunk/LayoutTests

[chromium] Skip editing/inserting/smart-link-when-caret-is-moved-before-URL.html
​https://bugs.webkit.org/show_bug.cgi?id=85463

Test added in ​http://trac.webkit.org/changeset/141618 - requires that DRT or WKTR
implement setAutomaticLinkDetectionEnabled().

Unreviewed gardening.

• platform/chromium/TestExpectations:

5:03 PM Changeset in webkit [141723] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Make ChangeLogEntry detect annotations by prepare-ChangeLog (Added/Removed/Copied from/Renamed from) as clean.
​https://bugs.webkit.org/show_bug.cgi?id=108433

Patch by Timothy Loh <​timloh@chromium.com> on 2013-02-03
Reviewed by Eric Seidel.

PrepareChangeLog is supposed to update the file/function list if we
haven't touched it, but the existing regex doesn't handle the
annotations prepare-ChangeLog adds (e.g. "Added.")

• Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry.is_touched_files_text_clean):

• Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_is_touched_files_text_clean):

4:47 PM Changeset in webkit [141722] by tkent@chromium.org

• 3 edits in trunk/LayoutTests

calendar-picker-key-operations.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=108566

Reviewed by Kentaro Hara.

• platform/chromium/TestExpectations:
• platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:

Month.createFromDate supports only UTC Date. Use the Month constructor
with local year and local month.

4:43 PM Changeset in webkit [141721] by haraken@chromium.org

• 18 edits in trunk/Source/WebCore

[V8] Pass an Isolate to HasInstance() (part 1)
​https://bugs.webkit.org/show_bug.cgi?id=108617

Reviewed by Adam Barth.

This is one of efforts to pass an Isolate to GetTemplate().

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorV8.pm:

(JSValueToNative):

• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):

• bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):

• bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventCallback):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):

• bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

• bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

• bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):

• bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

• bindings/v8/V8Binding.h:

(WebCore):

• bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

• bindings/v8/V8GCController.cpp:

(WebCore::WrapperVisitor::WrapperVisitor):
(WrapperVisitor):
(WebCore::V8GCController::majorGCPrologue):

• bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

• bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

• bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

4:01 PM Changeset in webkit [141720] by commit-queue@webkit.org

• 4 edits in trunk/Source

[GTK] Make distcheck fails
​https://bugs.webkit.org/show_bug.cgi?id=108756

Patch by Joanmarie Diggs <​jdiggs@igalia.com> on 2013-02-03
Reviewed by Kentaro Hara.

Source/WebCore:

• GNUmakefile.list.am: Remove header files which no longer exist;

correct one which got added incorrectly.

Source/WebKit2:

• GNUmakefile.list.am: Remove header files which no longer exist

3:53 PM Changeset in webkit [141719] by haraken@chromium.org

• 5 edits in trunk/Source/WebCore

[V8] Pass an Isolate to HasInstance() (part 3)
​https://bugs.webkit.org/show_bug.cgi?id=108622

Reviewed by Adam Barth.

This is one of efforts to pass an Isolate to GetTemplate().

No tests. No change in behavior.

• bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
(WebCore::V8InjectedScriptHost::typeCallback):
(WebCore::V8InjectedScriptHost::getEventListenersCallback):

• bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):

• bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

• bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendCallback):

3:26 PM Changeset in webkit [141718] by haraken@chromium.org

• 13 edits in trunk/Source/WebCore

[V8] Pass an Isolate to HasInstance() (part 2)
​https://bugs.webkit.org/show_bug.cgi?id=108620

Reviewed by Adam Barth.

This is one of efforts to pass an Isolate to GetTemplate().

No tests. No change in behavior.

• bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

• bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):

• bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallbackCustom):

• bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toCanvasStyle):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorSetter):

• bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageCallback):

• bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesCallback):

• bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallbackCustom):
(WebCore::V8DOMFormData::appendCallback):

• bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallbackCustom):

• bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

• bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAccessorSetter):

• bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addCallback):

• bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::removeElement):

10:35 AM Changeset in webkit [141717] by mkwst@chromium.org

• 2 edits in trunk/Source/WebCore

Cleanup: 'ExceptionCode& ec', not 'ExceptionCode &ec'.
​https://bugs.webkit.org/show_bug.cgi?id=108769

Reviewed by Eric Seidel.

Does what it says on the tin: reference parameters should read
'type& name', and this patch fixes the two occurances of 'type &name'
that cropped up for ExceptionCode.

Pure style change; no effect on behavior.

• html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):

5:37 AM Changeset in webkit [141716] by akling@apple.com

• 8 edits in trunk/Source

Vector should consult allocator about ideal size when choosing capacity.
<​http://webkit.org/b/108410>
<rdar://problem/13124002>

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Remove assertion about Vector capacity that won't hold anymore since capacity()
may not be what you passed to reserveCapacity().
Also export WTF::fastMallocGoodSize() for Windows builds.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

Source/WTF:

Added WTF::fastMallocGoodSize(), a workalike/wrapper for OS X's malloc_good_size().
It returns the actual size of the block that will get allocated for a given byte size.

Vector's internal buffer now checks with the allocator if the resulting allocation
could actually house more objects and updates its capacity to make use of the space.

• wtf/Deque.h:

(WTF::::expandCapacity):

• wtf/FastMalloc.cpp:

(WTF::fastMallocGoodSize):

• wtf/FastMalloc.h:
• wtf/Vector.h:

(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):

4:17 AM Changeset in webkit [141715] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Mark inspector/debugger/source-frame-count.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=108768

Unreviewed EFL gardening.

Mark inspector/debugger/source-frame-count.html as flaky as it sometimes
crashes due to Bug 81574.

Patch by Christophe Dumez <​dchris@gmail.com> on 2013-02-03

• platform/efl-wk2/TestExpectations:

2:48 AM Changeset in webkit [141714] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Mark a few more media tests as flaky due to gstreamer 1.0
​https://bugs.webkit.org/show_bug.cgi?id=108765

Unreviewed EFL gardening.

Mark 2 more media tests as flaky since the update to gstreamer 1.0.
They sometimes crash in MediaPlayerPrivateGStreamer dtor.

Patch by Christophe Dumez <​dchris@gmail.com> on 2013-02-03

• platform/efl/TestExpectations:

2:42 AM Changeset in webkit [141713] by commit-queue@webkit.org

• 1 edit
  2 adds in trunk/LayoutTests

[EFL] svg/custom/text-ctm.svg needs a baseline
​https://bugs.webkit.org/show_bug.cgi?id=108764

Unreviewed EFL gardening.

Add baseline for svg/custom/text-ctm.svg that was added in r17879.

Patch by Christophe Dumez <​dchris@gmail.com> on 2013-02-03

• platform/efl/svg/custom/text-ctm-expected.png: Added.
• platform/efl/svg/custom/text-ctm-expected.txt: Added.