Timeline
Feb 9, 2013:
- 11:37 PM Changeset in webkit [142389] by
-
- 2 edits in trunk/Tools
Make TestWebKitAPI work for iOS
https://bugs.webkit.org/show_bug.cgi?id=108978
Patch by David Farler <dfarler@apple.com> on 2013-02-09
Reviewed by Joseph Pecoraro.
- TestWebKitAPI/Configurations/Base.xcconfig:
Added back FRAMEWORK_SEARCH_PATHS for Lion builds.
- 11:09 PM Changeset in webkit [142388] by
-
- 2 edits1 add in trunk/Source/Platform
[chromium] Enable more of webkit_unit_tests in component builds
https://bugs.webkit.org/show_bug.cgi?id=109369
Reviewed by Darin Fisher.
Add a set of testing APIs to a WebUnitTestSupport interface available off of Platform for unit tests to access
in component builds.
- chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::unitTestSupport):
- chromium/public/WebUnitTestSupport.h: Added.
(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::registerMockedURL):
(WebKit::WebUnitTestSupport::registerMockedErrorURL):
(WebKit::WebUnitTestSupport::unregisterMockedURL):
(WebKit::WebUnitTestSupport::unregisterAllMockedURLs):
(WebKit::WebUnitTestSupport::serveAsynchronousMockedRequests):
(WebKit::WebUnitTestSupport::webKitRootDir):
- 10:41 PM Changeset in webkit [142387] by
-
- 3 edits in trunk/Source/JavaScriptCore
Shrink-wrap UnlinkedCodeBlock members.
<http://webkit.org/b/109368>
Reviewed by Oliver Hunt.
Rearrange the members of UnlinkedCodeBlock to avoid unnecessary padding on 64-bit.
Knocks ~600 KB off of the Membuster3 peak.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(UnlinkedCodeBlock):
- 10:26 PM Changeset in webkit [142386] by
-
- 3 edits in trunk/LayoutTests
Chromium gardening
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- platform/chromium/TestExpectations:
- 10:11 PM Changeset in webkit [142385] by
-
- 4 edits in trunk
fast/encoding/parser-tests-*.html tests sometimes crash
https://bugs.webkit.org/show_bug.cgi?id=108058
Reviewed by Chris Fleizach.
Source/WebCore:
To avoid calling accessibilityIsIgnored while the render
tree is unstable, call accessibilityIsIgnored in the
notification timer handler, only for childrenChanged
notifications.
This exposed a problem where notifications queued on
objects can fire after the object has been deleted; fix that
by checking the object's id, which is always set to 0 when
removed from the tree.
Covered by existing tests.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::notificationPostTimerFired):
LayoutTests:
Make test less brittle by (1) giving the iframe an aria-role so
it's never ignored, and (2) using accessibilityElementById instead
of assuming an element is in a specific place in the AX tree.
- accessibility/loading-iframe-updates-axtree.html:
- 7:48 PM Changeset in webkit [142384] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, rolling out r137328.
http://trac.webkit.org/changeset/137328
https://bugs.webkit.org/show_bug.cgi?id=109367
causes memory usage to balloon if connection queue is filling
faster than sending (Requested by kling on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-09
- Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::ArgumentEncoder):
(CoreIPC::ArgumentEncoder::grow):
- Platform/CoreIPC/ArgumentEncoder.h:
(CoreIPC::ArgumentEncoder::buffer):
(ArgumentEncoder):
- 4:50 PM Changeset in webkit [142383] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Do not assume MediaAccessibility framework is installed
https://bugs.webkit.org/show_bug.cgi?id=109365
Reviewed by Sam Weinig.
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): Call the base class if the framework
is not available.
(WebCore::CaptionUserPreferencesMac::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferencesMac::userHasCaptionPreferences): Ditto.
(WebCore::CaptionUserPreferencesMac::registerForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferencesMac::unregisterForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Ditto.
(WebCore::CaptionUserPreferencesMac::captionFontSizeScale): Ditto.
(WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Ditto.
(WebCore::CaptionUserPreferencesMac::preferredLanguages): Ditto.
- 3:06 PM Changeset in webkit [142382] by
-
- 39 edits in trunk/Source/WebCore
AX: move isIgnored caching to AXObject
https://bugs.webkit.org/show_bug.cgi?id=109322
Reviewed by Chris Fleizach.
There's some benefit to caching accessibilityIsIgnored
(using AXComputedObjectAttributeCache) for more than just
AXRenderObject, so move the caching code to AXObject.
AXObject now has a protected virtual method
computeAccessibilityIsIgnored, and all subclasses
override that instead.
No new tests.
- accessibility/AccessibilityImageMapLink.h:
(AccessibilityImageMapLink):
(WebCore::AccessibilityImageMapLink::computeAccessibilityIsIgnored):
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::computeAccessibilityIsIgnored):
- accessibility/AccessibilityList.h:
(AccessibilityList):
- accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::computeAccessibilityIsIgnored):
- accessibility/AccessibilityListBox.h:
(AccessibilityListBox):
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored):
- accessibility/AccessibilityListBoxOption.h:
(AccessibilityListBoxOption):
- accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMediaControls.h:
(AccessibilityMediaControl):
(WebCore::AccessibilityMediaControlsContainer::computeAccessibilityIsIgnored):
(AccessibilityMediaTimeDisplay):
- accessibility/AccessibilityMenuList.h:
(WebCore::AccessibilityMenuList::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMenuListOption.h:
(AccessibilityMenuListOption):
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMenuListPopup.h:
(AccessibilityMenuListPopup):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):
- accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::accessibilityIsIgnored):
(WebCore):
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
(WebCore::AccessibilityObject::computeAccessibilityIsIgnored):
- accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::computeAccessibilityIsIgnored):
- accessibility/AccessibilityProgressIndicator.h:
(AccessibilityProgressIndicator):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::computeAccessibilityIsIgnored):
- accessibility/AccessibilityScrollView.h:
(AccessibilityScrollView):
- accessibility/AccessibilityScrollbar.h:
(WebCore::AccessibilityScrollbar::computeAccessibilityIsIgnored):
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::computeAccessibilityIsIgnored):
(WebCore::AccessibilitySliderThumb::computeAccessibilityIsIgnored):
- accessibility/AccessibilitySlider.h:
(AccessibilitySlider):
(AccessibilitySliderThumb):
- accessibility/AccessibilitySpinButton.h:
(WebCore::AccessibilitySpinButton::computeAccessibilityIsIgnored):
(WebCore::AccessibilitySpinButtonPart::computeAccessibilityIsIgnored):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::computeAccessibilityIsIgnored):
- accessibility/AccessibilityTable.h:
(AccessibilityTable):
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored):
- accessibility/AccessibilityTableCell.h:
(AccessibilityTableCell):
- accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):
- accessibility/AccessibilityTableColumn.h:
(AccessibilityTableColumn):
- accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):
- accessibility/AccessibilityTableHeaderContainer.h:
(AccessibilityTableHeaderContainer):
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::computeAccessibilityIsIgnored):
- accessibility/AccessibilityTableRow.h:
(AccessibilityTableRow):
- 2:53 PM Changeset in webkit [142381] by
-
- 10 edits1 copy1 move1 add in trunk
Make TestWebKitAPI work for iOS
https://bugs.webkit.org/show_bug.cgi?id=108978
Patch by David Farler <dfarler@apple.com> on 2013-02-09
Reviewed by David Kilzer.
Source/WebCore:
Tests already exist - refactor only.
- WebCore.exp.in: Lumped ZNK7WebCore4KURL7hasPathEv with related methods.
- platform/KURL.cpp: Inlined hasPath() into the header
- platform/KURL.h: Inlined hasPath() into the header
Tools:
- Makefile: Added TestWebKitAPI to iOS MODULES list.
- TestWebKitAPI/Configurations/Base.xcconfig:
- Include FeatureDefines
- Removed VALID_ARCHS
- Removed FRAMEWORK_SEARCH_PATHS - allows building against other SDKs
- Excluded source files per platform
- TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
- framework and library switches per platform
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- Remove explicit framework and library linking (moved to xcconfigs)
- Added iOS main.mm
- TestWebKitAPI/config.h:
- Guard importing Cocoa.h and WebKit2_C.h on iOS
- TestWebKitAPI/ios/mainIOS.mm: Copied from Tools/TestWebKitAPI/mac/main.mm.
- TestWebKitAPI/mac/mainMac.mm: Renamed from Tools/TestWebKitAPI/mac/main.mm.
- 1:00 PM Changeset in webkit [142380] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Reverting earlier change now
Unreviewed expectations.
- platform/chromium/TestExpectations: Removed all the expectations added earlier.
- 12:13 PM Changeset in webkit [142379] by
-
- 2 edits in trunk/Tools
[CHROMIUM] Suppress c4267 build warnings for Win64 tests
https://bugs.webkit.org/show_bug.cgi?id=109359
Reviewed by Abhishek Arya.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 11:34 AM Changeset in webkit [142378] by
-
- 8 edits in trunk/Source/WebCore
Load event fires too early with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=108984
Reviewed by Eric Seidel.
Previously, the DocumentLoader would always be on the stack when the
HTMLDocumentParser was processing data from the network. The
DocumentLoader would then tell isLoadingInAPISense not to fire the load
event. Now that we process data asynchronously with the threaded
parser, the DocumentLoader is not always on the stack, which means we
need to delay the load event using the clause that asks the parser
whether it is processing data.
Unfortunately, that clause is fragile because we can check for load
completion while we're switching parsers between the network-created
parser and a script-created parser. To avoid accidentially triggerin
the load event during these "gaps," this patch introduces a counter on
document to record how many parsers are active on the stack. While
that numer is non-zero, we'll delay the load event. When that number
reaches zero, we'll check for load complete.
That last step is required because the DocumentLoader::finishLoading
method is no longer guarunteed to check for load complete after calling
finish on the parser because the finish operation might complete
asynchronously.
After this patch, the threaded parser passes all but four fast/parser
tests.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::hasActiveParser):
(WebCore):
(WebCore::Document::decrementActiveParserCount):
- dom/Document.h:
(Document):
(WebCore::Document::incrementActiveParserCount):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/HTMLParserScheduler.cpp:
(WebCore::ActiveParserSession::ActiveParserSession):
(WebCore):
(WebCore::ActiveParserSession::~ActiveParserSession):
(WebCore::PumpSession::PumpSession):
(WebCore::PumpSession::~PumpSession):
- html/parser/HTMLParserScheduler.h:
(WebCore):
(ActiveParserSession):
(PumpSession):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoadingInAPISense):
- 11:33 AM Changeset in webkit [142377] by
-
- 33 edits6 adds in trunk/Source/JavaScriptCore
DFG should allow phases to break Phi's and then have one phase to rebuild them
https://bugs.webkit.org/show_bug.cgi?id=108414
Reviewed by Mark Hahnenberg.
Introduces two new DFG forms: LoadStore and ThreadedCPS. These are described in
detail in DFGCommon.h.
Consequently, DFG phases no longer have to worry about preserving data flow
links between basic blocks. It is generally always safe to request that the
graph be dethreaded (Graph::dethread), which brings it into LoadStore form, where
the data flow is implicit. In this form, only liveness-at-head needs to be
preserved.
All of the machinery for "threading" the graph to introduce data flow between
blocks is now moved out of the bytecode parser and into the CPSRethreadingPhase.
All phases that previously did this maintenance themselves now just rely on
being able to dethread the graph. The one exception is the structure check
hoising phase, which operates over a threaded graph and preserves it, for the
sake of performance.
Also moved two other things into their own phases: unification (previously found
in the parser) and prediction injection (previously found in various places).
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/Operands.h:
(Operands):
(JSC::Operands::sizeFor):
(JSC::Operands::atFor):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
- dfg/DFGAllocator.h:
(JSC::DFG::::allocateSlow):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGBasicBlockInlines.h:
(DFG):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::parseBlock):
(DFG):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::killUnreachable):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
- dfg/DFGCPSRethreadingPhase.cpp: Added.
(DFG):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::freeUnnecessaryNodes):
(JSC::DFG::CPSRethreadingPhase::clearVariablesAtHeadAndTail):
(JSC::DFG::CPSRethreadingPhase::addPhiSilently):
(JSC::DFG::CPSRethreadingPhase::addPhi):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetArgument):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlock):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlocks):
(JSC::DFG::CPSRethreadingPhase::propagatePhis):
(JSC::DFG::CPSRethreadingPhase::PhiStackEntry::PhiStackEntry):
(PhiStackEntry):
(JSC::DFG::CPSRethreadingPhase::phiStackFor):
(JSC::DFG::performCPSRethreading):
- dfg/DFGCPSRethreadingPhase.h: Added.
(DFG):
- dfg/DFGCSEPhase.cpp:
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGCommon.cpp:
(WTF):
(WTF::printInternal):
- dfg/DFGCommon.h:
(JSC::DFG::logCompilationChanges):
(DFG):
(WTF):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dethread):
(JSC::DFG::Graph::collectGarbage):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::performSubstitution):
(Graph):
(JSC::DFG::Graph::performSubstitutionForEdge):
(JSC::DFG::Graph::convertToConstant):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToPhantomLocal):
(Node):
(JSC::DFG::Node::convertToGetLocal):
(JSC::DFG::Node::hasVariableAccessData):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPhase.cpp:
(JSC::DFG::Phase::beginPhase):
- dfg/DFGPhase.h:
(JSC::DFG::runAndLog):
- dfg/DFGPredictionInjectionPhase.cpp: Added.
(DFG):
(PredictionInjectionPhase):
(JSC::DFG::PredictionInjectionPhase::PredictionInjectionPhase):
(JSC::DFG::PredictionInjectionPhase::run):
(JSC::DFG::performPredictionInjection):
- dfg/DFGPredictionInjectionPhase.h: Added.
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- dfg/DFGUnificationPhase.cpp: Added.
(DFG):
(UnificationPhase):
(JSC::DFG::UnificationPhase::UnificationPhase):
(JSC::DFG::UnificationPhase::run):
(JSC::DFG::performUnification):
- dfg/DFGUnificationPhase.h: Added.
(DFG):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::dumpGraphIfAppropriate):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::dump):
- runtime/JSString.h:
(JSString):
- runtime/Options.h:
(JSC):
- 11:29 AM Changeset in webkit [142376] by
-
- 2 edits in trunk/Tools
Add a link to EFL perf bot on build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=109342
Reviewed by Gyuyoung Kim.
Added.
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 11:19 AM Changeset in webkit [142375] by
-
- 39 edits in trunk/Source/WebCore
Use IGNORE_EXCEPTION for initialized, but unused, ExceptionCodes.
https://bugs.webkit.org/show_bug.cgi?id=109295
Reviewed by Darin Adler.
The monster patch in http://wkbug.com/108771 missed an entire class of
ignored exceptions. It only dealt with call sites that never initialized
the ExceptionCode variable, on the assumption that only such call sites
would ignore the variable's value.
That was a flawed assumption: a large number of sites that initialize the
ExceptionCode to 0 ignore it regardless. This patch deals with the
almost-as-large set of callsites that initialize the variable, pass it to
a function, and then never touch it again.
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::forceClose):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaSelectedTextRange):
(WebCore::AccessibilityRenderObject::visiblePositionForIndex):
(WebCore::AccessibilityRenderObject::indexForVisiblePosition):
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getSelectionOffsetsForObject):
- accessibility/atk/WebKitAccessibleUtil.cpp:
(selectionBelongsToObject):
- dom/Node.cpp:
(WebCore::Node::textRects):
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::hide):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::styleAtSelectionStart):
- editing/Editor.cpp:
(WebCore::Editor::canDeleteRange):
(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::pasteAsFragment):
(WebCore::Editor::shouldDeleteRange):
(WebCore::Editor::dispatchCPPEvent):
(WebCore::Editor::setComposition):
(WebCore::Editor::advanceToNextMisspelling):
(WebCore::isFrameInRange):
- editing/EditorCommand.cpp:
(WebCore::expandSelectionToGranularity):
- editing/MergeIdenticalElementsCommand.cpp:
(WebCore::MergeIdenticalElementsCommand::doApply):
- editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::doUnapply):
- editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doApply):
- editing/TextCheckingHelper.cpp:
(WebCore::expandToParagraphBoundary):
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
(WebCore::TextCheckingHelper::isUngrammatical):
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
- editing/TextInsertionBaseCommand.cpp:
(WebCore::dispatchBeforeTextInsertedEvent):
(WebCore::canAppendNewLineFeedToSelection):
- editing/TextIterator.cpp:
(WebCore::findPlainText):
- editing/htmlediting.cpp:
(WebCore::extendRangeToWrappingNodes):
(WebCore::isNodeVisiblyContainedWithin):
- editing/visible_units.cpp:
(WebCore::nextBoundary):
- html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::setText):
- html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::setText):
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::didCompleteLoad):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
- html/SearchInputType.cpp:
(WebCore::SearchInputType::createShadowSubtree):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
- html/track/TextTrackList.cpp:
(TextTrackList::asyncEventTimerFired):
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchDocument):
- inspector/InspectorDatabaseAgent.cpp:
(WebCore):
- inspector/InspectorFileSystemAgent.cpp:
(WebCore):
- page/DOMSelection.cpp:
(WebCore::DOMSelection::addRange):
- page/DragController.cpp:
(WebCore::DragController::dispatchTextInputEventFor):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::handleTouchEvent):
- page/FrameActionScheduler.cpp:
(WebCore::EventFrameAction::fire):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
- svg/SVGDocument.cpp:
(WebCore::SVGDocument::dispatchZoomEvent):
(WebCore::SVGDocument::dispatchScrollEvent):
- svg/SVGLength.cpp:
(WebCore::SVGLength::SVGLength):
(WebCore::SVGLength::value):
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::exitText):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::startDocument):
(WebCore::XMLDocumentParser::parseCharacters):
- 11:11 AM Changeset in webkit [142374] by
-
- 2 edits in trunk/Tools
Unreviewed. Update my IRC nickname in committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 11:09 AM Changeset in webkit [142373] by
-
- 3 edits in trunk/Tools
build-webkit: document sdk, debug, release, device, and simulator options
https://bugs.webkit.org/show_bug.cgi?id=109221
Patch by David Farler <dfarler@apple.com> on 2013-02-09
Reviewed by David Kilzer.
- Scripts/build-webkit: Add options to usage
- Scripts/webkitdirs.pm: Remove --deploy and --devel checks
- 11:07 AM WebKit Team edited by
- Update my IRC nickname (diff)
- 11:05 AM Changeset in webkit [142372] by
-
- 6 edits in trunk/Source/WebCore
[skia] Fix memory management in SkiaImageFilterBuilder and friends.
https://bugs.webkit.org/show_bug.cgi?id=109326
Sadly, skia has no official ref-counted pointers, so we must make do
with SkAutoTUnref.
Reviewed by James Robinson.
Correctness covered by existing tests in css3/filters.
- platform/graphics/filters/skia/FEBlendSkia.cpp:
(WebCore::FEBlend::createImageFilter):
- platform/graphics/filters/skia/FEComponentTransferSkia.cpp:
(WebCore::FEComponentTransfer::createImageFilter):
- platform/graphics/filters/skia/FELightingSkia.cpp:
(WebCore::FELighting::createImageFilter):
Adopt refs produced by the build() pass with SkAutoTUnref.
- platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp:
(WebCore::SkiaImageFilterBuilder::~SkiaImageFilterBuilder):
Unref the builder's hashmap effect pointers.
(WebCore::SkiaImageFilterBuilder::build):
Ref the pointer returned to the caller, and use SkAutoTUnref
internally while building the tree.
- platform/graphics/filters/skia/SkiaImageFilterBuilder.h:
(SkiaImageFilterBuilder):
Add a destructor to SkiaImageFilterBuilder.
- 11:01 AM Changeset in webkit [142371] by
-
- 8 edits in trunk/Tools
[chromium] move context menu data tracking to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109313
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebKit):
(WebTestDelegate):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestRunner::WebTestProxy::showContextMenu):
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::setContextMenuData):
(WebTestRunner::EventSender::contextClick):
- DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(WebKit):
(EventSender):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::showContextMenu):
(WebTestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::showContextMenu):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 10:55 AM Changeset in webkit [142370] by
-
- 9 edits in trunk/Tools
[chromium] move methods that change initial testRunner state to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109043
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::configureForTestWithURL):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebKit):
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::showDevTools):
(WebTestRunner):
(WebTestRunner::TestRunner::showWebInspector):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::configureForTestWithURL):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::runFileTest):
- 10:41 AM Changeset in webkit [142369] by
-
- 2 edits in trunk/Tools
Add myself as a reviewer. (Yay!!!!!)
https://bugs.webkit.org/show_bug.cgi?id=109110
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 10:35 AM Changeset in webkit [142368] by
-
- 4 edits in trunk/Source/WebCore
AX: Rename AXObject::cachedIsIgnoredValue to lastKnownIsIgnoredValue
https://bugs.webkit.org/show_bug.cgi?id=108238
Reviewed by Chris Fleizach.
Simple refactoring, no new tests.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::childrenChanged):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::lastKnownIsIgnoredValue):
(WebCore::AccessibilityObject::setLastKnownIsIgnoredValue):
(WebCore::AccessibilityObject::notifyIfIgnoredValueChanged):
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
- 10:34 AM Changeset in webkit [142367] by
-
- 3 edits in trunk/Source/WebCore
[Text Autosizing] Cleanup change: converter the pointer argument to be a reference since
non-null pointer is always expected.
https://bugs.webkit.org/show_bug.cgi?id=109079
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-09
Reviewed by Kenneth Rohde Christiansen.
Cleanup change, no need to add new tests or modify the existing ones.
- rendering/TextAutosizer.cpp:
Changed parameter from a pointer to a reference in the methods below.
(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::isNarrowDescendant):
(WebCore::TextAutosizer::isWiderDescendant):
(WebCore::TextAutosizer::isAutosizingCluster):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):
- rendering/TextAutosizer.h: updated method prototypes.
- 10:15 AM Changeset in webkit [142366] by
-
- 10 edits1 copy5 adds in trunk/Source/WebCore
[TexMap] Separate classes per file in TextureMapperBackingStore.h
https://bugs.webkit.org/show_bug.cgi?id=109333
Reviewed by Noam Rosenthal.
TextureMapperBackingStore.h had the classes TextureMapperBackingStore,
TextureMapperTiledBackingStore, TextureMapperSurfaceBackingStore and
TextureMapperTile which was quite confusing. Now each one has its
own header and its own source file.
No new tests needed, refactoring only.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/graphics/texmap/TextureMapperBackingStore.cpp:
- platform/graphics/texmap/TextureMapperBackingStore.h:
- platform/graphics/texmap/TextureMapperSurfaceBackingStore.cpp: Added.
(WebCore):
(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::swapBuffersIfNeeded):
(WebCore::TextureMapperSurfaceBackingStore::texture):
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):
- platform/graphics/texmap/TextureMapperSurfaceBackingStore.h: Added.
(WebCore):
(TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::create):
(WebCore::TextureMapperSurfaceBackingStore::~TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::TextureMapperSurfaceBackingStore):
- platform/graphics/texmap/TextureMapperTile.cpp: Added.
(WebCore):
(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTile::paint):
- platform/graphics/texmap/TextureMapperTile.h: Added.
(WebCore):
(TextureMapperTile):
(WebCore::TextureMapperTile::texture):
(WebCore::TextureMapperTile::rect):
(WebCore::TextureMapperTile::setTexture):
(WebCore::TextureMapperTile::setRect):
(WebCore::TextureMapperTile::~TextureMapperTile):
(WebCore::TextureMapperTile::TextureMapperTile):
- platform/graphics/texmap/TextureMapperTiledBackingStore.cpp: Copied from Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp.
(WebCore):
(WebCore::TextureMapperTiledBackingStore::TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::adjustedTransformForRect):
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper):
(WebCore::TextureMapperTiledBackingStore::drawBorder):
(WebCore::TextureMapperTiledBackingStore::drawRepaintCounter):
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):
(WebCore::TextureMapperTiledBackingStore::texture):
- platform/graphics/texmap/TextureMapperTiledBackingStore.h: Added.
(WebCore):
(TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::create):
(WebCore::TextureMapperTiledBackingStore::~TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::setContentsToImage):
(WebCore::TextureMapperTiledBackingStore::rect):
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
- 10:02 AM Changeset in webkit [142365] by
-
- 3 edits2 adds in trunk
Sanitize m_keyTimes for paced value animations
https://bugs.webkit.org/show_bug.cgi?id=108828
Reviewed by Dirk Schulze.
Source/WebCore:
SVG animations with calcMode=paced calculate new m_keyTimes in
SVGAnimationElement::calculateKeyTimesForCalcModePaced() because paced animations do not
specify keyTimes. If an error occurs while calculating m_keyTimes, and there exists
user-specified values, a crash could occur because the user-specified values were not
sanitized.
This change clears user-specified keyTimes before calculating new ones.
Test: svg/animations/animate-keytimes-crash.html
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced):
LayoutTests:
- svg/animations/animate-keytimes-crash-expected.html: Added.
- svg/animations/animate-keytimes-crash.html: Added.
- 9:54 AM Changeset in webkit [142364] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Set mouse document position for mouse event in updateCursor.
https://bugs.webkit.org/show_bug.cgi?id=109094.
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-09
Reviewed by Rob Buis.
RIM PR 246976
Internally Reviewed by Genevieve Mak.
BlackBerry::Platform::MouseEvent have document viewport and document
content position as members. When we create the event, we should initial
them as well.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::updateCursor):
- 9:52 AM Changeset in webkit [142363] by
-
- 6 edits in trunk/Source/WebCore
Fix TextDocumentParser to play nice with threading
https://bugs.webkit.org/show_bug.cgi?id=109240
Reviewed by Adam Barth.
Before the HTML5 parser re-write the text document parser
was completely custom. With the HTML5 parser, we just made
the TextDocumentParser use the HTMLDocumentParser with an
artificial script tag.
However, our solution was slightly over-engineered to avoid
lying about the column numbers of the first line of the text document
during parsing. :)
This change makes us use a simpler (and threading-compatible)
solution by just inserting a real "<pre>" tag into the
input stream instead of hacking one together with the treebuilder
and manually setting the Tokenizer state.
fast/parser/empty-text-resource.html covers this case.
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::TextDocumentParser):
(WebCore::TextDocumentParser::insertFakePreElement):
- 9:28 AM Changeset in webkit [142362] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to last-known good revision. Really this time.
- DEPS: 181594
- 9:21 AM Changeset in webkit [142361] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to last-known good revision.
Requested by "Stephen Chenney" <schenney@chromium.org> via
sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-09
- DEPS:
- 9:05 AM Changeset in webkit [142360] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Trying to turn the build.webkit.org builders greener
Unreviewed expectations.
We seem to have an issue with build.webkit.org test bots and
Chromium.WebKit test bots doing different things. This is temporary
until we figure out what went wrong.
- platform/chromium/TestExpectations: Re-adding all the changes due to Skia flags.
- 7:37 AM Changeset in webkit [142359] by
-
- 3 edits in trunk/Source/WebCore
Add missing copyright header
https://bugs.webkit.org/show_bug.cgi?id=107507
- Resources/pagepopups/chromium/calendarPickerChromium.css:
- Resources/pagepopups/chromium/pickerCommonChromium.css:
- 7:25 AM Changeset in webkit [142358] by
-
- 3 edits2 adds in trunk
Fix crash by img[ismap] with content property
https://bugs.webkit.org/show_bug.cgi?id=108702
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/dom/HTMLAnchorElement/anchor-ismap-crash.html
- html/HTMLAnchorElement.cpp:
(WebCore::appendServerMapMousePosition):
Check if the renderer of an img element is RenderImage.
LayoutTests:
- fast/dom/HTMLAnchorElement/anchor-ismap-crash-expected.txt: Added.
- fast/dom/HTMLAnchorElement/anchor-ismap-crash.html: Added.
- 7:16 AM Changeset in webkit [142357] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectation update.
- platform/chromium/TestExpectations:
Correct encrypted-media-v2-*.html expectation.
- 7:14 AM Changeset in webkit [142356] by
-
- 5 edits in trunk/Source/WebCore
Drop ExceptionCode from IDB's directionToString and modeToString.
https://bugs.webkit.org/show_bug.cgi?id=109143
Reviewed by Jochen Eisinger.
No caller of either IDBCursor::directionToString or
IDBTransaction::modeToString makes use of the ExceptionCode these
methods require. This patch removes the 'ExceptionCode&' parameter from
both methods and their callsites.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::direction):
(WebCore::IDBCursor::directionToString):
Drop the 'ExceptionCode&' parameter, and replace the 'TypeError'
exception previously generated with ASSERT_NOT_REACHED.
- Modules/indexeddb/IDBCursor.h:
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::mode):
(WebCore::IDBTransaction::modeToString):
Drop the 'ExceptionCode&' parameter, and replace the 'TypeError'
exception previously generated with ASSERT_NOT_REACHED.
- Modules/indexeddb/IDBTransaction.h:
- 7:10 AM Changeset in webkit [142355] by
-
- 12 edits1 copy1 add2 deletes in trunk
[EFL][Qt][WebGL] Share the common code between GraphicsSurfaceGLX and X11WindowResources.
https://bugs.webkit.org/show_bug.cgi?id=106666
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-09
Reviewed by Kenneth Rohde Christiansen.
Covered by existing WebGL tests.
This patch removes any duplicate code in X11WindowResources and
GraphicsSurfaceGLX. No new functionality is added.
- PlatformEfl.cmake:
- Target.pri:
- platform/graphics/surfaces/egl/EGLConfigSelector.cpp:
(WebCore::EGLConfigSelector::pixmapContextConfig):
- platform/graphics/surfaces/egl/EGLConfigSelector.h:
(EGLConfigSelector):
- platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::destroy):
(WebCore::EGLWindowTransportSurface::setGeometry):
- platform/graphics/surfaces/egl/EGLSurface.h:
(WebCore):
(EGLWindowTransportSurface):
- platform/graphics/surfaces/glx/GLXConfigSelector.h:
(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::visualInfo):
(WebCore::GLXConfigSelector::pBufferContextConfig):
(WebCore::GLXConfigSelector::createSurfaceConfig):
(GLXConfigSelector):
- platform/graphics/surfaces/glx/GLXContext.cpp:
(WebCore::initializeARBExtensions):
(WebCore::GLXOffScreenContext::GLXOffScreenContext):
(WebCore::GLXOffScreenContext::initialize):
(WebCore::GLXOffScreenContext::platformReleaseCurrent):
(WebCore::GLXOffScreenContext::freeResources):
- platform/graphics/surfaces/glx/GLXContext.h:
(GLXOffScreenContext):
- platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::setGeometry):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXPBuffer::initialize):
- platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXPBuffer):
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::initialize):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::flags):
(WebCore::GraphicsSurfacePrivate::clear):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
No new functionality added. Made changes to take the common code into use.
- platform/graphics/surfaces/glx/X11WindowResources.h: Removed.
- platform/graphics/surfaces/glx/X11Helper.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/glx/X11WindowResources.cpp.
(WebCore):
(WebCore::DisplayConnection::DisplayConnection):
(DisplayConnection):
(WebCore::DisplayConnection::~DisplayConnection):
(WebCore::DisplayConnection::display):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::OffScreenRootWindow::rootWindow):
(WebCore::X11Helper::resizeWindow):
(WebCore::X11Helper::createOffScreenWindow):
(WebCore::X11Helper::destroyWindow):
(WebCore::X11Helper::isXRenderExtensionSupported):
(WebCore::X11Helper::nativeDisplay):
(WebCore::X11Helper::offscreenRootWindow):
- platform/graphics/surfaces/glx/X11Helper.h: Added.
(WebCore):
(WebCore::handleXPixmapCreationError):
(X11Helper):
(ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::~ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::isValidOperation):
Moved common code from GraphicsSurfaceGLX to X11Helper.
- 6:58 AM Changeset in webkit [142354] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding a failure expectation for the test introduced in r142335.
- 6:31 AM Changeset in webkit [142353] by
-
- 4 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/text/international/bidi-ignored-for-first-child-inline.html
after r142152.
- platform/efl/TestExpectations:
- platform/efl/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
- platform/efl/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
- 3:51 AM Changeset in webkit [142352] by
-
- 2 edits in trunk
Unreviewed, another GTK+ build fix after r142343.
- Source/autotools/symbols.filter: Expose the InlineBox delete operator.
- 1:58 AM Changeset in webkit [142351] by
-
- 7 edits2 adds in trunk
Web Inspector: show whitespace characters in DTE
https://bugs.webkit.org/show_bug.cgi?id=108947
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-09
Reviewed by Pavel Feldman.
Source/WebCore:
New test: inspector/editor/text-editor-show-whitespaces.html
Split consecutive whitespace characters into groups of 16, 8, 4, 2 and 1 and
add ::before pseudoclass for this groups which contains necessary
amount of "dots" (u+00b7). Add a setting "Show whitespace" for this
option in "Sources" section of "General" tab.
- English.lproj/localizedStrings.js:
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype.wasShown):
(WebInspector.TextEditorMainPanel.prototype.willHide):
(WebInspector.TextEditorMainPanel.prototype._renderRanges):
(WebInspector.TextEditorMainPanel.prototype._renderWhitespaceCharsWithFixedSizeSpans):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
- inspector/front-end/Settings.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
- inspector/front-end/inspectorSyntaxHighlight.css:
(.webkit-whitespace-1::before):
(.webkit-whitespace-2::before):
(.webkit-whitespace-4::before):
(.webkit-whitespace-8::before):
(.webkit-whitespace-16::before):
(.webkit-whitespace::before):
LayoutTests:
Add layout test to verify whitespace highlight functionality.
- inspector/editor/text-editor-show-whitespace-expected.txt: Added.
- inspector/editor/text-editor-show-whitespace.html: Added.
Feb 8, 2013:
- 10:13 PM Changeset in webkit [142350] by
-
- 2 edits in trunk/Source/WebKit2
Fix ASSERT when the Web Content Process crashes
https://bugs.webkit.org/show_bug.cgi?id=109346
Reviewed by Simon Fraser.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidCrash):
We need to remove ourselves as a message receiver before calling out to the client, as
the client might want to re-add us (as Safari does).
- 9:52 PM Changeset in webkit [142349] by
-
- 16 edits2 adds in trunk
[Mac] respect in-band caption color
https://bugs.webkit.org/show_bug.cgi?id=109203
Reviewed by Dean Jackson.
Source/WebCore:
Test: media/track/track-in-band-style.html
- WebCore.xcodeproj/project.pbxproj: Add HTMLDivElement.h to private headers because it is
included by HTMLTextElement, which is included by HTMLMediaElement.h, which is included
by files in WebKit/WebKit2.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::addGenericCue): Set cue colors if necessary.
- html/track/TextTrackCue.h:
(WebCore::TextTrackCue::element): New, accessor for the cue element so it can be styled.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): Set container and cue background
color if necessary.
(WebCore::TextTrackCueGeneric::operator==): Compare cue colors.
- html/track/TextTrackCueGeneric.h:
(WebCore::TextTrackCueGeneric::foregroundColor): Add color accessors.
(WebCore::TextTrackCueGeneric::setForegroundColor):
(WebCore::TextTrackCueGeneric::backgroundColor):
(WebCore::TextTrackCueGeneric::setBackgroundColor):
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::registerForCaptionPreferencesChangedCallbacks): Always
regenerate override CSS when an element registers for callbacks.
(WebCore::CaptionUserPreferencesMac::captionsWindowCSS): Drive by fix of "window color" padding.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Log the stylesheet generated
for easier debugging.
- platform/graphics/InbandTextTrackPrivateClient.h:
(WebCore::GenericCueData::foregroundColor): Add color getters/setters.
(WebCore::GenericCueData::setForegroundColor):
(WebCore::GenericCueData::backgroundColor):
(WebCore::GenericCueData::setBackgroundColor):
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::makeRGBA32FromARGBCFArray): Initialize a RGBA32 from a CFArray of color values.
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes): Process cue colors.
LayoutTests:
- media/track/track-in-band-style-expected.txt: Added.
- media/track/track-in-band-style.html: Added.
- platform/chromium/TestExpectations: Skip new test.
- platform/efl/TestExpectations: Ditto.
- platform/gtk/TestExpectations: Ditto.
- platform/mac/TestExpectations: Ditto.
- platform/qt/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- 9:17 PM Changeset in webkit [142348] by
-
- 49 edits1 delete in trunk
Move workerThreadCount from TestRunner to WebCore Internals
https://bugs.webkit.org/show_bug.cgi?id=109239
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-08
Reviewed by Darin Adler.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Add the new read-only property workerThreadCount.
- testing/Internals.cpp:
(WebCore::Internals::workerThreadCount):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac:
Get rid of WebWorkersPrivate, which was only needed for DRT.
- WebKit.exp:
- Workers/WebWorkersPrivate.h: Removed.
- Workers/WebWorkersPrivate.mm: Removed.
Source/WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
- WebProcess/WebPage/WebFrame.cpp: Remove a useless #include.
Tools:
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticValues):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::webHistoryItemCount):
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
LayoutTests:
Update the tests testRunner->internals.
- fast/workers/resources/dedicated-worker-lifecycle.js:
(runTests.worker.onmessage):
(runTests):
(orphanedWorkerExited.worker.onmessage):
(orphanedWorkerExited):
- fast/workers/resources/worker-lifecycle.js:
(runTests.worker.onmessage):
(runTests):
- fast/workers/resources/worker-util.js:
(.return):
(waitUntilThreadCountMatches):
- fast/workers/worker-close-more.html:
- http/tests/workers/resources/worker-util.js:
(.return):
(waitUntilThreadCountMatches):
- 8:21 PM Changeset in webkit [142347] by
-
- 5 edits in trunk
Remove use of plugInStartLabelImage
https://bugs.webkit.org/show_bug.cgi?id=108273
Reviewed by Simon Fraser.
Source/WebKit2:
Remove any use of plugInStartLabelImage. While there, implement plugInStartLabelTitle
and plugInStartLabelSubtitle to return the values from the client.
implement them.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h: Remove callback and entry from client structure.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Remove plugInStartLabelImage.
(WebKit::InjectedBundlePageUIClient::plugInStartLabelTitle): Ask the client bundle for value.
(WebKit::InjectedBundlePageUIClient::plugInStartLabelSubtitle): Ditto.
Tools:
Removed plugInStartLabelImage entry from client structure.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
- 8:04 PM Changeset in webkit [142346] by
-
- 2 edits in trunk
Only a fool would cut and paste from a terminal showing truncated git logs.
I am that fool.
Export the full symbol for InlineBox::nodeAtPoint.
- Source/autotools/symbols.filter:
- 7:58 PM Changeset in webkit [142345] by
-
- 2 edits in trunk
Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284
Unreviewed GTK+ build fix.
- Source/autotools/symbols.filter: Export InlineBox symbols.
- 7:42 PM Changeset in webkit [142344] by
-
- 2 edits in trunk/Tools
Fix the WebInspectorAPI watch list.
Reviewed by Joseph Pecoraro.
- Scripts/webkitpy/common/config/watchlist: Fix the regrexs.
Added InjectedScriptSource.js and Console.idl.
- 7:29 PM Changeset in webkit [142343] by
-
- 21 edits in trunk/Source
Source/WebCore: Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284
Reviewed by Simon Fraser.
Take two! This time with updated exports file.
A snapshotted plugin needs to indicate to the user that it can be clicked
to be restarted. Previously this was done with an image that had embedded
text. Instead, we now use an internal shadow root to embed some markup that
will display instructions that can be localised.
The UA stylesheet for plug-ins provides a default styling for the label, which
can be overridden by ports.
In the process, RenderSnapshottedPlugIn no longer inherits from RenderEmbeddedObject,
since it is only responsible for drawing a paused plug-in. The snapshot creation
can work with the default renderer, but a shadow root requires something like
RenderBlock in order to draw its children. We swap from one renderer to another when
necessary either by creating the shadow root or by explicitly detaching and attaching
the plugin element.
Unfortunately this is difficult to test, because the snapshotting requires
time to execute, and also a PluginView to be instantiated.
- WebCore.exp.in: Export the InlineBox interface.
- css/plugIns.css:
(object::-webkit-snapshotted-plugin-content): New rules for a default label style.
- platform/LocalizedStrings.cpp: Make sure all ports have plugin strings, now it is called.
- platform/LocalizedStrings.h:
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
- platform/chromium/LocalizedStringsChromium.cpp:
- platform/efl/LocalizedStringsEfl.cpp:
- platform/gtk/LocalizedStringsGtk.cpp:
- platform/qt/LocalizedStringsQt.cpp:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler): Take into account the fact
that RenderSnapshottedPlugIn no longer is an embedded object.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): New default values in constructor.
(WebCore::HTMLPlugInElement::defaultEventHandler): Make sure to call base class.
(WebCore::HTMLPlugInElement::willRecalcStyle): No need to reattach if we're a snapshot.
(WebCore::HTMLPlugInImageElement::createRenderer): If we're showing a snapshot, create such
a renderer, otherwise use the typical plug-in path.
(WebCore::HTMLPlugInImageElement::updateSnapshot): Keep a record of the snapshot, since we'll
need to give it to the renderer.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Build a subtree that will display a label.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): New member variable to record the snapshot image and whether the label
should show immediately.
(WebCore::HTMLPlugInImageElement::swapRendererTimerFired): The callback function triggered when we need
to swap to the Shadow Root.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): The user has tapped on the snapshot so the plugin
in being recreated. Make sure we reattach so that a plugin renderer will be created.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Make sure we set the right
displayState for snapshots.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): The new methods listed above.
(WebCore::HTMLPlugInImageElement::setShouldShowSnapshotLabelAutomatically): Indicates whether or not
a snapshot should be immediately labeled.
- page/ChromeClient.h: No need for plugInStartLabelImage any more.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): New inheritance.
(WebCore::RenderSnapshottedPlugIn::paint): If we're in the background paint phase, render the snapshot image.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotImage): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotWithLabel): Rename. No need for label sizes.
(WebCore::RenderSnapshottedPlugIn::getCursor):
(WebCore::RenderSnapshottedPlugIn::handleEvent): The renderer doesn't restart the plug-in any more. Tell the element and it will do it.
- rendering/RenderSnapshottedPlugIn.h:
(RenderSnapshottedPlugIn): New inheritance. Some method renaming.
Source/WebKit2:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
(InjectedBundlePageUIClient):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- 7:08 PM Changeset in webkit [142342] by
-
- 2 edits in trunk/LayoutTests
Disable All WebGL Tests on WebKit for Windows
https://bugs.webkit.org/show_bug.cgi?id=109207
Unreviewed expectations update.
- platform/win/TestExpectations:
- 6:42 PM Changeset in webkit [142341] by
-
- 20 edits in trunk/Source
Rolling out r142333 and r142337 which broke Mac Release builds.
- 6:40 PM Changeset in webkit [142340] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r142337.
http://trac.webkit.org/changeset/142337
https://bugs.webkit.org/show_bug.cgi?id=109339
Breaking Mac release builds (Requested by dino_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-08
- rendering/RenderSnapshottedPlugIn.h:
- 6:34 PM Changeset in webkit [142339] by
-
- 9 edits in trunk/Source/WebKit2
Move plug-in enumeration back to the main thread
https://bugs.webkit.org/show_bug.cgi?id=109337
<rdar://problem/12015046>
Reviewed by Andreas Kling.
Plug-in enumeration was moved to a separate work queue to improve responsiveness, but
doing so lead to crashes when WebKit1 would enumerate plug-ins on the main thread at the same time.
Bug <rdar://problem/13185819> tracks fixing the responsiveness issue by spawning a plug-in process
and have it do the enumeration.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromCarbonResources):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::connectionWillClose):
(WebKit::WebProcessProxy::getPlugins):
- UIProcess/WebProcessProxy.h:
(WebCore):
(WebProcessProxy):
- UIProcess/WebProcessProxy.messages.in:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit):
(WebKit::WebPlatformStrategies::populatePluginCache):
- WebProcess/WebProcess.cpp:
- WebProcess/WebProcess.h:
(WebProcess):
- WebProcess/WebProcess.messages.in:
- 6:20 PM Changeset in webkit [142338] by
-
- 7 edits in trunk/LayoutTests
Some tiled drawing tests use scalePageBy() incorrectly
https://bugs.webkit.org/show_bug.cgi?id=109336
Rubber-stamped by Simon Fraser.
scalePageBy takes (scale, x, y). Some of the tiled drawing tests are incorrectly handing them (scale, scale).
Adjust the tests and the expected results.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed.html:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed.html:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled.html:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom.html:
- 6:07 PM Changeset in webkit [142337] by
-
- 2 edits in trunk/Source/WebCore
Attempted Mac and GTK build fix after r142333.
- rendering/RenderSnapshottedPlugIn.h: Include InlineBox.h.
- 5:58 PM Changeset in webkit [142336] by
-
- 2 edits in trunk/Source/WTF
ARM_NEON Inline Assembly for copyLCharsFromUCharSource() inefficient for aligned destinations
https://bugs.webkit.org/show_bug.cgi?id=109335
Reviewed by Filip Pizlo.
Change a "do while" to a "while" so that we don't copy single characters to align the
destination when it is already aligned.
- wtf/text/ASCIIFastPath.h:
(WTF::copyLCharsFromUCharSource):
- 5:48 PM Changeset in webkit [142335] by
-
- 4 edits2 adds2 deletes in trunk
Restore pre-r118852 behavior for EllipsisBox::nodeAtPoint()
https://bugs.webkit.org/show_bug.cgi?id=109277
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/flexbox/line-clamp-link-after-ellipsis.html
Roll out r118852. Enough time has passed that this can't be done
mechanically, so transcribe the old method definition to current
WebCore interfaces.
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::markupBox): EllipsisBox no longer has
m_markupBox, so break the logic for finding the markup box from
paintMarkupBox() into its own function.
(WebCore::EllipsisBox::paintMarkupBox): Call markupBox().
(WebCore::EllipsisBox::nodeAtPoint): Transcribe the pre-r118852 implementation.
- rendering/EllipsisBox.h:
(EllipsisBox): Declare markupBox().
LayoutTests:
Remove test added by r118852 and add a test that verifies the original
expected behavior.
- fast/css/text-overflow-ellipsis-hit-test-expected.txt: Removed.
- fast/css/text-overflow-ellipsis-hit-test.html: Removed.
- fast/flexbox/line-clamp-link-after-ellipsis-expected.txt: Added.
- fast/flexbox/line-clamp-link-after-ellipsis.html: Added.
- 5:32 PM Changeset in webkit [142334] by
-
- 2 edits in trunk/Source/WebCore
[Mac] In-band closed caption tracks are not always initialized correctly
https://bugs.webkit.org/show_bug.cgi?id=109323
Reviewed by Dean Jackson.
No new tests, makes existing tests less flakey.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Create and configure legible output
here instad of in tracksChanged.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible): Do nothing in a build with
in-band track support.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Move legible output creation to
createAVPlayerItem, don't set look at track media type to see if the movie has captions
when we have support for in-band captions.
- 5:24 PM Changeset in webkit [142333] by
-
- 20 edits in trunk/Source
Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284
Reviewed by Simon Fraser.
Source/WebCore:
A snapshotted plugin needs to indicate to the user that it can be clicked
to be restarted. Previously this was done with an image that had embedded
text. Instead, we now use an internal shadow root to embed some markup that
will display instructions that can be localised.
The UA stylesheet for plug-ins provides a default styling for the label, which
can be overridden by ports.
In the process, RenderSnapshottedPlugIn no longer inherits from RenderEmbeddedObject,
since it is only responsible for drawing a paused plug-in. The snapshot creation
can work with the default renderer, but a shadow root requires something like
RenderBlock in order to draw its children. We swap from one renderer to another when
necessary either by creating the shadow root or by explicitly detaching and attaching
the plugin element.
Unfortunately this is difficult to test, because the snapshotting requires
time to execute, and also a PluginView to be instantiated.
- css/plugIns.css:
(object::-webkit-snapshotted-plugin-content): New rules for a default label style.
- platform/LocalizedStrings.cpp: Make sure all ports have plugin strings, now it is called.
- platform/LocalizedStrings.h:
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
- platform/chromium/LocalizedStringsChromium.cpp:
- platform/efl/LocalizedStringsEfl.cpp:
- platform/gtk/LocalizedStringsGtk.cpp:
- platform/qt/LocalizedStringsQt.cpp:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler): Take into account the fact
that RenderSnapshottedPlugIn no longer is an embedded object.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): New default values in constructor.
(WebCore::HTMLPlugInElement::defaultEventHandler): Make sure to call base class.
(WebCore::HTMLPlugInElement::willRecalcStyle): No need to reattach if we're a snapshot.
(WebCore::HTMLPlugInImageElement::createRenderer): If we're showing a snapshot, create such
a renderer, otherwise use the typical plug-in path.
(WebCore::HTMLPlugInImageElement::updateSnapshot): Keep a record of the snapshot, since we'll
need to give it to the renderer.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Build a subtree that will display a label.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): New member variable to record the snapshot image and whether the label
should show immediately.
(WebCore::HTMLPlugInImageElement::swapRendererTimerFired): The callback function triggered when we need
to swap to the Shadow Root.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): The user has tapped on the snapshot so the plugin
in being recreated. Make sure we reattach so that a plugin renderer will be created.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Make sure we set the right
displayState for snapshots.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): The new methods listed above.
(WebCore::HTMLPlugInImageElement::setShouldShowSnapshotLabelAutomatically): Indicates whether or not
a snapshot should be immediately labeled.
- page/ChromeClient.h: No need for plugInStartLabelImage any more.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): New inheritance.
(WebCore::RenderSnapshottedPlugIn::paint): If we're in the background paint phase, render the snapshot image.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotImage): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotWithLabel): Rename. No need for label sizes.
(WebCore::RenderSnapshottedPlugIn::getCursor):
(WebCore::RenderSnapshottedPlugIn::handleEvent): The renderer doesn't restart the plug-in any more. Tell the element and it will do it.
- rendering/RenderSnapshottedPlugIn.h:
(RenderSnapshottedPlugIn): New inheritance. Some method renaming.
Source/WebKit2:
We no longer have any need for plugInStartLabelImage.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Remove plugInStartLabelImage.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.h: Ditto.
- 4:45 PM Changeset in webkit [142332] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Expectation modification after r142327
Unreviewed expectations update.
The test from "Bring WebKit up to speed with latest Encrypted Media spec" is slow.
- platform/chromium/TestExpectations:
- 4:41 PM Changeset in webkit [142331] by
-
- 1 edit2 adds2 deletes in trunk/LayoutTests
[Chromium] Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
A remaining textual fix.
- editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
- platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
- platform/chromium-mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
- platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
- 4:28 PM Changeset in webkit [142330] by
-
- 2 edits1 delete in trunk/LayoutTests
[Mac] Unreviewed rebaseline
- platform/mac-lion/compositing/visible-rect/iframe-no-layers-expected.txt: Removed.
- platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
- 4:20 PM Changeset in webkit [142329] by
-
- 7 edits in trunk/Source/WebCore
{FocusIn,FocusOut,Focus,Blur}EventDispatchMediator should be in FocusEvent.cpp
https://bugs.webkit.org/show_bug.cgi?id=109265
Reviewed by Dimitri Glazkov.
Conventionally we put XXXEventDispatchMediator to XXXEvent.cpp.
We should move {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator to FocusEvent.cpp.
No tests. No change in behavior.
- dom/EventDispatchMediator.cpp:
- dom/EventDispatchMediator.h:
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
- dom/FocusEvent.h:
(WebCore):
(FocusEventDispatchMediator):
(BlurEventDispatchMediator):
(FocusInEventDispatchMediator):
(FocusOutEventDispatchMediator):
- dom/UIEvent.cpp:
- dom/UIEvent.h:
- 4:13 PM Changeset in webkit [142328] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix. MSVC (and other compilers) need a default: case in switch statement.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::notificationName):
- 3:31 PM Changeset in webkit [142327] by
-
- 30 edits8 copies16 adds in trunk
Bring WebKit up to speed with latest Encrypted Media spec.
https://bugs.webkit.org/show_bug.cgi?id=97037
Reviewed by Eric Carlson.
Source/JavaScriptCore:
Define the ENABLE_ENCRYPTED_MEDIA_V2 setting.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
The most recent version of the Encrypted Media Extensions spec breaks functionality out of the
HTMLMediaElement and into new MediaKeys and MediaKeySession classes. Since the CDM functionality
has been pulled out of the media element, we create a proxy CDM class and factory system for
creating specific CDM key system implementations. The spec also breaks out MediaKeyEvent
into distinct event classes, MediaKeyNeededEvent and MediaKeyMessageEvent, for needkey and
keymessage events, respectively.
Tests: media/encrypted-media/encrypted-media-v2-events.html
media/encrypted-media/encrypted-media-v2-syntax.html
CDM is a proxy class (a la MediaPlayer) for a specific CDMPrivateInterface implementation. A CDM
implementation is registered with the CDMFactory and will be created if that implementation supports
the key system passed into the MediaKeys constructor. CDMSession is a pure-virtual interface exposed
by concrete CDMPrivate subclasses. Its lifetime is owned by MediaKeySession.
- Modules/encryptedmedia/CDM.cpp: Added.
(WebCore::installedCDMFactories): Initialize all the known CDM subtypes. Ports will add CDM implementations here.
(WebCore::CDM::registerCDMFactory): Registers a new CDMFactory using the passed in function pointers.
(WebCore::CDMFactoryForKeySystem): Return the first CDM factory which supports the requested key system.
(WebCore::CDM::supportsKeySystem): Walk the installed CDMs and ask if the given key system is supported.
(WebCore::CDM::supportsKeySystemMIMETypeAndCodec): Ditto, with an additional MIME type and codec string.
(WebCore::CDM::create): Simple constructor wrapper.
(WebCore::CDM::CDM): Simple constructor; calls bestCDMForKeySystem() to create it's private implementation.
(WebCore::CDM::~CDM): Simple destructor.
(WebCore::CDM::createSession): Creates a new CDMSession.
- Modules/encryptedmedia/CDM.h: Added.
(WebCore::CDM::keySystem): Simple accessor for m_keySystem.
(WebCore::CDMSession::CDMSession): Simple constructor.
(WebCore::CDMSession::~CDMSession): Simple destructor.
- Modules/encryptedmedia/CDMPrivate.h: Added.
(WebCore::CDMPrivateInterface::CDMPrivateInterface): Simple constructor.
(WebCore::CDMPrivateInterface::~CDMPrivateInterface): Simple destructor.
The new classes, MediaKeyMessageEvent and MediaKeyNeededEvent, take distinct subsets of the initializers of
the original MediaKeyMessageEvent.
- Modules/encryptedmedia/MediaKeyMessageEvent.cpp: Copied from Source/WebCore/html/MediaKeyEvent.cpp.
(WebCore::MediaKeyMessageEventInit::MediaKeyMessageEventInit): Initializer now only takes message and destinationURL
parameters.
(WebCore::MediaKeyMessageEvent::MediaKeyMessageEvent): Simple constructor.
(WebCore::MediaKeyMessageEvent::~MediaKeyMessageEvent): Simple destructor.
(WebCore::MediaKeyMessageEvent::interfaceName): Standard interfaceName.
- Modules/encryptedmedia/MediaKeyMessageEvent.h: Copied from Source/WebCore/html/MediaKeyEvent.h.
(WebCore::MediaKeyMessageEvent::create): Simple construction wrapper.
(WebCore::MediaKeyMessageEvent::message): Simple accessor for m_message.
(WebCore::MediaKeyMessageEvent::destinationURL): Simple accessor for m_destinationURL.
- Modules/encryptedmedia/MediaKeyMessageEvent.idl: Copied from Source/WebCore/html/MediaKeyEvent.idl.
- Modules/encryptedmedia/MediaKeyNeededEvent.cpp: Copied from Source/WebCore/html/MediaKeyEvent.h.
(WebCore::MediaKeyNeededEventInit::MediaKeyNeededEventInit): Initializer now only takes initData parameter.
(WebCore::MediaKeyNeededEvent::MediaKeyNeededEvent): Simple constructor.
(WebCore::MediaKeyNeededEvent::~MediaKeyNeededEvent): Simple destructor.
(WebCore::MediaKeyNeededEvent::interfaceName): Standard interfaceName.
- Modules/encryptedmedia/MediaKeyNeededEvent.h: Copied from Source/WebCore/html/MediaKeyEvent.h.
(WebCore::MediaKeyNeededEvent::create): Simple construction wrapper.
(WebCore::MediaKeyNeededEvent::initData): Simple accessor for m_initData.
- Modules/encryptedmedia/MediaKeyNeededEvent.idl: Copied from Source/WebCore/html/MediaKeyEvent.idl.
MediaKeySession is a new class that maps keys and key requests to a given session ID:
- Modules/encryptedmedia/MediaKeySession.cpp: Added.
(WebCore::MediaKeySession::create): Simple construction wrapper.
(WebCore::MediaKeySession::MediaKeySession): Simple constructor.
(WebCore::MediaKeySession::~MediaKeySession): Simple destructor; calls close().
(WebCore::MediaKeySession::setError): Simple setter for m_error;
(WebCore::MediaKeySession::close): Tell the CDM to clear any saved session keys.
(WebCore::MediaKeySession::generateKeyRequest): Start a one-shot timer, handled in keyRequestTimerFired.
(WebCore::MediaKeySession::keyRequestTimerFired): Follow the steps in the spec; ask the CDM to generate a key request.
(WebCore::MediaKeySession::addKey): Start a one-shot timer, handled in addKeyTimerFired.
(WebCore::MediaKeySession::addKeyTimerFired): Follow the steps in the spec; provide the key data to the CDM.
- Modules/encryptedmedia/MediaKeySession.h: Added.
(WebCore::MediaKeySession::keySystem): Simple accessor for m_keySystem.
(WebCore::MediaKeySession::sessionId): Simple accessor for m_sessionId.
(WebCore::MediaKeySession::error): Simple accessor for m_error;
- Modules/encryptedmedia/MediaKeySession.idl:
MediaKeySession inherits from EventTarget, and must override the pure virtual functions in that class:
- Modules/encryptedmedia/MediaKeySession.cpp: Added.
(WebCore::MediaKeySession::interfaceName):
- Modules/encryptedmedia/MediaKeySession.h: Added.
(WebCore::MediaKeySession::refEventTarget):
(WebCore::MediaKeySession::derefEventTarget):
(WebCore::MediaKeySession::eventTargetData):
(WebCore::MediaKeySession::ensureEventTargetData):
(WebCore::MediaKeySession::scriptExecutionContext):
MediaKeys is a new class that encapsulates a CDM and a number of key sessions:
- Modules/encryptedmedia/MediaKeys.cpp: Added.
(WebCore::MediaKeys::create): Throw an exception if the key system parameter is unsupported; create a CDM object
and a new MediaKeys session.
(WebCore::MediaKeys::MediaKeys): Simple constructor.
(WebCore::MediaKeys::~MediaKeys): Simple destructor.
(WebCore::MediaKeys::createSession): Follow the spec and create a new key session.
- Modules/encryptedmedia/MediaKeys.h: Added.
- Modules/encryptedmedia/MediaKeys.idl: Copied from Source/WebCore/html/MediaError.idl.
Provide a new interface to HTMLMediaElement for MediaPlayer which does not require a sessionId or a key system:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::keyNeeded):
MediaKeyError now has a systemCode parameter and member variable.
- html/MediaKeyError.h:
(WebCore::MediaKeyError::create): Take a systemCode parameter with a default (0) value.
(WebCore::MediaKeyError::MediaKeyError): Ditto.
(WebCore::MediaKeyError::systemCode): Simple accessor for m_systemCode.
- html/MediaKeyError.idl:
Add new methods to HTMLMediaElement to support MediaKeys. Support different initializer
for the MediaKeyNeededEvent.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setMediaKeys): Simple setter for m_mediaKeys.
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded): This version takes fewer parameters
than the deprecated version.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::mediaKeys): Simple accessor for m_mediaKeys.
- html/HTMLMediaElement.idl: Add the mediaKeys attribute.
Add an ENABLE(ENCRYPTED_MEDIA_V2) check to the existing ENABLE(ENCRYPTED_MEDIA) one:
- html/MediaError.h:
- html/MediaError.idl:
- platform/graphics/MediaPlayer.cpp:
(WebCore::bestMediaEngineForTypeAndCodecs):
(WebCore::MediaPlayer::supportsType):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayer::keyNeeded): This version takes fewer parameters than the
deprecated version.
Support the new version of canPlayType which takes an extra parameter:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine):
(WebCore::MediaPlayerPrivateAVFoundationObjC::extendedSupportsType):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::registerMediaEngine):
(WebCore::MediaPlayerPrivateQTKit::extendedSupportsType):
Add a mock CDM for use within DRT and WKTR to test the MediaKeys and MediaKeySession
APIs and events:
- testing/Internals.cpp:
(WebCore::Internals::initializeMockCDM): Add the MockCDM class to the CDM factories.
- testing/Internals.h:
- testing/Internals.idl: Add the initializeMockCDM() method.
- testing/MockCDM.cpp: Added.
(WebCore::MockCDM::supportsKeySystem): Only supports the 'com.webcore.mock' key system.
(WebCore::MockCDM::supportsMIMEType): Only supports the 'video/mock' mime type.
(WebCore::initDataPrefix): Static method which returns a Uint8Array containing 'mock'.
(WebCore::keyPrefix): Static method which returns a Uint8Array containing 'key'.
(WebCore::keyRequest): Static method which returns a Uint8Array containing 'request'.
(WebCore::generateSessionId): Return a monotonically increasing number.
(WebCore::MockCDMSession::MockCDMSession): Simple constructor.
(WebCore::MockCDMSession::generateKeyRequest): Ignores the parameters and returns a keyRequest() array.
(WebCore::MockCDMSession::releaseKeys): No-op.
(WebCore::MockCDMSession::addKey): Checks that the key starts with the keyPrefix() array.
- testing/MockCDM.h: Added.
(WebCore::MockCDM::create):
(WebCore::MockCDM::~MockCDM): Simple destructor.
(WebCore::MockCDM::MockCDM): Simple constructor.
Add the new classes to the built system:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
Miscelaneous changes:
- dom/EventNames.in: Add the two new event types, MediaKeyMessageEvent and MediaKeyNeededEvent.
- dom/EventTargetFactory.in: Add the new EventTarget, MediaKeySession.
- page/DOMWindow.idl: Add constructors for the new classes to the window object.
Source/WTF:
Define the ENABLE_ENCRYPTED_MEDIA_V2 setting.
- wtf/Platform.h:
LayoutTests:
Added new tests for the updated Encrypted Media Extensions spec.
- media/encrypted-media/encrypted-media-v2-events-expected.txt: Added.
- media/encrypted-media/encrypted-media-v2-events.html: Added.
- media/encrypted-media/encrypted-media-v2-syntax-expected.txt: Added.
- media/encrypted-media/encrypted-media-v2-syntax.html: Added.
- platform/Chromium/TestExpectations: Skip the new media/encrypted-media/ v2 tests.
- platform/mac/media/encrypted-media/encrypted-media-can-play-type-expected.txt: Added.
- 3:04 PM Changeset in webkit [142326] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Fix the build on !Mac after r142314.
https://bugs.webkit.org/show_bug.cgi?id=109327
Reviewed by Benjamin Poulain.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformPreInitialize): Add a stub for
the newly-added function.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformPreInitialize):
(WebKit):
- 3:02 PM Changeset in webkit [142325] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Why does this test always fail to be correctly rebaselined during mass updates?
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- 2:48 PM Changeset in webkit [142324] by
-
- 3 edits in trunk/LayoutTests
IndexedDB: De-flake open-during-transaction layout test
https://bugs.webkit.org/show_bug.cgi?id=109072
Reviewed by Tony Chang.
This test was observed to be flaky in local runs; sometimes the transaction
would terminate after the third open() call rather than the second, resulting
in a TEXT difference. Added code to keep the transaction alive until all of
the open() calls are complete, and changed expectations to match.
- storage/indexeddb/open-during-transaction-expected.txt:
- storage/indexeddb/resources/open-during-transaction.js:
- 2:35 PM Changeset in webkit [142323] by
-
- 11 edits1 add4 deletes in trunk/LayoutTests
[Chromium] Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Cleaning up the remaining failures. With luck this is it, although probably not.
- platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
- platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.png:
- platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
- platform/chromium-mac-lion/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-mac-lion/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-win-xp/media/video-zoom-controls-expected.png: Removed.
- platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-win/media/video-zoom-controls-expected.png:
- 2:18 PM Changeset in webkit [142322] by
-
- 611 edits3 adds1 delete in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 19. The last, except for cleanup. Too many to list.
- platform/chromium/TestExpectations:
- 1:46 PM Changeset in webkit [142321] by
-
- 457 edits10 adds14 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 18. SVG all but dynamic-updates and custom tests. List omitted
except for changes touching other ports.
- platform/chromium/TestExpectations:
- platform/efl-wk2/svg/css/circle-in-mask-with-shadow-expected.png: Added.
- platform/efl-wk2/svg/css/group-with-shadow-expected.png: Added.
- platform/efl-wk2/svg/css/text-gradient-shadow-expected.png: Added.
- platform/efl/svg/batik/text/textEffect-expected.png: Removed.
- platform/efl/svg/batik/text/textEffect2-expected.png: Removed.
- platform/efl/svg/batik/text/textProperties2-expected.png: Removed.
- platform/efl/svg/css/circle-in-mask-with-shadow-expected.png: Removed.
- platform/efl/svg/css/group-with-shadow-expected.png: Removed.
- platform/efl/svg/css/text-gradient-shadow-expected.png: Removed.
- platform/mac/svg/batik/text/textPosition2-expected.txt: Removed.
- platform/win-future/svg/batik/text/textPosition2-expected.txt: Added.
- svg/batik/text/textPosition2-expected.txt: Replaced.
- 1:45 PM Changeset in webkit [142320] by
-
- 9 edits8 copies1 move in trunk/Source/WebCore
Refactor platform-specific code in SpeechSynthesis
https://bugs.webkit.org/show_bug.cgi?id=107414
Reviewed by Sam Weinig.
Refactor WebSpeech code to use a platform mechanism to provide access to platform resources.
- Modules/speech/DOMWindowSpeechSynthesis.cpp:
(WebCore::DOMWindowSpeechSynthesis::from):
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore):
(WebCore::SpeechSynthesis::voicesDidChange):
(WebCore::SpeechSynthesis::getVoices):
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::speaking):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::speak):
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::pause):
(WebCore::SpeechSynthesis::resume):
- Modules/speech/SpeechSynthesis.h:
(WebCore):
(SpeechSynthesis):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
- Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
- Modules/speech/SpeechSynthesisUtterance.h:
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::voiceURI):
(WebCore::SpeechSynthesisUtterance::setVoiceURI):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::platformUtterance):
- Modules/speech/SpeechSynthesisVoice.cpp:
(WebCore::SpeechSynthesisVoice::create):
(WebCore::SpeechSynthesisVoice::SpeechSynthesisVoice):
- Modules/speech/SpeechSynthesisVoice.h:
(SpeechSynthesisVoice):
(WebCore::SpeechSynthesisVoice::voiceURI):
(WebCore::SpeechSynthesisVoice::name):
(WebCore::SpeechSynthesisVoice::lang):
(WebCore::SpeechSynthesisVoice::localService):
(WebCore::SpeechSynthesisVoice::isDefault):
- Modules/speech/mac/SpeechSynthesisMac.mm:
- WebCore.xcodeproj/project.pbxproj:
- platform/PlatformSpeechSynthesis.h: Added.
(WebCore):
(PlatformSpeechSynthesis):
- platform/PlatformSpeechSynthesisUtterance.cpp: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::PlatformSpeechSynthesisUtterance):
- platform/PlatformSpeechSynthesisUtterance.h: Added.
(WebCore):
(PlatformSpeechSynthesisUtteranceClient):
(WebCore::PlatformSpeechSynthesisUtteranceClient::~PlatformSpeechSynthesisUtteranceClient):
(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::text):
(WebCore::PlatformSpeechSynthesisUtterance::setText):
(WebCore::PlatformSpeechSynthesisUtterance::lang):
(WebCore::PlatformSpeechSynthesisUtterance::setLang):
(WebCore::PlatformSpeechSynthesisUtterance::voiceURI):
(WebCore::PlatformSpeechSynthesisUtterance::setVoiceURI):
(WebCore::PlatformSpeechSynthesisUtterance::volume):
(WebCore::PlatformSpeechSynthesisUtterance::setVolume):
(WebCore::PlatformSpeechSynthesisUtterance::rate):
(WebCore::PlatformSpeechSynthesisUtterance::setRate):
(WebCore::PlatformSpeechSynthesisUtterance::pitch):
(WebCore::PlatformSpeechSynthesisUtterance::setPitch):
- platform/PlatformSpeechSynthesisVoice.cpp: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):
- platform/PlatformSpeechSynthesisVoice.h: Added.
(WebCore):
(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::voiceURI):
(WebCore::PlatformSpeechSynthesisVoice::name):
(WebCore::PlatformSpeechSynthesisVoice::lang):
(WebCore::PlatformSpeechSynthesisVoice::localService):
(WebCore::PlatformSpeechSynthesisVoice::isDefault):
- platform/PlatformSpeechSynthesizer.cpp: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
- platform/PlatformSpeechSynthesizer.h: Added.
(WebCore):
(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizerClient::~PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::voiceList):
- platform/mac/PlatformSpeechSynthesisMac.mm: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesis::create):
(WebCore::PlatformSpeechSynthesis::PlatformSpeechSynthesis):
(WebCore::PlatformSpeechSynthesis::platformSpeak):
- platform/mac/PlatformSpeechSynthesizerMac.mm: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::speak):
- 1:41 PM Changeset in webkit [142319] by
-
- 8 edits in trunk/Source/JavaScriptCore
Objective-C API for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=105889
Reviewed by Joseph Pecoraro
Following up on review comments, mostly typos.
- API/JSBlockAdaptor.h:
- API/JSBlockAdaptor.mm:
(-[JSBlockAdaptor blockFromValue:inContext:withException:]):
- API/JSContext.h:
- API/JSExport.h:
- API/JSValue.h:
- API/JSValue.mm:
- API/JSWrapperMap.mm:
(selectorToPropertyName):
(-[JSWrapperMap classInfoForClass:]):
(-[JSWrapperMap wrapperForObject:]):
- 1:18 PM Changeset in webkit [142318] by
-
- 666 edits2 adds in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 17. SVG W3C tests. List omitted.
- platform/chromium/TestExpectations:
- 1:04 PM Changeset in webkit [142317] by
-
- 2 edits in trunk/LayoutTests
[Mac] Unreviewed, fix test expectation for a test only crashing in debug mode
- platform/mac/TestExpectations:
- 1:00 PM Changeset in webkit [142316] by
-
- 37 edits33 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 16. Everything done but SVG, and cleanup.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug138725-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug18359-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug2479-2-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug2479-3-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug26178-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug28928-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug29326-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug33855-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug39209-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug4382-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug4429-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug44505-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug46368-1-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug46368-2-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug51037-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug51727-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug52505-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug52506-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug60749-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug68912-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug7342-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug92647-2-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug96334-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/collapsing_borders: Removed.
- platform/chromium-linux-x86/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/core: Removed.
- platform/chromium-linux-x86/tables/mozilla/core/margins-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/dom: Removed.
- platform/chromium-linux-x86/tables/mozilla/dom/tableDom-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/other: Removed.
- platform/chromium-linux-x86/tables/mozilla/other/move_row-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/core: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions1-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions2-expected.png: Removed.
- platform/chromium-linux-x86/transforms/2d/zoom-menulist-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug26178-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug51727-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug52505-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug52506-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug68912-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
- platform/chromium-linux/tables/mozilla/core/margins-expected.png:
- platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-linux/tables/mozilla/other/move_row-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
- platform/chromium-linux/transforms/2d/zoom-menulist-expected.png:
- platform/chromium/TestExpectations:
- 12:54 PM Changeset in webkit [142315] by
-
- 48 edits12 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 15. platform/. Too many to list.
- platform/chromium/TestExpectations:
- 12:46 PM Changeset in webkit [142314] by
-
- 6 edits in trunk/Source/WebKit2
Work around a bug in Flash where NSException objects can be released too early
https://bugs.webkit.org/show_bug.cgi?id=109242
<rdar://problem/13003470>
Reviewed by Darin Adler.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::determineQuirks):
Set the new plug-in quirk.
- Shared/Plugins/PluginQuirks.h:
Add a new plug-in quirk.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::initialize):
Call platformPreInitialize.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
(NetscapePlugin):
Add platformPreInitialize.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NSException_release):
Add new empty function.
(WebKit::NetscapePlugin::platformPreInitialize):
Patch -[NSException release] to be a no-op.
- 12:45 PM Changeset in webkit [142313] by
-
- 178 edits1 add28 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 14. Remaining tests up to platform in sorted order. Too many to list.
- platform/chromium/TestExpectations:
- 12:35 PM Changeset in webkit [142312] by
-
- 153 edits13 adds62 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 13. Last of the fast tests. Too many to list. Still listing efl changes.
- platform/chromium/TestExpectations:
- platform/chromium/fast/repaint/gradients-em-stops-repaint-expected.png: Removed.
- platform/efl-wk2/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
- platform/efl-wk2/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
- platform/efl-wk2/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
- platform/efl-wk2/fast/repaint/shadow-multiple-vertical-expected.png: Added.
- platform/efl-wk2/fast/text: Added.
- platform/efl-wk2/fast/text/stroking-decorations-expected.png: Added.
- platform/efl-wk2/fast/text/stroking-expected.png: Added.
- platform/efl-wk2/fast/transforms: Added.
- platform/efl-wk2/fast/transforms/shadows-expected.png: Added.
- platform/efl-wk2/fast/transforms/transformed-focused-text-input-expected.png: Added.
- platform/efl/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
- platform/efl/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
- platform/efl/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
- platform/efl/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
- platform/efl/fast/text/stroking-decorations-expected.png: Removed.
- platform/efl/fast/text/stroking-expected.png: Removed.
- platform/efl/fast/transforms/shadows-expected.png: Removed.
- platform/efl/fast/transforms/transformed-focused-text-input-expected.png: Removed.
- platform/mac/fast/replaced/three-selects-break-expected.png: Removed.
- 12:24 PM Changeset in webkit [142311] by
-
- 4 edits in trunk/Source/WebCore
Put snapshotting label text into localizable strings
https://bugs.webkit.org/show_bug.cgi?id=108268
Reviewed by Simon Fraser.
In preparation for a snapshotted plug-in using a ShadowRoot, allow
its label to be localized.
- English.lproj/Localizable.strings:
- platform/LocalizedStrings.cpp:
(WebCore::snapshottedPlugInLabelTitle): New method for returning title.
(WebCore::snapshottedPlugInLabelSubtitle): New method for returning subtitle.
- platform/LocalizedStrings.h:
- 12:23 PM Changeset in webkit [142310] by
-
- 4 edits in trunk/Source
Do not register autostart for plugins from file:// (or nowhere)
https://bugs.webkit.org/show_bug.cgi?id=108271
Reviewed by Tim Horton.
Source/WebCore:
If the page url origin is treated as a local URL, don't attempt
to add it to the auto-start list.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot):
Source/WebKit2:
If the pageOrigin is the empty string don't add
it to the auto-start origin list for snapshotting.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::addPlugInAutoStartOrigin):
- 12:18 PM Changeset in webkit [142309] by
-
- 2 edits in trunk
Update .gitignore for vim swap files.
https://bugs.webkit.org/show_bug.cgi?id=109252
Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-08
Reviewed by Dirk Pranke.
When opening the same files multiple with vim, vim creates a .*.sw[a-p]
file as the swap file.
- .gitignore:
- 11:48 AM Changeset in webkit [142308] by
-
- 266 edits4 adds94 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 12. More fast tests. Too many to list.
- platform/chromium/TestExpectations:
- 11:41 AM Changeset in webkit [142307] by
-
- 20 edits3 adds20 deletes in trunk
Unreviewed. VS2010 WebKit Solution touchups.
Remove all .user files.
Add some build scripts to QTMovieWin that were forgotten about earlier.
Update the OpenSource WebKit solution to include DumpRenderTree and related projects.
- WebKit.vcxproj: Added properties svn:ignore, svn:ignore, svn:ignore, svn:ignore and svn:ignore.
- WebKit.vcxproj/Interfaces: Added property svn:ignore.
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj.user: Removed.
- WebKit.vcxproj/WebKit: Added property svn:ignore.
- WebKit.vcxproj/WebKit.sln:
- WebKit.vcxproj/WebKit/WebKit.vcxproj.user: Removed.
- WebKit.vcxproj/WebKitExportGenerator: Added property svn:ignore.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.user: Removed.
- WebKit.vcxproj/WebKitGUID: Added property svn:ignore.
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.user: Removed.
- WebCore.vcxproj: Added properties svn:ignore and svn:ignore.
- WebCore.vcxproj/QTMovieWin: Added property svn:ignore.
- WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj.user: Removed.
- WebCore.vcxproj/QTMovieWin/QTMovieWinPostBuild.cmd: Added.
- WebCore.vcxproj/QTMovieWin/QTMovieWinPreBuild.cmd: Added.
- WebCore.vcxproj/QTMovieWin/QTMovieWinPreLink.cmd: Added.
- WebCore.vcxproj/WebCore.vcxproj.user: Removed.
- WebCore.vcxproj/WebCoreGenerated.vcxproj.user: Removed.
- JavaScriptCore.vcxproj: Added properties svn:ignore, svn:ignore, svn:ignore, svn:ignore, svn:ignore, svn:ignore, svn:ignore and svn:ignore.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator: Added property svn:ignore.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly: Added property svn:ignore.
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets: Added property svn:ignore.
- JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor: Added property svn:ignore.
- JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/jsc: Added property svn:ignore.
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/testRegExp: Added property svn:ignore.
- JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/testapi: Added property svn:ignore.
- JavaScriptCore.vcxproj/testapi/testapi.vcxproj.user: Removed.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Added property svn:ignore.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Added property svn:ignore.
- WinLauncher/WinLauncher.vcxproj: Added property svn:ignore.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.user: Removed.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.user: Removed.
- WTF.vcxproj: Added property svn:ignore.
- WTF.vcxproj/WTF.vcxproj.user: Removed.
- WTF.vcxproj/WTFGenerated.vcxproj.user: Removed.
- 11:30 AM Changeset in webkit [142306] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Flakey test expectations update
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 11:30 AM Changeset in webkit [142305] by
-
- 7 edits in trunk/Source
Use WeakPtrs to communicate between the HTMLDocumentParser and the BackgroundHTMLParser
https://bugs.webkit.org/show_bug.cgi?id=107190
Reviewed by Eric Seidel.
Source/WebCore:
This patch replaces the parser map with WeakPtr. We now use WeakPtrs to
communicate from the main thread to the background thread. (We were
already using WeakPtrs to communicate from the background thread to the
main thread.) This change lets us remove a bunch of boilerplate code.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::stop):
(WebCore):
- html/parser/BackgroundHTMLParser.h:
(WebCore::BackgroundHTMLParser::create):
(BackgroundHTMLParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didFailSpeculation):
(WebCore::HTMLDocumentParser::startBackgroundParser):
(WebCore::HTMLDocumentParser::stopBackgroundParser):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::finish):
- html/parser/HTMLDocumentParser.h:
(WebCore):
(HTMLDocumentParser):
Source/WTF:
Add the ability to create an unbound weak reference. This facility lets
you start sending messages to a WeakPtr on another thread before the
object backing the WeakPtr has actually been created.
- wtf/WeakPtr.h:
(WTF::WeakReference::createUnbound):
(WTF::WeakReference::bindTo):
(WeakReference):
(WTF::WeakReference::WeakReference):
(WTF::WeakPtr::WeakPtr):
(WeakPtr):
(WTF::WeakPtrFactory::WeakPtrFactory):
(WeakPtrFactory):
(WTF::WeakPtrFactory::revokeAll):
- 11:09 AM Changeset in webkit [142304] by
-
- 274 edits17 adds80 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 11. Some fast tests. Elided.
- platform/chromium/TestExpectations:
- 10:45 AM Changeset in webkit [142303] by
-
- 2 edits3 copies1 move35 adds in trunk
DumpRenderTree, ImageDiff and TestNetscapePlugin projects, property sheets and resources for VS2010 solution.
https://bugs.webkit.org/show_bug.cgi?id=107034.
Reviewed by Brent Fulgham.
- DumpRenderTree/DumpRenderTree.vcxproj: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPostBuild.cmd: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def: Copied from DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc: Copied from DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPostBuild.cmd: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h: Copied from DumpRenderTree/TestNetscapePlugIn/win/resource.h.
- DumpRenderTree/TestNetscapePlugIn/Tests/win/CallJSThatDestroysPlugin.cpp: Copied from DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp.
- DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Removed.
VS2010 WebCore TestSupport project.
- WebCore.vcxproj/WebCoreTestSupport.vcxproj: Added.
- WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters: Added.
- 10:42 AM GStreamer edited by
- (diff)
- 10:11 AM GStreamer/GStreamerOnMac created by
- 10:09 AM Changeset in webkit [142302] by
-
- 4 edits1 add2 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 10. Mac 10.6 results were wrong. This simplifies things a lot.
- fast/repaint/scale-page-shrink-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/background-scaling-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/scale-page-shrink-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/transform-absolute-in-positioned-container-expected.png:
- platform/chromium/fast/repaint/scale-page-shrink-expected.png: Removed.
- platform/mac/fast/repaint/scale-page-shrink-expected.png: Removed.
- 10:08 AM GStreamer created by
- 10:06 AM Changeset in webkit [142301] by
-
- 19 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 9. These were rebaselined earlier before all the bots were done.
- platform/chromium-mac-lion/svg/batik/text/smallFonts-expected.png:
- platform/chromium-mac-lion/svg/batik/text/textDecoration-expected.png:
- platform/chromium-mac-lion/svg/batik/text/textFeatures-expected.png:
- platform/chromium-mac-lion/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium-mac-lion/svg/text/selection-styles-expected.png:
- platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
- platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
- platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
- platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
- platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
- platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
- platform/chromium-mac/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium-mac/svg/text/selection-styles-expected.png:
- platform/chromium-win/svg/batik/text/smallFonts-expected.png:
- platform/chromium-win/svg/batik/text/textDecoration-expected.png:
- platform/chromium-win/svg/batik/text/textFeatures-expected.png:
- platform/chromium-win/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium-win/svg/text/selection-styles-expected.png:
- 10:04 AM Changeset in webkit [142300] by
-
- 1 edit2 adds2 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 8. Outstanding mac failure.
- editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
- platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
- platform/chromium/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
- platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
- 10:01 AM Changeset in webkit [142299] by
-
- 1 edit2 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 7. Outstanding failing linux tests
- platform/chromium-linux-x86/fast/forms/button-generated-content-expected.png: Removed.
- platform/chromium-linux-x86/fast/forms/button-inner-block-reuse-expected.png: Removed.
- 9:59 AM Changeset in webkit [142298] by
-
- 6 edits5 adds in trunk/Source
[GTK] Add an experimental gyp build
https://bugs.webkit.org/show_bug.cgi?id=109003
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-08
Reviewed by Gustavo Noronha Silva.
Source/JavaScriptCore:
- JavaScriptCore.gypi: Update the list of source files to include those
necessary for the GTK+ build.
Source/WebKit/gtk:
Add an experimental gyp build for WebKitGTK+. Currently only libjavascriptcoregtk,
jsc, and minidom build (and only on platforms for that support bash). To use the
build simply run:
$ gyp --generator-output=build --depth=. Source/WebKit/gtk/gyp/JavaScriptCore.gyp
Then enter the build directory and run make.
- gyp/Configuration.gypi: Added.
- gyp/JavaScriptCore.gyp: Added.
- gyp/WTF.gyp: Added.
- gyp/generate-derived-sources.sh: Added.
Source/WTF:
- WTF.gyp/WTF.gyp: Filter out MetaAllocator.(cpp/h) from the Chromium
build. It's only necessary for GTK+.
- WTF.gypi: Add MetaAllocator to the build for WebKitGTK+.
- 9:58 AM Changeset in webkit [142297] by
-
- 3 edits in trunk/Source/WebCore
[GTK][AC] GraphicsLayerActor code clean up after clutter version up.
https://bugs.webkit.org/show_bug.cgi?id=109304
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-08
Reviewed by Gustavo Noronha Silva.
This patch cleans up GraphicsLayerActor functions by using new clutter apis
and makes existing functions simple & readable.
No new tests since no change in functionality
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(_GraphicsLayerActorPrivate):
(graphicsLayerActorApplyTransform):
(graphicsLayerActorPaint):
(graphicsLayerActorDraw):
(graphicsLayerActorUpdateTexture):
(drawLayerContents):
(graphicsLayerActorNew):
(graphicsLayerActorInvalidateRectangle):
(graphicsLayerActorSetTransform):
(graphicsLayerActorSetAnchorPoint):
(graphicsLayerActorGetAnchorPoint):
(graphicsLayerActorSetScrollPosition):
- platform/graphics/clutter/PlatformClutterAnimation.h:
- 9:58 AM Changeset in webkit [142296] by
-
- 2 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 6. Outstanding failing linux tests
- platform/chromium-linux/fast/writing-mode/japanese-rl-text-expected.png:
- 9:55 AM Changeset in webkit [142295] by
-
- 1126 edits2 adds188 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 5. Editing expectations.
File list truncated to remove the hundreds of files that have been updated.
- platform/chromium/TestExpectations: Removed the temp expectations and re-added one mac failure case
- platform/efl-wk1/editing/selection: Added.
- platform/efl-wk1/editing/selection/move-by-character-6-expected.png: Added.
- platform/efl/editing/selection/move-by-character-6-expected.png: Removed.
- 9:35 AM Changeset in webkit [142294] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Update platform specific expected files after r142280.
- 9:32 AM Changeset in webkit [142293] by
-
- 4 edits in tags/Safari-537.30.1/Source
Versioning.
- 9:29 AM Changeset in webkit [142292] by
-
- 1 copy in tags/Safari-537.30.1
New Tag.
- 9:28 AM Changeset in webkit [142291] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Remove effect-reference-hw from test expectations, since it's now passing.
https://bugs.webkit.org/show_bug.cgi?id=104289
- platform/chromium/TestExpectations:
- 9:12 AM Changeset in webkit [142290] by
-
- 5 edits in trunk
[Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
https://bugs.webkit.org/show_bug.cgi?id=109272
Reviewed by Kentaro Hara.
Source/WebKit/chromium:
We enabled this flag for desktop Chromium, but disabled the feature by a
runtime flag. We disables the compile flag too because we have no plan
to ship it in near future.
- features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.
LayoutTests:
- platform/chromium/TestExpectations:
Skip fast/forms/datetime and datetime-multiple-fields
- 9:05 AM Changeset in webkit [142289] by
-
- 4 edits in trunk
Source/WebCore: Fix and test for missing return statement
RTCPeerConnection.getStats() failed when remote stats were instantiated.
https://bugs.webkit.org/show_bug.cgi?id=109292
Patch by Harald Alvestrand <hta@google.com> on 2013-02-08
Reviewed by Adam Barth.
Tested by extending the existing mock's behaviour.
- Modules/mediastream/RTCStatsReport.cpp:
(WebCore::RTCStatsReport::addElement):
Tools: Fix and test for missing return
RTCPeerConnection.getStats() fails when remote stats are instantiated.
https://bugs.webkit.org/show_bug.cgi?id=109292
Patch by Harald Alvestrand <hta@google.com> on 2013-02-08
Reviewed by Adam Barth.
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::getStats):
- 8:57 AM Changeset in webkit [142288] by
-
- 6 edits2 deletes in trunk
MediaStream API: Removing the deprecated WebMediaStreamDescriptor and WebMediaStreamComponent shims
https://bugs.webkit.org/show_bug.cgi?id=109296
Reviewed by Adam Barth.
Source/Platform:
- Platform.gypi:
- chromium/public/WebMediaStreamComponent.h: Removed.
- chromium/public/WebMediaStreamDescriptor.h: Removed.
Tools:
- DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.cpp:
(MockWebRTCDTMFSenderHandler::MockWebRTCDTMFSenderHandler):
- DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.h:
(MockWebRTCDTMFSenderHandler):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::createDTMFSender):
- 8:40 AM Changeset in webkit [142287] by
-
- 3 edits in trunk/Source/WebCore
[Text Autosizing] Split isAutosizingCluster into three independent checks
https://bugs.webkit.org/show_bug.cgi?id=109093
Refactoring to create more flexible version of isAutosizingCluster since there're more types
of autosizing cluster now: narrower than the parent cluster, wider than the parent cluster
and the one that doesn't depend on the parent cluster.
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-08
Reviewed by Kenneth Rohde Christiansen.
Refactoring, no test changes.
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::isNarrowDescendant):
Separate check for the container to be of the narrow-descendant type. Was a part of
isAutosizingCluster().
(WebCore::TextAutosizer::isWiderDescendant):
Separate check for the container to be of the wider-descendant type. Was a part of
isAutosizingCluster().
(WebCore::TextAutosizer::isIndependentDescendant):
Separate check for the container to be autosized separately from the ancestor cluster.
Checks for conditions independent of the aforementioned cluster.
(WebCore::TextAutosizer::isAutosizingCluster):
Handy method to check all separate conditions together.
(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):
(WebCore::TextAutosizer::findFirstTextLeafNotInCluster):
The methods above were updated to use new functions/arguments.
- rendering/TextAutosizer.h:
Updated/added method definitions.
- 8:27 AM Changeset in webkit [142286] by
-
- 46 edits6 adds18 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 4. CSS expectations.
- platform/chromium-linux-x86/css1/box_properties: Removed.
- platform/chromium-linux-x86/css1/box_properties/acid_test-expected.png: Removed.
- platform/chromium-linux-x86/css2.1/t09-c5526c-display-00-e-expected.png: Removed.
- platform/chromium-linux-x86/css3/images: Removed.
- platform/chromium-linux-x86/css3/images/cross-fade-overflow-position-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/html: Removed.
- platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-161-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-19b-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-25-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-64-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-70-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-161-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-25-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-64-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-70-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-161-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-19b-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-25-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-64-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-70-expected.png: Removed.
- platform/chromium-linux/compositing/overflow/theme-affects-visual-overflow-expected.png:
- platform/chromium-linux/compositing/video/video-controls-layer-creation-expected.png:
- platform/chromium-linux/css1/box_properties/acid_test-expected.png:
- platform/chromium-linux/css2.1/t0505-c16-descendant-01-e-expected.png:
- platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/chromium-linux/css3/images/cross-fade-overflow-position-expected.png: Removed.
- platform/chromium-linux/css3/masking/clip-path-circle-filter-expected.png:
- platform/chromium-linux/css3/masking/clip-path-circle-overflow-expected.png:
- platform/chromium-linux/css3/masking/clip-path-ellipse-expected.png:
- platform/chromium-linux/css3/selectors3/html/css3-modsel-161-expected.png:
- platform/chromium-linux/css3/selectors3/html/css3-modsel-19b-expected.png:
- platform/chromium-linux/css3/selectors3/html/css3-modsel-25-expected.png:
- platform/chromium-linux/css3/selectors3/html/css3-modsel-64-expected.png:
- platform/chromium-linux/css3/selectors3/html/css3-modsel-70-expected.png:
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-161-expected.png:
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-25-expected.png:
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-64-expected.png:
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-70-expected.png:
- platform/chromium-linux/css3/selectors3/xml/css3-modsel-161-expected.png:
- platform/chromium-linux/css3/selectors3/xml/css3-modsel-19b-expected.png:
- platform/chromium-linux/css3/selectors3/xml/css3-modsel-25-expected.png:
- platform/chromium-linux/css3/selectors3/xml/css3-modsel-64-expected.png:
- platform/chromium-linux/css3/selectors3/xml/css3-modsel-70-expected.png:
- platform/chromium-mac-lion/compositing/video/video-controls-layer-creation-expected.png:
- platform/chromium-mac-lion/css2.1/t0505-c16-descendant-01-e-expected.png:
- platform/chromium-mac-lion/css3/images: Removed.
- platform/chromium-mac-lion/css3/images/cross-fade-overflow-position-expected.png: Removed.
- platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/video/video-controls-layer-creation-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t0505-c16-descendant-01-e-expected.png:
- platform/chromium-mac-snowleopard/css3/images/cross-fade-overflow-position-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
- platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png:
- platform/chromium-mac/css2.1/t0505-c16-descendant-01-e-expected.png:
- platform/chromium-mac/css2.1/t0505-c16-descendant-01-e-expected.txt: Added.
- platform/chromium-mac/css3/images/cross-fade-overflow-position-expected.png:
- platform/chromium-mac/css3/masking/clip-path-circle-filter-expected.png:
- platform/chromium-mac/css3/masking/clip-path-circle-overflow-expected.png:
- platform/chromium-mac/css3/masking/clip-path-ellipse-expected.png:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-15c-expected.png:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-15c-expected.txt:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-15c-expected.png:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-15c-expected.txt:
- platform/chromium-win-xp/css3/images: Removed.
- platform/chromium-win-xp/css3/images/cross-fade-overflow-position-expected.png: Removed.
- platform/chromium-win-xp/css3/selectors3: Removed.
- platform/chromium-win/compositing/video/video-controls-layer-creation-expected.png:
- platform/chromium-win/css2.1/t0505-c16-descendant-01-e-expected.png:
- platform/chromium-win/css2.1/t0505-c16-descendant-01-e-expected.txt:
- platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png:
- platform/chromium-win/css3/masking/clip-path-circle-filter-expected.png:
- platform/chromium-win/css3/masking/clip-path-circle-overflow-expected.png:
- platform/chromium-win/css3/masking/clip-path-ellipse-expected.png:
- platform/chromium-win/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
- platform/chromium-win/css3/selectors3/xhtml/css3-modsel-15c-expected.txt: Added.
- platform/chromium/TestExpectations:
- platform/chromium/css2.1/t0505-c16-descendant-01-e-expected.txt: Removed.
- platform/chromium/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Removed.
- platform/chromium/css3/selectors3/xhtml/css3-modsel-15c-expected.txt: Removed.
- 8:17 AM Changeset in webkit [142285] by
-
- 3 edits in trunk
[GTK] Include files from DerivedSources/webkitdom for introspection
https://bugs.webkit.org/show_bug.cgi?id=108631
Patch by Tomas Popela <tpopela@redhat.com> on 2013-02-08
Reviewed by Martin Robinson.
Include files from DerivedSources/webkitdom for introspection
- /Source/WebKit/gtk/GNUmakefile.am:
- /Source/WebKit2/GNUmakefile.am:
- 8:15 AM Changeset in webkit [142284] by
-
- 2 edits9 adds in trunk
[GTK] Split configure.ac into reusable portions
https://bugs.webkit.org/show_bug.cgi?id=109246
Reviewed by Philippe Normand.
Split up configure.ac into sections based on different "phases"
of configuration. This should make it easier to find what you are
looking for as well as creating a "right" place to put things.
A nice side effect of this is that we can share the different
modules with a gyp build.
- Source/autotools/CheckSystemAndBasicDependencies.m4: Added.
- Source/autotools/FindDependencies.m4: Added.
- Source/autotools/PrintBuildConfiguration.m4: Added.
- Source/autotools/ReadCommandLineArguments.m4: Added.
- Source/autotools/SetupAutoconfHeader.m4: Added.
- Source/autotools/SetupAutomake.m4: Added.
- Source/autotools/SetupCompilerFlags.m4: Added.
- Source/autotools/SetupLibtool.m4: Added.
- Source/autotools/Versions.m4: Added.
- configure.ac:
- 8:09 AM Changeset in webkit [142283] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Extension sever should use Workspace.projectForType() instead of Workspace.project()
https://bugs.webkit.org/show_bug.cgi?id=109301
Reviewed by Alexander Pavlov.
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onGetPageResources):
- 8:09 AM Changeset in webkit [142282] by
-
- 22 edits6 adds9 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 3. Remaining expected failures that had platform-specific supppressions
- platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Removed.
- platform/chromium-linux-x86/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
- platform/chromium-linux/fast/css/background-clip-radius-values-expected.png:
- platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
- platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.png:
- platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png:
- platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
- platform/chromium-mac-lion/editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
- platform/chromium-mac-lion/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Added.
- platform/chromium-mac-lion/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-mac-lion/fast/dom/52776-expected.png:
- platform/chromium-mac-lion/fast/frames/iframe-scaling-with-scroll-expected.png:
- platform/chromium-mac-lion/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/52776-expected.png:
- platform/chromium-mac-snowleopard/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
- platform/chromium-mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Added.
- platform/chromium-mac/fast/css/background-clip-radius-values-expected.png:
- platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-mac/fast/dom/52776-expected.png:
- platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png:
- platform/chromium-mac/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
- platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Removed.
- platform/chromium-win-xp/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
- platform/chromium-win/fast/css/background-clip-radius-values-expected.png:
- platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
- platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png:
- platform/chromium-win/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/editing/pasteboard/emacs-cntl-y-001-expected.png: Removed.
- platform/chromium/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Removed.
- 8:04 AM Changeset in webkit [142281] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: simplify Memory.getDOMNodeCount implementation
https://bugs.webkit.org/show_bug.cgi?id=108821
Reviewed by Alexander Pavlov.
Removed Memory.getDOMNodeCount command from the protocol. Memory.getDOMCounters
should be used instead.
- inspector/Inspector.json:
- inspector/InspectorMemoryAgent.cpp:
- inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):
- 7:59 AM Changeset in webkit [142280] by
-
- 9 edits1 copy1 add in trunk/LayoutTests
[Qt] Reviewin Qt TestExpectations. Rebaseline and unskip passing tests.
- platform/qt/TestExpectations:
- platform/qt/svg/css/arrow-with-shadow-expected.png:
- platform/qt/svg/css/arrow-with-shadow-expected.txt:
- platform/qt/svg/css/clippath-with-shadow-expected.png:
- platform/qt/svg/css/clippath-with-shadow-expected.txt:
- platform/qt/svg/css/composite-shadow-text-expected.png:
- platform/qt/svg/custom/simple-text-double-shadow-expected.png:
- platform/qt/svg/custom/simple-text-double-shadow-expected.txt:
- platform/qt/svg/repaint/repaint-webkit-svg-shadow-expected.png: Copied from LayoutTests/platform/qt/svg/css/clippath-with-shadow-expected.png.
- platform/qt/svg/repaint/repaint-webkit-svg-shadow-expected.txt: Added.
- 7:46 AM Changeset in webkit [142279] by
-
- 16 edits2 adds2 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 2. Failing Linux tests with no expectations
- platform/chromium-linux/fast/forms/button-generated-content-expected.png:
- platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.png:
- platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.png:
- platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
- platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/chromium-linux/fast/text/justify-ideograph-vertical-expected.png:
- platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-lr-text-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png:
- platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
- platform/chromium-linux/svg/batik/text/textDecoration-expected.png:
- platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
- platform/chromium-linux/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium-linux/svg/text/selection-styles-expected.png:
- platform/efl-wk2/fast/repaint: Added.
- platform/efl-wk2/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
- platform/efl/fast/repaint/japanese-rl-selection-clear-expected.png: Removed.
- platform/efl/svg/batik/text/textDecoration-expected.png: Removed.
- 7:44 AM Changeset in webkit [142278] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: refactor MemoryStatistics.js
https://bugs.webkit.org/show_bug.cgi?id=109299
Reviewed by Vsevolod Vlasov.
Extracted functionality specific to DOM counter graphs drawing into
separate methods on MemoryStatistics class.
Introduced CounterUIBase base class for DOMCounterUI that contains
functionality which can be shared with native memory graph.
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics):
(WebInspector.CounterUIBase):
(WebInspector.CounterUIBase.prototype.updateCurrentValue):
(WebInspector.CounterUIBase.prototype.clearCurrentValueAndMarker):
(WebInspector.CounterUIBase.prototype.get visible):
(WebInspector.DOMCounterUI):
(WebInspector.DOMCounterUI.prototype.discardImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._onMouseOut):
(WebInspector.MemoryStatistics.prototype._clearCurrentValueAndMarker):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype._updateCurrentValue):
(WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
(WebInspector.MemoryStatistics.prototype._restoreImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._saveImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._drawMarker):
(WebInspector.MemoryStatistics.prototype._clear):
(WebInspector.MemoryStatistics.prototype._discardImageUnderMarker):
- 7:36 AM Changeset in webkit [142277] by
-
- 25 edits7 adds6 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 1. Some tests that have existing expectations.
- editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
- fast/repaint/transform-absolute-in-positioned-container-expected.txt: Added.
- platform/chromium-linux-x86/editing/input: Removed.
- platform/chromium-linux/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
- platform/chromium-linux/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
- platform/chromium-linux/editing/input/reveal-caret-of-multiline-input-expected.png:
- platform/chromium-linux/fast/repaint/transform-absolute-in-positioned-container-expected.png:
- platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
- platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
- platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
- platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.png:
- platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
- platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
- platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-input-expected.png:
- platform/chromium-mac/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
- platform/chromium-mac/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
- platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
- platform/chromium-mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
- platform/chromium-mac/editing/input/reveal-caret-of-multiline-input-expected.png:
- platform/chromium-win-xp/editing/input: Removed.
- platform/chromium-win/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
- platform/chromium-win/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
- platform/chromium-win/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
- platform/chromium-win/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
- platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.png:
- platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.txt:
- platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
- platform/efl-wk1/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
- platform/efl-wk2/editing/input: Added.
- platform/efl-wk2/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
- platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
- platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
- 7:07 AM Changeset in webkit [142276] by
-
- 3 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=109209.
- 7:02 AM Changeset in webkit [142275] by
-
- 2 edits in branches/chromium/1364/Source/WebKit/chromium
Merge 141904
[chromium] Make overlay layers slow-scrolling
https://bugs.webkit.org/show_bug.cgi?id=108957
Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-05
Reviewed by James Robinson.
Since overlay layers get inserted on top of everything else, we must
mark them slow-scrolling to prevent all scroll input events to the rest
of the page from getting blocked. This is also more correct because
generally the overlay contents need to be repainted whenever the scroll
offset changes, and with this patch the painting happens in sync with
page scrolling.
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12210085
- 6:50 AM Changeset in webkit [142274] by
-
- 2 edits in trunk/LayoutTests
[Qt][Wk2] Unreviewed gardening. Skip failing tests.
https://bugs.webkit.org/show_bug.cgi?id=109291.
- platform/qt-5.0-wk2/TestExpectations:
- 6:42 AM Changeset in webkit [142273] by
-
- 11 edits25 adds in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
These are tests that failed due to bad expectations.
- platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
- platform/chromium-mac-lion/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/overhang-ne-expected.png: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/overhang-nw-expected.png: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/overhang-se-expected.png: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/overhang-sw-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.txt: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.txt: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-se-expected.txt: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.txt: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-ne-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-ne-expected.txt: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-nw-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-nw-expected.txt: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-se-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-se-expected.txt: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-sw-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-sw-expected.txt: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-win/svg/custom/embedding-external-svgs-expected.png:
- platform/chromium-win/svg/custom/pointer-events-text-expected.png:
- platform/chromium/TestExpectations:
- 6:23 AM Changeset in webkit [142272] by
-
- 2 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed gardening.
- platform/chromium/TestExpectations: Last of the Win failures.
- 6:21 AM Changeset in webkit [142271] by
-
- 66 edits in trunk/Source/WebCore
Add a new IGNORE_EXCEPTION helper to ignore ExceptionCodes when they are expected but uninteresting
https://bugs.webkit.org/show_bug.cgi?id=108771
Reviewed by Eric Seidel.
In cases where the ExceptionCode passed into a function is completely
ignored, this patch replaces it with a new IGNORE_EXCEPTION macro. This
makes our expectations about possible exceptions (or lack thereof)
explicit, rather than relying on implicit assumptions about whether a
variable is intentionally uninitialized or not. It also removes
knowledge about the internals of ExceptionCodes (that they're currently
ints, for instance) from code that shouldn't care, which will help with
future refactorings.
The implementation is entirely based upon ASSERT_NO_EXCEPTION, and
shouldn't have any visible effect on the web. As long as all the
current tests pass, we're good.
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::stop):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::processBuffer):
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
- dom/ExceptionCodePlaceholder.h:
(WebCore):
- dom/Node.cpp:
(WebCore::Node::normalize):
- dom/Text.cpp:
(WebCore::Text::replaceWholeText):
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::insertDictatedText):
- editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::doApply):
(WebCore::AppendNodeCommand::doUnapply):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt):
- editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doUnapply):
- editing/Editor.cpp:
(WebCore::dispatchEditableContentChangedEvents):
(WebCore::Editor::applyEditingStyleToElement):
- editing/EditorCommand.cpp:
(WebCore::executeFormatBlock):
- editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::elementForFormatBlockCommand):
- editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApplyForSingleParagraph):
- editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):
- editing/RemoveCSSPropertyCommand.cpp:
(WebCore::RemoveCSSPropertyCommand::doApply):
(WebCore::RemoveCSSPropertyCommand::doUnapply):
- editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::doApply):
(WebCore::RemoveNodeCommand::doUnapply):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
- editing/TextIterator.cpp:
(WebCore::TextIterator::getLocationAndLengthFromRange):
- editing/WrapContentsInDummySpanCommand.cpp:
(WebCore::WrapContentsInDummySpanCommand::executeApply):
(WebCore::WrapContentsInDummySpanCommand::doUnapply):
- editing/htmlediting.cpp:
(WebCore::comparePositions):
- editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup):
- html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::appendEntry):
(WebCore::FTPDirectoryDocumentParser::createTDForFilename):
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::rewind):
(WebCore::HTMLMediaElement::returnToRealtime):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::percentLoaded):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::mediaPlayerDurationChanged):
(WebCore::HTMLMediaElement::applyMediaFragmentURI):
- html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::setTextContentInternal):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::remove):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::createTHead):
(WebCore::HTMLTableElement::deleteTHead):
(WebCore::HTMLTableElement::createTFoot):
(WebCore::HTMLTableElement::deleteTFoot):
(WebCore::HTMLTableElement::createCaption):
(WebCore::HTMLTableElement::deleteCaption):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setDefaultValue):
- html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure):
- html/InputType.cpp:
(WebCore::InputType::stepUpFromRenderer):
- html/MediaController.cpp:
(MediaController::bringElementUpToSpeed):
(MediaController::asyncEventTimerFired):
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::MediaDocument::replaceMediaElementTimerFired):
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent):
- html/TimeRanges.cpp:
(TimeRanges::contain):
(TimeRanges::nearest):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlSeekButtonElement::seekTimerFired):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlStatusDisplayElement::update):
(WebCore::MediaControlRewindButtonElement::defaultEventHandler):
(WebCore::MediaControlTimelineElement::defaultEventHandler):
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::updateCurrentTimeDisplay):
(WebCore::MediaControls::createTextTrackDisplay):
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::updateCurrentTimeDisplay):
- html/shadow/MediaControlsBlackBerry.cpp:
(WebCore::MediaControlEmbeddedPanelElement::setPosition):
(WebCore::MediaControlEmbeddedPanelElement::resetPosition):
(WebCore::MediaControlFullscreenTimelineElement::defaultEventHandler):
(WebCore::MediaControlsBlackBerry::updateCurrentTimeDisplay):
- html/shadow/MediaControlsChromium.cpp:
(WebCore::MediaControlsChromium::updateCurrentTimeDisplay):
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::addGenericCue):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
- inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::markUndoableState):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::replayXHR):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
- page/DOMWindow.cpp:
(WebCore::didAddStorageEventListener):
- page/DragController.cpp:
(WebCore::documentFragmentFromDragData):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):
- page/Page.cpp:
(WebCore::Page::findStringMatchingRanges):
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaSliderTrack):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::percentLoaded):
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaSliderTrack):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getDataSelection):
(WebCore::documentFragmentWithImageResource):
(WebCore::Pasteboard::documentFragment):
- platform/mac/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
(-[WebVideoFullscreenHUDWindowController setVolume:]):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintMediaSliderTrack):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::getRanges):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaSliderTrack):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::detachTarget):
- xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::endElementNs):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseEndElement):
- 6:14 AM Changeset in webkit [142270] by
-
- 2 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed gardening.
- platform/chromium/TestExpectations: Adding Mac rubberbanding failures
- 6:10 AM Changeset in webkit [142269] by
-
- 25 edits in trunk
Web Inspector: Introduce workspace provider/project type, encapsulate uri creation in SimpleWorkspaceProvider.
https://bugs.webkit.org/show_bug.cgi?id=109282
Reviewed by Alexander Pavlov.
Source/WebCore:
SimpleWorkspaceProvider now fully takes care of creating uri based on project/workspace provider type.
This is the first step on the way to project-per-domain mode for non file system project types.
Workspace is now partly aware of the possibility that several projects with the same type exist.
Drive-by: ScriptsPanel now uses FileMapping to show anchor location properly.
- inspector/front-end/DefaultScriptMapping.js:
(WebInspector.DefaultScriptMapping):
(WebInspector.DefaultScriptMapping.prototype.addScript):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onGetPageResources):
- inspector/front-end/FileMapping.js:
(WebInspector.FileMapping.prototype.uriForURL):
- inspector/front-end/FileSystemWorkspaceProvider.js:
(WebInspector.FileSystemWorkspaceProvider.prototype.type):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._supportsEnabledBreakpointsWhileEditing):
- inspector/front-end/LiveEditSupport.js:
(WebInspector.LiveEditSupport):
(WebInspector.LiveEditSupport.prototype.uiSourceCodeForLiveEdit):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._navigatorViewForUISourceCode):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._projectWillReset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.type):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addUniqueFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._uniqueURI):
- inspector/front-end/Workspace.js:
(WebInspector.WorkspaceProvider.prototype.type):
(WebInspector.Project.prototype.type):
(WebInspector.Project.prototype.isServiceProject):
(WebInspector.Workspace.prototype.uiSourceCodeForOriginURL):
(WebInspector.Workspace.prototype.uiSourceCodesForProjectType):
(WebInspector.Workspace.prototype.projectsForType):
- inspector/front-end/inspector.js:
LayoutTests:
- http/tests/inspector-enabled/dynamic-scripts.html:
- http/tests/inspector/compiler-script-mapping.html:
- http/tests/inspector/workspace-test.js:
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/dynamic-scripts.html:
- inspector/debugger/script-snippet-model.html:
- inspector/debugger/scripts-file-selector.html:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting-expected.txt:
- inspector/debugger/scripts-sorting.html:
- inspector/uisourcecode-revisions.html:
- 5:55 AM Changeset in webkit [142268] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
Updated French translation
https://bugs.webkit.org/show_bug.cgi?id=106229
Patch by Alexandre Franke <alexandre.franke@gmail.com> on 2013-02-08
Rubber-stamped by Gustavo Noronha.
- fr.po: updated.
- 5:49 AM Changeset in webkit [142267] by
-
- 2 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed gardening.
- platform/chromium/TestExpectations: Outstanding Win failures
- 5:41 AM Changeset in webkit [142266] by
-
- 2 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed gardening.
- platform/chromium/TestExpectations: One more to get all bots green again ready for rebaselining.
- 5:35 AM Changeset in webkit [142265] by
-
- 2 edits in trunk/Source/WebCore
[GTK][AC] GraphicsLayerClutter doesn't need to recalculate its position after changing anchor position.
https://bugs.webkit.org/show_bug.cgi?id=109226
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-08
Reviewed by Gustavo Noronha Silva.
Clutter has a different coordinate system from mac port's, so we don't need to
recalulate GraphicsLayer position after changing its anchor position.
Covered by existing ac tests.
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::updateGeometry):
- 5:16 AM Changeset in webkit [142264] by
-
- 2 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed gardening.
- platform/chromium/TestExpectations: Modified a MountainLion expectation
- 5:05 AM Changeset in webkit [142263] by
-
- 2 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 5:04 AM Changeset in webkit [142262] by
-
- 4 edits in trunk/Source/WebCore
Migrate ExceptionCode ASSERTs in IDB to ASSERT_NO_EXCEPTION.
https://bugs.webkit.org/show_bug.cgi?id=109266
Reviewed by Jochen Eisinger.
The pattern:
ExceptionCode ec = 0;
methodThatGeneratesException(ec);
ASSERT(!ec);
is more clearly and succinctly written as:
methodThatGeneratesException(ASSERT_NO_EXCEPTION);
This patch replaces the occurances of the former in IDB code that never
touch 'ec' again with the latter. No change in behavior should result
from this refactoring.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::advance):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::deleteFunction):
These methods checked the value of the ExceptionCode without first
initializing it to 0. Now the ExceptionCode is explicitly set to 0
before doing potentially exception-generating work.
(WebCore::IDBCursor::direction):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::mode):
Replace the above pattern with ASSERT_NO_EXCEPTION.
- 4:54 AM Changeset in webkit [142261] by
-
- 7 edits in trunk/Source/WebCore
Migrate ExceptionCode ASSERTs in SVG to ASSERT_NO_EXCEPTION.
https://bugs.webkit.org/show_bug.cgi?id=109267
Reviewed by Jochen Eisinger.
The pattern:
ExceptionCode ec = 0;
methodThatGeneratesException(ec);
ASSERT(!ec);
is more clearly and succinctly written as:
methodThatGeneratesException(ASSERT_NO_EXCEPTION);
This patch replaces the occurances of the former in SVG code that never
touch 'ec' again with the latter. No change in behavior should result
from this refactoring.
- svg/SVGLength.cpp:
(WebCore::SVGLength::SVGLength):
(WebCore::SVGLength::setValue):
This method checked the value of the ExceptionCode without first
initializing it to 0. Now it initializes before doing potentially
exception-generating work.
- rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::initialBaselineShiftValue):
(WebCore::SVGRenderStyle::initialKerning):
(WebCore::SVGRenderStyle::initialStrokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeWidth):
- svg/SVGAnimatedLength.cpp:
(WebCore::sharedSVGLength):
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
- svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::textLengthAnimated):
- svg/animation/SVGSMILElement.cpp:
(WebCore::constructQualifiedName):
Replace the above pattern with ASSERT_NO_EXCEPTION.
- 4:45 AM Changeset in webkit [142260] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSC: Lower minimum PropertyTable size.
<http://webkit.org/b/109247>
Reviewed by Darin Adler.
Lower the minimum table size for PropertyTable from 16 to 8.
3.32 MB progression on Membuster3 (a ~13% reduction in memory used by PropertyTables.)
- runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::sizeForCapacity):
- 4:42 AM Changeset in webkit [142259] by
-
- 13 edits in trunk
Web Inspector: Replace workspace with project in UISourceCode constructor.
https://bugs.webkit.org/show_bug.cgi?id=109256
Reviewed by Alexander Pavlov.
Source/WebCore:
Replaced workspace with project in UISourceCode constructor since every UISourceCode
operation is delegated to project anyway.
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.project):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype.requestOriginalContent):
(WebInspector.UISourceCode.prototype._commitContent):
(WebInspector.UISourceCode.prototype.searchInContent):
- inspector/front-end/Workspace.js:
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.setFileContent):
(WebInspector.Project.prototype.searchInFileContent):
LayoutTests:
- inspector/debugger/breakpoint-manager-expected.txt:
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/script-formatter-search.html:
- inspector/debugger/scripts-file-selector.html:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting.html:
- inspector/debugger/ui-source-code-display-name.html:
- inspector/debugger/ui-source-code.html:
- inspector/uisourcecode-revisions.html:
- 4:39 AM Changeset in webkit [142258] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r142205.
- 4:22 AM Changeset in webkit [142257] by
-
- 4 edits in trunk
Remove Skia code suppressions
Unreviewed enabling of existing optimizations
Removing all skia_webkit.gyp code suppressions and adding expectations
for the failures.
Source/WebKit/chromium:
- skia_webkit.gyp:
LayoutTests:
- platform/chromium/TestExpectations:
- 4:10 AM Changeset in webkit [142256] by
-
- 2 edits in trunk/Tools
Update my entries in the watchlist
Unreviewed.
- Scripts/webkitpy/common/config/watchlist:
- 4:08 AM Changeset in webkit [142255] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Adjusting expectations for two failures.
Unreviewed Chromium expectations
- platform/chromium/TestExpectations:
- 3:58 AM Changeset in webkit [142254] by
-
- 2 edits in trunk/Source/WebCore
Build fix for Windows after r141981.
- platform/network/win/ResourceHandleWin.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously):
- 3:51 AM Changeset in webkit [142253] by
-
- 7 edits in trunk/Tools
[chromium] copy normalizeLayoutTestURL code to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109269
Reviewed by Kent Tamura.
The method doesn't have any external dependencies, so there's no reason
it should be on the delegate. It's still required by TestShell, however,
by making a copy, we can avoid implementing this in content shell.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
- DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
(WebTestRunner::WebPermissions::allowImage):
(WebTestRunner::WebPermissions::allowScriptFromSource):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::windowCount):
- DumpRenderTree/chromium/TestShell.h:
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 3:45 AM Changeset in webkit [142252] by
-
- 1 edit in trunk/Tools/MiniBrowser/efl/main.c
Unreviewed, forced commit to trigger an EFL bot cycle
- 3:15 AM Changeset in webkit [142251] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r141695 and r141697.
http://trac.webkit.org/changeset/141695
http://trac.webkit.org/changeset/141697
https://bugs.webkit.org/show_bug.cgi?id=109279
broke on-disk buffering for http(s) media (Requested by philn
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-08
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcGetProtocols):
(webKitWebSrcSetUri):
- 2:17 AM Changeset in webkit [142250] by
-
- 37 edits in trunk/Source
[v8] isolate parameter added to all v8::peristent calls
https://bugs.webkit.org/show_bug.cgi?id=109268
Patch by Dan Carney <dcarney@google.com> on 2013-02-08
Reviewed by Kentaro Hara.
Source/WebCore:
No new tests. No change in functionality.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::GetRawTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::V8TestActiveDOMObject::GetRawTemplate):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::GetRawTemplate):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::GetRawTemplate):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::GetRawTemplate):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::GetRawTemplate):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::GetRawTemplate):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::GetRawTemplate):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::GetRawTemplate):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::GetRawTemplate):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::GetRawTemplate):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
- bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::clear):
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore::isolatedWorldWeakCallback):
(WebCore::DOMWrapperWorld::makeContextWeak):
- bindings/v8/NPV8Object.cpp:
(WebCore::freeV8NPObject):
(WebCore::npCreateV8ScriptObject):
- bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::~ScheduledAction):
- bindings/v8/ScopedPersistent.h:
(WebCore::ScopedPersistent::ScopedPersistent):
(WebCore::ScopedPersistent::set):
(WebCore::ScopedPersistent::clear):
- bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::disposeWrapper):
(WebCore::ScriptWrappable::weakCallback):
- bindings/v8/V8Binding.cpp:
(WebCore::createRawTemplate):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8GCController.cpp:
(WebCore::gcTree):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
- bindings/v8/V8GCController.h:
(V8GCController):
- bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::V8HiddenPropertyName::createString):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8NPObject.cpp:
(WebCore::V8NPTemplateMap::dispose):
(WebCore::npObjectGetProperty):
(WebCore::createV8ObjectForNPObject):
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8PerContextData::constructorForTypeSlowCase):
- bindings/v8/V8ValueCache.cpp:
(WebCore::makeExternalString):
- bindings/v8/WrapperTypeInfo.h:
(WebCore::WrapperConfiguration::configureWrapper):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::wrapInShadowObject):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::WeakReferenceCallback):
(WebCore::createInjectedScriptHostV8Wrapper):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAccessorGetter):
(WebCore::V8Location::replaceAccessorGetter):
(WebCore::V8Location::assignAccessorGetter):
Source/WebKit/chromium:
- tests/WebFrameTest.cpp:
- 1:56 AM Changeset in webkit [142249] by
-
- 2 edits in trunk/Tools
[EFL] Make the Performance bot also build WebKit.
https://bugs.webkit.org/show_bug.cgi?id=109273
Reviewed by Philippe Normand.
There has not been much benefit in fetching binaries compiled by
another bot; it makes the build bot take 6 to 7 minutes to upload
the binaries to build.webkit.org, we need to manually override
LD_LIBRARY_PATH to find the compiled libraries and still have
other path-related problems.
Since we have enough horsepower in the perf bot, let's experiment
with building WebKit there instead.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 1:34 AM Changeset in webkit [142248] by
-
- 41 edits in trunk/Source/WebCore
Adjust usage of ENABLE flags to enable whole content
https://bugs.webkit.org/show_bug.cgi?id=109270
Reviewed by Eric Seidel.
Our common usage of ENABLE flags to enable whole content of files is:
For .cpp files:
#include "config.h"
#if ENABLE(FOOBAR)
#include "FooBar.h"
For .h files:
#ifndef FooBar_h
#define FooBar_h
#if ENABLE(FOOBAR)
Fix files which have uncommon usage, and fix CodeGeneratorV8.pm so that
it generates the common pattern. Note that CodeGeneratorJS.pm already
generates code in this order.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
- bindings/scripts/test/V8/V8TestCallback.cpp:
- bindings/scripts/test/V8/V8TestCallback.h:
- bindings/scripts/test/V8/V8TestInterface.cpp:
- bindings/scripts/test/V8/V8TestInterface.h:
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
- html/BaseMultipleFieldsDateAndTimeInputType.h:
- html/ColorInputType.cpp:
- html/ColorInputType.h:
- html/DateInputType.cpp:
- html/DateTimeInputType.cpp:
- html/DateTimeInputType.h:
- html/DateTimeLocalInputType.cpp:
- html/HTMLAudioElement.cpp:
- html/HTMLAudioElement.h:
- html/HTMLDataListElement.cpp:
- html/HTMLDialogElement.cpp:
- html/HTMLDialogElement.h:
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
- html/HTMLMeterElement.cpp:
- html/HTMLProgressElement.cpp:
- html/HTMLSourceElement.cpp:
- html/HTMLSourceElement.h:
- html/HTMLTrackElement.cpp:
- html/HTMLTrackElement.h:
- html/HTMLVideoElement.cpp:
- html/HTMLVideoElement.h:
- html/MonthInputType.cpp:
- html/TimeInputType.cpp:
- html/WeekInputType.cpp:
- html/shadow/DateTimeFieldElement.h:
- html/shadow/DetailsMarkerControl.cpp:
- html/shadow/MeterShadowElement.cpp:
- html/shadow/ProgressShadowElement.cpp:
- rendering/RenderDetailsMarker.cpp:
- rendering/RenderInputSpeech.cpp:
- rendering/RenderMeter.cpp:
- rendering/RenderProgress.cpp:
- 1:12 AM Changeset in webkit [142247] by
-
- 26 edits in trunk/Source/WebCore
Replace ExceptionCode assertions with ASSERT_NO_EXCEPTION macro.
https://bugs.webkit.org/show_bug.cgi?id=109044
Reviewed by Darin Adler.
The pattern:
ExceptionCode ec = 0;
methodThatGeneratesException(ec);
ASSERT(!ec);
is more clearly and succinctly written as:
methodThatGeneratesException(ASSERT_NO_EXCEPTION);
This patch replaces the occurances of the former that never touch 'ec'
again with the latter. It does the same for 'ASSERT(ec == 0);' (and, as
a drive-by, replaces 'ASSERT(ec == 0)' with 'ASSERT(!ec)' in places
where it does indeed matter that 'ec' get set properly.
No change in behavior should result from this refactoring.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
- dom/Document.cpp:
(WebCore::Document::setTitle):
- dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):
- editing/DeleteButtonController.cpp:
(WebCore::enclosingDeletableElement):
(WebCore::DeleteButtonController::createDeletionUI):
Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
(WebCore::DeleteButtonController::show):
Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
- editing/EditorCommand.cpp:
(WebCore::unionDOMRanges):
- editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::removeNode):
(WebCore::ReplacementFragment::insertNodeBefore):
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
(WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
- editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doUnapply):
- editing/TextIterator.cpp:
(WebCore::CharacterIterator::range):
(WebCore::BackwardsCharacterIterator::range):
(WebCore::TextIterator::rangeFromLocationAndLength):
(WebCore::collapsedToBoundary):
- editing/htmlediting.cpp:
(WebCore::createTabSpanElement):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):
- editing/markup.cpp:
(WebCore::createMarkup):
(WebCore::trimFragment):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
(WebCore::createFragmentFromNodes):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::updatePlaceholderText):
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCookies):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::addRule):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::dispatchDOMEvent):
- page/DOMSelection.cpp:
(WebCore::DOMSelection::deleteFromDocument):
- page/DragController.cpp:
(WebCore::prepareClipboardForImageDrag):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::visiblePositionForIndex):
Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
- 1:03 AM Changeset in webkit [142246] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Adjusting expectations for two hidpi tests.
https://bugs.webkit.org/show_bug.cgi?id=96441
- platform/chromium/TestExpectations:
- 1:00 AM Changeset in webkit [142245] by
-
- 3 edits1 delete in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests.
- platform/qt-5.0/fast/js/global-constructors-expected.txt: Removed.
- platform/qt/TestExpectations:
- platform/qt/fast/js/global-constructors-expected.txt: Added after r142149.
- 12:57 AM Changeset in webkit [142244] by
-
- 4 edits in trunk/LayoutTests
[EFL] Mark some tests as passing with incorrect expectations
https://bugs.webkit.org/show_bug.cgi?id=109173
Unreviewed EFL gardening.
Add new category for TestExpectations: PASSING TESTS WITH INCORRECT EXPECTATIONS.
Currently, the tests are passing with their generated incorrect expectations.
It should be checked if the test starts failing. It means, the test can be passing now.
Below tests are marked as passing tests with incorrect expectations.
fast/forms/basic-textareas-quirks.html
fast/forms/input-disabled-color.html
fast/forms/input-readonly-dimmed.html
fast/forms/listbox-hit-test-zoomed.html
fast/forms/menulist-narrow-width.html
fast/forms/menulist-style-color.html
fast/forms/plaintext-mode-2.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-rtl.html
fast/forms/select-baseline.html
fast/forms/select-style.html
fast/forms/zoomed-controls.html
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-08
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 12:25 AM Changeset in webkit [142243] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: disable profile type switching while profile in progress
https://bugs.webkit.org/show_bug.cgi?id=109178
Patch by Alexei Filippov <alph@chromium.org> on 2013-02-08
Reviewed by Yury Semikhatsky.
Disables profile type selection controls when a profiling session
is in progress.
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
- inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView.prototype._updateControls):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
- 12:24 AM Changeset in webkit [142242] by
-
- 2 edits in trunk/Source/WTF
Web Inspector: Native Memory Instrumentation: reportBaseAddress needs to be called after the reportNode. So it may reuse the node index for the real address.
https://bugs.webkit.org/show_bug.cgi?id=109051
Reviewed by Yury Semikhatsky.
- wtf/MemoryInstrumentation.cpp:
(WTF::MemoryInstrumentation::WrapperBase::processPointer):
- 12:18 AM Changeset in webkit [142241] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Native Memory Instrumentation: adjust chunk transfer size for better speed.
https://bugs.webkit.org/show_bug.cgi?id=109263
Reviewed by Yury Semikhatsky.
The chunk size is changed from 100 to 10000.
addString counts only first 256 symbols of the string.o
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::pushUpdateIfNeeded):
(WebCore::HeapGraphSerializer::addString):
- inspector/front-end/NativeMemorySnapshotView.js:
- 12:05 AM Changeset in webkit [142240] by
-
- 9 edits in trunk
Support a relatedTarget attribute on focus/blur events
https://bugs.webkit.org/show_bug.cgi?id=109176
Reviewed by Ojan Vafai.
In bug 76216, we supported a relatedTarget attribute on
focusin/focusout events. We should also support it on focus/blur events.
See http://lists.w3.org/Archives/Public/www-dom/2012OctDec/0061.html
for the www-dom discussion.
Source/WebCore:
Test: fast/dom/shadow/shadow-boundary-events.html
fast/events/related-target-focusevent.html
- dom/EventDispatchMediator.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
- dom/EventDispatchMediator.h:
(FocusEventDispatchMediator):
(BlurEventDispatchMediator):
- dom/Node.cpp:
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):
LayoutTests:
- fast/dom/shadow/shadow-boundary-events-expected.txt:
- fast/dom/shadow/shadow-boundary-events.html:
- fast/events/related-target-focusevent-expected.txt:
- fast/events/related-target-focusevent.html:
