⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 10, 2013:

11:24 PM Changeset in webkit [142433] by Chris Fleizach
  • 12 edits
    2 adds in trunk

WebSpeech: Implement basic speaking/finished speaking behavior
​https://bugs.webkit.org/show_bug.cgi?id=107135

Reviewed by Sam Weinig.

Source/WebCore:

Implements the basic functionality of speaking utterances.

In the WebCore side, it manages the speech queue the way the spec defines
(that is, new jobs are appended to a queue and wait for other jobs to finish).

On the Mac side, it instantiates a synthesizer and handles the callbacks for when
jobs are finished. It sends those jobs back to WebCore to dispatch the right events.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-speak.html

  • Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::startSpeakingImmediately):
(WebCore::SpeechSynthesis::speak):
(WebCore):
(WebCore::SpeechSynthesis::fireEvent):
(WebCore::SpeechSynthesis::handleSpeakingCompleted):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):

  • Modules/speech/SpeechSynthesis.h:

(WebCore):
(WebCore::SpeechSynthesis::speaking):
(SpeechSynthesis):

  • Modules/speech/SpeechSynthesisEvent.cpp:

(WebCore::SpeechSynthesisEvent::create):
(WebCore):
(WebCore::SpeechSynthesisEvent::SpeechSynthesisEvent):

  • Modules/speech/SpeechSynthesisEvent.h:

(SpeechSynthesisEvent):
(WebCore::SpeechSynthesisEvent::interfaceName):

  • Modules/speech/SpeechSynthesisUtterance.h:

(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(SpeechSynthesisUtterance):

  • platform/PlatformSpeechSynthesisUtterance.cpp:

(WebCore::PlatformSpeechSynthesisUtterance::PlatformSpeechSynthesisUtterance):

  • platform/PlatformSpeechSynthesisUtterance.h:

(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setVolume):
(WebCore::PlatformSpeechSynthesisUtterance::setRate):
(WebCore::PlatformSpeechSynthesisUtterance::setPitch):
(WebCore::PlatformSpeechSynthesisUtterance::startTime):
(WebCore::PlatformSpeechSynthesisUtterance::setStartTime):
(WebCore::PlatformSpeechSynthesisUtterance::client):

  • platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):

  • platform/PlatformSpeechSynthesizer.h:

(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizer::client):
(PlatformSpeechSynthesizer):

  • platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper initWithSpeechSynthesizer:WebCore::]):
(-[WebSpeechSynthesisWrapper dealloc]):
(-[WebSpeechSynthesisWrapper convertRateToWPM:]):
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::speak):

LayoutTests:

  • platform/mac/fast/speechsynthesis/speech-synthesis-speak-expected.txt: Added.
  • platform/mac/fast/speechsynthesis/speech-synthesis-speak.html: Added.
11:06 PM EFLWebKitBuildBots edited by Christophe Dumez
(diff)
11:04 PM EFLWebKitBuildBots edited by Christophe Dumez
(diff)
10:54 PM Changeset in webkit [142432] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaselined an image.

  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
10:53 PM Changeset in webkit [142431] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marked http/tests/css/css-image-loading.html as SLOW.

  • platform/chromium/TestExpectations:
10:47 PM Changeset in webkit [142430] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaselined an image.

  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
10:38 PM Changeset in webkit [142429] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Add adobe.com to team.html
​https://bugs.webkit.org/show_bug.cgi?id=109396

Patch by Dirk Schulze <​dschulze@adobe.com> on 2013-02-10
Reviewed by Laszlo Gombos.

  • team.html:
9:16 PM Changeset in webkit [142428] by weinig@apple.com
  • 22 edits in trunk/Source/WebKit2

Make the Plug-in XPCService build work even when building in Xcode
<rdar://problem/13011186>
​https://bugs.webkit.org/show_bug.cgi?id=109392

Reviewed by Anders Carlsson.

  • Configurations/DebugRelease.xcconfig:

Add a DEBUG_OR_RELEASE variable to test against.

  • Configurations/PluginService.32.xcconfig:
  • Configurations/PluginService.64.xcconfig:

In non-production builds, don't link against WebKit2, so that we don't get warnings about WebKit2.framework
not containing the right architectures. This is ok, as these services are not used in non-production builds.

  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/NetworkServiceMain.Development.mm:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32/PluginService.32.Main.mm:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64/PluginService.64.Main.mm:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/PluginService.Development.Main.mm:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm:

Switch off the the old idiom of defining a macro for the initializer function, and instead set
it in the Info.plist, so the XPCServiceBootstrapper can grab it.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h:

(WebKit::XPCServiceEventHandler):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.h:

(WebKit::XPCServiceEventHandler):
Get the entry point from the bundle, rather than the macro. This is not only a bit less gross,
but also allows us to build without having linked against WebKit2.framework.

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::shouldUseXPC):
Re-enable using XPC for plug-ins.

  • WebKit2.xcodeproj/project.pbxproj:

Update project.

9:14 PM Changeset in webkit [142427] by eric@webkit.org
  • 15 edits
    2 adds in trunk/Source/WebCore

Make the existing HTMLPreloadScanner threading-aware
​https://bugs.webkit.org/show_bug.cgi?id=107807

Reviewed by Adam Barth.

The HTMLPreloadScanner and CSSPreloadScanner do a number of things.
CSSPreloadScanner is mostly just a helper class for HTMLPreloadScanner.
HTMLPreloadScanner runs its own copy of the HTMLTokenizer and uses
HTMLTokenizer::updateStateFor to emulate enough of the TreeBuilder
to get a realistic stream of tokens. It does some additional TreeBuilder
emulation, including tracking template tags and base tags, but mostly
just scans the token stream for start-tags and looks for URLs in them.
It tracks when it has seen a <style> tag and starts sending all character tokens
to the CSSPreloadScanner until a </style> tag is seen.
It also (unfortunately) knows some about the loader guts and how to construct
a proper CachedResourcRequest and issue a preload.

This patch changes the model so that the preload scanners only know how to produce
PreloadRequest objects and append them to a passed-in vector.

This changes the preload-scanner behavior so that preloads are now all issued in one large
batch at the end of scanning, instead of as we hit each resource. It's possible that
we'll wait to instead check for preload requests more often, at a possible tradeoff
to tokenizing speed.

An alternate approach might be to pass in a preload-delegate of sorts which knew how
to either build a vector, or send requests immediately. For now the build-a-vector-always
approach seems clean, and does not seem to slow down our PerformanceTest microbenchmarks at least.

This patch has 2 main pieces:

  • Remove Document and (and loader) dependencies from HTMLPreloadScanner/CSSPreloadScanner This is done through introduction of a new HTMLResourcePreloader class which holds a Document* and knows how to talk to the CachedResourceLoader.
  • Clean-up HTMLPreloadScanners token-loop to not be tied to having a Tokenizer. (On a background thead, the HTMLPreloadScanner won't own the tokenizer, it will just

be passed in tokens and expected to issue loads if necessary.)

This passes all of the LayoutTests using the main thread parser.

This patch does not make the HTMLPreloadScanner 100% ready for threading
(it still uses AtomicString which is currently not-OK on the parser thread)
but it's very close. Two further (already written) patches will complete this.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::CSSPreloadScanner):
(WebCore::CSSPreloadScanner::scan):
(WebCore::CSSPreloadScanner::emitRule):

  • html/parser/CSSPreloadScanner.h:

(CSSPreloadScanner):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::isStartTag):
(WebCore):
(WebCore::isStartOrEndTag):
(WebCore::PreloadTask::processAttributes):
(WebCore::PreloadTask::charset):
(PreloadTask):
(WebCore::PreloadTask::resourceType):
(WebCore::PreloadTask::shouldPreload):
(WebCore::PreloadTask::createPreloadRequest):
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::processPossibleTemplateTag):
(WebCore::HTMLPreloadScanner::processPossibleStyleTag):
(WebCore::HTMLPreloadScanner::processPossibleBaseTag):
(WebCore::HTMLPreloadScanner::processToken):

  • html/parser/HTMLPreloadScanner.h:

(HTMLPreloadScanner):

  • html/parser/HTMLResourcePreloader.cpp: Added.

(WebCore):
(WebCore::isStringSafeToSendToAnotherThread):
(WebCore::PreloadRequest::isSafeToSendToAnotherThread):
(WebCore::PreloadRequest::completeURL):
(WebCore::PreloadRequest::resourceRequest):
(WebCore::HTMLResourcePreloader::preload):

  • html/parser/HTMLResourcePreloader.h: Added.

(WebCore):
(PreloadRequest):
(WebCore::PreloadRequest::create):
(WebCore::PreloadRequest::PreloadRequest):
(HTMLResourcePreloader):
(WebCore::HTMLResourcePreloader::HTMLResourcePreloader):
(WebCore::HTMLResourcePreloader::createWeakPtr):

  • loader/cache/CachedResourceRequest.h:
8:37 PM Changeset in webkit [142426] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaselined an image.

  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
8:29 PM Changeset in webkit [142425] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Add sisa.samsung.com to team.html
​https://bugs.webkit.org/show_bug.cgi?id=109394

Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-10
Reviewed by Dirk Schulze.

  • team.html:
8:14 PM Changeset in webkit [142424] by haraken@chromium.org
  • 11 edits in trunk/Source/WebCore

[V8] Rename isolated() to getWorld(), rename worldForEnteredContextIfIsolated() to worldForEnteredContext()
​https://bugs.webkit.org/show_bug.cgi?id=109039

Reviewed by Adam Barth.

This is a follow-up patch for r141983.
Rename methods for consistency.

No tests. No change in behavior.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::getWorld):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
(WebCore::ScriptController::currentWorldContext):

  • bindings/v8/V8Binding.h:

(WebCore::worldForEnteredContext):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::wrap):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::wrap):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::wrap):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCallbackCustom):

6:54 PM Changeset in webkit [142423] by aelias@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix Android scrollbar size
​https://bugs.webkit.org/show_bug.cgi?id=109374

Reviewed by James Robinson.

This shrinks scrollbars to 3 device-independent pixels (usually 6
physical pixels) and deletes the edge fade. Although the Android
system theme does have an edge fade, it's a much sharper cliff
than we had (against black, the colors go 64 -> 64 -> 52 -> 21 -> 0)
and I can't perceive any difference compared with no fade at all.

No new tests (due for rewrite in a week anyway).

  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp:

(WebCore):
(WebCore::ScrollbarThemeChromiumAndroid::paintThumb):

6:38 PM Changeset in webkit [142422] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebKit/chromium

[chromium] Enable more of webkit_unit_tests in component builds
​https://bugs.webkit.org/show_bug.cgi?id=109369

Patch by James Robinson <​jamesr@chromium.org> on 2013-02-10
Reviewed by Darin Fisher.

Updates all webkit_unit_tests (except for LevelDBTest) to go through the Platform API instead of directly
calling into webkit_support so they work in component builds.

  • WebKit.gyp:
  • tests/AssociatedURLLoaderTest.cpp:
  • tests/EventListenerTest.cpp:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::createWebViewAndLoad):
(QuitTask):
(WebKit::FrameTestHelpers::QuitTask::run):
(FrameTestHelpers):
(WebKit::FrameTestHelpers::runPendingTasks):

  • tests/FrameTestHelpers.h:

(FrameTestHelpers):

  • tests/ListenerLeakTest.cpp:
  • tests/PopupMenuTest.cpp:
  • tests/PrerenderingTest.cpp:
  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::ScrollingCoordinatorChromiumTest::~ScrollingCoordinatorChromiumTest):
(WebKit::ScrollingCoordinatorChromiumTest::navigateTo):

  • tests/URLTestHelpers.cpp:

(WebKit::URLTestHelpers::registerMockedURLLoad):

  • tests/WebFrameTest.cpp:
  • tests/WebImageTest.cpp:

(WebKit::readFile):

  • tests/WebPageNewSerializerTest.cpp:
  • tests/WebPageSerializerTest.cpp:
  • tests/WebPluginContainerTest.cpp:

(WebKit::WebPluginContainerTest::TearDown):
(WebKit::TEST_F):

  • tests/WebViewTest.cpp:
5:29 PM Changeset in webkit [142421] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marked fast/frames/seamless/seamless-inherited-origin.html as FAIL.

  • platform/chromium/TestExpectations:
5:23 PM Changeset in webkit [142420] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaselined svg/custom/foreign-object-skew.svg.

  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
5:16 PM Changeset in webkit [142419] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[V8] Remove V8GCController::m_edenNodes and make minor DOM GC more precise
​https://bugs.webkit.org/show_bug.cgi?id=108579

Reviewed by Adam Barth.

Currently V8GCController::m_edenNodes stores a list of nodes whose
wrappers have been created since the latest GC. The reason why we
needed m_edenNodes is that there was no way to know a list of wrappers
in the new space of V8. By using m_edenNodes, we had been approximating
'wrappers in the new space' by 'wrappers that have been created since
the latest GC'.

Now V8 provides VisitHandlesForPartialDependence(), with which WebKit
can know a list of wrappers in the new space. By using the API, we can
remove V8GCController::m_edenNodes. The benefit is that (1) we no longer
need to keep m_edenNodes and that (2) it enables more precise minor
DOM GC (Remember that m_edenNodes was just an approximation).

Performance benchmark: ​https://bugs.webkit.org/attachment.cgi?id=185940
The benchmark runs 300 iterations, each of which creates 100000 elements.
The benchmark measures average, min, median, max and stdev of execution times
of the 300 iterations. This will tell us the worst-case overhead of this change.

Before:

mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms

After:

mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms

As shown above, I couldn't observe any performance regression.

No tests. No change in behavior.

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapperInObject):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::getWorldWithoutContextCheck):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::worldForEnteredContextIfIsolated):
(WebCore::worldForEnteredContextWithoutContextCheck):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

  • bindings/v8/V8GCController.cpp:

(WebCore::gcTree):
(WebCore):
(MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::notifyFinished):
(WebCore::MajorGCWrapperVisitor::MajorGCWrapperVisitor):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):

  • bindings/v8/V8GCController.h:

(V8GCController):

1:50 PM Changeset in webkit [142418] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r181645. Requested by
"James Robinson" <​jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-10

  • DEPS:
1:04 PM Changeset in webkit [142417] by commit-queue@webkit.org
  • 6 edits in trunk

Consolidate the way WTF_USE_PTHREADS is enabled
​https://bugs.webkit.org/show_bug.cgi?id=108191

Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-10
Reviewed by Benjamin Poulain.

.:

Remove duplicated definition of WTF_USE_PTHREADS.

WTF_USE_PTHREADS is defined to 1 on all OS(UNIX) environments in
Platform.h.

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:

Source/WTF:

Define WTF_USE_PTHREADS to 1 on all OS(UNIX) environments.

  • WTF.gyp/WTF.gyp: Remove duplicated definition of WTF_USE_PTHREADS.
  • wtf/Platform.h:
12:11 PM Changeset in webkit [142416] by timothy_horton@apple.com
  • 3 edits
    5 adds in trunk

REGRESSION (r132422): Page content and scrollbars are incorrectly offset after restoring a page from the page cache
​https://bugs.webkit.org/show_bug.cgi?id=109317
<rdar://problem/12649131>

Reviewed by Simon Fraser.

Mark all scrolling that occurs beneath FrameView::layout as programmatic.

Test: platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

Add a test that ensures that scroll position is correctly restored for pages coming out of the page cache when tiled drawing is enabled.

  • platform/mac-wk2/tiled-drawing/resources/go-back.html: Added.
  • platform/mac-wk2/tiled-drawing/resources/scroll-and-load-page.html: Added.
  • platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html: Added.
11:54 AM Changeset in webkit [142415] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Unreviewed attempted build fix for Gtk after r142412

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView):

11:51 AM Changeset in webkit [142414] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r142413.
​http://trac.webkit.org/changeset/142413
​https://bugs.webkit.org/show_bug.cgi?id=109383

didn't fix the gtk build (Requested by thorton on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-10

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
11:40 AM Changeset in webkit [142413] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Unreviewed attempted build fix for Gtk after r142412

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
11:27 AM Changeset in webkit [142412] by timothy_horton@apple.com
  • 7 edits in trunk/Tools

WKTR should propagate view creation options to opened windows
​https://bugs.webkit.org/show_bug.cgi?id=109381

Reviewed by Simon Fraser.

  • WebKitTestRunner/PlatformWebView.h:

(WTR::PlatformWebView::options):
Add storage and a getter for PlatformWebView's creation options dictionary.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
Propagate creation options from parent to child PlatformWebView when creating subwindows.

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):
Store creation options on the PlatformWebView.

10:26 AM Changeset in webkit [142411] by Martin Robinson
  • 2 edits in trunk/Source/JavaScriptCore

Fix the GTK+ gyp build

reflect what's in the repository and remove the offsets extractor
from the list of JavaScriptCore files. It's only used to build
the extractor binary.

10:18 AM Changeset in webkit [142410] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

[Mac] Fix release build failure by recent reverts

  • WebCore.exp.in:
9:55 AM Changeset in webkit [142409] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Add back code that was accidentally removed when moving plug-in enumeration back to the main thread
​https://bugs.webkit.org/show_bug.cgi?id=109379

Reviewed by Andreas Kling.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPlugins):

9:48 AM Changeset in webkit [142408] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Added *.pdf to EXCLUDED_SOURCE_FILE_NAMES_iphoneos.

Rubber-stamped by Anders Carlsson.

  • Configurations/WebKit.xcconfig:
9:33 AM Changeset in webkit [142407] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/TestExpectations: Remove duplicate test expectation

for media/track/track-in-band-style.html.

9:29 AM Changeset in webkit [142406] by Philippe Normand
  • 9 edits in trunk

[GStreamer] media/video-controls-fullscreen-volume.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=108682

Reviewed by Martin Robinson.

Source/WebCore:

Clean up various signal handlers and avoid bad interaction between
the FullscreenVideoControllerGStreamer and its subclasses,
especially when the platform video window is created.

  • platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.cpp:

(WebCore::FullscreenVideoControllerGStreamer::enterFullscreen):
Initialize the window before connecting to the volume/mute
signals. This ensures that the signals won't ever interfere with
an inexisting window.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::GStreamerGWorld::~GStreamerGWorld): Remove GstBus
synchronous handler function.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
Disconnect from volume/mute signals.
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
Keep a trace of volume/mute signal handlers.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

Various forward type declarations to avoid un-necessary header includes.
(MediaPlayerPrivateGStreamerBase):

  • platform/graphics/gtk/FullscreenVideoControllerGtk.cpp:

(WebCore::FullscreenVideoControllerGtk::FullscreenVideoControllerGtk):
(WebCore::FullscreenVideoControllerGtk::volumeChanged): Bail out
if volume button hasn't been created yet.
(WebCore::FullscreenVideoControllerGtk::muteChanged): Ditto.

LayoutTests:

  • platform/gtk/TestExpectations: Unflag now passing tests.
8:39 AM Changeset in webkit [142405] by tkent@chromium.org
  • 5 edits in trunk

Unreviewed, rolling out r142347.
​http://trac.webkit.org/changeset/142347
​https://bugs.webkit.org/show_bug.cgi?id=108273

Because a depending change r142343 was rolled out.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::plugInStartLabelTitle):
(WebKit::InjectedBundlePageUIClient::plugInStartLabelSubtitle):

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

8:04 AM Changeset in webkit [142404] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

RenderStyle should use copy-on-write inheritance for NinePieceImage.
<​http://webkit.org/b/109366>

Reviewed by Antti Koivisto.

Refactor NinePieceImage to hold a copy-on-write DataRef like other RenderStyle substructures.
This allows us to avoids copying the NinePieceImageData when one RenderStyle inherits from another
but modifies something in the substructure holding the NinePieceImage (typically StyleSurroundData.)

Also made RenderStyle not copy-on-write its StyleSurroundData prematurely when doing a no-op write
to a border-image related value.

1.23 MB progression on Membuster3.

  • rendering/style/NinePieceImage.cpp:

(WebCore::defaultData):
(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImageData::NinePieceImageData):
(WebCore::NinePieceImageData::operator==):

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImageData::create):
(WebCore::NinePieceImageData::copy):
(NinePieceImageData):
(NinePieceImage):
(WebCore::NinePieceImage::operator==):
(WebCore::NinePieceImage::operator!=):
(WebCore::NinePieceImage::hasImage):
(WebCore::NinePieceImage::image):
(WebCore::NinePieceImage::setImage):
(WebCore::NinePieceImage::imageSlices):
(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::fill):
(WebCore::NinePieceImage::setFill):
(WebCore::NinePieceImage::borderSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::outset):
(WebCore::NinePieceImage::setOutset):
(WebCore::NinePieceImage::horizontalRule):
(WebCore::NinePieceImage::setHorizontalRule):
(WebCore::NinePieceImage::verticalRule):
(WebCore::NinePieceImage::setVerticalRule):
(WebCore::NinePieceImage::copyImageSlicesFrom):
(WebCore::NinePieceImage::copyBorderSlicesFrom):
(WebCore::NinePieceImage::copyOutsetFrom):
(WebCore::NinePieceImage::copyRepeatFrom):
(WebCore::NinePieceImage::setMaskDefaults):
(WebCore::NinePieceImage::computeOutset):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setBorderImageSource):
(WebCore::RenderStyle::setBorderImageSlices):
(WebCore::RenderStyle::setBorderImageWidth):
(WebCore::RenderStyle::setBorderImageOutset):

  • rendering/style/RenderStyle.h:
7:05 AM Changeset in webkit [142403] by tkent@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Build fix for r142371
​https://bugs.webkit.org/show_bug.cgi?id=109313

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(WebKit):

6:33 AM Changeset in webkit [142402] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
​https://bugs.webkit.org/show_bug.cgi?id=109376

  • platform/chromium/TestExpectations:

fast/frames/seamless/seamless-inherited-origin.html is failing on debug bots.

6:26 AM Changeset in webkit [142401] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/TestExpectations: Flag new failing media/track test.
6:24 AM Changeset in webkit [142400] by tkent@chromium.org
  • 21 edits in trunk/Source

Unreviewed, rolling out r142343.
​http://trac.webkit.org/changeset/142343
​https://bugs.webkit.org/show_bug.cgi?id=108284

It might make inspector/profiler/selector-profiler-url.html
crashy.

Source/WebCore:

  • WebCore.exp.in:
  • css/plugIns.css:

(p):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::createRenderer):
(WebCore::HTMLPlugInImageElement::willRecalcStyle):
(WebCore::HTMLPlugInImageElement::updateSnapshot):
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot):
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):

  • html/HTMLPlugInImageElement.h:

(WebCore):
(HTMLPlugInImageElement):

  • page/ChromeClient.h:

(WebCore::ChromeClient::plugInStartLabelImage):

  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:
  • platform/blackberry/LocalizedStringsBlackBerry.cpp:
  • platform/chromium/LocalizedStringsChromium.cpp:
  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore):

  • platform/qt/LocalizedStringsQt.cpp:
  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore):
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::paint):
(WebCore::RenderSnapshottedPlugIn::paintReplaced):
(WebCore::RenderSnapshottedPlugIn::paintSnapshot):
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshot):
(WebCore::RenderSnapshottedPlugIn::startLabelImage):
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshotWithLabel):
(WebCore::RenderSnapshottedPlugIn::getCursor):
(WebCore::RenderSnapshottedPlugIn::handleEvent):
(WebCore::RenderSnapshottedPlugIn::tryToFitStartLabel):

  • rendering/RenderSnapshottedPlugIn.h:

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::plugInStartLabelImage):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

(InjectedBundlePageUIClient):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::plugInStartLabelImage):
(WebKit):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

6:13 AM Changeset in webkit [142399] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Refactor the way HAVE_XXX macros are set
​https://bugs.webkit.org/show_bug.cgi?id=108132

Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-10
Reviewed by Benjamin Poulain.

OS(WINDOWS) and OS(UNIX) are so broadly defined that for each
builds exactly one of them is enabled. Use this assumption to
cleanup Platform.h.

  • wtf/Platform.h:
5:44 AM Changeset in webkit [142398] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

RenderText: Access characters through m_text instead of caching data pointers separately.
<​http://webkit.org/b/109357>

Reviewed by Antti Koivisto.

Go through RenderText::m_text.impl() instead of caching the character data pointer.
RenderText should never have a null String in m_text so it's safe to access impl() directly.
We have assertions for this since before.

Removing this pointer shrinks RenderText by 8 bytes, allowing it to fit into a snugger size class.
749 KB progression on Membuster3.

  • rendering/RenderText.cpp:

(SameSizeAsRenderText):
(WebCore::RenderText::RenderText):
(WebCore::RenderText::setTextInternal):

  • rendering/RenderText.h:

(WebCore::RenderText::is8Bit):
(WebCore::RenderText::characters8):
(WebCore::RenderText::characters16):
(WebCore::RenderText::characterAt):
(WebCore::RenderText::operator[]):
(RenderText):

5:01 AM Changeset in webkit [142397] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
​https://bugs.webkit.org/show_bug.cgi?id=92941

  • platform/chromium/TestExpectations:

accessibility/loading-iframe-updates-axtree.html is [ Timeout ].

4:49 AM FeatureFlags edited by tkent@chromium.org
Remove GLIB_SUPPORT, add ENCRYPTED_MEDiA_V2 and NOSNIFF (diff)
4:42 AM Changeset in webkit [142396] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip fast/encoding/parser-tests-*.html tests now that the crashes
have been fixed by r142385.

  • platform/efl-wk2/TestExpectations:
3:23 AM Changeset in webkit [142395] by commit-queue@webkit.org
  • 18 edits in trunk

Rename ENABLE(GLIB_SUPPORT) to USE(GLIB)
​https://bugs.webkit.org/show_bug.cgi?id=104266

Patch by Jae Hyun Park <​jae.park08@gmail.com> on 2013-02-10
Reviewed by Philippe Normand.

Using USE(GLIB) instead of ENABLE(GLIB_SUPPORT) is more consistent with
the existing macro naming conventions.

From Platform.h
USE() - use a particular third-party library or optional OS service
ENABLE() - turn on a specific feature of WebKit

.:

  • Source/autotools/SetupAutoconfHeader.m4:
  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

No new tests, no new functionality.

  • WebCore.pri:

Source/WebKit/gtk:

  • gyp/Configuration.gypi:

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _close]):

  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:

Source/WTF:

  • WTF.pri:
  • wtf/Platform.h:
  • wtf/gobject/GOwnPtr.cpp:
  • wtf/gobject/GOwnPtr.h:
  • wtf/gobject/GRefPtr.cpp:
  • wtf/gobject/GRefPtr.h:
2:44 AM Changeset in webkit [142394] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

gtkdoc-scangobj throwing warnings when using Clang, causes generate-gtkdoc to fail
​https://bugs.webkit.org/show_bug.cgi?id=109315

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2013-02-10
Reviewed by Philippe Normand.

  • GNUmakefile.am: Define the CC environment variable to the CC compiler that the whole

project was configured to use. This ensures both the regular build and the gtkdoc-scangobj
program use the same compiler.

  • gtk/generate-gtkdoc: Add '-Qunused-arguments' to the CFLAGS in case we're using Clang. This

forces Clang to suppress unused arguments warnings that can unnecessarily cause generate-gtkdoc
script to fail.

2:42 AM Changeset in webkit [142393] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

[WebKit2][Gtk] Remove the fullscreen manager proxy message receiver upon invalidating
​https://bugs.webkit.org/show_bug.cgi?id=109352

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2013-02-10
Reviewed by Sam Weinig.

As added for the Mac port in r142160 due to the changes in the same revision, remove
the fullscreen manager proxy as a message receiver. Also fixes a failing unit test.

  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:

(WebKit::WebFullScreenManagerProxy::invalidate):

2:40 AM Changeset in webkit [142392] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] Build errors in TextureMapperShaderProgram.cpp when compiling with Clang
​https://bugs.webkit.org/show_bug.cgi?id=109321

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2013-02-10
Reviewed by Noam Rosenthal.

Clang is reporting errors due to non-constant expressions that cannot be narrowed
from double to float type in initializer list when constructing a matrix of GC3Dfloat
numbers. To avoid this every parameter is passed through an explicit GC3Dfloat constructor.

No new tests - no new functionality.

  • platform/graphics/texmap/TextureMapperShaderProgram.cpp:

(WebCore::TextureMapperShaderProgram::setMatrix):

2:00 AM Changeset in webkit [142391] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] audio is muted when playback rate is between 0.8 and 2.0
​https://bugs.webkit.org/show_bug.cgi?id=109362

Reviewed by Martin Robinson.

Don't mute sound if the audio pitch is preserved. If this is not
the case mute it if it's too extreme, as the HTML5 spec recommends.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setRate):

12:36 AM Changeset in webkit [142390] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Fix build on PLUGIN_ARCHITECTURE(UNSUPPORTED) after r142314
​https://bugs.webkit.org/show_bug.cgi?id=109364

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2013-02-10
Reviewed by Simon Hausmann.

void NetscapePlugin::platformPreInitialize() is need to be added to NetscapePluginNone.cpp.

  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:

(WebKit::NetscapePlugin::platformPreInitialize):
(WebKit):

Feb 9, 2013:

11:37 PM Changeset in webkit [142389] by Joseph Pecoraro
  • 2 edits in trunk/Tools

Make TestWebKitAPI work for iOS
​https://bugs.webkit.org/show_bug.cgi?id=108978

Patch by David Farler <​dfarler@apple.com> on 2013-02-09
Reviewed by Joseph Pecoraro.

  • TestWebKitAPI/Configurations/Base.xcconfig:

Added back FRAMEWORK_SEARCH_PATHS for Lion builds.

11:09 PM Changeset in webkit [142388] by jamesr@google.com
  • 2 edits
    1 add in trunk/Source/Platform

[chromium] Enable more of webkit_unit_tests in component builds
​https://bugs.webkit.org/show_bug.cgi?id=109369

Reviewed by Darin Fisher.

Add a set of testing APIs to a WebUnitTestSupport interface available off of Platform for unit tests to access
in component builds.

  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::unitTestSupport):

  • chromium/public/WebUnitTestSupport.h: Added.

(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::registerMockedURL):
(WebKit::WebUnitTestSupport::registerMockedErrorURL):
(WebKit::WebUnitTestSupport::unregisterMockedURL):
(WebKit::WebUnitTestSupport::unregisterAllMockedURLs):
(WebKit::WebUnitTestSupport::serveAsynchronousMockedRequests):
(WebKit::WebUnitTestSupport::webKitRootDir):

10:41 PM Changeset in webkit [142387] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Shrink-wrap UnlinkedCodeBlock members.
<​http://webkit.org/b/109368>

Reviewed by Oliver Hunt.

Rearrange the members of UnlinkedCodeBlock to avoid unnecessary padding on 64-bit.
Knocks ~600 KB off of the Membuster3 peak.

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

  • bytecode/UnlinkedCodeBlock.h:

(UnlinkedCodeBlock):

10:26 PM Changeset in webkit [142386] by jamesr@google.com
  • 3 edits in trunk/LayoutTests

Chromium gardening

  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium/TestExpectations:
10:11 PM Changeset in webkit [142385] by dmazzoni@google.com
  • 4 edits in trunk

fast/encoding/parser-tests-*.html tests sometimes crash
​https://bugs.webkit.org/show_bug.cgi?id=108058

Reviewed by Chris Fleizach.

Source/WebCore:

To avoid calling accessibilityIsIgnored while the render
tree is unstable, call accessibilityIsIgnored in the
notification timer handler, only for childrenChanged
notifications.

This exposed a problem where notifications queued on
objects can fire after the object has been deleted; fix that
by checking the object's id, which is always set to 0 when
removed from the tree.

Covered by existing tests.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::notificationPostTimerFired):

LayoutTests:

Make test less brittle by (1) giving the iframe an aria-role so
it's never ignored, and (2) using accessibilityElementById instead
of assuming an element is in a specific place in the AX tree.

  • accessibility/loading-iframe-updates-axtree.html:
7:48 PM Changeset in webkit [142384] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r137328.
​http://trac.webkit.org/changeset/137328
​https://bugs.webkit.org/show_bug.cgi?id=109367

causes memory usage to balloon if connection queue is filling
faster than sending (Requested by kling on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-09

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::ArgumentEncoder):
(CoreIPC::ArgumentEncoder::grow):

  • Platform/CoreIPC/ArgumentEncoder.h:

(CoreIPC::ArgumentEncoder::buffer):
(ArgumentEncoder):

4:50 PM Changeset in webkit [142383] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

[Mac] Do not assume MediaAccessibility framework is installed
​https://bugs.webkit.org/show_bug.cgi?id=109365

Reviewed by Sam Weinig.

  • page/CaptionUserPreferencesMac.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): Call the base class if the framework

is not available.

(WebCore::CaptionUserPreferencesMac::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferencesMac::userHasCaptionPreferences): Ditto.
(WebCore::CaptionUserPreferencesMac::registerForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferencesMac::unregisterForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Ditto.
(WebCore::CaptionUserPreferencesMac::captionFontSizeScale): Ditto.
(WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Ditto.
(WebCore::CaptionUserPreferencesMac::preferredLanguages): Ditto.

3:06 PM Changeset in webkit [142382] by dmazzoni@google.com
  • 39 edits in trunk/Source/WebCore

AX: move isIgnored caching to AXObject
​https://bugs.webkit.org/show_bug.cgi?id=109322

Reviewed by Chris Fleizach.

There's some benefit to caching accessibilityIsIgnored
(using AXComputedObjectAttributeCache) for more than just
AXRenderObject, so move the caching code to AXObject.

AXObject now has a protected virtual method
computeAccessibilityIsIgnored, and all subclasses
override that instead.

No new tests.

  • accessibility/AccessibilityImageMapLink.h:

(AccessibilityImageMapLink):
(WebCore::AccessibilityImageMapLink::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityList.h:

(AccessibilityList):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityListBox.h:

(AccessibilityListBox):

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityListBoxOption.h:

(AccessibilityListBoxOption):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMediaControls.h:

(AccessibilityMediaControl):
(WebCore::AccessibilityMediaControlsContainer::computeAccessibilityIsIgnored):
(AccessibilityMediaTimeDisplay):

  • accessibility/AccessibilityMenuList.h:

(WebCore::AccessibilityMenuList::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMenuListOption.h:

(AccessibilityMenuListOption):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMenuListPopup.h:

(AccessibilityMenuListPopup):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::accessibilityIsIgnored):
(WebCore):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
(WebCore::AccessibilityObject::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityProgressIndicator.h:

(AccessibilityProgressIndicator):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityScrollView.h:

(AccessibilityScrollView):

  • accessibility/AccessibilityScrollbar.h:

(WebCore::AccessibilityScrollbar::computeAccessibilityIsIgnored):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::computeAccessibilityIsIgnored):
(WebCore::AccessibilitySliderThumb::computeAccessibilityIsIgnored):

  • accessibility/AccessibilitySlider.h:

(AccessibilitySlider):
(AccessibilitySliderThumb):

  • accessibility/AccessibilitySpinButton.h:

(WebCore::AccessibilitySpinButton::computeAccessibilityIsIgnored):
(WebCore::AccessibilitySpinButtonPart::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTable.h:

(AccessibilityTable):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTableCell.h:

(AccessibilityTableCell):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTableColumn.h:

(AccessibilityTableColumn):

  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTableHeaderContainer.h:

(AccessibilityTableHeaderContainer):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTableRow.h:

(AccessibilityTableRow):

2:53 PM Changeset in webkit [142381] by commit-queue@webkit.org
  • 10 edits
    1 copy
    1 move
    1 add in trunk

Make TestWebKitAPI work for iOS
​https://bugs.webkit.org/show_bug.cgi?id=108978

Patch by David Farler <​dfarler@apple.com> on 2013-02-09
Reviewed by David Kilzer.

Source/WebCore:

Tests already exist - refactor only.

  • WebCore.exp.in: Lumped ZNK7WebCore4KURL7hasPathEv with related methods.
  • platform/KURL.cpp: Inlined hasPath() into the header
  • platform/KURL.h: Inlined hasPath() into the header

Tools:

  • Makefile: Added TestWebKitAPI to iOS MODULES list.
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • Include FeatureDefines
  • Removed VALID_ARCHS
  • Removed FRAMEWORK_SEARCH_PATHS - allows building against other SDKs
  • Excluded source files per platform
  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
  • framework and library switches per platform
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • Remove explicit framework and library linking (moved to xcconfigs)
  • Added iOS main.mm
  • TestWebKitAPI/config.h:
  • Guard importing Cocoa.h and WebKit2_C.h on iOS
  • TestWebKitAPI/ios/mainIOS.mm: Copied from Tools/TestWebKitAPI/mac/main.mm.
  • TestWebKitAPI/mac/mainMac.mm: Renamed from Tools/TestWebKitAPI/mac/main.mm.
1:00 PM Changeset in webkit [142380] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Reverting earlier change now

Unreviewed expectations.

  • platform/chromium/TestExpectations: Removed all the expectations added earlier.
12:13 PM Changeset in webkit [142379] by jschuh@chromium.org
  • 2 edits in trunk/Tools

[CHROMIUM] Suppress c4267 build warnings for Win64 tests
​https://bugs.webkit.org/show_bug.cgi?id=109359

Reviewed by Abhishek Arya.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11:34 AM Changeset in webkit [142378] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

Load event fires too early with threaded HTML parser
​https://bugs.webkit.org/show_bug.cgi?id=108984

Reviewed by Eric Seidel.

Previously, the DocumentLoader would always be on the stack when the
HTMLDocumentParser was processing data from the network. The
DocumentLoader would then tell isLoadingInAPISense not to fire the load
event. Now that we process data asynchronously with the threaded
parser, the DocumentLoader is not always on the stack, which means we
need to delay the load event using the clause that asks the parser
whether it is processing data.

Unfortunately, that clause is fragile because we can check for load
completion while we're switching parsers between the network-created
parser and a script-created parser. To avoid accidentially triggerin
the load event during these "gaps," this patch introduces a counter on
document to record how many parsers are active on the stack. While
that numer is non-zero, we'll delay the load event. When that number
reaches zero, we'll check for load complete.

That last step is required because the DocumentLoader::finishLoading
method is no longer guarunteed to check for load complete after calling
finish on the parser because the finish operation might complete
asynchronously.

After this patch, the threaded parser passes all but four fast/parser
tests.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::hasActiveParser):
(WebCore):
(WebCore::Document::decrementActiveParserCount):

  • dom/Document.h:

(Document):
(WebCore::Document::incrementActiveParserCount):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/HTMLParserScheduler.cpp:

(WebCore::ActiveParserSession::ActiveParserSession):
(WebCore):
(WebCore::ActiveParserSession::~ActiveParserSession):
(WebCore::PumpSession::PumpSession):
(WebCore::PumpSession::~PumpSession):

  • html/parser/HTMLParserScheduler.h:

(WebCore):
(ActiveParserSession):
(PumpSession):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoadingInAPISense):

11:33 AM Changeset in webkit [142377] by fpizlo@apple.com
  • 33 edits
    6 adds in trunk/Source/JavaScriptCore

DFG should allow phases to break Phi's and then have one phase to rebuild them
​https://bugs.webkit.org/show_bug.cgi?id=108414

Reviewed by Mark Hahnenberg.

Introduces two new DFG forms: LoadStore and ThreadedCPS. These are described in
detail in DFGCommon.h.

Consequently, DFG phases no longer have to worry about preserving data flow
links between basic blocks. It is generally always safe to request that the
graph be dethreaded (Graph::dethread), which brings it into LoadStore form, where
the data flow is implicit. In this form, only liveness-at-head needs to be
preserved.

All of the machinery for "threading" the graph to introduce data flow between
blocks is now moved out of the bytecode parser and into the CPSRethreadingPhase.
All phases that previously did this maintenance themselves now just rely on
being able to dethread the graph. The one exception is the structure check
hoising phase, which operates over a threaded graph and preserves it, for the
sake of performance.

Also moved two other things into their own phases: unification (previously found
in the parser) and prediction injection (previously found in various places).

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/Operands.h:

(Operands):
(JSC::Operands::sizeFor):
(JSC::Operands::atFor):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):

  • dfg/DFGAllocator.h:

(JSC::DFG::::allocateSlow):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGBasicBlockInlines.h:

(DFG):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::parseBlock):
(DFG):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::killUnreachable):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGCPSRethreadingPhase.cpp: Added.

(DFG):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::freeUnnecessaryNodes):
(JSC::DFG::CPSRethreadingPhase::clearVariablesAtHeadAndTail):
(JSC::DFG::CPSRethreadingPhase::addPhiSilently):
(JSC::DFG::CPSRethreadingPhase::addPhi):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetArgument):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlock):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlocks):
(JSC::DFG::CPSRethreadingPhase::propagatePhis):
(JSC::DFG::CPSRethreadingPhase::PhiStackEntry::PhiStackEntry):
(PhiStackEntry):
(JSC::DFG::CPSRethreadingPhase::phiStackFor):
(JSC::DFG::performCPSRethreading):

  • dfg/DFGCPSRethreadingPhase.h: Added.

(DFG):

  • dfg/DFGCSEPhase.cpp:

(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCommon.cpp:

(WTF):
(WTF::printInternal):

  • dfg/DFGCommon.h:

(JSC::DFG::logCompilationChanges):
(DFG):
(WTF):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dethread):
(JSC::DFG::Graph::collectGarbage):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::performSubstitution):
(Graph):
(JSC::DFG::Graph::performSubstitutionForEdge):
(JSC::DFG::Graph::convertToConstant):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToPhantomLocal):
(Node):
(JSC::DFG::Node::convertToGetLocal):
(JSC::DFG::Node::hasVariableAccessData):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPhase.cpp:

(JSC::DFG::Phase::beginPhase):

  • dfg/DFGPhase.h:

(JSC::DFG::runAndLog):

  • dfg/DFGPredictionInjectionPhase.cpp: Added.

(DFG):
(PredictionInjectionPhase):
(JSC::DFG::PredictionInjectionPhase::PredictionInjectionPhase):
(JSC::DFG::PredictionInjectionPhase::run):
(JSC::DFG::performPredictionInjection):

  • dfg/DFGPredictionInjectionPhase.h: Added.

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

  • dfg/DFGUnificationPhase.cpp: Added.

(DFG):
(UnificationPhase):
(JSC::DFG::UnificationPhase::UnificationPhase):
(JSC::DFG::UnificationPhase::run):
(JSC::DFG::performUnification):

  • dfg/DFGUnificationPhase.h: Added.

(DFG):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::dumpGraphIfAppropriate):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::setUpCall):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::dump):

  • runtime/JSString.h:

(JSString):

  • runtime/Options.h:

(JSC):

11:29 AM Changeset in webkit [142376] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Add a link to EFL perf bot on build.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=109342

Reviewed by Gyuyoung Kim.

Added.

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
11:19 AM Changeset in webkit [142375] by mkwst@chromium.org
  • 39 edits in trunk/Source/WebCore

Use IGNORE_EXCEPTION for initialized, but unused, ExceptionCodes.
​https://bugs.webkit.org/show_bug.cgi?id=109295

Reviewed by Darin Adler.

The monster patch in ​http://wkbug.com/108771 missed an entire class of
ignored exceptions. It only dealt with call sites that never initialized
the ExceptionCode variable, on the assumption that only such call sites
would ignore the variable's value.

That was a flawed assumption: a large number of sites that initialize the
ExceptionCode to 0 ignore it regardless. This patch deals with the
almost-as-large set of callsites that initialize the variable, pass it to
a function, and then never touch it again.

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::forceClose):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaSelectedTextRange):
(WebCore::AccessibilityRenderObject::visiblePositionForIndex):
(WebCore::AccessibilityRenderObject::indexForVisiblePosition):

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getSelectionOffsetsForObject):

  • accessibility/atk/WebKitAccessibleUtil.cpp:

(selectionBelongsToObject):

  • dom/Node.cpp:

(WebCore::Node::textRects):

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::hide):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::styleAtSelectionStart):

  • editing/Editor.cpp:

(WebCore::Editor::canDeleteRange):
(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::pasteAsFragment):
(WebCore::Editor::shouldDeleteRange):
(WebCore::Editor::dispatchCPPEvent):
(WebCore::Editor::setComposition):
(WebCore::Editor::advanceToNextMisspelling):
(WebCore::isFrameInRange):

  • editing/EditorCommand.cpp:

(WebCore::expandSelectionToGranularity):

  • editing/MergeIdenticalElementsCommand.cpp:

(WebCore::MergeIdenticalElementsCommand::doApply):

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::doUnapply):

  • editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doApply):

  • editing/TextCheckingHelper.cpp:

(WebCore::expandToParagraphBoundary):
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
(WebCore::TextCheckingHelper::isUngrammatical):
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):

  • editing/TextInsertionBaseCommand.cpp:

(WebCore::dispatchBeforeTextInsertedEvent):
(WebCore::canAppendNewLineFeedToSelection):

  • editing/TextIterator.cpp:

(WebCore::findPlainText):

  • editing/htmlediting.cpp:

(WebCore::extendRangeToWrappingNodes):
(WebCore::isNodeVisiblyContainedWithin):

  • editing/visible_units.cpp:

(WebCore::nextBoundary):

  • html/FileInputType.cpp:

(WebCore::FileInputType::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::setText):

  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::setText):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::didCompleteLoad):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::createShadowSubtree):

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):

  • html/track/TextTrackList.cpp:

(TextTrackList::asyncEventTimerFired):

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchDocument):

  • inspector/InspectorDatabaseAgent.cpp:

(WebCore):

  • inspector/InspectorFileSystemAgent.cpp:

(WebCore):

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::addRange):

  • page/DragController.cpp:

(WebCore::DragController::dispatchTextInputEventFor):

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::handleTouchEvent):

  • page/FrameActionScheduler.cpp:

(WebCore::EventFrameAction::fire):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::dispatchZoomEvent):
(WebCore::SVGDocument::dispatchScrollEvent):

  • svg/SVGLength.cpp:

(WebCore::SVGLength::SVGLength):
(WebCore::SVGLength::value):

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::exitText):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::startDocument):
(WebCore::XMLDocumentParser::parseCharacters):

11:11 AM Changeset in webkit [142374] by Christophe Dumez
  • 2 edits in trunk/Tools

Unreviewed. Update my IRC nickname in committers.py.

  • Scripts/webkitpy/common/config/committers.py:
11:09 AM Changeset in webkit [142373] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

build-webkit: document sdk, debug, release, device, and simulator options
​https://bugs.webkit.org/show_bug.cgi?id=109221

Patch by David Farler <​dfarler@apple.com> on 2013-02-09
Reviewed by David Kilzer.

  • Scripts/build-webkit: Add options to usage
  • Scripts/webkitdirs.pm: Remove --deploy and --devel checks
11:07 AM WebKit Team edited by Christophe Dumez
Update my IRC nickname (diff)
11:05 AM Changeset in webkit [142372] by senorblanco@chromium.org
  • 6 edits in trunk/Source/WebCore

[skia] Fix memory management in SkiaImageFilterBuilder and friends.
​https://bugs.webkit.org/show_bug.cgi?id=109326

Sadly, skia has no official ref-counted pointers, so we must make do
with SkAutoTUnref.

Reviewed by James Robinson.

Correctness covered by existing tests in css3/filters.

  • platform/graphics/filters/skia/FEBlendSkia.cpp:

(WebCore::FEBlend::createImageFilter):

  • platform/graphics/filters/skia/FEComponentTransferSkia.cpp:

(WebCore::FEComponentTransfer::createImageFilter):

  • platform/graphics/filters/skia/FELightingSkia.cpp:

(WebCore::FELighting::createImageFilter):
Adopt refs produced by the build() pass with SkAutoTUnref.

  • platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp:

(WebCore::SkiaImageFilterBuilder::~SkiaImageFilterBuilder):
Unref the builder's hashmap effect pointers.
(WebCore::SkiaImageFilterBuilder::build):
Ref the pointer returned to the caller, and use SkAutoTUnref
internally while building the tree.

  • platform/graphics/filters/skia/SkiaImageFilterBuilder.h:

(SkiaImageFilterBuilder):
Add a destructor to SkiaImageFilterBuilder.

11:01 AM Changeset in webkit [142371] by jochen@chromium.org
  • 8 edits in trunk/Tools

[chromium] move context menu data tracking to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=109313

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebKit):
(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestRunner::WebTestProxy::showContextMenu):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::setContextMenuData):
(WebTestRunner::EventSender::contextClick):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(WebKit):
(EventSender):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::showContextMenu):
(WebTestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::showContextMenu):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

10:55 AM Changeset in webkit [142370] by jochen@chromium.org
  • 9 edits in trunk/Tools

[chromium] move methods that change initial testRunner state to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=109043

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebKit):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::configureForTestWithURL):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(WebKit):
(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::showDevTools):
(WebTestRunner):
(WebTestRunner::TestRunner::showWebInspector):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::configureForTestWithURL):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):

10:41 AM Changeset in webkit [142369] by thakis@chromium.org
  • 2 edits in trunk/Tools

Add myself as a reviewer. (Yay!!!!!)
​https://bugs.webkit.org/show_bug.cgi?id=109110

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
10:35 AM Changeset in webkit [142368] by dmazzoni@google.com
  • 4 edits in trunk/Source/WebCore

AX: Rename AXObject::cachedIsIgnoredValue to lastKnownIsIgnoredValue
​https://bugs.webkit.org/show_bug.cgi?id=108238

Reviewed by Chris Fleizach.

Simple refactoring, no new tests.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::childrenChanged):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::lastKnownIsIgnoredValue):
(WebCore::AccessibilityObject::setLastKnownIsIgnoredValue):
(WebCore::AccessibilityObject::notifyIfIgnoredValueChanged):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):

10:34 AM Changeset in webkit [142367] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Text Autosizing] Cleanup change: converter the pointer argument to be a reference since
non-null pointer is always expected.
​https://bugs.webkit.org/show_bug.cgi?id=109079

Patch by Anton Vayvod <​avayvod@chromium.org> on 2013-02-09
Reviewed by Kenneth Rohde Christiansen.

Cleanup change, no need to add new tests or modify the existing ones.

  • rendering/TextAutosizer.cpp:

Changed parameter from a pointer to a reference in the methods below.

(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::isNarrowDescendant):
(WebCore::TextAutosizer::isWiderDescendant):
(WebCore::TextAutosizer::isAutosizingCluster):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):

  • rendering/TextAutosizer.h: updated method prototypes.
10:15 AM Changeset in webkit [142366] by rafael.lobo@openbossa.org
  • 10 edits
    1 copy
    5 adds in trunk/Source/WebCore

[TexMap] Separate classes per file in TextureMapperBackingStore.h
​https://bugs.webkit.org/show_bug.cgi?id=109333

Reviewed by Noam Rosenthal.

TextureMapperBackingStore.h had the classes TextureMapperBackingStore,
TextureMapperTiledBackingStore, TextureMapperSurfaceBackingStore and
TextureMapperTile which was quite confusing. Now each one has its
own header and its own source file.

No new tests needed, refactoring only.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • platform/graphics/texmap/TextureMapperBackingStore.cpp:
  • platform/graphics/texmap/TextureMapperBackingStore.h:
  • platform/graphics/texmap/TextureMapperSurfaceBackingStore.cpp: Added.

(WebCore):
(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::swapBuffersIfNeeded):
(WebCore::TextureMapperSurfaceBackingStore::texture):
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapperSurfaceBackingStore.h: Added.

(WebCore):
(TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::create):
(WebCore::TextureMapperSurfaceBackingStore::~TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::TextureMapperSurfaceBackingStore):

  • platform/graphics/texmap/TextureMapperTile.cpp: Added.

(WebCore):
(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTile::paint):

  • platform/graphics/texmap/TextureMapperTile.h: Added.

(WebCore):
(TextureMapperTile):
(WebCore::TextureMapperTile::texture):
(WebCore::TextureMapperTile::rect):
(WebCore::TextureMapperTile::setTexture):
(WebCore::TextureMapperTile::setRect):
(WebCore::TextureMapperTile::~TextureMapperTile):
(WebCore::TextureMapperTile::TextureMapperTile):

  • platform/graphics/texmap/TextureMapperTiledBackingStore.cpp: Copied from Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp.

(WebCore):
(WebCore::TextureMapperTiledBackingStore::TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::adjustedTransformForRect):
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper):
(WebCore::TextureMapperTiledBackingStore::drawBorder):
(WebCore::TextureMapperTiledBackingStore::drawRepaintCounter):
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):
(WebCore::TextureMapperTiledBackingStore::texture):

  • platform/graphics/texmap/TextureMapperTiledBackingStore.h: Added.

(WebCore):
(TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::create):
(WebCore::TextureMapperTiledBackingStore::~TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::setContentsToImage):
(WebCore::TextureMapperTiledBackingStore::rect):

  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
10:02 AM Changeset in webkit [142365] by pdr@google.com
  • 3 edits
    2 adds in trunk

Sanitize m_keyTimes for paced value animations
​https://bugs.webkit.org/show_bug.cgi?id=108828

Reviewed by Dirk Schulze.

Source/WebCore:

SVG animations with calcMode=paced calculate new m_keyTimes in
SVGAnimationElement::calculateKeyTimesForCalcModePaced() because paced animations do not
specify keyTimes. If an error occurs while calculating m_keyTimes, and there exists
user-specified values, a crash could occur because the user-specified values were not
sanitized.

This change clears user-specified keyTimes before calculating new ones.

Test: svg/animations/animate-keytimes-crash.html

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced):

LayoutTests:

  • svg/animations/animate-keytimes-crash-expected.html: Added.
  • svg/animations/animate-keytimes-crash.html: Added.
9:54 AM Changeset in webkit [142364] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Set mouse document position for mouse event in updateCursor.
​https://bugs.webkit.org/show_bug.cgi?id=109094.

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-02-09
Reviewed by Rob Buis.

RIM PR 246976
Internally Reviewed by Genevieve Mak.

BlackBerry::Platform::MouseEvent have document viewport and document
content position as members. When we create the event, we should initial
them as well.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::updateCursor):

9:52 AM Changeset in webkit [142363] by eric@webkit.org
  • 6 edits in trunk/Source/WebCore

Fix TextDocumentParser to play nice with threading
​https://bugs.webkit.org/show_bug.cgi?id=109240

Reviewed by Adam Barth.

Before the HTML5 parser re-write the text document parser
was completely custom. With the HTML5 parser, we just made
the TextDocumentParser use the HTMLDocumentParser with an
artificial script tag.

However, our solution was slightly over-engineered to avoid
lying about the column numbers of the first line of the text document
during parsing. :)

This change makes us use a simpler (and threading-compatible)
solution by just inserting a real "<pre>" tag into the
input stream instead of hacking one together with the treebuilder
and manually setting the Tokenizer state.

fast/parser/empty-text-resource.html covers this case.

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::TextDocumentParser):
(WebCore::TextDocumentParser::insertFakePreElement):

9:28 AM Changeset in webkit [142362] by schenney@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to last-known good revision. Really this time.

  • DEPS: 181594
9:21 AM Changeset in webkit [142361] by schenney@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to last-known good revision.
Requested by "Stephen Chenney" <​schenney@chromium.org> via
sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-09

  • DEPS:
9:05 AM Changeset in webkit [142360] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Trying to turn the build.webkit.org builders greener

Unreviewed expectations.

We seem to have an issue with build.webkit.org test bots and
Chromium.WebKit test bots doing different things. This is temporary
until we figure out what went wrong.

  • platform/chromium/TestExpectations: Re-adding all the changes due to Skia flags.
7:37 AM Changeset in webkit [142359] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Add missing copyright header
​https://bugs.webkit.org/show_bug.cgi?id=107507

  • Resources/pagepopups/chromium/calendarPickerChromium.css:
  • Resources/pagepopups/chromium/pickerCommonChromium.css:
7:25 AM Changeset in webkit [142358] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Fix crash by img[ismap] with content property
​https://bugs.webkit.org/show_bug.cgi?id=108702

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/dom/HTMLAnchorElement/anchor-ismap-crash.html

  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition):
Check if the renderer of an img element is RenderImage.

LayoutTests:

  • fast/dom/HTMLAnchorElement/anchor-ismap-crash-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-ismap-crash.html: Added.
7:16 AM Changeset in webkit [142357] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update.

  • platform/chromium/TestExpectations:

Correct encrypted-media-v2-*.html expectation.

7:14 AM Changeset in webkit [142356] by mkwst@chromium.org
  • 5 edits in trunk/Source/WebCore

Drop ExceptionCode from IDB's directionToString and modeToString.
​https://bugs.webkit.org/show_bug.cgi?id=109143

Reviewed by Jochen Eisinger.

No caller of either IDBCursor::directionToString or
IDBTransaction::modeToString makes use of the ExceptionCode these
methods require. This patch removes the 'ExceptionCode&' parameter from
both methods and their callsites.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::direction):
(WebCore::IDBCursor::directionToString):

Drop the 'ExceptionCode&' parameter, and replace the 'TypeError'
exception previously generated with ASSERT_NOT_REACHED.

  • Modules/indexeddb/IDBCursor.h:
  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::mode):
(WebCore::IDBTransaction::modeToString):

Drop the 'ExceptionCode&' parameter, and replace the 'TypeError'
exception previously generated with ASSERT_NOT_REACHED.

  • Modules/indexeddb/IDBTransaction.h:
7:10 AM Changeset in webkit [142355] by commit-queue@webkit.org
  • 12 edits
    1 copy
    1 add
    2 deletes in trunk

[EFL][Qt][WebGL] Share the common code between GraphicsSurfaceGLX and X11WindowResources.
​https://bugs.webkit.org/show_bug.cgi?id=106666

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2013-02-09
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

This patch removes any duplicate code in X11WindowResources and
GraphicsSurfaceGLX. No new functionality is added.

  • PlatformEfl.cmake:
  • Target.pri:
  • platform/graphics/surfaces/egl/EGLConfigSelector.cpp:

(WebCore::EGLConfigSelector::pixmapContextConfig):

  • platform/graphics/surfaces/egl/EGLConfigSelector.h:

(EGLConfigSelector):

  • platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::destroy):
(WebCore::EGLWindowTransportSurface::setGeometry):

  • platform/graphics/surfaces/egl/EGLSurface.h:

(WebCore):
(EGLWindowTransportSurface):

  • platform/graphics/surfaces/glx/GLXConfigSelector.h:

(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::visualInfo):
(WebCore::GLXConfigSelector::pBufferContextConfig):
(WebCore::GLXConfigSelector::createSurfaceConfig):
(GLXConfigSelector):

  • platform/graphics/surfaces/glx/GLXContext.cpp:

(WebCore::initializeARBExtensions):
(WebCore::GLXOffScreenContext::GLXOffScreenContext):
(WebCore::GLXOffScreenContext::initialize):
(WebCore::GLXOffScreenContext::platformReleaseCurrent):
(WebCore::GLXOffScreenContext::freeResources):

  • platform/graphics/surfaces/glx/GLXContext.h:

(GLXOffScreenContext):

  • platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::setGeometry):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXPBuffer::initialize):

  • platform/graphics/surfaces/glx/GLXSurface.h:

(GLXTransportSurface):
(GLXPBuffer):

  • platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::initialize):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::flags):
(WebCore::GraphicsSurfacePrivate::clear):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
No new functionality added. Made changes to take the common code into use.

  • platform/graphics/surfaces/glx/X11WindowResources.h: Removed.
  • platform/graphics/surfaces/glx/X11Helper.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/glx/X11WindowResources.cpp.

(WebCore):
(WebCore::DisplayConnection::DisplayConnection):
(DisplayConnection):
(WebCore::DisplayConnection::~DisplayConnection):
(WebCore::DisplayConnection::display):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::OffScreenRootWindow::rootWindow):
(WebCore::X11Helper::resizeWindow):
(WebCore::X11Helper::createOffScreenWindow):
(WebCore::X11Helper::destroyWindow):
(WebCore::X11Helper::isXRenderExtensionSupported):
(WebCore::X11Helper::nativeDisplay):
(WebCore::X11Helper::offscreenRootWindow):

  • platform/graphics/surfaces/glx/X11Helper.h: Added.

(WebCore):
(WebCore::handleXPixmapCreationError):
(X11Helper):
(ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::~ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::isValidOperation):
Moved common code from GraphicsSurfaceGLX to X11Helper.

6:58 AM Changeset in webkit [142354] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding a failure expectation for the test introduced in r142335.
6:31 AM Changeset in webkit [142353] by Christophe Dumez
  • 4 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/text/international/bidi-ignored-for-first-child-inline.html
after r142152.

  • platform/efl/TestExpectations:
  • platform/efl/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/efl/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
3:51 AM Changeset in webkit [142352] by Philippe Normand
  • 2 edits in trunk

Unreviewed, another GTK+ build fix after r142343.

  • Source/autotools/symbols.filter: Expose the InlineBox delete operator.
1:58 AM Changeset in webkit [142351] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Web Inspector: show whitespace characters in DTE
​https://bugs.webkit.org/show_bug.cgi?id=108947

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-02-09
Reviewed by Pavel Feldman.

Source/WebCore:

New test: inspector/editor/text-editor-show-whitespaces.html

Split consecutive whitespace characters into groups of 16, 8, 4, 2 and 1 and
add ::before pseudoclass for this groups which contains necessary
amount of "dots" (u+00b7). Add a setting "Show whitespace" for this
option in "Sources" section of "General" tab.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype.wasShown):
(WebInspector.TextEditorMainPanel.prototype.willHide):
(WebInspector.TextEditorMainPanel.prototype._renderRanges):
(WebInspector.TextEditorMainPanel.prototype._renderWhitespaceCharsWithFixedSizeSpans):
(WebInspector.TextEditorMainPanel.prototype._paintLine):

  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab):

  • inspector/front-end/inspectorSyntaxHighlight.css:

(.webkit-whitespace-1::before):
(.webkit-whitespace-2::before):
(.webkit-whitespace-4::before):
(.webkit-whitespace-8::before):
(.webkit-whitespace-16::before):
(.webkit-whitespace::before):

LayoutTests:

Add layout test to verify whitespace highlight functionality.

  • inspector/editor/text-editor-show-whitespace-expected.txt: Added.
  • inspector/editor/text-editor-show-whitespace.html: Added.
Note: See TracTimeline for information about the timeline view.