⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 17, 2013:

11:51 PM Changeset in webkit [143159] by eustas@chromium.org
  • 12 edits
    1 add in trunk

Web Inspector: Introduce ProfilesPanelDescriptor.
​https://bugs.webkit.org/show_bug.cgi?id=109906

Reviewed by Pavel Feldman.

Source/WebCore:

Some constants/methods should be accesible before ProfilesPanel
is instantiated.

Extracted methods to check if profile is "user-initiated" and what is
its index.

Also profile URL regexp moved to ProfilesPanelDescriptor.

  • inspector/front-end/ProfilesPanelDescriptor.js: Added.
  • WebCore.gypi: Added ProfilesPanelDescriptor.js
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • inspector/compile-front-end.py: Ditto.
  • inspector/front-end/WebKit.qrc: Ditto.
  • inspector/front-end/inspector.html: Ditto.
  • inspector/front-end/HeapSnapshotView.js: Adopted changes.
  • inspector/front-end/ProfilesPanel.js: Ditto.
  • inspector/front-end/externs.js: Ditto.
  • inspector/front-end/inspector.js: Ditto.

LayoutTests:

  • inspector/profiler/heap-snapshot-test.js: Adopted changes.
11:50 PM WebKit Team edited by kangil.han@samsung.com
(diff)
11:47 PM Changeset in webkit [143158] by kangil.han@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
11:46 PM Changeset in webkit [143157] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update test expectation for chromium.
​https://bugs.webkit.org/show_bug.cgi?id=110079

  • platform/chromium/TestExpectations:
11:44 PM Changeset in webkit [143156] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

GCE EWS bots are all offline
​https://bugs.webkit.org/show_bug.cgi?id=110069

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-02-17
Reviewed by Eric Seidel.

Updated GCE EWS build scripts to use the gcel-10-04-v20130104 image instead of the obsoleted ubuntu-10-04-v20120621.
This changed the ephemeral disk path to /dev/sdb and required /etc/hosts to be chmodded to 644.

  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
  • EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
  • EWSTools/build-vm.sh:
  • EWSTools/start-queue.sh:
11:35 PM Changeset in webkit [143155] by vivek.vg@samsung.com
  • 2 edits in trunk/LayoutTests

Add missing braces in fast/parser/noscript-with-javascript-enabled.html
​https://bugs.webkit.org/show_bug.cgi?id=110078

Unreviewed gardening. Adding the missing braces.

  • fast/parser/noscript-with-javascript-enabled.html:
11:25 PM WebKit Team edited by vivekg@webkit.org
(diff)
11:18 PM Changeset in webkit [143154] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed buildfix for JSVALUE32_64 builds after r143147.

  • jit/JIT.h:
10:50 PM Changeset in webkit [143153] by eustas@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, add myself to commiters.py.

  • Scripts/webkitpy/common/config/committers.py:
10:44 PM Changeset in webkit [143152] by Dimitri Glazkov
  • 3 edits in trunk/Source/WebCore

Stop passing around SelectorChecker in SelectorQuery, now that it's stack-allocated.
​https://bugs.webkit.org/show_bug.cgi?id=110038

Reviewed by Andreas Kling.

No functional changes, covered by existing tests.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::matches): Moved instantiation of SelectorChecker in here.
(WebCore::SelectorDataList::queryAll): Got rid of unneeded SelectorChecker arg.
(WebCore::SelectorDataList::queryFirst): Ditto.
(WebCore::SelectorDataList::execute): Moved instantiation of SelectorChecker in here.
(WebCore::SelectorQuery::matches): Removed instantiation of SelectorChecker here.
(WebCore::SelectorQuery::queryAll): Ditto.
(WebCore::SelectorQuery::queryFirst): Ditto.

  • dom/SelectorQuery.h:

(WebCore): Tweaked headers to make SelectorChecker just an implementation detail.
(SelectorDataList): Tweaked decls to remove SelectorChecker args.

10:38 PM Changeset in webkit [143151] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update test expectation for chromium.
​https://bugs.webkit.org/show_bug.cgi?id=110076

  • platform/chromium/TestExpectations:
10:37 PM Changeset in webkit [143150] by Dimitri Glazkov
  • 3 edits in trunk/Source/WebCore

Stop passing around SelectorChecker in ContentSelectorQuery.
​https://bugs.webkit.org/show_bug.cgi?id=110041

Now that SelectorChecker has no interesting state, we can simplify ContentSelectorQuery and get rid of a class.

Reviewed by Andreas Kling.

No functional changes, covered by existing tests.

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorDataList::checkContentSelector): Zapped ContentSelectorChecker and moved its only remaining method here.
(WebCore::ContentSelectorDataList::matches): Removed SelectorChecker argument.
(WebCore::ContentSelectorQuery::ContentSelectorQuery): Removed an unnecessary member.
(WebCore::ContentSelectorQuery::matches): Removed unnecessary argument.

  • html/shadow/ContentSelectorQuery.h:

(WebCore): Cleaned up the file.
(ContentSelectorDataList): Updated decls.
(ContentSelectorQuery): Ditto.

10:33 PM Changeset in webkit [143149] by dw.im@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
10:31 PM Changeset in webkit [143148] by mkwst@chromium.org
  • 3 edits
    2 adds in trunk

WheelEvent should not target text nodes.
​https://bugs.webkit.org/show_bug.cgi?id=109939

Reviewed by Darin Adler.

Source/WebCore:

WheelEvent, like other mouse events, should not target text nodes.
EventHandler correctly handles other mouse events by retargeting
events to text nodes' parents; this patch adds that logic to the
WheelEvent handler.

This should allow jQuery to stop working around WebKit's behavior[1].

[1]: ​https://github.com/jquery/jquery/commit/c61150427fc8ccc8e884df8f221a6c9bb5477929

Test: fast/events/wheelevent-in-text-node.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

If a WheelEvent's hit test lands on a text node, retarget the
event to the text node's parent. Do this before latching the node.

LayoutTests:

  • fast/events/wheelevent-in-text-node-expected.txt: Added.
  • fast/events/wheelevent-in-text-node.html: Added.
10:28 PM Changeset in webkit [143147] by fpizlo@apple.com
  • 35 edits
    4 adds in trunk/Source

Move all Structure out-of-line inline methods to StructureInlines.h
​https://bugs.webkit.org/show_bug.cgi?id=110024

Source/JavaScriptCore:

Rubber stamped by Mark Hahnenberg and Sam Weinig.

This was supposed to be easy.

But, initially, there was a Structure inline method in CodeBlock.h, and moving that
into StructureInlines.h meant that Operations.h included CodeBlock.h. This would
cause WebCore build failures, because CodeBlock.h transitively included the JSC
parser (via many, many paths), and the JSC parser defines tokens using enumeration
elements that CSSGrammar.cpp (generated by bison) would #define. For example,
bison would give CSSGrammar.cpp a #define FUNCTION 123, and would do so before
including anything interesting. The JSC parser would have an enum that included
FUNCTION as an element. Hence the JSC parser included into CSSGrammar.cpp would have
a token element called FUNCTION declared in an enumeration, but FUNCTION was
#define'd to 123, leading to a parser error.

Wow.

So I removed all transitive include paths from CodeBlock.h to the JSC Parser. I
believe I was able to do so without out-of-lining anything interesting or performance
critical. This is probably a purely good thing to have done: it will be nice to be
able to make changes to the parser without having to compile the universe.

Of course, doing this caused a bunch of other things to not compile, since a bunch of
headers relied on things being implicitly included for them when they transitively
included the parser. I fixed a lot of that.

Finally, I ended up removing the method that depended on CodeBlock.h from
StructureInlines.h, and putting it in Structure.cpp. That might seem like all of this
was a waste of time, except that I suspect it was a worthwhile forcing function for
cleaning up a bunch of cruft.

  • API/JSCallbackFunction.cpp:
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.h:

(JSC):

  • bytecode/EvalCodeCache.h:
  • bytecode/SamplingTool.h:
  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::parameterCount):
(JSC):

  • bytecode/UnlinkedCodeBlock.h:

(UnlinkedFunctionExecutable):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/Label.h:

(JSC):

  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGByteCodeParser.h:
  • dfg/DFGFPRInfo.h:
  • dfg/DFGRegisterBank.h:
  • heap/HandleStack.cpp:
  • jit/JITWriteBarrier.h:
  • parser/Nodes.h:

(JSC):

  • parser/Parser.h:
  • parser/ParserError.h: Added.

(JSC):
(JSC::ParserError::ParserError):
(ParserError):
(JSC::ParserError::toErrorObject):

  • parser/ParserModes.h:
  • parser/SourceProvider.cpp: Added.

(JSC):
(JSC::SourceProvider::SourceProvider):
(JSC::SourceProvider::~SourceProvider):

  • parser/SourceProvider.h:

(JSC):
(SourceProvider):

  • runtime/ArrayPrototype.cpp:
  • runtime/DatePrototype.cpp:
  • runtime/Executable.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:

(JSC):

  • runtime/Operations.h:
  • runtime/Structure.cpp:

(JSC::Structure::prototypeForLookup):
(JSC):

  • runtime/Structure.h:

(JSC):

  • runtime/StructureInlines.h: Added.

(JSC):
(JSC::Structure::create):
(JSC::Structure::createStructure):
(JSC::Structure::get):
(JSC::Structure::masqueradesAsUndefined):
(JSC::SlotVisitor::internalAppend):
(JSC::Structure::transitivelyTransitionedFrom):
(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache):
(JSC::Structure::prototypeForLookup):
(JSC::Structure::prototypeChain):
(JSC::Structure::isValid):

  • runtime/StructureRareData.cpp:

Source/WebCore:

Rubber stamped by Sam Weinig.

No new tests because no new behavior. Just rewiring includes.

  • ForwardingHeaders/parser/SourceProviderCache.h: Added.
  • loader/cache/CachedScript.cpp:
10:02 PM WebKit Team edited by dw.im@samsung.com
(diff)
9:53 PM Changeset in webkit [143146] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Remove unnecessary public method DrawingAreaImpl::createGraphicsContext()
​https://bugs.webkit.org/show_bug.cgi?id=109893

Patch by Jae Hyun Park <​jae.park@company100.net> on 2013-02-17
Reviewed by Anders Carlsson.

DrawingAreaImpl::createGraphicsContext() is unnecessary since
createGraphicsContext can be called directly using ShareableBitmap.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

9:51 PM Changeset in webkit [143145] by hayato@chromium.org
  • 7 edits in trunk/Source/WebCore

Make EventDispatcher take an Event object in its constructor.
​https://bugs.webkit.org/show_bug.cgi?id=109898

Reviewed by Dimitri Glazkov.

That makes EventDispatcher more RAII-like so that we can calculate
an EventPath in its constructor. I'll remove
EventDispatcher::ensureEventPath() in a following patch.

No tests. No change in behavior.

  • dom/EventDispatchMediator.cpp:

(WebCore::EventDispatchMediator::dispatchEvent):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::ensureEventPath):
(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::dispatchEventPreProcess):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):

  • dom/EventDispatcher.h:

(EventDispatcher):
(WebCore::EventDispatcher::node):
(WebCore::EventDispatcher::event):

  • dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):

  • dom/GestureEvent.cpp:

(WebCore::GestureEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

9:38 PM Changeset in webkit [143144] by pdr@google.com
  • 3 edits
    2 adds in trunk

Fix non-root SVG viewport under zoom
​https://bugs.webkit.org/show_bug.cgi?id=99453

Reviewed by Dirk Schulze.

Source/WebCore:

The root SVG element handles zoom differently than other SVG nodes because it needs
to translate between CSS (where zoom is applied to all units) and SVG (where zoom is only
applied at the top level). A good description of this difference can be found here:
​http://trac.webkit.org/browser/trunk/Source/WebCore/css/StyleResolver.cpp?rev=142855#L2598

SVG elements can appear as children in the SVG tree as well, and in this mode
SVGSVGElement should not consider the current zoom level. This patch fixes a bug
where non-root viewport calculations were removing zoom.

Test: svg/custom/symbol-zoom.html

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::currentViewportSize):

This change removes the unnecessary zoom calculation for non-root nodes. This is similar
to how zoom is handled elsewhere, e.g., SVGSVGElement::localCoordinateSpaceTransform.

LayoutTests:

  • svg/custom/symbol-zoom-expected.html: Added.
  • svg/custom/symbol-zoom.html: Added.
9:31 PM WebKit Team edited by bw80.lee@samsung.com
(diff)
9:30 PM Changeset in webkit [143143] by Chris Fleizach
  • 2 edits
    5 adds in trunk/Source/WebCore

AX: Upstream iOS Accessibility files
​https://bugs.webkit.org/show_bug.cgi?id=110071

Reviewed by David Kilzer.

Upstream the iOS Accessibility files for WebCore.

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/ios: Added.
  • accessibility/ios/AXObjectCacheIOS.mm: Added.

(WebCore):
(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::handleScrolledToAnchor):

  • accessibility/ios/AccessibilityObjectIOS.mm: Added.

(-[WAKView accessibilityIsIgnored]):
(WebCore):
(WebCore::AccessibilityObject::detachFromParent):
(WebCore::AccessibilityObject::overrideAttachmentParent):
(WebCore::AccessibilityObject::accessibilityPasswordFieldLength):
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/ios/AccessibilityObjectWrapperIOS.h: Added.

(WAKView):

  • accessibility/ios/AccessibilityObjectWrapperIOS.mm: Added.

(AccessibilityUnignoredAncestor):
(-[WebAccessibilityTextMarker initWithTextMarker:cache:]):
(-[WebAccessibilityTextMarker initWithData:cache:]):
(-[WebAccessibilityTextMarker initWithData:accessibilityObject:]):
(+[WebAccessibilityTextMarker textMarkerWithVisiblePosition:cache:]):
(-[WebAccessibilityTextMarker dataRepresentation]):
(-[WebAccessibilityTextMarker visiblePosition]):
(-[WebAccessibilityTextMarker description]):
(-[WebAccessibilityObjectWrapper initWithAccessibilityObject:]):
(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper dealloc]):
(-[WebAccessibilityObjectWrapper _prepareAccessibilityCall]):
(-[WebAccessibilityObjectWrapper accessibilityObject]):
(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper accessibilityPostProcessHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityElementCount]):
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper accessibilityLanguage]):
(-[WebAccessibilityObjectWrapper _accessibilityIsLandmarkRole:]):
(-[WebAccessibilityObjectWrapper _accessibilityListAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityLandmarkAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityTableAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper isAccessibilityElement]):
(-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]):
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
(-[WebAccessibilityObjectWrapper tableCellParent]):
(-[WebAccessibilityObjectWrapper tableParent]):
(-[WebAccessibilityObjectWrapper accessibilityTitleElement]):
(-[WebAccessibilityObjectWrapper accessibilityHeaderElements]):
(-[WebAccessibilityObjectWrapper accessibilityElementForRow:andColumn:]):
(-[WebAccessibilityObjectWrapper accessibilityRowRange]):
(-[WebAccessibilityObjectWrapper accessibilityColumnRange]):
(-[WebAccessibilityObjectWrapper accessibilityPlaceholderValue]):
(-[WebAccessibilityObjectWrapper accessibilityValue]):
(-[WebAccessibilityObjectWrapper accessibilityIsComboBox]):
(-[WebAccessibilityObjectWrapper accessibilityHint]):
(-[WebAccessibilityObjectWrapper accessibilityURL]):
(-[WebAccessibilityObjectWrapper _convertIntRectToScreenCoordinates:]):
(-[WebAccessibilityObjectWrapper accessibilityElementRect]):
(-[WebAccessibilityObjectWrapper accessibilityActivationPoint]):
(-[WebAccessibilityObjectWrapper accessibilityFrame]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):
(-[WebAccessibilityObjectWrapper accessibilityContainer]):
(-[WebAccessibilityObjectWrapper accessibilityFocusedUIElement]):
(-[WebAccessibilityObjectWrapper _accessibilityWebDocumentView]):
(-[WebAccessibilityObjectWrapper _accessibilityNextElementsWithCount:]):
(-[WebAccessibilityObjectWrapper _accessibilityPreviousElementsWithCount:]):
(-[WebAccessibilityObjectWrapper accessibilityRequired]):
(-[WebAccessibilityObjectWrapper accessibilityFlowToElements]):
(-[WebAccessibilityObjectWrapper accessibilityLinkedElement]):
(-[WebAccessibilityObjectWrapper isAttachment]):
(-[WebAccessibilityObjectWrapper _accessibilityActivate]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(rendererForView):
(-[WebAccessibilityObjectWrapper _accessibilityParentForSubview:]):
(-[WebAccessibilityObjectWrapper postFocusChangeNotification]):
(-[WebAccessibilityObjectWrapper postSelectedTextChangeNotification]):
(-[WebAccessibilityObjectWrapper postLayoutChangeNotification]):
(-[WebAccessibilityObjectWrapper postLiveRegionChangeNotification]):
(-[WebAccessibilityObjectWrapper postLoadCompleteNotification]):
(-[WebAccessibilityObjectWrapper postChildrenChangedNotification]):
(-[WebAccessibilityObjectWrapper postInvalidStatusChangedNotification]):
(-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]):
(-[WebAccessibilityObjectWrapper accessibilityModifySelection:increase:]):
(-[WebAccessibilityObjectWrapper accessibilityIncreaseSelection:]):
(-[WebAccessibilityObjectWrapper accessibilityDecreaseSelection:]):
(-[WebAccessibilityObjectWrapper accessibilityMoveSelectionToMarker:]):
(-[WebAccessibilityObjectWrapper accessibilityIncrement]):
(-[WebAccessibilityObjectWrapper accessibilityDecrement]):
(-[WebAccessibilityObjectWrapper _addAccessibilityObject:toTextMarkerArray:]):
(-[WebAccessibilityObjectWrapper stringForTextMarkers:]):
(blockquoteLevel):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetFont):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(AXAttributedStringAppendText):
(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):
(-[WebAccessibilityObjectWrapper _convertToNSRange:]):
(-[WebAccessibilityObjectWrapper _convertToDOMRange:]):
(-[WebAccessibilityObjectWrapper positionForTextMarker:]):
(-[WebAccessibilityObjectWrapper textMarkerRange]):
(-[WebAccessibilityObjectWrapper elementTextRange]):
(-[WebAccessibilityObjectWrapper accessibilityObjectForTextMarker:]):
(-[WebAccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[WebAccessibilityObjectWrapper textMarkerForPosition:]):
(-[WebAccessibilityObjectWrapper _stringForRange:attributed:]):
(-[WebAccessibilityObjectWrapper stringForRange:]):
(-[WebAccessibilityObjectWrapper attributedStringForRange:]):
(-[WebAccessibilityObjectWrapper elementsForRange:]):
(-[WebAccessibilityObjectWrapper selectionRangeString]):
(-[WebAccessibilityObjectWrapper selectedTextMarker]):
(-[WebAccessibilityObjectWrapper lineEndMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper lineStartMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper nextMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper previousMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper frameForTextMarkers:]):
(-[WebAccessibilityObjectWrapper textMarkerForPoint:]):
(-[WebAccessibilityObjectWrapper accessibilityIdentifier]):
(-[WebAccessibilityObjectWrapper accessibilitySpeechHint]):
(-[WebAccessibilityObjectWrapper accessibilityARIAIsBusy]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionStatus]):
(-[WebAccessibilityObjectWrapper accessibilityARIARelevantStatus]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionIsAtomic]):
(-[WebAccessibilityObjectWrapper accessibilityInvalidStatus]):
(-[WebAccessibilityObjectWrapper accessibilityMathRootIndexObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathRadicandObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathNumeratorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathDenominatorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathBaseObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSubscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSuperscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathUnderObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathOverObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedOpenString]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedCloseString]):
(-[WebAccessibilityObjectWrapper accessibilityIsMathTopObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathType]):
(-[WebAccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:withContext:]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:WebCore::AXObjectCache::]):
(-[WebAccessibilityObjectWrapper description]):

7:34 PM Changeset in webkit [143142] by Chris Fleizach
  • 4 edits
    2 moves
    2 adds in trunk/Source/WebCore

AX: rename WebAccessibilityObjectWrapper to WebAccessibilityObjectWrapperBase
​https://bugs.webkit.org/show_bug.cgi?id=110061

Reviewed by David Kilzer.

Rename the base accessibility wrapper class so that the iOS class can share the same name.

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::attachWrapper):

  • accessibility/mac/WebAccessibilityObjectWrapper.h: Replaced with Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h.
  • accessibility/mac/WebAccessibilityObjectWrapper.mm: Replaced with Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm.
  • accessibility/mac/WebAccessibilityObjectWrapperBase.h: Copied from Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.h.
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm: Copied from Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm.
  • accessibility/mac/WebAccessibilityObjectWrapperMac.h: Removed.
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Removed.
7:33 PM Changeset in webkit [143141] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Windows build fix.

  • runtime/CodeCache.h:

(CodeCacheMap):

7:13 PM Changeset in webkit [143140] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Fix typo in script.

  • EWSTools/start-queue-win.sh:
5:58 PM Changeset in webkit [143139] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Pass in bot name as parameter to start-queue-win script.
​https://bugs.webkit.org/show_bug.cgi?id=109998.

Reviewed by Darin Adler.

  • EWSTools/start-queue-win.sh:
5:25 PM Changeset in webkit [143138] by bw80.lee@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
3:26 PM Changeset in webkit [143137] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r143125): ~5% performance hit on Chromium's intl2 page cycler.
<​http://webkit.org/b/108835>

Reviewed by Ojan Vafai.

Streamline the case where GlyphPage has a per-glyph SimpleFontData* lookup table to allow
taking earlier branches on pages with lots of mixed-font text.
We accomplish this by explicitly storing a null SimpleFontData* for glyph #0 in the per-glyph
lookup table instead of relying on "if (!glyph)" checks in getters.

This is a speculative optimization, I can't get stable enough numbers locally to tell if this
will resolve the issue on the bots.

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):

12:57 PM Changeset in webkit [143136] by Chris Fleizach
  • 17 edits
    2 adds in trunk

WebSpeech: plumb through a method to generate fake speech jobs for testing
​https://bugs.webkit.org/show_bug.cgi?id=107351

Reviewed by Adam Barth.

Source/WebCore:

We can't reliably use the platforms synthesizer to test speech synthesis internals.
This patch adds an Internals method to enable a mock synthesizer, which is inherits
from the PlatformSpeechSythesizer.

The fake synthesizer goes through all the motions of a real synthesizer but doesn't do anything.
A bunch of changes were needed here to make PlatformSpeechSynthesizer subclassable so that the
right virtual are used.

The Mock synthesizer only lives in WebCoreTestSupport. Because PlatformSpeechSynthesizer uses
a RetainPtr, I needed to make WebCoreTestSupport link CoreFoundation

LayoutTests:

  • platform/mac/fast/speechsynthesis/speech-synthesis-speak.html:
  • platform/mac/fast/speechsynthesis/speech-synthesis-voices.html:
12:05 PM Changeset in webkit [143135] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark compositing/layer-creation/fixed-position-out-of-view-scaled.html as
flaky on WebKit2 EFL. It sometimes hits an assertion.

  • platform/efl-wk2/TestExpectations:
11:55 AM Changeset in webkit [143134] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] Remove fullscreen manager proxy as a message receiver on invalidate()
​https://bugs.webkit.org/show_bug.cgi?id=109451

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2013-02-17
Reviewed by Anders Carlsson.

Remove fullscreen manager proxy as a message receiver on invalidate(), like
other ports do after r142160.

  • UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:

(WebKit::WebFullScreenManagerProxy::invalidate):

11:15 AM Changeset in webkit [143133] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Code cache should be explicit about what it caches
​https://bugs.webkit.org/show_bug.cgi?id=110039

Reviewed by Oliver Hunt.

This patch makes the code cache more explicit in two ways:

(1) The cache caches top-level scripts. Any sub-functions executed as a
part of a script are cached with it and evicted with it.

This simplifies things by eliminating out-of-band sub-function tracking,
and fixes pathological cases where functions for live scripts would be
evicted in favor of functions for dead scripts, and/or high probability
functions executed early in script lifetime would be evicted in favor of
low probability functions executed late in script lifetime, due to LRU.

Statistical data from general browsing and PLT confirms that caching
functions independently of scripts is not profitable.

(2) The cache tracks script size, not script count.

This reduces the worst-case cache size by a factor of infinity.

Script size is a reasonable first-order estimate of in-memory footprint
for a cached script because there are no syntactic constructs that have
super-linear memory footprint.

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock): Moved this function out of the cache
because it does not consult the cache, and is not managed by it.

(JSC::UnlinkedFunctionExecutable::visitChildren): Visit our code blocks
because they are strong references now, rather than weak, a la (1).

(JSC::UnlinkedFunctionExecutable::codeBlockFor): Updated for interface changes.

  • bytecode/UnlinkedCodeBlock.h:

(UnlinkedFunctionExecutable):
(UnlinkedFunctionCodeBlock): Strong now, not weak, a la (1).

  • runtime/CodeCache.cpp:

(JSC::CodeCache::CodeCache):

  • runtime/CodeCache.h:

(JSC::SourceCodeKey::length):
(SourceCodeKey):
(CodeCacheMap):
(JSC::CodeCacheMap::CodeCacheMap):
(JSC::CodeCacheMap::find):
(JSC::CodeCacheMap::set):
(JSC::CodeCacheMap::clear):
(CodeCache):
(JSC::CodeCache::clear): Removed individual function tracking, due to (1).
Added explicit character counting, for (2).

You might think 16000000 characters is a lot. It is. But this patch
didn't establish that limit -- it just took the existing limit and
made it more visible. I intend to reduce the size of the cache in a
future patch.

10:59 AM Changeset in webkit [143132] by Christophe Dumez
  • 4 edits in trunk

Regression(r143124): Caused plugins/plugin-javascript-access.html to fail
​https://bugs.webkit.org/show_bug.cgi?id=110053

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Clear m_plugins in loadPluginsIfNecessary() before populating the
vector again. We get duplicates otherwise.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::loadPluginsIfNecessary):

LayoutTests:

Unskip plugins/plugin-javascript-access.html for WK2 EFL now that the
Test is passing again.

  • platform/efl-wk2/TestExpectations:
10:53 AM Changeset in webkit [143131] by Christophe Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed. Remove duplicates from EFL port's TestExpectations.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
7:39 AM Changeset in webkit [143130] by Christophe Dumez
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Generate baseline for svg/filters/filter-hidden-content.svg on EFL
port.

  • platform/efl/svg/filters/filter-hidden-content-expected.png: Added.
  • platform/efl/svg/filters/filter-hidden-content-expected.txt: Added.
7:35 AM Changeset in webkit [143129] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark compositing/geometry/limit-layer-bounds-fixed.html as failing on
EFL WK2. This test was introduced in r143073 but never passed on EFL.

  • platform/efl-wk2/TestExpectations:
7:19 AM Changeset in webkit [143128] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark plugins/plugin-javascript-access.html as failing on WK2 EFL
due to a regression in r143124.

  • platform/efl-wk2/TestExpectations:
1:14 AM Changeset in webkit [143127] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed buildfix for !USE(LIBXML) builds after r143112.

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

12:50 AM FeatureFlags edited by Laszlo Gombos
See r142533 (diff)
12:44 AM Changeset in webkit [143126] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Rename new-commit-bot to WKR to disambiguate it from commit-queue.

Rubber-stamped by Andreas Kling.

  • Scripts/webkitpy/tool/commands/newcommitbot.py:

(NewCommitBot.begin_work_queue):

12:17 AM Changeset in webkit [143125] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Optimize GlyphPage for case where all glyphs are available in the same font.
<​http://webkit.org/b/108835>
<rdar://problem/13157042>

Reviewed by Antti Koivisto.

Let GlyphPage begin optimistically assuming that all its glyphs will be represented in
the same SimpleFontData*. In this (very common) case, only keep a single SimpleFontData*.

If glyphs from multiple fonts are mixed in one page, an array of per-glyph SimpleFontData*
is allocated transparently.

This was landed before with some bogus branch prediction hints and didn't fare well on
page cyclers (intl2 specifically.) These have been removed this time around, and will
hopefully be regression-free.

4.98 MB progression on Membuster3.

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::createUninitialized):
(WebCore::GlyphPage::createZeroedSystemFallbackPage):
(WebCore::GlyphPage::createCopiedSystemFallbackPage):

There are now three ways of constructing a GlyphPage, two of them are only used for
creating system fallback pages.

(WebCore::GlyphPage::setGlyphDataForIndex):

Hold off creating a SimpleFontData* array until we're sure there are two different
SimpleFontData* backing the glyphs in this page.
We don't store font data for glyph #0, instead we let the getters always return null for it.

(WebCore::GlyphPage::~GlyphPage):

Free the SimpleFontData* array if needed.

(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):

The font data for glyph #0 is always a null pointer now.

(WebCore::GlyphPage::clearForFontData):

Updated for new storage format.

  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):

Fix bug where non-zero glyph was temporarily associated with null font data,
which triggered the new assertion in setGlyphDataForIndex().

Feb 16, 2013:

10:01 PM Changeset in webkit [143124] by akling@apple.com
  • 6 edits in trunk/Source

Source/WebCore: Remove multi-threading gunk from WebKit2's PluginInfoStore.
<​http://webkit.org/b/110046>

Reviewed by Alexey Proskuryakov.

Remove now-unused code for making deep (isolated) copies of WebCore plugin structures.

  • plugins/PluginData.h:

(MimeClassInfo):
(PluginInfo):

Source/WebKit2: Remove multi-threading gunk from PluginInfoStore.
<​http://webkit.org/b/110046>

Reviewed by Alexey Proskuryakov.

PluginInfoStore is never accessed from multiple threads anymore, so remove the Mutex locking
and stop making isolated copies of everything.

  • Shared/Plugins/PluginModuleInfo.h:

(PluginModuleInfo):

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::loadPluginsIfNecessary):
(WebKit::PluginInfoStore::plugins):
(WebKit::PluginInfoStore::findPluginForMIMEType):
(WebKit::PluginInfoStore::findPluginForExtension):
(WebKit::PluginInfoStore::findPlugin):
(WebKit::PluginInfoStore::infoForPluginWithPath):

  • UIProcess/Plugins/PluginInfoStore.h:

(PluginInfoStore):

9:42 PM Changeset in webkit [143123] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Identifier generated twice in FrameLoader::loadResourceSynchronously()
​https://bugs.webkit.org/show_bug.cgi?id=110022

Reviewed by Darin Adler.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): Fix an apparent refactoring mistake.
9:36 PM Changeset in webkit [143122] by fpizlo@apple.com
  • 8 edits
    1 delete in trunk/Source/JavaScriptCore

Remove support for bytecode comments, since it doesn't build, and hasn't been used in a while.
​https://bugs.webkit.org/show_bug.cgi?id=110035

Rubber stamped by Andreas Kling.

There are other ways of achieving the same effect, like adding print statements to the bytecode generator.
The fact that this feature doesn't build and nobody noticed implies that it's probably not a popular
feature. As well, the amount of wiring that was required for it was quite big considering its relatively
modest utility.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp:

(JSC):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecode/Comment.h: Removed.
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitOpcode):
(JSC):

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):
(JSC::BytecodeGenerator::symbolTable):

9:19 PM Changeset in webkit [143121] by glenn@skynav.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

8:08 PM Changeset in webkit [143120] by bfulgham@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[Windows] Unreviewed Visual Studio 2010 build fix after r143117

  • JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebug.props: Reference new path to property sheets.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

Build correction after new operator == added.

5:03 PM Changeset in webkit [143119] by rniwa@webkit.org
  • 3 edits in trunk/Tools

new-commit-bot should report the full name of committer and reviewer instead of just nicks
​https://bugs.webkit.org/show_bug.cgi?id=110040

Reviewed by Darin Adler.

Have it report names like "Ryosuke Niwa (rniwa)" instead of just "rniwa".

  • Scripts/webkitpy/tool/commands/newcommitbot.py:

(NewCommitBot):
(NewCommitBot._summarize_commit_log):

  • Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
5:02 PM Changeset in webkit [143118] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

[JSC] Remove custom mark function for NamedNodeMap.
<​http://webkit.org/b/110029>

Reviewed by Darin Adler.

NamedNodeMap refs and unrefs its Element owner, so there's no need for the wrapper to keep the Element alive.

Covered by fast/dom/Attr/access-after-element-destruction.html

  • bindings/js/JSNamedNodeMapCustom.cpp:
  • dom/NamedNodeMap.idl:
4:11 PM Changeset in webkit [143117] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix non-production builds.

  • WebKit2.xcodeproj/project.pbxproj:
3:51 PM Changeset in webkit [143116] by Darin Adler
  • 2 edits in trunk/Source/WTF

Remove redundant use of inline keyword in StringHasher.h
​https://bugs.webkit.org/show_bug.cgi?id=110036

Reviewed by Geoffrey Garen.

I have some other improvements for StringHasher.h, but wanted to get the simplest ones
out of the way first.

  • wtf/StringHasher.h: Remove inline keyword on functions inside the class definition,

since functions defined inside the class are automatically inline.

3:47 PM Changeset in webkit [143115] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r143076): Crash when calling removeNamedItem or removeNamedItemNS with a non-existent attribute of newly created element.
<​http://webkit.org/b/110019>

Patch by Peter Nelson <​peter@peterdn.com> on 2013-02-16
Reviewed by Andreas Kling.

Now checks Element::hasAttributes() before calling Element::getAttributeItemIndex().

Test: http/tests/misc/acid3.html

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):

3:34 PM Changeset in webkit [143114] by akling@apple.com
  • 9 edits in trunk/Source/WebCore

Element: Devirtualize attribute synchronization functions.
<​http://webkit.org/b/110033>

Reviewed by Darin Adler.

Devirtualize the functions that perform re-serialization of lazy attributes and give
them "synchronize"-style names:

  • SVGElement::synchronizeAnimatedSVGAttribute()
  • StyledElement::synchronizeStyleAttributeInternal()
  • dom/Element.cpp:

(WebCore::Element::synchronizeAllAttributes):
(WebCore::Element::synchronizeAttribute):

  • dom/Element.h:
  • dom/StyledElement.cpp:

(WebCore::StyledElement::synchronizeStyleAttribute):

  • dom/StyledElement.h:

(StyledElement):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::synchronizeAnimatedSVGAttribute):

  • svg/SVGElement.h:

(SVGElement):

3:02 PM Changeset in webkit [143113] by weinig@apple.com
  • 2 edits
    1 delete in trunk/Source/WebKit2

The Plugin.32 target does not build
​https://bugs.webkit.org/show_bug.cgi?id=110032

Reviewed by Anders Carlsson.

  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32/PluginService.32.Main.mm: Removed.

This was meant to be removed already.

  • WebKit2.xcodeproj/project.pbxproj:

Add Plugin.32 as dependency in All as it should be.

2:57 PM Changeset in webkit [143112] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Element: Avoid unrelated attribute synchronization on other attribute access.
<​http://webkit.org/b/110025>

Reviewed by Darin Adler.

We've been extremely trigger happy with re-serializing the style attribute (and SVG animatables)
whenever any Element attribute API was used. This patch narrows this down to (almost always)
only synchronizing an attribute when someone specifically wants to read/update it.

Also removed two more confusing ElementData accessors:

  • Element::elementDataWithSynchronizedAttributes()
  • Element::ensureElementDataWithSynchronizedAttributes()
  • dom/Element.h:
  • dom/Element.cpp:

(WebCore::Element::hasAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::synchronizeAllAttributes):

Renamed updateInvalidAttributes() to synchronizeAllAttributes().
This function should only be used when we need every single attribute to be up-to-date.

(WebCore::Element::synchronizeAttribute):

Broke out logic for synchronizing a specific attribute, given either a full QualifiedName
or a localName.

(WebCore::Element::setSynchronizedLazyAttribute):

Don't call ensureUniqueElementData() indisciminately here. This avoids converting the attribute
storage when re-serializing the inline style yields the same CSS text that was already in the
style attribute.

(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::getAttribute):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):

Only synchronize the attribute in question.

  • dom/Node.cpp:

(WebCore::Node::compareDocumentPosition):

Call synchronizeAllAttributes() when comparing two Attr nodes on the same Element instead
of relying on the side-effects of another function doing this.

2:27 PM Changeset in webkit [143111] by Darin Adler
  • 3 edits in trunk/Source/WebKit2

Fix WKDOMRangePrivate.h mistakes
​https://bugs.webkit.org/show_bug.cgi?id=110028

Reviewed by Ryosuke Niwa.

  • WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

Added include of WKDOMRangePrivate.h.

  • WebProcess/InjectedBundle/API/mac/WKDOMRangePrivate.h:

Fixed class name and include to be WKDOMRange.
Fixed method name, _copyBundleRangeHandleRef, to match the
name in the source file.

2:24 PM Changeset in webkit [143110] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a flaky image only failure expectation to the test added in r142979 on Mac per bug 110027.

  • platform/mac/TestExpectations:
1:57 PM Changeset in webkit [143109] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk/Tools

We need a CIA replacement
​https://bugs.webkit.org/show_bug.cgi?id=110008

Reviewed by Andreas Kling.

Added new-commit-bot.

  • Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngine.init):
(QueueEngine): Made the sleep tiem configurable.
(QueueEngine._sleep_message):
(QueueEngine._sleep):

  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:

(QueueEngineTest.test_sleep_message):

  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/newcommitbot.py: Added.

(PingPong): Added. Implements the ping pong protocol.
(NewCommitBot):
(NewCommitBot.begin_work_queue):
(NewCommitBot.work_item_log_path):
(NewCommitBot.next_work_item): Update SVN revision and report any new commits made since
the last time we checked the head SVN revision.
(NewCommitBot.process_work_item):
(NewCommitBot._update_checkout): svn up.
(NewCommitBot._new_svn_revisions): Returns a range of new revisions.
(NewCommitBot._summarize_commit_log): Summarize a commit log to be posted on IRC.
(NewCommitBot.handle_unexpected_error):
(NewCommitBot.handle_script_error):

  • Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Added.

(NewCommitBotTest.test_summarize_commit_log_basic): Tests for summarizing non-rollout commits.
(NewCommitBotTest.test_summarize_commit_log_rollout): Tests for summarizing rollouts.

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractQueue.execute):

  • Scripts/webkitpy/tool/commands/queuestest.py:

(MockQueueEngine.init):

  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

(SheriffBotTest.test_command_aliases):

  • Scripts/webkitpy/tool/main.py:

(WebKitPatch):

1:00 PM Changeset in webkit [143108] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build warnings after r139853
​https://bugs.webkit.org/show_bug.cgi?id=109929

Patch by Seokju Kwon <Seokju Kwon> on 2013-02-16
Reviewed by Alexey Proskuryakov.

Use UNUSED_PARAM macro to fix build warning -Wunused-parameter
when INSPECTOR is disabled.

No new tests, no behavior change.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore::InspectorInstrumentation::frameStoppedLoading):
(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):

12:07 PM Changeset in webkit [143107] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation of Structure.h

Rubber stamped by Mark Hahnenberg.

  • runtime/Structure.h:
10:27 AM Changeset in webkit [143106] by jochen@chromium.org
  • 3 edits in trunk/Tools

[chromium] initialize all variables of TestRunner classes
​https://bugs.webkit.org/show_bug.cgi?id=110013

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

10:08 AM Changeset in webkit [143105] by jochen@chromium.org
  • 2 edits in trunk/Tools

[chromium] destroy the TestPlugin when the destroy() method is invoked.
​https://bugs.webkit.org/show_bug.cgi?id=110012

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

(WebTestRunner::TestPlugin::destroy):

9:09 AM Changeset in webkit [143104] by commit-queue@webkit.org
  • 11 edits
    3 deletes in trunk

Unreviewed, rolling out r142734.
​http://trac.webkit.org/changeset/142734
​https://bugs.webkit.org/show_bug.cgi?id=110018

"Triggered crashes on lots of websites" (Requested by ggaren
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-16

Source/WebCore:

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):

LayoutTests:

  • http/tests/plugins/resources/cross-frame-object-access.html:
  • http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
  • http/tests/security/cross-frame-access-location-get-expected.txt:
  • http/tests/security/cross-frame-access-location-get.html:
  • http/tests/security/resources/cross-frame-access.js:
  • http/tests/security/resources/cross-frame-iframe-callback-explicit-domain-DENY.html:
  • http/tests/security/resources/cross-frame-iframe-for-location-get-test.html:
  • http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt: Removed.
  • platform/chromium/http/tests/security/cross-frame-access-location-get-expected.txt: Removed.
  • platform/chromium/http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt: Removed.
8:35 AM Changeset in webkit [143103] by toyoshim@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Rebaseline for Win7.

Unreviewed chromium gardening.

  • platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
5:06 AM Changeset in webkit [143102] by robert@webkit.org
  • 5 edits
    10 adds in trunk

percentage top value of position:relative element not calculated using parent's min-height unless height set
​https://bugs.webkit.org/show_bug.cgi?id=14762

Reviewed by Julien Chaffraix.

Source/WebCore:

Percentage height "is calculated with respect to the height of the generated box's containing block" says
​http://www.w3.org/TR/CSS21/visudet.html#the-height-property and "If the height of the containing block is not
specified explicitly (i.e., it depends on content height), and this element is not absolutely positioned, the
value computes to 'auto'." So when calculating the used height of a replaced element do not crawl through ancestor
blocks except when traversing anonymous blocks. Ensure that anonymous table cells are not skipped through though.

​http://www.w3.org/TR/CSS21/tables.html#height-layout adds "In CSS 2.1, the height of a cell box is the minimum
height required by the content." This height is decided by allowing table cells to report their height as auto.
It's not clear why ​http://trac.webkit.org/changeset/91242 decided it should no longer do this - doing so caused
us to regress in our rendering of computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor.html.

Tests: fast/block/percent-top-parent-respects-min-height.html

fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor-vertical-lr.html
fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor.html
fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor-vertical-lr.html
fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight):
(WebCore):
(WebCore::RenderBoxModelObject::relativePositionOffset):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::hasReplacedLogicalHeight):

LayoutTests:

  • fast/block/percent-top-parent-respects-min-height-expected.txt: Added.
  • fast/block/percent-top-parent-respects-min-height.html: Added.
  • fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor-expected.txt: Added.
  • fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor-vertical-lr-expected.txt: Added.
  • fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor-vertical-lr.html: Added.
  • fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor.html: Added.
  • fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor-expected.txt: Added.
  • fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor-vertical-lr-expected.txt: Added.
  • fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor-vertical-lr.html: Added.
  • fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor.html: Added.
4:45 AM Changeset in webkit [143101] by senorblanco@chromium.org
  • 7 edits
    1 add in trunk

[skia] FEOffset should have a Skia implementation.
​https://bugs.webkit.org/show_bug.cgi?id=109831

Reviewed by James Robinson.

Source/WebCore:

Covered by css3/filters/effect-reference.html and -hw.html.

  • WebCore.gypi:
  • platform/graphics/filters/FEOffset.h: Implement createImageFilter()

for the Skia path.

  • platform/graphics/filters/skia/FEOffsetSkia.cpp: Added.

(WebCore::FEOffset::createImageFilter):
Instantiate an SkOffsetImageFilter when building the Skia DAG.

LayoutTests:

  • css3/filters/effect-reference-hw.html:
  • css3/filters/effect-reference.html:
  • platform/chromium/TestExpectations:
3:28 AM Changeset in webkit [143100] by vsevik@chromium.org
  • 9 edits in trunk

Web Inspector: Create separate project for each domain for UISourceCode based on browser resources.
​https://bugs.webkit.org/show_bug.cgi?id=109691

Reviewed by Pavel Feldman.

Source/WebCore:

Separate project of certain type is now created for each domain.
UISourceCode path represents a path in the project now.
UISourceCode uri is now calculated based on project id and path.
It is also possible to calculate path based on projectId and URI, which is used for uiSourceCodeForURI() methods.

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):

  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.projectId):
(WebInspector.SimpleProjectDelegate.prototype.id):
(WebInspector.SimpleProjectDelegate.prototype.displayName):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.splitURL):
(WebInspector.SimpleWorkspaceProvider._pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._projectDelegate):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFile):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.uri):
(WebInspector.UISourceCode.path):
(WebInspector.UISourceCode.prototype.uri):

  • inspector/front-end/Workspace.js:

(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCodeForURI):

LayoutTests:

  • inspector/debugger/live-edit-breakpoints-expected.txt:
  • inspector/debugger/live-edit-breakpoints.html:
  • inspector/uisourcecode-revisions.html:
12:46 AM Changeset in webkit [143099] by Christophe Dumez
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix.

Export symbol for new CString operator== operator to fix Windows build.

Note: See TracTimeline for information about the timeline view.