Timeline
Feb 19, 2013:
- 11:42 PM Changeset in webkit [143433] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark fast/regions/seamless-iframe-flowed-into-regions.html failure
https://bugs.webkit.org/show_bug.cgi?id=110283
Unreviewed. This test is added by r143256 and it is failing.
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-19
- platform/efl/TestExpectations:
- 10:54 PM Changeset in webkit [143432] by
-
- 2 edits in trunk/Source/WebCore
Few methods in WebGLRenderingContext.idl have incorrect signatures
https://bugs.webkit.org/show_bug.cgi?id=110305
Reviewed by Kentaro Hara.
- html/canvas/WebGLRenderingContext.idl:
- 10:14 PM Changeset in webkit [143431] by
-
- 4 edits16 adds1 delete in trunk/LayoutTests
Unreviewed, rolling out r143393.
http://trac.webkit.org/changeset/143393
https://bugs.webkit.org/show_bug.cgi?id=110302
the converted reftest fails in chromium mac 10.6 and 10.7
(Requested by toyoshim on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19
- fast/flexbox/box-orient-button.html:
- fast/flexbox/resources/box-orient-button.js:
- fast/invalid/residual-style-expected.html: Removed.
- fast/invalid/residual-style.html:
- platform/chromium-android/fast/invalid/residual-style-expected.png: Added.
- platform/chromium-android/fast/invalid/residual-style-expected.txt: Added.
- platform/chromium-linux/fast/invalid/residual-style-expected.png: Added.
- platform/chromium-linux/fast/invalid/residual-style-expected.txt: Added.
- platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Added.
- platform/chromium-mac/fast/invalid/residual-style-expected.png: Added.
- platform/chromium-mac/fast/invalid/residual-style-expected.txt: Added.
- platform/chromium-win/fast/invalid/residual-style-expected.png: Added.
- platform/chromium-win/fast/invalid/residual-style-expected.txt: Added.
- platform/efl/fast/invalid/residual-style-expected.png: Added.
- platform/efl/fast/invalid/residual-style-expected.txt: Added.
- platform/gtk/fast/invalid/residual-style-expected.png: Added.
- platform/gtk/fast/invalid/residual-style-expected.txt: Added.
- platform/mac/fast/invalid/residual-style-expected.png: Added.
- platform/mac/fast/invalid/residual-style-expected.txt: Added.
- 10:02 PM Changeset in webkit [143430] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, uninteresting change to test a theory about bad dependency handling.
- API/JSStringRefCF.cpp:
(JSStringCreateWithCFString): Remove an unnecessary else clause.
- 9:57 PM Changeset in webkit [143429] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed, rolling out r143338.
http://trac.webkit.org/changeset/143338
https://bugs.webkit.org/show_bug.cgi?id=110301
False alarm, no need to export the symbol (Requested by
aandrey on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19
- WebKit.vcproj/WebKitExports.def.in:
- 9:53 PM Changeset in webkit [143428] by
-
- 15 edits in trunk/Source
Clarify isInWindow vs. isVisible path through to RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=110261
<rdar://problem/13196122>
Reviewed by Simon Fraser.
Remove RenderLayerCompositor::willMoveOffscreen/didMoveOnscreen.
Add RenderLayerCompositor::setIsInWindow, and pipe in-window changes through from Page::setIsInWindow.
Adjust a few Document functions that previously called RenderView::didMoveOnscreen/willMoveOffscreen to use setIsInWindow instead, since in-win$
- WebCore.exp.in: Export Page::setIsInWindow.
- dom/Document.cpp:
(WebCore::Document::attach): Use setIsInWindow instead of didMoveOnscreen.
(WebCore::Document::documentWillBecomeInactive): Use setIsInWindow instead of willMoveOffscreen.
(WebCore::Document::documentDidResumeFromPageCache): Use setIsInWindow instead of didMoveOnscreen.
- page/FrameView.cpp:
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
RenderView doesn't care about moving on/offscreen, just in-window state.
(WebCore::FrameView::setIsInWindow): Added. Forward isInWindow changes to our RenderView.
- page/FrameView.h:
(FrameView): Add setIsInWindow.
- page/Page.cpp:
(WebCore::Page::setIsInWindow): Added. Forward isInWindow changes to the Page's FrameViews.
- page/Page.h:
(Page): Add setIsInWindow.
(WebCore::Page::isInWindow):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::setIsInWindow): Added. Replace willMoveOffscreen/didMoveOnscreen with setIsInWindow,
since that's the only change we actually care about.
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor): Add setIsInWindow.
- rendering/RenderView.cpp:
(WebCore::RenderView::setIsInWindow): Added. Replace willMoveOffscreen/didMoveOnscreen with setIsInWindow,
since that's the only change RenderLayerCompositor actually cares about.
- rendering/RenderView.h:
(RenderView): Add setIsInWindow.
- WebView/WebView.mm:
(-[WebView viewWillMoveToWindow:]):
(-[WebView viewDidMoveToWindow]):
Use Page::setIsInWindow in addition to willMoveOffscreen/didMoveOnscreen.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setIsInWindow):
Use Page::setIsInWindow in addition to willMoveOffscreen/didMoveOnscreen.
- 9:24 PM Changeset in webkit [143427] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Cleanup and add JSDocs to SuggestBox
https://bugs.webkit.org/show_bug.cgi?id=110202
Reviewed by Pavel Feldman.
SuggestBox contains some obsolete/unused code and not fully
covered with JSDocs.
- inspector/front-end/SuggestBox.js:
(WebInspector.SuggestBox.prototype.visible):
Replaced getter with function.
(WebInspector.SuggestBox.prototype._onScrollOrResize):
Use camel-case for function names.
(WebInspector.SuggestBox.prototype._onBoxMouseDown): Ditto.
(WebInspector.SuggestBox.prototype.updateSuggestions):
Removed unused code.
(WebInspector.SuggestBox.prototype.hide): Adopt changes.
(WebInspector.SuggestBox.prototype._applySuggestion): Ditto.
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.isSuggestBoxVisible): Ditto.
- 7:05 PM Changeset in webkit [143426] by
-
- 5 edits in trunk/Source/WebCore
Calculate EventPath in EventDispatcher's constructor.
https://bugs.webkit.org/show_bug.cgi?id=109905
Reviewed by Dimitri Glazkov.
This patch calculates an EventPath in EventDispatcher's
constructor and removes EventDispatcher::ensureEventPath().
We don't have any reason to initialize an EventPath lazily.
No tests. No change in behavior.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatch):
- dom/EventDispatcher.h:
(WebCore::EventDispatcher::eventPath):
(EventDispatcher):
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
- 6:49 PM Changeset in webkit [143425] by
-
- 2 edits in trunk/Tools
Remove warning from run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=110285
Reviewed by Kentaro Hara.
Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
"Unknown option: idlattributesfile". That option was removed from
bindings/scripts/preprocess-idls.pl but was still being passed by
the test script. Remove it.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency): Remove unused arg.
- 6:46 PM Changeset in webkit [143424] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r143400.
http://trac.webkit.org/changeset/143400
https://bugs.webkit.org/show_bug.cgi?id=110290
breaks everything (instacrash launching Safari) (Requested by
thorton on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19
- wtf/FastMalloc.cpp:
(WTF::internalEntropyValue):
(WTF):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):
- 6:28 PM Changeset in webkit [143423] by
-
- 3 edits2 adds in trunk
Fix TileCache tile size when zoomed on slow-scrolling site
https://bugs.webkit.org/show_bug.cgi?id=110289
Source/WebCore:
Reviewed by Tim Horton.
In slow scrolling mode, we use the tile coverage rect as the tile size
(so a single tile covers the viewport). When zoomed, the tile coverage rect
shrinks relative to the TileCache, so scale the tile size back up.
Test: platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::tileSizeForCoverageRect):
LayoutTests:
Reviewed by Tim Horton.
Test that dumps tile coverage in a slow-scrolling, zoomed page.
- platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html: Added.
- 6:27 PM Changeset in webkit [143422] by
-
- 12 edits2 moves in trunk/Source/WebCore
Rename AncestorChainWalker.
https://bugs.webkit.org/show_bug.cgi?id=110146
Reviewed by Dimitri Glazkov.
Rename AncestorChainWalker to EventPathWalker.
The term of EventPath is used in DOM Core spec. EventPath was
already introduced into a EventContext.h in r112055. We should
spread this term into the Walker class since they share the same
purpose.
No new tests, no behavior change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/EventDispatcher.cpp:
- dom/EventPathWalker.cpp: Renamed from Source/WebCore/dom/AncestorChainWalker.cpp.
(WebCore):
(WebCore::EventPathWalker::EventPathWalker):
(WebCore::EventPathWalker::parent): parent() is now a static function to cover simple use cases.
(WebCore::EventPathWalker::moveToParent): Renamed from parent().
- dom/EventPathWalker.h: Renamed from Source/WebCore/dom/AncestorChainWalker.h.
(WebCore):
(EventPathWalker):
(WebCore::EventPathWalker::node):
(WebCore::EventPathWalker::isVisitingInsertionPointInReprojection): Renamed from isCrossingInsertionPoint().
- dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::calculateEventPath):
(WebCore::EventRetargeter::buildRelatedNodeMap):
- dom/TreeScope.cpp:
(WebCore::TreeScope::focusedNode):
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::attach):
- page/EventHandler.cpp:
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::handleWheelEvent):
- 5:59 PM Changeset in webkit [143421] by
-
- 2 edits in trunk/Source/WebCore
Snapshotted plugin label should not be selectable
https://bugs.webkit.org/show_bug.cgi?id=110286
Reviewed by Simon Fraser.
Update the CSS to make it clear that you should click
on a snapshot (use the finger pointer) and disable
text selection.
- css/plugIns.css:
(embed::-webkit-snapshotted-plugin-content .snapshot-container .snapshot-label):
- 5:56 PM Changeset in webkit [143420] by
-
- 3 edits2 adds in trunk
[CSS Exclusions] Enable shape-inside support for ellipses
https://bugs.webkit.org/show_bug.cgi?id=109868
Reviewed by Dirk Schulze.
Source/WebCore:
This change is very similar to the one recently made for circles:
removed the test that disabled ellipse values for shape-inside.
The remaining support for ellipses, which is based on rounded rectangles
whose width/height is equal to their radiusX/radiusY, has not changed.
Test: fast/exclusions/shape-inside/shape-inside-ellipse.html
- rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): No longer disallows any BasicShape type.
LayoutTests:
Added a test for ellipse shape-inside values.
- fast/exclusions/shape-inside/shape-inside-ellipse-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-ellipse.html: Added.
- 5:46 PM Changeset in webkit [143419] by
-
- 13 edits5 adds in trunk
'round' not implemented in border-image
https://bugs.webkit.org/show_bug.cgi?id=14185
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-02-19
Reviewed by David Hyatt.
Source/WebCore:
Add rendering support for 'round' keyword of border-image-repeat CSS property
http://dev.w3.org/csswg/css3-background/#border-image-repeat
Rebased original patch by Benjamin Otte <otte@gnome.org> and made few fixes.
Test: fast/borders/border-image-02.html
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h:
(GraphicsContext):
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
- platform/graphics/Image.h:
(Image):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage): For 'round' keyword,
the image is tiled (repeated) to fill the area. If it does not fill the area
with a whole number of tiles, the image is rescaled so that it does.
LayoutTests:
Added test for 'round' keyword of border-image-repeat CSS property
http://dev.w3.org/csswg/css3-background/#border-image-repeat
- fast/borders/border-image-02.html: Added.
- platform/chromium-linux/fast/borders/border-image-02-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/fast/borders/border-image-02-expected.txt: Added.
- platform/efl/TestExpectations:
- platform/gtk/fast/borders/border-image-02-expected.png: Added.
- platform/gtk/fast/borders/border-image-02-expected.txt: Added.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 5:42 PM Changeset in webkit [143418] by
-
- 18 edits in trunk/Source
Allow UI clients to handle vertical wheel events.
https://bugs.webkit.org/show_bug.cgi?id=110006
Patch by Conrad Shultz <Conrad Shultz> on 2013-02-19
Reviewed by Tim Horton.
Source/WebCore:
Add API to allow matching changes in WebKit2 to control rubber-banding behavior at vertical page extrema.
If rubber-banding is disabled during a scroll event that would otherwise trigger rubber-banding, dispatch
didNotHandleWheelEvent() to the page UI client.
- WebCore.exp.in:
Export new rubber-banding API.
- page/Page.cpp:
(WebCore):
(WebCore::Page::rubberBandsAtBottom):
Proxy for the corresponding function in ScrollingCoordinator.
(WebCore::Page::setRubberBandsAtBottom):
Ditto.
(WebCore::Page::rubberBandsAtTop):
Ditto.
(WebCore::Page::setRubberBandsAtTop):
Ditto.
- page/Page.h:
(Page):
Declare new rubber-banding API (above).
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::rubberBandsAtBottom):
Stub API implementation.
(WebCore::ScrollingCoordinator::setRubberBandsAtBottom):
Ditto.
(WebCore::ScrollingCoordinator::rubberBandsAtTop):
Ditto.
(WebCore::ScrollingCoordinator::setRubberBandsAtTop):
Ditto.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
Initialize new member variables.
(WebCore::ScrollingTree::setMainFramePinState):
Set top/bottom pinned states.
(WebCore::ScrollingTree::rubberBandsAtBottom):
New accessor function.
(WebCore::ScrollingTree::setRubberBandsAtBottom):
New mutator function.
(WebCore::ScrollingTree::rubberBandsAtTop):
New accessor function.
(WebCore::ScrollingTree::setRubberBandsAtTop):
New mutator function.
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
Start a vertical swipe event if the frame is pinned at the top or bottom and associated rubber-banding is disabled.
- page/scrolling/ScrollingTree.h:
(ScrollingTree):
Declare new rubber-banding API and associated member variables.
- page/scrolling/mac/ScrollingCoordinatorMac.h:
(ScrollingCoordinatorMac):
Declare API overrides.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::rubberBandsAtBottom):
Method override; proxy to corresponding function in ScrollingTree.
(WebCore::ScrollingCoordinatorMac::setRubberBandsAtBottom):
Ditto.
(WebCore::ScrollingCoordinatorMac::rubberBandsAtTop):
Ditto.
(WebCore::ScrollingCoordinatorMac::setRubberBandsAtTop):
Ditto.
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::pinnedInDirection):
Remove trailing whitespace.
(WebCore::ScrollingTreeScrollingNodeMac::updateMainFramePinState):
Calculate and pass vertical pinning state to ScrollingTree::setMainFramePinState().
Source/WebKit2:
Add API to allow clients to selectively control rubber-banding at vertical page extrema.
- UIProcess/API/C/WKPage.cpp:
(WKPageRubberBandsAtBottom):
Proxy for the corresponding function in WebCore::Page.
(WKPageSetRubberBandsAtBottom):
Ditto.
(WKPageRubberBandsAtTop):
Ditto.
(WKPageSetRubberBandsAtTop):
Ditto.
- UIProcess/API/C/WKPage.h:
Declare new API.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Initialize new member variables.
(WebKit::WebPageProxy::setRubberBandsAtBottom):
New function; dispatches a matching message to the WebKit::WebPage.
(WebKit::WebPageProxy::setRubberBandsAtTop):
Ditto.
- UIProcess/WebPageProxy.h:
(WebPageProxy):
Declare new API.
(WebKit::WebPageProxy::rubberBandsAtBottom):
New accessor function.
(WebKit::WebPageProxy::rubberBandsAtTop):
Ditto.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setRubberBandsAtBottom):
New function; call the matching function on the associated WebCore::Page.
(WebKit::WebPage::setRubberBandsAtTop):
Ditto.
- WebProcess/WebPage/WebPage.h:
(WebPage):
Declare new rubber-banding API.
- WebProcess/WebPage/WebPage.messages.in:
Declare new rubber-banding API.
- 5:29 PM Changeset in webkit [143417] by
-
- 5 edits in trunk/Source/WebCore
Rubber-banding should not affect the visibleRect of the TileCache
https://bugs.webkit.org/show_bug.cgi?id=110278
Reviewed by Beth Dakin.
When rubber-banding a slow-scrolling page, or image document, we would constantly re-create
the bottom tile because of the logic that adapts the tile size to the visible rect when slow
scrolling.
Avoid that by ensuring that the visibleRect is not affected by rubber-banding. This is done
via a GraphicsLayerClient function that allows RenderLayerCompositor to provide a custom
position for the scroll layer. We constrain that scroll position to remove the overhang that
results from rubber-banding.
I wasn't able to make a test for this, even with internals.setScrollViewPosition().
- platform/graphics/GraphicsLayerClient.h:
(GraphicsLayerClient):
(WebCore::GraphicsLayerClient::customPositionForVisibleRectComputation):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::computeVisibleRect):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::customPositionForVisibleRectComputation):
- rendering/RenderLayerCompositor.h:
- 5:24 PM Changeset in webkit [143416] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed, force file to recompile to fix win build.
- WebView.cpp:
- 5:20 PM Changeset in webkit [143415] by
-
- 8 edits in trunk/Source/WebCore
Fix crash in preloading scanning base tags with no href attribute for background parser
https://bugs.webkit.org/show_bug.cgi?id=110276
Reviewed by Eric Seidel.
Previously a <base> tag without an href attribute (like the one in fast/dom/HTMLAnchorElement/set-href-attribute-rebase.html)
would crash the background parser's preload scanner.
To fix that, we only call stripLeadingAndTrailingHTMLSpaces() if the href attribute is non-null. This matches the main thread parser.
Along with this, I decided to templatize updatePredictedBaseURL() so that the main and background parser can share the same impl.
This required making CompactHTMLToken and HTMLToken a little more similar:
- Give HTMLToken a getAttributeItem() method.
- Move CompactAttribute to CompactHTMLToken::Attribute and make it a struct.
No new tests because covered by existing tests.
- html/parser/AtomicHTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- html/parser/CompactHTMLToken.cpp:
(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken):
(WebCore::CompactHTMLToken::getAttributeItem):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):
- html/parser/CompactHTMLToken.h:
(WebCore::CompactHTMLToken::Attribute::Attribute):
(Attribute):
(WebCore::CompactHTMLToken::attributes):
(CompactHTMLToken):
(WebCore::CompactHTMLToken::publicIdentifier):
(WebCore::CompactHTMLToken::systemIdentifier):
- html/parser/HTMLParserIdioms.h:
(WebCore):
(WebCore::stripLeadingAndTrailingHTMLSpaces):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore):
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):
- html/parser/HTMLPreloadScanner.h:
- html/parser/HTMLToken.h:
(WebCore::HTMLToken::getAttributeItem):
(HTMLToken):
- 5:18 PM Changeset in webkit [143414] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, include exports for VS2010 as well.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 4:55 PM Changeset in webkit [143413] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp
Merge 142890
IndexedDB: Add a few more histogram calls
https://bugs.webkit.org/show_bug.cgi?id=109762
Reviewed by Tony Chang.
A few places where commits could fail weren't being logged.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::IDBBackingStore::Transaction::commit):
TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/12288067
- 4:48 PM Changeset in webkit [143412] by
-
- 6 edits2 adds in trunk/Source/WebCore
Introducing AbstractSQLTransaction and AbstractSQLTransactionBackend.
https://bugs.webkit.org/show_bug.cgi?id=110273.
Reviewed by Anders Carlsson.
This is part of the webdatabase refactoring for webkit2.
- Also changed the frontend and backend to only refer to the abstract interface of each other.
No new tests.
- Modules/webdatabase/AbstractSQLTransaction.h: Added.
(AbstractSQLTransaction):
(WebCore::AbstractSQLTransaction::~AbstractSQLTransaction):
- Modules/webdatabase/AbstractSQLTransactionBackend.h: Added.
(AbstractSQLTransactionBackend):
(WebCore::AbstractSQLTransactionBackend::~AbstractSQLTransactionBackend):
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::hasCallback):
(WebCore::SQLTransaction::hasSuccessCallback):
(WebCore::SQLTransaction::hasErrorCallback):
(WebCore::SQLTransaction::setBackend):
- Modules/webdatabase/SQLTransaction.h:
(SQLTransaction):
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
- Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
- Modules/webdatabase/SQLTransactionStateMachine.h:
- 4:47 PM Changeset in webkit [143411] by
-
- 2 edits in trunk/Source/JavaScriptCore
Silence some analyzer warnings
https://bugs.webkit.org/show_bug.cgi?id=110281
Reviewed by Mark Hahnenberg.
The static analyzer believes that callerCodeBlock can be null,
based on other code performing null tests. This should not
ever be the case, but we'll add RELEASE_ASSERTs to make it
obvious if we're ever wrong.
- interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
- 4:47 PM ExportingSymbols edited by
- Updated path to win exports file. (diff)
- 4:45 PM Changeset in webkit [143410] by
-
- 4 edits in trunk/Source/WebCore
Change computeStickyPositionConstraints to use LayoutBoxExtent for margins
https://bugs.webkit.org/show_bug.cgi?id=108872
Reviewed by Levi Weintraub.
Change RenderBoxModelObject::computeStickyPositionConstraints to
use a LayoutBoxExtent to represent margins.
No new tests, no change in functionality.
- platform/graphics/LayoutRect.h:
(WebCore::LayoutRect::contract):
Add version contract methods that takes a LayoutBoxExtent object.
- platform/graphics/LayoutSize.h:
(WebCore::LayoutSize::shrink):
Add shrink method.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints):
Change to use a LayoutBoxExtent object to represent margins.
- 4:45 PM NewRunWebKitTests edited by
- (diff)
- 4:45 PM Changeset in webkit [143409] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed, fix the Windows build after r143398.
Add new setters to the export list.
- WebKit.vcproj/WebKitExports.def.in:
- 4:42 PM Changeset in webkit [143408] by
-
- 2 edits in trunk/Source/JavaScriptCore
Don't force everything to be blinded in debug builds
https://bugs.webkit.org/show_bug.cgi?id=110279
Reviewed by Mark Hahnenberg.
Switch to an explicit flag for indicating that we want
every constant to be blinded.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlind):
- 4:35 PM Changeset in webkit [143407] by
-
- 2 edits in trunk/Source/WebCore
Disable ASSERT(!hasInsertionPoint()) for background parser
https://bugs.webkit.org/show_bug.cgi?id=110251
Reviewed by Adam Barth.
The background parser crashes about 10 layout tests by hitting ASSERT(!hasInsertionPoint()).
Now, finish() is the thing that closes the HTMLInputStream which removes the insertion point.
In these tests, a document.open() calls insert() which clears the HTMLInputStream which causes
there to be an insertion point again.
With the main thread parser, insert() is called before finish() so the ASSERT passes.
However, with the threaded parser, finish() is called before insert(), so we fail the ASSERT.
This patch disables the ASSERT for the background parser because m_input isn't really relevant.
This causes us to pass the tests. However, there is a risk that now hasInsertionPoint() may be incorrect
and Document has a non-debug branch that tests hasInsertionPoint().
No new tests because covered by existing tests.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd):
- 4:34 PM Changeset in webkit [143406] by
-
- 3 edits in trunk/Tools
Unreviewed. Add myself to watch lists.
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/watchlist:
- 4:26 PM Changeset in webkit [143405] by
-
- 2 edits in trunk/Tools
Unreviewed, corrected primary email.
- Scripts/webkitpy/common/config/committers.py:
- 4:25 PM Changeset in webkit [143404] by
-
- 8 edits in trunk/Source/WebCore
Separate constraining for overhang from fixed-position zooming behavior in scrollOffsetForFixedPosition()
https://bugs.webkit.org/show_bug.cgi?id=110267
Reviewed by Beth Dakin.
The static scrollOffsetForFixedPosition() function in ScrollingCoordinator did two things;
it constrained the scroll position when rubber-banding, and applied the special scaling for
fixed position when zoomed.
Separate these out so that we can use the rubber-banding constrained elsewhere.
- page/FrameView.cpp:
(WebCore::FrameView::scrollOffsetForFixedPosition): The static function is here now.
- page/FrameView.h:
- page/scrolling/ScrollingCoordinator.cpp: Code moved to FrameView.
- page/scrolling/ScrollingCoordinator.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition): scrollOffsetForFixedPosition()
is now on FrameView.
- platform/ScrollableArea.cpp:
(WebCore::constrainedScrollPosition): Helper to constrain one axis for overhang.
(WebCore::ScrollableArea::constrainScrollPositionForOverhang): Static function that
can be called by FrameView::scrollOffsetForFixedPosition().
- platform/ScrollableArea.h: Static function constrainScrollPositionForOverhang()
so we can call it from another thread. Also a member fuction of the same name, which takes
the scrollPosition as input (so we can feed it a layer position in a later patch).
- 4:20 PM Changeset in webkit [143403] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r143382 and r143401.
http://trac.webkit.org/changeset/143382
http://trac.webkit.org/changeset/143401
https://bugs.webkit.org/show_bug.cgi?id=106457
Breaks Chromium win/mac canary compilation
Source/Platform:
- chromium/public/Platform.h:
Source/WebKit/chromium:
- public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::idbFactory):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
- 4:15 PM Changeset in webkit [143402] by
-
- 2 edits in trunk/Source/WebCore
Fix checkThatTokensAreSafeToSendToAnotherThread() now that the preload scanner is enabled
https://bugs.webkit.org/show_bug.cgi?id=110258
Reviewed by Adam Barth.
We were hitting this ASSERT on numerous tests with the background parser enabled. This copy fixes the assertion.
No new tests becuase covered by existing tests.
- html/parser/HTMLResourcePreloader.h:
(WebCore::PreloadRequest::setCharset):
- 4:14 PM Changeset in webkit [143401] by
-
- 4 edits in trunk/Source
[Chromium] Move WebKitPlatformSupport declaration to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=110262
Reviewed by Adam Barth.
In preparation for removing WebKitPlatformSupport.h entirely (once
downstream references to that file have been updated). Part of a
larger refactoring series; see tracking bug 82948.
Source/Platform:
- chromium/public/Platform.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
(WebKit):
Source/WebKit/chromium:
- public/platform/WebKitPlatformSupport.h:
- 4:13 PM Changeset in webkit [143400] by
-
- 2 edits in trunk/Source/WTF
Moar hardening
https://bugs.webkit.org/show_bug.cgi?id=110275
Reviewed by Anders Carlsson.
We now poison objects when they get freed, and verify that
any object that is being freed is not poisoned. If the
object looks like it's poisoned we validate the freelist,
and ensure the object is not already present. If it is
we crash.
On allocation, we ensure that the object being allocated
is poisoned, then clear the poisoning fields.
- wtf/FastMalloc.cpp:
(WTF::internalEntropyValue):
(WTF):
(WTF::freedObjectStartPoison):
(WTF::freedObjectEndPoison):
(TCMalloc_ThreadCache_FreeList):
(WTF::TCMalloc_ThreadCache_FreeList::Validate):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):
- 3:58 PM Changeset in webkit [143399] by
-
- 3 edits in trunk/Source/WebCore
Fix typo: inititatorFor->initiatorFor
https://bugs.webkit.org/show_bug.cgi?id=110260
Reviewed by Adam Barth.
No new tests because no changed functionality.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::initiatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
- html/parser/HTMLPreloadScanner.h:
- 3:38 PM Changeset in webkit [143398] by
-
- 13 edits in trunk/Source
Convert 3 settings to use Settings.in
https://bugs.webkit.org/show_bug.cgi?id=109875
Reviewed by Ryosuke Niwa.
Source/WebCore:
Convert mediaEnabled, applicationChromeMode and DOMPasteAllowed to
use Settings.in. They previously had inconsistently named setters.
No new tests, this is a refactoring.
- Source/WebCore/WebCore.exp.in: Remove symbols that are now inlined from exports.
- Source/WebCore/WebCore.order: Remove symbols that no longer exist.
- dom/make_names.pl:
(printConstructorInterior): Rename isMediaEnabled to mediaEnabled.
(printWrapperFunctions): Rename isMediaEnabled to mediaEnabled.
- editing/EditorCommand.cpp:
(WebCore::supportedPaste): Rename isDOMPasteAllowed to DOMPasteAllowed.
- page/Settings.cpp:
(WebCore::Settings::Settings): Remove custom code.
- page/Settings.h:
(Settings): Remove custom code.
- page/Settings.in: Add entries for mediaEnabled, applicationChromeMode and DOMPasteAllowed.
- page/make_settings.pl:
(setterFunctionName): Expand uppercase rules to include DOM.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isDefault): Rename inApplicationChromeMode to applicationChromeMode.
- rendering/RenderThemeWin.cpp:
(WebCore::documentIsInApplicationChromeMode): Rename inApplicationChromeMode to applicationChromeMode.
Source/WebKit/efl:
- ewk/ewk_view.cpp:
(_ewk_view_priv_new): Rename isDOMPasteAllowed to DOMPasteAllowed.
- 3:34 PM Changeset in webkit [143397] by
-
- 5 edits2 adds in trunk
[CSS Grid Layout] Refactor the code in preparation of auto placement support
https://bugs.webkit.org/show_bug.cgi?id=110244
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/css-grid-layout/grid-auto-flow-resolution.html
In order to support auto placement, we need to iterate over the grid items with
auto row / column several times. This changes makes us do that in a very simple,
not-yet-conformant way. While touching this code, the distinction between grid-auto-flow
none and row / column was better drawn (and enforced).
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveGridPositionFromStyle):
Made it illegal to call resolveGridPositionFromStyle if the grid track is auto and
grid-auto-flow is not none. This would catch bad use of the function.
(WebCore::RenderGrid::maximumIndexInDirection):
Updated to bail out if the grid track is auto. Also improved the comment.
(WebCore::RenderGrid::placeItemsOnGrid):
Updated the function to do several iterations. Also handled the grid-auto-flow: none
case differently as it shouldn't need the extra iteration(s).
LayoutTests:
- fast/css-grid-layout/grid-auto-flow-resolution-expected.txt: Added.
- fast/css-grid-layout/grid-auto-flow-resolution.html: Added.
- fast/css-grid-layout/implicit-position-dynamic-change.html:
- fast/css-grid-layout/resources/grid.css:
(.autoRowAutoColumn):
(.firstRowAutoColumn):
(.secondRowAutoColumn):
(.thirdRowAutoColumn):
(.autoRowFirstColumn):
(.autoRowSecondColumn):
(.autoRowThirdColumn):
Added these helper classes, some will be used in a follow-up patch.
(.sizedToGridArea):
Hoisted this class into the common style.
- 3:31 PM Changeset in webkit [143396] by
-
- 5 edits in trunk/Source/WebKit2
StorageAreaProxy should know its quota
https://bugs.webkit.org/show_bug.cgi?id=110268
Reviewed by Sam Weinig.
Begin stubbing out StorageAreaProxy::setItem and add some quota member variables.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::StorageAreaProxy):
(WebKit::StorageAreaProxy::setItem):
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- WebProcess/Storage/StorageNamespaceProxy.cpp:
(WebKit::StorageNamespaceProxy::createSessionStorageNamespace):
(WebKit::StorageNamespaceProxy::StorageNamespaceProxy):
- WebProcess/Storage/StorageNamespaceProxy.h:
(WebKit::StorageNamespaceProxy::quota):
(StorageNamespaceProxy):
- 3:23 PM Changeset in webkit [143395] by
-
- 6 edits3 adds in trunk
[New Multicolumn] REGRESSION: RenderMultiColumnSets broken by the RenderRegion -> RenderBlock subclassing.
https://bugs.webkit.org/show_bug.cgi?id=110239.
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/multicol/newmulticol/column-rules-fixed-height.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::columnRectAt):
Make sure the columnGap() in the old multicolumn code is always expressed as a LayoutUnit. This was the
one place where it was still an int.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
Rework the painting of flow thread portions to account for the fact that regions paint at an integral
translation. This means you have to construct clipping around that integral destination. Subpixel layout
regions did not clip correctly as a result of this issue.
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnRectAt):
Fix the same bug with columnGap() that the old column code has, i.e., one spot where it was an int.
(WebCore::RenderMultiColumnSet::paintObject):
RenderMultiColumnSet should be using paintObject and not paint and it needs to check for visibility
and phases now that it is a RenderBlock subclass.
(WebCore::RenderMultiColumnSet::paintColumnRules):
Fix the bug that Opera guys fixed in the old multi-column code. They didn't patch the new code, so this
takes care of that.
- rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
Change to use paintObject instead of paint.
LayoutTests:
- fast/multicol/newmulticol: Added.
- fast/multicol/newmulticol/column-rules-fixed-height-expected.html: Added.
- fast/multicol/newmulticol/column-rules-fixed-height.html: Added.
- 3:21 PM Changeset in webkit [143394] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indentation of Opcode.h
Rubber stamped by Mark Hahnenberg.
- bytecode/Opcode.h:
- 3:20 PM Changeset in webkit [143393] by
-
- 4 edits1 add16 deletes in trunk/LayoutTests
Convert residual-style.html test to a reftest (and fix typos)
https://bugs.webkit.org/show_bug.cgi?id=109981
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-19
Reviewed by Darin Adler.
- fast/flexbox/box-orient-button.html: clsas->class
- fast/flexbox/resources/box-orient-button.js: DTR->DRT
- fast/invalid/residual-style-expected.html: Added. New reftest
version. Note that some lines are red, which is
https://bugs.webkit.org/show_bug.cgi?id=109984
- fast/invalid/residual-style.html: Add missing semicolon in <style>.
Also close a few more <font> tags, so that the descriptive text is
in black as it should be.
- platform/chromium-android/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-android/fast/invalid/residual-style-expected.txt: Removed.
- platform/chromium-linux/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-linux/fast/invalid/residual-style-expected.txt: Removed.
- platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
- platform/chromium-win/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-win/fast/invalid/residual-style-expected.txt: Removed.
- platform/efl/fast/invalid/residual-style-expected.png: Removed.
- platform/efl/fast/invalid/residual-style-expected.txt: Removed.
- platform/gtk/fast/invalid/residual-style-expected.png: Removed.
- platform/gtk/fast/invalid/residual-style-expected.txt: Removed.
- platform/mac/fast/invalid/residual-style-expected.png: Removed.
- platform/mac/fast/invalid/residual-style-expected.txt: Removed.
Removed old expectation files.
- 3:19 PM Changeset in webkit [143392] by
-
- 6 edits1 add in trunk/Source/JavaScriptCore
Moved PolymorphicAccessStructureList into its own file.
Rubber stamped by Mark Hahnenberg.
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/Instruction.h:
(JSC):
- bytecode/PolymorphicAccessStructureList.h: Added.
(JSC):
(PolymorphicAccessStructureList):
(PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::visitWeak):
- bytecode/StructureStubInfo.h:
- 3:17 PM WebKit Team edited by
- (diff)
- 3:15 PM Changeset in webkit [143391] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Appropriately handle word wrapping in SpellingHandler
https://bugs.webkit.org/show_bug.cgi?id=110253
Reviewed by Rob Buis.
PR286001
Since we traverse through text by visual lines instead of blocks, word wrapping causes some
bad behavior. Changing the way we traverse text to jump by words instead of lines. This will
mean it takes longer to finish spellchecking, but the removal of any loops allows webkit
processing to continue. This gives priority to user actions while still completing a large
paragraph in a reasonable amount of time.
Internally reviewed by Mike Fenton
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- WebKitSupport/SpellingHandler.cpp:
(BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
(BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
(BlackBerry::WebKit::SpellingHandler::startOfNextWord):
(WebKit):
(BlackBerry::WebKit::SpellingHandler::incrementByWord):
(BlackBerry::WebKit::SpellingHandler::doesWordWrap):
- WebKitSupport/SpellingHandler.h:
(SpellingHandler):
- 3:10 PM Changeset in webkit [143390] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indentation of Instruction.h
Rubber stamped by Mark Hahnenberg.
- bytecode/Instruction.h:
- 3:04 PM Changeset in webkit [143389] by
-
- 8 edits6 adds in trunk
Fix 'slice' aspect ratio calculation
https://bugs.webkit.org/show_bug.cgi?id=99984
Patch by Branimir Lambov <blambov@google.com> on 2013-02-19
Reviewed by Dirk Schulze.
Source/WebCore:
Previously the calculation for the 'slice' aspect ratio would incorrectly calculate the
source rect location based on the destination rect offset. This caused our source rect to be
incorrect, and sometimes render outside the visible area completely. After this patch
our implementation matches the implementation of both Gecko and Presto.
The relevant spec section:
http://www.w3.org/TR/SVG/single-page.html#coords-PreserveAspectRatioAttribute
Tests: svg/as-image/image-preserveAspectRatio-all.svg
svg/filters/feImage-preserveAspectRatio-all.svg
- svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::transformRect):
LayoutTests:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
- svg/as-image/image-preserveAspectRatio-all-expected.txt: Added.
- svg/as-image/image-preserveAspectRatio-all.svg: Added.
- svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
- svg/filters/feImage-preserveAspectRatio-all-expected.txt: Added.
- svg/filters/feImage-preserveAspectRatio-all.svg: Added.
- 3:03 PM Changeset in webkit [143388] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test Expectations to reflect flakey calendar tests.
https://bugs.webkit.org/show_bug.cgi?id=107508
Unreviewed test expectations.
- platform/chromium/TestExpectations: Re-added all the flakey calendar tests.
- 3:01 PM Changeset in webkit [143387] by
-
- 2 edits in trunk/Source/WebCore
[V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
https://bugs.webkit.org/show_bug.cgi?id=110254
Patch by Kentaro Hara <haraken@google.com> on 2013-02-19
Reviewed by Adam Barth.
Chromium bug: https://code.google.com/p/chromium/issues/detail?id=176951
Currently ScriptRunner::runCompiledScript() calls
ASSERT(script.IsEmpty()) when OOM occurs. The Chromium bug is
hitting the ASSERT(). The ASSERT() does not make sense at all.
Instead, we should return an empty handle when OOM occurs.
No tests. The bug happens only when OOM occurs.
- bindings/v8/ScriptRunner.cpp:
(WebCore::ScriptRunner::runCompiledScript):
- 2:58 PM Changeset in webkit [143386] by
-
- 31 edits2 adds in trunk
Support both MutationObserver and WebKitMutationObserver
https://bugs.webkit.org/show_bug.cgi?id=109776
Reviewed by Ojan Vafai.
Source/WebCore:
We should allow new MutationObserver now that we support parser generated
mutations. This leaves the old prefixed constructor in until we decide
people don't depend on it.
Test: fast/dom/MutationObserver/mutation-observer-prefix.html
- page/DOMWindow.idl:
LayoutTests:
- fast/dom/MutationObserver/added-out-of-order.html:
- fast/dom/MutationObserver/callback-arguments.html:
- fast/dom/MutationObserver/clear-transient-without-delivery.html:
- fast/dom/MutationObserver/create-during-delivery.html:
- fast/dom/MutationObserver/cross-document.html:
- fast/dom/MutationObserver/database-callback-delivery.html:
- fast/dom/MutationObserver/delivery-order.html:
- fast/dom/MutationObserver/disconnect-cancel-pending.html:
- fast/dom/MutationObserver/document-fragment-insertion.html:
- fast/dom/MutationObserver/end-of-task-delivery.html:
- fast/dom/MutationObserver/filesystem-callback-delivery.html:
- fast/dom/MutationObserver/inline-event-listener.html:
- fast/dom/MutationObserver/mutate-during-delivery.html:
- fast/dom/MutationObserver/mutation-callback-non-element-crash.html:
- fast/dom/MutationObserver/mutation-observer-constructor.html:
- fast/dom/MutationObserver/mutation-observer-prefix-expected.txt: Added.
- fast/dom/MutationObserver/mutation-observer-prefix.html: Added.
- fast/dom/MutationObserver/mutation-record-nullity.html:
- fast/dom/MutationObserver/observe-attributes.html:
- fast/dom/MutationObserver/observe-characterdata.html:
- fast/dom/MutationObserver/observe-childList.html:
- fast/dom/MutationObserver/observe-exceptions.html:
- fast/dom/MutationObserver/observe-subtree.html:
- fast/dom/MutationObserver/observer-wrapper-dropoff-transient.html:
- fast/dom/MutationObserver/observer-wrapper-dropoff.html:
- fast/dom/MutationObserver/parser-mutations.html:
- fast/dom/MutationObserver/removed-out-of-order.html:
- fast/dom/MutationObserver/shadow-dom.html:
- fast/dom/MutationObserver/takeRecords.html:
- fast/dom/MutationObserver/transient-gc-crash.html:
- 2:38 PM Changeset in webkit [143385] by
-
- 6 edits in trunk/Source/WebKit2
<rdar://problem/13239119> NetworkProcess generates timeout spindump logs
Reviewed by Mark Rowe.
Don't keep a window server connection in processes that don't need it, and don't
run an NSApplication run loop.
- Shared/ChildProcess.h:
- Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::shutdownWindowServerConnection): Added a function to shut down connections, and to make sure we don't get one in the future.
- NetworkProcess/mac/NetworkProcessMac.mm: (WebKit::NetworkProcess::initializeProcessName):
- OfflineStorageProcess/mac/OfflineStorageProcessMac.mm: (WebKit::OfflineStorageProcess::initializeProcessName):
- SharedWorkerProcess/mac/SharedWorkerProcessMac.mm: (WebKit::SharedWorkerProcess::platformInitializeSharedWorkerProcess): Also removed some unused includes and forward declarations.
- 2:29 PM Changeset in webkit [143384] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling in r143348.
http://trac.webkit.org/changeset/143348
https://bugs.webkit.org/show_bug.cgi?id=110242
The bug was that isEmptyValue() was returning true for the deleted value.
Fixed this and simplified things further by delegating to m_sourceCode
for both isNull() and isHashTableDeletedValue(), so they can't be out of
sync.
- runtime/CodeCache.cpp:
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- runtime/CodeCache.h:
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(SourceCodeKey):
- 2:15 PM Changeset in webkit [143383] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 2:02 PM Changeset in webkit [143382] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457
Reviewed by Kentaro Hara.
Now that https://codereview.chromium.org/12230054 has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.
- public/platform/WebKitPlatformSupport.h:
(WebKit):
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
- 1:53 PM Changeset in webkit [143381] by
-
- 2 edits1 add1 delete in trunk/Source/JavaScriptCore
[GTK] Improve gyp build JavaScriptCore code generation
https://bugs.webkit.org/show_bug.cgi?id=109969
Reviewed by Dirk Pranke.
Switch away from using DerivedSources.make when building JavaScriptCore generated
sources. This bring a couple advantages, such as building the sources in parallel,
but requires us to list the generated sources more than once.
- JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Add rules for generating JavaScriptCore sources.
- JavaScriptCore.gyp/generate-derived-sources.sh: Added.
- JavaScriptCore.gyp/redirect-stdout.sh: Added.
- 1:51 PM Changeset in webkit [143380] by
-
- 7 edits in trunk/Source/WebCore
Remove RenderText::updateText
https://bugs.webkit.org/show_bug.cgi?id=109991
Reviewed by Eric Seidel.
There's no reason for the generic RenderText::updateText virtual hook
anymore now that r143060 made RenderQuote stop setting dirty bits during
layout since the hook is only used by RenderCounter.
Instead add updateCounterIfNeeded and make it clear this is a hack for
counters.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::updateCounterIfNeeded): Added, not handles the counter specific hack.
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
- rendering/RenderCounter.cpp:
(WebCore::RenderCounter::updateCounter):
- rendering/RenderCounter.h:
(RenderCounter):
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::updateDepth):
- rendering/RenderQuote.h:
(RenderQuote):
- rendering/RenderText.h:
(RenderText):
- 1:48 PM Changeset in webkit [143379] by
-
- 5 edits3 copies in branches/chromium/1364
Merge 141645
Prevent skipped repaints for children of inner SVG elements
https://bugs.webkit.org/show_bug.cgi?id=108429
Reviewed by Eric Seidel.
Source/WebCore:
This patch fixes a bug caused by r108699 and r133786 where we would not repaint children
of inner SVG elements because "m_didTransformToRootUpdate" was never reset on viewport
containers. The stale m_didTransformToRootUpdate variable caused us to skip child repaints.
I verified that the Robohornet SVG benchmark performance gains in r133786 are not regressed
with this patch.
Test: svg/repaint/svgsvgelement-repaint-children.html
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::calcViewport):
This can be removed because setNeedsTransformUpdate() will set m_needsTransformUpdate.
(WebCore::RenderSVGViewportContainer::calculateLocalTransform):
This change is straightforward and is similar to the equivalent assignment in
RenderSVGTransformableContainer::calculateLocalTransform().
LayoutTests:
Need to update expectations for a single file (just a 1px difference).
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
- svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
- svg/repaint/svgsvgelement-repaint-children.html: Added.
TBR=pdr@google.com
- 1:46 PM Changeset in webkit [143378] by
-
- 2 edits64 adds in trunk/LayoutTests
CSS3: add line-break tests, initially skipping on all platforms
https://bugs.webkit.org/show_bug.cgi?id=109954
Reviewed by Dirk Pranke.
See also wiki documentation at:
[1] http://trac.webkit.org/wiki/LineBreaking
[2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping
See also:
https://bugs.webkit.org/show_bug.cgi?id=89235
- TestExpectations:
- css3/line-break/line-break-auto-centered-expected.html: Added.
- css3/line-break/line-break-auto-centered.html: Added.
- css3/line-break/line-break-auto-half-kana-expected.html: Added.
- css3/line-break/line-break-auto-half-kana.html: Added.
- css3/line-break/line-break-auto-hyphens-expected.html: Added.
- css3/line-break/line-break-auto-hyphens.html: Added.
- css3/line-break/line-break-auto-inseparables-expected.html: Added.
- css3/line-break/line-break-auto-inseparables.html: Added.
- css3/line-break/line-break-auto-iteration-marks-expected.html: Added.
- css3/line-break/line-break-auto-iteration-marks.html: Added.
- css3/line-break/line-break-auto-postfixes-expected.html: Added.
- css3/line-break/line-break-auto-postfixes.html: Added.
- css3/line-break/line-break-auto-prefixes-expected.html: Added.
- css3/line-break/line-break-auto-prefixes.html: Added.
- css3/line-break/line-break-auto-sound-marks-expected.html: Added.
- css3/line-break/line-break-auto-sound-marks.html: Added.
- css3/line-break/line-break-loose-centered-expected.html: Added.
- css3/line-break/line-break-loose-centered.html: Added.
- css3/line-break/line-break-loose-half-kana-expected.html: Added.
- css3/line-break/line-break-loose-half-kana.html: Added.
- css3/line-break/line-break-loose-hyphens-expected.html: Added.
- css3/line-break/line-break-loose-hyphens.html: Added.
- css3/line-break/line-break-loose-inseparables-expected.html: Added.
- css3/line-break/line-break-loose-inseparables.html: Added.
- css3/line-break/line-break-loose-iteration-marks-expected.html: Added.
- css3/line-break/line-break-loose-iteration-marks.html: Added.
- css3/line-break/line-break-loose-postfixes-expected.html: Added.
- css3/line-break/line-break-loose-postfixes.html: Added.
- css3/line-break/line-break-loose-prefixes-expected.html: Added.
- css3/line-break/line-break-loose-prefixes.html: Added.
- css3/line-break/line-break-loose-sound-marks-expected.html: Added.
- css3/line-break/line-break-loose-sound-marks.html: Added.
- css3/line-break/line-break-normal-centered-expected.html: Added.
- css3/line-break/line-break-normal-centered.html: Added.
- css3/line-break/line-break-normal-half-kana-expected.html: Added.
- css3/line-break/line-break-normal-half-kana.html: Added.
- css3/line-break/line-break-normal-hyphens-expected.html: Added.
- css3/line-break/line-break-normal-hyphens.html: Added.
- css3/line-break/line-break-normal-inseparables-expected.html: Added.
- css3/line-break/line-break-normal-inseparables.html: Added.
- css3/line-break/line-break-normal-iteration-marks-expected.html: Added.
- css3/line-break/line-break-normal-iteration-marks.html: Added.
- css3/line-break/line-break-normal-postfixes-expected.html: Added.
- css3/line-break/line-break-normal-postfixes.html: Added.
- css3/line-break/line-break-normal-prefixes-expected.html: Added.
- css3/line-break/line-break-normal-prefixes.html: Added.
- css3/line-break/line-break-normal-sound-marks-expected.html: Added.
- css3/line-break/line-break-normal-sound-marks.html: Added.
- css3/line-break/line-break-strict-centered-expected.html: Added.
- css3/line-break/line-break-strict-centered.html: Added.
- css3/line-break/line-break-strict-half-kana-expected.html: Added.
- css3/line-break/line-break-strict-half-kana.html: Added.
- css3/line-break/line-break-strict-hyphens-expected.html: Added.
- css3/line-break/line-break-strict-hyphens.html: Added.
- css3/line-break/line-break-strict-inseparables-expected.html: Added.
- css3/line-break/line-break-strict-inseparables.html: Added.
- css3/line-break/line-break-strict-iteration-marks-expected.html: Added.
- css3/line-break/line-break-strict-iteration-marks.html: Added.
- css3/line-break/line-break-strict-postfixes-expected.html: Added.
- css3/line-break/line-break-strict-postfixes.html: Added.
- css3/line-break/line-break-strict-prefixes-expected.html: Added.
- css3/line-break/line-break-strict-prefixes.html: Added.
- css3/line-break/line-break-strict-sound-marks-expected.html: Added.
- css3/line-break/line-break-strict-sound-marks.html: Added.
- 1:18 PM Changeset in webkit [143377] by
-
- 3 edits2 adds in trunk
Border changes on tables with collapsed borders doesn't relayout table cells
https://bugs.webkit.org/show_bug.cgi?id=109774
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/table/border-collapsing/dynamic-border-width-change.html
Changes to border top and border bottom on table rows also changes the size
of the table cell causing a relayout to be needed.
- rendering/RenderTableRow.cpp:
(WebCore::borderWidthChanged): Also include border top and bottom.
(WebCore::RenderTableRow::styleDidChange): Remove logical from the helper function name.
LayoutTests:
- fast/table/border-collapsing/dynamic-border-width-change-expected.txt: Added.
- fast/table/border-collapsing/dynamic-border-width-change.html: Added.
- 12:56 PM Changeset in webkit [143376] by
-
- 1 edit1 add in trunk/LayoutTests
Add a test result missed in r143074.
- platform/mac-wk2/tiled-drawing/null-parent-back-crash-expected.txt: Added.
- 12:49 PM Changeset in webkit [143375] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Remove two now-passing tests.
- platform/chromium/TestExpectations:
- 12:47 PM Changeset in webkit [143374] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests.
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):
- 12:43 PM Changeset in webkit [143373] by
-
- 4 edits in trunk/LayoutTests
[WebGL] Fix oes-element-index-uint.html test.
https://bugs.webkit.org/show_bug.cgi?id=110045
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-19
Reviewed by Kenneth Russell.
This patch fixes the test case to use updated WebGLTestUtils functions
and adds shaders used during resized buffer tests. This patch
also enables the test for EFL port.
- fast/canvas/webgl/oes-element-index-uint-expected.txt:
- fast/canvas/webgl/oes-element-index-uint.html:
- platform/efl/TestExpectations:
- 12:36 PM Changeset in webkit [143372] by
-
- 2 edits in trunk/Source/Platform
WebAudio API: Change the Platform::createAudioDevice function to take a DeviceId parameter
https://bugs.webkit.org/show_bug.cgi?id=110192
Reviewed by Adam Barth.
- chromium/public/Platform.h:
(WebKit::Platform::createAudioDevice):
(Platform):
- 12:32 PM Changeset in webkit [143371] by
-
- 4 edits in tags/Safari-537.31.4/Source
Versioning.
- 12:29 PM Changeset in webkit [143370] by
-
- 1 copy in tags/Safari-537.31.4
New Tag.
- 12:10 PM Changeset in webkit [143369] by
-
- 6 edits in trunk/Source/WebCore
[GTK][AC] Implement matrix transform animation with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=109848
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-19
Reviewed by Gustavo Noronha Silva.
Clutter 1.12 doesn't support additive transform animations yet, so the combination
of two or more transformations(such as rotation after translation) runs unexpectedly.
So we use a matrix transformation instead for the case.
Covered by existing animation tests.
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
- platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::toClutterActorPropertyString): Add actor property "transform"
(WebCore::clutterMatrixProgress): Handle interpolation between two matrices instead of default clutter_matrix_progress.
(WebCore):
(WebCore::PlatformClutterAnimation::supportsAdditiveValueFunction):
(WebCore::PlatformClutterAnimation::setFromValue): for TransformationMatrix.
(WebCore::PlatformClutterAnimation::setToValue): ditto.
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addTransformTransition):
- platform/graphics/clutter/PlatformClutterAnimation.h:
(PlatformClutterAnimation):
- platform/graphics/clutter/TransformationMatrixClutter.cpp: Add copy constructor for CoglMatrix.
(WebCore::TransformationMatrix::TransformationMatrix):
(WebCore):
- platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix):
- 12:02 PM Changeset in webkit [143368] by
-
- 2 edits1 delete in branches/chromium/1410
Revert 129070
[Chromium] Disable resource load scheduling
https://bugs.webkit.org/show_bug.cgi?id=97131
Reviewed by Nate Chapin.
Source/WebCore:
We'll use Chrome's network stack for scheduling instead.
No new tests.
- loader/ResourceLoadScheduler.cpp:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload):
LayoutTests:
The preload scanner loads resources sooner and these tests are affected.
- platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
- platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Added.
TBR=simonjam@chromium.org
Review URL: https://codereview.chromium.org/12294041
- 12:01 PM Changeset in webkit [143367] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark fast/workers/storage/interrupt-database.html as flaky crasher
https://bugs.webkit.org/show_bug.cgi?id=110247
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 11:39 AM Changeset in webkit [143366] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r143348.
http://trac.webkit.org/changeset/143348
https://bugs.webkit.org/show_bug.cgi?id=110242
"Caused a deleted value sentinel crash on the layout tests"
(Requested by ggaren on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19
- runtime/CodeCache.cpp:
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- runtime/CodeCache.h:
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(SourceCodeKey):
- 11:34 AM Changeset in webkit [143365] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 142793
Bidi-Isolated inlines can cause subsequent content to not be rendered
https://bugs.webkit.org/show_bug.cgi?id=108137
Reviewed by Eric Seidel.
Source/WebCore:
First step in fixing how inline isolates behave with collapsed spaces.
webkit.org/b/109624 tracks the overarching issue.
Test: fast/text/content-following-inline-isolate-with-collapsed-whitespace.html
- rendering/InlineIterator.h:
(WebCore::IsolateTracker::addFakeRunIfNecessary): If we enter an isolate while
ignoring spaces, ensure we leave it considering them again. This can result in
including spaces that should be ignored following the isolate on the line, but
failing to do so results in those contents not being rendered at all.
LayoutTests:
- fast/text/content-following-inline-isolate-with-collapsed-whitespace.html: Added.
- fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt: Added.
TBR=leviw@chromium.org
Review URL: https://codereview.chromium.org/12308006
- 11:29 AM Changeset in webkit [143364] by
-
- 61 edits4 deletes in trunk/LayoutTests
Rebaselining, again, calendar tests
https://bugs.webkit.org/show_bug.cgi?id=110240
Unreviewed expectations update.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Removed.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- 11:19 AM Changeset in webkit [143363] by
-
- 4 edits in trunk/Source/WebCore
Update FeatureObserver on top level navigation in addition to page destruction.
https://bugs.webkit.org/show_bug.cgi?id=109874
Patch by Kassy Coan <kassycoan@chromium.org> on 2013-02-19
Reviewed by Adam Barth.
No new tests. Only effect is to histogram more frequently.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidCommitLoad):
- page/FeatureObserver.cpp:
(WebCore::FeatureObserver::~FeatureObserver):
(WebCore):
(WebCore::FeatureObserver::updateMeasurements):
(WebCore::FeatureObserver::didCommitLoad):
- page/FeatureObserver.h:
(FeatureObserver):
- 11:15 AM Changeset in webkit [143362] by
-
- 2 edits in trunk/Tools
Unreviewed, changing primary email.
- 11:10 AM Changeset in webkit [143361] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary (and problematic) copy-constructor from LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=110121
This copy constructor does what a default copy constructor would do, so
it's not necessary. Furthermore, this copy constructor is the only
reason why LayoutUnit becomes non-POD, and that triggers a gdb bug,
making it impossible to do things like "print location()" when inside
some RenderBlock, for instance.
Gdb bug http://sourceware.org/bugzilla/show_bug.cgi?id=15154 reported.
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-02-19
Reviewed by Benjamin Poulain.
No tests. Apart from dealing with buggy debuggers, this is just code cleanup.
- platform/LayoutUnit.h:
- 11:10 AM Changeset in webkit [143360] by
-
- 2 edits1 copy1 move in trunk/Tools
REGRESSION: Sheriffbot is failing to process rollout requests
https://bugs.webkit.org/show_bug.cgi?id=106945
Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-19
Reviewed by Adam Barth.
Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
This resolves problems when Sheriffbot attempts to perform a rollout request.
- EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
- EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
- EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
- 11:08 AM Changeset in webkit [143359] by
-
- 1 edit1 add in trunk/Source/WebKit/gtk/po
Romanian translation for WebKitGtk+ HEAD
https://bugs.webkit.org/show_bug.cgi?id=110009
Patch by Mișu Moldovan <dumol@gnome.org> on 2013-02-19
Reviewed by Gustavo Noronha.
- ro.po: Added.
- 11:06 AM Changeset in webkit [143358] by
-
- 1 edit4 adds in trunk/LayoutTests
[WK2] Cannot load documents with blob urls
https://bugs.webkit.org/show_bug.cgi?id=110160
Reviewed by Sam Weinig.
- http/tests/fileapi/blob-url-in-subframe-expected.txt: Added.
- http/tests/fileapi/blob-url-in-subframe.html: Added.
- http/tests/fileapi/resources: Added.
- http/tests/fileapi/resources/blob-url-in-subframe-frame.html: Added.
- 11:00 AM Changeset in webkit [143357] by
-
- 2 edits in trunk/Source/WebCore
LayoutUnit::epsilon shouldn't be necessary to place floats
https://bugs.webkit.org/show_bug.cgi?id=94000
Reviewed by Levi Weintraub.
Currently, to get float placement correct, we need to have an
epsilon tolerance in RenderBlock::computeLogicalLocationForFloat
for the width of the line to fit them on. This really shouldn't
be necessary, and probably indicates we're losing precision
elsewhere.
Remove epsilon as it no longer appears to be needed. All layout
tests pass without it.
No new tests, covered by existing tests.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat):
- 10:57 AM Changeset in webkit [143356] by
-
- 22 edits2 adds in trunk
Text Autosizing: prevent oscillation of font sizes during autosizing
https://bugs.webkit.org/show_bug.cgi?id=108205
Patch by Tim Volodine <timvolodine@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
On some websites autosized font-sizes oscillate due to layouts caused by
hovering or incremental page loading (and on other sites font sizes do
eventually stabilize, but it takes many layouts before they reach a steady
size). To prevent all these cases, we no longer allow the autosizing
multiplier to change after it has been set (to a value other than 1).
This won't always give exactly the same results, but testing on 2000 top
sites shows that this makes little difference in practice, and it prevents
these very jarring cases. As a happy side-effect, this speeds up layouts
as font sizes change less.
Test: fast/text-autosizing/oscillation-javascript-fontsize-change.html
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
- page/Settings.cpp:
(WebCore::Settings::setTextAutosizingFontScaleFactor):
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::recalculateMultipliers):
(WebCore):
(WebCore::TextAutosizer::processContainer):
- rendering/TextAutosizer.h:
(TextAutosizer):
LayoutTests:
Added overflow-y:hidden to some existing tests, since previously those tests
would start off with incorrect multipliers (because mainFrame->view()-layoutSize()
is initially 785 instead of 800 as ScrollView wrongly guesses a scrollbar will
be needed), and then the multipliers would get corrected on a subsequent layout.
Now that we don't allow the multiplier to change after being set, it needs to be
right first time.
Also added specific oscillation test triggered by javascript.
- fast/text-autosizing/constrained-height-body-expected.html:
- fast/text-autosizing/constrained-height-body.html:
- fast/text-autosizing/constrained-then-float-ancestors-expected.html:
- fast/text-autosizing/constrained-then-float-ancestors.html:
- fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html:
- fast/text-autosizing/constrained-then-position-fixed-ancestors.html:
- fast/text-autosizing/nested-em-line-height-expected.html:
- fast/text-autosizing/nested-em-line-height.html:
- fast/text-autosizing/oscillation-javascript-fontsize-change-expected.html: Added.
- fast/text-autosizing/oscillation-javascript-fontsize-change.html: Added.
- fast/text-autosizing/simple-paragraph-expected.html:
- fast/text-autosizing/simple-paragraph.html:
- fast/text-autosizing/span-child-expected.html:
- fast/text-autosizing/span-child.html:
- fast/text-autosizing/unwrappable-blocks-expected.html:
- fast/text-autosizing/unwrappable-blocks.html:
- fast/text-autosizing/unwrappable-inlines-expected.html:
- fast/text-autosizing/unwrappable-inlines.html:
- 10:42 AM Changeset in webkit [143355] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Fix races in double-tap zoom minimum scale policy
https://bugs.webkit.org/show_bug.cgi?id=110183
Reviewed by Adam Barth.
Double-tap zoom on Android is supposed to return to minimum scale
if no pinch zoom occurred since the last double-tap. Because both
pinch zoom and the result of double-tap zoom gets passed in from CC
via applyScrollAndScale, this logic was brittle and prone to races
depending on when the animation update was received. This patch
keeps track of what the target double-tap scale is to make it more
robust.
I also fixed double-tap zoom test mocking to exercise the entire
page scale animation flow (our previous way of testing was hiding the
raciness), and added a new test case in DivAutoZoomMultipleParamsTest.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::startPageScaleAnimation):
(WebKit):
(WebKit::WebViewImpl::enableFakeDoubleTapAnimationForTesting):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::animateZoomAroundPoint):
(WebKit::WebViewImpl::didCommitLoad):
(WebKit::WebViewImpl::applyScrollAndScale):
- src/WebViewImpl.h:
(WebViewImpl):
(WebKit::WebViewImpl::fakeDoubleTapAnimationPendingForTesting):
(WebKit::WebViewImpl::fakeDoubleTapTargetPositionForTesting):
(WebKit::WebViewImpl::fakeDoubleTapPageScaleFactorForTesting):
(WebKit::WebViewImpl::fakeDoubleTapUseAnchorForTesting):
- tests/WebFrameTest.cpp:
- 10:40 AM Changeset in webkit [143354] by
-
- 2 edits in trunk/Source/JavaScriptCore
HeapBlock::destroy should issue warning if result is unused
https://bugs.webkit.org/show_bug.cgi?id=110233
Reviewed by Oliver Hunt.
To enforce the fact that we need to return blocks to the BlockAllocator after calling destroy,
we should add WARN_UNUSED_RETURN to HeapBlock::destroy and any other destroy functions in its subclasses.
- heap/HeapBlock.h:
- 10:29 AM Changeset in webkit [143353] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Cannot load documents with blob urls
https://bugs.webkit.org/show_bug.cgi?id=110160
Reviewed by Sam Weinig.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::canHandleRequest): Added knowledge about blobs.
- 10:28 AM Changeset in webkit [143352] by
-
- 4 edits in trunk
[EFL][DRT] http/tests/loading/307-after-303-after-post.html times out
https://bugs.webkit.org/show_bug.cgi?id=93214
Source/WebCore:
Ensured that GET verb is consistently used for any request
coming after a redirection that triggers switching to GET.
Patch by Youenn Fablet <youennf@gmail.com> on 2013-02-19
Reviewed by Martin Robinson.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::doRedirect):
LayoutTests:
Removed Failure from potential outcome of
http/tests/loading/307-after-303-after-post.html test.
Patch by Youenn Fablet <youennf@gmail.com> on 2013-02-19
Reviewed by Martin Robinson.
- platform/efl/TestExpectations:
- 10:12 AM Changeset in webkit [143351] by
-
- 2 edits in trunk/Source/JavaScriptCore
WeakSet::removeAllocator leaks WeakBlocks
https://bugs.webkit.org/show_bug.cgi?id=110228
Reviewed by Geoffrey Garen.
We need to return the WeakBlock to the BlockAllocator after the call to WeakBlock::destroy.
- heap/WeakSet.cpp:
(JSC::WeakSet::removeAllocator):
- 10:07 AM Changeset in webkit [143350] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix compilation if Qt was configured with -no-rtti
https://bugs.webkit.org/show_bug.cgi?id=110234
Reviewed by Noam Rosenthal.
Availability of dynamic_cast should be checked.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):
- 10:05 AM Changeset in webkit [143349] by
-
- 3 edits in trunk/Source/WebCore
Unregistered blob URLs have incorrect MIME type
https://bugs.webkit.org/show_bug.cgi?id=110166
Reviewed by Sam Weinig.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::shouldUseInnerURL): Added a FIXME.
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyResponseOnError): Pass an accurate MIME type (for a delegate to see).
- 9:48 AM Changeset in webkit [143348] by
-
- 3 edits in trunk/Source/JavaScriptCore
Save space on keys in the CodeCache
https://bugs.webkit.org/show_bug.cgi?id=110179
Reviewed by Oliver Hunt.
Share the SourceProvider's string instead of making our own copy. This
chops off 16MB - 32MB from the CodeCache's memory footprint when full.
(It's 16MB when the strings are LChar, and 32MB when they're UChar.)
- runtime/CodeCache.cpp:
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- runtime/CodeCache.h: Removed a defunct enum value.
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(SourceCodeKey):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::string):
(JSC::SourceCodeKey::operator==): Store a SourceCode instead of a String
so we can share our string with our SourceProvider. Cache our hash so
we don't have to re-decode our string just to re-hash the table.
- 9:42 AM Changeset in webkit [143347] by
-
- 5 edits in trunk/Source
IndexedDB: additional checks on LevelDB decoding
https://bugs.webkit.org/show_bug.cgi?id=109711
Reviewed by Tony Chang.
Source/WebCore:
Watch out for decoding errors caused by corrupted data, and exit various
decode/compare operations earlier.
Covered by existing LayoutTests and Chromium's webkit_unit_tests
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::decodeStringWithLength): Bail if length is negative.
(WebCore::IDBLevelDBCoding::compareEncodedStringsWithLength): Distinguish error case.
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey): Bail if length is negative.
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys): Distinguish error case.
(WebCore::IDBLevelDBCoding::compare): Plumb through "ok".
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare): Ditto.
(WebCore::IDBLevelDBCoding::ExistsEntryKey::compare): Ditto.
(WebCore::IDBLevelDBCoding::IndexDataKey::compare): Ditto.
- Modules/indexeddb/IDBLevelDBCoding.h: Updated method signatures.
Source/WebKit/chromium:
- tests/IDBLevelDBCodingTest.cpp: Update test with new method signatures.
- 9:12 AM Changeset in webkit [143346] by
-
- 3 edits in trunk/Source/JavaScriptCore
revertBranchPtrWithPatch is incorrect on ARM traditional
https://bugs.webkit.org/show_bug.cgi?id=110201
Reviewed by Oliver Hunt.
Revert two instructions back to their original value.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::revertBranchPtrWithPatch):
(ARMAssembler):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::revertJumpReplacementToBranchPtrWithPatch):
- 9:09 AM Changeset in webkit [143345] by
-
- 7 edits in trunk
Unreviewed build fix.
.:
- Source/autotools/FindDependencies.m4:
- Source/autotools/Versions.m4:
- Source/cmake/FindHarfBuzz.cmake:
Bump gtk and efl dependencies on harfbuzz
to 0.9.7. See bug 110145.
Tools:
- efl/jhbuild.modules:
- gtk/jhbuild.modules:
Bump harfbuzz module to 0.9.7. See related bug 110145.
- 9:01 AM Changeset in webkit [143344] by
-
- 2 edits in trunk
Only depend on xrender if x11 is being used
https://bugs.webkit.org/show_bug.cgi?id=84095
Patch by Changhun Kang <temoochin@company100.net> on 2013-02-19
Reviewed by Martin Robinson.
- Source/autotools/FindDependencies.m4:
- 9:01 AM Changeset in webkit [143343] by
-
- 4 edits in trunk/Source/WebCore
[GTK][AC] Implement keyframe animations with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=110057
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-19
Reviewed by Gustavo Noronha Silva.
This patch brings accelerated keyframe animation with clutter to WebKitGtk+.
Changes of GraphicsLayerClutter are based on GraphicsLayerCA. But major changes
of PlatformClutterAnimation are implemented with clutter keyframe transition apis.
See http://developer.gnome.org/clutter/stable/ClutterKeyframeTransition.html
Covered by existing animation tests.
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::createKeyframeAnimation):
(WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerClutter::setAnimationKeyframes):
- platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::toClutterActorPropertyString):
(WebCore::PlatformClutterAnimation::PlatformClutterAnimation):
(WebCore::PlatformClutterAnimation::setTimingFunction):
(WebCore::PlatformClutterAnimation::setValues):
(WebCore::PlatformClutterAnimation::setKeyTimes):
(WebCore::PlatformClutterAnimation::setTimingFunctions):
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):
(WebCore::PlatformClutterAnimation::addOpacityTransition):
(WebCore::PlatformClutterAnimation::addTransformTransition):
(WebCore::PlatformClutterAnimation::addAnimationForKey):
(WebCore::PlatformClutterAnimation::removeAnimationForKey):
- platform/graphics/clutter/PlatformClutterAnimation.h:
(PlatformClutterAnimation):
- 8:55 AM Changeset in webkit [143342] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing test.
- platform/qt/TestExpectations:
- 8:50 AM Changeset in webkit [143341] by
-
- 8 edits in trunk/Source/WebKit2
[GTK] Move the API to get TLS certificate from WebKitURIResponse to WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=110190
Reviewed by Anders Carlsson.
Add webkit_web_view_get_tls_info() and remove
webkit_uri_response_get_https_status(). This way I can be sure
that when called after load has been committed the certificate
will be available. It also makes the API easier to use.
- UIProcess/API/gtk/WebKitURIResponse.cpp:
- UIProcess/API/gtk/WebKitURIResponse.h:
- UIProcess/API/gtk/WebKitURIResponsePrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewLoadChanged):
(mainResourceResponseChangedCallback):
(webkit_web_view_get_tls_info):
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestSSL.cpp:
- 8:50 AM Changeset in webkit [143340] by
-
- 1 edit in trunk/Source/WebKit/win/ChangeLog
Unreviewed, adding external symbol ?didBeginFrame@InspectorCanvasAgent@WebCore@@QAEXXZ.
- WebKit.vcproj/WebKitExports.def.in:
- 8:48 AM Changeset in webkit [143339] by
-
- 8 edits in trunk/Source/WebKit2
[WK2][EFL] Eliminate access to WK2 C++ internals from ewk_view functions
https://bugs.webkit.org/show_bug.cgi?id=109794
Reviewed by Anders Carlsson.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewSetShowsAsSource):
(WKViewGetShowsAsSource):
Added new WKView API to wrap WebPageProxy::setMainFrameInViewSourceMode()
and WebPageProxy::mainFrameInViewSourceMode() calls.
(WKViewExitFullScreen):
Added new WKView API to wrap WebFullScreenManagerProxy::exitFullScreen()
calls.
- UIProcess/API/C/efl/WKView.h:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::feedTouchEvent):
Added feedTouchEvent() method so that: at first ewk_view_feed_touch_event()
is not invoked from EwkView class, secondly ewk_view_feed_touch_event() does
not access WebPage instance directly.
(EwkView::feedTouchEvents):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_feed_touch_event):
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):
(ewk_view_fullscreen_exit):
(ewkViewPageContentsCallback):
(ewk_view_page_contents_get):
(ewk_view_source_mode_set):
(ewk_view_source_mode_get):
Those are now using exported C API.
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::setShowsAsSource):
(WebKit):
(WebKit::WebView::showsAsSource):
(WebKit::WebView::exitFullScreen):
- UIProcess/efl/WebView.h:
(WebView):
Added WebView methods to support added WKView API.
- 8:47 AM Changeset in webkit [143338] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed, Web Inspector: follow up to r143328 fixing Win Debug Build
https://bugs.webkit.org/show_bug.cgi?id=110227
Adding external symbol ?didBeginFrame@InspectorCanvasAgent@WebCore@@QAEXXZ.
- WebKit.vcproj/WebKitExports.def.in:
- 8:27 AM Changeset in webkit [143337] by
-
- 2 edits in trunk/Source/WebCore
[harfbuzz] Crash in harfbuzz related code
https://bugs.webkit.org/show_bug.cgi?id=110145
Reviewed by Martin Robinson.
Patch by Behdad Esfahbod <behdad@google.com>
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Ask harfbuzz
to guess the segment properties.
- 8:27 AM Changeset in webkit [143336] by
-
- 188 edits47 adds23 deletes in trunk/LayoutTests
Test Expectations update after r143267 and others
Unreviewed expectations update.
Updated many Chromium expectations, and removed superfluous
expectations from mac and win.
- editing/selection/extend-by-sentence-001-expected.txt: Added.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-linux-x86/svg/filters/big-sized-filter-2-expected.png: Removed.
- platform/chromium-linux-x86/svg/filters/shadow-on-filter-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug1188-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug1318-expected.png: Removed.
- platform/chromium-linux/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-linux/svg/batik/text/xmlSpace-expected.txt:
- platform/chromium-linux/svg/filters/big-sized-filter-2-expected.png: Removed.
- platform/chromium-linux/svg/filters/shadow-on-filter-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
- platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.txt:
- platform/chromium-mac-lion/editing/selection/extend-by-sentence-001-expected.png:
- platform/chromium-mac-lion/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/chromium-mac-lion/svg/filters/filter-on-tspan-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/extend-by-sentence-001-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/filters/big-sized-filter-2-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/filters/filter-on-tspan-expected.png:
- platform/chromium-mac-snowleopard/svg/filters/shadow-on-filter-expected.png: Removed.
- platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.png:
- platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.txt: Added.
- platform/chromium-mac/fast/inline/drawStyledEmptyInlines-expected.txt: Added.
- platform/chromium-mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/chromium-mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Added.
- platform/chromium-mac/fast/text/capitalize-empty-generated-string-expected.txt: Added.
- platform/chromium-mac/fast/text/whitespace/006-expected.txt: Added.
- platform/chromium-mac/fast/text/whitespace/007-expected.txt: Added.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added property svn:mime-type.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
- platform/chromium-mac/svg/batik/text/xmlSpace-expected.txt: Added.
- platform/chromium-mac/svg/custom/visibility-override-filter-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/chromium-mac/svg/filters/big-sized-filter-2-expected.png:
- platform/chromium-mac/svg/filters/feImage-reference-svg-primitive-expected.png:
- platform/chromium-mac/svg/filters/filter-on-tspan-expected.png:
- platform/chromium-mac/svg/filters/filterRes1-expected.png:
- platform/chromium-mac/svg/filters/filterRes3-expected.png:
- platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png:
- platform/chromium-mac/svg/filters/shadow-on-filter-expected.png:
- platform/chromium-mac/svg/filters/shadow-on-rect-with-filter-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug113235-3-expected.txt: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.
- platform/chromium-win-xp/svg/filters/big-sized-filter-2-expected.png: Removed.
- platform/chromium-win-xp/svg/filters/shadow-on-filter-expected.png: Removed.
- platform/chromium-win/editing/selection/extend-by-sentence-001-expected.txt:
- platform/chromium-win/fast/inline/drawStyledEmptyInlines-expected.txt:
- platform/chromium-win/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/chromium-win/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
- platform/chromium-win/fast/text/capitalize-empty-generated-string-expected.txt:
- platform/chromium-win/fast/text/whitespace/006-expected.txt:
- platform/chromium-win/fast/text/whitespace/007-expected.txt:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
- platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
- platform/chromium-win/svg/filters/big-sized-filter-2-expected.png:
- platform/chromium-win/svg/filters/feImage-reference-svg-primitive-expected.png:
- platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
- platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug113235-3-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug1318-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/editing/selection/extend-by-sentence-001-expected.txt: Removed.
- platform/chromium/fast/inline/drawStyledEmptyInlines-expected.txt: Removed.
- platform/chromium/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Removed.
- platform/chromium/fast/text/capitalize-empty-generated-string-expected.txt: Removed.
- platform/chromium/fast/text/whitespace/006-expected.txt: Removed.
- platform/chromium/fast/text/whitespace/007-expected.txt: Removed.
- platform/chromium/svg/batik/text/xmlSpace-expected.txt: Removed.
- platform/chromium/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Removed.
- platform/chromium/tables/mozilla/bugs/bug113235-3-expected.txt: Removed.
- platform/efl-wk2/svg/filters: Added.
- platform/efl-wk2/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/efl/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
- platform/gtk/editing/selection/extend-by-sentence-001-expected.txt: Removed.
- platform/mac/TestExpectations:
- platform/mac/editing/selection/extend-by-sentence-001-expected.txt: Removed.
- platform/win/TestExpectations:
- 8:26 AM Changeset in webkit [143335] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] ASSERT(node) hit in WebPage::findZoomableAreaForPoint if no zoomable area found
https://bugs.webkit.org/show_bug.cgi?id=110220
Reviewed by Allan Sandfeld Jensen.
If EventHandler::bestZoomableAreaForTouchPoint was unsuccessfull, eg.
no node was found for a given point, we hit ASSERT(node).
We should only assert for a valid node if a zoomable area was found.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findZoomableAreaForPoint):
- 8:12 AM Changeset in webkit [143334] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: release backtrace object group on each step.
https://bugs.webkit.org/show_bug.cgi?id=110223
Reviewed by Pavel Feldman.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
- 8:01 AM Changeset in webkit [143333] by
-
- 12 edits3 deletes in trunk
Unreviewed, rolling out r142975.
http://trac.webkit.org/changeset/142975
https://bugs.webkit.org/show_bug.cgi?id=110225
Introduces hard-to-reproduce crashes upon inspected page
navigation on Mac (Requested by apavlov on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19
Source/WebCore:
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::enable):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::collectStyleSheets):
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):
(WebCore::InspectorCSSAgent::buildObjectForRule):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
- inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getViaInspectorResourceForRule):
(WebInspector.CSSStyleModelResourceBinding.prototype.):
(WebInspector.CSSStyleModelResourceBinding.prototype.requestStyleSheetIdForResource):
(WebInspector.CSSStyleModelResourceBinding.prototype.requestResourceURLForStyleSheetId):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetIdForResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._loadStyleSheetHeaders):
(WebInspector.CSSStyleModelResourceBinding.prototype.headersLoaded):
(WebInspector.CSSStyleModelResourceBinding.prototype._requestViaInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._getOrCreateInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._reset):
- inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged.callback):
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode.callback):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):
- inspector/front-end/StylesSourceMapping.js:
(WebInspector.StyleContentBinding.prototype.callback):
(WebInspector.StyleContentBinding.prototype.setStyleContent):
(WebInspector.StyleContentBinding.prototype.):
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):
LayoutTests:
- inspector/styles/resources/stylesheet-tracking.css: Removed.
- inspector/styles/stylesheet-tracking-expected.txt: Removed.
- inspector/styles/stylesheet-tracking.html: Removed.
- 7:53 AM Changeset in webkit [143332] by
-
- 2 edits in trunk/Source/WebKit2
Regression(r143273): Caused a lot of tests to time out
https://bugs.webkit.org/show_bug.cgi?id=110212
Reviewed by Anders Carlsson.
StorageManager::destroySessionStorageNamespace() and StorageManager::cloneSessionStorageNamespace()
should call their respective "*Internal" equivalent instead of calling themselves. This lead to
a lot of time outs on our build bots.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::destroySessionStorageNamespace):
(WebKit::StorageManager::cloneSessionStorageNamespace):
- 7:41 AM QtWebKitBuildBots edited by
- (diff)
- 7:36 AM Changeset in webkit [143331] by
-
- 4 edits2 adds in trunk
RenderGrid::computedUsedBreadthOfGridTracks can read past m_grid's size
https://bugs.webkit.org/show_bug.cgi?id=110126
Reviewed by Ojan Vafai.
Source/WebCore:
The issue comes from how we store the column information inside m_grid.
Because m_grid is a Vector of rows, we could lose the column information
if we had no row, no grid item but some columns defined in CSS. As the
logic would assume that our row / column size would be greater than what
the style defines explicitely, we would access past our Vector's boundary.
The fix is to ensure that we have at least a row so that we can store the
column information in every case. This fix is overly broad as it also forces
the grid to have one column, which shouldn't be an issue.
Test: fast/css-grid-layout/grid-element-empty-row-column.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
Forced this function to return at least one as the maximum index so that
m_grid has at least one row / column.
(WebCore::RenderGrid::placeItemsOnGrid):
Added a ASSERT that m_grid is bigger than the explicit grid-rows / grid-columns.
Also changed an existing ASSERT to use gridWasPopulated for consistency and changed
the code not to call gridRowCount as it would ASSERT (we are in the middle of populating
the grid).
- rendering/RenderGrid.h:
(WebCore::RenderGrid::gridWasPopulated):
Added this helper function.
(WebCore::RenderGrid::gridColumnCount):
Replaced a now unneeded branch with an ASSERT. As placeItemsOnGrid should be called
prior to read m_grid, this change should be fine.
(WebCore::RenderGrid::gridRowCount):
Added an ASSERT.
LayoutTests:
- fast/css-grid-layout/grid-element-empty-row-column-expected.txt: Added.
- fast/css-grid-layout/grid-element-empty-row-column.html: Added.
- 7:19 AM Changeset in webkit [143330] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding a crash expectation for the layout test
added in r143303. The test is crashing due to missing bits of EventSender implementation.
- 7:16 AM Changeset in webkit [143329] by
-
- 2 edits in trunk/Source/WebCore
[Soup] Use synchronous calls to close completely processed streams
https://bugs.webkit.org/show_bug.cgi?id=107432
Reviewed by Martin Robinson.
There is no need to close already processed streams in asynchronous
calls since they won't block. Using the synchronous call will save
us some code and unnecessary asynchronous burden. This is kind of
a code refactor so no new tests needed.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore):
(WebCore::redirectSkipCallback):
(WebCore::readCallback):
- 7:13 AM Changeset in webkit [143328] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: [Canvas] use timeline's didBeginFrame for marking frame end calls
https://bugs.webkit.org/show_bug.cgi?id=110130
Reviewed by Pavel Feldman.
In Web Inspector canvas profiler use timeline's didBeginFrame for marking frame end calls instead of an ad-hoc timeout-based solution.
- inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::markFrameEnd):
(WebCore):
- inspector/InjectedScriptCanvasModule.h:
(InjectedScriptCanvasModule):
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::hasUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped):
(WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::frameNavigated):
(WebCore::InspectorCanvasAgent::didBeginFrame):
(WebCore):
- inspector/InspectorCanvasAgent.h:
(InspectorCanvasAgent):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::didBeginFrame):
- 6:59 AM Changeset in webkit [143327] by
-
- 12 edits2 adds in trunk
Web Inspector: Decouple various file system project implementation parts for better testability and cover with tests.
https://bugs.webkit.org/show_bug.cgi?id=110204
Reviewed by Pavel Feldman.
Source/WebCore:
Extracted FileSystemWorkspaceProvider from IsolatedFileSystemManager to take care of managing workspace projects and projectDelegates.
Replaced FileMapping.urlForURI with urlForPath method that does not need any information about workspace structure anymore.
Test: inspector/file-system-project.html
- inspector/front-end/FileMapping.js:
(WebInspector.FileMapping.prototype.urlForPath):
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemRemoved):
- inspector/front-end/IsolatedFileSystem.js:
(WebInspector.IsolatedFileSystem):
(WebInspector.IsolatedFileSystem.prototype.name):
(WebInspector.IsolatedFileSystem.prototype.rootURL):
- inspector/front-end/IsolatedFileSystemManager.js:
(WebInspector.IsolatedFileSystemManager):
(WebInspector.IsolatedFileSystemManager.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemRemoved):
(WebInspector.IsolatedFileSystemManager.prototype._isolatedFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype.requestDOMFileSystem):
- inspector/front-end/inspector.js:
LayoutTests:
- http/tests/inspector/inspector-test.js:
(initialize_InspectorTest):
(initialize_InspectorTest.):
- http/tests/inspector/workspace-test.js:
(initialize_WorkspaceTest.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
- inspector/file-mapping-expected.txt:
- inspector/file-mapping.html:
- inspector/file-system-project-expected.txt: Added.
- inspector/file-system-project.html: Added.
- inspector/version-controller.html:
- 6:43 AM Changeset in webkit [143326] by
-
- 3 edits in trunk/Tools
[Qt] Skip the build with a warning if certain tools cannot be found in the PATH
https://bugs.webkit.org/show_bug.cgi?id=110215
Reviewed by Tor Arne Vestbø.
Check that gperf, python, ruby, perl, bison and flex are in the PATH before
continuing the build. Otherwise skip with an error message explaining which
programs are missing from the build.
- qmake/mkspecs/features/configure.prf:
- qmake/mkspecs/features/functions.prf:
- 6:31 AM Changeset in webkit [143325] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Canvas] do not replace replay image with spinner icon
https://bugs.webkit.org/show_bug.cgi?id=110213
Reviewed by Pavel Feldman.
Otherwise it's visually hard to see changes in the replay image. Instead show a small spinner icon in the bottom right corner.
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._enableWaitIcon):
- inspector/front-end/canvasProfiler.css:
(#canvas-replay-image-container):
(.canvas-debug-info):
(.canvas-spinner-icon):
- 6:29 AM Changeset in webkit [143324] by
-
- 5 edits in trunk
Web Inspector: [Canvas] UI: tweak replay control buttons behavior
https://bugs.webkit.org/show_bug.cgi?id=110207
Reviewed by Pavel Feldman.
Source/WebCore:
New behavior for control buttons in the Canvas profiler.
- The NextCall button (~StepInto) on a node group should expand it and move into its first child (instead of expanding and moving into the next node group)
- The NextDrawCall button (~StepOver) should move to a next node that has children (instead of just iterating call group nodes, ignoring frame nodes).
- The ReplayLast button should select the last expanded node (instead of always selecting last frame group node).
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype._onReplayStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayDrawingCallClick):
(WebInspector.CanvasProfileView.prototype._onReplayLastStepClick):
LayoutTests:
Testing control buttons behavior.
- inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt:
- inspector/profiler/canvas2d/canvas-replay-log-grid.html:
- 5:54 AM Changeset in webkit [143323] by
-
- 3 edits42 deletes in trunk
Unreviewed, rolling out r143319.
http://trac.webkit.org/changeset/143319
https://bugs.webkit.org/show_bug.cgi?id=110214
Causes build issues on win32 (Requested by carewolf on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19
Tools:
- qmake/mkspecs/features/features.pri:
LayoutTests:
- platform/qt/mathml/presentation/attributes-expected.png: Removed.
- platform/qt/mathml/presentation/attributes-expected.txt: Removed.
- platform/qt/mathml/presentation/fenced-expected.png: Removed.
- platform/qt/mathml/presentation/fenced-expected.txt: Removed.
- platform/qt/mathml/presentation/fenced-mi-expected.png: Removed.
- platform/qt/mathml/presentation/fenced-mi-expected.txt: Removed.
- platform/qt/mathml/presentation/fractions-expected.png: Removed.
- platform/qt/mathml/presentation/fractions-expected.txt: Removed.
- platform/qt/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
- platform/qt/mathml/presentation/fractions-vertical-alignment-expected.txt: Removed.
- platform/qt/mathml/presentation/mo-expected.png: Removed.
- platform/qt/mathml/presentation/mo-expected.txt: Removed.
- platform/qt/mathml/presentation/mo-stretch-expected.png: Removed.
- platform/qt/mathml/presentation/mo-stretch-expected.txt: Removed.
- platform/qt/mathml/presentation/mroot-pref-width-expected.png: Removed.
- platform/qt/mathml/presentation/mroot-pref-width-expected.txt: Removed.
- platform/qt/mathml/presentation/over-expected.png: Removed.
- platform/qt/mathml/presentation/over-expected.txt: Removed.
- platform/qt/mathml/presentation/roots-expected.png: Removed.
- platform/qt/mathml/presentation/roots-expected.txt: Removed.
- platform/qt/mathml/presentation/row-alignment-expected.png: Removed.
- platform/qt/mathml/presentation/row-alignment-expected.txt: Removed.
- platform/qt/mathml/presentation/row-expected.png: Removed.
- platform/qt/mathml/presentation/row-expected.txt: Removed.
- platform/qt/mathml/presentation/style-expected.png: Removed.
- platform/qt/mathml/presentation/style-expected.txt: Removed.
- platform/qt/mathml/presentation/sub-expected.png: Removed.
- platform/qt/mathml/presentation/sub-expected.txt: Removed.
- platform/qt/mathml/presentation/subsup-expected.png: Removed.
- platform/qt/mathml/presentation/subsup-expected.txt: Removed.
- platform/qt/mathml/presentation/sup-expected.png: Removed.
- platform/qt/mathml/presentation/sup-expected.txt: Removed.
- platform/qt/mathml/presentation/tables-expected.png: Removed.
- platform/qt/mathml/presentation/tables-expected.txt: Removed.
- platform/qt/mathml/presentation/tokenElements-expected.png: Removed.
- platform/qt/mathml/presentation/tokenElements-expected.txt: Removed.
- platform/qt/mathml/presentation/under-expected.png: Removed.
- platform/qt/mathml/presentation/under-expected.txt: Removed.
- platform/qt/mathml/presentation/underover-expected.png: Removed.
- platform/qt/mathml/presentation/underover-expected.txt: Removed.
- platform/qt/mathml/xHeight-expected.png: Removed.
- platform/qt/mathml/xHeight-expected.txt: Removed.
- 5:49 AM AddingFeatures edited by
- wtf/FeatureDefines.h has the defaults for all the feature flags (diff)
- 5:44 AM Changeset in webkit [143322] by
-
- 5 edits2 adds in trunk
[CSS Regions] Assertion in RenderFlowThread::removeRenderBoxRegionInfo
https://bugs.webkit.org/show_bug.cgi?id=109914
Reviewed by David Hyatt.
Source/WebCore:
This patch moves a part of the invalidation operations inside the RenderFlowThread::invalidateRegions call. The maps
are cleared anyway at layout time but doing this earlier makes sure the flow thread is in a more consistent state
(the RenderFlowThread object has both the region chain invalidated and the regions information cleared).
RenderFlowThread::removeRenderBoxRegionInfo will check if the region chain is invalidated. If true, it means the
flow thread has a layout scheduled and the regions information is not yet reliable. In this case we just return from the
function and wait for the layout to cleanup the box information.
Test: fast/regions/remove-box-info-assert.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
- rendering/RenderFlowThread.h:
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
LayoutTests:
The test creates a flow thread with two regions and a content node. We remove the region and the node from the flow thread
at the same time. When the style is updated, the region is first removed from the chain and range information for boxes
is cleared from the flow thread. When the node is removed from the flow thread it tries to delete its region box information.
The range information on the flow thread is gone so the range for the node's box is zero - nothing gets deleted. Afterwards,
an ASSERT is triggered because there's leftover box information inside the region chain.
- fast/regions/remove-box-info-assert-expected.txt: Added.
- fast/regions/remove-box-info-assert.html: Added.
- 5:30 AM Changeset in webkit [143321] by
-
- 10 edits3 copies2 moves5 adds in trunk/LayoutTests
[chromium] Unreviewed gardening.
New baselines for effect-reference.html and effect-reference-hw.html
- platform/chromium-linux-x86/css3/filters/effect-reference-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
- platform/chromium-linux/css3/filters/effect-reference-expected.png: Added.
- platform/chromium-linux/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
- platform/chromium-linux/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-mac-lion/css3/filters/effect-reference-expected.png: Added.
- platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/css3/filters/effect-reference-hw-expected.txt.
- platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/css3/filters/effect-reference-hw-expected.txt.
- platform/chromium-mac/css3/filters/effect-reference-expected.png:
- platform/chromium-mac/css3/filters/effect-reference-expected.txt:
- platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
- platform/chromium-win-xp/css3/filters/effect-reference-expected.png: Added.
- platform/chromium-win-xp/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
- platform/chromium-win/css3/filters/effect-reference-expected.png:
- platform/chromium-win/css3/filters/effect-reference-expected.txt:
- platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-win/css3/filters/effect-reference-hw-expected.txt:
- 5:15 AM Changeset in webkit [143320] by
-
- 2 edits in trunk/Source/WebCore
Fix build broekn by r142988.
https://bugs.webkit.org/show_bug.cgi?id=109530
Unreviewed. Build fix.
Properly add shortMonthFormat() to the LocaleNone class.
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-02-19
- platform/text/LocaleNone.cpp:
(LocaleNone):
(WebCore::LocaleNone::shortMonthFormat):
- 5:02 AM Changeset in webkit [143319] by
-
- 3 edits44 adds in trunk
[Qt] Enable MathML
https://bugs.webkit.org/show_bug.cgi?id=110205
Reviewed by Simon Hausmann.
Tools:
- qmake/mkspecs/features/features.pri:
LayoutTests:
Baselines for the MathML tests.
- platform/qt/mathml/presentation/attributes-expected.png: Added.
- platform/qt/mathml/presentation/attributes-expected.txt: Added.
- platform/qt/mathml/presentation/fenced-expected.png: Added.
- platform/qt/mathml/presentation/fenced-expected.txt: Added.
- platform/qt/mathml/presentation/fenced-mi-expected.png: Added.
- platform/qt/mathml/presentation/fenced-mi-expected.txt: Added.
- platform/qt/mathml/presentation/fractions-expected.png: Added.
- platform/qt/mathml/presentation/fractions-expected.txt: Added.
- platform/qt/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
- platform/qt/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
- platform/qt/mathml/presentation/mo-expected.png: Added.
- platform/qt/mathml/presentation/mo-expected.txt: Added.
- platform/qt/mathml/presentation/mo-stretch-expected.png: Added.
- platform/qt/mathml/presentation/mo-stretch-expected.txt: Added.
- platform/qt/mathml/presentation/mroot-pref-width-expected.png: Added.
- platform/qt/mathml/presentation/mroot-pref-width-expected.txt: Added.
- platform/qt/mathml/presentation/over-expected.png: Added.
- platform/qt/mathml/presentation/over-expected.txt: Added.
- platform/qt/mathml/presentation/roots-expected.png: Added.
- platform/qt/mathml/presentation/roots-expected.txt: Added.
- platform/qt/mathml/presentation/row-alignment-expected.png: Added.
- platform/qt/mathml/presentation/row-alignment-expected.txt: Added.
- platform/qt/mathml/presentation/row-expected.png: Added.
- platform/qt/mathml/presentation/row-expected.txt: Added.
- platform/qt/mathml/presentation/style-expected.png: Added.
- platform/qt/mathml/presentation/style-expected.txt: Added.
- platform/qt/mathml/presentation/sub-expected.png: Added.
- platform/qt/mathml/presentation/sub-expected.txt: Added.
- platform/qt/mathml/presentation/subsup-expected.png: Added.
- platform/qt/mathml/presentation/subsup-expected.txt: Added.
- platform/qt/mathml/presentation/sup-expected.png: Added.
- platform/qt/mathml/presentation/sup-expected.txt: Added.
- platform/qt/mathml/presentation/tables-expected.png: Added.
- platform/qt/mathml/presentation/tables-expected.txt: Added.
- platform/qt/mathml/presentation/tokenElements-expected.png: Added.
- platform/qt/mathml/presentation/tokenElements-expected.txt: Added.
- platform/qt/mathml/presentation/under-expected.png: Added.
- platform/qt/mathml/presentation/under-expected.txt: Added.
- platform/qt/mathml/presentation/underover-expected.png: Added.
- platform/qt/mathml/presentation/underover-expected.txt: Added.
- platform/qt/mathml/xHeight-expected.png: Added.
- platform/qt/mathml/xHeight-expected.txt: Added.
- 4:45 AM Changeset in webkit [143318] by
-
- 6 edits in trunk
[Text Autosizing] Combine narrow descendants of a cluster into groups that should be autosized with the same multiplier.
https://bugs.webkit.org/show_bug.cgi?id=109825
Source/WebCore:
Enhancement of the approach introduced in https://bugs.webkit.org/show_bug.cgi?id=109573.
Instead of using the same text size multiplier for all narrow descendants of any autosizing
cluster, group the descendants by how much narrower they are than the cluster's
|blockContainingAllText| and process each group separately with a different multiplier for
each one.
For example, we want nested comments on the page to be autosized as a group but separately
from a sidebar on the same page.
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.
Updated the existing test to verify the patch.
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processClusterInternal):
Splits the narrow descendants of the autosizing cluster into groups before processing
each group individually.
(WebCore::TextAutosizer::getNarrowDescendantsGroupedByWidth):
Sorts the narrow descendants of the given cluster into groups, combining them by the
difference between their content widths. If sorted by width, two consecutive nodes
belong to the same group if their width difference is no greater than 100 CSS units.
- rendering/TextAutosizer.h:
New method definitions.
LayoutTests:
Verify that narrow descendants are grouped and autosized separately according to the
difference between the descendant's width and the width of its enclosing cluster's
|blockContainingAllText|.
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.
- fast/text-autosizing/narrow-descendants-combined-expected.html:
- fast/text-autosizing/narrow-descendants-combined.html:
- 4:21 AM Changeset in webkit [143317] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Native Memory Instrumentation: show user provided name property of the heap snapshot node.
https://bugs.webkit.org/show_bug.cgi?id=110124
Reviewed by Yury Semikhatsky.
Publish userProvidedName into grid node.
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker):
- inspector/front-end/NativeHeapSnapshot.js:
(WebInspector.NativeHeapSnapshotNode.prototype.serialize):
- 4:15 AM Changeset in webkit [143316] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 3:46 AM Changeset in webkit [143315] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening for chromium.
https://bugs.webkit.org/show_bug.cgi?id=110203
- platform/chromium/TestExpectations:
- 2:41 AM Changeset in webkit [143314] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION(r143241): It made 27 layout tests crash on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=110184
Reviewed by Zoltan Herczeg.
32-bit backend was making all sorts of crazy assumptions, which happened to mostly
not break things prior to http://trac.webkit.org/changeset/143241. This brings the
32-bit backend's type speculation fully into compliance with what the 64-bit
backend does.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
- 2:14 AM Changeset in webkit [143313] by
-
- 3 edits2 adds in trunk
Caret is not displayed when trying to focus inside a contenteditable element containing an empty block.
https://bugs.webkit.org/show_bug.cgi?id=108053
Source/WebCore:
Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-02-19
Reviewed by Ryosuke Niwa.
Test: editing/selection/caret-in-div-containing-empty-block.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):
When trying to compute the caret rect for the contenteditable div, the
border and the padding were not considered. Because of this, for the
given test case, which had a border defined on the containing div, the
caret was being painted just atop the border, thereby masking it.
Have modified the code to ensure that the computed caret rect takes
into account the border and padding (if any) specified on the box, but only
if the node doesn't have content that shall be skipped for editing.
We do not add border and padding while computing the caret rect for any
element that either has no content or has content that shall be skipped
for editing purposes. This holds true for table elements as well.
This helps avoid the caret displacement previsouly observed before/after
any controls placed within the contenteditable box, when considering
border and padding in computation of the caret rect.
LayoutTests:
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2013-02-19
Reviewed by Ryosuke Niwa.
- editing/selection/caret-in-div-containing-empty-block-expected.txt: Added.
- editing/selection/caret-in-div-containing-empty-block.html: Added.
Layout test added for verifying that a caret is displayed within a
contenteditable div having a border, both for the horizontal
as well as the vertical writing modes.
- 1:56 AM Changeset in webkit [143312] by
-
- 4 edits2 adds in trunk
CSSRegions: crash positioned object with inline containing block in flow thread
https://bugs.webkit.org/show_bug.cgi?id=108307
Reviewed by David Hyatt.
Source/WebCore:
The fix for https://bugs.webkit.org/show_bug.cgi?id=69896 allowed positioned blocks work
with variable width regions. However, the information needed for that is available only
when the container used for positioning is a block.
This patch ensures we are using this solution only when the container used for positioning
is a block. This needs to be revisited when we will extend support for other types of boxes
as mentioned in RenderBox::renderBoxRegionInfo.
Test: fast/regions/positioned-object-inline-cb-crash.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth): Make sure we are using containerBlocks
that are blocks. Add an assert that the type of containerBlock we are using can have
computed RenderBoxRegionInfo.
(WebCore::RenderBox::computePositionedLogicalHeight):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion): This helper method
will return the boxes that may have computed RenderBoxRegionInfo. Currently,
returns true for blocks only.
LayoutTests:
- fast/regions/positioned-object-inline-cb-crash-expected.txt: Added.
- fast/regions/positioned-object-inline-cb-crash.html: Added.
- 1:31 AM Changeset in webkit [143311] by
-
- 2 edits in trunk/Tools
Unreviewed, updated spelling of my name.
- Scripts/webkitpy/common/config/committers.py:
- 1:27 AM Changeset in webkit [143310] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] fix ScrollAnimatorNoneTest after r143295
https://bugs.webkit.org/show_bug.cgi?id=110189
Reviewed by Nico Weber.
- tests/ScrollAnimatorNoneTest.cpp:
(MockScrollableArea):
- 1:22 AM Changeset in webkit [143309] by
-
- 2 edits in trunk/Source/WebCore
Yet anther JSC build fix after r143304.
- bindings/js/JSDOMBinding.h:
(WebCore::argumentOrNull):
- 1:00 AM Changeset in webkit [143308] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix. Fixed warning caused by r143305.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- 12:55 AM Changeset in webkit [143307] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding a failure expectation for the failing
fast/regions/seamless-iframe-flowed-into-regions.html added in r143256.
- 12:23 AM Changeset in webkit [143306] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r143304.
- bindings/js/JSDOMBinding.h:
(WebCore::argumentOrNull):
- 12:21 AM Changeset in webkit [143305] by
-
- 16 edits in trunk/Source/WebCore
[V8] Remove redundant usage of MAYBE_MISSING_PARAMETER() macro
https://bugs.webkit.org/show_bug.cgi?id=109899
Reviewed by Adam Barth.
Currently:
- MAYBE_MISSING_PARAMETER(args, index, DefaultIsUndefined) returns args[index].
- MAYBE_MISSING_PARAMETER(args, index, DefaultIsNullString) returns Local<Value>()
if args[index] is missing (i.e. the length of |args| is less than |index|).
It returns args[index] otherwise.
No one other than CodeGeneratorV8.pm uses
MAYBE_MISSING_PARAMETER(args, index, DefaultIsUndefined). Instead, we simply use
args[index]. We should remove the redundant usage from CodeGeneratorV8.pm too.
The long-name macro has been making generated code less readable.
In addition, we can rename MAYBE_MISSING_PARAMETER() to argumentOrNull().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooCallback):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerV8Internal::methodCallback):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::TestObjV8Internal::methodWithOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::classMethodWithOptionalCallback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
(WebCore::TestObjV8Internal::domStringListFunctionCallback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::TestObjV8Internal::variadicStringMethodCallback):
(WebCore::TestObjV8Internal::variadicDoubleMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
(WebCore::V8TestOverloadedConstructors::constructor4Callback):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::funcCallback):
(WebCore::TestTypedefsV8Internal::setShadowCallback):
(WebCore::TestTypedefsV8Internal::methodWithSequenceArgCallback):
(WebCore::TestTypedefsV8Internal::nullableArrayArgCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunctionCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunction2Callback):
(WebCore::V8TestTypedefs::constructorCallback):
- bindings/v8/V8BindingMacros.h:
(WebCore):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallbackCustom):
(WebCore::V8History::replaceStateCallbackCustom):
- 12:12 AM Changeset in webkit [143304] by
-
- 14 edits in trunk/Source/WebCore
[JSC] MAYBE_MISSING_PARAMETER(..., DefaultIsNullString) macro is redundant
https://bugs.webkit.org/show_bug.cgi?id=109902
Reviewed by Adam Barth.
Currently:
- MAYBE_MISSING_PARAMETER(exec, index, DefaultIsUndefined) returns exec->argument(index).
- MAYBE_MISSING_PARAMETER(exec, index, DefaultIsNullString) returns JSValue() if exec->argument(index) is missing (i.e. the length of the argument is less than index). It returns exec->argument(index) otherwise.
No one other than CodeGeneratorJS.pm uses
MAYBE_MISSING_PARAMETER(exec, index, DefaultIsUndefined).
Instead, we simply use exec->argument(index). We should remove
the redundant usage in CodeGeneratorJS.pm too. The long-name macro
has been making generated code less readable.
In addition, we can rename MAYBE_MISSING_PARAMETER() to argumentOrNull().
c.f. corresponding V8 bug: https://bugs.webkit.org/show_bug.cgi?id=109899
No tests. No change in behavior.
- bindings/js/JSDOMBinding.h:
(WebCore):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::jsFloat64ArrayPrototypeFunctionFoo):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefined):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod8):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod9):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod10):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence):
(WebCore::jsTestObjPrototypeFunctionStringArrayFunction):
(WebCore::jsTestObjPrototypeFunctionDomStringListFunction):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
(WebCore::jsTestObjPrototypeFunctionVariadicStringMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors1):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors2):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors3):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors4):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionMultiTransferList):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::constructJSTestTypedefs):
(WebCore::jsTestTypedefsPrototypeFunctionFunc):
(WebCore::jsTestTypedefsPrototypeFunctionMultiTransferList):
(WebCore::jsTestTypedefsPrototypeFunctionSetShadow):
(WebCore::jsTestTypedefsPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestTypedefsPrototypeFunctionNullableArrayArg):
(WebCore::jsTestTypedefsPrototypeFunctionStringArrayFunction):
(WebCore::jsTestTypedefsPrototypeFunctionStringArrayFunction2):
Feb 18, 2013:
- 11:57 PM Changeset in webkit [143303] by
-
- 9 edits2 adds in trunk
Make EventDispatcher take an Event object in its constructor.
https://bugs.webkit.org/show_bug.cgi?id=109898
Reviewed by Dimitri Glazkov.
Source/WebCore:
Re-landing r143145, which caused a crash when deltaX and deltaY of a PlatformWheelEvent are both zero.
Fixed a crash by early exiting in EventDispatcher::dispatchEvent(Node*, PassRefPtr<EventDispatcher*>)
if mediator's event() returns null.
Also Added a layout test to catch this kind of crash in the future.
Test: fast/events/platform-wheelevent-with-delta-zero-crash.html
- dom/EventDispatchMediator.cpp:
(WebCore::EventDispatchMediator::dispatchEvent):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::ensureEventPath):
(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::dispatchEventPreProcess):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventDispatcher.h:
(EventDispatcher):
(WebCore::EventDispatcher::node):
(WebCore::EventDispatcher::event):
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
- dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::dispatchEvent):
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
- dom/WheelEvent.cpp:
(WebCore::WheelEventDispatchMediator::dispatchEvent):
Assert event() rather than an early exit since this code path should be hit only when event() is non-null.
LayoutTests:
- fast/events/platform-wheelevent-with-delta-zero-crash-expected.txt: Added.
- fast/events/platform-wheelevent-with-delta-zero-crash.html: Added.
- 11:48 PM Changeset in webkit [143302] by
-
- 7 edits in trunk/Source/WebKit2
[GTK] Remove webkit_web_view_get_subresources from WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=110125
Reviewed by Anders Carlsson.
This API is currently implemented caching all resources in the
WebView which causes some problems in documents loading resources
indefinitely. This API was used in WebKit1 mainly to implement
webkit_web_view_save(), but we already have such API in
WebKit2.
- UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
(didReceiveWebViewMessageFromInjectedBundle):
- UIProcess/API/gtk/WebKitWebView.cpp:
(_WebKitWebViewPrivate):
(webkitWebViewLoadChanged):
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestResources.cpp:
(testWebViewResources):
(testWebResourceGetData):
- 11:39 PM Changeset in webkit [143301] by
-
- 2 edits in trunk/LayoutTests
Add a flaky failing test expectation to inspector/editor/brace-matcher.html on Mac per bug 110186.
- platform/mac/TestExpectations:
- 11:31 PM Changeset in webkit [143300] by
-
- 5 edits2 adds in trunk
:before/:after pseudo elements do not always apply to the proper element
https://bugs.webkit.org/show_bug.cgi?id=93925
Reviewed by Dimitri Glazkov.
Source/WebCore:
Disable sharing a style with siblings if :after or :before pseudo style
is unique.
Test: fast/css/before-after-pseudo-class.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
Added a new condition, hasUniquePseudoStyle.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::hasUniquePseudoStyle):
Added to check whether any pseudo style has unique bit or not.
(WebCore):
- rendering/style/RenderStyle.h:
LayoutTests:
- fast/css/before-after-pseudo-class-expected.html: Added.
- fast/css/before-after-pseudo-class.html: Added.
- 11:22 PM Changeset in webkit [143299] by
-
- 5 edits2 adds in trunk
Focusing a new frame (via window.focus()) should blur the active element in the current frame
https://bugs.webkit.org/show_bug.cgi?id=110172
Reviewed by Ryosuke Niwa.
Source/WebCore:
When a change in the focused node crosses a frame boundary, WebKit
doesn't always succeed in blurring the old focused node before focusing
the new one.
Each document remembers its focused node, and a Page-scoped
FocusController remembers the focused frame. If a new focused node is
in a different frame than the focused frame, FocusController tells the
old frame's document to clear its focused node before focusing the new
one (and remembering the new frame).
Unfortunately, web content can confuse FocusController by calling
window.focus() at the wrong time. Since window.focus() changes
FocusController's focused frame without focusing a new node,
FocusController won't think that a frame boundary is being crossed if a
node in this frame is later focused. Therefore it won't clear the old
frame's focused node (it won't even know which frame contained the old
focused node), causing at least two bugs:
1) The node in the old frame will not receive a blur event.
2) Calling document.activeElement on the main frame will return the
previously focused node, but the HTML5 spec says it should return
the frame owner element if a subframe has focus.
Fix both of these bugs by explicitly clearing the current frame's
focused node if window.focus() changes the focused frame. This fix
carries some compatibility risk by changing a long-standing behavior
of the engine (we've had this bug since the beginning of the project,
AFAICT). On the upside, it matches the behavior of both Firefox and IE,
matches what HTML5 says about subframe focus, and fixes at least one
well-known enterprise web app.
Tests: fast/dom/HTMLDocument/active-element-frames.html
fast/frames/frame-focus-blurs-active-element.html
- page/DOMWindow.cpp:
(WebCore::DOMWindow::focus): If the frame being focused is not the same
as the currently focused frame, clear the currently focused frame's
focused node.
LayoutTests:
- fast/dom/HTMLDocument/active-element-frames-expected.txt:
- fast/dom/HTMLDocument/active-element-frames.html: Modified to run the
test a second time, focusing each element's frame before focusing the
element itself.
- fast/frames/frame-focus-blurs-active-element-expected.txt: Added.
- fast/frames/frame-focus-blurs-active-element.html: Added a test that
verifies a blur event is fired on the active element when a new frame
is focused.
- 11:18 PM Changeset in webkit [143298] by
-
- 2 edits in trunk/Tools
Unreviewed. Adjust expectations.
- TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
(TestWebKitAPI::TEST):
- 10:57 PM Changeset in webkit [143297] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][EFL] Stop using internal C++ API in ewk_error
https://bugs.webkit.org/show_bug.cgi?id=108796
Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-18
Reviewed by Benjamin Poulain.
Stop using internal C++ API in ewk_error and use C API instead of avoid
violating API layering.
- UIProcess/API/efl/ewk_error.cpp:
(EwkError::domain):
(EwkError::isCancellation):
(ewk_error_type_get):
- UIProcess/API/efl/ewk_error_private.h:
(EwkError):
- 10:39 PM Changeset in webkit [143296] by
-
- 2 edits in trunk/LayoutTests
[EFL][WebGL] Enable test webgl/conformance/canvas/texture-bindings-unaffected-on-resize.html.
https://bugs.webkit.org/show_bug.cgi?id=110176
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-18
Reviewed by Laszlo Gombos.
Enable the test for EFL port, as it passes after r143220.
- platform/efl-wk2/TestExpectations:
- 10:35 PM Changeset in webkit [143295] by
-
- 30 edits in trunk/Source
Clean up the boolean argument to visibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=110167
Source/WebCore:
Reviewed by Simon Fraser.
Replace the boolean argument to visibleContentRect() with
an enum.
No behavior change.
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::viewportSize):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
- page/FrameView.cpp:
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::layout):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::windowClipRect):
- page/SpatialNavigation.cpp:
(WebCore::canScrollInDirection):
- platform/ScrollView.cpp:
(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::layoutSize):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::paint):
- platform/ScrollView.h:
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::visibleContentRect):
- platform/ScrollableArea.h:
- rendering/RenderDialog.cpp:
(WebCore::RenderDialog::layout):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::maximumScrollPosition):
(WebCore::RenderLayer::visibleContentRect):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
Source/WebKit/blackberry:
Reviewed by Simon Fraser.
Replace the boolean argument to visibleContentRect() with
an enum.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::getRecursiveVisibleWindowRect):
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
Source/WebKit/chromium:
Reviewed by Simon Fraser.
Replace the boolean argument to visibleContentRect() with
an enum.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::popupOpened):
Source/WebKit/efl:
Reviewed by Simon Fraser.
Replace the boolean argument to visibleContentRect() with
an enum.
- ewk/ewk_frame.cpp:
(ewk_frame_visible_content_geometry_get):
Source/WebKit/win:
Reviewed by Simon Fraser.
Replace the boolean argument to visibleContentRect() with
an enum.
- WebFrame.cpp:
(WebFrame::visibleContentRect):
(WebFrame::frameBounds):
Source/WebKit2:
Reviewed by Simon Fraser.
Replace the boolean argument to visibleContentRect() with
an enum.
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::visibleContentBounds):
(WebKit::WebFrame::visibleContentBoundsExcludingScrollbars):
- 10:27 PM Changeset in webkit [143294] by
-
- 2 edits in trunk/Source/WebCore
That didn't work either. Just make it public. This is why I hate nested classes. They just don't work.
- rendering/RenderBlock.h:
(RenderBlock):
- 10:12 PM Changeset in webkit [143293] by
-
- 3 edits in trunk/Source/WebCore
Windows build fix. Apparently Visual Studio still has a lot of bugs with respect to nested classes.
Work around it by directly instantiating the class inside createFloatingObjects.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::createFloatingObjects): Directly instantiate FloatingObjects.
- rendering/RenderBlock.h:
(RenderBlock): Moved the declaration of createFloatingObjects up.
(FloatingObjects::FloatingObjects):
- 9:51 PM Changeset in webkit [143292] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for Apple Windows. Second stage.
Add missed export statement.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- 7:52 PM Changeset in webkit [143291] by
-
- 2 edits in trunk/LayoutTests
Add a flaky crash expectation to video-controls-captions-trackmenu.html on Mac per bug 110173.
- platform/mac/TestExpectations:
- 7:42 PM Changeset in webkit [143290] by
-
- 3 edits in trunk/Source/WebCore
Merge handleSpecialChild into layoutBlockChildren
https://bugs.webkit.org/show_bug.cgi?id=110165
Reviewed by Darin Adler.
Merge handleSpecialChild, handlePositionedChild, and handleFloatingChild into layoutBlockChildren
to make the semantics of the code clear and to get rid of the outdated comment about how there are
four types of four types of special children.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChildren):
- rendering/RenderBlock.h:
(RenderBlock):
- 7:38 PM Changeset in webkit [143289] by
-
- 3 edits in trunk/Source/WebCore
Encapsulate FloatingObject's constructor inside create
https://bugs.webkit.org/show_bug.cgi?id=110169
Reviewed by Darin Adler.
Added FloatingObject::create and made FloatingObject's constructor private.
Also added RenderBlock::ensureFloatingObjects to help lazily creating FloatingObjects.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::ensureFloatingObjects):
(WebCore::RenderBlock::FloatingObjects::create):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
- rendering/RenderBlock.h:
(FloatingObjects):
(RenderBlock):
- 7:20 PM Changeset in webkit [143288] by
-
- 2 edits in trunk/LayoutTests
Remove a stale Mac test expectation.
- platform/mac/TestExpectations:
- 6:55 PM Changeset in webkit [143287] by
-
- 16 edits in trunk/Source
Add a DefaultHash for RefPtr<SecurityOrigin>
https://bugs.webkit.org/show_bug.cgi?id=110170
Reviewed by Andreas Kling.
Remove all explicit uses of SecurityOriginHash.
Source/WebCore:
- Modules/webdatabase/DatabaseTracker.h:
- Modules/webdatabase/OriginQuotaManager.h:
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::getOriginsWithCache):
- loader/cache/MemoryCache.h:
- page/SecurityOriginHash.h:
- storage/StorageNamespaceImpl.h:
(StorageNamespaceImpl):
Source/WebKit/mac:
- WebCoreSupport/WebApplicationCache.mm:
(+[WebApplicationCache originsWithCache]):
Source/WebKit2:
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::SessionStorageNamespace):
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::originsWithApplicationCache):
- WebProcess/Notifications/NotificationPermissionRequestManager.h:
Include SecurityOriginHash.h. This fixes a bug where m_originToIDMap used pointer-equality
for looking up security origins.
- WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
This can just take a const reference.
- WebProcess/ResourceCache/WebResourceCacheManager.h:
- 6:34 PM Changeset in webkit [143286] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 6:02 PM Changeset in webkit [143285] by
-
- 2 edits in branches/chromium/1410/Source/WebCore/Modules/mediastream
Merge 142887
BUG=176033
Review URL: https://codereview.chromium.org/12297021
- 6:01 PM Changeset in webkit [143284] by
-
- 5 edits2 adds in trunk
Padding and border changes don't trigger the relayout of children in some cases.
https://bugs.webkit.org/show_bug.cgi?id=109639.
Reviewed by Ryosuke Niwa.
Source/WebCore:
The fix for this bug was way too general and involved putting code into RenderBox. Since
RenderBox makes no assumptions about what kind of layout system might derive from it, it
was incorrect to just mark all children as needing layout whenever borders and padding
changed widths.
This patch takes the two cases handled by the original code and makes them more
specialized down in subclasses, i.e., RenderBlock and RenderTableRow. RenderBlock has
been refined to only check if children aren't inline and to also not invalidate
floats or irrelevant positioned objects that might not even have this block as their
containing block.
The RenderTableRow code is specialized to only care about collapsing borders and
to only check borders rather than padding. It also requires that a child be a cell
in order to do the invalidation.
Covered by existing tests, since this is just specializing the code to more precisely
cover the test cases that have already been written.
Longer term, it should be layout code that figures this stuff out rather than style
change code, but that involves more dramatic changes that can wait.
Test: fast/block/positioning/border-change-relayout-test.html
- rendering/RenderBlock.cpp:
(WebCore::borderOrPaddingLogicalWidthChanged):
(WebCore):
(WebCore::RenderBlock::styleDidChange):
- rendering/RenderBox.cpp:
(WebCore):
(WebCore::RenderBox::styleDidChange):
- rendering/RenderTableRow.cpp:
(WebCore::borderLogicalWidthChanged):
(WebCore):
(WebCore::RenderTableRow::styleDidChange):
LayoutTests:
- fast/block/positioning/border-change-relayout-test-expected.html: Added.
- fast/block/positioning/border-change-relayout-test.html: Added.
- 5:56 PM Changeset in webkit [143283] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove unneeded explicit function template arguments.
https://bugs.webkit.org/show_bug.cgi?id=110043
Reviewed by Ryosuke Niwa.
- runtime/Identifier.cpp:
(JSC::IdentifierASCIIStringTranslator::hash): Let the compiler deduce the type
when calling computeHashAndMaskTop8Bits.
(JSC::IdentifierLCharFromUCharTranslator::hash): Ditto.
- runtime/Identifier.h:
(JSC::IdentifierCharBufferTranslator::hash): Ditto.
- 5:55 PM Changeset in webkit [143282] by
-
- 3 edits in trunk/Source/WebCore
Small follow up to r143271: Fix SQLTransaction leak.
https://bugs.webkit.org/show_bug.cgi?id=110052.
Reviewed by Geoffrey Garen.
Applied Geoff's suggestion nullify m_frontend sooner for greater
code clarity. Also added some comments about m_frontend.
No new tests.
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::doCleanup):
- Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
- 5:51 PM Changeset in webkit [143281] by
-
- 4 edits2 copies in branches/chromium/1410
Merge 143060
BUG=170184
Review URL: https://codereview.chromium.org/12301012
- 5:45 PM Changeset in webkit [143280] by
-
- 2 edits in trunk/Source/WTF
Style tweaks to StringHasher.h
https://bugs.webkit.org/show_bug.cgi?id=110042
Reviewed by Alexey Proskuryakov.
I have a bug fix coming soon, but figured I'd separate out style tweaks and land them
first to make that patch easier to undrestand.
- wtf/StringHasher.h: Tweak and rearrange comments a bit.
(WTF::StringHasher::addCharacter): Use character instead of ch.
(WTF::StringHasher::addCharacters): Use remainder instead of rem. Also capitalize the U
that we use to make an unsigned 1 constant.
(WTF::StringHasher::computeHashAndMaskTop8Bits): Ditto.
(WTF::StringHasher::hashMemory): Change version that takes size as a template argument
to call the version that takes the size at runtime, since both generate the same code
anyway. Added a FIXME questioning why this function uses the "mask top 8 bits" version
of the hash. Fix incorrect compile assertion that required sizes that are multiples
of four. This function works on sizes that are multiples of two. Also fixed a spelling
error where we called it a "multible".
(WTF::StringHasher::defaultConverter): Use character instead of ch.
(WTF::StringHasher::addCharactersToHash): Eliminated unnecessary local variable.
- 5:39 PM Changeset in webkit [143279] by
-
- 17 edits3 adds in trunk
Shrank the SourceProvider cache
https://bugs.webkit.org/show_bug.cgi?id=110158
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
CodeCache is now our primary source cache, so a long-lived SourceProvider
cache is a waste. I measured this as a 10MB Membuster win; with more
precise instrumentation, Andreas estimated it as up to 30MB.
I didn't eliminate the SourceProvider cache because it's still useful
in speeding up uncached parsing of scripts with large nested functions
(i.e., all scripts).
- heap/Heap.cpp:
(JSC::Heap::collect): Discard all source provider caches after GC. This
is a convenient place to do so because it's reasonably soon after initial
parsing without being immediate.
- parser/Parser.cpp:
(JSC::::Parser): Updated for interface change: The heap now owns the
source provider cache, since most SourceProviders are not expected to
have one by default, and the heap is responsible for throwing them away.
(JSC::::parseInner): No need to update statistics on cache size, since
we're going to throw it away no matter what.
(JSC::::parseFunctionInfo): Reduced the minimum function size to 16. This
is a 27% win on a new parsing micro-benchmark I've added. Now that the
cache is temporary, we don't have to worry so much about its memory
footprint.
- parser/Parser.h:
(Parser): Updated for interface changes.
- parser/SourceProvider.cpp:
(JSC::SourceProvider::SourceProvider):
(JSC::SourceProvider::~SourceProvider):
- parser/SourceProvider.h:
(JSC):
(SourceProvider): SourceProvider doesn't own its cache anymore because
the cache is temporary.
- parser/SourceProviderCache.cpp:
(JSC::SourceProviderCache::clear):
(JSC::SourceProviderCache::add):
- parser/SourceProviderCache.h:
(JSC::SourceProviderCache::SourceProviderCache):
(SourceProviderCache):
- parser/SourceProviderCacheItem.h:
(SourceProviderCacheItem): No need to update statistics on cache size,
since we're going to throw it away no matter what.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::addSourceProviderCache):
(JSC):
(JSC::JSGlobalData::clearSourceProviderCaches):
- runtime/JSGlobalData.h:
(JSC):
(JSGlobalData): Moved the cache here so it's easier to throw away.
Source/WebCore:
Test: fast/js/regress/nested-function-parsing.html
No need to keep statistics on cache size, since we're going to throw it
away no matter what.
- WebCore.order:
- bindings/js/CachedScriptSourceProvider.h:
(CachedScriptSourceProvider):
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::destroyDecodedData):
(WebCore):
(WebCore::CachedScript::reportMemoryUsage):
- loader/cache/CachedScript.h:
(CachedScript):
LayoutTests:
New benchmark to show that a minimum size of 16 is better than 64.
- fast/js/regress/nested-function-parsing-expected.txt: Added.
- fast/js/regress/nested-function-parsing.html: Added.
- fast/js/regress/script-tests/nested-function-parsing.js: Added.
- 5:29 PM Changeset in webkit [143278] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed VS2010 build correction.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Sync
export definition with VS2005 version.
- 5:22 PM Changeset in webkit [143277] by
-
- 3 edits in trunk/Source/WebKit2
Begin stubbing out session storage classes
https://bugs.webkit.org/show_bug.cgi?id=110168
Reviewed by Andreas Kling.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
(WebKit):
(WebKit::StorageManager::StorageArea::create):
(WebKit::StorageManager::StorageArea::StorageArea):
(WebKit::StorageManager::StorageArea::~StorageArea):
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::isEmpty):
(WebKit::StorageManager::SessionStorageNamespace::create):
(WebKit::StorageManager::SessionStorageNamespace::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::~SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
(WebKit::StorageManager::createSessionStorageNamespaceInternal):
(WebKit::StorageManager::destroySessionStorageNamespaceInternal):
(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- 5:15 PM Changeset in webkit [143276] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG backend Branch handling has duplicate code and dead code
https://bugs.webkit.org/show_bug.cgi?id=110162
Reviewed by Mark Hahnenberg.
Streamline the code, and make the 64 backend's optimizations make more sense
(i.e. not be dead code).
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- 4:40 PM Changeset in webkit [143275] by
-
- 16 edits2 moves10 adds in trunk/Source/WebKit2
[EFL][WK2] Add C API for popup menu and popup item
https://bugs.webkit.org/show_bug.cgi?id=109083
Reviewed by Anders Carlsson.
WK2 EFL delegates display of the popup menu to the browser which causes
us to have a strong interdependency between internal C++ classes
(WebPopupMenuProxyEfl, WebPopupItem) and our EFL API implementation
(EwkView, EwkPopupMenu, EwkPopupMenuItem).
Since we want to remove this interdependency, this patch introduces a
for WebPopupMenuProxyEfl (WKPopupMenuListener) and for WebPopupItem
(WKPopupItem). It also introduces a WKPage client with callbacks for
showPopupMenu and hidePopupMenu.
Note that the popup menu functionality is covered by ewk_popup_menu API
tests and no functionality is lost.
- PlatformEfl.cmake: Add new files to EFL CMake config.
- Shared/API/c/efl/WKBaseEfl.h: Add typedefs for WKPopupItemRef and
WKPopupMenuListenerRef.
- Shared/APIObject.h: Add new TypePopupMenuItem APIObject type for EFL
platform.
- UIProcess/API/C/efl/WKAPICastEfl.h: Add mapping for WKPopupItemRef
and WKPopupMenuListenerRef API types.
(WebKit):
(WebKit::toAPI):
- UIProcess/API/C/efl/WKPageEfl.cpp: Added.
(WKPageSetUIPopupMenuClient): Add new C API to set the UI Popup Menu
client on the page.
- UIProcess/API/C/efl/WKPageEfl.h: Added.
- UIProcess/API/C/efl/WKPopupItem.cpp: Added. Add C API for WebPopupItem.
(WKPopupItemGetType):
(WKPopupItemGetTextDirection):
(WKPopupItemHasTextDirectionOverride):
(WKPopupItemCopyText):
(WKPopupItemCopyToolTipText):
(WKPopupItemCopyAccessibilityText):
(WKPopupItemIsEnabled):
(WKPopupItemIsLabel):
(WKPopupItemIsSelected):
- UIProcess/API/C/efl/WKPopupItem.h: Added.
- UIProcess/API/C/efl/WKPopupMenuListener.cpp: Added. Add C API for
WebPopupMenuListenerEfl (formerly WebPopupMenuProxyEfl) so that the
client can report which popup menu item was selected.
(WKPopupMenuListenerSetSelection):
- UIProcess/API/C/efl/WKPopupMenuListener.h: Added.
- UIProcess/API/efl/EwkView.cpp: Remove dependency on internal C++ types
(WebPopupMenuProxyEfl and WebPopupItem) and use C API types instead.
(EwkView::requestPopupMenu):
- UIProcess/API/efl/EwkView.h:
(WebKit):
(EwkView):
- UIProcess/API/efl/ewk_popup_menu.cpp: Use C API for Popup menu.
(EwkPopupMenu::EwkPopupMenu):
(EwkPopupMenu::setSelectedIndex):
- UIProcess/API/efl/ewk_popup_menu_private.h:
(EwkPopupMenu::create):
(EwkPopupMenu):
- UIProcess/WebPageProxy.cpp: Use WKPageUIPopupMenuClient to show / hide
the popup menu on EFL port instead of asking the WebPopupMenuProxy.
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::hidePopupMenu):
- UIProcess/WebPageProxy.h: Add new WKPageUIPopupMenuClient member and
corresponding initialization method.
(WebPageProxy):
- UIProcess/WebPopupMenuProxy.h: Disable showPopupMenu / hidePopupMenu
virtual methods on EFL port since we go via WKPageUIPopupMenuClient
for this now.
(WebPopupMenuProxy):
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::PageUIClientEfl): Handle WKPageUIPopupMenuClient
callbacks and call corresponding EwkView methods. Previously, the EwkView
methods were called by the internal WebPageProxyEfl class which is no
longer needed.
(WebKit::PageUIClientEfl::showPopupMenu):
(WebKit):
(WebKit::PageUIClientEfl::hidePopupMenu):
- UIProcess/efl/PageUIClientEfl.h:
(PageUIClientEfl):
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::initializeUIPopupMenuClient):
(WebKit):
- UIProcess/efl/WebPopupItemEfl.cpp: Added. Add APIObject wrapper for
WebPopupItem so that we can use it in WKPageUIPopupMenuClient.
(WebKit):
(WebKit::WebPopupItemEfl::WebPopupItemEfl):
(WebKit::WebPopupItemEfl::~WebPopupItemEfl):
- UIProcess/efl/WebPopupItemEfl.h: Added.
(WebKit):
(WebPopupItemEfl):
(WebKit::WebPopupItemEfl::create):
(WebKit::WebPopupItemEfl::data):
(WebKit::WebPopupItemEfl::itemType):
(WebKit::WebPopupItemEfl::text):
(WebKit::WebPopupItemEfl::textDirection):
(WebKit::WebPopupItemEfl::hasTextDirectionOverride):
(WebKit::WebPopupItemEfl::toolTipText):
(WebKit::WebPopupItemEfl::accessibilityText):
(WebKit::WebPopupItemEfl::isEnabled):
(WebKit::WebPopupItemEfl::isLabel):
(WebKit::WebPopupItemEfl::isSelected):
(WebKit::WebPopupItemEfl::type):
- UIProcess/efl/WebPopupMenuListenerEfl.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebPopupMenuProxyEfl.cpp.
Use WebPopupMenuListenerEfl name instead of WebPopupMenuProxyEfl since
it more accurately represents its functionality now.
(WebKit):
(WebKit::WebPopupMenuListenerEfl::WebPopupMenuListenerEfl):
(WebKit::WebPopupMenuListenerEfl::valueChanged):
- UIProcess/efl/WebPopupMenuListenerEfl.h: Renamed from Source/WebKit2/UIProcess/efl/WebPopupMenuProxyEfl.h.
(WebKit):
(WebPopupMenuListenerEfl):
(WebKit::WebPopupMenuListenerEfl::create):
- UIProcess/efl/WebUIPopupMenuClient.cpp: Added.
(WebUIPopupMenuClient::showPopupMenu):
(WebUIPopupMenuClient::hidePopupMenu):
- UIProcess/efl/WebUIPopupMenuClient.h: Added.
(WebKit):
(WebUIPopupMenuClient):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::createPopupMenuProxy):
- 4:30 PM WebKit Team edited by
- (diff)
- 4:19 PM Changeset in webkit [143274] by
-
- 4 edits in trunk/Source/JavaScriptCore
[Windows] Unreviewed VS2010 build correction after r143273.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add missing source
file SourceProvider.cpp.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Add missing exports.
- 4:03 PM Changeset in webkit [143273] by
-
- 5 edits in trunk/Source/WebKit2
Add StorageManager member functions for keeping track of session storage namespaces
https://bugs.webkit.org/show_bug.cgi?id=110163
Reviewed by Andreas Kling.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createSessionStorageNamespace):
(WebKit):
(WebKit::StorageManager::destroySessionStorageNamespace):
(WebKit::StorageManager::cloneSessionStorageNamespace):
(WebKit::StorageManager::createSessionStorageNamespaceInternal):
(WebKit::StorageManager::destroySessionStorageNamespaceInternal):
(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- UIProcess/WebContext.h:
(WebKit::WebContext::storageManager):
(WebContext):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::createNewPage):
- 4:00 PM Changeset in webkit [143272] by
-
- 2 edits in trunk/Source/WebCore
[Curl] The function cookiesForDOM() does not behave correctly.
https://bugs.webkit.org/show_bug.cgi?id=109923
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-02-18
Reviewed by Brent Fulgham.
The cookiesForDOM() function should return a list of matching cookies, both persistent and session cookies.
- platform/network/curl/CookieJarCurl.cpp:
(WebCore::readCurlCookieToken): Added function to read next token from Curl cookie string.
(WebCore::addMatchingCurlCookie): Added function to add matching cookies to cookie list.
(WebCore::setCookiesFromDOM): Add domain and path from url to cookie if not already set.
(WebCore::cookiesForDOM): Return a list of matching cookies, both session and persistent cookies.
- 3:42 PM Changeset in webkit [143271] by
-
- 11 edits in trunk/Source/WebCore
Fix SQLTransaction leak.
https://bugs.webkit.org/show_bug.cgi?id=110052.
Reviewed by Geoffrey Garen.
With https://bugs.webkit.org/show_bug.cgi?id=104750, there is now a circular
reference between SQLTransaction and its backend. The clean up process needs
to be fixed to explicitly break this reference cycle.
The 5 phases of the SQLTransaction (and backend) phases and their clean up
actions are:
Phase 1. After Birth, before scheduling
- During shutdown, DatabaseThread::databaseThread() calls DatabaseBackendAsync::close(). DatabaseBackendAsync::close() iterates DatabaseBackendAsync::m_transactionQueue and calls SQLtransactionBackend::notifyDatabaseThreadIsShuttingDown() on each transaction there.
Phase 2. After scheduling, before state AcquireLock
- ~DatabaseTask() calls SQLtransactionBackend's notifyDatabaseThreadIsShuttingDown().
Phase 3. After state AcquireLock, before "lockAcquired"
- During shutdown, DatabaseThread::databaseThread() calls SQLTransactionCoordinator::shutdown(), which calls SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown().
Phase 4: After "lockAcquired", before state CleanupAndTerminate
- Same as Phase 3.
Phase 5: After state CleanupAndTerminate
- state CleanupAndTerminate calls SQLTransactionBackend::doCleanup().
See comment at the top of SQLTransactionBackend.cpp for more details.
Other supporting changes:
- Moved Database::close() to the DatabaseBackendAsync.
- Moved the "if already cleaned up" check from SQLTransactionBackend's notifyDatabaseThreadIsShuttingDown() to doCleanup().
- Added a check to prevent SQLTransactionCoordinator's releaseLock() from running when it's shutting down.
No new tests.
- Modules/webdatabase/Database.cpp:
- Modules/webdatabase/Database.h:
- Modules/webdatabase/DatabaseBackendAsync.cpp:
(WebCore::DatabaseBackendAsync::close): Move from Database.cpp.
- Modules/webdatabase/DatabaseBackendAsync.h:
- Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::~DatabaseTransactionTask):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::doPerformTask):
- Modules/webdatabase/DatabaseTask.h:
(DatabaseBackendAsync::DatabaseTransactionTask):
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThread):
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):
(WebCore::SQLTransactionBackend::cleanupAndTerminate):
- Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::SQLTransactionCoordinator::SQLTransactionCoordinator):
(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):
- Modules/webdatabase/SQLTransactionCoordinator.h:
(SQLTransactionCoordinator):
- 3:29 PM Changeset in webkit [143270] by
-
- 2 edits in trunk/Source/WebCore
Fix WebCore Xcode project
- WebCore.xcodeproj/project.pbxproj: Fix path for CDMPrivate.h.
- 3:21 PM Changeset in webkit [143269] by
-
- 4 edits3 adds in trunk
Structure::flattenDictionaryStructure should compute max offset in a manner that soundly handles the case where the property list becomes empty
https://bugs.webkit.org/show_bug.cgi?id=110155
<rdar://problem/13233773>
Source/JavaScriptCore:
Reviewed by Mark Rowe.
This was a rookie mistake. It was doing:
for (blah) {
m_offset = foo foo's monotonically increase in the loop
}
as a way of computing max offset for all of the properties. Except what if the loop doesn't
execute because there are no properties? Well, then, you're going to have a bogus m_offset.
The solution is to initialize m_offset at the top of the loop.
- runtime/Structure.cpp:
(JSC::Structure::flattenDictionaryStructure):
LayoutTests:
Reviewed by Mark Rowe.
- fast/js/flatten-dictionary-structure-from-which-all-properties-were-deleted-expected.txt: Added.
- fast/js/flatten-dictionary-structure-from-which-all-properties-were-deleted.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/flatten-dictionary-structure-from-which-all-properties-were-deleted.js: Added.
- 3:15 PM Changeset in webkit [143268] by
-
- 3 edits in trunk/Source/WebCore
[CSS Grid Layout] Refactor grid position resolution code to support an internal grid representation
https://bugs.webkit.org/show_bug.cgi?id=109718
Reviewed by Ojan Vafai.
In order to support auto placement (where we can't infer a grid item's position from its style),
we need to have 2 code paths:
- One that places the elements on the grid representation.
- One that reuse the grid representation to return the position.
This code path implements this split so that we can add auto placement in a follow-up patch(es).
Also in order to avoid a O(n2) behavior [walking over our grid to find a grid item's position],
the cached position code path needed an efficient way to find the grid items -> position mapping.
Refactoring, covered by existing tests.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::cachedGridCoordinate):
(WebCore::RenderGrid::resolveGridPositionFromStyle):
These methods implements the above split. The first one
reuses our cached information whereas the other one is
used to build the cache.
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::layoutGridItems):
Added some code to clear the grid items' position.
(WebCore::RenderGrid::findChildLogicalPosition):
(WebCore::RenderGrid::logicalContentHeightForChild):
Updated these functions to use cachedGridPosition.
(WebCore::RenderGrid::maximumIndexInDirection):
Added a comment about why we don't use cachedGridPosition.
(WebCore::RenderGrid::insertItemIntoGrid):
Added this helper function to insert into the grid and
cache the position in the reverse lookup map.
(WebCore::RenderGrid::placeItemsOnGrid):
Updated to call insertItemIntoGrid. Also added an ASSERT
similar to m_grid.
(WebCore::RenderGrid::clearGrid):
Added this helper function to clear our grid structure.
- rendering/RenderGrid.h:
(GridCoordinate):
(WebCore::RenderGrid::GridCoordinate::GridCoordinate):
Added this POD to hold the coordinates in our reverse map.
- 3:07 PM Changeset in webkit [143267] by
-
- 37 edits2 adds in trunk
feFlood incorrectly applied color-interpolation-filters
https://bugs.webkit.org/show_bug.cgi?id=109985
Reviewed by Dirk Schulze.
Source/WebCore:
The SVG spec defines the color-interpolation-filters property for all
filter effect elements in order to control cases where a color is
based on some arithmetic computation on other colors. For example,
when computing gradients or blending colors. feFlood simply fills a
region with the given color, and that given color is always defined to
be in sRGB space, so the feFlood result should always be sRGB.
The new behavior matches both Opera and Firefox.
Tests: svg/filters/feFlood-color-interpolation-expected.svg
svg/filters/feFlood-color-interpolation.svg
- platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::platformApplySoftware): Force the color mode to be
sRGB before returning.
LayoutTests:
New test for feFlood behavior when color-interpolation-filters is used.
Failing expectations for tests affected by this change.
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- svg/filters/feFlood-color-interpolation-expected.svg: Added.
- svg/filters/feFlood-color-interpolation.svg: Added.
- 3:00 PM Changeset in webkit [143266] by
-
- 2 edits in trunk/LayoutTests
Just skip the seamless iframe flowed into regions test on chromium. It's failing with a repaint issue.
- platform/chromium/TestExpectations:
- 2:38 PM Changeset in webkit [143265] by
-
- 2 edits in trunk/Source/WTF
Make HexNumber functions return 8-bit strings
https://bugs.webkit.org/show_bug.cgi?id=110152
Reviewed by Michael Saboff.
- wtf/HexNumber.h: (Internal): (WTF::Internal::hexDigitsForMode): (WTF::appendByteAsHex): (WTF::placeByteAsHexCompressIfPossible): (WTF::placeByteAsHex): (WTF::appendUnsignedAsHex): (WTF::appendUnsignedAsHexFixedSize): Use LChar everywhere.
- 2:31 PM Changeset in webkit [143264] by
-
- 15 edits2 adds in trunk/Source/WebCore
Introduced AbstractSQLStatement and AbstractSQLStatementBackend.
https://bugs.webkit.org/show_bug.cgi?id=110148.
Reviewed by Geoff Garen.
This is part of the webdatabase refactoring for webkit2.
- Also changed the frontend and backend to only refer to the abstract interface of each other.
No new tests.
- GNUmakefile.list.am:
- Modules/webdatabase/AbstractSQLStatement.h: Added.
(AbstractSQLStatement):
(WebCore::AbstractSQLStatement::~AbstractSQLStatement):
- Modules/webdatabase/AbstractSQLStatementBackend.h: Added.
(AbstractSQLStatementBackend):
(WebCore::AbstractSQLStatementBackend::~AbstractSQLStatementBackend):
- Modules/webdatabase/SQLStatement.cpp:
(WebCore::SQLStatement::setBackend):
- Modules/webdatabase/SQLStatement.h:
(SQLStatement):
- Modules/webdatabase/SQLStatementBackend.cpp:
(WebCore::SQLStatementBackend::create):
(WebCore::SQLStatementBackend::SQLStatementBackend):
(WebCore::SQLStatementBackend::frontend):
- Modules/webdatabase/SQLStatementBackend.h:
(SQLStatementBackend):
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverStatementCallback):
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::currentStatement):
(WebCore::SQLTransactionBackend::executeSQL):
- Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- 2:11 PM Changeset in webkit [143263] by
-
- 5 edits in trunk/Source/WebCore
BUILD FIX (r143230): Fix renamed header and implementation of -[WebAccessibilityObjectWrapper accessibilityPostedNotification:]
<http://webkit.org/b/110077>
Fixes the following build failures:
AccessibilityObjectIOS.mm:35:9: fatal error: 'AccessibilityObjectWrapperIOS.h' file not found
#import "AccessibilityObjectWrapperIOS.h"
1 error generated.
WebAccessibilityObjectWrapperIOS.mm:2051:35: error: use of undeclared identifier 'notificationString'; did you mean 'notificationType'?
if (AXNotificationCallback && notificationString)
~
notificationType
WebAccessibilityObjectWrapperIOS.mm:2049:81: note: 'notificationType' declared here
- (void)accessibilityPostedNotification:(WebCore::AXObjectCache::AXNotification)notificationType
WebAccessibilityObjectWrapperIOS.mm:2052:38: error: use of undeclared identifier 'notificationString'; did you mean 'notificationType'?
AXNotificationCallback(self, notificationString, AXPostedNotificationContext);
~
notificationType
WebAccessibilityObjectWrapperIOS.mm:2049:81: note: 'notificationType' declared here
- (void)accessibilityPostedNotification:(WebCore::AXObjectCache::AXNotification)notificationType
WebAccessibilityObjectWrapperIOS.mm:2052:38: error: cannot initialize a parameter of type 'NSString *' with an lvalue of type 'WebCore::AXObjectCache::AXNotification'
AXNotificationCallback(self, notificationString, AXPostedNotificationContext);
~
WebAccessibilityObjectWrapperIOS.mm:2049:81: error: conflicting parameter types in implementation of 'accessibilityPostedNotification:': 'NSString *' vs 'WebCore::AXObjectCache::AXNotification' [-Werror,-Wmismatched-parameter-types]
- (void)accessibilityPostedNotification:(WebCore::AXObjectCache::AXNotification)notificationType
WebAccessibilityObjectWrapperBase.h:48:53: note: previous definition is here
- (void)accessibilityPostedNotification:(NSString *)notificationName;
4 errors generated.
- accessibility/ios/AccessibilityObjectIOS.mm: Fix name of
included header.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
Fix implementation to match declaration.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
- accessibility/ios/AXObjectCacheIOS.mm:
- Clean up #endif comments.
- 1:52 PM Changeset in webkit [143262] by
-
- 6 edits in trunk/Source/WebKit2
StorageManager message handlers should take the connection
https://bugs.webkit.org/show_bug.cgi?id=110151
Reviewed by Andreas Kling.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC):
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessage):
- Scripts/webkit2/messages.py:
(sync_message_statement):
(generate_message_handler):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):
(WebKit::StorageManager::getValues):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- UIProcess/Storage/StorageManager.messages.in:
- 1:52 PM Changeset in webkit [143261] by
-
- 2 edits in trunk/LayoutTests
clear databases before running read-transactions-running-concurrently test
https://bugs.webkit.org/show_bug.cgi?id=110144
Reviewed by Nico Weber.
Otherwise, we might not have enough quota when running this tests and lots
of databases from previous tests are hanging around.
- storage/websql/read-transactions-running-concurrently.html:
- 1:44 PM Changeset in webkit [143260] by
-
- 6 edits in tags/Safari-537.31.3/Source
Merge <rdar://problem/12968169>
- 1:37 PM Changeset in webkit [143259] by
-
- 6 edits2 adds in trunk/Source/WebCore
EME: Add a CDMPrivate implementation using AVFoundation.
https://bugs.webkit.org/show_bug.cgi?id=109739
Reviewed by Eric Carlson.
Add a CDMPrivate implementation using AVFoundation, similar to the EME v1 implementation
in MediaPlayerPrivateAVFoundationObjC. This requires passing the AVAssetResourceLoadingRequest
from the MediaPlayerPrivateAVFoundationObjC instance to CDMSessionAVFoundation. To do so
without adding platform-specific API to MediaPlayer, add a static map from MediaPlayer ->
MediaPlayerPrivateAVFoundationObjC instances to be used to vend the AVAssetResourceLoadingRequest
to CDMSessionAVFoundation.
- Modules/encryptedmedia/CDM.cpp:
(WebCore::installedCDMFactories): Add the factory for CDMPrivateAVFoundation.
- Modules/encryptedmedia/CDM.h:
- Modules/encryptedmedia/CDMPrivateAVFoundation.h: Added.
(WebCore::CDMPrivateAVFoundation::create): Simple factory method.
(WebCore::CDMPrivateAVFoundation::~CDMPrivateAVFoundation): Simple virtual destructor.
(WebCore::CDMPrivateAVFoundation::cdm): Simple getter.
(WebCore::CDMPrivateAVFoundation::CDMPrivateAVFoundation): Simple constructor.
- Modules/encryptedmedia/CDMPrivateAVFoundation.mm: Added.
(WebCore::CDMSessionAVFoundation::~CDMSessionAVFoundation): Simple destructor.
(WebCore::CDMPrivateAVFoundation::supportsKeySytem): Check whether the given key system is supported.
(WebCore::CDMPrivateAVFoundation::supportsMIMEType): Check whether the given MIME type is supported.
(WebCore::CDMPrivateAVFoundation::createSession): Return a new CDMSessionAVFoundation.
(WebCore::CDMSessionAVFoundation::CDMSessionAVFoundation): Simple constructor.
(WebCore::CDMSessionAVFoundation::generateKeyRequest): Retrieve the AVAssetResourceLoadingRequest
from the MediaPlayer, and use it to generate a key request.
(WebCore::CDMSessionAVFoundation::releaseKeys): No-op.
(WebCore::CDMSessionAVFoundation::update): Add the passed in key to the AVAssetResourceLoadingRequest.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::playerToPrivateMap): Lazily instantiate static map.
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Register with the playerToPrivateMap.
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): Unregister from same.
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource): Also send keyNeeded event in ENCRYPTED_MEDIA_V2.
(WebCore::MediaPlayerPrivateAVFoundationObjC::extractKeyURIKeyIDAndCertificateFromInitData): Convert this
method from file-static to class static.
(WebCore::MediaPlayerPrivateAVFoundationObjC::takeRequestForPlayerAndKeyURI): Pull the AVAssetResourceLoadingRequest
from m_keyURIToRequestMap and return it, if present.
- 1:36 PM Changeset in webkit [143258] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API inside ewk_security_origin
https://bugs.webkit.org/show_bug.cgi?id=107923
Patch by Christophe Dumez <Christophe Dumez> on 2013-02-18
Reviewed by Alexey Proskuryakov.
Use C API inside ewk_security_origin instead of accessing
directly internal C++ classes, to avoid breaking API
layering.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::enterFullScreen):
- UIProcess/API/efl/ewk_security_origin.cpp:
(EwkSecurityOrigin::EwkSecurityOrigin):
- UIProcess/API/efl/ewk_security_origin_private.h:
(EwkSecurityOrigin::create):
(EwkSecurityOrigin):
- 1:25 PM Changeset in webkit [143257] by
-
- 3 edits2 adds in trunk
Fix scaling of tiled SVG backgrounds on high-dpi displays
https://bugs.webkit.org/show_bug.cgi?id=110047
Reviewed by Dirk Schulze.
Source/WebCore:
This patch fixes the scaling of SVG when used for drawing patterns. Tiled/patterend SVG
images are first drawn into an image buffer and then the image buffer is used to stamp
out tiles. Because it is a raster source, the size of the image buffer needs to
be scaled to the final resolution of the device. After scaling the image buffer, the
source rect and pattern transforms need to be adjusted so they align in device pixel
coordinates. This adjustment was not done before this patch, causing pixelated rendering.
Additionally, a FIXME has been added due to webkit.org/b/110065 and the image buffer
has been manually scaled (using "zoomedAndScaledContainerRect") instead of relying
on the ImageBuffer's resolutionScale parameter.
Test: svg/as-background-image/tiled-background-image.html
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
Note that fixing the FIXME does not change that the source rect and transform need
to be adjusted for page scale.
LayoutTests:
- svg/as-background-image/tiled-background-image-expected.html: Added.
- svg/as-background-image/tiled-background-image.html: Added.
- 1:20 PM Changeset in webkit [143256] by
-
- 7 edits8 adds in trunk
Make seamless iframes paginate properly in their enclosing document's pagination context.
https://bugs.webkit.org/show_bug.cgi?id=106125
<rdar://problem/12922720> Text in iframe is clipped while printing
Reviewed by Simon Fraser.
Added new tests in fast/multicol and fast/region.
Source/WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clampToStartAndEndRegions):
Don't clamp when the RenderView is the containing block of an object in a RenderFlowThread.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint):
Don't attempt any repaint container antics when we're in a seamless iframe, since the ancestor
document will actually do the handoff into the flow thread.
- rendering/RenderView.cpp:
(WebCore::enclosingSeamlessRenderer):
Heper function to test for an enclosing seamless iframe.
(WebCore::RenderView::addChild):
Subclass addChild on RenderView to properly set the inRenderFlowThread state for a seamless
child document so thta it will check regions.
(WebCore::RenderView::initializeLayoutState):
New helper method for setting up the initial layout state of a RenderView. If inside a seamless
paginated ancestor, set up the appropriate pagination information so the child document
knows about it. This method will expand to inherit info about line grids and exclusions eventually
also.
(WebCore::RenderView::layout):
Now calls initializeLayoutState to set up the layout state.
- rendering/RenderView.h:
(WebCore::RenderView::pageLogicalHeight):
(WebCore::RenderView::setPageLogicalHeight):
(RenderView):
Fix the type of the page logical height methods to be LayoutUnit instead of unsigned.
LayoutTests:
- fast/multicol/resources/ipad.jpg: Added.
- fast/multicol/resources/seamless.html: Added.
- fast/multicol/seamless-flowed-through-columns-expected.html: Added.
- fast/multicol/seamless-flowed-through-columns.html: Added.
- fast/regions/resources/ipad.jpg: Added.
- fast/regions/resources/seamless.html: Added.
- fast/regions/seamless-iframe-flowed-into-regions-expected.html: Added.
- fast/regions/seamless-iframe-flowed-into-regions.html: Added.
- 12:25 PM Changeset in webkit [143255] by
-
- 3 edits in tags/Safari-537.31.3/Source/WebKit2
Merged r143111. <rdar://problem/13205468>
- 12:25 PM Changeset in webkit [143254] by
-
- 2 edits in trunk/Source/WTF
Remove Vector::dataSlot(), it has no implementation
https://bugs.webkit.org/show_bug.cgi?id=109999
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-18
Reviewed by Andreas Kling.
VectorBufferBase does not implement any function bufferSlot().
The file only compiles because that part of the template is never
instantiated.
- wtf/Vector.h:
- 12:22 PM Changeset in webkit [143253] by
-
- 2 edits in tags/Safari-537.31.3/Source/WebKit2
Merged r143091. <rdar://problem/13212621>
- 12:19 PM Changeset in webkit [143252] by
-
- 4 edits1 copy in tags/Safari-537.31.3
Merged r143074. <rdar://problem/13216100>
- 12:15 PM Changeset in webkit [143251] by
-
- 8 edits in tags/Safari-537.31.3/Source/WebCore
Merged r142936. <rdar://problem/13210723>
- 12:08 PM Changeset in webkit [143250] by
-
- 2 edits in tags/Safari-537.31.3/Source/WebKit2
Merged r142836. <rdar://problem/13211893>
- 12:05 PM Changeset in webkit [143249] by
-
- 1 edit in tags/Safari-537.31.3/Source/WebCore/English.lproj/Localizable.strings
Update localizable strings.
- 11:29 AM Changeset in webkit [143248] by
-
- 2 edits in trunk/Source/WTF
Move ENABLE macros for WebCore out from Platform.h
https://bugs.webkit.org/show_bug.cgi?id=105735
Unreviewed, build fix when NETSCAPE_PLUGIN_API is disabled.
Enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH even if
NETSCAPE_PLUGIN_API is disabled (Qt, Efl, GTK, WX ports).
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-18
- wtf/FeatureDefines.h:
- 11:25 AM Changeset in webkit [143247] by
-
- 13 edits in trunk/Source
MIPS DFG implementation.
https://bugs.webkit.org/show_bug.cgi?id=101328
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-02-18
Reviewed by Oliver Hunt.
DFG implementation for MIPS.
Source/JavaScriptCore:
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::MIPSAssembler):
(JSC::MIPSAssembler::sllv):
(JSC::MIPSAssembler::movd):
(MIPSAssembler):
(JSC::MIPSAssembler::negd):
(JSC::MIPSAssembler::labelForWatchpoint):
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::vmov):
(JSC::MIPSAssembler::linkDirectJump):
(JSC::MIPSAssembler::maxJumpReplacementSize):
(JSC::MIPSAssembler::revertJumpToMove):
(JSC::MIPSAssembler::replaceWithJump):
- assembler/MacroAssembler.h:
(MacroAssembler):
(JSC::MacroAssembler::poke):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::add32):
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::lshift32):
(JSC::MacroAssemblerMIPS::mul32):
(JSC::MacroAssemblerMIPS::or32):
(JSC::MacroAssemblerMIPS::rshift32):
(JSC::MacroAssemblerMIPS::urshift32):
(JSC::MacroAssemblerMIPS::sub32):
(JSC::MacroAssemblerMIPS::xor32):
(JSC::MacroAssemblerMIPS::store32):
(JSC::MacroAssemblerMIPS::jump):
(JSC::MacroAssemblerMIPS::branchAdd32):
(JSC::MacroAssemblerMIPS::branchMul32):
(JSC::MacroAssemblerMIPS::branchSub32):
(JSC::MacroAssemblerMIPS::branchNeg32):
(JSC::MacroAssemblerMIPS::call):
(JSC::MacroAssemblerMIPS::loadDouble):
(JSC::MacroAssemblerMIPS::moveDouble):
(JSC::MacroAssemblerMIPS::swapDouble):
(JSC::MacroAssemblerMIPS::subDouble):
(JSC::MacroAssemblerMIPS::mulDouble):
(JSC::MacroAssemblerMIPS::divDouble):
(JSC::MacroAssemblerMIPS::negateDouble):
(JSC::MacroAssemblerMIPS::branchEqual):
(JSC::MacroAssemblerMIPS::branchNotEqual):
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToUint32):
(JSC::MacroAssemblerMIPS::truncateDoubleToInt32):
(JSC::MacroAssemblerMIPS::truncateDoubleToUint32):
(JSC::MacroAssemblerMIPS::branchDoubleNonZero):
(JSC::MacroAssemblerMIPS::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerMIPS::invert):
(JSC::MacroAssemblerMIPS::replaceWithJump):
(JSC::MacroAssemblerMIPS::maxJumpReplacementSize):
- dfg/DFGAssemblyHelpers.h:
(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::preserveReturnAddressAfterCall):
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
(JSC::DFG::AssemblyHelpers::debugCall):
- dfg/DFGCCallHelpers.h:
(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArguments):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
- dfg/DFGFPRInfo.h:
(DFG):
(FPRInfo):
(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::toIndex):
(JSC::DFG::FPRInfo::debugName):
- dfg/DFGGPRInfo.h:
(DFG):
(GPRInfo):
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- jit/JSInterfaceJIT.h:
(JSInterfaceJIT):
- runtime/JSGlobalData.h:
(JSC::ScratchBuffer::allocationSize):
(ScratchBuffer):
Source/WTF:
- wtf/Platform.h:
- 11:16 AM Changeset in webkit [143246] by
-
- 4 edits in tags/Safari-537.31.3/Source
Versioning.
- 11:13 AM Changeset in webkit [143245] by
-
- 1 copy in tags/Safari-537.31.3
New Tag.
- 11:07 AM Changeset in webkit [143244] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r143145.
http://trac.webkit.org/changeset/143145
https://bugs.webkit.org/show_bug.cgi?id=110143
Causes frequent crashes. (Requested by eric_carlson on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-18
- dom/EventDispatchMediator.cpp:
(WebCore::EventDispatchMediator::dispatchEvent):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::ensureEventPath):
(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::dispatchEventPreProcess):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventDispatcher.h:
(EventDispatcher):
(WebCore::EventDispatcher::node):
(WebCore):
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
- dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::dispatchEvent):
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
- 11:01 AM Changeset in webkit [143243] by
-
- 2 edits in trunk/Source/WebCore
[Soup] Free cookies explicitly in loops instead of using GOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=110103
Reviewed by Martin Robinson.
Free cookies explicitly in loops instead of using GOwnPtr for this.
Until now, the code was mixing both styles. This patch makes the
code consistent one way. Adopting list items with GOwnPtr for the
sole purpose to free them makes the freeing less obvious and may
lead to mistakes if someone refactors the code and calls "break;"
to abort loop iteration.
No new tests, no behavior change.
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
- 10:43 AM Changeset in webkit [143242] by
-
- 7 edits in trunk/Source/JavaScriptCore
DFG::SpeculativeJIT::isKnownXYZ methods should use CFA rather than other things
https://bugs.webkit.org/show_bug.cgi?id=110092
Reviewed by Geoffrey Garen.
These methods were previously using GenerationInfo and other things to try to
gain information that the CFA could give away for free, if you asked kindly
enough.
Also fixed CallLinkStatus's dump() method since it was making an invalid
assertion: we most certainly can have a status where the structure is non-null
and the executable is null, like if we're dealing with an InternalFunction.
Also removed calls to isKnownNotXYZ from fillSpeculateABC methods in 32_64. I
don't know why that was there. But it was causing asserts if the value was
empty - i.e. we had already exited unconditionally but we didn't know it. I
could have fixed this by introducing another form of isKnownNotXYZ which was
tolerant of empty values, but I didn't feel like fixing code that I knew to be
unnecessary. (More deeply, isKnownNotCell, for example, really asks: "do you
know that this value can never be a cell?" while some of the previous uses
wanted to ask: "do you know that this is a value that is not a cell?". The
former is "true" if the value is a contradiction [i.e. BOTTOM], while the
latter is "false" for contradictions, since contradictions are not values.)
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::dump):
- bytecode/CallLinkStatus.h:
(JSC::CallLinkStatus::CallLinkStatus):
- dfg/DFGSpeculativeJIT.cpp:
(DFG):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotInteger):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::isKnownNotCell):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
- dfg/DFGStructureAbstractValue.h:
(JSC::DFG::StructureAbstractValue::dump):
- 10:40 AM Changeset in webkit [143241] by
-
- 11 edits3 adds in trunk
Get rid of DFG::DoubleOperand and simplify ValueToInt32
https://bugs.webkit.org/show_bug.cgi?id=110072
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
ValueToInt32 had a side-effecting path, which was not OSR-friendly: an OSR after
the side-effect would lead to the side-effect re-executing. I got rid of that path
and replaced it with an optimization for the case where the input is speculated
number-or-other. This makes idioms like null|0 and true|0 work as expected, and
get optimized appropriately.
Also got rid of DoubleOperand. Replaced all remaining uses of it with
SpeculateDoubleOperand. Because the latter asserts that the Edge is a DoubleUse
edge and the remaining uses of DoubleOperand are all for untyped uses, I worked
around the assertion by setting the UseKind to DoubleUse by force. This is sound,
since all existing assertions for DoubleUse are actually asserting that we're not
converting a value to double unexpectedly. But all of these calls to
SpeculateDoubleOperand are when the operand is already known to be represented as
double, so there is no conversion.
This is neutral on benchmarks, except stanford-crypto-ccm, which speeds up a
little. Mostly, this is intended to delete a bunch of code. DoubleOperand was
equivalent to the replace-edge-with-DoubleUse trick that I'm using now, except it
involved a _lot_ more code.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGSpeculativeJIT.cpp:
(DFG):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(DFG):
(FPRTemporary):
- dfg/DFGSpeculativeJIT32_64.cpp:
(DFG):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(DFG):
LayoutTests:
Reviewed by Geoffrey Garen.
- fast/js/dfg-value-to-int32-with-side-effect-expected.txt: Added.
- fast/js/dfg-value-to-int32-with-side-effect.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-value-to-int32-with-side-effect.js: Added.
(foo):
(.result.foo):
- 10:33 AM Changeset in webkit [143240] by
-
- 5 edits in trunk
[JSC]: ASSERT in KURL(ParsedURLStringTag) under sourceMapURLForScript
https://bugs.webkit.org/show_bug.cgi?id=109987
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-02-18
Reviewed by Pavel Feldman.
Source/WebCore:
Improved an existing test to cover this.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
Remove the sourceURL parsing and script.url replacement from the JSC
implementation of ScriptDebugServer. The WebCore inspector code that
this was added for already does this, at a more appropriate time.
LayoutTests:
- inspector/debugger/source-url-comment-expected.txt:
- inspector/debugger/source-url-comment.html:
Add a test for a sourceURL with a non-relative path. This was causing
an ASSERT, rightfully so, in JSC builds.
- 10:21 AM Changeset in webkit [143239] by
-
- 3 edits2 adds in trunk
compareDocumentPosition reports disconnected nodes as following each other
https://bugs.webkit.org/show_bug.cgi?id=108274
Reviewed by Dimitri Glazkov.
Source/WebCore:
jQuery has had to implement their own sorting mechanism in Sizzle[1] due
to Node::compareDocumentPosition always reporting disconnected nodes
as following each other. According to spec[2], we should instead be
indicating that the result is (a) disconnected, (b) implementation
specific, and (c) deterministically ordered.
[1]: https://github.com/jquery/sizzle/commit/1c8aec91284af8d8c14447976235d5dd72b0d75e
[2]: http://dom.spec.whatwg.org/#dom-node-comparedocumentposition
Test: fast/dom/compare-document-position-disconnected-nodes.html
- dom/Node.cpp:
(WebCore::Node::compareDocumentPosition):
After walking the parentNode chain of both Nodes, compare the root.
If the Nodes don't share a root, they're in distinct trees, and
should return as described above. We determine which element
"preceeds" the other in an arbitrary fashion via pointer comparison.
LayoutTests:
- fast/dom/compare-document-position-disconnected-nodes-expected.txt: Added.
- fast/dom/compare-document-position-disconnected-nodes.html: Added.
- 10:06 AM Changeset in webkit [143238] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
Update test expectations for recent failures.
- platform/chromium/TestExpectations:
- 9:45 AM Changeset in webkit [143237] by
-
- 5 edits in trunk
Web Inspector: [Canvas] fix replay log grouping by frames
https://bugs.webkit.org/show_bug.cgi?id=110122
Reviewed by Pavel Feldman.
Source/WebCore:
Bug: log grouping by frames did not work if a frame end call is not a draw call.
Drive-by: Last draw call group may not contain a draw call. In this case merge it into the previous group.
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype._appendCallNode):
(WebInspector.CanvasProfileView.prototype._maybeMergeLastDrawCallGroups):
LayoutTests:
Canvas replay test: last command is not a draw call.
- inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt:
- inspector/profiler/canvas2d/canvas-replay-log-grid.html:
- 9:42 AM Changeset in webkit [143236] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
Fix test expectations for effect-reference* tests which I messed up
in my last commit.
- platform/chromium/TestExpectations:
- 9:33 AM Changeset in webkit [143235] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Mountain Lion buildfix after r143147.
Reviewed by Csaba Osztrogonác.
- runtime/DateConstructor.cpp:
- 9:19 AM Changeset in webkit [143234] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Moved WK1 specific failures from the shared TestExpectations file
to the wk1 one. Also removed some tests from the WK2
TestExpectations file as they have been consistently passing on
bots.
- platform/gtk-wk1/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 9:19 AM Changeset in webkit [143233] by
-
- 2 edits in trunk/Source/WebCore
[Soup] Superfluous HashMap check in SocketStreamHandleSoup::getHandleFromId()
https://bugs.webkit.org/show_bug.cgi?id=110107
Reviewed by Martin Robinson.
Remove Superfluous HashMap::contains() call in SocketStreamHandleSoup::getHandleFromId()
as HashMap::get() will already return 0 in this case anyway.
No new tests, no behavior change.
- platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore):
(WebCore::getHandleFromId):
- 9:13 AM Changeset in webkit [143232] by
-
- 66 edits in trunk/Source
Stop placing std::isfinite and std::signbit inside the global scope
https://bugs.webkit.org/show_bug.cgi?id=109817
Reviewed by Darin Adler.
Prefix calls to the isfinite and signbit methods with std:: as the two
methods are no longer being imported into the global scope.
Source/JavaScriptCore:
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlindDouble):
- offlineasm/cloop.rb:
- runtime/BigInteger.h:
(JSC::BigInteger::BigInteger):
- runtime/DateConstructor.cpp:
(JSC::constructDate):
- runtime/DatePrototype.cpp:
(JSC::fillStructuresUsingTimeArgs):
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncSetYear):
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::JSValue):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncIsFinite):
- runtime/JSONObject.cpp:
(JSC::Stringifier::appendStringifiedValue):
- runtime/MathObject.cpp:
(JSC::mathProtoFuncMax): Also include an opportunistic style fix.
(JSC::mathProtoFuncMin): Ditto.
- runtime/NumberPrototype.cpp:
(JSC::toStringWithRadix):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):
- runtime/Uint16WithFraction.h:
(JSC::Uint16WithFraction::Uint16WithFraction):
Source/WebCore:
No new tests as there's no change in functionality.
- bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2D::setWebkitLineDash):
- bindings/js/JSDOMBinding.cpp:
(WebCore::jsDateOrNull):
- bindings/js/JSDOMBinding.h:
(WebCore::finiteInt32Value):
- bindings/v8/V8Binding.h:
(WebCore::v8DateOrNull):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::parseToNumber):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValueAsNumber):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::setMin):
(WebCore::HTMLMeterElement::setMax):
(WebCore::HTMLMeterElement::setValue):
(WebCore::HTMLMeterElement::setLow):
(WebCore::HTMLMeterElement::setHigh):
(WebCore::HTMLMeterElement::setOptimum):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::value):
(WebCore::HTMLProgressElement::setValue):
(WebCore::HTMLProgressElement::max):
(WebCore::HTMLProgressElement::setMax):
- html/MonthInputType.cpp:
(WebCore::MonthInputType::valueAsDate):
(WebCore::MonthInputType::defaultValueForStepUp):
(WebCore::MonthInputType::parseToNumber):
- html/NumberInputType.cpp:
(WebCore::NumberInputType::typeMismatchFor):
(WebCore::NumberInputType::sanitizeValue):
(WebCore::NumberInputType::hasBadInput):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::typeMismatchFor):
- html/TimeInputType.cpp:
(WebCore::TimeInputType::defaultValueForStepUp):
- html/canvas/CanvasPathMethods.cpp:
(WebCore::CanvasPathMethods::moveTo):
(WebCore::CanvasPathMethods::lineTo):
(WebCore::CanvasPathMethods::quadraticCurveTo):
(WebCore::CanvasPathMethods::bezierCurveTo):
(WebCore::CanvasPathMethods::arcTo):
(WebCore::CanvasPathMethods::arc):
(WebCore::CanvasPathMethods::rect):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setLineWidth):
(WebCore::CanvasRenderingContext2D::setMiterLimit):
(WebCore::CanvasRenderingContext2D::setShadowOffsetX):
(WebCore::CanvasRenderingContext2D::setShadowOffsetY):
(WebCore::CanvasRenderingContext2D::setShadowBlur):
(WebCore::lineDashSequenceIsValid):
(WebCore::CanvasRenderingContext2D::setLineDashOffset):
(WebCore::CanvasRenderingContext2D::scale):
(WebCore::CanvasRenderingContext2D::rotate):
(WebCore::CanvasRenderingContext2D::translate):
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):
(WebCore::validateRectForCanvas):
(WebCore::CanvasRenderingContext2D::isPointInPath):
(WebCore::CanvasRenderingContext2D::isPointInStroke):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::createLinearGradient):
(WebCore::CanvasRenderingContext2D::createRadialGradient):
(WebCore::CanvasRenderingContext2D::createImageData):
(WebCore::CanvasRenderingContext2D::getImageData):
(WebCore::CanvasRenderingContext2D::putImageData):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- html/parser/HTMLParserIdioms.cpp:
(WebCore::parseToDoubleForNumberType):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTimelineElement::setDuration):
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::reset):
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::reset):
- html/shadow/MediaControlsBlackBerry.cpp:
(WebCore::MediaControlFullscreenTimelineElement::setDuration):
(WebCore::MediaControlsBlackBerry::reset):
- inspector/InspectorValues.cpp:
(WebCore::InspectorBasicValue::writeJSON):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::currentAge):
(WebCore::CachedResource::freshnessLifetime):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::adjustWindowRect):
- platform/DateComponents.cpp:
(WebCore::DateComponents::setMillisecondsSinceEpochForDate):
(WebCore::DateComponents::setMillisecondsSinceEpochForDateTime):
(WebCore::DateComponents::setMillisecondsSinceEpochForMonth):
(WebCore::DateComponents::setMillisecondsSinceMidnight):
(WebCore::DateComponents::setMonthsSinceEpoch):
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):
- platform/Decimal.cpp:
(WebCore::Decimal::fromDouble):
- platform/FileSystem.h:
(WebCore::isValidFileTime):
- platform/LocalizedStrings.cpp:
(WebCore::localizedMediaTimeDescription):
- platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::drawPatternToCairoContext):
- platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::addArc):
(WebCore::Path::contains):
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::addArc):
- platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.cpp:
(WebCore::FullscreenVideoControllerGStreamer::timeToString):
- platform/graphics/openvg/PathOpenVG.cpp:
(WebCore::Path::addArc):
- platform/graphics/skia/SkiaUtils.h:
(WebCore::WebCoreFloatToSkScalar):
(WebCore::WebCoreDoubleToSkScalar):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::maxTimeSeekable):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaTimeDescription):
- platform/mac/WebVideoFullscreenHUDWindowController.mm:
(timeToString):
- platform/network/ResourceResponseBase.cpp:
(WebCore::parseDateValueInHeader):
- platform/qt/LocalizedStringsQt.cpp:
(WebCore::localizedMediaTimeDescription):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::formatChromiumMediaControlsTime):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::formatMediaControlsTime):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setFontSize):
- svg/SVGPathParser.cpp:
(WebCore::SVGPathParser::decomposeArcToCubic):
- xml/XPathFunctions.cpp:
(WebCore::XPath::FunRound::round):
- xml/XPathValue.cpp:
(WebCore::XPath::Value::toString):
Source/WebKit/win:
- FullscreenVideoController.cpp:
(timeToString):
Source/WTF:
On Solaris and OpenBSD platforms or when using Visual C++ the two methods
are now defined (as incompatibility workarounds) inside the std namespace.
- wtf/DateMath.cpp:
(WTF::timeClip):
- wtf/DecimalNumber.h:
(WTF::DecimalNumber::DecimalNumber):
- wtf/MathExtras.h:
(std):
(std::isfinite):
(std::signbit):
(lrint):
(wtf_pow):
(decomposeDouble):
- wtf/MediaTime.cpp:
(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):
- wtf/dtoa.cpp:
(WTF::dtoa):
- 9:08 AM Changeset in webkit [143231] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Mountain Lion buildfix after r143147.
Reviewed by Csaba Osztrogonác.
- runtime/DateInstance.cpp:
- 9:06 AM Changeset in webkit [143230] by
-
- 3 edits2 moves in trunk/Source/WebCore
AX: Make iOS wrapper use the WebAccessibilityObjectBase wrapper
https://bugs.webkit.org/show_bug.cgi?id=110077
Reviewed by David Kilzer.
Make the iOS wrapper a subclass of the shared wrapper so that iOS can re-use code from the Mac.
Rename the iOS file to reflect the class name.
- WebCore.xcodeproj/project.pbxproj:
- accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/ios/AccessibilityObjectWrapperIOS.h: Removed.
- accessibility/ios/AccessibilityObjectWrapperIOS.mm: Removed.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.h: Copied from Source/WebCore/accessibility/ios/AccessibilityObjectWrapperIOS.h.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: Copied from Source/WebCore/accessibility/ios/AccessibilityObjectWrapperIOS.mm.
(-[WebAccessibilityObjectWrapper initWithAccessibilityObject:]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:WebCore::AXObjectCache::]):
- 9:06 AM Changeset in webkit [143229] by
-
- 2 edits in trunk/Tools
Unreviewed GTK gardening.
- Scripts/run-gtk-tests:
(TestRunner): Skipped the ReloadPageAfterCrash unit test as it is flakily timing out.
- 9:04 AM Changeset in webkit [143228] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r143210.
http://trac.webkit.org/changeset/143210
https://bugs.webkit.org/show_bug.cgi?id=110128
Still causing some test timeouts (Requested by anttik on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-18
- platform/SharedTimer.h:
(SharedTimer):
(WebCore):
(WebCore::MainThreadSharedTimer::stop):
- platform/ThreadTimers.cpp:
(WebCore::ThreadTimers::fireTimersInNestedEventLoop):
- platform/mac/SharedTimerMac.mm:
(WebCore):
(WebCore::PowerObserver::restartSharedTimer):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):
- 8:54 AM Changeset in webkit [143227] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Disable hiding the debugger when it is below the source code
https://bugs.webkit.org/show_bug.cgi?id=110106
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-18
Reviewed by Pavel Feldman.
When the "Split horizontally" option is checked in the Sources panel the button responsible for the sidebar
visibility is hidden and the sidebar is force-shown. Also set the "Split sidebar" option default to true.
No new tests.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
- inspector/front-end/scriptsPanel.css:
(.split-view-horizontal #scripts-debug-sidebar-resizer-widget):
- 8:49 AM Changeset in webkit [143226] by
-
- 3 edits in trunk/Source/WebKit2
pinch-zooming webpage messes up full-screening of embedded video
https://bugs.webkit.org/show_bug.cgi?id=106115
Reviewed by Maciej Stachowiak.
Reset the page scale when entering full screen, and reset to the original scale when exiting.
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
- 8:48 AM Changeset in webkit [143225] by
-
- 6 edits2 adds in trunk
[CSS Exclusions] Support outside-shape layout for shape-inside property
https://bugs.webkit.org/show_bug.cgi?id=102571
Reviewed by David Hyatt.
Source/WebCore:
A shape-inside value of 'outside-shape' should resolve to the value of
the shape-outside property for layout. This patch introduces a helper
method to resolve shape-inside in RenderStyle, and replaces calls to
RenderStyle::shapeInside() when the resolved (layout) value should be
used.
Test: fast/exclusions/shape-inside/shape-inside-outside-shape.html
- rendering/ExclusionShapeInfo.cpp:
(WebCore::::computedShape): Use the resolved shape-inside getter.
- rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Ditto.
(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo): Ditto.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange): Ditto.
(WebCore::RenderBlock::exclusionShapeInsideInfo): Ditto.
- rendering/style/RenderStyle.h: Add the resolved shape inside getter.
LayoutTests:
Test that the shape-outside value correctly propagates to shape-inside
when shape-inside has a value of 'outside-shape,' using both an
undefined and a simple shape outside value.
- fast/exclusions/shape-inside/shape-inside-outside-shape-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-outside-shape.html: Added.
- 8:41 AM Changeset in webkit [143224] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: hide vertical-sidebar-split in dock-to-right mode behind single experimental flag.
https://bugs.webkit.org/show_bug.cgi?id=110119
Reviewed by Vsevolod Vlasov.
Removed context menus, made it toggle automatically upon dock orientation change.
- inspector/front-end/DockController.js:
(WebInspector.DockController.prototype._toggleDockState):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._sidebarContextMenuEventFired):
(WebInspector.ElementsPanel.prototype._dockSideChanged):
(WebInspector.ElementsPanel.prototype._setVerticalSplit):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._dockSideChanged):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/inspector.css:
- inspector/front-end/scriptsPanel.css:
(#scripts-sidebar-stack-pane):
(div.sidebar-pane-stack#scripts-debug-sidebar-contents):
- inspector/front-end/tabbedPane.css:
(.tabbed-pane):
- 8:34 AM Changeset in webkit [143223] by
-
- 4 edits in trunk
[GTK] Fix nits for configuration
https://bugs.webkit.org/show_bug.cgi?id=110083
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-18
Reviewed by Martin Robinson.
.:
Remove unicode backend printing option. The only backend for unicode is icu
after changeset 142724.
- Source/autotools/PrintBuildConfiguration.m4:
Source/WebCore:
Remove trailing white space. It has caused annoying warning while configuration.
No new tests since no funtionality change.
- GNUmakefile.list.am:
- 8:29 AM Changeset in webkit [143222] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adjusting failure expectation for an inspector
test which now times out.
- 8:17 AM Changeset in webkit [143221] by
-
- 2 edits in trunk/Tools
[Qt][WK2] Remove duped test name and append new test in project file
https://bugs.webkit.org/show_bug.cgi?id=110117
A new WK2 API test has landed recently (ResizeWindowAfterCrash), this patch will
add this test into the runnable test suite and remove a duped test in project file.
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-18
Reviewed by Jocelyn Turcotte.
- TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
- 8:15 AM Changeset in webkit [143220] by
-
- 18 edits in trunk/Source/WebCore
[WebGL][EFL] Refactor GraphicsContext3DPrivate to add support for SharedContext.
https://bugs.webkit.org/show_bug.cgi?id=109988
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-18
Reviewed by Kenneth Rohde Christiansen.
Covered by existing WebGL tests.
This patch refactors PlatformContext and GraphicsContext3DPrivate to
add support for Shared Context. This would help share GL resources
between transport surface and offscreen surface without having to worry
about the context state. So far, we used the same drawable as transport
surface and offscreen surface. After this patch we use pixmap surface as
offscreen surface and use shared context to render texture content to
transport surface. This would also align as to how shared surface is implemented
on EFL and Qt ports.
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::makeSharedContextCurrent):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
- platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- platform/graphics/opengl/GLPlatformContext.cpp:
(WebCore::GLPlatformContext::initialize):
- platform/graphics/opengl/GLPlatformContext.h:
Needed changes to take shared context into use.
- platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::createOffScreenSurface):
(WebCore::GLPlatformSurface::updateContents):
- platform/graphics/opengl/GLPlatformSurface.h:
(GLPlatformSurface):
- platform/graphics/surfaces/glx/GLXConfigSelector.h:
(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::visualInfo):
(WebCore::GLXConfigSelector::pixmapContextConfig):
(GLXConfigSelector):
(WebCore::GLXConfigSelector::reset):
- platform/graphics/surfaces/glx/GLXContext.cpp:
Added support to query configiration supporting
pixmap surface.
(WebCore::GLXOffScreenContext::initialize):
- platform/graphics/surfaces/glx/GLXContext.h:
(GLXOffScreenContext):
- platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::swapBuffers):
(WebCore::GLXOffScreenSurface::GLXOffScreenSurface):
(WebCore::GLXOffScreenSurface::~GLXOffScreenSurface):
(WebCore::GLXOffScreenSurface::initialize):
(WebCore::GLXOffScreenSurface::configuration):
(WebCore::GLXOffScreenSurface::destroy):
(WebCore::GLXOffScreenSurface::freeResources):
(WebCore::GLXOffScreenSurface::setGeometry):
Renamed GLXPBuffer surface as GLXOffScreenSurface.
- platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXOffScreenSurface):
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::createSurface):
- platform/graphics/surfaces/glx/X11Helper.cpp:
(WebCore::X11Helper::createPixmap):
(WebCore):
(WebCore::X11Helper::destroyPixmap):
(WebCore::X11Helper::createOffScreenWindow):
- platform/graphics/surfaces/glx/X11Helper.h:
(X11Helper):
Added functions to create and destroy pixmap.
- 8:14 AM Changeset in webkit [143219] by
-
- 2 edits in trunk/Websites/webkit.org
Add Digia to the domain affiliations
https://bugs.webkit.org/show_bug.cgi?id=110116
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2013-02-18
Reviewed by Kenneth Rohde Christiansen.
- team.html:
- 7:46 AM Changeset in webkit [143218] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: Native Memory Instrumentation: Generate meta information for HeapSnapshot parser.
https://bugs.webkit.org/show_bug.cgi?id=110104
Reviewed by Yury Semikhatsky.
The format of Native heap snapshot is slightly different so it should provide its own meta information.
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::finish):
(WebCore::HeapGraphSerializer::reportMemoryUsage):
(WebCore::HeapGraphSerializer::registerTypeString):
(WebCore):
- inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
- inspector/Inspector.json:
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):
- inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildPostOrderIndex):
- inspector/front-end/NativeHeapSnapshot.js:
(WebInspector.NativeHeapSnapshot):
- 7:40 AM Changeset in webkit [143217] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r183105. Requested by
thakis_ via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-18
- DEPS:
- 7:33 AM Changeset in webkit [143216] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove ahem_path from WebKit.gyp
https://bugs.webkit.org/show_bug.cgi?id=110111
Reviewed by Jochen Eisinger.
It's only used in DumpRenderTree.gyp, and that file defines its own
copy of this variable.
- WebKit.gyp:
- 7:32 AM Changeset in webkit [143215] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Unreviewed. Add myself to committers list.
- 7:32 AM Changeset in webkit [143214] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark perf/show-hide-table-rows.html as sometimes failing or slow
on EFL port.
- platform/efl/TestExpectations:
- 6:47 AM Changeset in webkit [143213] by
-
- 2 edits in trunk/Tools
[chromium] remove log spew from dumpAllBackForwardLists
https://bugs.webkit.org/show_bug.cgi?id=110108
Reviewed by Nico Weber.
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
- 6:45 AM Changeset in webkit [143212] by
-
- 18 edits in trunk/Source/WebCore
[GTK] Force single header includes in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=104676
Reviewed by Xan Lopez.
Only including <webkitdom/webkitdom.h> should be allowed from
apps.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateHeader):
- bindings/scripts/gobject-generate-headers.pl:
- bindings/scripts/test/GObject/WebKitDOMFloat64Array.h:
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
- bindings/scripts/test/GObject/WebKitDOMTestException.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
- bindings/scripts/test/GObject/WebKitDOMTestNode.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- 6:35 AM Changeset in webkit [143211] by
-
- 10 edits1 add in trunk/Source
Move ENABLE macros for WebCore out from Platform.h
https://bugs.webkit.org/show_bug.cgi?id=105735
Source/WebKit/chromium:
Move the chromium specific WebCore ENABLE macro definitions
from Platform.h to features.gypi.
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-18
Reviewed by Darin Adler and Benjamin Poulain.
- features.gypi: Set ENABLE_SUBPIXEL_LAYOUT to 1.
Source/WTF:
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-18
Reviewed by Darin Adler and Benjamin Poulain.
Introduce FeatureDefines.h by combining the existing rules from
Platform.h and adding new rules for all the ENABLE flags that are
listed in the FeatureFlags wiki.
The new rules are not used at the moment by any ports
as the port specific build systems already define these flags
so the !defined() guard will prevent redefinition of the macros.
- GNUmakefile.list.am: Add FeatureDefines.h.
- WTF.gypi: Ditto.
- WTF.pro: Ditto.
- WTF.vcproj/WTF.vcproj: Ditto.
- WTF.xcodeproj/project.pbxproj: Ditto.
- wtf/CMakeLists.txt: Ditto.
- wtf/FeatureDefines.h: Added.
- wtf/Platform.h: Move macro definitions to FeatureDefines.h.
- 6:28 AM Changeset in webkit [143210] by
-
- 4 edits in trunk/Source/WebCore
Reschedule shared CFRunLoopTimer instead of reconstructing it
https://bugs.webkit.org/show_bug.cgi?id=109765
Reviewed by Andreas Kling.
Using CFRunLoopTimerSetNextFireDate is over 2x faster than deleting and reconstructing timers.
- platform/SharedTimer.h:
(WebCore::SharedTimer::willEnterNestedEventLoop):
(WebCore):
(MainThreadSharedTimer):
(WebCore::MainThreadSharedTimer::willEnterNestedEventLoop):
- platform/ThreadTimers.cpp:
(WebCore::ThreadTimers::fireTimersInNestedEventLoop):
- platform/mac/SharedTimerMac.mm:
(WebCore):
(WebCore::PowerObserver::clearSharedTimer):
(WebCore::ensurePowerObserver):
(WebCore::sharedTimer):
(WebCore::reinsertSharedTimer):
Before entering nested runloop (used for inspector debugger mostly) reconstruct and reinsert the timer. For some reason
the timer doesn't fire otherwise.
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):
- 6:10 AM Changeset in webkit [143209] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Resources] Only remember the tree element selection if explicitly made by user
https://bugs.webkit.org/show_bug.cgi?id=110105
Reviewed by Pavel Feldman.
This change instructs the Resources panel to remember the selected tree element only if it has been
selected by the user (not automatically, like selecting a parent when its child is removed).
All onselect() overrides pass the selectedByUser argument value
to BaseStorageTreeElement.prototype.onselect.
Drive-by: Use === comparisons everywhere.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._reset): Do not detach [immutable] category views.
(WebInspector.BaseStorageTreeElement.prototype.onselect): Remember itemURL on user gesture only.
(WebInspector.StorageCategoryTreeElement.prototype.onselect):
(WebInspector.FrameTreeElement.prototype.onselect):
(WebInspector.FrameResourceTreeElement.prototype.onselect):
(WebInspector.DatabaseTreeElement.prototype.onselect):
(WebInspector.DatabaseTableTreeElement.prototype.onselect):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement.prototype.onselect):
(WebInspector.IDBIndexTreeElement.prototype.onselect):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.onselect):
(WebInspector.CookieTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.onselect):
(WebInspector.FileSystemTreeElement.prototype.onselect):
(WebInspector.FileSystemTreeElement.prototype.clear):
(WebInspector.ResourcesSearchController.prototype.nextSearchResult):
- 6:03 AM Changeset in webkit [143208] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark fast/dom/shadow/shadow-dom-event-dispatching-distributed-child.html as
failing on EFL port. The test was introduced in r143191.
- platform/efl/TestExpectations:
- 6:01 AM Changeset in webkit [143207] by
-
- 4 edits in trunk
Web Inspector: Color picker should not be available in Computed Styles pane
https://bugs.webkit.org/show_bug.cgi?id=109697
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-18
Reviewed by Pavel Feldman.
Source/WebCore:
Refactored PropertiesSection and TreeElement inheritors in StylesSidebarPane.js for cleaner separation
of read-only and editable properties.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.BlankStylePropertiesSection):
(WebInspector.StylePropertyTreeElementBase):
(WebInspector.StylePropertyTreeElementBase.prototype.node):
(WebInspector.StylePropertyTreeElementBase.prototype.editablePane):
(WebInspector.StylePropertyTreeElementBase.prototype.onattach):
(WebInspector.StylePropertyTreeElementBase.prototype.updateTitle.linkifyURL):
(WebInspector.StylePropertyTreeElementBase.prototype.updateTitle.):
(WebInspector.StylePropertyTreeElementBase.prototype):
(.event):
(.isRevert):
LayoutTests:
- inspector/styles/undo-add-property.html:
- 5:45 AM Changeset in webkit [143206] by
-
- 9 edits in trunk
Web Inspector: [Canvas] group replay log calls by frames
https://bugs.webkit.org/show_bug.cgi?id=110101
Reviewed by Pavel Feldman.
Source/WebCore:
Group canvas replay log by frames, then by draw calls.
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
- inspector/Inspector.json:
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype._appendCallNode):
(WebInspector.CanvasProfileView.prototype._appendDrawCallGroup):
LayoutTests:
- inspector/profiler/canvas-profiler-test.js:
- inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt:
- inspector/profiler/canvas2d/canvas-replay-log-grid.html:
- inspector/profiler/canvas2d/canvas-stack-trace-expected.txt:
- 5:35 AM Changeset in webkit [143205] by
-
- 1 edit1 delete in trunk/LayoutTests
[Qt] Deleted extraneous file. It has been added accidentally in r142135.
https://bugs.webkit.org/show_bug.cgi?id=109953.
- platform/qt-5.0-wk2/TestExpectations.orig: Removed.
- 5:29 AM Changeset in webkit [143204] by
-
- 2 edits in trunk/Source/WebCore
[Soup] CookieJarSoup::deleteCookie() should stop looking for the cookie after it is removed
https://bugs.webkit.org/show_bug.cgi?id=110100
Reviewed by Kenneth Rohde Christiansen.
CookieJarSoup::deleteCookie() retrieves the list of cookies that apply to a given URL, then
iterates through the cookies to find the one with the right name and delete it. However, the
current implementation keeps on comparing cookie names after the cookie was removed. This
patch introduces a "wasDeleted" boolean to stop comparing cookie names after the cookie was
deleted. Note that we cannot break as soon as the cookie is found as we need to keep iterating
so that the cookies get freed by GOwnPtr.
No new tests, no behavior change.
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::deleteCookie):
- 5:26 AM Changeset in webkit [143203] by
-
- 4 edits in trunk
[EFL][WK2] Disable failing API tests
https://bugs.webkit.org/show_bug.cgi?id=110081
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Disable EWK2UnitTestBase.ewk_view_scale API test as it is failing.
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
Tools:
Disable DOMWindowExtensionBasic WK2 test on EFL port as it times out.
- TestWebKitAPI/PlatformEfl.cmake:
- 5:26 AM Changeset in webkit [143202] by
-
- 10 edits in trunk
Web Inspector: Create separate project for each domain for UISourceCode based on browser resources.
https://bugs.webkit.org/show_bug.cgi?id=109691
Reviewed by Pavel Feldman.
Source/WebCore:
Separate project of certain type is now created for each domain.
UISourceCode path represents a path in the project now.
UISourceCode uri is now calculated based on project id and path.
It is also possible to calculate path based on projectId and URI, which is used for uiSourceCodeForURI() methods.
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.prototype._filePathForPath):
(WebInspector.FileSystemProjectDelegate.prototype.setFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype._populate):
(WebInspector.FileSystemProjectDelegate.prototype._removeFile):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.projectId):
(WebInspector.SimpleProjectDelegate.prototype.id):
(WebInspector.SimpleProjectDelegate.prototype.displayName):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.splitURL):
(WebInspector.SimpleWorkspaceProvider._pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._projectDelegate):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFile):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.uri):
(WebInspector.UISourceCode.path):
(WebInspector.UISourceCode.prototype.uri):
- inspector/front-end/Workspace.js:
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCodeForURI):
LayoutTests:
- inspector/debugger/live-edit-breakpoints-expected.txt:
- inspector/debugger/live-edit-breakpoints.html:
- inspector/uisourcecode-revisions.html:
- 5:21 AM Changeset in webkit [143201] by
-
- 2 edits in trunk/Tools
[Qt] Disable the build if certain configure checks fail
https://bugs.webkit.org/show_bug.cgi?id=110094
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2013-02-18
Reviewed by Tor Arne Vestbø.
Allow for the build to be skipped (clear out SUBDIRS) if certain
configure conditions aren't met.
- qmake/mkspecs/features/configure.prf:
- 5:20 AM Changeset in webkit [143200] by
-
- 4 edits in trunk/Source/WebKit/efl
[EFL] Fix build when CONTEXT_MENUS flag is turned off
https://bugs.webkit.org/show_bug.cgi?id=109924
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-02-18
Reviewed by Gyuyoung Kim.
- WebCoreSupport/ContextMenuClientEfl.cpp:
- WebCoreSupport/ContextMenuClientEfl.h:
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(ewk_view_context_menu_get):
- 5:12 AM Changeset in webkit [143199] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 5:06 AM Changeset in webkit [143198] by
-
- 22 edits in trunk
[EFL] Rebaseline failure media tests after r142947
https://bugs.webkit.org/show_bug.cgi?id=109904
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
- css/mediaControlsEfl.css: Align time text vertically.
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
LayoutTests:
- platform/efl/TestExpectations:
- platform/efl/media/audio-controls-rendering-expected.png:
- platform/efl/media/audio-controls-rendering-expected.txt:
- platform/efl/media/controls-after-reload-expected.png:
- platform/efl/media/controls-after-reload-expected.txt:
- platform/efl/media/controls-strict-expected.png:
- platform/efl/media/controls-strict-expected.txt:
- platform/efl/media/controls-styling-expected.png:
- platform/efl/media/controls-styling-expected.txt:
- platform/efl/media/controls-styling-strict-expected.png:
- platform/efl/media/controls-styling-strict-expected.txt:
- platform/efl/media/controls-without-preload-expected.png:
- platform/efl/media/controls-without-preload-expected.txt:
- platform/efl/media/video-controls-rendering-expected.png:
- platform/efl/media/video-controls-rendering-expected.txt:
- platform/efl/media/video-display-toggle-expected.png:
- platform/efl/media/video-display-toggle-expected.txt:
- platform/efl/media/video-playing-and-pause-expected.png:
- platform/efl/media/video-playing-and-pause-expected.txt:
- 5:00 AM Changeset in webkit [143197] by
-
- 9 edits6 adds in trunk
[Qt][WK2] Support WK2 API tests
https://bugs.webkit.org/show_bug.cgi?id=109843
Reviewed by Jocelyn Turcotte.
Source/WebKit2:
- UIProcess/API/qt/qquickwebview_p.h:
(TestWebKitAPI):
Tools:
- TestWebKitAPI/DerivedSources.pri: Added.
- TestWebKitAPI/InjectedBundle.pri: Added.
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/TestWebKitAPI.pri:
- TestWebKitAPI/TestWebKitAPI.pro:
- TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Added.
- TestWebKitAPI/Tests/WTF/WTF.pro:
- TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Added.
- TestWebKitAPI/qt/PlatformUtilitiesQt.cpp:
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::isKeyDown):
(Util):
- TestWebKitAPI/qt/PlatformWebViewQt.cpp: Added.
(TestWebKitAPI):
(WrapperWindow):
(TestWebKitAPI::WrapperWindow::WrapperWindow):
(TestWebKitAPI::WrapperWindow::handleStatusChanged):
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::focus):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
(TestWebKitAPI::PlatformWebView::simulateRightClick):
- TestWebKitAPI/qt/main.cpp:
(addQtWebProcessToPath):
(main):
- 4:56 AM Changeset in webkit [143196] by
-
- 9 edits1 move1 add in trunk/Source/WebCore
Web Inspector: Extract FileSystemUtils from FileSystemProjectDelegate as IsolatedFileSystem class.
https://bugs.webkit.org/show_bug.cgi?id=110086
Reviewed by Pavel Feldman.
Extracted IsolatedFileSystem class that could be mocked for tests now.
Renamed IsolatedFileSystemModel to IsolatedFileSystemManager.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.id):
(WebInspector.FileSystemProjectDelegate.prototype.displayName):
(WebInspector.FileSystemProjectDelegate.prototype.setFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype._populate):
- inspector/front-end/IsolatedFileSystem.js: Added.
(WebInspector.IsolatedFileSystem):
(WebInspector.IsolatedFileSystem.errorMessage):
(WebInspector.IsolatedFileSystem.prototype.id):
(WebInspector.IsolatedFileSystem.prototype.path):
(WebInspector.IsolatedFileSystem.prototype._requestFileSystem):
(WebInspector.IsolatedFileSystem.prototype.fileSystemLoaded):
(WebInspector.IsolatedFileSystem.prototype.innerCallback):
(WebInspector.IsolatedFileSystem.prototype.requestFilesRecursive):
(WebInspector.IsolatedFileSystem.prototype.fileEntryLoaded):
(WebInspector.IsolatedFileSystem.prototype.fileLoaded):
(WebInspector.IsolatedFileSystem.prototype.readerLoadEnd):
(WebInspector.IsolatedFileSystem.prototype.errorHandler):
(WebInspector.IsolatedFileSystem.prototype.requestFileContent):
(WebInspector.IsolatedFileSystem.prototype.fileWriterCreated.fileTruncated):
(WebInspector.IsolatedFileSystem.prototype.fileWriterCreated):
(WebInspector.IsolatedFileSystem.prototype.writerEnd):
(WebInspector.IsolatedFileSystem.prototype.setFileContent):
(WebInspector.IsolatedFileSystem.prototype.):
(WebInspector.IsolatedFileSystem.prototype.toArray):
(WebInspector.IsolatedFileSystem.prototype._readDirectory):
(WebInspector.IsolatedFileSystem.prototype._requestEntries):
- inspector/front-end/IsolatedFileSystemManager.js: Renamed from Source/WebCore/inspector/front-end/IsolatedFileSystemModel.js.
(WebInspector.IsolatedFileSystemManager):
(WebInspector.IsolatedFileSystemManager.prototype.mapping):
(WebInspector.IsolatedFileSystemManager.prototype.supportsFileSystems):
(WebInspector.IsolatedFileSystemManager.prototype._requestFileSystems):
(WebInspector.IsolatedFileSystemManager.prototype.addFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype.removeFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemsLoaded):
(WebInspector.IsolatedFileSystemManager.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemPaths):
(WebInspector.IsolatedFileSystemManager.prototype._processPendingFileSystemRequests):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemAdded):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemRemoved):
(WebInspector.IsolatedFileSystemManager.prototype._isolatedFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype.requestDOMFileSystem):
(WebInspector.IsolatedFileSystemDispatcher):
(WebInspector.IsolatedFileSystemDispatcher.prototype.fileSystemsLoaded):
(WebInspector.IsolatedFileSystemDispatcher.prototype.fileSystemRemoved):
(WebInspector.IsolatedFileSystemDispatcher.prototype.fileSystemAdded):
- inspector/front-end/SettingsScreen.js:
(WebInspector.WorkspaceSettingsTab.prototype._createFileSystemsEditor):
(WebInspector.WorkspaceSettingsTab.prototype._addFileSystemRow.removeFileSystemClicked):
(WebInspector.WorkspaceSettingsTab.prototype._addFileSystemClicked):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
- 4:54 AM Changeset in webkit [143195] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Changing WebView.contentY and WebView.contentX does not redraw content
https://bugs.webkit.org/show_bug.cgi?id=108337
Reviewed by Jocelyn Turcotte.
We should not ignore content position changes unless pinch zoom or bounce-back
animation is ongoing.
This way we notify the web process about visible rect changes if the contentX
and contentY properties are used to programmatically scroll the content from QML.
One important usecase for this is when implementing scrollbars.
- UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::flickMoveStarted):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::pageItemPositionChanged):
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
- 4:11 AM Changeset in webkit [143194] by
-
- 4 edits in trunk
[EFL][WK2] compositing/layer-creation/fixed-position-out-of-view-scaled.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=110059
Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-18
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Remove the ASSERT check in TextureMapperLayer. This assertion seems
valid because CoordinatedGraphicsScene::adjustPositionForFixedLayers() calls
TextureMapperLayer::setScrollPositionDeltaIfNeeded() when the graphics
layer is a fixed position layer. However, the assertion can be failed
because it is possible that TextureMapperLayer is a non-fixed position
layer when the graphics layer that holds the TextureMapperLayer is a
fixed position layer. When CoordinatedGraphicsScene flushes,
TextureMapperLayer becomes a fixed position layer.
No new tests. No change in behavior.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):
LayoutTests:
Unskip two tests on EFL port. Now those pass.
compositing/layer-creation/fixed-position-out-of-view-scaled.html
compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html
- platform/efl-wk2/TestExpectations:
- 3:45 AM Changeset in webkit [143193] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip several webgl/conformance tests that started passing after
r142854.
- platform/efl-wk2/TestExpectations:
- 3:33 AM Changeset in webkit [143192] by
-
- 8 edits in trunk/Source
[WK2][EFL] Unified text checker implementation
https://bugs.webkit.org/show_bug.cgi?id=107682
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests, covered by editing/spelling tests.
- platform/text/TextChecking.h:
(WebCore):
Enabling unified text checker feature for WebKit-EFL.
Source/WebKit/efl:
Add an empty checkTextOfParagraph implementation for WK1-EFL
to do not break build when WTF_USE_UNIFIED_TEXT_CHECKING
is enabled.
- WebCoreSupport/EditorClientEfl.h:
(EditorClientEfl):
(WebCore::EditorClientEfl::checkTextOfParagraph):
Source/WebKit2:
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit):
(WebKit::nextWordOffset):
Helper function to determine the word offset to do not call
client's checkSpellingOfString for the word separators.
(WebKit::TextChecker::checkTextOfParagraph):
Allow to check spelling for multiple words,
their misspelling location and length are saved to the vector.
- WebProcess/WebCoreSupport/WebEditorClient.h:
Add UNIFIED_TEXT_CHECKING guard to checkTextOfParagraph.
- WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
(WebKit):
(WebKit::WebEditorClient::checkTextOfParagraph):
As spelling implementation is exposed to UIProcess,
send a meesage to UIProcess to call TextChecker::checkTextOfParagraph.
- 3:26 AM Changeset in webkit [143191] by
-
- 2 edits25 adds2 deletes in trunk/LayoutTests
fast/dom/shadow/shadow-dom-event-dispatching.html flake
https://bugs.webkit.org/show_bug.cgi?id=103299
Reviewed by Jochen Eisinger.
This patch breaks fast/dom/shadow/shadow-dom-event-dispatching.html out
into 12 separate tests to avoid timeouts. Common logic for all these
dispatching tests is now in resources/event-dispatching.js, and each
individual test function now runs in its own HTML file.
- fast/dom/shadow/resources/event-dispatching.js: Added.
(moveMouseOver):
(recordEvent):
(dumpNode):
(dumpComposedShadowTree):
(addEventListeners):
(debugDispatchedEvent):
(moveMouse):
(showSandboxTree):
- fast/dom/shadow/shadow-dom-event-dispatching-child-of-inactive-content-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-child-of-inactive-content.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-details-summary-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-details-summary.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-distributed-child-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-distributed-child.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-manually-fired.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-multiple-shadow-roots-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-multiple-shadow-roots.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-nested-shadow-roots-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-nested-shadow-roots.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root.html: Added.
New tests!
- fast/dom/shadow/shadow-dom-event-dispatching-expected.txt: Removed.
- fast/dom/shadow/shadow-dom-event-dispatching.html: Removed.
- platform/chromium/TestExpectations:
Dropped the old, monolithic test, and removed it from Chromium's
TestExpectations file.
- 3:24 AM Changeset in webkit [143190] by
-
- 12 edits in trunk
[EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal C++ API
https://bugs.webkit.org/show_bug.cgi?id=108598
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Refactor the Ewk_Favicon code so that it no longer relies on internal
C++ API and so that it is based solely on the C API. The API is changed
a little as well so that the Favicon URL is no longer exposed to the
client. Also the client is now only notified of icon changes once the
favicon data is actually available.
The API is covered by existing API tests and by MiniBrowser which are
both updated accordingly in this patch.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::informURLChange):
(EwkView::createFavicon):
(EwkView::onFaviconChanged):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/API/efl/EwkViewCallbacks.h:
- UIProcess/API/efl/ewk_favicon_database.cpp:
Client are now notified of favicon changes only when the favicon data
becomes available and make API to retrieve a favicon synchronous. NULL
is returned if the favicon data is not available.
(EwkFaviconDatabase::EwkFaviconDatabase):
(EwkFaviconDatabase::getIconSurfaceSynchronously):
(EwkFaviconDatabase::iconDataReadyForPageURL):
(ewk_favicon_database_icon_get):
- UIProcess/API/efl/ewk_favicon_database.h:
- UIProcess/API/efl/ewk_favicon_database_private.h:
(EwkFaviconDatabase):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_favicon_get):
- UIProcess/API/efl/ewk_view.h:
Rename 'icon,changed' signal to 'favicon,changed' for clarity and
consistency with the rest of the favicon API. Remove API to retrieve
the favicon URL and replace it by one to retrieve the favicon image as
an Evas_Object instead.
- UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
Update API tests to use the new favicon API.
Tools:
Update EFL's MiniBrowser to make use of new Ewk_Favicon API.
- MiniBrowser/efl/main.c:
(update_view_favicon):
(on_view_favicon_changed):
(window_create):
- 3:22 AM Changeset in webkit [143189] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip several webaudio test cases that pass now that we updated to
gstreamer 1.0.
- platform/efl/TestExpectations:
- 2:59 AM Changeset in webkit [143188] by
-
- 2 edits in trunk/Source/WebCore
[chromium/clang] Remove -Wno-return-type-c-linkage
https://bugs.webkit.org/show_bug.cgi?id=110098
Reviewed by Jochen Eisinger.
The one instance where this triggered was removed in
http://trac.webkit.org/changeset/141184 . A clang that has this
warning landed in chromium r182694, so it should be safe to turn
the warning on now.
- WebCore.gyp/WebCore.gyp:
- 2:56 AM Changeset in webkit [143187] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Update expectations for several test cases to make the bots green.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 2:51 AM Changeset in webkit [143186] by
-
- 21 edits2 adds in trunk
Web Inspector: provide basic console.table implementation (no [,columns] support)
https://bugs.webkit.org/show_bug.cgi?id=109453
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: inspector/console/console-format-table.html
Using console preview infrastructure to support console.table.
- English.lproj/localizedStrings.js:
- inspector/ConsoleAPITypes.h:
- inspector/ConsoleMessage.cpp:
(WebCore::messageTypeValue):
(WebCore::ConsoleMessage::addToFrontend):
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::wrapObject):
(WebCore):
(WebCore::InjectedScript::wrapTable):
- inspector/InjectedScript.h:
(InjectedScript):
- inspector/InjectedScriptSource.js:
(.):
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype.willHide):
(WebInspector.ConsoleMessageImpl.prototype._format):
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
(WebInspector.ConsoleMessageImpl.prototype._renderPropertyPreview):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsTable):
- inspector/front-end/ConsoleModel.js:
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleCommand.prototype.wasShown):
(WebInspector.ConsoleCommand.prototype.willHide):
(WebInspector.ConsoleGroup.prototype.addMessage):
- inspector/front-end/DataGrid.js:
(.sortDataGrid.comparator):
(.sortDataGrid):
(WebInspector.DataGrid.createSortableDataGrid):
(WebInspector.DataGrid.prototype.renderInline):
- inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView.prototype._queryFinished):
- inspector/front-end/dataGrid.css:
(.data-grid.inline):
(.data-grid.inline td.corner):
- inspector/front-end/resourcesPanel.css:
(.storage-view > .data-grid):
- page/Console.cpp:
(WebCore::Console::table):
(WebCore):
- page/Console.h:
(Console):
- page/Console.idl:
LayoutTests:
- inspector/console/command-line-api-expected.txt:
- inspector/console/console-format-table-expected.txt: Added.
- inspector/console/console-format-table.html: Added.
- 2:45 AM Changeset in webkit [143185] by
-
- 2 edits in branches/chromium/1410/Source/WebCore/inspector/front-end
Merge 142870
Web Inspector: fix to record button remaining red after heap snapshot is taken
https://bugs.webkit.org/show_bug.cgi?id=109804
Patch by Alexei Filippov <alph@chromium.org> on 2013-02-14
Reviewed by Yury Semikhatsky.
Revert part of r142243 fix. Namely heap snapshot taking button made
stateless as it was before.
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12294013
- 2:45 AM Changeset in webkit [143184] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: JavaScriptSourceFrame should inherit UISourceCodeFrame
https://bugs.webkit.org/show_bug.cgi?id=110091
Reviewed by Pavel Feldman.
Removed duplicated code from JavaScriptSourceFrame and made it inherit UISourceCodeFrame.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.onUISourceCodeContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype.canEditSource):
(WebInspector.UISourceCodeFrame.prototype.onTextChanged):
(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):
(WebInspector.UISourceCodeFrame.prototype.onUISourceCodeContentChanged):
(WebInspector.UISourceCodeFrame.prototype._innerSetContent):
- 2:35 AM Changeset in webkit [143183] by
-
- 3 edits in branches/chromium/1410/Source/WebCore/inspector/front-end
Merge 142745
Web Inspector: Fixed colorpicker editing and scrolling.
https://bugs.webkit.org/show_bug.cgi?id=109434.
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-13
Reviewed by Alexander Pavlov.
The color picker scrolling logic relied on the fixed DOM structure which changed with the introduction of
SidebarPaneStack (https://bugs.webkit.org/show_bug.cgi?id=108183).
Added a special CSS class to mark the scroll target.
No new tests.
- inspector/front-end/SplitView.js:
(WebInspector.SplitView):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12301008
- 2:31 AM Changeset in webkit [143182] by
-
- 3 edits in trunk/LayoutTests
Follow up to r143112, fixing tests.
Not reviewed.
- inspector/elements/insert-node-expected.txt:
- inspector/elements/insert-node.html:
- 2:30 AM Changeset in webkit [143181] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed speculative build fix for Apple Win bots.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- 2:29 AM Changeset in webkit [143180] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Remove unused _files field in FileSystemProjectDelegate
https://bugs.webkit.org/show_bug.cgi?id=110082
Reviewed by Pavel Feldman.
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype._addFile):
(WebInspector.FileSystemProjectDelegate.prototype._removeFile):
- 2:28 AM Changeset in webkit [143179] by
-
- 5 edits in trunk
Web Inspector: allow 0 as a formatted parameter in console message.
https://bugs.webkit.org/show_bug.cgi?id=110096
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.append):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):
LayoutTests:
- inspector/console/console-format.html:
- 2:20 AM Changeset in webkit [143178] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed speculative fix for Chromium Mac.
- WebCore.gypi:
- 2:15 AM Changeset in webkit [143177] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipped failing tests.
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt/TestExpectations:
- 2:11 AM Changeset in webkit [143176] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 1:54 AM Changeset in webkit [143175] by
-
- 6 edits1 add in trunk
Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
https://bugs.webkit.org/show_bug.cgi?id=109554
In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
Drive by fix: I introduced a client interface for the HeapGraphSerializer.
It helps me to do the tests for the serializer.
Reviewed by Yury Semikhatsky.
It is covered by newly added tests in TestWebKitAPI.
Source/WebCore:
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):
- inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
(Client):
(WebCore::HeapGraphSerializer::Client::~Client):
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):
Tools:
- TestWebKitAPI/TestWebKitAPI.gypi:
- TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
(TestWebKitAPI):
(HeapGraphReceiver):
(TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
(TestWebKitAPI::HeapGraphReceiver::printGraph):
(TestWebKitAPI::HeapGraphReceiver::dumpNodes):
(TestWebKitAPI::HeapGraphReceiver::dumpEdges):
(TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
(TestWebKitAPI::HeapGraphReceiver::dumpStrings):
(TestWebKitAPI::HeapGraphReceiver::serializer):
(TestWebKitAPI::HeapGraphReceiver::chunkPart):
(TestWebKitAPI::HeapGraphReceiver::dumpPart):
(TestWebKitAPI::HeapGraphReceiver::stringValue):
(TestWebKitAPI::HeapGraphReceiver::intValue):
(TestWebKitAPI::HeapGraphReceiver::nodeToString):
(TestWebKitAPI::HeapGraphReceiver::edgeToString):
(TestWebKitAPI::HeapGraphReceiver::printNode):
(Helper):
(TestWebKitAPI::Helper::Helper):
(TestWebKitAPI::Helper::addNode):
(TestWebKitAPI::Helper::addEdge):
(TestWebKitAPI::Helper::done):
(Object):
(TestWebKitAPI::Helper::Object::Object):
(TestWebKitAPI::TEST):
(Owner):
(TestWebKitAPI::Owner::Owner):
(TestWebKitAPI::Owner::reportMemoryUsage):
- 1:30 AM Changeset in webkit [143174] by
-
- 9 edits in trunk
Unreviewed, rolling out r143100.
http://trac.webkit.org/changeset/143100
https://bugs.webkit.org/show_bug.cgi?id=110088
Breaks file system support in workspace. (Requested by vsevik
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-18
Source/WebCore:
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.prototype.id):
(WebInspector.SimpleProjectDelegate.prototype.displayName):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.uri):
- inspector/front-end/Workspace.js:
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCodeForURI):
(WebInspector.Workspace.prototype.projectForUISourceCode):
LayoutTests:
- inspector/debugger/live-edit-breakpoints-expected.txt:
- inspector/debugger/live-edit-breakpoints.html:
- inspector/uisourcecode-revisions.html:
- 1:27 AM Changeset in webkit [143173] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening.
Adding failure expectations for two tests that are failing on GTK and Qt,
most likely due to disabled subpixel layout.
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- 1:26 AM Changeset in webkit [143172] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indentation of StructureStubInfo.h
Rubber stamped by Mark Hahnenberg.
- bytecode/StructureStubInfo.h:
- 1:25 AM Changeset in webkit [143171] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix indentation of JSGlobalObject.h and JSGlobalObjectFunctions.h
Rubber stamped by Mark Hahnenberg.
- runtime/JSGlobalObject.h:
- runtime/JSGlobalObjectFunctions.h:
- 1:20 AM Changeset in webkit [143170] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indention of Operations.h
Rubber stamped by Mark Hahnenberg.
- runtime/Operations.h:
- 1:16 AM Changeset in webkit [143169] by
-
- 3 edits2 deletes in trunk/LayoutTests
Unreviewed. Clean up a few EFL unexpected passes.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Removed.
- platform/efl/ietestcenter/css3/text/textshadow-005-expected.txt: Removed.
- 1:16 AM Changeset in webkit [143168] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove DFG::SpeculativeJIT::isKnownNumeric(), since it's not called from anywhere.
Rubber stamped by Andy Estes.
- dfg/DFGSpeculativeJIT.cpp:
(DFG):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- 1:11 AM Changeset in webkit [143167] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove DFG::SpeculativeJIT::isStrictInt32(), since it's not called from anywhere.
Rubber stampted by Andy Estes.
- dfg/DFGSpeculativeJIT.cpp:
(DFG):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- 1:00 AM Changeset in webkit [143166] by
-
- 2 edits in branches/chromium/1364/Source/WebCore/Modules/mediastream
Merge 142887
MediaStream API: RTCDataChannel triggers a use-after-free
https://bugs.webkit.org/show_bug.cgi?id=109806
Reviewed by Adam Barth.
Making sure RTCPeerConnection::stop() is always called at least once.
Also making sure that RTCDataChannels state gets set to Closed correctly.
Hard to test in WebKit but covered by Chromium tests.
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::stop):
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::stop):
TBR=tommyw@google.com
Review URL: https://codereview.chromium.org/12301006
- 12:59 AM Changeset in webkit [143165] by
-
- 7 edits in trunk/Source/JavaScriptCore
Remove dead code for ValueToNumber from the DFG.
Rubber stamped by Andy Estes.
We killed ValueToNumber at some point, but forgot to kill all of the backend support
for it.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleMinMax):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
- dfg/DFGSpeculativeJIT64.cpp:
- 12:59 AM Changeset in webkit [143164] by
-
- 2 edits4 deletes in trunk/LayoutTests
Unreviewed. Clean up a few EFL unexpected passes.
- platform/efl/TestExpectations:
- platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.png: Removed.
- platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.txt: Removed.
- platform/efl/fast/repaint/caret-with-transformation-expected.png: Removed.
- platform/efl/fast/repaint/caret-with-transformation-expected.txt: Removed.
- 12:46 AM Changeset in webkit [143163] by
-
- 2 edits12 deletes in trunk/LayoutTests
Unreviewed. Remove invalid EFL results that were wrongly added in r140249.
- platform/efl/TestExpectations:
- platform/efl/fast/css/color-correction-on-background-image-expected.png: Removed.
- platform/efl/fast/css/color-correction-on-background-image-expected.txt: Removed.
- platform/efl/fast/css/color-correction-on-backgrounds-expected.png: Removed.
- platform/efl/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
- platform/efl/fast/css/color-correction-on-box-shadow-expected.png: Removed.
- platform/efl/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
- platform/efl/fast/css/color-correction-on-text-expected.png: Removed.
- platform/efl/fast/css/color-correction-on-text-expected.txt: Removed.
- platform/efl/fast/css/color-correction-on-text-shadow-expected.png: Removed.
- platform/efl/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
- platform/efl/fast/css/color-correction-untagged-images-expected.png: Removed.
- platform/efl/fast/css/color-correction-untagged-images-expected.txt: Removed.
- 12:38 AM Changeset in webkit [143162] by
-
- 2 edits in trunk/Tools
WKR build fix. Always use ascii since irclib/ircbot doesn't support unicode.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):
- 12:37 AM Changeset in webkit [143161] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Unskip several test cases that are now passing on
EFL port, most of them due to enabling subpixel layout.
- platform/efl/TestExpectations:
- 12:22 AM Changeset in webkit [143160] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Unskip several compositing tests that are now
passing on WK2 EFL.
- platform/efl/TestExpectations: