⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 20, 2013:

11:54 PM CoordinatedGraphicsSystem edited by cwhong@company100.net
New dorothybrowser site! (diff)
11:53 PM Changeset in webkit [143568] by vsevik@chromium.org
  • 7 edits in trunk

Web Inspector: TabbedEditorContainer and OpenResourceDialog should show uiSourceCode path and name instead of parsedURL
​https://bugs.webkit.org/show_bug.cgi?id=110334

Reviewed by Alexander Pavlov.

Source/WebCore:

Introduced uiSourceCode.name() that returns a name based on uiSourceCode path.
OpenResourceDialog now shows uiSourceCode workspace path as a subtitle.
TabbedEditorContainer now shows uiSourceCode name in the tab header.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemSubtitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype._updateScriptTitle):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._titleForFile):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.name):

LayoutTests:

  • inspector/debugger/scripts-file-selector-expected.txt:
  • inspector/debugger/ui-source-code-display-name-expected.txt:
  • inspector/debugger/ui-source-code-display-name.html:
11:33 PM Changeset in webkit [143567] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: debugger buttons are scrolled along with the sidebar content.
​https://bugs.webkit.org/show_bug.cgi?id=110434

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/scriptsPanel.css:

(div.sidebar-pane-stack#scripts-debug-sidebar-contents, #scripts-sidebar-stack-pane):

11:21 PM Changeset in webkit [143566] by pfeldman@chromium.org
  • 2 edits in branches/chromium/1410/Source/WebCore/inspector/front-end

Merge 143437

Web Inspector: View.markAsRoot should never be invoked on attached view.
​https://bugs.webkit.org/show_bug.cgi?id=110224

Reviewed by Pavel Feldman.

This will cause CSS loading problems after "show".

  • inspector/front-end/Drawer.js:

Ensure child view is detached before marked as root.

  • inspector/front-end/View.js:

(WebInspector.View.prototype.markAsRoot): Added assertion.

TBR=​eustas@chromium.org
BUG=176912
Review URL: ​https://codereview.chromium.org/12320033

10:34 PM Changeset in webkit [143565] by james.wei@intel.com
  • 3 edits in trunk/Source/WebCore

ChannelMergerNode may need check for deferred updating of output channels
​https://bugs.webkit.org/show_bug.cgi?id=108863

There can in rare cases be a slight delay before the output bus is updated
to the new number of channels because of tryLocks() in the context's
updating system. So need to check the channel number before processing.

Reviewed by Chris Rogers.

  • Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::ChannelMergerNode):
(WebCore::ChannelMergerNode::process):
(WebCore::ChannelMergerNode::checkNumberOfChannelsForInput):

  • Modules/webaudio/ChannelMergerNode.h:

(ChannelMergerNode):

10:26 PM Changeset in webkit [143564] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Web Inspector] Fix Sort by Initiator functionality of Network Panel.
​https://bugs.webkit.org/show_bug.cgi?id=109135.

Patch by Pan Deng <​pan.deng@intel.com> on 2013-02-20
Reviewed by Pavel Feldman.

A refactor for request initiator types, and the sort by Initiator functionality
was changed to sort by url and line number that displayed in initiator cell.

No new tests.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell): save initiator displayedURL and displayedLineNumber
(WebInspector.NetworkDataGridNode.InitiatorComparator):

  • inspector/front-end/NetworkRequest.js:
9:36 PM Changeset in webkit [143563] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

WebVTTParser copies character buffer more often than necessary
​https://bugs.webkit.org/show_bug.cgi?id=103319

Reviewed by Eric Carlson.

Previously this codepath was creating a String just to parse the timestamp
and then if the timestamp was valid, was creating a second string.
I've fixed it to only create one string and use it in both places.
I also fixed this codepath to use 8bit strings when possible, per the FIXME.

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::constructTreeFromToken):

8:58 PM Changeset in webkit [143562] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG::SpeculativeJIT::compileInt32ToDouble() has an unnecessary case for constant operands
​https://bugs.webkit.org/show_bug.cgi?id=110309

Reviewed by Sam Weinig.

It used to be necessary, back when we didn't have constant folding. Now we have
constant folding. So we don't need it.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):

8:38 PM Changeset in webkit [143561] by vivek.vg@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Changing primary email id.

8:21 PM Changeset in webkit [143560] by mkwst@chromium.org
  • 3 edits
    4 adds in trunk

Mouseup event does not fire on Scroll Bar
​https://bugs.webkit.org/show_bug.cgi?id=25811

Reviewed by Tony Chang.

Source/WebCore:

Currently, clicking on a scrollbar fires a mousedown event, but not a
mouseup event. This causes problems for code like jQuery UI's
draggable[1], as the drag starts, but is never cancelled. Other use
cases are noted in the slightly old Chromium bug[2].

If a mouseup event is received after a mousedown event on a scrollbar,
this patch dispatches a mouseup event on the same node the mousedown
event dispatched on. This matches Gecko's behavior.

[1]: ​http://bugs.jqueryui.com/ticket/6925
[2]: ​http://crbug.com/14204

Tests: fast/scrolling/scrollbar-mousedown-mouseup.html

fast/scrolling/scrollbar-mousedown-move-mouseup.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseReleaseEvent):

If a mouseup event follow a mousedown event on a scrollbar,
dispatch an event on the same node from which the mousedown event
was triggered.

LayoutTests:

  • fast/scrolling/scrollbar-mousedown-mouseup-expected.txt: Added.
  • fast/scrolling/scrollbar-mousedown-mouseup.html: Added.
  • fast/scrolling/scrollbar-mousedown-move-mouseup-expected.txt: Added.
  • fast/scrolling/scrollbar-mousedown-move-mouseup.html: Added.
7:58 PM Changeset in webkit [143559] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, update TestExpectations.

  • platform/chromium/TestExpectations:
7:51 PM Changeset in webkit [143558] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Provide WKView SPI to defer telling the WebPageProxy and WebProcess about changes in the hosting window
​https://bugs.webkit.org/show_bug.cgi?id=110415
<rdar://problem/13095405>

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKView.mm: Add _viewInWindowChangesDeferredCount and _viewInWindowChangeWasDeferred to WKViewData.

(-[WKView viewDidMoveToWindow]): If we're deferring window changes, don't include the ViewIsInWindow flag
when sending viewStateDidChange. Instead, save the fact that we want to do that later aside.
(-[WKView beginDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChanges]): Straightforward begin/end pair. When we exit the last pair and
have a pending window change, let the WebPageProxy know. WebPageProxy will do the check to ensure that
the in-window state has actually changed.
(-[WKView isDeferringViewInWindowChanges]):

  • UIProcess/API/mac/WKViewPrivate.h:
7:50 PM Changeset in webkit [143557] by toyoshim@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed gardening, add chromium-mac specific expectation image.

  • platform/chromium-mac/fast/repaint/paint-caret-in-div-with-negative-indent-expected.png: Added.
7:39 PM Changeset in webkit [143556] by tasak@google.com
  • 13 edits in trunk/Source/WebCore

[Refactoring] Make m_state an on-stack object
​https://bugs.webkit.org/show_bug.cgi?id=109909

Reviewed by Antti Koivisto.

Mode m_state, an instance of StyleResolver::State, an on-stack object.
The state is only required in styleForElement, styleForKeyframe and
so on. No need to keep the state outside of those methods.

No new tests, because just refactoring.

  • css/BasicShapeFunctions.cpp:

(WebCore::convertToLength):
(WebCore::basicShapeForValue):

  • css/BasicShapeFunctions.h:

(WebCore):
Replaced StyleResolver* with StyleResolver::State&.

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::gradientWithStylesResolved):

  • css/CSSGradientValue.h:

(CSSGradientValue):
Replaced StyleResolver* with StyleResolver::State&.

  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::style):
(WebCore::CSSToStyleMap::rootElementStyle):
(WebCore::CSSToStyleMap::useSVGZoomRules):
(WebCore::CSSToStyleMap::styleImage):

  • css/CSSToStyleMap.h:

(WebCore):
(WebCore::CSSToStyleMap::CSSToStyleMap):
(CSSToStyleMap):
Replaced StyleResolver* with StyleResolver::State&.

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):
Replaced m_state with state which is given as an argument of
applySVGProperty.

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyExclusionShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):
(WebCore::ApplyPropertyImageResolution::applyValue):

  • css/StyleBuilder.h:

(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
Replaced StyleResolver* with StyleResolver::State&.

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::StyleResolver):
Removed m_styleMap. Now m_styleMap is an on-stack object.
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::findSiblingForStyleSharing):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyWithNullCheck):
(WebCore::StyleResolver::applyFontPropertyToStyle):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::checkForZoomChange):
(WebCore::StyleResolver::checkForGenericFamilyChange):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::styleShader):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createCustomFilterOperation):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
(WebCore::StyleResolver::loadPendingResources):
Just replaced m_state with state and added one more parameter to
provide the state.
(WebCore::StyleResolver::reportMemoryUsage):
Since m_state was removed, removed a code for reporting m_state's
memory usage.

  • css/StyleResolver.h:

(StyleResolver):
(WebCore::StyleResolver::isRightPage):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::document):
Since State::m_element is not always available (sometimes, 0),
added m_document to State and modified to return the m_document.
(WebCore::StyleResolver::State::useSVGZoomRules):
Moved StyleResolver to State.
(State):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):
Moved the code, updating a style by using a given StylePropertySet,
to StyleResolver.

7:26 PM Changeset in webkit [143555] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

AutoTableLayout applies min-width redundantly with RenderTable
​https://bugs.webkit.org/show_bug.cgi?id=110426

Reviewed by Emil A Eklund.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::computePreferredLogicalWidths):
This code used to do something, but has since been superceded by
code in RenderTable::computePreferredLogicalWidths.

7:22 PM Changeset in webkit [143554] by krit@webkit.org
  • 4 edits in trunk

Enable CANVAS_PATH flag
​https://bugs.webkit.org/show_bug.cgi?id=108508

Source/WebCore:

Uneviewed attempt to fix Qt minimal build.

  • html/canvas/DOMPath.h:

(WebCore::DOMPath::DOMPath):

LayoutTests:

Reviewed by Simon Fraser.

Unreviewed rebaseline after landing patch.

  • fast/dom/constructed-objects-prototypes-expected.txt:
6:43 PM Changeset in webkit [143553] by fpizlo@apple.com
  • 3 edits
    2 adds in trunk

DFG inlines Resolves that it doesn't know how to handle correctly
​https://bugs.webkit.org/show_bug.cgi?id=110405

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Don't try to be clever: if there's a failing resolve, we can't inline it, period.

  • dfg/DFGCapabilities.h:

(JSC::DFG::canInlineResolveOperations):
(JSC::DFG::canInlineOpcode):

LayoutTests:

Reviewed by Geoffrey Garen.

  • fast/js/dfg-inline-resolve-expected.txt: Added.
  • fast/js/dfg-inline-resolve.html: Added.
6:41 PM Changeset in webkit [143552] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Disable window occlusion notifications for App Store on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=110417

Patch by Kiran Muppala <​cmuppala@apple.com> on 2013-02-20
Reviewed by Simon Fraser.

Temporary fix to workaround issues with window occlusion notifications
in App Store.

  • UIProcess/API/mac/WKView.mm:

(+[WKView _registerWindowOcclusionNotificationHandlers]): Return early
if the main bundle identifier matches that of App Store.

6:36 PM Changeset in webkit [143551] by mark.lam@apple.com
  • 24 edits
    2 moves in trunk/Source/WebCore

\2013-02-20 Mark Lam <​mark.lam@apple.com>

Rename DatabaseBackendAsync to DatabaseBackend.
​https://bugs.webkit.org/show_bug.cgi?id=110422.

Reviewed by Geoffrey Garen.

This is a purely cosmetic change to make the naming consistent with
the front-end Database.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/webdatabase/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::from):
(WebCore::Database::backend):

  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackendAsync.cpp.

(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::openAndVerifyVersion):
(WebCore::DatabaseBackend::performOpenAndVerify):
(WebCore::DatabaseBackend::close):
(WebCore::DatabaseBackend::runTransaction):
(WebCore::DatabaseBackend::inProgressTransactionCompleted):
(WebCore::DatabaseBackend::scheduleTransaction):
(WebCore::DatabaseBackend::scheduleTransactionStep):
(WebCore::DatabaseBackend::transactionClient):
(WebCore::DatabaseBackend::transactionCoordinator):

  • Modules/webdatabase/DatabaseBackend.h: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackendAsync.h.
  • Modules/webdatabase/DatabaseBackendAsync.cpp: Removed.
  • Modules/webdatabase/DatabaseBackendAsync.h: Removed.
  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::~DatabaseBackendBase):

  • Modules/webdatabase/DatabaseManager.cpp:
  • Modules/webdatabase/DatabaseServer.cpp:
  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseTask::DatabaseTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::~DatabaseTransactionTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::debugTaskName):

  • Modules/webdatabase/DatabaseTask.h:

(WebCore::DatabaseTask::database):
(DatabaseTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::create):
(DatabaseBackend::DatabaseOpenTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::create):
(DatabaseBackend::DatabaseCloseTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::create):
(DatabaseBackend::DatabaseTableNamesTask):

  • Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):
(WebCore::SameDatabasePredicate::SameDatabasePredicate):
(SameDatabasePredicate):
(WebCore::DatabaseThread::unscheduleDatabaseTasks):

  • Modules/webdatabase/DatabaseThread.h:
  • Modules/webdatabase/SQLStatementBackend.cpp:

(WebCore::SQLStatementBackend::execute):
(WebCore::SQLStatementBackend::setDatabaseDeletedError):
(WebCore::SQLStatementBackend::setVersionMismatchedError):
(WebCore::SQLStatementBackend::setFailureDueToQuota):

  • Modules/webdatabase/SQLStatementBackend.h:
  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):

  • Modules/webdatabase/SQLTransactionBackend.h:

(WebCore::SQLTransactionBackend::database):

  • Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::getDatabaseIdentifier):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
6:25 PM Changeset in webkit [143550] by ddkilzer@apple.com
  • 3 edits
    1 add in trunk/Source/WebCore

Upstream SharedTimerIOS.mm
<​http://webkit.org/b/110161>

Reviewed by Benjamin Poulain.

  • Configurations/WebCore.xcconfig:

(EXCLUDED_SOURCE_FILE_NAMES_iphoneos): Add SharedTimerMac.mm.

  • WebCore.xcodeproj/project.pbxproj: Add SharedTimerIOS.mm.
  • platform/ios/SharedTimerIOS.mm: Add.

(WebCore):
(-[WebCoreResumeNotifierIOS init]):
(-[WebCoreResumeNotifierIOS dealloc]):
(-[WebCoreResumeNotifierIOS didWake]):
(WebCore::setSharedTimerFiredFunction):
(WebCore::timerFired):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

6:24 PM Changeset in webkit [143549] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Speculative fix for EFL and Windows compilers not realizing
that all possible cases have a return value from this switch.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):

6:20 PM Changeset in webkit [143548] by commit-queue@webkit.org
  • 4 edits
    1 add
    16 deletes in trunk/LayoutTests

Convert residual-style.html test to a reftest (and fix typos)
​https://bugs.webkit.org/show_bug.cgi?id=109981

Patch by Christian Biesinger <​cbiesinger@chromium.org> on 2013-02-20
Reviewed by Darin Adler.

  • fast/flexbox/box-orient-button.html: clsas->class
  • fast/flexbox/resources/box-orient-button.js: DTR->DRT
  • fast/invalid/residual-style-expected.html: Added. New reftest

version. Note that some lines are red, which is
​https://bugs.webkit.org/show_bug.cgi?id=109984

  • fast/invalid/residual-style.html: Add missing semicolon in <style>.

Also close a few more <font> tags, so that the descriptive text is
in black as it should be.

  • platform/chromium-android/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-android/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-linux/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-win/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-win/fast/invalid/residual-style-expected.txt: Removed.
  • platform/efl/fast/invalid/residual-style-expected.png: Removed.
  • platform/efl/fast/invalid/residual-style-expected.txt: Removed.
  • platform/gtk/fast/invalid/residual-style-expected.png: Removed.
  • platform/gtk/fast/invalid/residual-style-expected.txt: Removed.
  • platform/mac/fast/invalid/residual-style-expected.png: Removed.
  • platform/mac/fast/invalid/residual-style-expected.txt: Removed.

Removed old expectation files.

6:09 PM Changeset in webkit [143547] by jamesr@google.com
  • 5 edits in trunk

[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
​https://bugs.webkit.org/show_bug.cgi?id=109634

Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebUnitTestSupport.h:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createOutputSurface):
(WebViewHost::initializeLayerTreeView):

6:02 PM Changeset in webkit [143546] by hyatt@apple.com
  • 9 edits in trunk

[New Multicolumn] Fix overflow computation for column blocks.
​https://bugs.webkit.org/show_bug.cgi?id=110392.

Reviewed by Simon Fraser.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addOverflowFromChild):
Exclude in-flow RenderFlowThreads from overflow propagation.

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderRegion.h:

(WebCore::RenderRegion::shouldHaveAutoLogicalHeight):

  • rendering/RenderRegionSet.h:

(RenderRegionSet):
Override shouldHaveAutoLogicalHeight to always be false
for region sets and for columns. Eventually we're going to try
to leverage this code to do column balancing, and that's why
RenderMultiColumnSet has a unique override.

LayoutTests:

  • fast/multicol/newmulticol/column-rules-fixed-height-expected.html:
  • fast/multicol/newmulticol/column-rules-fixed-height.html:
5:35 PM Changeset in webkit [143545] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Printing WebGL canvases in Chrome uses stale data after first print
​https://bugs.webkit.org/show_bug.cgi?id=110003

Patch by Brandon Jones <​bajones@google.com> on 2013-02-20
Reviewed by Kenneth Russell.

Unable to validate printed content automatically. No regression in existing WebGL tests.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore): (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
5:29 PM Changeset in webkit [143544] by mrowe@apple.com
  • 7 edits
    1 move
    1 delete in trunk/Source/WebKit2

<​https://webkit.org/b/110410> Specify the plug-in process / service entitlements via the Xcode configuration.

This is the modern mechanism for applying entitlements to production builds,
and it simplifies the maintenance of entitlements going forward. It also allows
us to fix the new XPC PluginServices to have the same entitlements as PluginProcess.

Reviewed by Alexey Proskuryakov.

  • Configurations/Base.xcconfig: Ad-hoc sign all WebKit2 components.
  • Configurations/PluginProcess.xcconfig: Specify the entitlements to use.
  • Configurations/PluginService.32.xcconfig: Ditto.
  • Configurations/PluginService.64.xcconfig: Ditto.
  • Configurations/PluginService.Development.xcconfig: Ditto.
  • Configurations/PluginService.entitlements: Renamed from Source/WebKit2/PluginProcess/mac/PluginProcess.entitlements.

Move the entitlements in to the Configurations directory to make them easier to find.

  • PluginProcess/mac/add-entitlements.sh: Removed. In my testing the dependency issue mentioned

in the script is not an issue with current versions of Xcode. If we see it again we can come
up with a workaround that doesn't involve performing the signing via a script phase.

  • WebKit2.xcodeproj/project.pbxproj:
5:29 PM Changeset in webkit [143543] by mrowe@apple.com
  • 3 edits
    1 move
    1 delete in trunk/Source/WebKit2

<​https://webkit.org/b/110409> Remove duplication between 32- and 64-bit PluginService plists.

Reviewed by Dan Bernstein.

The only difference between the plists was the CFBundleIdentifier. Since the values are the
same as the product name, we can just use the value of the PRODUCT_NAME configuration setting.

  • Configurations/PluginService.32.xcconfig:
  • Configurations/PluginService.64.xcconfig:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist: Renamed from Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist: Removed.
5:22 PM Changeset in webkit [143542] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

Incorrect rendering for flex boxes with percentage height in a table cell
​https://bugs.webkit.org/show_bug.cgi?id=110389

Patch by Christian Biesinger <​cbiesinger@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

Source/WebCore:

Tests: css3/flexbox/flex-percentage-height-in-table-standards-mode.html

css3/flexbox/flex-percentage-height-in-table.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
Always update the logical height of the flex box, not just when it is
auto. If necessary, the later updateLogicalHeight() call will adjust
it.

LayoutTests:

  • css3/flexbox/flex-percentage-height-in-table-expected.html: Added.
  • css3/flexbox/flex-percentage-height-in-table-standards-mode-expected.html: Added.
  • css3/flexbox/flex-percentage-height-in-table-standards-mode.html: Added.
  • css3/flexbox/flex-percentage-height-in-table.html: Added.
5:19 PM Changeset in webkit [143541] by pdr@google.com
  • 9 edits
    2 adds in trunk

Account for transform in SVG background images
​https://bugs.webkit.org/show_bug.cgi?id=110295

Reviewed by Dirk Schulze.

Source/WebCore:

Tiled SVG background images are rendererd by drawing the SVG content into a temporary
image buffer, then stamping out a tiled pattern using this buffer. Previously the
image buffer did not account for CSS transforms which could result in pixelated backgrounds.

This patch takes advantage of the context's transform when sizing the temporary tiling
image buffer. Because the context's transform also includes scale, this patch simplifies
the SVG image code to no longer track scale.

Test: svg/as-background-image/svg-transformed-background.html

  • loader/cache/CachedImage.cpp:

(WebCore):
(WebCore::CachedImage::imageForRenderer):

CachedImage::lookupOrCreateImageForRenderer no longer creates images so it has been
refactored into just "imageForRenderer". Previously there were two versions of
lookupOrCreateImageForRenderer; these have been folded into imageForRenderer.

  • loader/cache/CachedImage.h:
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawPatternForContainer):

To create the temporary tiling image buffer, the final size in screen coordinates is
needed. This is now computed using the current context's CTM. Because the CTM
already includes the page scale, all page scale tracking can be removed.

The adjustments to srcRect and the pattern transform are the same as before, just
refactored to use imageBufferScale which has x and y components.

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::setContainerSizeForRenderer):

Because the page scale needed to be cached between calls to
setContainerSizeForRenderer, this function was written to modify an existing cache
entry. Because the page scale no longer needs to be tracked, this code has been
simplified to re-write any existing cache entry.

(WebCore::SVGImageCache::imageSizeForRenderer):

This function has been simplified by calling SVGImageForContainer::size() instead
of computing this value manually. The value returned remains the same, containing
the container size multiplied by zoom.

(WebCore::SVGImageCache::imageForRenderer):

Previously we set the page scale on every call to imageForRenderer. Because page scale
no longer needs to be tracked, this function has been simplified to simply return
the cached SVGImageForContainer.

  • svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::drawPattern):

  • svg/graphics/SVGImageForContainer.h:

(WebCore::SVGImageForContainer::create):
(WebCore::SVGImageForContainer::SVGImageForContainer):
(SVGImageForContainer):

LayoutTests:

  • svg/as-background-image/svg-transformed-background-expected.html: Added.
  • svg/as-background-image/svg-transformed-background.html: Added.
5:09 PM Changeset in webkit [143540] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in com.apple.WebKit2.WebProcessService at com.apple.avfoundation: 73-[AVAssetResourceLoader _attemptDelegateHandlingOfRequestWithDictionary:]_block_invoke + 51
​https://bugs.webkit.org/show_bug.cgi?id=110385

Reviewed by Eric Carlson.

Ensure AVFoundation does not attempt to message a dead object by explicitly disassociating
the AVAssetResourceLoaderDelegate on MediaPlayerPrivateAVFoundationObjC destruction.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC):

5:07 PM Changeset in webkit [143539] by ojan@chromium.org
  • 4 edits
    2 adds in trunk

Positioned, replaced elements with intrinsic width keywords compute the wrong width
​https://bugs.webkit.org/show_bug.cgi?id=110393

Reviewed by Emil A Eklund.

Source/WebCore:

Test: fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
Add the intrinsic size keywords to the switch. Confusingly, we have to
subtract the border and padding since the callers expect the content width.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):
Don't do the intrinsic ratio calculation if the width is an
intrinsic width keyword, as per, ​http://dev.w3.org/csswg/css3-sizing/#replaced-intrinsic.

(WebCore::RenderReplaced::computeIntrinsicLogicalWidths):
(WebCore::RenderReplaced::computePreferredLogicalWidths):
The old code was trying to apply the intrinsic ratio calculation to
the intrinsic width, which is wrong per spec.

LayoutTests:

  • fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes-expected.txt: Added.
  • fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes.html: Added.
4:49 PM Changeset in webkit [143538] by alecflett@chromium.org
  • 2 edits in trunk/Source/WebCore

LevelDB: Remove excess vector copy
​https://bugs.webkit.org/show_bug.cgi?id=110399

Reviewed by Tony Chang.

Remove an extra copy introduced by the makeVector function.

No new tests, this is covered by existing tests.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::safeGet):

4:48 PM Changeset in webkit [143537] by Simon Fraser
  • 18 edits in trunk

Zoomed, slow-scrolling pages keep recreating tiles when scrolled
​https://bugs.webkit.org/show_bug.cgi?id=110379

Source/WebCore:

Reviewed by Tim Horton.

On slow-scrolling pages the TileCache makes the tiles the size of
the visible rect to minimize per-tile painting overhead. If the size
of that rect changes, the TileCache re-creates all the tiles.

This was a problem whem zoomed, because mapping the visible rect
through the scale transform and then rounding it would cause the
size to keep changing, causing lots of tile re-creation.

Fix by carrying the visibleRect around as a FloatRect, and doing
the same for the exposedRect. We then only expand to integers
when computing the tile size. This also fixes an issue where we could
sometimes make extra tiles because of fractional bits of tiles at the edges,
as shown by the test result change.

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateVisibleRect):

  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setVisibleRect):
(WebCore::TileCache::setExposedRect):
(WebCore::TileCache::prepopulateRect):
(WebCore::TileCache::computeTileCoverageRect):
(WebCore::TileCache::tileSizeForCoverageRect):
(WebCore::TileCache::blankPixelCountForTiles):
(WebCore::TileCache::revalidateTiles):
(WebCore::TileCache::ensureTilesForRect):

  • platform/graphics/ca/mac/WebTileLayer.mm:

(-[WebTileLayer logFilledFreshTile]):

Source/WebKit2:

Reviewed by Tim Horton.

Make the visible rect and exposed rects passed through
the drawing area to the tile cache FloatRects instead of IntRects.

  • UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView setMinimumWidthForAutoLayout:]):

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::viewExposedRectChanged):

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setExposedRect):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::viewExposedRectChanged):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):

LayoutTests:

Reviewed by Tim Horton.

This test now just has one tile, rather than four. There is an apparent issue
with the integral tile cache coverage rect being smaller than the visible rect.
This is caused by rounding when dumping the tile coverage rect.

  • platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
4:46 PM HackingOnNewRunWebKitTests edited by dpranke@chromium.org
(diff)
4:45 PM HackingOnNewRunWebKitTests edited by dpranke@chromium.org
actually fill out a high-level overview of how things work. (diff)
4:45 PM Changeset in webkit [143536] by roger_fong@apple.com
  • 9 edits in trunk/Source

Unreviewed. Remove references to SAFARI_THEME from Windows Solution.
<rdar://problem/13258710>

  • config.h:
  • page/Settings.cpp:
  • page/Settings.h:
  • platform/win/ScrollbarThemeWin.cpp:
  • rendering/RenderThemeWin.cpp:
  • WebKitClassFactory.cpp:
  • WebView.cpp:
4:33 PM Changeset in webkit [143535] by jchaffraix@webkit.org
  • 6 edits
    4 adds in trunk

[CSS Grid Layout] Implement the auto-placement algorithm without grid growth
​https://bugs.webkit.org/show_bug.cgi?id=110277

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-grid-layout/grid-item-addition-auto-placement-update.html

fast/css-grid-layout/grid-item-removal-auto-placement-update.html
fast/css-grid-layout/grid-auto-flow-resolution.html (extended to cover more cases)

This change implements most of the auto-placement algorithm per
​http://dev.w3.org/csswg/css3-grid-layout/#auto-placement-algo

To limit the size of the code change, it doesn't implement growing the grid if there
are no empty grid areas. If we don't find any empty grid areas, we just insert in the first
one, like what grid-auto-flow: none would do (which explains the test failures).

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridIterator::nextEmptyGridArea):
Added this function to return the GridCoordinate of the next empty grid area along
the iterator's direction.

(WebCore::RenderGrid::placeItemsOnGrid):
Split this function into the different steps below. For efficiency, collect the auto vs specified
major axis grid items in different Vectors.

(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
Added this function that implements part of step 1 of the algorithm (the grid items without
auto row / column are already handled in placeItemsOnGrid).

(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid):
Added this function that iterates over the auto grid items and call placeAutoMajorAxisItemOnGrid.

(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
Added this method to handle the step 4 of the algorithm. Based on the minor axis's position,
it either walks along the major axis once or several times until it finds an empty grid area
for the grid item.

(WebCore::RenderGrid::autoPlacementMajorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMinorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMajorAxisDirection):
(WebCore::RenderGrid::autoPlacementMinorAxisDirection):
Added these helper functions that return minor / major axis positions & direction.

  • rendering/RenderGrid.h:

Added the previous new RenderGrid functions.

LayoutTests:

  • fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
  • fast/css-grid-layout/grid-auto-flow-resolution.html:
  • fast/css-grid-layout/grid-item-addition-auto-placement-update-expected.txt: Added.
  • fast/css-grid-layout/grid-item-addition-auto-placement-update.html: Added.
  • fast/css-grid-layout/grid-item-removal-auto-placement-update-expected.txt: Added.
  • fast/css-grid-layout/grid-item-removal-auto-placement-update.html: Added.

The current algorithm doesn't grow the grid but falls back to inserting the element at
position (1, 1). The failures in these tests are due to that.

4:32 PM Changeset in webkit [143534] by jchaffraix@webkit.org
  • 1 edit
    2 deletes in branches/chromium/1410

Revert 130774

max-width property is does not overriding the width properties for css tables(display:table)
​https://bugs.webkit.org/show_bug.cgi?id=98455

Patch by Pravin D <​pravind.2k4@gmail.com> on 2012-10-09
Reviewed by Tony Chang.

Source/WebCore:

The max-width property determines the maximum computed width an element can have. In case of css tables(display:table),
the computed was not being limited by the max-width property. The current patch fixes this issue.

Test: fast/table/css-table-max-width.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::updateLogicalWidth):

Logic to compute the logical width of an element such that it does not exceed the max-width value.
Also when both min-width and max-width are present, the following contraint is used to compute the logical width:

1) min-width < Computed LogicalWidth < max-width, when min-width < max-width.
2) Computed LogicalWidth = min-width, when min-width > max-width.

LayoutTests:

  • fast/table/css-table-max-width-expected.txt: Added.
  • fast/table/css-table-max-width.html: Added.

TBR=​tony@chromium.org
Review URL: ​https://codereview.chromium.org/12316027

4:32 PM Changeset in webkit [143533] by scheib@chromium.org
  • 6 edits
    2 copies
    6 adds in trunk

Accept 'allowfullscreen' in addition to 'webkitallowfullscreen'.
​https://bugs.webkit.org/show_bug.cgi?id=110374

Reviewed by Adam Barth.

Source/WebCore:

The fullscreen API also includes a new HTML attribute for iframes
which permits its use. That attribute, 'allowfullcreen' is now
included in the HTML specification [1] and is stable enough
to remove the webkit prefix.

[1] ​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-allowfullscreen

Tests: fullscreen/full-screen-enabled-prefixed.html

fullscreen/full-screen-iframe-allowed-prefixed.html
fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute.html

  • dom/Document.cpp:

(WebCore::isAttributeOnAllOwners):
(WebCore::Document::fullScreenIsAllowedForElement):
(WebCore::Document::webkitFullscreenEnabled):

  • html/HTMLAttributeNames.in:

LayoutTests:

Two previous tests duplicated to preserve testing webkitallowfullscreen
and then modified to test allowfullscreen.

A new test 'full-screen-iframe-with-mixed-allow-webkitallow-attribute.html'
added to test a mixed nesting of iframs with both allowfullscreen and
webkitallowfullscreen.

  • fullscreen/full-screen-enabled-prefixed-expected.txt: Added.
  • fullscreen/full-screen-enabled-prefixed.html: Copied from LayoutTests/fullscreen/full-screen-enabled.html.
  • fullscreen/full-screen-enabled.html:
  • fullscreen/full-screen-iframe-allowed-prefixed-expected.txt: Added.
  • fullscreen/full-screen-iframe-allowed-prefixed.html: Copied from LayoutTests/fullscreen/full-screen-iframe-allowed.html.
  • fullscreen/full-screen-iframe-allowed.html:
  • fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute-expected.txt:
  • fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute.html: Added.
  • fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe1.html: Added.
  • fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe2.html: Added.
4:31 PM Changeset in webkit [143532] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Re-enable 3D CSS transforms when using build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=110402

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-02-20
Reviewed by Xan Lopez.

  • Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default

when building WebKitGTK+.

4:20 PM Changeset in webkit [143531] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 142365
BUG=174017
Review URL: ​https://codereview.chromium.org/12310030

4:17 PM Changeset in webkit [143530] by cevans@google.com
  • 15 edits in branches/chromium/1364

Merge 142759
BUG=174566
Review URL: ​https://codereview.chromium.org/12316026

4:07 PM Changeset in webkit [143529] by roger_fong@apple.com
  • 81 edits
    2 moves
    33 adds
    1 delete in trunk

Get VS2010 Solution B&I ready.
<rdar://problem/1322988>

Rubberstamped by Timothy Horton.

Add Production configuration.
Add a submit solutions with a DebugSuffix configuration.
Modify B&I make files as necessary.

4:05 PM Changeset in webkit [143528] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1410

Merge 143454
BUG=176738
Review URL: ​https://codereview.chromium.org/12316025

4:02 PM Changeset in webkit [143527] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 142358
BUG=173402
Review URL: ​https://codereview.chromium.org/12310028

4:00 PM Changeset in webkit [143526] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

[v8] Fix an erroneous WrapperGrouper call in preparation for refactoring
​https://bugs.webkit.org/show_bug.cgi?id=110396

Reviewed by Kentaro Hara.

This is in preparation for a refactor to expose a simplified
WrapperGrouper interface to V8 wrapper classes enabling them to
specify multiple roots per wrapper object.

  • bindings/v8/V8GCController.cpp: Since MutationObservers are not Nodes, the correct call here is addObjectToGroup, as it is for all other non-Node wrappers.
3:59 PM Changeset in webkit [143525] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 142657
BUG=173399
Review URL: ​https://codereview.chromium.org/12330035

3:58 PM Changeset in webkit [143524] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 142539
BUG=173068
Review URL: ​https://codereview.chromium.org/12318024

3:53 PM Changeset in webkit [143523] by cevans@google.com
  • 3 edits in branches/chromium/1410/Source

Merge 143347
BUG=174627
Review URL: ​https://codereview.chromium.org/12321031

3:52 PM Changeset in webkit [143522] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/1364

Merge 143514
BUG=176882
Review URL: ​https://codereview.chromium.org/12327026

3:50 PM Changeset in webkit [143521] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/1410

Merge 143514
BUG=176882
Review URL: ​https://codereview.chromium.org/12318023

3:44 PM Changeset in webkit [143520] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

Line layout (but not pref widths) double-counts word spacing when between inlines
​https://bugs.webkit.org/show_bug.cgi?id=110381

Reviewed by Emil A Eklund.

Source/WebCore:

When a word break with a space occurs between inlines and word-spacing is non-zero,
line layout incorrectly committed the word-spacing value to the line twice, causing
wrapping in inline-blocks. To fix this, clear the word-spacing value when between
words and ignoring spaces, as we will already have added the word-spacing to the
line.

Test: fast/text/word-space-between-inlines.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/text/word-space-between-inlines-expected.html: Added.
  • fast/text/word-space-between-inlines.html: Added.
3:44 PM Changeset in webkit [143519] by cevans@google.com
  • 2 edits in branches/chromium/1410/Source/WebKit/chromium

Merge 142564
BUG=174895
Review URL: ​https://codereview.chromium.org/12310026

3:31 PM Changeset in webkit [143518] by nghanavatian@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Check offset for initialized value
​https://bugs.webkit.org/show_bug.cgi?id=110390

Reviewed by Rob Buis.

Instead of checking isEmpty, which checks for either point being <= 0, we want to explicitly check
for the initialized value of (-1, -1). This would be set in redrawSpellCheckDialogIfRequired, and
triggers the restore from cache in requestSpellingCheckingOptions.

Internally reviewed by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

3:29 PM Changeset in webkit [143517] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/editing/CompositeEditCommand.cpp

Merge 142642
BUG=175342
Review URL: ​https://codereview.chromium.org/12324025

3:25 PM Changeset in webkit [143516] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp

Merge 141851
BUG=172926
Review URL: ​https://codereview.chromium.org/12317033

3:21 PM Changeset in webkit [143515] by kareng@chromium.org
  • 4 edits in branches/chromium/1410/Source

Merge 142755

[Qt] window.open passes height and width parameters even if not defined in a page
​https://bugs.webkit.org/show_bug.cgi?id=107705

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Do not override width or height of 0, as that indicates default size, and not minimum size.

Tested by tst_qwebpage.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::adjustWindowRect):

Source/WebKit/efl:

Do not resize window when default size is requested.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::setWindowRect):

Source/WebKit/gtk:

Do not resize window when default size is requested.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::setWindowRect):

Source/WebKit/qt:

Test that minimum size is applied only when the requested size is too small,
not when default is requested.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage):
(TestPage):
(TestPage::TestPage):
(TestPage::createWindow):
(TestPage::slotGeometryChangeRequested):
(tst_QWebPage::openWindowDefaultSize):

TBR=​allan.jensen@digia.com
Review URL: ​https://codereview.chromium.org/12320020

3:13 PM Changeset in webkit [143514] by Nate Chapin
  • 3 edits
    4 adds in trunk

Source/WebCore: Crash in WebCore::FrameLoader::checkCompleted()
​https://bugs.webkit.org/show_bug.cgi?id=110237

Reviewed by Abhishek Arya.

Test: http/tests/misc/delete-frame-during-readystatechange.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkCompleted): Protect before setReadyState() is called.

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=110237

Reviewed by Abhishek Arya.

  • http/tests/misc/delete-frame-during-readystatechange-expected.txt: Added.
  • http/tests/misc/delete-frame-during-readystatechange.html: Added.
  • http/tests/misc/resources/delete-frame-during-readystatechange-frame.html: Added.
  • http/tests/misc/resources/empty.ogv: Added.
3:04 PM Changeset in webkit [143513] by cevans@google.com
  • 2 edits in branches/chromium/1364/Source/WebCore/Modules/webaudio

Merge 142687
BUG=172331
Review URL: ​https://codereview.chromium.org/12321030

3:00 PM Changeset in webkit [143512] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Limit LevelDB's max open files
​https://bugs.webkit.org/show_bug.cgi?id=109993

Reviewed by Tony Chang.

LevelDB keeps up to 1000 (by default) data files open at a time to
avoid having to open() them. This has caused chromium to hit the
process-wide open file limit. This patch changes max_open_files to 20,
as that's the minimum permitted by LevelDB and we have no reason to
think that performance will suffer because of the extra open calls.

No new tests - a chromium browser test that tracks the open LevelDB
files is plausible but is blocked on ​http://crbug.com/177249/.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::openDB):

2:56 PM Changeset in webkit [143511] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Add gyp option to switch ENABLE(SQL_DATABASE)
​https://bugs.webkit.org/show_bug.cgi?id=109303
​http://code.google.com/p/chromium/issues/detail?id=22208

Patch by Paweł Hajdan, Jr. <​phajdan.jr@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

This will be useful to implement build with system sqlite.

  • features.gypi:
  • src/ChromeClientImpl.cpp:

(WebKit):

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

2:54 PM Changeset in webkit [143510] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 142816
BUG=171557
Review URL: ​https://codereview.chromium.org/12315018

2:49 PM Changeset in webkit [143509] by jer.noble@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

EME: Enable both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 until clients transition to the new API.
​https://bugs.webkit.org/show_bug.cgi?id=110284

Reviewed by Eric Carlson.

Re-enable the ENCRYPTED_MEDIA flag.

  • Configurations/FeatureDefines.xcconfig:
2:39 PM Changeset in webkit [143508] by cevans@google.com
  • 3 edits in branches/chromium/1364

Merge 142063
BUG=173906
Review URL: ​https://codereview.chromium.org/12324023

2:24 PM Changeset in webkit [143507] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 142922
BUG-170679
Review URL: ​https://codereview.chromium.org/12310023

2:16 PM Changeset in webkit [143506] by hyatt@apple.com
  • 8 edits
    2 adds in trunk

[New Multicolumn] Resize RenderMultiColumnSets around their columns.
​https://bugs.webkit.org/show_bug.cgi?id=110378.

Reviewed by Dirk Schulze.

Source/WebCore:

Test: fast/multicol/newmulticol/positioned-with-constrained-height.html.

  • rendering/RenderBlock.h:

(RenderBlock):
Make computeOverflow public so that RenderMultiColumnFlowThread can
access it.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::layout):
Subclass layout to recompute the overflow for RenderMultiColumnBlock
after the flow thread has finished layout. This way it can account
for changes in RenderMultiColumnSets without having to do a second
layout pass.

  • rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):
Override layout().

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::columnCount):
Clean up a comment that referred to portions as region rects still.

(WebCore::RenderMultiColumnSet::setFlowThreadPortionRect):

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderRegion.h:

(WebCore::RenderRegion::setFlowThreadPortionRect):
Make setFlowThreadPortionRect virtual and actually mutate the size
and position of RenderMultiColumnSets so that they enclose their
column rects.

LayoutTests:

  • fast/multicol/newmulticol/positioned-with-constrained-height-expected.html: Added.
  • fast/multicol/newmulticol/positioned-with-constrained-height.html: Added.
2:14 PM Changeset in webkit [143505] by krit@webkit.org
  • 22 edits in trunk

Enable CANVAS_PATH flag
​https://bugs.webkit.org/show_bug.cgi?id=108508

Reviewed by Simon Fraser.

Enable CANVAS_PATH flag on trunk.

.:

Existing tests cover the feature.

  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

Existing tests cover the feature.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Existing tests cover the feature.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Existing tests cover the feature.

  • fast/canvas/canvas-path-object-expected.txt:
  • inspector/profiler/canvas2d/canvas2d-api-changes.html:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
2:03 PM Changeset in webkit [143504] by tony@chromium.org
  • 3 edits in trunk/Tools

Parse author names with commas in ChangeLogs
​https://bugs.webkit.org/show_bug.cgi?id=110356

Reviewed by Dirk Pranke.

Paweł's name has a comma in it, which was confusing the ChangeLog parser.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry): Move name splitting regexp into a constant.
(ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
(ChangeLogEntry._split_reviewer_names): Rename to be more specific.
(ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
(ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_parse_authors): Test case with Paweł's name.

1:56 PM Changeset in webkit [143503] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r143441.
​http://trac.webkit.org/changeset/143441
​https://bugs.webkit.org/show_bug.cgi?id=110376

May be causing chromium content_browsertests failures.
(Requested by vollick on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-20

  • bindings/v8/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):

  • bindings/v8/ScriptValue.h:

(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(WebCore::ScriptValue::v8Value):
(ScriptValue):

  • bindings/v8/SharedPersistent.h:

(WebCore):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::scriptValueAsNode):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAttrGetterCustom):

1:53 PM Changeset in webkit [143502] by krit@webkit.org
  • 11 edits in trunk

[Chromium] Add runtime flag for CanvasPath
​https://bugs.webkit.org/show_bug.cgi?id=109997

Reviewed by Adam Barth.

Source/WebCore:

Add runtime flag for Chromium.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setCanvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::canvasPathEnabled):

  • html/canvas/DOMPath.idl:
  • page/DOMWindow.idl:

Source/WebKit/chromium:

Add runtime flag for Chromium.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableCanvasPath):
(WebKit):
(WebKit::WebRuntimeFeatures::isCanvasPathEnabled):

Tools:

Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
the constructor for Path on DOMWindow would never be activatable, since the script
is running after creating the DOMWindow object.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

1:53 PM Changeset in webkit [143501] by cevans@google.com
  • 4 edits
    2 copies in branches/chromium/1364

Merge 143060
Review URL: ​https://codereview.chromium.org/12328018

1:48 PM Changeset in webkit [143500] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

Patch by Ian Vollick <​vollick@chromium.org> on 2013-02-20

  • platform/chromium/TestExpectations:
1:45 PM Changeset in webkit [143499] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Remove unnecessary includes for Platform.h from headers
​https://bugs.webkit.org/show_bug.cgi?id=110300

Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-20
Reviewed by Alexey Proskuryakov.

Source/WebCore:

wtf/Platform.h only need to be included in a few places directly
as it is included in config.h. Remove the unnecessay duplicate as
it can be confusing.

No new tests, no change in functionality.

  • platform/SecureTextInput.h:
  • platform/audio/Biquad.h:
  • platform/audio/FFTFrame.h:
  • platform/graphics/cpu/arm/filters/FEBlendNEON.h:
  • platform/graphics/cpu/arm/filters/NEONHelpers.h:
  • platform/graphics/filters/FELighting.h:

Source/WebKit2:

wtf/Platform.h only need to be included in a few places directly
as it is included in config.h. Remove the unnecessay duplicate as
it can be confusing.

  • Shared/PrintInfo.h:
1:43 PM Changeset in webkit [143498] by fmalita@chromium.org
  • 3 edits in trunk/Source/WebCore

[SVG] Update of element referenced by multiple 'use' nodes is absurdly slow
​https://bugs.webkit.org/show_bug.cgi?id=97905

Reviewed by Dirk Schulze.

Rebuilding the shadow and instance trees of dependent use nodes recursively can be
extremely inefficient with non-trivial dependency graphs (the trees are not constructed
in topological order).

To avoid redundant buildShadowAndInstanceTree() invokations, separate the invalidation
phase from the actual tree (re)building phase, and only descend into the dependency DAG
during the invalidation phase (recursion also stops at nodes that have been previously
invalidated).

No new tests: functional coverage provided by existing tests, perfomance tracked by
PerformanceTests/SVG/SvgNestedUse.html.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::invalidateShadowTree):
(WebCore):
(WebCore::SVGUseElement::invalidateDependentShadowTrees):

  • svg/SVGUseElement.h:

(SVGUseElement):

1:34 PM Changeset in webkit [143497] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

Patch by Ian Vollick <​vollick@chromium.org> on 2013-02-20

  • platform/chromium/TestExpectations:
1:31 PM Changeset in webkit [143496] by pilgrim@chromium.org
  • 4 edits in trunk/Source

[Chromium] Move WebKitPlatformSupport declaration to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=110262

Reviewed by Adam Barth.

In preparation for removing WebKitPlatformSupport.h entirely (once
downstream references to that file have been updated). Part of a
larger refactoring series; see tracking bug 82948.

Source/Platform:

  • chromium/public/Platform.h:

(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
(WebKit):

Source/WebKit/chromium:

  • public/platform/WebKitPlatformSupport.h:
1:28 PM Changeset in webkit [143495] by robert@webkit.org
  • 3 edits in trunk/LayoutTests

Make the test land in r143482 less platform-specific

Add outline:none to the test so platform-specific outlines don't kick in and
make us require separate results for Mac and Linux.

Unreviewed, gardening.

  • fast/repaint/paint-caret-in-div-with-negative-indent-expected.png:
  • fast/repaint/paint-caret-in-div-with-negative-indent.html:
1:27 PM Changeset in webkit [143494] by cevans@google.com
  • 5 edits
    2 deletes in branches/chromium/1364

Revert 143493
Review URL: ​https://codereview.chromium.org/12314017

1:24 PM Changeset in webkit [143493] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/1364

Merge 142820
BUG=170184

1:20 PM Changeset in webkit [143492] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/1364

Merge 142500
BUG=169398
Review URL: ​https://codereview.chromium.org/12327019

1:15 PM Changeset in webkit [143491] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 142899
BUG=168982
Review URL: ​https://codereview.chromium.org/12315016

1:15 PM Changeset in webkit [143490] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

RenderLayerBacking should initialize TiledBacking's isInWindow state with Page's isInWindow, not isOnscreen
​https://bugs.webkit.org/show_bug.cgi?id=110370
<rdar://problem/13254006>

Reviewed by Simon Fraser.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

1:10 PM Changeset in webkit [143489] by mark.lam@apple.com
  • 5 edits in trunk/Source/WebCore

Cleanup the SQLTransaction and SQLTransactionBackend state dispatch
to only honor a state transition request if the associated database
hasn't been interrupted.
​https://bugs.webkit.org/show_bug.cgi?id=110247.

Reviewed by Antti Koivisto.

No new tests.

  • Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::performPendingCallback):
(WebCore::SQLTransaction::computeNextStateAndCleanupIfNeeded):

  • Modules/webdatabase/SQLTransaction.h:
  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::computeNextStateAndCleanupIfNeeded):
(WebCore::SQLTransactionBackend::performNextStep):

  • Modules/webdatabase/SQLTransactionBackend.h:
1:09 PM Changeset in webkit [143488] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

Moar hardening
​https://bugs.webkit.org/show_bug.cgi?id=110275

Reviewed by Mark Hahnenberg.

We now poison objects when they get freed, and verify that
any object that is being freed is not poisoned. If the
object looks like it's poisoned we validate the freelist,
and ensure the object is not already present. If it is
we crash.

On allocation, we ensure that the object being allocated
is poisoned, then clear the poisoning fields.

  • wtf/FastMalloc.cpp:

(WTF::internalEntropyValue):
(WTF):
(WTF::freedObjectStartPoison):
(WTF::freedObjectEndPoison):
(TCMalloc_ThreadCache_FreeList):
(WTF::TCMalloc_ThreadCache_FreeList::Validate):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

1:02 PM Changeset in webkit [143487] by ap@apple.com
  • 10 edits in trunk/Source/WebCore

ResourceHandle::loadResourceSynchronously should have blob support in cross-platform code
​https://bugs.webkit.org/show_bug.cgi?id=110364

Reviewed by Anders Carlsson.

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Added a cross-platform version to keep blob-related logic in one place.
  • platform/network/blackberry/ResourceHandleBlackBerry.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously): Renamed loadResourceSynchronously to platformLoadResourceSynchronously, removed blob handling from platforms that had it.
1:00 PM Changeset in webkit [143486] by hyatt@apple.com
  • 3 edits
    10 adds in trunk

[New Multicolumn] RenderMultiColumnFlowThreads should establish a BFC.
​https://bugs.webkit.org/show_bug.cgi?id=110366.

Reviewed by Antti Koivisto.

Source/WebCore:

RenderFlowThreads should establish a block formatting context always.
CSS Regions have named flow thread that they absolutely position, and so
they got this for free by being absolutely positioned.

RenderMultiColumnFlowThreads, however, are relative positioned, so we need
to just add an isRenderFlowThread case specifically so we're not dependent
on the positioning scheme used for the flow thread to establish the BFC.

Test: fast/multicol/newmulticol/float-*.html.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):

LayoutTests:

  • fast/multicol/newmulticol/float-avoidance-expected.html: Added.
  • fast/multicol/newmulticol/float-avoidance.html: Added.
  • fast/multicol/newmulticol/float-multicol-expected.html: Added.
  • fast/multicol/newmulticol/float-multicol.html: Added.
  • fast/multicol/newmulticol/float-paginate-complex-expected.html: Added.
  • fast/multicol/newmulticol/float-paginate-complex.html: Added.
  • fast/multicol/newmulticol/float-paginate-empty-lines-expected.html: Added.
  • fast/multicol/newmulticol/float-paginate-empty-lines.html: Added.
  • fast/multicol/newmulticol/float-paginate-expected.html: Added.
  • fast/multicol/newmulticol/float-paginate.html: Added.
12:14 PM Changeset in webkit [143485] by fmalita@chromium.org
  • 2 edits in branches/chromium/1410/Source/Platform

Merge 142496

[Chromium] FilterTypeSaturatingBrightness enum
​https://bugs.webkit.org/show_bug.cgi?id=109380

Introduce a new WebFilterOperation::FilterType enum (FilterTypeSaturatingBrightness)
to support existing interntal clients which rely on the current saturating brightness
behavior (in preparation of switching to the new brightness implementation).

Reviewed by James Robinson.

  • chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::createSaturatingBrightnessFilter):
(WebKit::WebFilterOperation::setAmount):

TBR=​jamesr@chromium.org
Review URL: ​https://codereview.chromium.org/12321021

11:58 AM Changeset in webkit [143484] by hyatt@apple.com
  • 4 edits
    2 adds in trunk

[New Multicolumn] Column gap is computed incorrectly.
​https://bugs.webkit.org/show_bug.cgi?id=110360.

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/multicol/newmulticol/layers-split-across-columns.html.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::columnGap):
Make sure we ask the RenderMultiColumnBlock for the gap rather than our
own style, since we don't actually have the gap value in our style.

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):

  • rendering/RenderMultiColumnSet.h:

Fix another spot where the columnGap was an int. It should be a LayoutUnit.

LayoutTests:

  • fast/multicol/newmulticol/layers-split-across-columns-expected.html: Added.
  • fast/multicol/newmulticol/layers-split-across-columns.html: Added.
11:51 AM Changeset in webkit [143483] by robert@webkit.org
  • 3 edits
    3 adds in trunk

No caret on empty contenteditable element with negative text-indent
​https://bugs.webkit.org/show_bug.cgi?id=108633

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/repaint/paint-caret-in-div-with-negative-indent.html

When an editable element has a negative text indent we won't paint the caret when the
element is empty because it falls outside the element's border box. To ensure the caret is painted,
account for any negative indent with our overflow.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

LayoutTests:

  • fast/repaint/paint-caret-in-div-with-negative-indent-expected.png: Added.
  • fast/repaint/paint-caret-in-div-with-negative-indent-expected.txt: Added.
  • fast/repaint/paint-caret-in-div-with-negative-indent.html: Added.
11:09 AM Changeset in webkit [143482] by Lucas Forschler
  • 18 edits in tags/Safari-537.31.5/Source

Merged r143418. <rdar://problem/13067171>

11:01 AM Changeset in webkit [143481] by Lucas Forschler
  • 2 edits
    1 delete in tags/Safari-537.31.5/Source/WebKit2

Merged r143113. <rdar://problem/13236883>

10:45 AM Changeset in webkit [143480] by jochen@chromium.org
  • 7 edits in trunk/Tools

[chromium] use a WebTestProxyBase pointer to identify the window we need the history for
​https://bugs.webkit.org/show_bug.cgi?id=110346

Reviewed by Adam Barth.

Using an index is very brittle, as the TestRunner API does not define
any ordering of windows.

Also, make TestRunner::shouldDumpBackForwardList() so content shell can
trigger the capturing in the browser process before generating the
text dump.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestRunner):
(WebTestRunner::WebTestDelegate::captureHistoryForWindow):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::captureTree):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::captureHistoryForWindow):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

10:45 AM Changeset in webkit [143479] by ojan@chromium.org
  • 7 edits in trunk/Source/WebCore

Remove stretchesToMinIntrinsicLogicalWidth
​https://bugs.webkit.org/show_bug.cgi?id=110266

Reviewed by Emil Eklund.

This was only used by fieldsets and now we have a way to express this
concept in CSS.

  • WebCore.order:
  • css/html.css:

Make fieldsets min-width: -webkit-min-content.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computePositionedLogicalWidth):

  • rendering/RenderBox.h:

Remove all calls to stretchesToMinIntrinsicLogicalWidth.

10:41 AM Changeset in webkit [143478] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.5/Source

Versioning.

10:37 AM Changeset in webkit [143477] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.5

New Tag.

10:37 AM Changeset in webkit [143476] by ojan@chromium.org
  • 4 edits
    4 adds in trunk

Make intrinsic width values work for positioned elements
​https://bugs.webkit.org/show_bug.cgi?id=110264

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-intrinsic-dimensions/intrinsic-sized-absolutes.html

fast/css-intrinsic-dimensions/width-shrinks-avoid-floats.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
Move the computation of intrinsic widths out into a helper function so that
computePositionedLogicalWidthUsing can use it. As per the current spec,
fill-available measures shrink to avoid floats. ​http://dev.w3.org/csswg/css3-sizing/

(WebCore::RenderBox::computePositionedLogicalWidth):
Compute intrinsic min-widths in addition to non-zero ones. Intrinsic widths
return true for isZero. width and max-width don't need modifying since they already
call computePositionedLogicalWidthUsing for intrinsic widths.

(WebCore::RenderBox::computePositionedLogicalWidthUsing):
Compute intrinsic widths and use a Fixed length for the rest of the positioned width
computation. Doesn't include bordersPlusPadding because the caller, expected the content
width and adds in the bordersPlusPadding later.

  • rendering/RenderBox.h:

LayoutTests:

  • fast/css-intrinsic-dimensions/intrinsic-sized-absolutes-expected.txt: Added.
  • fast/css-intrinsic-dimensions/intrinsic-sized-absolutes.html: Added.
  • fast/css-intrinsic-dimensions/width-shrinks-avoid-floats-expected.txt: Added.
  • fast/css-intrinsic-dimensions/width-shrinks-avoid-floats.html: Added.
10:27 AM Changeset in webkit [143475] by robert@webkit.org
  • 3 edits
    4 adds in trunk

input element with placeholder text and width set to 100% on focus causes overflow even after losing focus
​https://bugs.webkit.org/show_bug.cgi?id=109020

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/forms/input-placeholder-layout-view.html

fast/forms/textarea-placeholder-layout-view.html

Placeholder elements don't affect layout so shouldn't contribute overflow either.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):

LayoutTests:

  • fast/forms/input-placeholder-layout-view-expected.html: Added.
  • fast/forms/input-placeholder-layout-view.html: Added.
  • fast/forms/textarea-placeholder-layout-view-expected.html: Added.
  • fast/forms/textarea-placeholder-layout-view.html: Added.
10:23 AM Changeset in webkit [143474] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit2

[WK2] Remove m_viewportSize in WebPage.
​https://bugs.webkit.org/show_bug.cgi?id=110311

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-02-20
Reviewed by Anders Carlsson.

EFL and Qt use m_viewSize as a contents size while Apple use it as a viewport
size, so EFL and Qt introduced m_viewportSize to make WebPage know a viewport
size.

EFL and Qt use m_viewSize as a contents size because the size of non compositing
layer is contents size, and EFL and Qt mark whole non compositing layer as dirty
using m_viewSize. Bug 110299 (​http://webkit.org/b/110299) changes that it is not
necessary to know m_viewSize when marking whole non compositing layer as dirty.
So we can make EFL and Qt use m_viewSize as a viewport size also.

This patch removes m_viewportSize and related methods to increase readability.

  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebView::setSize):

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::didChangeViewportSize):

  • UIProcess/WebPageProxy.cpp:

(WebKit):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::pageRect):
(WebKit::WebChromeClient::contentsSizeChanged):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updateBackingStoreState):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setSize):
(WebKit::WebPage::sendViewportAttributesChanged):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
10:21 AM Changeset in webkit [143473] by pilgrim@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove idbFactory from WebKitPlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=106457

Reviewed by Adam Barth.

Now that ​https://codereview.chromium.org/12230054 has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.

  • public/platform/WebKitPlatformSupport.h:

(WebKit):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

10:10 AM Changeset in webkit [143472] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebKit2

[WK2] add setNeedsDisplay in DrawingArea to mark whole layer as dirty.
​https://bugs.webkit.org/show_bug.cgi?id=110299

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-02-20
Reviewed by Anders Carlsson.

Currently, we call setNeedsDisplay with the size of WebPage to mark whole
backing store as dirty. However, the size of non compositing layer can be
inconsistent with the size of WebPage. For example, in Coordinated Graphics, the
size of non compositing layer is contents size.

So, WebPage should not assume the size of non compositing layer, and should just
call setNeedsDisplay when marking whole layer as dirty.

In addition, this patch renames from setNeedsDisplay() with a rect argument to
setNeedsDisplayInRect(), which matches to the terms of GraphicsLayer.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateContentsAndRootView):
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::restoreViewState):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::setNonCompositedContentsNeedDisplay):
(WebKit):
(WebKit::CoordinatedLayerTreeHost::setNonCompositedContentsNeedDisplayInRect):
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

(CoordinatedLayerTreeHost):

  • WebProcess/WebPage/DrawingArea.h:

(DrawingArea):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit):
(WebKit::DrawingAreaImpl::setNeedsDisplayInRect):
(WebKit::DrawingAreaImpl::scroll):
(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
(WebKit::DrawingAreaImpl::resumePainting):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

  • WebProcess/WebPage/LayerTreeHost.h:

(LayerTreeHost):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setSize):
(WebKit::WebPage::setDrawsBackground):
(WebKit::WebPage::setDrawsTransparentBackground):
(WebKit::WebPage::resumeActiveDOMObjectsAndAnimations):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplay):
(WebKit):
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostGtk::scrollNonCompositedContents):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

(LayerTreeHostGtk):

  • WebProcess/WebPage/mac/LayerTreeHostMac.h:

(LayerTreeHostMac):

  • WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
(WebKit):
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostMac::scrollNonCompositedContents):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

(RemoteLayerTreeDrawingArea):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::setNeedsDisplay):
(WebKit):
(WebKit::RemoteLayerTreeDrawingArea::setNeedsDisplayInRect):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
(WebKit):
(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplayInRect):

9:56 AM Changeset in webkit [143471] by mark.lam@apple.com
  • 36 edits
    2 moves in trunk/Source

Rename DatabaseBackend to DatabaseBackendBase.
​https://bugs.webkit.org/show_bug.cgi?id=110303.

Rubber stamped by Alexey Proskuryakov.

Source/WebCore:

This is a purely cosmetic change to make the naming consistent with
the front-end DatabaseBase.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/webdatabase/AbstractDatabaseServer.h:
  • Modules/webdatabase/Database.cpp:

(WebCore::Database::create):
(WebCore::Database::version):

  • Modules/webdatabase/Database.h:

(Database):

  • Modules/webdatabase/DatabaseBackend.cpp: Removed.
  • Modules/webdatabase/DatabaseBackend.h: Removed.
  • Modules/webdatabase/DatabaseBackendAsync.cpp:

(WebCore::DatabaseBackendAsync::DatabaseBackendAsync):
(WebCore::DatabaseBackendAsync::performOpenAndVerify):

  • Modules/webdatabase/DatabaseBackendAsync.h:
  • Modules/webdatabase/DatabaseBackendBase.cpp: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackend.cpp.

(WebCore::DatabaseBackendBase::databaseInfoTableName):
(WebCore::DatabaseBackendBase::DatabaseBackendBase):
(WebCore::DatabaseBackendBase::~DatabaseBackendBase):
(WebCore::DatabaseBackendBase::closeDatabase):
(WebCore::DatabaseBackendBase::version):
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(DoneCreatingDatabaseOnExitCaller):
(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::securityOrigin):
(WebCore::DatabaseBackendBase::stringIdentifier):
(WebCore::DatabaseBackendBase::displayName):
(WebCore::DatabaseBackendBase::estimatedSize):
(WebCore::DatabaseBackendBase::fileName):
(WebCore::DatabaseBackendBase::details):
(WebCore::DatabaseBackendBase::getVersionFromDatabase):
(WebCore::DatabaseBackendBase::setVersionInDatabase):
(WebCore::DatabaseBackendBase::setExpectedVersion):
(WebCore::DatabaseBackendBase::getCachedVersion):
(WebCore::DatabaseBackendBase::setCachedVersion):
(WebCore::DatabaseBackendBase::getActualVersionForTransaction):
(WebCore::DatabaseBackendBase::disableAuthorizer):
(WebCore::DatabaseBackendBase::enableAuthorizer):
(WebCore::DatabaseBackendBase::setAuthorizerReadOnly):
(WebCore::DatabaseBackendBase::setAuthorizerPermissions):
(WebCore::DatabaseBackendBase::lastActionChangedDatabase):
(WebCore::DatabaseBackendBase::lastActionWasInsert):
(WebCore::DatabaseBackendBase::resetDeletes):
(WebCore::DatabaseBackendBase::hadDeletes):
(WebCore::DatabaseBackendBase::resetAuthorizer):
(WebCore::DatabaseBackendBase::maximumSize):
(WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded):
(WebCore::DatabaseBackendBase::interrupt):
(WebCore::DatabaseBackendBase::isInterrupted):
(WebCore::DatabaseBackendBase::reportOpenDatabaseResult):
(WebCore::DatabaseBackendBase::reportChangeVersionResult):
(WebCore::DatabaseBackendBase::reportStartTransactionResult):
(WebCore::DatabaseBackendBase::reportCommitTransactionResult):
(WebCore::DatabaseBackendBase::reportExecuteStatementResult):
(WebCore::DatabaseBackendBase::reportVacuumDatabaseResult):

  • Modules/webdatabase/DatabaseBackendBase.h: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackend.h.

(DatabaseBackendBase):

  • Modules/webdatabase/DatabaseBackendSync.cpp:

(WebCore::DatabaseBackendSync::DatabaseBackendSync):

  • Modules/webdatabase/DatabaseBackendSync.h:
  • Modules/webdatabase/DatabaseBase.h:
  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
(WebCore::DatabaseManager::getMaxSizeForDatabase):

  • Modules/webdatabase/DatabaseManager.h:

(DatabaseManager):

  • Modules/webdatabase/DatabaseServer.cpp:

(WebCore::DatabaseServer::openDatabase):
(WebCore::DatabaseServer::createDatabase):
(WebCore::DatabaseServer::getMaxSizeForDatabase):

  • Modules/webdatabase/DatabaseServer.h:
  • Modules/webdatabase/DatabaseSync.cpp:

(WebCore::DatabaseSync::create):

  • Modules/webdatabase/DatabaseSync.h:

(DatabaseSync):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):

  • Modules/webdatabase/DatabaseTracker.h:

(DatabaseTracker):

  • Modules/webdatabase/OriginQuotaManager.cpp:

(WebCore::OriginQuotaManager::markDatabase):

  • Modules/webdatabase/OriginQuotaManager.h:

(OriginQuotaManager):

  • Modules/webdatabase/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):

  • Modules/webdatabase/SQLTransactionClient.h:

(SQLTransactionClient):

  • Modules/webdatabase/chromium/DatabaseObserver.h:

(DatabaseObserver):

  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::NotifyDatabaseObserverOnCloseTask::create):
(WebCore::NotifyDatabaseObserverOnCloseTask::NotifyDatabaseObserverOnCloseTask):
(NotifyDatabaseObserverOnCloseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::prepareToOpenDatabase):
(WebCore::DatabaseTracker::failedToOpenDatabase):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::create):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::CloseOneDatabaseImmediatelyTask):
(DatabaseTracker::CloseOneDatabaseImmediatelyTask):
(WebCore::DatabaseTracker::closeOneDatabaseImmediately):

  • Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp:

(WebCore::NotifyDatabaseChangedTask::create):
(WebCore::NotifyDatabaseChangedTask::NotifyDatabaseChangedTask):
(NotifyDatabaseChangedTask):
(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

  • public/WebDatabase.h:

(WebDatabase):

  • src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):
(WebCore::DatabaseObserver::reportOpenDatabaseResult):
(WebCore::DatabaseObserver::reportChangeVersionResult):
(WebCore::DatabaseObserver::reportStartTransactionResult):
(WebCore::DatabaseObserver::reportCommitTransactionResult):
(WebCore::DatabaseObserver::reportExecuteStatementResult):
(WebCore::DatabaseObserver::reportVacuumDatabaseResult):

  • src/WebDatabase.cpp:

(WebKit::WebDatabase::WebDatabase):

9:48 AM Changeset in webkit [143470] by tony@chromium.org
  • 7 edits
    2 adds in trunk

Source/WebKit/chromium: Fix use after free in ContextMenuClientImpl.cpp
​https://bugs.webkit.org/show_bug.cgi?id=109220

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

ContextMenuClientImpl can use a DocumentMarker after it is freed. The DocumentMarker is originally allocated
by the spell checker. When the user context-clicks on a misspelling, ContextMenuClientImpl saves a reference
to the clicked DocumentMarker, changes the selection, and then uses the DocumentMarker. Changing the selection
causes re-check of spelling. If the spell check client serves the spellcheck request from cache, then re-checking
spelling will delete the DocumentMarker and add a new one. This invalidates the DocumentMarker reference held by
ContextMenuClientImpl. When ContextMenuClientImpl attempts to use the DocumentMarker, Address Sanitizer detects
use after free. The fix is to save a copy of the DocumentMarker before changing selection.

  • src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspellingAsync): Save a copy of DocumentMarker before changing selection.
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Use DocumentMarker instead of Vector<DocumentMarker*>.

Tools: [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
​https://bugs.webkit.org/show_bug.cgi?id=109220

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-02-19
Reviewed by Tony Chang.

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
(WebTestRunner):
(WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
(WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

  • DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.

LayoutTests: Spellchecker should not crash after text has changed and spellcheck results are served from cache
​https://bugs.webkit.org/show_bug.cgi?id=109220

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

  • editing/spelling/spelling-changed-text-expected.txt: Added the expected output for serving spellcheck results from cache for edited text.
  • editing/spelling/spelling-changed-text.html: Added a test for serving spellcheck results from cache for edited text.
9:33 AM WebKit Team edited by mvujovic@adobe.com
Add Max Vujovic to committers list. (diff)
9:23 AM Changeset in webkit [143469] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

iOS does not use CaptionUserPreferencesMac
​https://bugs.webkit.org/show_bug.cgi?id=110259

Reviewed by Dean Jackson.

  • page/CaptionUserPreferencesMac.h: Add PLATFORM(IOS) guard
  • page/CaptionUserPreferencesMac.mm: Ditto.
  • page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferences): Ditto.

9:15 AM Changeset in webkit [143468] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r183552. Requested by
"Mark Pilgrim" <​pilgrim@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-20

  • DEPS:
9:10 AM WebKit Team edited by hmuller@adobe.com
Added Hans Muller to list of committers (diff)
8:59 AM Changeset in webkit [143467] by hyatt@apple.com
  • 6 edits
    2 adds in trunk

[New Multicolumn] Make layers paint properly in columns.
​https://bugs.webkit.org/show_bug.cgi?id=110296.

Reviewed by Sam Weinig.

Source/WebCore:

Construct the style for the RenderMultiColumnFlowThread such that it
establishes a stacking context (by being position:relative
with a z-index of 0). This causes the layer collection code
to correctly ignore the RenderFlowThread layers during normal
painting.

Fix more clipping bugs to eliminate subpixel layout differences
between old and new multicolumn.

Test: fast/multicol/newmulticol/layers-in-multicol.html

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::createMultiColumnFlowThreadStyle):
(WebCore):
(WebCore::RenderMultiColumnBlock::addChild):
Use a custom style (similar to what normal RenderFlowThreads do)
for the RenderMultiColumnFlowThread that makes it a stacking
context.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
Fix the overflow calculations out the leftmost and rightmost
columns to actually look at the physical placement of the columns.
The old code was backwards for RTL.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
Fix the clipping done by overflowRectForFlowThreadPortion to min
and max with the passed-in portion rect so that subclasses that
inflate the rect prior to passing it into the method don't have that
inflation discarded.

LayoutTests:

  • fast/multicol/newmulticol/layers-in-multicol-expected.html: Added.
  • fast/multicol/newmulticol/layers-in-multicol.html: Added.
8:43 AM Changeset in webkit [143466] by jpetsovits@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make sure to always sync before reusing backingstore tiles.
​https://bugs.webkit.org/show_bug.cgi?id=109863
PR 296118

Reviewed by Rob Buis.
Internally reviewed by Mike Lattanzio and Konrad Piascik.

In SVN r142137, I replaced a syncToCurrentMessage() call
with updateSuspendScreenUpdateState() in some cases,
which internally calls the same function.

Unfortunately, when I optimized updateSuspendScreenUpdateState()
to only sync when the state is actually being changed,
I omitted an adaptation of adoptAsFrontState() which would
rely on this sync but now didn't always perform it.

This caused a bad race condition as tile buffers could now
be accessed from the WebKit thread and the UI thread at
the same time. Fix it by (optionally) letting the caller
of updateSuspendScreenUpdateState() know whether a sync
was performed, and adapt adoptAsFrontState() accordingly.

Also fixes some excessive flicker caused by the same
race condition.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
(BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):

  • Api/BackingStore_p.h:
8:12 AM WebKit Team edited by Claudio Saavedra
Adding myself (diff)
8:08 AM Changeset in webkit [143465] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CSSProperty.status defaults to "style" not "active"
​https://bugs.webkit.org/show_bug.cgi?id=110348

Reviewed by Timothy Hatcher.

  • inspector/Inspector.json: Fix the default property status to be "style" in the description.
8:07 AM WebKit Team edited by zhajiang@rim.com
(diff)
7:38 AM Changeset in webkit [143464] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[v8] potentially disposed handle returned for npapi object
​https://bugs.webkit.org/show_bug.cgi?id=110331

Patch by Dan Carney <​dcarney@google.com> on 2013-02-20
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertNPVariantToV8Object):

7:30 AM Changeset in webkit [143463] by commit-queue@webkit.org
  • 27 edits
    2 adds in trunk

[Gtk] HTML5 Media controls require a design refresh
​https://bugs.webkit.org/show_bug.cgi?id=83869

Source/WebCore:

Created new controls that depend less on Gtk and more in CSS.

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> and Martin Robinson <​mrobinson@igalia.com> on 2013-02-20
Reviewed by Philippe Normand.

  • GNUmakefile.list.am: Added compilation for MediaControlsGtk.cpp

and MediaControlsGtk.h

  • css/mediaControlsGtk.css: Taken from Chromium and adapted for

WebKitGtk+.

  • html/shadow/MediaControlsGtk.cpp: Added.

(WebCore): Added MediaControlsGtk class.
(WebCore::MediaControlsGtk::MediaControlsGtk): Class constructor
(WebCore::MediaControls::create): Creates the Gtk+ controls
components.
(WebCore::MediaControlsGtk::createControls): Creates the Gtk+
controls components.
(WebCore::MediaControlsGtk::initializeControls): Initializes all
media controls.
(WebCore::MediaControlsGtk::setMediaController): Sets the media
controller.
(WebCore::MediaControlsGtk::reset): Resets the controllers.
(WebCore::MediaControlsGtk::playbackStarted): Invoked when the
playback starts
(WebCore::MediaControlsGtk::updateCurrentTimeDisplay): Updates the
controls when the current time shall be updated.
(WebCore::MediaControlsGtk::changedMute): Updates the controls
then the mute changes.
(WebCore::MediaControlsGtk::showVolumeSlider): Invoked when the
volume slider is meant to be shown.
(WebCore::MediaControlsGtk::createTextTrackDisplay): Creates the
track display. Though it is not used by us, it needs to be created
to prevent immediate crashes when loading a video.

  • html/shadow/MediaControlsGtk.h: Added.

(WebCore): Added the MediaControlsGtk class.
(MediaControlsGtk): Added the MediaControlsGtk class.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore): Added getStockSymbolicIconForWidgetType function
signature to load symbolic icons.
(WebCore::supportsFocus): Added media control widgets to support
focus so that the focus ring is not painted by WebCore.
(WebCore::RenderThemeGtk::paintMediaButton): Added the symbolic
icon support. It supports now normal and symbolic icons at the
same time.
(WebCore::RenderThemeGtk::paintMediaFullscreenButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaMuteButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaPlayButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaSeekBackButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaSeekForwardButton): Added the
symbolic icon support.
(WebCore::borderRadiiFromStyle): Created the radii info from the
style.
(WebCore::RenderThemeGtk::paintMediaSliderTrack): Removed the
background and the Gtk widget support as it is painted with
CSS. Also paint the time ranges with the CSS style.
(WebCore::RenderThemeGtk::paintMediaSliderThumb): Paint slider
thumb according to the CSS parameters.
(WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer):
Delegates in the CSS.
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Fills the
track up to the volume level and delegates the border in the CSS.
(WebCore::RenderThemeGtk::paintMediaVolumeSliderThumb): Delegates
in the paintMediaSliderThumb method so the thumb is painted the
same with the CSS parameters.
(WebCore::RenderThemeGtk::paintMediaCurrentTime): Removed the Gtk
background to use only CSS.

  • platform/gtk/RenderThemeGtk.h:

(RenderThemeGtk): Changed paintMediaButton to support the symbolic
and normal icons at the same time.

  • platform/gtk/RenderThemeGtk2.cpp:

(WebCore::RenderThemeGtk::adjustSliderThumbSize): Not adjusting
the thumb size and letting the CSS decide that for media slider.
(WebCore::getStockSymbolicIconForWidgetType): Implemented as a
fallback to the normal stock icons.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore):
(WebCore::RenderThemeGtk::adjustSliderThumbSize): Not adjusting
the thumb size and letting the CSS decide that for the media
sliders.
(WebCore::getStockSymbolicIconForWidgetType): Added this function
to load symbolic icons. It falls back to normal icons if the
symbolic is not found.

Tools:

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-02-20
Reviewed by Philippe Normand.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(initializeGtkFontSettings): Added gnome as default icon theme for
the DRT.

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::initializeGtkSettings): Added gnome as default icon theme for
the WTR.

  • gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external

dependency.

LayoutTests:

Tests flagged and rebaselines.

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-02-20
Reviewed by Philippe Normand.

  • platform/gtk/TestExpectations: Tests flagged and removed some

other flags.

  • platform/gtk/accessibility/media-element-expected.txt: Rebaseline
  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt: Rebaseline
  • platform/gtk/fast/layers/video-layer-expected.png: Rebaseline
  • platform/gtk/fast/layers/video-layer-expected.txt: Rebaseline
  • platform/gtk/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Rebaseline
  • platform/gtk/media/audio-repaint-expected.png: Rebaseline
  • platform/gtk/media/audio-repaint-expected.txt: Rebaseline
  • platform/gtk/media/controls-styling-strict-expected.png: Rebaseline
  • platform/gtk/media/video-controls-rendering-expected.png: Rebaseline
  • platform/gtk/media/video-empty-source-expected.txt: Rebaseline
  • platform/gtk/media/video-no-audio-expected.txt: Rebaseline
  • platform/gtk/media/video-volume-slider-expected.txt: Rebaseline
  • platform/gtk/media/video-zoom-controls-expected.txt: Rebaseline
  • platform/gtk/media/video-zoom-expected.png: Rebaseline
7:27 AM Changeset in webkit [143462] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Rename AncestorChainWalker.h to EventPathWalker.h in the project file.

Unreviewed gardening.

AncestorChainWalker has been renamed to EventPathWalker in r143422.
Rename the header in the project file as well so that it shows up in QtCreator.

No new tests needed.

  • Target.pri:
7:24 AM Changeset in webkit [143461] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Read "data-blackberry-text-selection-handle-position" attribute from element
​https://bugs.webkit.org/show_bug.cgi?id=110235

Patch by Yongxin Dai <​yodai@rim.com> on 2013-02-20
Reviewed by Yong Li.

PR #257207.

Read "data-blackberry-text-selection-handle-position" attribute from element and pass it along
with notifySelectionDetailsChanged(). If "data-blackberry-text-selection-handle-position" attribute
is specified in the element, the selection handle is always flipped to the required position.
along with selected text within element.

Reviewed Internally by Mike Fenton.

  • Api/WebPageClient.h:
  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::selectionContainerElement):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::elementHandlePositionAttribute):

  • WebKitSupport/DOMSupport.h:
  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::requestedSelectionHandlePosition):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

  • WebKitSupport/SelectionHandler.h:

(SelectionHandler):

7:04 AM Changeset in webkit [143460] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix usage of HitTestRequest::RequestType
​https://bugs.webkit.org/show_bug.cgi?id=110342

Patch by Alberto Garcia <​albgarcia@rim.com> on 2013-02-20
Reviewed by Carlos Garcia Campos.

Rename HitTestResult::* -> HitTestRequest::*
This was introduced by mistake in r142977.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::hitTestResult):

6:39 AM Changeset in webkit [143459] by yurys@chromium.org
  • 1 edit
    2 copies in branches/chromium/1410

Merge 142594

Web Inspector: stack trace is cut at native bind if inspector is closed
​https://bugs.webkit.org/show_bug.cgi?id=109427

Reviewed by Pavel Feldman.

Source/WebCore:

Only top frame is collected instead of full stack trace when inspector
front-end is closed to avoid expensive operations when exceptions are
thrown.

Test: http/tests/inspector-enabled/console-exception-while-no-inspector.html

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):

LayoutTests:

Test that stack trace for uncaught exceptions is collected when inspector
front-end is closed.

  • http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.
  • http/tests/inspector-enabled/console-exception-while-no-inspector.html: Added.
  • platform/chromium/http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.

TBR=​yurys@chromium.org
Review URL: ​https://codereview.chromium.org/12324011

6:24 AM Changeset in webkit [143458] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/TestExpectations: Marked touch event emulation test as failing.
6:10 AM Changeset in webkit [143457] by jochen@chromium.org
  • 11 edits
    4 moves in trunk/Tools

[chromium] move most of the remaining mocks to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=110217

Reviewed by Nico Weber.

While most of the functionality provided by these mocks is also
available in the content module, there is no straight forward way to
inject the mock results required for layout tests.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestRunner):
(WebTestRunner::WebTestProxy::geolocationClient):
(WebTestRunner::WebTestProxy::speechInputController):
(WebTestRunner::WebTestProxy::speechRecognizer):
(WebTestRunner::WebTestProxy::deviceOrientationClient):
(WebTestRunner::WebTestProxy::requestPointerLock):
(WebTestRunner::WebTestProxy::requestPointerUnlock):
(WebTestRunner::WebTestProxy::isPointerLocked):

  • DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.

(WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
(WebTestRunner):
(WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
(WebTestRunner::MockWebSpeechInputController::setDelegate):
(WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
(WebTestRunner::MockWebSpeechInputController::setDumpRect):
(WebTestRunner::MockWebSpeechInputController::clearResults):
(WebTestRunner::MockWebSpeechInputController::startRecognition):
(WebTestRunner::MockWebSpeechInputController::cancelRecognition):
(WebTestRunner::MockWebSpeechInputController::stopRecording):
(WebTestRunner::MockWebSpeechInputController::speechTaskFired):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):

  • DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.

(WebKit):
(WebTestRunner):
(MockWebSpeechInputController):
(WebTestRunner::MockWebSpeechInputController::taskList):
(SpeechTask):

  • DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.

(WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
(WebTestRunner):
(WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
(WebTestRunner::MockWebSpeechRecognizer::setDelegate):
(WebTestRunner::MockWebSpeechRecognizer::start):
(WebTestRunner::MockWebSpeechRecognizer::stop):
(WebTestRunner::MockWebSpeechRecognizer::abort):
(WebTestRunner::MockWebSpeechRecognizer::addMockResult):
(WebTestRunner::MockWebSpeechRecognizer::setError):
(WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
(WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
(WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):

  • DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.

(WebKit):
(WebTestRunner):
(MockWebSpeechRecognizer):
(WebTestRunner::MockWebSpeechRecognizer::wasAborted):
(WebTestRunner::MockWebSpeechRecognizer::client):
(WebTestRunner::MockWebSpeechRecognizer::handle):
(WebTestRunner::MockWebSpeechRecognizer::taskList):
(Task):
(WebTestRunner::MockWebSpeechRecognizer::Task::Task):
(WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
(StepTask):
(WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::windowOpened):
(WebTestRunner):
(WebTestRunner::TestInterfaces::windowClosed):
(WebTestRunner::TestInterfaces::windowList):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::requestPointerLock):
(WebTestRunner):
(WebTestRunner::TestRunner::requestPointerUnlock):
(WebTestRunner::TestRunner::isPointerLocked):
(WebTestRunner::TestRunner::didAcquirePointerLockInternal):
(WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
(WebTestRunner::TestRunner::didLosePointerLockInternal):
(WebTestRunner::TestRunner::windowCount):
(WebTestRunner::TestRunner::setMockDeviceOrientation):
(WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
(WebTestRunner::TestRunner::setGeolocationPermission):
(WebTestRunner::TestRunner::setMockGeolocationPosition):
(WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
(WebTestRunner::TestRunner::addMockSpeechInputResult):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
(WebTestRunner::TestRunner::setMockSpeechRecognitionError):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::didAcquirePointerLock):
(WebTestRunner::TestRunner::didNotAcquirePointerLock):
(WebTestRunner::TestRunner::didLosePointerLock):
(WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner):
(TestRunner):
(HostMethodTask):
(WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
(WebTestRunner::TestRunner::HostMethodTask::runIfValid):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::setInterfaces):
(WebTestRunner::WebTestProxyBase::setDelegate):
(WebTestRunner::WebTestProxyBase::reset):
(WebTestRunner::WebTestProxyBase::captureTree):
(WebTestRunner::WebTestProxyBase::geolocationClientMock):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
(WebTestRunner::WebTestProxyBase::speechInputControllerMock):
(WebTestRunner::WebTestProxyBase::speechRecognizerMock):
(WebTestRunner::WebTestProxyBase::geolocationClient):
(WebTestRunner::WebTestProxyBase::speechInputController):
(WebTestRunner::WebTestProxyBase::speechRecognizer):
(WebTestRunner::WebTestProxyBase::deviceOrientationClient):
(WebTestRunner::WebTestProxyBase::requestPointerLock):
(WebTestRunner::WebTestProxyBase::requestPointerUnlock):
(WebTestRunner::WebTestProxyBase::isPointerLocked):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::reset):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebKit):
(WebViewHost):

5:42 AM Changeset in webkit [143456] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed. Correcting gardening after r143436.

  • platform/qt/TestExpectations:
5:40 AM Changeset in webkit [143455] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: fix for frontend closure compile errors.
​https://bugs.webkit.org/show_bug.cgi?id=110329

Reviewed by Vsevolod Vlasov.

It has no tests because it has no code changes.

  • inspector/front-end/HeapSnapshot.js:

(HeapSnapshotMetainfo):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):

5:38 AM Changeset in webkit [143454] by fmalita@chromium.org
  • 4 edits
    2 adds in trunk

Clear SVGPathSeg role on removal.
​https://bugs.webkit.org/show_bug.cgi?id=110058

Reviewed by Dirk Schulze.

Source/WebCore:

SVGPathSegListPropertyTearOff::initialize() and SVGPathSegListPropertyTearOff::replaceItem()
need to clear the context and role for segments being expunged from the list, similarly to
removeItem(). Otherwise, processIncomingListItemValue() can get confused and attempt to
remove stale segments.

Test: svg/dom/SVGPathSegList-crash.html

  • svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):
(WebCore::SVGPathSegListPropertyTearOff::clear):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore):

  • svg/properties/SVGPathSegListPropertyTearOff.h:

(WebCore::SVGPathSegListPropertyTearOff::initialize):
(SVGPathSegListPropertyTearOff):

LayoutTests:

  • svg/dom/SVGPathSegList-crash-expected.txt: Added.
  • svg/dom/SVGPathSegList-crash.html: Added.
4:45 AM Changeset in webkit [143453] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r143434.
​http://trac.webkit.org/changeset/143434
​https://bugs.webkit.org/show_bug.cgi?id=110326

added reftest fails on chromium mac 10.6 (Requested by
toyoshim on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-20

Source/WebCore:

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

LayoutTests:

  • fast/forms/file/file-vertical-padding-border-expected.html: Removed.
  • fast/forms/file/file-vertical-padding-border.html: Removed.
4:36 AM Changeset in webkit [143452] by abecsi@webkit.org
  • 2 edits in trunk/Tools

[Qt] Make debug builds possible on 32bit Linux
​https://bugs.webkit.org/show_bug.cgi?id=110231

Reviewed by Tor Arne Vestbø.

Use the stabs format for debug builds to make the object files
a bit smaller so that they can be linked on a 32bit system.

  • qmake/mkspecs/features/unix/default_post.prf:
4:33 AM Changeset in webkit [143451] by vsevik@chromium.org
  • 7 edits in trunk

Web Inspector: Make UISourceCode.path() an array of path segments.
​https://bugs.webkit.org/show_bug.cgi?id=110229

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate.prototype._filePathForPath):
(WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
(WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._contentTypeForPath):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):

  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleProjectDelegate.prototype.requestFileContent):
(WebInspector.SimpleProjectDelegate.prototype.searchInFileContent):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleProjectDelegate.prototype._ensureUniquePath):
(WebInspector.SimpleProjectDelegate.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFileByName):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.uri):

  • inspector/front-end/Workspace.js:

(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCode):
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
(WebInspector.Workspace.prototype.urlForPath):

LayoutTests:

  • inspector/workspace-mapping.html:
4:17 AM Changeset in webkit [143450] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update expectation for chromium gardening.
​https://bugs.webkit.org/show_bug.cgi?id=110324

  • platform/chromium/TestExpectations:
4:15 AM Changeset in webkit [143449] by yurys@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: fix message for non-existent domain warning
​https://bugs.webkit.org/show_bug.cgi?id=110315

Reviewed by Alexander Pavlov.

Only send (Heap)Profiler.resetProfiles event if the client has
requested profile headers before.

  • inspector/InspectorHeapProfilerAgent.cpp:

(HeapProfilerAgentState):
(WebCore):
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorHeapProfilerAgent::clearFrontend):
(WebCore::InspectorHeapProfilerAgent::restore):
(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):

  • inspector/InspectorHeapProfilerAgent.h:

(InspectorHeapProfilerAgent):

  • inspector/InspectorProfilerAgent.cpp:

(ProfilerAgentState):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::addProfile):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorProfilerAgent::restore):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

4:06 AM Changeset in webkit [143448] by vsevik@chromium.org
  • 25 edits
    2 adds in trunk

Web Inspector: Move workspace specific code from FileMapping to workspace.
​https://bugs.webkit.org/show_bug.cgi?id=110219

Reviewed by Pavel Feldman.

Source/WebCore:

Extracted workspace specific code from FileMapping to Workspace.
This allows to reduce usage of uri and eventually make UISourceCode.path an array of path segments.

Test: inspector/workspace-mapping.html

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.rawLocationToUILocation):

  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.get addScript.get this):
(WebInspector.CompilerScriptMapping.prototype.get addScript):

  • inspector/front-end/FileMapping.js:

(WebInspector.FileMapping):
(WebInspector.FileMapping.prototype.mappingEntryForURL):
(WebInspector.FileMapping.prototype.mappingEntryForPath):

  • inspector/front-end/FileSystemMapping.js:

(WebInspector.FileSystemMapping.prototype.fileSystemPathForPrefix):
(WebInspector.FileSystemMappingImpl.prototype.addFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.removeFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPathForPrefix):

  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):

  • inspector/front-end/IsolatedFileSystemManager.js:

(WebInspector.IsolatedFileSystemManager):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._workspaceUISourceCodeForScript):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.displayNameForURL):

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping.prototype._reloadCSS):
(WebInspector.SASSSourceMapping.prototype._bindUISourceCode):
(WebInspector.SASSSourceMapping.prototype.rawLocationToUILocation):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):

  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleWorkspaceProvider.pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):

  • inspector/front-end/StylesSourceMapping.js:

(WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.StylesSourceMapping.prototype._resourceAdded):
(WebInspector.StylesSourceMapping.prototype._mainFrameCreatedOrNavigated):
(WebInspector.StyleContentBinding):
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):

  • inspector/front-end/Workspace.js:

(WebInspector.Workspace):
(WebInspector.Workspace.prototype.hasMappingForURL):
(WebInspector.Workspace.prototype._fileSystemPathForEntry):
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
(WebInspector.Workspace.prototype.urlForPath):

  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.createWorkspace):

  • inspector/debugger/network-uisourcecode-provider.html:
  • inspector/file-mapping-expected.txt:
  • inspector/file-mapping.html:
  • inspector/file-system-mapping-expected.txt:
  • inspector/file-system-mapping.html:
  • inspector/file-system-project.html:
  • inspector/workspace-mapping-expected.txt: Added.
  • inspector/workspace-mapping.html: Added.
3:48 AM Changeset in webkit [143447] by toyoshim@chromium.org
  • 3 edits in trunk/Tools

Unreviewed. Add myself to watch lists.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
3:25 AM Changeset in webkit [143446] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit/blackberry

Unreviewed BlackBerry build fix.

WebPage::download was renamed in the header by mistake to
convertMainResourceLoadToDownload in r137845.

  • Api/WebPage.h:
3:18 AM Changeset in webkit [143445] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for tests added in r143395, r143420 and r143439.
  • platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r143386.
3:08 AM Changeset in webkit [143444] by Christophe Dumez
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Port EwkPopupMenuItem to the C API
​https://bugs.webkit.org/show_bug.cgi?id=108798

Reviewed by Kenneth Rohde Christiansen.

Make use of the new WKPopupItem C API inside EwkPopupMenuItem to remove
dependency on internal WebPopupItem type. Eina shared string members
are now lazily initialized to make the object cheaper to construct.

  • UIProcess/API/efl/ewk_popup_menu.cpp:

(EwkPopupMenu::EwkPopupMenu):

  • UIProcess/API/efl/ewk_popup_menu_item.cpp:

(EwkPopupMenuItem::EwkPopupMenuItem):
(EwkPopupMenuItem::type):
(EwkPopupMenuItem::textDirection):
(EwkPopupMenuItem::text):
(EwkPopupMenuItem::tooltipText):
(EwkPopupMenuItem::accessibilityText):
(EwkPopupMenuItem::hasTextDirectionOverride):
(EwkPopupMenuItem::isEnabled):
(EwkPopupMenuItem::isLabel):
(EwkPopupMenuItem::isSelected):

  • UIProcess/API/efl/ewk_popup_menu_item_private.h:

(EwkPopupMenuItem::create):
(EwkPopupMenuItem):

3:01 AM Changeset in webkit [143443] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: Introduce SecurityOriginAdded and SecurityOriginRemoved events into ResourceTreeModel
​https://bugs.webkit.org/show_bug.cgi?id=110232

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._addSecurityOrigin): Added.
(WebInspector.ResourceTreeModel.prototype._removeSecurityOrigin): Added.
(WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached): Added.
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-events-expected.txt:
  • http/tests/inspector/resource-tree/resource-tree-events.html:
2:01 AM Changeset in webkit [143442] by dominik.rottsches@intel.com
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/TestExpectations: Marked new failing ref test svg/as-background-image/tiled-background-image.html.
  • platform/efl/fast/js/global-constructors-expected.txt: Rebaselined, MutationObserver constructor now found.
1:58 AM Changeset in webkit [143441] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[v8] ScriptValue has dangerous copy semantics
​https://bugs.webkit.org/show_bug.cgi?id=110206

Patch by Dan Carney <​dcarney@google.com> on 2013-02-20
Reviewed by Kentaro Hara.

Update ScriptValue to used a SharedPersistent,
making it impossible to return dead references.

No new tests. No change in functionality.

  • bindings/v8/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):

  • bindings/v8/ScriptValue.h:

(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(ScriptValue):
(WebCore::ScriptValue::v8Value):
(WebCore::ScriptValue::v8ValueRaw):

  • bindings/v8/SharedPersistent.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::scriptValueAsNode):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAttrGetterCustom):

1:44 AM Changeset in webkit [143440] by commit-queue@webkit.org
  • 7 edits in trunk

Web Inspector: highlight undefined word in JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=109585

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-02-20
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test enhancement: inspector/syntax-highlight-javascript.html

Add global object value properties to tokenizer and add a css style
class to highlight "undefined" with gray color.

  • inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):

  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
  • inspector/front-end/inspectorSyntaxHighlight.css:

(.webkit-javascript-undef):

LayoutTests:

Enhance layout test to verify highlighting of global object value properties.

  • inspector/syntax-highlight-javascript-expected.txt:
  • inspector/syntax-highlight-javascript.html:
1:43 AM Changeset in webkit [143439] by mkwst@chromium.org
  • 8 edits in trunk

Use EventPathWalker rather than parentNode() to normalize event targets in EventHandler.
​https://bugs.webkit.org/show_bug.cgi?id=110037

Reviewed by Ryosuke Niwa.

Source/WebCore:

We need to teach EventHandler about Shadow DOM in a few places in order
to ensure that we properly target events dispatched upon text nodes.
Rather than naively grabbing the text node's direct parent via
parentNode(), we need to account for the case in which the text node is
distributed[1] to an insertion point inside a shadow host.
EventPathWalker::parent understands these relationships, and should
be used when dealing with mouse, drag, and touch events.

[1]: ​http://www.w3.org/TR/shadow-dom/#dfn-distribution

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::passGestureEventToWidgetIfPossible):
(WebCore::EventHandler::updateDragAndDrop):

Refactor parentNode callsites to use EventPathWalker::parent().

LayoutTests:

  • fast/dom/shadow/resources/event-dispatching.js:

(scrollMouseWheel):
(addEventListeners):

Add MouseWheel, Drag, and Touch support to the event-dispatching
tests in Shadow DOM.

  • fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node.html:
  • fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root.html:

Scroll the mouse wheel, drag a bit, and touch before leaving the
text node, and record the generated events.

1:24 AM Changeset in webkit [143438] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Regression] Search in ProfilesPanel is broken
​https://bugs.webkit.org/show_bug.cgi?id=110312

Reviewed by Pavel Feldman.

  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileView.prototype.matchesQuery):
(WebInspector.CPUProfileView.prototype.performSearch):

1:21 AM Changeset in webkit [143437] by eustas@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: View.markAsRoot should never be invoked on attached view.
​https://bugs.webkit.org/show_bug.cgi?id=110224

Reviewed by Pavel Feldman.

This will cause CSS loading problems after "show".

  • inspector/front-end/Drawer.js:

Ensure child view is detached before marked as root.

  • inspector/front-end/View.js:

(WebInspector.View.prototype.markAsRoot): Added assertion.

1:17 AM Changeset in webkit [143436] by zarvai@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/TestExpectations:
  • platform/qt/fast/js/global-constructors-expected.txt: Rebaseline after r143420.
1:06 AM Changeset in webkit [143435] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardenning. Unskip now passing tests.
​https://bugs.webkit.org/show_bug.cgi?id=99306

  • platform/qt-5.0-wk2/TestExpectations:
12:10 AM Changeset in webkit [143434] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

File upload control doesn't apply CSS vertical padding or border to file name
​https://bugs.webkit.org/show_bug.cgi?id=109011

Patch by Nils Barth <​nbarth@google.com> on 2013-02-20
Reviewed by Hajime Morrita.

Source/WebCore:

Test: fast/forms/file/file-vertical-padding-border.html

  • rendering/RenderFileUploadControl.cpp:

Add borderTop() and paddingTop() when computing position.

(WebCore::RenderFileUploadControl::paintObject):

LayoutTests:

  • fast/forms/file/file-vertical-padding-border.html: Added.
  • fast/forms/file/file-vertical-padding-border-expected.html: Added.

Feb 19, 2013:

11:42 PM Changeset in webkit [143433] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark fast/regions/seamless-iframe-flowed-into-regions.html failure
​https://bugs.webkit.org/show_bug.cgi?id=110283

Unreviewed. This test is added by r143256 and it is failing.

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2013-02-19

  • platform/efl/TestExpectations:
10:54 PM Changeset in webkit [143432] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Few methods in WebGLRenderingContext.idl have incorrect signatures
​https://bugs.webkit.org/show_bug.cgi?id=110305

Reviewed by Kentaro Hara.

  • html/canvas/WebGLRenderingContext.idl:
10:14 PM Changeset in webkit [143431] by commit-queue@webkit.org
  • 4 edits
    16 adds
    1 delete in trunk/LayoutTests

Unreviewed, rolling out r143393.
​http://trac.webkit.org/changeset/143393
​https://bugs.webkit.org/show_bug.cgi?id=110302

the converted reftest fails in chromium mac 10.6 and 10.7
(Requested by toyoshim on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-19

  • fast/flexbox/box-orient-button.html:
  • fast/flexbox/resources/box-orient-button.js:
  • fast/invalid/residual-style-expected.html: Removed.
  • fast/invalid/residual-style.html:
  • platform/chromium-android/fast/invalid/residual-style-expected.png: Added.
  • platform/chromium-android/fast/invalid/residual-style-expected.txt: Added.
  • platform/chromium-linux/fast/invalid/residual-style-expected.png: Added.
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt: Added.
  • platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Added.
  • platform/chromium-mac/fast/invalid/residual-style-expected.png: Added.
  • platform/chromium-mac/fast/invalid/residual-style-expected.txt: Added.
  • platform/chromium-win/fast/invalid/residual-style-expected.png: Added.
  • platform/chromium-win/fast/invalid/residual-style-expected.txt: Added.
  • platform/efl/fast/invalid/residual-style-expected.png: Added.
  • platform/efl/fast/invalid/residual-style-expected.txt: Added.
  • platform/gtk/fast/invalid/residual-style-expected.png: Added.
  • platform/gtk/fast/invalid/residual-style-expected.txt: Added.
  • platform/mac/fast/invalid/residual-style-expected.png: Added.
  • platform/mac/fast/invalid/residual-style-expected.txt: Added.
10:02 PM Changeset in webkit [143430] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, uninteresting change to test a theory about bad dependency handling.

  • API/JSStringRefCF.cpp:

(JSStringCreateWithCFString): Remove an unnecessary else clause.

9:57 PM Changeset in webkit [143429] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Unreviewed, rolling out r143338.
​http://trac.webkit.org/changeset/143338
​https://bugs.webkit.org/show_bug.cgi?id=110301

False alarm, no need to export the symbol (Requested by
aandrey on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-19

  • WebKit.vcproj/WebKitExports.def.in:
9:53 PM Changeset in webkit [143428] by timothy_horton@apple.com
  • 15 edits in trunk/Source

Clarify isInWindow vs. isVisible path through to RenderLayerCompositor
​https://bugs.webkit.org/show_bug.cgi?id=110261
<rdar://problem/13196122>

Reviewed by Simon Fraser.

Remove RenderLayerCompositor::willMoveOffscreen/didMoveOnscreen.
Add RenderLayerCompositor::setIsInWindow, and pipe in-window changes through from Page::setIsInWindow.
Adjust a few Document functions that previously called RenderView::didMoveOnscreen/willMoveOffscreen to use setIsInWindow instead, since in-win$

  • WebCore.exp.in: Export Page::setIsInWindow.
  • dom/Document.cpp:

(WebCore::Document::attach): Use setIsInWindow instead of didMoveOnscreen.
(WebCore::Document::documentWillBecomeInactive): Use setIsInWindow instead of willMoveOffscreen.
(WebCore::Document::documentDidResumeFromPageCache): Use setIsInWindow instead of didMoveOnscreen.

  • page/FrameView.cpp:

(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
RenderView doesn't care about moving on/offscreen, just in-window state.
(WebCore::FrameView::setIsInWindow): Added. Forward isInWindow changes to our RenderView.

  • page/FrameView.h:

(FrameView): Add setIsInWindow.

  • page/Page.cpp:

(WebCore::Page::setIsInWindow): Added. Forward isInWindow changes to the Page's FrameViews.

  • page/Page.h:

(Page): Add setIsInWindow.
(WebCore::Page::isInWindow):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::setIsInWindow): Added. Replace willMoveOffscreen/didMoveOnscreen with setIsInWindow,
since that's the only change we actually care about.

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor): Add setIsInWindow.

  • rendering/RenderView.cpp:

(WebCore::RenderView::setIsInWindow): Added. Replace willMoveOffscreen/didMoveOnscreen with setIsInWindow,
since that's the only change RenderLayerCompositor actually cares about.

  • rendering/RenderView.h:

(RenderView): Add setIsInWindow.

  • WebView/WebView.mm:

(-[WebView viewWillMoveToWindow:]):
(-[WebView viewDidMoveToWindow]):
Use Page::setIsInWindow in addition to willMoveOffscreen/didMoveOnscreen.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setIsInWindow):
Use Page::setIsInWindow in addition to willMoveOffscreen/didMoveOnscreen.

9:24 PM Changeset in webkit [143427] by eustas@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Cleanup and add JSDocs to SuggestBox
​https://bugs.webkit.org/show_bug.cgi?id=110202

Reviewed by Pavel Feldman.

SuggestBox contains some obsolete/unused code and not fully
covered with JSDocs.

  • inspector/front-end/SuggestBox.js:

(WebInspector.SuggestBox.prototype.visible):
Replaced getter with function.
(WebInspector.SuggestBox.prototype._onScrollOrResize):
Use camel-case for function names.
(WebInspector.SuggestBox.prototype._onBoxMouseDown): Ditto.
(WebInspector.SuggestBox.prototype.updateSuggestions):
Removed unused code.
(WebInspector.SuggestBox.prototype.hide): Adopt changes.
(WebInspector.SuggestBox.prototype._applySuggestion): Ditto.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.isSuggestBoxVisible): Ditto.

7:05 PM Changeset in webkit [143426] by hayato@chromium.org
  • 5 edits in trunk/Source/WebCore

Calculate EventPath in EventDispatcher's constructor.
​https://bugs.webkit.org/show_bug.cgi?id=109905

Reviewed by Dimitri Glazkov.

This patch calculates an EventPath in EventDispatcher's
constructor and removes EventDispatcher::ensureEventPath().
We don't have any reason to initialize an EventPath lazily.

No tests. No change in behavior.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatch):

  • dom/EventDispatcher.h:

(WebCore::EventDispatcher::eventPath):
(EventDispatcher):

  • dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

6:49 PM Changeset in webkit [143425] by jsbell@chromium.org
  • 2 edits in trunk/Tools

Remove warning from run-bindings-tests
​https://bugs.webkit.org/show_bug.cgi?id=110285

Reviewed by Kentaro Hara.

Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
"Unknown option: idlattributesfile". That option was removed from
bindings/scripts/preprocess-idls.pl but was still being passed by
the test script. Remove it.

  • Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency): Remove unused arg.

6:46 PM Changeset in webkit [143424] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Unreviewed, rolling out r143400.
​http://trac.webkit.org/changeset/143400
​https://bugs.webkit.org/show_bug.cgi?id=110290

breaks everything (instacrash launching Safari) (Requested by
thorton on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-19

  • wtf/FastMalloc.cpp:

(WTF::internalEntropyValue):
(WTF):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):

6:28 PM Changeset in webkit [143423] by Simon Fraser
  • 3 edits
    2 adds in trunk

Fix TileCache tile size when zoomed on slow-scrolling site
​https://bugs.webkit.org/show_bug.cgi?id=110289

Source/WebCore:

Reviewed by Tim Horton.

In slow scrolling mode, we use the tile coverage rect as the tile size
(so a single tile covers the viewport). When zoomed, the tile coverage rect
shrinks relative to the TileCache, so scale the tile size back up.

Test: platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::tileSizeForCoverageRect):

LayoutTests:

Reviewed by Tim Horton.

Test that dumps tile coverage in a slow-scrolling, zoomed page.

  • platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html: Added.
6:27 PM Changeset in webkit [143422] by hayato@chromium.org
  • 12 edits
    2 moves in trunk/Source/WebCore

Rename AncestorChainWalker.
​https://bugs.webkit.org/show_bug.cgi?id=110146

Reviewed by Dimitri Glazkov.

Rename AncestorChainWalker to EventPathWalker.
The term of EventPath is used in DOM Core spec. EventPath was
already introduced into a EventContext.h in r112055. We should
spread this term into the Walker class since they share the same
purpose.

No new tests, no behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/EventDispatcher.cpp:
  • dom/EventPathWalker.cpp: Renamed from Source/WebCore/dom/AncestorChainWalker.cpp.

(WebCore):
(WebCore::EventPathWalker::EventPathWalker):
(WebCore::EventPathWalker::parent): parent() is now a static function to cover simple use cases.
(WebCore::EventPathWalker::moveToParent): Renamed from parent().

  • dom/EventPathWalker.h: Renamed from Source/WebCore/dom/AncestorChainWalker.h.

(WebCore):
(EventPathWalker):
(WebCore::EventPathWalker::node):
(WebCore::EventPathWalker::isVisitingInsertionPointInReprojection): Renamed from isCrossingInsertionPoint().

  • dom/EventRetargeter.cpp:

(WebCore::EventRetargeter::calculateEventPath):
(WebCore::EventRetargeter::buildRelatedNodeMap):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::focusedNode):

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::handleWheelEvent):

5:59 PM Changeset in webkit [143421] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Snapshotted plugin label should not be selectable
​https://bugs.webkit.org/show_bug.cgi?id=110286

Reviewed by Simon Fraser.

Update the CSS to make it clear that you should click
on a snapshot (use the finger pointer) and disable
text selection.

  • css/plugIns.css:

(embed::-webkit-snapshotted-plugin-content .snapshot-container .snapshot-label):

5:56 PM Changeset in webkit [143420] by hmuller@adobe.com
  • 3 edits
    2 adds in trunk

[CSS Exclusions] Enable shape-inside support for ellipses
​https://bugs.webkit.org/show_bug.cgi?id=109868

Reviewed by Dirk Schulze.

Source/WebCore:

This change is very similar to the one recently made for circles:
removed the test that disabled ellipse values for shape-inside.
The remaining support for ellipses, which is based on rounded rectangles
whose width/height is equal to their radiusX/radiusY, has not changed.

Test: fast/exclusions/shape-inside/shape-inside-ellipse.html

  • rendering/ExclusionShapeInsideInfo.h:

(WebCore::ExclusionShapeInsideInfo::isEnabledFor): No longer disallows any BasicShape type.

LayoutTests:

Added a test for ellipse shape-inside values.

  • fast/exclusions/shape-inside/shape-inside-ellipse-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-ellipse.html: Added.
5:46 PM Changeset in webkit [143419] by commit-queue@webkit.org
  • 13 edits
    5 adds in trunk

'round' not implemented in border-image
​https://bugs.webkit.org/show_bug.cgi?id=14185

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-02-19
Reviewed by David Hyatt.

Source/WebCore:

Add rendering support for 'round' keyword of border-image-repeat CSS property
​http://dev.w3.org/csswg/css3-background/#border-image-repeat
Rebased original patch by Benjamin Otte <​otte@gnome.org> and made few fixes.

Test: fast/borders/border-image-02.html

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawTiledImage):

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

(Image):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage): For 'round' keyword,
the image is tiled (repeated) to fill the area. If it does not fill the area
with a whole number of tiles, the image is rescaled so that it does.

LayoutTests:

Added test for 'round' keyword of border-image-repeat CSS property
​http://dev.w3.org/csswg/css3-background/#border-image-repeat

  • fast/borders/border-image-02.html: Added.
  • platform/chromium-linux/fast/borders/border-image-02-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/borders/border-image-02-expected.txt: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/fast/borders/border-image-02-expected.png: Added.
  • platform/gtk/fast/borders/border-image-02-expected.txt: Added.
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
5:42 PM Changeset in webkit [143418] by commit-queue@webkit.org
  • 18 edits in trunk/Source

Allow UI clients to handle vertical wheel events.
​https://bugs.webkit.org/show_bug.cgi?id=110006

Patch by Conrad Shultz <Conrad Shultz> on 2013-02-19
Reviewed by Tim Horton.

Source/WebCore:

Add API to allow matching changes in WebKit2 to control rubber-banding behavior at vertical page extrema.
If rubber-banding is disabled during a scroll event that would otherwise trigger rubber-banding, dispatch
didNotHandleWheelEvent() to the page UI client.

  • WebCore.exp.in:

Export new rubber-banding API.

  • page/Page.cpp:

(WebCore):
(WebCore::Page::rubberBandsAtBottom):
Proxy for the corresponding function in ScrollingCoordinator.
(WebCore::Page::setRubberBandsAtBottom):
Ditto.
(WebCore::Page::rubberBandsAtTop):
Ditto.
(WebCore::Page::setRubberBandsAtTop):
Ditto.

  • page/Page.h:

(Page):
Declare new rubber-banding API (above).

  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::rubberBandsAtBottom):
Stub API implementation.
(WebCore::ScrollingCoordinator::setRubberBandsAtBottom):
Ditto.
(WebCore::ScrollingCoordinator::rubberBandsAtTop):
Ditto.
(WebCore::ScrollingCoordinator::setRubberBandsAtTop):
Ditto.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Initialize new member variables.
(WebCore::ScrollingTree::setMainFramePinState):
Set top/bottom pinned states.
(WebCore::ScrollingTree::rubberBandsAtBottom):
New accessor function.
(WebCore::ScrollingTree::setRubberBandsAtBottom):
New mutator function.
(WebCore::ScrollingTree::rubberBandsAtTop):
New accessor function.
(WebCore::ScrollingTree::setRubberBandsAtTop):
New mutator function.
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
Start a vertical swipe event if the frame is pinned at the top or bottom and associated rubber-banding is disabled.

  • page/scrolling/ScrollingTree.h:

(ScrollingTree):
Declare new rubber-banding API and associated member variables.

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollingCoordinatorMac):
Declare API overrides.

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::rubberBandsAtBottom):
Method override; proxy to corresponding function in ScrollingTree.
(WebCore::ScrollingCoordinatorMac::setRubberBandsAtBottom):
Ditto.
(WebCore::ScrollingCoordinatorMac::rubberBandsAtTop):
Ditto.
(WebCore::ScrollingCoordinatorMac::setRubberBandsAtTop):
Ditto.

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::pinnedInDirection):
Remove trailing whitespace.
(WebCore::ScrollingTreeScrollingNodeMac::updateMainFramePinState):
Calculate and pass vertical pinning state to ScrollingTree::setMainFramePinState().

Source/WebKit2:

Add API to allow clients to selectively control rubber-banding at vertical page extrema.

  • UIProcess/API/C/WKPage.cpp:

(WKPageRubberBandsAtBottom):
Proxy for the corresponding function in WebCore::Page.
(WKPageSetRubberBandsAtBottom):
Ditto.
(WKPageRubberBandsAtTop):
Ditto.
(WKPageSetRubberBandsAtTop):
Ditto.

  • UIProcess/API/C/WKPage.h:

Declare new API.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Initialize new member variables.
(WebKit::WebPageProxy::setRubberBandsAtBottom):
New function; dispatches a matching message to the WebKit::WebPage.
(WebKit::WebPageProxy::setRubberBandsAtTop):
Ditto.

  • UIProcess/WebPageProxy.h:

(WebPageProxy):
Declare new API.
(WebKit::WebPageProxy::rubberBandsAtBottom):
New accessor function.
(WebKit::WebPageProxy::rubberBandsAtTop):
Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setRubberBandsAtBottom):
New function; call the matching function on the associated WebCore::Page.
(WebKit::WebPage::setRubberBandsAtTop):
Ditto.

  • WebProcess/WebPage/WebPage.h:

(WebPage):
Declare new rubber-banding API.

  • WebProcess/WebPage/WebPage.messages.in:

Declare new rubber-banding API.

5:29 PM Changeset in webkit [143417] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Rubber-banding should not affect the visibleRect of the TileCache
​https://bugs.webkit.org/show_bug.cgi?id=110278

Reviewed by Beth Dakin.

When rubber-banding a slow-scrolling page, or image document, we would constantly re-create
the bottom tile because of the logic that adapts the tile size to the visible rect when slow
scrolling.

Avoid that by ensuring that the visibleRect is not affected by rubber-banding. This is done
via a GraphicsLayerClient function that allows RenderLayerCompositor to provide a custom
position for the scroll layer. We constrain that scroll position to remove the overhang that
results from rubber-banding.

I wasn't able to make a test for this, even with internals.setScrollViewPosition().

  • platform/graphics/GraphicsLayerClient.h:

(GraphicsLayerClient):
(WebCore::GraphicsLayerClient::customPositionForVisibleRectComputation):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::computeVisibleRect):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::customPositionForVisibleRectComputation):

  • rendering/RenderLayerCompositor.h:
5:24 PM Changeset in webkit [143416] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/win

Unreviewed, force file to recompile to fix win build.

  • WebView.cpp:
5:20 PM Changeset in webkit [143415] by tonyg@chromium.org
  • 8 edits in trunk/Source/WebCore

Fix crash in preloading scanning base tags with no href attribute for background parser
​https://bugs.webkit.org/show_bug.cgi?id=110276

Reviewed by Eric Seidel.

Previously a <base> tag without an href attribute (like the one in fast/dom/HTMLAnchorElement/set-href-attribute-rebase.html)
would crash the background parser's preload scanner.

To fix that, we only call stripLeadingAndTrailingHTMLSpaces() if the href attribute is non-null. This matches the main thread parser.

Along with this, I decided to templatize updatePredictedBaseURL() so that the main and background parser can share the same impl.

This required making CompactHTMLToken and HTMLToken a little more similar:

  1. Give HTMLToken a getAttributeItem() method.
  2. Move CompactAttribute to CompactHTMLToken::Attribute and make it a struct.

No new tests because covered by existing tests.

  • html/parser/AtomicHTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/CompactHTMLToken.cpp:

(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken):
(WebCore::CompactHTMLToken::getAttributeItem):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):

  • html/parser/CompactHTMLToken.h:

(WebCore::CompactHTMLToken::Attribute::Attribute):
(Attribute):
(WebCore::CompactHTMLToken::attributes):
(CompactHTMLToken):
(WebCore::CompactHTMLToken::publicIdentifier):
(WebCore::CompactHTMLToken::systemIdentifier):

  • html/parser/HTMLParserIdioms.h:

(WebCore):
(WebCore::stripLeadingAndTrailingHTMLSpaces):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore):
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):

  • html/parser/HTMLPreloadScanner.h:
  • html/parser/HTMLToken.h:

(WebCore::HTMLToken::getAttributeItem):
(HTMLToken):

5:18 PM Changeset in webkit [143414] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit

Unreviewed, include exports for VS2010 as well.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
4:55 PM Changeset in webkit [143413] by dgrogan@chromium.org
  • 1 edit in branches/chromium/1410/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp

Merge 142890

IndexedDB: Add a few more histogram calls
​https://bugs.webkit.org/show_bug.cgi?id=109762

Reviewed by Tony Chang.

A few places where commits could fail weren't being logged.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::IDBBackingStore::Transaction::commit):

TBR=​dgrogan@chromium.org
Review URL: ​https://codereview.chromium.org/12288067

4:48 PM Changeset in webkit [143412] by mark.lam@apple.com
  • 6 edits
    2 adds in trunk/Source/WebCore

Introducing AbstractSQLTransaction and AbstractSQLTransactionBackend.
​https://bugs.webkit.org/show_bug.cgi?id=110273.

Reviewed by Anders Carlsson.

This is part of the webdatabase refactoring for webkit2.

  • Also changed the frontend and backend to only refer to the abstract interface of each other.

No new tests.

  • Modules/webdatabase/AbstractSQLTransaction.h: Added.

(AbstractSQLTransaction):
(WebCore::AbstractSQLTransaction::~AbstractSQLTransaction):

  • Modules/webdatabase/AbstractSQLTransactionBackend.h: Added.

(AbstractSQLTransactionBackend):
(WebCore::AbstractSQLTransactionBackend::~AbstractSQLTransactionBackend):

  • Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::hasCallback):
(WebCore::SQLTransaction::hasSuccessCallback):
(WebCore::SQLTransaction::hasErrorCallback):
(WebCore::SQLTransaction::setBackend):

  • Modules/webdatabase/SQLTransaction.h:

(SQLTransaction):

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):

  • Modules/webdatabase/SQLTransactionBackend.h:

(SQLTransactionBackend):

  • Modules/webdatabase/SQLTransactionStateMachine.h:
4:47 PM Changeset in webkit [143411] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Silence some analyzer warnings
​https://bugs.webkit.org/show_bug.cgi?id=110281

Reviewed by Mark Hahnenberg.

The static analyzer believes that callerCodeBlock can be null,
based on other code performing null tests. This should not
ever be the case, but we'll add RELEASE_ASSERTs to make it
obvious if we're ever wrong.

  • interpreter/Interpreter.cpp:

(JSC::getCallerInfo):

4:47 PM ExportingSymbols edited by tony@chromium.org
Updated path to win exports file. (diff)
4:45 PM Changeset in webkit [143410] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

Change computeStickyPositionConstraints to use LayoutBoxExtent for margins
​https://bugs.webkit.org/show_bug.cgi?id=108872

Reviewed by Levi Weintraub.

Change RenderBoxModelObject::computeStickyPositionConstraints to
use a LayoutBoxExtent to represent margins.

No new tests, no change in functionality.

  • platform/graphics/LayoutRect.h:

(WebCore::LayoutRect::contract):
Add version contract methods that takes a LayoutBoxExtent object.

  • platform/graphics/LayoutSize.h:

(WebCore::LayoutSize::shrink):
Add shrink method.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computeStickyPositionConstraints):
Change to use a LayoutBoxExtent object to represent margins.

4:45 PM NewRunWebKitTests edited by dpranke@chromium.org
(diff)
4:45 PM Changeset in webkit [143409] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/win

Unreviewed, fix the Windows build after r143398.
Add new setters to the export list.

  • WebKit.vcproj/WebKitExports.def.in:
4:42 PM Changeset in webkit [143408] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Don't force everything to be blinded in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=110279

Reviewed by Mark Hahnenberg.

Switch to an explicit flag for indicating that we want
every constant to be blinded.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlind):

4:35 PM Changeset in webkit [143407] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

Disable ASSERT(!hasInsertionPoint()) for background parser
​https://bugs.webkit.org/show_bug.cgi?id=110251

Reviewed by Adam Barth.

The background parser crashes about 10 layout tests by hitting ASSERT(!hasInsertionPoint()).
Now, finish() is the thing that closes the HTMLInputStream which removes the insertion point.
In these tests, a document.open() calls insert() which clears the HTMLInputStream which causes
there to be an insertion point again.

With the main thread parser, insert() is called before finish() so the ASSERT passes.
However, with the threaded parser, finish() is called before insert(), so we fail the ASSERT.

This patch disables the ASSERT for the background parser because m_input isn't really relevant.
This causes us to pass the tests. However, there is a risk that now hasInsertionPoint() may be incorrect
and Document has a non-debug branch that tests hasInsertionPoint().

No new tests because covered by existing tests.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd):

4:34 PM Changeset in webkit [143406] by esprehn@chromium.org
  • 3 edits in trunk/Tools

Unreviewed. Add myself to watch lists.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
4:26 PM Changeset in webkit [143405] by hmuller@adobe.com
  • 2 edits in trunk/Tools

Unreviewed, corrected primary email.

  • Scripts/webkitpy/common/config/committers.py:
4:25 PM Changeset in webkit [143404] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

Separate constraining for overhang from fixed-position zooming behavior in scrollOffsetForFixedPosition()
​https://bugs.webkit.org/show_bug.cgi?id=110267

Reviewed by Beth Dakin.

The static scrollOffsetForFixedPosition() function in ScrollingCoordinator did two things;
it constrained the scroll position when rubber-banding, and applied the special scaling for
fixed position when zoomed.

Separate these out so that we can use the rubber-banding constrained elsewhere.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollOffsetForFixedPosition): The static function is here now.

  • page/FrameView.h:
  • page/scrolling/ScrollingCoordinator.cpp: Code moved to FrameView.
  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition): scrollOffsetForFixedPosition()
is now on FrameView.

  • platform/ScrollableArea.cpp:

(WebCore::constrainedScrollPosition): Helper to constrain one axis for overhang.
(WebCore::ScrollableArea::constrainScrollPositionForOverhang): Static function that
can be called by FrameView::scrollOffsetForFixedPosition().

  • platform/ScrollableArea.h: Static function constrainScrollPositionForOverhang()

so we can call it from another thread. Also a member fuction of the same name, which takes
the scrollPosition as input (so we can feed it a layer position in a later patch).

4:20 PM Changeset in webkit [143403] by enne@google.com
  • 5 edits in trunk/Source

Unreviewed, rolling out r143382 and r143401.
​http://trac.webkit.org/changeset/143382
​http://trac.webkit.org/changeset/143401
​https://bugs.webkit.org/show_bug.cgi?id=106457

Breaks Chromium win/mac canary compilation

Source/Platform:

  • chromium/public/Platform.h:

Source/WebKit/chromium:

  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::idbFactory):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

4:15 PM Changeset in webkit [143402] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix checkThatTokensAreSafeToSendToAnotherThread() now that the preload scanner is enabled
​https://bugs.webkit.org/show_bug.cgi?id=110258

Reviewed by Adam Barth.

We were hitting this ASSERT on numerous tests with the background parser enabled. This copy fixes the assertion.

No new tests becuase covered by existing tests.

  • html/parser/HTMLResourcePreloader.h:

(WebCore::PreloadRequest::setCharset):

4:14 PM Changeset in webkit [143401] by pilgrim@chromium.org
  • 4 edits in trunk/Source

[Chromium] Move WebKitPlatformSupport declaration to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=110262

Reviewed by Adam Barth.

In preparation for removing WebKitPlatformSupport.h entirely (once
downstream references to that file have been updated). Part of a
larger refactoring series; see tracking bug 82948.

Source/Platform:

  • chromium/public/Platform.h:

(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
(WebKit):

Source/WebKit/chromium:

  • public/platform/WebKitPlatformSupport.h:
4:13 PM Changeset in webkit [143400] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

Moar hardening
​https://bugs.webkit.org/show_bug.cgi?id=110275

Reviewed by Anders Carlsson.

We now poison objects when they get freed, and verify that
any object that is being freed is not poisoned. If the
object looks like it's poisoned we validate the freelist,
and ensure the object is not already present. If it is
we crash.

On allocation, we ensure that the object being allocated
is poisoned, then clear the poisoning fields.

  • wtf/FastMalloc.cpp:

(WTF::internalEntropyValue):
(WTF):
(WTF::freedObjectStartPoison):
(WTF::freedObjectEndPoison):
(TCMalloc_ThreadCache_FreeList):
(WTF::TCMalloc_ThreadCache_FreeList::Validate):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):

3:58 PM Changeset in webkit [143399] by tonyg@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix typo: inititatorFor->initiatorFor
​https://bugs.webkit.org/show_bug.cgi?id=110260

Reviewed by Adam Barth.

No new tests because no changed functionality.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::initiatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):

  • html/parser/HTMLPreloadScanner.h:
3:38 PM Changeset in webkit [143398] by tony@chromium.org
  • 13 edits in trunk/Source

Convert 3 settings to use Settings.in
​https://bugs.webkit.org/show_bug.cgi?id=109875

Reviewed by Ryosuke Niwa.

Source/WebCore:

Convert mediaEnabled, applicationChromeMode and DOMPasteAllowed to
use Settings.in. They previously had inconsistently named setters.

No new tests, this is a refactoring.

  • Source/WebCore/WebCore.exp.in: Remove symbols that are now inlined from exports.
  • Source/WebCore/WebCore.order: Remove symbols that no longer exist.
  • dom/make_names.pl:

(printConstructorInterior): Rename isMediaEnabled to mediaEnabled.
(printWrapperFunctions): Rename isMediaEnabled to mediaEnabled.

  • editing/EditorCommand.cpp:

(WebCore::supportedPaste): Rename isDOMPasteAllowed to DOMPasteAllowed.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Remove custom code.

  • page/Settings.h:

(Settings): Remove custom code.

  • page/Settings.in: Add entries for mediaEnabled, applicationChromeMode and DOMPasteAllowed.
  • page/make_settings.pl:

(setterFunctionName): Expand uppercase rules to include DOM.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isDefault): Rename inApplicationChromeMode to applicationChromeMode.

  • rendering/RenderThemeWin.cpp:

(WebCore::documentIsInApplicationChromeMode): Rename inApplicationChromeMode to applicationChromeMode.

Source/WebKit/efl:

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new): Rename isDOMPasteAllowed to DOMPasteAllowed.

3:34 PM Changeset in webkit [143397] by jchaffraix@webkit.org
  • 5 edits
    2 adds in trunk

[CSS Grid Layout] Refactor the code in preparation of auto placement support
​https://bugs.webkit.org/show_bug.cgi?id=110244

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-auto-flow-resolution.html

In order to support auto placement, we need to iterate over the grid items with
auto row / column several times. This changes makes us do that in a very simple,
not-yet-conformant way. While touching this code, the distinction between grid-auto-flow
none and row / column was better drawn (and enforced).

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveGridPositionFromStyle):
Made it illegal to call resolveGridPositionFromStyle if the grid track is auto and
grid-auto-flow is not none. This would catch bad use of the function.

(WebCore::RenderGrid::maximumIndexInDirection):
Updated to bail out if the grid track is auto. Also improved the comment.

(WebCore::RenderGrid::placeItemsOnGrid):
Updated the function to do several iterations. Also handled the grid-auto-flow: none
case differently as it shouldn't need the extra iteration(s).

LayoutTests:

  • fast/css-grid-layout/grid-auto-flow-resolution-expected.txt: Added.
  • fast/css-grid-layout/grid-auto-flow-resolution.html: Added.
  • fast/css-grid-layout/implicit-position-dynamic-change.html:
  • fast/css-grid-layout/resources/grid.css:

(.autoRowAutoColumn):
(.firstRowAutoColumn):
(.secondRowAutoColumn):
(.thirdRowAutoColumn):
(.autoRowFirstColumn):
(.autoRowSecondColumn):
(.autoRowThirdColumn):
Added these helper classes, some will be used in a follow-up patch.

(.sizedToGridArea):
Hoisted this class into the common style.

3:31 PM Changeset in webkit [143396] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

StorageAreaProxy should know its quota
​https://bugs.webkit.org/show_bug.cgi?id=110268

Reviewed by Sam Weinig.

Begin stubbing out StorageAreaProxy::setItem and add some quota member variables.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::StorageAreaProxy):
(WebKit::StorageAreaProxy::setItem):

  • WebProcess/Storage/StorageAreaProxy.h:

(StorageAreaProxy):

  • WebProcess/Storage/StorageNamespaceProxy.cpp:

(WebKit::StorageNamespaceProxy::createSessionStorageNamespace):
(WebKit::StorageNamespaceProxy::StorageNamespaceProxy):

  • WebProcess/Storage/StorageNamespaceProxy.h:

(WebKit::StorageNamespaceProxy::quota):
(StorageNamespaceProxy):

3:23 PM Changeset in webkit [143395] by hyatt@apple.com
  • 6 edits
    3 adds in trunk

[New Multicolumn] REGRESSION: RenderMultiColumnSets broken by the RenderRegion -> RenderBlock subclassing.
​https://bugs.webkit.org/show_bug.cgi?id=110239.

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/multicol/newmulticol/column-rules-fixed-height.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::columnRectAt):
Make sure the columnGap() in the old multicolumn code is always expressed as a LayoutUnit. This was the
one place where it was still an int.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
Rework the painting of flow thread portions to account for the fact that regions paint at an integral
translation. This means you have to construct clipping around that integral destination. Subpixel layout
regions did not clip correctly as a result of this issue.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::columnRectAt):
Fix the same bug with columnGap() that the old column code has, i.e., one spot where it was an int.

(WebCore::RenderMultiColumnSet::paintObject):
RenderMultiColumnSet should be using paintObject and not paint and it needs to check for visibility
and phases now that it is a RenderBlock subclass.

(WebCore::RenderMultiColumnSet::paintColumnRules):
Fix the bug that Opera guys fixed in the old multi-column code. They didn't patch the new code, so this
takes care of that.

  • rendering/RenderMultiColumnSet.h:

(RenderMultiColumnSet):
Change to use paintObject instead of paint.

LayoutTests:

  • fast/multicol/newmulticol: Added.
  • fast/multicol/newmulticol/column-rules-fixed-height-expected.html: Added.
  • fast/multicol/newmulticol/column-rules-fixed-height.html: Added.
3:21 PM Changeset in webkit [143394] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation of Opcode.h

Rubber stamped by Mark Hahnenberg.

  • bytecode/Opcode.h:
3:20 PM Changeset in webkit [143393] by commit-queue@webkit.org
  • 4 edits
    1 add
    16 deletes in trunk/LayoutTests

Convert residual-style.html test to a reftest (and fix typos)
​https://bugs.webkit.org/show_bug.cgi?id=109981

Patch by Christian Biesinger <​cbiesinger@chromium.org> on 2013-02-19
Reviewed by Darin Adler.

  • fast/flexbox/box-orient-button.html: clsas->class
  • fast/flexbox/resources/box-orient-button.js: DTR->DRT
  • fast/invalid/residual-style-expected.html: Added. New reftest

version. Note that some lines are red, which is
​https://bugs.webkit.org/show_bug.cgi?id=109984

  • fast/invalid/residual-style.html: Add missing semicolon in <style>.

Also close a few more <font> tags, so that the descriptive text is
in black as it should be.

  • platform/chromium-android/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-android/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-linux/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-win/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-win/fast/invalid/residual-style-expected.txt: Removed.
  • platform/efl/fast/invalid/residual-style-expected.png: Removed.
  • platform/efl/fast/invalid/residual-style-expected.txt: Removed.
  • platform/gtk/fast/invalid/residual-style-expected.png: Removed.
  • platform/gtk/fast/invalid/residual-style-expected.txt: Removed.
  • platform/mac/fast/invalid/residual-style-expected.png: Removed.
  • platform/mac/fast/invalid/residual-style-expected.txt: Removed.

Removed old expectation files.

3:19 PM Changeset in webkit [143392] by fpizlo@apple.com
  • 6 edits
    1 add in trunk/Source/JavaScriptCore

Moved PolymorphicAccessStructureList into its own file.

Rubber stamped by Mark Hahnenberg.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/Instruction.h:

(JSC):

  • bytecode/PolymorphicAccessStructureList.h: Added.

(JSC):
(PolymorphicAccessStructureList):
(PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::visitWeak):

  • bytecode/StructureStubInfo.h:
3:17 PM WebKit Team edited by abucur@adobe.com
(diff)
3:15 PM Changeset in webkit [143391] by nghanavatian@rim.com
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Appropriately handle word wrapping in SpellingHandler
​https://bugs.webkit.org/show_bug.cgi?id=110253

Reviewed by Rob Buis.

PR286001
Since we traverse through text by visual lines instead of blocks, word wrapping causes some
bad behavior. Changing the way we traverse text to jump by words instead of lines. This will
mean it takes longer to finish spellchecking, but the removal of any loops allows webkit
processing to continue. This gives priority to user actions while still completing a large
paragraph in a reasonable amount of time.

Internally reviewed by Mike Fenton

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):

  • WebKitSupport/SpellingHandler.cpp:

(BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
(BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
(BlackBerry::WebKit::SpellingHandler::startOfNextWord):
(WebKit):
(BlackBerry::WebKit::SpellingHandler::incrementByWord):
(BlackBerry::WebKit::SpellingHandler::doesWordWrap):

  • WebKitSupport/SpellingHandler.h:

(SpellingHandler):

3:10 PM Changeset in webkit [143390] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation of Instruction.h

Rubber stamped by Mark Hahnenberg.

  • bytecode/Instruction.h:
3:04 PM Changeset in webkit [143389] by pdr@google.com
  • 8 edits
    6 adds in trunk

Fix 'slice' aspect ratio calculation
​https://bugs.webkit.org/show_bug.cgi?id=99984

Patch by Branimir Lambov <​blambov@google.com> on 2013-02-19
Reviewed by Dirk Schulze.

Source/WebCore:

Previously the calculation for the 'slice' aspect ratio would incorrectly calculate the
source rect location based on the destination rect offset. This caused our source rect to be
incorrect, and sometimes render outside the visible area completely. After this patch
our implementation matches the implementation of both Gecko and Presto.

The relevant spec section:
​http://www.w3.org/TR/SVG/single-page.html#coords-PreserveAspectRatioAttribute

Tests: svg/as-image/image-preserveAspectRatio-all.svg

svg/filters/feImage-preserveAspectRatio-all.svg

  • svg/SVGPreserveAspectRatio.cpp:

(WebCore::SVGPreserveAspectRatio::transformRect):

LayoutTests:

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
  • svg/as-image/image-preserveAspectRatio-all-expected.txt: Added.
  • svg/as-image/image-preserveAspectRatio-all.svg: Added.
  • svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
  • svg/filters/feImage-preserveAspectRatio-all-expected.txt: Added.
  • svg/filters/feImage-preserveAspectRatio-all.svg: Added.
3:03 PM Changeset in webkit [143388] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test Expectations to reflect flakey calendar tests.
​https://bugs.webkit.org/show_bug.cgi?id=107508

Unreviewed test expectations.

  • platform/chromium/TestExpectations: Re-added all the flakey calendar tests.
3:01 PM Changeset in webkit [143387] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
​https://bugs.webkit.org/show_bug.cgi?id=110254

Patch by Kentaro Hara <​haraken@google.com> on 2013-02-19
Reviewed by Adam Barth.

Chromium bug: ​https://code.google.com/p/chromium/issues/detail?id=176951

Currently ScriptRunner::runCompiledScript() calls
ASSERT(script.IsEmpty()) when OOM occurs. The Chromium bug is
hitting the ASSERT(). The ASSERT() does not make sense at all.
Instead, we should return an empty handle when OOM occurs.

No tests. The bug happens only when OOM occurs.

  • bindings/v8/ScriptRunner.cpp:

(WebCore::ScriptRunner::runCompiledScript):

2:58 PM Changeset in webkit [143386] by esprehn@chromium.org
  • 31 edits
    2 adds in trunk

Support both MutationObserver and WebKitMutationObserver
​https://bugs.webkit.org/show_bug.cgi?id=109776

Reviewed by Ojan Vafai.

Source/WebCore:

We should allow new MutationObserver now that we support parser generated
mutations. This leaves the old prefixed constructor in until we decide
people don't depend on it.

Test: fast/dom/MutationObserver/mutation-observer-prefix.html

  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/MutationObserver/added-out-of-order.html:
  • fast/dom/MutationObserver/callback-arguments.html:
  • fast/dom/MutationObserver/clear-transient-without-delivery.html:
  • fast/dom/MutationObserver/create-during-delivery.html:
  • fast/dom/MutationObserver/cross-document.html:
  • fast/dom/MutationObserver/database-callback-delivery.html:
  • fast/dom/MutationObserver/delivery-order.html:
  • fast/dom/MutationObserver/disconnect-cancel-pending.html:
  • fast/dom/MutationObserver/document-fragment-insertion.html:
  • fast/dom/MutationObserver/end-of-task-delivery.html:
  • fast/dom/MutationObserver/filesystem-callback-delivery.html:
  • fast/dom/MutationObserver/inline-event-listener.html:
  • fast/dom/MutationObserver/mutate-during-delivery.html:
  • fast/dom/MutationObserver/mutation-callback-non-element-crash.html:
  • fast/dom/MutationObserver/mutation-observer-constructor.html:
  • fast/dom/MutationObserver/mutation-observer-prefix-expected.txt: Added.
  • fast/dom/MutationObserver/mutation-observer-prefix.html: Added.
  • fast/dom/MutationObserver/mutation-record-nullity.html:
  • fast/dom/MutationObserver/observe-attributes.html:
  • fast/dom/MutationObserver/observe-characterdata.html:
  • fast/dom/MutationObserver/observe-childList.html:
  • fast/dom/MutationObserver/observe-exceptions.html:
  • fast/dom/MutationObserver/observe-subtree.html:
  • fast/dom/MutationObserver/observer-wrapper-dropoff-transient.html:
  • fast/dom/MutationObserver/observer-wrapper-dropoff.html:
  • fast/dom/MutationObserver/parser-mutations.html:
  • fast/dom/MutationObserver/removed-out-of-order.html:
  • fast/dom/MutationObserver/shadow-dom.html:
  • fast/dom/MutationObserver/takeRecords.html:
  • fast/dom/MutationObserver/transient-gc-crash.html:
2:38 PM Changeset in webkit [143385] by ap@apple.com
  • 6 edits in trunk/Source/WebKit2

<rdar://problem/13239119> NetworkProcess generates timeout spindump logs

Reviewed by Mark Rowe.

Don't keep a window server connection in processes that don't need it, and don't
run an NSApplication run loop.

  • Shared/ChildProcess.h:
  • Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::shutdownWindowServerConnection): Added a function to shut down connections, and to make sure we don't get one in the future.
  • NetworkProcess/mac/NetworkProcessMac.mm: (WebKit::NetworkProcess::initializeProcessName):
  • OfflineStorageProcess/mac/OfflineStorageProcessMac.mm: (WebKit::OfflineStorageProcess::initializeProcessName):
  • SharedWorkerProcess/mac/SharedWorkerProcessMac.mm: (WebKit::SharedWorkerProcess::platformInitializeSharedWorkerProcess): Also removed some unused includes and forward declarations.
2:29 PM Changeset in webkit [143384] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling in r143348.
​http://trac.webkit.org/changeset/143348
​https://bugs.webkit.org/show_bug.cgi?id=110242

The bug was that isEmptyValue() was returning true for the deleted value.
Fixed this and simplified things further by delegating to m_sourceCode
for both isNull() and isHashTableDeletedValue(), so they can't be out of
sync.

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

  • runtime/CodeCache.h:

(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(SourceCodeKey):

2:15 PM Changeset in webkit [143383] by hmuller@adobe.com
  • 2 edits in trunk/Tools

Unreviewed. Adding myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
2:02 PM Changeset in webkit [143382] by pilgrim@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove idbFactory from WebKitPlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=106457

Reviewed by Kentaro Hara.

Now that ​https://codereview.chromium.org/12230054 has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.

  • public/platform/WebKitPlatformSupport.h:

(WebKit):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

1:53 PM Changeset in webkit [143381] by Martin Robinson
  • 2 edits
    1 add
    1 delete in trunk/Source/JavaScriptCore

[GTK] Improve gyp build JavaScriptCore code generation
​https://bugs.webkit.org/show_bug.cgi?id=109969

Reviewed by Dirk Pranke.

Switch away from using DerivedSources.make when building JavaScriptCore generated
sources. This bring a couple advantages, such as building the sources in parallel,
but requires us to list the generated sources more than once.

1:51 PM Changeset in webkit [143380] by esprehn@chromium.org
  • 7 edits in trunk/Source/WebCore

Remove RenderText::updateText
​https://bugs.webkit.org/show_bug.cgi?id=109991

Reviewed by Eric Seidel.

There's no reason for the generic RenderText::updateText virtual hook
anymore now that r143060 made RenderQuote stop setting dirty bits during
layout since the hook is only used by RenderCounter.

Instead add updateCounterIfNeeded and make it clear this is a hack for
counters.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::updateCounterIfNeeded): Added, not handles the counter specific hack.
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::updateCounter):

  • rendering/RenderCounter.h:

(RenderCounter):

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::updateDepth):

  • rendering/RenderQuote.h:

(RenderQuote):

  • rendering/RenderText.h:

(RenderText):

1:48 PM Changeset in webkit [143379] by pdr@google.com
  • 5 edits
    3 copies in branches/chromium/1364

Merge 141645

Prevent skipped repaints for children of inner SVG elements
​https://bugs.webkit.org/show_bug.cgi?id=108429

Reviewed by Eric Seidel.

Source/WebCore:

This patch fixes a bug caused by r108699 and r133786 where we would not repaint children
of inner SVG elements because "m_didTransformToRootUpdate" was never reset on viewport
containers. The stale m_didTransformToRootUpdate variable caused us to skip child repaints.

I verified that the Robohornet SVG benchmark performance gains in r133786 are not regressed
with this patch.

Test: svg/repaint/svgsvgelement-repaint-children.html

  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::calcViewport):

This can be removed because setNeedsTransformUpdate() will set m_needsTransformUpdate.

(WebCore::RenderSVGViewportContainer::calculateLocalTransform):

This change is straightforward and is similar to the equivalent assignment in
RenderSVGTransformableContainer::calculateLocalTransform().

LayoutTests:

Need to update expectations for a single file (just a 1px difference).

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
  • svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
  • svg/repaint/svgsvgelement-repaint-children.html: Added.

TBR=​pdr@google.com

1:46 PM Changeset in webkit [143378] by glenn@skynav.com
  • 2 edits
    64 adds in trunk/LayoutTests

CSS3: add line-break tests, initially skipping on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=109954

Reviewed by Dirk Pranke.

See also wiki documentation at:
[1] ​http://trac.webkit.org/wiki/LineBreaking
[2] ​http://trac.webkit.org/wiki/LineBreakingCSS3Mapping

See also:
​https://bugs.webkit.org/show_bug.cgi?id=89235

  • TestExpectations:
  • css3/line-break/line-break-auto-centered-expected.html: Added.
  • css3/line-break/line-break-auto-centered.html: Added.
  • css3/line-break/line-break-auto-half-kana-expected.html: Added.
  • css3/line-break/line-break-auto-half-kana.html: Added.
  • css3/line-break/line-break-auto-hyphens-expected.html: Added.
  • css3/line-break/line-break-auto-hyphens.html: Added.
  • css3/line-break/line-break-auto-inseparables-expected.html: Added.
  • css3/line-break/line-break-auto-inseparables.html: Added.
  • css3/line-break/line-break-auto-iteration-marks-expected.html: Added.
  • css3/line-break/line-break-auto-iteration-marks.html: Added.
  • css3/line-break/line-break-auto-postfixes-expected.html: Added.
  • css3/line-break/line-break-auto-postfixes.html: Added.
  • css3/line-break/line-break-auto-prefixes-expected.html: Added.
  • css3/line-break/line-break-auto-prefixes.html: Added.
  • css3/line-break/line-break-auto-sound-marks-expected.html: Added.
  • css3/line-break/line-break-auto-sound-marks.html: Added.
  • css3/line-break/line-break-loose-centered-expected.html: Added.
  • css3/line-break/line-break-loose-centered.html: Added.
  • css3/line-break/line-break-loose-half-kana-expected.html: Added.
  • css3/line-break/line-break-loose-half-kana.html: Added.
  • css3/line-break/line-break-loose-hyphens-expected.html: Added.
  • css3/line-break/line-break-loose-hyphens.html: Added.
  • css3/line-break/line-break-loose-inseparables-expected.html: Added.
  • css3/line-break/line-break-loose-inseparables.html: Added.
  • css3/line-break/line-break-loose-iteration-marks-expected.html: Added.
  • css3/line-break/line-break-loose-iteration-marks.html: Added.
  • css3/line-break/line-break-loose-postfixes-expected.html: Added.
  • css3/line-break/line-break-loose-postfixes.html: Added.
  • css3/line-break/line-break-loose-prefixes-expected.html: Added.
  • css3/line-break/line-break-loose-prefixes.html: Added.
  • css3/line-break/line-break-loose-sound-marks-expected.html: Added.
  • css3/line-break/line-break-loose-sound-marks.html: Added.
  • css3/line-break/line-break-normal-centered-expected.html: Added.
  • css3/line-break/line-break-normal-centered.html: Added.
  • css3/line-break/line-break-normal-half-kana-expected.html: Added.
  • css3/line-break/line-break-normal-half-kana.html: Added.
  • css3/line-break/line-break-normal-hyphens-expected.html: Added.
  • css3/line-break/line-break-normal-hyphens.html: Added.
  • css3/line-break/line-break-normal-inseparables-expected.html: Added.
  • css3/line-break/line-break-normal-inseparables.html: Added.
  • css3/line-break/line-break-normal-iteration-marks-expected.html: Added.
  • css3/line-break/line-break-normal-iteration-marks.html: Added.
  • css3/line-break/line-break-normal-postfixes-expected.html: Added.
  • css3/line-break/line-break-normal-postfixes.html: Added.
  • css3/line-break/line-break-normal-prefixes-expected.html: Added.
  • css3/line-break/line-break-normal-prefixes.html: Added.
  • css3/line-break/line-break-normal-sound-marks-expected.html: Added.
  • css3/line-break/line-break-normal-sound-marks.html: Added.
  • css3/line-break/line-break-strict-centered-expected.html: Added.
  • css3/line-break/line-break-strict-centered.html: Added.
  • css3/line-break/line-break-strict-half-kana-expected.html: Added.
  • css3/line-break/line-break-strict-half-kana.html: Added.
  • css3/line-break/line-break-strict-hyphens-expected.html: Added.
  • css3/line-break/line-break-strict-hyphens.html: Added.
  • css3/line-break/line-break-strict-inseparables-expected.html: Added.
  • css3/line-break/line-break-strict-inseparables.html: Added.
  • css3/line-break/line-break-strict-iteration-marks-expected.html: Added.
  • css3/line-break/line-break-strict-iteration-marks.html: Added.
  • css3/line-break/line-break-strict-postfixes-expected.html: Added.
  • css3/line-break/line-break-strict-postfixes.html: Added.
  • css3/line-break/line-break-strict-prefixes-expected.html: Added.
  • css3/line-break/line-break-strict-prefixes.html: Added.
  • css3/line-break/line-break-strict-sound-marks-expected.html: Added.
  • css3/line-break/line-break-strict-sound-marks.html: Added.
1:18 PM Changeset in webkit [143377] by tony@chromium.org
  • 3 edits
    2 adds in trunk

Border changes on tables with collapsed borders doesn't relayout table cells
​https://bugs.webkit.org/show_bug.cgi?id=109774

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/table/border-collapsing/dynamic-border-width-change.html

Changes to border top and border bottom on table rows also changes the size
of the table cell causing a relayout to be needed.

  • rendering/RenderTableRow.cpp:

(WebCore::borderWidthChanged): Also include border top and bottom.
(WebCore::RenderTableRow::styleDidChange): Remove logical from the helper function name.

LayoutTests:

  • fast/table/border-collapsing/dynamic-border-width-change-expected.txt: Added.
  • fast/table/border-collapsing/dynamic-border-width-change.html: Added.
12:56 PM Changeset in webkit [143376] by Simon Fraser
  • 1 edit
    1 add in trunk/LayoutTests

Add a test result missed in r143074.

  • platform/mac-wk2/tiled-drawing/null-parent-back-crash-expected.txt: Added.
12:49 PM Changeset in webkit [143375] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.
Remove two now-passing tests.

  • platform/chromium/TestExpectations:
12:47 PM Changeset in webkit [143374] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests.

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):

12:43 PM Changeset in webkit [143373] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[WebGL] Fix oes-element-index-uint.html test.
​https://bugs.webkit.org/show_bug.cgi?id=110045

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2013-02-19
Reviewed by Kenneth Russell.

This patch fixes the test case to use updated WebGLTestUtils functions
and adds shaders used during resized buffer tests. This patch
also enables the test for EFL port.

  • fast/canvas/webgl/oes-element-index-uint-expected.txt:
  • fast/canvas/webgl/oes-element-index-uint.html:
  • platform/efl/TestExpectations:
12:36 PM Changeset in webkit [143372] by tommyw@google.com
  • 2 edits in trunk/Source/Platform

WebAudio API: Change the Platform::createAudioDevice function to take a DeviceId parameter
​https://bugs.webkit.org/show_bug.cgi?id=110192

Reviewed by Adam Barth.

  • chromium/public/Platform.h:

(WebKit::Platform::createAudioDevice):
(Platform):

12:32 PM Changeset in webkit [143371] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.4/Source

Versioning.

12:29 PM Changeset in webkit [143370] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.4

New Tag.

12:10 PM Changeset in webkit [143369] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[GTK][AC] Implement matrix transform animation with clutter ac backend
​https://bugs.webkit.org/show_bug.cgi?id=109848

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-19
Reviewed by Gustavo Noronha Silva.

Clutter 1.12 doesn't support additive transform animations yet, so the combination
of two or more transformations(such as rotation after translation) runs unexpectedly.
So we use a matrix transformation instead for the case.

Covered by existing animation tests.

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):

  • platform/graphics/clutter/PlatformClutterAnimation.cpp:

(WebCore::toClutterActorPropertyString): Add actor property "transform"
(WebCore::clutterMatrixProgress): Handle interpolation between two matrices instead of default clutter_matrix_progress.
(WebCore):
(WebCore::PlatformClutterAnimation::supportsAdditiveValueFunction):
(WebCore::PlatformClutterAnimation::setFromValue): for TransformationMatrix.
(WebCore::PlatformClutterAnimation::setToValue): ditto.
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addTransformTransition):

  • platform/graphics/clutter/PlatformClutterAnimation.h:

(PlatformClutterAnimation):

  • platform/graphics/clutter/TransformationMatrixClutter.cpp: Add copy constructor for CoglMatrix.

(WebCore::TransformationMatrix::TransformationMatrix):
(WebCore):

  • platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

12:02 PM Changeset in webkit [143368] by simonjam@chromium.org
  • 2 edits
    1 delete in branches/chromium/1410

Revert 129070

[Chromium] Disable resource load scheduling
​https://bugs.webkit.org/show_bug.cgi?id=97131

Reviewed by Nate Chapin.

Source/WebCore:

We'll use Chrome's network stack for scheduling instead.

No new tests.

  • loader/ResourceLoadScheduler.cpp:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::preload):

LayoutTests:

The preload scanner loads resources sooner and these tests are affected.

  • platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
  • platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Added.

TBR=​simonjam@chromium.org
Review URL: ​https://codereview.chromium.org/12294041

12:01 PM Changeset in webkit [143367] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark fast/workers/storage/interrupt-database.html as flaky crasher
​https://bugs.webkit.org/show_bug.cgi?id=110247

Unreviewed gardening.

  • platform/chromium/TestExpectations:
11:39 AM Changeset in webkit [143366] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r143348.
​http://trac.webkit.org/changeset/143348
​https://bugs.webkit.org/show_bug.cgi?id=110242

"Caused a deleted value sentinel crash on the layout tests"
(Requested by ggaren on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-19

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

  • runtime/CodeCache.h:

(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(SourceCodeKey):

11:34 AM Changeset in webkit [143365] by leviw@chromium.org
  • 1 edit
    2 copies in branches/chromium/1410

Merge 142793

Bidi-Isolated inlines can cause subsequent content to not be rendered
​https://bugs.webkit.org/show_bug.cgi?id=108137

Reviewed by Eric Seidel.

Source/WebCore:

First step in fixing how inline isolates behave with collapsed spaces.
webkit.org/b/109624 tracks the overarching issue.

Test: fast/text/content-following-inline-isolate-with-collapsed-whitespace.html

  • rendering/InlineIterator.h:

(WebCore::IsolateTracker::addFakeRunIfNecessary): If we enter an isolate while
ignoring spaces, ensure we leave it considering them again. This can result in
including spaces that should be ignored following the isolate on the line, but
failing to do so results in those contents not being rendered at all.

LayoutTests:

  • fast/text/content-following-inline-isolate-with-collapsed-whitespace.html: Added.
  • fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt: Added.

TBR=​leviw@chromium.org
Review URL: ​https://codereview.chromium.org/12308006

11:29 AM Changeset in webkit [143364] by schenney@chromium.org
  • 61 edits
    4 deletes in trunk/LayoutTests

Rebaselining, again, calendar tests
​https://bugs.webkit.org/show_bug.cgi?id=110240

Unreviewed expectations update.

  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Removed.
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
11:19 AM Changeset in webkit [143363] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Update FeatureObserver on top level navigation in addition to page destruction.
​https://bugs.webkit.org/show_bug.cgi?id=109874

Patch by Kassy Coan <​kassycoan@chromium.org> on 2013-02-19
Reviewed by Adam Barth.

No new tests. Only effect is to histogram more frequently.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchDidCommitLoad):

  • page/FeatureObserver.cpp:

(WebCore::FeatureObserver::~FeatureObserver):
(WebCore):
(WebCore::FeatureObserver::updateMeasurements):
(WebCore::FeatureObserver::didCommitLoad):

  • page/FeatureObserver.h:

(FeatureObserver):

11:15 AM Changeset in webkit [143362] by pravin.d@samsung.com
  • 2 edits in trunk/Tools

Unreviewed, changing primary email.

11:10 AM Changeset in webkit [143361] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary (and problematic) copy-constructor from LayoutUnit
​https://bugs.webkit.org/show_bug.cgi?id=110121

This copy constructor does what a default copy constructor would do, so
it's not necessary. Furthermore, this copy constructor is the only
reason why LayoutUnit becomes non-POD, and that triggers a gdb bug,
making it impossible to do things like "print location()" when inside
some RenderBlock, for instance.

Gdb bug ​http://sourceware.org/bugzilla/show_bug.cgi?id=15154 reported.

Patch by Morten Stenshorne <​mstensho@opera.com> on 2013-02-19
Reviewed by Benjamin Poulain.

No tests. Apart from dealing with buggy debuggers, this is just code cleanup.

  • platform/LayoutUnit.h:
11:10 AM Changeset in webkit [143360] by commit-queue@webkit.org
  • 2 edits
    1 copy
    1 move in trunk/Tools

REGRESSION: Sheriffbot is failing to process rollout requests
​https://bugs.webkit.org/show_bug.cgi?id=106945

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-02-19
Reviewed by Adam Barth.

Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
This resolves problems when Sheriffbot attempts to perform a rollout request.

  • EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
  • EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
  • EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
11:08 AM Changeset in webkit [143359] by kov@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Romanian translation for WebKitGtk+ HEAD
​https://bugs.webkit.org/show_bug.cgi?id=110009

Patch by Mișu Moldovan <​dumol@gnome.org> on 2013-02-19
Reviewed by Gustavo Noronha.

  • ro.po: Added.
11:06 AM Changeset in webkit [143358] by ap@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

[WK2] Cannot load documents with blob urls
​https://bugs.webkit.org/show_bug.cgi?id=110160

Reviewed by Sam Weinig.

  • http/tests/fileapi/blob-url-in-subframe-expected.txt: Added.
  • http/tests/fileapi/blob-url-in-subframe.html: Added.
  • http/tests/fileapi/resources: Added.
  • http/tests/fileapi/resources/blob-url-in-subframe-frame.html: Added.
11:00 AM Changeset in webkit [143357] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

LayoutUnit::epsilon shouldn't be necessary to place floats
​https://bugs.webkit.org/show_bug.cgi?id=94000

Reviewed by Levi Weintraub.

Currently, to get float placement correct, we need to have an
epsilon tolerance in RenderBlock::computeLogicalLocationForFloat
for the width of the line to fit them on. This really shouldn't
be necessary, and probably indicates we're losing precision
elsewhere.

Remove epsilon as it no longer appears to be needed. All layout
tests pass without it.

No new tests, covered by existing tests.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeLogicalLocationForFloat):

10:57 AM Changeset in webkit [143356] by commit-queue@webkit.org
  • 22 edits
    2 adds in trunk

Text Autosizing: prevent oscillation of font sizes during autosizing
​https://bugs.webkit.org/show_bug.cgi?id=108205

Patch by Tim Volodine <​timvolodine@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

On some websites autosized font-sizes oscillate due to layouts caused by
hovering or incremental page loading (and on other sites font sizes do
eventually stabilize, but it takes many layouts before they reach a steady
size). To prevent all these cases, we no longer allow the autosizing
multiplier to change after it has been set (to a value other than 1).

This won't always give exactly the same results, but testing on 2000 top
sites shows that this makes little difference in practice, and it prevents
these very jarring cases. As a happy side-effect, this speeds up layouts
as font sizes change less.

Test: fast/text-autosizing/oscillation-javascript-fontsize-change.html

  • page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):

  • page/Settings.cpp:

(WebCore::Settings::setTextAutosizingFontScaleFactor):

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::recalculateMultipliers):
(WebCore):
(WebCore::TextAutosizer::processContainer):

  • rendering/TextAutosizer.h:

(TextAutosizer):

LayoutTests:

Added overflow-y:hidden to some existing tests, since previously those tests
would start off with incorrect multipliers (because mainFrame->view()-layoutSize()
is initially 785 instead of 800 as ScrollView wrongly guesses a scrollbar will
be needed), and then the multipliers would get corrected on a subsequent layout.
Now that we don't allow the multiplier to change after being set, it needs to be
right first time.
Also added specific oscillation test triggered by javascript.

  • fast/text-autosizing/constrained-height-body-expected.html:
  • fast/text-autosizing/constrained-height-body.html:
  • fast/text-autosizing/constrained-then-float-ancestors-expected.html:
  • fast/text-autosizing/constrained-then-float-ancestors.html:
  • fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html:
  • fast/text-autosizing/constrained-then-position-fixed-ancestors.html:
  • fast/text-autosizing/nested-em-line-height-expected.html:
  • fast/text-autosizing/nested-em-line-height.html:
  • fast/text-autosizing/oscillation-javascript-fontsize-change-expected.html: Added.
  • fast/text-autosizing/oscillation-javascript-fontsize-change.html: Added.
  • fast/text-autosizing/simple-paragraph-expected.html:
  • fast/text-autosizing/simple-paragraph.html:
  • fast/text-autosizing/span-child-expected.html:
  • fast/text-autosizing/span-child.html:
  • fast/text-autosizing/unwrappable-blocks-expected.html:
  • fast/text-autosizing/unwrappable-blocks.html:
  • fast/text-autosizing/unwrappable-inlines-expected.html:
  • fast/text-autosizing/unwrappable-inlines.html:
10:42 AM Changeset in webkit [143355] by aelias@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Fix races in double-tap zoom minimum scale policy
​https://bugs.webkit.org/show_bug.cgi?id=110183

Reviewed by Adam Barth.

Double-tap zoom on Android is supposed to return to minimum scale
if no pinch zoom occurred since the last double-tap. Because both
pinch zoom and the result of double-tap zoom gets passed in from CC
via applyScrollAndScale, this logic was brittle and prone to races
depending on when the animation update was received. This patch
keeps track of what the target double-tap scale is to make it more
robust.

I also fixed double-tap zoom test mocking to exercise the entire
page scale animation flow (our previous way of testing was hiding the
raciness), and added a new test case in DivAutoZoomMultipleParamsTest.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::startPageScaleAnimation):
(WebKit):
(WebKit::WebViewImpl::enableFakeDoubleTapAnimationForTesting):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::animateZoomAroundPoint):
(WebKit::WebViewImpl::didCommitLoad):
(WebKit::WebViewImpl::applyScrollAndScale):

  • src/WebViewImpl.h:

(WebViewImpl):
(WebKit::WebViewImpl::fakeDoubleTapAnimationPendingForTesting):
(WebKit::WebViewImpl::fakeDoubleTapTargetPositionForTesting):
(WebKit::WebViewImpl::fakeDoubleTapPageScaleFactorForTesting):
(WebKit::WebViewImpl::fakeDoubleTapUseAnchorForTesting):

  • tests/WebFrameTest.cpp:
10:40 AM Changeset in webkit [143354] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

HeapBlock::destroy should issue warning if result is unused
​https://bugs.webkit.org/show_bug.cgi?id=110233

Reviewed by Oliver Hunt.

To enforce the fact that we need to return blocks to the BlockAllocator after calling destroy,
we should add WARN_UNUSED_RETURN to HeapBlock::destroy and any other destroy functions in its subclasses.

  • heap/HeapBlock.h:
10:29 AM Changeset in webkit [143353] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Cannot load documents with blob urls
​https://bugs.webkit.org/show_bug.cgi?id=110160

Reviewed by Sam Weinig.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::canHandleRequest): Added knowledge about blobs.
10:28 AM Changeset in webkit [143352] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][DRT] http/tests/loading/307-after-303-after-post.html times out
​https://bugs.webkit.org/show_bug.cgi?id=93214

Source/WebCore:

Ensured that GET verb is consistently used for any request
coming after a redirection that triggers switching to GET.

Patch by Youenn Fablet <​youennf@gmail.com> on 2013-02-19
Reviewed by Martin Robinson.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::doRedirect):

LayoutTests:

Removed Failure from potential outcome of
http/tests/loading/307-after-303-after-post.html test.

Patch by Youenn Fablet <​youennf@gmail.com> on 2013-02-19
Reviewed by Martin Robinson.

  • platform/efl/TestExpectations:
10:12 AM Changeset in webkit [143351] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

WeakSet::removeAllocator leaks WeakBlocks
​https://bugs.webkit.org/show_bug.cgi?id=110228

Reviewed by Geoffrey Garen.

We need to return the WeakBlock to the BlockAllocator after the call to WeakBlock::destroy.

  • heap/WeakSet.cpp:

(JSC::WeakSet::removeAllocator):

10:07 AM Changeset in webkit [143350] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix compilation if Qt was configured with -no-rtti
​https://bugs.webkit.org/show_bug.cgi?id=110234

Reviewed by Noam Rosenthal.

Availability of dynamic_cast should be checked.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):

10:05 AM Changeset in webkit [143349] by ap@apple.com
  • 3 edits in trunk/Source/WebCore

Unregistered blob URLs have incorrect MIME type
​https://bugs.webkit.org/show_bug.cgi?id=110166

Reviewed by Sam Weinig.

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::shouldUseInnerURL): Added a FIXME.
  • platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyResponseOnError): Pass an accurate MIME type (for a delegate to see).
9:48 AM Changeset in webkit [143348] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Save space on keys in the CodeCache
​https://bugs.webkit.org/show_bug.cgi?id=110179

Reviewed by Oliver Hunt.

Share the SourceProvider's string instead of making our own copy. This
chops off 16MB - 32MB from the CodeCache's memory footprint when full.
(It's 16MB when the strings are LChar, and 32MB when they're UChar.)

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

  • runtime/CodeCache.h: Removed a defunct enum value.

(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(SourceCodeKey):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::string):
(JSC::SourceCodeKey::operator==): Store a SourceCode instead of a String
so we can share our string with our SourceProvider. Cache our hash so
we don't have to re-decode our string just to re-hash the table.

9:42 AM Changeset in webkit [143347] by jsbell@chromium.org
  • 5 edits in trunk/Source

IndexedDB: additional checks on LevelDB decoding
​https://bugs.webkit.org/show_bug.cgi?id=109711

Reviewed by Tony Chang.

Source/WebCore:

Watch out for decoding errors caused by corrupted data, and exit various
decode/compare operations earlier.

Covered by existing LayoutTests and Chromium's webkit_unit_tests

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::decodeStringWithLength): Bail if length is negative.
(WebCore::IDBLevelDBCoding::compareEncodedStringsWithLength): Distinguish error case.
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey): Bail if length is negative.
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys): Distinguish error case.
(WebCore::IDBLevelDBCoding::compare): Plumb through "ok".
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare): Ditto.
(WebCore::IDBLevelDBCoding::ExistsEntryKey::compare): Ditto.
(WebCore::IDBLevelDBCoding::IndexDataKey::compare): Ditto.

  • Modules/indexeddb/IDBLevelDBCoding.h: Updated method signatures.

Source/WebKit/chromium:

  • tests/IDBLevelDBCodingTest.cpp: Update test with new method signatures.
9:12 AM Changeset in webkit [143346] by zherczeg@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

revertBranchPtrWithPatch is incorrect on ARM traditional
​https://bugs.webkit.org/show_bug.cgi?id=110201

Reviewed by Oliver Hunt.

Revert two instructions back to their original value.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::revertBranchPtrWithPatch):
(ARMAssembler):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::revertJumpReplacementToBranchPtrWithPatch):

9:09 AM Changeset in webkit [143345] by Claudio Saavedra
  • 7 edits in trunk

Unreviewed build fix.

.:

  • Source/autotools/FindDependencies.m4:
  • Source/autotools/Versions.m4:
  • Source/cmake/FindHarfBuzz.cmake:

Bump gtk and efl dependencies on harfbuzz
to 0.9.7. See bug 110145.

Tools:

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:

Bump harfbuzz module to 0.9.7. See related bug 110145.

9:01 AM Changeset in webkit [143344] by commit-queue@webkit.org
  • 2 edits in trunk

Only depend on xrender if x11 is being used
​https://bugs.webkit.org/show_bug.cgi?id=84095

Patch by Changhun Kang <​temoochin@company100.net> on 2013-02-19
Reviewed by Martin Robinson.

  • Source/autotools/FindDependencies.m4:
9:01 AM Changeset in webkit [143343] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GTK][AC] Implement keyframe animations with clutter ac backend
​https://bugs.webkit.org/show_bug.cgi?id=110057

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-19
Reviewed by Gustavo Noronha Silva.

This patch brings accelerated keyframe animation with clutter to WebKitGtk+.
Changes of GraphicsLayerClutter are based on GraphicsLayerCA. But major changes
of PlatformClutterAnimation are implemented with clutter keyframe transition apis.
See ​http://developer.gnome.org/clutter/stable/ClutterKeyframeTransition.html

Covered by existing animation tests.

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::createKeyframeAnimation):
(WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerClutter::setAnimationKeyframes):

  • platform/graphics/clutter/PlatformClutterAnimation.cpp:

(WebCore::toClutterActorPropertyString):
(WebCore::PlatformClutterAnimation::PlatformClutterAnimation):
(WebCore::PlatformClutterAnimation::setTimingFunction):
(WebCore::PlatformClutterAnimation::setValues):
(WebCore::PlatformClutterAnimation::setKeyTimes):
(WebCore::PlatformClutterAnimation::setTimingFunctions):
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):
(WebCore::PlatformClutterAnimation::addOpacityTransition):
(WebCore::PlatformClutterAnimation::addTransformTransition):
(WebCore::PlatformClutterAnimation::addAnimationForKey):
(WebCore::PlatformClutterAnimation::removeAnimationForKey):

  • platform/graphics/clutter/PlatformClutterAnimation.h:

(PlatformClutterAnimation):

8:55 AM Changeset in webkit [143342] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing test.

  • platform/qt/TestExpectations:
8:50 AM Changeset in webkit [143341] by Carlos Garcia Campos
  • 8 edits in trunk/Source/WebKit2

[GTK] Move the API to get TLS certificate from WebKitURIResponse to WebKitWebView
​https://bugs.webkit.org/show_bug.cgi?id=110190

Reviewed by Anders Carlsson.

Add webkit_web_view_get_tls_info() and remove
webkit_uri_response_get_https_status(). This way I can be sure
that when called after load has been committed the certificate
will be available. It also makes the API easier to use.

  • UIProcess/API/gtk/WebKitURIResponse.cpp:
  • UIProcess/API/gtk/WebKitURIResponse.h:
  • UIProcess/API/gtk/WebKitURIResponsePrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewLoadChanged):
(mainResourceResponseChangedCallback):
(webkit_web_view_get_tls_info):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestSSL.cpp:
8:50 AM Changeset in webkit [143340] by aandrey@chromium.org
  • 1 edit in trunk/Source/WebKit/win/ChangeLog

Unreviewed, adding external symbol ?didBeginFrame@InspectorCanvasAgent@WebCore@@QAEXXZ.

  • WebKit.vcproj/WebKitExports.def.in:
8:48 AM Changeset in webkit [143339] by mikhail.pozdnyakov@intel.com
  • 8 edits in trunk/Source/WebKit2

[WK2][EFL] Eliminate access to WK2 C++ internals from ewk_view functions
​https://bugs.webkit.org/show_bug.cgi?id=109794

Reviewed by Anders Carlsson.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewSetShowsAsSource):
(WKViewGetShowsAsSource):

Added new WKView API to wrap WebPageProxy::setMainFrameInViewSourceMode()
and WebPageProxy::mainFrameInViewSourceMode() calls.

(WKViewExitFullScreen):

Added new WKView API to wrap WebFullScreenManagerProxy::exitFullScreen()
calls.

  • UIProcess/API/C/efl/WKView.h:
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::feedTouchEvent):

Added feedTouchEvent() method so that: at first ewk_view_feed_touch_event()
is not invoked from EwkView class, secondly ewk_view_feed_touch_event() does
not access WebPage instance directly.

(EwkView::feedTouchEvents):

  • UIProcess/API/efl/EwkView.h:

(EwkView):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_feed_touch_event):
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):
(ewk_view_fullscreen_exit):
(ewkViewPageContentsCallback):
(ewk_view_page_contents_get):
(ewk_view_source_mode_set):
(ewk_view_source_mode_get):

Those are now using exported C API.

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::setShowsAsSource):
(WebKit):
(WebKit::WebView::showsAsSource):
(WebKit::WebView::exitFullScreen):

  • UIProcess/efl/WebView.h:

(WebView):

Added WebView methods to support added WKView API.

8:47 AM Changeset in webkit [143338] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebKit/win

Unreviewed, Web Inspector: follow up to r143328 fixing Win Debug Build
​https://bugs.webkit.org/show_bug.cgi?id=110227

Adding external symbol ?didBeginFrame@InspectorCanvasAgent@WebCore@@QAEXXZ.

  • WebKit.vcproj/WebKitExports.def.in:
8:27 AM Changeset in webkit [143337] by Claudio Saavedra
  • 2 edits in trunk/Source/WebCore

[harfbuzz] Crash in harfbuzz related code
​https://bugs.webkit.org/show_bug.cgi?id=110145

Reviewed by Martin Robinson.

Patch by Behdad Esfahbod <​behdad@google.com>

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Ask harfbuzz
to guess the segment properties.

8:27 AM Changeset in webkit [143336] by schenney@chromium.org
  • 188 edits
    47 adds
    23 deletes in trunk/LayoutTests

Test Expectations update after r143267 and others

Unreviewed expectations update.

Updated many Chromium expectations, and removed superfluous
expectations from mac and win.

  • editing/selection/extend-by-sentence-001-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-linux-x86/svg/filters/big-sized-filter-2-expected.png: Removed.
  • platform/chromium-linux-x86/svg/filters/shadow-on-filter-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug1188-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug1318-expected.png: Removed.
  • platform/chromium-linux/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-linux/svg/batik/text/xmlSpace-expected.txt:
  • platform/chromium-linux/svg/filters/big-sized-filter-2-expected.png: Removed.
  • platform/chromium-linux/svg/filters/shadow-on-filter-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-mac-lion/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac-lion/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
  • platform/chromium-mac-lion/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-sentence-001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/big-sized-filter-2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/shadow-on-filter-expected.png: Removed.
  • platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.txt: Added.
  • platform/chromium-mac/fast/inline/drawStyledEmptyInlines-expected.txt: Added.
  • platform/chromium-mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/chromium-mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Added.
  • platform/chromium-mac/fast/text/capitalize-empty-generated-string-expected.txt: Added.
  • platform/chromium-mac/fast/text/whitespace/006-expected.txt: Added.
  • platform/chromium-mac/fast/text/whitespace/007-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added property svn:mime-type.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/chromium-mac/svg/batik/text/xmlSpace-expected.txt: Added.
  • platform/chromium-mac/svg/custom/visibility-override-filter-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
  • platform/chromium-mac/svg/filters/big-sized-filter-2-expected.png:
  • platform/chromium-mac/svg/filters/feImage-reference-svg-primitive-expected.png:
  • platform/chromium-mac/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-mac/svg/filters/filterRes1-expected.png:
  • platform/chromium-mac/svg/filters/filterRes3-expected.png:
  • platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/chromium-mac/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-mac/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug113235-3-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.
  • platform/chromium-win-xp/svg/filters/big-sized-filter-2-expected.png: Removed.
  • platform/chromium-win-xp/svg/filters/shadow-on-filter-expected.png: Removed.
  • platform/chromium-win/editing/selection/extend-by-sentence-001-expected.txt:
  • platform/chromium-win/fast/inline/drawStyledEmptyInlines-expected.txt:
  • platform/chromium-win/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/chromium-win/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
  • platform/chromium-win/fast/text/capitalize-empty-generated-string-expected.txt:
  • platform/chromium-win/fast/text/whitespace/006-expected.txt:
  • platform/chromium-win/fast/text/whitespace/007-expected.txt:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • platform/chromium-win/svg/filters/big-sized-filter-2-expected.png:
  • platform/chromium-win/svg/filters/feImage-reference-svg-primitive-expected.png:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug113235-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/editing/selection/extend-by-sentence-001-expected.txt: Removed.
  • platform/chromium/fast/inline/drawStyledEmptyInlines-expected.txt: Removed.
  • platform/chromium/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Removed.
  • platform/chromium/fast/text/capitalize-empty-generated-string-expected.txt: Removed.
  • platform/chromium/fast/text/whitespace/006-expected.txt: Removed.
  • platform/chromium/fast/text/whitespace/007-expected.txt: Removed.
  • platform/chromium/svg/batik/text/xmlSpace-expected.txt: Removed.
  • platform/chromium/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Removed.
  • platform/chromium/tables/mozilla/bugs/bug113235-3-expected.txt: Removed.
  • platform/efl-wk2/svg/filters: Added.
  • platform/efl-wk2/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
  • platform/efl/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
  • platform/gtk/editing/selection/extend-by-sentence-001-expected.txt: Removed.
  • platform/mac/TestExpectations:
  • platform/mac/editing/selection/extend-by-sentence-001-expected.txt: Removed.
  • platform/win/TestExpectations:
8:26 AM Changeset in webkit [143335] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] ASSERT(node) hit in WebPage::findZoomableAreaForPoint if no zoomable area found
​https://bugs.webkit.org/show_bug.cgi?id=110220

Reviewed by Allan Sandfeld Jensen.

If EventHandler::bestZoomableAreaForTouchPoint was unsuccessfull, eg.
no node was found for a given point, we hit ASSERT(node).
We should only assert for a valid node if a zoomable area was found.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::findZoomableAreaForPoint):

8:12 AM Changeset in webkit [143334] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: release backtrace object group on each step.
​https://bugs.webkit.org/show_bug.cgi?id=110223

Reviewed by Pavel Feldman.

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):

8:01 AM Changeset in webkit [143333] by commit-queue@webkit.org
  • 12 edits
    3 deletes in trunk

Unreviewed, rolling out r142975.
​http://trac.webkit.org/changeset/142975
​https://bugs.webkit.org/show_bug.cgi?id=110225

Introduces hard-to-reproduce crashes upon inspected page
navigation on Mac (Requested by apavlov on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-19

Source/WebCore:

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::enable):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::collectStyleSheets):
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):
(WebCore::InspectorCSSAgent::buildObjectForRule):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getViaInspectorResourceForRule):
(WebInspector.CSSStyleModelResourceBinding.prototype.):
(WebInspector.CSSStyleModelResourceBinding.prototype.requestStyleSheetIdForResource):
(WebInspector.CSSStyleModelResourceBinding.prototype.requestResourceURLForStyleSheetId):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetIdForResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._loadStyleSheetHeaders):
(WebInspector.CSSStyleModelResourceBinding.prototype.headersLoaded):
(WebInspector.CSSStyleModelResourceBinding.prototype._requestViaInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._getOrCreateInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._reset):

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping.prototype._styleSheetChanged.callback):
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode.callback):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):

  • inspector/front-end/StylesSourceMapping.js:

(WebInspector.StyleContentBinding.prototype.callback):
(WebInspector.StyleContentBinding.prototype.setStyleContent):
(WebInspector.StyleContentBinding.prototype.):
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):

LayoutTests:

  • inspector/styles/resources/stylesheet-tracking.css: Removed.
  • inspector/styles/stylesheet-tracking-expected.txt: Removed.
  • inspector/styles/stylesheet-tracking.html: Removed.
7:53 AM Changeset in webkit [143332] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

Regression(r143273): Caused a lot of tests to time out
​https://bugs.webkit.org/show_bug.cgi?id=110212

Reviewed by Anders Carlsson.

StorageManager::destroySessionStorageNamespace() and StorageManager::cloneSessionStorageNamespace()
should call their respective "*Internal" equivalent instead of calling themselves. This lead to
a lot of time outs on our build bots.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::destroySessionStorageNamespace):
(WebKit::StorageManager::cloneSessionStorageNamespace):

7:41 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu
(diff)
7:36 AM Changeset in webkit [143331] by jchaffraix@webkit.org
  • 4 edits
    2 adds in trunk

RenderGrid::computedUsedBreadthOfGridTracks can read past m_grid's size
​https://bugs.webkit.org/show_bug.cgi?id=110126

Reviewed by Ojan Vafai.

Source/WebCore:

The issue comes from how we store the column information inside m_grid.
Because m_grid is a Vector of rows, we could lose the column information
if we had no row, no grid item but some columns defined in CSS. As the
logic would assume that our row / column size would be greater than what
the style defines explicitely, we would access past our Vector's boundary.

The fix is to ensure that we have at least a row so that we can store the
column information in every case. This fix is overly broad as it also forces
the grid to have one column, which shouldn't be an issue.

Test: fast/css-grid-layout/grid-element-empty-row-column.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::maximumIndexInDirection):
Forced this function to return at least one as the maximum index so that
m_grid has at least one row / column.

(WebCore::RenderGrid::placeItemsOnGrid):
Added a ASSERT that m_grid is bigger than the explicit grid-rows / grid-columns.
Also changed an existing ASSERT to use gridWasPopulated for consistency and changed
the code not to call gridRowCount as it would ASSERT (we are in the middle of populating
the grid).

  • rendering/RenderGrid.h:

(WebCore::RenderGrid::gridWasPopulated):
Added this helper function.

(WebCore::RenderGrid::gridColumnCount):
Replaced a now unneeded branch with an ASSERT. As placeItemsOnGrid should be called
prior to read m_grid, this change should be fine.

(WebCore::RenderGrid::gridRowCount):
Added an ASSERT.

LayoutTests:

  • fast/css-grid-layout/grid-element-empty-row-column-expected.txt: Added.
  • fast/css-grid-layout/grid-element-empty-row-column.html: Added.
7:19 AM Changeset in webkit [143330] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding a crash expectation for the layout test

added in r143303. The test is crashing due to missing bits of EventSender implementation.

7:16 AM Changeset in webkit [143329] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

[Soup] Use synchronous calls to close completely processed streams
​https://bugs.webkit.org/show_bug.cgi?id=107432

Reviewed by Martin Robinson.

There is no need to close already processed streams in asynchronous
calls since they won't block. Using the synchronous call will save
us some code and unnecessary asynchronous burden. This is kind of
a code refactor so no new tests needed.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore):
(WebCore::redirectSkipCallback):
(WebCore::readCallback):

7:13 AM Changeset in webkit [143328] by aandrey@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: [Canvas] use timeline's didBeginFrame for marking frame end calls
​https://bugs.webkit.org/show_bug.cgi?id=110130

Reviewed by Pavel Feldman.

In Web Inspector canvas profiler use timeline's didBeginFrame for marking frame end calls instead of an ad-hoc timeout-based solution.

  • inspector/InjectedScriptCanvasModule.cpp:

(WebCore::InjectedScriptCanvasModule::markFrameEnd):
(WebCore):

  • inspector/InjectedScriptCanvasModule.h:

(InjectedScriptCanvasModule):

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::hasUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped):
(WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::frameNavigated):
(WebCore::InspectorCanvasAgent::didBeginFrame):
(WebCore):

  • inspector/InspectorCanvasAgent.h:

(InspectorCanvasAgent):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::didBeginFrame):

6:59 AM Changeset in webkit [143327] by vsevik@chromium.org
  • 12 edits
    2 adds in trunk

Web Inspector: Decouple various file system project implementation parts for better testability and cover with tests.
​https://bugs.webkit.org/show_bug.cgi?id=110204

Reviewed by Pavel Feldman.

Source/WebCore:

Extracted FileSystemWorkspaceProvider from IsolatedFileSystemManager to take care of managing workspace projects and projectDelegates.
Replaced FileMapping.urlForURI with urlForPath method that does not need any information about workspace structure anymore.

Test: inspector/file-system-project.html

  • inspector/front-end/FileMapping.js:

(WebInspector.FileMapping.prototype.urlForPath):

  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemRemoved):

  • inspector/front-end/IsolatedFileSystem.js:

(WebInspector.IsolatedFileSystem):
(WebInspector.IsolatedFileSystem.prototype.name):
(WebInspector.IsolatedFileSystem.prototype.rootURL):

  • inspector/front-end/IsolatedFileSystemManager.js:

(WebInspector.IsolatedFileSystemManager):
(WebInspector.IsolatedFileSystemManager.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemRemoved):
(WebInspector.IsolatedFileSystemManager.prototype._isolatedFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype.requestDOMFileSystem):

  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest):
(initialize_InspectorTest.):

  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):

  • inspector/file-mapping-expected.txt:
  • inspector/file-mapping.html:
  • inspector/file-system-project-expected.txt: Added.
  • inspector/file-system-project.html: Added.
  • inspector/version-controller.html:
6:43 AM Changeset in webkit [143326] by Simon Hausmann
  • 3 edits in trunk/Tools

[Qt] Skip the build with a warning if certain tools cannot be found in the PATH
​https://bugs.webkit.org/show_bug.cgi?id=110215

Reviewed by Tor Arne Vestbø.

Check that gperf, python, ruby, perl, bison and flex are in the PATH before
continuing the build. Otherwise skip with an error message explaining which
programs are missing from the build.

  • qmake/mkspecs/features/configure.prf:
  • qmake/mkspecs/features/functions.prf:
6:31 AM Changeset in webkit [143325] by aandrey@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Canvas] do not replace replay image with spinner icon
​https://bugs.webkit.org/show_bug.cgi?id=110213

Reviewed by Pavel Feldman.

Otherwise it's visually hard to see changes in the replay image. Instead show a small spinner icon in the bottom right corner.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._enableWaitIcon):

  • inspector/front-end/canvasProfiler.css:

(#canvas-replay-image-container):
(.canvas-debug-info):
(.canvas-spinner-icon):

6:29 AM Changeset in webkit [143324] by aandrey@chromium.org
  • 5 edits in trunk

Web Inspector: [Canvas] UI: tweak replay control buttons behavior
​https://bugs.webkit.org/show_bug.cgi?id=110207

Reviewed by Pavel Feldman.

Source/WebCore:

New behavior for control buttons in the Canvas profiler.

  • The NextCall button (~StepInto) on a node group should expand it and move into its first child (instead of expanding and moving into the next node group)
  • The NextDrawCall button (~StepOver) should move to a next node that has children (instead of just iterating call group nodes, ignoring frame nodes).
  • The ReplayLast button should select the last expanded node (instead of always selecting last frame group node).
  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype._onReplayStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayDrawingCallClick):
(WebInspector.CanvasProfileView.prototype._onReplayLastStepClick):

LayoutTests:

Testing control buttons behavior.

  • inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt:
  • inspector/profiler/canvas2d/canvas-replay-log-grid.html:
5:54 AM Changeset in webkit [143323] by commit-queue@webkit.org
  • 3 edits
    42 deletes in trunk

Unreviewed, rolling out r143319.
​http://trac.webkit.org/changeset/143319
​https://bugs.webkit.org/show_bug.cgi?id=110214

Causes build issues on win32 (Requested by carewolf on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-19

Tools:

  • qmake/mkspecs/features/features.pri:

LayoutTests:

  • platform/qt/mathml/presentation/attributes-expected.png: Removed.
  • platform/qt/mathml/presentation/attributes-expected.txt: Removed.
  • platform/qt/mathml/presentation/fenced-expected.png: Removed.
  • platform/qt/mathml/presentation/fenced-expected.txt: Removed.
  • platform/qt/mathml/presentation/fenced-mi-expected.png: Removed.
  • platform/qt/mathml/presentation/fenced-mi-expected.txt: Removed.
  • platform/qt/mathml/presentation/fractions-expected.png: Removed.
  • platform/qt/mathml/presentation/fractions-expected.txt: Removed.
  • platform/qt/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
  • platform/qt/mathml/presentation/fractions-vertical-alignment-expected.txt: Removed.
  • platform/qt/mathml/presentation/mo-expected.png: Removed.
  • platform/qt/mathml/presentation/mo-expected.txt: Removed.
  • platform/qt/mathml/presentation/mo-stretch-expected.png: Removed.
  • platform/qt/mathml/presentation/mo-stretch-expected.txt: Removed.
  • platform/qt/mathml/presentation/mroot-pref-width-expected.png: Removed.
  • platform/qt/mathml/presentation/mroot-pref-width-expected.txt: Removed.
  • platform/qt/mathml/presentation/over-expected.png: Removed.
  • platform/qt/mathml/presentation/over-expected.txt: Removed.
  • platform/qt/mathml/presentation/roots-expected.png: Removed.
  • platform/qt/mathml/presentation/roots-expected.txt: Removed.
  • platform/qt/mathml/presentation/row-alignment-expected.png: Removed.
  • platform/qt/mathml/presentation/row-alignment-expected.txt: Removed.
  • platform/qt/mathml/presentation/row-expected.png: Removed.
  • platform/qt/mathml/presentation/row-expected.txt: Removed.
  • platform/qt/mathml/presentation/style-expected.png: Removed.
  • platform/qt/mathml/presentation/style-expected.txt: Removed.
  • platform/qt/mathml/presentation/sub-expected.png: Removed.
  • platform/qt/mathml/presentation/sub-expected.txt: Removed.
  • platform/qt/mathml/presentation/subsup-expected.png: Removed.
  • platform/qt/mathml/presentation/subsup-expected.txt: Removed.
  • platform/qt/mathml/presentation/sup-expected.png: Removed.
  • platform/qt/mathml/presentation/sup-expected.txt: Removed.
  • platform/qt/mathml/presentation/tables-expected.png: Removed.
  • platform/qt/mathml/presentation/tables-expected.txt: Removed.
  • platform/qt/mathml/presentation/tokenElements-expected.png: Removed.
  • platform/qt/mathml/presentation/tokenElements-expected.txt: Removed.
  • platform/qt/mathml/presentation/under-expected.png: Removed.
  • platform/qt/mathml/presentation/under-expected.txt: Removed.
  • platform/qt/mathml/presentation/underover-expected.png: Removed.
  • platform/qt/mathml/presentation/underover-expected.txt: Removed.
  • platform/qt/mathml/xHeight-expected.png: Removed.
  • platform/qt/mathml/xHeight-expected.txt: Removed.
5:49 AM AddingFeatures edited by Laszlo Gombos
wtf/FeatureDefines.h has the defaults for all the feature flags (diff)
5:44 AM Changeset in webkit [143322] by abucur@adobe.com
  • 5 edits
    2 adds in trunk

[CSS Regions] Assertion in RenderFlowThread::removeRenderBoxRegionInfo
​https://bugs.webkit.org/show_bug.cgi?id=109914

Reviewed by David Hyatt.

Source/WebCore:

This patch moves a part of the invalidation operations inside the RenderFlowThread::invalidateRegions call. The maps
are cleared anyway at layout time but doing this earlier makes sure the flow thread is in a more consistent state
(the RenderFlowThread object has both the region chain invalidated and the regions information cleared).

RenderFlowThread::removeRenderBoxRegionInfo will check if the region chain is invalidated. If true, it means the
flow thread has a layout scheduled and the regions information is not yet reliable. In this case we just return from the
function and wait for the layout to cleanup the box information.

Test: fast/regions/remove-box-info-assert.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):

  • rendering/RenderFlowThread.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::removeRegionFromThread):

LayoutTests:

The test creates a flow thread with two regions and a content node. We remove the region and the node from the flow thread
at the same time. When the style is updated, the region is first removed from the chain and range information for boxes
is cleared from the flow thread. When the node is removed from the flow thread it tries to delete its region box information.
The range information on the flow thread is gone so the range for the node's box is zero - nothing gets deleted. Afterwards,
an ASSERT is triggered because there's leftover box information inside the region chain.

  • fast/regions/remove-box-info-assert-expected.txt: Added.
  • fast/regions/remove-box-info-assert.html: Added.
5:30 AM Changeset in webkit [143321] by senorblanco@chromium.org
  • 10 edits
    3 copies
    2 moves
    5 adds in trunk/LayoutTests

[chromium] Unreviewed gardening.
New baselines for effect-reference.html and effect-reference-hw.html

  • platform/chromium-linux-x86/css3/filters/effect-reference-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
  • platform/chromium-linux/css3/filters/effect-reference-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
  • platform/chromium-linux/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-mac-lion/css3/filters/effect-reference-expected.png: Added.
  • platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/css3/filters/effect-reference-hw-expected.txt.
  • platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/css3/filters/effect-reference-hw-expected.txt.
  • platform/chromium-mac/css3/filters/effect-reference-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-expected.txt:
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
  • platform/chromium-win-xp/css3/filters/effect-reference-expected.png: Added.
  • platform/chromium-win-xp/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
  • platform/chromium-win/css3/filters/effect-reference-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-expected.txt:
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.txt:
5:15 AM Changeset in webkit [143320] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build broekn by r142988.
​https://bugs.webkit.org/show_bug.cgi?id=109530

Unreviewed. Build fix.

Properly add shortMonthFormat() to the LocaleNone class.

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-02-19

  • platform/text/LocaleNone.cpp:

(LocaleNone):
(WebCore::LocaleNone::shortMonthFormat):

5:02 AM Changeset in webkit [143319] by allan.jensen@digia.com
  • 3 edits
    44 adds in trunk

[Qt] Enable MathML
​https://bugs.webkit.org/show_bug.cgi?id=110205

Reviewed by Simon Hausmann.

Tools:

  • qmake/mkspecs/features/features.pri:

LayoutTests:

Baselines for the MathML tests.

  • platform/qt/mathml/presentation/attributes-expected.png: Added.
  • platform/qt/mathml/presentation/attributes-expected.txt: Added.
  • platform/qt/mathml/presentation/fenced-expected.png: Added.
  • platform/qt/mathml/presentation/fenced-expected.txt: Added.
  • platform/qt/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/qt/mathml/presentation/fenced-mi-expected.txt: Added.
  • platform/qt/mathml/presentation/fractions-expected.png: Added.
  • platform/qt/mathml/presentation/fractions-expected.txt: Added.
  • platform/qt/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/qt/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
  • platform/qt/mathml/presentation/mo-expected.png: Added.
  • platform/qt/mathml/presentation/mo-expected.txt: Added.
  • platform/qt/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/qt/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/qt/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/qt/mathml/presentation/mroot-pref-width-expected.txt: Added.
  • platform/qt/mathml/presentation/over-expected.png: Added.
  • platform/qt/mathml/presentation/over-expected.txt: Added.
  • platform/qt/mathml/presentation/roots-expected.png: Added.
  • platform/qt/mathml/presentation/roots-expected.txt: Added.
  • platform/qt/mathml/presentation/row-alignment-expected.png: Added.
  • platform/qt/mathml/presentation/row-alignment-expected.txt: Added.
  • platform/qt/mathml/presentation/row-expected.png: Added.
  • platform/qt/mathml/presentation/row-expected.txt: Added.
  • platform/qt/mathml/presentation/style-expected.png: Added.
  • platform/qt/mathml/presentation/style-expected.txt: Added.
  • platform/qt/mathml/presentation/sub-expected.png: Added.
  • platform/qt/mathml/presentation/sub-expected.txt: Added.
  • platform/qt/mathml/presentation/subsup-expected.png: Added.
  • platform/qt/mathml/presentation/subsup-expected.txt: Added.
  • platform/qt/mathml/presentation/sup-expected.png: Added.
  • platform/qt/mathml/presentation/sup-expected.txt: Added.
  • platform/qt/mathml/presentation/tables-expected.png: Added.
  • platform/qt/mathml/presentation/tables-expected.txt: Added.
  • platform/qt/mathml/presentation/tokenElements-expected.png: Added.
  • platform/qt/mathml/presentation/tokenElements-expected.txt: Added.
  • platform/qt/mathml/presentation/under-expected.png: Added.
  • platform/qt/mathml/presentation/under-expected.txt: Added.
  • platform/qt/mathml/presentation/underover-expected.png: Added.
  • platform/qt/mathml/presentation/underover-expected.txt: Added.
  • platform/qt/mathml/xHeight-expected.png: Added.
  • platform/qt/mathml/xHeight-expected.txt: Added.
4:45 AM Changeset in webkit [143318] by commit-queue@webkit.org
  • 6 edits in trunk

[Text Autosizing] Combine narrow descendants of a cluster into groups that should be autosized with the same multiplier.
​https://bugs.webkit.org/show_bug.cgi?id=109825

Source/WebCore:

Enhancement of the approach introduced in ​https://bugs.webkit.org/show_bug.cgi?id=109573.
Instead of using the same text size multiplier for all narrow descendants of any autosizing
cluster, group the descendants by how much narrower they are than the cluster's
|blockContainingAllText| and process each group separately with a different multiplier for
each one.
For example, we want nested comments on the page to be autosized as a group but separately
from a sidebar on the same page.

Patch by Anton Vayvod <​avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

Updated the existing test to verify the patch.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processClusterInternal):

Splits the narrow descendants of the autosizing cluster into groups before processing
each group individually.

(WebCore::TextAutosizer::getNarrowDescendantsGroupedByWidth):

Sorts the narrow descendants of the given cluster into groups, combining them by the
difference between their content widths. If sorted by width, two consecutive nodes
belong to the same group if their width difference is no greater than 100 CSS units.

  • rendering/TextAutosizer.h:

New method definitions.

LayoutTests:

Verify that narrow descendants are grouped and autosized separately according to the
difference between the descendant's width and the width of its enclosing cluster's
|blockContainingAllText|.

Patch by Anton Vayvod <​avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

  • fast/text-autosizing/narrow-descendants-combined-expected.html:
  • fast/text-autosizing/narrow-descendants-combined.html:
4:21 AM Changeset in webkit [143317] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: show user provided name property of the heap snapshot node.
​https://bugs.webkit.org/show_bug.cgi?id=110124

Reviewed by Yury Semikhatsky.

Publish userProvidedName into grid node.

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker):

  • inspector/front-end/NativeHeapSnapshot.js:

(WebInspector.NativeHeapSnapshotNode.prototype.serialize):

4:15 AM Changeset in webkit [143316] by abucur@adobe.com
  • 2 edits in trunk/Tools

Unreviewed. Adding myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
3:46 AM Changeset in webkit [143315] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, gardening for chromium.
​https://bugs.webkit.org/show_bug.cgi?id=110203

  • platform/chromium/TestExpectations:
2:41 AM Changeset in webkit [143314] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(r143241): It made 27 layout tests crash on 32 bit platforms
​https://bugs.webkit.org/show_bug.cgi?id=110184

Reviewed by Zoltan Herczeg.

32-bit backend was making all sorts of crazy assumptions, which happened to mostly
not break things prior to ​http://trac.webkit.org/changeset/143241. This brings the
32-bit backend's type speculation fully into compliance with what the 64-bit
backend does.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):

2:14 AM Changeset in webkit [143313] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Caret is not displayed when trying to focus inside a contenteditable element containing an empty block.
​https://bugs.webkit.org/show_bug.cgi?id=108053

Source/WebCore:

Patch by Arpita Bahuguna <​a.bah@samsung.com> on 2013-02-19
Reviewed by Ryosuke Niwa.

Test: editing/selection/caret-in-div-containing-empty-block.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::localCaretRect):
When trying to compute the caret rect for the contenteditable div, the
border and the padding were not considered. Because of this, for the
given test case, which had a border defined on the containing div, the
caret was being painted just atop the border, thereby masking it.

Have modified the code to ensure that the computed caret rect takes
into account the border and padding (if any) specified on the box, but only
if the node doesn't have content that shall be skipped for editing.

We do not add border and padding while computing the caret rect for any
element that either has no content or has content that shall be skipped
for editing purposes. This holds true for table elements as well.

This helps avoid the caret displacement previsouly observed before/after
any controls placed within the contenteditable box, when considering
border and padding in computation of the caret rect.

LayoutTests:

Patch by Arpita Bahuguna <​arpitabahuguna@gmail.com> on 2013-02-19
Reviewed by Ryosuke Niwa.

  • editing/selection/caret-in-div-containing-empty-block-expected.txt: Added.
  • editing/selection/caret-in-div-containing-empty-block.html: Added.

Layout test added for verifying that a caret is displayed within a
contenteditable div having a border, both for the horizontal
as well as the vertical writing modes.

1:56 AM Changeset in webkit [143312] by mihnea@adobe.com
  • 4 edits
    2 adds in trunk

CSSRegions: crash positioned object with inline containing block in flow thread
​https://bugs.webkit.org/show_bug.cgi?id=108307

Reviewed by David Hyatt.

Source/WebCore:

The fix for ​https://bugs.webkit.org/show_bug.cgi?id=69896 allowed positioned blocks work
with variable width regions. However, the information needed for that is available only
when the container used for positioning is a block.

This patch ensures we are using this solution only when the container used for positioning
is a block. This needs to be revisited when we will extend support for other types of boxes
as mentioned in RenderBox::renderBoxRegionInfo.

Test: fast/regions/positioned-object-inline-cb-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth): Make sure we are using containerBlocks
that are blocks. Add an assert that the type of containerBlock we are using can have
computed RenderBoxRegionInfo.
(WebCore::RenderBox::computePositionedLogicalHeight):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion): This helper method
will return the boxes that may have computed RenderBoxRegionInfo. Currently,
returns true for blocks only.

LayoutTests:

  • fast/regions/positioned-object-inline-cb-crash-expected.txt: Added.
  • fast/regions/positioned-object-inline-cb-crash.html: Added.
1:31 AM Changeset in webkit [143311] by morrita@google.com
  • 2 edits in trunk/Tools

Unreviewed, updated spelling of my name.

  • Scripts/webkitpy/common/config/committers.py:
1:27 AM Changeset in webkit [143310] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] fix ScrollAnimatorNoneTest after r143295
​https://bugs.webkit.org/show_bug.cgi?id=110189

Reviewed by Nico Weber.

  • tests/ScrollAnimatorNoneTest.cpp:

(MockScrollableArea):

1:22 AM Changeset in webkit [143309] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Yet anther JSC build fix after r143304.

  • bindings/js/JSDOMBinding.h:

(WebCore::argumentOrNull):

1:00 AM Changeset in webkit [143308] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix. Fixed warning caused by r143305.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

12:55 AM Changeset in webkit [143307] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding a failure expectation for the failing

fast/regions/seamless-iframe-flowed-into-regions.html added in r143256.

12:23 AM Changeset in webkit [143306] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r143304.

  • bindings/js/JSDOMBinding.h:

(WebCore::argumentOrNull):

12:21 AM Changeset in webkit [143305] by haraken@chromium.org
  • 16 edits in trunk/Source/WebCore

[V8] Remove redundant usage of MAYBE_MISSING_PARAMETER() macro
​https://bugs.webkit.org/show_bug.cgi?id=109899

Reviewed by Adam Barth.

Currently:

  • MAYBE_MISSING_PARAMETER(args, index, DefaultIsUndefined) returns args[index].
  • MAYBE_MISSING_PARAMETER(args, index, DefaultIsNullString) returns Local<Value>()

if args[index] is missing (i.e. the length of |args| is less than |index|).
It returns args[index] otherwise.

No one other than CodeGeneratorV8.pm uses
MAYBE_MISSING_PARAMETER(args, index, DefaultIsUndefined). Instead, we simply use
args[index]. We should remove the redundant usage from CodeGeneratorV8.pm too.
The long-name macro has been making generated code less readable.

In addition, we can rename MAYBE_MISSING_PARAMETER() to argumentOrNull().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::TestMediaQueryListListenerV8Internal::methodCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::TestObjV8Internal::methodWithOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::classMethodWithOptionalCallback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
(WebCore::TestObjV8Internal::domStringListFunctionCallback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::TestObjV8Internal::variadicStringMethodCallback):
(WebCore::TestObjV8Internal::variadicDoubleMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
(WebCore::V8TestOverloadedConstructors::constructor4Callback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcCallback):
(WebCore::TestTypedefsV8Internal::setShadowCallback):
(WebCore::TestTypedefsV8Internal::methodWithSequenceArgCallback):
(WebCore::TestTypedefsV8Internal::nullableArrayArgCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunctionCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunction2Callback):
(WebCore::V8TestTypedefs::constructorCallback):

  • bindings/v8/V8BindingMacros.h:

(WebCore):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallbackCustom):
(WebCore::V8History::replaceStateCallbackCustom):

12:12 AM Changeset in webkit [143304] by haraken@chromium.org
  • 14 edits in trunk/Source/WebCore

[JSC] MAYBE_MISSING_PARAMETER(..., DefaultIsNullString) macro is redundant
​https://bugs.webkit.org/show_bug.cgi?id=109902

Reviewed by Adam Barth.

Currently:

  • MAYBE_MISSING_PARAMETER(exec, index, DefaultIsUndefined) returns exec->argument(index).
  • MAYBE_MISSING_PARAMETER(exec, index, DefaultIsNullString) returns JSValue() if exec->argument(index) is missing (i.e. the length of the argument is less than index). It returns exec->argument(index) otherwise.

No one other than CodeGeneratorJS.pm uses
MAYBE_MISSING_PARAMETER(exec, index, DefaultIsUndefined).
Instead, we simply use exec->argument(index). We should remove
the redundant usage in CodeGeneratorJS.pm too. The long-name macro
has been making generated code less readable.

In addition, we can rename MAYBE_MISSING_PARAMETER() to argumentOrNull().

c.f. corresponding V8 bug: ​https://bugs.webkit.org/show_bug.cgi?id=109899

No tests. No change in behavior.

  • bindings/js/JSDOMBinding.h:

(WebCore):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::jsFloat64ArrayPrototypeFunctionFoo):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefined):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod8):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod9):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod10):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence):
(WebCore::jsTestObjPrototypeFunctionStringArrayFunction):
(WebCore::jsTestObjPrototypeFunctionDomStringListFunction):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
(WebCore::jsTestObjPrototypeFunctionVariadicStringMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors1):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors2):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors3):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors4):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionMultiTransferList):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::constructJSTestTypedefs):
(WebCore::jsTestTypedefsPrototypeFunctionFunc):
(WebCore::jsTestTypedefsPrototypeFunctionMultiTransferList):
(WebCore::jsTestTypedefsPrototypeFunctionSetShadow):
(WebCore::jsTestTypedefsPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestTypedefsPrototypeFunctionNullableArrayArg):
(WebCore::jsTestTypedefsPrototypeFunctionStringArrayFunction):
(WebCore::jsTestTypedefsPrototypeFunctionStringArrayFunction2):

Note: See TracTimeline for information about the timeline view.