Context Navigation

← Previous Period
Next Period →

Timeline

Feb 23, 2013:

11:29 PM Changeset in webkit [143861] by ap@apple.com

2 edits in trunk/Source/WebCore

ResourceRequestBase unnecessarily updates when nothing changes
https://bugs.webkit.org/show_bug.cgi?id=110665

Reviewed by Dan Bernstein.

Don't mark platform data for update if nothing really changed. This avoids ever doing
doUpdatePlatformRequest() in NetworkProcess during normal browsing for me, which is
good for performance.

platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::removeCredentials):
(WebCore::ResourceRequestBase::setCachePolicy):
(WebCore::ResourceRequestBase::setTimeoutInterval):
(WebCore::ResourceRequestBase::setFirstPartyForCookies):
(WebCore::ResourceRequestBase::setHTTPMethod):
(WebCore::ResourceRequestBase::clearHTTPAuthorization):
(WebCore::ResourceRequestBase::setAllowCookies):
(WebCore::ResourceRequestBase::setPriority):

11:24 PM Changeset in webkit [143860] by benjamin@webkit.org

6 edits
2 deletes in trunk/LayoutTests

Add support for testing states changing asynchronously. Apply it to state-url-sets-links-visited.html.
https://bugs.webkit.org/show_bug.cgi?id=109883

Reviewed by Antti Koivisto.

Some tests depends on state change happening asynchronously. This is typically solved by using
timers with a long enough interval.

Timers have the general pitfalls of causing unreliable tests, and forcing unnecessary delays
in the tests.

This patch introduces new testing helpers, shouldBecomeEqual and shouldBecomeEqualToString, to
test a change of state repetively until it succeed (or timeout). Those test functions execute
the condition every 5ms until the test succeed.

The helper shouldBecomeEqualToString is applied on state-url-sets-links-visited.html to illustrate
the concept.

fast/js/resources/js-test-pre.js:

(_waitForCondition): Generic helper function for the familly shouldBecomeXXX.
(.condition):
(.failureHandler):
(shouldBecomeEqual):
(shouldBecomeEqualToString):

fast/loader/stateobjects/state-url-sets-links-visited.html:
platform/wk2/TestExpectations:

state-url-sets-links-visited.html failed on WebKit2 because the visited links table is updated
asynchronously, and the style is only updated after 1 IPC message + 1 timer + 1 IPC message.

The test is changed to use shouldBecomeEqualToString in order to become reliable. If the UIProcess
does not update the style in a reasonable amount of time, the test fails.

platform/chromium/TestExpectations: Make the test as failing on Chromium until proper test support is added

to DRT or Internals.

10:35 PM Changeset in webkit [143859] by pdr@google.com

3 edits
2 adds in trunk

Prevent crash in animated transform lists
https://bugs.webkit.org/show_bug.cgi?id=110704

Reviewed by Abhishek Arya.

Source/WebCore:

This change prevents accessing values off the end of toAtEndOfDuration by adding a check
for this case. Similar checks were added in r116458 but the author failed to catch this
case. WK110706 has been filed to handle this case in general.

This change also makes a trivial change that marks effectiveFrom as const.

Test: svg/animations/animateTransform-list-crash.html

svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):

LayoutTests:

svg/animations/animateTransform-list-crash-expected.txt: Added.
svg/animations/animateTransform-list-crash.html: Added.

10:18 PM Changeset in webkit [143858] by Dimitri Glazkov

6 edits in trunk/Source/WebCore

SelectorChecker should not know about SelectorCheckerFastPath.
https://bugs.webkit.org/show_bug.cgi?id=110663

Both SelectorChecker and it's speedy cousin unfortunately include each other.
Luckily, the particular way in which SelectorQuery uses SelectorChecker yields
to a fairly simple decoupling. Now only the cousin knows of SelectorChecker.

Reviewed by Antti Koivisto.

No new functionality, covered by existing tests.

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matches): Removed.

css/SelectorChecker.h:

(SelectorChecker): Updated the decls to remove fast-path flag.

dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorMatches): Added a helper just for SelectorQuery.
(WebCore::SelectorDataList::matches): Changed the callsite to use new helper.
(WebCore::SelectorDataList::execute): Ditto.

dom/SelectorQuery.h:

(SelectorDataList): Updated decls.

9:31 PM Changeset in webkit [143857] by eric.carlson@apple.com

4 edits in trunk/Source/WebCore

[Mac] user preference caption style applied incorrectly
https://bugs.webkit.org/show_bug.cgi?id=110707
<rdar://problem/13281096>

Reviewed by Maciej Stachowiak.

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::textTrackContainerElementShadowPseudoId): New

static function so the pseudo ID is available.

(WebCore::MediaControlTextTrackContainerElement::shadowPseudoId): Call textTrackContainerElementShadowPseudoId.

html/shadow/MediaControlElements.h:

page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Style the text track container

element for cue color, edge style, and font name.

6:54 PM Changeset in webkit [143856] by haraken@chromium.org

9 edits in trunk/Source/WebCore

[V8] Generate xxxAttrGetterCallback()
https://bugs.webkit.org/show_bug.cgi?id=110676

Reviewed by Adam Barth.

This is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings. This patch introduces an indirection
function for xxxAttrGetter(), like this:

For non-custom getters
Handle<Value> xxxAttrGetterCallback(...) {

return xxxAttrGetter(...);

}

For custom getters.
Handle<Value> xxxAttrGetterCallback(...) {

return xxxAttrGetterCustom(...);

}

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateSingleBatchedAttribute):
(GenerateNonStandardFunction):
(GenerateImplementation):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingAttrAttrGetterCallback):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetterCallback):
(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::TestEventConstructorV8Internal::attr1AttrGetterCallback):
(TestEventConstructorV8Internal):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetterCallback):
(WebCore):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::TestExceptionV8Internal::nameAttrGetterCallback):
(TestExceptionV8Internal):
(WebCore):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetterCallback):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetterCallback):
(WebCore):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyLongAttrAttrGetterCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::staticReadOnlyLongAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::enumAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::shortAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::longAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::longLongAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::stringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::testObjAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::createAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::customAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr1AttrGetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr2AttrGetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr3AttrGetterCallback):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetterCallback):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetterCallback):
(WebCore::TestObjV8Internal::anyAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrGetterCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrGetterCallback):
(WebCore::TestObjV8Internal::enabledPerContextAttr1AttrGetterCallback):
(WebCore::TestObjV8Internal::enabledPerContextAttr2AttrGetterCallback):
(WebCore::TestObjV8Internal::floatArrayAttrGetterCallback):
(WebCore::TestObjV8Internal::doubleArrayAttrGetterCallback):
(WebCore::TestObjV8Internal::contentDocumentAttrGetterCallback):
(WebCore::TestObjV8Internal::mutablePointAttrGetterCallback):
(WebCore::TestObjV8Internal::immutablePointAttrGetterCallback):
(WebCore::TestObjV8Internal::strawberryAttrGetterCallback):
(WebCore::TestObjV8Internal::strictFloatAttrGetterCallback):
(WebCore::TestObjV8Internal::descriptionAttrGetterCallback):
(WebCore::TestObjV8Internal::idAttrGetterCallback):
(WebCore::TestObjV8Internal::hashAttrGetterCallback):
(WebCore::TestObjV8Internal::replaceableAttributeAttrGetterCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetterCallback):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetterCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetterCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetterCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetterCallback):
(WebCore):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrGetterCallback):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrGetterCallback):
(WebCore):

5:38 PM Changeset in webkit [143855] by haraken@chromium.org

2 edits in trunk/Source/WebCore

WebCore fails to link in Chromium official build
https://bugs.webkit.org/show_bug.cgi?id=110701

Reviewed by Abhishek Arya.

This is a follow-up fix for r143853. In WebCore.gyp, we need to
increase the shard of 'webcore_rendering' as well.

No tests. No change in behavior.

WebCore.gyp/WebCore.gyp:

4:17 PM Changeset in webkit [143854] by haraken@chromium.org

3 edits
1 delete in trunk/Source/WebCore

Unreviewed, rolling out r143844.
http://trac.webkit.org/changeset/143844
https://bugs.webkit.org/show_bug.cgi?id=110241

It broke Chromium Mac Release Build

WebCore.gyp/WebCore.gyp:
WebCore.gyp/WebCoreGTK.gyp: Removed.
WebCore.gypi:

3:33 PM Changeset in webkit [143853] by abarth@webkit.org

2 edits in trunk/Source/WebCore

WebCore fails to link in Chromium official build
https://bugs.webkit.org/show_bug.cgi?id=110697

Reviewed by Eric Seidel.

Apparently we need to use more shards to work around linker limitations
on Windows again.

WebCore.gyp/WebCore.gyp:

3:31 PM Changeset in webkit [143852] by pilgrim@chromium.org

6 edits
2 moves in trunk/Tools

[Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
https://bugs.webkit.org/show_bug.cgi?id=110606

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/DumpRenderTree.cpp:

(WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
(WebKitSupportTestEnvironment::mockPlatform):
(WebKitSupportTestEnvironment):

DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.

(MockPlatform::create):
(MockPlatform::MockPlatform):
(MockPlatform::~MockPlatform):
(MockPlatform::setInterfaces):
(MockPlatform::cryptographicallyRandomValues):
(MockPlatform::createMediaStreamCenter):
(MockPlatform::createRTCPeerConnectionHandler):

DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.

(MockPlatform):

DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

DumpRenderTree/chromium/TestShell.h:

(TestShell):

2:37 PM Changeset in webkit [143851] by haraken@chromium.org

11 edits in trunk/Source/WebCore

[V8] Rename constructorCallbackCustom() to constructorCustom()
https://bugs.webkit.org/show_bug.cgi?id=110671

Reviewed by Adam Barth.

his is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings.
See https://bugs.webkit.org/show_bug.cgi?id=110667#c0

In the new world, "Callback" is used to indicate that it
is a function called back by V8. Currently "Callback" is
used for both V8 callbacks, DOM methods and DOM constructors.
This patch fixes the inconsistency.

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateCustomConstructorCallback):

bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCustom):

bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCustom):

bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCustom):

bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCustom):

bindings/v8/custom/V8MessageChannelCustom.cpp:

(WebCore::V8MessageChannel::constructorCustom):

bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCustom):

bindings/v8/custom/V8WebKitPointCustom.cpp:

(WebCore::V8WebKitPoint::constructorCustom):

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCustom):

2:23 PM Changeset in webkit [143850] by haraken@chromium.org

50 edits in trunk/Source/WebCore

[V8] Rename xxxCallback() to xxxMethod(), and xxxCallbackCustom() to xxxMethodCustom()
https://bugs.webkit.org/show_bug.cgi?id=110669

Reviewed by Adam Barth.

This is one of steps to insert TRACE_EVENT_STATE()
macros into DOM bindings.
See https://bugs.webkit.org/show_bug.cgi?id=110667#c0

In the new world, "Callback" is used to refer that it
is a function called back by V8. Currently "Callback" is
used for both V8 callbacks, DOM methods and DOM constructors.
This patch fixes the inconsistency.

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::Float64ArrayV8Internal::setMethod):
(WebCore):
(WebCore::ConfigureV8Float64ArrayTemplate):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionMethod):
(WebCore):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemMethod):
(WebCore::TestEventTargetV8Internal::addEventListenerMethod):
(WebCore::TestEventTargetV8Internal::removeEventListenerMethod):
(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore):
(WebCore::ConfigureV8TestEventTargetTemplate):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalMethod1Method):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::TestInterfaceV8Internal::supplementalMethod3Method):
(WebCore::TestInterfaceV8Internal::supplementalMethod4Method):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::TestMediaQueryListListenerV8Internal::methodMethod):
(WebCore):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::voidMethodMethod):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodWithSequenceArgMethod):
(WebCore::TestObjV8Internal::methodReturningSequenceMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::serializedValueMethod):
(WebCore::TestObjV8Internal::optionsObjectMethod):
(WebCore::TestObjV8Internal::methodWithExceptionMethod):
(WebCore::TestObjV8Internal::customMethodMethod):
(WebCore::TestObjV8Internal::customMethodWithArgsMethod):
(WebCore::TestObjV8Internal::addEventListenerMethod):
(WebCore::TestObjV8Internal::removeEventListenerMethod):
(WebCore::TestObjV8Internal::withScriptStateVoidMethod):
(WebCore::TestObjV8Internal::withScriptStateObjMethod):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionMethod):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesMethod):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackMethod):
(WebCore::TestObjV8Internal::methodWithOptionalArgMethod):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgMethod):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsMethod):
(WebCore::TestObjV8Internal::methodWithOptionalStringMethod):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedMethod):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringMethod):
(WebCore::TestObjV8Internal::methodWithCallbackArgMethod):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgMethod):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgMethod):
(WebCore::TestObjV8Internal::conditionalMethod1Method):
(WebCore::TestObjV8Internal::conditionalMethod2Method):
(WebCore::TestObjV8Internal::conditionalMethod3Method):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod3Method):
(WebCore::TestObjV8Internal::overloadedMethod4Method):
(WebCore::TestObjV8Internal::overloadedMethod5Method):
(WebCore::TestObjV8Internal::overloadedMethod6Method):
(WebCore::TestObjV8Internal::overloadedMethod7Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethod9Method):
(WebCore::TestObjV8Internal::overloadedMethod10Method):
(WebCore::TestObjV8Internal::overloadedMethod11Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::classMethodMethod):
(WebCore::TestObjV8Internal::classMethodWithOptionalMethod):
(WebCore::TestObjV8Internal::classMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod12Method):
(WebCore::TestObjV8Internal::classMethodWithClampMethod):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Method):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Method):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Method):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Method):
(WebCore::TestObjV8Internal::stringArrayFunctionMethod):
(WebCore::TestObjV8Internal::domStringListFunctionMethod):
(WebCore::TestObjV8Internal::getSVGDocumentMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::mutablePointFunctionMethod):
(WebCore::TestObjV8Internal::immutablePointFunctionMethod):
(WebCore::TestObjV8Internal::orangeMethod):
(WebCore::TestObjV8Internal::strictFunctionMethod):
(WebCore::TestObjV8Internal::variadicStringMethodMethod):
(WebCore::TestObjV8Internal::variadicDoubleMethodMethod):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextPrototypeProperties):

bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListMethod):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListMethod):
(WebCore):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::TestTypedefsV8Internal::multiTransferListMethod):
(WebCore::TestTypedefsV8Internal::setShadowMethod):
(WebCore::TestTypedefsV8Internal::methodWithSequenceArgMethod):
(WebCore::TestTypedefsV8Internal::nullableArrayArgMethod):
(WebCore::TestTypedefsV8Internal::funcWithClampMethod):
(WebCore::TestTypedefsV8Internal::immutablePointFunctionMethod):
(WebCore::TestTypedefsV8Internal::stringArrayFunctionMethod):
(WebCore::TestTypedefsV8Internal::stringArrayFunction2Method):
(WebCore::TestTypedefsV8Internal::methodWithExceptionMethod):
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):

bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::clearDataMethodCustom):
(WebCore::V8Clipboard::setDragImageMethodCustom):

bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::traceMethodCustom):
(WebCore::V8Console::assertMethodCustom):
(WebCore::V8Console::profileMethodCustom):
(WebCore::V8Console::profileEndMethodCustom):

bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesMethodCustom):

bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::appendMethodCustom):

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::addEventListenerMethodCustom):
(WebCore::V8DOMWindow::removeEventListenerMethodCustom):
(WebCore::V8DOMWindow::postMessageMethodCustom):
(WebCore::V8DOMWindow::toStringMethodCustom):
(WebCore::V8DOMWindow::releaseEventsMethodCustom):
(WebCore::V8DOMWindow::captureEventsMethodCustom):
(WebCore::V8DOMWindow::showModalDialogMethodCustom):
(WebCore::V8DOMWindow::openMethodCustom):
(WebCore::V8DOMWindow::setTimeoutMethodCustom):
(WebCore::V8DOMWindow::setIntervalMethodCustom):

bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::getInt8MethodCustom):
(WebCore::V8DataView::getUint8MethodCustom):
(WebCore::V8DataView::setInt8MethodCustom):
(WebCore::V8DataView::setUint8MethodCustom):

bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::V8DedicatedWorkerContext::postMessageMethodCustom):

bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::initDeviceMotionEventMethodCustom):

bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventMethodCustom):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateMethodCustom):
(WebCore::V8Document::createTouchListMethodCustom):

bindings/v8/custom/V8GeolocationCustom.cpp:

(WebCore::V8Geolocation::getCurrentPositionMethodCustom):
(WebCore::V8Geolocation::watchPositionMethodCustom):

bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::V8HTMLAllCollection::itemMethodCustom):
(WebCore::V8HTMLAllCollection::namedItemMethodCustom):

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextMethodCustom):
(WebCore::V8HTMLCanvasElement::toDataURLMethodCustom):

bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::writeMethodCustom):
(WebCore::V8HTMLDocument::writelnMethodCustom):
(WebCore::V8HTMLDocument::openMethodCustom):

bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:

(WebCore::V8HTMLFormControlsCollection::namedItemMethodCustom):

bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorMethodCustom):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):

bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::setSelectionRangeMethodCustom):

bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::namedItemMethodCustom):
(WebCore::V8HTMLOptionsCollection::removeMethodCustom):
(WebCore::V8HTMLOptionsCollection::addMethodCustom):

bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::removeMethodCustom):

bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateMethodCustom):
(WebCore::V8History::replaceStateMethodCustom):

bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::inspectedObjectMethodCustom):
(WebCore::V8InjectedScriptHost::internalConstructorNameMethodCustom):
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::functionDetailsMethodCustom):
(WebCore::V8InjectedScriptHost::getInternalPropertiesMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):
(WebCore::V8InjectedScriptHost::inspectMethodCustom):
(WebCore::V8InjectedScriptHost::databaseIdMethodCustom):
(WebCore::V8InjectedScriptHost::storageIdMethodCustom):
(WebCore::V8InjectedScriptHost::evaluateMethodCustom):
(WebCore::V8InjectedScriptHost::setFunctionVariableValueMethodCustom):

bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::V8InspectorFrontendHost::platformMethodCustom):
(WebCore::V8InspectorFrontendHost::portMethodCustom):
(WebCore::V8InspectorFrontendHost::showContextMenuMethodCustom):
(WebCore::V8InspectorFrontendHost::recordActionTakenMethodCustom):
(WebCore::V8InspectorFrontendHost::recordPanelShownMethodCustom):
(WebCore::V8InspectorFrontendHost::recordSettingChangedMethodCustom):

bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::evaluateMethodCustom):
(WebCore::V8JavaScriptCallFrame::restartMethodCustom):
(WebCore::V8JavaScriptCallFrame::setVariableValueMethodCustom):
(WebCore::V8JavaScriptCallFrame::scopeTypeMethodCustom):

bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):
(WebCore::V8Location::reloadMethodCustom):
(WebCore::V8Location::replaceMethodCustom):
(WebCore::V8Location::assignMethodCustom):
(WebCore::V8Location::valueOfMethodCustom):
(WebCore::V8Location::toStringMethodCustom):

bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::initMessageEventMethodCustom):
(WebCore::V8MessageEvent::webkitInitMessageEventMethodCustom):

bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::V8MessagePort::postMessageMethodCustom):

bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::requestPermissionMethodCustom):

bindings/v8/custom/V8NotificationCustom.cpp:

(WebCore::V8Notification::requestPermissionMethodCustom):

bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemMethodCustom):

bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlMethodCustom):

bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlMethodCustom):

bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::convertToSpecifiedUnitsMethodCustom):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getBufferParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getExtensionMethodCustom):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getRenderbufferParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsMethodCustom):
(WebCore::V8WebGLRenderingContext::getTexParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::V8WebGLRenderingContext::getVertexAttribMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform1fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform1ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform2fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform2ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform3fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform3ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform4fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform4ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix2fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix3fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix4fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib1fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib2fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib3fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib4fvMethodCustom):

bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::importScriptsMethodCustom):
(WebCore::V8WorkerContext::setTimeoutMethodCustom):
(WebCore::V8WorkerContext::setIntervalMethodCustom):

bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::V8Worker::postMessageMethodCustom):

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::openMethodCustom):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

bindings/v8/custom/V8XSLTProcessorCustom.cpp:

(WebCore::V8XSLTProcessor::setParameterMethodCustom):
(WebCore::V8XSLTProcessor::getParameterMethodCustom):
(WebCore::V8XSLTProcessor::removeParameterMethodCustom):

12:44 PM Changeset in webkit [143849] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Skip javascriptDialogEvents.html since its result bleed into other tests non-deterministically per bug 110186.

platform/mac/TestExpectations:

12:41 PM Changeset in webkit [143848] by Dimitri Glazkov

12 edits in trunk/Source/WebCore

Scrollbar style resolution arguments should not passed via statics.
https://bugs.webkit.org/show_bug.cgi?id=110690

Use PseudoStyleRequest to pass scrollbar params for style resolve.

Reviewed by Eric Seidel.

No change in functionality, covered by existing tests.

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match): Changed to use context params, rather than statics.
(WebCore::SelectorChecker::checkOne): Changed to pass context to checkScrollbarPseudoClass.
(WebCore::SelectorChecker::checkScrollbarPseudoClass): Changed to use context params, rather than statics.

css/SelectorChecker.h:

(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): Added scrollbar style args.
(SelectorCheckingContext): Ditto.

css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use PseudoStyleRequest.
(WebCore::StyleResolver::State::initForStyleResolve): Ditto.
(WebCore::StyleResolver::pseudoStyleForElement): Ditto.
(WebCore::StyleResolver::ruleMatches): Ditto and added stuffing scrollbar style resolve args into SelectorCheckingContext.

css/StyleResolver.h:

(PseudoStyleRequest): Added.
(State): Changed to hold and use PseudoStyleRequest instead of just PseudoId

dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid): Changed to use PseudoStyleRequest.

page/FrameView.cpp: Ditto.

(WebCore::FrameView::updateScrollCorner): Ditto.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollCornerStyle): Ditto.
(WebCore::RenderLayer::updateResizerStyle): Ditto.

rendering/RenderObject.cpp:

(WebCore::RenderObject::selectionBackgroundColor): Ditto.
(WebCore::RenderObject::selectionColor): Ditto.
(WebCore::firstLineStyleForCachedUncachedType): Ditto.
(WebCore::RenderObject::getCachedPseudoStyle): Ditto.
(WebCore::RenderObject::getUncachedPseudoStyle): Ditto.

rendering/RenderObject.h:

(RenderObject): Ditto.

rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::getScrollbarPseudoStyle): Ditto.

rendering/RenderScrollbar.h:

(RenderScrollbar): Removed static members that are now obsolete.

12:00 PM Changeset in webkit [143847] by zandobersek@gmail.com

3 edits in trunk/LayoutTests

Unreviewed gardening.

platform/efl/TestExpectations: Adding a failure expectation for the html5lib/runner.html test

that started failing with r143804.

platform/gtk/TestExpectations: Ditto. Also adding flaky crasher expectations for two http tests,

crashes are originating from IDB code and starter appearing with r143694.

11:57 AM Changeset in webkit [143846] by pilgrim@chromium.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
https://bugs.webkit.org/show_bug.cgi?id=110605

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

public/WebKit.h:

(WebKit):

src/WebKit.cpp:

(WebKit::initialize):
(WebKit::initializeWithoutV8):
(WebKit::webKitPlatformSupport):

10:37 AM Changeset in webkit [143845] by abarth@webkit.org

4 edits in trunk/Source/WebCore

Threaded HTML parser should pass fast/parser/parser-yield-timing.html
https://bugs.webkit.org/show_bug.cgi?id=110647

Reviewed by Eric Seidel.

Previously, the threaded HTML parser would run for an arbitrary amount
of time without yielding after speculation succeeded. This might be the
cause of the good DOMContentLoaded numbers.

Note: This patch also demonstrates that the ParseHTML_max numbers
aren't correct currently because they're measuring the interior of this
loop instead of all the time spent in the loop. We should move the
instrumentation in a followup patch.

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::resumeParsingAfterYield):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

html/parser/HTMLParserScheduler.cpp:

10:22 AM Changeset in webkit [143844] by commit-queue@webkit.org

3 edits
1 add in trunk/Source/WebCore

[GTK] Allow sharing the WebCore include list with the Chromium build
https://bugs.webkit.org/show_bug.cgi?id=110241

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-23
Reviewed by Dirk Pranke.

WebCore.gyp/WebCore.gyp: Moved shared include directories to

WebCore.gypi.

WebCore.gyp/WebCoreGTK.gyp: Added. A skeleton gyp file for WebCoreGTK+.
WebCore.gypi: Added shared include directories.

9:57 AM Changeset in webkit [143843] by akling@apple.com

64 edits in trunk/Source/WebCore

StyledElement: Tweak signature of collectStyleForPresentationAttribute().
<http://webkit.org/b/110687>

Reviewed by Antti Koivisto.

Out with the old:

collectStyleForPresentationAttribute(const Attribute&, StylePropertySet*)

In with the new:

collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*)

This is primarily about switching to using MutableStylePropertySet* in preparation for
removing mutating functions from the StylePropertySet base class.

8:55 AM Changeset in webkit [143842] by commit-queue@webkit.org

9 edits
1 copy
1 add in trunk/Source/WebCore

[EFL][WebGL] Refactor GLPlatformSurface.
https://bugs.webkit.org/show_bug.cgi?id=110616

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-23
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

With recent changes, there is a clear separation between
transport surface and off-screen surface. PlatformSurface
has the logic to render content to transport surface.
We currently rely on EXT_framebuffer_blit for this. This
extension is not exposed on GLES2.0. PlatformSurface was
supposed to be an abstraction layer without any knowledge
of the type of surface. This patch addresses the issues
in PlatformSurface class. We use shaders to draw texture
content to the surface. Any transport surface related
code in PlatformSurface is moved to GLTransportSurface class.

PlatformEfl.cmake:
platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::didResizeCanvas):

platform/graphics/surfaces/GLTransportSurface.cpp: Added.

(WebCore):
(WebCore::GLTransportSurface::GLTransportSurface):
(WebCore::GLTransportSurface::~GLTransportSurface):
(WebCore::GLTransportSurface::updateContents):
(WebCore::GLTransportSurface::setGeometry):
(WebCore::GLTransportSurface::destroy):
(WebCore::GLTransportSurface::draw):
(WebCore::GLTransportSurface::bindArrayBuffer):
(WebCore::GLTransportSurface::updateTransformationMatrix):
(WebCore::GLTransportSurface::initializeShaderProgram):

platform/graphics/surfaces/GLTransportSurface.h:

(WebCore):
(GLTransportSurface):

platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::destroy):
(WebCore::EGLWindowTransportSurface::setGeometry):

platform/graphics/surfaces/egl/EGLSurface.h:
platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::setGeometry):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXOffScreenSurface::freeResources):

platform/graphics/surfaces/glx/GLXSurface.h:

8:16 AM Changeset in webkit [143841] by Martin Robinson

41 edits
25 adds in trunk/LayoutTests

Remove some tests needing to be rebaselined from TestExpectations

platform/gtk/TestExpectations: Update the list of tests needing new baselines

and skip some that are timing out on my machine.

platform/gtk/accessibility/color-well-expected.txt: Added.
platform/gtk/accessibility/image-link-expected.txt: Added.
platform/gtk/accessibility/image-map1-expected.txt: Added.
platform/gtk/accessibility/image-map2-expected.txt: Added.
platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt: Added.
platform/gtk/accessibility/multiselect-list-reports-active-option-expected.txt: Added.
platform/gtk/accessibility/notification-listeners-expected.txt: Added.
platform/gtk/css2.1/t0505-c16-descendant-01-e-expected.png:
platform/gtk/css2.1/t0505-c16-descendant-01-e-expected.txt:
platform/gtk/editing/selection/extend-by-sentence-001-expected.png:
platform/gtk/editing/selection/extend-by-sentence-001-expected.txt: Added.
platform/gtk/fast/block/float/024-expected.png:
platform/gtk/fast/block/float/024-expected.txt: Added.
platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.png:
platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt: Added.
platform/gtk/fast/css/resize-corner-tracking-expected.png:
platform/gtk/fast/css/resize-corner-tracking-expected.txt:
platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
platform/gtk/fast/inline/drawStyledEmptyInlines-expected.png:
platform/gtk/fast/inline/drawStyledEmptyInlines-expected.txt:
platform/gtk/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
platform/gtk/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
platform/gtk/fast/inline/justify-emphasis-inline-box-expected.png: Added.
platform/gtk/fast/inline/justify-emphasis-inline-box-expected.txt: Added.
platform/gtk/fast/repaint/caret-with-transformation-expected.png: Added.
platform/gtk/fast/repaint/caret-with-transformation-expected.txt: Added.
platform/gtk/fast/text/capitalize-empty-generated-string-expected.png:
platform/gtk/fast/text/capitalize-empty-generated-string-expected.txt:
platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
platform/gtk/fast/text/whitespace/006-expected.png:
platform/gtk/fast/text/whitespace/006-expected.txt:
platform/gtk/fast/text/whitespace/007-expected.png:
platform/gtk/fast/text/whitespace/007-expected.txt:
platform/gtk/media/audio-controls-rendering-expected.png: Added.
platform/gtk/media/audio-controls-rendering-expected.txt:
platform/gtk/media/controls-after-reload-expected.txt:
platform/gtk/media/controls-strict-expected.txt:
platform/gtk/media/controls-styling-strict-expected.txt:
platform/gtk/media/controls-without-preload-expected.txt:
platform/gtk/media/video-controls-rendering-expected.txt:
platform/gtk/media/video-display-toggle-expected.txt:
platform/gtk/media/video-playing-and-pause-expected.txt:
platform/gtk/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
platform/gtk/svg/as-image/image-preserveAspectRatio-all-expected.txt: Added.
platform/gtk/svg/batik/text/xmlSpace-expected.png:
platform/gtk/svg/batik/text/xmlSpace-expected.txt:
platform/gtk/svg/carto.net/combobox-expected.png:
platform/gtk/svg/carto.net/combobox-expected.txt:
platform/gtk/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/gtk/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.txt: Added.
platform/gtk/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
platform/gtk/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Added.
platform/gtk/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
platform/gtk/svg/filters/feImage-preserveAspectRatio-all-expected.txt: Added.
platform/gtk/svg/filters/filter-hidden-content-expected.png: Added.
platform/gtk/svg/filters/filter-hidden-content-expected.txt: Added.
platform/gtk/tables/mozilla/bugs/bug113235-3-expected.png:
platform/gtk/tables/mozilla/bugs/bug113235-3-expected.txt:
platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
platform/gtk/tables/mozilla/bugs/bug1318-expected.png:
platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:

3:26 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas

Add bug #110614 to proposed merges for 1.11.91 (diff)

2:49 AM Changeset in webkit [143840] by morrita@google.com

13 edits in trunk/Source/WebCore

ShadowRoot needs guardRef() and guardDeref()
https://bugs.webkit.org/show_bug.cgi?id=109777

Reviewed by Dimitri Glazkov.

This change moves m_guardRefCount from Document to TreeScope,
which allows ShadowRoot to be guarded by guardRef() mechanism as
Document. After r137524, Node referes TreeScope instead of
Document. This is natural consequence of the change: It no longer
makes sense to guardRef() Document pointer from Node.

Detail:

Document::m_guardRefCount and related funcdtions are moved to TreeScope
Document::removedLastRef is factored out into TreeScope::removedLastRefToScope(), TreeScope::dispose() and Docuent::dispose(). ShadowRoot also got its own dispose() implementation.
Moved guardRef() and guardDeref() calls to TreeScope and Node. Note that there are two "guarded" TreeScope references. One is Node::m_treeScope and another is TreeScope::m_parentTreeScope. The guarded-ref management is now encapsulated in these two classes.

No new tests. Covered by existing tests.

WebCore.exp.in:
dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::dispose): Extracted from removedLastRef()

dom/Document.h:

(WebCore::Node::isTreeScope):
(WebCore::Node::Node):

dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::DocumentFragment): Remove ASSERT() and move it to ...
(WebCore::DocumentFragment::create): ... here, to allow NULL document from ShadowRoot.

dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::removedLastRef):

dom/Node.h:

(WebCore::Node::setTreeScope):

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot): Passed NULL document to superclass. This aligns what Document is doing.
(WebCore::ShadowRoot::dispose): Added.

dom/ShadowRoot.h:

(ShadowRoot):

dom/TreeScope.cpp:

(SameSizeAsTreeScope):
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::dispose): Added.
(WebCore::TreeScope::setParentTreeScope):
(WebCore::TreeScope::deletionHasBegun):
(WebCore::TreeScope::beginDeletion):
(WebCore::TreeScope::refCount): Added.

dom/TreeScope.h: Turned m_rootNode to Node* from ContainerNode* for Node::isTreeScope to be inlined.

(WebCore::TreeScope::guardRef): Pulled up from Document.
(WebCore::TreeScope::guardDeref): Ditto.
(WebCore::TreeScope::hasGuardRefCount): Added to hide m_guardRefCount.
(WebCore::TreeScope::deletionHasBegun): Added.
(WebCore::TreeScope::beginDeletion): Added.
(WebCore::TreeScope::removedLastRefToScope): Pulled up from Document.

dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

1:03 AM Changeset in webkit [143839] by rniwa@webkit.org

2 edits in trunk/Tools

Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.

Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.timestamp_of_latest_commit):

12:54 AM Changeset in webkit [143838] by ap@apple.com

2 edits in trunk/Source/WebCore

Don't include ResourceHandle.h in ResourceLoaderOptions.h
https://bugs.webkit.org/show_bug.cgi?id=110662

Reviewed by Tim Horton.

loader/ResourceLoaderOptions.h: Include ResourceHandleTypes.h instead.

12:14 AM Changeset in webkit [143837] by commit-queue@webkit.org

31 edits in trunk

Source/WebCore: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

testing/Internals.cpp:

(WebCore):
(WebCore::Internals::setAutofilled):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit/efl: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/qt: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

WebCoreSupport/DumpRenderTreeSupportQt.cpp:
WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

DumpRenderTree/TestRunner.h:

(TestRunner):

DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

DumpRenderTree/efl/TestRunnerEfl.cpp:
DumpRenderTree/gtk/TestRunnerGtk.cpp:
DumpRenderTree/mac/TestRunnerMac.mm:
DumpRenderTree/qt/TestRunnerQt.cpp:
DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

DumpRenderTree/win/TestRunnerWin.cpp:
DumpRenderTree/wx/TestRunnerWx.cpp:

LayoutTests: Moved setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

fast/forms/input-autofilled.html:
fast/forms/reset-autofilled.html:
platform/wk2/TestExpectations:

Feb 22, 2013:

10:16 PM Changeset in webkit [143836] by commit-queue@webkit.org

43 edits
1 copy
5 moves
3 deletes in trunk/LayoutTests

Rebaseline ports after bug 109994
https://bugs.webkit.org/show_bug.cgi?id=110551

Unreviewed rebaseline of test expectations.

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-22

css2.1/20110323/replaced-elements-001-expected.txt: Renamed from LayoutTests/platform/mac/css2.1/20110323/replaced-elements-001-expected.txt.
fast/forms/button-generated-content-expected.txt:
fast/forms/select-baseline-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/select-baseline-expected.txt.
platform/chromium-mac-lion/css2.1/20110323/replaced-elements-001-expected.png:
platform/chromium-mac-lion/fast/forms/button-generated-content-expected.png:
platform/chromium-mac-lion/fast/forms/select-baseline-expected.png:
platform/chromium-mac-lion/svg/custom/foreign-object-skew-expected.png:
platform/chromium-mac-snowleopard/css2.1/20110323/replaced-elements-001-expected.png:
platform/chromium-mac-snowleopard/fast/forms/button-generated-content-expected.png:
platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png:
platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
platform/chromium-mac/css2.1/20110323/replaced-elements-001-expected.png:
platform/chromium-mac/fast/forms/button-generated-content-expected.png:
platform/chromium-mac/fast/forms/select-baseline-expected.png:
platform/chromium-mac/svg/custom/foreign-object-skew-expected.png:
platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.png:
platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.txt:
platform/chromium-win/fast/forms/button-generated-content-expected.png:
platform/chromium-win/fast/forms/button-generated-content-expected.txt:
platform/chromium-win/fast/forms/select-baseline-expected.png:
platform/chromium-win/fast/forms/select-baseline-expected.txt:
platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.txt:
platform/chromium/TestExpectations:
platform/chromium/css2.1/20110323/replaced-elements-001-expected.txt: Removed.
platform/efl/TestExpectations:
platform/efl/css2.1/20110323/replaced-elements-001-expected.txt:
platform/efl/fast/forms/button-generated-content-expected.txt:
platform/efl/fast/forms/select-baseline-expected.txt:
platform/efl/svg/custom/foreign-object-skew-expected.txt: Renamed from LayoutTests/platform/mac/svg/custom/foreign-object-skew-expected.txt.
platform/efl/tables/mozilla/bugs/bug92647-2-expected.txt:
platform/gtk/TestExpectations:
platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
platform/gtk/fast/forms/button-generated-content-expected.txt:
platform/gtk/fast/forms/select-baseline-expected.txt:
platform/gtk/svg/custom/foreign-object-skew-expected.txt:
platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt:
platform/mac/TestExpectations:
platform/mac/fast/forms/select-baseline-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug92647-2-expected.txt: Removed.
platform/qt/TestExpectations:
platform/qt/css2.1/20110323/replaced-elements-001-expected.txt:
platform/qt/fast/forms/button-generated-content-expected.txt:
platform/qt/fast/forms/select-baseline-expected.txt:
platform/qt/svg/custom/foreign-object-skew-expected.txt:
platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
platform/win-future/fast/forms/button-generated-content-expected.txt: Copied from LayoutTests/fast/forms/button-generated-content-expected.txt.
svg/custom/foreign-object-skew-expected.txt: Renamed from LayoutTests/platform/chromium/svg/custom/foreign-object-skew-expected.txt.
tables/mozilla/bugs/bug92647-2-expected.txt: Renamed from LayoutTests/platform/chromium/tables/mozilla/bugs/bug92647-2-expected.txt.

9:40 PM Changeset in webkit [143835] by Martin Robinson

3 edits in trunk/Source/WebKit/gtk

[GTK] Expose all dependencies to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=110498

Reviewed by Dirk Pranke.

gyp/Configuration.gypi.in: Add the missing configuration cflags here.
gyp/Dependencies.gyp: Add targets for all missing dependencies.

8:47 PM Changeset in webkit [143834] by akling@apple.com

5 edits in trunk/Source/WebCore

Attr: Simplify modification callbacks.
<http://webkit.org/b/110598>

Reviewed by Antti Koivisto.

Instead of Attr being a friend of Element and grabbing at various internal storage and callbacks,
let Attr simply call Element::setAttribute() when its value is changed, and do all that business
from Element.

dom/Element.h:
dom/Element.cpp:

(WebCore::Element::setAttributeInternal):

Call Attr::recreateTextChildAfterAttributeValueChanged() after modifying an attribute value instead
of doing the modification through the Attr node.

dom/Attr.h:
dom/Attr.cpp:

(WebCore::Attr::Attr):
(WebCore::Attr::childrenChanged):

Added an m_inChildrenChanged flag so we can prevent infinite callback recursion in childrenChanged().

(WebCore::Attr::setValue):

Call Element::setAttribute() instead of modifying the attribute storage directly.

(WebCore::Attr::recreateTextChildAfterAttributeValueChanged):

Factored out the "remove all children / create a new text child with attribute value" logic into
a separate function.

8:28 PM Changeset in webkit [143833] by rniwa@webkit.org

12 edits in trunk/Tools

Upload results to perf.webkit.org in addition to the one specified by --test-results-server
https://bugs.webkit.org/show_bug.cgi?id=108577

Reviewed by Dirk Pranke.

Upload results to perf.webkit.org using new JSON format as well as the host specified by
--test-results-server. The new format is needed to provide extra information perf.webkit.org
need such as the subversion commit time and test URLs. This is a temporarily measure until
we complete the transition and the old JSON format and the code to upload results to
webkit-perf.appspot.com can be deleted.

This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
so that the app can sort performance test results based on the timestamp of the last commit.

It also changes the repository names returned by port objects to be properly capitalized
human readable names such as WebKit instead of lowercased names such as webkit since these names
are displayed on perf.webkit.org for humans. Several users of this feature has been updated
to explicitly lowercase the names.

Scripts/webkitpy/common/checkout/scm/git.py:

(Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
git's timestamp granularity is seconds so we're losing some information compared to using a regular
subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
UTC so we're going to manually fiddle with timezone.

Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.timestamp_of_latest_commit): Added.

Scripts/webkitpy/common/checkout/scm/scm_mock.py:

(MockSCM.timestamp_of_latest_commit): Added.

Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.

Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
the timestamp which is always in UTC.

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
'chromium' needs to be substituted by 'chrome' for historical reasons.

Scripts/webkitpy/layout_tests/port/base.py:

(Port.repository_paths): Return WebKit instead of webkit as noted above.

Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.init): Store the current time in UTC as well as in local time.
(PerfTestsRunner._collect_tests):

(PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
and upload them appropriately.

(PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
in revisions_for_perf_webkit and construct an output for perf.webkit.org.

(PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.

(PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
e.g. "processor" would be renamed to "builderProcessor".

(PerfTestsRunner._generate_output_files):

(PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
webkit-perf.appspot.com which spits out a plaintext response.

Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:

(MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
(MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.

Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
cases to parse JSON responses.
(MainTest.test_upload_json.MockFileUploader): Refactored.
(MainTest.test_upload_json.MockFileUploader.reset): Added.
(MainTest.test_upload_json.MockFileUploader.init):
(MainTest.test_upload_json.MockFileUploader.upload_single_text_file):

8:14 PM Changeset in webkit [143832] by gyuyoung.kim@samsung.com

5 edits in trunk/Source

[EFL] Use EINA_LOG instead of fprintf
https://bugs.webkit.org/show_bug.cgi?id=110313

Reviewed by Laszlo Gombos.

Replace fprintf with EINA_LOG.

Source/WebCore:

platform/efl/NetworkInfoProviderEfl.cpp:

(WebCore::NetworkInfoProviderEfl::startUpdating):

platform/graphics/efl/CairoUtilitiesEfl.cpp:

(WebCore::evasObjectFromCairoImageSurface):

Source/WebKit/efl:

ewk/ewk_frame.cpp:

(_ewk_frame_debug):

7:43 PM Changeset in webkit [143831] by Lucas Forschler

6 edits in tags/Safari-537.31.7/Source

Rollout r143761.

7:28 PM Changeset in webkit [143830] by tonyg@chromium.org

2 edits in trunk/Source/WebCore

Threaded HTML parser fails resources/plain-text-unsafe.dat
https://bugs.webkit.org/show_bug.cgi?id=110538

Reviewed by Eric Seidel.

With this patch, the background HTML parser passes all tests in plain-text-unsafe.dat.

No new tests because covered by existing tests.

html/parser/BackgroundHTMLParser.cpp:

(WebCore::tokenExitsSVG):
(WebCore):
(WebCore::tokenExitsMath):
(WebCore::BackgroundHTMLParser::simulateTreeBuilder):

7:18 PM Changeset in webkit [143829] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Add temporary work around for 32-bit plugins not working in production builds as XPCServices
https://bugs.webkit.org/show_bug.cgi?id=110680
<rdar://problem/13236883>

Reviewed by Anders Carlsson.

UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::shouldUseXPC):
Temporarily don't use XPC for plug-ins for Safari while we figure out why the
32-bit XPCService is being built universal.

7:14 PM Changeset in webkit [143828] by tonyg@chromium.org

2 edits in trunk/Source/WebCore

Correct InspectorInstrumentation for background HTML parser
https://bugs.webkit.org/show_bug.cgi?id=110678

Reviewed by Adam Barth.

resumeParsingAfterScriptExecution potentially calls processParsedChunkFromBackgroundParser multiple times
without yielding. So it is not correct to count each of those as a separate ParseHTML event.

This patch moves the instrumentation outside of the loop.

No new tests because no new functionality.

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

6:54 PM Changeset in webkit [143827] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Remove call to detach WebHelperPluginImpl's frame since it is never attached
https://bugs.webkit.org/show_bug.cgi?id=110668

Patch by David Dorwin <ddorwin@chromium.org> on 2013-02-22
Reviewed by Adam Barth.

This fixes http://crbug.com/172764

src/WebHelperPluginImpl.cpp:

(WebKit::WebHelperPluginImpl::destoryPage):

6:48 PM Changeset in webkit [143826] by acolwell@chromium.org

15 edits
5 adds in trunk/Source

Factor MediaSource methods out of MediaPlayer & MediaPlayerPrivate and into a new MediaSourcePrivate interface.
https://bugs.webkit.org/show_bug.cgi?id=109857

Reviewed by Adam Barth.

Source/WebCore:

This is a simple refactor that moves MediaSource related methods out of MediaPlayer & MediaPlayerPrivate
so that the MediaSource implementation can be updated without further polluting these interfaces.
MediaSourcePrivate is the new WebCore interface that ports must implement to support the MediaSource API.

No new tests. No user visible behavior has changed.

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::duration):
(WebCore::MediaSource::setDuration):
(WebCore::MediaSource::addSourceBuffer):
(WebCore::MediaSource::removeSourceBuffer):
(WebCore::MediaSource::setReadyState):
(WebCore::MediaSource::endOfStream):
(WebCore::MediaSource::buffered):
(WebCore::MediaSource::append):
(WebCore::MediaSource::abort):
(WebCore::MediaSource::setTimestampOffset):
(WebCore::MediaSource::setPrivateAndOpen):
(WebCore):
(WebCore::MediaSource::hasPendingActivity):
(WebCore::MediaSource::stop):

Modules/mediasource/MediaSource.h:

(MediaSource):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::reportMemoryUsage):

html/HTMLMediaElement.h:

(HTMLMediaElement):

platform/graphics/MediaPlayer.cpp:

(NullMediaPlayerPrivate):
(WebCore::NullMediaPlayerPrivate::load):
(WebCore::MediaPlayer::load):
(WebCore):
(WebCore::MediaPlayer::loadWithNextMediaEngine):

platform/graphics/MediaPlayer.h:

(WebCore):
(MediaPlayerClient):
(MediaPlayer):

platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):

platform/graphics/MediaSourcePrivate.h: Added.

(WebCore):
(MediaSourcePrivate): Contains the MediaSource methods extracted from MediaPlayer.
(WebCore::MediaSourcePrivate::MediaSourcePrivate):
(WebCore::MediaSourcePrivate::~MediaSourcePrivate):

Source/WebKit/chromium:

WebMediaSource and WebMediaSource client were created to replace the MediaSource methods in WebMediaPlayer and
WebMediaPlayerClient. This allows the MediaSource implementation to be updated without further polluting the
media player interfaces.

WebKit.gyp:
public/WebMediaPlayer.h:

(WebMediaPlayer):
(WebKit::WebMediaPlayer::load):

public/WebMediaPlayerClient.h:

(WebKit):

public/WebMediaSource.h: Added.

(WebKit):
(WebMediaSource):
(WebKit::WebMediaSource::~WebMediaSource):

public/WebMediaSourceClient.h: Added.

(WebKit):
(WebMediaSourceClient):
(WebKit::WebMediaSourceClient::~WebMediaSourceClient):

src/AssertMatchingEnums.cpp:
src/WebMediaPlayerClientImpl.cpp:

(WebKit):
(WebMediaSourceClientImpl): Temporary WebMediaSourceClient implementation to keep things working until Chromium

changes land.

(WebKit::WebMediaSourceClientImpl::WebMediaSourceClientImpl):
(WebKit::WebMediaSourceClientImpl::~WebMediaSourceClientImpl):
(WebKit::WebMediaSourceClientImpl::addId):
(WebKit::WebMediaSourceClientImpl::removeId):
(WebKit::WebMediaSourceClientImpl::buffered):
(WebKit::WebMediaSourceClientImpl::append):
(WebKit::WebMediaSourceClientImpl::abort):
(WebKit::WebMediaSourceClientImpl::duration):
(WebKit::WebMediaSourceClientImpl::setDuration):
(WebKit::WebMediaSourceClientImpl::endOfStream):
(WebKit::WebMediaSourceClientImpl::setTimestampOffset):
(WebKit::WebMediaPlayerClientImpl::sourceOpened):
(WebKit::WebMediaPlayerClientImpl::sourceURL):
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::loadInternal):

src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

src/WebMediaSourceImpl.cpp: Added.

(WebKit):
(MediaSourcePrivateImpl):
(WebKit::MediaSourcePrivateImpl::~MediaSourcePrivateImpl):
(WebKit::MediaSourcePrivateImpl::MediaSourcePrivateImpl):
(WebKit::MediaSourcePrivateImpl::addId):
(WebKit::MediaSourcePrivateImpl::removeId):
(WebKit::MediaSourcePrivateImpl::buffered):
(WebKit::MediaSourcePrivateImpl::append):
(WebKit::MediaSourcePrivateImpl::abort):
(WebKit::MediaSourcePrivateImpl::duration):
(WebKit::MediaSourcePrivateImpl::setDuration):
(WebKit::MediaSourcePrivateImpl::endOfStream):
(WebKit::MediaSourcePrivateImpl::setTimestampOffset):
(WebKit::WebMediaSourceImpl::WebMediaSourceImpl):
(WebKit::WebMediaSourceImpl::~WebMediaSourceImpl):
(WebKit::WebMediaSourceImpl::open):

src/WebMediaSourceImpl.h: Added.

(WebKit):
(WebMediaSourceImpl):

6:13 PM Changeset in webkit [143825] by Beth Dakin

2 edits in trunk/Source/WebCore

RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
https://bugs.webkit.org/show_bug.cgi?id=110673
-and corresponding-
<rdar://problem/13258596>

Reviewed by Sam Weinig.

FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages that
have overflow on the body. We can easily address this by calling it at the
end of RenderLayer::scrollTo().

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

6:09 PM Changeset in webkit [143824] by roger_fong@apple.com

2 edits in trunk/Tools

Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.

BuildSlaveSupport/build.webkit.org-config/config.json:

6:00 PM Changeset in webkit [143823] by rniwa@webkit.org

4 edits in trunk/LayoutTests

More rebaselines after http://trac.webkit.org/changeset/143804.

html5lib/run-test1-expected.txt:
html5lib/run-test18-expected.txt:
html5lib/run-test7-expected.txt:

5:59 PM Changeset in webkit [143822] by acolwell@chromium.org

4 edits in trunk

Disable MediaSource on Apple Windows port
https://bugs.webkit.org/show_bug.cgi?id=110494

Reviewed by Tim Horton.

Source/WebKit:

WebKit.vcxproj/FeatureDefines.props:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:

5:54 PM Changeset in webkit [143821] by rniwa@webkit.org

11 edits
4 adds in trunk

WebKit can erroneously strip font-size CSS property from font element with size attribute
https://bugs.webkit.org/show_bug.cgi?id=110657

Reviewed by Justin Garcia.

Source/WebCore:

The bug was caused by ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline
erroneously removing style attributes even on an element such as font that implicitly adds
editing style.

Fixed the bug by removing these elements or attributes when they conflict with the inline
style of the element. This is always safe because implicit style of an element is always
overridden by that of inline style.

Note that when the font element becomes "empty" (i.e. doesn't have any attributes), then
we also want to delete this font element as it doesn't contribute anything to the style.

Test: editing/pasteboard/insert-u-with-text-decoration-none.html

editing/pasteboard/insert-font-with-size-and-css.html

editing/ApplyStyleCommand.cpp:

(WebCore::isEmptyFontTag): Added ShouldStyleAttributeBeEmpty as an argument. This will
allow removeRedundantStylesAndKeepStyleSpanInline to ignore style attribute when we know
the attribute can be removed.

editing/ApplyStyleCommand.h: Expose isEmptyFontTag and ShouldStyleAttributeBeEmpty.

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::InsertedNodes::didReplaceNode): Added.
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): See above.

editing/ReplaceSelectionCommand.h:

(InsertedNodes): Added a declaration of didReplaceNode.

LayoutTests:

Added two regression tests to ensure WebKit doesn't erroneously remove inline styles of an element
when its implicit styles differ from the inline styles. Also rebaselined some tests as their results
have progressed.

editing/pasteboard/insert-u-with-text-decoration-none-expected.txt: Added.
editing/pasteboard/insert-u-with-text-decoration-none.html: Added.
editing/pasteboard/insert-font-with-size-and-css-expected.txt: Added.
editing/pasteboard/insert-font-with-size-and-css.html: Added.
editing/pasteboard/4744008-expected.txt:
editing/pasteboard/paste-text-with-style-5-expected.txt:
editing/pasteboard/paste-text-with-style-5.html:
editing/pasteboard/style-from-rules-expected.txt:
editing/pasteboard/style-from-rules.html:

5:32 PM Changeset in webkit [143820] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove unused make variable from DerivedSources.make
https://bugs.webkit.org/show_bug.cgi?id=110306

Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-22
Reviewed by Alexey Proskuryakov.

r107026 removed the last piece of logic that was guarded with
ENABLE_DASHBOARD_SUPPORT, so now it can be removed from
DerivedSources.make.

Also combined the way ENABLE_ORIENTATION_EVENTS is set to 0
to make it more readable.

No new tests, no new functionality.

DerivedSources.make:

5:15 PM Changeset in webkit [143819] by Dimitri Glazkov

3 edits
2 adds in trunk

REGRESSION(r130089): Scrollbar thumb no longer re-rendered on hover
https://bugs.webkit.org/show_bug.cgi?id=109230

Source/WebCore:

In r130089, I accidentally removed the extra check that made scrollbar
parts styles sad. I put it back and made them happy.

Reviewed by Eric Seidel.

Test: fast/css/pseudo-element-selector-scrollbar-hover.html

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match): Added the check back.

LayoutTests:

Reviewed by Eric Seidel.

fast/css/pseudo-element-selector-scrollbar-hover-expected.html: Added.
fast/css/pseudo-element-selector-scrollbar-hover.html: Added.

5:10 PM Changeset in webkit [143818] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG::SpeculativeJIT::speculateNumber() should just use SpeculateDoubleOperand instead of doing its own thing
https://bugs.webkit.org/show_bug.cgi?id=110659

Reviewed by Oliver Hunt and Mark Hahnenberg.

This simplifies the code, and also has the effect that if speculateNumber() is called
prior to someone actually using the number in a double context, then the number will
already be up-converted to double and ready to go.

Previously if this ever came up, the subsequent use would have to again branch to see
if the value is tagged as int or tagged as double.

On the other hand, if you ever did speculateNumber() and then used the value as a
JSValue, this will be a slow down now.

I suspect that the former (speculateNumber() and then use as number) is more likely
than the latter (speculateNumber() and then use as JSValue).

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculateNumber):

5:03 PM Changeset in webkit [143817] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG FixupPhase should have one common hook for knowing if a node is ever being speculated a certain way
https://bugs.webkit.org/show_bug.cgi?id=110650

Reviewed by Mark Hahnenberg.

Changes almost all calls to edge.setUseKind(kind) to be
setUseKindAndUnboxIfProfitable<kind>(edge). This will allow us to use the latter
as a hook for deciding which locals to unbox (webkit.org/b/110433).

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(FixupPhase):
(JSC::DFG::FixupPhase::setUseKindAndUnboxIfProfitable):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::fixDoubleEdge):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):

4:57 PM Changeset in webkit [143816] by timothy_horton@apple.com

4 edits in trunk/Source

[WK2] The root and page overlay layers should be the size of the view, not the content
https://bugs.webkit.org/show_bug.cgi?id=110660
<rdar://problem/13096456>

Reviewed by Simon Fraser.

Use the view size for the size of the root and page overlay layers.
For one, we never update these layers' sizes when the content size changes, causing size mismatches.
In addition, there's no reason an overlay shouldn't be able to draw outside of the bounds of the content.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

WebCore.exp.in:

4:43 PM Changeset in webkit [143815] by andersca@apple.com

11 edits in trunk/Source

pluginLoadStrategy should take a WKDictionaryRef for extensibility
https://bugs.webkit.org/show_bug.cgi?id=110656
<rdar://problem/13265303>

Reviewed by Jessie Berlin.

Source/WebCore:

Export a symbol needed by WebKit2.

WebCore.exp.in:

Source/WebKit2:

Change pluginLoadStrategy to take a WKDictionaryRef instead of a number of parameters;
this lets us add more plug-in information if needed. Also add the page URL and rename documentURL to frameURL.

UIProcess/API/C/WKPage.cpp:

(WKPageGetPluginInformationBundleIdentifierKey):
(WKPageGetPluginInformationBundleVersionKey):
(WKPageGetPluginInformationDisplayNameKey):
(WKPageGetPluginInformationFrameURLKey):
(WKPageGetPluginInformationMIMETypeKey):
(WKPageGetPluginInformationPageURLKey):

UIProcess/API/C/WKPage.h:
UIProcess/WebLoaderClient.cpp:

(WebKit):
(WebKit::WebLoaderClient::pluginLoadPolicy):

UIProcess/WebLoaderClient.h:

(WebLoaderClient):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getPluginPath):
(WebKit::WebPageProxy::pluginInformationBundleIdentifierKey):
(WebKit):
(WebKit::WebPageProxy::pluginInformationBundleVersionKey):
(WebKit::WebPageProxy::pluginInformationDisplayNameKey):
(WebKit::WebPageProxy::pluginInformationFrameURLKey):
(WebKit::WebPageProxy::pluginInformationMIMETypeKey):
(WebKit::WebPageProxy::pluginInformationPageURLKey):

UIProcess/WebPageProxy.h:

(WebPageProxy):

UIProcess/WebPageProxy.messages.in:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):

4:35 PM Changeset in webkit [143814] by leviw@chromium.org

3 edits
2 deletes in trunk/LayoutTests

Unreviewed gardening, updating test expecations after r140374.

platform/chromium-mac-snowleopard/platform/chromium/fast/events/touch: Removed.
platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
platform/chromium-win-xp/platform/chromium/fast/events/touch: Removed.
platform/chromium-win/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:

4:21 PM Changeset in webkit [143813] by dpranke@chromium.org

4 edits in trunk

Unreviewed, rolling out r143794.
http://trac.webkit.org/changeset/143794
https://bugs.webkit.org/show_bug.cgi?id=110542

debug linux builds broken?

Tools:

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

LayoutTests:

platform/chromium/TestExpectations:

4:00 PM Changeset in webkit [143812] by leviw@chromium.org

2 edits in trunk/Source/WebCore

Add descriptive names for different addMidpoint use cases
https://bugs.webkit.org/show_bug.cgi?id=110644

Reviewed by Ryosuke Niwa.

Midpoints are used to delineate ranges where we don't add line boxes for contents (collapsed spaces),
and to explicitly split a RenderText into multiple text runs so that text paragraph seperators get
their own line boxes. This patch encapsulates the different cases where midpoints are added to
lineMidpointState into 4 helper functions to make it clearer what's going on in each case.

No new tests. No change in functionality.

rendering/RenderBlockLineLayout.cpp:

(WebCore::deprecatedAddMidpoint): Original function simply adds a midpoint to the lineMidpointState.
Renaming to deprecated to discourage callers.
(WebCore::startIgnoringSpaces): Adds a midpoint to start collapsing subsequent spaces. Asserts that
we have an even number of midpoints.
(WebCore::stopIgnoringSpaces): Adds the corresponding midpoint from startIgnoringSpaces and asserts
that it's an odd number.
(WebCore::ensureLineBoxInsideIgnoredSpaces): When ignoring spaces and we come across a RenderInline
that needs a line box, this function adds a pair of midpoints which ensures we'll later add a line
box for it.
(WebCore::ensureCharacterGetsLineBox): Adds a pair of midpoints in a text renderer to mark that
the current character needs its own line box. This is used by svg for absolutely positioned
characters, or for text paragraph seperators.

3:37 PM Changeset in webkit [143811] by jschuh@chromium.org

2 edits in trunk/Source/WebCore

RenderArena masking has low entropy
https://bugs.webkit.org/show_bug.cgi?id=110394

Reviewed by Oliver Hunt.

No new tests. This is a hardening measure.

rendering/RenderArena.cpp:

(WebCore::RenderArena::RenderArena):

3:28 PM Changeset in webkit [143810] by alecflett@chromium.org

2 edits in trunk/Source/WebKit/chromium

IndexedDB: Remove old SerializedScriptValue-based get() callbacks
https://bugs.webkit.org/show_bug.cgi?id=110626

Reviewed by James Robinson.

Removal now that refactoring is complete.

public/WebIDBCallbacks.h:

(WebKit):

3:21 PM Changeset in webkit [143809] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix the overlay play button position on android
https://bugs.webkit.org/show_bug.cgi?id=110638

Patch by Min Qin <qinmin@chromium.org> on 2013-02-22
Reviewed by Ojan Vafai.

Because we are using flex box, specifying the height is not necessary.
Setting height to 100% will make the enclosure go outside the control panel.
There are no media layout test expecations for android, will do that in another patch.

css/mediaControlsChromiumAndroid.css:

(video::-webkit-media-controls-overlay-enclosure):

3:20 PM Changeset in webkit [143808] by roger_fong@apple.com

2 edits in trunk/WebKitLibraries

Unreviewed. Make WinTools.make stop copying vsprops into nested vsprops folders.

win/tools/WinTools.make:

3:15 PM Changeset in webkit [143807] by schenney@chromium.org

2 edits
24 adds in trunk/LayoutTests

[Chromium] Test expectations for newish tests

Unreviewed test expectations addition.

platform/chromium-linux-x86/fast/text/decorations-with-text-combine-expected.txt: Added.
platform/chromium-linux-x86/fast/text/orientation-sideways-expected.txt: Added.
platform/chromium-linux/fast/text/decorations-with-text-combine-expected.png: Added.
platform/chromium-linux/fast/text/decorations-with-text-combine-expected.txt: Added.
platform/chromium-linux/fast/text/orientation-sideways-expected.png: Added.
platform/chromium-linux/fast/text/orientation-sideways-expected.txt: Added.
platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.png: Added.
platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.txt: Added.
platform/chromium-mac-lion/fast/text/orientation-sideways-expected.png: Added.
platform/chromium-mac-lion/fast/text/orientation-sideways-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/text/decorations-with-text-combine-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/text/orientation-sideways-expected.txt: Added.
platform/chromium-mac/fast/text/decorations-with-text-combine-expected.png: Added.
platform/chromium-mac/fast/text/decorations-with-text-combine-expected.txt: Added.
platform/chromium-mac/fast/text/orientation-sideways-expected.png: Added.
platform/chromium-mac/fast/text/orientation-sideways-expected.txt: Added.
platform/chromium-win-xp/fast/text/decorations-with-text-combine-expected.png: Added.
platform/chromium-win-xp/fast/text/decorations-with-text-combine-expected.txt: Added.
platform/chromium-win-xp/fast/text/orientation-sideways-expected.png: Added.
platform/chromium-win-xp/fast/text/orientation-sideways-expected.txt: Added.
platform/chromium-win/fast/text/decorations-with-text-combine-expected.png: Added.
platform/chromium-win/fast/text/decorations-with-text-combine-expected.txt: Added.
platform/chromium-win/fast/text/orientation-sideways-expected.png: Added.
platform/chromium-win/fast/text/orientation-sideways-expected.txt: Added.
platform/chromium/TestExpectations:

3:04 PM Changeset in webkit [143806] by haraken@chromium.org

3 edits in trunk/Source/WebCore

Unreviewed build fix. Added missing #if PLATFORM(CHROMIUM).

dom/Document.cpp:

(WebCore::Document::recalcStyle):

page/FrameView.cpp:

(WebCore::FrameView::layout):

3:00 PM Changeset in webkit [143805] by haraken@chromium.org

3 edits in trunk/Source/WebCore

Document::styleRecalc() and FrameView::layout() should be traced
https://bugs.webkit.org/show_bug.cgi?id=110646

Reviewed by Ojan Vafai.

Document::styleRecalc() and FrameView::layout() are key factors
for web page rendering performance. We should add TRACE_EVENT()
macros to these functions.

dom/Document.cpp:

(WebCore::Document::recalcStyle):

page/FrameView.cpp:

(WebCore::FrameView::layout):

2:57 PM Changeset in webkit [143804] by eric@webkit.org

33 edits in trunk

Teach the html5lib tests how to test the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=110643

Reviewed by Adam Barth.

Source/WebCore:

This adds a way to force data: url parsing to go through
the threaded parser, to enable us to test the threaded parser
using the html5lib test harness.

html/parser/HTMLParserOptions.cpp:

(WebCore::HTMLParserOptions::HTMLParserOptions):

page/Settings.in:

LayoutTests:

TestExpectations:
html5lib/resources/runner.js:

(window.onload):

html5lib/run-template-expected.txt:
html5lib/run-test10-expected.txt:
html5lib/run-test11-expected.txt:
html5lib/run-test12-expected.txt:
html5lib/run-test14-expected.txt:
html5lib/run-test15-expected.txt:
html5lib/run-test16-expected.txt:
html5lib/run-test17-expected.txt:
html5lib/run-test19-expected.txt:
html5lib/run-test2-expected.txt:
html5lib/run-test20-expected.txt:
html5lib/run-test21-expected.txt:
html5lib/run-test22-expected.txt:
html5lib/run-test23-expected.txt:
html5lib/run-test24-expected.txt:
html5lib/run-test25-expected.txt:
html5lib/run-test26-expected.txt:
html5lib/run-test3-expected.txt:
html5lib/run-test4-expected.txt:
html5lib/run-test5-expected.txt:
html5lib/run-test6-expected.txt:
html5lib/run-test8-expected.txt:
html5lib/run-test9-expected.txt:
html5lib/runner-expected.txt:
platform/chromium/html5lib/run-test1-expected.txt:
platform/chromium/html5lib/run-test18-expected.txt:
platform/chromium/html5lib/run-test7-expected.txt:

2:42 PM Changeset in webkit [143803] by commit-queue@webkit.org

8 edits
2 adds in trunk/Source

[chromium] Register newly-created layers for animation
https://bugs.webkit.org/show_bug.cgi?id=106594

Patch by Ali Juma <ajuma@chromium.org> on 2013-02-22
Reviewed by James Robinson.

Source/Platform:

chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):
(WebKit::WebLayerTreeView::registerForAnimations):

Source/WebKit/chromium:

WebKit.gyp:
src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::ChromeClientImpl):
(WebKit::ChromeClientImpl::graphicsLayerFactory):

src/ChromeClientImpl.h:

(ChromeClientImpl):

src/GraphicsLayerFactoryChromium.cpp: Added.

(WebKit):
(WebKit::GraphicsLayerFactoryChromium::GraphicsLayerFactoryChromium):
(WebKit::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium):
(WebKit::GraphicsLayerFactoryChromium::createGraphicsLayer):

src/GraphicsLayerFactoryChromium.h: Added.

(WebKit):
(GraphicsLayerFactoryChromium):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::graphicsLayerFactory):
(WebKit):
(WebKit::WebViewImpl::registerForAnimations):

src/WebViewImpl.h:

(WebViewImpl):

2:39 PM Changeset in webkit [143802] by abarth@webkit.org

2 edits in trunk/LayoutTests

fast/parser/parser-yield-timing.html doesn't integrate with js-test-pre correctly
https://bugs.webkit.org/show_bug.cgi?id=110645

Reviewed by Eric Seidel.

fast/parser/parser-yield-timing.html:

2:38 PM Changeset in webkit [143801] by ojan@chromium.org

4 edits
2 adds in trunk

Increase the max preferred width of tables to 1000000
https://bugs.webkit.org/show_bug.cgi?id=110545

Reviewed by Emil A Eklund.

Source/WebCore:

Test: fast/table/large-shrink-wrapped-width.html

The old limit of 15000 was picked arbitrarily to avoid overflow.
No need to pick such a small number.

rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::computeInstrinsicLogicalWidths):
As best I can tell, this code is just wrong. Removing this makes the
new test pass and doesn't cause any test failure. While we have many
tests that hit this codepath, this code would only
show a difference in the cases where the available container width is
greater then 15000, and I don't think we have any tests that hit that case
other than this new one.

rendering/TableLayout.h:

LayoutTests:

fast/table/large-shrink-wrapped-width-expected.txt: Added.
fast/table/large-shrink-wrapped-width.html: Added.

2:38 PM Changeset in webkit [143800] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

REGRESSION(r143654): some fast/js test crashes on 32 bit build
https://bugs.webkit.org/show_bug.cgi?id=110590

Reviewed by Mark Hahnenberg.

In compileValueToInt32, the refactoring in r143654 undid one of the fixes from
r143314 due to a merge goof.

In speculateNumber, we were simply forgetting to indicate that we need a
ManualOperandSpeculation on a JSValueOperand. ManualOperandSpeculation should
be passed whenever you will be performing the type checks yourself rather than
using the operand class to do it for you.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::speculateNumber):

2:30 PM Changeset in webkit [143799] by vollick@chromium.org

2 edits in trunk/LayoutTests

[chromium] Update test expectations for XP after 143554
https://bugs.webkit.org/show_bug.cgi?id=110636

Unreviewed gardening.

platform/chromium/TestExpectations:

2:19 PM Changeset in webkit [143798] by dgrogan@chromium.org

1 edit in branches/chromium/1410/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp

Merge 143512

IndexedDB: Limit LevelDB's max open files
https://bugs.webkit.org/show_bug.cgi?id=109993

Reviewed by Tony Chang.

LevelDB keeps up to 1000 (by default) data files open at a time to
avoid having to open() them. This has caused chromium to hit the
process-wide open file limit. This patch changes max_open_files to 20,
as that's the minimum permitted by LevelDB and we have no reason to
think that performance will suffer because of the extra open calls.

No new tests - a chromium browser test that tracks the open LevelDB
files is plausible but is blocked on http://crbug.com/177249/.

platform/leveldb/LevelDBDatabase.cpp:
(WebCore::openDB):

TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/12326083

2:17 PM Changeset in webkit [143797] by abarth@webkit.org

5 edits in trunk/Source/WebCore

Threaded HTML parser should pass fast/parser/iframe-sets-parent-to-javascript-url.html
https://bugs.webkit.org/show_bug.cgi?id=110637

Reviewed by Eric Seidel.

With the main thread parser, we always parse the first chunk of content
returned as the result of evaluating a JavaScript URL synchronously. In
particular, if the first chunk has an inline script, we'll execute it
synchronously.

Previous to this patch, the threaded parser would always parse this
content asynchronously. It's conceivable that there could be some
content relying on the synchronous behavior, so this patch introduces
the notion of "pinning" a parser to the main thread and uses that
concept to force the result of JavaScript URLs to be parsed on the main
thread (which is probably desirable anyway because they're likely to be
quite short).

This patch fixes fast/parser/iframe-sets-parent-to-javascript-url.html
and fast/dom/javascript-url-crash-function.html with the threaded
parser with --enable-threaded-html-parser.

dom/DocumentParser.h:

(WebCore::DocumentParser::pinToMainThread):
(DocumentParser):

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore):
(WebCore::HTMLDocumentParser::pinToMainThread):

html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):
(WebCore::HTMLDocumentParser::shouldUseThreading):

loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):

2:16 PM Changeset in webkit [143796] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

[BlackBerry] Reread cookies when retrying a request with new auth credentials
https://bugs.webkit.org/show_bug.cgi?id=110628

Patch by Joe Mason <jmason@rim.com> on 2013-02-22
Reviewed by George Staikos.

Internal PR: 298805
Internally Reviewed By: Leo Yang

The "isRedirect" parameter of initializePlatformRequest is only used to decide whether to
reread cookies. Since we must reread cookies when resending a request with new auth
credentials as well, rename this to "rereadCookies".

The only caller which sets this parameter rather than using the default value is
NetworkManager::startJob, which also has other processing on redirect. So add a new
"rereadCookies" parameter to startJob and ensure it is always set to true on a redirect, but
can also be set to true on a non-redirect. And when startJob is called due to new auth
credentials, set it to true.

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::startNewJobWithRequest): Add rereadCookies parameter, pass it to
startJob.
(WebCore::NetworkJob::handleRedirect): Set new rereadCookies param of startNewJob to true.
(WebCore::NetworkJob::notifyChallengeResult): Set new rereadCookies param of startNewJob to
true.

platform/network/blackberry/NetworkJob.h:

(NetworkJob): Add rereadCookies parameter to startNewJobWithRequest.

platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob): Add rereadCookies parameter, pass it instead of
redirectCount to initializePlatformRequest.

platform/network/blackberry/NetworkManager.h:

(NetworkManager): Add rereadCookies parameter to startJob.

platform/network/blackberry/ResourceRequest.h:

(ResourceRequest): Rename isRedirect parameter to rereadCookies.

platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest): Rename isRedirect to rereadCookies.

2:15 PM Changeset in webkit [143795] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Use CFNotificationCenter instead of NSNotificationCenter for SharedTimerIOS
https://bugs.webkit.org/show_bug.cgi?id=110544

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-22
Reviewed by Daniel Bates.

Previously, we were instantiating the Obj-C object WebCoreResumeNotifierIOS
with the only purpose of forwarding one notification to a C function.

This patch updates the code to use CFNotificationCenter to dispatch the notification
without the intermediary object.

platform/ios/SharedTimerIOS.mm:

(WebCore::applicationDidBecomeActive):
(WebCore::setSharedTimerFireInterval):

2:12 PM Changeset in webkit [143794] by dpranke@chromium.org

4 edits in trunk

[chromium] enable the fixed version of freetype on linux
https://bugs.webkit.org/show_bug.cgi?id=110542

Reviewed by Tony Chang.

Tools:

Switch to building with a fixed version of FreeType for
just DumpRenderTree. This allows us to share one version
of pixel baselines for both Lucid and Precise, and run
the layout tests in a stock Precise install (instead of a Lucid
chroot). Going forward, this approach isolates us from os-level
changes to the version of FreeType. Note that Chromium itself
still uses the system FreeType and is unaffected by this change.

This setting can still be turned off (at compile/gyp-time) by
manually setting use_custom_freetype=0.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

LayoutTests:

Add entries for two tests that pass on Lucid but fail on Precise
even with the Freetype change. This isn't worth adding in
Lucid and Precise keywords for just these two tests.

platform/chromium/TestExpectations:

2:10 PM Changeset in webkit [143793] by fsamuel@chromium.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] Expose shadowRoot to the WebKit API
https://bugs.webkit.org/show_bug.cgi?id=110522

Reviewed by Dimitri Glazkov.

public/WebElement.h:

(WebElement):

src/WebElement.cpp:

(WebKit::WebElement::shadowRoot):
(WebKit):

2:10 PM Changeset in webkit [143792] by kbr@google.com

6 edits
10 adds in trunk

Uint8ClampedArray constructor is wrong in WorkerContext.idl
https://bugs.webkit.org/show_bug.cgi?id=110634

Reviewed by Adam Barth.

Source/WebCore:

Tests: fast/canvas/webgl/typed-arrays-in-workers.html

webgl/conformance/typedarrays/typed-arrays-in-workers.html

workers/WorkerContext.idl:

LayoutTests:

Added copy of new WebGL conformance test both in old location
(fast/canvas/webgl) and new location (webgl -- not yet being run
on any ports) to avoid losing test coverage after cutover.

fast/canvas/webgl/array-unit-tests.html:
fast/canvas/webgl/resources/typed-array-test-cases.js: Added.
fast/canvas/webgl/resources/typed-array-worker.js: Added.

(constructTypedArray):
(constructDataView):
(onmessage):

fast/canvas/webgl/typed-arrays-in-workers-expected.txt: Added.
fast/canvas/webgl/typed-arrays-in-workers.html: Added.
webgl/conformance/typedarrays/typed-arrays-in-workers-expected.txt: Added.
webgl/conformance/typedarrays/typed-arrays-in-workers.html: Added.
webgl/resources/webgl_test_files/conformance/typedarrays/00_test_list.txt:
webgl/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html:
webgl/resources/webgl_test_files/conformance/typedarrays/resources/typed-array-test-cases.js: Added.
webgl/resources/webgl_test_files/conformance/typedarrays/resources/typed-array-worker.js: Added.

(constructTypedArray):
(constructDataView):
(onmessage):

webgl/resources/webgl_test_files/conformance/typedarrays/typed-arrays-in-workers.html: Added.

2:07 PM Changeset in webkit [143791] by mark.lam@apple.com

2 edits in trunk/Source/WebCore

Add some checks to DatabaseTracker::getMaxSizeForDatabase() to ensure
that it returns a sane value.
https://bugs.webkit.org/show_bug.cgi?id=110557.

Reviewed by Geoffrey Garen.

No layout test, but there is a quota-test.html attached to bugzilla.
The test is a webpage that can be loaded into multiple tabs to
consuming storage space. Once the test webpages are loaded, you will
need to monitor the database directory and its files to confirm that
growth is bounded. Also try reloading the test in the tabs. At no
time should any database file ever exceed the quota.

Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase):

2:06 PM Changeset in webkit [143790] by andersca@apple.com

11 edits in trunk

Source/WebKit2: Move pluginLoadPolicy to the page loader client
https://bugs.webkit.org/show_bug.cgi?id=110635
<rdar://problem/13265303>

Reviewed by Sam Weinig.

Move the pluginLoadPolicy callback to the page loader client where it belongs.

UIProcess/API/C/WKPage.h:
UIProcess/WebLoaderClient.cpp:

(WebKit::toWKPluginLoadPolicy):
(WebKit):
(WebKit::toPluginModuleLoadPolicy):
(WebKit::WebLoaderClient::pluginLoadPolicy):

UIProcess/WebLoaderClient.h:

(WebLoaderClient):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getPluginPath):

UIProcess/WebUIClient.cpp:

(WebKit):

UIProcess/WebUIClient.h:

(WebUIClient):

UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Tools: Move pluginLoadPolicy to the page loader client
https://bugs.webkit.org/show_bug.cgi?id=110635

Reviewed by Sam Weinig.

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):

2:00 PM Changeset in webkit [143789] by simonjam@chromium.org

3 edits
2 adds in trunk

Preloads should be cleared when JavaScript cancels loading prematurely.
https://bugs.webkit.org/show_bug.cgi?id=110388

Reviewed by Antti Koivisto.

Source/WebCore:

If a page preloads a resource, but JavaScript aborts parsing for any reason (for example, a
redirect or document.write()), the resource is forever marked a preload and won't be reloaded
even if it's explicitly marked no-cache and the page is reloaded.

Test: http/tests/cache/preload-cleared-after-parrsing-canceled-by-js.html

dom/Document.cpp:

(WebCore::Document::implicitClose):
(WebCore::Document::finishedParsing):

LayoutTests:

http/tests/cache/preload-cleared-after-parrsing-canceled-by-js-expected.txt: Added.
http/tests/cache/preload-cleared-after-parrsing-canceled-by-js.html: Added.

1:50 PM Changeset in webkit [143788] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Expect editing/spelling/spelling-changed-text.html to fail on Qt and GTK
https://bugs.webkit.org/show_bug.cgi?id=110447

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-22
Reviewed by Ryosuke Niwa.

Qt and GTK layout tests do not mark the word "wellcome" as a misspelling in
editing/spelling/spelling-changed-text.html layout test. This patch disables
editing/spelling/spelling-changed-text.html on Qt and GTK platforms.

platform/gtk/TestExpectations: Mark editing/spelling/spelling-changed-text.html as [ Failure ].
platform/qt/TestExpectations: Mark editing/spelling/spelling-changed-text.html as [ Failure ].

1:45 PM Changeset in webkit [143787] by Antoine Quint

3 edits in trunk/Source/WebCore

Expose a list of all reasons that qualify a RenderLayer to be composited
https://bugs.webkit.org/show_bug.cgi?id=110505

Expose the various reasons that can qualify a RenderLayer to be composited
via a new bitmask returned by the reasonForCompositing() method on
RenderLayerCompositor. This method already existed and was used for logging
purposes, but the previous functionality is now accessed via the
logReasonForCompositing() method.

This will allow the the InspectorLayerTreeAgent to provide this information
to the front-end on a per-layer basis as requested by the front-end.

Reviewed by Simon Fraser.

No new tests.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore):
(WebCore::RenderLayerCompositor::logReasonsForCompositing):

rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

1:41 PM Changeset in webkit [143786] by mifenton@rim.com

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Eliminate invalid clipping for content editable selections
https://bugs.webkit.org/show_bug.cgi?id=110630

Reviewed by Rob Buis.

PR 284629.

Remove selection clipping for content editable
fields as the bounds aren't valid and cause
clipping based on starting node rather than the
union of nodes.

Reviewed Internally by Nima Ghanavatian.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::updateFormState):

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):

1:38 PM Changeset in webkit [143785] by Beth Dakin

2 edits in trunk/Source/WebCore

ScrollingStateTree::rootStateNode() should be null-checked since it can be null
https://bugs.webkit.org/show_bug.cgi?id=110631

Reviewed by Simon Fraser.

This is a speculative fix for <rdar://problem/13233090> and
<rdar://problem/12519348>. It is totally possible for rootStateNode() to be null,
so we should null-check it.

page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinatorMac::syncChildPositions):

1:30 PM Changeset in webkit [143784] by reed@google.com

2 edits in trunk/Source/WebCore

Check for null-device when calling createCompatibleDevice
https://bugs.webkit.org/show_bug.cgi?id=107981

Reviewed by James Robinson.

No new tests. Current tests provided coverage. Site in the wild triggered the failure
(cairo failed to allocate a huge surface).

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):

1:24 PM Changeset in webkit [143783] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry]Adjust fatfinger detection rect size
https://bugs.webkit.org/show_bug.cgi?id=108678.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-22
Reviewed by Antonio Gomes.

Changing HitTestRequest::IgnoreClipping does not solve the problem that
FatFinger rect detect the element out of the viewport. We have to clip
the fatfinger rect according to the current viewport size to avoid picking
the element out of the viewport.

WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::fingerRectForPoint):
(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::getAdjustedPaddings):
(BlackBerry::WebKit::FatFingers::getNodesFromRect):

WebKitSupport/FatFingers.h:

1:20 PM Changeset in webkit [143782] by kbr@google.com

1 edit
3 adds in trunk/LayoutTests

Add script to generate LayoutTests from WebGL Conformance Tests
https://bugs.webkit.org/show_bug.cgi?id=110525

Patch by Gregg Tavares <Gregg Tavares> on 2013-02-22
Reviewed by Kenneth Russell.

Adds the script generate-webgl-tests.py which given a path
to the WebGL Conformance 'sdk/tests' folder generates and
or updates LayoutTests for WebGL. Example

git clone git://github.com/KhronosGroup/WebGL.git
generate-webgl-tests.py -w WebGL/sdk/tests -e

webgl/generate-webgl-tests.py: Added.

(ReadFile):
(WriteFile):
(CopyTree):
(FileReader):
(GreaterThanOrEqualToVersion):
(GetTestList):
(main):

webgl/resources/webgl-expectation-template.txt: Added.
webgl/resources/webgl-wrapper-template.html: Added.

12:49 PM Changeset in webkit [143781] by crogers@google.com

15 edits in trunk/Source

AudioDestination::create() needs extra device identification information for live/local input streams
https://bugs.webkit.org/show_bug.cgi?id=109494

Reviewed by James Robinson.

Source/Platform:

chromium/public/WebMediaStreamSource.h:

(WebMediaStreamSource):

Source/WebCore:

AudioDestination::create() supports live/local audio input. But, since there may be multiple
audio input devices available, an identifier for the requested input device needs to be
passed in. The embedder may then use this information so that the proper audio hardware is
accessed.

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource):

Modules/webaudio/AudioDestinationNode.h:

(AudioDestinationNode):

Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::initialize):
(WebCore::DefaultAudioDestinationNode::createDestination):
(WebCore::DefaultAudioDestinationNode::enableInput):

Modules/webaudio/DefaultAudioDestinationNode.h:

(DefaultAudioDestinationNode):

Modules/webaudio/OfflineAudioDestinationNode.h:
platform/audio/AudioDestination.h:

(AudioDestination):

platform/audio/chromium/AudioDestinationChromium.cpp:

(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):

platform/audio/chromium/AudioDestinationChromium.h:

(AudioDestinationChromium):

platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestination::create):

platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestination::create):

platform/chromium/support/WebMediaStreamSource.cpp:

(WebKit::WebMediaStreamSource::deviceId):
(WebKit):
(WebKit::WebMediaStreamSource::setDeviceId):

platform/mediastream/MediaStreamSource.h:

(WebCore::MediaStreamSource::deviceId):
(WebCore::MediaStreamSource::setDeviceId):
(MediaStreamSource):

12:44 PM Changeset in webkit [143780] by zandobersek@gmail.com

3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removed expectations for tests that now pass. Adjusted an expectation for a flaky crasher.
Marked a few more sputnik tests as slow.

platform/gtk-wk1/TestExpectations:
platform/gtk/TestExpectations:

12:41 PM Changeset in webkit [143779] by rniwa@webkit.org

2 edits
1 copy in trunk/LayoutTests

Mac WebKit2 rebaselines.

Partially revert http://trac.webkit.org/changeset/143709 since the expected result for
cross-origin-local-storage-wk1-expected.txt is different on Mac WebKit on the contrary to
the change log description in the changeset.

Also skip editing/spelling/spelling-changed-text.html on Mac since the test requires
the support for asynchronous spellchecking.

platform/mac-wk2/http/tests/security/cross-origin-local-storage-wk1-expected.txt: Copied

from platform/mac/http/tests/security/cross-origin-local-storage-wk1-expected.txt.

platform/mac/TestExpectations:

12:37 PM Changeset in webkit [143778] by aelias@chromium.org

4 edits in branches/chromium/1410/Source/WebKit/chromium

Merge 143355

[chromium] Fix races in double-tap zoom minimum scale policy
https://bugs.webkit.org/show_bug.cgi?id=110183

Reviewed by Adam Barth.

Double-tap zoom on Android is supposed to return to minimum scale
if no pinch zoom occurred since the last double-tap. Because both
pinch zoom and the result of double-tap zoom gets passed in from CC
via applyScrollAndScale, this logic was brittle and prone to races
depending on when the animation update was received. This patch
keeps track of what the target double-tap scale is to make it more
robust.

I also fixed double-tap zoom test mocking to exercise the entire
page scale animation flow (our previous way of testing was hiding the
raciness), and added a new test case in DivAutoZoomMultipleParamsTest.

src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::startPageScaleAnimation):
(WebKit):
(WebKit::WebViewImpl::enableFakeDoubleTapAnimationForTesting):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::animateZoomAroundPoint):
(WebKit::WebViewImpl::didCommitLoad):
(WebKit::WebViewImpl::applyScrollAndScale):

src/WebViewImpl.h:
(WebViewImpl):
(WebKit::WebViewImpl::fakeDoubleTapAnimationPendingForTesting):
(WebKit::WebViewImpl::fakeDoubleTapTargetPositionForTesting):
(WebKit::WebViewImpl::fakeDoubleTapPageScaleFactorForTesting):
(WebKit::WebViewImpl::fakeDoubleTapUseAnchorForTesting):

tests/WebFrameTest.cpp:

TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/12330082

12:35 PM Changeset in webkit [143777] by aelias@chromium.org

3 edits in branches/chromium/1410/Source/WebKit/chromium

Merge 143032

[chromium] WebInputEventBuilders should not reverse page scale
https://bugs.webkit.org/show_bug.cgi?id=109901

Reviewed by James Robinson.

Though in theory logical that if WebInputEvent -> PlatformEvent
conversions divide by page scale, then the reverse builders should
multiply, in reality the only user of the reverse builders is
plugins which expect the same coordinate space as WebCore.

src/WebInputEventConversion.cpp:
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):

tests/WebInputEventConversionTest.cpp:
(WebCore::TEST):

TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/12330081

12:34 PM Changeset in webkit [143776] by aelias@chromium.org

4 edits in branches/chromium/1410/Source/WebKit/chromium

Merge 142927

[chromium] No triggering autofill on unfocus
https://bugs.webkit.org/show_bug.cgi?id=109735

Patch by David Trainor <dtrainor@chromium.org> on 2013-02-14
Reviewed by James Robinson.

Need to notify the autofill client to not process text changes when we're setting
focus to false and are trying to commit a composition.

public/WebAutofillClient.h:
(WebAutofillClient):
(WebKit::WebAutofillClient::setIgnoreTextChanges):
(WebKit::WebAutofillClient::~WebAutofillClient):

src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setFocus):

tests/WebViewTest.cpp:

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12340032

12:33 PM Changeset in webkit [143775] by aelias@chromium.org

4 edits in branches/chromium/1410/Source/WebKit/chromium

Merge 142913

[chromium] Fix scaling in WebViewImpl::handleGestureEvent, second try
https://bugs.webkit.org/show_bug.cgi?id=109671

Reviewed by James Robinson.

My patch 142571 broke a bunch of things in handleGestureEvent that
assumed the event came in scaled, most notably tap highlight and
double-tap zoom. Switch those to PlatformGestureEvent.

142808 was an earlier version of this patch that was reverted
due to fling events asserting they can't be converted to
PlatformGestureEvent. This version moves fling earlier in the
function to avoid that.

src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::bestTapNode):
(WebKit::WebViewImpl::enableTapHighlight):

src/WebViewImpl.h:
(WebViewImpl):

tests/LinkHighlightTest.cpp:
(WebCore::TEST):

TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/12315056

12:31 PM Changeset in webkit [143774] by aelias@chromium.org

5 edits in branches/chromium/1410/Source/WebKit/chromium

Merge 142571

[chromium] Apply page scale to all WebInputEvent types
https://bugs.webkit.org/show_bug.cgi?id=109370

Reviewed by James Robinson.

Previously we only adjusted a few common input event types by page
scale, but in fact almost every position and size in WebInputEvents
requires it.

I also took the opportunity to change some WebGestureEvent members to
floats (which I checked causes no warnings in Chromium-side code with
GCC or Clang).

New WebInputEventConversionTest: InputEventsScaling

public/WebInputEvent.h:
(WebKit::WebGestureEvent::WebGestureEvent):

src/WebInputEventConversion.cpp:
(WebKit::widgetScaleFactor):
(WebKit):
(WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):

src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::hasTouchEventHandlersAt):
(WebKit::WebViewImpl::handleInputEvent):

tests/WebInputEventConversionTest.cpp:
(WebCore::TEST):
(WebCore):

TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/12319074

12:30 PM Changeset in webkit [143773] by rniwa@webkit.org

2 edits
2 adds in trunk/LayoutTests

Add a Mac baseline for the test added in r142955.

platform/mac/TestExpectations:
platform/mac/svg/filters/filter-hidden-content-expected.png: Added.
platform/mac/svg/filters/filter-hidden-content-expected.txt: Added.

12:28 PM Changeset in webkit [143772] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Marking a bunch of (mostly Sputnik) tests as slow.

12:22 PM Changeset in webkit [143771] by rniwa@webkit.org

15 edits in trunk/Source/WebCore

Binding tests rebaseline after r143737.

bindings/scripts/test/V8/V8Float64Array.cpp:
bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
bindings/scripts/test/V8/V8TestEventConstructor.cpp:
bindings/scripts/test/V8/V8TestEventTarget.cpp:
bindings/scripts/test/V8/V8TestException.cpp:
bindings/scripts/test/V8/V8TestInterface.cpp:
bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
bindings/scripts/test/V8/V8TestNode.cpp:
bindings/scripts/test/V8/V8TestObj.cpp:
bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
bindings/scripts/test/V8/V8TestTypedefs.cpp:

12:18 PM Changeset in webkit [143770] by commit-queue@webkit.org

6 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: Unable to enter "24" to hour field
https://bugs.webkit.org/show_bug.cgi?id=110431

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-02-22
Reviewed by Kent Tamura.

Source/WebCore:

Fixed a bug that hour-field does not accept "24" as a valid input when hour format is 1-24.
To test <input> against different time formats, added "pattern" attribute to DateTimeEditElement.

Test: fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html

html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Overwrites layoutParameters.dateTimeFormat by pattern attribute of DateTimeEditElement (if exists).

html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState): Fixed a bug where AM/PM value was passed to setHour().
(WebCore::DateTimeHourFieldElement::setValueAsInteger): Clamps the given value to 0-24 when the range of the field is 1-12 or 1-24. Renamed the parameter as it may not be an hour23 value (0-23).

LayoutTests:

Added test cases for hour formats 0-11 and 1-24.

fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:

12:08 PM Changeset in webkit [143769] by kbr@google.com

2 edits in trunk/Tools

Unreviewed. Changed gman's primary address for auto-complete in Bugzilla.

Scripts/webkitpy/common/config/committers.py:

12:05 PM Changeset in webkit [143768] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Fix the 32-bit build by using the right data type in more places.

runtime/CodeCache.h:

(CodeCacheMap):

11:59 AM Changeset in webkit [143767] by mifenton@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Accept key events even when composing region is active.
https://bugs.webkit.org/show_bug.cgi?id=110617

Reviewed by Rob Buis.

PR 293598.

Don't reject key events that arrive when composing region is active,
this can prevent navigation events from firing, instead end
the composition and process the key.

Reviewed Internally by Nima Ghanavatian.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::updateFormState):

11:53 AM Changeset in webkit [143766] by zoltan@webkit.org

5 edits
2 adds in trunk

[CSS Regions] Region boxes should respect -shape-inside CSS property
https://bugs.webkit.org/show_bug.cgi?id=107880

Reviewed by David Hyatt.

The shape-inside CSS property modifies the shape of the inner inline flow content from rectangular content box
to an arbitrary geometry. The detailed documentation is located in the CSS-Exclusions specification:
http://dev.w3.org/csswg/css3-exclusions/#shape-inside-property. This change adds support for the shape-inside property
on CSS Regions.

Source/WebCore:

Test: fast/regions/shape-inside-on-regions.html

rendering/ExclusionShapeInfo.cpp:

(WebCore):
(WebCore::::logicalTopOffset): Shape dimension should be relative to the current region.

rendering/ExclusionShapeInfo.h:

(ExclusionShapeInfo):
(WebCore::::logicalTopOffset): Move the implementation to ExclusionShapeInfo.cpp.

rendering/RenderBlockLineLayout.cpp:

(WebCore::logicalHeightForLine): Move the function prior to layoutExclusionShapeInsideInfo, since we need to use it there.
(WebCore):
(WebCore::layoutExclusionShapeInsideInfo): Add support for cases when shape-inside is a region-block property.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Update the exclusion shape information for every line, since the content
could flow through several region containers which can have different shape-inside properties.

LayoutTests:

fast/regions/shape-inside-on-regions-expected.html: Added.
fast/regions/shape-inside-on-regions.html: Added.

11:51 AM Changeset in webkit [143765] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Fix the 32-bit build by using the right data type.

runtime/CodeCache.h:

(JSC::CodeCacheMap::find):

11:48 AM Changeset in webkit [143764] by jer.noble@apple.com

2 edits in trunk/Source/WebKit2

Two video contollers appear after exiting the fullscreen video when using menubar to exit.
https://bugs.webkit.org/show_bug.cgi?id=110506

Reviewed by Eric Carlson.

When we are notified that the fullscreen window is about to exit fullscreen mode unrequested,
call requestExitFullScreen(), as that will result in Document::webkitExitFullScreen() correctly
tearing down the fullscreen state.

UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):

11:44 AM Changeset in webkit [143763] by kbr@google.com

2 edits in trunk/Source/ThirdParty/ANGLE

Mac OS build broken by new ExpressionParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=110629

Unreviewed build fix. Regenerated ExpressionParser with Bison 2.3.

src/compiler/preprocessor/ExpressionParser.cpp:

11:40 AM Changeset in webkit [143762] by ojan@chromium.org

7 edits in trunk/Source/WebCore

Add computeInstrinsicLogicalWidths functions to TableLayout subclasses
https://bugs.webkit.org/show_bug.cgi?id=110520

Reviewed by Tony Chang.

This is just a refactor in preparation for adding RenderTable::computeIntinsicLogicalWidths.
No change in behavior.

Split the computePreferredLogicalWidths functions into a computeIntinsicLogicalWidths
and a applyPreferredLogicalWidthQuirks. Also, move the addition of bordersPaddingAndSpacing
into RenderTable since both TableLayout subclasses need this.

This has the added readability benefit of better isolating the quirks that each table layout
mode requires.

rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::AutoTableLayout::applyPreferredLogicalWidthQuirks):

rendering/AutoTableLayout.h:

(AutoTableLayout):

rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::computeIntrinsicLogicalWidths):
(WebCore::FixedTableLayout::applyPreferredLogicalWidthQuirks):

rendering/FixedTableLayout.h:

(FixedTableLayout):

rendering/RenderTable.cpp:

(WebCore::RenderTable::computePreferredLogicalWidths):

rendering/TableLayout.h:

(TableLayout):

11:25 AM Changeset in webkit [143761] by Lucas Forschler

6 edits in tags/Safari-537.31.7/Source

Merged r143650. <rdar://problem/13250271>

11:16 AM Changeset in webkit [143760] by Lucas Forschler

4 edits
3 copies in tags/Safari-537.31.7

Merged r143269. <rdar://problem/13146994>

11:16 AM Changeset in webkit [143759] by ggaren@apple.com

3 edits in trunk/Source/JavaScriptCore

Code cache size should adapt to workload
https://bugs.webkit.org/show_bug.cgi?id=110560

Reviewed by Antti Koivisto.

(*) 5% PLT arithmetic mean speedup
(*) 10% PLT geometric mean speedup
(*) 3.4X microbenchmark speedup
(*) Reduces initial cache capacity by 16X

runtime/CodeCache.cpp:

(JSC::CodeCache::CodeCache): Updated for interface change.

runtime/CodeCache.h:

(JSC::SourceCodeValue::SourceCodeValue):
(SourceCodeValue): Turned the cache value into a struct so it can track its age.

(CodeCacheMap):
(JSC::CodeCacheMap::CodeCacheMap):
(JSC::CodeCacheMap::find):
(JSC::CodeCacheMap::set):
(JSC::CodeCacheMap::clear):
(JSC::CodeCacheMap::pruneIfNeeded):
(CodeCache): Grow and shrink in response to usage.

11:14 AM Changeset in webkit [143758] by Lucas Forschler

4 edits in tags/Safari-537.31.7/Source/JavaScriptCore

Merged r143097. <rdar://problem/13146994>

11:09 AM Changeset in webkit [143757] by hyatt@apple.com

5 edits in trunk/Source/WebCore

[New Multicolumn] Correctly track whether or not a layer is paginated.
https://bugs.webkit.org/show_bug.cgi?id=110625.

Taking the first step towards implementing the correct spec-compliant painting
model for the new multi-column layout. Add code to make sure the paginated
bits in RenderLayer get propagated correctly for the new layout.

The main difference in bit propagation between the old multicolumn layout and
the new multicolumn layout is that the old layout only tracked pagination "roots",
since it has a broken layer painting model. It incorrectly treats a pagination
"root" inside a multi-column block as establishing a stacking context in each
column. This is incorrect.

The new multicolumn code is going to paint each paginated layer individually,
and this means the bits can't just be about roots. Instead they have to be set
on every layer that may be split across columns, without regard for whether parent
layers are also split or not. This is actually a simpler bit propagation model
than the old code.

Reviewed by Beth Dakin.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
Add code to set the m_isPaginated bit for in-flow RenderFlowThreads. This includes
only RenderMultiColumnFlowThread for now, but eventually it will also include
RenderPageFlowThread.

(WebCore::RenderLayer::useRegionBasedColumns):
Add a helper method to check if region-based columns are turned on, since we're
not attempting to alter the old column pagination model.

(WebCore::RenderLayer::updatePagination):
Added the code to propagate bits under the new model. Whether or not you're paginated
just depends on whether or not your enclosing layer along the containing block chain
is paginated.

(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::hitTestList):
Add code that avoids the old multi-column pagination model when the new column model
is enabled. For now there is no code in the new model that does anything with the bits,
but we're avoiding calling the old code, since it is broken for the new columns.

rendering/RenderLayer.h:

(RenderLayer):
Added the useRegionBasedColumns method to check the Setting.

rendering/RenderMultiColumnFlowThread.h:
rendering/RenderObject.h:

(WebCore::RenderObject::isInFlowRenderFlowThread):
(RenderObject):
Implement isInFlowRenderFlowThread, a virtual function for asking if a renderer is
an in-flow RenderFlowThread, which means that it is going to need paginated layers
because the flow thread has to split across "pages" that do not establish stacking
contexts.

11:01 AM Changeset in webkit [143756] by adamk@chromium.org

29 edits
2 copies in branches/chromium/1410

Merge 143386

Support both MutationObserver and WebKitMutationObserver
https://bugs.webkit.org/show_bug.cgi?id=109776

Reviewed by Ojan Vafai.

Source/WebCore:

We should allow new MutationObserver now that we support parser generated
mutations. This leaves the old prefixed constructor in until we decide
people don't depend on it.

Test: fast/dom/MutationObserver/mutation-observer-prefix.html

page/DOMWindow.idl:
LayoutTests:

fast/dom/MutationObserver/added-out-of-order.html:
fast/dom/MutationObserver/callback-arguments.html:
fast/dom/MutationObserver/clear-transient-without-delivery.html:
fast/dom/MutationObserver/create-during-delivery.html:
fast/dom/MutationObserver/cross-document.html:
fast/dom/MutationObserver/database-callback-delivery.html:
fast/dom/MutationObserver/delivery-order.html:
fast/dom/MutationObserver/disconnect-cancel-pending.html:
fast/dom/MutationObserver/document-fragment-insertion.html:
fast/dom/MutationObserver/end-of-task-delivery.html:
fast/dom/MutationObserver/filesystem-callback-delivery.html:
fast/dom/MutationObserver/inline-event-listener.html:
fast/dom/MutationObserver/mutate-during-delivery.html:
fast/dom/MutationObserver/mutation-callback-non-element-crash.html:
fast/dom/MutationObserver/mutation-observer-constructor.html:
fast/dom/MutationObserver/mutation-observer-prefix-expected.txt: Added.
fast/dom/MutationObserver/mutation-observer-prefix.html: Added.
fast/dom/MutationObserver/mutation-record-nullity.html:
fast/dom/MutationObserver/observe-attributes.html:
fast/dom/MutationObserver/observe-characterdata.html:
fast/dom/MutationObserver/observe-childList.html:
fast/dom/MutationObserver/observe-exceptions.html:
fast/dom/MutationObserver/observe-subtree.html:
fast/dom/MutationObserver/observer-wrapper-dropoff-transient.html:
fast/dom/MutationObserver/observer-wrapper-dropoff.html:
fast/dom/MutationObserver/parser-mutations.html:
fast/dom/MutationObserver/removed-out-of-order.html:
fast/dom/MutationObserver/shadow-dom.html:
fast/dom/MutationObserver/takeRecords.html:
fast/dom/MutationObserver/transient-gc-crash.html:

TBR=esprehn@chromium.org
Review URL: https://codereview.chromium.org/12317072

11:00 AM Changeset in webkit [143755] by Lucas Forschler

4 edits in tags/Safari-537.31.7/Source

Versioning.

10:58 AM Changeset in webkit [143754] by commit-queue@webkit.org

3 edits
2 adds in trunk

text-overflow:ellipsis is not applied when the block contains nested blocks
https://bugs.webkit.org/show_bug.cgi?id=101879

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-02-22
Reviewed by Eric Seidel.

Source/WebCore:

Since text-overflow is not an inherited property, the anonymous blocks
don't know they should ellipse. This causes the anonymous blocks
created in the nested block situation to check their parent to find
out if they should ellipse.

Test: fast/css/text-overflow-ellipsis-anonymous-blocks.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

Use the test from the specification that is supplied as part of the
bug.

fast/css/text-overflow-ellipsis-anonymous-blocks-expected.html: Added.
fast/css/text-overflow-ellipsis-anonymous-blocks.html: Added.

10:50 AM Changeset in webkit [143753] by eric@webkit.org

3 edits in trunk/Source/WebCore

REGRESSION(r143664, r143681): http/tests/security/feed-urls-from-remote.html fails
https://bugs.webkit.org/show_bug.cgi?id=110554

Reviewed by Adam Barth.

Will fix http/tests/security/feed-urls-from-remote.html for Mac WK1.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoading):

10:45 AM Changeset in webkit [143752] by leviw@chromium.org

1 edit
2 copies in branches/chromium/1410

Merge 142659

REGRESSION(r136967): Combination of float and clear yields to bad layout
https://bugs.webkit.org/show_bug.cgi?id=109476

Reviewed by Levi Weintraub.

Source/WebCore:

Test: fast/block/margin-collapse/self-collapsing-block-with-float-children.html

The change made at http://trac.webkit.org/changeset/136967 only needs to worry about the first floated
child of a self-collapsing block. The ones that follow are not affected by its margins.

rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

fast/block/margin-collapse/self-collapsing-block-with-float-children-expected.txt: Added.
fast/block/margin-collapse/self-collapsing-block-with-float-children.html: Added.

TBR=robert@webkit.org
Review URL: https://codereview.chromium.org/12335038

10:40 AM Changeset in webkit [143751] by Lucas Forschler

1 copy in tags/Safari-537.31.7

New Tag.

10:21 AM Changeset in webkit [143750] by mrowe@apple.com

4 edits in trunk/Source/WebCore

Build fix after r143637.

WebCore.exp.in: Unconditionally export ScriptController::javaScriptContext.
bindings/js/ScriptController.h: Unconditionally define javaScriptContext for Mac builds.
bindings/js/ScriptControllerMac.mm:

(WebCore::ScriptController::javaScriptContext): Move the #if inside the function, and return 0 when false.

10:20 AM Changeset in webkit [143749] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[TextAutosizing] Refactoring to eliminate boolean parameter.
https://bugs.webkit.org/show_bug.cgi?id=110490

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-22
Reviewed by Julien Chaffraix.

A follow-up to the recent change that introduced a boolean parameter to
processClusterInternal method of TextAutosizer. Boolean parameters are discouraged by the
WebKit style guide. See http://trac.webkit.org/changeset/142866

Refactoring so no new tests.

rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::clusterMultiplier):

Calculates the font size multiplier for the specified cluster.

(WebCore::TextAutosizer::processClusterInternal):

Accepts the font size multiplier instead of |shouldBeAutosized|.

(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processCompositeCluster):

Both methods above now calculate the multiplier and then pass it to
processClusterInternal.

rendering/TextAutosizer.h:

Updated method declarations.

10:13 AM Changeset in webkit [143748] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Use KURL::protocolIsInHTTPFamily instead of KURL::protocolInHTTPFamily
https://bugs.webkit.org/show_bug.cgi?id=110581

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-22
Reviewed by Rob Buis.

KURL::protocolInHTTPFamily() was removed in r109670.

platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::clearHTTPContentLength):
(WebCore::ResourceRequest::clearHTTPContentType):

10:07 AM Changeset in webkit [143747] by allan.jensen@digia.com

2 edits in trunk/Source/WebCore

Unreviewed build-fix after r143744.

dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

10:05 AM Changeset in webkit [143746] by kareng@chromium.org

4 edits in branches/chromium/1364/Source

Merge 142755

[Qt] window.open passes height and width parameters even if not defined in a page
https://bugs.webkit.org/show_bug.cgi?id=107705

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Do not override width or height of 0, as that indicates default size, and not minimum size.

Tested by tst_qwebpage.

page/DOMWindow.cpp:
(WebCore::DOMWindow::adjustWindowRect):

Source/WebKit/efl:

Do not resize window when default size is requested.

WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::setWindowRect):

Source/WebKit/gtk:

Do not resize window when default size is requested.

WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::setWindowRect):

Source/WebKit/qt:

Test that minimum size is applied only when the requested size is too small,
not when default is requested.

tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage):
(TestPage):
(TestPage::TestPage):
(TestPage::createWindow):
(TestPage::slotGeometryChangeRequested):
(tst_QWebPage::openWindowDefaultSize):

TBR=allan.jensen@digia.com
Review URL: https://codereview.chromium.org/12320068

9:56 AM Changeset in webkit [143745] by aandrey@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] throttle replayTraceLog messages to backend
https://bugs.webkit.org/show_bug.cgi?id=110591

Reviewed by Pavel Feldman.

The replayTraceLog message may be quite expensive. So, while such a request is processed by the
backend, user may well generate a dozen of new ones simply by walking through the DataGrid.
We should actually send to the backend only the last event from the queue.

inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):

9:53 AM Changeset in webkit [143744] by allan.jensen@digia.com

2 edits in trunk/Source/WebCore

Multiple Layout Test crashes (ASSERT) on chromium linux debug after r143727
https://bugs.webkit.org/show_bug.cgi?id=110609

Reviewed by Antonio Gomes.

Revert r128869. InnerNode may now again be from a child document,
and should be handled and not asserted against.

dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

9:47 AM Changeset in webkit [143743] by akling@apple.com

3 edits in trunk/Source/WebCore

Element: Make updateName/updateId/updateLabel private.
<http://webkit.org/b/110603>

Reviewed by Antti Koivisto.

These methods are only called from inside Element so make them private and
move them to the .cpp file.

dom/Element.cpp:

(WebCore::Element::updateName):
(WebCore::Element::updateId):

dom/Element.h:

9:42 AM Changeset in webkit [143742] by zmo@google.com

46 edits
7 adds
2 deletes in trunk/Source

Roll ANGLE to r1833
https://bugs.webkit.org/show_bug.cgi?id=110513

Reviewed by Kenneth Russell.

Source/ThirdParty/ANGLE:

Upstream ANGLE r1833 includes webkit side local fixes
1) r139758 build fix for -Wshorten-64-to-32
2) r139665 build fix for uninitialized variables

After this roll, WebKit side ANGLE is the same as upstream ANGLE r1833, except:
1) include/GLSLANG/ShaderLang.h, where "KHR" is removed from include path.

With this roll, we have EXT_draw_buffers support.

ANGLE.xcodeproj/project.pbxproj:
Target.pri:
include/GLSLANG/ShaderLang.h:
src/common/debug.cpp:
src/common/system.h: Added.
src/common/version.h:
src/compiler/ArrayBoundsClamper.cpp: Removed.
src/compiler/ArrayBoundsClamper.h: Removed.
src/compiler/Compiler.cpp:

(TCompiler::TCompiler):
(TCompiler::Init):
(TCompiler::compile):
(TCompiler::getArrayBoundsClamper):
(TCompiler::getArrayIndexClampingStrategy):
(TCompiler::getBuiltInFunctionEmulator):

src/compiler/DetectDiscontinuity.cpp:

(sh::DetectLoopDiscontinuity::traverse):
(sh::DetectLoopDiscontinuity::visitLoop):
(sh):
(sh::DetectLoopDiscontinuity::visitBranch):

src/compiler/DetectDiscontinuity.h:

(DetectLoopDiscontinuity):

src/compiler/Initialize.cpp:

(InitExtensionBehavior):

src/compiler/Intermediate.cpp:

(TIntermConstantUnion::fold):
(TIntermTraverser::hash):

src/compiler/MapLongVariableNames.cpp:

(LongNameMap::Size):
(MapLongVariableNames::mapGlobalLongName):

src/compiler/MapLongVariableNames.h:

(LongNameMap):

src/compiler/OutputESSL.cpp:

(TOutputESSL::TOutputESSL):

src/compiler/OutputESSL.h:

(TOutputESSL):

src/compiler/OutputGLSL.cpp:

(TOutputGLSL::TOutputGLSL):

src/compiler/OutputGLSL.h:

(TOutputGLSL):

src/compiler/OutputGLSLBase.cpp:

(TOutputGLSLBase::TOutputGLSLBase):
(TOutputGLSLBase::writeConstantUnion):
(TOutputGLSLBase::visitBinary):

src/compiler/OutputGLSLBase.h:

(TOutputGLSLBase):

src/compiler/OutputHLSL.cpp:

(sh::OutputHLSL::output):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::writeConstantUnion):

src/compiler/ParseHelper.cpp:

(TParseContext::constructorErrorCheck):
(PaParseStrings):

src/compiler/ParseHelper.h:
src/compiler/ShHandle.h:

(TCompiler):

src/compiler/ShaderLang.cpp:

(checkActiveUniformAndAttribMaxLengths):
(checkMappedNameMaxLength):
(getVariableInfo):
(ShInitBuiltInResources):
(ShCompile):
(ShGetInfo):
(ShGetActiveAttrib):
(ShGetActiveUniform):
(ShGetNameHashingEntry):

src/compiler/SymbolTable.h:

(TFunction::getParamCount):
(TFunction::getParam):
(TSymbolTable::setDefaultPrecision):

src/compiler/TranslatorESSL.cpp:

(TranslatorESSL::translate):

src/compiler/TranslatorGLSL.cpp:

(TranslatorGLSL::translate):

src/compiler/ValidateLimitations.cpp:

(ValidateLimitations::validateFunctionCall):

src/compiler/VariablePacker.cpp:

(VariablePacker::GetNumRows):

src/compiler/glslang.h:
src/compiler/glslang.l:
src/compiler/glslang.y:
src/compiler/glslang_lex.cpp:

(string_input):
(glslang_scan):

src/compiler/glslang_tab.cpp:
src/compiler/preprocessor/ExpressionParser.cpp:
src/compiler/preprocessor/ExpressionParser.y:
src/compiler/preprocessor/Input.cpp:

(pp::Input::Input):
(pp::Input::read):

src/compiler/preprocessor/Input.h:

(Input):
(pp::Input::count):
(pp::Input::string):
(pp::Input::length):
(Location):

src/compiler/preprocessor/Preprocessor.cpp:

(pp::Preprocessor::init):

src/compiler/preprocessor/Preprocessor.h:

(Preprocessor):

src/compiler/preprocessor/Tokenizer.cpp:

(pp::Tokenizer::init):

src/compiler/preprocessor/Tokenizer.h:

(Tokenizer):

src/compiler/preprocessor/Tokenizer.l:
src/third_party: Added.
src/third_party/compiler: Added.
src/third_party/compiler/ArrayBoundsClamper.cpp: Added.

(ArrayBoundsClamper::ArrayBoundsClamper):
(ArrayBoundsClamper::SetClampingStrategy):
(ArrayBoundsClamper::MarkIndirectArrayBoundsForClamping):
(ArrayBoundsClamper::OutputClampingFunctionDefinition):

src/third_party/compiler/ArrayBoundsClamper.h: Added.

(ArrayBoundsClamper):
(ArrayBoundsClamper::Cleanup):
(ArrayBoundsClamper::GetArrayBoundsClampDefinitionNeeded):
(ArrayBoundsClamper::SetArrayBoundsClampDefinitionNeeded):

src/third_party/compiler/LICENSE: Added.
src/third_party/compiler/README.angle: Added.

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:

9:28 AM Changeset in webkit [143741] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r143734.
http://trac.webkit.org/changeset/143734
https://bugs.webkit.org/show_bug.cgi?id=110615

Causes linux build failures. (Requested by vollick on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-22

public/WebKit.h:

(WebKit):

src/WebKit.cpp:

(WebKit::initialize):
(WebKit::initializeWithoutV8):
(WebKit::webKitPlatformSupport):

9:26 AM Changeset in webkit [143740] by commit-queue@webkit.org

5 edits in trunk/Source

[BlackBerry] Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=110577

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-22
Reviewed by Rob Buis.

Iterators were renamed to key/value in r130612.

Source/WebCore:

platform/blackberry/AuthenticationChallengeManager.cpp:

(WebCore::AuthenticationChallengeManager::pageVisibilityChanged):

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyMultipartHeaderReceived):

Source/WebKit/blackberry:

WebKitSupport/NotificationManager.cpp:

(BlackBerry::WebKit::NotificationManager::show):
(BlackBerry::WebKit::NotificationManager::clearNotifications):
(BlackBerry::WebKit::NotificationManager::removeNotificationFromContextMap):

9:23 AM Changeset in webkit [143739] by rakuco@webkit.org

4 edits
6 deletes in trunk

[WTR] Do not dump information about empty subframes.
https://bugs.webkit.org/show_bug.cgi?id=110585

Reviewed by Simon Fraser.

Tools:

Follow DumpRenderTree more closely by skipping empty frames
(frames which have no document). We are not really interested in
showing anything about them.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::dumpDescendantFramesText): Do not print subframe names when they
have no associated Document.

LayoutTests:

Remove some platform-specific expectations now that the results match
the base expectations.

platform/efl/TestExpectations: Unskip tests that are now passing.
platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed.
platform/qt-5.0-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
platform/qt-5.0-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed.
platform/win-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed.

8:55 AM Changeset in webkit [143738] by commit-queue@webkit.org

6 edits
2 copies
2 adds in trunk/LayoutTests

Unreviewed, rolling out r143678 and r143702.
http://trac.webkit.org/changeset/143678
http://trac.webkit.org/changeset/143702
https://bugs.webkit.org/show_bug.cgi?id=110613

Breaks fast/loader/stateobjects/state-url-sets-links-
visited.html in Chromium (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-22

fast/js/resources/js-test-pre.js:
fast/loader/stateobjects/state-url-sets-links-visited-expected.txt:
fast/loader/stateobjects/state-url-sets-links-visited.html:
platform/chromium-win/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt.
platform/chromium/TestExpectations:
platform/win/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt.
platform/wk2/TestExpectations:

8:54 AM Changeset in webkit [143737] by haraken@chromium.org

3 edits in trunk/Source/WebCore

[V8] Add comments to checkTypeOrDieTrying()
https://bugs.webkit.org/show_bug.cgi?id=110553

Reviewed by Adam Barth.

It is mysterious how the check is helpful. We need comments.

No tests. Just added comments.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

bindings/v8/ScriptWrappable.h:

(ScriptWrappable):

8:51 AM Changeset in webkit [143736] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove ProtocolHandler methods from ChromeClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=110567

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-22
Reviewed by Rob Buis.

They were removed from ChromeClient in r122810 and are now
implemented in NavigatorContentUtilsClientBlackBerry since r131056.

WebCoreSupport/ChromeClientBlackBerry.cpp:
WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

8:46 AM Changeset in webkit [143735] by mnaganov@chromium.org

6 edits in trunk/Source/WebKit/chromium

[Chromium] Add support for emulating legacy Android WebView 'setInitialScale' method
https://bugs.webkit.org/show_bug.cgi?id=109946

Adding a WebView method for permanently setting initial page scale.
This override has higher priority than any calculated page scale
and viewport meta tag value.

Also, this patch eliminates a dubious "fixed layout enabled, viewport disabled" mode
previously used by Android WebView.

Reviewed by Adam Barth.

public/WebView.h:

(WebView):

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setInitialPageScaleOverride):
(WebKit):
(WebKit::WebViewImpl::computePageScaleFactorLimits):

src/WebViewImpl.h:
tests/WebFrameTest.cpp:

8:41 AM Changeset in webkit [143734] by pilgrim@chromium.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
https://bugs.webkit.org/show_bug.cgi?id=110605

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

public/WebKit.h:

(WebKit):

src/WebKit.cpp:

(WebKit::initialize):
(WebKit::initializeWithoutV8):
(WebKit::webKitPlatformSupport):

8:33 AM Changeset in webkit [143733] by jberlin@webkit.org

2 edits in trunk/Source/WebCore

32-bit build fix after r143706

fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::didReceiveData):

8:24 AM Changeset in webkit [143732] by kadam@inf.u-szeged.hu

6 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Added platform specific expected files after 143626.

platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
platform/qt/TestExpectations:

8:17 AM Changeset in webkit [143731] by aandrey@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] do no show a single frame node in data grid
https://bugs.webkit.org/show_bug.cgi?id=110473

Reviewed by Pavel Feldman.

In a single canvas frame capture mode do not show the single "Frame #1" node.
Drive-by: Fix a wrong "this" pointer.

inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileView.prototype.appendDrawCallGroup):
(WebInspector.CanvasProfileView.prototype._flattenSingleFrameNode):

8:12 AM Changeset in webkit [143730] by allan.jensen@digia.com

2 edits in trunk/Source/WebCore

Multiple Layout Test crashes (ASSERT) on chromium linux debug after r143727
https://bugs.webkit.org/show_bug.cgi?id=110609

Reviewed by Antonio Gomes.

Point based hit tests should not append but assign HitTestResults.

rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::nodeAtPoint):

7:54 AM Changeset in webkit [143729] by commit-queue@webkit.org

10 edits in trunk/Source/WebCore

Web Inspector: show source location after drawer views
https://bugs.webkit.org/show_bug.cgi?id=110156

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-22
Reviewed by Pavel Feldman.

Add statusBarText method
Add #drawer-view-anchor, which determines layout position of

drawerView

Fix layout in #panel-status-bar to avoid floating elements.

No new tests.

inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.wasShown): Add statusBarItems before
drawer-view-anchor and statusBarText after.
(WebInspector.Panel.prototype.willHide): Remove statusBarText from DOM in the
way it's done for statusBarItems

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.statusBarText): Added.

inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.statusBarText): Added.
(WebInspector.SourceFrame.prototype.statusBarItems):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get statusBarItems):

inspector/front-end/View.js:

(WebInspector.View.prototype.statusBarText):

inspector/front-end/inspector.css:

(#drawer-view-anchor):
(.source-frame-cursor-position):

inspector/front-end/inspector.html:
inspector/front-end/inspector.js:

(WebInspector.showViewInDrawer):

inspector/front-end/timelinePanel.css:

(.timeline-records-stats):
(.timeline-records-stats-container):

7:31 AM Changeset in webkit [143728] by sudarsana.nagineni@linux.intel.com

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip failing tests on EFL bots.

platform/efl/TestExpectations:

6:46 AM Changeset in webkit [143727] by allan.jensen@digia.com

15 edits
3 adds in trunk

Allow child-frame content in hit-tests.
https://bugs.webkit.org/show_bug.cgi?id=95204

Reviewed by Julien Chaffraix.

Source/WebCore:

Refactors how EventHandler::hitTestResultAtPoint handles child-frame content,
it is now handled by the hit test itself controlled by the AllowChildFrameContent
flag in HitTestRequest.

This means that area-based hit-tests can now return elements from all the child frames
they intersect instead of just the one frame containing the center point. The improved
results from area-based hit-tests will among other things also improve touch adjustment
near frame boundaries.

Tests: fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html

page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

Recursion into child-frames have been moved to RenderFrameBase::nodeAtPoint, so
now hitTestResultAtPoint just needs to set AllowChildFrameContent.

page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::parentShadowHostOrOwner):

New function to iterate up across frame boundaries.

(WebCore::TouchAdjustment::compileSubtargetList):

We need to iterate up across frame boundaries to avoid iframes competing with their
own content for touch adjustment.

rendering/HitTestRequest.h:

(WebCore::HitTestRequest::allowsChildFrameContent):
(WebCore::HitTestRequest::isChildFrameHitTest):

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::append):
(WebCore::HitTestResult::dictationAlternatives):

rendering/HitTestResult.h:

(WebCore::HitTestResult::pointInMainFrame):
(WebCore::HitTestResult::pointInInnerNodeFrame):
(HitTestResult):

m_hitTestLocation is now in main frame coordinates, which make m_pointInMainFrame
unnecessary, but requires the introduction of m_pointInInnerFrame, to remember
the coordinates of inner-node in its own frame.

rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::nodeAtPoint):

The recursion into child-frames is now handled here instead of in hitTestResultAtPoint, this
allows us to recurse into multiple frames, instead of just one.

rendering/RenderFrameBase.h:

(RenderFrameBase):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

RenderLayer should not lie about being hit if the request is child-frame request.

testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Extended so nodesFromRect with child-frame content can be tested.

LayoutTests:

A new tests for nodesFromRect that returns result from child frames.

fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Added.
fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Added.
fast/dom/nodesFromRect/nodesFromRect-continuation-crash.html:
fast/dom/nodesFromRect/resources/child-frame.html: Added.
fast/dom/nodesFromRect/resources/nodesFromRect.js:

(check):
(checkShadowContent):
(nodesFromRectAsString):

6:39 AM Changeset in webkit [143726] by akling@apple.com

5 edits in trunk/Source/WebCore

ShareableElementData should use zero-length array for storage.
<http://webkit.org/b/109959>

Reviewed by Anders Carlsson.

Use a zero-length Attribute array instead of always casting from void* to an array.
It was done this way originally because I didn't know we could sidestep the MSVC
build error with some #pragma hackery and a default constructor for Attribute.

dom/Attribute.cpp:

(WebCore::Attribute::Attribute):

dom/DocumentSharedObjectPool.cpp:

(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):

dom/Element.cpp:

(WebCore::sizeForShareableElementDataWithAttributeCount):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::UniqueElementData::UniqueElementData):

dom/Element.h:

(ShareableElementData):
(WebCore::ElementData::attributeItem):

5:52 AM Changeset in webkit [143725] by caseq@chromium.org

2 edits in trunk/Source/WebKit/chromium

Web Inspector: [Chromium] add a browser test for frames on timeline
https://bugs.webkit.org/show_bug.cgi?id=110592

factor out timeline recording logic from testPageOverlayUpdate for reuse;
record timeline while running a simple DOM-based animation;
assure we have frames and Style Recalc/Layout/Paint events in between.

Reviewed by Yury Semikhatsky.

src/js/Tests.js:

(.TestSuite.prototype.assertHasKey):
(.TestSuite.prototype.testTimelineFrames.step1):
(.TestSuite.prototype.testTimelineFrames.onTimelineRecorded):
(.TestSuite.prototype.testTimelineFrames):
(.TestSuite.prototype.testPageOverlayUpdate.step4):
(.TestSuite.prototype.testPageOverlayUpdate.onTimelineRecorded):
(.TestSuite.prototype.recordTimeline.addRecord):
(.TestSuite.prototype.recordTimeline.innerAddRecord):
(.TestSuite.prototype.recordTimeline.done):
(.TestSuite.prototype.recordTimeline):
(.TestSuite.prototype.stopTimeline):

5:50 AM Changeset in webkit [143724] by akling@apple.com

2 edits in trunk/Source/WebCore

Remove unused declaration: Element::removeCachedHTMLCollection()

Not reviewed by Antti Koivisto.

dom/Element.h:

(Element):

5:44 AM Changeset in webkit [143723] by keishi@webkit.org

2 edits in trunk/Source/WebCore

Add scroll view for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110137

Reviewed by Kent Tamura.

Adding a scroll view class as part of the new calendar picker (Bug 109439).

No new tests. Code not yet used.

Resources/pagepopups/calendarPicker.js:

(View):
(View.prototype.offsetRelativeTo): Returns the offset position of this view relative to the given ancestor element.
(View.prototype.attachTo): Attaches view to a node or view.
(View.prototype.bindCallbackMethods): Binds all methods starting with "on" to this.
(ScrollView): A custom scroll view that can contain extremely long content. CSS values have a limit. This can go beyond that.
(ScrollView.prototype.setWidth): Sets the view width.
(ScrollView.prototype.width):
(ScrollView.prototype.setHeight):Sets the view height.
(ScrollView.prototype.height):
(ScrollView.prototype.onScrollAnimatorStep): Callback for scroll animator step.
(ScrollView.prototype.scrollTo): Scrolls to a certain offset.
(ScrollView.prototype.scrollBy): Scrolls by a certain amount.
(ScrollView.prototype.contentOffset): Current content offset.
(ScrollView.prototype.onMouseWheel): Scroll with the mouse wheel.
(ScrollView.prototype.setContentOffset): Sets the content offset.
(ScrollView.prototype.contentPositionForContentOffset): Returns where the content element should be positioned.

5:43 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

5:42 AM Changeset in webkit [143722] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r143696 - [GTK] Control+Shift+Up/Down selection works backwards
https://bugs.webkit.org/show_bug.cgi?id=110459

Reviewed by Martin Robinson.

platform/gtk/KeyBindingTranslator.cpp:

(WebCore): The translation table for paragraph selection
commands is backwards, fix it.

5:41 AM Changeset in webkit [143721] by apavlov@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: InspectorPageAgent::disable() should not update view metrics regardless of the override state
https://bugs.webkit.org/show_bug.cgi?id=110593

Reviewed by Vsevolod Vlasov.

InspectorPageAgent::disable() now checks if the device metrics are overridden before
telling the client to disable the override.

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::deviceMetricsChanged):

inspector/InspectorPageAgent.h:

(InspectorPageAgent):

5:35 AM Changeset in webkit [143720] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-1.11.90

Tagging the WebKitGTK+ 1.11.90 release

5:34 AM Changeset in webkit [143719] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r143695.
http://trac.webkit.org/changeset/143695
https://bugs.webkit.org/show_bug.cgi?id=110554

Crashes in DocumentLoader::checkLoadComplete on AppleMac WK1, EFL, GTK.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoading):

5:33 AM Changeset in webkit [143718] by zandobersek@gmail.com

3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adding crash expectations for tests that regressed with r143624.
platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining.

5:33 AM Changeset in webkit [143717] by kbalazs@webkit.org

2 edits in trunk/Source/WebKit2

Yet another unreviewed buildfix after r143714.

UIProcess/efl/WebView.cpp:

(WebKit::WebView::paintToCairoSurface):

5:26 AM Changeset in webkit [143716] by zarvai@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip tests until regressions (r143470, r143654) fixed.

platform/qt/TestExpectations:

5:18 AM Changeset in webkit [143715] by rakuco@webkit.org

2 edits in trunk/Source/WebKit2

Unreviewed preventive buildfix after my last commit.

UIProcess/API/efl/EwkView.cpp:
UIProcess/efl/WebView.cpp:

4:58 AM Changeset in webkit [143714] by kbalazs@webkit.org

6 edits in trunk/Source

[CoordGfx] Minor cleanup in CoordinatedGraphicsScene::paintToGraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=109824

Reviewed by Andreas Kling.

Avoid ugly ifdefs by using PlatformGraphicsContext.

Source/WebCore:

No new tests, only refactoring.

platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):

platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

(CoordinatedGraphicsScene):

Source/WebKit2:

UIProcess/API/efl/EwkView.cpp:

(EwkView::displayTimerFired):

4:22 AM Changeset in webkit [143713] by mikhail.pozdnyakov@intel.com

2 edits in trunk/Source/WebKit2

[WK2][EFL] Remove declaration of non-existent functions from EwkView
https://bugs.webkit.org/show_bug.cgi?id=110572

Reviewed by Kenneth Rohde Christiansen.

Removed declarations of non-existent EwkView::paintToCurrentGLContext() and
EwkView::paintToCairoSurface(cairo_surface_t*) that were accidentally
left at r143699.

UIProcess/API/efl/EwkView.h:

(EwkView):

4:11 AM Changeset in webkit [143712] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.0

Unreviewed. Update NEWS and Versions.m4 for 1.11.90 release.

4:07 AM Changeset in webkit [143711] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r143710 - Unreviewed. Fix make distcheck.

GNUmakefile.am: Add CodeGeneratorInspectorStrings.py to

EXTRA_DIST.

4:05 AM Changeset in webkit [143710] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck.

GNUmakefile.am: Add CodeGeneratorInspectorStrings.py to

EXTRA_DIST.

2:50 AM Changeset in webkit [143709] by rakuco@webkit.org

1 edit
6 deletes in trunk/LayoutTests

Unreviewed gardening.

Remove some platform expectations which are identical to the
original ones.

platform/efl/http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt: Removed.
platform/gtk/http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Removed.
platform/mac-wk2/http/tests/security/cross-origin-local-storage-wk1-expected.txt: Removed.
platform/qt-5.0-wk2/http/tests/navigation/forward-and-cancel-expected.txt: Removed.
platform/qt-5.0-wk2/http/tests/navigation/postredirect-frames-expected.txt: Removed.
platform/qt-5.0-wk2/http/tests/navigation/postredirect-goback2-expected.txt: Removed.

2:33 AM Changeset in webkit [143708] by rakuco@webkit.org

2 edits in trunk/Tools

[EFL][DRT] Do not dump empty frames.
https://bugs.webkit.org/show_bug.cgi?id=110474

Reviewed by Kenneth Rohde Christiansen.

Follow the original Mac implementation more closely by skipping
empty frames (frames which have no document). We are not really
interested in showing anything about them.

DumpRenderTree/efl/DumpRenderTree.cpp:

(dumpFramesAsText):

2:15 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:13 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

Bring back previous versions sections (diff)

2:10 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

Subresources leaks was merged already (diff)

2:07 AM Changeset in webkit [143707] by akling@apple.com

2 edits in trunk/Source/WebCore

GlyphPage: ALWAYS_INLINE all performance-relevant getters.

REGRESSION(r143125): ~5% performance hit on Chromium's intl2 page cycler
<http://webkit.org/b/108835>

Reviewed by Antti Koivisto.

Unreviewed desperate hack. Since I can't reproduce the problem and it's only showing
up on two bots, one Linux and one Snow Leopard, I'm thinking it may be GCC related.
Let's see what happens if we tell it to force inline all the GlyphPage getters.

platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::indexForCharacter):
(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::glyphAt):
(WebCore::GlyphPage::fontDataForCharacter):

2:03 AM Changeset in webkit [143706] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Update FileReaderLoader to allow specifying a range and reading as a blob.
https://bugs.webkit.org/show_bug.cgi?id=110556

This is part of a series of patches to implement Stream support. See:
https://bugs.webkit.org/show_bug.cgi?id=110194

Patch by Zach Kuznia <zork@chromium.org> on 2013-02-22
Reviewed by Hajime Morrita.

Tests: will be added when js binding is added.

fileapi/FileReaderLoader.cpp:
fileapi/FileReaderLoader.h:

1:33 AM Changeset in webkit [143705] by mikhail.pozdnyakov@intel.com

5 edits in trunk/Source/WebKit2

[WK2][EFL] Clean up PageViewportControllerClientEfl class
https://bugs.webkit.org/show_bug.cgi?id=110438

Reviewed by Andreas Kling.

Cleaned up PageViewportControllerClientEfl class from unused methods
and class members, eliminated access to WK2 internals from this class.

UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):

UIProcess/efl/PageViewportControllerClientEfl.h:

(WebKit::PageViewportControllerClientEfl::~PageViewportControllerClientEfl):
(PageViewportControllerClientEfl):

UIProcess/efl/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::updateViewportSize):

1:33 AM Changeset in webkit [143704] by commit-queue@webkit.org

17 edits
3 adds in trunk

[WebGL][EFL] Support for creating surface with alpha disabled.
https://bugs.webkit.org/show_bug.cgi?id=110067

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-22
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Covered by compositing/webgl/webgl-no-alpha.html

We currently always create a surface supporting alpha channel.
With this patch we create the surface with alpha only if
required.

platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::initialize):

platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::createOffScreenSurface):
(WebCore::GLPlatformSurface::createTransportSurface):
(WebCore::GLPlatformSurface::GLPlatformSurface):
(WebCore::GLPlatformSurface::attributes):
(WebCore):

platform/graphics/opengl/GLPlatformSurface.h:
platform/graphics/surfaces/egl/EGLConfigSelector.cpp:

(WebCore):
(WebCore::EGLConfigSelector::EGLConfigSelector):
(WebCore::EGLConfigSelector::pBufferContextConfig):
(WebCore::EGLConfigSelector::surfaceContextConfig):

platform/graphics/surfaces/egl/EGLConfigSelector.h:

(EGLConfigSelector):

platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):

platform/graphics/surfaces/egl/EGLSurface.h:

(EGLWindowTransportSurface):

platform/graphics/surfaces/glx/GLXConfigSelector.h:

(WebCore):
(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::pixmapContextConfig):
(WebCore::GLXConfigSelector::surfaceContextConfig):
(WebCore::GLXConfigSelector::surfaceClientConfig):
(WebCore::GLXConfigSelector::validateAttributes):
(WebCore::GLXConfigSelector::findMatchingConfig):
(WebCore::GLXConfigSelector::findMatchingConfigWithVisualId):
(GLXConfigSelector):

platform/graphics/surfaces/glx/GLXContext.cpp:

(WebCore::GLXOffScreenContext::initialize):

platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXOffScreenSurface::GLXOffScreenSurface):
(WebCore::GLXOffScreenSurface::initialize):

platform/graphics/surfaces/glx/GLXSurface.h:

(GLXTransportSurface):
(GLXOffScreenSurface):

platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap):

LayoutTests:

Enabled compositing/webgl/webgl-no-alpha.html for Efl port.

platform/efl/TestExpectations:
platform/efl/compositing/webgl/webgl-no-alpha-expected.png: Added.
platform/efl/compositing/webgl/webgl-no-alpha-expected.txt: Added.

1:20 AM Changeset in webkit [143703] by vsevik@chromium.org

2 edits in trunk/LayoutTests

Layout Test fast/multicol/newmulticol/positioned-split.html is failing on chromium mac 10.8 since it was added
https://bugs.webkit.org/show_bug.cgi?id=110568

Unreviewed test expectation update.

platform/chromium/TestExpectations:

1:07 AM Changeset in webkit [143702] by vsevik@chromium.org

2 edits in trunk/LayoutTests

Layout Test fast/loader/stateobjects/state-url-sets-links-visited.html is timing out in chromium
https://bugs.webkit.org/show_bug.cgi?id=110566

Unreviewed test expectation update.

platform/chromium/TestExpectations:

12:59 AM Changeset in webkit [143701] by pfeldman@chromium.org

6 edits in trunk/Source/WebCore

Web Inspector: allow opting out from vertical split in the dock-to-right mode
https://bugs.webkit.org/show_bug.cgi?id=110564

Reviewed by Vsevolod Vlasov.

English.lproj/localizedStrings.js:
inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._splitVertically):

inspector/front-end/ScriptsPanel.js:
inspector/front-end/Settings.js:

(WebInspector.Settings):

inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab):

12:56 AM WebKitGTK/1.10.x edited by Claudio Saavedra

(diff)

12:55 AM Changeset in webkit [143700] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[WK2][EFL][GTK][Qt] Add context menu item tags for C API
https://bugs.webkit.org/show_bug.cgi?id=109815

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-02-22
Reviewed by Anders Carlsson.

This patch adds context menu item tags used by EFL, GTK and Qt ports, defined in
WebCore to WK2 C API.

Shared/API/c/WKContextMenuItemTypes.h:
Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

12:52 AM Changeset in webkit [143699] by mikhail.pozdnyakov@intel.com

7 edits in trunk/Source/WebKit2

[WK2][EFL] Move AC code from EwkView to WebView
https://bugs.webkit.org/show_bug.cgi?id=110216

Reviewed by Anders Carlsson.

Accelerated compositing code is moved from EwkView to WebView.
Added new WKView API to be used from EwkView instead of direct accessing
to coordinated graphics scene.

UIProcess/API/C/efl/WKView.cpp:

(WKViewSetUserViewportTranslation):
(WKViewUserViewportToContents):
(WKViewPaintToCurrentGLContext):
(WKViewPaintToCairoSurface):

UIProcess/API/C/efl/WKView.h:

Added WKView API functions.

UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::displayTimerFired):
(EwkView::feedTouchEvent):
(EwkView::createGLSurface):
(EwkView::handleEvasObjectCalculate):
(EwkView::handleEwkViewMouseWheel):
(EwkView::handleEwkViewMouseDown):
(EwkView::handleEwkViewMouseUp):
(EwkView::handleEwkViewMouseMove):

UIProcess/API/efl/EwkView.h:

(EwkView):

Using new WKView API.

UIProcess/efl/WebView.cpp:

(WebKit::WebView::initialize):
(WebKit):
(WebKit::WebView::paintToCurrentGLContext):
(WebKit::WebView::paintToCairoSurface):
(WebKit::WebView::userViewportToContents):
(WebKit::WebView::transformFromScene):
(WebKit::WebView::transformToScene):
(WebKit::WebView::coordinatedGraphicsScene):
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):

UIProcess/efl/WebView.h:

(WebCore):
(WebKit::WebView::setUserViewportTranslation):
(WebView):

Added WebView methods to support new WKView API.

12:46 AM Changeset in webkit [143698] by vsevik@chromium.org

9 edits
2 copies
5 adds in trunk/LayoutTests

Unreviewed tests rebaseline.

platform/chromium-linux-x86/fast/images/favicon-as-image-expected.png: Added.
platform/chromium-linux/fast/images/favicon-as-image-expected.png:
platform/chromium-linux/http/tests/misc/favicon-as-image-expected.png: Added.
platform/chromium-linux/http/tests/misc/favicon-as-image-expected.txt: Added.
platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png: Added.
platform/chromium-mac-lion/fast/images/favicon-as-image-expected.png:
platform/chromium-mac-lion/fast/images/favicon-as-image-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/images/favicon-as-image-expected.txt.
platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png:
platform/chromium-mac-snowleopard/fast/images/favicon-as-image-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png: Added.
platform/chromium-mac/fast/images/favicon-as-image-expected.png:
platform/chromium-mac/fast/images/favicon-as-image-expected.txt:
platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png:
platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/images/favicon-as-image-expected.txt.
platform/chromium/TestExpectations:

12:45 AM Changeset in webkit [143697] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] DomSupport: use NodeTraversal APIs
https://bugs.webkit.org/show_bug.cgi?id=110467

Patch by Xan Lopez <xlopez@rim.com> on 2013-02-22
Reviewed by Antonio Gomes.

WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::visibleTextQuads):

12:40 AM Changeset in webkit [143696] by Claudio Saavedra

2 edits in trunk/Source/WebCore

[GTK] Control+Shift+Up/Down selection works backwards
https://bugs.webkit.org/show_bug.cgi?id=110459

Reviewed by Martin Robinson.

platform/gtk/KeyBindingTranslator.cpp:

(WebCore): The translation table for paragraph selection
commands is backwards, fix it.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed