⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 27, 2013:

11:57 PM Changeset in webkit [144267] by rniwa@webkit.org
  • 2 edits in trunk/Tools

PerfTestRunner doesn't need _needs_http and _has_http_lock
​https://bugs.webkit.org/show_bug.cgi?id=111037

Reviewed by Adam Barth.

Delete these variables in favor of using a local variable.

Member variables are like global variables. They introduce implicit dependencies
between member functions.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.init):
(PerfTestsRunner._start_http_servers):
(PerfTestsRunner):
(PerfTestsRunner._stop_http_servers):
(PerfTestsRunner.run):

11:55 PM Changeset in webkit [144266] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk

Unreviewed, rolling out r144224.
​http://trac.webkit.org/changeset/144224
​https://bugs.webkit.org/show_bug.cgi?id=111045

Caused plugins/pass-different-npp-struct.html to time out
(Requested by abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-27

Tools:

  • DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:

(PassDifferentNPPStruct::NPP_SetWindow):

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_SetWindow):

LayoutTests:

  • platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Added.
  • plugins/netscape-plugin-setwindow-size-2.html:
  • plugins/netscape-plugin-setwindow-size.html:
  • plugins/pass-different-npp-struct.html:
11:50 PM Changeset in webkit [144265] by eustas@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: [Protocol] Genarate JS enum definitions.
​https://bugs.webkit.org/show_bug.cgi?id=110461

Reviewed by Pavel Feldman.

Generating corresponding type annotations
would help to compiler to point errors.

  • inspector/CodeGeneratorInspector.py: Generate "registerEnum" records.
  • inspector/InjectedScriptSource.js: Shadow compiler warning.
  • inspector/front-end/InspectorBackend.js:

Added "registerEnum". Added "registerEnum" generation.

  • inspector/front-end/NetworkManager.js: Use enum instead of literal.
  • inspector/generate_protocol_externs.py: Generate enum typedefs.
11:44 PM Changeset in webkit [144264] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Update some test expectations based on the threaded parser behavior.
These look like test integration issues rather than actual bugs in the
parser. We will investigate them offline.

  • platform/chromium/TestExpectations:
10:44 PM Changeset in webkit [144263] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of hour field should respect min/max attributes
​https://bugs.webkit.org/show_bug.cgi?id=109555

Patch by Kunihiko Sakamoto <​ksakamoto@chromium.org> on 2013-02-27
Reviewed by Kent Tamura.

Source/WebCore:

Make step-up/-down of the hour field respect the min/max attributes of the element.
Note that it still accepts any keyboard inputs (the element
becomes 'invalid' state when out-of-range values entered).
Also, disable the hour field and/or the AMPM field when there is only single possible value.

Test: fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html

fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer.html
fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html
fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::setupLayoutParameters): Populates layoutParameters.{minimum,maximum}.

  • html/shadow/DateTimeEditElement.cpp:

(DateTimeEditBuilder): Add data fields for min/max of day and hour fields.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Set newly added data members.
(WebCore::DateTimeEditBuilder::visitField): Pass minimum/maximum value to the month field constructors.
(WebCore::DateTimeEditBuilder::shouldAMPMFieldDisabled): Added.
(WebCore::DateTimeEditBuilder::shouldDayOfMonthFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled):
Disables the hour field when min, max, and value have the same hour, except when the minute
field is disabled (by step attribute), because we need to leave at least one field editable.

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeHourFieldElementBase::DateTimeHourFieldElementBase):
(WebCore::DateTimeHourFieldElementBase::initialize):
(WebCore::DateTimeHourFieldElementBase::setValueAsDate):
(WebCore::DateTimeHourFieldElementBase::setValueAsDateTimeFieldsState):
(WebCore::DateTimeHour11FieldElement::DateTimeHour11FieldElement):
(WebCore::DateTimeHour11FieldElement::create):
(WebCore::DateTimeHour11FieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeHour11FieldElement::setValueAsInteger):
(WebCore::DateTimeHour11FieldElement::clampValueForHardLimits):
(WebCore::DateTimeHour12FieldElement::DateTimeHour12FieldElement):
(WebCore::DateTimeHour12FieldElement::create):
(WebCore::DateTimeHour12FieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeHour12FieldElement::setValueAsInteger):
(WebCore::DateTimeHour12FieldElement::clampValueForHardLimits):
(WebCore::DateTimeHour23FieldElement::DateTimeHour23FieldElement):
(WebCore::DateTimeHour23FieldElement::create):
(WebCore::DateTimeHour23FieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeHour23FieldElement::setValueAsInteger):
(WebCore::DateTimeHour23FieldElement::clampValueForHardLimits):
(WebCore::DateTimeHour24FieldElement::DateTimeHour24FieldElement):
(WebCore::DateTimeHour24FieldElement::create):
(WebCore::DateTimeHour24FieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeHour24FieldElement::setValueAsInteger):
(WebCore::DateTimeHour24FieldElement::clampValueForHardLimits):

  • html/shadow/DateTimeFieldElements.h: Splitted DateTimeHourFieldElement into a base class and four derived classes that represents different hour formats.

(DateTimeHourFieldElementBase): Added.
(DateTimeHour11FieldElement): Added. Represents 0-11 hour format.
(DateTimeHour12FieldElement): Added. Represents 1-12 hour format.
(DateTimeHour23FieldElement): Added. Represents 0-23 hour format.
(DateTimeHour24FieldElement): Added. Represents 1-24 hour format.

LayoutTests:

Added test cases with min/max attributes.

  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield-expected.txt:
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html:
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Added.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
  • fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
10:41 PM Changeset in webkit [144262] by abarth@webkit.org
  • 11 edits
    15 adds
    2 deletes in trunk

[Chromium] Enable threaded HTML parser by default in DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=110907

Reviewed by Eric Seidel.

Tools:

This patch changes --enable-threaded-html-parser into
--disable-threaded-html-parser and thereby enables the threaded HTML
parser by default for the Chromium port.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:
  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

Update test results to show subtle differences in FrameLoaderClient callbacks.

  • platform/chromium-mac/security/block-test-no-port-expected.txt: Removed.
  • platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt:
  • platform/chromium-win/security/block-test-no-port-expected.txt: Removed.
  • platform/chromium/fast/images/support-broken-image-delegate-expected.txt:
  • platform/chromium/fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
  • platform/chromium/http/tests/loading/307-after-303-after-post-expected.txt: Added.
  • platform/chromium/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
  • platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
  • platform/chromium/http/tests/misc/window-dot-stop-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
  • platform/chromium/inspector/debugger/pause-in-inline-script-expected.txt: Added.
  • platform/chromium/inspector/timeline/timeline-script-tag-1-expected.txt: Added.
  • platform/chromium/security/block-test-no-port-expected.txt:
10:31 PM FeatureFlags edited by tkent@chromium.org
Sort CSS3_* flags, update comments for form flags (diff)
10:25 PM FeatureFlags edited by tkent@chromium.org
Add STREAM and CSS3_TEXT_LINE_BREAK (diff)
10:14 PM EnableFormFeatures edited by tkent@chromium.org
(diff)
9:53 PM Changeset in webkit [144261] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Should not return WebTextInputTypeNone for date input element.
​https://bugs.webkit.org/show_bug.cgi?id=110740

Patch by Seigo Nonaka <​nona@chromium.org> on 2013-02-27
Reviewed by Kent Tamura.

In the case of Windows 8, text input state including on-screen keyboard is controlled by the
value of WebTextInputType returned from WebViewImpl::textInputType().
In past, it returned WebTextInputTypeDate for date text input but now it returns
WebTextInputTypeNone.
WebTextInputTypeNone is used for non editable node, so on-screen keyboard will be hidden if
the date text input is focused. So there is no way to input on Windows 8 tablet without
physical keyboard except tapping small up/down arrow.

  • public/WebTextInputType.h: Introduces WebTextInputTypeDateTimeField.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of editable or not. It is
safe because textInputType returns editable type only for known editable element.
(WebKit::WebViewImpl::textInputType): Returns WebTextInputTypeDateTimeField for the date
time field element.

9:04 PM Changeset in webkit [144260] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Need to re-layout fixed position elements after scale when using settings()->fixedElementsLayoutRelativeToFrame()
​https://bugs.webkit.org/show_bug.cgi?id=105486

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-02-27
Reviewed by James Robinson.

In settings()->fixedElementsLayoutRelativeToFrame() mode, fixed-position
elements are layout relative to the current visible viewport, which can
be different from the layout viewport when using fixed-layout mode.
We need to re-layout fixed-position elements in case of visible content
size changes.

The test is currently chromium-specific due to difficulties to make this
test works on Mac. The mac port seems to work very differently with
visible content size when a page is scaled. And there is no reliable way
to hide scrollbars in mac-wk1 that doesn't cause a side effect.

Source/WebCore:

Test: platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html

  • page/FrameView.h:

(FrameView):

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

LayoutTests:

  • platform/chromium/fast/repaint/relayout-fixed-position-after-scale-expected.html: Added.
  • platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html: Added.
7:51 PM Changeset in webkit [144259] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Initialize page visibility after creating WebKitTestRunner WebView on Mac
​https://bugs.webkit.org/show_bug.cgi?id=111025

Patch by Kiran Muppala <​cmuppala@apple.com> on 2013-02-27
Reviewed by Simon Fraser.

Set page visibility to "visible" after creating WebView to override
visibility state inferred from window occlusion notifications on Mac.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions): Add call to
setVisibilityState.

7:31 PM Changeset in webkit [144258] by hmuller@adobe.com
  • 7 edits
    8 adds in trunk

[CSS Exclusions] Enable shape-inside rectangle support for shape-padding
​https://bugs.webkit.org/show_bug.cgi?id=110500

Reviewed by Dirk Schulze.

Source/WebCore:

Added support for CSS shape-padding for shapes defined with shape-inside.

Tests: fast/exclusions/shape-inside/shape-inside-circle-padding.html

fast/exclusions/shape-inside/shape-inside-ellipse-padding.html
fast/exclusions/shape-inside/shape-inside-rectangle-padding.html
fast/exclusions/shape-inside/shape-inside-rounded-rectangle-padding.html

  • rendering/ExclusionRectangle.cpp:

(WebCore::FloatRoundedRect::paddingBounds): Inset the rounded rectangle to reflect the padding parameter.
(WebCore::FloatRoundedRect::marginBounds): Expand the rounded rectangle to reflect the margin parameter.
(WebCore::FloatRoundedRect::cornerInterceptForWidth): Moved this method from ExclusionRectangle to FloatRoundedRect.
(WebCore::ExclusionRectangle::shapePaddingBounds): Lazily compute the bounds of the padding box.
(WebCore::ExclusionRectangle::shapeMarginBounds): Lazily compute the bounds of the margin box.
(WebCore::ExclusionRectangle::getExcludedIntervals): This computuation is now based on the (new) margin box.
(WebCore::ExclusionRectangle::getIncludedIntervals): This computation is now base don the (new) padding box.
(WebCore::ExclusionRectangle::firstIncludedIntervalLogicalTop): This computation is now base don the (new) padding box.

  • rendering/ExclusionRectangle.h:

(FloatRoundedRect): A subclass of FloatRect that includes corner radii specified as CSS shapes do.
(WebCore::FloatRoundedRect::FloatRoundedRect):
(WebCore::FloatRoundedRect::rx):
(WebCore::FloatRoundedRect::ry):
(WebCore::ExclusionRectangle::ExclusionRectangle):

  • rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape): Initialize the new shapeMargin and shapePadding properties.

  • rendering/ExclusionShape.h:

(ExclusionShape):
(WebCore::ExclusionShape::shapeMargin): Added a public read-only property for shapeMargin.
(WebCore::ExclusionShape::shapePadding): Added a public read-only property for shapePadding.

  • rendering/ExclusionShapeInfo.cpp:

(WebCore::::computedShape): Pass the values of the CSS shape-margin and shapp-padding properties to createExclusionShape().

LayoutTests:

Added one shape-inside, shape-padding test for each CSS shape type.

  • fast/exclusions/shape-inside/shape-inside-circle-padding-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-circle-padding.html: Added.
  • fast/exclusions/shape-inside/shape-inside-ellipse-padding-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-ellipse-padding.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rectangle-padding-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rectangle-padding.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-padding-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-padding.html: Added.
7:09 PM Changeset in webkit [144257] by hclam@chromium.org
  • 2 edits in trunk/Source/WebCore

More style cleanup in GIFImageReader
​https://bugs.webkit.org/show_bug.cgi?id=110776

Reviewed by Allan Sandfeld Jensen.

Renamed variable q to currentComponent which more accurately represent
the purpose.

No test. Simple refactoring.

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::decodeInternal):

6:58 PM Changeset in webkit [144256] by schenney@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Rebaseline after r144236
​https://bugs.webkit.org/show_bug.cgi?id=109879

Unreviewed expectations update

  • platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt: Added.
6:29 PM Changeset in webkit [144255] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Merge PageLoadingPerfTest into ReplayPerfTest
​https://bugs.webkit.org/show_bug.cgi?id=111027

Reviewed by Dirk Pranke.

Merged two classes.

We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
part of ReplayPerfTest.

  • Scripts/webkitpy/performance_tests/perftest.py:

(ReplayPerfTest): Moved _FORCE_GC_FILE here.
(ReplayPerfTest.init):
(ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
(ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestReplayPerfTest):
(TestReplayPerfTest.test_run_single.run_test):
(TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
(TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
TestPageLoadingPerfTest.test_run.
(TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
TestPageLoadingPerfTest.test_run_with_memory_output
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
(TestReplayPerfTest.test_prepare_calls_run_single):

6:24 PM Changeset in webkit [144254] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Add month popup for new calendar picker
​https://bugs.webkit.org/show_bug.cgi?id=110830

Reviewed by Kent Tamura.

Adding month popup view for use in the new calendar picker (Bug 109439).
YearListCell will grow in height when selected to reveal the buttons for
selecting the month.

No new tests. Code is not used yet.

  • Resources/pagepopups/calendarPicker.js:

(YearListCell): A row inside the month popup. Contains buttons for choosing a month.
(YearListCell.prototype._recycleBin):
(YearListCell.prototype.reset): Resets a thrown away cell for reuse at the given row.
(YearListCell.prototype.height):
(YearListCell.prototype.setHeight):
(YearListView): List view showing YearListCells.
(YearListView.prototype.onMouseOver): If the mouse is over a month button, highlights it.
(YearListView.prototype.onMouseOut): De-highlights the month button.
(YearListView.prototype.setWidth): Set scroll view width to leave space for the scroll bar.
(YearListView.prototype.setHeight): Sets the scroll bar height as well.
(YearListView.prototype._animateRow): Animates the row height to open/close the YearListCell.
(YearListView.prototype.onCellHeightAnimatorDidStop): Keep this._runningAnimators and this._animatingRows up to date.
(YearListView.prototype.onCellHeightAnimatorStep): Update the cell height and position.
(YearListView.prototype.onClick): If this is a click on a month button, select the month.
(YearListView.prototype.rowAtScrollOffset): Calculates the row currently at the given offset.
(YearListView.prototype.scrollOffsetForRow): Calculates the current scroll offset of the given row.
(YearListView.prototype.prepareNewCell): Prepares a new or recycled YearListCell.
(YearListView.prototype.updateCells): Updates the position of the visible cells.
(YearListView.prototype.deselect): Deselects a row.
(YearListView.prototype.deselectWithoutAnimating): Deselects a row without the closing animation.
(YearListView.prototype.select): Selects a row.
(YearListView.prototype.selectWithoutAnimating): Deselects a row without the opening animation.
(YearListView.prototype.buttonForMonth): Returns the month button for a given month. Returns null if the cell is not visible.
(YearListView.prototype.dehighlightMonth): Dehighlights the month button.
(YearListView.prototype.highlightMonth): Highlights the month button.
(YearListView.prototype.show): Call when showing the year list view. Shows the given month as highlighted.
(YearListView.prototype.hide): Dispatches a did hide event which will be picked up by the CalendarPicker and the MonthPopupView will close.
(YearListView.prototype._moveHighlightTo): Used to move the month highlight in response to a key event.
(YearListView.prototype.onKeyDown): Arrow keys and PageUp/PageDown keys work.
(MonthPopupView): The popup view to be overlayed over the calendar picker.
(MonthPopupView.prototype.show): Takes the initialMonth to show and the calendarTableRect so we can overlay the year list view right on top of it.
(MonthPopupView.prototype.hide):
(MonthPopupView.prototype.onClick): Hides itself if the use clicks outside the year list view.

5:33 PM Changeset in webkit [144253] by eric@webkit.org
  • 3 edits in trunk/Tools

Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
​https://bugs.webkit.org/show_bug.cgi?id=111021

Reviewed by Dirk Pranke.

The underlying code (which is shared with run-webkit-tests)
already knew how to support this option, it just wasn't exposed
via the run-perf-tests front-end. This patch fixes that.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):

4:56 PM Changeset in webkit [144252] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Stop uploading results to webkit-perf.appspot.com
​https://bugs.webkit.org/show_bug.cgi?id=110954

Reviewed by Benjamin Poulain.

Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunAndUploadPerfTests):

4:42 PM Changeset in webkit [144251] by schenney@chromium.org
  • 1 edit
    2 adds
    1 delete in trunk/LayoutTests

[Chromium] Rebaseline after r144236
​https://bugs.webkit.org/show_bug.cgi?id=109879

Unreviewed expectations update

  • platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt: Added.
  • platform/chromium-win-xp/plugins: Removed.
  • platform/chromium-win/plugins/plugin-clip-subframe-expected.txt: Added.
4:41 PM AddingFeatures edited by Laszlo Gombos
GTK port is now using SetupWebKitFeatures.m4 (diff)
4:17 PM Changeset in webkit [144250] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Use FeatureObserver to see how often web sites use multipart main documents
​https://bugs.webkit.org/show_bug.cgi?id=111015

Reviewed by Nate Chapin.

Multipart main documents add sigificant complexity to the loader. It
would be interesting to know how often this complexity is used.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::responseReceived):

  • page/FeatureObserver.h:
3:50 PM Changeset in webkit [144249] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r144168.
​http://trac.webkit.org/changeset/144168
​https://bugs.webkit.org/show_bug.cgi?id=111019

It broke the build and tronical is unavailable (Requested by
Ossy_night on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-27

  • LLIntOffsetsExtractor.pro:
3:47 PM Changeset in webkit [144248] by simonjam@chromium.org
  • 22 edits
    2 adds in trunk

[chromium] Lower priority of preloaded images
​https://bugs.webkit.org/show_bug.cgi?id=110527

Source/WebCore:

Reviewed by Nate Chapin.

This improves Speed Index by ~5%, because it encourages us to load images that are needed for
painting over speculative preloads. Ideally, all embedders would use this, but it relies on
ResourceHandle::didChangePriority being implemented. Currently, only Chrome does that.

Test: http/tests/loading/promote-img-preload-priority.html

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):
(WebCore::FrameLoaderClient::dispatchDidChangeResourcePriority): Added callback to enable testing.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::setLoadPriority): Signal callback.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::preload): Actual behavior change.

Source/WebKit/chromium:

Plumb the didChangePriority signal into DRT so it can be tested.

Reviewed by Nate Chapin.

  • public/WebFrameClient.h:

(WebKit):
(WebKit::WebFrameClient::didChangeResourcePriority):
(WebFrameClient):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidChangeResourcePriority):
(WebKit):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

Tools:

Plumb the didChangePriority signal into DRT so it can be tested.

Reviewed by Nate Chapin.

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestRunner::WebTestProxy::didChangeResourcePriority):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpResourcePriorities):
(WebTestRunner):
(WebTestRunner::TestRunner::dumpResourceRequestPriorities):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
(WebTestRunner::WebTestProxyBase::willSendRequest):
(WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
(WebTestRunner):

LayoutTests:

Reviewed by Nate Chapin.

  • http/tests/loading/promote-img-preload-priority-expected.txt: Added.
  • http/tests/loading/promote-img-preload-priority.html: Added.
3:25 PM Changeset in webkit [144247] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed trivial buildfix after r144190.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-27

  • platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:

(WebCore::GraphicsSurface::platformPaintToTextureMapper):

3:13 PM Changeset in webkit [144246] by Csaba Osztrogonác
  • 5 edits in trunk/Source/WebKit2

[WK2] One more unreviewed buildfix for EFL, GTK and Qt after r144218.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-27

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebProcess/Storage/StorageNamespaceProxy.cpp:

(WebKit::StorageNamespaceProxy::copy):

3:04 PM Changeset in webkit [144245] by pdr@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

Rebaseline 2 SVG tests after WK108429

This patch rebaselines svg/repaint after WK108429 and removes a stale
test expectations entry for svg/custom/text-ctm.

Unreviewed update of test expectations.

  • platform/chromium-win/svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
  • platform/chromium-win/svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
  • platform/chromium/TestExpectations:
2:55 PM Changeset in webkit [144244] by Chris Fleizach
  • 7 edits
    2 adds in trunk

WebSpeech: support speech cancel
​https://bugs.webkit.org/show_bug.cgi?id=107349

Reviewed by Beth Dakin.

Source/WebCore:

Add the ability to cancel speech utterances and make it work with Mac
and the mock speech synthesizer.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-cancel.html

  • Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::handleSpeakingCompleted):

  • platform/PlatformSpeechSynthesizer.h:

(PlatformSpeechSynthesizer):

  • platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper cancel]):
(WebCore::PlatformSpeechSynthesizer::cancel):
(WebCore):

  • platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::cancel):
(WebCore):
(WebCore::PlatformSpeechSynthesizerMock::speak):

  • platform/mock/PlatformSpeechSynthesizerMock.h:

(PlatformSpeechSynthesizerMock):

LayoutTests:

  • platform/mac/fast/speechsynthesis/speech-synthesis-cancel-expected.txt: Added.
  • platform/mac/fast/speechsynthesis/speech-synthesis-cancel.html: Added.
2:53 PM Changeset in webkit [144243] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebKit2

Unreviewed (speculative) build fixes for EFL, GTK and Qt after r144218.

  • CMakeLists.txt:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
2:49 PM Changeset in webkit [144242] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Unlock partially decoded images after passing them to the ImageDecodingStore
​https://bugs.webkit.org/show_bug.cgi?id=110778

Patch by Min Qin <​qinmin@chromium.org> on 2013-02-27
Reviewed by Stephen White.

Source/WebCore:

For partially decoded images, we need to unlock them so that the memory can be freed.
This change unlocks all the image frames after they are passed to ImageDecodingStore.
Unit tests are added in ImageFrameGeneratorTest.

  • platform/graphics/chromium/ImageFrameGenerator.cpp:

(WebCore::ImageFrameGenerator::tryToResumeDecodeAndScale):
(WebCore::ImageFrameGenerator::tryToDecodeAndScale):
(WebCore::ImageFrameGenerator::decode):

  • platform/image-decoders/ImageDecoder.h:

(ImageDecoder):
(WebCore::ImageDecoder::lockFrameBuffers):
(WebCore::ImageDecoder::unlockFrameBuffers):

Source/WebKit/chromium:

Test for testing that image frames are unlocked after passing to ImageDecodingStore.

  • tests/ImageFrameGeneratorTest.cpp:

(WebCore::ImageFrameGeneratorTest::SetUp):
(WebCore::ImageFrameGeneratorTest::frameBuffersUnlocked):
(ImageFrameGeneratorTest):
(WebCore::ImageFrameGeneratorTest::frameBuffersLocked):
(WebCore::TEST_F):

  • tests/MockImageDecoder.h:

(WebCore::MockImageDecoderClient::frameBuffersLocked):
(WebCore::MockImageDecoderClient::frameBuffersUnlocked):
(WebCore::MockImageDecoder::unlockFrameBuffers):
(WebCore::MockImageDecoder::lockFrameBuffers):
(MockImageDecoder):

2:44 PM Changeset in webkit [144241] by kbr@google.com
  • 4 edits in trunk

Insufficient validation when uploading depth textures to WebGL
​https://bugs.webkit.org/show_bug.cgi?id=110931

Reviewed by Abhishek Arya.

Source/WebCore:

Updated webgl/conformance/extensions/webgl-depth-texture.html
layout test with additional test cases.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2D):

Check for valid format/type combinations, depth, and
depth+stencil formats when uploading HTML elements and
ImageData as textures.

LayoutTests:

Updated webgl/conformance/extensions/webgl-depth-texture.html
layout test with additional test cases. These changes will be
added to the Khronos repository.

  • webgl/resources/webgl_test_files/conformance/extensions/webgl-depth-texture.html:

Added more test cases.

2:39 PM Changeset in webkit [144240] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Threaded HTML Parser fails fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html in debug
​https://bugs.webkit.org/show_bug.cgi?id=110951

Reviewed by Eric Seidel.

We were triggering this ASSERT because we didn't understand that a
given frame might have multiple DocumentLoaders in various states. That
caused us to think that a DocumentLoader in the provisional state was
actually loading.

  • dom/Document.cpp:

(WebCore::Document::decrementActiveParserCount):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoading):

2:24 PM Changeset in webkit [144239] by pdr@google.com
  • 7 edits
    2 copies in branches/chromium/1410

Merge 143541

Account for transform in SVG background images
​https://bugs.webkit.org/show_bug.cgi?id=110295

Reviewed by Dirk Schulze.

Source/WebCore:

Tiled SVG background images are rendererd by drawing the SVG content into a temporary
image buffer, then stamping out a tiled pattern using this buffer. Previously the
image buffer did not account for CSS transforms which could result in pixelated backgrounds.

This patch takes advantage of the context's transform when sizing the temporary tiling
image buffer. Because the context's transform also includes scale, this patch simplifies
the SVG image code to no longer track scale.

Test: svg/as-background-image/svg-transformed-background.html

  • loader/cache/CachedImage.cpp:

(WebCore):
(WebCore::CachedImage::imageForRenderer):

CachedImage::lookupOrCreateImageForRenderer no longer creates images so it has been
refactored into just "imageForRenderer". Previously there were two versions of
lookupOrCreateImageForRenderer; these have been folded into imageForRenderer.

  • loader/cache/CachedImage.h:
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawPatternForContainer):

To create the temporary tiling image buffer, the final size in screen coordinates is
needed. This is now computed using the current context's CTM. Because the CTM
already includes the page scale, all page scale tracking can be removed.

The adjustments to srcRect and the pattern transform are the same as before, just
refactored to use imageBufferScale which has x and y components.

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::setContainerSizeForRenderer):

Because the page scale needed to be cached between calls to
setContainerSizeForRenderer, this function was written to modify an existing cache
entry. Because the page scale no longer needs to be tracked, this code has been
simplified to re-write any existing cache entry.

(WebCore::SVGImageCache::imageSizeForRenderer):

This function has been simplified by calling SVGImageForContainer::size() instead
of computing this value manually. The value returned remains the same, containing
the container size multiplied by zoom.

(WebCore::SVGImageCache::imageForRenderer):

Previously we set the page scale on every call to imageForRenderer. Because page scale
no longer needs to be tracked, this function has been simplified to simply return
the cached SVGImageForContainer.

  • svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::drawPattern):

  • svg/graphics/SVGImageForContainer.h:

(WebCore::SVGImageForContainer::create):
(WebCore::SVGImageForContainer::SVGImageForContainer):
(SVGImageForContainer):

LayoutTests:

  • svg/as-background-image/svg-transformed-background-expected.html: Added.
  • svg/as-background-image/svg-transformed-background.html: Added.

TBR=​pdr@google.com
Review URL: ​https://codereview.chromium.org/12314169

2:22 PM Changeset in webkit [144238] by pdr@google.com
  • 1 edit
    2 copies in branches/chromium/1410

Merge 143257

Fix scaling of tiled SVG backgrounds on high-dpi displays
​https://bugs.webkit.org/show_bug.cgi?id=110047

Reviewed by Dirk Schulze.

Source/WebCore:

This patch fixes the scaling of SVG when used for drawing patterns. Tiled/patterend SVG
images are first drawn into an image buffer and then the image buffer is used to stamp
out tiles. Because it is a raster source, the size of the image buffer needs to
be scaled to the final resolution of the device. After scaling the image buffer, the
source rect and pattern transforms need to be adjusted so they align in device pixel
coordinates. This adjustment was not done before this patch, causing pixelated rendering.

Additionally, a FIXME has been added due to webkit.org/b/110065 and the image buffer
has been manually scaled (using "zoomedAndScaledContainerRect") instead of relying
on the ImageBuffer's resolutionScale parameter.

Test: svg/as-background-image/tiled-background-image.html

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawPatternForContainer):

Note that fixing the FIXME does not change that the source rect and transform need
to be adjusted for page scale.

LayoutTests:

  • svg/as-background-image/tiled-background-image-expected.html: Added.
  • svg/as-background-image/tiled-background-image.html: Added.

TBR=​pdr@google.com
Review URL: ​https://codereview.chromium.org/12326167

2:10 PM Changeset in webkit [144237] by Chris Fleizach
  • 10 edits
    2 adds in trunk

AX: Mac platform should support ability to scroll an element into visible
​https://bugs.webkit.org/show_bug.cgi?id=109860

Reviewed by Beth Dakin.

Source/WebCore:

Support the scrollToMakeVisible() action for MacOS accessibility clients.

Tests: platform/mac/accessibility/scroll-to-visible-action.html

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper accessibilityScrollToVisible]):
(-[WebAccessibilityObjectWrapper accessibilityPerformAction:]):

Tools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(scrollToMakeVisibleCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::scrollToMakeVisible):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::scrollToMakeVisible):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::scrollToMakeVisible):
(WTR):

LayoutTests:

  • platform/mac/accessibility/scroll-to-visible-action.html: Added.
  • platform/mac/accessibility/scroll-to-visible-action-expected.txt: Added.
2:05 PM Changeset in webkit [144236] by commit-queue@webkit.org
  • 20 edits
    5 adds in trunk

Plugin in iframe may not display
​https://bugs.webkit.org/show_bug.cgi?id=109879

Patch by John Bauman <​jbauman@chromium.org> on 2013-02-27
Reviewed by Simon Fraser.

Source/WebCore:

Changing the cliprect on a layer containing an iframe may change the
cliprect of plugins inside the iframe, so recursively tell all plugins
in iframes that their cliprect has changed after doing layout on the
outer frame.

Test: plugins/plugin-clip-subframe.html

  • platform/ScrollView.cpp:

(WebCore::ScrollView::clipRectChanged):

  • platform/ScrollView.h:
  • platform/Widget.h:

(WebCore::Widget::clipRectChanged):

  • plugins/PluginView.cpp:

(WebCore::PluginView::clipRectChanged):

  • plugins/PluginView.h:
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):

Source/WebKit/chromium:

Use clipRectChanged to update the geometry.

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::clipRectChanged):

  • src/WebPluginContainerImpl.h:

Source/WebKit/mac:

Ensure NetscapePluginWidget informs the plugin view of the cliprect change directly.

  • Plugins/WebBaseNetscapePluginView.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(NetscapePluginWidget::clipRectChanged):

Source/WebKit2:

Update geometry when cliprect changes.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::clipRectChanged):

  • WebProcess/Plugins/PluginView.h:

Tools:

LogNPPSetWindow will be used with other ports as well.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:

LayoutTests:

Use log-npp-set-window to ensure plugin clip changes correctly.

  • platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt: Added.
  • platform/mac/plugins/plugin-clip-subframe-expected.txt: Added.
  • plugins/plugin-clip-subframe-expected.txt: Added.
  • plugins/plugin-clip-subframe.html: Added.
  • plugins/resources/plugin-clip-subframe-iframe.html: Added.
1:46 PM Changeset in webkit [144235] by crogers@google.com
  • 12 edits
    2 adds in trunk

Implement channel up-mixing and down-mixing rules
​https://bugs.webkit.org/show_bug.cgi?id=110812

Reviewed by Kenneth Russell.

Source/WebCore:

Please see Web Audio specification for details of the AudioNode mixing rules attributes:
​https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#UpMix

Test: webaudio/audionode-channel-rules.html

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::channelCount):
(WebCore):
(WebCore::AudioNode::setChannelCount):
(WebCore::AudioNode::channelCountMode):
(WebCore::AudioNode::setChannelCountMode):
(WebCore::AudioNode::channelInterpretation):
(WebCore::AudioNode::setChannelInterpretation):
(WebCore::AudioNode::updateChannelsForInputs):

  • Modules/webaudio/AudioNode.h:

(AudioNode):
(WebCore::AudioNode::internalChannelCountMode):
(WebCore::AudioNode::internalChannelInterpretation):

  • Modules/webaudio/AudioNode.idl:
  • Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::numberOfChannels):
(WebCore::AudioNodeInput::bus):
(WebCore::AudioNodeInput::internalSummingBus):
(WebCore::AudioNodeInput::sumAllConnections):
(WebCore::AudioNodeInput::pull):

  • Modules/webaudio/AudioNodeInput.h:

(AudioNodeInput):

  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::ConvolverNode):

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::speakersCopyFrom):
(WebCore::AudioBus::speakersSumFrom):
(WebCore::AudioBus::speakersSumFrom5_1_ToMono):
(WebCore):

  • platform/audio/AudioBus.h:

(AudioBus):

LayoutTests:

  • webaudio/audionode-channel-rules-expected.txt: Added.
  • webaudio/audionode-channel-rules.html: Added.
1:42 PM Changeset in webkit [144234] by schenney@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

RenderTableCellDeathTest unit test fails on mac
​https://bugs.webkit.org/show_bug.cgi?id=110992

Unreviewed second attempt. Trying to get the right define for the OS.

  • tests/RenderTableCellTest.cpp:
1:35 PM WebKitGTK/2.0.x edited by zandobersek@gmail.com
(diff)
1:30 PM Changeset in webkit [144233] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Need WebPage API for animating scroll position & zoom changes
​https://bugs.webkit.org/show_bug.cgi?id=110912

Patch by Andrew Lo <​anlo@rim.com> on 2013-02-27
Reviewed by Rob Buis.

Internally reviewed by Jakob Petsovits.
Internal PR 285468.

Add an API to WebPage for animated scroll position & zoom level
adjustments.

Have InputHandler use the new API.

Rename some variables to reflect the fact that they are not only
used by block zoom now.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):
(BlackBerry::WebKit::WebPage::blockZoom):
(BlackBerry::WebKit::WebPagePrivate::animateToScaleAndDocumentScrollPosition):
(WebKit):
(BlackBerry::WebKit::WebPage::animateToScaleAndDocumentScrollPosition):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

1:23 PM Changeset in webkit [144232] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Threaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader()
​https://bugs.webkit.org/show_bug.cgi?id=110937

Reviewed by Darin Adler.

This patch restores the ASSERT behind an ifdef so that we can continue
to get converage from the ASSERT while we investigate why it is
triggering in the threaded parser.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::checkLoadComplete):

1:20 PM Changeset in webkit [144231] by jochen@chromium.org
  • 3 edits
    1 add in trunk/Source/Platform

[chromium] Introduce WebHyphenator class to consolidate hyphenation related method on WebKit::Platform
​https://bugs.webkit.org/show_bug.cgi?id=110953

Reviewed by Adam Barth.

This patch makes it easier to mock the hyphenation related methods.

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::hyphenator):

  • chromium/public/WebHyphenator.h: Added.

(WebKit):
(WebHyphenator):
(WebKit::WebHyphenator::canHyphenate):
(WebKit::WebHyphenator::computeLastHyphenLocation):
(WebKit::WebHyphenator::~WebHyphenator):

12:58 PM Changeset in webkit [144230] by jochen@chromium.org
  • 2 edits in trunk/LayoutTests

Skip media tests that fail on content_shell

Unreviewed gardening.

  • platform/chromium/ContentShellTestExpectations:
12:50 PM Changeset in webkit [144229] by liachen@rim.com
  • 9 edits in trunk/Source

[BlackBerry] User credentials is not correctly handled
​https://bugs.webkit.org/show_bug.cgi?id=110994

Source/WebCore:

Internal PR: 280990
Internal reviewed by Leo Yang.

Reviewed by Yong Li.

Following changes are made:

Remove url from generating the hash to index user credential.
Remove url from database.
Use new CertMgrWrapper API to remove password from CertMgr.
Handle encrypted password as binary data, instead of normal text string.
When authentication fails, remove the saved user credential only when they match.
Remove some url related API from CredentialBackingStore, as they are obsolete now.

No new tests as this is platform specific change about user credential.

  • platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::hashCredentialInfo):
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::~CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::hasLogin):
(WebCore::CredentialBackingStore::getLogin):
(WebCore::CredentialBackingStore::removeLogin):
(WebCore::CredentialBackingStore::addNeverRemember):
(WebCore::CredentialBackingStore::encryptedString):
(WebCore::CredentialBackingStore::decryptedString):

  • platform/network/blackberry/CredentialBackingStore.h:

(CredentialBackingStore):

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::purgeCredentials):

Source/WebKit/blackberry:

Reviewed by Yong Li.

Following change are made:

Remove url from CredentialTransformData, as url is not used anymore.
Adapt to updated CredentialBackingStore API about removing url.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):

  • WebCoreSupport/CredentialManager.cpp:

(WebCore::CredentialManager::autofillPasswordForms):
(WebCore::CredentialManager::saveCredentialIfConfirmed):

  • WebCoreSupport/CredentialTransformData.cpp:

(WebCore::CredentialTransformData::CredentialTransformData):

  • WebCoreSupport/CredentialTransformData.h:

(CredentialTransformData):

12:44 PM Changeset in webkit [144228] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebKit2

REGRESSION (48533): Full-frame plugins stopped working (download instead of loading the plugin)
​https://bugs.webkit.org/show_bug.cgi?id=111003

Reviewed by Anders Carlsson.

Also query the Page's pluginData when determining whether a given MIME type can be shown.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCanShowMIMEType):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::canShowMIMEType):

  • WebProcess/WebPage/WebPage.h:
12:43 PM Changeset in webkit [144227] by schenney@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

RenderTableCellDeathTest unit test fails on mac
​https://bugs.webkit.org/show_bug.cgi?id=110992

Unreviewed disabling of test that is hanging or crashing on Mac.

  • tests/RenderTableCellTest.cpp:
12:40 PM Changeset in webkit [144226] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

Refactor transform painting/hit testing code in RenderLayer.
​https://bugs.webkit.org/show_bug.cgi?id=110998

Reviewed by Eric Seidel.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
Pull the code that applies the transform for painting into a new
function that can also apply an additional translation offset. This
offset will be used by the new columns code when that patch lands.

(WebCore::RenderLayer::createLocalTransformState):
Also patched to be able to apply an additional translation offset.

(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestLayerByApplyingTransform):
Same as with painting, pull the code that applies the transform into
its own function and also enable an extra translation offset to be
applied.

  • rendering/RenderLayer.h:

Added the new functions to the header.

12:39 PM Changeset in webkit [144225] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Remove suppression invalidation logic from WebViewImpl
​https://bugs.webkit.org/show_bug.cgi?id=110999

Patch by James Robinson <​jamesr@chromium.org> on 2013-02-27
Reviewed by Adrienne Walker.

This suppression logic is now handled on the embedder side. In fact, scheduleComposite() is now only used
by DumpRenderTree.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::suppressInvalidations):
(WebKit::WebViewImpl::scheduleComposite):

  • src/WebViewImpl.h:
12:38 PM Changeset in webkit [144224] by jochen@chromium.org
  • 7 edits
    1 delete in trunk

plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
​https://bugs.webkit.org/show_bug.cgi?id=110973

Reviewed by Adam Barth.

There is nothing that ensures that the log messages from the plugin
come in before the layout test finished loading.

Tools:

  • DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:

(PassDifferentNPPStruct::NPP_SetWindow):

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_SetWindow):

LayoutTests:

  • platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Removed.
  • plugins/netscape-plugin-setwindow-size-2.html:
  • plugins/netscape-plugin-setwindow-size.html:
  • plugins/pass-different-npp-struct.html:
12:37 PM Changeset in webkit [144223] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Touch CSSGrammar.y.in to fix an internal buildbot

  • css/CSSGrammar.y.in: Add copyright dates based on previous

commits.

12:21 PM Changeset in webkit [144222] by zandobersek@gmail.com
  • 2 edits in trunk

[GTK] Disable MathML support in release builds
​https://bugs.webkit.org/show_bug.cgi?id=110981

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2013-02-27
Reviewed by Martin Robinson.

  • Source/autotools/SetupWebKitFeatures.m4: Disable the MathML support in release builds

as the code is not yet deemed production-ready.

12:20 PM Changeset in webkit [144221] by commit-queue@webkit.org
  • 19 edits in trunk

Add smartInsertDeleteEnabled setting to WebCore::Page
​https://bugs.webkit.org/show_bug.cgi?id=107840

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-27
Reviewed by Ryosuke Niwa.

Source/WebCore:

Covered by editing/deleting/smart-editing-disabled.html.

  • page/Settings.in: Add new setting with true as initial value.

Source/WebKit2:

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode): Remove code related to
isSmartInsertDeleteEnabled.

  • Shared/WebPageCreationParameters.h:

(WebPageCreationParameters): Remove isSmartInsertDeleteEnabled.

  • Shared/WebPreferencesStore.h:

(WebKit): Add macro for smartInsertDeleteEnabled setting.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetSmartInsertDeleteEnabled):
(WKPreferencesGetSmartInsertDeleteEnabled): Implement methods using the
new setting.

  • UIProcess/API/C/WKPreferencesPrivate.h: Add new methods headers.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage): Set smartInsertDeleteEnabled
setting using m_isSmartInsertDeleteEnabled to keep initial value on Mac.
(WebKit::WebPageProxy::creationParameters): Remove usage of
parameters.isSmartInsertDeleteEnabled.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::smartInsertDeleteEnabled): Enable method for
all platforms.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Remove m_isSmartInsertDeleteEnabled
initialization.
(WebKit::WebPage::updatePreferences): Set smartInsertDeleteEnabled
setting.
(WebKit::WebPage::isSmartInsertDeleteEnabled): Implement method using
settings.
(WebKit):
(WebKit::WebPage::setSmartInsertDeleteEnabled): Implement method using
settings.

  • WebProcess/WebPage/WebPage.h:

(WebPage): Enable methods dealing with smartInsertDeleteEnabled for all
platforms and remove m_isSmartInsertDeleteEnabled as it will be a
setting.

LayoutTests:

Replace testRunner.setSmartInsertDeleteEnabled by
internals.settings.setSmartInsertDeleteEnabled in tests.

  • editing/deleting/smart-editing-disabled.html:
  • editing/selection/doubleclick-beside-cr-span.html:
  • editing/selection/doubleclick-whitespace-crash.html:
  • editing/selection/doubleclick-whitespace-img-crash.html:
  • editing/selection/doubleclick-whitespace.html:
  • platform/wk2/TestExpectations: Unflag

editing/deleting/smart-editing-disabled.html as it passes now.

12:14 PM Changeset in webkit [144220] by Chris Fleizach
  • 8 edits
    2 adds in trunk

WebSpeech: Support pause/resume ability
​https://bugs.webkit.org/show_bug.cgi?id=107345

Reviewed by Beth Dakin.

Source/WebCore:

Add in the pause/resume functionality to SpeechSynthesis. Also hook up
the callback events.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-pause-resume.html

  • Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::startSpeakingImmediately):
(WebCore::SpeechSynthesis::pause):
(WebCore::SpeechSynthesis::resume):
(WebCore):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):

  • Modules/speech/SpeechSynthesis.h:

(SpeechSynthesis):

  • platform/PlatformSpeechSynthesizer.h:

(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):

  • platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper pause]):
(-[WebSpeechSynthesisWrapper resume]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::resume):

LayoutTests:

  • platform/mac/fast/speechsynthesis/speech-synthesis-pause-resume-expected.txt: Added.
  • platform/mac/fast/speechsynthesis/speech-synthesis-pause-resume.html: Added.
12:11 PM Changeset in webkit [144219] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Disable some unsound DFG DCE
​https://bugs.webkit.org/show_bug.cgi?id=110948

Reviewed by Michael Saboff.

DCE of bitops is not sound since the bitops might call some variant of valueOf.

This used to work right because ValueToInt32 was MustGenerate. From the DFG IR
standpoint it feels weird to make ValueToInt32 be MustGenerate since that node is
implemented entirely as a pure conversion. If we ever gave the DFG the ability to
do effectful bitops, we would most likely implement them as special nodes not
related to the ValueToInt32 and bitop nodes we have now.

This change is performance neutral.

  • dfg/DFGNodeType.h:

(DFG):

12:04 PM Changeset in webkit [144218] by andersca@apple.com
  • 6 edits
    1 add in trunk/Source/WebKit2

More storage scaffolding
​https://bugs.webkit.org/show_bug.cgi?id=110997

Reviewed by Andreas Kling.

  • DerivedSources.make:

Add StorageAreaProxy.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::setItem):
Send back a DidSetItem message.

  • WebKit2.xcodeproj/project.pbxproj:

Add generated files.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::StorageAreaProxy):
Add the message receiver.

(WebKit::StorageAreaProxy::~StorageAreaProxy):
Remove the message receiver.

(WebKit::StorageAreaProxy::didSetItem):
add stub.

  • WebProcess/Storage/StorageAreaProxy.h:

(StorageAreaProxy):

  • WebProcess/Storage/StorageAreaProxy.messages.in: Added.
11:40 AM Changeset in webkit [144217] by weinig@apple.com
  • 8 edits in trunk/Source/WebKit2

REGRESSION: Loading flash switches to discrete graphics, 100 MB on membuster
<rdar://problem/13229828>

Reviewed by Dan Bernstein.

Due the change in CFBundleIdentifier, the WebProcess and PluginProcess were
unnecessarily muxing (they used to be whitelisted by OpenGL) to the discrete
GPU.

  • PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
  • WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:

Add NSSupportsAutomaticGraphicsSwitching YES.

  • WebKit2.xcodeproj/project.pbxproj:

Re-add the PluginService.32-64.Info.plist plist to the project file.

11:14 AM Changeset in webkit [144216] by ap@apple.com
  • 34 edits in trunk/Source

Don't add a body to platform request until necessary
​https://bugs.webkit.org/show_bug.cgi?id=110900

Reviewed by NOBODY (OOPS!).

Reviewed by Brady Eidson.

ResourceRequest now has more state for syncing between resource and platform parts.
In addition to tracking which is up to date, we also track which has up to date
HTTP Body.

The reason is that we don't need the body on request before it's actually sent,
and we actually cannot build it when networking is out of process.

  • WebCore.exp.in: Updated exports.
  • platform/network/ResourceRequestBase.h:
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setHTTPBody): Update HTTP body before returning it. (WebCore::ResourceRequestBase::updatePlatformRequest): Update according to HTTPBodyUpdatePolicy. (WebCore::ResourceRequestBase::updateResourceRequest): Ditto.
  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::formDataStreamLengthPropertyName): (WebCore::formCopyProperty): (WebCore::setHTTPBody): Changed to not update Content-Length in platform request directly. We need to keep it in sync with resource request, and it's easier to do in a caller. Exposed computed length as a property do avoid duplicating the work.
  • platform/network/cf/FormDataStreamCFNet.h: Removed unnecessary httpBodyFromStream().
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::ResourceHandle::createCFURLConnection): Update body when necessary.

(WebCore::ResourceRequest::nsURLRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdateResourceHTTPBody):
(WebCore):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):
Ditto.

  • platform/network/cf/ResourceRequest.h: Track body up-to-date state.
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::cfURLRequest): Honor HTTPBodyUpdatePolicy. (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't update body here. (WebCore::ResourceRequest::doUpdatePlatformHTTPBody): Update the body, and make sure that Content-Length is correct. (WebCore::ResourceRequest::doUpdateResourceRequest): Don't update body here. (WebCore::ResourceRequest::doUpdateResourceHTTPBody): Update the body, fixing a bug where body stream was lost if this function got called. (WebCore::ResourceRequest::applyWebArchiveHackForMail): No need to update body for this one.
  • platform/network/mac/ResourceRequestMac.mm: Ditto (but this didn't have a bug with streams in doUpdateResourceRequest()).
  • platform/network/mac/FormDataStreamMac.h: Forward declare formDataStreamLengthPropertyName().
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::createNSURLConnection): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::platformLoadResourceSynchronously): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Update body when necessary.
  • platform/network/blackberry/ResourceRequest.h:
  • platform/network/chromium/ResourceRequest.h:
  • platform/network/curl/ResourceRequest.h:
  • platform/network/qt/ResourceRequest.h:
  • platform/network/soup/ResourceRequest.h:
  • platform/network/win/ResourceRequest.h: Added stubs for new functions. These ports don't keep a platform request in ResourceRequest, and don't need updating.
11:03 AM Changeset in webkit [144215] by schenney@chromium.org
  • 8 edits
    4 adds in trunk/LayoutTests

[Chromium] Test expectations updates

Unreviewed expectations after recent bug fixes.

  • platform/chromium-mac-lion/fast/borders/border-radius-percent-expected.png: Added.
  • platform/chromium-mac-lion/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-percent-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-percent-expected.png: Added.
  • platform/chromium-mac/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-mac/svg/custom/transform-with-shadow-and-gradient-expected.png:
  • platform/chromium-win/fast/borders/border-radius-percent-expected.png: Added.
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-win/svg/custom/transform-with-shadow-and-gradient-expected.png:
  • platform/chromium/TestExpectations:
10:46 AM Changeset in webkit [144214] by glenn@skynav.com
  • 19 edits in trunk

Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
​https://bugs.webkit.org/show_bug.cgi?id=110944

Reviewed by Dean Jackson.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
10:43 AM Changeset in webkit [144213] by abucur@adobe.com
  • 10 edits in trunk

REGRESSION(r124739): fast/lists/list-marker-remove-crash.html hits an assertion in MoveParagraphs
​https://bugs.webkit.org/show_bug.cgi?id=93247

Reviewed by Darin Adler.

Source/WebCore:

The listifyParagraph function inside InsertListCommand triggered a layout for the new list and updated
only the "start" Position. The insertion and layout may have changed the "end" Position as well. The patch
makes sure "end" is also recomputed.

Test: No new test, the patch fixes a regression.

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::listifyParagraph):

LayoutTests:

Update TestExpectations because the test doesn't crash any more.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
10:38 AM Changeset in webkit [144212] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Add ENABLE_STREAM guards to FileReaderLoader
​https://bugs.webkit.org/show_bug.cgi?id=110938

Patch by Zach Kuznia <​zork@chromium.org> on 2013-02-27
Reviewed by Hajime Morrita.

  • fileapi/FileReaderLoader.cpp:
  • fileapi/FileReaderLoader.h:
10:38 AM Changeset in webkit [144211] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Remove myself from watchlist.

Patch by Yong Li <​yong.li.webkit@outlook.com> on 2013-02-27

  • Scripts/webkitpy/common/config/watchlist:
10:34 AM Changeset in webkit [144210] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build when DFG_JIT is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=110991

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-02-27
Reviewed by Csaba Osztrogonác.

  • jit/JIT.h:

(JSC::JIT::canBeOptimizedOrInlined):

10:19 AM Changeset in webkit [144209] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Fix bug in HTML5 Fullscreen API implementation that was preventing YouTube HTML5 media controls fullscreen button from working properly.
​https://bugs.webkit.org/show_bug.cgi?id=110905

Patch by John Griggs <​jgriggs@rim.com> on 2013-02-27
Reviewed by Yong Li.

Return true from ChromeClientBlackBerry::supportsFullScreenForElement instead of the negation of the boolean flag (withKeyboard) passed in.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):

10:18 AM Changeset in webkit [144208] by allan.jensen@digia.com
  • 4 edits in trunk

Switch QtWebKit to GStreamer 1.0.
​https://bugs.webkit.org/show_bug.cgi?id=106669.

Original patch by Sebastian Dröge.
Reviewed by Csaba Osztrogonác.

Source/WebCore:

  • WebCore.pri:

Tools:

Build with GStreamer 1.0 if available, but support GStreamer 0.10
temporarily to make upgrading easy and the patch suitable for Qt5.

  • qmake/mkspecs/features/features.prf:
10:01 AM Changeset in webkit [144207] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/planet.webkit.org

Add Martin Robinson's blog to the planet
​https://bugs.webkit.org/show_bug.cgi?id=110990

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-02-27
Reviewed by Eric Seidel.

  • config.ini: Add my blog to the planet.
9:53 AM Changeset in webkit [144206] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove WebViewImpl::animate shimmy out through compositor
​https://bugs.webkit.org/show_bug.cgi?id=110935

Reviewed by Adrienne Walker.

WebViewImpl::animate() and WebViewImpl::updateAnimations() are confusingly similar. ::animate() implements
the WebWidget API and is called by content::RenderWidget and WebViewHost. ::updateAnimations() implements
the WebLayerTreeViewClient API and is called by content::RenderWidgetCompositor and by ::animate(). The
important part of this indirection is that whenever the compositor is active, all animation calls must
route through cc::LayerTreeHost before entering into WebCore's animation code so that the compositor
can set the appropriate rate limiting state. Animations may originate from
content::RenderWidget::AnimateIfNeeded when in software and single threaded mode or from
cc::LayerTreeHost::updateAnimations in threaded compositing mode. In the long ago, content::RenderWidget had no
idea if compositing was active or not and always called WebWidget::animate(), so WebViewImpl::animate() had to
redirect to the compositor when appropriate.

Now (as of chromium r180947) RenderWidget calls WebWidget::animate only when in software mode and otherwise
calls directly into the compositor. Thus WebViewImpl::animate() no longer needs to do this check. In a
follow-up, WebViewImpl::updateAnimations will go away completely in favor of just calling WebWidget::animate in
all cases.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::updateAnimations):

9:48 AM Changeset in webkit [144205] by efidler@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fix BlackBerry::Platform::String to WTF::String conversion when the string is Latin-1-encoded.
​https://bugs.webkit.org/show_bug.cgi?id=110986

Reviewed by Yong Li.

Internally reviewed by Nima Ghanavatian.
BlackBerry PR 292922

We were assuming all platform strings were valid UTF-8, which isn't true for Latin-1 strings.

  • platform/text/blackberry/StringBlackBerry.cpp:

(WTF::String::String):

9:42 AM Changeset in webkit [144204] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[TexMap] REGRESSION(144183): It make negative delay tests fails
​https://bugs.webkit.org/show_bug.cgi?id=110989

Reviewed by Noam Rosenthal.

Do not apply a negative offset to the animation starttime send to the GraphicLayerClient,
it needs the actual animation start not a virtual start.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):

9:35 AM Changeset in webkit [144203] by acolwell@chromium.org
  • 3 edits
    2 adds in trunk

Fix SourceBufferList so SourceBuffer.append() calls are always rejected after the MediaSource is closed.
​https://bugs.webkit.org/show_bug.cgi?id=110917

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/media-source/video-media-source-reject-append-after-reopening.html

  • Modules/mediasource/SourceBufferList.cpp:

(WebCore::SourceBufferList::clear):

LayoutTests:

  • http/tests/media/media-source/video-media-source-reject-append-after-reopening-expected.txt: Added.
  • http/tests/media/media-source/video-media-source-reject-append-after-reopening.html: Added.
9:25 AM AddingFeatures edited by Martin Robinson
(diff)
9:20 AM Changeset in webkit [144202] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Context menu cannot be invoked after doing text selection in landscape mode
​https://bugs.webkit.org/show_bug.cgi?id=110860

Patch by Sean Wang <​Xuewen.Wang@torchmobile.com.cn> on 2013-02-27
Reviewed by Yong Li.

PR 290248 Internally reviewed by Mike Fenton

Add a parameter to notify the webpage client which parts of selection have
changed in visual or in its selected DOM content. Refactor the selection details
parameter to platform repo.

The reason of this issue is that when javascript triggers webpage layout, the selection
will update its apperance event when the selected content is not changed. We want
to hide the context menu only when the selected content is changed not when only its
visual is changed.

9:18 AM Changeset in webkit [144201] by Szilárd LEDÁN
  • 2 edits in trunk/Tools

Unreviewed. Added myself to committers.py

  • Scripts/webkitpy/common/config/committers.py:
9:12 AM Changeset in webkit [144200] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] The virtual keyboard hides part of Signing In dialog
​https://bugs.webkit.org/show_bug.cgi?id=110836

Patch by Sean Wang <​Xuewen.Wang@torchmobile.com.cn> on 2013-02-27
Reviewed by Yong Li.

PR # 283427 Internally reviewed by Mike Fenton.

Store form credentials before javascript "onSubmit" event and notify
webpage client to save credentials after that event since javascript
may check credentials and stop the submission in its event handler.

  • WebCoreSupport/CredentialTransformData.cpp:

(WebCore::CredentialTransformData::CredentialTransformData):
(WebCore):

  • WebCoreSupport/CredentialTransformData.h:

(CredentialTransformData):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):

  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

9:07 AM Changeset in webkit [144199] by Szilárd LEDÁN
  • 2 edits in trunk/Tools

Unreviewed, rolling out r144192.
​http://trac.webkit.org/changeset/144192
​https://bugs.webkit.org/show_bug.cgi?id=110984

Stored svn password on wrong computer (Requested by kkristof
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-27

  • Scripts/webkitpy/common/config/committers.py:
9:02 AM Changeset in webkit [144198] by pilgrim@chromium.org
  • 2 edits in trunk/Source/Platform

[Chromium] Remove unused WebKitPlatformSupport class
​https://bugs.webkit.org/show_bug.cgi?id=110982

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

  • chromium/public/Platform.h:
8:59 AM Changeset in webkit [144197] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskipp inspector tests after r144071.

  • platform/qt/TestExpectations:
8:48 AM Changeset in webkit [144196] by junov@google.com
  • 4 edits
    3 adds in trunk

REGRESSION (r134631) of border-radius percentage with border pixel
​https://bugs.webkit.org/show_bug.cgi?id=110889

Reviewed by Simon Fraser.

Source/WebCore:

Fixing background color filling to handle "non renderable" rounded
rectangles.

Test: fast/borders/border-radius-percent.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

LayoutTests:

Adding new pixel test to verify the correct rendering of
rounded rectangle backgrounds with inner border radii that
exceed the dimensions of the inner edge of the border.

  • fast/borders/border-radius-percent-expected.txt: Added.
  • fast/borders/border-radius-percent.html: Added.
  • platform/chromium-linux/fast/borders/border-radius-percent-expected.png: Added.
  • platform/chromium/TestExpectations:
8:45 AM Changeset in webkit [144195] by fmalita@chromium.org
  • 6 edits in trunk

[Chromium] Layout Test svg/custom/transform-with-shadow-and-gradient.svg is failing
​https://bugs.webkit.org/show_bug.cgi?id=76557

Reviewed by Stephen Chenney.

Source/WebCore:

Always use kDst_Mode transfer for the shadow looper. Using kSrc_Mode to enforce CSS
box-shadow opaqueness at this level is not necessary since the RenderBoxModel box
decoration code already makes sure that shadows are filled with opaque black.

This change aligns the SVG shadow behavior (and pixel results) with CG/Safari.

No new tests, coverage provided by existing tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

LayoutTests:

  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-linux/svg/custom/transform-with-shadow-and-gradient-expected.png:
  • platform/chromium/TestExpectations:
8:42 AM Changeset in webkit [144194] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Generate a wrapper function for ReplaceableAttrSetter()
​https://bugs.webkit.org/show_bug.cgi?id=110781

Reviewed by Adam Barth.

This is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings. This patch introduces an indirection function
for xxxReplaceableAttrSetter(), like this:

For non-custom replaceable setters (Note: One implementation
is enough for all replaceable setters in one interface.)
void V8XXX:::ReplaceableAttrSetterCallback(...) {

V8XXX::ReplaceableAttrSetter(...);

}

For custom replaceable setters. (Note: This is treated as
a normal custom setter.)
void xxxAttrSetterCallback(...) {

return xxxAttrSetterCustom(...);

}

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateReplaceableAttrSetterCallback):
(GenerateReplaceableAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::TestObjReplaceableAttrSetterCallback):
(TestObjV8Internal):
(WebCore):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::TestTypedefsReplaceableAttrSetterCallback):
(TestTypedefsV8Internal):

8:26 AM Changeset in webkit [144193] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Accept key events even when composing region is active.
​https://bugs.webkit.org/show_bug.cgi?id=110617

Reviewed by Rob Buis.

PR 293598.

Fix a regression in the previous patch caused
by an unhandled Alt key down being sent through
by IMF.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::updateFormState):

  • WebKitSupport/InputHandler.h:

(InputHandler):

8:21 AM Changeset in webkit [144192] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/Tools

Unreviewed. Added myself to committers.py

  • Scripts/webkitpy/common/config/committers.py:
8:18 AM Changeset in webkit [144191] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Flash objects won't load until scrolling page
​https://bugs.webkit.org/show_bug.cgi?id=110149

Reviewed by Simon Hausmann.

Revert r134222. The issue from bug 101836 is no longer reproducable,
and the fix was causing flash objects to not load properly.

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::determineQuirks):

8:16 AM Changeset in webkit [144190] by commit-queue@webkit.org
  • 36 edits
    7 adds in trunk

[Texmap] TextureMapper is too eager to use intermediate surfaces
​https://bugs.webkit.org/show_bug.cgi?id=110762

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-02-27
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

Refactor the way intermediate surfaces are handled in TextureMapperLayer.
Beforehand, we would create an intermediate surface whenever there is a chance of overlap, and
the intermediate surface would be the largest possible. The result would then be drawn to the
target surface with the layer's opacity and mask.

This would make it so that (1) surfaces are created even when they're not needed, i.e. when there
is no actual overlap, and (2) mask wouldn't be applied correctly.

In this patch the behavior is changed so that the area to be painted is divided to "overlapping"
and "non overlapping" regions. The non-overlapping regions are painted directly, while the overlapping
regions are tiled to smaller rectangles painted using an intermediate surface.
Masks are applied to those intermediate surfaces based on the transform of the actual mask, not drawn
together with the content texture like before.

This optimizes for the more common case of opacity animations on a large tree, while making the quite
rare case of composited masks slightly less optimized but always correct.

Tests: compositing/overlap-blending/children-opacity-huge.html

compositing/overlap-blending/reflection-opacity-huge.html
compositing/overlap-blending/children-opacity-no-overlap.html

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/cairo/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::paintToTextureMapper):

  • platform/graphics/qt/MediaPlayerPrivateQt.h:

(MediaPlayerPrivateQt):

  • platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::paintToTextureMapper):

  • platform/graphics/surfaces/GraphicsSurface.h:

(GraphicsSurface):

  • platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurface::platformPaintToTextureMapper):

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore::GraphicsSurface::platformPaintToTextureMapper):

  • platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:

(WebCore::GraphicsSurface::platformPaintToTextureMapper):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

(TextureMapperBackingStore):

  • platform/graphics/texmap/TextureMapperPlatformLayer.h:

(TextureMapperPlatformLayer):

  • platform/graphics/texmap/TextureMapperSurfaceBackingStore.cpp:

(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapperSurfaceBackingStore.h:

(TextureMapperSurfaceBackingStore):

  • platform/graphics/texmap/TextureMapperTile.cpp:

(WebCore::TextureMapperTile::paint):

  • platform/graphics/texmap/TextureMapperTile.h:

(TextureMapperTile):

  • platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:

(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapperTiledBackingStore.h:

(TextureMapperTiledBackingStore):

  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:

(WebCore::CoordinatedBackingStore::paintTilesToTextureMapper):
(WebCore::CoordinatedBackingStore::paintToTextureMapper):

  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:

(CoordinatedBackingStore):

Removed the "mask" parameter from TextureMapperPlatformLayer and overrides, since
we no longer paint the contents and the mask in the same pass.

  • platform/graphics/texmap/TextureMapper.cpp:

(WebCore::TextureMapper::TextureMapper):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::TextureMapper::setMaskMode):
(TextureMapper):
(WebCore::TextureMapper::isInMaskMode):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawNumber):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::draw):
(WebCore):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
(WebCore::TextureMapperGL::drawFiltered):

  • platform/graphics/texmap/TextureMapperGL.h:

(TextureMapperGL):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::TextureMapperImageBuffer::drawTexture):
(WebCore::TextureMapperImageBuffer::drawSolidColor):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(TextureMapperImageBuffer):

Instead of painting the mask together with the texture/color, paint the mask
by drawing with DestinationIn to an existing surface.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(TextureMapperPaintOptions):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::shouldBlend):
(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::replicaTransform):
(WebCore):
(WebCore::applyFilters):
(WebCore::resolveOverlaps):
(WebCore::TextureMapperLayer::computeOverlapRegions):
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
(WebCore::TextureMapperLayer::applyMask):
(WebCore::TextureMapperLayer::paintIntoSurface):
(WebCore::commitSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):
(WebCore::TextureMapperLayer::paintRecursive):

  • platform/graphics/texmap/TextureMapperLayer.h:

(WebCore):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::hasFilters):

  • platform/graphics/texmap/TextureMapperShaderProgram.cpp:

(WebCore):
(WebCore::TextureMapperShaderProgram::create):

  • platform/graphics/texmap/TextureMapperShaderProgram.h:

LayoutTests:

Added a few ref-tests for correct overlap blending in accelearated compositing mode.
Skipping the new reflection test on Mac/Chromium since it's not rendered
properly on those platforms.

  • compositing/overlap-blending/children-opacity-huge-expected.html: Added.
  • compositing/overlap-blending/children-opacity-huge.html: Added.
  • compositing/overlap-blending/children-opacity-no-overlap-expected.html: Added.
  • compositing/overlap-blending/children-opacity-no-overlap.html: Added.
  • compositing/overlap-blending/reflection-opacity-huge-expected.html: Added.
  • compositing/overlap-blending/reflection-opacity-huge.html: Added.
8:13 AM Changeset in webkit [144189] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Template element support is already enabled in

development builds. Removing skip entries for related tests as they all pass.

8:11 AM Changeset in webkit [144188] by zandobersek@gmail.com
  • 5 edits
    3 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining after r144096.

  • platform/gtk/TestExpectations:
  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/gtk/css2.1/replaced-elements-001-expected.png: Added.
  • platform/gtk/css3/flexbox/button-expected.png: Added.
  • platform/gtk/css3/flexbox/button-expected.txt: Added.
  • platform/gtk/svg/custom/foreign-object-skew-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt:
8:03 AM Changeset in webkit [144187] by jochen@chromium.org
  • 2 edits in trunk/LayoutTests

Add plugins test expectations for content_shell

Unreviewed gardening.

  • platform/chromium/ContentShellTestExpectations:
7:48 AM Changeset in webkit [144186] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] [Audits] Disabled "Run" button styling is the same as the enabled one
​https://bugs.webkit.org/show_bug.cgi?id=110971

Reviewed by Yury Semikhatsky.

Split out PanelEnablerView-related rules into panelEnabledView.css and restored the missing rules
in inspector.css.

  • inspector/front-end/inspector.css:
  • inspector/front-end/panelEnablerView.css:
7:35 AM Changeset in webkit [144185] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r144179.
​http://trac.webkit.org/changeset/144179
​https://bugs.webkit.org/show_bug.cgi?id=110980

Breaks compilation (Requested by vsevik on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-27

  • public/WebTextInputType.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::textInputInfo):
(WebKit::WebViewImpl::textInputType):

7:29 AM Changeset in webkit [144184] by tkent@chromium.org
  • 8 edits in trunk

REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator
​https://bugs.webkit.org/show_bug.cgi?id=110974

Reviewed by Kentaro Hara.

Source/WebCore:

Input elements with the multiple fields UI require flexible box
layout. We should use RenderFlexibleBox regardless of display
property values.

Tests: Update fast/forms/date/date-apparance-basic.html

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::createRenderer):
Always use RenderFlexibleBox.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Declare createRenderer.

LayoutTests:

  • fast/forms/date/date-appearance-basic-expected.txt:
  • fast/forms/date/date-appearance-basic.html:
  • platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
  • platform/chromium/TestExpectations:
7:27 AM Changeset in webkit [144183] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebCore

[TexMap] Flickering after transitions on Apple HTML5 demo
​https://bugs.webkit.org/show_bug.cgi?id=102501

Reviewed by Noam Rosenthal.

Notify about animation start after the new animation is actually commited.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
(WebCore::GraphicsLayerTextureMapper::addAnimation):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

7:11 AM Changeset in webkit [144182] by vivek.vg@samsung.com
  • 9 edits
    1 add in trunk

Web Inspector: Refactor AuditsPanel with AuditController as newly introduced entity
​https://bugs.webkit.org/show_bug.cgi?id=110866

Reviewed by Alexander Pavlov.

Source/WebCore:

AuditController is being introduced in order to follow MVC pattern with the Audits.
This is the first step about the refactoring. Moving the methods from the AuditsPanel
into AuditController would ease the event driven approach to de-couple the AuditsPanel
and the AuditLauncherView.

No new tests as code refactoring.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/AuditController.js: Added.

(WebInspector.AuditController):
(WebInspector.AuditController.prototype.ruleResultReadyCallback):
(WebInspector.AuditController.prototype.categoryDoneCallback):
(WebInspector.AuditController.prototype._executeAudit):
(WebInspector.AuditController.prototype._auditFinishedCallback):
(WebInspector.AuditController.prototype.startAuditWhenResourcesReady):
(WebInspector.AuditController.prototype.initiateAudit):
(WebInspector.AuditController.prototype._reloadResources):
(WebInspector.AuditController.prototype._didMainResourceLoad):

  • inspector/front-end/AuditLauncherView.js:

(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._startAudit):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):
(WebInspector.AuditsPanel.prototype.auditFinishedCallback):

  • inspector/front-end/WebKit.qrc:

LayoutTests:

  • inspector/extensions/extensions-audits-tests.js:
7:11 AM Changeset in webkit [144181] by schenney@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Android
​https://bugs.webkit.org/show_bug.cgi?id=110922

Unreviewed build fix.

  • tests/GIFImageDecoderTest.cpp:

(WebKit):
(WebKit::TEST): Disable the entire test on Android.

7:00 AM Changeset in webkit [144180] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
6:54 AM Changeset in webkit [144179] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Should not return WebTextInputTypeNone for date input element.
​https://bugs.webkit.org/show_bug.cgi?id=110740

Patch by Seigo Nonaka <​nona@chromium.org> on 2013-02-27
Reviewed by Kent Tamura.

In the case of Windows 8, text input state including on-screen keyboard is controlled by the
value of WebTextInputType returned from WebViewImpl::textInputType().
In past, it returned WebTextInputTypeDate for date text input but now it returns
WebTextInputTypeNone.
WebTextInputTypeNone is used for non editable node, so on-screen keyboard will be hidden if
the date text input is focused. So there is no way to input on Windows 8 tablet without
physical keyboard except tapping small up/down arrow.

  • public/WebTextInputType.h: Introduces WebTextInputTypeDateTimeField.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of editable or not. It is
safe because textInputType returns editable type only for known editable element.
(WebKit::WebViewImpl::textInputType): Returns WebTextInputTypeDateTimeField for the date
time field element.

6:50 AM Changeset in webkit [144178] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk

[CSS Regions] Region overset property is not properly computed when there is a region break
​https://bugs.webkit.org/show_bug.cgi?id=92497

Patch by Mihai Maerean <Mihai Maerean> on 2013-02-27
Reviewed by David Hyatt.

Source/WebCore:

For "paginated" content in regions that has -webkit-region-break-after:always, the bottom margin was being passed
along for the next region in the chain, which shouldn't happen.

The fix is, at layout, to clear the bottom margin for the nodes (inside paginated contexts) that have
-webkit-region-break-after:always.

Tests: fast/multicol/break-after-always-bottom-margin.html

fast/regions/overset-break-nested.html
fast/regions/overset-break-with-sibling.html
fast/regions/overset-break.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::applyAfterBreak):

LayoutTests:

  • fast/multicol/break-after-always-bottom-margin-expected.txt: Added.
  • fast/multicol/break-after-always-bottom-margin.html: Added.
  • fast/regions/overset-break-expected.txt: Added.
  • fast/regions/overset-break-nested-expected.txt: Added.
  • fast/regions/overset-break-nested.html: Added.
  • fast/regions/overset-break-with-sibling-expected.txt: Added.
  • fast/regions/overset-break-with-sibling.html: Added.
  • fast/regions/overset-break.html: Added.
6:47 AM Changeset in webkit [144177] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
6:46 AM Changeset in webkit [144176] by schenney@chromium.org
  • 2 edits in trunk/Source/WebCore

Bindings test results update after r144126
​https://bugs.webkit.org/show_bug.cgi?id=108196

Unreviewed test update.

  • bindings/scripts/test/JS/JSTestObj.cpp: Add include of CallbackFunction.h
5:49 AM Changeset in webkit [144175] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[chromium] Adapt test expectations to V8 proto changes.
​https://bugs.webkit.org/show_bug.cgi?id=110887

Patch by Michael Starzinger <​mstarzinger@chromium.org> on 2013-02-27
Reviewed by Stephen Chenney.

ad window-custom-prototype) This is expected bahavior, consistent with
SpiderMonkey. The test expectation is broken. Assigning 'null' to
'proto' makes the accessor installed on Object.prototype disappear.

ad JSON-parse) The result of JSON.parse() doesn't match the result we
get when evaluating the same string through eval() as V8 still has
special handling of the proto property for object literals.

ad cyclic-prototypes) Test fully matches the WebKit expectation now and
no longer fails. However the exception message has a slightly different
format and hence causes a text diff.

  • platform/chromium/TestExpectations: Temporary mark tests failing.
  • platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt:
  • platform/chromium/fast/js/JSON-parse-expected.txt:
  • platform/chromium/fast/js/cyclic-prototypes-expected.txt:
5:34 AM Changeset in webkit [144174] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Bug in atomicIncrement implementation for MIPS GCC
​https://bugs.webkit.org/show_bug.cgi?id=110969

Patch by Balazs Kilvady <​kilvadyb@homejinni.com> on 2013-02-27
Reviewed by Csaba Osztrogonác.

Fix of sync_[add|sub]_and_fetch_8 for GCC patch.

  • wtf/Atomics.cpp:
5:07 AM Changeset in webkit [144173] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed inspector front-end closure compilaiton fix.

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.set _fileRenamed):

4:49 AM Changeset in webkit [144172] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
4:38 AM Changeset in webkit [144171] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
4:09 AM Changeset in webkit [144170] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

REGRESSION(r137994): It made JSC tests hang and layout tests fail on ARM Thumb2 / Linux
​https://bugs.webkit.org/show_bug.cgi?id=108632

Patch by Simon Hausmann <​simon.hausmann@digia.com> on 2013-02-27
Reviewed by Csaba Osztrogonác.

It appears that mprotect() is very slow on ARM/Linux, so disable the
approach of unreserved mappings there and fall back to overcomitting
memory, based on Uli Schlachter's recommendation.

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::decommit):

4:05 AM Changeset in webkit [144169] by Bruno de Oliveira Abinader
  • 3 edits in trunk/Source/WebCore

[texmap] Do not apply clip state if redundant
​https://bugs.webkit.org/show_bug.cgi?id=110790

Reviewed by Noam Rosenthal.

Add a bool to check if clip state has changed since last apply.

No behavior changes, thus covered by existing tests.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::ClipStack::reset):
(WebCore::TextureMapperGL::ClipStack::pop):
(WebCore::TextureMapperGL::ClipStack::apply):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::TextureMapperGL::ClipStack::ClipStack):
(ClipStack):

4:05 AM Changeset in webkit [144168] by Simon Hausmann
  • 2 edits in trunk/Source/JavaScriptCore

[Qt][Mac] Fix massive parallel builds

Reviewed by Tor Arne Vestbø.

There exists a race condition that LLIntDesiredOffsets.h is written to
by two parllel instances of the ruby script. This patch ensures that similar to the output file,
the generated file is also prefixed according to the build configuration.

  • LLIntOffsetsExtractor.pro:
4:03 AM Changeset in webkit [144167] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
3:51 AM Changeset in webkit [144166] by li.yin@intel.com
  • 3 edits in trunk/LayoutTests

MediaStream constructor test should cover ended MediaStreamTrack.
​https://bugs.webkit.org/show_bug.cgi?id=110941

Reviewed by Kentaro Hara.

Spec: ​http://dev.w3.org/2011/webrtc/editor/getusermedia.html#mediastream
If tracks has ended, it should skip these tracks and continue with the next one.

  • fast/mediastream/MediaStreamConstructor-expected.txt:
  • fast/mediastream/MediaStreamConstructor.html:
3:40 AM Changeset in webkit [144165] by michael.bruning@digia.com
  • 7 edits in trunk/Source/WebKit2

[Qt][WK2] Replace use of WebPreferences with use of WKPrefences C API
​https://bugs.webkit.org/show_bug.cgi?id=108952

Reviewed by Simon Hausmann.

Signed off for WebKit2 by Benjamin Poulain.

This patch moves the view classes and preferences in the Qt API
to use the C API for accessing and manipulating preferences as
part of the cleanup and move towards using the C API as base for
the Qt WebKit2 API.

Adds the function WebKit::adoptToQString for convenience when
dealing with QString and copied String objects.

Removes the ScrollAnimatorEnabled options from QWebPreferences.

  • UIProcess/API/cpp/qt/WKStringQt.cpp:

(WebKit::adoptToQString):

  • UIProcess/API/cpp/qt/WKStringQt.h:

(WebKit):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::setFontFamily):
(QWebPreferencesPrivate::fontFamily):
(QWebPreferencesPrivate::setFontSize):
(QWebPreferencesPrivate::fontSize):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:
3:07 AM Changeset in webkit [144164] by thiago.santos@intel.com
  • 1 edit
    1 add in trunk/LayoutTests

[EFL] Unreviewed gardening

Updated tests baselines.

  • platform/efl/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
2:53 AM Changeset in webkit [144163] by mkwst@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

XHR should fire 'abort' event when navigation interrupts a request.
​https://bugs.webkit.org/show_bug.cgi?id=110867

Reviewed by Alexey Proskuryakov.

Adding a layout test to ensure that navigation-canceled XMLHttpRequests
fire an 'abort' event rather than an 'error' event.

  • http/tests/xmlhttprequest/navigation-should-abort-expected.txt: Added.
  • http/tests/xmlhttprequest/navigation-should-abort.html: Added.
2:16 AM Changeset in webkit [144162] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix after r144155. The report page is located at /api/report, not /api/test/report.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._upload_json):

2:15 AM Changeset in webkit [144161] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: timeline stops working on certain sites
​https://bugs.webkit.org/show_bug.cgi?id=110955

Reviewed by Alexander Pavlov.

Analysis: "timerId" value is number,
so it is not wrapped to node as expected.

Solution: wrap values of all types except Node.

  • inspector/front-end/TimelinePresentationModel.js:

Wrap nonstring values to text nodes.

2:03 AM Changeset in webkit [144160] by thiago.santos@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening

Mark custom elements tests as failures until we enable them.

  • platform/efl/TestExpectations:
1:22 AM Changeset in webkit [144159] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Remove test related to html5lib after r144032
​https://bugs.webkit.org/show_bug.cgi?id=110946

Unreviewed, EFL gardening.

Test was removed after r144032. And remove it from TestExpectations.
html5lib/generated/run-template.html.

Patch by Seokju Kwon <Seokju Kwon> on 2013-02-27

  • platform/efl/TestExpectations:
1:21 AM Changeset in webkit [144158] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser can trigger ASSERT(m_speculations.isEmpty())
​https://bugs.webkit.org/show_bug.cgi?id=110949

Reviewed by Eric Seidel.

We can hit this ASSERT if didReceiveParsedChunkFromBackgroundParser is
called from the background thread while we're processing
m_speculations (i.e., if processing m_speculations is taking a while
and we've yielded to the event loop).

It's hard to write a deterministic test for this patch, but it's hit
quite often with existing LayoutTests.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):

1:09 AM Changeset in webkit [144157] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Generate a wrapper function for named constructor callbacks
​https://bugs.webkit.org/show_bug.cgi?id=110794

Reviewed by Adam Barth.

This would be the final step of generating wrapper functions.
The patch generates the following wrapper function for named
constructor callbacks.

Handle<Value> namedConstructorCallback(...)
{

return namedConstructor(...);

}

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructor):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::namedConstructor):
(WebCore::namedConstructorCallback):
(WebCore):
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::namedConstructor):
(WebCore::namedConstructorCallback):
(WebCore):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):

1:02 AM Changeset in webkit [144156] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
12:56 AM Changeset in webkit [144155] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Stop uploading results to webkit-perf.appspot.com
​https://bugs.webkit.org/show_bug.cgi?id=110954

Reviewed by Benjamin Poulain.

When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
Also, always use the new JSON format. Removed the code to generate the old format.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_and_show_results):
(PerfTestsRunner._generate_results_dict):
(PerfTestsRunner._merge_slave_config_json):
(PerfTestsRunner._generate_output_files):

12:37 AM Changeset in webkit [144154] by caseq@chromium.org
  • 12 edits in trunk

Web Inspector: show raster tasks on Timeline
​https://bugs.webkit.org/show_bug.cgi?id=105851

  • add DeferPaint, Paint & RasterTask trace events handling to trace event processor;
  • upon begin frame, emit aggregated background event for all raster tasks related to inspected page.

Reviewed by Pavel Feldman.

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(InstrumentationEvents):
(InstrumentationEventArguments):

  • inspector/InspectorInstrumentation.h:

(InstrumentationEvents):
(WebCore):
(InstrumentationEventArguments):

  • inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::didBeginFrame):

  • inspector/InspectorTimelineAgent.h:

(TimelineRecordType):
(WebCore):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createRasterData):
(WebCore):

  • inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):

  • inspector/TimelineTraceEventProcessor.cpp:

(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::~TimelineTraceEventProcessor):
(WebCore):
(WebCore::TimelineTraceEventProcessor::registerHandler):
(WebCore::TimelineTraceEventProcessor::shutdown):
(WebCore::TimelineTraceEventProcessor::TraceEvent::findParameter):
(WebCore::TimelineTraceEventProcessor::TraceEvent::parameter):
(WebCore::TimelineTraceEventProcessor::processEventOnAnyThread):
(WebCore::TimelineTraceEventProcessor::onBeginFrame):
(WebCore::TimelineTraceEventProcessor::onPaintLayerBegin):
(WebCore::TimelineTraceEventProcessor::onPaintLayerEnd):
(WebCore::TimelineTraceEventProcessor::onRasterTaskBegin):
(WebCore::TimelineTraceEventProcessor::onRasterTaskEnd):
(WebCore::TimelineTraceEventProcessor::onLayerDeleted):
(WebCore::TimelineTraceEventProcessor::onPaint):
(WebCore::TimelineTraceEventProcessor::flushRasterizerStatistics):
(WebCore::TimelineTraceEventProcessor::sendTimelineRecord):
(WebCore::TimelineTraceEventProcessor::processBackgroundEvents):

  • inspector/TimelineTraceEventProcessor.h:

(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::id):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asUInt):
(TimelineTraceEventProcessor):

  • inspector/front-end/TimelineModel.js:
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel._initRecordStyles):

12:33 AM Changeset in webkit [144153] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
12:23 AM Changeset in webkit [144152] by benjamin@webkit.org
  • 12 edits in trunk/LayoutTests

Fix the tests based on computedStyleIncludingVisitedInfo for asynchronous update of the visited style
​https://bugs.webkit.org/show_bug.cgi?id=110708

Reviewed by Ryosuke Niwa.

The tests using computedStyleIncludingVisitedInfo were using the asumption that visited style
is updated synchronously with the loading of resources.
This assumption is valid for Mac WebKit1, but does not hold for multiprocess
WebKit because the list of visited URLs is maintained outside the WebProcess.

This patch changes the tests to use the 'shouldBecomeXXX' test functions in order to wait
for the asynchronous update. With the change, all the tests succeed reliably on WebKit2.

  • fast/history/multiple-classes-visited-expected.txt:
  • fast/history/multiple-classes-visited.html:
  • fast/history/nested-visited-test-expected.txt:
  • fast/history/nested-visited-test.html:
  • fast/history/self-is-visited-expected.txt:
  • fast/history/self-is-visited.html:
  • fast/history/sibling-visited-test-expected.txt:
  • fast/history/sibling-visited-test.html:
  • fast/js/resources/js-test-pre.js:

(.condition):
(.failureHandler):
(shouldBecomeDifferent):

  • platform/wk2/TestExpectations:
  • platform/chromium/TestExpectations: The tests can now also timeout due to

computedStyleIncludingVisitedInfo missing from Chromium's DRT.

12:09 AM Changeset in webkit [144151] by zandobersek@gmail.com
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed gardening.

  • platform/efl/TestExpectations: Removing expectation for html5lib/runner.html, the test was removed in r144032.
  • platform/gtk/TestExpectations: Ditto.
  • platform/gtk/http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt: Added. Required after r144105.
12:04 AM Changeset in webkit [144150] by commit-queue@webkit.org
  • 11 edits
    2 copies
    15 deletes in trunk

Unreviewed, rolling out r144136, r144143, and r144147.
​http://trac.webkit.org/changeset/144136
​http://trac.webkit.org/changeset/144143
​http://trac.webkit.org/changeset/144147
​https://bugs.webkit.org/show_bug.cgi?id=110950

Caused some timeouts and flaky crashes (Requested by abarth on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-27

Tools:

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

  • platform/chromium-mac/security/block-test-no-port-expected.txt: Copied from LayoutTests/platform/chromium/security/block-test-no-port-expected.txt.
  • platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt:
  • platform/chromium-win/http/tests/loading/redirect-methods-expected.txt:
  • platform/chromium-win/security/block-test-no-port-expected.txt: Copied from LayoutTests/platform/chromium/security/block-test-no-port-expected.txt.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/images/support-broken-image-delegate-expected.txt:
  • platform/chromium/fast/loader/main-document-url-for-non-http-loads-expected.txt: Removed.
  • platform/chromium/http/tests/loading/307-after-303-after-post-expected.txt: Removed.
  • platform/chromium/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Removed.
  • platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
  • platform/chromium/http/tests/misc/window-dot-stop-expected.txt: Removed.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt: Removed.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Removed.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Removed.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Removed.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Removed.
  • platform/chromium/inspector/debugger/pause-in-inline-script-expected.txt: Removed.
  • platform/chromium/inspector/timeline/timeline-script-tag-1-expected.txt: Removed.
  • platform/chromium/security/block-test-no-port-expected.txt:

Feb 26, 2013:

11:32 PM Changeset in webkit [144149] by Csaba Osztrogonác
  • 8 edits in trunk/LayoutTests

One more unreviewed fix after r144032 and r144051.
​https://bugs.webkit.org/show_bug.cgi?id=110734

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-26

  • TestExpectations: Unskip tests.
  • html5lib/generated/run-template-write.html: Revert an accidental change by r144051.
  • platform/gtk/TestExpectations: Skip run-template-data.html and run-template-write.html instead of run-template.html
  • platform/mac/TestExpectations: Ditto.
  • platform/qt/TestExpectations: Ditto.
  • platform/win/TestExpectations: Ditto.
  • platform/wincairo/TestExpectations: Ditto.
11:17 PM Changeset in webkit [144148] by vsevik@chromium.org
  • 6 edits in trunk/Source

Unreviewed, rolling out r144129.
​http://trac.webkit.org/changeset/144129
​https://bugs.webkit.org/show_bug.cgi?id=110947

Breaks compilation on chromium mac and win (Requested by
vsevik on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-26

Source/Platform:

  • chromium/public/WebLayerTreeViewClient.h:

(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::willBeginFrame):
(WebKit::WebLayerTreeViewClient::didBeginFrame):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::willBeginFrame):
(WebKit):
(WebKit::WebViewImpl::didBeginFrame):

  • src/WebViewImpl.h:
  • tests/WebLayerTreeViewTestCommon.h:
10:18 PM Changeset in webkit [144147] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Note another multipart failure to work through.

  • platform/chromium/TestExpectations:
10:16 PM Changeset in webkit [144146] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

getPropertyValue for -webkit-column-rule returns null, should compute the shorthand value
​https://bugs.webkit.org/show_bug.cgi?id=110698

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-02-26
Reviewed by Alexander Pavlov.

Source/WebCore:

Test: fast/css/getPropertyValue-column-rule.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

LayoutTests:

  • fast/css/getPropertyValue-column-rule-expected.txt: Added.
  • fast/css/getPropertyValue-column-rule.html: Added.
10:14 PM Changeset in webkit [144145] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

getPropertyValue for -webkit-margin-collapse returns null, should compute the shorthand value
​https://bugs.webkit.org/show_bug.cgi?id=110903

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-02-26
Reviewed by Alexander Pavlov.

Source/WebCore:

getPropertyValue("-webkit-margin-collapse") should compute shorthand value
when -webkit-margin-collapse is specified in CSS.

Test: fast/css/getPropertyValue-webkit-margin-collapse.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

LayoutTests:

Added test for getPropertyValue("-webkit-margin-collapse").

  • fast/css/getPropertyValue-webkit-margin-collapse-expected.txt: Added.
  • fast/css/getPropertyValue-webkit-margin-collapse.html: Added.
10:06 PM Changeset in webkit [144144] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

getPropertyValue for -webkit-marquee returns null, should compute the shorthand value
​https://bugs.webkit.org/show_bug.cgi?id=110816

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-02-26
Reviewed by Alexander Pavlov.

Source/WebCore:

Compute the shorthand value for '-webkit-marquee' specified in CSS.

Test: fast/css/getPropertyValue-webkit-marquee.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

LayoutTests:

Added testcases to check getPropertyValue for -webkit-marquee shorthand.

  • fast/css/getPropertyValue-webkit-marquee-expected.txt: Added.
  • fast/css/getPropertyValue-webkit-marquee.html: Added.
9:51 PM Changeset in webkit [144143] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Update expectations to show new FrameLoaderClient callbacks. I missed
this test earlier because it doesn't run on Linux.

  • platform/chromium-win/http/tests/loading/redirect-methods-expected.txt:
9:11 PM Changeset in webkit [144142] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Remove Event::dataTransferAttrGetterCustom() and Event::valueAttrSetterCustom()
​https://bugs.webkit.org/show_bug.cgi?id=110666

Reviewed by Adam Barth.

Event::dataTransferAttrGetterCustom() is not used
(i.e. the custom method is not registered to V8).
Event::valueAttrSetterCustom() is declared but not
implemented. We can remove them.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderCustomCall):

  • bindings/v8/custom/V8EventCustom.cpp:
9:02 PM Changeset in webkit [144141] by rniwa@webkit.org
  • 5 edits
    1 add in trunk

Use perf.webkit.org JSON format in results page
​https://bugs.webkit.org/show_bug.cgi?id=110842

Reviewed by Benjamin Poulain.

PerformanceTests:

Updated the results page template to use the new JSON format.

Since new JSON format doesn't contain statistics such as stdev and min, added statistics.js to compute
these values. Also use 95% percentile confidence interval instead of standard deviation in various places.

  • resources/results-template.html: Added statistics.js as dependency.

(TestResult): Updated to take a metric instead of its test. Replaced stdev() with confidenceIntervalDelta()
now that we have a fancy Statistics class.

(TestRun.webkitRevision):
(PerfTestMetric): Renamed from PerfTest since this object now encapsulates each measurement (such as time,
JS heap, and malloc) in test. Also added a conversion table from a metric name to a unit since new format
doesn't contain units.
(PerfTestMetric.name): Updated to compute the full metric name from test name and metric name, matching
the old behavior.
(PerfTestMetric.isMemoryTest): Explicitly look for 'JSHeap' and 'Malloc' tests.
(PerfTestMetric.smallerIsBetter):

(attachPlot): Deleted the code to deal with tests that don't provide individual iteration measurement
since such tests no longer exist. Also fixed up the code compute y-axis range.

(createTableRow.markupForRun): Updated to use confidenceIntervalDelta() instead of stdev().

(init.addTests): Added. Recursively add metrics.

  • resources/statistics.js: Added. Imported from perf.webkit.org.

(Statistics.max):
(Statistics.min):
(Statistics.sum):
(Statistics.squareSum):
(Statistics.sampleStandardDeviation):
(Statistics.supportedConfidenceLevels):
(Statistics.confidenceIntervalDelta):
(Statistics.confidenceInterval):

Tools:

Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.

A whole bunch of integration tests have been updated to use the new JSON format.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
and legacy_output_json_path respectively.
(PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
(PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
JSON file and the results page out of perf_webkit_output instead of legacy_output.

  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:

(MainTest.test_run_memory_test):
(MainTest._test_run_with_json_output.mock_upload_json):
(MainTest):
(MainTest.test_run_with_json_output):
(MainTest.test_run_with_description):
(MainTest.test_run_generates_json_by_default):
(MainTest.test_run_merges_output_by_default):
(MainTest.test_run_respects_reset_results):
(MainTest.test_run_generates_and_show_results_page):
(MainTest.test_run_with_slave_config_json):
(MainTest.test_run_with_multiple_repositories):
(MainTest.test_run_with_upload_json):
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):

8:34 PM Changeset in webkit [144140] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

SelectorQuery should not ever use ResolvingStyle mode.
​https://bugs.webkit.org/show_bug.cgi?id=110843

It looks like we accidentally used ResolvingStyle mode for webkitMatchesSelector, and I exacerbated the problem
in r143858 by switching all of SelectorQuery to use it. There aren't any visible effects, but the style bits
of elements are unnecessarily twiddled when if we do that. Let's not do it.

Reviewed by Eric Seidel.

No public-facing behavior change, covered by existing tests.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorMatches): Switched to always use QueryingRules mode.

8:32 PM Changeset in webkit [144139] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Silence this ASSERT. It is triggered by the threaded HTML parser.
Investigation to follow in ​https://bugs.webkit.org/show_bug.cgi?id=110937

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::checkLoadComplete):

8:26 PM Changeset in webkit [144138] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r184829. Requested by
"Mark Pilgrim" <​pilgrim@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-26

  • DEPS:
7:52 PM Changeset in webkit [144137] by fpizlo@apple.com
  • 15 edits
    3 adds in trunk

DFG OSR exit doesn't know which virtual register to use for the last result register for post_inc and post_dec
​https://bugs.webkit.org/show_bug.cgi?id=109036
<rdar://problem/13292139>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

This was a two-fold problem:

1) post_inc/dec has two results - the new value of the variable, and the old value of the variable. DFG OSR exit

assumed that the "last result" used for the Baseline JIT's register allocation would be the new value. It was
wrong in this assumption.


2) The Baseline JIT knew to disable its last result optimization in cases where it might confuse the DFG. But it

was doing this only for code blocks that could be totally optimized, but not code blocks that could only be
optimized when inlined.


This patch introduces a more rigorous notion of when the Baseline JIT emits profiling, when it does extra work
to account for the possibility of OSR exit, and when it does extra work to account for the possibility of OSR
entry. These notions are called shouldEmitProfiling(), canBeOptimizedOrInlined(), and canBeOptimized(),
respectively.

This is performance-neutral and fixes the reported bug. It probably fixes other bugs as well, since previously
we for example weren't doing the more conservative implementation of op_mov in the Baseline JIT for code blocks
that could be inlined but not optimized. So, if such a code block OSR exited at just the right point, you'd get
symptoms similar to this bug.

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGCommon.h:
  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::JIT::compilePatchGetArrayLength):
(JSC::JIT::canBeOptimizedOrInlined):
(JIT):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):

  • jit/JITCall.cpp:

(JSC::JIT::emit_op_call_put_result):
(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITInlines.h:

(JSC::JIT::emitArrayProfilingSite):
(JSC::JIT::map):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_mov):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::privateCompilePutByIdTransition):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::privateCompilePutByIdTransition):

LayoutTests:

Reviewed by Gavin Barraclough.

  • fast/js/dfg-post-inc-then-exit-expected.txt: Added.
  • fast/js/dfg-post-inc-then-exit.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-post-inc-then-exit.js: Added.

(foo):

7:00 PM Changeset in webkit [144136] by abarth@webkit.org
  • 10 edits
    16 adds
    2 deletes in trunk

[Chromium] Enable threaded HTML parser by default in DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=110907

Reviewed by Eric Seidel.

Tools:

This patch changes --enable-threaded-html-parser into
--disable-threaded-html-parser and thereby enables the threaded HTML
parser by default for the Chromium port.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:
  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

Update test results to show subtle differences in FrameLoaderClient callbacks.

  • platform/chromium-mac/security/block-test-no-port-expected.txt: Removed.
  • platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt:
  • platform/chromium-win/security/block-test-no-port-expected.txt: Removed.
  • platform/chromium/fast/images/support-broken-image-delegate-expected.txt:
  • platform/chromium/fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
  • platform/chromium/http/tests/loading/307-after-303-after-post-expected.txt: Added.
  • platform/chromium/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
  • platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
  • platform/chromium/http/tests/misc/window-dot-stop-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
  • platform/chromium/inspector/debugger/pause-in-inline-script-expected.txt: Added.
  • platform/chromium/inspector/timeline/timeline-script-tag-1-expected.txt: Added.
  • platform/chromium/security/block-test-no-port-expected.txt:
6:51 PM Changeset in webkit [144135] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebCore

SQLTransactionBackend::doCleanup() should not nullify its current
statement and transaction error fields.
​https://bugs.webkit.org/show_bug.cgi?id=110826.

Reviewed by Geoffrey Garen.

The reason for this is because the frontend SQLTransaction may have
tasks that are already registered via callOnMainThread(), and may
invoke transaction state functions that access these objects in the
SQLTransactionBackend. This proves to be problematic if the database
was interrupted resulting in doCleanup() being called concurrently
while those states are executing.

Instead, we leave their clean up to the SQLTransactionBackend destructor
which is guaranteed to only be called when the SQLTransaction is also
destructing i.e. these objects are no longer needed.

No new tests.

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::doCleanup):

6:40 PM Changeset in webkit [144134] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Crashes in fast/notifications/notifications-request-permission.html after r144126
​https://bugs.webkit.org/show_bug.cgi?id=108196

Unreviewed expectations update.

  • platform/chromium/TestExpectations:
6:34 PM Changeset in webkit [144133] by schenney@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Deleting extraneous baseline after feDisplacementMap fix
​https://bugs.webkit.org/show_bug.cgi?id=10592

Unreviewed expectations update. Slow build bot to blame.

  • platform/chromium-win-xp/svg/filters/feDisplacementMap-expected.png: Removed.
6:04 PM Changeset in webkit [144132] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. AppleWin VS2010 build fix.

  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
5:45 PM Changeset in webkit [144131] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

The DFG backend's and OSR's decision to unbox a variable should be based on whether it's used in a typed context
​https://bugs.webkit.org/show_bug.cgi?id=110433

Reviewed by Oliver Hunt and Mark Hahnenberg.

This introduces the equivalent of a liveness analysis, except for type checking.
A variable is said to be "profitable for unboxing" (i.e. live at a type check)
if there exists a type check on a GetLocal of that variable, and the type check
is consistent with the variable's prediction. Variables that are not profitable
for unboxing aren't unboxed. Previously they would have been.

This is a slight speed-up on some things but mostly neutral.

  • dfg/DFGArgumentPosition.h:

(JSC::DFG::ArgumentPosition::ArgumentPosition):
(JSC::DFG::ArgumentPosition::mergeShouldNeverUnbox):
(JSC::DFG::ArgumentPosition::mergeArgumentPredictionAwareness):
(JSC::DFG::ArgumentPosition::mergeArgumentUnboxingAwareness):
(ArgumentPosition):
(JSC::DFG::ArgumentPosition::isProfitableToUnbox):
(JSC::DFG::ArgumentPosition::shouldUseDoubleFormat):

  • dfg/DFGCommon.h:

(JSC::DFG::checkAndSet):
(DFG):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(FixupPhase):
(JSC::DFG::FixupPhase::alwaysUnboxSimplePrimitives):
(JSC::DFG::FixupPhase::setUseKindAndUnboxIfProfitable):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsCaptured):
(JSC::DFG::VariableAccessData::mergeIsProfitableToUnbox):
(VariableAccessData):
(JSC::DFG::VariableAccessData::isProfitableToUnbox):
(JSC::DFG::VariableAccessData::shouldUnboxIfPossible):
(JSC::DFG::VariableAccessData::mergeStructureCheckHoistingFailed):
(JSC::DFG::VariableAccessData::mergeIsArgumentsAlias):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::mergeFlags):

5:20 PM Changeset in webkit [144130] by andersca@apple.com
  • 7 edits in trunk/Source

Implement StorageAreaProxy::getItem and StorageAreaProxy::setItem
​https://bugs.webkit.org/show_bug.cgi?id=110927

Reviewed by Sam Weinig.

Source/WebCore:

Export StorageMap::getItem and StorageMap::setItem.

  • WebCore.exp.in:

Source/WebKit2:

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::setItem):

  • UIProcess/Storage/StorageManager.h:

Add empty stub.

  • UIProcess/Storage/StorageManager.messages.in:

Add SetItem message.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::getItem):
Fill the storage map and get the item from it.

(WebKit::StorageAreaProxy::setItem):
Update the storage map and send a SetItem message to the UI process.

5:09 PM Changeset in webkit [144129] by jamesr@google.com
  • 6 edits in trunk/Source

[chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
​https://bugs.webkit.org/show_bug.cgi?id=110928

Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebLayerTreeViewClient.h:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
  • tests/WebLayerTreeViewTestCommon.h:
5:05 PM Changeset in webkit [144128] by adamk@chromium.org
  • 4 edits
    5 adds in trunk

Parsing of HTML tags in MathML Text Insertion Points leads to bogus parser behavior
​https://bugs.webkit.org/show_bug.cgi?id=110808

Reviewed by Adam Barth.

Source/WebCore:

When looking for various table tags in the HTMLElementStack, compare
QualifiedNames rather than just local names, where necessary.

Note that not all uses have been "fixed"; I've only changed for which
I could write a test with differing behavior. A followup patch to
rationalize the use of QualifiedName vs local names would be ideal.

Tests: html5lib/generated/run-math-data.html

html5lib/generated/run-math-write.html

  • html/parser/HTMLElementStack.cpp:

(WebCore::inScopeCommon): Added a version of inScopeCommon that
handles QualifiedNames instead of just localNames.
(WebCore::HTMLElementStack::inTableScope): When given a QualifiedName,
call the new version of inScopeCommon().

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):

LayoutTests:

  • html5lib/generated/run-math-data-expected.txt: Added.
  • html5lib/generated/run-math-data.html: Added.
  • html5lib/generated/run-math-write-expected.txt: Added.
  • html5lib/generated/run-math-write.html: Added.
  • html5lib/resources/math.dat: Added.
5:01 PM Changeset in webkit [144127] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix windows build.

4:52 PM Changeset in webkit [144126] by Kaustubh Atrawalkar
  • 14 edits
    2 adds
    2 deletes in trunk

Notification.requestPermission callback should be optional
​https://bugs.webkit.org/show_bug.cgi?id=108196

Reviewed by Adam Barth.

Source/WebCore:

Spec says it should be optional.
​http://notifications.spec.whatwg.org/#notification

Test: fast/notifications/notifications-request-permission-optional.html

  • GNUmakefile.list.am:
  • Modules/notifications/Notification.h:

(Notification):

  • Modules/notifications/Notification.idl:
  • Target.pri:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSNotificationCustom.cpp: Removed.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/v8/custom/V8NotificationCustom.cpp: Removed.

LayoutTests:

Specs says it should be optional.
​http://notifications.spec.whatwg.org/#notification

  • fast/notifications/notifications-request-permission-optional-expected.txt: Added.
  • fast/notifications/notifications-request-permission-optional.html: Added.
4:45 PM Changeset in webkit [144125] by jsbell@chromium.org
  • 3 edits
    1 add in trunk/Source/WebCore

IndexedDB: Add temporary diagnostic code to IDBRequest.result getter
​https://bugs.webkit.org/show_bug.cgi?id=110916

Reviewed by Kentaro Hara.

Implement a custom getter for IDBRequest.result that does one additional hidden
property set, to try and isolate the flaky crash seen in wkbug.com/105363 which is
difficult to repro locally. If the crash moves to the new line it will point
the investigation in a new direction. Also add an assertion that probes string
wrappers (the expected type).

  • Modules/indexeddb/IDBRequest.idl: Mark attribute as [Custom]
  • WebCore.gypi: New file.
  • bindings/v8/custom/V8IDBRequestCustom.cpp: Added.

(WebCore::V8IDBRequest::resultAttrGetterCustom): Implementation - copy/paste from
generated code, plus extra setNamedHiddenReference call and string ASSERT.

4:44 PM Changeset in webkit [144124] by hclam@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Android
​https://bugs.webkit.org/show_bug.cgi?id=110922

Unreviewed. Build fix.

  • tests/GIFImageDecoderTest.cpp:

(WebKit):

4:42 PM Changeset in webkit [144123] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] TestExpectations addition

Unreviewed addition of fast/js/regress/inlined-put-by-id-transition.html which crashes occasionally.

  • platform/chromium/TestExpectations:
4:38 PM Changeset in webkit [144122] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Web Inspector: REGRESSION: [JSC] SourceProvider reuses IDs
​https://bugs.webkit.org/show_bug.cgi?id=99674

Reviewed by Gavin Barraclough.

Simple incrementing counter for SourceProvider IDs. Uses a
lock to incrementing the counter so we don't increment reuse
counter values or reassign the ID for a given SourceProvider.

  • parser/SourceProvider.cpp:

(JSC::SourceProvider::SourceProvider):
(JSC):
(JSC::SourceProvider::getID):

  • parser/SourceProvider.h:

(JSC::SourceProvider::asID):
(SourceProvider):

4:34 PM Changeset in webkit [144121] by schenney@chromium.org
  • 50 edits
    3 deletes in trunk/LayoutTests

New baselines after feDisplacementMap fix
​https://bugs.webkit.org/show_bug.cgi?id=10592

Unreviewed expectations update.

  • platform/chromium-linux-x86/svg/filters/feDisplacementMap-expected.png: Removed.
  • platform/chromium-linux/svg/filters/feDisplacementMap-expected.png: Removed.
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feDisplacementMap-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac/svg/filters/feDisplacementMap-expected.png:
  • platform/chromium-mac/svg/filters/filterRes-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-win/svg/filters/feDisplacementMap-expected.png:
  • platform/chromium-win/svg/filters/filterRes-expected.png:
  • platform/chromium/TestExpectations:
4:31 PM Changeset in webkit [144120] by jamesr@google.com
  • 6 edits in trunk/Source

[chromium] Remove unused WebLayerTreeViewClient calls
​https://bugs.webkit.org/show_bug.cgi?id=110923

Reviewed by Adrienne Walker.

These notifications existed for instrumentation, but now the instrumentation routes
through WebDevToolsAgent.

Source/Platform:

  • chromium/public/WebLayerTreeViewClient.h:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
  • tests/WebLayerTreeViewTestCommon.h:
4:28 PM Changeset in webkit [144119] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Add a couple of symbols needed by WebKit2.

  • WebCore.exp.in:
4:19 PM Changeset in webkit [144118] by Michelangelo De Simone
  • 4 edits
    4 adds in trunk

[CSS Shaders] Implement color and luminosity non-separable blend modes
​https://bugs.webkit.org/show_bug.cgi?id=106226

Source/WebCore:

Added the following GLSL helper functions to the CustomFilterValidatedProgram:

  • css_Lum(C): returns the luminosity for the color C
  • css_ClipColor(C): clips color C
  • css_SetLum(C, l): sets the luminosity l on the color C

The above functions are being used for the "color" and "luminosity" non-separable
blend modes, the relevant spec for such modes is at URL:
​https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnonseparable

Reviewed by Dean Jackson.

Tests: css3/filters/custom/custom-filter-nonseparable-blend-mode-color.html

css3/filters/custom/custom-filter-nonseparable-blend-mode-luminosity.html

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::blendFunctionString):

LayoutTests:

Added relevant tests for the "color" and "luminosity" non-separable blend modes.
These tests are currently skipped on Mac due to a slight color difference; please
see relevant bug: ​http://webkit.org/b/107487.

Reviewed by Dean Jackson.

  • css3/filters/custom/custom-filter-nonseparable-blend-mode-color-expected.html: Added.
  • css3/filters/custom/custom-filter-nonseparable-blend-mode-color.html: Added.
  • css3/filters/custom/custom-filter-nonseparable-blend-mode-luminosity-expected.html: Added.
  • css3/filters/custom/custom-filter-nonseparable-blend-mode-luminosity.html: Added.
4:13 PM Changeset in webkit [144117] by andersca@apple.com
  • 5 edits in trunk/Source

StorageAreaProxy should hold on to a StorageMap and not a HashMap
​https://bugs.webkit.org/show_bug.cgi?id=110919

Reviewed by Jessie Berlin.

Source/WebCore:

StorageMap should be a private header.

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Create a storage map instead of a hash map.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::length):
(WebKit::StorageAreaProxy::loadValuesIfNeeded):

  • WebProcess/Storage/StorageAreaProxy.h:

(WebCore):
(StorageAreaProxy):

3:43 PM Changeset in webkit [144116] by dpranke@chromium.org
  • 4 edits in trunk

[chromium] Re-enable the fixed version of freetype on linux
​https://bugs.webkit.org/show_bug.cgi?id=110542

Reviewed by Tony Chang.

Tools:

Re-land the change in r143794 to switch to building with a fixed
version of FreeType for just DumpRenderTree. This allows us to share
one version of pixel baselines for both Lucid and Precise, and run the
layout tests in a stock Precise install (instead of a Lucid chroot).
Going forward, this approach isolates us from os-level changes to the
version of FreeType. Note that Chromium itself still uses the system
FreeType and is unaffected by this change.

This setting can still be turned off (at compile/gyp-time) by
manually setting use_custom_freetype=0.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

LayoutTests:

Re-add entries for two tests that pass on Lucid but fail on Precise
even with the Freetype change. This isn't worth adding in
Lucid and Precise keywords for just these two tests.

  • platform/chromium/TestExpectations:
3:18 PM Changeset in webkit [144115] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r183905 -> r184646.

Unreviewed.

  • DEPS:
3:06 PM Changeset in webkit [144114] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a copy/paste error in WebLoaderClient::didBlockInsecurePluginVersion
​https://bugs.webkit.org/show_bug.cgi?id=110914
<rdar://problem/13297581>

Reviewed by Beth Dakin.

Pass kWKErrorCodeInsecurePlugInVersion to the pluginDidFail callback.

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):

2:57 PM Changeset in webkit [144113] by commit-queue@webkit.org
  • 14 edits
    1 delete in trunk/Source/JavaScriptCore

Unreviewed, rolling out r144074.
​http://trac.webkit.org/changeset/144074
​https://bugs.webkit.org/show_bug.cgi?id=110897

Causing 20+ crashes on Mac (Requested by bradee-oh on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-26

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/PropertyMapHashTable.h:

(PropertyTable):
(JSC::PropertyTable::PropertyTable):
(JSC):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::copy):

  • runtime/PropertyTable.cpp: Removed.
  • runtime/Structure.cpp:

(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
(JSC::Structure::visitChildren):

  • runtime/Structure.h:

(JSC):
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):
(Structure):

  • runtime/StructureInlines.h:
2:49 PM Changeset in webkit [144112] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Remove unused WebWidget::instrument calls
​https://bugs.webkit.org/show_bug.cgi?id=110906

Patch by James Robinson <​jamesr@chromium.org> on 2013-02-26
Reviewed by Jochen Eisinger.

These calls are now routed through WebDevToolsAgent.

  • public/WebWidget.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::willBeginFrame):

  • src/WebViewImpl.h:
2:40 PM Changeset in webkit [144111] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. AppleWin VS2010 build fix.

  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props:
2:33 PM Changeset in webkit [144110] by schenney@chromium.org
  • 24 edits
    4 adds in trunk

feDisplacementMap filter gets color space wrong
​https://bugs.webkit.org/show_bug.cgi?id=105929

Reviewed by Dirk Schulze.

Source/WebCore:

Tests: svg/filters/feDisplacementMap-color-interpolation-filters-expected.svg

svg/filters/feDisplacementMap-color-interpolation-filters.svg
svg/filters/feDisplacementMap-filterUnits-expected.svg
svg/filters/feDisplacementMap-filterUnits.svg

According to the spec, the SVG feDisplacementMap filter should not
change the color space on its first input, and other vendors seem to
agree that this also means that the output should be in the first
input's color space. That makes sense: we are displacing the input,
not otherwise manipulating colors.

This change improves color space handling for filters by more
explicitly tracking which color space is used for the filter's
operation and which is used for the filter's result. It provides a
means for filter effects to override the color-interpolation-filters
property as defined by the spec. feFlood and feDisplacementMap use
this new feature to enforce the spec requirements.

  • platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::setResultColorSpace): Override the default color space with the

same color space as the first input filter.

(WebCore):
(WebCore::FEDisplacementMap::transformResultColorSpace): Only transform the color space on

the second filter input.

(WebCore::FEDisplacementMap::platformApplySoftware): Make the application code more efficient,

and give slightly better numerical accuracy.

  • platform/graphics/filters/FEDisplacementMap.h:

(FEDisplacementMap): Declare setResultColorSpace.

  • platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::platformApplySoftware): Remove the call that forces

the result color space. We do it now in the setResultColorSpace.

  • platform/graphics/filters/FEFlood.h:

(FEFlood): Add setResultColorSPace override that enforces sRGB color space. But not if using

CG, which apparently does this this already internally.

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::FilterEffect): Rename m_colorSpace to m_operatingColorSpace.
(WebCore::FilterEffect::apply): Allow filter effects to

override the color space conversion of their inputs.

(WebCore::FilterEffect::createImageBufferResult): Always create the

image buffer with the result color space.

  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::operatingColorSpace): New accessor.
(WebCore::FilterEffect::setOperatingColorSpace): New accessor.
(WebCore::FilterEffect::resultColorSpace): New accessor.
(WebCore::FilterEffect::setResultColorSpace): New accessor.
(FilterEffect):
(WebCore::FilterEffect::transformResultColorSpace): A new virtual

method that allows filter effects individual control over the color
space conversion of their inputs.

  • platform/graphics/filters/SourceGraphic.h:

(WebCore::SourceGraphic::SourceGraphic): Variable rename.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build): Use accessors to set color

space to enable per-effect overrides.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives): Use accessors to set color.

LayoutTests:

Add two new feDisplacementMap tests to get better coverage. And update some results.

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-linux/svg/filters/feDisplacementMap-expected.png:
  • platform/chromium-linux/svg/filters/filterRes-expected.png:
  • svg/filters/feDisplacementMap-color-interpolation-filters-expected.svg: Added.
  • svg/filters/feDisplacementMap-color-interpolation-filters.svg: Added.
  • svg/filters/feDisplacementMap-filterUnits-expected.svg: Added.
  • svg/filters/feDisplacementMap-filterUnits.svg: Added.
2:29 PM Changeset in webkit [144109] by roger_fong@apple.com
  • 4 edits in trunk/Source/WebKit

Unreviewed AppleWin build fix following r143996.

  • WebKit.vcproj/WebKitExportGeneratorCommon.vsprops:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorCommon.props:
2:21 PM Changeset in webkit [144108] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 143454
BUG=176738
Review URL: ​https://codereview.chromium.org/12334104

2:15 PM Changeset in webkit [144107] by jschuh@chromium.org
  • 1 edit in branches/chromium/1410/Source/WebCore/rendering/RenderArena.cpp

Merge 143811
BUG=webkit.org/b/110394
TBR=​jschuh@chromium.org
Review URL: ​https://codereview.chromium.org/12321148

2:13 PM Changeset in webkit [144106] by jschuh@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/rendering/RenderArena.cpp

Merge 143811
BUG=webkit.org/b/110394
TBR=​jschuh@chromium.org
Review URL: ​https://codereview.chromium.org/12334103

2:00 PM Changeset in webkit [144105] by mkwst@chromium.org
  • 4 edits
    3 adds in trunk

X-Frame-Options should accept ALLOWALL as a valid value.
​https://bugs.webkit.org/show_bug.cgi?id=110857

Reviewed by Adam Barth.

Source/WebCore:

DoubleClick, among others, serves ALLOWALL as a 'X-Frame-Options' value
with the intent of (shock!) allowing a resource to be framed by all
origins. Given its prevelance, and the fact that IE supports the header,
we shouldn't call it out as invalid.

This patch tweaks the warning logic to only throw the warning if the
header's value isn't 'ALLOWALL', 'DENY', or 'SAMEORIGIN'.

Test: http/tests/security/XFrameOptions/x-frame-options-allowall.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):

LayoutTests:

  • http/tests/security/XFrameOptions/resources/x-frame-options-allowall.cgi: Added.
  • http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-allowall.html: Added.

Exciting new test!

  • http/tests/security/XFrameOptions/x-frame-options-cached-expected.txt:

Exciting new baseline for an old test that was already using ALLOWALL!

1:58 PM Changeset in webkit [144104] by tony@chromium.org
  • 5 edits
    2 adds in trunk

CSS Flexbox: dynamically applied align-items doesn't affect item alignment
​https://bugs.webkit.org/show_bug.cgi?id=110341

Reviewed by Ojan Vafai.

Source/WebCore:

If flex items don't change width, we don't lay them out again. This causes problems
when an item goes from stretch to non-stretch since we need to relayout to get the
smaller height. Fix this by marking flex items that were stretch as needing layout.

Test: css3/flexbox/relayout-align-items.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::resolveAlignment): Pull out common code for computing flex item style.
(WebCore::RenderFlexibleBox::styleDidChange): Mark children as needing layout.
(WebCore::RenderFlexibleBox::alignmentForChild): Use resolveAlignment.

  • rendering/RenderFlexibleBox.h:

LayoutTests:

Also fix a typo causing align-self-* classes from not applying. There
was only one test that tried to use the align-self classes and it was
testing all values behaved the same.

  • css3/flexbox/relayout-align-items-expected.txt: Added.
  • css3/flexbox/relayout-align-items.html: Added.
  • css3/flexbox/resources/flexbox.css:

(.align-self-auto):
(.align-self-flex-start):
(.align-self-flex-end):
(.align-self-center):
(.align-self-baseline):
(.align-self-stretch):

1:54 PM Changeset in webkit [144103] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

StorageMap can just import an entire map of items at once
​https://bugs.webkit.org/show_bug.cgi?id=110904

Reviewed by Beth Dakin.

Instead of iterating over the map inside StorageAreaSync, just pass it directly
(through StorageAreaImpl) to StorageMap and iterate over it there.

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::importItems):

  • storage/StorageAreaImpl.h:

(StorageAreaImpl):

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::performImport):

  • storage/StorageMap.cpp:

(WebCore::StorageMap::importItems):

  • storage/StorageMap.h:

(StorageMap):

1:40 PM Changeset in webkit [144102] by Lucas Forschler
  • 8 edits in tags/Safari-537.31.10/Source

Merged r144091. <rdar://problem/13254985>

1:40 PM Changeset in webkit [144101] by Vineet
  • 6 edits in trunk/Source/WebCore

[JSC] static methods with Callback should not have this pointer
​https://bugs.webkit.org/show_bug.cgi?id=110846

Reviewed by Kentaro Hara.

Fixing the JSC Codegenerator not to use 'this' pointer in static methods.

No new tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackArg):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::staticMethodWithCallbackAndOptionalArgMethod):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::staticMethodWithCallbackAndOptionalArgMethodCallback):
(WebCore::TestObjV8Internal::staticMethodWithCallbackArgMethod):
(WebCore::TestObjV8Internal::staticMethodWithCallbackArgMethodCallback):
(WebCore::ConfigureV8TestObjTemplate):

1:38 PM Changeset in webkit [144100] by hclam@chromium.org
  • 7 edits
    2 adds in trunk/Source

GIFImageReader to read from source data directly
​https://bugs.webkit.org/show_bug.cgi?id=109662

Reviewed by Stephen White.

Source/WebCore:

This is the first patch to improve GIF image decoding.

GIFImageReader has an internal 256 bytes buffer to saving incoming
bytes. This mechanism is out-dated because WebKit holds the entire
file in memory and it is not necessary to hold data in an intermediate
buffer.

This is also a blocker for later work to parse and decode GIF
incrementally.

This change removed the imtermediate 'hold' buffer and uses an index
for data position to keep track of parsing of the GIF file. Buffer for
global colormap and local colormap are also removed because they can be
referenced from the data stream.

This change is tested by:

Layout tests
All tests passed under fast/images.

Unit tests
Added GIFImageDecoderTest for Chromium.

Local testing
I tested this implementation against a set of 50k GIF images and
there's no crashes and produces bit-exact results as previous code.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::decode):

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::doLZW):
(GIFImageReader::decode):
(GIFImageReader::decodeInternal):
(GIFImageReader::setRemainingBytes):

  • platform/image-decoders/gif/GIFImageReader.h:

(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFImageReader::GIFImageReader):
(GIFImageReader::~GIFImageReader):
(GIFImageReader::setData):
(GIFImageReader):
(GIFImageReader::globalColormap):
(GIFImageReader::localColormap):
(GIFImageReader::localColormapSize):
(GIFImageReader::data):
(GIFImageReader::colormap):

Source/WebKit/chromium:

Added the following unit tests to test new logic in GIFImageDecoder:

GIFImageDecoderTest.decodeTwoFrames
Test that it can decode a multi-frame GIF image correctly.

GIFImageDecoderTest.parseAndDecode
First perform a parse operation and then a decode operation. Expect
that parse and decode operates correctly.

GIFImageDecoderTest.parseByteByByte
Test that multi-frame GIF image can be parsed correctly byte by byte.

GIFImageDecoderTest.parseAndDecodeByteByByte
Run a loop to feed decoder byte by byte, perform a parse and then
decode operation and make sure frames are decoded correctly.

GIFImageDecoderTest.brokenSecondFrame
Decode a GIF image with second frame broken. Expect that the first
frame can be decoded correctly.

  • WebKit.gypi:
  • tests/GIFImageDecoderTest.cpp: Added.

(WebKit):
(WebKit::readFile):
(WebKit::TEST):

  • tests/data/broken.gif: Added.
1:35 PM Changeset in webkit [144099] by Lucas Forschler
  • 10 edits in tags/Safari-537.31.10/Source

Merged r143984. <rdar://problem/13254985>

1:12 PM Changeset in webkit [144098] by Lucas Forschler
  • 2 edits in tags/Safari-537.31.10/Source/JavaScriptCore

Merged r143509. <rdar://problem/13254985>

1:09 PM Changeset in webkit [144097] by Lucas Forschler
  • 6 edits
    2 copies in tags/Safari-537.31.10/Source/WebCore

Merged r143259. <rdar://problem/13254985>

1:08 PM Changeset in webkit [144096] by commit-queue@webkit.org
  • 17 edits
    5 adds in trunk

Empty <button>s should collapse; empty <input type="button"> should not collapse
​https://bugs.webkit.org/show_bug.cgi?id=110654

Patch by Christian Biesinger <​cbiesinger@chromium.org> on 2013-02-26
Reviewed by Ojan Vafai.

Source/WebCore:

This patch also fixes other height computation issues with flex boxes
related to scroll bars and hasLineIfEmpty()=true. See below for
details.

Tests: css3/flexbox/button.html

css3/flexbox/position-absolute-child-with-contenteditable.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock): Add a FIXME to make
border/padding/scrollbar inclusion more consistent with other
renderers.

  • rendering/RenderButton.h:

(WebCore::RenderButton::hasLineIfEmpty): We only want a line for
<input type=button|submit|reset>, for consistency with Firefox.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock): Start out layoutBlock by
setting the logical height to border + padding + scrollbar height to
ensure that we have space for the scrollbar even without children. The
layoutFlexItems change below is not enough because we also need this
when hasLineIfEmpty() is false.
(WebCore::RenderFlexibleBox::layoutFlexItems): Ensure we have a line
when hasLineIfEmpty() is true by calling setLogicalHeight(border+
padding+scrollbar+lineHeight()) if we don't have a flex line.

LayoutTests:

  • css3/flexbox/button-expected.png: Added.
  • css3/flexbox/button-expected.txt: Added.
  • css3/flexbox/button.html: Added.

Test empty buttons, <input type=button>, and buttons with
overflow:scroll;

  • css3/flexbox/position-absolute-child-with-contenteditable-expected.html: Added.
  • css3/flexbox/position-absolute-child-with-contenteditable.html: Added.

Test flex boxes with hasLineIfEmpty()=true and absolute positioned
children. Uses contenteditable=true to get that effect.

  • platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-linux/svg/custom/foreign-object-skew-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.txt:

Regenerate test cases that use <input type=button>.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:

Mark tests for rebaselining.

1:07 PM Changeset in webkit [144095] by Lucas Forschler
  • 7 edits in tags/Safari-537.31.10/Source/WebCore

Merged r143072. <rdar://problem/13254985>

1:04 PM Changeset in webkit [144094] by Lucas Forschler
  • 10 edits in tags/Safari-537.31.10

Merged r142918. <rdar://problem/13254985>

1:01 PM Changeset in webkit [144093] by Lucas Forschler
  • 5 edits in tags/Safari-537.31.10/Source/WebCore

Merged r142819. <rdar://problem/13254985>

12:52 PM Changeset in webkit [144092] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r143941.
​http://trac.webkit.org/changeset/143941
​https://bugs.webkit.org/show_bug.cgi?id=110901

This is a step in the wrong direction as it ties us to what
grid-{row|column} expect (see
​https://bugs.webkit.org/show_bug.cgi?id=110777 for the right
direction) (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-26

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridPosition):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/StyleResolver.cpp:

(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::autoPlacementMajorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMinorAxisPositionForChild):

  • rendering/RenderGrid.h:
  • rendering/style/GridPosition.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleGridItemData.h:

(StyleGridItemData):

12:51 PM Changeset in webkit [144091] by jer.noble@apple.com
  • 8 edits in trunk/Source

Unreviewed build fix; use correct macro for platform name in FeatureDefines.xcconfig.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
12:48 PM Changeset in webkit [144090] by Lucas Forschler
  • 10 edits in tags/Safari-537.31.10/Source

Merged r144067. <rdar://problem/13250271>

12:44 PM Changeset in webkit [144089] by cevans@google.com
  • 3 edits in branches/chromium/1364/Source

Merge 143347
BUG=174627
Review URL: ​https://codereview.chromium.org/12310146

12:36 PM Changeset in webkit [144088] by Lucas Forschler
  • 6 edits in tags/Safari-537.31.10/Source

Merged r143650. <rdar://problem/13250271>

12:33 PM Changeset in webkit [144087] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.10/Source

Versioning.

12:28 PM Changeset in webkit [144086] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.10

New Tag.

12:13 PM Changeset in webkit [144085] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Animated images not animating on accelerated compositing layers
​https://bugs.webkit.org/show_bug.cgi?id=110886

Patch by Andrew Lo <​anlo@rim.com> on 2013-02-26
Reviewed by Rob Buis.

Internally reviewed by Arvid Nilsson.
Internal PR 299598.

Animated images on AC layers call GraphicsLayer::setContentsToImage
on each frame with the same Image.

We need to set needs display in that case so that the frames are
displayed.

No new tests are needed since there is no new functionality.

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::setContents):

11:48 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas
(diff)
11:43 AM Changeset in webkit [144084] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r144065.
​http://trac.webkit.org/changeset/144065
​https://bugs.webkit.org/show_bug.cgi?id=110896

Causing failures and crashes on Chromium Win7 and Win XP
(Requested by schenney on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-26

Source/WebCore:

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::normalizeCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:

(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):

Source/WebKit/chromium:

  • features.gypi:
11:37 AM Changeset in webkit [144083] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Potential crash in YARR JIT generated code when building 64 bit
​https://bugs.webkit.org/show_bug.cgi?id=110893

Reviewed by Gavin Barraclough.

The ABI doesn't define the behavior for the upper bits of a value that takes less than 64 bits.
Therefore, we zero extend both the count and length registers to assure that these unsigned values
don't have garbage upper bits.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generateEnter):

11:25 AM Changeset in webkit [144082] by roger_fong@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed. Build fix for VS2010 solution, take 2.

  • WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py:
11:21 AM Changeset in webkit [144081] by thakis@chromium.org
  • 2 edits in trunk/Tools

[chromium] content shell drt: Enable WebKit::setLayoutTestMode()
​https://bugs.webkit.org/show_bug.cgi?id=110890

Reviewed by Jochen Eisinger.

Several functions in webkit check that bit to change rendering
in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
disables font smoothing in this mode. TestShell and DRT both set
this flag, so content shell drt should set it too.

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

11:12 AM Changeset in webkit [144080] by roger_fong@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed. Unreviewed build fix for VS2010 solution.

  • WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py:
11:03 AM Changeset in webkit [144079] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.

Adding failure expectations for three html5lib tests that are failing after r144032
on EFL and GTK, most likely due to the ports sharing Libsoup as the network backend.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
11:00 AM Changeset in webkit [144078] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[TexMap] Ignore layer repaint request when drawsContent is false
​https://bugs.webkit.org/show_bug.cgi?id=110888

Reviewed by Noam Rosenthal.

As long as drawsContent is false we should ignore requests for repaints.
A full repaint will be requested when drawsContent is changed to true.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::setDrawsContent):

10:55 AM Changeset in webkit [144077] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WTF

Fix the atomicIncrement implementation for MIPS GCC
​https://bugs.webkit.org/show_bug.cgi?id=106739

Patch by Balazs Kilvady <​kilvadyb@homejinni.com> on 2013-02-26
Reviewed by Oliver Hunt.

Implementation of missing sync_[add|sub]_and_fetch_8 functions.

Some architectures, like MIPS32, don't have GCC implementation for
builtin sync_* functions with 64 bits variable size. GCC answer
for the problem: If a target doesn't support atomic operations on
certain variable sizes, you are out of luck with atomicity in that
case (​http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56296). GCC >= 4.8
will support atomic_* builtin functions for this purpose for all
the GCC targets, but for current compilers we have to include our
own implementation.

  • GNUmakefile.list.am:
  • WTF.pro:
  • wtf/Atomics.cpp: Added.

(WTF):
(WTF::getSwapLock):
(WTF::atomicStep):

  • wtf/CMakeLists.txt:
10:50 AM Changeset in webkit [144076] by vivek.vg@samsung.com
  • 2 edits in trunk/Tools

new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
​https://bugs.webkit.org/show_bug.cgi?id=110884

Reviewed by Csaba Osztrogonác.

Adding the missing spaces before ':' in the unit test.

  • Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
10:44 AM Changeset in webkit [144075] by jsbell@chromium.org
  • 3 edits
    2 adds in trunk

IndexedDB: IDBObjectStore.index() doesn't report errors after deleteIndex()
​https://bugs.webkit.org/show_bug.cgi?id=110792

Reviewed by Tony Chang.

Source/WebCore:

The object store's metadata wasn't updated if the index hadn't been accessed
by script and hence placed in the name->object map. Make sure the metadata
is always updated.

Test: storage/indexeddb/deleteIndex-bug110792.html

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::deleteIndex): Always update the object store's metadata.

LayoutTests:

Added regression test for bug.

  • storage/indexeddb/deleteIndex-bug110792-expected.txt: Added.
  • storage/indexeddb/deleteIndex-bug110792.html: Added.
10:43 AM Changeset in webkit [144074] by akling@apple.com
  • 14 edits
    1 add in trunk/Source/JavaScriptCore

Unused Structure property tables waste 14MB on Membuster.
<​http://webkit.org/b/110854>
<rdar://problem/13292104>

Reviewed by Filip Pizlo.

Turn PropertyTable into a GC object and have Structure drop unpinned tables when marking.
14 MB progression on Membuster3.

Added PropertyTable.cpp.

  • runtime/PropertyTable.cpp: Added.

(JSC::PropertyTable::create):
(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::destroy):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::visitChildren):

Moved marking of property table values here from Structure::visitChildren().

  • runtime/StructureInlines.h:

(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):

Moved these to StructureInlines.h to break header dependency cycle between Structure/PropertyTable.

  • runtime/Structure.cpp:

(JSC::Structure::visitChildren):

Null out m_propertyTable if the table is unpinned. This'll cause the table to get GC'd.

(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):

  • runtime/Structure.h:

(Structure):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/PropertyMapHashTable.h:

(PropertyTable):
(JSC::PropertyTable::createStructure):
(JSC::PropertyTable::copy):

10:38 AM Changeset in webkit [144073] by commit-queue@webkit.org
  • 11 edits in trunk

Unreviewed, rolling out r144019.
​http://trac.webkit.org/changeset/144019
​https://bugs.webkit.org/show_bug.cgi?id=110892

due to 8% perf regression on chromium-win7 intl1 page cycler,
see ​https://bugs.webkit.org/show_bug.cgi?id=110872 (Requested
by gasubic on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-26

Source/WebCore:

  • platform/text/LineBreakIteratorPoolICU.h:

(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
(LineBreakIteratorPool):

  • platform/text/TextBreakIterator.h:

(WebCore):
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/RenderText.h:

(WebCore):

  • rendering/break_lines.cpp:

(WebCore):
(WebCore::isBreakableSpace):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):

  • rendering/break_lines.h:

(WebCore):
(WebCore::isBreakable):

LayoutTests:

  • platform/mac/TestExpectations:
10:35 AM Changeset in webkit [144072] by danakj@chromium.org
  • 6 edits in trunk/Source

Create the SharedGraphicsContext3D through its own method.
​https://bugs.webkit.org/show_bug.cgi?id=109345

Reviewed by James Robinson.

Source/Platform:

Add Platform API methods to get shared contexts from the embedder.

  • chromium/public/Platform.h:

(Platform):
(WebKit::Platform::sharedOffscreenGraphicsContext3D):
(WebKit::Platform::sharedOffscreenGrContext):

Source/WebCore:

Allow creating a GraphicsContext3DPrivate from an externally owned
WebGraphicsContext3D and GrContext. Then create the shared graphics
context from these provided by the embedder.

This falls back to the old path if the new methods return NULL to
let us land this immediately and then transition the chromium side
over to this path.

  • platform/chromium/support/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromExternalWebContextAndGrContext):
(WebCore::GraphicsContext3DPrivate::grContext):

  • platform/chromium/support/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::webContext):

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3DImpl::getOrCreateContext):

10:32 AM Changeset in webkit [144071] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

Appease the QT bots.

10:29 AM Changeset in webkit [144070] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][GTK] REGRESSION (r143463): unit test failure in WebKit2APITests/TestContextMenu
​https://bugs.webkit.org/show_bug.cgi?id=110869

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-26
Reviewed by Martin Robinson.

Test was failing because of new media controls needs more space to be
painted than just 10x10 pixels.

  • UIProcess/API/gtk/tests/TestContextMenu.cpp:

(testContextMenuDefaultMenu): Modified test in order to give more space
to the media controls.

10:04 AM Changeset in webkit [144069] by yoli@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use APIEntryShim when making JS call
​https://bugs.webkit.org/show_bug.cgi?id=110787

Reviewed by Rob Buis.

PR# 301451.
Use APIEntryShim to fix an assert and ensure it is thread-safe.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):

9:50 AM Changeset in webkit [144068] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

REGRESSION(r143986): fast/files/revoke-blob-url.html asserts
​https://bugs.webkit.org/show_bug.cgi?id=110885

Reviewed by Alexey Proskuryakov.

The ResourceRequest string constructor assumes that the string is a valid URL. Use KURL constructor instead.

  • html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL):

9:16 AM Changeset in webkit [144067] by dino@apple.com
  • 10 edits in trunk/Source

Draw intermediate snapshots if possible
​https://bugs.webkit.org/show_bug.cgi?id=110811

Reviewed by Simon Fraser.

After ​http://webkit.org/b/110495 we delayed snapshotting until we've
received a nice image, but this made the page look like it is broken.
We should draw any intermediate snapshots that we find, which might
include content such as progress bars/spinners.

Source/WebCore:

  • html/HTMLPlugInElement.h:

(WebCore::HTMLPlugInElement::isPlugInImageElement): Expose virtual method
to indicate if this is a HTMLPlugInImageElement or not.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateSnapshot): If we have
a RenderEmbeddedObject renderer, then tell it to repaint.

  • html/HTMLPlugInImageElement.h:

(WebCore::HTMLPlugInImageElement::snapshotImage): Expose an
accessor for snapshot images.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintSnapshotImage): New helper
method to render an image directly. This code is similar to
that in RenderSnapshottedPlugIn.
(WebCore::RenderEmbeddedObject::paintContents): The virtual implementation
of this method for use when we have a snapshot to paint. If we are a plugin that is
in the process of being snapshotted, ask our HTMLPlugInImageElement for a
snapshot and paint that instead. In the case where we are not snapshotting,
or we do not yet have a snapshot, this will call back into the RenderWidget code.

  • rendering/RenderEmbeddedObject.h:

(RenderEmbeddedObject): New methods paintSnapshotImage and paintContents

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paintContents): New method called in the middle
of paint() that can be overridden by RenderEmbeddedObject. The code here was
simply moved out of the previous paint().
(WebCore::RenderWidget::paint): Call paintContents at the appropriate time.

  • rendering/RenderWidget.h:

(RenderWidget): New virtual method paintContents.

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit): Reinstate 60 attempts at snapshots before giving up.
(WebKit::PluginView::isAcceleratedCompositingEnabled): We do not
want accelerated compositing enabled when we are trying to capture
snapshots.

9:15 AM Changeset in webkit [144066] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove nonexistent StringPairVector.h from Target.pri after r142839

Unreviewed gardening.

  • Target.pri:
9:08 AM Changeset in webkit [144065] by leviw@chromium.org
  • 5 edits in trunk/Source

Add support for 8 bit TextRuns for Chromium/HarfBuzz
​https://bugs.webkit.org/show_bug.cgi?id=99393

Reviewed by Eric Seidel.

Source/WebCore:

Adding support for 8 bit TextRuns for platforms using HarfBuzz. To accomplish this,
8 bit text runs are upconverted to 16 bit in the complex text path during string
normalization, as HarfBuzz operates on UChars.

No new tests. No change in behavior.

(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::normalizeCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):

Source/WebKit/chromium:

Enabling 8 bit text runs for Chromium.

  • features.gypi:
8:51 AM WebKitGTK edited by kov@webkit.org
(diff)
8:37 AM Changeset in webkit [144064] by commit-queue@webkit.org
  • 17 edits in trunk/Source

Merged Tip and Debug log levels for web console.
​https://bugs.webkit.org/show_bug.cgi?id=109919

Patch by Dmitry Zvorygin <​zvorygin@chromium.org> on 2013-02-26
Reviewed by Pavel Feldman.

In every component either TIP or DEBUG level was used for reporting,
but not both. This patch is prerequisite for Web Inspector console log filtering.

Source/WebCore:

  • css/MediaList.cpp:

(WebCore::addResolutionWarningMessageToConsole):

  • inspector/ConsoleMessage.cpp:

(WebCore::messageLevelValue):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::abort):

  • page/Console.cpp:

(WebCore::printMessageSourceAndLevelPrefix):

  • page/ConsoleTypes.h:
  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::XSLTProcessor::parseErrorFunc):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTMessageHandler::handleMessage):

Source/WebKit/chromium:

  • public/WebConsoleMessage.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::addMessageToConsole):

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.mm:

(stringForMessageLevel):

  • WebView/WebUIDelegatePrivate.h:

Source/WebKit/wx:

  • WebView.h:
8:28 AM Changeset in webkit [144063] by commit-queue@webkit.org
  • 10 edits
    4 adds in trunk/Source

[BlackBerry] Upstream the datalist support UI
​https://bugs.webkit.org/show_bug.cgi?id=110736

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-02-26
Reviewed by Rob Buis.

Original code by Otto Derek Cheung <​otcheung@rim.com>

Source/WebCore:

  • css/themeBlackBerry.css:

(input::-webkit-suggestion-dropdown-box):
(input::-webkit-suggestion-dropdown-box-item):
(input::-webkit-suggestion-prefix-text):
(input::-webkit-suggestion-dropdown-box-item-last):

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::supportsDataListUI):
(WebCore):

  • platform/blackberry/RenderThemeBlackBerry.h:

(RenderThemeBlackBerry):

Source/WebKit:

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

  • WebCoreSupport/SuggestionBoxElement.cpp: Added.

(WebCore):
(WebCore::SuggestionBoxElement::SuggestionBoxElement):
(WebCore::SuggestionBoxElement::~SuggestionBoxElement):
(WebCore::SuggestionBoxElement::create):
(WebCore::SuggestionBoxElement::defaultEventHandler):

  • WebCoreSupport/SuggestionBoxElement.h: Added.

(WebCore):
(SuggestionBoxElement):

  • WebCoreSupport/SuggestionBoxHandler.cpp: Added.

(WebCore):
(WebCore::SuggestionBoxHandler::SuggestionBoxHandler):
(WebCore::SuggestionBoxHandler::~SuggestionBoxHandler):
(WebCore::SuggestionBoxHandler::create):
(WebCore::SuggestionBoxHandler::setInputElementAndUpdateDisplay):
(WebCore::SuggestionBoxHandler::showDropdownBox):
(WebCore::SuggestionBoxHandler::hideDropdownBox):
(WebCore::SuggestionBoxHandler::changeInputElementInnerTextValue):
(WebCore::SuggestionBoxHandler::parseSuggestions):
(WebCore::SuggestionBoxHandler::insertSuggestionsToDropdownBox):
(WebCore::adjustDropdownBoxPosition):
(WebCore::SuggestionBoxHandler::buildDropdownBoxTree):

  • WebCoreSupport/SuggestionBoxHandler.h: Added.

(WebCore):
(SuggestionBoxHandler):
(WebCore::SuggestionBoxHandler::focusedElement):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::updateFormState):

  • WebKitSupport/InputHandler.h:

(WebCore):
(InputHandler):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

8:22 AM Changeset in webkit [144062] by caseq@chromium.org
  • 17 edits
    2 adds in trunk/Source

Source/WebCore: Web Inspector: plumb trace events to Timeline agent
​https://bugs.webkit.org/show_bug.cgi?id=105796

Reviewed by Pavel Feldman.

  • plumb trace events to Timeline;
  • add TimelineTraceEventProcessor to process selected trace events;
  • emit timeline events from TimelineTraceEventProcessor.

Note that actual event processing logic is a separate change.

  • CMakeLists.txt: Added TimelineTraceEventProcessor.{h,cpp}.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • inspector/InspectorAllInOne.cpp: Ditto.
  • inspector/InspectorClient.h:

(InspectorClient):
(WebCore::InspectorClient::setTraceEventCallback):

  • inspector/InspectorTimelineAgent.cpp: create/destroy trace event processor on start/stop.

(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::page):
(WebCore):

  • inspector/InspectorTimelineAgent.h:

(WebCore):
(InspectorTimelineAgent):

  • inspector/TimelineTraceEventProcessor.cpp: Added.

(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore):
(WebCore::TimelineTraceEventProcessor::~TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::TraceEvent::parameter):
(WebCore::TimelineTraceEventProcessor::processEventOnAnyThread):
(WebCore::TimelineTraceEventProcessor::processEvent):
(WebCore::TimelineTraceEventProcessor::sendTimelineRecord):
(WebCore::TimelineTraceEventProcessor::processBackgroundEvents):

  • inspector/TimelineTraceEventProcessor.h: Added.

(WebCore):
(TimelineTraceEventProcessor):
(TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::timestamp):
(WebCore::TimelineTraceEventProcessor::TraceEvent::phase):
(WebCore::TimelineTraceEventProcessor::TraceEvent::name):
(WebCore::TimelineTraceEventProcessor::TraceEvent::threadIdentifier):
(WebCore::TimelineTraceEventProcessor::TraceEvent::argumentCount):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asBool):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asUInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asDouble):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asString):
(WebCore::TimelineTraceEventProcessor::EventTypeEntry::EventTypeEntry):
(EventTypeEntry):

Source/WebKit/chromium: Plumbing trace events to Timeline

Web Inspector: plumb trace events to Timeline agent
​https://bugs.webkit.org/show_bug.cgi?id=105796

Reviewed by Pavel Feldman.

  • public/WebDevToolsAgentClient.h:

(WebDevToolsAgentClient):
(WebKit::WebDevToolsAgentClient::setTraceEventCallback):

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::setTraceEventCallback):
(WebKit):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
(WebKit):

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

8:14 AM Changeset in webkit [144061] by eustas@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Web Inspector: Specify return type of WebInspector.UIString
​https://bugs.webkit.org/show_bug.cgi?id=110095

Reviewed by Pavel Feldman.

Specify return type of WebInspector.UIString.
Fix new js-compiler warnings.

This change will increase type coverage by 0.4% (to 81%)

  • inspector/front-end/ObjectPropertiesSection.js: Fix type errors.
  • inspector/front-end/UIString.js:

(WebInspector.UIString): Return type specified.

8:08 AM Changeset in webkit [144060] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Resources] Cookies table looks empty.
​https://bugs.webkit.org/show_bug.cgi?id=110870

Reviewed by Pavel Feldman.

Fixed data-grid selector.

  • inspector/front-end/resourcesPanel.css:

(.storage-view .data-grid): Fixed selector.

8:05 AM Changeset in webkit [144059] by schenney@chromium.org
  • 1 edit
    5 adds
    3 deletes in trunk/LayoutTests

[Chromium] New baselines for css3-modsel-15c

Unreviewed test expectations update.

  • platform/chromium-linux-x86/css3/selectors3/xml: Removed.
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-15c-expected.png: Added.
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-15c-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15c-expected.png: Added.
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-15c-expected.png: Added.
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-15c-expected.txt: Added.
  • platform/chromium/css3/selectors3/xml/css3-modsel-15c-expected.png: Removed.
  • platform/chromium/css3/selectors3/xml/css3-modsel-15c-expected.txt: Removed.
7:59 AM Changeset in webkit [144058] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Migrate FileSystem inspection support to ResourceTreeModel's SecurityOriginAdded/Removed events.
​https://bugs.webkit.org/show_bug.cgi?id=110878

Reviewed by Alexander Pavlov.

Recently added SecurityOriginAdded/Removed events support was essentially duplicated in
FileSystemModel. This patch migrates FileSystem inspection support to new events.

  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel):
(WebInspector.FileSystemModel.prototype._reset):
(WebInspector.FileSystemModel.prototype._securityOriginAdded):
(WebInspector.FileSystemModel.prototype._securityOriginRemoved):
(WebInspector.FileSystemModel.prototype._addOrigin):
(WebInspector.FileSystemModel.prototype._removeOrigin):
(WebInspector.FileSystemModel.prototype.refreshFileSystemList):

7:57 AM Changeset in webkit [144057] by Antoine Quint
  • 5 edits in trunk

Web Inspector: Cannot deep expand an element that has previously been partially expanded
​https://bugs.webkit.org/show_bug.cgi?id=110424

In the case where the children from the provided node have already been pushed, traverse children at the depth provided until we find children that have not been pushed yet.

Reviewed by Pavel Feldman.

7:53 AM Changeset in webkit [144056] by akling@apple.com
  • 14 edits
    1 delete in trunk/Source/JavaScriptCore

Unreviewed, rolling out r144054.
​http://trac.webkit.org/changeset/144054
​https://bugs.webkit.org/show_bug.cgi?id=110854

broke builds

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/PropertyMapHashTable.h:

(PropertyTable):
(JSC::PropertyTable::PropertyTable):
(JSC):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::copy):

  • runtime/PropertyTable.cpp: Removed.
  • runtime/Structure.cpp:

(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
(JSC::Structure::visitChildren):

  • runtime/Structure.h:

(JSC):
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):
(Structure):

  • runtime/StructureInlines.h:
7:43 AM Changeset in webkit [144055] by commit-queue@webkit.org
  • 6 edits in trunk

REGRESSION (r143619): Crashes in three layout tests
​https://bugs.webkit.org/show_bug.cgi?id=110588

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-02-26
Reviewed by Gustavo Noronha Silva.

Source/WebKit/gtk:

Guard against null main resource identifiers. The main resource
identifier can be null at various times during the load. A null
identifier is never equal to the ones we are looking to remove.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidFinishLoading): Use the new webkitWebViewRemoveSubresource helper.
(WebKit::FrameLoaderClient::dispatchDidFailLoading): ditto.

  • webkit/webkitwebview.cpp:

(webkitWebViewRemoveSubresource): Added this helper which removes a subresource, but
never touches the main resource. This is adapted from the old method, for which the
main resource branch was dead code.

  • webkit/webkitwebviewprivate.h: Update the method list.

LayoutTests:

  • platform/gtk/TestExpectations: Unskip some tests which are no longer

crashing.

7:36 AM WebKitGTK/2.0.x edited by sergio@webkit.org
(diff)
7:32 AM Changeset in webkit [144054] by akling@apple.com
  • 14 edits
    1 add in trunk/Source/JavaScriptCore

Unused Structure property tables waste 14MB on Membuster.
<​http://webkit.org/b/110854>
<rdar://problem/13292104>

Reviewed by Filip Pizlo.

Turn PropertyTable into a GC object and have Structure drop unpinned tables when marking.
14 MB progression on Membuster3.

Added PropertyTable.cpp.

  • runtime/PropertyTable.cpp: Added.

(JSC::PropertyTable::create):
(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::destroy):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::visitChildren):

Moved marking of property table values here from Structure::visitChildren().

  • runtime/StructureInlines.h:

(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):

Moved these to StructureInlines.h to break header dependency cycle between Structure/PropertyTable.

  • runtime/Structure.cpp:

(JSC::Structure::visitChildren):

Null out m_propertyTable if the table is unpinned. This'll cause the table to get GC'd.

(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):

  • runtime/Structure.h:

(Structure):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/PropertyMapHashTable.h:

(PropertyTable):
(JSC::PropertyTable::createStructure):
(JSC::PropertyTable::copy):

6:22 AM Changeset in webkit [144053] by caseq@chromium.org
  • 25 edits
    2 deletes in trunk

Unreviewed, rolling out r144041, r144044, and r144048.
​http://trac.webkit.org/changeset/144041
​http://trac.webkit.org/changeset/144044
​http://trac.webkit.org/changeset/144048
​https://bugs.webkit.org/show_bug.cgi?id=105796

Broke build

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorClient.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

  • inspector/InspectorTimelineAgent.h:

(WebCore):
(InspectorTimelineAgent):

  • inspector/TimelineRecordFactory.cpp:
  • inspector/TimelineRecordFactory.h:
  • inspector/TimelineTraceEventProcessor.cpp: Removed.
  • inspector/TimelineTraceEventProcessor.h: Removed.
  • inspector/front-end/TimelineModel.js:
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel._initRecordStyles):

Source/WebKit/chromium:

  • public/WebDevToolsAgentClient.h:
  • src/InspectorClientImpl.cpp:
  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

LayoutTests:

  • inspector/timeline/timeline-enum-stability-expected.txt:
6:20 AM Changeset in webkit [144052] by vsevik@chromium.org
  • 9 edits in trunk

Web Inspector: Migrate IndexedDB support to ResourceTreeModel's SecurityOriginAdded/Removed events.
​https://bugs.webkit.org/show_bug.cgi?id=110863

Reviewed by Alexander Pavlov.

Source/WebCore:

Recently added SecurityOriginAdded/Removed events support was essentially duplicated in
IndexedDBModel. This patch migrates IndexedDB support to new events.

  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):

  • inspector/InspectorIndexedDBAgent.h:

(InspectorIndexedDBAgent):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
(WebInspector.IndexedDBModel.prototype._securityOriginAdded):
(WebInspector.IndexedDBModel.prototype._securityOriginRemoved):
(WebInspector.IndexedDBModel.prototype._addOrigin):
(WebInspector.IndexedDBModel.prototype._removeOrigin):
(WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.):
(WebInspector.IndexedDBModel.prototype._requestData):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype.securityOrigins):

LayoutTests:

  • http/tests/inspector/indexeddb/database-names-expected.txt:
  • http/tests/inspector/indexeddb/database-names.html:
5:57 AM Changeset in webkit [144051] by Csaba Osztrogonác
  • 9 edits
    6 copies in trunk/LayoutTests

Unreviewed fix after r144032.
​https://bugs.webkit.org/show_bug.cgi?id=110734

Update expected files due to JSC/V8 differences.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-26

  • TestExpectations: Skip 2 failing tests until proper fix.
  • html5lib/generated/run-template-write.html:
  • html5lib/generated/run-tests1-data-expected.txt:
  • html5lib/generated/run-tests1-write-expected.txt:
  • html5lib/generated/run-tests18-data-expected.txt:
  • html5lib/generated/run-tests18-write-expected.txt:
  • html5lib/generated/run-tests7-data-expected.txt:
  • html5lib/generated/run-tests7-write-expected.txt:
  • platform/chromium/html5lib/generated/run-tests1-data-expected.txt: Copied from LayoutTests/html5lib/generated/run-tests1-data-expected.txt.
  • platform/chromium/html5lib/generated/run-tests1-write-expected.txt: Copied from LayoutTests/html5lib/generated/run-tests1-write-expected.txt.
  • platform/chromium/html5lib/generated/run-tests18-data-expected.txt: Copied from LayoutTests/html5lib/generated/run-tests18-data-expected.txt.
  • platform/chromium/html5lib/generated/run-tests18-write-expected.txt: Copied from LayoutTests/html5lib/generated/run-tests18-write-expected.txt.
  • platform/chromium/html5lib/generated/run-tests7-data-expected.txt: Copied from LayoutTests/html5lib/generated/run-tests7-data-expected.txt.
  • platform/chromium/html5lib/generated/run-tests7-write-expected.txt: Copied from LayoutTests/html5lib/generated/run-tests7-write-expected.txt.
5:51 AM Changeset in webkit [144050] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
5:51 AM Changeset in webkit [144049] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: in protocol make field "securityOrigin" in type Page.Frame mandatory
​https://bugs.webkit.org/show_bug.cgi?id=80857

Reviewed by Vsevolod Vlasov.

Frame.securityOrigin has always been set to a valid value, so this change just fixes
the protocol flaw.

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):

5:44 AM Changeset in webkit [144048] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix following r144041.

  • inspector/TimelineTraceEventProcessor.h:

(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):

5:43 AM Changeset in webkit [144047] by vivek.vg@samsung.com
  • 2 edits in trunk/Source/WebCore

Web Inspector: DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node
​https://bugs.webkit.org/show_bug.cgi?id=110862

Reviewed by Alexander Pavlov.

While deleting entries in the DataGrid, deleting of selected node should trigger selection of
next possible (backward/forward) DataGridNode.

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGridNode.prototype.get leftPadding):
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):

5:42 AM Changeset in webkit [144046] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] TestExpectations cleanup.

Unreviewed removal of expectations for tests that are now passing.

  • platform/chromium/TestExpectations:
5:37 AM Changeset in webkit [144045] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

REGRESSION (r143931): set-cookie-on-redirect.html breaks subsequent tests
​https://bugs.webkit.org/show_bug.cgi?id=110844

Patch by Sergio Villar Senin <​svillar@igalia.com> on 2013-02-26
Reviewed by Alexey Proskuryakov.

Clean up cookies at the beginning and after finishing the test in
order not to break other tests behavior.

  • http/tests/cookies/resources/set-cookie-on-redirect.php: clear cookie before returning.
  • http/tests/cookies/set-cookie-on-redirect.html: clear all cookies before starting the test.
5:12 AM Changeset in webkit [144044] by caseq@chromium.org
  • 13 edits in trunk

Source/WebCore: Web Inspector: show raster tasks on Timeline
​https://bugs.webkit.org/show_bug.cgi?id=105851

  • add PaintLayer, Paint & RasterTask trace events handling to trace event processor;
  • upon begin frame, emit aggregated background event for all raster tasks related to the inspected page.

Reviewed by Pavel Feldman.

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(InstrumentationEvents):
(InstrumentationEventArguments):

  • inspector/InspectorInstrumentation.h:

(InstrumentationEvents):
(WebCore):
(InstrumentationEventArguments):

  • inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::didBeginFrame):

  • inspector/InspectorTimelineAgent.h:

(TimelineRecordType):
(WebCore):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createRasterData):
(WebCore):

  • inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):

  • inspector/TimelineTraceEventProcessor.cpp:

(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::~TimelineTraceEventProcessor):
(WebCore):
(WebCore::TimelineTraceEventProcessor::registerHandler):
(WebCore::TimelineTraceEventProcessor::shutdown):
(WebCore::TimelineTraceEventProcessor::TraceEvent::findParameter):
(WebCore::TimelineTraceEventProcessor::TraceEvent::parameter):
(WebCore::TimelineTraceEventProcessor::processEventOnAnyThread):
(WebCore::TimelineTraceEventProcessor::onBeginFrame):
(WebCore::TimelineTraceEventProcessor::onPaintLayerBegin):
(WebCore::TimelineTraceEventProcessor::onPaintLayerEnd):
(WebCore::TimelineTraceEventProcessor::onRasterTaskBegin):
(WebCore::TimelineTraceEventProcessor::onRasterTaskEnd):
(WebCore::TimelineTraceEventProcessor::onLayerDeleted):
(WebCore::TimelineTraceEventProcessor::onPaint):
(WebCore::TimelineTraceEventProcessor::flushRasterizerStatistics):
(WebCore::TimelineTraceEventProcessor::sendTimelineRecord):
(WebCore::TimelineTraceEventProcessor::processBackgroundEvents):

  • inspector/TimelineTraceEventProcessor.h:

(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::id):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asBool):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asUInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asDouble):
(TimelineTraceEventProcessor):

  • inspector/front-end/TimelineModel.js:
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel._initRecordStyles):

LayoutTests: Web Inspector: show deferred paints on Timeline
​https://bugs.webkit.org/show_bug.cgi?id=105851

Reviewed by Pavel Feldman.

  • inspector/timeline/timeline-enum-stability-expected.txt: Added "Rasterize" record type.
5:11 AM WebKitGtkLayoutTests edited by Manuel Rego Casasnovas
Add explanation to launch a single unit test (diff)
5:04 AM Changeset in webkit [144043] by jocelyn.turcotte@digia.com
  • 9 edits
    1 add in trunk/Source

Implement JIT on Windows 64 bits
​https://bugs.webkit.org/show_bug.cgi?id=107965

Reviewed by Simon Hausmann.

Source/JavaScriptCore:

  1. MSVC doesn't support inline assembly for 64 bits, implements the trampoline in a separate ASM file.
  1. Windows 64 bits has a different calling convention than other OSes following the AMD64 ABI.

Differences that we have to handle here:

  • Registers passed parameters are RCX, RDX, R8 and R9 instead of RDI, RSI, RDX, RCX, R8 and R9
  • RDI and RSI must be preserved by callee
  • Only return values <= 8 bytes can be returned by register (RDX can't be used to return a second word)
  • There is no red-zone after RIP on the stack, but instead 4 reserved words before it
  • Target.pri:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:

(JSC):
(JITStackFrame):
(JSC::JITStackFrame::returnAddressSlot):

  • jit/JITStubsMSVC64.asm: Added.
  • jit/JSInterfaceJIT.h:

(JSInterfaceJIT):

  • jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

  • yarr/YarrJIT.cpp:

(YarrGenerator):
(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::generateReturn):

Source/WTF:

  • wtf/Platform.h:
5:01 AM Changeset in webkit [144042] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebCore

Work around a MSVC 2012 Update 1 bug causing a crash on x86
​https://bugs.webkit.org/show_bug.cgi?id=110488

Reviewed by Anders Carlsson.

The crash happens when building with /O2, where TextEncodingNameHash::equal is
incorrectly optimized with the inlined toASCIILower and uses a register already in use.
The function returns false incorrectly, causing a mismatch of text encoding name which
then results in a null pointer access.

Slightly rewording the use of the inline function lets the compiler produce correct code.

The bug has already been reported and should be fixed in the next release of MSVS later this year.
​https://connect.microsoft.com/VisualStudio/feedback/details/777533/vs2012-c-optimizing-bug-when-using-inline-and-char-return-type-x86-target-only

  • platform/text/TextEncodingRegistry.cpp:
4:52 AM Changeset in webkit [144041] by caseq@chromium.org
  • 17 edits
    2 adds in trunk/Source

Web Inspector: plumb trace events to Timeline agent
​https://bugs.webkit.org/show_bug.cgi?id=105796

Reviewed by Pavel Feldman.

Source/WebCore:

  • plumb trace events to Timeline;
  • add TimelineTraceEventProcessor to process selected trace events;
  • emit timeline events from TimelineTraceEventProcessor.

Note that actual event processing logic is a separate change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorClient.h:

(InspectorClient):
(WebCore::InspectorClient::setTraceEventCallback):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::appendBackgroundThreadRecord):
(WebCore):
(WebCore::InspectorTimelineAgent::page):

  • inspector/InspectorTimelineAgent.h:

(WebCore):
(InspectorTimelineAgent):

  • inspector/TimelineTraceEventProcessor.cpp: Added.

(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore):
(WebCore::TimelineTraceEventProcessor::~TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::TraceEvent::parameter):
(WebCore::TimelineTraceEventProcessor::processEventOnAnyThread):
(WebCore::TimelineTraceEventProcessor::processEvent):
(WebCore::TimelineTraceEventProcessor::sendTimelineRecord):
(WebCore::TimelineTraceEventProcessor::processBackgroundEvents):

  • inspector/TimelineTraceEventProcessor.h: Added.

(WebCore):
(TimelineTraceEventProcessor):
(TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::timestamp):
(WebCore::TimelineTraceEventProcessor::TraceEvent::phase):
(WebCore::TimelineTraceEventProcessor::TraceEvent::name):
(WebCore::TimelineTraceEventProcessor::TraceEvent::threadIdentifier):
(WebCore::TimelineTraceEventProcessor::TraceEvent::argumentCount):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asBool):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asUInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asDouble):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asString):
(WebCore::TimelineTraceEventProcessor::EventTypeEntry::EventTypeEntry):
(EventTypeEntry):

  • inspector/front-end/TimelineFrameController.js:

(WebInspector.TimelineFrameController.prototype._addRecord):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineRecordListRow.prototype.update):
(WebInspector.TimelineRecordGraphRow.prototype.update):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.insertRetrospecitveRecord):
(WebInspector.TimelinePresentationModel.Record.prototype.get isBackground):

  • inspector/front-end/timelinePanel.css:

(.timeline-tree-item.background .timeline-tree-icon):
(.timeline-graph-side.background .timeline-graph-bar):

Source/WebKit/chromium:

Plumb trace events to Inspector.

  • public/WebDevToolsAgentClient.h:

(WebDevToolsAgentClient):
(WebKit::WebDevToolsAgentClient::setTraceEventCallback):

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::setTraceEventCallback):
(WebKit):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
(WebKit):

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

4:52 AM Changeset in webkit [144040] by vivek.vg@samsung.com
  • 2 edits in trunk/Tools

new-commit-bot: Some IRC clients doesn't linkify rollout messages
​https://bugs.webkit.org/show_bug.cgi?id=110861

Reviewed by Ryosuke Niwa.

Adding the space before ':' in order to fix the links shown for the rollout message.

  • Scripts/webkitpy/tool/commands/newcommitbot.py:

(NewCommitBot._summarize_commit_log):

4:42 AM Changeset in webkit [144039] by caseq@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: display background events on Timeline
​https://bugs.webkit.org/show_bug.cgi?id=108599

Reviewed by Pavel Feldman.

  • add optional `thread' field to timeline event;
  • if thread field is present, display the event as 'background' (hollow bar / list icon), align to nearest foreground event;
  • do not account background events in Frame mode of overview.
  • inspector/Inspector.json:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::appendBackgroundThreadRecord):
(WebCore):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/front-end/TimelineFrameController.js:

(WebInspector.TimelineFrameController.prototype._addRecord):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineRecordListRow.prototype.update):
(WebInspector.TimelineRecordGraphRow.prototype.update):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.insertRetrospecitveRecord):
(WebInspector.TimelinePresentationModel.Record.prototype.get isBackground):

  • inspector/front-end/timelinePanel.css:

(.timeline-tree-item.background .timeline-tree-icon):
(.timeline-graph-side.background .timeline-graph-bar):

4:33 AM Changeset in webkit [144038] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

[V8] Rename BatchedCallback to BatchedMethod
​https://bugs.webkit.org/show_bug.cgi?id=110791

Reviewed by Adam Barth.

Now 'Callback' is used to refer to functions that are called back
by V8. DOM methods should be referred to as 'Method's.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):
(WebCore::ConfigureV8Float64ArrayTemplate):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):
(WebCore::ConfigureV8TestEventTargetTemplate):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):

  • bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):

  • bindings/v8/V8DOMConfiguration.h:

(V8DOMConfiguration):

4:08 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas
(diff)
4:01 AM Changeset in webkit [144037] by toyoshim@chromium.org
  • 3 edits
    3 adds in trunk

Add User-Agent header in opening handshake headers.
​https://bugs.webkit.org/show_bug.cgi?id=110601

Reviewed by Alexey Proskuryakov.

RFC-6455 doesn't require to send User-Agent header, but allow it.
Many web application developers want to have it, and Firefox already
did it. This patch adds User-Agent header in opening handshake also in
WebKit ports.

Test: http/tests/websocket/tests/hybi/useragent-in-openinghandshake.html

Source/WebCore:

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):

LayoutTests:

  • http/tests/websocket/tests/hybi/sendback_ua_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/useragent-in-openinghandshake-expected.txt: Added.
  • http/tests/websocket/tests/hybi/useragent-in-openinghandshake.html: Added.
4:01 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas
(diff)
3:41 AM Changeset in webkit [144036] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

XSSAuditor: Don't rely on implicit casting when copying the document's KURL to String.
​https://bugs.webkit.org/show_bug.cgi?id=110859

Reviewed by Jochen Eisinger.

XSSAuditor::init should explicitly make a thread-safe copy of the
document's URL as a String rather than relying on implicit casting from
a copy of the KURL.

This shouldn't change any visible behavior; all existing XSSAuditor
tests should continue to pass. They'll now just be a bit more smug while
doing so.

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::init):

3:38 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
3:31 AM Changeset in webkit [144035] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Updating expectations for two inspector tests.

Expanding expectation for media/encrypted-media/encrypted-media-syntax.html to expect timeouts as well.
Adding a flaky failure expectation for svg/custom/animation-currentColor.svg.

3:30 AM WebKitGTK/2.0.x edited by Claudio Saavedra
(diff)
3:28 AM WebKitGTK/1.10.x edited by Claudio Saavedra
(diff)
3:22 AM Changeset in webkit [144034] by jochen@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[chromium] add content shell specific TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=110710

Reviewed by Eric Seidel.

For now, add tests that pass on content shell but fail on DRT.
Next, I will file bugs for all the remaining failing tests and skip
them here to ease the transition from DRT.

  • platform/chromium/ContentShellTestExpectations: Added.
3:09 AM Changeset in webkit [144033] by zarvai@inf.u-szeged.hu
  • 1 edit
    3 moves
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk1/http/tests/navigation/forward-and-cancel-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/navigation/forward-and-cancel-expected.txt.
  • platform/qt-5.0-wk1/http/tests/navigation/postredirect-frames-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/navigation/postredirect-frames-expected.txt.
  • platform/qt-5.0-wk1/http/tests/navigation/postredirect-goback2-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/navigation/postredirect-goback2-expected.txt.
3:05 AM Changeset in webkit [144032] by eric@webkit.org
  • 4 edits
    82 copies
    7 moves
    93 adds
    50 deletes in trunk/LayoutTests

Layout Test Multiple html5lib/ tests are too slow and should be split.
​https://bugs.webkit.org/show_bug.cgi?id=110734

Reviewed by Adam Barth.

Split all of the html5lib tests into write and data variants
instead of running both in sequence in each test.
I added a script to autogenerate all of the test harness files
from the *.dat files in resources/ (which we sync with the
upstream html5lib tests.

I removed all the old tests and expectations as well as TestExpectation entries.
All of these tests should now be fast enough to avoid timeout on all platforms.
I set the expectations from my chromium-linux (v8) machine, thus someone
from a jsc port will need to rebaseline appropriately from their machine.

(WrapperGenerator):
(_files_in_directory_with_suffix):
(_last_path_component_removing_suffix):
(_remove_harness_prefix):
(_remove_harness_type):
(_test_name_from_harness_name):
(_remove_stale_tests):
(_input_path):
(_harness_path):
(_harness_content):
(_write_harness):
(main):

  • html5lib/generated/run-adoption01-data-expected.txt: Added.
  • html5lib/generated/run-adoption01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-adoption01-write-expected.txt: Added.
  • html5lib/generated/run-adoption01-write.html: Renamed from LayoutTests/html5lib/generated/run-template.html.
  • html5lib/generated/run-adoption02-data-expected.txt: Added.
  • html5lib/generated/run-adoption02-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-adoption02-write-expected.txt: Added.
  • html5lib/generated/run-adoption02-write.html: Renamed from LayoutTests/html5lib/generated/run-tests11.html.
  • html5lib/generated/run-comments01-data-expected.txt: Added.
  • html5lib/generated/run-comments01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-comments01-write-expected.txt: Added.
  • html5lib/generated/run-comments01-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-doctype01-data-expected.txt: Added.
  • html5lib/generated/run-doctype01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-doctype01-write-expected.txt: Added.
  • html5lib/generated/run-doctype01-write.html: Renamed from LayoutTests/html5lib/generated/run-tests10.html.
  • html5lib/generated/run-domjs-unsafe-data-expected.txt: Added.
  • html5lib/generated/run-domjs-unsafe-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-domjs-unsafe-write-expected.txt: Added.
  • html5lib/generated/run-domjs-unsafe-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-entities01-data-expected.txt: Added.
  • html5lib/generated/run-entities01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-entities01-write-expected.txt: Added.
  • html5lib/generated/run-entities01-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-entities02-data-expected.txt: Added.
  • html5lib/generated/run-entities02-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-entities02-write-expected.txt: Added.
  • html5lib/generated/run-entities02-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-html5test-com-data-expected.txt: Added.
  • html5lib/generated/run-html5test-com-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-html5test-com-write-expected.txt: Added.
  • html5lib/generated/run-html5test-com-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-inbody01-data-expected.txt: Added.
  • html5lib/generated/run-inbody01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-inbody01-write-expected.txt: Added.
  • html5lib/generated/run-inbody01-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-isindex-data-expected.txt: Added.
  • html5lib/generated/run-isindex-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-isindex-write-expected.txt: Added.
  • html5lib/generated/run-isindex-write.html: Renamed from LayoutTests/html5lib/generated/run-tests2.html.
  • html5lib/generated/run-pending-spec-changes-data-expected.txt: Added.
  • html5lib/generated/run-pending-spec-changes-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-pending-spec-changes-plain-text-unsafe-data-expected.txt: Added.
  • html5lib/generated/run-pending-spec-changes-plain-text-unsafe-data.html: Added.
  • html5lib/generated/run-pending-spec-changes-plain-text-unsafe-write-expected.txt: Added.
  • html5lib/generated/run-pending-spec-changes-plain-text-unsafe-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-pending-spec-changes-write-expected.txt: Added.
  • html5lib/generated/run-pending-spec-changes-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-plain-text-unsafe-data-expected.txt: Added.
  • html5lib/generated/run-plain-text-unsafe-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-plain-text-unsafe-write-expected.txt: Added.
  • html5lib/generated/run-plain-text-unsafe-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-scriptdata01-data-expected.txt: Added.
  • html5lib/generated/run-scriptdata01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-scriptdata01-write-expected.txt: Added.
  • html5lib/generated/run-scriptdata01-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tables01-data-expected.txt: Added.
  • html5lib/generated/run-tables01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tables01-write-expected.txt: Added.
  • html5lib/generated/run-tables01-write.html: Renamed from LayoutTests/html5lib/generated/run-tests22.html.
  • html5lib/generated/run-template-data-expected.txt: Added.
  • html5lib/generated/run-template-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-template-expected.txt: Removed.
  • html5lib/generated/run-template-write-expected.txt: Added.
  • html5lib/generated/run-template-write.html: Renamed from LayoutTests/html5lib/generated/run-tests3.html.
  • html5lib/generated/run-tests1-data-expected.txt: Added.
  • html5lib/generated/run-tests1-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests1-expected.txt: Removed.
  • html5lib/generated/run-tests1-write-expected.txt: Added.
  • html5lib/generated/run-tests1-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests10-data-expected.txt: Added.
  • html5lib/generated/run-tests10-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests10-expected.txt: Removed.
  • html5lib/generated/run-tests10-write-expected.txt: Added.
  • html5lib/generated/run-tests10-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests11-data-expected.txt: Added.
  • html5lib/generated/run-tests11-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests11-expected.txt: Removed.
  • html5lib/generated/run-tests11-write-expected.txt: Added.
  • html5lib/generated/run-tests11-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests12-data-expected.txt: Added.
  • html5lib/generated/run-tests12-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests12-expected.txt: Removed.
  • html5lib/generated/run-tests12-write-expected.txt: Added.
  • html5lib/generated/run-tests12-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests12.html: Removed.
  • html5lib/generated/run-tests14-data-expected.txt: Added.
  • html5lib/generated/run-tests14-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests14-expected.txt: Removed.
  • html5lib/generated/run-tests14-write-expected.txt: Added.
  • html5lib/generated/run-tests14-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests14.html: Removed.
  • html5lib/generated/run-tests15-data-expected.txt: Added.
  • html5lib/generated/run-tests15-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests15-expected.txt: Removed.
  • html5lib/generated/run-tests15-write-expected.txt: Added.
  • html5lib/generated/run-tests15-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests15.html: Removed.
  • html5lib/generated/run-tests16-data-expected.txt: Added.
  • html5lib/generated/run-tests16-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests16-expected.txt: Removed.
  • html5lib/generated/run-tests16-write-expected.txt: Added.
  • html5lib/generated/run-tests16-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests16.html: Removed.
  • html5lib/generated/run-tests17-data-expected.txt: Added.
  • html5lib/generated/run-tests17-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests17-expected.txt: Removed.
  • html5lib/generated/run-tests17-write-expected.txt: Added.
  • html5lib/generated/run-tests17-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests17.html: Removed.
  • html5lib/generated/run-tests18-data-expected.txt: Added.
  • html5lib/generated/run-tests18-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests18-expected.txt: Removed.
  • html5lib/generated/run-tests18-write-expected.txt: Added.
  • html5lib/generated/run-tests18-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests18.html: Removed.
  • html5lib/generated/run-tests19-data-expected.txt: Added.
  • html5lib/generated/run-tests19-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests19-expected.txt: Removed.
  • html5lib/generated/run-tests19-write-expected.txt: Added.
  • html5lib/generated/run-tests19-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests19.html: Removed.
  • html5lib/generated/run-tests2-data-expected.txt: Added.
  • html5lib/generated/run-tests2-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests2-expected.txt: Removed.
  • html5lib/generated/run-tests2-write-expected.txt: Added.
  • html5lib/generated/run-tests2-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests20-data-expected.txt: Added.
  • html5lib/generated/run-tests20-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests20-expected.txt: Removed.
  • html5lib/generated/run-tests20-write-expected.txt: Added.
  • html5lib/generated/run-tests20-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests20.html: Removed.
  • html5lib/generated/run-tests21-data-expected.txt: Added.
  • html5lib/generated/run-tests21-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests21-expected.txt: Removed.
  • html5lib/generated/run-tests21-write-expected.txt: Added.
  • html5lib/generated/run-tests21-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests21.html: Removed.
  • html5lib/generated/run-tests22-data-expected.txt: Added.
  • html5lib/generated/run-tests22-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests22-expected.txt: Removed.
  • html5lib/generated/run-tests22-write-expected.txt: Added.
  • html5lib/generated/run-tests22-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests23-data-expected.txt: Added.
  • html5lib/generated/run-tests23-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests23-expected.txt: Removed.
  • html5lib/generated/run-tests23-write-expected.txt: Added.
  • html5lib/generated/run-tests23-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests23.html: Removed.
  • html5lib/generated/run-tests24-data-expected.txt: Added.
  • html5lib/generated/run-tests24-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests24-expected.txt: Removed.
  • html5lib/generated/run-tests24-write-expected.txt: Added.
  • html5lib/generated/run-tests24-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests24.html: Removed.
  • html5lib/generated/run-tests25-data-expected.txt: Added.
  • html5lib/generated/run-tests25-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests25-expected.txt: Removed.
  • html5lib/generated/run-tests25-write-expected.txt: Added.
  • html5lib/generated/run-tests25-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests25.html: Removed.
  • html5lib/generated/run-tests26-data-expected.txt: Added.
  • html5lib/generated/run-tests26-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests26-expected.txt: Removed.
  • html5lib/generated/run-tests26-write-expected.txt: Added.
  • html5lib/generated/run-tests26-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests26.html: Removed.
  • html5lib/generated/run-tests3-data-expected.txt: Added.
  • html5lib/generated/run-tests3-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests3-expected.txt: Removed.
  • html5lib/generated/run-tests3-write-expected.txt: Added.
  • html5lib/generated/run-tests3-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests4-data-expected.txt: Added.
  • html5lib/generated/run-tests4-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests4-expected.txt: Removed.
  • html5lib/generated/run-tests4-write-expected.txt: Added.
  • html5lib/generated/run-tests4-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests4.html: Removed.
  • html5lib/generated/run-tests5-data-expected.txt: Added.
  • html5lib/generated/run-tests5-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests5-expected.txt: Removed.
  • html5lib/generated/run-tests5-write-expected.txt: Added.
  • html5lib/generated/run-tests5-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests5.html: Removed.
  • html5lib/generated/run-tests6-data-expected.txt: Added.
  • html5lib/generated/run-tests6-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests6-expected.txt: Removed.
  • html5lib/generated/run-tests6-write-expected.txt: Added.
  • html5lib/generated/run-tests6-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests6.html: Removed.
  • html5lib/generated/run-tests7-data-expected.txt: Added.
  • html5lib/generated/run-tests7-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests7-expected.txt: Removed.
  • html5lib/generated/run-tests7-write-expected.txt: Added.
  • html5lib/generated/run-tests7-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests7.html: Removed.
  • html5lib/generated/run-tests8-data-expected.txt: Added.
  • html5lib/generated/run-tests8-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests8-expected.txt: Removed.
  • html5lib/generated/run-tests8-write-expected.txt: Added.
  • html5lib/generated/run-tests8-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests8.html: Removed.
  • html5lib/generated/run-tests9-data-expected.txt: Added.
  • html5lib/generated/run-tests9-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests9-expected.txt: Removed.
  • html5lib/generated/run-tests9-write-expected.txt: Added.
  • html5lib/generated/run-tests9-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests9.html: Removed.
  • html5lib/generated/run-tests_innerHTML_1-data-expected.txt: Added.
  • html5lib/generated/run-tests_innerHTML_1-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tests_innerHTML_1-write-expected.txt: Added.
  • html5lib/generated/run-tests_innerHTML_1-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tricky01-data-expected.txt: Added.
  • html5lib/generated/run-tricky01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-tricky01-write-expected.txt: Added.
  • html5lib/generated/run-tricky01-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-webkit01-data-expected.txt: Added.
  • html5lib/generated/run-webkit01-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-webkit01-write-expected.txt: Added.
  • html5lib/generated/run-webkit01-write.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-webkit02-data-expected.txt: Added.
  • html5lib/generated/run-webkit02-data.html: Copied from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/generated/run-webkit02-write-expected.txt: Added.
  • html5lib/generated/run-webkit02-write.html: Renamed from LayoutTests/html5lib/generated/run-tests1.html.
  • html5lib/resources/runner.js:

(window.onload):

  • html5lib/runner-expected.txt: Removed.
  • html5lib/runner.html: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/html5lib/generated/run-tests1-expected.txt: Removed.
  • platform/chromium/html5lib/generated/run-tests18-expected.txt: Removed.
  • platform/chromium/html5lib/generated/run-tests7-expected.txt: Removed.
2:51 AM Changeset in webkit [144031] by tasak@google.com
  • 3 edits
    2 adds in trunk

Shadow DOM styles appear to be over-eagerly shared
​https://bugs.webkit.org/show_bug.cgi?id=110797

Reviewed by Dimitri Glazkov.

Source/WebCore:

A style of a distributed node should not be shared, because the node
might be affected by styles in a shadow dom tree, i.e. :distributed
or something.

Test: fast/dom/shadow/no-style-sharing-with-distributed-nodes.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::locateCousinList):
Skip shadow hosts, because children of shadow hosts are distributed
nodes and cannot share their styles.

LayoutTests:

  • fast/dom/shadow/no-style-sharing-with-distributed-nodes-expected.html: Added.
  • fast/dom/shadow/no-style-sharing-with-distributed-nodes.html: Added.
2:40 AM Changeset in webkit [144030] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused conditional includes of {MathML,SVG}Names.h
​https://bugs.webkit.org/show_bug.cgi?id=110809

Reviewed by Eric Seidel.

  • html/parser/HTMLConstructionSite.cpp:
2:30 AM Changeset in webkit [144029] by kadam@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Update platform specific expected file after r143836.

  • platform/qt/TestExpectations: Skipped after r143300.
  • platform/qt/fast/forms/select-baseline-expected.txt: Update after r143836.
2:05 AM Changeset in webkit [144028] by joone.hur@intel.com
  • 2 edits in trunk/Tools

[GTK] Add Clutter to jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=110245

Reviewed by Martin Robinson.

Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
This allows to build WebKitGtk+ with clutter as an acceleration backend
within the jhbuild environment.

  • gtk/jhbuild-optional.modules:
1:57 AM Changeset in webkit [144027] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

Threaded HTML parser fails fast/loader/stateobjects/state-attribute-history-getter.html
​https://bugs.webkit.org/show_bug.cgi?id=110801

Reviewed by Adam Barth.

This causes 6 more tests to pass for the threaded parser,
an solves all of our timeout issues.

These tests which were failing were racy, we just were never
hitting the race due to using file urls. This change fixes
the threaded parser to emulate one more of the EOF quirks from
the loader/main-thread-parser interaction.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):

1:47 AM Changeset in webkit [144026] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Kill another analyzer warning in javascriptcore
​https://bugs.webkit.org/show_bug.cgi?id=110802

Reviewed by Benjamin Poulain.

Add null checks.

  • profiler/LegacyProfiler.cpp:

(JSC::LegacyProfiler::startProfiling):
(JSC::LegacyProfiler::stopProfiling):

1:15 AM Changeset in webkit [144025] by apavlov@chromium.org
  • 7 edits in trunk

Web Inspector: CSSAgent.setStyleSheetText crashes on inline styles
​https://bugs.webkit.org/show_bug.cgi?id=110359

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo): Pass ExceptionCode into setText().
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::redo): Ditto.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::setText): Make use of checkPageStyleSheet().
(WebCore::InspectorStyleSheet::setRuleSelector): Ditto.
(WebCore::InspectorStyleSheet::addRule): Ditto.
(WebCore::InspectorStyleSheet::deleteRule): Ditto.
(WebCore::InspectorStyleSheet::checkPageStyleSheet):

Return NOT_SUPPORTED_ERR if no m_pageStyleSheet.

(WebCore::InspectorStyleSheet::setStyleText): Check field directly.

  • inspector/InspectorStyleSheet.h:

LayoutTests:

  • inspector/styles/styles-new-API-expected.txt:
  • inspector/styles/styles-new-API.html:
1:13 AM Changeset in webkit [144024] by commit-queue@webkit.org
  • 26 edits
    9 copies
    42 adds in trunk

Implement coordinated scrollbar for subframes and overflow:scroll
​https://bugs.webkit.org/show_bug.cgi?id=109560

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-02-26
Reviewed by James Robinson.

Source/WebCore:

This patch obsoletes ScrollingCoordinatorPrivate for the Chromium
implementation. Also removes the concept of a single main scrolling
layer. Should use HashMap to keep track resources for multiple
scrollable objects.

Many of the callbacks are extended to support ScrollableArea instead
of just FrameView. Now ScrollingCoordinatorChromium coordinates
scrollbars for both subframes and overflow:scroll.

Some drive-by change:

  1. Remove the GraphicsLayer parameter for layer change callbacks. Should be able to get the latest layer from the ScrollableArea anyway.
  2. Should start from main frame document when updating touch event target rects.

New chromium test: ScrollingCoordinatorChromiumTest.iframeScrolling

  • page/Frame.cpp:

(WebCore::Frame::willDetachPage):

  • page/FrameView.cpp:

(WebCore::FrameView::prepareForDetach):
(WebCore::FrameView::layerForScrolling):
(WebCore):

  • page/FrameView.h:

(FrameView):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::scrollLayerForScrollableArea):
(WebCore):
(WebCore::ScrollingCoordinator::horizontalScrollbarLayerForScrollableArea):
(WebCore::ScrollingCoordinator::verticalScrollbarLayerForScrollableArea):

  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::willDestroyScrollableArea):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
(WebCore::ScrollingCoordinator::scrollableAreaScrollbarLayerDidChange):
(ScrollingCoordinator):

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::scrollingWebLayerForGraphicsLayer):
(WebCore::ScrollingCoordinatorChromium::scrollingWebLayerForScrollableArea):
(WebCore::ScrollingCoordinatorChromium::ScrollingCoordinatorChromium):
(WebCore::ScrollingCoordinatorChromium::~ScrollingCoordinatorChromium):
(WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinatorChromium::touchEventTargetRectsDidChange):
(WebCore::createScrollbarLayer):
(WebCore::detachScrollbarLayer):
(WebCore::setupScrollbarLayer):
(WebCore::ScrollingCoordinatorChromium::willDestroyScrollableArea):
(WebCore::ScrollingCoordinatorChromium::scrollableAreaScrollbarLayerDidChange):
(WebCore::ScrollingCoordinatorChromium::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinatorChromium::setTouchEventTargetRects):
(WebCore::ScrollingCoordinatorChromium::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinatorChromium::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinatorChromium::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinatorChromium::setLayerIsFixedToContainerLayer):
(WebCore::ScrollingCoordinatorChromium::scrollableAreaScrollLayerDidChange):
(WebCore::ScrollingCoordinatorChromium::addWebScrollbarLayer):
(WebCore):
(WebCore::ScrollingCoordinatorChromium::getWebScrollbarLayer):
(WebCore::ScrollingCoordinatorChromium::removeWebScrollbarLayer):

  • page/scrolling/chromium/ScrollingCoordinatorChromium.h:

(WebCore):
(ScrollingCoordinatorChromium):

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollingCoordinatorMac):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::scrollableAreaScrollbarLayerDidChange):

  • platform/ScrollableArea.h:

(ScrollableArea):
(WebCore::ScrollableArea::layerForScrolling):

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer):
(WebCore::GraphicsLayer::setContentsToPlatformLayer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::layerForScrolling):
(WebCore):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateOverflowControlsLayers):
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):
(WebCore::RenderLayerBacking::updateScrollingLayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll):
(WebCore::RenderLayerCompositor::scrollingLayerDidChange):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

Source/WebKit/chromium:

Added ScrollingCoordinatorChromiumTest.iframeScrolling to verify
impl-side scrolling and impl-side scrollbars for frames.

Update ScrollingCoordinatorChromiumTest.overflowScrolling to verify
impl-side scrollbars.

  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::TEST_F):
(WebKit):

  • tests/data/iframe-scrolling-inner.html: Added.
  • tests/data/iframe-scrolling.html: Added.

LayoutTests:

Coordinated scrollbars changes drawsContent flag on scrollbar GraphicsLayers,
test expectation are updated.

  • platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
  • platform/chromium-linux/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/chromium-linux/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/chromium-linux/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/chromium-linux/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/chromium-linux/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/chromium-linux/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
  • platform/chromium-linux/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/chromium-linux/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
  • platform/chromium-linux/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium-linux/compositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/chromium-linux/compositing/iframes/resizer-expected.txt: Added.
  • platform/chromium-linux/compositing/iframes/scrolling-iframe-expected.txt: Added.
  • platform/chromium-linux/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium-linux/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt:
  • platform/chromium-linux/compositing/overflow/textarea-scroll-touch-expected.txt: Added.
  • platform/chromium-linux/compositing/overflow/updating-scrolling-content-expected.txt:
  • platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
  • platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
  • platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
  • platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-overlay-with-touch-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-content-clip-to-viewport-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/become-overlapped-iframe-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/enter-compositing-iframe-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/iframe-resize-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/iframe-size-from-zero-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/resizer-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/scrolling-iframe-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/scrolling-content-clip-to-viewport-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/scrolling-without-painting-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/updating-scrolling-content-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium/TestExpectations:
1:07 AM Changeset in webkit [144023] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r144004.
​http://trac.webkit.org/changeset/144004
​https://bugs.webkit.org/show_bug.cgi?id=110858

This iOS change is outdated (Requested by notbenjamin on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-26

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::emitNodeInConditionContext):
(BytecodeGenerator):

  • parser/Parser.cpp:

(JSC::::Parser):

  • parser/Parser.h:

(JSC::Parser::canRecurse):
(Parser):

1:06 AM Changeset in webkit [144022] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Overloaded constructors don't need header declarations
​https://bugs.webkit.org/show_bug.cgi?id=110799

Reviewed by Adam Barth.

They are implemented as static functions in cpp files.
Header declarations are not needed.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
1:04 AM Changeset in webkit [144021] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk/Source

Unreviewed, rolling out r144016.
​http://trac.webkit.org/changeset/144016
​https://bugs.webkit.org/show_bug.cgi?id=110856

Breaks compilation on chromium mac (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-26

Source/WebCore:

  • platform/chromium/KeyCodeConversionGtk.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/KeyCodeConversionTest.cpp: Removed.
12:49 AM Changeset in webkit [144020] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

Appease static analyzer warning about null string passed to strlen
​https://bugs.webkit.org/show_bug.cgi?id=110658

Reviewed by Benjamin Poulain.

Add a null check before calling strlen

  • wtf/Threading.cpp:

(WTF::createThread):

12:42 AM Changeset in webkit [144019] by glenn@skynav.com
  • 11 edits in trunk

Source/WebCore: Add support to -webkit-line-break property for CSS3 Text line-break property values and semantics.
​https://bugs.webkit.org/show_bug.cgi?id=89235

Reviewed by Eric Seidel.

This patch adds semantic support for the CSS3 line-break property (qua -webkit-line-break),
and enables testing on (apple) mac ports. Follow on patches will enable these tests on
other ports as they are incrementally verified.

See also wiki documentation at:
[1] ​http://trac.webkit.org/wiki/LineBreaking
[2] ​http://trac.webkit.org/wiki/LineBreakingCSS3Mapping

Tests: css3/line-break/line-break-auto-centered.html

css3/line-break/line-break-auto-half-kana.html
css3/line-break/line-break-auto-hyphens.html
css3/line-break/line-break-auto-inseparables.html
css3/line-break/line-break-auto-iteration-marks.html
css3/line-break/line-break-auto-postfixes.html
css3/line-break/line-break-auto-prefixes.html
css3/line-break/line-break-auto-sound-marks.html
css3/line-break/line-break-loose-centered.html
css3/line-break/line-break-loose-half-kana.html
css3/line-break/line-break-loose-hyphens.html
css3/line-break/line-break-loose-inseparables.html
css3/line-break/line-break-loose-iteration-marks.html
css3/line-break/line-break-loose-postfixes.html
css3/line-break/line-break-loose-prefixes.html
css3/line-break/line-break-loose-sound-marks.html
css3/line-break/line-break-normal-centered.html
css3/line-break/line-break-normal-half-kana.html
css3/line-break/line-break-normal-hyphens.html
css3/line-break/line-break-normal-inseparables.html
css3/line-break/line-break-normal-iteration-marks.html
css3/line-break/line-break-normal-postfixes.html
css3/line-break/line-break-normal-prefixes.html
css3/line-break/line-break-normal-sound-marks.html
css3/line-break/line-break-strict-centered.html
css3/line-break/line-break-strict-half-kana.html
css3/line-break/line-break-strict-hyphens.html
css3/line-break/line-break-strict-inseparables.html
css3/line-break/line-break-strict-iteration-marks.html
css3/line-break/line-break-strict-postfixes.html
css3/line-break/line-break-strict-prefixes.html
css3/line-break/line-break-strict-sound-marks.html

These tests were previously added in ​http://trac.webkit.org/changeset/143378, but skipped
in generic TestExpectations. In this patch, they are marked as Pass for the (apple) mac ports.

  • platform/text/LineBreakIteratorPoolICU.h:

(WebCore::LineBreakIteratorPool::makeLocaleWithBreakKeyword):
Add static function to construct ICU locale argument (also used as pool key) with additional
break keyword.
(LineBreakIteratorPool):
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
Remove direct dependency from ICU library (and types), moving that dependency into
new {open,close}LineBreakIterator() functions (defined in TextBreakIteratorICU.cpp).
Update to take line break mode into account.
Create (and cache) different break iterators depending on line break mode (in addition to locale),
which entails expanding pool entry key format to optionally append "@break=" +
"loose"|"normal"|"strict" keyword to locale string.

  • platform/text/TextBreakIterator.h:

(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::isLooseCJKMode):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
Define LineBreakIteratorMode enumeration for use in TextBreakIterator et al.
Add state member to indicate line break mode.

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::acquireLineBreakIterator):
Use new line break mode when making iterator from pool.
Handle change of return type of LineBreakIteratorPool::take() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::releaseLineBreakIterator):
Handle change of parameter type of LineBreakIteratorPool::put() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore):
(WebCore::isCJKLocale):
New functions for determining if CJK rules apply.
(WebCore::openLineBreakIterator):
New function for abstracting opening of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
This function also takes into account the line break mode.
(WebCore::closeLineBreakIterator):
(WebCore::mapLineIteratorModeToRules):
New function for abstracting closing of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
Pass line break iterator mode flag when reseting LazyLineBreakIterator.
Add looseMode local variable to prevent need for computing under isBreakable().

  • rendering/RenderText.cpp:

(WebCore::mapLineBreakToIteratorMode):
Add implementation for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
(WebCore):
(WebCore::RenderText::computePreferredLogicalWidths):
Ensure (lazy line) breakIterator is initialized for line break mode.
Ensure isBreakable() is passed loose mode flag to match behavior in RenderBlock::LineBreaker::nextLineBreak.

  • rendering/RenderText.h:

(WebCore):
Add declaration for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.

  • rendering/break_lines.cpp:

(WebCore):
Introduce (local) enum NBSPBehavior for expanding template on nextBreakablePosition.
(WebCore::isBreakableSpace):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation. Use new loose mode flavors off NBP functions.
(WebCore::needsLineBreakIterator):
Use enum NBSP behavior template parameter rather than boolean.
(WebCore::nextBreakablePositionNonLoosely):
Extend name to distinguish from loose flavor of this function.
(WebCore::nextBreakablePositionLoosely):
Add loose flavor of NBP invoked only when loose mode applies, in which case ASCII shortcut
table cannot be used.
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
Use (renamed) non-loose flavor of NBP.
(WebCore::nextBreakablePositionLoose):
(WebCore::nextBreakablePositionIgnoringNBSPLoose):
Introduce loose flavor of NBP template expansions.

  • rendering/break_lines.h:

(WebCore):
(WebCore::isBreakable):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation.

LayoutTests: CSS3: line-break property support
​https://bugs.webkit.org/show_bug.cgi?id=89235

Reviewed by Eric Seidel.

  • platform/mac/TestExpectations: Mark css3/line-break tests as passing.
12:38 AM Changeset in webkit [144018] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskipp now passing tests after r144005.
​https://bugs.webkit.org/show_bug.cgi?id=110756.

Reviewed by Geoffrey Garen.

  • platform/qt/TestExpectations:
12:34 AM Changeset in webkit [144017] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Fix continuous painting mode
​https://bugs.webkit.org/show_bug.cgi?id=110788

Patch by James Robinson <​jamesr@chromium.org> on 2013-02-26
Reviewed by Adrienne Walker.

Recent instrumentation shuffling caused WebViewImpl::didBeginFrame to no longer be called, which
broke continuous painting. Since continuous painting mode is meant to simply invalidate layers
on each frame, it's a better fit for the animation system. This moves the invalidation calls
into WebViewImpl::updateAnimations along with other animation type things.

Tested manually by enabling continuous painting mode in the inspector. There aren't any automated
tests in WebKit for this feature.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setContinuousPaintingEnabled):
(WebKit::WebViewImpl::didBeginFrame):
(WebKit::WebViewImpl::updateAnimations):

  • src/painting/ContinuousPainter.cpp:

(WebKit::ContinuousPainter::setNeedsDisplayRecursive):

12:32 AM Changeset in webkit [144016] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source

keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
​https://bugs.webkit.org/show_bug.cgi?id=85642

Source/WebCore:

Add missing key mappings for GDK_KP_Begin, GDK_KP_Insert, GDK_KP_Delete and GDK_ISO_Level3_Shift.

Patch by James Weatherall <​wez@chromium.org> on 2013-02-26
Reviewed by Ojan Vafai.

  • platform/chromium/KeyCodeConversionGtk.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

Source/WebKit/chromium:

Add tests to verify that the fixed keys generate the same keyCode values
as their equivalents.

Patch by James Weatherall <​wez@chromium.org> on 2013-02-26
Reviewed by Ojan Vafai.

  • WebKit.gypi:
  • tests/KeyCodeConversionTest.cpp: Added.

(WebCore):
(WebCore::TEST):

12:28 AM Changeset in webkit [144015] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

Unreviewed trivial !ENABLE(NETSCAPE_PLUGIN_API) build fix

Add an intermediate pluginName string variable instead of
accessing plugin.info outside the feature #ifdef.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::unavailablePluginButtonClicked):

Note: See TracTimeline for information about the timeline view.