Timeline

Mar 9, 2013:

2:48 PM Changeset in webkit [145323] by commit-queue@webkit.org

• 16 edits
  8 deletes in trunk

Unreviewed, rolling out r145299.
​http://trac.webkit.org/changeset/145299
​https://bugs.webkit.org/show_bug.cgi?id=111928

compilation failure with recent clang
(DFGBackwardsPropagationPhase.cpp:132:35: error: comparison of
constant 10 with expression of type 'bool' is always false)
(Requested by thorton on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-09

Source/JavaScriptCore:

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine):

• dfg/DFGBackwardsPropagationPhase.cpp: Removed.
• dfg/DFGBackwardsPropagationPhase.h: Removed.
• dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::run):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):

• dfg/DFGDriver.cpp:

(JSC::DFG::compile):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

• dfg/DFGNodeFlags.cpp:

(JSC::DFG::nodeFlagsAsString):
(DFG):

• dfg/DFGNodeFlags.h:

(DFG):

• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::isNotNegZero):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::isNotZero):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoForConstant):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoNonRecursive):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):

• dfg/DFGUnificationPhase.cpp:

(JSC::DFG::UnificationPhase::run):

• dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(VariableAccessData):

LayoutTests:

• fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int-expected.txt: Removed.
• fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.html: Removed.
• fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers-expected.txt: Removed.
• fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.html: Removed.
• fast/js/jsc-test-list:
• fast/js/script-tests/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js: Removed.
• fast/js/script-tests/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.js: Removed.

1:29 PM Changeset in webkit [145322] by eric.carlson@apple.com

• 11 edits
  2 adds in trunk/Source/WebCore

Enable platform code to implement text track menu
​https://bugs.webkit.org/show_bug.cgi?id=111924

Reviewed by Dean Jackson.

No new tests, the new code isn't enabled in any ports yet.

• WebCore.xcodeproj/project.pbxproj: Add PlatformTextTrack.h and PlatformTextTrackMenu.h.

• html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::createForJSConstructor): scheduleLoad -> scheduleDelayedAction.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Deal with scheduleLoad to scheduleDelayedAction rename.
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
(WebCore::HTMLMediaElement::finishParsingChildren): Ditto.
(WebCore::HTMLMediaElement::insertedInto): Ditto.
(WebCore::HTMLMediaElement::scheduleDelayedAction): Ditto.
(WebCore::HTMLMediaElement::scheduleNextSourceChild): Ditto.
(WebCore::HTMLMediaElement::loadTimerFired): Ditto.
(WebCore::HTMLMediaElement::textTrackModeChanged): Notify platform menu of track change.
(WebCore::HTMLMediaElement::playInternal): Deal with scheduleLoad to scheduleDelayedAction rename.
(WebCore::HTMLMediaElement::pauseInternal): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerDidAddTrack): Ditto. Call addTrack() instead of appending

the track directly.

(WebCore::HTMLMediaElement::setSelectedTextTrack): Deal with platform menu changing the

selected track.

(WebCore::HTMLMediaElement::platformTextTracks): Return an array of PlatformTracks representing

the current text tracks.

(WebCore::HTMLMediaElement::notifyMediaPlayerOfTextTrackChanges): Notify the platform menu

that the list of text tracks has changed.

(WebCore::HTMLMediaElement::platformTextTrackMenu): Return the platform track menu, if any.
(WebCore::HTMLMediaElement::closeCaptionTracksChanged):
(WebCore::HTMLMediaElement::addTrack): Call addTrack() instead of appending the track directly.
(WebCore::HTMLMediaElement::removeTrack): Call closeCaptionTracksChanged.
(WebCore::HTMLMediaElement::addTextTrack): Call addTrack() instead of appending the track directly.
(WebCore::HTMLMediaElement::didAddTrack): Ditto.
(WebCore::HTMLMediaElement::didRemoveTrack): Deal with scheduleLoad to scheduleDelayedAction rename.
(WebCore::HTMLMediaElement::sourceWasAdded): Ditto.
(WebCore::HTMLMediaElement::clearMediaPlayer): Forget the platform track menu.
(WebCore::HTMLMediaElement::resume): Deal with scheduleLoad to scheduleDelayedAction rename.

• html/HTMLMediaElement.h:

• html/track/InbandTextTrack.h: scheduleLoad -> scheduleDelayedAction.

• html/track/TextTrack.cpp:

(WebCore::TextTrack::platformTextTrack): Create a PlatformTextTrack.

• html/track/TextTrack.h:

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::implementsTextTrackControls): New, player private passthrough.
(WebCore::MediaPlayer::textTrackMenu): Ditto.

• platform/graphics/MediaPlayer.h:
• platform/graphics/MediaPlayerPrivate.h:

• platform/graphics/PlatformTextTrack.h: Added.

• platform/graphics/PlatformTextTrackMenu.h: Added.

1:27 PM Changeset in webkit [145321] by sadrul@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove deprecated flingStart.sourceDevice from WebGestureEvent
​https://bugs.webkit.org/show_bug.cgi?id=111866

Reviewed by James Robinson.

• public/WebInputEvent.h:

11:43 AM Changeset in webkit [145320] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

Video size calculated incorrectly when PLUGIN_PROXY_FOR_VIDEO
​https://bugs.webkit.org/show_bug.cgi?id=111912

Reviewed by Dean Jackson.

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): We use RenderPart when

PLUGIN_PROXY_FOR_VIDEO is defined, not RenderVideo.

8:54 AM Changeset in webkit [145319] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebKit/chromium

[chromium] Set the Helper Plugin's URL to that of the host document.
​https://bugs.webkit.org/show_bug.cgi?id=111913

This allows content settings, etc. to be based on the document hosting
the element that requested the Helper Plugin.

Patch by David Dorwin <​ddorwin@chromium.org> on 2013-03-09
Reviewed by Adam Barth.

• src/WebHelperPluginImpl.cpp:

(WebKit::writeDocument):
(WebKit::WebHelperPluginImpl::initialize):
(WebKit::WebHelperPluginImpl::initializePage):

• src/WebHelperPluginImpl.h:

(WebKit):
(WebHelperPluginImpl):

• src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::createHelperPlugin):

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::createHelperPlugin):

• src/WebViewImpl.h:

(WebViewImpl):

8:34 AM Changeset in webkit [145318] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Fix offset handling in GStreamer WebKitWebSource.
​https://bugs.webkit.org/show_bug.cgi?id=111888

Patch by Sebastian Dröge <​sebastian.droege@collabora.co.uk> on 2013-03-09
Reviewed by Philippe Normand.

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcSeekDataCb):
(StreamingClient::didReceiveData):
The offset handling in WebKitWebSource was completely wrong
before and caused wrong offsets to be set on the GStreamer buffers
after a seek.

Apart from that there was also a race condition that happens
when a downstream element causes seeks in very short succession
and is switching between two different parts of the stream.

4:45 AM Changeset in webkit [145317] by keishi@webkit.org

• 1 edit
  9 adds in trunk/LayoutTests

Add tests for opening the picker with the f4 key
​https://bugs.webkit.org/show_bug.cgi?id=111811

Reviewed by Kent Tamura.

• platform/chromium-win/fast/forms/calendar-picker/date-open-picker-with-f4-key-expected.txt: Added.
• platform/chromium-win/fast/forms/calendar-picker/date-open-picker-with-f4-key.html: Added.
• platform/chromium-win/fast/forms/calendar-picker/datetimelocal-open-picker-with-f4-key-expected.txt: Added.
• platform/chromium-win/fast/forms/calendar-picker/datetimelocal-open-picker-with-f4-key.html: Added.
• platform/chromium-win/fast/forms/calendar-picker/month-open-picker-with-f4-key-expected.txt: Added.
• platform/chromium-win/fast/forms/calendar-picker/month-open-picker-with-f4-key.html: Added.
• platform/chromium-win/fast/forms/calendar-picker/week-open-picker-with-f4-key-expected.txt: Added.
• platform/chromium-win/fast/forms/calendar-picker/week-open-picker-with-f4-key.html: Added.

4:43 AM Changeset in webkit [145316] by keishi@webkit.org

• 10 edits in trunk

Month transition animation is missing in some places
​https://bugs.webkit.org/show_bug.cgi?id=111908

Reviewed by Kent Tamura.

Source/WebCore:

Month transition animation was missing when navigating using keyboard
shortcuts and when navigation was trigger by selecting.

Added tests to calendar-picker/*-picker-key-operations.html.

• Resources/pagepopups/calendarPicker.js:

(Animator): Added annotations.
(Animator.prototype.isRunning): Returns true of the animation is running. Used by test.
(ScrollView.prototype.scrollAnimator): Returns the scroll animator. Used by test.
(CalendarPicker):
(CalendarPicker.prototype.onYearListViewDidSelectMonth): Use CalendarPicker.NavigationBehavior enum instead of bool.
(CalendarPicker.prototype.setSelection): Ditto.
(CalendarPicker.prototype._moveHighlight): Ditto.
(CalendarPicker.prototype.onCalendarTableKeyDown): Ditto.
(CalendarPicker.prototype.onBodyKeyDown): Ditto.

LayoutTests:

• platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
• platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
• platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
• platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:
• platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:

(isCalendarTableScrollingWithAnimation):

• platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
• platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html:

3:27 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

3:25 AM Changeset in webkit [145315] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk

Merge r144055 - REGRESSION (r143619): Crashes in three layout tests
​https://bugs.webkit.org/show_bug.cgi?id=110588

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-02-26
Reviewed by Gustavo Noronha Silva.

Source/WebKit/gtk:

Guard against null main resource identifiers. The main resource
identifier can be null at various times during the load. A null
identifier is never equal to the ones we are looking to remove.

• WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidFinishLoading): Use the new webkitWebViewRemoveSubresource helper.
(WebKit::FrameLoaderClient::dispatchDidFailLoading): ditto.

• webkit/webkitwebview.cpp:

(webkitWebViewRemoveSubresource): Added this helper which removes a subresource, but
never touches the main resource. This is adapted from the old method, for which the
main resource branch was dead code.

• webkit/webkitwebviewprivate.h: Update the method list.

3:20 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

3:19 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

3:17 AM Changeset in webkit [145314] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r145244 - [WK2][GTK] Invalid request returned by webkit_download_get_request if called before download starts
​https://bugs.webkit.org/show_bug.cgi?id=111574

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-03-08
Reviewed by Alexey Proskuryakov.

webkit_download_get_request() creates the WebKitURIRequest object
on demand using the ResourceRequest from the DownloadProxy. The
ResourceRequest of the DownloadProxy is set in
DownloadProxy::didStart(), so if we call
webkit_download_get_request() before didStart we return an invalid
WebKitURIRequest created from a NULL ResourceRequest. This is not
a problem for downloads started in the web process, because we
create the WebKitDownload after DownloadProxy::didStart(). For
downloads started manually with webkit_web_context_download_uri()
we need to create download object with the ResourceRequest passed
to the DownloadProxy.

• UIProcess/API/gtk/WebKitDownload.cpp:

(webkitDownloadCreateForRequest): New helper function for
downloads started manually to created them with a given
ResourceRequest.

• UIProcess/API/gtk/WebKitDownloadPrivate.h:
• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextStartDownload): Use
webkitDownloadCreateForRequest().

• UIProcess/API/gtk/tests/TestDownloads.cpp:

(testDownloadLocalFile):
(testDownloadLocalFileError):
(testDownloadRemoteFile):
(testDownloadRemoteFileError):
(testPolicyResponseDownload):

3:10 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

3:09 AM Changeset in webkit [145313] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r145202 - [GTK] Memory leak in webkit_web_view_load_request() in WebKit2 API
​https://bugs.webkit.org/show_bug.cgi?id=111160

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-03-08
Reviewed by Benjamin Poulain.

leakRef() is used for the returned PassRefPtr without taking the
ownership of the leaked ref.

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_request): Use RefPtr local variable.

3:08 AM Changeset in webkit [145312] by dino@apple.com

• 2 edits in trunk/Source/WebCore

Can't build w/o accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=111891

Patch originally came from Tobias Mueller <​tobiasmue@gnome.org>

Unreviewed build fix for platforms without ACCELERATED_COMPOSITING enabled, which
broke in r145057.

• dom/PseudoElement.cpp:

(WebCore::PseudoElement::~PseudoElement): Wrap the call to pseudoElementDestroyed in

USE(ACCELERATED_COMPOSITING)

3:05 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

3:04 AM Changeset in webkit [145311] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0

Merge r145307 - [GTK] Versions.m4 is missing some key dependencies version definitions
​https://bugs.webkit.org/show_bug.cgi?id=111903

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-03-09
Reviewed by Carlos Garcia Campos.

• Source/autotools/Versions.m4: Add missing required version

definitions.

3:00 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:58 AM Changeset in webkit [145310] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.0

Merge r145199 - [GTK] Remove media stream support from the configuration options
​https://bugs.webkit.org/show_bug.cgi?id=111813

Reviewed by Philippe Normand.

Remove the media-stream configuration flag. The feature is incomplete and
thus unsupported, so it really shouldn't be possible to enable it.

• Source/autotools/PrintBuildConfiguration.m4:
• Source/autotools/ReadCommandLineArguments.m4:
• Source/autotools/SetupAutomake.m4:
• Source/autotools/SetupWebKitFeatures.m4:

2:54 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:52 AM Changeset in webkit [145309] by Carlos Garcia Campos

• 10 edits in releases/WebKitGTK/webkit-2.0

Merge r145084 - [GTK] Limit the supported compilers to GCC >= 4.7 and Clang >= 3.0
​https://bugs.webkit.org/show_bug.cgi?id=109932

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2013-03-07
Reviewed by Martin Robinson.

.:

• Source/autotools/CheckSystemAndBasicDependencies.m4: Strictly check for one of the two compilers.
• Source/autotools/SetupCompilerFlags.m4: Set up C++11-specific compiler flags. Force the C99 standard for the C code.

Use the -Qunused-arguments flag when using Clang, it reduces irrelevant errors when using ccache.

Source/WebCore:

• GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.

They are now available by default due to the limited set of supported compilers.

• bindings/gobject/GNUmakefile.am: Ditto.

Source/WebKit/gtk:

• GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.

They are now available by default due to the limited set of supported compilers.

Source/WebKit2:

• GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.

They are now available by default due to the limited set of supported compilers.

1:50 AM Changeset in webkit [145308] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[GTK][WK2] Fix compilation warning missing-field-initializers in webkit-2.0 stable branch
​https://bugs.webkit.org/show_bug.cgi?id=111863

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-09
Reviewed by Benjamin Poulain.

• UIProcess/API/gtk/WebKitUIClient.cpp:

(attachUIClientToView): Include missing initializer for pluginLoadPolicy.

1:37 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

1:31 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

1:30 AM Changeset in webkit [145307] by commit-queue@webkit.org

• 2 edits in trunk

[GTK] Versions.m4 is missing some key dependencies version definitions
​https://bugs.webkit.org/show_bug.cgi?id=111903

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-03-09
Reviewed by Carlos Garcia Campos.

• Source/autotools/Versions.m4: Add missing required version

definitions.

1:30 AM Changeset in webkit [145306] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0

Merge r144222 - [GTK] Disable MathML support in release builds
​https://bugs.webkit.org/show_bug.cgi?id=110981

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2013-02-27
Reviewed by Martin Robinson.

• Source/autotools/SetupWebKitFeatures.m4: Disable the MathML support in release builds

as the code is not yet deemed production-ready.

Mar 8, 2013:

10:40 PM Changeset in webkit [145305] by robert@webkit.org

• 5 edits
  8 adds in trunk

REGRESSION(r140907): Incorrect baseline for cells with media content during load
​https://bugs.webkit.org/show_bug.cgi?id=108357

Reviewed by Julien Chaffraix.

Source/WebCore:

If a cell has replaced content, the intrinsic height of its content can change between layouts. If that's the case then the intrinsic padding we used
for layout (the padding required to push the contents of the cell down to the row's baseline) is included in the new height and baseline and makes both
of them wrong. So if a cell's content's intrinsic height has changed push the new content up into the intrinsic padding and relayout so that the rest of
table and row layout can use the correct baseline and height for this cell.

Tests: fast/css/vertical-align-baseline-rowspan-012.html

http/tests/css/vertical-align-baseline-after-image-load-2.html
http/tests/css/vertical-align-baseline-after-image-load-3.html
http/tests/css/vertical-align-baseline-after-image-load.html

• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::layout):

• rendering/RenderTableCell.h:

(WebCore::RenderTableCell::isBaselineAligned):

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

LayoutTests:

• fast/css/vertical-align-baseline-rowspan-012-expected.html: Added.
• fast/css/vertical-align-baseline-rowspan-012.html: Added.
• http/tests/css/vertical-align-baseline-after-image-load-2-expected.html: Added.
• http/tests/css/vertical-align-baseline-after-image-load-2.html: Added.
• http/tests/css/vertical-align-baseline-after-image-load-3-expected.html: Added.
• http/tests/css/vertical-align-baseline-after-image-load-3.html: Added.
• http/tests/css/vertical-align-baseline-after-image-load-expected.html: Added.
• http/tests/css/vertical-align-baseline-after-image-load.html: Added.

10:37 PM Changeset in webkit [145304] by Chris Fleizach

• 2 edits in trunk/Source/WebCore

REGRESSION: Intermittent crash in SpeechSynthesis::didFinishSpeaking
​https://bugs.webkit.org/show_bug.cgi?id=111613

Reviewed by Ryosuke Niwa.

This crash happens when the mock synthesizer utterance variable gets cleared
before the speakingFinished timer happens. I don't see how that could happen
but I was able to make a similar problem happen when cancel is called twice.

This adds in a few more asserts and common sense checks. I'm hoping it will
illuminate the problem further.

• platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):
(WebCore::PlatformSpeechSynthesizerMock::cancel):

9:54 PM Changeset in webkit [145303] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

BUILD FIX: Make WebCore link for iOS

• WebCore.exp.in:
• Add ENABLE(RUBBER_BAND) for FrameView::setWantsLayerForTopOverHangArea(bool) and FrameView::setWantsLayerForBottomOverHangArea(bool).
• Move FloatPoint::FloatPoint(_NSPoint const&) to !PLATFORM(IOS) section.

9:54 PM Changeset in webkit [145302] by ddkilzer@apple.com

• 5 edits in trunk/Websites/bugs.webkit.org

(CVE-2013-0786) [SECURITY] build_subselect() leaks the existence of products and components you cannot access
<​https://bugzilla.mozilla.org/show_bug.cgi?id=824399>
<exp2://Ticket/14465628>

Applied "v5 patch, 3.6" to bugs.webkit.org.

• Bugzilla/Config/GroupSecurity.pm:

(get_param_list):

• buglist.cgi:
• report.cgi:
• template/en/default/admin/params/groupsecurity.html.tmpl:

9:54 PM Changeset in webkit [145301] by ddkilzer@apple.com

• 3 edits in trunk/Websites/bugs.webkit.org

(CVE-2013-0785) [SECURITY] XSS in show_bug.cgi when using an invalid page format
<​https://bugzilla.mozilla.org/show_bug.cgi?id=842038>
<exp2://Ticket/14465628>

Applied "patch for 3.6 and 4.0, v1" to bugs.webkit.org.

• Bugzilla/Template.pm:

(get_format):

• show_bug.cgi:

9:20 PM May 2013 Meeting edited by rniwa@webkit.org

Add myself to pixel->ref test conversion Hackathon; also add an option … (diff)

9:11 PM May 2013 Meeting edited by rniwa@webkit.org

Rename a topic. (diff)

9:04 PM May 2013 Meeting edited by rniwa@webkit.org

Added "Reduce the amount of knowledge you need in order to contribute … (diff)

8:50 PM May 2013 Meeting edited by benjamin@webkit.org

(diff)

8:31 PM Changeset in webkit [145300] by commit-queue@webkit.org

• 9 edits in trunk

Unreviewed, rolling out r145254, r145264, and r145288.
​http://trac.webkit.org/changeset/145254
​http://trac.webkit.org/changeset/145264
​http://trac.webkit.org/changeset/145288
​https://bugs.webkit.org/show_bug.cgi?id=111917

Test breakage hints at conceptual unsoundness (Requested by ap
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-08

Source/WebKit2:

• NetworkProcess/SchedulableLoader.cpp:

(WebKit::SchedulableLoader::invalidateSandboxExtensions):

• Shared/Downloads/Download.cpp:

(WebKit::Download::didFinish):
(WebKit::Download::didFail):
(WebKit::Download::didCancel):

• Shared/SandboxExtension.h:

(SandboxExtension):
(WebKit::SandboxExtension::invalidate):

• Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::stop):

• Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::SandboxExtension):
(WebKit::SandboxExtension::invalidate):
(WebKit::SandboxExtension::consume):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::SandboxExtensionTracker::invalidate):
(WebKit::WebPage::SandboxExtensionTracker::setPendingProvisionalSandboxExtension):
(WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad):
(WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):

LayoutTests:

• platform/mac-wk2/TestExpectations:

6:51 PM Changeset in webkit [145299] by fpizlo@apple.com

• 16 edits
  8 adds in trunk

DFG overflow check elimination is too smart for its own good
​https://bugs.webkit.org/show_bug.cgi?id=111832

Source/JavaScriptCore:

Reviewed by Oliver Hunt and Gavin Barraclough.

This improves overflow check elimination in three ways:

1) It reduces the amount of time the compiler will spend doing it.

2) It fixes bugs where overflow check elimination was overzealous. Precisely, for a binary operation

over @a and @b where both @a and @b will type check that their inputs (@a->children, @b->children)
are int32's and then perform a possibly-overflowing operation, we must be careful not to assume
that @a's non-int32 parts don't matter if at the point that @a runs we have as yet not proved that
@b->children are int32's and that hence @b might produce a large enough result that doubles would
start chopping low bits. The specific implication of this is that for a binary operation to not
propagate that it cares about non-int32 parts (NodeUsedAsNumber), we must prove that at least one
of the inputs is guaranteed to produce a result within 2^{32 and that there won't be a tower of such
operations large enough to ultimately produce a double greater than 2}52 (roughly). We achieve the
latter by disabling this optimization for very large basic blocks. It's noteworthy that blocks that
large won't even make it into the DFG currently.

3) It makes the overflow check elimination more precise for cases where the inputs to an Add or Sub

are the outputs of a bit-op. For example in (@a + (@b | 0)) | 0, we don't need to propagate
NodeUsedAsNumber to either @a or @b.

This is neutral on V8v7 and a slight speed-up on compile time benchmarks.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine):

• dfg/DFGBackwardsPropagationPhase.cpp: Added.

(DFG):
(BackwardsPropagationPhase):
(JSC::DFG::BackwardsPropagationPhase::BackwardsPropagationPhase):
(JSC::DFG::BackwardsPropagationPhase::run):
(JSC::DFG::BackwardsPropagationPhase::isNotNegZero):
(JSC::DFG::BackwardsPropagationPhase::isNotZero):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwoForConstant):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwoNonRecursive):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::BackwardsPropagationPhase::mergeDefaultFlags):
(JSC::DFG::BackwardsPropagationPhase::propagate):
(JSC::DFG::performBackwardsPropagation):

• dfg/DFGBackwardsPropagationPhase.h: Added.

(DFG):

• dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::clearIsLoadedFrom):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):

• dfg/DFGDriver.cpp:

(JSC::DFG::compile):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

• dfg/DFGNodeFlags.cpp:

(JSC::DFG::dumpNodeFlags):
(DFG):

• dfg/DFGNodeFlags.h:

(DFG):

• dfg/DFGPredictionPropagationPhase.cpp:

(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::propagate):

• dfg/DFGUnificationPhase.cpp:

(JSC::DFG::UnificationPhase::run):

• dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsLoadedFrom):
(VariableAccessData):
(JSC::DFG::VariableAccessData::setIsLoadedFrom):
(JSC::DFG::VariableAccessData::isLoadedFrom):

LayoutTests:

Reviewed by Oliver Hunt and Gavin Barraclough.

• fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int-expected.txt: Added.
• fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.html: Added.
• fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers-expected.txt: Added.
• fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.html: Added.
• fast/js/jsc-test-list:
• fast/js/script-tests/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js: Added.

(foo):
(bar):

• fast/js/script-tests/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.js: Added.

(foo):
(bar):

6:29 PM Changeset in webkit [145298] by jamesr@google.com

• 13 edits
  16 adds
  2 deletes in trunk/LayoutTests

Update chromium baselines for transforms/3d/point-mapping

• platform/chromium-linux-x86/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
• platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
• platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
• platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
• platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
• platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
• platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
• platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png:
• platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
• platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
• platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
• platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
• platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
• platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png:
• platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
• platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
• platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
• platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
• platform/chromium-win-xp/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
• platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
• platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
• platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png:
• platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
• platform/chromium/TestExpectations:
• platform/chromium/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Removed.
• platform/chromium/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Removed.

5:48 PM Changeset in webkit [145297] by jchaffraix@webkit.org

• 5 edits in trunk

[CSS Grid Layout] Resolve grid-{end|after} integer against the end|after edge
​https://bugs.webkit.org/show_bug.cgi?id=111885

Reviewed by Tony Chang.

Source/WebCore:

The current code resolves grid-end (resp. grid-after) <integer>'s format against the start
(resp. before) axis. The specification changed so that they are resolved against their matching
axis.

Test: fast/css-grid-layout/grid-auto-flow-resolution.html

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::maximumIndexInDirection):
Updated the code to do the grid sizing measurement without resolveGridPositionsFromStyle. That's required
as resolveGridPositionsFromStyle requires the grid to be sized.

(WebCore::RenderGrid::placeItemsOnGrid):
Added a comment about not recomputing after grid growth. This issue was raised to www-style
(​http://lists.w3.org/Archives/Public/www-style/2013Mar/0182.html).

(WebCore::RenderGrid::resolveGridPositionsFromStyle):
Added an ASSERT now that we don't call it during grid construction. Also added some code to pass
the side of the GridPosition we give to resolveGridPositionFromStyle.

(WebCore::RenderGrid::resolveGridPositionFromStyle):
Updated the code to resolve the grid position against the right side.

• rendering/RenderGrid.h:

Added GridPositionSide and updated resolveGridPositionFromStyle's signature.

LayoutTests:

• fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:

Moar passing tests!

5:37 PM Changeset in webkit [145296] by commit-queue@webkit.org

• 17 edits
  14 deletes in trunk

Unreviewed, rolling out r142015.
​http://trac.webkit.org/changeset/142015
​https://bugs.webkit.org/show_bug.cgi?id=111904

The change caused 2 major regressions (bug 111091 and bug
111595) and Pravin doesn't have time to investigate them
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-08

Source/WebCore:

• dom/Node.cpp:

(WebCore::Node::diff):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::childBecameNonInline):
(WebCore):

• rendering/RenderBlock.h:

(RenderBlock):

• rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::childBecameNonInline):
(RenderBoxModelObject):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::childBecameNonInline):
(WebCore):

• rendering/RenderInline.h:

(RenderInline):

• rendering/RenderObject.cpp:

(WebCore):
(WebCore::RenderObject::handleDynamicFloatPositionChange):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::styleDidChange):

• rendering/RenderObject.h:

(RenderObject):

LayoutTests:

• fast/css/first-letter-removed-added-expected.txt:
• fast/dynamic/absolute-positioned-to-static-positioned-expected.txt: Removed.
• fast/dynamic/absolute-positioned-to-static-positioned.html: Removed.
• fast/dynamic/floating-to-non-floating-expected.txt: Removed.
• fast/dynamic/floating-to-non-floating.html: Removed.
• fast/dynamic/non-floating-to-floating-expected.txt: Removed.
• fast/dynamic/non-floating-to-floating.html: Removed.
• fast/dynamic/resources/helper-bug91665.js: Removed.
• fast/dynamic/resources/style-bug91665.css: Removed.
• fast/dynamic/static-positioned-to-absolute-positioned-expected.txt: Removed.
• fast/dynamic/static-positioned-to-absolute-positioned.html: Removed.
• fullscreen/full-screen-fixed-pos-parent-expected.txt:
• platform/chromium-mac/fast/repaint/absolute-position-change-containing-block-expected.png:
• platform/chromium-mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png:
• platform/chromium-win/fast/dynamic/002-expected.txt:
• platform/chromium/fast/dynamic/002-expected.txt:
• platform/chromium/fast/repaint/absolute-position-change-containing-block-expected.png: Removed.
• platform/chromium/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Removed.
• platform/mac/fast/dynamic/002-expected.txt:
• platform/mac/fast/repaint/absolute-position-change-containing-block-expected.png: Removed.
• platform/mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Removed.

5:31 PM Changeset in webkit [145295] by dino@apple.com

• 6 edits in trunk

Don't snapshot Java plugins
​https://bugs.webkit.org/show_bug.cgi?id=111899

Reviewed by Tim Horton.

Top-level:

Export MIMETypeRegistry::isJavaAppletMIMEType symbol.

• Source/autotools/symbols.filter:

Source/WebCore:

Export MIMETypeRegistry::isJavaAppletMIMEType symbol.

• WebCore.exp.in:

Source/WebKit2:

If the plugin is Java, return true from shouldAlwaysAutoStart.

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::shouldAlwaysAutoStart): Check the mimetype for Java.

5:31 PM Changeset in webkit [145294] by jparent@chromium.org

• 2 edits in trunk/Tools

Cleanup: Remove dead code.
​https://bugs.webkit.org/show_bug.cgi?id=111900

Reviewed by Dirk Pranke.

Treemap overrides a global function that used to be in
dashboard_base, but was removed months ago in
​https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
no caller.

• TestResultServer/static-dashboards/treemap.html:

5:29 PM Changeset in webkit [145293] by rafaelw@chromium.org

• 4 edits in trunk

[HTMLTemplateElement] processTemplateEndTag() needs to check for template in html scope
​https://bugs.webkit.org/show_bug.cgi?id=111880

Reviewed by Eric Seidel.

Source/WebCore:

Currently, </template> handling exits with an error if there is not a template tag "in scope"
which will be true if there is a table (for instance) below a template. This makes it so that
the search (correctly) examines the entire element stack.

Tests added to html5lib testing library.

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processTemplateEndTag):

LayoutTests:

• html5lib/resources/template.dat:

5:06 PM Changeset in webkit [145292] by eric@webkit.org

• 19 edits
  2 adds in trunk/Source/WebCore

BackgroundHTMLParser should be able to atomize well-known strings
​https://bugs.webkit.org/show_bug.cgi?id=107337

Reviewed by Adam Barth.

Testing this patch easily requires applying bug 107236 locally
to remove all the rendering noise from Parser/html-threaded-parser.html.

This patch adds a new class HTMLIdentifier which allows us to avoid
allocating strings for known tag/attribute names from HTMLNames.

There is still a lot of meat on this bone, but I think it's important to
land something "smallish" to start and iterate from there.

This took Parser/html-threaded-parser.html from:
median= 443.726500002 ms, stdev= 7.25002679952 ms, min= 430.244000047 ms, max= 455.511000007 ms
to:
median= 427.849500004 ms, stdev= 9.96967058292 ms, min= 417.914000049 ms, max= 461.528000014 ms
on my MBP.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• html/parser/AtomicHTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

• html/parser/BackgroundHTMLParser.cpp:

(WebCore::tokenExitsForeignContent):
(WebCore::tokenExitsSVG):
(WebCore::tokenExitsMath):
(WebCore::BackgroundHTMLParser::simulateTreeBuilder):

• html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::scan):

• html/parser/CSSPreloadScanner.h:

(WebCore):
(CSSPreloadScanner):

• html/parser/CompactHTMLToken.cpp:

(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken):

• html/parser/CompactHTMLToken.h:

(WebCore::CompactHTMLToken::Attribute::Attribute):
(Attribute):
(WebCore::CompactHTMLToken::data):
(WebCore::CompactHTMLToken::publicIdentifier):
(CompactHTMLToken):

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::startBackgroundParser):

• html/parser/HTMLIdentifier.cpp: Added.

(WebCore):
(WebCore::identifierTable):
(WebCore::HTMLIdentifier::hasIndex):
(WebCore::HTMLIdentifier::findIndex):
(WebCore::nameForIndex):
(WebCore::HTMLIdentifier::asString):
(WebCore::HTMLIdentifier::asStringImpl):
(WebCore::HTMLIdentifier::addNames):
(WebCore::HTMLIdentifier::init):

• html/parser/HTMLIdentifier.h: Added.

(WebCore):
(HTMLIdentifier):
(WebCore::HTMLIdentifier::HTMLIdentifier):
(WebCore::HTMLIdentifier::isSafeToSendToAnotherThread):

• html/parser/HTMLParserIdioms.cpp:

(WebCore::threadSafeEqual):
(WebCore::threadSafeMatch):

• html/parser/HTMLParserIdioms.h:

(WebCore):
(WebCore::threadSafeHTMLNamesMatch):

• html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::tagIdFor):
(WebCore::TokenPreloadScanner::StartTagScanner::match):
(TokenPreloadScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

• html/parser/HTMLPreloadScanner.h:

4:56 PM Changeset in webkit [145291] by Lucas Forschler

• 6 edits in tags/Safari-537.33.2/Source

Merged r145247. <rdar://problem/13383659>

4:53 PM Changeset in webkit [145290] by Lucas Forschler

• 4 edits in tags/Safari-537.33.2/Source

Versioning.

4:49 PM Changeset in webkit [145289] by Lucas Forschler

• 1 copy in tags/Safari-537.33.2

New Tag.

4:42 PM Changeset in webkit [145288] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Add a failing test expectation per bug 111901.

• platform/mac-wk2/TestExpectations:

4:29 PM Changeset in webkit [145287] by jamesr@google.com

• 3 edits
  3 copies in trunk/LayoutTests

Update a few more chromium baselines.

• platform/chromium-mac-lion/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
• platform/chromium-mac/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
• platform/chromium-win-xp/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
• platform/chromium-win-xp/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
• platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt:

4:17 PM Changeset in webkit [145286] by Lucas Forschler

• 4 edits in branches/safari-536.29-branch/Source

Versioning.

4:15 PM Changeset in webkit [145285] by Lucas Forschler

• 1 copy in tags/Safari-536.29.6

New Tag.

4:15 PM Changeset in webkit [145284] by Lucas Forschler

• 5 edits in branches/safari-534.59-branch/Source

Versioning.

4:14 PM Changeset in webkit [145283] by Lucas Forschler

• 1 copy in tags/Safari-534.59.2

New Tag.

4:10 PM Changeset in webkit [145282] by Lucas Forschler

• 3 edits in branches/safari-536.29-branch/Source/WebKit2

Windows build fix #2.
<rdar://problem/13380471> REGRESSION: Debussy Windows broken after merging ​http://trac.webkit.org/changeset/144831

Reviewed by Roger Fong.

• win/WebKit2.def:
• win/WebKit2.vcproj:

3:57 PM Changeset in webkit [145281] by Lucas Forschler

• 2 edits in branches/safari-536.29-branch/Source/WebKit2

Windows build fix.
<rdar://problem/13380471> REGRESSION: Debussy Windows broken after merging ​http://trac.webkit.org/changeset/144831

Reviewed by Roger Fong.

• win/WebKit2.def:

3:47 PM Changeset in webkit [145280] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Check to ensure MultisampleRenderbuffer creation succeeds
​https://bugs.webkit.org/show_bug.cgi?id=111780

Patch by Brandon Jones <​bajones@google.com> on 2013-03-08
Reviewed by Dean Jackson.

On OSX systems using AMD graphics chips the allocation of large
Multisample Renderbuffers in Chromium would fail without any indication
of failure. Attempting to draw to the buffer resulted in garbage being
rendered onscreen. This could be reproduced by opening a full-page
WebGL app and pressing (Command + "-") several times. This patch adds an
additional check during DrawingBuffer resize to verify that the resized
buffer is valid.

• platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):
(WebCore::DrawingBuffer::checkBufferIntegrity):
(WebCore::DrawingBuffer::reset):

• platform/graphics/gpu/DrawingBuffer.h:

(DrawingBuffer):

3:45 PM Changeset in webkit [145279] by commit-queue@webkit.org

• 19 edits
  3 deletes in trunk

Implemented new API for RTCStatsReport object.
​https://bugs.webkit.org/show_bug.cgi?id=110333

Source/Platform:

Patch by Harald Alvestrand <​hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.

• chromium/public/WebRTCStatsResponse.h:

(WebKit::WebRTCStatsResponse::WebRTCStatsResponse):
(WebRTCStatsResponse):

Source/WebCore:

Removed RTCStatsElement object, moved its interface to
RTCStatsReport. Preserved some interfaces for
backwards compatibility; will be removed in a later patch.

Patch by Harald Alvestrand <​hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.

Tested by extensions to RTCPeerConnection-stats test.

• Modules/mediastream/RTCStatsElement.cpp: Removed.
• Modules/mediastream/RTCStatsElement.h: Removed.
• Modules/mediastream/RTCStatsElement.idl: Removed.
• Modules/mediastream/RTCStatsReport.cpp:

(WebCore::RTCStatsReport::create):
(WebCore::RTCStatsReport::RTCStatsReport):
(WebCore):
(WebCore::RTCStatsReport::names):
(WebCore::RTCStatsReport::local):
(WebCore::RTCStatsReport::remote):
(WebCore::RTCStatsReport::addStatistic):
(WebCore::RTCStatsReport::addElement):

• Modules/mediastream/RTCStatsReport.h:

(RTCStatsReport):
(WebCore::RTCStatsReport::timestamp):
(WebCore::RTCStatsReport::id):
(WebCore::RTCStatsReport::stat):

• Modules/mediastream/RTCStatsReport.idl:
• Modules/mediastream/RTCStatsResponse.cpp:

(WebCore::RTCStatsResponse::namedItem):
(WebCore):
(WebCore::RTCStatsResponse::addReport):
(WebCore::RTCStatsResponse::addStatistic):

• Modules/mediastream/RTCStatsResponse.h:

(RTCStatsResponse):

• Modules/mediastream/RTCStatsResponse.idl:
• WebCore.gypi:
• platform/chromium/support/WebRTCStatsResponse.cpp:

(WebKit::WebRTCStatsResponse::addReport):
(WebKit):
(WebKit::WebRTCStatsResponse::addStatistic):
(WebKit::WebRTCStatsResponse::addElement):

• platform/mediastream/RTCStatsResponseBase.h:

(RTCStatsResponseBase):

Tools:

Patch by Harald Alvestrand <​hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.

• DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:

(WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):

LayoutTests:

Patch by Harald Alvestrand <​hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.

• fast/mediastream/RTCPeerConnection-stats-expected.txt:
• fast/mediastream/RTCPeerConnection-stats.html:

3:40 PM Changeset in webkit [145278] by jamesr@google.com

• 4 edits
  7 copies
  36 adds in trunk/LayoutTests

Chromium rebaselines and expectations updates.

• platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
• platform/chromium-linux/compositing/tiling/rotated-tiled-clamped-expected.png: Added.
• platform/chromium-linux/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
• platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
• platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
• platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
• platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
• platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
• platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
• platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
• platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium-mac/compositing/tiling/rotated-tiled-clamped-expected.png: Added.
• platform/chromium-mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
• platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png: Added.
• platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png: Added.
• platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.png: Added.
• platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png: Added.
• platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png: Added.
• platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scroll-expected.txt: Added.
• platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
• platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
• platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
• platform/chromium-win/compositing/tiling/rotated-tiled-clamped-expected.png: Added.
• platform/chromium-win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
• platform/chromium-win/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium-win/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scroll-expected.txt: Added.
• platform/chromium-win/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
• platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
• platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium/TestExpectations:
• platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
• platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
• platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.txt: Added.
• platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.

3:39 PM Changeset in webkit [145277] by eric@webkit.org

• 6 edits in trunk/Source/WebCore

Free up background parser's checkpoints when speculation succeeds
​https://bugs.webkit.org/show_bug.cgi?id=110547

Reviewed by Adam Barth.

This should be a memory (and possible perf) win while parsing
pages, as we will no longer hold multiple copies of every
source byte during the whole parse.

Many LayoutTests exercise this code path, and I've manually (debugger and printf)
that we're hitting this code, but we'll have to wait for the memory/perf bots
to tell us if this shows up as a win.

We only bother to message the parser at the end of a speculation chain, so as not
to send too many messages to the background parser.

• html/parser/BackgroundHTMLInputStream.cpp:

(WebCore::BackgroundHTMLInputStream::BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::invalidateCheckpointsUpThrough):
(WebCore):
(WebCore::BackgroundHTMLInputStream::rewindTo):

• html/parser/BackgroundHTMLInputStream.h:

(BackgroundHTMLInputStream):
(Checkpoint):
(WebCore::BackgroundHTMLInputStream::Checkpoint::isNull):
(WebCore::BackgroundHTMLInputStream::Checkpoint::clear):

• html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::passedCheckpoint):
(WebCore):

• html/parser/BackgroundHTMLParser.h:

(BackgroundHTMLParser):

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpPendingSpeculations):

3:27 PM Changeset in webkit [145276] by commit-queue@webkit.org

• 3 edits
  1 add in trunk

[chromium] Keydown event for 'shift+alt' returns win keycode instead of 'alt'
​https://bugs.webkit.org/show_bug.cgi?id=111112

Patch by Chandra Shekar Vallala <​brk376@motorola.com> on 2013-03-08
Reviewed by Tony Chang.

.:

Return windows keycode of Alt incase of GDK_META_L, GDK_META_R.

Try press Shift then alt key. The test passes if the shiftKey, altKey values
of JSKeyEvent are true and keycode/which is 18.

• ManualTests/shift-alt-key-event.html: Added.

Source/WebCore:

Return windows keycode of Alt incase of GDK_META_L, GDK_META_R. This matches
the firefox behaviour in linux platform.

Added Manual Test : ManualTests/shift-alt-key-event.html
Try press Shift then alt key. The test passes if the shiftKey, altKey values
of JSKeyEvent are true and keycode/which is 18.

• platform/chromium/KeyCodeConversionGtk.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

3:11 PM Changeset in webkit [145275] by jamesr@google.com

• 20 edits
  5 copies in branches/chromium/1364

Merge 144236

Plugin in iframe may not display
​https://bugs.webkit.org/show_bug.cgi?id=109879

Patch by John Bauman <​jbauman@chromium.org> on 2013-02-27
Reviewed by Simon Fraser.

Source/WebCore:

Changing the cliprect on a layer containing an iframe may change the
cliprect of plugins inside the iframe, so recursively tell all plugins
in iframes that their cliprect has changed after doing layout on the
outer frame.

Test: plugins/plugin-clip-subframe.html

• platform/ScrollView.cpp:

(WebCore::ScrollView::clipRectChanged):

• platform/ScrollView.h:
• platform/Widget.h:

(WebCore::Widget::clipRectChanged):

• plugins/PluginView.cpp:

(WebCore::PluginView::clipRectChanged):

• plugins/PluginView.h:
• rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):

Source/WebKit/chromium:

Use clipRectChanged to update the geometry.

• src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::clipRectChanged):

• src/WebPluginContainerImpl.h:

Source/WebKit/mac:

Ensure NetscapePluginWidget informs the plugin view of the cliprect change directly.

• Plugins/WebBaseNetscapePluginView.h:
• WebCoreSupport/WebFrameLoaderClient.mm:

(NetscapePluginWidget::clipRectChanged):

Source/WebKit2:

Update geometry when cliprect changes.

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::clipRectChanged):

• WebProcess/Plugins/PluginView.h:

Tools:

LogNPPSetWindow will be used with other ports as well.

• DumpRenderTree/DumpRenderTree.gypi:
• DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:

LayoutTests:

Use log-npp-set-window to ensure plugin clip changes correctly.

• platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt: Added.
• platform/mac/plugins/plugin-clip-subframe-expected.txt: Added.
• plugins/plugin-clip-subframe-expected.txt: Added.
• plugins/plugin-clip-subframe.html: Added.
• plugins/resources/plugin-clip-subframe-iframe.html: Added.

BUG=168900
TBR=​jbauman@chromium.org
Review URL: ​https://codereview.chromium.org/12475008

2:57 PM Changeset in webkit [145274] by jamesr@google.com

• 18 edits
  1 copy
  1 move
  14 adds in trunk/LayoutTests

Update some more chromium compositor pixel baselines.

• platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
• platform/chromium-linux/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
• platform/chromium-linux/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium-linux/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
• platform/chromium-linux/compositing/reflections/load-video-in-reflection-expected.png:
• platform/chromium-linux/compositing/reflections/nested-reflection-anchor-point-expected.png:
• platform/chromium-mac-lion/compositing/masks/simple-composited-mask-expected.png:
• platform/chromium-mac-lion/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium-mac-lion/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
• platform/chromium-mac-lion/compositing/reflections/load-video-in-reflection-expected.png:
• platform/chromium-mac-lion/compositing/reflections/nested-reflection-anchor-point-expected.png:
• platform/chromium-mac-snowleopard/compositing/masks/simple-composited-mask-expected.png:
• platform/chromium-mac-snowleopard/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium-mac-snowleopard/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
• platform/chromium-mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png:
• platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png:
• platform/chromium-mac/compositing/masks/simple-composited-mask-expected.png:
• platform/chromium-mac/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium-mac/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
• platform/chromium-mac/compositing/reflections/load-video-in-reflection-expected.png:
• platform/chromium-mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
• platform/chromium-win/compositing/masks/simple-composited-mask-expected.png:
• platform/chromium-win/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
• platform/chromium-win/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
• platform/chromium-win/compositing/reflections/load-video-in-reflection-expected.png:
• platform/chromium-win/compositing/reflections/nested-reflection-anchor-point-expected.png:
• platform/chromium/TestExpectations:
• platform/chromium/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
• platform/chromium/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
• platform/chromium/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.txt: Added.
• platform/efl-wk2/compositing/reflections/nested-reflection-anchor-point-expected.png: Renamed from LayoutTests/platform/efl/compositing/reflections/nested-reflection-anchor-point-expected.png.

2:45 PM Changeset in webkit [145273] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r187037. Requested by
"James Robinson" <​jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-08

• DEPS:

2:41 PM Changeset in webkit [145272] by dpranke@chromium.org

• 2 edits in trunk/Tools

[chromium] use custom freetype on linux asan builds again
​https://bugs.webkit.org/show_bug.cgi?id=111884

Reviewed by Tony Chang.

We no longer need the workaround after chromium r186540.

• DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

2:38 PM Changeset in webkit [145271] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed gardening. AppleWin port.

• platform/win/TestExpectations:

2:36 PM Changeset in webkit [145270] by rniwa@webkit.org

• 2 edits in trunk/Tools

Warning about the user not having edit rights on Bugzilla is confusing new contributors
​https://bugs.webkit.org/show_bug.cgi?id=111798

Reviewed by Dirk Pranke.

Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.

• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

2:32 PM May 2013 Meeting edited by rniwa@webkit.org

Add a new topic (diff)

2:26 PM Changeset in webkit [145269] by jamesr@google.com

• 6 edits
  3 deletes in trunk/LayoutTests

Update baselines for a few chromium compositor tests.

• platform/chromium-linux/compositing/checkerboard-expected.png: Removed.
• platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
• platform/chromium-mac-lion/compositing/checkerboard-expected.png: Removed.
• platform/chromium-mac/compositing/checkerboard-expected.png:
• platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
• platform/chromium-win/compositing/checkerboard-expected.png: Removed.
• platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
• platform/chromium/TestExpectations:

2:19 PM Changeset in webkit [145268] by mkwst@chromium.org

• 3 edits
  2 adds in trunk

CSP: 'eval()' is blocked in report-only mode.
​https://bugs.webkit.org/show_bug.cgi?id=111867

Reviewed by Adam Barth.

Source/WebCore:

Setting a 'Content-Security-Policy-Report-Only' header should not have
any effect on what a page actually executes. Currently, however, setting
a 'script-src' directive that doesn't whitelist 'unsafe-eval' actually
blocks 'eval()' on the page. This patch fixes that by checking whether
we're in report-only mode before turning 'eval()' off inside the script
engine.

This leaves us in a weird state, however. We don't currently have any
mechanism of explaining to the VM that we just want to be notified of
'eval()' usage. I've filed ​http://wkbug.com/111869 to cover this
aspect.

Test: http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode.html

• page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::didReceiveHeader):

For each policy we parse, check that we're only turning off eval in
the VM when we're in enforce mode. If we're in report-only mode,
skip it.

LayoutTests:

• http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode.html: Added.

2:09 PM Changeset in webkit [145267] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/13338743> Fix sandbox profile preprocessor flags for compatibility with new clang.

Reviewed by Alexey Proskuryakov.
Patch by Bob Wilson.

• DerivedSources.make: Only use -traditional when we have to work around old behavior of -std=c89.

1:47 PM Changeset in webkit [145266] by jamesr@google.com

• 3 edits
  1 delete in trunk/LayoutTests

Update baselines for string prototypes fixed by v8-i18n roll 164:171

• platform/chromium/fast/js/kde/function_length-expected.txt: Removed.
• platform/chromium/fast/js/kde/inbuilt_function_tostring-expected.txt:
• platform/chromium/fast/js/string-prototype-properties-expected.txt:

1:45 PM Changeset in webkit [145265] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

REGRESSION (r143643): <button> should support ::first-line and ::first-letter
​https://bugs.webkit.org/show_bug.cgi?id=111782

Patch by Christian Biesinger <​cbiesinger@chromium.org> on 2013-03-08
Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/forms/button-first-line-first-letter.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::firstLineBlock):
(WebCore::findFirstLetterBlock):
Add isRenderButton to the first-line and first-letter checks that
don't allow ::first-* styles for flexbox.

LayoutTests:

• fast/forms/button-first-line-first-letter-expected.html: Added.
• fast/forms/button-first-line-first-letter.html: Added.

1:25 PM Changeset in webkit [145264] by joone.hur@intel.com

• 2 edits in trunk/Source/WebKit2

Unreviewed build fix for EFL, GTK and Qt after r145254.

• Shared/SandboxExtension.h:

(WebKit::SandboxExtension::revoke):

1:20 PM Changeset in webkit [145263] by jamesr@google.com

• 2 edits in trunk/LayoutTests

Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=88131

Reviewed by Tony Chang.

This test was calling setTimeout(..., 0) in a <script> block before the end of the document.
The timeout sometimes fired before parsing the rest of the document and sometimes after,
depending on when the parser yielded. This moves the <script> block to the end of the document
so it always runs after parsing the rest of the test, which is the more common and expected
behavior.

• fast/dom/HTMLMeterElement/meter-element-crash.html:

1:14 PM Changeset in webkit [145262] by roger_fong@apple.com

• 2 edits in trunk/Source/WebKit

Build fix for AppleWin VS2010.

• WebKit.vcxproj/FeatureDefines.props:

1:11 PM Changeset in webkit [145261] by ggaren@apple.com

• 1 edit
  3 adds in trunk/LayoutTests

Added a regression test for raw parsing speed
​https://bugs.webkit.org/show_bug.cgi?id=111808

Reviewed by Oliver Hunt.

• fast/js/regress/nested-function-parsing-random.html: Added.
• fast/js/regress/script-tests/nested-function-parsing-random.js: Added.

(randomIdent): Use randomness to defeat caching.

1:11 PM Changeset in webkit [145260] by ggaren@apple.com

• 3 edits in trunk/Source/WebCore

Removed an out-of-date comment from SharedTimer
​https://bugs.webkit.org/show_bug.cgi?id=111875

Reviewed by Mark Hahnenberg.

Even if we surround each call to an ObjC interface with an autorelease
pool, it's still nice to have one at top-level entry points like
timers, to avoid turning a single mistake into a long-term leak.

• platform/ios/SharedTimerIOS.mm:

(WebCore::timerFired):

• platform/mac/SharedTimerMac.mm:

(WebCore::timerFired):

1:04 PM Changeset in webkit [145259] by jamesr@google.com

• 2 edits
  6 adds in trunk/LayoutTests

Chromium gardening.

• platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
• platform/chromium-linux/editing/pasteboard/paste-text-016-expected.txt: Added.
• platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
• platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-016-expected.txt: Added.
• platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
• platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
• platform/chromium/TestExpectations:

1:02 PM Changeset in webkit [145258] by commit-queue@webkit.org

• 12 edits
  1 delete in trunk

[chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
​https://bugs.webkit.org/show_bug.cgi?id=111632

Patch by James Robinson <​jamesr@chromium.org> on 2013-03-08
Reviewed by Adrienne Walker.

Source/Platform:

Neither of these are used any more. All callbacks from the compositor are handled by
the embedder and plumbed (where appropriate) through the WebWidget/WebView APIs. All
settings are handled by the embedder.

• Platform.gypi:
• chromium/public/WebLayerTreeView.h:

(WebKit):

• chromium/public/WebLayerTreeViewClient.h: Removed.
• chromium/public/WebUnitTestSupport.h:

(WebKit):

Source/WebKit/chromium:

• public/WebWidgetClient.h:

(WebWidgetClient):
(WebKit::WebWidgetClient::initializeLayerTreeView):

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

• src/WebViewImpl.h:
• tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::FakeWebViewClient::initializeLayerTreeView):

Tools:

• DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::initializeLayerTreeView):

• DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

12:56 PM Changeset in webkit [145257] by rniwa@webkit.org

• 9 edits
  13 adds in trunk/LayoutTests

Mac rebaseline after r145242. I'm really hoping that the optimization didn't mess this up.

• css1/box_properties/margin_bottom-expected.txt: Replaced.
• css1/box_properties/margin_top-expected.txt: Replaced.
• css1/box_properties/padding_bottom-expected.txt: Replaced.
• css1/box_properties/padding_top-expected.txt: Replaced.
• css1/color_and_background/background_attachment-expected.txt: Replaced.
• platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
• platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
• platform/mac/css3/flexbox/flexbox-baseline-expected.txt:
• platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
• platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
• platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
• platform/mac/tables/mozilla/bugs/bug126742-expected.txt:
• platform/mac/tables/mozilla/bugs/bug69187-expected.txt:
• platform/win-future/css1: Added.
• platform/win-future/css1/box_properties: Added.
• platform/win-future/css1/box_properties/margin_bottom-expected.txt: Added.
• platform/win-future/css1/box_properties/margin_top-expected.txt: Added.
• platform/win-future/css1/box_properties/padding_bottom-expected.txt: Added.
• platform/win-future/css1/box_properties/padding_top-expected.txt: Added.
• platform/win-future/css1/color_and_background: Added.
• platform/win-future/css1/color_and_background/background_attachment-expected.txt: Added.

12:47 PM Changeset in webkit [145256] by rniwa@webkit.org

• 2 edits in trunk/Source/WebKit2

non-Mac ports build fix after r145235.

• UIProcess/WebInspectorProxy.cpp:

(WebKit::createInspectorPageGroup):

12:40 PM Changeset in webkit [145255] by benjamin@webkit.org

• 31 edits in trunk

[Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
​https://bugs.webkit.org/show_bug.cgi?id=111297

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The 'view-mode' Media Feature spec is implemented in WebCore but
there is no WebKit support for it on Mac.
Because of this, we always lie and report a windowed view mode.

This patch add a feature flag for the feature and disable it on
Mac so that we stop reporting incorrect default values.

• WebCore.exp.in:
• css/CSSValueKeywords.in:
• css/MediaFeatureNames.h:

(MediaFeatureNames):

• css/MediaQueryEvaluator.cpp:
• css/MediaQueryExp.cpp:

(WebCore::featureWithCSSValueID):
(WebCore::featureWithoutValue):

• page/Page.cpp:

(WebCore::Page::Page):

• page/Page.h:

(Page):

Source/WebKit2:

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
• WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
• WebProcess/WebPage/WebPage.cpp:
• WebProcess/WebPage/WebPage.h:

Source/WTF:

• wtf/FeatureDefines.h: Add a new feature flag for the view-mode

CSS media: ENABLE_VIEW_MODE_CSS_MEDIA.

Tools:

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setViewModeMediaFeature):

LayoutTests:

• platform/mac/TestExpectations:

Mark the view-mode tests as failing to track any regression
or crash in this area.

12:25 PM Changeset in webkit [145254] by ap@apple.com

• 7 edits in trunk/Source/WebKit2

Make it possible to reuse sandbox extensions
​https://bugs.webkit.org/show_bug.cgi?id=111883

Reviewed by Anders Carlsson.

Replaced invalidate() with revoke().

We now count how many times consume() was called, and keep the extension active
for as long as revoke() hasn't been called as many times. Also, we only permanently
destroy the extension in destructor.

This allows for properly keeping extensions in NetworkBlobRegistry for as long as
they are needed.

• NetworkProcess/SchedulableLoader.cpp: (WebKit::SchedulableLoader::invalidateSandboxExtensions):
• Shared/Downloads/Download.cpp: (WebKit::Download::didFinish): (WebKit::Download::didFail): (WebKit::Download::didCancel):
• Shared/SandboxExtension.h: (SandboxExtension):
• Shared/WebMemorySampler.cpp: (WebKit::WebMemorySampler::stop):
• Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::SandboxExtension): (WebKit::SandboxExtension::revoke): (WebKit::SandboxExtension::consume):
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::performDragControllerAction): (WebKit::WebPage::SandboxExtensionTracker::invalidate): (WebKit::WebPage::SandboxExtensionTracker::setPendingProvisionalSandboxExtension): (WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad): (WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):

12:11 PM Changeset in webkit [145253] by rniwa@webkit.org

• 9 edits
  4 adds in trunk

After sending message, Mail changes formatting
​https://bugs.webkit.org/show_bug.cgi?id=111360

Reviewed by Enrica Casucci.

Source/WebCore:

Added makeInsertedContentRoundTrippableWithHTMLTreeBuilder to move prohibited children (e.g. p, h1, etc...)
out of paragraph elements to run immediately after the fragment insertion. This function splits trees and
moves prohibited children out of paragraph elements to keep the tree isomorphic under HTML serialization and
parsing. Unfortunately, there are many other DOM tree constructs we need to fix to make the subtree truly
isomorphic but this is a step forward.

Test: editing/pasteboard/pasting-into-p-should-not-nest-p.html

• editing/ReplaceSelectionCommand.cpp:

(WebCore::isProhibitedParagraphChild): Added. Matches the list at
​https://dvcs.w3.org/hg/editing/raw-file/57abe6d3cb60/editing.html#prohibited-paragraph-child
except main element, which is currently missing in the specification.
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder): Added.
(WebCore::ReplaceSelectionCommand::moveNodeOutOfAncestor): Added.
(WebCore::ReplaceSelectionCommand::doApply): Call moveProhibitedChildrenOutOfParagraphElements.

• editing/ReplaceSelectionCommand.h:

(ReplaceSelectionCommand):

LayoutTests:

Added a regression test, demonstrating that a paragraph element is not nested after a paste.
Also rebaselined multiple tests that had been exhibiting this bug in their expected results.

• editing/pasteboard/block-wrappers-necessary-expected.txt:
• editing/pasteboard/paste-table-001-expected.txt:
• editing/pasteboard/paste-text-011-expected.txt:
• editing/pasteboard/paste-text-015-expected.txt:
• editing/pasteboard/pasting-into-p-should-not-nest-p-expected.txt: Added.
• editing/pasteboard/pasting-into-p-should-not-nest-p.html: Added.
• editing/pasteboard/pasting-into-h6-should-not-nest-h6-expected.txt: Added.
• editing/pasteboard/pasting-into-h6-should-not-nest-h6.html: Added.
• platform/mac/editing/pasteboard/paste-text-016-expected.txt:

11:58 AM Changeset in webkit [145252] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r186991. Requested by
"James Robinson" <​jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-08

• DEPS:

11:34 AM Changeset in webkit [145251] by eae@chromium.org

• 58 edits
  18 adds
  20 deletes in trunk/LayoutTests

Unreviewed chromium mac/win rebaselines for r145242.

• css1/basic/inheritance-expected.txt: Added.
• css1/box_properties/clear_float-expected.txt: Added.
• css1/box_properties/margin-expected.txt: Added.
• css1/box_properties/padding-expected.txt: Added.
• css1/font_properties/font_weight-expected.txt: Added.
• fast/css-generated-content/015-expected.txt: Added.
• fast/css/h1-in-section-elements-expected.txt: Added.
• platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
• platform/chromium-mac-lion/css1/box_properties/clear_float-expected.png:
• platform/chromium-mac-lion/css1/box_properties/padding-expected.png:
• platform/chromium-mac-lion/css1/font_properties/font_weight-expected.png:
• platform/chromium-mac-lion/css3/flexbox/flexbox-baseline-expected.png:
• platform/chromium-mac-lion/fast/css/h1-in-section-elements-expected.png:
• platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
• platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
• platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
• platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
• platform/chromium-mac-lion/tables/mozilla/bugs/bug126742-expected.png:
• platform/chromium-mac-lion/tables/mozilla/bugs/bug69187-expected.png:
• platform/chromium-mac-lion/tables/mozilla/bugs/bug73321-expected.png:
• platform/chromium-mac-lion/tables/mozilla/bugs/bug73321-expected.txt: Added.
• platform/chromium-mac-snowleopard/css1/basic/inheritance-expected.png:
• platform/chromium-mac-snowleopard/css1/box_properties/padding-expected.png:
• platform/chromium-mac-snowleopard/css1/color_and_background/background_attachment-expected.png:
• platform/chromium-mac-snowleopard/css1/font_properties/font_weight-expected.png:
• platform/chromium-mac-snowleopard/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
• platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png:
• platform/chromium-mac-snowleopard/fast/css/h1-in-section-elements-expected.png:
• platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
• platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
• platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
• platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
• platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug126742-expected.png:
• platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug69187-expected.png:
• platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.png:
• platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.txt: Added.
• platform/chromium-mac/css1/basic/inheritance-expected.txt: Removed.
• platform/chromium-mac/css1/box_properties/clear_float-expected.png:
• platform/chromium-mac/css1/box_properties/clear_float-expected.txt: Removed.
• platform/chromium-mac/css1/box_properties/margin-expected.txt: Removed.
• platform/chromium-mac/css1/box_properties/margin_bottom-expected.txt: Added.
• platform/chromium-mac/css1/box_properties/margin_top-expected.txt: Added.
• platform/chromium-mac/css1/box_properties/padding-expected.png:
• platform/chromium-mac/css1/box_properties/padding-expected.txt: Removed.
• platform/chromium-mac/css1/box_properties/padding_bottom-expected.txt: Added.
• platform/chromium-mac/css1/box_properties/padding_top-expected.txt: Added.
• platform/chromium-mac/css1/color_and_background/background_attachment-expected.txt: Added.
• platform/chromium-mac/css1/font_properties/font_weight-expected.png:
• platform/chromium-mac/css1/font_properties/font_weight-expected.txt: Removed.
• platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.txt:
• platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
• platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png:
• platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt:
• platform/chromium-mac/fast/css-generated-content/015-expected.txt: Removed.
• platform/chromium-mac/fast/css/h1-in-section-elements-expected.png:
• platform/chromium-mac/fast/css/h1-in-section-elements-expected.txt: Removed.
• platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
• platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
• platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
• platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
• platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.
• platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
• platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
• platform/chromium-mac/tables/mozilla/bugs/bug126742-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug126742-expected.txt:
• platform/chromium-mac/tables/mozilla/bugs/bug69187-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug69187-expected.txt:
• platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
• platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.txt: Added.
• platform/chromium-win/css1/basic/inheritance-expected.png:
• platform/chromium-win/css1/box_properties/clear_float-expected.png:
• platform/chromium-win/css1/box_properties/margin_top-expected.png:
• platform/chromium-win/css1/font_properties/font_weight-expected.png:
• platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png:
• platform/chromium-win/fast/css/h1-in-section-elements-expected.png:
• platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
• platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
• platform/chromium-win/tables/mozilla/bugs/bug126742-expected.png:
• platform/chromium-win/tables/mozilla/bugs/bug69187-expected.png:
• platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:
• platform/chromium/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Removed.
• platform/chromium/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
• platform/chromium/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
• platform/mac/css1/basic/inheritance-expected.txt: Removed.
• platform/mac/css1/box_properties/clear_float-expected.txt: Removed.
• platform/mac/css1/box_properties/margin-expected.txt: Removed.
• platform/mac/css1/box_properties/padding-expected.txt: Removed.
• platform/mac/css1/font_properties/font_weight-expected.txt: Removed.
• platform/mac/fast/css-generated-content/015-expected.txt: Removed.
• platform/mac/fast/css/h1-in-section-elements-expected.txt: Removed.

11:28 AM Changeset in webkit [145250] by eae@chromium.org

• 10 edits
  7 adds
  14 deletes in trunk/LayoutTests

Unreviewed apple rebaselines for r145242.

• css1/box_properties/margin_bottom-expected.txt: Added.
• css1/box_properties/margin_top-expected.txt: Added.
• css1/box_properties/padding_bottom-expected.txt: Added.
• css1/box_properties/padding_top-expected.txt: Added.
• css1/color_and_background/background_attachment-expected.txt: Added.
• platform/chromium-mac/css1/box_properties/margin_bottom-expected.txt: Removed.
• platform/chromium-mac/css1/box_properties/margin_top-expected.txt: Removed.
• platform/chromium-mac/css1/box_properties/padding_bottom-expected.txt: Removed.
• platform/chromium-mac/css1/box_properties/padding_top-expected.txt: Removed.
• platform/chromium-mac/css1/color_and_background/background_attachment-expected.txt: Removed.
• platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
• platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.txt: Removed.
• platform/chromium/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.
• platform/efl/tables/mozilla/bugs/bug73321-expected.txt: Removed.
• platform/mac-lion/css1/box_properties: Removed.
• platform/mac/css1/basic/inheritance-expected.txt:
• platform/mac/css1/box_properties/clear_float-expected.txt:
• platform/mac/css1/box_properties/margin-expected.txt:
• platform/mac/css1/box_properties/margin_bottom-expected.txt: Removed.
• platform/mac/css1/box_properties/margin_top-expected.txt: Removed.
• platform/mac/css1/box_properties/padding-expected.txt:
• platform/mac/css1/box_properties/padding_bottom-expected.txt: Removed.
• platform/mac/css1/box_properties/padding_top-expected.txt: Removed.
• platform/mac/css1/color_and_background/background_attachment-expected.txt: Removed.
• platform/mac/css1/font_properties/font_weight-expected.txt:
• platform/mac/fast/css-generated-content/015-expected.txt:
• platform/mac/fast/css/h1-in-section-elements-expected.txt:
• platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
• platform/mac/tables/mozilla/bugs/bug73321-expected.txt:
• tables/mozilla/bugs/bug73321-expected.txt: Added.

11:28 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

11:26 AM Changeset in webkit [145249] by Carlos Garcia Campos

• 9 edits
  2 adds
  3 deletes in releases/WebKitGTK/webkit-2.0

Merge r143604 - [GTK] Move feature overriding to the configure phase
​https://bugs.webkit.org/show_bug.cgi?id=110293

Reviewed by Gustavo Noronha Silva.

.:

Rework the feature overrides logic so all feature defines go into a
header rather than the command line. This has a few benefits. Most
notably, we can reuse the header in the gyp build. Another nice result
is that changes to the configuration automatically result in a full
rebuild and Debug and Release builds can have different configurations.

All feature define processing happens now during the configuration phase,
instead of when running autogen.sh. This means that we need to distribute
the feature processing script.

• GNUmakefile.am: Read feature defines from WebKitFeatures.txt when kicking

off a build. Also include generate-feature-defines-files in the distribution.

• Source/autotools/SetupAutoconfHeader.m4: Remove an extra ENABLE_3D_RENDERING

from the autoconf header, as it is already provided by the feature configuration.

• Source/autotools/SetupWebKitFeatures.m4: Added.
• Source/autotools/webkitfeature.m4: Removed. The functionality has been moved

to SetupWebKitFeatures.m4.

• autogen.sh: Remove the call to override-feature-defines.
• configure.ac: Now include SetupWebKitFeatures.

Source/WebCore:

• GNUmakefile.am: No longer include GNUmakefile.features.am. We don't

have to process the result of this file or do any modification of
feature_defines_override, because this variable is gone.

Tools:

• Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
WebKitFeatureOverrides.txt to better match the other filenames used in
the new feature processing.

• gtk/generate-feature-defines-files: Added. A script which takes as an argument

the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
and writes WebKitFeatures.txt and WebKitFeatures.h.

• gtk/override-feature-defines: Removed.

11:15 AM Changeset in webkit [145248] by eric@webkit.org

• 9 edits in trunk/Source/WebCore

AtomicHTMLToken should not be heap allocated or RefCounted
​https://bugs.webkit.org/show_bug.cgi?id=111250

Reviewed by Adam Barth.

It was clearly an oversight on our part to ever make AtomicHTMLToken ref-counted.
We don't need the actual "token" saved, just enough of it to recreate a fake token.

This removed many more mallocs than I thought it would, for a nice little speed win.
Before:
median= 450.482999993 ms, stdev= 7.2381436538 ms, min= 436.084999994 ms, max= 464.968999964 ms
After:
median= 436.41600004 ms, stdev= 5.71435647554 ms, min= 427.160999971 ms, max= 446.753000026 ms

• html/parser/AtomicHTMLToken.h:

(AtomicHTMLToken):

• html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::createElementFromSavedToken):

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):
(WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):

• html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::isHTMLIntegrationPoint):

• html/parser/HTMLFormattingElementList.cpp:

(WebCore):
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition):

• html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::create):
(WebCore::HTMLStackItem::localName):
(WebCore::HTMLStackItem::attributes):
(WebCore::HTMLStackItem::getAttributeItem):
(HTMLStackItem):
(WebCore::HTMLStackItem::hasLocalName):
(WebCore::HTMLStackItem::hasTagName):
(WebCore::HTMLStackItem::HTMLStackItem):

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):

• html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

10:57 AM Changeset in webkit [145247] by roger_fong@apple.com

• 6 edits in trunk/Source

Makefile fixes.

• WTF.vcxproj/WTF.make:
• JavaScriptCore.vcxproj/JavaScriptCore.make:
• WebCore.vcxproj/WebCore.make:

10:53 AM Changeset in webkit [145246] by Lucas Forschler

• 4 edits in tags/Safari-537.33.1/Source

Versioning.

10:49 AM WebKitGTK/2.0.x edited by Martin Robinson

(diff)

10:43 AM Changeset in webkit [145245] by Lucas Forschler

• 1 copy in tags/Safari-537.33.1

New Tag.

10:42 AM Changeset in webkit [145244] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit2

[WK2][GTK] Invalid request returned by webkit_download_get_request if called before download starts
​https://bugs.webkit.org/show_bug.cgi?id=111574

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-03-08
Reviewed by Alexey Proskuryakov.

webkit_download_get_request() creates the WebKitURIRequest object
on demand using the ResourceRequest from the DownloadProxy. The
ResourceRequest of the DownloadProxy is set in
DownloadProxy::didStart(), so if we call
webkit_download_get_request() before didStart we return an invalid
WebKitURIRequest created from a NULL ResourceRequest. This is not
a problem for downloads started in the web process, because we
create the WebKitDownload after DownloadProxy::didStart(). For
downloads started manually with webkit_web_context_download_uri()
we need to create download object with the ResourceRequest passed
to the DownloadProxy.

• UIProcess/API/gtk/WebKitDownload.cpp:

(webkitDownloadCreateForRequest): New helper function for
downloads started manually to created them with a given
ResourceRequest.

• UIProcess/API/gtk/WebKitDownloadPrivate.h:
• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextStartDownload): Use
webkitDownloadCreateForRequest().

• UIProcess/API/gtk/tests/TestDownloads.cpp:

(testDownloadLocalFile):
(testDownloadLocalFileError):
(testDownloadRemoteFile):
(testDownloadRemoteFileError):
(testPolicyResponseDownload):

10:33 AM Changeset in webkit [145243] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Skip editing/selection/drag-list-item.html on Mac WebKit2 since drag and drop is not supported
in WebKitTestRunner yet.

• platform/mac-wk2/TestExpectations:

10:30 AM Changeset in webkit [145242] by eae@chromium.org

• 34 edits
  2 adds in trunk

[sub-pixel] Rounding error in table cell height calculation causes unnecessary scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=111794

Source/WebCore:

Reviewed by Levi Weintraub.

In RenderTableCell::logicalHeightForRowSizing the
adjustedLogicalHeight is calculated from the logicalHeight and
intrinsic padding and is then returned and floored. This can
cause cause the cell to be slightly smaller (0.5px) than the
element it contains.

Test: fast/sub-pixel/table-cell-height.html

• rendering/RenderTableCell.h:

(WebCore::RenderTableCell::logicalHeightForRowSizing):
Change to use pixelSnapped version of logicalHeight method and
change signature to return int as the only caller immediately
down-casts the result to an int.

LayoutTests:

Reviewed by Levi Weintraub.

Add test for zoomed-in table containing block child.

• fast/sub-pixel/table-cell-height-expected.html: Added.
• fast/sub-pixel/table-cell-height.html: Added.

10:27 AM Changeset in webkit [145241] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

RenderFullScreen needs to clear override sizes when exiting full screen
​https://bugs.webkit.org/show_bug.cgi?id=111775

Patch by Christian Biesinger <​cbiesinger@chromium.org> on 2013-03-08
Reviewed by Ojan Vafai.

Source/WebCore:

Test: fullscreen/full-screen-with-flex-item.html

• rendering/RenderFullScreen.cpp:

(RenderFullScreen::unwrapRenderer):
RenderFullScreen is a flexbox, so it will potentially set override
sizes on its children while in fullscreen mode. When we exit
fullscreen mode, we need to clear this override size, otherwise the
the leftover override size may affect layout. See the testcase for an
example.

LayoutTests:

• fullscreen/full-screen-with-flex-item-expected.txt: Added.
• fullscreen/full-screen-with-flex-item.html: Added.

10:26 AM LayoutUnit edited by eae@chromium.org

Removed note about FractionalLayoutUnit typedef as it has since been … (diff)

10:25 AM Changeset in webkit [145240] by jchaffraix@webkit.org

• 7 edits
  2 adds in trunk

[CSS Grid Layout] Handle 2 positions with one 'auto' properly
​https://bugs.webkit.org/show_bug.cgi?id=111653

Reviewed by Tony Chang.

Source/WebCore:

The rendering code was making the assumption that we have one position.
Thus it couldn't fully match what the specification wants as the 2 opposite
positions are required to resolve either position in several cases (e.g.
1 / span 2, auto / 'c').

This change introduces resolveGridPositionsFromStyle to do both opposite
positions resolution in one pass and thus handling more cases.

Test: fast/css-grid-layout/grid-item-spanning-resolution.html

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
Updated the above functions to rely on resolveGridPositionsFromStyle.

(WebCore::RenderGrid::resolveGridPositionsFromStyle):
Added this new function that handle the correct resolution.

(WebCore::RenderGrid::resolveGridPositionFromStyle):
Updated the ASSERT to match the new code flow.

• rendering/RenderGrid.h:

(WebCore::RenderGrid::GridSpan::GridSpan):
Introduced this new struct to hold the 2 positions along one axis.

LayoutTests:

• fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
• fast/css-grid-layout/grid-auto-flow-resolution.html:
• fast/css-grid-layout/grid-item-spanning-resolution-expected.txt: Added.
• fast/css-grid-layout/grid-item-spanning-resolution.html: Added.

Extended and added a new test. Most of the new testing is failing as it
requires other changes to land. This will help us track our progress
towards fully supporting the new syntax and padding.

• fast/css-grid-layout/resources/grid.css:

Added the 2 new classes.

10:12 AM Changeset in webkit [145239] by dominicc@chromium.org

• 3 edits
  6 adds in trunk

RenderTextControlSingleLine should not assume that its text element has a renderer
​https://bugs.webkit.org/show_bug.cgi?id=111826

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/forms/search/search-autoscroll-hidden-decoration-container-crash.html

fast/forms/search/search-hide-decoration-container-crash.html
fast/forms/search/search-scroll-hidden-decoration-container-crash.html

• rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::autoscroll):
(WebCore::RenderTextControlSingleLine::scroll):

LayoutTests:

• fast/forms/search/search-autoscroll-hidden-decoration-container-crash-expected.txt: Added.
• fast/forms/search/search-autoscroll-hidden-decoration-container-crash.html: Added.
• fast/forms/search/search-hide-decoration-container-crash-expected.txt: Added.
• fast/forms/search/search-hide-decoration-container-crash.html: Added.
• fast/forms/search/search-scroll-hidden-decoration-container-crash-expected.txt: Added.
• fast/forms/search/search-scroll-hidden-decoration-container-crash.html: Added.

10:06 AM Changeset in webkit [145238] by jsbell@chromium.org

• 9 edits in trunk/Source

IndexedDB: Use WeakPtr for Factory-to-BackingStore reference
​https://bugs.webkit.org/show_bug.cgi?id=111459

Reviewed by Adam Barth.

Source/WebCore:

IDBFactoryBackendImpl maintains a map of backing stores - if another database in the same
origin is opened, the backing store instance must be re-used). This was a map to raw
pointers so that the backing store can be collected when all database references are
dropped. The map was maintained manually by passing the factory to the IDBBackingStore which
would add/remove itself on creation/destruction.

Replace this with a HashMap<WeakPtr<T>>. This simplifies the plumbing; map entries
"leak" but are purged on subsequent opens.

Added webkit_unit_test (Chromium port) to verify refcounts.

• Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::IDBBackingStore): No need to notify factory of lifetime.
(WebCore::IDBBackingStore::~IDBBackingStore): Ditto.
(WebCore::IDBBackingStore::open): Ditto.

• Modules/indexeddb/IDBBackingStore.h: No reference to the factory, but...

(WebCore::IDBBackingStore::createWeakPtr): Do need to expose weak pointers for the factory to hold.

• Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::cleanWeakMap): Helper function to scrub a HashMap<WeakPtr<T>> of empty pointers.
May move to WTF when we've learned how general it is, or come up with a dedicated WeakPtrHashMap type.
(WebCore::IDBFactoryBackendImpl::openBackingStore): WeakPtr fu.

• Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl): Remove plumbing methods.

Source/WebKit/chromium:

Add new test that verifies refcounts.

• WebKit.gyp: Don't include files depending on webkit_support.
• tests/IDBBackingStoreTest.cpp:

(WebCore::IDBBackingStoreTest::SetUp): No need for dummy factory.
(MockIDBFactoryBackend): Allow access to protected openBackingStore method.
(WebCore::TEST): Add new test that verifies refcounts.

• tests/IDBCleanupOnIOErrorTest.cpp:

(WebCore::TEST): No need for dummy factory.

9:42 AM Changeset in webkit [145237] by tony@chromium.org

• 3 edits
  3 copies in branches/chromium/1410

Merge 144894

Crash during middle mouse click when page is removed
​https://bugs.webkit.org/show_bug.cgi?id=111489

Reviewed by Hajime Morrita.

Source/WebCore:

Check for a null page that can happen if we remove the document from the DOM.
The other methods in EventHandler also check for a null page.

Test: editing/pasteboard/selection-paste-crash.html

• page/EventHandler.cpp:

(WebCore::EventHandler::handlePasteGlobalSelection):

LayoutTests:

• editing/pasteboard/resources/selection-paste-crash.html: Added.
• editing/pasteboard/selection-paste-crash-expected.txt: Added.
• editing/pasteboard/selection-paste-crash.html: Added.

TBR=​tony@chromium.org
Review URL: ​https://codereview.chromium.org/12510009

9:38 AM Changeset in webkit [145236] by ap@apple.com

• 4 edits in trunk/Source/WebKit2

<rdar://problem/13363499> Blobs are not cleaned up when WebProcess terminates
​https://bugs.webkit.org/show_bug.cgi?id=111803

Reviewed by Brady Eidson.

Track which blobs were created for each connection, and unregister them when
the connection closes.

Normally, this happens when a document is destroyed through PublicURLManager
in WebProcess. But we don't get there when the web process crashes, or is terminated
without waiting for document destruction.

• NetworkProcess/FileAPI/NetworkBlobRegistry.cpp: (WebKit::NetworkBlobRegistry::registerBlobURL): (WebKit::NetworkBlobRegistry::unregisterBlobURL): (WebKit::NetworkBlobRegistry::connectionToWebProcessDidClose):
• NetworkProcess/FileAPI/NetworkBlobRegistry.h:
• NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::didClose): (WebKit::NetworkConnectionToWebProcess::registerBlobURL): (WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL): (WebKit::NetworkConnectionToWebProcess::unregisterBlobURL):

9:35 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

9:33 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

9:30 AM Changeset in webkit [145235] by timothy@apple.com

• 3 edits in trunk/Source/WebKit2

Make the WebKit2 Web Inspector use tiled drawing and accelerated drawing.

<rdar://problem/12676223>

Reviewed by David Kilzer.

• UIProcess/WebInspectorProxy.cpp:

(WebKit::createInspectorPageGroup): Call setAcceleratedDrawingEnabled with true on 10.8+.

• UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorWKView _shouldUseTiledDrawingArea]): Added. Return YES on 10.8+.

9:29 AM Changeset in webkit [145234] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[GTK][WK2] Fix compilation warning missing-field-initializers in webkit-2.0 stable branch
​https://bugs.webkit.org/show_bug.cgi?id=111863

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-08
Reviewed by Martin Robinson.

• UIProcess/API/gtk/WebKitUIClient.cpp:

(attachUIClientToView): Include missing initializer for pluginLoadPolicy.

9:19 AM Changeset in webkit [145233] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

@media queries do not take zooming into account
​https://bugs.webkit.org/show_bug.cgi?id=53186

Patch by John Mellor <​johnme@chromium.org> on 2013-03-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Fixes @media width and height to take into account full page zoom, by
adding code to MediaQueryEvaluator's width/heightMediaFeatureEval,
corresponding to the existing code in Element::clientWidth which makes
document.documentElement.clientWidth take into account page zoom.

Test: fast/media/mq-width-pagezoom.html

• css/MediaQueryEvaluator.cpp:

(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):

LayoutTests:

• fast/media/mq-width-pagezoom-expected.html: Added.
• fast/media/mq-width-pagezoom.html: Added.

9:12 AM Changeset in webkit [145232] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] Add stubs for DNSResolveQueue platform specific methods
​https://bugs.webkit.org/show_bug.cgi?id=111841

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.

Add empty implementations of
DNSResolveQueue::platformProxyIsEnabledInSystemPreferences() and
DNSResolveQueue::platformResolve() to DNSBlackBerry.cpp to make it
build.

• platform/network/blackberry/DNSBlackBerry.cpp:

(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):

8:59 AM Changeset in webkit [145231] by Chris Fleizach

• 7 edits in trunk

[Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
​https://bugs.webkit.org/show_bug.cgi?id=111814

Reviewed by Ryosuke Niwa.

Tools:

Add the needed supportedActions() attribute to WKTestRunner.

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::supportedActions):

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
• WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::supportedActions):

LayoutTests:

• platform/mac-wk2/TestExpectations:

8:55 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas

Add new change on track (diff)

8:33 AM Changeset in webkit [145230] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

Coordinated Graphics: Handle scrolling correctly.
​https://bugs.webkit.org/show_bug.cgi?id=111406

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-03-08
Reviewed by Simon Fraser.

Coordinated Graphics deals with fast scrolling and slow scrolling in the same
routine, so WebChromeClient::invalidateContentsForSlowScroll() should call
DrawingArea:scroll().

When CoordinatedLayerTreeHost::scrollNonCompositedContents() is called, we
should call scheduleLayerFlush() to notify to UI Process. In addition, when we
don't use fixed layout, we should call setNonCompositedContentsNeedDisplay() to
update non composited contents.

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateContentsForSlowScroll):

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):

8:28 AM Changeset in webkit [145229] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Adding a hook to collect data for a Google UMA histogram to track when
m_needsCompositedScrolling is turned on and off.
​https://bugs.webkit.org/show_bug.cgi?id=111725

Reviewed by Julien Chaffraix.

We want to keep track of this information to quantify the effects of a
few patches that will cause us to opt in to composited scrolling.
Specifically, we want to measure the effects of
​https://bugs.webkit.org/show_bug.cgi?id=109302,
​https://bugs.webkit.org/show_bug.cgi?id=109966,
​https://bugs.webkit.org/show_bug.cgi?id=109591, and
​https://bugs.webkit.org/show_bug.cgi?id=107618.

We do this by measuring a per-layer boolean value, and comparing the
ratio between number of layers opted in and number of layers that remain
uncomposited. We hope the relative number of layers opting in will
increase after the relevant patches land and are enabled.

Unfortunately implementing extra statistics is impractical at the
moment since most of the actionable relevant data is expensive to
compute. For example, it would be useful to know if the layers that opt
out do so because of invisible or non-overlapping layers that cause a
potential stacking container's children to be discontiguous, because we
would potentially be able to mitigate the problem. However, this would
add considerable overhead to perform overlap testing just to gather
data.

No new tests (no change in behaviour).

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateNeedsCompositedScrolling):

Patch by Glenn Hartmann <​hartmanng@chromium.org> on 2013-03-08

8:28 AM Changeset in webkit [145228] by sudarsana.nagineni@linux.intel.com

• 2 edits
  2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Update platform expectations for failing tests after r145024 and r145067.

• platform/efl/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
• platform/efl/fast/forms/datalist/input-list-expected.txt:
• platform/efl/fast/forms/validationMessage-expected.txt: Added.

8:06 AM Changeset in webkit [145227] by sudarsana.nagineni@linux.intel.com

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip failing tests on EFL bots.

• platform/efl/TestExpectations:

8:00 AM Changeset in webkit [145226] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] GraphicsContext: rename addRoundedRectClip to clipRoundedRect
​https://bugs.webkit.org/show_bug.cgi?id=111852

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.

This changed in r139353.

• platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:

(WebCore::GraphicsContext::clipRoundedRect):

7:59 AM Changeset in webkit [145225] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] Add BlendMode parameter to GraphicsContext::setPlatformCompositeOperation
​https://bugs.webkit.org/show_bug.cgi?id=111840

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.

This parameter was added in r137011.

• platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

7:57 AM Changeset in webkit [145224] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] Remove unused GraphicsContext::addInnerRoundedRectClip()
​https://bugs.webkit.org/show_bug.cgi?id=111838

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.

This was removed in r139138.

• platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:

7:56 AM Changeset in webkit [145223] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] GraphicsContext: add fillRule parameter to clip() and canvasClip()
​https://bugs.webkit.org/show_bug.cgi?id=111836

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.

This parameter was added in r139967.

• platform/graphics/blackberry/PathBlackBerry.cpp:

(WebCore):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):

7:51 AM Changeset in webkit [145222] by kadam@inf.u-szeged.hu

• 3 edits
  1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip now passing compositing tests.

• platform/qt-5.0-wk2/TestExpectations:
• platform/qt/TestExpectations:
• platform/qt/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.

7:39 AM Changeset in webkit [145221] by vsevik@chromium.org

• 12 edits in trunk

Web Inspector: Get rid of file system ids and use file pathes as uri for file based uiSourceCodes.
​https://bugs.webkit.org/show_bug.cgi?id=111753

Reviewed by Pavel Feldman.

Source/WebCore:

• inspector/front-end/FileSystemMapping.js:

(WebInspector.FileSystemMappingImpl):
(WebInspector.FileSystemMappingImpl.prototype._loadFromSettings.get this):
(WebInspector.FileSystemMappingImpl.prototype._loadFromSettings):
(WebInspector.FileSystemMappingImpl.prototype._saveToSettings):
(WebInspector.FileSystemMappingImpl.prototype.set addFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.removeFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPaths):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPathForPrefix):

• inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate.projectId):
(WebInspector.FileSystemProjectDelegate.prototype.id):
(WebInspector.FileSystemProjectDelegate.prototype.fileSystemPath):
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemRemoved):
(WebInspector.FileSystemWorkspaceProvider.prototype.fileSystemPath):

• inspector/front-end/IsolatedFileSystemManager.js:

(WebInspector.IsolatedFileSystemManager.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemRemoved):

• inspector/front-end/Workspace.js:

(WebInspector.Workspace.prototype.uiSourceCodeForURL):

LayoutTests:

• inspector/file-system-mapping-expected.txt:
• inspector/file-system-mapping.html:
• inspector/file-system-project-expected.txt:
• inspector/workspace-mapping-expected.txt:
• inspector/workspace-mapping.html:

7:25 AM Changeset in webkit [145220] by vsevik@chromium.org

• 6 edits in trunk/Source/WebCore

Web Inspector: Polish TabbedEditorContaner and ScriptsNavigator behavior.
​https://bugs.webkit.org/show_bug.cgi?id=111732

Reviewed by Pavel Feldman.

Resources matching inspectedPageURL are always expanded in NavigatorView now.
Snippets tab in scripts navigator is not automatically opened anymore.
Cleared saved TabbedEditorContainer history because it might have been corrupted due to errors in earlier versions.
Snippets are not revealed in TabbedEditorContainer anymore unless they were actually selected by user or there is no other tabs opened.

• inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype.addUISourceCode):
(WebInspector.NavigatorView.prototype._inspectedURLChanged):
(WebInspector.NavigatorView.prototype.revealUISourceCode):
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.uiSourceCode):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.reveal):

• inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._showFile):

• inspector/front-end/Settings.js:

(WebInspector.VersionController.prototype._updateVersionFrom1To2):

• inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype.addUISourceCode.tabId.this._tabIds.get this):
(WebInspector.TabbedEditorContainer.prototype.addUISourceCode):
(WebInspector.TabbedEditorContainer.History.prototype._rebuildItemIndex):

7:14 AM Changeset in webkit [145219] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

• platform/qt/TestExpectations: Skip test after r145195.

7:11 AM Changeset in webkit [145218] by vsevik@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Add shortcut for running a snippet.
​https://bugs.webkit.org/show_bug.cgi?id=111680

Reviewed by Pavel Feldman.

Added Ctrl/Cmd+Enter as a shortcut for running a snippet.

• inspector/front-end/SnippetJavaScriptSourceFrame.js:

(WebInspector.SnippetJavaScriptSourceFrame):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runButtonClicked):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runSnippet):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._onKeyDown):

7:05 AM Changeset in webkit [145217] by mikhail.pozdnyakov@intel.com

• 2 edits in trunk/Tools

[EFL] Memory leak at WKViewClientWebProcessCallbacks API test
​https://bugs.webkit.org/show_bug.cgi?id=111851

Reviewed by Kenneth Rohde Christiansen.

• TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:

(TestWebKitAPI::TEST):

Fixed WKURLRef instance leaking.

6:37 AM Changeset in webkit [145216] by pdr@google.com

• 3 edits
  2 adds in trunk

Prevent infinite loop in SVG use cycle detection
​https://bugs.webkit.org/show_bug.cgi?id=111822

Reviewed by Stephen Chenney.

Source/WebCore:

SVG use cycle detection depended on idForStyleResolution() which differs from
getIdAttribute() in quirks mode. During use tree cycle detection, this difference
resulted in an infinite loop because idForStyleResolution() used lower-cased id
attributes. This patch removes an existing fixme for this and switches to using
getIdAttribute().

Test: svg/custom/use-cycle-detection.html

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::hasCycleUseReferencing):

LayoutTests:

• svg/custom/use-cycle-detection-expected.html: Added.
• svg/custom/use-cycle-detection.html: Added.

6:32 AM Changeset in webkit [145215] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

When we set word-wrap: break-word and xml:space="preserve" to svg text element, the text is collapsed.
​https://bugs.webkit.org/show_bug.cgi?id=111675

Patch by Yuki Sekiguchi <​yuki.sekiguchi@access-company.com> on 2013-03-08
Reviewed by Stephen Chenney.

Source/WebCore:

RenderSVGText define its size when it laid out its first line at SVGRootInlineBox::computePerCharacterLayoutInformation().

In the following spec, SVG don't perform automatic line break or word wrapping.
​http://www.w3.org/TR/SVG/text.html#Introduction

SVG performs no automatic line breaking or word wrapping.

However, when we set word-wrap: break-word and xml:space="preserve" to svg text element, RenderBlock::LineBreaker::nextLineBreak() breaks the text.
This make single character lines and make RenderSVGText narrow.

We must ignore word-wrap property to make the text a single line.

We always disable break words and break all in nextLineBreak() when the object is SVGInlineText.

Test: svg/text/preserve-break-word.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Disable break words and break all when we process SVG Text.

LayoutTests:

Test combination of xml:space="preserve" and word-wrap: break-word to SVG Text.
These text should not be collapsed.

• svg/text/preserve-break-word-expected.html: Added.
• svg/text/preserve-break-word.html: Added.

6:23 AM Changeset in webkit [145214] by allan.jensen@digia.com

• 2 edits in trunk/Source/WebCore

[Qt] HTML5 video - sound volume bar out of widget
​https://bugs.webkit.org/show_bug.cgi?id=108213

Reviewed by Jocelyn Turcotte.

Since we use Safari shadow DOM for media controls, follow
the overall layout of Safari media control CSS.

• css/mediaControlsQt.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
(audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):

6:13 AM Changeset in webkit [145213] by mikhail.pozdnyakov@intel.com

• 4 edits in trunk/Source/WebKit2

[WK2][EFL] Remove EwkView::setImageData()
​https://bugs.webkit.org/show_bug.cgi?id=111849

Reviewed by Andreas Kling.

EwkView::setImageData() removed as it is not used at the moment
(it used to be part of eliminated non coord graphics code path).

• UIProcess/API/efl/EwkView.cpp:
• UIProcess/API/efl/EwkView.h:

(EwkView):

• UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::incorporateUpdate):

6:12 AM Changeset in webkit [145212] by tkent@chromium.org

• 3 edits
  1 copy in trunk/LayoutTests

Allow platform-dependent strings for validationMessage property
​https://bugs.webkit.org/show_bug.cgi?id=111846

Reviewed by Kentaro Hara.

Do not check matching with fixed strings in validationMessage.html
test. We print validationMessage values in the test instead.
We'd like to change user-visible strings at our own discretion.

• fast/forms/validationMessage-expected.txt:

Note that many platforms don't have a dedicated message for
badInput and uses the same message as typeMismatch for now.

• fast/forms/validationMessage.html:
• platform/chromium/fast/forms/validationMessage-expected.txt:

Chromium has a dedicated one for badInput.

5:43 AM Changeset in webkit [145211] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/qt

[Qt] QWebSettings::clearMemoryCaches should release FastMalloc's free pages to OS
​https://bugs.webkit.org/show_bug.cgi?id=111605

Patch by Arunprasad Rajkumar <​arunprasadr@nds.com> on 2013-03-08
Reviewed by Jocelyn Turcotte.

• Api/qwebsettings.cpp:

(QWebSettings::clearMemoryCaches):

5:24 AM Changeset in webkit [145210] by allan.jensen@digia.com

• 2 edits in trunk/Source/WebCore

[Qt] Doesn't build with QtMultimedia
​https://bugs.webkit.org/show_bug.cgi?id=111847

Reviewed by Jocelyn Turcotte.

Fix include.

• platform/graphics/qt/MediaPlayerPrivateQt.h:

5:18 AM Changeset in webkit [145209] by Christophe Dumez

• 4 edits
  1 add in trunk

[EFL] [WK2] Some authentication tests fail in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=106407

Reviewed by Kenneth Rohde Christiansen.

Tools:

Add patch from upstream for libsoup 2.40 to fix several authentication
test cases.

• efl/jhbuild.modules:
• efl/patches/libsoup-2.40-auth-fix.patch: Added.

LayoutTests:

Unskip several authentication test cases now that we cherry-picked
the needed libsoup fix from upstream.

• platform/efl-wk2/TestExpectations:

4:12 AM Changeset in webkit [145208] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r145200.

3:36 AM May 2013 Meeting edited by alexis@webkit.org

(diff)

3:25 AM Changeset in webkit [145207] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[EFL][Qt] REGRESSION(r144787): A fixed element lags when scrolling and wheeling.
​https://bugs.webkit.org/show_bug.cgi?id=111829

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-03-08
Reviewed by Noam Rosenthal.

Currently, flagsChanged deals with all boolean flags. It introduces this bug
because when another flag (i.e. preserves3D) is changed, fixedToViewport is set
to false. So this patch updates all flags when at least one flag is changed.

In addition, this patch amends isScrollable code to match other flags.

This patch can only be tested manually since there is no automated
testing facilities for in-motion touch.
Test: ManualTests/fixed-position.html

ManualTests/nested-fixed-position.html

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setScrollableArea):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::setLayerState):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):

3:20 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

3:19 AM Changeset in webkit [145206] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r144982 - [GTK][WK2] Implement WebInspector::localizedStringsURL() to return the file URL of localizedStrings.js
​https://bugs.webkit.org/show_bug.cgi?id=111448

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2013-03-06
Reviewed by Alexey Proskuryakov.

Implement WebInspector::localizedStringsURL() method to return the
file URL of the localizedStrings.js.

This prevents printing warnings about "Localized string not found" in
the console.

• WebProcess/WebPage/gtk/WebInspectorGtk.cpp:

(WebKit::WebInspector::localizedStringsURL):

3:09 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

3:08 AM Changeset in webkit [145205] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk

Merge r144943 - Link the webkit_tests to XRENDER_LIBS.
This solves the linking failure when building against gtk2 like:
usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
Source/WebCore/platform/gtk/Programs_unittests_testcopyandpaste-GtkVersioning.o:
undefined reference to symbol 'XFree'
/usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
note: 'XFree' is defined in DSO /usr/lib/libX11.so.6 so try adding it
to the linker command line
/usr/lib/libX11.so.6: could not read symbols: Invalid operation

​https://bugs.webkit.org/show_bug.cgi?id=111572

Patch by Dominique Leuenberger <​dimstar@opensuse.org> on 2013-03-06
Reviewed by Gustavo Noronha Silva.

• GNUmakefile.am:

3:01 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

3:00 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

3:00 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:58 AM Changeset in webkit [145204] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r144936 - [soup] session cookies are not correctly reported in getRawCookies()
​https://bugs.webkit.org/show_bug.cgi?id=111584

Reviewed by Martin Robinson.

As per libsoup documentation, SoupCookie->expires is NULL for session cookies.
However, the soup implementation for getRawCookies() does not check for NULL
case before passing the value to soup_date_to_time_t(), which leads to run time
warnings.

We should also pass true for WebCore::Cookie's session argument if
SoupCookie->expires is NULL. The current implementation reports the cookie as a
session one if soup_cookie_jar_is_persistent(jar) returns true, which is
inaccurate.

No new tests, no behavior change for layout tests as Web Inspector currently
ignores the "session" member and uses expires/max-age instead to deduce it.

• platform/network/soup/CookieJarSoup.cpp:

(WebCore::getRawCookies):

2:55 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:54 AM Changeset in webkit [145203] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.0

Merge r144969 - [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
​https://bugs.webkit.org/show_bug.cgi?id=82866

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-06
Reviewed by Martin Robinson.

Source/WebKit2:

Test was failing because of new media controls needs more space to be
painted than just 10x10 pixels. This is similar to r144070.

• UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewMouseTarget): Modified HTML in order to give more space to the media controls.

Tools:

• Scripts/run-gtk-tests:

(TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
it is passing now.

2:40 AM Changeset in webkit [145202] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[GTK] Memory leak in webkit_web_view_load_request() in WebKit2 API
​https://bugs.webkit.org/show_bug.cgi?id=111160

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-03-08
Reviewed by Benjamin Poulain.

leakRef() is used for the returned PassRefPtr without taking the
ownership of the leaked ref.

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_request): Use RefPtr local variable.

2:29 AM Changeset in webkit [145201] by zandobersek@gmail.com

• 2 edits in trunk

[Autotools] Remove definitions of unnecessary Automake conditionals
​https://bugs.webkit.org/show_bug.cgi?id=111830

Reviewed by Philippe Normand.

The following Automake conditionals are not used anywhere and should have their
definitions in SetupAutomake.m4 removed:
ENABLE_GAMEPAD, ENABLE_XSLT, ENABLE_GEOLOCATION, ENABLE_SVG_FONTS,
ENABLE_OPCODE_STATS, ENABLE_CSS_FILTERS, ENABLE_CSS_SHADERS.

• Source/autotools/SetupAutomake.m4:

2:08 AM Changeset in webkit [145200] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[GTK] Enable Web Audio in development builds
​https://bugs.webkit.org/show_bug.cgi?id=111831

Reviewed by Philippe Normand.

Web Audio is already quite well supported on the GTK port but still has a few issues
that must be addressed before it is enabled by default. Despite that it should be enabled
in development builds just so we are up-to-date with future feature infrastructure changes.
The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
that's an obvious goal before enabling the feature in release builds.

• Scripts/webkitperl/FeatureList.pm:

2:06 AM Changeset in webkit [145199] by zandobersek@gmail.com

• 5 edits in trunk

[GTK] Remove media stream support from the configuration options
​https://bugs.webkit.org/show_bug.cgi?id=111813

Reviewed by Philippe Normand.

Remove the media-stream configuration flag. The feature is incomplete and
thus unsupported, so it really shouldn't be possible to enable it.

• Source/autotools/PrintBuildConfiguration.m4:
• Source/autotools/ReadCommandLineArguments.m4:
• Source/autotools/SetupAutomake.m4:
• Source/autotools/SetupWebKitFeatures.m4:

2:04 AM Changeset in webkit [145198] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Skipping the tests in inspector-protocol/layers as they rely on compositing support
which is not available on the GTK builders.
Adding failure expectations for tests that regressed with r145100.

• platform/gtk/TestExpectations:

2:01 AM Changeset in webkit [145197] by dino@apple.com

• 3 edits in trunk/Source/WebCore

Remove dead label code in snapshotted plugin
​https://bugs.webkit.org/show_bug.cgi?id=111781

Reviewed by Tim Horton.

Since ports can use the shadow tree to do label display,
there is no need for the hardcoded timers in RenderSnapshottedPlugin.

• rendering/RenderSnapshottedPlugIn.cpp: Remove label flags and timers.

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::updateSnapshot):
(WebCore::RenderSnapshottedPlugIn::handleEvent):

• rendering/RenderSnapshottedPlugIn.h:

(RenderSnapshottedPlugIn):

Conflicts:

Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp

2:01 AM Changeset in webkit [145196] by dino@apple.com

• 13 edits
  2 adds in trunk

Implement a custom appearance for the snapshotted plugin background
​https://bugs.webkit.org/show_bug.cgi?id=108368

Reviewed by NOBODY (OOPS!).

Source/WebCore:

After ​https://bugs.webkit.org/show_bug.cgi?id=108284 (r142507), a
snapshotted plugin was no longer drawing the background of the
label blurred. Since the snapshot content was now a shadow tree,
it wasn't feasible to pre-blur a region of the snapshot: the label
could be any size and in any location, with ports being able to
override the appearance through their UA style sheet.

Instead we now use one of the elements in the tree, the snapshot-overlay,
as a hook where ports can add any effect they want. This could be simply
a border, or a transparent mask, or even a CSS filter. We introduce a custom
CSS appearance "snapshotted-plugin-overlay", which could be added to the
element in the injected UA stylesheet. This calls into RenderTheme in
the same way that custom controls do.

Meanwhile, in RenderThemeMac, we implement the appearance by drawing the
content of the plugin snapshot into the background of the element. That
way we can add effects in CSS.

Test: plugins/snapshot-appearance.html

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Handle SnapshottedPluginOverlayPart.

• css/CSSValueKeywords.in: New appearance value snapshotted-plugin-overlay.
• platform/ThemeTypes.h: New value SnapshottedPluginOverlayPart.
• html/HTMLPlugInElement.h:

(WebCore::toHTMLPlugInElement): Add safer casting helpers.

• html/HTMLPlugInImageElement.h:

(WebCore::toHTMLPlugInImageElement): Ditto.

• rendering/RenderSnapshottedPlugIn.cpp: Remove the code for handling

the blur directly in the renderer.

(WebCore::RenderSnapshottedPlugIn::paint): Simplify the paint logic since we're

no longer trying to blur here.

(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Ditto.

• rendering/RenderSnapshottedPlugIn.h: Remove the methods that were trying

to blur the image directly.

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint): Call paintSnapshottedPluginOverlay.

• rendering/RenderTheme.h:

(WebCore::RenderTheme::paintSnapshottedPluginOverlay): New virtual method with default implementation.

• rendering/RenderThemeMacShared.h:

(RenderThemeMacShared): Override paintSnapshottedPluginOverlay.

• rendering/RenderThemeMacShared.mm:

(WebCore::RenderThemeMacShared::paintSnapshottedPluginOverlay): Implement a custom render path

that takes the snapshot image from the node's parent, and draws it into the background.
Along the way make sure we're actually using the right type of element (an HTMLPlugInImageElement).

LayoutTests:

Toggles our new snapshotted-plugin-overlay appearance, to make sure it
isn't getting applied to non-plugins.

• plugins/snapshot-appearance-expected.html: Added.
• plugins/snapshot-appearance.html: Added.

1:58 AM Changeset in webkit [145195] by sergio@webkit.org

• 5 edits
  2 adds in trunk

Improve drag&drop of list items in contentEditable divs
​https://bugs.webkit.org/show_bug.cgi?id=111556

Reviewed by Ryosuke Niwa.

Source/WebCore:

A single fully selected <li> should generate the same markup as if
we were selecting some of them, i.e., we should preserve the list
structure and appearance.

Test: editing/selection/drag-list-item.html

• editing/htmlediting.cpp:

(WebCore::isListItem): modified constness.

• editing/htmlediting.h:

(WebCore): ditto.

• editing/markup.cpp:

(WebCore::highestAncestorToWrapMarkup):

LayoutTests:

Added a new test case. The test performs 2 drag&drops, first of
all a selection of a single list item, and secondly a selection of
two list items. It checks that both behave the same way, i.e, the
whole <li> is moved and not only the text.

• editing/selection/drag-list-item-expected.txt: Added.
• editing/selection/drag-list-item.html: Added.

1:44 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com

(diff)

1:27 AM Changeset in webkit [145194] by rgabor@webkit.org

• 4 edits in trunk/Source

Cache flush problem on ARMv7 JSC
​https://bugs.webkit.org/show_bug.cgi?id=111441

Reviewed by Zoltan Herczeg.

Not proper cache flush causing random crashes on ARMv7 Linux with V8 tests.
The problem is similar to ​https://bugs.webkit.org/show_bug.cgi?id=77712.
Change the cache fulsh mechanism similar to ARM traditinal and revert the
temporary fix.

Source/JavaScriptCore:

• assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::cacheFlush):

Source/WTF:

• wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::decommit):

1:21 AM Changeset in webkit [145193] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] LayerTiler: rename currentFrameHasAlpha as currentFrameKnownToBeOpaque
​https://bugs.webkit.org/show_bug.cgi?id=111828

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-03-08
Reviewed by Carlos Garcia Campos.

This changed in r141637.

• platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::updateTextureContentsIfNeeded):

1:17 AM Changeset in webkit [145192] by zarvai@inf.u-szeged.hu

• 2 edits
  1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

• platform/qt/TestExpectations: Skip failing test after r145100.
• platform/qt/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Rebaselining after r145067.

12:56 AM Changeset in webkit [145191] by Antoine Quint

• 2 edits in trunk/Source/WebCore

Fix a couple of typos, unreviewed.

12:29 AM Changeset in webkit [145190] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[BlackBerry] Use OwnPtr for CredentialBackingStore members
​https://bugs.webkit.org/show_bug.cgi?id=111737

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.

It simplifies the code a bit.

• platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::CredentialBackingStore::~CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::certMgrWrapper):

• platform/network/blackberry/CredentialBackingStore.h:

(CredentialBackingStore):

12:00 AM Changeset in webkit [145189] by jochen@chromium.org

• 2 edits in trunk/Tools

[chromium] delay clearing the TestRunners until the main view was deleted
​https://bugs.webkit.org/show_bug.cgi?id=111823

Reviewed by Eric Seidel.

During WebViewHost::shutdown, we navigate the WebView to about:blank.
This may call into the test runners which assume that the delegate is
always non-NULL.

• DumpRenderTree/chromium/TestShell.cpp:

(TestShell::~TestShell):