Timeline
Mar 10, 2013:
- 1:20 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:18 AM Changeset in webkit [145324] by
-
- 7 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK] When the WebProcess crashes, a signal should be emitted
https://bugs.webkit.org/show_bug.cgi?id=105180
Emit a "web-process-crashed" signal when the WebProcess crashes. This
is useful, for example, to show an error page in a web browser
like Chrome does.
Reviewed Carlos Garcia Campos.
Patch by Xan Lopez <Xan Lopez> on 2013-03-10
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(processDidCrash):
(attachLoaderClientToView):
- UIProcess/API/gtk/WebKitWebContextPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init):
(webkitWebViewWebProcessCrashed):
- UIProcess/API/gtk/tests/TestWebExtensions.cpp:
(testWebExtensionGetTitle):
(webProcessCrashedCallback):
(testWebKitWebViewProcessCrashed):
(beforeAll):
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(methodCallCallback):
Mar 9, 2013:
- 11:29 PM Changeset in webkit [145341] by
-
- 2 edits in trunk/Source/WebKit2
WebPage::scaledSnapshotWithOptions returns a corrupt snapshot if you request a rect larger than the FrameView’s size
https://bugs.webkit.org/show_bug.cgi?id=111820
<rdar://problem/13375785>
Reviewed by Simon Fraser.
We have to clear the image - there could be area that won’t be painted by the FrameView,
or the FrameView could have a transparent background.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scaledSnapshotWithOptions):
- 11:13 PM Changeset in webkit [145340] by
-
- 6 edits6 adds in trunk
Implement inert subtrees needed for modal <dialog>
https://bugs.webkit.org/show_bug.cgi?id=110952
Reviewed by Hajime Morrita.
Source/WebCore:
This changes Node::disabled() to return true when a modal dialog is
open and the node is not in the dialog.
Reusing disabled for inertness is useful because then event
targeting and focus control automatically have the desired behavior:
inert nodes are skipped over.
Tests: fast/dom/HTMLDialogElement/closed-dialog-does-not-block-mouse-events.html
fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html
fast/dom/HTMLDialogElement/non-modal-dialog-does-not-block-mouse-events.html
- dom/Document.h:
(WebCore::Document::activeModalDialog): Returns the topmost element in the top layer.
Since now the only elements in the top layer are modal dialogs, it is the active modal dialog.
- dom/Node.cpp:
(WebCore):
(WebCore::Node::isInert): As per the spec, a node that is not an ancestor or descendant of the modal dialog is inert.
(WebCore::Node::disabled): Return false when inert.
- dom/Node.h:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::disabled): Fall back to the superclass so inert is taken into account.
LayoutTests:
- fast/dom/HTMLDialogElement/closed-dialog-does-not-block-mouse-events-expected.txt: Added.
- fast/dom/HTMLDialogElement/closed-dialog-does-not-block-mouse-events.html: Added.
- fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events-expected.txt: Added.
- fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html: Added.
- fast/dom/HTMLDialogElement/non-modal-dialog-does-not-block-mouse-events-expected.txt: Added.
- fast/dom/HTMLDialogElement/non-modal-dialog-does-not-block-mouse-events.html: Added.
- 10:42 PM Changeset in webkit [145339] by
-
- 2 edits in trunk/Tools
Add myself to committers.py
- 8:30 PM Changeset in webkit [145338] by
-
- 5 edits2 adds in trunk
Line breaking opportunities at the end of a text node are missed
https://bugs.webkit.org/show_bug.cgi?id=17427
Reviewed by Darin Adler.
Source/WebCore:
When initializing context for determining next break position,
reuse last two characters from previous text node(s) within block.
This additional state is stored in the current LazyLineBreakIterator
as an optimization to prevent having to add two new parameters to
isBreakable().
At present, this fixes only the ASCII shortcut code path, but
does not yet handle the non-ASCII path. Since the ASCII path is
the most performant critical, the handling of this latter path
will be addressed by webkit.org/b/105692.
Additionally test for case where last two characters context
is derived from distinct nodes, possibly with intervening empty
inline node(s).
Test: fast/text/line-break-between-text-nodes.html
- platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::lastCharacter):
(WebCore::LazyLineBreakIterator::secondToLastCharacter):
(WebCore::LazyLineBreakIterator::setLastTwoCharacters):
(WebCore::LazyLineBreakIterator::resetLastTwoCharacters):
(WebCore::LazyLineBreakIterator::updateLastTwoCharacters):
(LazyLineBreakIterator):
Add state variables to retain last two characters of previous text node(s)
for reuse when initializing nextBreakPosition<>() context.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
Record and reset retained last two characters of previous text node(s) as
appropriate.
- rendering/break_lines.cpp:
(WebCore::nextBreakablePosition):
Use state variables holding retained last two characters of previous text node(s)
for when initializing nextBreakPosition<>() context.
LayoutTests:
- fast/text/line-break-between-text-nodes-expected.html: Added.
- fast/text/line-break-between-text-nodes.html: Added.
- 6:21 PM Changeset in webkit [145337] by
-
- 2 edits in trunk/Source/WebKit2
Fix a typo in http://trac.webkit.org/changeset/145332.
Unreviewed.
ENABLE() doesn't use the WTF_ prefix.
- WebProcess/WebPage/WebPage.h:
- 6:19 PM Changeset in webkit [145336] by
-
- 3 edits in trunk/Source/WebCore
NetworkStorageSession leaks its CFURLStorageSessionRef
https://bugs.webkit.org/show_bug.cgi?id=111950
<rdar://problem/13384134>
Reviewed by Sam Weinig.
- platform/network/NetworkStorageSession.h:
Change the argument type of the constructor to a RetainPtr.
- platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::NetworkStorageSession): Changed
the argument type to a RetainPtr.
(WebCore::NetworkStorageSession::switchToNewTestingSession): Added
calls to adoptCF to adopt the value returned by wkCreatePrivateStorageSession.
(WebCore::NetworkStorageSession::createPrivateBrowsingSession): Ditto.
(WebCore::NetworkStorageSession::cookieStorage): Changed to use adoptCF
instead of the RetainPtr constructor with AdoptCF since the former is
far easier to read.
- 4:36 PM WebKit Team edited by
- (diff)
- 4:12 PM Changeset in webkit [145335] by
-
- 5 edits in trunk/Source/WebKit2
Add bundle API to get the current selection as a WKDOMRange
https://bugs.webkit.org/show_bug.cgi?id=111947
<rdar://problem/13205460>
Reviewed by Gavin Barraclough.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController selectedRange]):
Add new selectedRange property.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::frameWithSelection):
(WebKit::WebPage::currentSelectionAsRange):
- WebProcess/WebPage/WebPage.h:
Get the range by finding the frame that has a selection, and then normalizing it.
- 3:37 PM Changeset in webkit [145334] by
-
- 2 edits in trunk/Source/WebCore
Conformance Test 1.0.3 (Beta) function: bufferData undefined value failed.
https://bugs.webkit.org/show_bug.cgi?id=111641
Patch by Jason Anderssen <janderssen@gmail.com> on 2013-03-10
Reviewed by Dean Jackson.
The WebGL specification requires that a size of 0 is not valid. In javascript, passing in undefined
as a parameter to a long long is the same as passing in 0, so we must check for this incorrect
value and fail.
The test suite in Kronos 1.0.3 failed, test to verify conformance is as follows:
https://www.khronos.org/registry/webgl/sdk/tests/conformance/more/functions/bufferDataBadArgs.html.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::bufferData):
Synthesize error and returned if size is 0.
- 2:00 PM Changeset in webkit [145333] by
-
- 3 edits in trunk/Source/WebCore
SVGDocumentExtensions should use OwnPtr for pending resource maps.
<http://webkit.org/b/111943>
Reviewed by Anders Carlsson.
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removePendingResource):
(WebCore::SVGDocumentExtensions::removePendingResourceForRemoval):
(WebCore::SVGDocumentExtensions::markPendingResourcesForRemoval):
- svg/SVGDocumentExtensions.h:
(SVGDocumentExtensions):
- 1:40 PM Changeset in webkit [145332] by
-
- 8 edits in trunk/Source
Add a heuristic to determine the “primary” snapshotted plugin
https://bugs.webkit.org/show_bug.cgi?id=111932
<rdar://problem/13270208>
Reviewed by Dean Jackson.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
Forward didCommitLoad to WebPage. Move existing code that manipulated WebPage
itself during didCommitLoad into WebPage, where it belongs.
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad): Forward didFinishLoad to WebPage.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initialize m_didFindPrimarySnapshottedPlugin to false.
(WebKit::WebPage::didCommitLoad): Move code from WebPageFrameLoaderClient.
Reset the flag that says we've already found a snapshotted plugin.
(WebKit::WebPage::didFinishLoad):
Call determinePrimarySnapshottedPlugIn when any frame finishes loading. We call this for subframes,
not just the main frame, in case the main frame loads with no "primary" plugins, but a subframe later loads with one.
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
Attempt to find the primary snapshotted plugin on the page, by hit-testing a grid of points spaced 200px apart.
A plugin is considered if it is snapshotted and > 450x300. We scan vertically and left-to-right, only discarding
a previous candidate if another candidate is at least 110% the size of the previous candidate.
This tends to select plugins near the top left of the page, unless there is a significantly larger plugin elsewhere.
(WebKit::WebPage::resetPrimarySnapshottedPlugIn):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebCore.exp.in: Export a few things.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::classNameForShadowRoot): If we've been informed that we are the primary snapshotted plugin, add the 'primary' class.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Added
(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): Hand classNameForShadowRoot our primary-ness.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): Add storage for m_isPrimarySnapshottedPlugIn.
- 12:57 PM Changeset in webkit [145331] by
-
- 5 edits in trunk/Source/WebCore
XSSAuditor doesn't need a copy of the original document URL.
https://bugs.webkit.org/show_bug.cgi?id=111944
Reviewed by Adam Barth.
When creating an XSSInfo object in response to detecting reflected XSS
on a page, the Auditor was passing in a copy of the document's
original URL for reporting. It doesn't look like we need this, as
XSSInfo's only consumer, XSSAuditorDelegate, runs on the main thread
with access to the document. We can obtain access to the same
information by reading the URL directly from the delegate's Document
object if and when we need it.
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
Read the document's URL directly in order to create a violation
report.
(WebCore::XSSInfo::isSafeToSendToAnotherThread):
- html/parser/XSSAuditorDelegate.h:
(WebCore::XSSInfo::create):
(WebCore::XSSInfo::XSSInfo):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::isSafeToSendToAnotherThread):
- html/parser/XSSAuditor.h:
Remove the copied original URL from both XSSInfo objects and the
XSSAuditor.
- 12:30 PM Changeset in webkit [145330] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r145039 and r145096.
http://trac.webkit.org/changeset/145039
http://trac.webkit.org/changeset/145096
https://bugs.webkit.org/show_bug.cgi?id=111945
broke find indicator updates with scrolling subframes
(Requested by thorton on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-10
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
- 12:16 PM Changeset in webkit [145329] by
-
- 3 edits in trunk/Source/JavaScriptCore
SpeculativeJIT should use OwnPtr<SlowPathGenerator>.
<http://webkit.org/b/111942>
Reviewed by Anders Carlsson.
There's no need to include DFGSlowPathGenerator.h from the header as long as the destructor is out-of-line,
so let's use OwnPtr instead of raw pointers + deleteAllValues().
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::~SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- 11:30 AM WebKitGTK/2.0.x edited by
- (diff)
- 10:41 AM Changeset in webkit [145328] by
-
- 3 edits in trunk/Source/WebKit2
WebPluginSiteDataManager should use OwnPtr.
<http://webkit.org/b/111940>
Reviewed by Anders Carlsson.
- UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::invalidate):
(WebKit::WebPluginSiteDataManager::getSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):
(WebKit::WebPluginSiteDataManager::didGetSitesWithDataForAllPlugins):
(WebKit::WebPluginSiteDataManager::didClearSiteDataForAllPlugins):
- UIProcess/Plugins/WebPluginSiteDataManager.h:
(WebPluginSiteDataManager):
- 9:46 AM Changeset in webkit [145327] by
-
- 2 edits in trunk/Source/WebCore
GlyphMetricsMap should use OwnPtr.
<http://webkit.org/b/111937>
Reviewed by Anders Carlsson.
Use OwnPtr instead of raw pointer + deleteAllValues().
- platform/graphics/GlyphMetricsMap.h:
(GlyphMetricsMap):
(WebCore::::locatePageSlowCase):
- 9:09 AM Changeset in webkit [145326] by
-
- 3 edits in trunk/Source/WebCore
Allow iOS port to use InbandTextTrackPrivateAVF
https://bugs.webkit.org/show_bug.cgi?id=111933
Reviewed by Dean Jackson.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCue): Drive-by cleanup.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- 8:46 AM Changeset in webkit [145325] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0
Merge r144765 - Unreviewed build fix.
.:
- GNUmakefile.am: remove bad path for generate-feature-defines-files from EXTRA_DIST.
Tools:
- GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
- 8:38 AM WebKitGTK/2.0.x edited by
- (diff)
- 8:37 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:18 AM WebKit Team edited by
- Add myself to committers list (diff)
Mar 9, 2013:
- 2:48 PM Changeset in webkit [145323] by
-
- 16 edits8 deletes in trunk
Unreviewed, rolling out r145299.
http://trac.webkit.org/changeset/145299
https://bugs.webkit.org/show_bug.cgi?id=111928
compilation failure with recent clang
(DFGBackwardsPropagationPhase.cpp:132:35: error: comparison of
constant 10 with expression of type 'bool' is always false)
(Requested by thorton on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-09
Source/JavaScriptCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
- dfg/DFGBackwardsPropagationPhase.cpp: Removed.
- dfg/DFGBackwardsPropagationPhase.h: Removed.
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::run):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::nodeFlagsAsString):
(DFG):
- dfg/DFGNodeFlags.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::isNotNegZero):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::isNotZero):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoForConstant):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoNonRecursive):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):
- dfg/DFGUnificationPhase.cpp:
(JSC::DFG::UnificationPhase::run):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(VariableAccessData):
LayoutTests:
- fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int-expected.txt: Removed.
- fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.html: Removed.
- fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers-expected.txt: Removed.
- fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.html: Removed.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js: Removed.
- fast/js/script-tests/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.js: Removed.
- 1:29 PM Changeset in webkit [145322] by
-
- 11 edits2 adds in trunk/Source/WebCore
Enable platform code to implement text track menu
https://bugs.webkit.org/show_bug.cgi?id=111924
Reviewed by Dean Jackson.
No new tests, the new code isn't enabled in any ports yet.
- WebCore.xcodeproj/project.pbxproj: Add PlatformTextTrack.h and PlatformTextTrackMenu.h.
- html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::createForJSConstructor): scheduleLoad -> scheduleDelayedAction.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Deal with scheduleLoad to scheduleDelayedAction rename.
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
(WebCore::HTMLMediaElement::finishParsingChildren): Ditto.
(WebCore::HTMLMediaElement::insertedInto): Ditto.
(WebCore::HTMLMediaElement::scheduleDelayedAction): Ditto.
(WebCore::HTMLMediaElement::scheduleNextSourceChild): Ditto.
(WebCore::HTMLMediaElement::loadTimerFired): Ditto.
(WebCore::HTMLMediaElement::textTrackModeChanged): Notify platform menu of track change.
(WebCore::HTMLMediaElement::playInternal): Deal with scheduleLoad to scheduleDelayedAction rename.
(WebCore::HTMLMediaElement::pauseInternal): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerDidAddTrack): Ditto. Call addTrack() instead of appending
the track directly.
(WebCore::HTMLMediaElement::setSelectedTextTrack): Deal with platform menu changing the
selected track.
(WebCore::HTMLMediaElement::platformTextTracks): Return an array of PlatformTracks representing
the current text tracks.
(WebCore::HTMLMediaElement::notifyMediaPlayerOfTextTrackChanges): Notify the platform menu
that the list of text tracks has changed.
(WebCore::HTMLMediaElement::platformTextTrackMenu): Return the platform track menu, if any.
(WebCore::HTMLMediaElement::closeCaptionTracksChanged):
(WebCore::HTMLMediaElement::addTrack): Call addTrack() instead of appending the track directly.
(WebCore::HTMLMediaElement::removeTrack): Call closeCaptionTracksChanged.
(WebCore::HTMLMediaElement::addTextTrack): Call addTrack() instead of appending the track directly.
(WebCore::HTMLMediaElement::didAddTrack): Ditto.
(WebCore::HTMLMediaElement::didRemoveTrack): Deal with scheduleLoad to scheduleDelayedAction rename.
(WebCore::HTMLMediaElement::sourceWasAdded): Ditto.
(WebCore::HTMLMediaElement::clearMediaPlayer): Forget the platform track menu.
(WebCore::HTMLMediaElement::resume): Deal with scheduleLoad to scheduleDelayedAction rename.
- html/HTMLMediaElement.h:
- html/track/InbandTextTrack.h: scheduleLoad -> scheduleDelayedAction.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::platformTextTrack): Create a PlatformTextTrack.
- html/track/TextTrack.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::implementsTextTrackControls): New, player private passthrough.
(WebCore::MediaPlayer::textTrackMenu): Ditto.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
- platform/graphics/PlatformTextTrack.h: Added.
- platform/graphics/PlatformTextTrackMenu.h: Added.
- 1:27 PM Changeset in webkit [145321] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove deprecated flingStart.sourceDevice from WebGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=111866
Reviewed by James Robinson.
- public/WebInputEvent.h:
- 11:43 AM Changeset in webkit [145320] by
-
- 2 edits in trunk/Source/WebCore
Video size calculated incorrectly when PLUGIN_PROXY_FOR_VIDEO
https://bugs.webkit.org/show_bug.cgi?id=111912
Reviewed by Dean Jackson.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateSizes): We use RenderPart when
PLUGIN_PROXY_FOR_VIDEO is defined, not RenderVideo.
- 8:54 AM Changeset in webkit [145319] by
-
- 6 edits in trunk/Source/WebKit/chromium
[chromium] Set the Helper Plugin's URL to that of the host document.
https://bugs.webkit.org/show_bug.cgi?id=111913
This allows content settings, etc. to be based on the document hosting
the element that requested the Helper Plugin.
Patch by David Dorwin <ddorwin@chromium.org> on 2013-03-09
Reviewed by Adam Barth.
- src/WebHelperPluginImpl.cpp:
(WebKit::writeDocument):
(WebKit::WebHelperPluginImpl::initialize):
(WebKit::WebHelperPluginImpl::initializePage):
- src/WebHelperPluginImpl.h:
(WebKit):
(WebHelperPluginImpl):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::createHelperPlugin):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createHelperPlugin):
- src/WebViewImpl.h:
(WebViewImpl):
- 8:34 AM Changeset in webkit [145318] by
-
- 2 edits in trunk/Source/WebCore
Fix offset handling in GStreamer WebKitWebSource.
https://bugs.webkit.org/show_bug.cgi?id=111888
Patch by Sebastian Dröge <sebastian.droege@collabora.co.uk> on 2013-03-09
Reviewed by Philippe Normand.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcSeekDataCb):
(StreamingClient::didReceiveData):
The offset handling in WebKitWebSource was completely wrong
before and caused wrong offsets to be set on the GStreamer buffers
after a seek.
Apart from that there was also a race condition that happens
when a downstream element causes seeks in very short succession
and is switching between two different parts of the stream.
- 4:45 AM Changeset in webkit [145317] by
-
- 1 edit9 adds in trunk/LayoutTests
Add tests for opening the picker with the f4 key
https://bugs.webkit.org/show_bug.cgi?id=111811
Reviewed by Kent Tamura.
- platform/chromium-win/fast/forms/calendar-picker/date-open-picker-with-f4-key-expected.txt: Added.
- platform/chromium-win/fast/forms/calendar-picker/date-open-picker-with-f4-key.html: Added.
- platform/chromium-win/fast/forms/calendar-picker/datetimelocal-open-picker-with-f4-key-expected.txt: Added.
- platform/chromium-win/fast/forms/calendar-picker/datetimelocal-open-picker-with-f4-key.html: Added.
- platform/chromium-win/fast/forms/calendar-picker/month-open-picker-with-f4-key-expected.txt: Added.
- platform/chromium-win/fast/forms/calendar-picker/month-open-picker-with-f4-key.html: Added.
- platform/chromium-win/fast/forms/calendar-picker/week-open-picker-with-f4-key-expected.txt: Added.
- platform/chromium-win/fast/forms/calendar-picker/week-open-picker-with-f4-key.html: Added.
- 4:43 AM Changeset in webkit [145316] by
-
- 10 edits in trunk
Month transition animation is missing in some places
https://bugs.webkit.org/show_bug.cgi?id=111908
Reviewed by Kent Tamura.
Source/WebCore:
Month transition animation was missing when navigating using keyboard
shortcuts and when navigation was trigger by selecting.
Added tests to calendar-picker/*-picker-key-operations.html.
- Resources/pagepopups/calendarPicker.js:
(Animator): Added annotations.
(Animator.prototype.isRunning): Returns true of the animation is running. Used by test.
(ScrollView.prototype.scrollAnimator): Returns the scroll animator. Used by test.
(CalendarPicker):
(CalendarPicker.prototype.onYearListViewDidSelectMonth): Use CalendarPicker.NavigationBehavior enum instead of bool.
(CalendarPicker.prototype.setSelection): Ditto.
(CalendarPicker.prototype._moveHighlight): Ditto.
(CalendarPicker.prototype.onCalendarTableKeyDown): Ditto.
(CalendarPicker.prototype.onBodyKeyDown): Ditto.
LayoutTests:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(isCalendarTableScrollingWithAnimation):
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html:
- 3:27 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:25 AM Changeset in webkit [145315] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk
Merge r144055 - REGRESSION (r143619): Crashes in three layout tests
https://bugs.webkit.org/show_bug.cgi?id=110588
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-26
Reviewed by Gustavo Noronha Silva.
Source/WebKit/gtk:
Guard against null main resource identifiers. The main resource
identifier can be null at various times during the load. A null
identifier is never equal to the ones we are looking to remove.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidFinishLoading): Use the new webkitWebViewRemoveSubresource helper.
(WebKit::FrameLoaderClient::dispatchDidFailLoading): ditto.
- webkit/webkitwebview.cpp:
(webkitWebViewRemoveSubresource): Added this helper which removes a subresource, but
never touches the main resource. This is adapted from the old method, for which the
main resource branch was dead code.
- webkit/webkitwebviewprivate.h: Update the method list.
- 3:20 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:19 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:17 AM Changeset in webkit [145314] by
-
- 5 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r145244 - [WK2][GTK] Invalid request returned by webkit_download_get_request if called before download starts
https://bugs.webkit.org/show_bug.cgi?id=111574
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Alexey Proskuryakov.
webkit_download_get_request() creates the WebKitURIRequest object
on demand using the ResourceRequest from the DownloadProxy. The
ResourceRequest of the DownloadProxy is set in
DownloadProxy::didStart(), so if we call
webkit_download_get_request() before didStart we return an invalid
WebKitURIRequest created from a NULL ResourceRequest. This is not
a problem for downloads started in the web process, because we
create the WebKitDownload after DownloadProxy::didStart(). For
downloads started manually with webkit_web_context_download_uri()
we need to create download object with the ResourceRequest passed
to the DownloadProxy.
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkitDownloadCreateForRequest): New helper function for
downloads started manually to created them with a given
ResourceRequest.
- UIProcess/API/gtk/WebKitDownloadPrivate.h:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextStartDownload): Use
webkitDownloadCreateForRequest().
- UIProcess/API/gtk/tests/TestDownloads.cpp:
(testDownloadLocalFile):
(testDownloadLocalFileError):
(testDownloadRemoteFile):
(testDownloadRemoteFileError):
(testPolicyResponseDownload):
- 3:10 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:09 AM Changeset in webkit [145313] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r145202 - [GTK] Memory leak in webkit_web_view_load_request() in WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=111160
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Benjamin Poulain.
leakRef() is used for the returned PassRefPtr without taking the
ownership of the leaked ref.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_request): Use RefPtr local variable.
- 3:08 AM Changeset in webkit [145312] by
-
- 2 edits in trunk/Source/WebCore
Can't build w/o accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=111891
Patch originally came from Tobias Mueller <tobiasmue@gnome.org>
Unreviewed build fix for platforms without ACCELERATED_COMPOSITING enabled, which
broke in r145057.
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::~PseudoElement): Wrap the call to pseudoElementDestroyed in
USE(ACCELERATED_COMPOSITING)
- 3:05 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:04 AM Changeset in webkit [145311] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge r145307 - [GTK] Versions.m4 is missing some key dependencies version definitions
https://bugs.webkit.org/show_bug.cgi?id=111903
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-09
Reviewed by Carlos Garcia Campos.
- Source/autotools/Versions.m4: Add missing required version
definitions.
- 3:00 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:58 AM Changeset in webkit [145310] by
-
- 5 edits in releases/WebKitGTK/webkit-2.0
Merge r145199 - [GTK] Remove media stream support from the configuration options
https://bugs.webkit.org/show_bug.cgi?id=111813
Reviewed by Philippe Normand.
Remove the media-stream configuration flag. The feature is incomplete and
thus unsupported, so it really shouldn't be possible to enable it.
- Source/autotools/PrintBuildConfiguration.m4:
- Source/autotools/ReadCommandLineArguments.m4:
- Source/autotools/SetupAutomake.m4:
- Source/autotools/SetupWebKitFeatures.m4:
- 2:54 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:52 AM Changeset in webkit [145309] by
-
- 10 edits in releases/WebKitGTK/webkit-2.0
Merge r145084 - [GTK] Limit the supported compilers to GCC >= 4.7 and Clang >= 3.0
https://bugs.webkit.org/show_bug.cgi?id=109932
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-03-07
Reviewed by Martin Robinson.
.:
- Source/autotools/CheckSystemAndBasicDependencies.m4: Strictly check for one of the two compilers.
- Source/autotools/SetupCompilerFlags.m4: Set up C++11-specific compiler flags. Force the C99 standard for the C code.
Use the -Qunused-arguments flag when using Clang, it reduces irrelevant errors when using ccache.
Source/WebCore:
- GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.
They are now available by default due to the limited set of supported compilers.
- bindings/gobject/GNUmakefile.am: Ditto.
Source/WebKit/gtk:
- GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.
They are now available by default due to the limited set of supported compilers.
Source/WebKit2:
- GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.
They are now available by default due to the limited set of supported compilers.
- 1:50 AM Changeset in webkit [145308] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] Fix compilation warning missing-field-initializers in webkit-2.0 stable branch
https://bugs.webkit.org/show_bug.cgi?id=111863
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-09
Reviewed by Benjamin Poulain.
- UIProcess/API/gtk/WebKitUIClient.cpp:
(attachUIClientToView): Include missing initializer for pluginLoadPolicy.
- 1:37 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:31 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:30 AM Changeset in webkit [145307] by
-
- 2 edits in trunk
[GTK] Versions.m4 is missing some key dependencies version definitions
https://bugs.webkit.org/show_bug.cgi?id=111903
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-09
Reviewed by Carlos Garcia Campos.
- Source/autotools/Versions.m4: Add missing required version
definitions.
- 1:30 AM Changeset in webkit [145306] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge r144222 - [GTK] Disable MathML support in release builds
https://bugs.webkit.org/show_bug.cgi?id=110981
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-02-27
Reviewed by Martin Robinson.
- Source/autotools/SetupWebKitFeatures.m4: Disable the MathML support in release builds
as the code is not yet deemed production-ready.
