Timeline

Mar 15, 2013:

11:16 PM Changeset in webkit [145986] by Simon Fraser

• 2 edits in trunk/LayoutTests

Mark two media/track tests as flakey. Tracked by webkit.org/b/112492

• platform/mac/TestExpectations:

10:58 PM Changeset in webkit [145985] by Simon Fraser

• 1 edit
  1 delete in trunk/LayoutTests

Remove result in platform/mac/platform/mac

• platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Removed.

10:06 PM Changeset in webkit [145984] by Simon Fraser

• 2 edits in trunk/LayoutTests

Fix typo in TestExpectations file.

• platform/mac/TestExpectations:

9:56 PM Changeset in webkit [145983] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Reflected video elements hit assertion on Lion
​https://bugs.webkit.org/show_bug.cgi?id=112490

Disable the new reflected video functionality added in r145915
on Lion because of a nasty re-entrancy problem. Tracked by bug 112490.

• platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::clone):

9:40 PM Changeset in webkit [145982] by commit-queue@webkit.org

• 4 edits
  4 adds in trunk

[CSS Exclusions] shape-outside on floats for circle and ellipse shapes
​https://bugs.webkit.org/show_bug.cgi?id=98673

Source/WebCore:

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-15
Reviewed by Dirk Schulze.

Enable circles and ellipses for shape-outside on floats. Most of the
code already supports them, just needed to turn them on and add tests.

Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle.html

fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse.html

• rendering/ExclusionShapeOutsideInfo.cpp:

(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Enable circles and

ellipses. Also add a check for if the RenderBox is floating, since
that test should have been there all along, as shape outside is
only supported on floats for now.

LayoutTests:

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-15
Reviewed by Dirk Schulze.

Tests for circles and ellipses on floats.

• fast/exclusions/resources/rounded-rectangle.js:

(defined): Helper function to test and see if a js value is defined.
(convertToRoundedRect): Convert a circle or ellipse dimensions to a rounded rect.
(generateShapeOutsideOnFloat): Add ability to generate circles and

ellipses, since they are just special cases of rounded rectangles.

(generateSimulatedShapeOutsideOnFloat): Add ability to simulate

circles and ellipses, by treating them as rounded rectangles. Also
fix minor style issue with an if statement.

(xOutset): Remove unneeded condition in if statement.

• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle-expected.html: Added.
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle.html: Added.
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse-expected.html: Added.
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse.html: Added.

9:37 PM Changeset in webkit [145981] by Simon Fraser

• 2 edits in trunk/Tools

REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
​https://bugs.webkit.org/show_bug.cgi?id=112205

Disable this API test until Geoff can fix it.

• TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:

(TestWebKitAPI::TEST):

8:49 PM Changeset in webkit [145980] by Simon Fraser

• 2 edits in trunk/LayoutTests

Rebaseline after r145977.

• platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:

8:47 PM Changeset in webkit [145979] by Simon Fraser

• 2 edits in trunk/LayoutTests

Rebaseline after r145977.

• platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:

8:25 PM Changeset in webkit [145978] by kbr@google.com

• 13 edits in trunk/LayoutTests

Unreviewed new baselines after r145977.
​https://bugs.webkit.org/show_bug.cgi?id=110837

• platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
• platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
• platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
• platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
• platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
• platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
• platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
• platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
• platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
• platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
• platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
• platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:

7:27 PM Changeset in webkit [145977] by commit-queue@webkit.org

• 159 edits in trunk

Convert old flexbox uses in html.css to new flexbox (non-<select>)
​https://bugs.webkit.org/show_bug.cgi?id=110837

Patch by Christian Biesinger <​cbiesinger@chromium.org> on 2013-03-15
Reviewed by Ojan Vafai.

Source/WebCore:

Covered by existing tests.

• rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
After we set our descendants' heights, we need to mark them for
layout.
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
Use new-flexbox style setters.

• css/html.css:

(input::-webkit-textfield-decoration-container):
(input[type="search"]::-webkit-search-cancel-button):
(input[type="search"]::-webkit-search-decoration):
(input[type="search"]::-webkit-search-results-decoration):
(input[type="search"]::-webkit-search-results-button):
(input::-webkit-inner-spin-button):
(input::-webkit-input-speech-button):
(textarea):
(input[type="file"]):
(input[type="color"]::-webkit-color-swatch-wrapper):
(input[type="color"]::-webkit-color-swatch):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-text-block):

• css/themeWin.css:

(input[type="search"]::-webkit-search-results-decoration):
(input[type="search"]::-webkit-search-results-button):
Convert -webkit-box to -webkit-flex and adjust related properties.
Notably switch to auto margins for centering the speech button as well
as the search result and cancel buttons to stay compatible with the
previous centering behaviour. This does not produce visible
differences but eliminates the render tree dump changes.

• html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):

• html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerContainer::TextControlInnerContainer):
(WebCore):
(WebCore::TextControlInnerContainer::create):
(WebCore::TextControlInnerContainer::createRenderer):

• html/shadow/TextControlInnerElements.h:

(TextControlInnerContainer):
(WebCore):

• rendering/RenderTextControl.cpp:

(WebCore::RenderTextControlInnerContainer::RenderTextControlInnerContainer):
(WebCore):
(WebCore::RenderTextControlInnerContainer::~RenderTextControlInnerContainer):

• rendering/RenderTextControl.h:

(WebCore):
(RenderTextControlInnerContainer):
Create a new DOM element & renderer type for the textfield-decoration
div (the direct child of the <input> in the shadow dom if we have a
special input field). This is necessary because new-flexbox uses a
different algorithm for calculating the baseline, which would
otherwise cause an <input> and an <input type=search> to not be
aligned with each other.
The new renderer just calls back to RenderBlock for calculating the
baseline.

• rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
Make sure to mark renderers as needing layout when we change their
style. This didn't use to be necessary because old-flexbox relayouts
children even when they are not marked for needing layout.
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
Use new-flexbox CSS properties.

• html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::decorate):
Use new-flexbox CSS properties.

LayoutTests:

• fast/forms/placeholder-position-expected.txt:
• platform/chromium-linux/fast/css/input-search-padding-expected.txt:
• platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
• platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
• platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
• platform/chromium-linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
• platform/chromium-linux/fast/forms/search-styled-expected.txt:
• platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
• platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
• platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
• platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
• platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
• platform/chromium-mac-lion/fast/forms/search-rtl-expected.txt:
• platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt:
• platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt:
• platform/chromium-mac/fast/css/text-overflow-input-expected.txt:
• platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
• platform/chromium-mac/fast/forms/control-restrict-line-height-expected.txt:
• platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
• platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
• platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
• platform/chromium-mac/fast/forms/search-rtl-expected.txt:
• platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt:
• platform/chromium-mac/fast/forms/searchfield-heights-expected.txt:
• platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
• platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
• platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
• platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
• platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
• platform/chromium-win/fast/css/input-search-padding-expected.txt:
• platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
• platform/chromium-win/fast/css/text-overflow-input-expected.txt:
• platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
• platform/chromium-win/fast/forms/control-restrict-line-height-expected.txt:
• platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
• platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.txt:
• platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
• platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
• platform/chromium-win/fast/forms/placeholder-position-expected.txt:
• platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
• platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
• platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
• platform/chromium-win/fast/forms/search-rtl-expected.txt:
• platform/chromium-win/fast/forms/search-styled-expected.txt:
• platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
• platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
• platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
• platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
• platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
• platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
• platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
• platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
• platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt:
• platform/chromium/fast/css/input-search-padding-expected.txt:
• platform/chromium/fast/css/text-input-with-webkit-border-radius-expected.txt:
• platform/chromium/fast/forms/number/number-appearance-rtl-expected.txt:
• platform/chromium/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
• platform/chromium/fast/forms/search-cancel-button-style-sharing-expected.txt:
• platform/chromium/fast/forms/search-display-none-cancel-button-expected.txt:
• platform/chromium/fast/forms/search-rtl-expected.txt:
• platform/chromium/fast/forms/search-styled-expected.txt:
• platform/chromium/fast/repaint/search-field-cancel-expected.txt:
• platform/chromium/fast/replaced/width100percent-searchfield-expected.txt:
• platform/chromium/fast/speech/speech-bidi-rendering-expected.txt:
• platform/efl/fast/css/input-search-padding-expected.txt:
• platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
• platform/efl/fast/css/text-overflow-input-expected.txt:
• platform/efl/fast/forms/box-shadow-override-expected.txt:
• platform/efl/fast/forms/control-restrict-line-height-expected.txt:
• platform/efl/fast/forms/input-appearance-height-expected.txt:
• platform/efl/fast/forms/number/number-appearance-rtl-expected.txt:
• platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
• platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
• platform/efl/fast/forms/placeholder-position-expected.txt:
• platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
• platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
• platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
• platform/efl/fast/forms/search-rtl-expected.txt:
• platform/efl/fast/forms/search-styled-expected.txt:
• platform/efl/fast/forms/search-vertical-alignment-expected.txt:
• platform/efl/fast/forms/searchfield-heights-expected.txt:
• platform/efl/fast/forms/validation-message-appearance-expected.txt:
• platform/efl/fast/repaint/search-field-cancel-expected.txt:
• platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
• platform/gtk/fast/css/input-search-padding-expected.txt:
• platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
• platform/gtk/fast/css/text-overflow-input-expected.txt:
• platform/gtk/fast/forms/box-shadow-override-expected.txt:
• platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
• platform/gtk/fast/forms/input-appearance-height-expected.txt:
• platform/gtk/fast/forms/number/number-appearance-rtl-expected.txt:
• platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
• platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
• platform/gtk/fast/forms/placeholder-position-expected.txt:
• platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
• platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
• platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
• platform/gtk/fast/forms/search-rtl-expected.txt:
• platform/gtk/fast/forms/search-styled-expected.txt:
• platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
• platform/gtk/fast/forms/searchfield-heights-expected.txt:
• platform/gtk/fast/forms/validation-message-appearance-expected.txt:
• platform/gtk/fast/repaint/search-field-cancel-expected.txt:
• platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
• platform/gtk/fast/speech/input-appearance-searchandspeech-expected.txt:
• platform/mac/fast/css/input-search-padding-expected.txt:
• platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
• platform/mac/fast/css/text-overflow-input-expected.txt:
• platform/mac/fast/forms/box-shadow-override-expected.txt:
• platform/mac/fast/forms/control-restrict-line-height-expected.txt:
• platform/mac/fast/forms/input-appearance-height-expected.txt:
• platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
• platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
• platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
• platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
• platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
• platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
• platform/mac/fast/forms/search-rtl-expected.txt:
• platform/mac/fast/forms/search-styled-expected.txt:
• platform/mac/fast/forms/search-vertical-alignment-expected.txt:
• platform/mac/fast/forms/searchfield-heights-expected.txt:
• platform/mac/fast/forms/validation-message-appearance-expected.txt:
• platform/mac/fast/repaint/search-field-cancel-expected.txt:
• platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
• platform/mac/fast/speech/speech-bidi-rendering-expected.txt:
• platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt:
• platform/qt/fast/css/input-search-padding-expected.txt:
• platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
• platform/qt/fast/css/text-overflow-input-expected.txt:
• platform/qt/fast/forms/box-shadow-override-expected.txt:
• platform/qt/fast/forms/control-restrict-line-height-expected.txt:
• platform/qt/fast/forms/number/number-appearance-rtl-expected.txt:
• platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
• platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
• platform/qt/fast/forms/placeholder-position-expected.txt:
• platform/qt/fast/forms/placeholder-pseudo-style-expected.txt:
• platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
• platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
• platform/qt/fast/forms/search-rtl-expected.txt:
• platform/qt/fast/forms/search-styled-expected.txt:
• platform/qt/fast/forms/search-vertical-alignment-expected.txt:
• platform/qt/fast/repaint/search-field-cancel-expected.txt:
• platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
• platform/qt/fast/speech/input-appearance-searchandspeech-expected.txt:

Automated search & replace of RenderDeprecatedFlexibleBox ->
RenderFlexibleBox

• platform/mac/fast/forms/color/input-appearance-color-expected.txt:
• platform/chromium-mac/fast/forms/color/input-appearance-color-expected.txt:
• platform/chromium-win/fast/forms/color/input-appearance-color-expected.txt:
• platform/chromium-linux/fast/forms/color/input-appearance-color-expected.png:

This test shows a minor layout difference (less spacing between
paragraphs with an <input type=color>). The underlying reason is
alignment/baseline-differences with the new flexbox code, and the new
behaviour makes more sense in general (this becomes obvious when
putting text or a <input type=text> next to an <input type=color>).

• platform/chromium/TestExpectations:

Mark input-appearance-color as needing rebaseline on Mac/Win. All
non-Chromium ports ignore fast/forms/color because the feature isn't
enabled, so their TestExpectations need no update.

7:22 PM Changeset in webkit [145976] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r188504. Requested by
"Dana Jansens" <​danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-15

• DEPS:

7:13 PM Changeset in webkit [145975] by kbr@google.com

• 2 edits in trunk/Source/WebCore

Unreviewed attempted build fix for Chromium Windows after r145929.
Verified this fix builds and works on Linux.
​https://bugs.webkit.org/show_bug.cgi?id=96798

• bindings/v8/V8Binding.cpp:

(WebCore):

6:22 PM Changeset in webkit [145974] by Simon Fraser

• 3 edits
  2 adds in trunk/LayoutTests

Added some expected results that should be the same across platforms.
Removed some tests needing rebaseline from Mac TestExpectations.

• compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
• compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.txt: Added.
• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:

6:20 PM Changeset in webkit [145973] by Nate Chapin

• 5 edits in trunk/Source/WebCore

Merge MainResourceLoader::willSendRequest into DocumentLoader
​https://bugs.webkit.org/show_bug.cgi?id=109757

This is one of the steps to merging MainResourceLoader entirely into
DocumentLoader, given the lack of clear division of responsibility
between the two.

Reviewed by Antti Koivisto.

No new tests, refactor only.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::mainResourceData):
(WebCore::DocumentLoader::isPostOrRedirectAfterPost):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::callContinueAfterNavigationPolicy):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::startLoadingMainResource):

• loader/DocumentLoader.h:
• loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::resourceData):
(WebCore::MainResourceLoader::redirectReceived):
(WebCore::MainResourceLoader::continueAfterContentPolicy):
(WebCore::MainResourceLoader::reportMemoryUsage):
(WebCore::MainResourceLoader::handleSubstituteDataLoadNow):
(WebCore::MainResourceLoader::load):

• loader/MainResourceLoader.h:

(WebCore::MainResourceLoader::takeIdentifierFromResourceLoader): Temporarily

exposed for moving from a normal load to SubstituteData load on redirect.

6:11 PM Changeset in webkit [145972] by zmo@google.com

• 2 edits in trunk/Source/WebCore

Disable EXT_draw_buffers WebGL extension on Mac
​https://bugs.webkit.org/show_bug.cgi?id=112486

Reviewed by Kenneth Russell.

• html/canvas/EXTDrawBuffers.cpp:

(WebCore::EXTDrawBuffers::supported):

5:54 PM Changeset in webkit [145971] by kbr@google.com

• 1 edit
  6 adds in trunk/LayoutTests

Unreviewed addition of expectations for test added in r145915.

• platform/chromium-mac-lion/compositing/video/video-reflection-expected.png: Added.
• platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.
• platform/chromium-mac/compositing/video/video-reflection-expected.png: Added.
• platform/chromium-mac/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.
• platform/chromium-win/compositing/video/video-reflection-expected.png: Added.
• platform/chromium-win/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.

5:43 PM Changeset in webkit [145970] by danakj@chromium.org

• 5 edits
  9 deletes in trunk

[chromium] Remove the background filter blur layout tests
​https://bugs.webkit.org/show_bug.cgi?id=112372

Reviewed by James Robinson.

Source/WebCore:

Remove the now-unused hacks to regression test the background
filter blur compositor feature.

• testing/Internals.cpp:
• testing/Internals.h:

(Internals):

• testing/Internals.idl:

LayoutTests:

Given that we now have the ability to write pixel tests directly against
the compositor, these tests are no longer needed to guard against
regressions, and have been duplicated for the compositor as pixel tests
in ​https://codereview.chromium.org/12518026/ and
​https://codereview.chromium.org/12518026/.

• platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
• platform/chromium/compositing/filters/background-filter-blur-expected.txt: Removed.
• platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
• platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.txt: Removed.
• platform/chromium/compositing/filters/background-filter-blur-off-axis.html: Removed.
• platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
• platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Removed.
• platform/chromium/compositing/filters/background-filter-blur-outsets.html: Removed.
• platform/chromium/compositing/filters/background-filter-blur.html: Removed.

5:37 PM Changeset in webkit [145969] by Simon Fraser

• 2 edits in trunk/LayoutTests

Mark fast/frames/sandboxed-iframe-scripting as flakey.

webkit.org/b/104848 supposedly fixed fast/frames/sandboxed-iframe-parsing-space-characters.html,
so remove it.

• platform/mac/TestExpectations:

5:36 PM Changeset in webkit [145968] by anilsson@rim.com

• 16 edits in trunk/Source/WebKit/blackberry

[BlackBerry] BlackBerry::Platform::Graphics::GraphicsContext integration related changes in Source/WebKit/blackberry
​https://bugs.webkit.org/show_bug.cgi?id=112467

Reviewed by Rob Buis.

PR 293208

This patch contains contributions from many members of the BlackBerry
WebKit team:

Mike Lattanzio
Arvid Nilsson
Jakob Petsovits
Konrad Piascik
Jeff Rogers
Filip Spacek

• Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
(BlackBerry::WebKit::BackingStorePrivate::tileSize):

• Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivate::drawContents):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToImage):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::clearUploadedContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):

• Api/WebOverlay.h:
• Api/WebOverlayClient.h:
• Api/WebOverlay_p.h:

(WebOverlayPrivate):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
(WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::image):
(WebOverlayPrivateCompositingThread):

• Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):

• WebKitSupport/BackingStoreTile.cpp:

(BlackBerry::WebKit::TileBuffer::~TileBuffer):
(BlackBerry::WebKit::TileBuffer::nativeBuffer):
(BlackBerry::WebKit::TileBuffer::paintBackground):

• WebKitSupport/DefaultTapHighlight.cpp:

(BlackBerry::WebKit::DefaultTapHighlight::paintContents):
(BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):

• WebKitSupport/DefaultTapHighlight.h:

(DefaultTapHighlight):

• WebKitSupport/InspectorOverlayBlackBerry.cpp:

(BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):

• WebKitSupport/InspectorOverlayBlackBerry.h:

(InspectorOverlay):

• WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::draw):
(BlackBerry::WebKit::SelectionOverlay::hide):
(BlackBerry::WebKit::SelectionOverlay::paintContents):
(BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):

• WebKitSupport/SelectionOverlay.h:

(SelectionOverlay):

• WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
(BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
(BlackBerry::WebKit::SurfacePool::waitForBuffer):
(BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
(BlackBerry::WebKit::SurfacePool::destroyPlatformSync):

• WebKitSupport/SurfacePool.h:

5:20 PM Changeset in webkit [145967] by jochen@chromium.org

• 7 edits
  1 delete in trunk

plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
​https://bugs.webkit.org/show_bug.cgi?id=112478

Reviewed by Tony Chang.

There is nothing that ensures that the log messages from the plugin
come in before the layout test finished loading.

Tools:

• DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:

(PassDifferentNPPStruct::NPP_SetWindow):

• DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_SetWindow):

LayoutTests:

• platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Removed.
• plugins/netscape-plugin-setwindow-size-2.html:
• plugins/netscape-plugin-setwindow-size.html:
• plugins/pass-different-npp-struct.html:

4:52 PM Changeset in webkit [145966] by Simon Fraser

• 2 edits in trunk/LayoutTests

Mark some more sputnik tests as slow in debug.

• platform/mac/TestExpectations:

4:40 PM Changeset in webkit [145965] by ap@apple.com

• 4 edits in trunk/Source/WebCore

Reduce amount of platform specific code in MessagePortChannel
​https://bugs.webkit.org/show_bug.cgi?id=112469

Reviewed by Sam Weinig.

• dom/MessagePortChannel.h: Ifdefed out an unused channel() function, except for Chromium, where it is used. We certainly don't want to expose this implementation detail as a public function.

• dom/default/PlatformMessagePortChannel.h: Removed functions that are no longer delegated. Made class contents all public, as it's now basically a data storage for MessagePortChannel.

• dom/default/PlatformMessagePortChannel.cpp: (WebCore::MessagePortChannel::createChannel): (WebCore::MessagePortChannel::~MessagePortChannel): (WebCore::MessagePortChannel::entangleIfOpen): (WebCore::MessagePortChannel::disentangle): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::MessagePortChannel::close): (WebCore::MessagePortChannel::isConnectedTo): (WebCore::MessagePortChannel::hasPendingActivity): (WebCore::MessagePortChannel::locallyEntangledPort): (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::entangledChannel): Moved code from PlatformMessagePortChannel to MessagePortChannel. Added some FIXMEs.

4:36 PM Changeset in webkit [145964] by Simon Fraser

• 2 edits in trunk/LayoutTests

New baseline for this test on Lion.

• platform/mac-lion/platform/mac/fast/text/vertical-no-sideways-expected.txt:

4:30 PM Changeset in webkit [145963] by timothy@apple.com

• 4 edits in trunk/Source

Disable suppressesIncrementalRendering for the Web Inspector.

This ends up causing the Inspector to show blank for a couple seconds before
it does its first paint. During that time the bare window chrome is showing
when the Inspector's background and other simple elements count be painting.
This causes the Inspector to look like it is loading slower than reality.

Source/WebKit/mac:

​https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

• WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController init]): Disable suppressesIncrementalRendering.

Source/WebKit2:

​https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

• UIProcess/WebInspectorProxy.cpp:

(WebKit::createInspectorPageGroup): Disable suppressesIncrementalRendering.

4:30 PM Changeset in webkit [145962] by anilsson@rim.com

• 6 edits in trunk/Source

[BlackBerry] Expose the compositing thread layer's draw rectangle to aid hit testing
​https://bugs.webkit.org/show_bug.cgi?id=112255

Reviewed by Rob Buis.

PR 308284.
Reviewed internally by Yongxin Dai.

Source/WebCore:

Add a getter for the layer renderer of a compositing thread layer.

No change in behavior, no new tests.

• platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerCompositingThread::layerRenderer):

Source/WebKit/blackberry:

The cached draw rectangle is useful for hit testing. Add a getter for
this compositing thread layer property to the public WebOverlay API.
We name this getter using terminology familiar from the
ViewportAccessor interface, to clarify which coordinate system the
getter uses (pixel coordinates relative to the viewport).

Note that WebKit-thread flavor of WebOverlay is not currently used by
any API client and is marked obsolete. It is used internally in WebKit,
but for that case using GraphicsLayer directly works well. This will
allow the complexity of WebOverlay to be significantly reduced in the
future, by removing the WebKit-thread flavor entirely.

• Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlay::pixelViewportRect):
(WebKit):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::pixelViewportRect):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):

• Api/WebOverlay.h:

(WebKit):

• Api/WebOverlay_p.h:

(WebOverlayPrivate):
(WebOverlayPrivateWebKitThread):
(WebOverlayPrivateCompositingThread):

4:29 PM Changeset in webkit [145961] by timothy@apple.com

• 6 edits in trunk/Source/WebKit2

Delay creating the Inspector window so we don't cause a CoreIPC deadlock.

Other changes include:

• Create the Inspector WKView at the correct size so it does not need to resize later when added to the window.
• Update the minimum and initial window sizes to better match the new UI.
• Store the Inspector window frame in WebKit preferences so each page group can have different saved window frames. Handy for inspecting the Inspector.

​https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

• Shared/WebPreferencesStore.cpp:

(WebKit::defaultValueForKey):
Added FOR_EACH_WEBKIT_STRING_PREFERENCE_NOT_IN_WEBCORE.

• Shared/WebPreferencesStore.h:

(FOR_EACH_WEBKIT_STRING_PREFERENCE_NOT_IN_WEBCORE):
Added. Needed to keep WebPage::updatePreferences for trying to set WebCore::Settings.

• UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::minimumWindowWidth):
(WebKit::WebInspectorProxy::initialWindowWidth):
Bumped the values to work better with the new UI.

• UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::windowFrameDidChange):
Added.

• UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter windowDidMove:]):
(-[WKWebInspectorProxyObjCAdapter windowDidResize:]):
Call WebInspectorProxy::windowFrameDidChange.

(WebKit::WebInspectorProxy::createInspectorWindow):
Use the preferences for the page group to get the window frame.

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Stop calling platformAttach or createInspectorWindow, do it in platformOpen.

(WebKit::WebInspectorProxy::platformOpen):
Call platformAttach or createInspectorWindow here instead.

(WebKit::WebInspectorProxy::windowFrameDidChange):
Added. Store the frame in the page group's preferences.

(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
Remove code that called setHidden:. We don't need to do that anymore.

4:18 PM Changeset in webkit [145960] by Lucas Forschler

• 2 edits in tags/Safari-537.34/Source/WebCore

Merged r145958. <rdar://problem/13434350>

4:14 PM Changeset in webkit [145959] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Convert <select> to new-flexbox
​https://bugs.webkit.org/show_bug.cgi?id=112395

Patch by Christian Biesinger <​cbiesinger@chromium.org> on 2013-03-15
Reviewed by Ojan Vafai.

Covered by existing tests.

• css/html.css:

(select):
(select[size][multiple]):
(select[size="1"]):
Use new-style flexbox properties.

• rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::createInnerBlock):
(WebCore::RenderMenuList::adjustInnerStyle):
(WebCore::RenderMenuList::removeChild):
RenderDeprecatedFlexibleBox -> RenderFlexibleBox, and use the
new-style flexbox properties. Use margin:auto for centering to get
the old safe-centering behavior.

• rendering/RenderMenuList.h:

(RenderMenuList):
Inherit from RenderFlexibleBox. Override baseline methods to call the
RenderBlock methods

4:11 PM Changeset in webkit [145958] by aestes@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTransferPlatformData()
​https://bugs.webkit.org/show_bug.cgi?id=112474

Reviewed by Simon Fraser.

Transfer ownership of m_cfData to the local variable rather than leaking a reference.

• platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::maybeTransferPlatformData):

4:01 PM Changeset in webkit [145957] by fsamuel@chromium.org

• 3 edits in trunk/Source/WebKit/chromium

[Chromium] Focus Plugin on TouchStart
​https://bugs.webkit.org/show_bug.cgi?id=112385

Reviewed by Adam Barth.

• src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleMouseEvent):

• src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

4:00 PM Changeset in webkit [145956] by Lucas Forschler

• 2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r136062. <rdar://problem/13334906>

3:54 PM Changeset in webkit [145955] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

New context extensions restored improperly
​https://bugs.webkit.org/show_bug.cgi?id=112156

Patch by Rajeev Sarvaria <​rsarvaria@blackberry.com> on 2013-03-15
Reviewed by Rob Buis.

Sets up extensions after new context is created for restoration.
Previous extensions set up is lost when context is initially lost.

Cannot create a test as change is not visible from the web. When a context
is lost, WebGLRenderingContext drops m_context. Upon restoration a new context
object is created without available extensions initialized. Calling isEnabled
within setupFlags leads to the eventual initialization of extensions for the
new context.

• html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

3:22 PM Changeset in webkit [145954] by commit-queue@webkit.org

• 7 edits
  2 adds in trunk

TextIterator emits LF for a br element inside an empty input element
​https://bugs.webkit.org/show_bug.cgi?id=112275

Patch by Aurimas Liutikas <​aurimas@chromium.org> on 2013-03-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

Adding a check to avoid emiting LF for br elements inside a shadow tree
of an input element.

Test: editing/text-iterator/basic-iteration.html

editing/text-iterator/basic-iteration-shadowdom.html

• editing/TextIterator.cpp:

(WebCore::shouldEmitNewlineForNode):
(WebCore::TextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::exitNode):

• editing/TextIterator.h:

(SimplifiedBackwardsTextIterator):

LayoutTests:

• editing/text-iterator/basic-iteration-expected.txt: Extended to add two more cases.
• editing/text-iterator/basic-iteration-shadowdom-expected.txt: Added.
• editing/text-iterator/basic-iteration-shadowdom.html: Added.
• editing/text-iterator/script-tests/basic-iteration.js: Extended to add two mroe cases.
• platform/mac/TestExpectations:

3:19 PM Changeset in webkit [145953] by anilsson@rim.com

• 8 edits
  1 add in trunk/Source

[BlackBerry] Allow an embedder to position child windows using window coordinates
​https://bugs.webkit.org/show_bug.cgi?id=112236

Reviewed by Rob Buis.

PR 232752

Source/WebCore:

The LayerCompositingThread can now position the video window using
either document or window coordinates.

The LayerRenderer class gets a new client interface. This allows us to
avoid state duplication by delegating decisions directly to the client,
which can then be in charge of the (one and only) state.

The context is moved over to the client, as well as delegation of the
decision on whether to clear the surface every frame.

Also, the decision on which coordinate system to use for positioning
child windows is delegated to the client interface.

No new tests, not testable using DRT.

• platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawTextures):

• platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::create):
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::toWebKitWindowCoordinates):
(WebCore::LayerRenderer::makeContextCurrent):

• platform/graphics/blackberry/LayerRenderer.h:

(WebCore):
(LayerRenderer):
(WebCore::LayerRenderer::client):

• platform/graphics/blackberry/LayerRendererClient.h: Added.

(Graphics):
(WebCore):
(LayerRendererClient):
(WebCore::LayerRendererClient::~LayerRendererClient):

Source/WebKit/blackberry:

Child windows used to always be positioned in document coordinates,
which requires the
BlackBerry::Platform::Graphics::Window::virtualRect() of the parent
window to be kept in sync with the document visible content rect.
This is easy if there's a one-to-one correspondence between windows
and scrollable frames.

However, for an embedder that can display an entire scene graph (where
the web page is just one of the nodes) in one window, several
scrollable nodes may be present in that window, and it's difficult to
know which scrollable node to sync the virtualRect with. It could also
lead to conflicts, if two scrollable nodes have child windows.

For the latter scenario, it makes more sense to use window coordinates
to place child windows.

The internal default is to use document coordinates, for legacy
reasons.

When an external WebPageCompositor is attached, we switch to using
window coordinates instead of document coordinates by default. The
behavior is still configurable using the new public
setChildWindowPlacement method.

• Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
(BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::shouldClearSurfaceBeforeCompositing):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::shouldChildWindowsUseDocumentCoordinates):
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::setChildWindowPlacement):

• Api/WebPageCompositor.h:
• Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::setChildWindowPlacement):
(WebPageCompositorPrivate):

3:13 PM Changeset in webkit [145952] by pdr@google.com

• 2 edits
  2 copies in branches/chromium/1410

Merge 145726 "Fix body background image geometry calculation"

Fix body background image geometry calculation
​https://bugs.webkit.org/show_bug.cgi?id=112226

Reviewed by Stephen Chenney.

Source/WebCore:

Images that depend on a container size require a call to set the container size before
rendering, and a call to look up the correct image during painting.

The body's renderer is special in that it may not be the renderer that actually paints its
background. This patch fixes a bug where the correct RenderObject was used for looking up
the image, but not for setting the container size. This fixes SVG background images on body.

Test: svg/as-background-image/svg-as-background-body.html

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

This change introduces clientForBackgroundImage in the background geometry calculation.
This is very similar to how the client is looked up in paintFillLayerExtended.

• rendering/RenderBoxModelObject.h:

The new signature for calculateBackgroundImageGeometry now mirrors
paintFillLayerExtended, containing a parameter for the correct background renderer.

(RenderBoxModelObject):

LayoutTests:

This test is required to have a repeating background, as we optimize non-repeating
backgrounds so the bug is not hit. A light green color is used so the text is still
readable, and gridlines are present to prove the correct container size is being used.

• svg/as-background-image/svg-as-background-body-expected.html: Added.
• svg/as-background-image/svg-as-background-body.html: Added.

TBR=​pdr@google.com
Review URL: ​https://codereview.chromium.org/12712011

3:12 PM Changeset in webkit [145951] by zandobersek@gmail.com

• 5 edits in trunk/Source/WebKit2

[GTK] Enforce the C++11 standard when compiling WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=112169

Reviewed by Gustavo Noronha Silva.

With a limited set of supported compilers the WebKit2 source code can now
be built with the C++11 language standard enforced.

• GNUmakefile.am:
• UIProcess/API/gtk/WebKitWebContext.cpp:

(injectedBundleDirectory): Adjust the string literals concatenation, moving away from empty strings
(which C++11 refuses to handle as concatenation operators) and using whitespace instead.

• UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath): Ditto.

• UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::inspectorFilesBasePath): Ditto.

3:11 PM Changeset in webkit [145950] by Lucas Forschler

• 3 edits in branches/safari-536.30-branch/Source/WebCore

Merged r132970. <rdar://problem/13335073>

3:09 PM Changeset in webkit [145949] by benjamin@webkit.org

• 2 edits in trunk/Source/WTF

[iOS] Update StringImpl's equal to have a single version on all supported Apple CPUs
​https://bugs.webkit.org/show_bug.cgi?id=112400

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-03-15
Reviewed by Michael Saboff.

• wtf/text/StringImpl.h:

(WTF::equal):
Tweak the code to make it work on older Apple CPUs:
-Use external "ouput" variable instead of the registers R9 and R12. This gets rid

of some register pressure previously imposed on the compiler. (Clang nicely
choose R9 and R12 when needed, following iOS ABI).

-Instead of using "R3" for storing the length / 4, update the length by -4 on

each iteration and work in the negative space for the tail. This frees one register
which is then used for isEqual.

-Get rid of the unconditional branch from the loop. By using subs and working in the

negative space, we can test for the Carry flag to jump back to the next LDR.

3:05 PM Changeset in webkit [145948] by Simon Fraser

• 2 edits in trunk/Tools

Have the mac port support per_test_timeout in webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=112466

Reviewed by Dirk Pranke.

Both WTR and DRT handle --timeout arguments, so we can
have the scripts pass the timeout values down to the tools.

• Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.supports_per_test_timeout):

2:57 PM Changeset in webkit [145947] by akling@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Don't also clone StructureRareData when cloning Structure.
<​http://webkit.org/b/111672>

Reviewed by Mark Hahnenberg.

We were cloning a lot of StructureRareData with only the previousID pointer set since
the enumerationCache is not shared between clones.

Let the Structure copy constructor decide whether it wants to clone the rare data.
The decision is made by StructureRareData::needsCloning() and will currently always
return false, since StructureRareData only holds on to caches at present.
This may change in the future as more members are added to StructureRareData.

• runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::cloneRareDataFrom):

• runtime/StructureInlines.h:

(JSC::Structure::create):

2:55 PM Changeset in webkit [145946] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Adding failure expectations for IDB tests that regressed with r145929.

2:52 PM Changeset in webkit [145945] by mhahnenberg@apple.com

• 24 edits
  9 deletes in trunk

Roll out r145838
​https://bugs.webkit.org/show_bug.cgi?id=112458

Unreviewed. Requested by Filip Pizlo.

Source/JavaScriptCore:

• CMakeLists.txt:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.list.am:
• dfg/DFGOperations.cpp:
• interpreter/CallFrame.h:

(JSC::ExecState::objectPrototypeTable):

• jit/JITStubs.cpp:

(JSC::getByVal):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):

• runtime/CommonIdentifiers.h:
• runtime/JSCell.cpp:

(JSC):

• runtime/JSCell.h:

(JSCell):

• runtime/JSCellInlines.h:

(JSC):
(JSC::JSCell::fastGetOwnProperty):

• runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

• runtime/JSGlobalData.h:

(JSGlobalData):

• runtime/JSObject.cpp:

(JSC):

• runtime/JSObject.h:

(JSObject):
(JSC):

• runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

• runtime/ObjectPrototype.cpp:

(JSC):
(JSC::ObjectPrototype::finishCreation):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):

• runtime/ObjectPrototype.h:

(JSC::ObjectPrototype::create):
(ObjectPrototype):

• runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::findWithString):

• runtime/Structure.h:

(Structure):

• runtime/StructureInlines.h:

(JSC::Structure::get):

LayoutTests:

• fast/js/regress/script-tests/string-lookup-hit-identifier.js: Removed.
• fast/js/regress/script-tests/string-lookup-hit.js: Removed.
• fast/js/regress/script-tests/string-lookup-miss.js: Removed.
• fast/js/regress/string-lookup-hit-expected.txt: Removed.
• fast/js/regress/string-lookup-hit-identifier-expected.txt: Removed.
• fast/js/regress/string-lookup-hit-identifier.html: Removed.
• fast/js/regress/string-lookup-hit.html: Removed.
• fast/js/regress/string-lookup-miss-expected.txt: Removed.
• fast/js/regress/string-lookup-miss.html: Removed.

2:52 PM Changeset in webkit [145944] by jochen@chromium.org

• 7 edits in trunk/Source

Expose whether a UserGestureToken still has gestures via WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=112342

Reviewed by Adam Barth.

Source/WebCore:

• dom/UserGestureIndicator.cpp:
• dom/UserGestureIndicator.h:

(UserGestureToken):

Source/WebKit/chromium:

• public/WebUserGestureToken.h:

(WebUserGestureToken):

• src/WebUserGestureToken.cpp:

(WebKit::WebUserGestureToken::hasGestures):
(WebKit):

• tests/WebUserGestureTokenTest.cpp:

(WebCore::TEST):

2:50 PM Changeset in webkit [145943] by commit-queue@webkit.org

• 12 edits in trunk/Source/WebCore

Convert inspector to new-flexbox
​https://bugs.webkit.org/show_bug.cgi?id=112399

Patch by Christian Biesinger <​cbiesinger@chromium.org> on 2013-03-15
Reviewed by Ojan Vafai.

No new tests, refactoring.

• inspector/front-end/auditsPanel.css:

(.audit-launcher-view .audit-launcher-view-content):
(.audit-launcher-view div.button-container):
(.audit-launcher-view div.button-container > button):

• inspector/front-end/dialog.css:

(.dialog):

• inspector/front-end/elementsPanel.css:

(.sidebar-pane.composite .metrics):

• inspector/front-end/helpScreen.css:

(.help-window-main):
(.help-content):

• inspector/front-end/inspector.css:

(#toolbar):
(#toolbar-controls):
(#toolbar-dropdown .scrollable-content):
(#toolbar-dropdown .toolbar-item):
(.toolbar-item.close-left, .toolbar-item.close-right):

• inspector/front-end/nativeMemoryProfiler.css:

(.memory-pie-chart-container):
(.memory-pie-chart):

• inspector/front-end/networkPanel.css:

(.network-item-view.visible):

• inspector/front-end/panelEnablerView.css:

(.panel-enabler-view .flexible-space):

• inspector/front-end/profilesPanel.css:

(.profile-launcher-view-content):
(.control-profiling):

• inspector/front-end/splitView.css:

(.sidebar-overlay):

• inspector/front-end/tabbedPane.css:

(.tabbed-pane):
(.tabbed-pane-content):
Replace -webkit-box with -webkit-flex, -webkit-box-orient with
-webkit-flex-direction, etc.

2:37 PM Changeset in webkit [145942] by Lucas Forschler

• 5 edits
  2 copies in branches/safari-536.30-branch

Merged r132724. <rdar://problem/13335007>

2:30 PM Changeset in webkit [145941] by Lucas Forschler

• 6 edits in branches/safari-536.30-branch

Merged r132511. <rdar://problem/13334997>

2:28 PM Changeset in webkit [145940] by commit-queue@webkit.org

• 30 edits in trunk

Source/WebCore: Remove unused unified textchecker variable
​https://bugs.webkit.org/show_bug.cgi?id=112362

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-03-15
Reviewed by Tony Chang.

The variable m_originalUnifiedSpellCheckerEnabled is never used. The generated
code from Settings.in already backs up and restores unified textchecker setting.

• testing/InternalSettings.h: Remove unusued m_originalUnifiedSpellCheckerEnabled variable.

Tools: Remove setAsynchronousSpellCheckingEnabled from test runners
​https://bugs.webkit.org/show_bug.cgi?id=112362

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-03-15
Reviewed by Tony Chang.

Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
in internals.settings, so all ports can share it.

• DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
• DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
• DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
• DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
• DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
• DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
• DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
• DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
• DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
• DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
• DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
• DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.

LayoutTests: Move setAsynchronousSpellCheckingEnabled to internals.settings
​https://bugs.webkit.org/show_bug.cgi?id=112362

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-03-15
Reviewed by Tony Chang.

Changed the tests from using testRunner.setAsynchronousSpellCheckingEnabled(bool)
with port-specific implementations to use internals.settings.setAsynchronousSpellCheckingEnabled(bool)
with one common implementation, similar to internals.settings.setUnifiedTextCheckerEnabled(bool).
Changed the tests to not reset these settings when they finish, because the test harness resets
the settings automatically.

• editing/spelling/grammar-markers-hidpi.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
• editing/spelling/grammar-markers.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
• editing/spelling/grammar-paste.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
• editing/spelling/resources/util.js: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
• editing/spelling/script-tests/spellcheck-paste.js: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
• editing/spelling/spellcheck-async-mutation.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
• editing/spelling/spellcheck-async-remove-frame.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
• editing/spelling/spellcheck-async.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
• editing/spelling/spellcheck-paste-disabled.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
• editing/spelling/spellcheck-queue.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
• editing/spelling/spellcheck-sequencenum.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
• editing/spelling/spelling-marker-description.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
• platform/chromium/editing/spelling/delete-misspelled-word.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
• platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).

2:26 PM Changeset in webkit [145939] by Lucas Forschler

• 2 edits in branches/safari-536.30-branch/Source/WebCore

Merge 132287. <rdar://problem/13335000>

2:16 PM Changeset in webkit [145938] by Lucas Forschler

• 3 edits
  3 adds in branches/safari-536.30-branch

Merge 131709. <rdar://problem/13334885>

2:13 PM Changeset in webkit [145937] by ojan@chromium.org

• 4 edits
  2 adds in trunk

Auto height column flexboxes with border and padding are too short
​https://bugs.webkit.org/show_bug.cgi?id=112398

Reviewed by Tony Chang.

Source/WebCore:

Test: css3/flexbox/auto-height-column-with-border-and-padding.html

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainAxisContentExtent):
computeLogicalHeight expects that you pass in the border-box logicalHeight, not
the contentLogicalHeight. Since we subtract the border, padding and scrollbar height from
the returned m_extent, if we pass in the contentLogicalHeight and the flexbox is auto-sized
then we end up incorrectly subtracting border, padding and scrollbar height from the
contentLogicalHeight.

LayoutTests:

• css3/flexbox/auto-height-column-with-border-and-padding-expected.html: Added.
• css3/flexbox/auto-height-column-with-border-and-padding.html: Added.
• css3/flexbox/resources/flexbox.css:

(.flex-one-one-auto):

2:06 PM Changeset in webkit [145936] by kov@webkit.org

• 41 edits in trunk/Source/WebCore/platform/gtk/po

Unreviewed, build fix. Also gather translatable strings from WebKit2 files.

• POTFILES.in: added WebKit2GTK+ files that have translatable strings.
• ar.po: regenerated.
• as.po: ditto.
• bg.po: ditto.
• cs.po: ditto.
• de.po: ditto.
• el.po: ditto.
• en_CA.po: ditto.
• en_GB.po: ditto.
• eo.po: ditto.
• es.po: ditto.
• et.po: ditto.
• eu.po: ditto.
• fr.po: ditto.
• gl.po: ditto.
• gu.po: ditto.
• he.po: ditto.
• hi.po: ditto.
• hu.po: ditto.
• id.po: ditto.
• it.po: ditto.
• ko.po: ditto.
• lt.po: ditto.
• lv.po: ditto.
• mr.po: ditto.
• nb.po: ditto.
• nl.po: ditto.
• pa.po: ditto.
• pl.po: ditto.
• pt.po: ditto.
• pt_BR.po: ditto.
• ro.po: ditto.
• ru.po: ditto.
• sl.po: ditto.
• sr.po: ditto.
• ​sr@latin.po: ditto.
• sv.po: ditto.
• uk.po: ditto.
• vi.po: ditto.
• zh_CN.po: ditto.

1:34 PM Changeset in webkit [145935] by benjamin@webkit.org

• 2 edits in trunk/Source/WTF

[iOS] Fix the length pass to memcmp in the fallback versions of String's equal
​https://bugs.webkit.org/show_bug.cgi?id=112463

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-03-15
Reviewed by Ryosuke Niwa.

• wtf/text/StringImpl.h:

(WTF::equal): It might be a good idea to compare the full UChar strings...

1:33 PM Changeset in webkit [145934] by timothy_horton@apple.com

• 7 edits in trunk/Source/WebCore

RenderSnapshottedPlugIn can't be a RenderBlock (what if it's display: inline?)
​https://bugs.webkit.org/show_bug.cgi?id=112432
<rdar://problem/13187211>

Reviewed by Simon Fraser and Dean Jackson.

Re-use code from PLUGIN_PROXY_FOR_VIDEO to allow RenderEmbeddedObject to lay out its children,
and make RenderSnapshottedPlugIn a RenderEmbeddedObject subclass once again. This will ensure that
RenderSnapshottedPlugIn lays itself out in the page the same as the RenderEmbeddedObject it replaces did,
preventing snapshotted plug-ins from breaking the layout when they are display: inline.

• html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):
RenderSnapshottedPlugIn is a RenderEmbeddedObject subclass again, so we need to check
for it when we have a RenderEmbeddedObject, instead of when we don't.

• page/FrameView.cpp:

(WebCore::FrameView::updateWidget):
Ditto.

• rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::layout):
(WebCore::RenderEmbeddedObject::canHaveChildren):
Allow RenderEmbeddedObject to have and lay out children if it is a RenderSnapshottedPlugIn.
Also, preserve the code that allows children if it is a media element and PLUGIN_PROXY_FOR_VIDEO is enabled.
Don't call addWidgetToUpdate for instances which will never have a widget, like RenderSnapshottedPlugIn.

• rendering/RenderEmbeddedObject.h:

(RenderEmbeddedObject):
We need canHaveChildren() and children() and m_children now.
Add canHaveWidget(), which returns true. Subclasses can override if need be.

• rendering/RenderSnapshottedPlugIn.h: Add canHaveWidget(), which is false for RenderSnapshottedPlugIn.
• rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::layout):
(WebCore::RenderSnapshottedPlugIn::getCursor):
Make RenderSnapshottedPlugIn a RenderEmbeddedObject.

(WebCore::RenderSnapshottedPlugIn::paint):
Paint our children.

1:24 PM Changeset in webkit [145933] by msaboff@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Cleanup of DFG and Baseline JIT debugging code
​https://bugs.webkit.org/show_bug.cgi?id=111871

Reviewed by Geoffrey Garen.

Fixed various debug related issue in baseline and DFG JITs. See below.

• dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkClosureCall): Used pointerDump() to handle when calleeCodeBlock is NULL.

• dfg/DFGScratchRegisterAllocator.h: Now use ScratchBuffer::activeLengthPtr() to get

pointer to scratch register length.
(JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkConsistency): Added missing case labels for DataFormatOSRMarker,
DataFormatDead, and DataFormatArguments and made them RELEASE_ASSERT_NOT_REACHED();

• jit/JITCall.cpp:

(JSC::JIT::privateCompileClosureCall): Used pointerDump() to handle when calleeCodeBlock is NULL.

• jit/JITCall32_64.cpp:

(JSC::JIT::privateCompileClosureCall): Used pointerDump() to handle when calleeCodeBlock is NULL.

• runtime/JSGlobalData.h:

(JSC::ScratchBuffer::ScratchBuffer): Fixed buffer allocation alignment to
be on a double boundary.
(JSC::ScratchBuffer::setActiveLength):
(JSC::ScratchBuffer::activeLength):
(JSC::ScratchBuffer::activeLengthPtr):

1:12 PM Changeset in webkit [145932] by morrita@google.com

• 34 edits
  2 adds in trunk

[Custom Elements] Any HTMLElement subclass should become a superclass of custom element
​https://bugs.webkit.org/show_bug.cgi?id=110436

Reviewed by Dimitri Glazkov.

Source/WebCore:

This change introduces "type extension" concept of custom elements.
With the type extension, each custom elements are able to inherit
from not only HTMLElement, but also any HTML element. To make it work,
this change extends the plumbing.

This change does following changes:

Data structure:

• Let CustomElementConstructor objects being keyed by pair of (element name, local name) as the standard requries, instead of just using single name. See CustomElementRegistry::ConstructorMap and CustomElementRegistry::find().

• Creates mapping from WrapperTypeInfo to element name. This map can be looked-up by generated functions like findHTMLTagNameOfV8Type(). With this table, WebKit can determine the custom element local name of given prototype object. See make_names.pl. Note that V8 prototype object knows associated WrapperTypeInfo. See r144865.

Hooking up element lifecyle:

• Create appropriate C++ instance for each custom element. Before this change, the C++ backend of custom elements were always HTMLUnknownElements or HTMLElement. See CustomElementConstructor::createElement() and ElementFactories in make_names.pl.

• Hooks up element construction and element wrapper creation for custom element "before" non-custom case instead of "after" that. We do this because custom element needs to override non-custom case when @is attribute is given for otherwise-non-custom elements like <div is=x-bar>. See make_names.pl.

• Gives @is attributes to elements if needed. See setTypeExtension() call sites like Document::createElement(), Document::createElementtNS() and CustomElementConstructor::createElementt()

Test: fast/dom/custom/document-register-type-extensions.html

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

• bindings/scripts/test/V8/V8Float64Array.h:
• bindings/scripts/test/V8/V8TestActiveDOMObject.h:
• bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
• bindings/scripts/test/V8/V8TestEventConstructor.h:
• bindings/scripts/test/V8/V8TestEventTarget.h:
• bindings/scripts/test/V8/V8TestException.h:
• bindings/scripts/test/V8/V8TestInterface.h:
• bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
• bindings/scripts/test/V8/V8TestNamedConstructor.h:
• bindings/scripts/test/V8/V8TestNode.h:
• bindings/scripts/test/V8/V8TestObj.h:
• bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
• bindings/scripts/test/V8/V8TestTypedefs.h:
• bindings/v8/CustomElementHelpers.cpp:

(WebCore::hasValidPrototypeChain):
(WebCore::CustomElementHelpers::isValidPrototypeParameter):
(WebCore::CustomElementHelpers::findLocalName):
(WebCore):
(WebCore::CustomElementHelpers::findWrapperType):

• bindings/v8/CustomElementHelpers.h:

(CustomElementHelpers):

• bindings/v8/V8CustomElement.cpp:

(WebCore::V8CustomElement::createWrapper):

• bindings/v8/V8CustomElement.h:

(V8CustomElement):
(WebCore::V8CustomElement::wrap):
(WebCore::V8CustomElement::constructorOf):

• bindings/v8/WrapperTypeInfo.h:

(WrapperTypeTraits): Added.

• bindings/v8/custom/V8CustomElementConstructorCustom.cpp:

(WebCore::V8CustomElementConstructor::callAsFunctionCallback):

• dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::create):
(WebCore::CustomElementConstructor::CustomElementConstructor):
(WebCore::CustomElementConstructor::createElement):
(WebCore::setTypeExtension):

• dom/CustomElementConstructor.h:

(CustomElementConstructor):
(WebCore::CustomElementConstructor::document):
(WebCore::CustomElementConstructor::typeName):
(WebCore::CustomElementConstructor::localName):

• dom/CustomElementRegistry.cpp:

(WebCore::nameIncludesHyphen):
(WebCore::CustomElementRegistry::isValidName):
(WebCore::CustomElementRegistry::registerElement):
(WebCore::CustomElementRegistry::findFor):
(WebCore::CustomElementRegistry::find):
(WebCore::CustomElementRegistry::createElement):

• dom/CustomElementRegistry.h:

(CustomElementRegistry):

• dom/Document.cpp:

(WebCore::Document::createElement):
(WebCore::Document::createElementNS):
(WebCore::Document::registerElement):

• dom/Document.h:

(Document):
(WebCore::Document::registry): Moved from Document.cpp to be inlined.

• dom/Document.idl:
• dom/make_names.pl:

(printFactoryCppFile):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

• html/HTMLAttributeNames.in: Added @is attribute

LayoutTests:

• fast/dom/custom/document-register-basic-expected.txt:
• fast/dom/custom/document-register-basic.html:
• fast/dom/custom/document-register-type-extensions-expected.txt: Added.
• fast/dom/custom/document-register-type-extensions.html: Added.

12:33 PM Changeset in webkit [145931] by msaboff@apple.com

• 7 edits in trunk/Source

Add runtime check for improper register allocations in DFG
​https://bugs.webkit.org/show_bug.cgi?id=112380

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added framework to check for register allocation within a branch source - target range. All register allocations
are saved using the offset in the code stream where the allocation occurred. Later when a jump is linked, the
currently saved register allocations are checked to make sure that they didn't occur in the range of code that was
jumped over. This protects against the case where an allocation could have spilled register contents to free up
a register and that spill only occurs on one path of a many through the code. A subsequent fill of the spilled
register may load garbage. See ​https://bugs.webkit.org/show_bug.cgi?id=111777 for one such bug.
This code is protected by the compile time check of #if ENABLE(DFG_REGISTER_ALLOCATION_VALIDATION).
The check is only done during the processing of SpeculativeJIT::compile(Node* node) and its callees.

• assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Jump::link): Invoke register allocation checks using source and target of link.
(JSC::AbstractMacroAssembler::Jump::linkTo): Invoke register allocation checks using source and target of link.
(AbstractMacroAssembler):
(RegisterAllocationOffset): New helper class to store the instruction stream offset and compare against a
jump range.
(JSC::AbstractMacroAssembler::RegisterAllocationOffset::RegisterAllocationOffset):
(JSC::AbstractMacroAssembler::RegisterAllocationOffset::check):
(JSC::AbstractMacroAssembler::addRegisterAllocationAtOffset):
(JSC::AbstractMacroAssembler::clearRegisterAllocationOffsets):
(JSC::AbstractMacroAssembler::checkRegisterAllocationAgainstBranchRange):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::allocate):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Source/WTF:

• wtf/Platform.h: Added new ENABLE_DFG_REGISTER_ALLOCATION_VALIDATION compilation flag to

enable generation of register allocation checking. This is on for debug builds.

12:03 PM Changeset in webkit [145930] by ap@apple.com

• 20 edits in trunk/Source/WebCore

Minor cleanup in worker code
​https://bugs.webkit.org/show_bug.cgi?id=112455

Reviewed by Anders Carlsson.

• Added OVERRIDE keywords.
• Toned down FIXMEs about single MessagePort versions of functions. It's not a given that we'll want to get rid of them even when implementing array versions.
• Explicitly marked virtual destructors as virtual.

• dom/MessageEvent.cpp:
• dom/MessageEvent.h:
• workers/Worker.cpp:
• workers/Worker.h: Removed an unused version of postMessage() that took no MessagePorts. This makes it less confusing why MessagePortArray is passed by pointer, and not by reference.

• workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext):
• workers/DedicatedWorkerContext.h: Added a destructor instead of an implicit one. Removed an unused version of postMessage() that took no MessagePorts.

• workers/SharedWorker.h: Removed an unused virtual function (thank you OVERRIDE!)

• dom/MessagePort.cpp:
• dom/MessagePort.h:
• loader/WorkerThreadableLoader.h:
• page/DOMWindow.h:
• workers/AbstractWorker.h:
• workers/DedicatedWorkerThread.h:
• workers/SharedWorkerContext.h:
• workers/SharedWorkerThread.h:
• workers/WorkerContext.h:
• workers/WorkerMessagingProxy.h:
• workers/WorkerObjectProxy.h:
• workers/WorkerScriptLoader.h:

11:58 AM Changeset in webkit [145929] by jsbell@chromium.org

• 27 edits
  2 copies
  1 add in trunk

[V8] Binding: Implement EnforceRange IDL Attribute for long long conversions
​https://bugs.webkit.org/show_bug.cgi?id=96798

Reviewed by Kentaro Hara.

Source/WebCore:

Implement [EnforceRange] attribute for V8 bindings, which specifies throwing behavior
on conversions outside int/uint 32/64 ranges and edge cases like NaNs and Infinities.
Conversely, conversions without this attribute should *not* throw.

Tests: fast/js/webidl-type-mapping.html:

fast/dom/non-numeric-values-numeric-parameters.html
fast/js/script-tests/select-options-add.html
storage/indexeddb/intversion-bad-parameters.html

• Modules/indexeddb/IDBCursor.cpp: Remove custom range enforcement for advance()
• Modules/indexeddb/IDBCursor.h: Adjust type to match WebIDL.
• Modules/indexeddb/IDBCursor.idl: Specify [EnforceRange] and type matches spec WebIDL.
• Modules/indexeddb/IDBFactory.cpp: Remove custom range enforcement for open()
• Modules/indexeddb/IDBFactory.h: Adjust type to match WebIDL.
• Modules/indexeddb/IDBFactory.idl: Specify [EnforceRange] and type matches spec WebIDL.
• bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative): Add FIXME to support [EnforceRange]

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter): Handle [EnforceRange] in attribute setters
(GenerateParametersCheck): Handle [EnforceRange] in parameters.
(JSValueToNative): Pass EnforceRange to toInt() functions as appropriate.

• bindings/scripts/IDLAttributes.txt:
• bindings/scripts/test/TestObj.idl: Tests w/ [EnforceRange]
• bindings/scripts/test/V8/V8TestObj.cpp: Updated expectations
• bindings/scripts/test/V8/V8TestTypedefs.cpp: Updated expectations.
• bindings/v8/V8Binding.cpp: Overloads for toInt() variants that handle constraints.

(WebCore::toInt32):
(WebCore::toUInt32):
(WebCore::toInt64):
(WebCore::toUInt64):

• bindings/v8/V8Binding.h: Ditto, plus helpers for callers not expecting errors.

(WebCore::toInt32):
(WebCore::toUInt32):
(WebCore::toInt64):
(WebCore::toUInt64):

• bindings/v8/V8BindingMacros.h: Helper macros for type conversions that may throw.
• testing/TypeConversions.h: Added new members with EnforceRange constraint.
• testing/TypeConversions.idl: Ditto.

LayoutTests:

Some of the tests for HTMLOptionsCollection.add() assumed it should throw for
Infinities and NaNs, but this is not what the DOM+WebIDL specs say. (Firefox doesn't throw
so this does not appear to be a web-compat issue.) This updates the tests/expectations so
that V8 passes. JSC expectations are FAIL in a few places since it still incorrectly throws
on Infinity/NaN -> int32 conversion (existing tests) and does not implement EnforceRange
(new tests).

Tne non-numeric-values-numeric-parameters test was also broken for NaN testing, reporting
incorrect results which hid some of this behavior.

• fast/dom/non-numeric-values-numeric-parameters-expected.txt: Failing behavior for JSC.
• fast/dom/script-tests/non-numeric-values-numeric-parameters.js: HTMLOptionsCollection.add()

should not throw on NaNs/Infinities.

• fast/js/script-tests/select-options-add.js: Ditto.
• fast/js/select-options-add-expected.txt: Failing behavior for JSC.
• fast/js/webidl-type-mapping-expected.txt: Ditto.
• fast/js/webidl-type-mapping.html: Added test cases for [EnforceRange]
• platform/chromium/fast/dom/non-numeric-values-numeric-parameters-expected.txt: Added - passing behavior for V8.
• platform/chromium/fast/js/select-options-add-expected.txt: Ditto.
• platform/chromium/fast/js/webidl-type-mapping-expected.txt: Added.
• storage/indexeddb/intversion-bad-parameters-expected.txt: Added non-finite test cases.
• storage/indexeddb/resources/intversion-bad-parameters.js: Ditto.

11:58 AM Changeset in webkit [145928] by Lucas Forschler

• 3 edits
  2 copies in branches/safari-536.30-branch

Merged r130999. <rdar://problem/13334880>

11:52 AM Changeset in webkit [145927] by Simon Fraser

• 2 edits in trunk/LayoutTests

Marking sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.8_Arguments_Object/S10.1.8_A3_T2.html
as a Slow test.

• platform/mac/TestExpectations:

11:47 AM Changeset in webkit [145926] by eustas@chromium.org

• 3 edits in trunk/Source/WebCore

Web Inspector: [Network] Refine JSDocs in NetworkRequest.js
​https://bugs.webkit.org/show_bug.cgi?id=112412

Reviewed by Vsevolod Vlasov.

Return types for some members are confusing (Object).

• inspector/front-end/NetworkManager.js: Fixed JSDocs.
• inspector/front-end/NetworkRequest.js: Ditto. Plus minor refactorings.

11:43 AM Changeset in webkit [145925] by Simon Fraser

• 2 edits in trunk/Tools

Fix the stupid unit tests.

• Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_sample_process):

11:26 AM Changeset in webkit [145924] by aestes@apple.com

• 4 edits
  2 adds in trunk

REGRESSION (r127277): CSS URIs with multi-byte Unicode escape sequences fail to parse
​https://bugs.webkit.org/show_bug.cgi?id=112436

Reviewed by Michael Saboff.

Source/WebCore:

r127277 modified the CSS parser to use 8-bit strings when possible.
However, it failed to handle URIs that contain Unicode escape sequences
that expand to multi-byte characters. Not only would the URI fail to
parse, but so would the remainder of the input string.

Fix this by producing a 16-bit result when we detect a URI with a
multi-byte Unicode escape, like we do for identifiers and other strings.

Test: fast/css/url-with-multi-byte-unicode-escape.html

• css/CSSParser.cpp:

(WebCore::checkAndSkipString): Changed to be a free function since it
doesn't access CSSParser's internal state.
(WebCore::CSSParser::findURI): Added a function that consolidates the
logic of finding the start and end pointers of the URI and the quote
character (if encountered), starting at the current character.
(WebCore::CSSParser::parseURIInternal): Removed duplicated logic for
finding the URI bounds (this now lives in findURI()) and logic for
setting the token type and updating the current character (this now
lives in parseURI()).
(WebCore::CSSParser::parseURI): Find the URI and parse it. If a
multi-byte Unicode escape is encountered, rewind to the beginning of
the URI and re-parse with a 16-bit string as the destination.

• css/CSSParser.h:

LayoutTests:

• fast/css/url-with-multi-byte-unicode-escape-expected.txt: Added.
• fast/css/url-with-multi-byte-unicode-escape.html: Added.

11:16 AM Changeset in webkit [145923] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r188418. Requested by
"Adam Barth" <​abarth@webkit.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-15

• DEPS:

11:10 AM Changeset in webkit [145922] by akling@apple.com

• 8 edits
  1 delete in trunk/Source/WebCore

[JSC] Remove custom WebAudio mark functions that we can generate instead.
<​http://webkit.org/b/110976>

Reviewed by Eric Carlson.

Remove custom JSC mark functions for AudioContext and ScriptProcessorNode since they
are trivial to generate.

• Modules/webaudio/AudioContext.idl:
• Modules/webaudio/ScriptProcessorNode.idl:
• GNUmakefile.list.am:
• UseJSC.cmake:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSAudioContextCustom.cpp:
• bindings/js/JSScriptProcessorNodeCustom.cpp: Removed.

11:08 AM Changeset in webkit [145921] by kareng@chromium.org

• 62 edits in branches/chromium/1441/Source

Revert 145802 "[V8] Store main world and non-main world template..."

[V8] Store main world and non-main world templates separately.
​https://bugs.webkit.org/show_bug.cgi?id=111724

Patch by Marja Hölttä <​marja@chromium.org> on 2013-03-14
Reviewed by Jochen Eisinger.

This is needed for generating specialized bindings for the main
world (bug 110874).

Source/WebCore:

No new tests (updated existing bindings tests).

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
(JSValueToNative):
(CreateCustomSignature):

• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

• bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

• bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

• bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

• bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

• bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

• bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

• bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

• bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

• bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

• bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

• bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

• bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

• bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

• bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

• bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

• bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

• bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

• bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

• bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

• bindings/v8/SerializedScriptValue.cpp:
• bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

• bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

• bindings/v8/V8Binding.h:

(WebCore):
(WebCore::toRefPtrNativeArray):

• bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

• bindings/v8/V8GCController.cpp:
• bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

• bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):

• bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::rawTemplateMap):
(V8PerIsolateData):
(WebCore::V8PerIsolateData::templateMap):

• bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

• bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

• bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

• bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

• bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toCanvasStyle):

• bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageMethodCustom):

• bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesMethodCustom):

• bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):

• bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCustom):

• bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateMethodCustom):

• bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

• bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addMethodCustom):

• bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::removeElement):

• bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):

• bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

• bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

• bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

• bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

• bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

• src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::createFromV8Value):

• src/WebArrayBufferView.cpp:

(WebKit::WebArrayBufferView::createFromV8Value):

• src/WebBindings.cpp:

(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

TBR=​commit-queue@webkit.org

11:05 AM Changeset in webkit [145920] by kareng@chromium.org

• 1 add in branches/chromium/1441/codereview.settings

for drovering

11:04 AM Changeset in webkit [145919] by kareng@chromium.org

• 1 copy in branches/chromium/1441

branching for 1441 to revert top crasher.

11:03 AM Changeset in webkit [145918] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix. Rename local variable which was colliding with class method.

• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::clone):

11:00 AM Changeset in webkit [145917] by jsbell@chromium.org

• 4 edits in trunk/Source

IndexedDB: Handle success events arriving after context stopped
​https://bugs.webkit.org/show_bug.cgi?id=112451

Reviewed by Tony Chang.

Source/WebCore:

In multiprocess ports, events from the back-end can arrive in the form of
onXXX() calls after the script execution context has stopped. These need to
be ignored. This was already done in most cases, but missing for two overloads
of IDBRequest::onSuccess() - void and int64_t.

Test: webkit_unit_test IDBRequestTest.EventsAfterStopping

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess): Early return if context has stopped.
(WebCore::IDBRequest::onSuccessInternal): ASSERT() that callers have checked context.

Source/WebKit/chromium:

• tests/IDBRequestTest.cpp:

(WebKit::TEST_F): Add cases for onSuccess() and onSuccess(int64_t)

10:59 AM Changeset in webkit [145916] by Simon Fraser

• 8 edits in trunk

Collect samples for unresponsive web processes
​https://bugs.webkit.org/show_bug.cgi?id=112409

Tools:

Reviewed by Tim Horton.

When we detect that a subprocess was unresponsive, run the 'sample'
tool on that process, for the Mac port.

The sample will be linked to from the results.html page, next
to the crash log link.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._look_for_new_crash_logs): Before looking for crash logs,
look for samples on disk.

• Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter):
(TestResultWriter.copy_sample_file): Teach TestResultWriter about
-sample.txt files, and have it copy their contents to a new file
next to the test that spawned them (as we do for crash logs).

• Scripts/webkitpy/layout_tests/port/base.py:

(Port.look_for_new_samples): Base class does nothing for sampling.

• Scripts/webkitpy/layout_tests/port/driver.py:

(Driver._check_for_driver_crash): Kick off a sample if we detected
that the subprocess was unresponsive.

• Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.sample_file_path): Utility to generate the file path
to the generated sample files at the top level of layout-test-results.
(MacPort.look_for_new_crash_logs): Fix typo
(MacPort.look_for_new_samples): New function to find sample files.
(MacPort.sample_process): Use the utility function to get the file path.

LayoutTests:

Reviewed by Tim Horton.

Add links for samples, which some platforms will show for unresponsive WebProcess timeouts.

• fast/harness/results.html:

10:58 AM Changeset in webkit [145915] by jer.noble@apple.com

• 6 edits
  3 adds in trunk

REGRESSION: -webkit-box-reflect does not show on video elements
​https://bugs.webkit.org/show_bug.cgi?id=112397

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/video/video-reflection.html

Support cloning specific CALayer subtypes in PlatformCALayer,
which allows reflections to work correctly for those layer types.
Specifically, add support for cloning AVPlayerLayer layers.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::cloneLayer): Moved most of the

implementation to PlatformCALayer::clone().

• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::PlatformCALayer): Set the layerType to

LayerTypeAVPlayerLayer if the PlatformLayer parameter is an
AVPlayerLayer.

(PlatformCALayer::clone): Moved from GraphicsLayerCA::cloneLayer().

Copy the player value to the new layer, if the current layer is
a LayerTypeAVPlayerLayer.

(PlatformCALayer::playerLayer):

• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::clone): Moved from GraphicsLayerCA::cloneLayer().

May want to add support for AVCFPlayerLayers in the future.

LayoutTests:

• compositing/video/video-reflection-expected.png: Added.
• compositing/video/video-reflection-expected.txt: Added.
• compositing/video/video-reflection.html: Added.

10:45 AM Changeset in webkit [145914] by Nate Chapin

• 46 edits in trunk/Source

Hide MainResourceLoader from the outside world
​https://bugs.webkit.org/show_bug.cgi?id=109971

Reviewed by Adam Barth.

Source/WebCore:

No new tests, refactor only.

• WebCore.exp.in:
• dom/Document.cpp:
• html/HTMLEmbedElement.cpp:
• html/MediaDocument.cpp:
• html/PluginDocument.cpp:
• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::mainResourceLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):

• loader/DocumentLoader.h:
• loader/EmptyClients.h:
• loader/FrameLoader.cpp:
• loader/FrameLoaderClient.h:
• loader/MainResourceLoader.cpp:
• loader/appcache/ApplicationCacheGroup.cpp:
• loader/appcache/ApplicationCacheHost.cpp:

Source/WebKit/blackberry:

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):

• WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

Source/WebKit/chromium:

• src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::convertMainResourceLoadToDownload):

• src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

Source/WebKit/efl:

• WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::convertMainResourceLoadToDownload):

• WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

Source/WebKit/gtk:

• WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::convertMainResourceLoadToDownload):

• WebCoreSupport/FrameLoaderClientGtk.h:

(FrameLoaderClient):

Source/WebKit/mac:

• WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::convertMainResourceLoadToDownload):

Source/WebKit/qt:

• WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::convertMainResourceLoadToDownload):

• WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

Source/WebKit/win:

• WebFrame.cpp:

(WebFrame::convertMainResourceLoadToDownload):

• WebFrame.h:

Source/WebKit/wince:

• WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::convertMainResourceLoadToDownload):

• WebCoreSupport/FrameLoaderClientWinCE.h:

(FrameLoaderClientWinCE):

Source/WebKit/wx:

• WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::convertMainResourceLoadToDownload):

• WebKitSupport/FrameLoaderClientWx.h:

(FrameLoaderClientWx):

Source/WebKit2:

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::convertMainResourceLoadToDownload):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::convertMainResourceLoadToDownload):

• WebProcess/WebPage/WebFrame.h:

(WebFrame):

10:31 AM Changeset in webkit [145913] by inferno@chromium.org

• 77 edits in trunk/Source

Replace static_casts with to* helper functions.
​https://bugs.webkit.org/show_bug.cgi?id=112401

Reviewed by Stephen Chenney.

to* helper functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

Source/WebCore:

• accessibility/AccessibilityObject.cpp:

(WebCore::appendAccessibilityObject):

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForPoint):

• accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::documentFrameView):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):

• accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

• bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginScriptObjectFromPluginViewBase):

• bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::setJavaScriptPaused):

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createScriptInstanceForWidget):

• bindings/js/ScriptControllerQt.cpp:

(WebCore::ScriptController::createScriptInstanceForWidget):

• bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::createScriptInstanceForWidget):

• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::appendFormData):

• page/EventHandler.cpp:

(WebCore::EventHandler::subframeForTargetNode):
(WebCore::EventHandler::passGestureEventToWidget):

• page/Frame.cpp:

(WebCore::Frame::frameForWidget):

• page/FrameView.cpp:

(WebCore::collectFrameViewChildren):
(WebCore::FrameView::hasCustomScrollbars):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):
(WebCore::FrameView::removeChild):

• page/FrameView.h:

(WebCore::toFrameView):
(WebCore):

• page/Page.cpp:

(WebCore::Page::collectPluginViews):

• page/chromium/EventHandlerChromium.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

• page/efl/EventHandlerEfl.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

• page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

• page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passWheelEventToWidget):

• page/qt/EventHandlerQt.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):

• page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

• page/wx/EventHandlerWx.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

• platform/ScrollView.h:

(WebCore::toScrollView):
(WebCore):

• platform/Scrollbar.cpp:

(WebCore::Scrollbar::isScrollViewScrollbar):
(WebCore::Scrollbar::mouseUp):
(WebCore::Scrollbar::axObjectCache):

• platform/Widget.h:

(WebCore::Widget::isScrollView):

• platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::toUserSpace):

• platform/efl/ScrollbarEfl.cpp:

(ScrollbarEfl::setParent):

• platform/qt/PlatformSupportQt.cpp:

(WebCore::PlatformSupport::popupsAllowed):
(WebCore::PlatformSupport::pluginScriptableObject):

• plugins/IFrameShimSupport.cpp:

(WebCore::getPluginOcclusions):

• plugins/PluginView.h:

(WebCore::toPluginView):
(WebCore):

• plugins/PluginViewBase.h:

(WebCore::PluginViewBase::isPluginViewBase):
(PluginViewBase):
(WebCore::toPluginViewBase):
(WebCore):

• plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::updateBuffer):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleScrollEvent):
(WebCore::PluginView::calculateClipRect):
(WebCore::PluginView::handleFullScreenAllowedEvent):
(WebCore::PluginView::handleFullScreenExitEvent):
(WebCore::PluginView::setParent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
(WebCore::PluginView::setBackgroundPlay):

• plugins/blackberry/PluginViewPrivateBlackBerry.cpp:

(WebCore::PluginViewPrivate::setVisibleRects):
(WebCore::PluginViewPrivate::showKeyboard):
(WebCore::PluginViewPrivate::requestFullScreen):
(WebCore::PluginViewPrivate::requestCenterFitZoom):
(WebCore::PluginViewPrivate::lockOrientation):
(WebCore::PluginViewPrivate::unlockOrientation):
(WebCore::PluginViewPrivate::preventIdle):

• plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::updatePluginWidget):

• plugins/mac/PluginViewMac.mm:

(WebCore::PluginView::platformStart):

• plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::updatePluginWidget):

• plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paintIntoTransformedContext):
(WebCore::PluginView::paintWindowedPluginIntoContext):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::snapshot):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::addLayoutOverflow):

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):

• rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing):
(WebCore::RenderEmbeddedObject::viewCleared):
(WebCore::RenderEmbeddedObject::nodeAtPoint):
(WebCore::RenderEmbeddedObject::scroll):

• rendering/RenderFlexibleBox.h:

(WebCore::toRenderFlexibleBox):
(WebCore):

• rendering/RenderFrame.cpp:

(WebCore::RenderFrame::viewCleared):

• rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::layoutWithFlattening):

• rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::contentRootRenderer):
(WebCore::RenderIFrame::layoutSeamlessly):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):

• rendering/RenderPart.cpp:

(WebCore::RenderPart::requiresAcceleratedCompositing):
(WebCore::RenderPart::embeddedContentBox):
(WebCore::RenderPart::nodeAtPoint):

• rendering/RenderRuby.cpp:

(WebCore::rubyBeforeBlock):
(WebCore::rubyAfterBlock):
(WebCore::lastRubyRun):
(WebCore::findRubyRunParent):

• rendering/RenderTreeAsText.cpp:

(WebCore::write):

• rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paintContents):
(WebCore::RenderWidget::setOverlapTestResult):
(WebCore::RenderWidget::updateWidgetPosition):

Source/WebKit/blackberry:

• Api/WebPage.cpp:

(BlackBerry::WebKit::frameForNode):
(BlackBerry::WebKit::needsLayoutRecursive):

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):

Source/WebKit/chromium:

• src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::scrollRect):
(WebKit::WebPluginContainerImpl::setWantsWheelEvents):
(WebKit::WebPluginContainerImpl::handleMouseEvent):

• tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::TEST_F):

Source/WebKit/efl:

• WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::redirectDataToPlugin):

Source/WebKit/gtk:

• WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::redirectDataToPlugin):

Source/WebKit/mac:

• WebView/WebRenderNode.mm:

(copyRenderNode):

• WebView/WebView.mm:

(-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):

Source/WebKit/qt:

• WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::redirectDataToPlugin):

Source/WebKit/win:

• WebCoreSupport/EmbeddedWidget.cpp:

(EmbeddedWidget::frameRectsChanged):

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::redirectDataToPlugin):

Source/WebKit/wince:

• WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::redirectDataToPlugin):

Source/WebKit/wx:

• WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::redirectDataToPlugin):

Source/WebKit2:

• Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::WebRenderObject):

10:11 AM Changeset in webkit [145912] by commit-queue@webkit.org

• 2 edits in trunk

[GTK] acceleration_backend_description does not concatenate "(gles2"
​https://bugs.webkit.org/show_bug.cgi?id=112405

Patch by Jae Hyun Park <​jae.park@company100.net> on 2013-03-15
Reviewed by Martin Robinson.

In FindDependencies.m4, acceleration_backend_description string does not
concatenate if there is a space between the operator and the operand.

• Source/autotools/FindDependencies.m4:

10:07 AM Changeset in webkit [145911] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Source/WebCore: [Texmap] REGRESSION (r144190): Failure at style with preserve-3d and opacity
​https://bugs.webkit.org/show_bug.cgi?id=112370

According to spec, we avoid masking and clipping when preserves-3d is enabled.
However, opacity should still work.
Allowing opacity when preserves-3d is on.

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-03-15
Reviewed by Caio Marcelo de Oliveira Filho.

Test: compositing/overlap-blending/preserves3d-opacity.html

• platform/graphics/texmap/TextureMapperGL.cpp:
• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintRecursive):

LayoutTests: [Texmap] REGRESSION (r144190): Failure at style with webkit-transform and opacity
​https://bugs.webkit.org/show_bug.cgi?id=112370

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-03-15
Reviewed by Caio Marcelo de Oliveira Filho.

New ref-test for opacity+preserves-3d.

• compositing/overlap-blending/preserves3d-opacity-expected.html: Added.
• compositing/overlap-blending/preserves3d-opacity.html: Added.

9:56 AM Changeset in webkit [145910] by Lucas Forschler

• 4 edits in tags/Safari-537.34/Source

Versioning

9:51 AM Changeset in webkit [145909] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Get rid of useless forward declaration.
​https://bugs.webkit.org/show_bug.cgi?id=112449

Patch by Konrad Piascik <​kpiascik@blackberry.com> on 2013-03-15
Reviewed by Stephen Chenney.

No behavioural change

• svg/SVGRectElement.cpp:

9:26 AM Changeset in webkit [145908] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: make CPU profiler show timings using the same time unit [ms]
​https://bugs.webkit.org/show_bug.cgi?id=112356

That makes it much easier to compare values when looking at the data.

Patch by Alexei Filippov <​alph@chromium.org> on 2013-03-15
Reviewed by Yury Semikhatsky.

• inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):

9:24 AM Changeset in webkit [145907] by peter@chromium.org

• 17 edits in trunk/Source/WebCore

Implement support for nullable types in the bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=111728

Reviewed by Kentaro Hara.

This patch adds support for nullable types in the bindings
generator, as described in section 3.10.22 of WebIDL:

​http://dev.w3.org/2006/webapi/WebIDL/#idl-nullable-type

interface MyInterface {

readonly attribute boolean? value; true, false or null.

};

The IDL Parser has been modified to record whether attributes are
nullable. Question marks from the type will always be stripped
from the domAttribute->signature->type field. Once support for
this has been completely implemented, we'll be able to remove a
bunch of custom bindings, i.e. those of Device Orientation.

Any getter for an attribute which returns a nullable type will be
called with an additional attribute (passed by reference) named
"isNull". This will be the last argument passed to the method,
unless an exception code (ec) argument will be passed as well.

The CPP, GObject and ObjC bindings will not change behavior following
this patch, although they have been modified to call the WebCore
methods for nullable attributes with the correct signature. The
V8 and JS binding generators do have modified behavior, in that they
will actually return v8Null/jsNull when isNull == true.

Tested by existing binding tests and the new nullable attribute
tests in the bindings/scripts/test/ directory.

• bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

• bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty):
(GenerateFunction):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):

• bindings/scripts/IDLParser.pm:

(typeHasNullableSuffix):
(typeRemoveNullableSuffix):
(parseAttributeRest):
(parseOptionalOrRequiredArgument):
(parseAttributeRestOld):

• bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::nullableDoubleAttribute):
(WebDOMTestObj::nullableLongAttribute):
(WebDOMTestObj::nullableBooleanAttribute):
(WebDOMTestObj::nullableStringAttribute):
(WebDOMTestObj::nullableLongSettableAttribute):
(WebDOMTestObj::setNullableLongSettableAttribute):
(WebDOMTestObj::nullableStringValue):
(WebDOMTestObj::setNullableStringValue):

• bindings/scripts/test/CPP/WebDOMTestObj.h:
• bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_get_nullable_double_attribute):
(webkit_dom_test_obj_get_nullable_long_attribute):
(webkit_dom_test_obj_get_nullable_boolean_attribute):
(webkit_dom_test_obj_get_nullable_string_attribute):
(webkit_dom_test_obj_get_nullable_long_settable_attribute):
(webkit_dom_test_obj_set_nullable_long_settable_attribute):
(webkit_dom_test_obj_get_nullable_string_value):
(webkit_dom_test_obj_set_nullable_string_value):

• bindings/scripts/test/GObject/WebKitDOMTestObj.h:
• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringValue):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableStringValue):

• bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestObj.h:
• bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj nullableDoubleAttribute]):
(-[DOMTestObj nullableLongAttribute]):
(-[DOMTestObj nullableBooleanAttribute]):
(-[DOMTestObj nullableStringAttribute]):
(-[DOMTestObj nullableLongSettableAttribute]):
(-[DOMTestObj setNullableLongSettableAttribute:]):
(-[DOMTestObj nullableStringValue]):
(-[DOMTestObj setNullableStringValue:]):

• bindings/scripts/test/TestObj.idl:
• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::nullableDoubleAttributeAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::nullableDoubleAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableLongAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableLongAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableBooleanAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableBooleanAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableStringAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableStringAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrSetter):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::nullableStringValueAttrGetter):
(WebCore::TestObjV8Internal::nullableStringValueAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableStringValueAttrSetter):
(WebCore::TestObjV8Internal::nullableStringValueAttrSetterCallback):
(WebCore):

8:37 AM Changeset in webkit [145906] by commit-queue@webkit.org

• 64 edits in trunk/Source

[V8] Store main world and non-main world templates separately.
​https://bugs.webkit.org/show_bug.cgi?id=111724

Patch by Marja Hölttä <​marja@chromium.org> on 2013-03-15
Reviewed by Jochen Eisinger.

This is needed for generating specialized bindings for the main
world (bug 110874).

Source/WebCore:

No new tests (updated existing bindings tests).

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
(JSValueToNative):
(CreateCustomSignature):

• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
(WebCore):
(WebCore::V8Float64Array::HasInstanceInAnyWorld):

• bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

• bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):
(WebCore):
(WebCore::V8TestActiveDOMObject::HasInstanceInAnyWorld):

• bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
(WebCore):
(WebCore::V8TestCustomNamedGetter::HasInstanceInAnyWorld):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

• bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
(WebCore):
(WebCore::V8TestEventConstructor::HasInstanceInAnyWorld):

• bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

• bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):
(WebCore):
(WebCore::V8TestEventTarget::HasInstanceInAnyWorld):

• bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

• bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
(WebCore):
(WebCore::V8TestException::HasInstanceInAnyWorld):

• bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):
(WebCore):
(WebCore::V8TestInterface::HasInstanceInAnyWorld):

• bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):
(WebCore):
(WebCore::V8TestMediaQueryListListener::HasInstanceInAnyWorld):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

• bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
(WebCore):
(WebCore::V8TestNamedConstructor::HasInstanceInAnyWorld):

• bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

• bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):
(WebCore):
(WebCore::V8TestNode::HasInstanceInAnyWorld):

• bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):
(WebCore):
(WebCore::V8TestObj::HasInstanceInAnyWorld):

• bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
(WebCore):
(WebCore::V8TestOverloadedConstructors::HasInstanceInAnyWorld):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
(WebCore):
(WebCore::V8TestSerializedScriptValueInterface::HasInstanceInAnyWorld):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

• bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
(WebCore):
(WebCore::V8TestTypedefs::HasInstanceInAnyWorld):

• bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

• bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

• bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

• bindings/v8/SerializedScriptValue.cpp:
• bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

• bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

• bindings/v8/V8Binding.h:

(WebCore):
(WebCore::toRefPtrNativeArray):

• bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

• bindings/v8/V8GCController.cpp:
• bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

• bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):

• bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::rawTemplateMap):
(V8PerIsolateData):
(WebCore::V8PerIsolateData::templateMap):

• bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

• bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

• bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

• bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

• bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toCanvasStyle):

• bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageMethodCustom):

• bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesMethodCustom):

• bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):

• bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCustom):

• bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateMethodCustom):

• bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

• bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addMethodCustom):

• bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::removeElement):

• bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):

• bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

• bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

• bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

• bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

• bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

• src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::createFromV8Value):

• src/WebArrayBufferView.cpp:

(WebKit::WebArrayBufferView::createFromV8Value):

• src/WebBindings.cpp:

(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

7:14 AM Changeset in webkit [145905] by commit-queue@webkit.org

• 64 edits in trunk/Source

Unreviewed, rolling out r145802.
​http://trac.webkit.org/changeset/145802
​https://bugs.webkit.org/show_bug.cgi?id=112444

This broke Chrome. (Requested by marja on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-15

Source/WebCore:

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
(JSValueToNative):
(CreateCustomSignature):

• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

• bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

• bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

• bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

• bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

• bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

• bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

• bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

• bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

• bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

• bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

• bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

• bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

• bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

• bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

• bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

• bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

• bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

• bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

• bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

• bindings/v8/SerializedScriptValue.cpp:
• bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

• bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

• bindings/v8/V8Binding.h:

(WebCore::toRefPtrNativeArray):
(WebCore):

• bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

• bindings/v8/V8GCController.cpp:
• bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

• bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):

• bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::rawTemplateMap):
(WebCore::V8PerIsolateData::templateMap):
(V8PerIsolateData):

• bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

• bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

• bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

• bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

• bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toCanvasStyle):

• bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageMethodCustom):

• bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesMethodCustom):

• bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):

• bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCustom):

• bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateMethodCustom):

• bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

• bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addMethodCustom):

• bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::removeElement):

• bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):

• bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

• bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

• bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

• bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

• bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

• src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::createFromV8Value):

• src/WebArrayBufferView.cpp:

(WebKit::WebArrayBufferView::createFromV8Value):

• src/WebBindings.cpp:

(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

7:05 AM Changeset in webkit [145904] by commit-queue@webkit.org

• 38 edits in trunk/Source/WebCore

Unreviewed, rolling out r145896.
​http://trac.webkit.org/changeset/145896
​https://bugs.webkit.org/show_bug.cgi?id=112443

Chrome broken by r145802 and this builds on top of it.
(Requested by marja on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-15

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateNamedConstructor):
(GenerateBatchedAttributeData):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(CreateCustomSignature):
(NativeToJSValue):

• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

• bindings/scripts/test/V8/V8Float64Array.h:

(WebCore):

• bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

• bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore):

• bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

• bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore):

• bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

• bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore):

• bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

• bindings/scripts/test/V8/V8TestException.h:

(WebCore):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(TestInterfaceV8Internal):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

• bindings/scripts/test/V8/V8TestInterface.h:

(WebCore):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore):

• bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

• bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore):

• bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

• bindings/scripts/test/V8/V8TestNode.h:

(WebCore):

• bindings/scripts/test/V8/V8TestObj.cpp:

(TestObjV8Internal):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

• bindings/scripts/test/V8/V8TestObj.h:

(WebCore):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(WebCore):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore):

• bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

• bindings/scripts/test/V8/V8TestTypedefs.h:

(WebCore):

• bindings/v8/DOMDataStore.h:

(DOMDataStore):

• bindings/v8/V8DOMConfiguration.cpp:
• bindings/v8/V8DOMConfiguration.h:

(V8DOMConfiguration):

• bindings/v8/custom/V8DOMWindowCustom.cpp:
• bindings/v8/custom/V8EventTargetCustom.cpp:
• bindings/v8/custom/V8IDBAnyCustom.cpp:
• bindings/v8/custom/V8MicroDataItemValueCustom.cpp:
• bindings/v8/custom/V8WorkerContextCustom.cpp:

6:52 AM Changeset in webkit [145903] by commit-queue@webkit.org

• 3 edits
  2 deletes in trunk/Source/WebCore

[BlackBerry] Remove PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=112438

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-03-15
Reviewed by Rob Buis.

This class only contains getFontFamilyForCharacters(), which was
moved from PlatformSupport to FontCache in r129257.

This patch does the same for the BlackBerry port.

• platform/graphics/FontCache.h:

(FontCache):

• platform/graphics/blackberry/FontCacheBlackBerry.cpp:

(WebCore::FontCache::getFontFamilyForCharacters):
(WebCore):
(WebCore::FontCache::getFontDataForCharacters):

• platform/graphics/blackberry/PlatformSupport.cpp: Removed.
• platform/graphics/blackberry/PlatformSupport.h: Removed.

6:50 AM Changeset in webkit [145902] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] FontPlatformData: remove TextOrientation parameter
​https://bugs.webkit.org/show_bug.cgi?id=112135

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-03-15
Reviewed by Rob Buis.

I forgot to remove the #include "TextOrientation.h" line as
well. This file no longer exists.

• platform/graphics/blackberry/FontCustomPlatformData.h:

6:35 AM Changeset in webkit [145901] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node
​https://bugs.webkit.org/show_bug.cgi?id=112404

Patch by Sankeerth V S <​sankeerth.vs@samsung.com> on 2013-03-15
Reviewed by Vsevolod Vlasov.

No new tests as this is a UI related change.

While deleting the entries of the data grid by clicking on 'Delete'
status bar button, deletion of selected node should trigger selection of
next possible (backward/forward) DataGridNode.

• inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):

• inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype.changeNodeAfterDeletion):

6:29 AM Changeset in webkit [145900] by loislo@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Draw timeline grid over flame chart items.
​https://bugs.webkit.org/show_bug.cgi?id=112439

Reviewed by Pavel Feldman.

I've used WebInspector.TimelineGrid

• inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.Calculator):
(WebInspector.FlameChart.Calculator.prototype._updateBoundaries):
(WebInspector.FlameChart.Calculator.prototype.computePosition):
(WebInspector.FlameChart.Calculator.prototype.formatTime):
(WebInspector.FlameChart.Calculator.prototype.maximumBoundary):
(WebInspector.FlameChart.Calculator.prototype.minimumBoundary):
(WebInspector.FlameChart.Calculator.prototype.boundarySpan):
(WebInspector.FlameChart.prototype.update):

5:48 AM Changeset in webkit [145899] by allan.jensen@digia.com

• 4 edits in trunk

[Qt] Build error with building with Qt 5.1
​https://bugs.webkit.org/show_bug.cgi?id=112435

Reviewed by Noam Rosenthal.

QAccessibleWidget has moved to private.

.:

• Source/widgetsapi.pri:

Source/WebKit/qt:

• WidgetApi/qwebviewaccessible_p.h:

5:32 AM Changeset in webkit [145898] by jknotten@chromium.org

• 5 edits in trunk/Source/WebKit/chromium

[Chromium] Compositor is applying scroll offset using 'programmatic' API
​https://bugs.webkit.org/show_bug.cgi?id=109712

Reviewed by James Robinson.

Ensure that the compositor uses non-programmatic APIs to scroll and
scale.

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::updateMainFrameScrollPosition):
(WebKit):
(WebKit::WebViewImpl::applyScrollAndScale):

• src/WebViewImpl.h:

(WebViewImpl):

• tests/WebFrameTest.cpp:
• tests/WebViewTest.cpp:

5:21 AM Changeset in webkit [145897] by caseq@chromium.org

• 3 edits in trunk/LayoutTests

Unreviewed -- remove test expectations for timeline-receive-response-event and remove
another source of flakiness in the test.

• inspector/timeline/timeline-receive-response-event.html:
• platform/chromium/TestExpectations:

4:45 AM WebKitGTK/2.0.x edited by Philippe Normand

(diff)

4:14 AM Changeset in webkit [145896] by commit-queue@webkit.org

• 38 edits in trunk/Source/WebCore

[V8] Add machinery for generating specialized bindings for the main world
​https://bugs.webkit.org/show_bug.cgi?id=111417

Patch by Marja Hölttä <​marja@chromium.org> on 2013-03-15
Reviewed by Kentaro Hara.

The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.

This patch generates main world bindings for getters and setters.

No new tests (updated existing bindings tests).

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateNamedConstructor):
(GenerateBatchedAttributeData):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(CreateCustomSignature):
(NativeToJSValue):

• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

• bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

• bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingAttrAttrGetterForMainWorld):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::excitingAttrAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

• bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

• bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::TestEventConstructorV8Internal::attr1AttrGetterForMainWorld):
(TestEventConstructorV8Internal):
(WebCore::TestEventConstructorV8Internal::attr1AttrGetterCallbackForMainWorld):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetterForMainWorld):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

• bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

• bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

• bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

• bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::TestExceptionV8Internal::nameAttrGetterForMainWorld):
(TestExceptionV8Internal):
(WebCore::TestExceptionV8Internal::nameAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

• bindings/scripts/test/V8/V8TestException.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetterForMainWorld):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

• bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

• bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

• bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

• bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

• bindings/scripts/test/V8/V8TestNode.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyLongAttrAttrGetterForMainWorld):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::readOnlyLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::staticReadOnlyLongAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::staticReadOnlyLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::createAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::createAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::createAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::createAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::customAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::customAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::contentDocumentAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::contentDocumentAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::descriptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::descriptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::idAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::idAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::idAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::idAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::hashAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::hashAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::replaceableAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::replaceableAttributeAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

• bindings/scripts/test/V8/V8TestObj.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetterForMainWorld):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

• bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrGetterForMainWorld):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

• bindings/scripts/test/V8/V8TestTypedefs.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

• bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::getWrapperForMainWorld):
(DOMDataStore):

• bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::addToTemplate):
(WebCore):

• bindings/v8/V8DOMConfiguration.h:

(V8DOMConfiguration):

• bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

• bindings/v8/custom/V8EventTargetCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

• bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

• bindings/v8/custom/V8MicroDataItemValueCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

• bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

4:07 AM Changeset in webkit [145895] by Simon Hausmann

• 2 edits in trunk/Source/WebKit/qt

[Qt] Unreviewed trivial DRT ASSERT fix

r145805 erroneously added setController calls for device orientation/motion
mock clients. Those ASSERT, the controller ctor already calls setController
on the client.

• WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::initializeWebCorePage):

3:46 AM Changeset in webkit [145894] by loislo@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. xOffset calculates incorrectly when chart width less that canvas.width.
​https://bugs.webkit.org/show_bug.cgi?id=112423

Reviewed by Yury Semikhatsky.

I extracted xOffset assigment procedure into a separate function.

Drive by fix: size and posion of anchor element was adjusted.
Drive by fix: we will not paint item if it is not visible.

• inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._maxXOffset):
(WebInspector.FlameChart.prototype._setXOffset):
(WebInspector.FlameChart.prototype._canvasDragging):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._adjustXOffset):
(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype.draw):

3:40 AM Changeset in webkit [145893] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Texmap] Change brightness filter to match new spec
​https://bugs.webkit.org/show_bug.cgi?id=112422

New filters spec specifies an intercept of 0 instead of 1.
This is already done for the software version in ​http://trac.webkit.org/changeset/139770.
This patch adjusts the value for the accelerated version.

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-03-15
Reviewed by Allan Sandfeld Jensen.

Filter tests are currently disabled on Qt/GTK/EFL, but they would need to be rebaselined once enabled.

• platform/graphics/texmap/TextureMapperShaderProgram.cpp:

3:22 AM Changeset in webkit [145892] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Call release() when a RefPtr is returned.
​https://bugs.webkit.org/show_bug.cgi?id=112420

Patch by Jaehun Lim <​ljaehun.lim@samsung.com> on 2013-03-15
Reviewed by Eric Seidel.

release() should be called on a RefPtr to convert it to a PassRefPtr.

No new tests needed, no behavior changes.

• css/CSSParser.cpp:

(WebCore::CSSParser::parseImageResolution):
(WebCore::CSSParser::parseImageSet):

3:18 AM Changeset in webkit [145891] by eustas@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: [Network] InitiatorComparator is not reflexive/antisymmetric.
​https://bugs.webkit.org/show_bug.cgi?id=112341

Reviewed by Vsevolod Vlasov.

When both objects do not have initiator: f(a, b) = f(b, a) = -1
Furthermore: redirected responses are mixed with "other".

• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
Remember "displayed" initiator type.
(WebInspector.NetworkDataGridNode.InitiatorComparator):
Recall "diaplayed" initiator type for more precise comparison.

3:17 AM Changeset in webkit [145890] by zeno.albisser@digia.com

• 4 edits in trunk/Tools

[Qt] Remove simple getters and setters from TestRunnerQt
​https://bugs.webkit.org/show_bug.cgi?id=112343

Reviewed by Benjamin Poulain.

The removed functions and boolean members
are being replaced by the implementations in the
generic TestRunner.h.

• DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(DumpRenderTree::dumpFrameScrollPosition):
(DumpRenderTree::dumpFramesAsText):
(DumpRenderTree::dump):
(DumpRenderTree::titleChanged):
(DumpRenderTree::dumpDatabaseQuota):
(DumpRenderTree::dumpApplicationCacheQuota):
(DumpRenderTree::statusBarMessage):
(DumpRenderTree::createWindow):

• DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::reset):

• DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

3:08 AM Changeset in webkit [145889] by caseq@chromium.org

• 7 edits in trunk/Source/WebCore

Web Inspector: show image decode performed off main thread on timeline
​https://bugs.webkit.org/show_bug.cgi?id=111159

Reviewed by Pavel Feldman.

• add handling of Decode Image event to TimelineTraceEventProcessorr;
• only log platform events for the main thread;
• extract constants for trace events produced by platform instrumentation.

• inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):

• inspector/InspectorTimelineAgent.h:

(TimelineRecordType):

• inspector/TimelineTraceEventProcessor.cpp:

(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::onImageDecodeBegin):
(WebCore):
(WebCore::TimelineTraceEventProcessor::onImageDecodeEnd):

• inspector/TimelineTraceEventProcessor.h:

(TimelineTraceEventProcessor):

• platform/PlatformInstrumentation.cpp:

(WebCore):

• platform/PlatformInstrumentation.h:

(PlatformInstrumentation):
(WebCore):
(WebCore::PlatformInstrumentation::willDecodeImage):
(WebCore::PlatformInstrumentation::didDecodeImage):
(WebCore::PlatformInstrumentation::willResizeImage):
(WebCore::PlatformInstrumentation::didResizeImage):

1:38 AM Changeset in webkit [145888] by loislo@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. When user zooms the chart, the point under cursor has to be the zooming center.
​https://bugs.webkit.org/show_bug.cgi?id=112417

Reviewed by Yury Semikhatsky.

It converts the cursor position into time,
changes the scale factor and calculates the new offset for the canvas.

• inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype._onMouseWheel):

1:33 AM Changeset in webkit [145887] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Adding a failure expectation for the reftest added in r145847

that is failing due to disabled subpixel layout on the GTK port.

1:28 AM Changeset in webkit [145886] by eustas@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: [Network] Sort columns context menu items alphabetically.
​https://bugs.webkit.org/show_bug.cgi?id=112321

Reviewed by Pavel Feldman.

Problem: columns are presented in "natural" order,
so it is hard to find specific item.

• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._getConfigurableColumnIDs):
Generate list of column IDs sorted alphabetically.
(WebInspector.NetworkLogView.prototype._contextMenu):
Use alphabetically sorted list of column IDs.

1:24 AM Changeset in webkit [145885] by tasak@google.com

• 4 edits
  2 adds in trunk

Crash at RenderStyle::inheritFrom reported by fuzzer
​https://bugs.webkit.org/show_bug.cgi?id=112322

Reviewed by Hajime Morrita.

Source/WebCore:

pseudoStyleForElement should check whether a parent style of a given
element is available or not. If a given element's parent is
an insertion point whose reset-style-inheritance is true, the parent
style is not available. Need to use defaultStyleForElement.

Test: fast/dom/shadow/insertion-point-resetStyleInheritance-with-pseudo-element-crash.html

• css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement):
Removed cloneForParent. Instead, made m_state own parentStyle, i.e.
changed m_parentStyle in class State from RenderStyle* to
RefPtr<RenderStyle>.
(WebCore::StyleResolver::pseudoStyleForElement):
If an actual parent style of a given element is not available, use
defaultStyleForElement. This is the same logic as styleForElement.

• css/StyleResolver.h:

(WebCore::StyleResolver::State::setParentStyle):
Modified the parameter to use PassRefPtr<RenderStyle>.
(WebCore::StyleResolver::State::parentStyle):
(State):

LayoutTests:

• fast/dom/shadow/insertion-point-resetStyleInheritance-with-pseudo-element-crash-expected.txt: Added.
• fast/dom/shadow/insertion-point-resetStyleInheritance-with-pseudo-element-crash.html: Added.

1:08 AM Changeset in webkit [145884] by mihnea@adobe.com

• 3 edits
  2 adds in trunk

[CSS Regions] Selecting text inside an empty region causes selection outside the region area
​https://bugs.webkit.org/show_bug.cgi?id=107752

Reviewed by David Hyatt.

Source/WebCore:

When performing hit testing inside a flow thread, we need to make sure that
we actually hit some node from the flow thread content and not the flow thread
itself (which would set the hit test result node to the document node, allowing
wrong selection of content outside the empty region).

Test: fast/regions/selecting-text-in-empty-region.html

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):

LayoutTests:

Add test showing that you cannot select content outside a empty region (without flow thread content).

• fast/regions/selecting-text-in-empty-region-expected.txt: Added.
• fast/regions/selecting-text-in-empty-region.html: Added.

1:06 AM Changeset in webkit [145883] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Texmap] layerRect should be used instead of contents rect for scrollable layer hit tests.
​https://bugs.webkit.org/show_bug.cgi?id=112413

Patch by Luiz Agostini <​luiz.agostini@nokia.com> on 2013-03-15
Reviewed by Noam Rosenthal.

Using layerRect() instead of m_state.contentsRect for scrollable layer hit test.

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::scrollableLayerHitTestCondition):

1:04 AM Changeset in webkit [145882] by rniwa@webkit.org

• 2 edits in trunk/Tools

Update the link on build.webkit.org to refer to perf.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=112416

Reviewed by Philip Rogers.

Updated the link. Also updated the template to use HTML5 DOCTYPE.

• BuildSlaveSupport/build.webkit.org-config/templates/root.html:

12:13 AM Changeset in webkit [145881] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
​https://bugs.webkit.org/show_bug.cgi?id=112394

Patch by Tobias Mueller <​tobiasmue@gnome.org> on 2013-03-15
Reviewed by Philippe Normand.

• GtkLauncher/main.c:

(main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER

12:13 AM Changeset in webkit [145880] by mikhail.pozdnyakov@intel.com

• 7 edits in trunk/Source/WebKit2

[WK2][EFL] Get rid of WebPageProxy::viewWidget() method
​https://bugs.webkit.org/show_bug.cgi?id=112289

Reviewed by Alexey Proskuryakov.

Web page should not be aware of platform-specific view.

• UIProcess/API/efl/EwkView.cpp:

(wkPageToEvasObjectMap):
(EwkView::EwkView):
(EwkView::~EwkView):
(EwkView::toEvasObject):

EwkView::toEvasObject() relies on static map rather than on
removed WebPageProxy::viewWidget() method.

• UIProcess/API/efl/EwkView.h:
• UIProcess/API/efl/ewk_text_checker.cpp:

(uniqueSpellDocumentTag):

• UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::incorporateUpdate):

Now uses EwkView::toEvasObject().

• UIProcess/WebPageProxy.h:

(WebPageProxy):

• UIProcess/efl/WebPageProxyEfl.cpp:

Removed WebPageProxy::viewWidget() method.

Mar 14, 2013:

11:28 PM Changeset in webkit [145879] by Lucas Forschler

• 4 edits in trunk/Source

Versioning.

11:26 PM Changeset in webkit [145878] by Lucas Forschler

• 1 copy in tags/Safari-537.34

New Tag.

11:22 PM Changeset in webkit [145877] by dominicc@chromium.org

• 2 edits in trunk/Source/WebCore

Redundant if statement in RenderTextControlSingleLine::layout should be removed
​https://bugs.webkit.org/show_bug.cgi?id=112406

Reviewed by Andreas Kling.

Covered by existing tests added in r145239.

• rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):

11:01 PM Changeset in webkit [145876] by commit-queue@webkit.org

• 3 edits
  2 deletes in trunk

Unreviewed, rolling out r145864.
​http://trac.webkit.org/changeset/145864
​https://bugs.webkit.org/show_bug.cgi?id=112408

should fix XMLDocumentParser instead of CSSDefaultStyleSheet
(Requested by tasak on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-14

Source/WebCore:

• css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

LayoutTests:

• fast/css/ensure-default-style-sheets-crash-expected.txt: Removed.
• fast/css/ensure-default-style-sheets-crash.xhtml: Removed.

10:29 PM Changeset in webkit [145875] by eustas@chromium.org

• 16 edits in trunk/Source/WebCore

Web Inspector: [DataGrid] Specify columns with array of descriptors.
​https://bugs.webkit.org/show_bug.cgi?id=112338

Reviewed by Pavel Feldman.

Currently columns are specified by Object that maps
column identifiers to column descriptors. Iteration order over
Object keys is not guaranteed.

Array should be used to specify column order.

• inspector/front-end/DataGrid.js: Change consrtructor parameter type.
• inspector/front-end/ApplicationCacheItemsView.js: Adopt changes.
• inspector/front-end/CPUProfileView.js: Ditto.
• inspector/front-end/CSSSelectorProfileView.js: Ditto.
• inspector/front-end/CanvasProfileView.js: Ditto.
• inspector/front-end/CookieItemsView.js: Ditto.
• inspector/front-end/CookiesTable.js: Ditto.
• inspector/front-end/DOMStorageItemsView.js: Ditto.
• inspector/front-end/DirectoryContentView.js: Ditto.
• inspector/front-end/HeapSnapshot.js: Ditto.
• inspector/front-end/HeapSnapshotDataGrids.js: Ditto.
• inspector/front-end/IndexedDBViews.js: Ditto.
• inspector/front-end/NativeMemorySnapshotView.js: Ditto.
• inspector/front-end/NetworkPanel.js: Ditto.
• inspector/front-end/ResourceWebSocketFrameView.js: Ditto.

10:26 PM Changeset in webkit [145874] by loislo@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Support scrolling by dragging.
​https://bugs.webkit.org/show_bug.cgi?id=112346

Reviewed by Yury Semikhatsky.

Drag hander was added. It seems that simple repaint works well.
When the user starts dragging we hide the popover, change offset
and do update for the new canvas image.
Drive by change: Due to new way of scrolling the canvas I changed
the behaiviour of the wheel events. Now wheel scrolls if Shift key pressed
and zooms if not.

• inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._startCanvasDragging):
(WebInspector.FlameChart.prototype._canvasDragging):
(WebInspector.FlameChart.prototype._endCanvasDragging):
(WebInspector.FlameChart.prototype._onMouseWheel):

10:14 PM Changeset in webkit [145873] by hayato@chromium.org

• 12 edits in trunk

[Shadow Dom]: Non Bubbling events in ShadowDOM dispatch in an incorrect order
​https://bugs.webkit.org/show_bug.cgi?id=112214

Reviewed by Dimitri Glazkov.

Source/WebCore:

Fix the order of event dispatching for Shadow DOM.

So far, an event whose event phase should be set to AT_TARGET,
e.g. event at shadow hosts, is dispatched in bubbling phase in the
whole event path. This patch fixed the order of event dispatching
so that an event whose event phase must be set to AT_TARGET phase
is dispatched in capturing phase rather than bubbling phase.

The spec is here:
​https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#event-dispatch

5.5 Event Dispatch says:

• When capturing, which entails processing step 3 of the event

dispatch algorithm, the Event eventPhase attribute must return
AT_TARGET if the relative target is same as the node on which
event listeners are invoked

• When bubbling, which entails

processing step 6 of the event dispatch algorithm, the event
listeners must not be invoked on a node if it is the same as its
relative target

No new tests. Update existing layout tests.

• dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtBubbling):

LayoutTests:

• fast/dom/shadow/cppevent-in-shadow-expected.txt:
• fast/dom/shadow/cppevent-input-in-shadow-expected.txt:
• fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:
• fast/dom/shadow/shadow-boundary-events-expected.txt:
• fast/dom/shadow/shadow-boundary-events.html:
• fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt:
• fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt:
• fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt:
• fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt:

9:47 PM Changeset in webkit [145872] by pfeldman@chromium.org

• 2 edits in trunk/LayoutTests

Not reviewed: Chromium TestExpectations cleanup prepared by kbr@

• platform/chromium/TestExpectations:

9:25 PM Changeset in webkit [145871] by commit-queue@webkit.org

• 3 edits
  4 adds in trunk

Backspace/delete at start of table cell shouldn't step out of cell
​https://bugs.webkit.org/show_bug.cgi?id=35372

Patch by Shezan Baig <Shezan Baig> on 2013-03-14
Reviewed by Ryosuke Niwa.

Source/WebCore:

Make Delete and ForwardDelete commands be no-ops if we are at the first
position or last position of a table cell respectively.

Tests: editing/deleting/backspace-at-table-cell-beginning.html

editing/deleting/forward-delete-at-table-cell-ending.html

• editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):

LayoutTests:

• editing/deleting/backspace-at-table-cell-beginning-expected.txt: Added.
• editing/deleting/backspace-at-table-cell-beginning.html: Added.
• editing/deleting/forward-delete-at-table-cell-ending-expected.txt: Added.
• editing/deleting/forward-delete-at-table-cell-ending.html: Added.

8:37 PM Changeset in webkit [145870] by commit-queue@webkit.org

• 9 edits
  2 adds in trunk

Clickable area is incorrect for elements with border-radius
​https://bugs.webkit.org/show_bug.cgi?id=95373

Patch by Xidorn Quan <​quanxunzhen@gmail.com> on 2013-03-14
Reviewed by Simon Fraser.

Source/WebCore:

As RenderBlock doesn't see rounded rect which comes from border-radius
in nodeAtPoint, the rounded corner seems to have an 'invisible' square
box which catches hits. So we added check on whether hitTestPoint also
intersects the rounded rect when hasBorderRadius is set.

This patch is based on Takashi Sakamoto's work in
​https://bugs.webkit.org/show_bug.cgi?id=95373

Test: fast/borders/border-radius-position.html

• platform/graphics/FloatQuad.cpp:

(WebCore):
(WebCore::lineIntersectsCircle):
(WebCore::FloatQuad::intersectsCircle):
(WebCore::FloatQuad::intersectsEllipse):

• platform/graphics/FloatQuad.h:

(FloatQuad):

• platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::intersectsQuad):
(WebCore):

• platform/graphics/RoundedRect.h:

(RoundedRect):

• rendering/HitTestLocation.cpp:

(WebCore::HitTestLocation::intersects):
(WebCore):

• rendering/HitTestLocation.h:

(HitTestLocation):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

LayoutTests:

This test is based on Takashi Sakamoto's work in
​https://bugs.webkit.org/show_bug.cgi?id=95373

• fast/borders/border-radius-position-expected.txt: Added.
• fast/borders/border-radius-position.html: Added.

8:30 PM Changeset in webkit [145869] by akling@apple.com

• 12 edits in trunk

REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
<​http://webkit.org/b/111815>
<rdar://problem/13380145>

Reviewed by Anders Carlsson.

Source/WebKit2:

Call getWindowFrame() to see if the UI client wants to override the window frame before sending
a WindowAndViewFramesChanged message to the web process.
This fixes a glitch in WTR and the Web Inspector where incorrect window frames were being used.

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::windowAndViewFramesChanged):

Tools:

Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.

• WebKitTestRunner/PlatformWebView.h:

(PlatformWebView):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):

• WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::didInitializeClients):

LayoutTests:

• platform/mac-wk2/TestExpectations:

7:41 PM Changeset in webkit [145868] by commit-queue@webkit.org

• 8 edits in trunk/LayoutTests

plugins/plugin-clip-subframe.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=112324

Patch by John Bauman <​jbauman@chromium.org> on 2013-03-14
Reviewed by Ryosuke Niwa.

Ignore duplicate SetWindow calls with identical arguments. Plugins
will ignore these so they're not a problem, and they can cause
flakiness on mac-wk2.

• platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt:
• platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt:
• platform/chromium-win/plugins/plugin-clip-subframe-expected.txt:
• platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt:
• platform/mac/plugins/plugin-clip-subframe-expected.txt:
• plugins/plugin-clip-subframe-expected.txt:
• plugins/resources/plugin-clip-subframe-iframe.html:

7:18 PM Changeset in webkit [145867] by dominicc@chromium.org

• 1 edit
  6 copies in branches/chromium/1410

[Chromium] Unreviewed, merge r145239.

7:08 PM Changeset in webkit [145866] by Chris Fleizach

• 3 edits
  2 adds in trunk

AX: Crash when removing aria-menu item from DOM
​https://bugs.webkit.org/show_bug.cgi?id=112396

Reviewed by Tim Horton.

Source/WebCore:

Prevent nil access to items in the ARIA menu flow when deleting
objects from the DOM.

Test: accessibility/menu-item-crash.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::siblingWithAriaRole):
(WebCore::AccessibilityNodeObject::menuButtonForMenu):

LayoutTests:

• accessibility/menu-item-crash-expected.txt: Added.
• accessibility/menu-item-crash.html: Added.

7:02 PM Changeset in webkit [145865] by hayato@chromium.org

• 6 edits
  2 adds in trunk

[Shadow]: left side of ::-webkit-distributed selector not working as expected
​https://bugs.webkit.org/show_bug.cgi?id=110825

Reviewed by Dimitri Glazkov.

Source/WebCore:

Make functional pseudo distributed elements work even when a left side element has specifiers.

Test: fast/dom/shadow/distributed-pseudo-element-specifiers-in-left-side.html

• css/CSSParser.cpp:

(WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded):
Make it call rewriteSpecifiersForShadowDistributed() if required.

(WebCore::CSSParser::rewriteSpecifiersWithElementName):
Updated so that it can generate a correct chain of
CSSParserSelectors even when '::distributed()' is used with an
element, which might be empty, with specifiers.

e.g. When parsing a selector of 'content.content-class::-webkit-distributed(div)', the following happens:

1. rewriteSpecifiersWithElementName(...) is called with:

elementName is: "content"
specifiers is: [.content-class] -> [::-webkit-distributed]

2. Looking for a distributed pseudo element in the specifiers and found it at the end of tagHistory chain of the specifiers.

3. The result of calling specifiers->prependTagSelector(tag) is:

specifiers is: [content] -> [.content-class] -> [::-webkit-distributed]

4. rewriteSpecifiersForShadowDistributed() is called with:

specifiers is: [content] -> [.content-class] -> [::-webkit-distributed]
distributedPseudoElementSelector is: [::-webkit-distributed]

5. An argumentSelector of the distributedPseudoElementSelector is:

argumentSelector is: [div]

6. Remove the distributed pseudo element selector from the specifiers.

specifiers is: [content] -> [.content-class]

Note that one pseudo-element may appear per complex selector
and the pseudo-element may appear only if the subject of the
selector is the last compound selector in the selector.

7. Append specifiers to the end of the argument selector with a relation of ShadowDistributed:

argumentSelector is: [div] -(ShadowDistributed)-> [content] -> [.content-class]

8. Returns the argument selector as a return value.

(WebCore::CSSParser::rewriteSpecifiersForShadowDistributed): As explained.

• css/CSSParserValues.cpp:

(WebCore):
(WebCore::CSSParserSelector::findDistributedPseudoElementSelector):

• css/CSSParserValues.h:

(CSSParserSelector):
(WebCore::CSSParserSelector::clearTagHistory):

LayoutTests:

• fast/dom/shadow/distributed-pseudo-element-specifiers-in-left-side-expected.html: Added.
• fast/dom/shadow/distributed-pseudo-element-specifiers-in-left-side.html: Added.

6:50 PM Changeset in webkit [145864] by tasak@google.com

• 3 edits
  2 adds in trunk

Crash at CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement reported by fuzzer
​https://bugs.webkit.org/show_bug.cgi?id=112328

Reviewed by Dimitri Glazkov.

Source/WebCore:

ensureDefaultStyleSheets should check whether page() is null or not.

Test: fast/css/ensure-default-style-sheets-crash.xhtml

• css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

LayoutTests:

• fast/css/ensure-default-style-sheets-crash-expected.txt: Added.
• fast/css/ensure-default-style-sheets-crash.xhtml: Added.

5:52 PM Changeset in webkit [145863] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[EFL][MiniBrowser] Add a search field to the MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=112122

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2013-03-14
Reviewed by Kenneth Rohde Christiansen.

Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.

• MiniBrowser/efl/main.c:

(_Browser_Window):
(search_box_show):
(search_box_hide):
(on_key_down):
(on_url_changed):
(on_search_field_aborted):
(on_search_field_activated):
(on_search_field_clicked):
(on_search_backward_button_clicked):
(on_search_forward_button_clicked):
(window_create):

5:51 PM Changeset in webkit [145862] by kbr@google.com

• 2 edits in trunk/LayoutTests

Unreviewed test expectations update. Expanded suppression.

• platform/chromium/TestExpectations:

5:48 PM Changeset in webkit [145861] by jparent@chromium.org

• 8 edits in trunk/Tools

Cleanup: Remove g_resourceLoader.
​https://bugs.webkit.org/show_bug.cgi?id=112305

Reviewed by Dirk Pranke.

Removing another global.

Now, each dashboard creates its own loader, rather than having
a general global one.

Remove usage of g_resourceLoader.isLoadingComplete from
handleLocationChange by ensuring that handleLocationChange is
never called before the loader is done. It was called in two
places before: 1 was from the callback when the loader is done,
so that was obviously true, and the other was from onhashchange,
where it would just return rather than running. Instead, lets
only register the onhashchange handler once the loader is
setup, so the check is no longer necessary.

Remove isLoadingComplete since it is now unused.

Callback for loader is now initializeHistory, rather than just
handleLocationChange which will set up the hashchange handler now.
This will all eventually be moving to a new History object.

• TestResultServer/static-dashboards/aggregate_results.html:
• TestResultServer/static-dashboards/dashboard_base.js:

(handleLocationChange):
(intializeHistory):
(decompressResults):

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(generatePage):

• TestResultServer/static-dashboards/loader.js:

(.):

• TestResultServer/static-dashboards/loader_unittests.js:
• TestResultServer/static-dashboards/timeline_explorer.html:
• TestResultServer/static-dashboards/treemap.html:

5:45 PM Changeset in webkit [145860] by oliver@apple.com

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r145000): Crash loading arstechnica.com when Safari Web Inspector is open
​https://bugs.webkit.org/show_bug.cgi?id=111868

Reviewed by Antti Koivisto.

Don't allow non-local property lookup when the debugger is enabled.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve):

5:10 PM Changeset in webkit [145859] by commit-queue@webkit.org

• 4 edits in trunk

Build: Remove XSLT option and depend hard on XSLT.
You will now not be able to give --disable-xslt or --enable-xslt
because it is not optional anymore.
​https://bugs.webkit.org/show_bug.cgi?id=112368

Patch by Tobias Mueller <​tobiasmue@gnome.org> on 2013-03-14
Reviewed by Martin Robinson.

• Source/autotools/FindDependencies.m4:

Always check for libxslt

• Source/autotools/PrintBuildConfiguration.m4:

Removed printing out the value of XSLT

• Source/autotools/ReadCommandLineArguments.m4:

Removed reading XSLT options

5:07 PM Changeset in webkit [145858] by kbr@google.com

• 1 edit
  8 adds in trunk/LayoutTests

Unreviewed gardening. Added images for new test.

• platform/chromium-mac-lion/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.
• platform/chromium-mac-snowleopard/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.
• platform/chromium-mac/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.
• platform/chromium-win/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.

5:02 PM Changeset in webkit [145857] by jamesr@google.com

• 20 edits in trunk/LayoutTests

Fix flaky layout tests that rely on setTimeout()s firing after <body> is parsed
​https://bugs.webkit.org/show_bug.cgi?id=112306

Reviewed by Eric Seidel.

These tests all rely in one way or another on the body of a setTimeout set in an inline <script> in the <head>
firing after the <body> element is generated by the HTML parser. This is a flaky pattern since the HTML parser
may yield when parsing a </script> or when runnnig out of bytes from the network. In practice, this pattern used
to be not terribly flaky for layout tests loaded from disk unless there was a large GC pause. However, since the
threaded HTML parser yields more frequently when hitting a </script> this flakes more.

These tests were found by identifying layout tests that call setTimeout before the document's body exists by
modifying the code, then intersecting that set with tests that are flaky on the chromium flakiness dashboard.

• editing/inserting/insert-text-into-empty-frameset-crash.html:
• editing/style/apply-style-crash.html:
• fast/block/float/float-originating-line-deleted-crash.html:
• fast/block/float/floats-not-cleared-crash.html:
• fast/block/line-layout/inline-box-wrapper-crash.html:
• fast/css/positioned-in-relative-position-inline-crash.html:
• fast/css/user-stylesheet-crash.html:
• fast/encoding/script-in-head.html:
• fast/forms/textarea-placeholder-relayout-assertion.html:
• fast/frames/seamless/seamless-form-get.html:
• fast/frames/seamless/seamless-form-post-named.html:
• fast/frames/seamless/seamless-window-location-href.html:
• fast/frames/seamless/seamless-window-location-replace.html:
• fast/inline/update-always-create-line-boxes-full-layout-crash.html:
• fast/innerHTML/innerHTML-iframe.html:
• fast/js/same-origin-subframe-about-blank.html:
• fast/multicol/span/removal-of-multicol-span-crash.html:
• fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html:
• fast/writing-mode/overhanging-float-legend-crash.html:

4:40 PM May 2013 Meeting edited by benjamin@webkit.org

(diff)

4:33 PM Changeset in webkit [145856] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Check to ensure MultisampleRenderbuffer creation succeeds
​https://bugs.webkit.org/show_bug.cgi?id=111780

Patch by Brandon Jones <​bajones@google.com> on 2013-03-14
Reviewed by Kenneth Russell.

On OSX systems using AMD graphics chips the allocation of large
Multisample Renderbuffers in Chromium would fail without any indication
of failure. Attempting to draw to the buffer resulted in garbage being
rendered onscreen. This could be reproduced by opening a full-page
WebGL app and pressing (Command + "-") several times. This patch adds an
additional check during DrawingBuffer resize to verify that the resized
buffer is valid.

• platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):
(WebCore::DrawingBuffer::checkBufferIntegrity):
(WebCore::DrawingBuffer::reset):

• platform/graphics/gpu/DrawingBuffer.h:

(DrawingBuffer):

4:29 PM Changeset in webkit [145855] by danakj@chromium.org

• 4 edits in trunk/Source

[chromium] Make zoom filter independent of the layer size.
​https://bugs.webkit.org/show_bug.cgi?id=112221

Reviewed by Stephen White.

Source/Platform:

Make the zoom filter hold a zoom amount and an inset.

• chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::zoomInset):
(WebFilterOperation):
(WebKit::WebFilterOperation::createZoomFilter):
(WebKit::WebFilterOperation::setZoomInset):
(WebKit::WebFilterOperation::WebFilterOperation):

Source/WebKit/chromium:

• tests/FilterOperationsTest.cpp:

(WebKit):
(WebKit::TEST):

4:22 PM May 2013 Meeting edited by rniwa@webkit.org

Add "improving wiki pages" as a hackathon (diff)

3:43 PM Changeset in webkit [145854] by enrica@apple.com

• 6 edits
  1 add in trunk

Character orientation should follow UTR50 specs for vertical layout.
​https://bugs.webkit.org/show_bug.cgi?id=112213
<rdar://problem/12880943>

Reviewed by Ryosuke Niwa.

Source/WebCore:

platform/mac/fast/text/vertical-no-sideways.html: Modified to cover samples
of the additional character ranges that should not be rotated in vertical layout.
Added pixel results.

This patch modifies shouldIgnoreRotation to include all the characters that
should not be rotated sideways in vertical layout according to the UTR50 draft 6
specifications. It also fixes rotation for Emojii.

• platform/graphics/FontFastPath.cpp:

(WebCore::shouldIgnoreRotation):
(WebCore::isInRange): Added.

• platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances): Adds the proper transforms to ensure
Emojii also are drawn correctly upright.

LayoutTests:

• platform/mac/fast/text/vertical-no-sideways.html: Modified to cover samples

of the additional character ranges that should not be rotated in vertical layout.

• platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt:
• platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.png: Added.

3:30 PM Changeset in webkit [145853] by Lucas Forschler

• 5 edits in branches/safari-534.59-branch/Source

Versioning.

3:30 PM Changeset in webkit [145852] by Lucas Forschler

• 1 copy in tags/Safari-534.59.6

New Tag.

3:16 PM Changeset in webkit [145851] by Lucas Forschler

• 16 edits in branches/safari-534.59-branch

Merged r138606. <rdar://problem/13424275>

3:10 PM Changeset in webkit [145850] by kbr@google.com

• 2 edits in trunk/LayoutTests

Unreviewed test expectations updates. Suppressed a couple of
failures and adjusted a couple of existing expectations.

• platform/chromium/TestExpectations:

3:07 PM HackingGtk edited by Martin Robinson

Cleaned up old information, conglomerated links at the top (diff)

2:54 PM Changeset in webkit [145849] by commit-queue@webkit.org

• 76 edits in trunk

Add selectTrailingWhitespaceEnabled setting to WebCore::Page
​https://bugs.webkit.org/show_bug.cgi?id=109404

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-14
Reviewed by Tony Chang.

Source/WebCore:

Covered by
editing/selection/doubleclick-inline-first-last-contenteditable.html.

• page/Settings.cpp:

(WebCore): Configure default value for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled seetings as they are different in
Chromium port depending on the OS.

• page/Settings.in: Add new setting.

Source/WebKit/blackberry:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

Remove code related to DRT as it is not needed anymore.

• Api/DumpRenderTreeClient.h:
• WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
(WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):

Source/WebKit/chromium:

Use new Page settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled and update API accordingly.

WebSettings API is required by DRT in order to set the proper default
values which are different from browser defaults.

• public/WebSettings.h: Add new API to manage smartInsertDeleteEnabled

and selectTrailingWhitespaceEnabled settings.

• public/WebViewClient.h: Remove API related to smartInsertDeleteEnabled

and selectTrailingWhitespaceEnabled as they will be managed from page
settings from now on.

• src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::smartInsertDeleteEnabled):
(WebKit::EditorClientImpl::isSelectTrailingWhitespaceEnabled): Use new
settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

• src/WebSettingsImpl.cpp: Implement methods establishing the page

settings.
(WebKit::WebSettingsImpl::setSelectTrailingWhitespaceEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setSmartInsertDeleteEnabled):

• src/WebSettingsImpl.h:

(WebSettingsImpl): Implement new API to manage the new settings.

Source/WebKit/efl:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

Remove code related to DRT as it is not needed anymore.

• WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
• WebCoreSupport/DumpRenderTreeSupportEfl.h:
• WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::smartInsertDeleteEnabled):
(WebCore::EditorClientEfl::isSelectTrailingWhitespaceEnabled):
(WebCore::EditorClientEfl::EditorClientEfl):

• WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Source/WebKit/gtk:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

Remove code related to DRT as it is not needed anymore.

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
• WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

• WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::smartInsertDeleteEnabled):
(WebKit::EditorClient::isSelectTrailingWhitespaceEnabled):
(WebKit::EditorClient::EditorClient):

• WebCoreSupport/EditorClientGtk.h:

(EditorClient):

Source/WebKit/mac:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

• WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::smartInsertDeleteEnabled):
(WebEditorClient::isSelectTrailingWhitespaceEnabled):

• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]): Initialize
settings from NSUserDefaults.
(-[WebView setSelectTrailingWhitespaceEnabled:]):
(-[WebView isSelectTrailingWhitespaceEnabled]):
(-[WebView setSmartInsertDeleteEnabled:]):
(-[WebView smartInsertDeleteEnabled]):

• WebView/WebViewData.h:
• WebView/WebViewData.mm:

(-[WebViewPrivate init]):

Source/WebKit/qt:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

Remove code related to DRT as it is not needed anymore.

• WebCoreSupport/DumpRenderTreeSupportQt.cpp:
• WebCoreSupport/DumpRenderTreeSupportQt.h:
• WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::smartInsertDeleteEnabled):
(WebCore::EditorClientQt::toggleSmartInsertDelete):
(WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
(WebCore::EditorClientQt::EditorClientQt):

• WebCoreSupport/EditorClientQt.h:

(EditorClientQt):

Source/WebKit/win:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

• WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::smartInsertDeleteEnabled):
(WebEditorClient::isSelectTrailingWhitespaceEnabled):

• WebView.cpp:

(WebView::WebView):
(WebView::setSmartInsertDeleteEnabled):
(WebView::smartInsertDeleteEnabled):
(WebView::setSelectTrailingWhitespaceEnabled):
(WebView::isSelectTrailingWhitespaceEnabled):

• WebView.h:

(WebView):

Source/WebKit/wince:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

• WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::smartInsertDeleteEnabled):
(WebKit::EditorClientWinCE::isSelectTrailingWhitespaceEnabled):

Source/WebKit/wx:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

• WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::smartInsertDeleteEnabled):
(WebCore::EditorClientWx::isSelectTrailingWhitespaceEnabled):

Tools:

Removes all the code related to smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled settings as they will be managed from
internals from now on.

• DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

• DumpRenderTree/TestRunner.h:

(TestRunner):

• DumpRenderTree/blackberry/DumpRenderTree.cpp:

(WebKit):
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

• DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

(DumpRenderTree):

• DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
• DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner::WebTestProxy::didStopLoading):

• DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):

• DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

• DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::applyTo): Set default values for
smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
Chromium DRT default values are different from Chromium browser.

• DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
• DumpRenderTree/chromium/WebViewHost.cpp:
• DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

• DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

• DumpRenderTree/efl/TestRunnerEfl.cpp:
• DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

• DumpRenderTree/gtk/TestRunnerGtk.cpp:
• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

• DumpRenderTree/mac/TestRunnerMac.mm:
• DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

• DumpRenderTree/qt/TestRunnerQt.cpp:
• DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

• DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

• DumpRenderTree/win/TestRunnerWin.cpp:
• DumpRenderTree/wx/TestRunnerWx.cpp:

LayoutTests:

Replace testRunner.setSelectTrailingWhitespaceEnabled by
internals.settings.setSelectTrailingWhitespaceEnabled in tests.

Be sure that trailingWhitespaceEnabled and
selectTrailingWhitespaceEnabled are set to opposite values as they are
mutually exclusive.

• editing/deleting/smart-editing-disabled.html:
• editing/selection/doubleclick-beside-cr-span.html:
• editing/selection/doubleclick-whitespace-crash.html:
• editing/selection/doubleclick-whitespace-img-crash.html:
• editing/selection/doubleclick-whitespace.html:
• editing/selection/script-tests/doubleclick-inline-first-last-contenteditable.js:
• editing/spelling/resources/util.js:

(initSpellTest):

• editing/spelling/spelling-double-clicked-word-with-underscores.html:
• editing/spelling/spelling-double-clicked-word.html:
• platform/wk2/TestExpectations: Unflag

editing/selection/doubleclick-inline-first-last-contenteditable.html
as it passes now.

2:14 PM Changeset in webkit [145848] by mhahnenberg@apple.com

• 11 edits in trunk/Source/JavaScriptCore

Objective-C API: Objective-C functions exposed to JavaScript have the wrong type (object instead of function)
​https://bugs.webkit.org/show_bug.cgi?id=105892

Reviewed by Geoffrey Garen.

Changed ObjCCallbackFunction to subclass JSCallbackFunction which already has all of the machinery to call
functions using the C API. Since ObjCCallbackFunction is now a JSCell, we changed the old implementation of
ObjCCallbackFunction to be the internal implementation and keep track of all the proper data so that we
don't have to put all of that in the header, which will now be included from C++ files (e.g. JSGlobalObject.cpp).

• API/JSCallbackFunction.cpp: Change JSCallbackFunction to allow subclassing. Originally it was internally

passing its own Structure up the chain of constructors, but we now want to be able to pass other Structures as well.
(JSC::JSCallbackFunction::JSCallbackFunction):
(JSC::JSCallbackFunction::create):

• API/JSCallbackFunction.h:

(JSCallbackFunction):

• API/JSWrapperMap.mm: Changed interface to tryUnwrapBlock.

(tryUnwrapObjcObject):

• API/ObjCCallbackFunction.h:

(ObjCCallbackFunction): Moved into the JSC namespace, just like JSCallbackFunction.
(JSC::ObjCCallbackFunction::createStructure): Overridden so that the correct ClassInfo gets used since we have
a destructor.
(JSC::ObjCCallbackFunction::impl): Getter for the internal impl.

• API/ObjCCallbackFunction.mm:

(JSC::ObjCCallbackFunctionImpl::ObjCCallbackFunctionImpl): What used to be ObjCCallbackFunction is now
ObjCCallbackFunctionImpl. It handles the Objective-C specific parts of managing callback functions.
(JSC::ObjCCallbackFunctionImpl::~ObjCCallbackFunctionImpl):
(JSC::objCCallbackFunctionCallAsFunction): Same as the old one, but now it casts to ObjCCallbackFunction and grabs the impl
rather than using JSObjectGetPrivate.
(JSC::ObjCCallbackFunction::ObjCCallbackFunction): New bits to allow being part of the JSCell hierarchy.
(JSC::ObjCCallbackFunction::create):
(JSC::ObjCCallbackFunction::destroy):
(JSC::ObjCCallbackFunctionImpl::call): Handles the actual invocation, just like it used to.
(objCCallbackFunctionForInvocation):
(tryUnwrapBlock): Changed to check the ClassInfo for inheritance directly, rather than going through the C API call.

• API/tests/testapi.mm: Added new test to make sure that doing Function.prototype.toString.call(f) won't result in

an error when f is an Objective-C method or block underneath the covers.

• runtime/JSGlobalObject.cpp: Added new Structure for ObjCCallbackFunction.

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

• runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::objcCallbackFunctionStructure):

2:10 PM Changeset in webkit [145847] by commit-queue@webkit.org

• 2 edits
  2 adds in trunk/LayoutTests

[CSS Exclusions] shape-outside on floats for rounded rectangle shapes
​https://bugs.webkit.org/show_bug.cgi?id=100299

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-14
Reviewed by Dirk Schulze.

Adding tests for rounded rectangles. The code already supports them,
but that was more of a happy accident. These tests makes it more
likely to stay that way.

• fast/exclusions/resources/rounded-rectangle.js:

(xOutset): Function to determine the offset for the outside shape.
(generateShapeOutsideOnFloat): Generate a shape outside on a float.
(generateSimulatedShapeOutsideOnFloat): Simulate a shape outside on a

float using a large number of smaller floats.

• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-expected.html: Added.
• fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle.html: Added.

2:05 PM Changeset in webkit [145846] by aestes@apple.com

• 2 edits in trunk/Source/WebKit2

[WebKit2] Only preprocess sandbox profiles if we're building for the OS X SDK
​https://bugs.webkit.org/show_bug.cgi?id=112330

Reviewed by David Kilzer.

We shouldn't preprocess sandbox profiles just because the computer
we're building on is a Mac. We should only do it if we're actually
building for the OS X SDK.

• DerivedSources.make: Check if $PLATFORM_NAME is macosx rather than if

$OS is MACOS.

1:56 PM Changeset in webkit [145845] by weinig@apple.com

• 10 edits in trunk/Source/WebKit2

Support private browsing on a per-page basis
<rdar://problem/11969491>

Reviewed by Timothy Horton.

Adds WKPageSetOverridePrivateBrowsingEnabled and WKPageGetOverridePrivateBrowsingEnabled.

• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

• Shared/WebPageCreationParameters.h:

(WebPageCreationParameters):

• UIProcess/API/C/WKPage.cpp:

(WKPageSetOverridePrivateBrowsingEnabled):
(WKPageGetOverridePrivateBrowsingEnabled):

• UIProcess/API/C/WKPagePrivate.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setOverridePrivateBrowsingEnabled):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::overridePrivateBrowsingEnabled):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):
(WebKit::WebPage::setOverridePrivateBrowsingEnabled):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Pipe through.

1:49 PM Changeset in webkit [145844] by commit-queue@webkit.org

• 8 edits
  4 adds in trunk

[chromium] Short scrollbar has empty track rect even when buttons have no size.
​https://bugs.webkit.org/show_bug.cgi?id=102580

Patch by Robert Flack <​flackr@chromium.org> on 2013-03-14
Reviewed by James Robinson.

When computing the scrollbar track rect, don't assume the button's height is the track width.

Source/WebCore:

Test: platform/chromium/scrollbars/short-scrollbar.html
Note however that this doesn't expose the bug on any tested platforms and mock scrollbars
don't use ScrollbarThemeChromium.cpp. Manually running this test on linux chromiumos will
show the now present scrollbar track and thumb.

• platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::trackRect):

LayoutTests:

• platform/chromium-linux/fast/forms/basic-textareas-expected.png:
• platform/chromium-linux/fast/forms/basic-textareas-quirks-expected.png:
• platform/chromium-linux/fast/overflow/overflow-x-y-expected.png:
• platform/chromium-linux/fast/parser/open-comment-in-textarea-expected.png:
• platform/chromium-linux/fast/replaced/width100percent-textarea-expected.png:
• platform/chromium-linux/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.
• platform/chromium/scrollbars/short-scrollbar-expected.txt: Added.
• platform/chromium/scrollbars/short-scrollbar.html: Added.

1:29 PM Changeset in webkit [145843] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Show syntax highlight for application/javascript in Resource Preview tab
​https://bugs.webkit.org/show_bug.cgi?id=112355

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-14
Reviewed by Pavel Feldman.

No new tests.

Return canonical mimeType in requestContent method of
NetworkRequest.js

• inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.requestContent):

1:14 PM Changeset in webkit [145842] by mhahnenberg@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Objective-C API: Nested dictionaries are not converted properly in the Objective-C binding
​https://bugs.webkit.org/show_bug.cgi?id=112377

Reviewed by Oliver Hunt.

Accidental reassignment of the root task in the container conversion logic was causing the last
array or dictionary processed to be returned in the case of nested containers.

• API/JSValue.mm:

(containerValueToObject):

• API/tests/testapi.mm:

1:08 PM Changeset in webkit [145841] by commit-queue@webkit.org

• 12 edits in trunk

[EFL] Use CROSS_PLATFORM_CONTEXT_MENU
​https://bugs.webkit.org/show_bug.cgi?id=111877

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2013-03-14
Reviewed by Caio Marcelo de Oliveira Filho.

.:

• Source/cmake/OptionsEfl.cmake: add -DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1

Source/WebCore:

Now EFL uses the CROSS_PLATFORM_CONTEXT_MENUS
USE flag. This flag provides a full cross-platform
representation of a ContextMenu and a ContextMenuItem.
The embedder can then decide how to show this and neither
WebCore nor WebCore/platform need to know any platform
specific code about the menus, even though they could.

No new tests needed, no behavior changes.

• platform/ContextMenu.h:

(ContextMenu):

• platform/ContextMenuItem.h:

(WebCore):

• platform/PlatformMenuDescription.h:

(WebCore):

• platform/efl/ContextMenuEfl.cpp:

(WebCore::ContextMenu::ContextMenu):
(WebCore::ContextMenu::getContextMenuItems):
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):

• platform/efl/ContextMenuItemEfl.cpp:

(WebCore::ContextMenuItem::platformContextMenuItem):

Source/WebKit/efl:

Adjust ContextMenuClient to use the CROSS_PLATFORM_CONTEXT_MENUS USE flag
by implementing customizeMenu() instead of getCustomMenuFromDefaultItems()
and by calling coreMenu->items() instead of coreMenu->platformDescription().

• WebCoreSupport/ContextMenuClientEfl.cpp:

(WebCore::ContextMenuClientEfl::customizeMenu):

• WebCoreSupport/ContextMenuClientEfl.h:

(ContextMenuClientEfl):

• ewk/ewk_contextmenu.cpp:

(ewk_context_menu_new):

1:04 PM Changeset in webkit [145840] by jchaffraix@webkit.org

• 4 edits in trunk/Source/WebCore

[CSS Grid Layout] resolveContentBasedTrackSizingFunctions should iterate over the grid items not the grid tracks
​https://bugs.webkit.org/show_bug.cgi?id=112299

Reviewed by Tony Chang.

Our initial implementation would iterate over the grid tracks. This was equivalent as no items were spanning but
once grid items spans, they start to contribute to several grid tracks differently. This change aligns our code
with what the specification does.

One upside of doing a grid items' iteration is that the complexity should be better in all cases as we don't do
a full grid walking (which is potentially quadratic), only some extra grid tracks' iteration (which are linear).

Refactoring, there should be no change in behavior.

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Moved the |availableLogicalSpace| update into resolveContentBasedTrackSizingFunctions. This simplifies and consolidate our handling.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
Updated the core loop to iterator over grid items and not grid tracks. This idea is that now resolveContentBasedTrackSizingFunctionsForItems
uses a filtering function to only process the appropriate grid tracks.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Updated to filter the grid tracks here (this matches the |TracksForGrowth| spec logic that is merely a filtering function).

• rendering/RenderGrid.h:

Added a new typedef and updated resolveContentBasedTrackSizingFunctionsForItems to use it.

• rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::hasMinOrMaxContentMinTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMinTrackBreadth):
(WebCore::GridTrackSize::hasMinOrMaxContentMaxTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMaxTrackBreadth):
Added the following filtering function, which matches the values from |TracksForGrowth| in the specification.

12:55 PM Changeset in webkit [145839] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0

Unreviewed. Pre-release version bump.

• Source/autotools/Versions.m4: Bump version to 1.11.92 for people

already using the webkit-2.0 branch.

12:42 PM Changeset in webkit [145838] by fpizlo@apple.com

• 24 edits
  9 adds in trunk

JSObject fast by-string access optimizations should work even on the prototype chain, and even when the result is undefined
​https://bugs.webkit.org/show_bug.cgi?id=112233

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Extended the existing fast access path for String keys to work over the entire prototype chain,
not just the self access case. This will fail as soon as it sees an object that intercepts
getOwnPropertySlot, so this patch also ensures that ObjectPrototype does not fall into that
category. This is accomplished by making ObjectPrototype eagerly reify all of its properties.
This is safe for ObjectPrototype because it's so common and we expect all of its properties to
be reified for any interesting programs anyway. A new idiom for adding native functions to
prototypes is introduced, which ought to work well for any other prototypes that we wish to do
this conversion for.

This is a >60% speed-up in the case that you frequently do by-string lookups that "miss", i.e.
they don't turn up anything.

• CMakeLists.txt:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.list.am:
• dfg/DFGOperations.cpp:
• interpreter/CallFrame.h:

(JSC::ExecState::objectConstructorTable):

• jit/JITStubs.cpp:

(JSC::getByVal):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):

• runtime/CommonIdentifiers.h:
• runtime/JSCell.cpp:

(JSC::JSCell::getByStringSlow):
(JSC):

• runtime/JSCell.h:

(JSCell):

• runtime/JSCellInlines.h:

(JSC):
(JSC::JSCell::getByStringAndKey):
(JSC::JSCell::getByString):

• runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

• runtime/JSGlobalData.h:

(JSGlobalData):

• runtime/JSObject.cpp:

(JSC::JSObject::putDirectNativeFunction):
(JSC):

• runtime/JSObject.h:

(JSObject):
(JSC):

• runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

• runtime/ObjectPrototype.cpp:

(JSC):
(JSC::ObjectPrototype::finishCreation):
(JSC::ObjectPrototype::create):

• runtime/ObjectPrototype.h:

(ObjectPrototype):

• runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::findWithString):

• runtime/Structure.h:

(Structure):

• runtime/StructureInlines.h:

(JSC::Structure::get):
(JSC):

LayoutTests:

Reviewed by Oliver Hunt.

• fast/js/regress/script-tests/string-lookup-hit-identifier.js: Added.

(result):

• fast/js/regress/script-tests/string-lookup-hit.js: Added.

(result):

• fast/js/regress/script-tests/string-lookup-miss.js: Added.

(result):

• fast/js/regress/string-lookup-hit-expected.txt: Added.
• fast/js/regress/string-lookup-hit-identifier-expected.txt: Added.
• fast/js/regress/string-lookup-hit-identifier.html: Added.
• fast/js/regress/string-lookup-hit.html: Added.
• fast/js/regress/string-lookup-miss-expected.txt: Added.
• fast/js/regress/string-lookup-miss.html: Added.

12:35 PM Changeset in webkit [145837] by Carlos Garcia Campos

• 1 edit
  1 add in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Unreviewed build fix. Add missing file.

• UIProcess/API/gtk/WebKitForwardDeclarations.h: Added.

12:18 PM Changeset in webkit [145836] by Carlos Garcia Campos

• 12 edits
  1 delete in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Split WebKitDefines.h in two files.

Reviewed by Gustavo Noronha Silva.

The WebKitDefines.h header has been split moving the forward
declarations specific to the UI process API to a new file
WebKitForwardDeclarations.h. This way we can share the
WebKitDefines.h header and remove the WebKitWebExtensionDefines.h
header used in the web extensions API.

• GNUmakefile.list.am:
• UIProcess/API/gtk/WebKitContextMenu.h:
• UIProcess/API/gtk/WebKitContextMenuItem.h:
• UIProcess/API/gtk/WebKitDefines.h:
• UIProcess/API/gtk/WebKitDownload.h:
• UIProcess/API/gtk/WebKitFindController.h:
• UIProcess/API/gtk/WebKitPrintOperation.h:
• UIProcess/API/gtk/WebKitURISchemeRequest.h:
• UIProcess/API/gtk/WebKitWebView.h:
• WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.h:
• WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionDefines.h: Removed.
• WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h:

12:13 PM Changeset in webkit [145835] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r188004. Requested by
"Dana Jansens" <​danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-14

• DEPS:

12:06 PM Changeset in webkit [145834] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] Gradient: don't use the default setPlatformGradientSpaceTransform()
​https://bugs.webkit.org/show_bug.cgi?id=112246

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-03-14
Reviewed by Xan Lopez.

BlackBerry has its own implementation.

• platform/graphics/Gradient.cpp:

(WebCore):

11:52 AM Changeset in webkit [145833] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/qt

[Qt][WK1] REGRESSION(r145784): Blend tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=112333

Patch by Rik Cabanier <​cabanier@adobe.com> on 2013-03-14
Reviewed by Ryosuke Niwa.

Added code to passed compositing prefence to WebCore.

• Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):

• Api/qwebsettings.h:

11:38 AM Changeset in webkit [145832] by kbr@google.com

• 2 edits in trunk/LayoutTests

Unreviewed expectations updates for a couple of failing tests.

• platform/chromium/TestExpectations:

11:37 AM Changeset in webkit [145831] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)"
​https://bugs.webkit.org/show_bug.cgi?id=112358

Guarded with ENABLE(VIDEO) to prevent problems when it is not
enabled.

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

11:32 AM Changeset in webkit [145830] by fmalita@chromium.org

• 15 edits in trunk/Source/WebCore

Tighten up the type bounds for SVGPropertyInfo callback parameters
​https://bugs.webkit.org/show_bug.cgi?id=111786

Reviewed by Philip Rogers.

Update SVGPropertyInfo's callbacks to pass SVGElement* parameters instead of void*. This
allows us to perform some ASSERT-based type checking before downcasting in implementors.

To avoid adding virtual methods unused in release builds to the base class (and overrides
in descendants), for subtypes lacking polymorphic type markers (isXXX()) the check is
performed using hasTagName() instead.

The patch is also removing the lookupOrCreateWrapperForAnimatedProperty() SVGPropertyInfo
callback for SVGViewSpec properties, because

a) it doesn't appear to be reachable (SVGViewSpec doesn't have a backing element and
thus cannot have an associated animator)

b) it interferes with the parameter specialization described above (SVGViewSpec does not
inherit from SVGElement)

No new tests, refactoring only.

• svg/SVGElement.cpp:

(WebCore::SVGElement::synchronizeRequiredFeatures):
(WebCore::SVGElement::synchronizeRequiredExtensions):
(WebCore::SVGElement::synchronizeSystemLanguage):

• svg/SVGElement.h:

(SVGElement):

• svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::synchronizeOrientType):
(WebCore::SVGMarkerElement::lookupOrCreateOrientTypeWrapper):

• svg/SVGMarkerElement.h:

(SVGMarkerElement):
(WebCore::toSVGMarkerElement):
(WebCore):

• svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::synchronizeD):

• svg/SVGPathElement.h:

(SVGPathElement):
(WebCore::toSVGPathElement):
(WebCore):

• svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):

• svg/SVGPolyElement.h:

(SVGPolyElement):
(WebCore::toSVGPolyElement):
(WebCore):

• svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):

• svg/SVGTextContentElement.h:

(SVGTextContentElement):
(WebCore::toSVGTextContentElement):
(WebCore):
Change SVGPropertyInfo callback params to SVGElement* and replace static casts with
conversion wrappers. Implement conversion wrappers where needed.

• svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::viewBoxPropertyInfo):
(WebCore::SVGViewSpec::preserveAspectRatioPropertyInfo):
(WebCore::SVGViewSpec::transformPropertyInfo):
(WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper):
(WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper):
(WebCore::SVGViewSpec::lookupOrCreateTransformWrapper):

• svg/SVGViewSpec.h:

(SVGViewSpec):
Remove SVGPropertyInfo-based lookupOrCreate* callbacks and updated the methods' parameters
to SVGViewSpec*. Remove now-unneeded casts.

• svg/properties/SVGAnimatedPropertyMacros.h:

(WebCore):

• svg/properties/SVGPropertyInfo.h:

(WebCore):
(SVGPropertyInfo):
Update callback declarations.

11:20 AM Changeset in webkit [145829] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

[chromium] Add tools/protoc_wrapper to directories pulled in Chromium-in-WebKit configuration
​https://bugs.webkit.org/show_bug.cgi?id=112363

Patch by James Robinson <​jamesr@chromium.org> on 2013-03-14
Reviewed by Kenneth Russell.

Chromium r187704 added a reference to this script to src/gpu/gpu.gyp, which we pull in the Chromium-in-WebKit
configuration. This adds the script to DEPS so we can roll past that rev.

• DEPS:

10:40 AM Changeset in webkit [145828] by fpizlo@apple.com

• 5 edits
  3 adds in trunk

DFG bytecode parser is too aggressive about getting rid of GetLocals on captured variables
​https://bugs.webkit.org/show_bug.cgi?id=112287
<rdar://problem/13342340>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finalizeUnconditionally):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):

LayoutTests:

• fast/js/dfg-captured-var-get-local-expected.txt: Added.
• fast/js/dfg-captured-var-get-local.html: Added.
• fast/js/jsc-test-list:
• fast/js/script-tests/dfg-captured-var-get-local.js: Added.

(foo):

10:38 AM Changeset in webkit [145827] by commit-queue@webkit.org

• 11 edits in trunk/Source

Move platform-specific typedefs to PlatformMenuDescription.h
​https://bugs.webkit.org/show_bug.cgi?id=111876

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2013-03-14
Reviewed by Caio Marcelo de Oliveira Filho.

Source/WebCore:

Cross platform Context Menu platform-specific typedefs fit better
in PlatformMenuDescription.h and should not be part of the classes
ContextMenu and ContextMenuItem. We have also renamed them to
PlatformContextMenu and PlatformContextMenuItem instead of NativeMenu
and NativeMenuItem respectively.

No new tests needed since no behavior has changed.

• platform/ContextMenu.h:

(ContextMenu):

• platform/ContextMenuItem.h:

(ContextMenuItem):

• platform/PlatformMenuDescription.h:

(WebCore):

• platform/efl/ContextMenuEfl.cpp:

(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):

• platform/efl/ContextMenuItemEfl.cpp:

(WebCore::ContextMenuItem::platformContextMenuItem):

• platform/win/ContextMenuItemWin.cpp:

(WebCore):
(WebCore::ContextMenuItem::platformContextMenuItem):

• platform/win/ContextMenuWin.cpp:

(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):

Source/WebKit/win:

Rename NativeMenuItem to PlatformContextMenuItem and the getter
function call.

• WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::customizeMenu):
(WebContextMenuClient::contextMenuItemSelected):

• WebView.cpp:

(WebView::handleContextMenuEvent):

10:27 AM Changeset in webkit [145826] by jer.noble@apple.com

• 18 edits in trunk/Source/WebCore

Crash in DumpRenderTree at com.apple.WebCore: WebCore::CaptionUserPreferences::captionPreferencesChanged + 185
​https://bugs.webkit.org/show_bug.cgi?id=112051

Reviewed by Eric Carlson.

No new tests; fixes a crash during media/video-controls-captions-trackmenu.html.

Instead of relying on a registration system which can fail when an element's document does not have a page,
Elements will register for captionPreferencesChanged() notifications directly with their owning Document.
CaptionUserPreferences, in turn, will notify all Documents in its PageGroup, rather than only directly
registered listeners.

• dom/Document.cpp:

(WebCore::Document::registerForCaptionPreferencesChangedCallbacks): Added. Notify the CaptionUserPreferences that someone

is interested in captionPreferencesChanged notfications.

(WebCore::Document::unregisterForCaptionPreferencesChangedCallbacks): Added.
(WebCore::Document::captionPreferencesChanged): Added. Pass to all registered elements.

• dom/Document.h:
• dom/Element.h:

(WebCore::Element::captionPreferencesChanged): Added. Empty; intended

to be overridden by subclasses.

• history/CachedPage.cpp:

(WebCore::CachedPage::CachedPage): Initialize m_needsCaptionPreferenceChanged member.
(WebCore::CachedPage::restore): Call captionPreferencesChanged() if necessary.

• history/CachedPage.h:

(WebCore::CachedPage::markForCaptionPreferencesChanged): Set the m_needsCaptionPreferenceChanged member.

• history/PageCache.cpp:

(WebCore::PageCache::markPagesForCaptionPreferencesChanged): Pass to every CachedPage.

• history/PageCache.h:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Register with the Document.
(WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister with same.
(WebCore::HTMLMediaElement::attach): Remove previous registration call.

• html/HTMLMediaElement.h:
• page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::captionPreferencesChanged): Pass to the

PageGroup.

• page/CaptionUserPreferences.h:

(WebCore::CaptionUserPreferences::setInterestedInCaptionPreferenceChanges):

Empty; intended to be overridden by subclasses.

• page/CaptionUserPreferencesMac.h:
• page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::setInterestedInCaptionPreferenceChanges):

Renamed from registerForPreferencesChangedCallbacks().

(WebCore::CaptionUserPreferencesMac::captionPreferencesChanged):

Replace call to havePreferenceChangeListeners() with m_listeningForPreferenceChanges.

• page/Page.cpp:

(WebCore::Page::captionPreferencesChanged):

Pass to every contained Document.

• page/Page.h:
• page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::captionPreferencesChanged): Pass to the PageGroup.

• page/CaptionUserPreferences.h:
• page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferencesChanged): Pass to every page, as well as pages in the PageCache.

• page/PageGroup.h:

10:11 AM Changeset in webkit [145825] by tdanderson@chromium.org

• 1 edit in branches/chromium/1410/LayoutTests/platform/chromium/TestExpectations

Merge 144700 "Unreviewed gardening."

Just merged ​https://codereview.chromium.org/12817006/ into the 26 milestone. I am also
merging this in order to suppress two test failures on chromium-mac. These tests are
no cause for concern (since chromium-mac does not use the scrolling code I have
changed) and these will be given new baselines in a future milestone. See
​https://code.google.com/p/chromium/issues/detail?id=174255

Unreviewed gardening.

• platform/chromium/TestExpectations: touch-gesture-noscroll-body-* are failing on mac.

TBR=​tdanderson@chromium.org
Review URL: ​https://codereview.chromium.org/12870005

10:08 AM Changeset in webkit [145824] by dgrogan@chromium.org

• 2 edits in trunk/Source/WebCore

IndexedDB: Histogram leveldb open errors.
​https://bugs.webkit.org/show_bug.cgi?id=112307

Reviewed by Tony Chang.

No new tests, I don't know if there's a good way to test histograms.

• platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::open):

10:06 AM Changeset in webkit [145823] by caseq@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed flakiness fix following r145727: filter out coalescing records while dumping timeline record structure.

• inspector/timeline/timeline-receive-response-event.html:

10:01 AM Changeset in webkit [145822] by robert@webkit.org

• 2 edits in trunk/Source/WebCore

REGRESSION(r145305) Performance: 1.3% mac-release-10.6-webkit-latest/intl2/times/t change after rev 145300
​https://bugs.webkit.org/show_bug.cgi?id=112125

Reviewed by Julien Chaffraix.

When detecting cases where a loaded image may need to move up into the padding created by the row's baseline
we don't need to do anything if the row doesn't have a baseline yet.

• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::layout):

9:55 AM Changeset in webkit [145821] by tdanderson@chromium.org

• 12 edits
  12 copies in branches/chromium/1410

Merge 144519 "EventHandler::handleGestureScrollUpdate() should i..."

EventHandler::handleGestureScrollUpdate() should invoke the user-generated scroll routines
so its behavior matches other user-initiated scrolls
​https://bugs.webkit.org/show_bug.cgi?id=109769

Reviewed by James Robinson.

Source/WebCore:

To ensure that the scrolling behavior of GestureScrollUpdate events are consistent with
the scrolling behavior of mousewheel events, use the existing user-generated scroll logic
instead of calling into RenderLayer::scrollByRecursively(). This patch fixes the bug
reported in ​https://bugs.webkit.org/show_bug.cgi?id=109316, where the example page can
be scrolled using touch but cannot be scrolled using mousewheels.

Note that this patch does not use any of the mousewheel event-handling code.

Tests: fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html

fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html
fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html
fast/events/touch/gesture/touch-gesture-noscroll-body.html

• page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureScrollBegin):
(WebCore::EventHandler::handleGestureScrollUpdate):
(WebCore::EventHandler::sendScrollEventToView):

By calling this function at the start of handleGestureScrollUpdate() in the case
where |m_scrollGestureHandlingNode| is null, we ensure that the scroll updates
can still scroll the page itself, if possible.

(WebCore):
(WebCore::EventHandler::clearGestureScrollNodes):

• page/EventHandler.h:

(EventHandler):

• platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::setHasPreciseScrollingDeltas):

Source/WebKit/chromium:

Clear the nodes corresponding to a fling scroll event when the event ends.

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateAnimations):

LayoutTests:

Four new layout tests have been added and touch-gesture-scroll-page.html has been
modified to demonstrate that this patch fixes two existing bugs. See the inline
comments below for details.

Because I am now using the existing user-generated scroll logic, the delta for a single
GestureScrollUpdate event will not be propagated to the parent of the targeted node
unless the targeted node has no remaining scrollable area. So the changes to the
existing layout tests have been made to ensure that the targeted node has been fully
scrolled before subsequent GestureScrollUpdate events will scroll the parent(s) of
the targeted node.

I have also removed the function recordScroll() from the existing layout tests
because this function already exists in the included file resources/gesture-helpers.js.

• fast/events/touch/gesture/touch-gesture-noscroll-body-expected.txt: Added.
• fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt: Added.
• fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
• fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt: Added.
• fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
• fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt: Added.
• fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
• fast/events/touch/gesture/touch-gesture-noscroll-body.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
• fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html:
• fast/events/touch/gesture/touch-gesture-scroll-div-propagated.html:
• fast/events/touch/gesture/touch-gesture-scroll-div-twice-propagated.html:
• fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html:
• fast/events/touch/gesture/touch-gesture-scroll-iframe-propagated.html:
• fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html:
• fast/events/touch/gesture/touch-gesture-scroll-page-propagated.html:
• fast/events/touch/gesture/touch-gesture-scroll-page.html:

I modified this layout test in order to add test coverage for another bug
which is fixed by this patch: if the hit test performed on a GestureScrollBegin
does not target a specific node, the subsequent GestureScrollUpdate events should
still attempt to scroll the page itself. This is consistent with how mousewheel
events behave.

• platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-expected.txt: Added.
• platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt: Added.
• platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt: Added.
• platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt: Added.

These four new layout tests verify that a non-scrollable body will not scroll,
as reported in ​https://bugs.webkit.org/show_bug.cgi?id=109316.

TBR=​tdanderson@chromium.org
Review URL: ​https://codereview.chromium.org/12817006

9:28 AM Changeset in webkit [145820] by beidson@apple.com

• 12 edits in trunk/Source/WebCore

Add a mode to ResourceLoader that takes SharedBuffers instead of raw pointers and lengths.
<rdar://problem/13416953> and ​https://bugs.webkit.org/show_bug.cgi?id=112310

Reviewed by Andy Estes.

No new tests (No independently testable change in behavior).

Many of the tested platforms deliver data buffers to their ResourceHandles from objects
that encapsulate a data buffer such as NSData (Mac), CFDataRef (CF), or QByteArray (qt).

If those platforms also augmented SharedBuffer to wrap their native object (which Mac/CF do)
and there existed ResourceLoader callbacks to take that SharedBuffer instead of char* + length,
then many resource loads could avoid a useless copy.

At least on Mac, there are some extremely important behind-the-scenes optimizations for NS/CFData
that will be a more important win than simply avoiding a copy.

This patch adds that SharedBuffer-based callback with the hope that all platforms could find a
way to use a buffer-encapsulating object going forward, and we could therefore deprecate the
char* + length version of didReceiveData.

• platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didReceiveBuffer): Add a didReceiveBuffer callback that takes

a SharedBuffer object. The default implementation passes raw bytes + length to didReceiveData.

• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::addDataOrBuffer): Replacing addData(), optionally adding the data from

either a data+length or SharedBuffer

(WebCore::ResourceLoader::didReceiveData): Pipe to didReceiveDataOrBuffer.
(WebCore::ResourceLoader::didReceiveBuffer): Pipe to didReceiveDataOrBuffer.
(WebCore::ResourceLoader::didReceiveDataOrBuffer): Single chokepoint for receiving data.

• loader/ResourceLoader.h: Add OVERRIDE to all of the ResourceHandleClient methods to help catch future mistakes. Remove "virtual" from methods that didn't need it. Make "addData" into "addDataOrBuffer" and make it private.

• loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::didReceiveData): Pipe to didReceiveDataOrBuffer.
(WebCore::NetscapePlugInStreamLoader::didReceiveBuffer): Pipe to didReceiveDataOrBuffer.
(WebCore::NetscapePlugInStreamLoader::didReceiveDataOrBuffer): Single chokepoint for receiving data.

• loader/NetscapePlugInStreamLoader.h:

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveData): Pipe to didReceiveDataOrBuffer.
(WebCore::SubresourceLoader::didReceiveBuffer): Pipe to didReceiveDataOrBuffer.
(WebCore::SubresourceLoader::didReceiveDataOrBuffer): Single chokepoint for receiving data. Also,

rely on ResourceLoader's base implementation for notifying the ResourceLoadNotifier.

• loader/SubresourceLoader.h:

• loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::append): Add a mode that appends a SharedBuffer.

• loader/ResourceBuffer.h:

• platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::maybeTransferPlatformData): Fix a bug where appending data to a CFData-backed

SharedBuffer would re-enter maybeTransferPlatformData and blow out the stack.

• platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): Send a wrapped NSData

to didReceiveBuffer() instead of sending its char* and length to didReceiveData()

9:14 AM Changeset in webkit [145819] by yurys@chromium.org

• 7 edits in trunk/Source/WebCore

Web Inspector: nuke bottom up CPU profile calculation on backend
​https://bugs.webkit.org/show_bug.cgi?id=112351

Reviewed by Pavel Feldman.

Removed code that builds bottom-up CPU profile on the inspector
backend. Bottom-up view is already built on the front-end from
the top-down profile data.

• bindings/js/ScriptProfile.cpp:
• bindings/js/ScriptProfile.h:

(ScriptProfile):

• bindings/v8/ScriptProfile.cpp:

(WebCore::ScriptProfile::buildInspectorObjectForHead):

• bindings/v8/ScriptProfile.h:

(ScriptProfile):

• inspector/Inspector.json:
• inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getCPUProfile):

9:08 AM Changeset in webkit [145818] by inferno@chromium.org

• 88 edits in trunk/Source

Replace static_casts with to* helper functions.
​https://bugs.webkit.org/show_bug.cgi?id=112296

Reviewed by Kentaro Hara.

to* helper functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

Source/WebCore:

• accessibility/AXObjectCache.cpp:

(WebCore::nodeHasRole):

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasAttribute):
(WebCore::AccessibilityObject::getAttribute):

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
(WebCore::AccessibilityRenderObject::titleUIElement):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::accessKey):
(WebCore::AccessibilityRenderObject::setElementAttributeValue):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::activeDescendant):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):
(WebCore::AccessibilityRenderObject::setAccessibleName):
(WebCore::AccessibilityRenderObject::stringRoleForMSAA):

• bindings/gobject/WebKitDOMBinding.cpp:

(WebKit::createWrapper):

• bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::setDragImage):

• bindings/js/JSElementCustom.cpp:

(WebCore::toJSNewlyCreated):

• bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

• bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageMethodCustom):

• bindings/v8/custom/V8ElementCustom.cpp:

(WebCore::wrap):

• bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::wrap):

• dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::recalcStyle):
(WebCore::Document::setFocusedNode):
(WebCore::Document::updateFocusAppearanceTimerFired):

• dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

• dom/Element.cpp:

(WebCore::Element::offsetParent):
(WebCore::Element::boundsInRootViewSpace):
(WebCore::Element::getBoundingClientRect):
(WebCore::Element::recalcStyle):
(WebCore::Element::computeInheritedLanguage):
(WebCore::Element::lastElementChild):

• dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::namedItem):

• dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::normalize):
(WebCore::Node::rootEditableElement):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::ancestorElement):
(WebCore::appendAttributeDesc):

• dom/Position.cpp:

(WebCore::Position::element):

• dom/Range.cpp:

(WebCore::Range::getBorderAndTextQuads):

• dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::queryFirst):
(WebCore::SelectorDataList::execute):

• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcStyle):

• dom/StaticHashSetNodeList.cpp:

(WebCore::StaticHashSetNodeList::namedItem):

• editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):

• editing/Editor.cpp:

(WebCore::Editor::applyEditingStyleToBodyElement):

• editing/FrameSelection.cpp:

(WebCore::removingNodeRemovesPosition):

• editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::outdentParagraph):

• editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::entityMaskForText):
(WebCore::MarkupAccumulator::appendStartMarkup):
(WebCore::MarkupAccumulator::appendEndMarkup):

• editing/ModifySelectionListLevel.cpp:

(WebCore::IncreaseSelectionListLevelCommand::doApply):

• editing/ReplaceSelectionCommand.cpp:

(WebCore::haveSameTagName):
(WebCore::handleStyleSpansBeforeInsertion):
(WebCore::ReplaceSelectionCommand::doApply):

• editing/SplitTextNodeContainingElementCommand.cpp:

(WebCore::SplitTextNodeContainingElementCommand::doApply):

• editing/TextIterator.cpp:

(WebCore::TextIterator::advance):

• editing/htmlediting.cpp:

(WebCore::unsplittableElementForPosition):
(WebCore::enclosingTableCell):

• editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::wrapWithNode):
(WebCore::createMarkupInternal):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::isPlainTextMarkup):
(WebCore::createFragmentFromText):

• html/HTMLElement.cpp:

(WebCore::HTMLElement::insertAdjacentElement):
(WebCore::contextElementForInsertion):

• html/HTMLFormControlElement.cpp:

(WebCore::focusPostAttach):
(WebCore::updateFromElementCallback):

• html/HTMLFormElement.cpp:

(WebCore::submitElementFromEvent):

• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateSnapshotInfo):

• html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::addRange):

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::closestFormAncestor):

• html/shadow/MediaControlElementTypes.cpp:

(WebCore::toParentMediaElement):

• html/shadow/TextFieldDecorationElement.h:

(WebCore::toTextFieldDecorationElement):

• inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::createDigest):

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::didInvalidateStyleAttr):

• inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::inlineStyleSheetText):

• mathml/MathMLElement.h:

(WebCore::toMathMLElement):

• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

• page/DragController.cpp:

(WebCore::elementUnderMouse):
(WebCore::DragController::startDrag):

• page/FocusController.cpp:

(WebCore::FocusController::advanceFocusInDocumentOrder):

• page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):

• page/FrameView.cpp:

(WebCore::FrameView::updateWidget):

• page/SpatialNavigation.cpp:

(WebCore::rectToAbsoluteCoordinates):

• page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::sendTransitionEvent):

• page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):

• platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
(WebCore::RenderThemeEfl::paintMediaMuteButton):

• rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):

• rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::calcViewport):

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::getElementById):

• svg/SVGUseElement.cpp:

(WebCore::isDisallowedElement):

• svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource):

• xml/XPathStep.cpp:

(WebCore::XPath::nodeMatchesBasicTest):

• xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::parseEndElement):

Source/WebKit/blackberry:

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::setNodeFocus):
(BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):

• WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):

• WebKitSupport/BackingStoreClient.cpp:

(BlackBerry::WebKit::BackingStoreClient::absoluteRect):

• WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::toTextControlElement):
(BlackBerry::WebKit::DOMSupport::selectionContainerElement):

• WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):
(BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
(BlackBerry::WebKit::InputHandler::willOpenPopupForNode):

• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):

• WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::elementForTapHighlight):

Source/WebKit/chromium:

• src/WebDocument.cpp:

(WebKit::WebDocument::images):

• src/WebElement.cpp:

(WebKit::WebElement::operator PassRefPtr<Element>):

• src/WebPageSerializer.cpp:

(WebCore::retrieveResourcesForFrame):

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setFocus):
(WebKit::WebViewImpl::clearFocusedNode):
(WebKit::WebViewImpl::scrollFocusedNodeIntoView):
(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):

Source/WebKit/gtk:

• webkit/webkitwebview.cpp:

(webkit_web_view_query_tooltip):

Source/WebKit/mac:

• WebCoreSupport/WebFrameLoaderClient.mm:

(applyAppleDictionaryApplicationQuirkNonInlinePart):

• WebView/WebHTMLRepresentation.mm:

(searchForLabelsBeforeElement):

Source/WebKit/qt:

• Api/qwebelement.cpp:

(QWebElement::firstChild):
(QWebElement::lastChild):
(QWebElement::nextSibling):
(QWebElement::previousSibling):
(QWebElementCollection::at):
(QWebElementCollection::toList):

• WebCoreSupport/QWebFrameAdapter.cpp:

(QWebHitTestResultPrivate::elementForInnerNode):

Source/WebKit/win:

• WebView.cpp:

(WebView::enterFullscreenForNode):

Source/WebKit2:

• WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::elementBounds):

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormElements):

9:02 AM Changeset in webkit [145817] by pfeldman@chromium.org

• 2 edits in trunk/LayoutTests

Not reviewed: chromium expectations updated.

• platform/chromium/TestExpectations:

8:50 AM Changeset in webkit [145816] by pfeldman@chromium.org

• 4 edits in trunk/Source/WebCore

Web Inspector: keep deprecated function stubs in InspectorFrontendHost.
​https://bugs.webkit.org/show_bug.cgi?id=112347

Reviewed by Vsevolod Vlasov.

In order to open older front-ends in newer hosts, we need to keep stubs
for deprecated functions. Longer term, we need to wrap all calls to InspectorFrontendHost in the front-end.

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canInspectWorkers):
(WebCore):
(WebCore::InspectorFrontendHost::hiddenPanels):

• inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

• inspector/InspectorFrontendHost.idl:

8:31 AM Changeset in webkit [145815] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Fixed styles pane visibility when docked to right.
​https://bugs.webkit.org/show_bug.cgi?id=112348

Patch by Vladislav Kaznacheev <​kaznacheev@chromium.org> on 2013-03-14
Reviewed by Pavel Feldman.

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._splitVertically):

• inspector/front-end/SidebarPane.js:

(WebInspector.SidebarPane.prototype.setExpandCallback):
(WebInspector.SidebarPaneTitle):
(WebInspector.SidebarTabbedPane.prototype.addPane):

8:25 AM Changeset in webkit [145814] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[BlackBerry] GraphicsContext3D: implement ImageExtractor::extractImage()
​https://bugs.webkit.org/show_bug.cgi?id=112242

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-03-14
Reviewed by Rob Buis.

In r136282 GraphicsContext3D::getImageData() was refactored in a
new class called ImageExtractor.

This patch implements the necessary changes for the BlackBerry
port, which is still using the old API.

• platform/graphics/GraphicsContext3D.h:

(ImageExtractor):

• platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

8:18 AM Changeset in webkit [145813] by Simon Hausmann

• 2 edits in trunk/Tools

[Qt] Disable DRT on Windows

Reviewed by Jocelyn Turcotte.

We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.

• qmake/mkspecs/features/configure.prf:

8:15 AM Changeset in webkit [145812] by commit-queue@webkit.org

• 14 edits
  6 adds in trunk

[EFL][WK2] Add an API for adding and removing user style sheets from a page group
​https://bugs.webkit.org/show_bug.cgi?id=110728

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2013-03-14
Reviewed by Gyuyoung Kim.

Source/WebKit2:

This patch implements EwkPageGroup API to provide the interface of WKPageGroup. Using the EwkPageGroup,
applications may create the views with a page group for the specific identifier. Also, this patch
encapsulates the APIs WKPageGroupAddUserStyleSheet and WKPageGroupRemoveAllUserStyleSheets behind
the EwkPageGroup class for adding and removing user style sheets from a page group. WKArrayCreateWithEinaList()
is added as a generic WKArray creation API from Eina_List.

• PlatformEfl.cmake:
• UIProcess/API/C/efl/WKView.cpp:

(createWKView):

• UIProcess/API/efl/EWebKit2.h:
• UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::createEvasObject):

• UIProcess/API/efl/EwkView.h:

(EwkView::ewkPageGroup):
(EwkView):

• UIProcess/API/efl/ewk_view.cpp:

(ewk_view_smart_add):
(ewk_view_page_group_get):

• UIProcess/API/efl/ewk_view.h:
• UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::SetUp):

• UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTest::EWK2UnitTestBase::setWebView):

• UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

• UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Tools:

Use the page group to create the view object.

• MiniBrowser/efl/main.c:

(window_create):

7:39 AM Changeset in webkit [145811] by commit-queue@webkit.org

• 13 edits
  2 adds in trunk

[GStreamer] Stopping playback of html5 media when receiving a higher priority audio event needs implementation
​https://bugs.webkit.org/show_bug.cgi?id=91611

Source/WebCore:

React to REQUEST_STATE GStreamer message to stop the pipeline when
a higher priority stream is played. When this happens, states are
updated accordingly.

A method was added in the MediaPlayer class and internals to allow
the the test runner to simulate an audio interruption.

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

Test: media/media-higher-prio-audio-stream.html

• platform/graphics/MediaPlayer.h:
• platform/graphics/MediaPlayer.cpp:

(WebCore):
(MediaPlayer):
(WebCore::MediaPlayer::simulateAudioInterruption): New method
delegating an audio interruption to the private backend to
simulate the use-case where an external application needs
exclusive access to the audio device.

• platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::simulateAudioInterruption):
Added default empty method in the common private header.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::setAudioStreamPropertiesCallback): Hooked to child-added
signal on the audio sink, delegates on setAudioStreamProperties.
(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
Sets the audio stream properties.
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Initializes the new attribute.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Disconnects autoaudiosink signal.
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
Changed logging.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Reacting to
the REQUEST_STATE message.
(WebCore::MediaPlayerPrivateGStreamer::simulateAudioInterruption):
Added. Injects the REQUEST_STATE message to the pipeline.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Updating the
playback state if REQUEST_STATE.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer): Added new method and attribute.

• testing/Internals.h:
• testing/Internals.idl:
• testing/Internals.cpp:

(WebCore):
(WebCore::Internals::simulateAudioInterruption): Added to call the
method to stop the element because of a higher prio stream at the
tests.

LayoutTests:

Created test, expected result and updated other ports
expectations.

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

• media/media-higher-prio-audio-stream-expected.txt: Added.
• media/media-higher-prio-audio-stream.html: Added.
• platform/chromium/TestExpectations: Skipped the new test.
• platform/mac/TestExpectations: Skipped the new test.
• platform/qt/TestExpectations: Skipped the new test for Mac and

Win.

7:28 AM WebKitGTK/2.0.x edited by Philippe Normand

(diff)

7:04 AM Changeset in webkit [145810] by allan.jensen@digia.com

• 3 edits in trunk/Source/WebCore

[Qt] Add support for tiled shadow blur
​https://bugs.webkit.org/show_bug.cgi?id=90082

Reviewed by Noam Rosenthal.

Use the optimized ShadowBlur::drawRectShadow as long as we do not
have a rotating transform. Such a transform would go through the
slow path in ShadowBlur anyway, and would end up using a transformed
TransparencyLayer with an alphaMap which causes scaling artifacts
for us.

Tested by fast/canvas/canvas-scale-fillRect-shadow.html
and fast/canvas/canvas-transforms-fillRect-shadow.html

• platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::drawInsetShadowWithTiling):

Handle scaling transforms when shadows ignore transforms.

(WebCore::ShadowBlur::drawRectShadowWithTiling):

Ditto.

• platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillRect):

6:59 AM Changeset in webkit [145809] by caseq@chromium.org

• 8 edits in trunk/Source/WebCore

Web Inspector: do not aggregate non-main thread timeline events, handle them in a generic fashion
​https://bugs.webkit.org/show_bug.cgi?id=112172

Reviewed by Vsevolod Vlasov.

• build nested event trees for non-main thread events similar to how it's done on the main thread;
• drop aggregation logic for Rasterize events;
• extract time conversion logic so that it may be reused in TimelineTraceEventProcessor.

• English.lproj/localizedStrings.js: drive-by: drop duplicate line.
• inspector/InspectorTimelineAgent.cpp:

(WebCore::TimelineTimeConverter::reset):
(WebCore):
(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::sendEvent):
(WebCore::InspectorTimelineAgent::timestamp):

• inspector/InspectorTimelineAgent.h:

(TimelineTimeConverter):
(WebCore::TimelineTimeConverter::TimelineTimeConverter):
(WebCore::TimelineTimeConverter::fromMonotonicallyIncreasingTime):
(WebCore):
(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::timeConverter):

• inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createBackgroundRecord):
(WebCore):

• inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):

• inspector/TimelineTraceEventProcessor.cpp:

(WebCore::TimelineRecordStack::TimelineRecordStack):
(WebCore):
(WebCore::TimelineRecordStack::addScopedRecord):
(WebCore::TimelineRecordStack::closeScopedRecord):
(WebCore::TimelineRecordStack::addInstantRecord):
(WebCore::TimelineRecordStack::isOpenRecordOfType):
(WebCore::TimelineRecordStack::send):
(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::onBeginFrame):
(WebCore::TimelineTraceEventProcessor::onRasterTaskBegin):
(WebCore::TimelineTraceEventProcessor::onRasterTaskEnd):
(WebCore::TimelineTraceEventProcessor::createRecord):

• inspector/TimelineTraceEventProcessor.h:

(TimelineRecordStack):
(WebCore::TimelineRecordStack::Entry::Entry):
(Entry):
(WebCore::TimelineRecordStack::TimelineRecordStack):
(WebCore):
(WebCore::TimelineTraceEventProcessor::TimelineThreadState::TimelineThreadState):
(TimelineThreadState):
(TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::isNull):
(WebCore::TimelineTraceEventProcessor::threadState):

6:56 AM Changeset in webkit [145808] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK] Wrong ASSERT in AudioDestinationGstreamer::stop
​https://bugs.webkit.org/show_bug.cgi?id=112344

Patch by Xan Lopez <​xlopez@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

Correct erroneous ASSERT, we want both member variables to exist.

• platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::stop):

6:36 AM Changeset in webkit [145807] by loislo@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Support scroll and zoom with help of mouse wheel.
​https://bugs.webkit.org/show_bug.cgi?id=112337

Reviewed by Yury Semikhatsky.

New member variable _xOffset were introduced.

• inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._adjustXOffset):
(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype._onMouseWheel):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._scheduleUpdate):
(WebInspector.FlameChart.prototype.update):

5:58 AM BadContent edited by zandobersek@gmail.com

Blacklist a spamming account. (diff)

5:29 AM Changeset in webkit [145806] by kbalazs@webkit.org

• 3 edits in trunk/Source/WebCore

[Texmap] Synchronize layers only if the layer has been changed.
​https://bugs.webkit.org/show_bug.cgi?id=112095

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-03-14
Reviewed by Allan Sandfeld Jensen.

A regression was introduced in r144787, causing an infinite IPC commitState/renderNextFrame
loop.
This patch fixes this by making sure we only commit layer states that have actual pending
changes.

No new tests, this is an optimization.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(CoordinatedGraphicsLayerState):
(WebCore::CoordinatedGraphicsLayerState::hasPendingChanges):

4:52 AM Changeset in webkit [145805] by Simon Hausmann

• 23 edits in trunk

[Qt] Improve the handling of mock geolocation, device orientation and motion clients

Reviewed by Tor Arne Vestbø.

The mock versions of these web facing features should be instantiated when
running in DumpRenderTree only. In order for them to work, no extra Qt modules
such as QtLocation are actually needed.

This patch decouples enabling device orientation/motion and geolocation from
the underlying Qt modules and makes them available in developer builds
(!production_build) and backed by mock backends when running in drt.

So if the Qt 5 modules are available, they'll be used (unless drtRun). For
developers the web facing features are always enabled (although requests will
time out) and the mock backends are enabled inside DRT, allowing for the layout
tests to run with less dependencies.

In addition this also enables the mock device motion client, which was
previously never instantiated.

.:

• Source/widgetsapi.pri:

Source/WebCore:

• Target.pri:
• WebCore.pri:

Source/WebKit:

• WebKit1.pri:
• WebKit1.pro:

Source/WebKit/qt:

• WebCoreSupport/QWebFrameAdapter.cpp:

(QWebFrameAdapter::_q_orientationChanged):

• WebCoreSupport/QWebFrameAdapter.h:
• WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::initializeWebCorePage):

• WebCoreSupport/QWebPageAdapter.h:
• WidgetApi/qwebframe.cpp:

(QWebFrame::QWebFrame):

• WidgetApi/qwebpage.cpp:

(QWebPage::setFeaturePermission):

Source/WebKit2:

• Target.pri:
• UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

• UIProcess/qt/WebGeolocationProviderQt.cpp:
• WebKit2.pri:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

Tools:

• qmake/mkspecs/features/features.prf:

4:46 AM Changeset in webkit [145804] by zeno.albisser@digia.com

• 4 edits in trunk/Tools

[Qt] Removing no-ops and simple setters/getters from TestRunnerQt
​https://bugs.webkit.org/show_bug.cgi?id=112340

Reviewed by Simon Hausmann.

• DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(DumpRenderTree::dump):

Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().

(DumpRenderTree::dumpApplicationCacheQuota):

• DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::reset):

• DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

4:26 AM Changeset in webkit [145803] by allan.jensen@digia.com

• 2 edits in trunk/Source/WebCore

[TexMap] Painting into area of composited tile not cleared
​https://bugs.webkit.org/show_bug.cgi?id=112268

Reviewed by Kenneth Rohde Christiansen.

Clip painting to the area that has been cleared, so we
do not accidentally overpaint other areas.

Can be observed in ManualTests/scrollbars/scrollbars-in-composited-layers.html.

• platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::updateContents):

4:12 AM Changeset in webkit [145802] by commit-queue@webkit.org

• 64 edits in trunk/Source

[V8] Store main world and non-main world templates separately.
​https://bugs.webkit.org/show_bug.cgi?id=111724

Patch by Marja Hölttä <​marja@chromium.org> on 2013-03-14
Reviewed by Jochen Eisinger.

This is needed for generating specialized bindings for the main
world (bug 110874).

Source/WebCore:

No new tests (updated existing bindings tests).

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
(JSValueToNative):
(CreateCustomSignature):

• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

• bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

• bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

• bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

• bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

• bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

• bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

• bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

• bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

• bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

• bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

• bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

• bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

• bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

• bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

• bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

• bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

• bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

• bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

• bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

• bindings/v8/SerializedScriptValue.cpp:
• bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

• bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

• bindings/v8/V8Binding.h:

(WebCore):
(WebCore::toRefPtrNativeArray):

• bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

• bindings/v8/V8GCController.cpp:
• bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

• bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):

• bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::rawTemplateMap):
(V8PerIsolateData):
(WebCore::V8PerIsolateData::templateMap):

• bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

• bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

• bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

• bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

• bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toCanvasStyle):

• bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageMethodCustom):

• bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesMethodCustom):

• bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):

• bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCustom):

• bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateMethodCustom):

• bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

• bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addMethodCustom):

• bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::removeElement):

• bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):

• bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

• bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

• bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

• bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

• bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

• src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::createFromV8Value):

• src/WebArrayBufferView.cpp:

(WebKit::WebArrayBufferView::createFromV8Value):

• src/WebBindings.cpp:

(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

3:51 AM Changeset in webkit [145801] by mkwst@chromium.org

• 3 edits in trunk/Source/WebCore

Explicitly send only one report via XSSAuditorDelegate.
​https://bugs.webkit.org/show_bug.cgi?id=111964

Reviewed by Adam Barth.

This patch pulls the XSSAuditor report generation out into a separate
function in XSSAuditorDelegate::generateViolationReport, and moves the
call to that function into the "have we already notified folks about
violations on this page?" block. This both clarifies the flow in
XSSAuditorDelegate::didBlockScript, and ensures that only one violation
report will be sent per page, which regressed in r145695.

Existing tests verify that reports are generated and sent correctly.

We have no tests for the latter condition: the XSSAuditor tests
currently verify that a report showed up, but they can't verify that
no report appeared without sitting around for a few more than a few
seconds on every run.

• html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::generateViolationReport):

Pull the report generation logic out to this new function.

(WebCore::XSSAuditorDelegate::didBlockScript):

Move the report generation call into the block that ensures it only
executes for the first violation.

3:07 AM Changeset in webkit [145800] by zeno.albisser@digia.com

• 4 edits in trunk/Tools

[Qt] Port DRT to use TestRunner::dumpAsText()
​https://bugs.webkit.org/show_bug.cgi?id=112260

Reviewed by Benjamin Poulain.

• DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::open):
(WebCore::methodNameStringForFailedTest):

Change parameter from type TestRunnerQt* to TestRunner*.

(WebCore::DumpRenderTree::dump):

TestRunnerQt::shouldDumpPixels() always returned true in our case.
Instead we should rely on TestRunner::generatePixelResults().

• DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::reset):

• DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

2:49 AM Changeset in webkit [145799] by zarvai@inf.u-szeged.hu

• 3 edits
  1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening.

• platform/qt-5.0-wk1/TestExpectations: Skip failing tests after r145784.
• platform/qt-5.0-wk2/fast/repaint/focus-ring-expected.txt: Removed.
• platform/qt/fast/repaint/focus-ring-expected.txt: Rebaselining after r145708.

2:43 AM Changeset in webkit [145798] by sergio@webkit.org

• 15 edits
  1 move
  4 adds
  1 delete in trunk

Empty list items after drag&drop in contentEditable divs
​https://bugs.webkit.org/show_bug.cgi?id=110610

Reviewed by Ryosuke Niwa.

Source/WebCore:

Perform a cleanup after moving operations. This will mainly prune
extra placeholders left by the editing algorithms. Also do not
leave empty <li> when moving them around inside a list element.

Tests: editing/pasteboard/cleanup-on-move.html

editing/pasteboard/drag-list-item.html

• editing/MoveSelectionCommand.cpp:

(WebCore::MoveSelectionCommand::doApply): perform
cleanupAfterDeletion().

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::insertAsListItems): do not
insert an empty list item.

• editing/MoveSelectionCommand.cpp:

(WebCore::MoveSelectionCommand::doApply):

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::insertAsListItems):

LayoutTests:

Some placeholders should not be left after performing a cleanup in
move operations, this includes the empty list items generated when
moving around list items inside a list.

I'm also moving drag-list-item.html to editing/pasteboard because
it fits much better there than under editing/selection.

• editing/pasteboard/cleanup-on-move-expected.txt: Added.
• editing/pasteboard/cleanup-on-move.html: Added.
• editing/pasteboard/drag-list-item-expected.txt: Renamed from LayoutTests/editing/selection/drag-list-item-expected.txt.
• editing/pasteboard/drag-list-item.html: Renamed from LayoutTests/editing/selection/drag-list-item.html.
• editing/pasteboard/resources/select-and-drag.js: Added.

(selectAndDragToTarget): Selects nodes and drops them after a target node.

• editing/pasteboard/drag-drop-list-expected.txt: Removed an empty <li>.
• editing/pasteboard/paste-list-004-expected.txt: Removed 2 empty <li>.
• editing/pasteboard/paste-list-004.html: Ditto.
• editing/selection/4895428-1-expected.txt: Removed a <br>.
• editing/selection/4895428-4-expected.txt: Ditto.
• fast/events/ondragenter-expected.txt: Removed a blank line.
• platform/chromium/fast/events/ondragenter-expected.txt: Ditto.
• platform/efl/TestExpectations: Added cleanup-on-move.html to the skipped list.
• platform/mac-wk2/TestExpectations: Ditto.
• platform/qt/TestExpectations: Ditto.
• platform/win/fast/events/ondragenter-expected.txt: Removed a blank line.

2:25 AM Changeset in webkit [145797] by eric@webkit.org

• 11 edits
  5 adds in trunk

Threaded HTML Parser should limit speculation to avoid using too much memory
​https://bugs.webkit.org/show_bug.cgi?id=112069

Reviewed by Adam Barth.

Source/WebCore:

This is a speculative fix for memory issues seen in:
​https://code.google.com/p/chromium/issues/detail?id=180819

This also fixed ​https://bugs.webkit.org/show_bug.cgi?id=110546
as a side-effect of simplifying the m_currentChunk handling.

We now tell the background html parser every time we start
a chunk on the main thread (instead of end), which greatly
simplified the checkpoint cleanup code from:
​https://trac.webkit.org/changeset/145277

The cost for this is now we have more messages going to the
background thread (and postTask acquires a lock to write to the
message queue). Chromium has more advanced (lock-less) primatives
for message posting, which we'll hopefully add to WebKit in
furture patches.

The outstanding chunks limit has not been tuned. But it makes sense that
we should not keeping infinite speculative tokens around for
large documents with slow-to-load scripts.

• html/parser/BackgroundHTMLInputStream.cpp:

(WebCore::BackgroundHTMLInputStream::BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::invalidateCheckpointsBefore):
(WebCore):
(WebCore::BackgroundHTMLInputStream::rewindTo):

• html/parser/BackgroundHTMLInputStream.h:

(BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::outstandingCheckpointCount):
(Checkpoint):
(WebCore::BackgroundHTMLInputStream::Checkpoint::isNull):
(WebCore::BackgroundHTMLInputStream::Checkpoint::clear):

• html/parser/BackgroundHTMLParser.cpp:

(WebCore):
(WebCore::BackgroundHTMLParser::startedChunkWithCheckpoint):
(WebCore::BackgroundHTMLParser::pumpTokenizer):

• html/parser/BackgroundHTMLParser.h:

(BackgroundHTMLParser):

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::validateSpeculations):
(WebCore::HTMLDocumentParser::discardSpeculationsAndResumeFrom):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

• html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

LayoutTests:

Test that this fixes ​https://bugs.webkit.org/show_bug.cgi?id=110546 for the threaded parser.
Ports using the main-thread parser are expected to fail (ASSERT in Debug).

• fast/parser/document-write-partial-entity-before-load-expected.txt: Added.
• fast/parser/document-write-partial-entity-before-load.html: Added.
• fast/parser/external-script-document-write-expected.txt: Added.
• fast/parser/external-script-document-write.html: Added.
• fast/parser/resources/external-script-document-write.js: Added.
• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:
• platform/qt/TestExpectations:

2:00 AM Changeset in webkit [145796] by loislo@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Minor changes for the popover.
​https://bugs.webkit.org/show_bug.cgi?id=112331

Reviewed by Yury Semikhatsky.

popover timeout needs to be decreased a bit.
hidePopover call in onMouseMove doesn't necessary.
We have to keep anchor element unmodified if the hovered item didn't changed.

• inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onMouseMove):

1:57 AM Changeset in webkit [145795] by commit-queue@webkit.org

• 6 edits in trunk/Source

Fix detection of Intel Mac OS X platform on Intel Mac 64-bit
​https://bugs.webkit.org/show_bug.cgi?id=112312

Patch by Jonathan Liu <​net147@gmail.com> on 2013-03-14
Reviewed by Simon Hausmann.

Source/WebCore:

• platform/gtk/UserAgentGtk.cpp:

(WebCore::platformVersionForUAString):

Source/WebKit/efl:

• ewk/ewk_settings.cpp:

(_ewk_settings_webkit_os_version_get):

Source/WebKit/wx:

• WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::agentOS):

1:38 AM Changeset in webkit [145794] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests

Layout Test plugins/plugin-clip-subframe.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=111514

Patch by John Bauman <​jbauman@chromium.org> on 2013-03-14
Reviewed by Ryosuke Niwa.

Rebaseline test result due to chromium r185729. Also try to force
layout in test to prevent flakiness on win-dbg.

• platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt:
• platform/chromium/TestExpectations:
• plugins/plugin-clip-subframe.html:

1:37 AM Changeset in webkit [145793] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Adding a couple of failure expectations for flaky
tests on the debug builder.

• platform/gtk/TestExpectations:

1:18 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

1:16 AM Changeset in webkit [145792] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] InRegionScrollableArea: fix call to visibleContentRect()
​https://bugs.webkit.org/show_bug.cgi?id=112244

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-03-14
Reviewed by Rob Buis.

Since r143295 visibleContentRect() receives an enum, not a boolean.

• WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

12:50 AM Changeset in webkit [145791] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[GTK] The style of visited links doesn't change in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=112175

Reviewed by Martin Robinson.

The problem is that visited links were not tracked by the web
process. There's a web process initial parameter to set whether
web process should track visited links or not and it's disabled by
default.

• UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess): Always set
shouldTrackVisitedLinks to true.

12:38 AM Changeset in webkit [145790] by loislo@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Rewrite drawing procedure for better performance.
​https://bugs.webkit.org/show_bug.cgi?id=112264

Reviewed by Yury Semikhatsky.

I traverses the profile tree in calculateTimelineData and calculates all the sizes and colors.
Later in draw code we lineary pass the array and draw items.
Also we could easily swap to another format of the profile.

• inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._nodeCount):
(WebInspector.FlameChart.prototype._calculateTimelineData.appendReversedArray):
(WebInspector.FlameChart.prototype._calculateTimelineData):
(WebInspector.FlameChart.prototype._getPopoverAnchor):
(WebInspector.FlameChart.prototype._showPopover):
(WebInspector.FlameChart.prototype._hidePopover):
(WebInspector.FlameChart.prototype._onClick):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype.draw):

12:30 AM Changeset in webkit [145789] by alice.liu@apple.com

• 17 edits in trunk/Source

Add to HistoryItem a way to know if its underlying CachedPage has expired.
​https://bugs.webkit.org/show_bug.cgi?id=110652

Reviewed by Brady Eidson.

Source/WebCore:

• WebCore.exp.in: Added WebCore::HistoryItem::isInPageCache and hasCachedPageExpired.
• history/CachedPage.cpp: Add a data member, m_expirationTime, and a function, hasExpired().
• history/CachedPage.h:
• history/HistoryItem.cpp:

(WebCore::HistoryItem::hasCachedPageExpired): Added. returns m_cachedPage's expiration state.

• history/HistoryItem.h:
• history/PageCache.cpp:

(WebCore::PageCache::get): Address the fixme about not using WebKitBackForwardCacheExpirationIntervalKey.

• page/Settings.in: Add backForwardCacheExpirationInterval to the automatically generated setters for Settings.

Source/WebKit/mac:

• History/WebHistoryItem.mm:

(-[WebHistoryItem _isInPageCache]): Added. Just calls and returns core imple's function.
(-[WebHistoryItem _hasCachedPageExpired]): Same thing.

• History/WebHistoryItemPrivate.h:
• WebView/WebPreferences.mm:

(-[WebPreferences _backForwardCacheExpirationInterval]): Address fixme, now that WebCore::Settings
has getters and setters with default value.

• WebView/WebView.mm:

(-[WebView _preferencesChanged:]): call setBackForwardCacheExpirationInterval similar to other settings.

Source/WebKit2:

Hook up hasCachedPageExpired in InjectedBundle's BackForwardListItem.

• WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:

(WKBundleBackForwardListItemHasCachedPageExpired):

• WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
• WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:

(WebKit::InjectedBundleBackForwardListItem::hasCachedPageExpired):