Timeline
Mar 17, 2013:
- 11:40 PM Changeset in webkit [146036] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/inspector/front-end/inspector.css
Merge (partial, css only) 143224 "Web Inspector: hide vertical-sidebar-split in dock..."
Web Inspector: hide vertical-sidebar-split in dock-to-right mode behind single experimental flag.
https://bugs.webkit.org/show_bug.cgi?id=110119
Reviewed by Vsevolod Vlasov.
Removed context menus, made it toggle automatically upon dock orientation change.
- inspector/front-end/inspector.css:
TBR=pfeldman@chromium.org
BUG=196537
Review URL: https://codereview.chromium.org/12895003
- 11:25 PM Changeset in webkit [146035] by
-
- 4 edits in trunk/Source/WebCore
Support Windows HTMLSelectElement keystrokes on Chromium win
https://bugs.webkit.org/show_bug.cgi?id=112460
Reviewed by Kent Tamura.
Compile in the windows-specific variant of
HTMLSelectElement::platformHandleKeydownEvent
on Chromium win, in addition to PLATFORM(WIN).
- WebCore.gypi:
Add html/HTMLSelectElementWin.cpp.
- html/HTMLSelectElement.cpp:
Don't compile generic platformHandleKeydownEvent on
Chromium win.
- html/HTMLSelectElementWin.cpp:
Only compile platformHandleKeydownEvent on Windows.
(WebCore):
- 10:54 PM Changeset in webkit [146034] by
-
- 3 edits in trunk/LayoutTests
Mark some more tests as flakey, or asserting in debug.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 10:51 PM Changeset in webkit [146033] by
-
- 8 edits in trunk
ScriptProcessorNode is garbage collected while still active if unreachable
https://bugs.webkit.org/show_bug.cgi?id=112521
Patch by Russell McClellan <russell.mcclellan@gmail.com> on 2013-03-17
Reviewed by Kentaro Hara.
Source/WebCore:
Fix for issue where ScriptProcessorNodes (and AudioNode js wrappers generally)
would be garbage collected before their time. Made AudioNode an ActiveDOMElement
marked pending if there are any open audio connections.
Test: webaudio/javascriptaudionode.html
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::hasPendingActivity): it's pending (and thus not GCed)
if it has open audio connections.
- Modules/webaudio/AudioNode.h: AudioNode is now an ActiveDOMElement
- Modules/webaudio/AudioScheduledSourceNode.h: added a using declaration
to avoid function name hiding.
- Modules/webaudio/ScriptProcessorNode.idl: AudioNode is an ActiveDOMElement
LayoutTests:
- webaudio/javascriptaudionode-expected.txt:
- webaudio/javascriptaudionode.html:
- 10:26 PM Changeset in webkit [146032] by
-
- 11 edits in trunk
INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of minute/second/millisecond fields should respect min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=112527
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-17
Reviewed by Kent Tamura.
Source/WebCore:
Make step-up/-down of the minute, second, and millisecond field
respect the min/max attributes of the element.
Note that it still accepts any keyboard inputs (the element
becomes 'invalid' state when out-of-range values entered).
Also, disable these fields when there is only single possible value.
Tests: fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html
fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html
- html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Add fields for min/max of minute/second/millisecond.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Set min/max for the fields.
(WebCore::DateTimeEditBuilder::visitField): Pass min/max parameters to the field constructors.
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled): Does not disable if minute, second, millisecond fields are all disabled, because we need at least one editable field.
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldDisabled): Disables if min, max, and value are equal.
(WebCore::DateTimeEditBuilder::shouldMinuteFieldDisabled): Ditto.
(WebCore::DateTimeEditBuilder::shouldSecondFieldDisabled): Ditto.
- html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeHourFieldElementBase::DateTimeHourFieldElementBase):
(WebCore::DateTimeHour11FieldElement::DateTimeHour11FieldElement):
(WebCore::DateTimeHour12FieldElement::DateTimeHour12FieldElement):
(WebCore::DateTimeHour23FieldElement::DateTimeHour23FieldElement):
(WebCore::DateTimeHour24FieldElement::DateTimeHour24FieldElement):
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeWeekFieldElement::DateTimeWeekFieldElement):
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement):
- html/shadow/DateTimeFieldElements.h:
(DateTimeDayFieldElement):
(DateTimeHourFieldElementBase):
(DateTimeHour11FieldElement):
(DateTimeHour12FieldElement):
(DateTimeHour23FieldElement):
(DateTimeHour24FieldElement):
(DateTimeMillisecondFieldElement): Add minimum/maximum parameters.
(DateTimeMinuteFieldElement): Add minimum/maximum parameters.
(DateTimeMonthFieldElement):
(DateTimeSecondFieldElement): Add minimum/maximum parameters.
(DateTimeWeekFieldElement):
(DateTimeYearFieldElement):
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::formatValue): Use hard-limit value instead of m_range.maximum, because millisecond field with max<100 will be displayed in two digits otherwise.
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Changed to have hard limits as a data member.
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
- 8:28 PM Changeset in webkit [146031] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Remove unused WebNode::hasEventListeners API
https://bugs.webkit.org/show_bug.cgi?id=112529
Reviewed by James Robinson.
This API no longer has any callers and can be removed.
- public/WebNode.h:
- src/WebNode.cpp:
- 7:21 PM Changeset in webkit [146030] by
-
- 3 edits in trunk/Source/WebCore
Encapsulate PlatformMessagePortChannel a little better yet
https://bugs.webkit.org/show_bug.cgi?id=112479
Reviewed by Sam Weinig.
- dom/MessagePortChannel.h: We no longer expose PlatformMessagePortChannel in
public functions in cross-platform code.
- dom/default/PlatformMessagePortChannel.cpp:
(WebCore::MessagePortChannel::createChannel): Tweaked the factory method to avoid
using the old create() function.
(WebCore::MessagePortChannel::~MessagePortChannel): Removed an unhelpful comment.
- 6:15 PM WebKitGTK/2.0.x edited by
- (diff)
- 5:38 PM Changeset in webkit [146029] by
-
- 10 edits in trunk
INPUT_MULTIPLE_FIELDS_UI: Don't update shadow tree by updating any attribute
https://bugs.webkit.org/show_bug.cgi?id=111990
Reviewed by Hajime Morrita.
Source/WebCore:
Bug detail:
Typing '1' then '1' into an hour field doesn't set the field to
'11' if an attribute is updated during these two keyboard inputs
because we always re-construct a shadow DOM tree by updating any
attributes and a shadow node records keyboard input state.
How to fix:
We should not re-construct a shadow DOM tree by updating
unaffected attributes. For example, we should re-construct it by
updating 'min' attribute, but we should not by updating 'class'
attribute.
We have InputType::updateInnerTextValue call in parseAttribute for
text field input types. The multiple fields input types
re-construct shadow DOM tree in updateInnerTextValue. The
updateInnerTextValue call is unnecessary for the multiple fields
input types, and we should call it when it is necessary. So, we
add InputType::attributeChange and text field input types call
updateInnerTextValue in it, and other input types don't.
Also, multiple fields input types need to call
updateInnerTextValue by 'value' attribute change. We add
InputType::valueAttributeChanged.
Tests: Update
fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html. The
value attribute change behavior is covered by
time-multiple-fields-change-layout-by-value.html and
time-multiple-fields-spinbutton-change-and-input-events.html.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
- Add a valueAttributeChanged call.
- Calls InputType::attributeChanged
- html/InputType.cpp:
(WebCore::InputType::attributeChanged): Added an empty implementation.
(WebCore::InputType::valueAttributeChanged): Ditto.
- html/InputType.h:
(InputType): Declare attributeChanged and valueAttributeChanged.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::attributeChanged):
Added. Always call updateInnerTextValue.
- html/TextFieldInputType.h:
(TextFieldInputType): Declare attributeChanged.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::valueAttributeChanged):
Added. Re-construct shadow DOM tree if the input has no dirty value.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Declare valueAttributeChanged.
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
- 4:58 PM Changeset in webkit [146028] by
-
- 6 edits in trunk
[HTMLTemplateElement] prevent </template> from matching "template" in a non-HTML tags on the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=112487
Reviewed by Adam Barth.
Source/WebCore:
When processing an end template tag, the parser now pops until a "template" tag is parsed, but now ensures that
the "template" it pops is in the HTML namespace.
Tests added to the html5lib test suite.
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::popUntil):
(WebCore):
(WebCore::HTMLElementStack::popUntilPopped):
- html/parser/HTMLElementStack.h:
(HTMLElementStack):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processTemplateEndTag):
LayoutTests:
- html5lib/resources/template.dat:
- 4:06 PM Changeset in webkit [146027] by
-
- 2 edits in trunk/LayoutTests
fast/frames/flattening/frameset-flattening-subframesets.html is flakey
- platform/mac/TestExpectations:
- 2:40 PM Changeset in webkit [146026] by
-
- 14 edits in trunk/LayoutTests
Add tests for calendar picker month popup
https://bugs.webkit.org/show_bug.cgi?id=112107
Adding tests to check if mouse and keyboard operations work on the month popup.
Reviewed by Kent Tamura.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html:
- platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(clickMonthPopupButton): Clicks the month popup button to open the month popup.
(clickYearListCell): Clicks the year list cell for the given year to reveal the month buttons.
(hoverOverMonthButton): Moves the mouse over to the month button for the given month.
(clickMonthButton): Clicks the month button for the given month.
(checkYearListViewScrollOffset): Checks the year list view scroll offset and returns the difference from the last time it was called.
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations.html:
- 2:39 PM Changeset in webkit [146025] by
-
- 16 edits15 deletes in trunk
Legacy CSS vendor prefixes should only work for Dashboard
https://bugs.webkit.org/show_bug.cgi?id=111890
Reviewed by Eric Seidel.
Source/WebCore:
Our experience with the Chromium port is that these legacy CSS vendor
prefixes (-apple- and -khtml-) are not needed for web compatibility.
There is reason to believe, however, that they are needed for
compatibility with Mac OS X Dashboard widgets.
This patch makes the code for these legacy CSS vendor prefixes
enabled at runtime and only enables them when running in Dashboard
compatibility mode. This is the first step towards the plan outlined in
https://lists.webkit.org/pipermail/webkit-dev/2013-March/024085.html.
This patch also removes support for ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
from the V8 bindings because V8 is never used with Dashboard.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setLegacyCSSVendorPrefixesEnabled):
(WebCore::RuntimeEnabledFeatures::legacyCSSVendorPrefixesEnabled):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::getCSSPropertyNamePrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyInfo):
- css/CSSParser.cpp:
(WebCore::CSSParser::rewriteSpecifiers):
Source/WebKit/mac:
Enable legacy CSS vendor prefixes when we've been asked to turn on
Dashboard compatibility mode.
- WebView/WebView.mm:
(-[WebView _setDashboardBehavior:to:]):
LayoutTests:
- inspector/styles/vendor-prefixes-expected.txt:
- Update results to show our new behavior now that -apple- and -khtml- are not supported.
- platform/mac/TestExpectations:
- Skip a test that is testing that we support -apple- prefixes.
- platform/mac/fast/css/dashboard-region-parser.html:
- Update test to use -webkit- rather than -apple-.
- 1:54 PM Changeset in webkit [146024] by
-
- 2 edits in trunk/LayoutTests
fast/frames/sandboxed-iframe-navigation-allowed.html sometimes
asserts in debug.
- platform/mac/TestExpectations:
- 1:09 PM Changeset in webkit [146023] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r145592): AutodrainedPool.h moved to WTF
<http://webkit.org/b/112171>
Fixes the following build failure:
Source/WebCore/platform/audio/mac/AudioBusMac.mm:32:9: fatal error: 'AutodrainedPool.h' file not found
#import "AutodrainedPool.h"
1 error generated.
- platform/audio/mac/AudioBusMac.mm: Fix include.
- 11:40 AM Changeset in webkit [146022] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectations for the two reftests added in r145982, failing due to disabled subpixel layout.
Triaging/enhancing failure expectations for spellcheck tests after r145940.
- platform/gtk/TestExpectations:
- 11:15 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:13 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:13 AM Changeset in webkit [146021] by
-
- 6 edits in releases/WebKitGTK/webkit-2.0/Source
Merge 146017 - [GTK] Fix and improve dist hooks for translations
https://bugs.webkit.org/show_bug.cgi?id=112519
Reviewed by Carlos Garcia Campos.
Source/WebCore:
- GNUmakefile.am: move translation-related rules and lists to the po directory's
GNUmakefile.am.
Source/WebCore/platform/gtk/po:
- GNUmakefile.am: move dist-related rules here; also move translation-related files
to this file's EXTRA_DIST, making sure to only list the files we actually want
shipped, so junk such as .orig, .rej and backup files do not end up in the tarball.
Source/WebKit/gtk:
- GNUmakefile.am: removed left-over translation files from EXTRA_DIST
- 11:12 AM Changeset in webkit [146020] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge 144990 - Build fix. Fixes problems building code that uses deprecated functions from GTK+ 2,
such as RenderThemeGtk2.cpp, in debug mode. RenderThemeGtk2.cpp tries to allow usage
of deprecated functions by undefining GTK_DISABLE_DEPRECATED, but it ended up being
redefined because autotoolsconfig.h was included again by headers that came after
config.h.
Reviewed by Martin Robinson.
- Source/autotools/SetupWebKitFeatures.m4: add checks to ensure the
autotoolsconfig.h header is only included once.
- 11:11 AM Changeset in webkit [146019] by
-
- 2 edits in trunk/Tools
Add reload button (and F5 accelerator) to the GtkLauncher toolbar
https://bugs.webkit.org/show_bug.cgi?id=112442
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.
- GtkLauncher/main.c:
(reloadCb):
(createToolbar):
(createWindow):
- 11:11 AM Changeset in webkit [146018] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r146011 - [GTK] Invalid charset encoding using when substituting a misspelled word in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112517
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Alexey Proskuryakov.
The problem is that we are creating the WebContextMenuItemData
with the GtkAction label as UTF-8.
- UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::contextMenuItemActivatedCallback): Use String::fromUTF8()
to convert the GtkAction label to UTF-16.
- 11:10 AM Changeset in webkit [146017] by
-
- 6 edits in trunk/Source
[GTK] Fix and improve dist hooks for translations
https://bugs.webkit.org/show_bug.cgi?id=112519
Reviewed by Carlos Garcia Campos.
Source/WebCore:
- GNUmakefile.am: move translation-related rules and lists to the po directory's
GNUmakefile.am.
Source/WebCore/platform/gtk/po:
- GNUmakefile.am: move dist-related rules here; also move translation-related files
to this file's EXTRA_DIST, making sure to only list the files we actually want
shipped, so junk such as .orig, .rej and backup files do not end up in the tarball.
Source/WebKit/gtk:
- GNUmakefile.am: removed left-over translation files from EXTRA_DIST
- 11:06 AM Changeset in webkit [146016] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r146010 - [ENCHANT] Invalid charset encoding used for spelling guess context menu items
https://bugs.webkit.org/show_bug.cgi?id=112516
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.
Convert spelling guesses returned by enchant to UTF-16 before
passing them to WebCore.
- platform/text/enchant/TextCheckerEnchant.cpp:
(WebCore::TextCheckerEnchant::getGuessesForWord): Use
String::fromUTF8().
- 10:22 AM Changeset in webkit [146015] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=97124
Mark a couple of WK2 tests as possibly asserting in debug.
- platform/mac-wk2/TestExpectations:
- 10:14 AM Changeset in webkit [146014] by
-
- 3 edits in trunk/Source/WebCore
Move font-family applying code to StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=112441
Reviewed by Allan Sandfeld Jensen.
Many of the font related properties were moved to StyleBuilder in r87362
two years ago. Move font-family as well so that all font properties are
handled the same way.
No new tests, no change in functionality.
- css/StyleBuilder.cpp:
(ApplyPropertyFontFamily):
(WebCore::ApplyPropertyFontFamily::applyInheritValue):
(WebCore::ApplyPropertyFontFamily::applyInitialValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontFamily::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
Add ApplyPropertyFontFamily for CSSPropertyFontFamily.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Remove CSSPropertyFontFamily from the giant switch statement.
- 10:12 AM Changeset in webkit [146013] by
-
- 2 edits in trunk/Source/Platform
[chromium] Remove the zoom filter operation ifdef
https://bugs.webkit.org/show_bug.cgi?id=112390
Reviewed by Darin Fisher.
This ifdef is not needed once the change that introduced it is
rolled into chromium, and the chromium side guards on the ifdef
are removed. Then it just does nothing and should be deleted.
- chromium/public/WebFilterOperation.h:
- 10:12 AM Changeset in webkit [146012] by
-
- 1 edit in branches/chromium/1441/Source/WebCore/rendering/RenderLayer.cpp
Revert 143825 "RenderLayer::scrollTo() should call FrameLoaderCl..."
RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
https://bugs.webkit.org/show_bug.cgi?id=110673
-and corresponding-
<rdar://problem/13258596>
Reviewed by Sam Weinig.
FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages that
have overflow on the body. We can easily address this by calling it at the
end of RenderLayer::scrollTo().
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
TBR=Beth Dakin
Review URL: https://codereview.chromium.org/12851007
- 9:49 AM Changeset in webkit [146011] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Invalid charset encoding using when substituting a misspelled word in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112517
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Alexey Proskuryakov.
The problem is that we are creating the WebContextMenuItemData
with the GtkAction label as UTF-8.
- UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::contextMenuItemActivatedCallback): Use String::fromUTF8()
to convert the GtkAction label to UTF-16.
- 9:25 AM Changeset in webkit [146010] by
-
- 2 edits in trunk/Source/WebCore
[ENCHANT] Invalid charset encoding used for spelling guess context menu items
https://bugs.webkit.org/show_bug.cgi?id=112516
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.
Convert spelling guesses returned by enchant to UTF-16 before
passing them to WebCore.
- platform/text/enchant/TextCheckerEnchant.cpp:
(WebCore::TextCheckerEnchant::getGuessesForWord): Use
String::fromUTF8().
- 9:21 AM Changeset in webkit [146009] by
-
- 2 edits in trunk/LayoutTests
Mark some more tests as asserting in debug, because of
https://bugs.webkit.org/show_bug.cgi?id=105986
- platform/mac/TestExpectations:
- 9:11 AM Changeset in webkit [146008] by
-
- 2 edits in trunk/LayoutTests
Occasional assertion in JSNPObject::invalidate() running plugins/object-embed-plugin-scripting.html
https://bugs.webkit.org/show_bug.cgi?id=112518
Mark this test as [ Crash Pass ] in debug.
- platform/mac/TestExpectations:
- 9:09 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:09 AM WebKitGTK/2.0.x edited by
- (diff)
- 7:35 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:44 AM Changeset in webkit [146007] by
-
- 3 edits2 adds in trunk/Source/WebCore
[EFL] Provide default cursor groups as cursor.edc
https://bugs.webkit.org/show_bug.cgi?id=112403
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-03-17
Reviewed by Gyuyoung Kim.
This patch provides a cursor.edc to use the CSS cursor images files in the
WebCore/Resources directory. cursor.edc is included in the default.edc
so that views can use it by default.
- platform/efl/DefaultTheme/CMakeLists.txt:
- platform/efl/DefaultTheme/default.edc:
- platform/efl/DefaultTheme/widget/cursor/cursor.edc: Added.
- 2:17 AM WebKitGTK/2.0.x edited by
- (diff)
Mar 16, 2013:
- 11:46 PM Changeset in webkit [146006] by
-
- 8 edits in trunk/Source
Disable High DPI Canvas on iOS
https://bugs.webkit.org/show_bug.cgi?id=112511
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 10:26 PM Changeset in webkit [146005] by
-
- 5 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r145898.
http://trac.webkit.org/changeset/145898
https://bugs.webkit.org/show_bug.cgi?id=112512
Causing flakiness on webkit_unit_tests on android bots on
chromium.webkit and chromium.linux (Requested by jochen on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-16
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::applyScrollAndScale):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp:
- tests/WebViewTest.cpp:
- 2:26 PM Changeset in webkit [146004] by
-
- 2 edits in trunk/LayoutTests
http/tests/notifications/legacy/window-show-on-click.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112499
- platform/mac/TestExpectations:
- 1:47 PM Changeset in webkit [146003] by
-
- 2 edits in trunk/Source/WebKit/chromium
Remove redundant checks from WebInputEvent::isGestureEventType
https://bugs.webkit.org/show_bug.cgi?id=112503
Reviewed by Darin Fisher.
GesturePinchBegin, GesturePinchEnd and GesturePinchUpdate were checked
for twice.
This was found by experimenting with a potential new Clang warning.
- public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):
- 12:43 PM Changeset in webkit [146002] by
-
- 2 edits in trunk/LayoutTests
inspector/elements/highlight-node-scaled.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112502
Mark this test as flakey.
- platform/mac/TestExpectations:
- 12:32 PM Changeset in webkit [146001] by
-
- 2 edits in trunk/Source/WebCore
Reflected video elements hit assertion
https://bugs.webkit.org/show_bug.cgi?id=112490
Disable reflections on video again, since there's some bad behavior
caused by an underlying system framework.
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::clone):
- 12:20 PM Changeset in webkit [146000] by
-
- 2 edits in trunk/LayoutTests
svg/batik/paints/gradientLimit.svg is flakey. Also fix
a couple of recent typos in TestExpectations.
- platform/mac/TestExpectations:
- 12:10 PM Changeset in webkit [145999] by
-
- 2 edits in trunk/LayoutTests
Notification test is flakey
https://bugs.webkit.org/show_bug.cgi?id=112499
- platform/mac/TestExpectations:
- 12:10 PM Changeset in webkit [145998] by
-
- 2 edits in trunk/LayoutTests
Another slow sputnik test.
- platform/mac/TestExpectations:
- 11:19 AM Changeset in webkit [145997] by
-
- 2 edits in trunk/LayoutTests
Fix typos. Also mark fast/frames/flattening/frameset-flattening-advanced.html
as flakey.
- platform/mac/TestExpectations:
- 11:00 AM Changeset in webkit [145996] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=93560
These WebGL tests are flakey on Lion too.
- platform/mac-lion/TestExpectations:
- 10:56 AM Changeset in webkit [145995] by
-
- 2 edits in trunk/LayoutTests
Change fast/events/controlclick-no-onclick.html to be a skip rather than a fail,
since it times out.
- platform/mac-wk2/TestExpectations:
- 10:08 AM Changeset in webkit [145994] by
-
- 3 edits2 adds in trunk
[v8] Disable binding integrity check for WebCore::Text
https://bugs.webkit.org/show_bug.cgi?id=112462
Reviewed by Kentaro Hara.
Source/WebCore:
Test: fast/dom/split-cdata.xml
- dom/Text.idl:
LayoutTests:
- fast/dom/split-cdata-expected.txt: Added.
- fast/dom/split-cdata.xml: Added.
- 9:43 AM Changeset in webkit [145993] by
-
- 2 edits10 adds2 deletes in trunk/LayoutTests
fast/frames/sandboxed-iframe-scripting is flakey
https://bugs.webkit.org/show_bug.cgi?id=112482
Reviewed by Simon Fraser.
Tests that rely on multiple 'iframe' elements loading in a specific
order are a Bad Idea™. This patch splits
'fast/frames/sandboxed-iframe-scripting.html' out into five tests, and
changes two of them (#2 and #4) to use message passing in order to
test in a way that 'js-test-{pre,post}' can cleanly report.
- fast/frames/sandboxed-iframe-scripting-01-expected.txt: Added.
- fast/frames/sandboxed-iframe-scripting-01.html: Added.
- fast/frames/sandboxed-iframe-scripting-02-expected.txt: Added.
- fast/frames/sandboxed-iframe-scripting-02.html: Added.
- fast/frames/sandboxed-iframe-scripting-03-expected.txt: Added.
- fast/frames/sandboxed-iframe-scripting-03.html: Added.
- fast/frames/sandboxed-iframe-scripting-04-expected.txt: Added.
- fast/frames/sandboxed-iframe-scripting-04.html: Added.
- fast/frames/sandboxed-iframe-scripting-05-expected.txt: Added.
- fast/frames/sandboxed-iframe-scripting-05.html: Added.
- fast/frames/sandboxed-iframe-scripting-expected.txt: Removed.
- fast/frames/sandboxed-iframe-scripting.html: Removed.
- platform/mac/TestExpectations:
Remove the skipped test, since it no longer exists.
- 9:41 AM Changeset in webkit [145992] by
-
- 2 edits in trunk/LayoutTests
Update test expectations for content shell.
Unreviewed gardening.
- platform/chromium/ContentShellTestExpectations:
- 8:50 AM Changeset in webkit [145991] by
-
- 2 edits in trunk/LayoutTests
Mark some ref tests as failing on Lion.
- platform/mac-lion/TestExpectations:
- 8:45 AM Changeset in webkit [145990] by
-
- 2 edits in trunk/LayoutTests
Mark some more sputnik tests as slow in debug.
- platform/mac/TestExpectations:
- 7:26 AM BadContent edited by
- Blacklist a spamming account. (diff)
- 4:21 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:18 AM Changeset in webkit [145989] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r145808 - [GTK] Wrong ASSERT in AudioDestinationGstreamer::stop
https://bugs.webkit.org/show_bug.cgi?id=112344
Patch by Xan Lopez <xlopez@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.
Correct erroneous ASSERT, we want both member variables to exist.
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::stop):
- 1:51 AM Changeset in webkit [145988] by
-
- 27 edits2 adds in trunk
AX: aria-hidden on container does not hide descendant popup buttons
https://bugs.webkit.org/show_bug.cgi?id=112373
Reviewed by Ryosuke Niwa.
Source/WebCore:
There are a number of subclass AX objects that implement accessibilityIsIgnored()
to always return false. This means that even if their parent is aria-hidden=true
they still show up in the tree.
This re-organizes this base case of aria-hidden into AccessibilityObject so that
it can be re-used by these special subclasses where appropriate.
Test: accessibility/aria-hidden-hides-all-elements.html
- accessibility/AccessibilityImageMapLink.h:
(WebCore::AccessibilityImageMapLink::isImageMapLink):
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::computeAccessibilityIsIgnored):
- accessibility/AccessibilityListBox.cpp:
(WebCore):
- accessibility/AccessibilityListBox.h:
(AccessibilityListBox):
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaControlsContainer::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMediaControls.h:
(AccessibilityMediaControlsContainer):
- accessibility/AccessibilityMenuList.h:
(WebCore::AccessibilityMenuList::roleValue):
- accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMockObject.cpp:
(WebCore::AccessibilityMockObject::computeAccessibilityIsIgnored):
(WebCore):
- accessibility/AccessibilityMockObject.h:
(AccessibilityMockObject):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::accessibilityIsIgnoredDefaultForObject):
(WebCore):
(WebCore::AccessibilityObject::ariaIsHidden):
(WebCore::AccessibilityObject::accessibilityIsIgnoredBase):
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
- accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::computeAccessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/AccessibilityScrollbar.h:
(AccessibilityScrollbar):
- accessibility/AccessibilitySlider.cpp:
(WebCore):
(WebCore::AccessibilitySliderThumb::computeAccessibilityIsIgnored):
- accessibility/AccessibilitySlider.h:
(AccessibilitySlider):
- accessibility/AccessibilitySpinButton.h:
(WebCore::AccessibilitySpinButton::roleValue):
(AccessibilitySpinButtonPart):
LayoutTests:
- accessibility/aria-hidden-hides-all-elements-expected.txt: Added.
- accessibility/aria-hidden-hides-all-elements.html: Added.
- 12:43 AM Changeset in webkit [145987] by
-
- 1 edit4 adds1 delete in trunk/LayoutTests
Mac rebaseline after r145977.
- platform/chromium-mac/platform/mac/fast: Added.
- platform/chromium-mac/platform/mac/fast/forms: Added.
- platform/chromium-mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
- platform/chromium/platform/mac/fast/forms: Removed.
- platform/chromium/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Removed.
- platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
