Timeline
Mar 21, 2013:
- 11:16 PM Changeset in webkit [146565] by
-
- 24 edits14 adds in trunk
Custom Elements: "readyCallback" lifecycle callback should be called.
https://bugs.webkit.org/show_bug.cgi?id=112538
Reviewed by Elliott Sprehn.
Source/WebCore:
This change allows each custom element definition to hook up its instantiation,
namely "readyCallback" lifecycle callback.
The change has two parts:
- 1. Tracking which Element objects to be created.
- 2. Invoking appropriate JavaScript functions, which are readyCallback(), before the Element object is visible from page script.
For 1, CustomElementRegistry maintains list of "callback
invocaions". Each list item ("invocation") tracks the element
which has a lifecycle callback to be invoked. Each invocation is
registered when - Any custom element C++ object is instantiated.
See changes on CustomElementConstructor.cpp.
This also happens when @is attribute is set by the parser or node
cloning routine, which can turn a non-custom element into a
type-extended custom element. See changes on Element.cpp.
For 2, CustomElementRegistry basically follows what
MutationObserver is doing, and introduces a method called
deliverLifecycleCallbacks(). This function flushes all pending
callback invocations. You can think it as a dual of
MutationObserver::deliverAllMutations().
The delivery function is called places where MutationObserver's
deliverAllMutations() is called. In addition, it is also called
just before returning from a set of DOM APIs. For example, it is
called just before createElement() returns, so that possibly
created custom element becomes ready through its readyCallback().
Such APIs get "V8DeliverCustomElementCallbacks" IDL attribute. In
principle, APIs which can create new custom element instnaces are
marked. See CustomElementRegistry::CallbackDeliveryScope and
changes on CodeGeneratorV8.pm.
We need this extra work because the readyCallback() needs to give
an illusion so that JavaScript programmers feel like the
readyCallback() callback being called just after it is created,
instead of called on arbitrary late timing like MutationObserver
notifications.
Tests: fast/dom/custom/lifecycle-ready-createElement-recursion.html
fast/dom/custom/lifecycle-ready-createElement-reentrancy.html
fast/dom/custom/lifecycle-ready-creation-api.html
fast/dom/custom/lifecycle-ready-innerHTML.html
fast/dom/custom/lifecycle-ready-parser-only.html
fast/dom/custom/lifecycle-ready-parser-script.html
fast/dom/custom/lifecycle-ready-paste.html
- bindings/scripts/CodeGeneratorV8.pm:
- Hooked up CallbackDeliveryScope through V8DeliverCustomElementCallbacks attriute.
(GenerateCustomElementInvocationScopeIfNeeded):
(GenerateNormalAttrSetter):
(GenerateFunction):
- bindings/scripts/IDLAttributes.txt:
- bindings/v8/CustomElementHelpers.cpp:
(WebCore::CustomElementHelpers::invokeReadyCallbackIfNeeded):
(WebCore::CustomElementHelpers::invokeReadyCallbacksIfNeeded):
- bindings/v8/CustomElementHelpers.h:
(CustomElementHelpers):
- bindings/v8/V8RecursionScope.cpp: Added deliverAllLifecycleCallbacks()
(WebCore::V8RecursionScope::didLeaveScriptContext):
- dom/CustomElementConstructor.cpp:
(WebCore::CustomElementConstructor::createElement):
(WebCore::CustomElementConstructor::createElementInternal):
- dom/CustomElementConstructor.h:
(WebCore::CustomElementConstructor::isExtended):
(CustomElementConstructor):
- dom/CustomElementRegistry.cpp: Adding element tracking and invocation execution.
(WebCore::CustomElementInvocation::CustomElementInvocation):
(WebCore::CustomElementInvocation::~CustomElementInvocation):
(WebCore::activeCustomElementRegistries):
(WebCore::CustomElementRegistry::~CustomElementRegistry):
(WebCore::CustomElementRegistry::didGiveTypeExtension):
(WebCore::CustomElementRegistry::didCreateElement):
(WebCore::CustomElementRegistry::activate):
(WebCore::CustomElementRegistry::deactivate):
(WebCore::CustomElementRegistry::deliverLifecycleCallbacks):
(WebCore::CustomElementRegistry::deliverAllLifecycleCallbacks):
- dom/CustomElementRegistry.h:
(CustomElementInvocation):
(WebCore::CustomElementInvocation::element):
(CallbackDeliveryScope):
(WebCore::CustomElementRegistry::CallbackDeliveryScope::CallbackDeliveryScope):
(WebCore::CustomElementRegistry::CallbackDeliveryScope::~CallbackDeliveryScope):
(CustomElementRegistry):
(WebCore::CustomElementRegistry::deliverAllLifecycleCallbacksIfNeeded):
- dom/Document.cpp:
(WebCore::Document::createElement):
(WebCore::Document::didCreateCustomElement):
- dom/Document.h:
(Document):
- dom/Document.idl:
- dom/Element.cpp:
(WebCore::Element::attributeChangedFromParserOrByCloning): Added to catch @is attribute
(WebCore::Element::parserSetAttributes):
(WebCore::Element::cloneAttributesFromElement):
- dom/Element.h:
- dom/Node.idl:
- dom/ShadowRoot.idl:
- html/HTMLElement.idl:
- html/parser/HTMLScriptRunner.cpp: Added deliverAllLifecycleCallbacks()
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::runScript):
Source/WebKit/chromium:
- src/WebKit.cpp: Added deliverAllLifecycleCallbacks()
Source/WTF:
- wtf/HashSet.h:
(WTF::copyToVector): Generalized to let it accept variants like ListHahsSet instead of only HashSet.
LayoutTests:
- fast/dom/custom/lifecycle-ready-createElement-recursion-expected.txt: Added.
- fast/dom/custom/lifecycle-ready-createElement-recursion.html: Added.
- fast/dom/custom/lifecycle-ready-createElement-reentrancy-expected.txt: Added.
- fast/dom/custom/lifecycle-ready-createElement-reentrancy.html: Added.
- fast/dom/custom/lifecycle-ready-creation-api-expected.txt: Added.
- fast/dom/custom/lifecycle-ready-creation-api.html: Added.
- fast/dom/custom/lifecycle-ready-innerHTML-expected.txt: Added.
- fast/dom/custom/lifecycle-ready-innerHTML.html: Added.
- fast/dom/custom/lifecycle-ready-parser-only-expected.html: Added.
- fast/dom/custom/lifecycle-ready-parser-only.html: Added.
- fast/dom/custom/lifecycle-ready-parser-script-expected.txt: Added.
- fast/dom/custom/lifecycle-ready-parser-script.html: Added.
- fast/dom/custom/lifecycle-ready-paste-expected.txt: Added.
- fast/dom/custom/lifecycle-ready-paste.html: Added.
- 11:05 PM Changeset in webkit [146564] by
-
- 5 edits in trunk/LayoutTests
Yet another Mac rebaseline attempt for r146531 since r146538 and r146554 didn't work.
- platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/mac/compositing/rtl/rtl-fixed-expected.txt:
- platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt:
- 10:50 PM Changeset in webkit [146563] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::MediaPlayer::cachedResourceLoader + 4
https://bugs.webkit.org/show_bug.cgi?id=112977
Reviewed by Geoffrey Garen.
Speculative fix for a NULL-dereference crash. MediaPlayerPrivateAVFoundationObjC is the
sole owner of a WebCoreAVFLoaderDelegate instance. It releases this instance in its destructor,
but it is possible that, on another thread, the AVAssetResourceLoader has already begun
using the delegate and in so doing has retained it. By the time the delegate method is fired
on the main thread, the MediaPlayerPrivateAVFoundationObjC owner of the delegate has already
been deleted, and the delegate's m_callback pointer is now pointing at freed memory.
In addition to calling -[AVAssetResourceLoader setDelegate:queue:] to avoid any not-yet-started
delegate callbacks, MediaPlayerPrivateAVFoundationObjC should clear the WebCoreAVFLoaderDelegate
m_callback ivar, to avoid calling into freed memory for already queued delegate callbacks.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): Clear the m_loaderDelegate's callback pointer.
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]): Check the value of m_callback before continuing.
(-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]): Ditto.
(-[WebCoreAVFLoaderDelegate setCallback:]): Added simple setter.
- 10:22 PM Changeset in webkit [146562] by
-
- 3 edits2 adds in trunk
XMLDocumentParser doesn't parse <template> correctly.
https://bugs.webkit.org/show_bug.cgi?id=112328
Reviewed by Hajime Morrita.
Source/WebCore:
XMLDocumentParser should check whether a parent node is attached or not
when a new element is appended.
Test: fast/dom/HTMLTemplateElement/xhtml-with-titleElement-parsing-crash.xhtml
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
m_currentNode is a parent node of newElement, but it is updated by
pushCurrentNode. So firstly stored copied m_curretNode's value into
local currentNode and used the currentNode to check whether
newElement's parent is attached or not.
LayoutTests:
- fast/dom/HTMLTemplateElement/xhtml-with-titleElement-parsing-crash-expected.txt: Added.
- fast/dom/HTMLTemplateElement/xhtml-with-titleElement-parsing-crash.xhtml: Added.
- 9:58 PM Changeset in webkit [146561] by
-
- 4 edits in trunk/Source
Unreviewed, rolling out r146560.
http://trac.webkit.org/changeset/146560
https://bugs.webkit.org/show_bug.cgi?id=112862
invalid parameter to histogram
Source/Platform:
- chromium/public/Platform.h:
Source/WebCore:
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::open):
- 9:03 PM Changeset in webkit [146560] by
-
- 4 edits in trunk/Source
IndexedDB: Histogram available disk space on attempt to open database
https://bugs.webkit.org/show_bug.cgi?id=112862
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/Platform.h:
(WebKit::Platform::availableDiskSpaceInBytes):
(Platform):
Source/WebCore:
ChromeOS suspects they might be hitting disk corruption when the disks
are nearly full. This patch logs the available space to either the
"success" or the "fail" histogram as appropriate so that the
distributions can be compared.
No new tests - I don't know of a good way to test histograms. Local
printf testing didn't turn up any bugs.
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::HistogramFreeSpace):
(WebCore):
(WebCore::LevelDBDatabase::open):
- 8:48 PM Changeset in webkit [146559] by
-
- 6 edits in trunk/Tools
nrwt is no longer saving retry results in the retries/ subdirectory
https://bugs.webkit.org/show_bug.cgi?id=112995
Reviewed by Ojan Vafai.
I think this has been broken a long time, unfortunately. This
patch should fix that.
In order to do so, I had to pass the directory to use from
the Worker object through the SingleTestWriter to the
TestResultWriter. While I was plumbing that through, I rationalized
the order of the parameter arguments a bit ...
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(Worker._run_single_test):
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(run_single_test):
(SingleTestRunner.init):
(SingleTestRunner._run_compare_test):
(SingleTestRunner._run_rebaseline):
(SingleTestRunner._run_reftest):
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
- Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
(TestResultWriterTest.test_reftest_diff_image):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_retrying_uses_retries_directory):
- 8:12 PM Changeset in webkit [146558] by
-
- 11 edits in trunk/Source/JavaScriptCore
Objective-C API: Need a good way to preserve custom properties on JS wrappers
https://bugs.webkit.org/show_bug.cgi?id=112608
Reviewed by Geoffrey Garen.
Currently, we just use a weak map, which means that garbage collection can cause a wrapper to
disappear if it isn't directly exported to JavaScript.
The most straightforward and safe way (with respect to garbage collection and concurrency) is to have
clients add and remove their external references along with their owners. Effectively, the client is
recording the structure of the external object graph so that the garbage collector can make sure to
mark any wrappers that are reachable through either the JS object graph of the external Obj-C object
graph. By keeping these wrappers alive, this has the effect that custom properties on these wrappers
will also remain alive.
The rule for if an object needs to be tracked by the runtime (and therefore whether the client should report it) is as follows:
For a particular object, its references to its children should be added if:
- The child is referenced from JavaScript.
- The child contains references to other objects for which (1) or (2) are true.
- API/JSAPIWrapperObject.mm:
(JSAPIWrapperObjectHandleOwner::finalize):
(JSAPIWrapperObjectHandleOwner::isReachableFromOpaqueRoots): A wrapper object is kept alive only if its JSGlobalObject
is marked and its corresponding Objective-C object was added to the set of opaque roots.
(JSC::JSAPIWrapperObject::visitChildren): We now call out to scanExternalObjectGraph, which handles adding all Objective-C
objects to the set of opaque roots.
- API/JSAPIWrapperObject.h:
(JSAPIWrapperObject):
- API/JSContext.mm: Moved dealloc to its proper place in the main implementation.
(-[JSContext dealloc]):
- API/JSVirtualMachine.h:
- API/JSVirtualMachine.mm:
(-[JSVirtualMachine initWithContextGroupRef:]):
(-[JSVirtualMachine dealloc]):
(getInternalObjcObject): Helper funciton to get the Objective-C object out of JSManagedValues or JSValues if there is one.
(-[JSVirtualMachine addManagedReference:withOwner:]): Adds the Objective-C object to the set of objects
owned by the owner object in that particular virtual machine.
(-[JSVirtualMachine removeManagedReference:withOwner:]): Removes the relationship between the two objects.
(-[JSVirtualMachine externalObjectGraph]):
(scanExternalObjectGraph): Does a depth-first search of the external object graph in a particular virtual machine starting at
the specified root. Each new object it encounters it adds to the set of opaque roots. These opaque roots will keep their
corresponding wrapper objects alive if they have them.
- API/JSManagedReferenceInternal.h: Added.
- API/JSVirtualMachine.mm: Added the per-JSVirtualMachine map between objects and the objects they own, which is more formally
known as that virtual machine's external object graph.
- API/JSWrapperMap.mm:
(-[JSWrapperMap dealloc]): We were leaking this before :-(
(-[JSVirtualMachine initWithContextGroupRef:]):
(-[JSVirtualMachine dealloc]):
(-[JSVirtualMachine externalObjectGraph]):
- API/JSVirtualMachineInternal.h:
- API/tests/testapi.mm: Added two new tests using the TinyDOMNode class. The first tests that a custom property added to a wrapper
doesn't vanish after GC, even though that wrapper isn't directly accessible to the JS garbage collector but is accessible through
the external Objective-C object graph. The second test makes sure that adding an object to the external object graph with the same
owner doesn't cause any sort of problems.
(+[TinyDOMNode sharedVirtualMachine]):
(-[TinyDOMNode init]):
(-[TinyDOMNode dealloc]):
(-[TinyDOMNode appendChild:]):
(-[TinyDOMNode numberOfChildren]):
(-[TinyDOMNode childAtIndex:]):
(-[TinyDOMNode removeChildAtIndex:]):
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/SlotVisitor.h:
(SlotVisitor):
- heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::containsOpaqueRootTriState): Added a new method to SlotVisitor to allow scanExternalObjectGraph to have a
thread-safe view of opaque roots during parallel marking. The set of opaque roots available to any one SlotVisitor isn't guaranteed
to be 100% correct, but that just results in a small duplication of work in scanExternalObjectGraph. To indicate this change for
false negatives we return a TriState that's either true or mixed, but never false.
- 8:11 PM Changeset in webkit [146557] by
-
- 8 edits in trunk
FileAPI: Remove deprecation warning when ArrayBuffer is in Blob constructor.
https://bugs.webkit.org/show_bug.cgi?id=88389
Reviewed by Kenneth Russell.
Source/WebCore:
Spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob
Both ArrayBuffer and ArrayBufferView should be supported for Blob constructor.
Test: fast/files/blob-constructor.html.
- bindings/js/JSBlobCustom.cpp:
(WebCore::JSBlobConstructor::constructJSBlob):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCustom):
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::BlobBuilder::append): Remove the deprecated warning.
- fileapi/WebKitBlobBuilder.h:
(WebCore):
(BlobBuilder):
LayoutTests:
- fast/files/blob-constructor-expected.txt:
- fast/files/script-tests/blob-constructor.js:
- 8:02 PM Changeset in webkit [146556] by
-
- 3 edits2 adds in trunk
[Shadow]: @host styles are not applied dynamically
https://bugs.webkit.org/show_bug.cgi?id=112869
Reviewed by Elliott Sprehn.
Source/WebCore:
Need to add features of @host @-rules to rule feature set.
Test: fast/dom/shadow/athost-apply-dynamically.html
- css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::collectFeaturesTo):
LayoutTests:
- fast/dom/shadow/athost-apply-dynamically-expected.html: Added.
- fast/dom/shadow/athost-apply-dynamically.html: Added.
- 8:00 PM Changeset in webkit [146555] by
-
- 6 edits2 adds in trunk
[Shadow] Provide an api of insertionParent().
https://bugs.webkit.org/show_bug.cgi?id=112866
Source/WebCore:
Add insertinParent binding to Element and Text.
It's prefixed (webkitInsertionParent) and guarded by SHADOW_DOM flag.
The bug in the Shadow DOM spec is here:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=21067
Reviewed by Dimitri Glazkov.
Test: fast/dom/shadow/insertion-parent.html
- dom/Element.idl:
- dom/Node.cpp:
(WebCore::Node::insertionParentForBinding):
(WebCore):
- dom/Node.h:
(Node):
- dom/Text.idl:
LayoutTests:
Reviewed by Dimitri Glazkov.
- fast/dom/shadow/insertion-parent-expected.txt: Added.
- fast/dom/shadow/insertion-parent.html: Added.
- 7:23 PM Changeset in webkit [146554] by
-
- 5 edits in trunk/LayoutTests
Another Mac rebaseline attempt for r146531 since r146538 didn't work.
- platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/mac/compositing/rtl/rtl-fixed-expected.txt:
- platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt:
- 7:02 PM Changeset in webkit [146553] by
-
- 2 edits in trunk/LayoutTests
[chromium] Test expectations updates.
https://bugs.webkit.org/show_bug.cgi?id=88833
https://bugs.webkit.org/show_bug.cgi?id=107935
https://bugs.webkit.org/show_bug.cgi?id=109507
Unreviewed, test expectations updates.
- platform/chromium/TestExpectations:
- 6:56 PM Changeset in webkit [146552] by
-
- 12 edits in trunk/Source
Source/JavaScriptCore: Fix O(n2) op_debug bytecode charPosition to column computation.
https://bugs.webkit.org/show_bug.cgi?id=112957.
Reviewed by Geoffrey Garen.
The previous algorithm does a linear reverse scan of the source string
to find the line start for any given char position. This results in a
O(n2) algortithm when the source string has no line breaks.
The new algorithm computes a line start column table for a
SourceProvider on first use. This line start table is used to fix up
op_debug's charPosition operand into a column operand when an
UnlinkedCodeBlock is linked into a CodeBlock. The initialization of
the line start table is O(n), and the CodeBlock column fix up is
O(log(n)).
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock): - do column fix up.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::debug): - no need to do column fixup anymore.
- interpreter/Interpreter.h:
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- parser/SourceProvider.cpp:
(JSC::SourceProvider::lineStarts):
(JSC::charPositionExtractor):
(JSC::SourceProvider::charPositionToColumnNumber):
- initialize line start column table if needed.
- look up line start for the given char position.
- parser/SourceProvider.h:
Source/WTF: Introducing String::findNextLineStart().
https://bugs.webkit.org/show_bug.cgi?id=112957.
Reviewed by Geoffrey Garen.
This is replaces String::reverseFindLineTerminator() in the JSC
debugger's code for computing column numbers.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::findNextLineStart):
- wtf/text/StringImpl.h:
(WTF::findNextLineStart):
- wtf/text/WTFString.h:
(WTF::String::findNextLineStart):
- 6:39 PM Changeset in webkit [146551] by
-
- 5 edits in trunk/Source/WebKit2
[wk2] Page Overlays: Don't create backing store until the client asks us to paint
https://bugs.webkit.org/show_bug.cgi?id=112989
<rdar://problem/13355759>
Reviewed by Anders Carlsson.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight):
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):
Invalidate the entire overlay on installation, to maintain existing behavior
on platforms where the fade-in animation is not performed by invalidating the overlay.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::installPageOverlay):
Don't invalidate the overlay upon installation.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
Create backing store for the page overlay layer the first time it is painted into.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Don't update the size of the page overlay layer unless we intend for it to have backing store.
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
Don't create backing store when we create the page overlay layer.
- 6:32 PM Changeset in webkit [146550] by
-
- 2 edits in trunk/Source/WebKit/win
WinCairo build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=112892
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-03-21
Reviewed by Kentaro Hara.
- WebKit.vcproj/WebKitExports.def.in: Added ENABLE(VIDEO_TRACK) guard.
- 6:26 PM Changeset in webkit [146549] by
-
- 3 edits2 adds in trunk
Bypass XSSAuditor for asp.net servers.
https://bugs.webkit.org/show_bug.cgi?id=112235
Reviewed by Adam Barth.
Source/WebCore:
Similar to https://bugs.webkit.org/show_bug.cgi?id=81283, but the
fix to that bug failed to cover this particular comma-splicing case.
Test: http/tests/security/xssAuditor/img-tag-with-comma.html
- html/parser/XSSAuditor.cpp:
(WebCore::isTerminatingCharacter):
Beware of comma-splicing tricks by stopping at commas.
LayoutTests:
- http/tests/security/xssAuditor/img-tag-with-comma-expected.txt: Added.
- http/tests/security/xssAuditor/img-tag-with-comma.html: Added.
- 6:17 PM Changeset in webkit [146548] by
-
- 7 edits in trunk
JSC profiler should have an at-a-glance report of the success of DFG optimization
https://bugs.webkit.org/show_bug.cgi?id=112988
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
- profiler/ProfilerCompilation.cpp:
(JSC::Profiler::Compilation::Compilation):
(JSC::Profiler::Compilation::toJS):
- profiler/ProfilerCompilation.h:
(JSC::Profiler::Compilation::noticeInlinedGetById):
(JSC::Profiler::Compilation::noticeInlinedPutById):
(JSC::Profiler::Compilation::noticeInlinedCall):
(Compilation):
- runtime/CommonIdentifiers.h:
Tools:
- Scripts/display-profiler-output:
- 5:58 PM Changeset in webkit [146547] by
-
- 2 edits in trunk/LayoutTests
[chromium] Test expectations updates: mark flaky tests; fix overlapping expectations; convert [ Pass Slow ] to [ Slow ].
https://bugs.webkit.org/show_bug.cgi?id=88833
https://bugs.webkit.org/show_bug.cgi?id=93569
https://bugs.webkit.org/show_bug.cgi?id=109507
https://bugs.webkit.org/show_bug.cgi?id=112980
https://bugs.webkit.org/show_bug.cgi?id=112981
https://bugs.webkit.org/show_bug.cgi?id=112984
https://bugs.webkit.org/show_bug.cgi?id=112987
http://crbug.com/24182
Unreviewed, test expectations updates.
- platform/chromium/TestExpectations:
- 5:25 PM Changeset in webkit [146546] by
-
- 3 edits in trunk/Tools
[chromium] Linux ASAN WebKit canary is running out of memory
https://bugs.webkit.org/show_bug.cgi?id=112978
Reviewed by Tony Chang.
Running the AddressSanitizer on a crash takes a lot of
memory, so we should serialize access to it to avoid running
out of memory on a machine.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._get_crash_log):
- Scripts/webkitpy/layout_tests/port/http_lock.py:
(HttpLock.init):
(HttpLock.wait_for_httpd_lock):
- 5:14 PM Changeset in webkit [146545] by
-
- 1 edit2 adds in trunk/LayoutTests
Add Mac baseline after r146510.
- platform/mac/svg/custom/marker-orient-auto-expected.png: Added.
- platform/mac/svg/custom/marker-orient-auto-expected.txt: Added.
- 5:14 PM Changeset in webkit [146544] by
-
- 21 edits in trunk/Source
If a previously loaded resource is later stored to the disk cache, replace the buffer with MMAP'ed memory.
<rdar://problem/13414154> and https://bugs.webkit.org/show_bug.cgi?id=112943
Reviewed by Geoff Garen.
Source/WebCore:
No new tests (No change in behavior.)
Give SharedBuffer the ability to replace its contents from another SharedBuffer:
- platform/SharedBuffer.h:
- platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer:: tryReplaceContentsWithPlatformBuffer):
Forward along SharedBuffer's new ability to ResourceBuffer:
- loader/mac/ResourceBuffer.mm:
(WebCore::ResourceBuffer:: tryReplaceSharedBufferContents):
- loader/ResourceBuffer.h:
Give CachedResource the ability to replace its encoded data buffer if appropriate:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource:: tryReplaceEncodedData):
- loader/cache/CachedResource.h:
- WebCore.exp.in:
Source/WebKit2:
Add a timer that will try to look up the disk cached buffer for the resource a few seconds after the load
completes and - if the resource is disk backed - send it to the WebProcess for sharing:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::diskCacheTimerFired):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didReceiveData):
(WebKit::NetworkResourceLoader::didFinishLoading):
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(WebKit::NetworkResourceLoader::tryGetShareableHandleForResource):
Refactor SharedMemory to remove the unnecessary vm_copy and only vm_allocate when an appropriate buffer
doesn't already exist:
- Platform/SharedMemory.h:
- Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::create):
(WebKit::SharedMemory::createFromVMBuffer):
(WebKit::SharedMemory::~SharedMemory):
Give ShareableResource the ability to create a CFDataRef that wraps "this", and return it in a SharedBuffer:
- Shared/ShareableResource.cpp:
(WebKit::shareableResourceDeallocate):
(WebKit::createShareableResourceDeallocator):
(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):
- Shared/ShareableResource.h:
- Shared/WebCoreArgumentCoders.cpp: Encode/decode the cache partition for ResourceRequest.
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didCacheResource): Lookup the CachedResource in the WebCore memory cache
and try to replace its encoded data with the shared mmap'ed buffer.
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Network/NetworkProcessConnection.messages.in:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResource):
- 5:08 PM Changeset in webkit [146543] by
-
- 4 edits5 adds in trunk/LayoutTests
[Mac] Add baselines for css3/filters/effect-reference*.html
https://bugs.webkit.org/show_bug.cgi?id=112962
Reviewed by Dean Jackson.
Add Mac rebaselines for the following tests and removed the corresponding entries in TestExpectations.
- platform/mac/TestExpectations:
- platform/mac/css3/filters/effect-reference-expected.png: Added.
- platform/mac/css3/filters/effect-reference-expected.txt:
- platform/mac/css3/filters/effect-reference-external-expected.png: Added.
- platform/mac/css3/filters/effect-reference-hw-expected.png: Added.
- platform/mac/css3/filters/effect-reference-hw-expected.txt:
- platform/mac/css3/filters/effect-reference-ordering-expected.png: Added.
- platform/mac/css3/filters/effect-reference-ordering-hw-expected.png: Added.
- 5:04 PM Changeset in webkit [146542] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix, forgot to stage one file.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::didChangeScrollOffsetForAnyFrame):
(DrawingArea):
- 4:58 PM Changeset in webkit [146541] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Suppressed text failures due to r146531.
- platform/chromium/TestExpectations:
- 4:52 PM Changeset in webkit [146540] by
-
- 4 edits in trunk/Source/WebCore
IndexedDB: Ensure script wrappers can be collected after context is stopped
https://bugs.webkit.org/show_bug.cgi?id=112976
Reviewed by Adam Barth.
ActiveDOMObject::hasPendingActivity is called to see if script wrappers
can be disposed of. Once the script execution context has stopped they
should be free to go - include this in the checks.
No new tests - suggestions welcome.
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::hasPendingActivity): Return false if stopped.
(WebCore::IDBDatabase::stop): Don't bother calling empty super impl.
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::hasPendingActivity): Return false if stopped.
(WebCore::IDBRequest::stop): Don't bother calling empty super impl.
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::hasPendingActivity): Return false if stopped.
(WebCore::IDBTransaction::stop): Don't bother calling empty super impl.
- 4:47 PM Changeset in webkit [146539] by
-
- 4 edits in trunk/Source/WebKit2
[wk2] Page overlays shouldn't dirty the entire layer when flushing if the main frame can't scroll
https://bugs.webkit.org/show_bug.cgi?id=111662
<rdar://problem/13355808>
Reviewed by Dean Jackson.
Instead of setNeedsDisplay()ing the whole page overlay layer every time through
TCADA::flushLayers, do it at scroll time instead. Repainting on scroll is
necessary to keep things painted in the right place when we scroll (the overlay
is fixed to the size of the view), but is quite wasteful in apps that don’t scroll.
This works with threaded scrolling because overlay installation forces us
into main-thread scrolling mode.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didChangeScrollOffset):
Plumb scroll offset changes through to the drawing area, so it can invalidate the page overlay.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
Add didChangeScrollOffsetForAnyFrame, for WebFrameLoaderClient to call us back when any frame scrolls.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::didChangeScrollOffsetForAnyFrame):
Invalidate the page overlay when any frame scrolls, so that find indicators in subframes are kept in the right place.
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
Stop unconditionally invalidating the page overlay when we flush layers.
- 4:41 PM Changeset in webkit [146538] by
-
- 1 edit2 adds in trunk/LayoutTests
Mac rebaseline r146531.
- platform/mac/compositing/rtl/rtl-fixed-expected.txt: Added.
- platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
- 4:28 PM Changeset in webkit [146537] by
-
- 37 edits in trunk/Source/WebCore
Remove upcastPointer from ActiveDOMObject constructor
https://bugs.webkit.org/show_bug.cgi?id=112858
Patch by Russell McClellan <russell.mcclellan@gmail.com> on 2013-03-21
Reviewed by Alexey Proskuryakov.
Removed pesky argument to ActiveDOMObject constructor that is no longer
used.
No new tests (no change in behavior).
- Modules/battery/BatteryManager.cpp:
(WebCore::BatteryManager::BatteryManager):
- Modules/filesystem/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::DOMFileSystem):
- Modules/filesystem/FileWriter.cpp:
(WebCore::FileWriter::FileWriter):
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::Geolocation):
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::IDBDatabase):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction):
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::MediaSource):
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack):
- Modules/mediastream/RTCDTMFSender.cpp:
(WebCore::RTCDTMFSender::RTCDTMFSender):
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
- Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
- Modules/mediastream/RTCStatsRequestImpl.cpp:
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
- Modules/mediastream/RTCVoidRequestImpl.cpp:
(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):
- Modules/networkinfo/NetworkInfoConnection.cpp:
(WebCore::NetworkInfoConnection::NetworkInfoConnection):
- Modules/notifications/Notification.cpp:
(WebCore::Notification::Notification):
- Modules/notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::NotificationCenter):
- Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::SpeechRecognition):
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
- Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::DatabaseContext):
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::WebSocket):
- css/FontLoader.cpp:
(WebCore::FontLoader::FontLoader):
- dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::ActiveDOMObject):
- dom/ActiveDOMObject.h:
(ActiveDOMObject):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::didCreateActiveDOMObject):
- dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
(WebCore::ScriptExecutionContext::activeDOMObjects):
- fileapi/FileReader.cpp:
(WebCore::FileReader::FileReader):
- html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
- loader/Prerenderer.cpp:
(WebCore::Prerenderer::Prerenderer):
- page/EventSource.cpp:
(WebCore::EventSource::EventSource):
- page/SuspendableTimer.cpp:
(WebCore::SuspendableTimer::SuspendableTimer):
- workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::AbstractWorker):
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::hasPendingActivity):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
- 3:54 PM Changeset in webkit [146536] by
-
- 8 edits in trunk/Source
[Mac] Move NSOperationQueue out of NetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=112970
Reviewed by Brady Eidson.
WebCore clients do not need explicit control over what queue ResourceHandle works on,
they just want to avoid blocking main thread.
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::usesAsyncCallbacks): Added. The name doesn't quite match what ResourceHandleMac currently does, but it will very soon.
- platform/network/NetworkingContext.h: (WebCore::NetworkingContext::scheduledRunLoopPairs):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::operationQueueForAsyncClients): (WebCore::ResourceHandle::start):
- 3:53 PM Changeset in webkit [146535] by
-
- 3 edits in trunk/LayoutTests
Revert bad change to resize-corner-tracking-transformed-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=112974
In bug 9221, I accidentally overwrite
resize-corner-tracking-transformed-expected.txt with a win/linux
version, which broke Mac. Unfortunately, the gardener didn't realize
this and just added the test to TestExpectations. This change restores
the original expectation to fix mac and removes the test from
TestExpectations.
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-21
Reviewed by Tony Chang.
- platform/chromium/TestExpectations:
- platform/chromium/fast/css/resize-corner-tracking-transformed-expected.txt:
- 3:52 PM Changeset in webkit [146534] by
-
- 15 edits in trunk/Source/WebCore
[V8] Generate specialized callbacks for the main world
https://bugs.webkit.org/show_bug.cgi?id=112430
Patch by Marja Hölttä <marja@chromium.org> on 2013-03-21
Reviewed by Jochen Eisinger.
The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.
This patch generates main world bindings for getters and setters of Node,
Element and Document.
No new tests (updated existing binding tests).
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateParametersCheck):
(GenerateSingleConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateFunctionCallString):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore):
- bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):
- bindings/v8/V8DOMConfiguration.h:
(BatchedMethod):
(V8DOMConfiguration):
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.idl:
- 3:50 PM Changeset in webkit [146533] by
-
- 2 edits in trunk/Source/WebCore
Remove RenderObject::canHaveRegionStyle since nothing uses it
https://bugs.webkit.org/show_bug.cgi?id=112973
Reviewed by Eric Seidel.
Nothing uses canHaveRegionStyle so we can remove it.
- rendering/RenderObject.h:
- 3:35 PM Changeset in webkit [146532] by
-
- 17 edits1 delete in trunk/LayoutTests
[chromium] Minor test expectations updates and some Skia rebaselines.
https://bugs.webkit.org/show_bug.cgi?id=94240
https://bugs.webkit.org/show_bug.cgi?id=104595
https://code.google.com/p/chromium/issues/detail?id=181700
https://code.google.com/p/chromium/issues/detail?id=222382
Unreviewed, gardening.
- platform/chromium-linux-x86/platform/chromium/virtual/gpu: Removed.
- platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast: Removed.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-win-xp/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium/TestExpectations:
- 3:29 PM Changeset in webkit [146531] by
-
- 326 edits11 copies6 adds2 deletes in trunk
Mark GraphicsLayers as opaque when possible
https://bugs.webkit.org/show_bug.cgi?id=70634
Reviewed by Simon Fraser.
Source/WebCore:
Mark layers as opaque in a very simple case - any child renderer has an opaque background and covers the entire composited bounds. It is important to note that since we only consider the background, the only layer that can be marked opaque is the primary GraphicsLayer of a RenderLayer.
Tests: compositing/contents-opaque/background-clip.html
compositing/contents-opaque/background-color.html
compositing/contents-opaque/body-background-painted.html
compositing/contents-opaque/body-background-skipped.html
compositing/contents-opaque/layer-opacity.html
compositing/contents-opaque/layer-transform.html
- rendering/RenderBox.cpp:
(WebCore::skipBodyBackground):
(WebCore):
(WebCore::RenderBox::paintBackground):
(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
(WebCore):
(WebCore::RenderLayer::listBackgroundIsKnownToBeOpaqueInRect):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerModelObject.h:
(RenderLayerModelObject):
(WebCore::RenderLayerModelObject::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
- compositing/absolute-inside-out-of-view-fixed-expected.txt:
- compositing/backing/no-backing-for-clip-expected.txt:
- compositing/backing/no-backing-for-clip-overlap-expected.txt:
- compositing/backing/no-backing-for-perspective-expected.txt:
- compositing/clip-child-by-non-stacking-ancestor-expected.txt:
- compositing/columns/composited-in-paginated-expected.txt:
- compositing/contents-opaque/background-clip-expected.txt: Copied from LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt.
- compositing/contents-opaque/background-clip.html: Added.
- compositing/contents-opaque/background-color-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
- compositing/contents-opaque/background-color.html: Added.
- compositing/contents-opaque/body-background-painted-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt.
- compositing/contents-opaque/body-background-painted.html: Added.
- compositing/contents-opaque/body-background-skipped-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt.
- compositing/contents-opaque/body-background-skipped.html: Added.
- compositing/contents-opaque/layer-opacity-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
- compositing/contents-opaque/layer-opacity.html: Added.
- compositing/contents-opaque/layer-transform-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
- compositing/contents-opaque/layer-transform.html: Added.
- compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt:
- compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- compositing/geometry/bounds-ignores-hidden-expected.txt:
- compositing/geometry/clip-expected.txt:
- compositing/geometry/clip-inside-expected.txt:
- compositing/geometry/fixed-position-composited-switch-expected.txt:
- compositing/geometry/flipped-writing-mode-expected.txt:
- compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
- compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
- compositing/geometry/limit-layer-bounds-fixed-expected.txt:
- compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
- compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- compositing/geometry/limit-layer-bounds-positioned-expected.txt:
- compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
- compositing/geometry/limit-layer-bounds-transformed-expected.txt:
- compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
- compositing/geometry/preserve-3d-switching-expected.txt:
- compositing/iframes/become-composited-nested-iframes-expected.txt:
- compositing/iframes/become-overlapped-iframe-expected.txt:
- compositing/iframes/composited-parent-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- compositing/iframes/connect-compositing-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe2-expected.txt:
- compositing/iframes/connect-compositing-iframe3-expected.txt:
- compositing/iframes/enter-compositing-iframe-expected.txt:
- compositing/iframes/iframe-resize-expected.txt:
- compositing/iframes/invisible-nested-iframe-hide-expected.txt:
- compositing/iframes/invisible-nested-iframe-show-expected.txt:
- compositing/iframes/overlapped-iframe-expected.txt:
- compositing/iframes/overlapped-iframe-iframe-expected.txt:
- compositing/iframes/overlapped-nested-iframes-expected.txt:
- compositing/iframes/page-cache-layer-tree-expected.txt:
- compositing/iframes/scrolling-iframe-expected.txt:
- compositing/layer-creation/animation-overlap-with-children-expected.txt:
- compositing/layer-creation/fixed-position-and-transform-expected.txt:
- compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- compositing/layer-creation/fixed-position-under-transform-expected.txt:
- compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- compositing/layer-creation/overflow-scroll-overlap-expected.txt:
- compositing/layer-creation/overlap-animation-clipping-expected.txt:
- compositing/layer-creation/overlap-animation-expected.txt:
- compositing/layer-creation/overlap-child-layer-expected.txt:
- compositing/layer-creation/overlap-clipping-expected.txt:
- compositing/layer-creation/overlap-transformed-3d-expected.txt:
- compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
- compositing/layer-creation/overlap-transformed-layer-expected.txt:
- compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
- compositing/layer-creation/overlap-transforms-expected.txt:
- compositing/layer-creation/spanOverlapsCanvas-expected.txt:
- compositing/layer-creation/stacking-context-overlap-expected.txt:
- compositing/layer-creation/translatez-overlap-expected.txt:
- compositing/masks/mask-layer-size-expected.txt:
- compositing/overflow-trumps-transform-style-expected.txt:
- compositing/overflow/clip-descendents-expected.txt:
- compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- compositing/overflow/textarea-scroll-touch-expected.txt:
- compositing/plugins/no-backing-store-expected.txt:
- compositing/repaint/invalidations-on-composited-layers-expected.txt:
- compositing/rtl/rtl-absolute-expected.txt:
- compositing/rtl/rtl-absolute-overflow-expected.txt:
- compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-fixed-expected.txt:
- compositing/rtl/rtl-fixed-overflow-expected.txt:
- compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-absolute-expected.txt:
- compositing/rtl/rtl-iframe-fixed-expected.txt:
- compositing/rtl/rtl-iframe-relative-expected.txt:
- compositing/rtl/rtl-relative-expected.txt:
- compositing/tiled-layers-hidpi-expected.txt:
- compositing/tiling/backface-preserve-3d-tiled-expected.txt:
- compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- compositing/tiling/huge-layer-add-remove-child-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- compositing/tiling/rotated-tiled-clamped-expected.txt:
- compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- compositing/tiling/tile-cache-zoomed-expected.txt:
- compositing/tiling/tiled-layer-resize-expected.txt:
- compositing/visible-rect/2d-transformed-expected.txt:
- compositing/visible-rect/3d-transform-style-expected.txt:
- compositing/visible-rect/3d-transformed-expected.txt:
- compositing/visible-rect/animated-expected.txt:
- compositing/visible-rect/animated-from-none-expected.txt:
- compositing/visible-rect/clipped-by-viewport-expected.txt:
- compositing/visible-rect/clipped-visible-rect-expected.txt:
- compositing/visible-rect/iframe-and-layers-expected.txt:
- compositing/visible-rect/iframe-no-layers-expected.txt:
- compositing/visible-rect/nested-transform-expected.txt:
- compositing/visible-rect/scrolled-expected.txt:
- css3/filters/filtered-compositing-descendant-expected.txt:
- platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/chromium-linux/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/chromium-linux/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/chromium-linux/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/chromium-linux/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/chromium-linux/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/chromium-linux/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/chromium-linux/compositing/iframes/iframe-resize-expected.txt:
- platform/chromium-linux/compositing/iframes/iframe-size-from-zero-expected.txt:
- platform/chromium-linux/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-linux/compositing/iframes/overlapped-iframe-expected.txt:
- platform/chromium-linux/compositing/iframes/resizer-expected.txt:
- platform/chromium-linux/compositing/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/become-overlapped-iframe-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/composited-parent-iframe-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/enter-compositing-iframe-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/iframe-resize-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/iframe-size-from-zero-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/overlapped-iframe-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/resizer-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/scrolling-iframe-expected.txt: Removed.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-mac/compositing/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- platform/chromium-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
- platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/chromium-win/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/backing/no-backing-for-clip-expected.txt:
- platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/chromium/compositing/columns/composited-in-paginated-expected.txt:
- platform/chromium/compositing/contents-opaque/background-color-expected.txt: Copied from LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt.
- platform/chromium/compositing/contents-opaque/body-background-painted-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt.
- platform/chromium/compositing/contents-opaque/body-background-skipped-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt.
- platform/chromium/compositing/contents-opaque/layer-opacity-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
- platform/chromium/compositing/contents-opaque/layer-transform-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
- platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium/compositing/geometry/clip-expected.txt:
- platform/chromium/compositing/geometry/clip-inside-expected.txt:
- platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt:
- platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt:
- platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
- platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt:
- platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/chromium/compositing/iframes/iframe-resize-expected.txt:
- platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
- platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt:
- platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
- platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt:
- platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt:
- platform/chromium/compositing/iframes/resizer-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt:
- platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-animation-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
- platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
- platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt:
- platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt:
- platform/chromium/compositing/overflow-trumps-transform-style-expected.txt:
- platform/chromium/compositing/overflow/clip-descendents-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium/compositing/rtl/rtl-relative-expected.txt:
- platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
- platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
- platform/mac/compositing/iframes/resizer-expected.txt:
- platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt:
- platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
- platform/mac/compositing/tiling/tiled-layer-resize-expected.txt:
- platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/qt-5.0-wk1/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- platform/qt-5.0-wk1/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
- platform/qt-5.0-wk1/compositing/iframes/page-cache-layer-tree-expected.txt:
- platform/qt-5.0-wk1/compositing/overflow/textarea-scroll-touch-expected.txt:
- platform/qt-5.0-wk1/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
- platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
- platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
- platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- 3:29 PM Changeset in webkit [146530] by
-
- 134 edits10 moves in trunk
Move common props files for VS2010 solution to WebKitLibraries folder and update all projects accordingly.
- WebKit.vcxproj/FeatureDefines.props: Removed.
- WebKit.vcxproj/FeatureDefinesCairo.props: Removed.
- WebKit.vcxproj/WebKit/cURL.props: Removed.
- WebKit.vcxproj/WinCairo.props: Removed.
- WebKit.vcxproj/common.props: Removed.
- WebKit.vcxproj/debug.props: Removed.
- WebKit.vcxproj/debug_wincairo.props: Removed.
- WebKit.vcxproj/debugsuffix.props: Removed.
- WebKit.vcxproj/production.props: Removed.
- WebKit.vcxproj/release.props: Removed.
- win/tools/vsprops/FeatureDefines.props: Copied from ../Source/WebKit/WebKit.vcxproj/FeatureDefines.props.
- win/tools/vsprops/FeatureDefinesCairo.props: Copied from ../Source/WebKit/WebKit.vcxproj/FeatureDefinesCairo.props.
- win/tools/vsprops/WinCairo.props: Copied from ../Source/WebKit/WebKit.vcxproj/WinCairo.props.
- win/tools/vsprops/cURL.props: Copied from ../Source/WebKit/WebKit.vcxproj/WebKit/cURL.props.
- win/tools/vsprops/common.props: Copied from ../Source/WebKit/WebKit.vcxproj/common.props.
- win/tools/vsprops/debug.props: Copied from ../Source/WebKit/WebKit.vcxproj/debug.props.
- win/tools/vsprops/debug_wincairo.props: Copied from ../Source/WebKit/WebKit.vcxproj/debug_wincairo.props.
- win/tools/vsprops/debugsuffix.props: Copied from ../Source/WebKit/WebKit.vcxproj/debugsuffix.props.
- win/tools/vsprops/production.props: Copied from ../Source/WebKit/WebKit.vcxproj/production.props.
- win/tools/vsprops/release.props: Copied from ../Source/WebKit/WebKit.vcxproj/release.props.
- 3:17 PM Changeset in webkit [146529] by
-
- 17 edits2 copies3 adds in trunk
[CSS Shaders] Implement a StyleCustomFilterProgram cache
https://bugs.webkit.org/show_bug.cgi?id=112602
Reviewed by Dean Jackson.
Source/WebCore:
When the style is recalculated, the new computed RenderStyle is saved as the m_style of the
RenderObject, even if the style was not different.
In the case of Custom Filters, a new StyleCustomFilterProgram was created at all times, but the
actual equality check was done by comparing the pair of cached shaders from inside the StyleCustomFilterProgram.
Because of that the RenderLayer::styleChanged was not called when the new StyleCustomFilterProgram was created, so it
will end up still knowing only about the previous StyleCustomFilterProgram.
The RenderLayer sets itself as a client of the StyleCustomFilterProgram, so that it can repaint itself
when the program is loaded, but because RenderLayer::styleChanged is not called, it will not add itself as a client of the new
StyleCustomFilterProgram.
StyleCustomFilterProgram waits until the first client to load the programs, so in this case it will just remain unloaded.
There was no crash, but just an assert in debug mode. Also, as a visible side-effect some frames were rendered using blank shaders,
resulting in a pass-through filter.
The fix would be to actually make the RenderStyle::diff detect the change of the StyleCustomFilterProgram
using the pointer value and not the values. However, that will always invalidate the "filter" property because
of the StyleCustomFilterProgram that always gets created during the recalculation time.
I've added StyleCustomFilterProgramCache to cache all the instances of the StyleCustomFilterPrograms that a
StyleResolver allocates. This way, next time it will try to reuse previously allocated StyleCustomFilterPrograms.
The key of the cache is the CustomFilterProgramInfo, that combines the URLs to the shaders and a couple of other program settings.
StyleCustomFilterProgramCache is owned by the StyleResovler and StyleCustomFilterPrograms are responsible with
removing themselves from the cache when the last reference goes away.
This change makes the previous "platform level" program cache obsolete and I will remove that in a future patch.
https://bugs.webkit.org/show_bug.cgi?id=112844
Test: css3/filters/custom/custom-filter-reload.html
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::lookupCustomFilterProgram): Lookup any similar programs in the cache. It will create a new pending
StyleCustomFilterProgram if there is no pre-cached version of the program.
if no program is found. loadPendingShaders is responsible for adding the program in the cache if it is actually going to be used.
(WebCore::StyleResolver::loadPendingShaders): At this point the program is final, so it's safe to add it to the cache.
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
- css/StyleResolver.h:
(StyleResolver):
- css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::completeURL): Factored out the function to compute the complete URL of the resource.
(WebCore::WebKitCSSShaderValue::cachedShader):
- css/WebKitCSSShaderValue.h:
(WebCore::toWebKitCSSShaderValue):
(WebKitCSSShaderValue):
- platform/graphics/filters/CustomFilterOperation.cpp:
(WebCore::CustomFilterOperation::blend):
- platform/graphics/filters/CustomFilterOperation.h:
(WebCore::CustomFilterOperation::operator==): Removed. Programs should now compare by pointer. Kept it as
private to catch any potential use of it.
- rendering/style/StyleCustomFilterProgram.cpp: Copied from Source/WebCore/css/WebKitCSSShaderValue.h.
(WebCore::StyleCustomFilterProgram::~StyleCustomFilterProgram): Destructor removes the program from the cache.
- rendering/style/StyleCustomFilterProgram.h:
(WebCore::StyleCustomFilterProgram::setVertexShader): Added an assert to check that the shader is not in the
cache while the mutation happens. Otherwise the cache might have the wrong key.
(WebCore::StyleCustomFilterProgram::setFragmentShader): Ditto.
(WebCore::StyleCustomFilterProgram::isLoaded): Added more asserts to catch cases when the program is used with no clients.
(StyleCustomFilterProgram):
(WebCore::StyleCustomFilterProgram::hasPendingShaders):
(WebCore::StyleCustomFilterProgram::inCache):
(WebCore::StyleCustomFilterProgram::setCache): Function called when a program is added to / removed from the cache.
(WebCore::StyleCustomFilterProgram::vertexShaderURL): Added methods to store the KURL that we used as keys in the cache.
The same KURLs will be used to lookup and remove the filter at the end.
(WebCore::StyleCustomFilterProgram::setVertexShaderURL):
(WebCore::StyleCustomFilterProgram::fragmentShaderURL):
(WebCore::StyleCustomFilterProgram::setFragmentShaderURL):
(WebCore::StyleCustomFilterProgram::StyleCustomFilterProgram):
- rendering/style/StyleCustomFilterProgramCache.cpp: Added.
(WebCore::StyleCustomFilterProgramCache::programCacheKey):
(WebCore::StyleCustomFilterProgramCache::StyleCustomFilterProgramCache):
(WebCore::StyleCustomFilterProgramCache::~StyleCustomFilterProgramCache): Destructor removes itself from all the
referenced StyleCustomFilterPrograms. This is to avoid issues with different destruction orders.
(WebCore::StyleCustomFilterProgramCache::lookup):
(WebCore::StyleCustomFilterProgramCache::add):
(WebCore::StyleCustomFilterProgramCache::remove):
- rendering/style/StyleCustomFilterProgramCache.h:
(StyleCustomFilterProgramCache):
- platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h:
(WebCore::CoordinatedCustomFilterProgram::operator==: Removed. Programs should now compare by pointer.
LayoutTests:
Added a new test to check for the case when the style is recalculated but the
filter property is not changed. All the other cases for the new StyleCustomFilterProgramCache
class should be tested by existing tests.
- css3/filters/custom/custom-filter-reload-expected.txt: Added.
- css3/filters/custom/custom-filter-reload.html: Added.
- 3:11 PM Changeset in webkit [146528] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Last paragraph can't be selected by touch hold selection if there is no new line after it in subframe.
https://bugs.webkit.org/show_bug.cgi?id=112966
Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-21
Reviewed by Rob Buis.
PR 312044
Reviewed Internally By Genevieve Mak.
If selection reaches the bottom of content, ignore scroll margin
so the text on the bottom can be selected.
Stop expanding selection only if the end of document is selected
or touch is released.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::expandSelection):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
- 2:53 PM Changeset in webkit [146527] by
-
- 5 edits in trunk/Source/WebCore
IndexedDB: Ensure all API methods have IDB_TRACE macros
https://bugs.webkit.org/show_bug.cgi?id=112963
Reviewed by Tony Chang.
Anntotate methods and callbacks that weren't already annotated
with IDB_TRACE macros to assist in debugging, e.g. when using
the chromium port's chrome://tracing visualization.
No new tests - just harmless diagnostic sprinkles.
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore): Added IDB_TRACE macro call here.
(WebCore::IDBDatabase::deleteObjectStore): ...and here.
(WebCore::IDBDatabase::transaction): ...etc.
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::onVersionChange):
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::deleteDatabase):
- Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::open):
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::onBlocked):
- 2:52 PM Changeset in webkit [146526] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] addSearchProvider shouldn't match the full host, only the server
https://bugs.webkit.org/show_bug.cgi?id=112960
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-03-21
Reviewed by Rob Buis.
Internally Reviewed by Jeff Rogers.
Remove full host matching. only check if domains are from the same server.
Also, check user gesture before dispatching the addSearchProvider event to the browser.
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::addSearchProvider):
(WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
- WebCoreSupport/ExternalExtension.cpp:
(IsSearchProviderInstalledMethod):
- 2:51 PM Changeset in webkit [146525] by
-
- 2 edits in trunk/LayoutTests
Skip triaged crashes on content shell
Unreviewed gardening
- platform/chromium/ContentShellTestExpectations:
- 2:49 PM Changeset in webkit [146524] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
EWS bubbles need more space
https://bugs.webkit.org/show_bug.cgi?id=112964
Reviewed by Philip Rogers.
Increased the width from 500px to 600px so that all bubbles fit.
- template/en/custom/attachment/list.html.tmpl:
- 2:47 PM Changeset in webkit [146523] by
-
- 2 edits in trunk/LayoutTests
fast/frames/detach-frame-during-focus.html fails on some platforms
https://bugs.webkit.org/show_bug.cgi?id=112904
- fast/frames/detach-frame-during-focus.html:
Do not run the test sequence twice.
- 2:37 PM Changeset in webkit [146522] by
-
- 3 edits2 adds in trunk
http://trac.webkit.org/changeset/146375 causing CrOS crashes
https://bugs.webkit.org/show_bug.cgi?id=112958
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-21
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/flexbox/crash-anonymous-box.html
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
Anonymous renderers don't have a node in their constructor, so
don't get document() in there.
LayoutTests:
- fast/flexbox/crash-anonymous-box-expected.txt: Added.
- fast/flexbox/crash-anonymous-box.html: Added.
- 2:30 PM Changeset in webkit [146521] by
-
- 5 edits in trunk/Source/WebKit/chromium
[chromium] Add possibleUserNames to WebPasswordFormData
https://bugs.webkit.org/show_bug.cgi?id=112375
Patch by Garrett Casto <gcasto@chromium.org> on 2013-03-21
Reviewed by Adam Barth.
- public/WebPasswordFormData.h:
(WebPasswordFormData):
- src/WebPasswordFormData.cpp:
(WebKit::WebPasswordFormData::WebPasswordFormData):
- src/WebPasswordFormUtils.cpp:
(WebKit::findPasswordFormFields):
- src/WebPasswordFormUtils.h:
(PasswordFormFields):
- 2:25 PM Changeset in webkit [146520] by
-
- 3 edits2 adds in trunk
CSP 1.1: Fire a SecurityPolicyViolationEvent when violations occur.
https://bugs.webkit.org/show_bug.cgi?id=112783
Reviewed by Adam Barth.
Source/WebCore:
A new event type for Content Security Policy violations landed in
http://wkrev.com/146305; this patch takes that stub, and wires it up to
ContentSecurityPolicy::reportViolation such that violation events fire
when resources are blocked.
This should bring WebKit up to date with the current description of
CSP's event model in sections 3.3[1] and 3.4.1.3[2] of the editor's
draft.
[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#processing-model
[2]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#firing-events-using-the-securitypolicyviolationevent-interface
Test: http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html
- page/ContentSecurityPolicy.cpp:
(WebCore::gatherSecurityPolicyViolationEventData):
Populate a SecurityPolicyViolationEventInit object with the various
bits of data that should be passed into the event constructor.
This static method is strictly an implementation detail; it's not
part of ContentSecurityPolicy's public API.
(WebCore::ContentSecurityPolicy::reportViolation):
Regardless of whether the policy has set a 'report-uri' directive
or not, gather together all the data we'll need to fire an event,
create the event, and queue it up for dispatching on the Document.
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html: Added.
- 2:22 PM Changeset in webkit [146519] by
-
- 8 edits in trunk/Source
[chromium] Remove SK_SUPPORT_HINTING_SCALE_FACTOR flag and code
https://bugs.webkit.org/show_bug.cgi?id=112928
Reviewed by Stephen White.
This flag was only for ChromeOS builds with HighDPI. It is no longer needed and can be removed.
See http://crbug.com/17550
Source/WebCore:
No new tests needed since this is just removing unused code.
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::setupPaintCommon):
- platform/graphics/skia/PlatformContextSkia.h:
Source/WebKit/chromium:
- features.gypi:
- tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
- tests/PlatformContextSkiaTest.cpp:
- 2:16 PM Changeset in webkit [146518] by
-
- 14 edits in trunk/Source/WebKit2
Support connecting the Web Inspector without showing it.
This allows you to get the debugger attached in the background. When a breakpoint is hit
the Inspector will open. This change also reduces some WebProcess messaging by removing
the DidLoadInspectorPage message and stops sending the SetAttachedWindow message on close.
https://bugs.webkit.org/show_bug.cgi?id=112445
Reviewed by Sam Weinig.
- UIProcess/API/C/WKInspector.cpp:
(WKInspectorIsConnected): Added.
(WKInspectorConnect): Added.
(WKInspectorHide): Added.
- UIProcess/API/C/WKInspector.h:
Added new APIs.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy):
Initialize new state booleans.
(WebKit::WebInspectorProxy::invalidate):
Don't set state booleans that didClose already resets.
(WebKit::WebInspectorProxy::connect): Added.
(WebKit::WebInspectorProxy::show):
Open if we are already connected. Call connect().
(WebKit::WebInspectorProxy::hide): Added.
(WebKit::WebInspectorProxy::close):
Call didClose we can detach or close the window immediately instead of waiting for a
message from the WebProcess.
(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::detach):
Check for !m_page to match other functions.
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::didLoadInspectorPage):
Removed. Moved logic to open().
(WebKit::WebInspectorProxy::open): Added.
(WebKit::WebInspectorProxy::didClose):
Clear new state booleans. Don't perform work again if already closed. Use platformDetach()
instead of detach() to avoid sending the SetAttachedWindow message.
(WebKit::WebInspectorProxy::bringToFront):
Call open() if we are not visible yet, otherwise platformBringToFront.
- UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::isConnected): Added.
- UIProcess/WebInspectorProxy.messages.in: Removed DidLoadInspectorPage.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformHide): Added stub.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformHide): Added.
- UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformHide): Added stub.
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
Removed frontendLoaded().
- WebProcess/WebPage/WebInspector.cpp:
- WebProcess/WebPage/WebInspector.h:
Removed didLoadInspectorPage().
- 2:02 PM Changeset in webkit [146517] by
-
- 2 edits in trunk/Tools
Cleanup android media layout test code
https://bugs.webkit.org/show_bug.cgi?id=112944
Patch by Min Qin <qinmin@chromium.org> on 2013-03-21
Reviewed by Adam Barth.
Chromium change: https://codereview.chromium.org/12892010/
The current android layout tests are using WebmediaPlayerInProcessAndroid class.
The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
Instead, we should switch to use content shell for layout tests.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetTestController):
- 2:02 PM Changeset in webkit [146516] by
-
- 54 edits in trunk
Drop full URLs from cross-origin access errors caused by protocol mismatches.
https://bugs.webkit.org/show_bug.cgi?id=112894
Reviewed by Timothy Hatcher.
Source/WebCore:
Following up on http://wkbug.com/112813, this patch brings protocol
mismatch errors into line with the new origin-only hotness. The message
is also changed to display the URL's protocol rather than the origin's
protocol: it makes a big difference for 'data:' URLs, for instance.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::crossDomainAccessErrorMessage):
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block-expected.txt:
- http/tests/security/cross-frame-access-protocol-expected.txt:
- http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
- http/tests/security/view-source-no-javascript-url-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt:
- http/tests/security/xssAuditor/full-block-base-href-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
- http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
- http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
- http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
- platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
- platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
- platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
- platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
- platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
- platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
- platform/chromium/http/tests/security/inactive-document-with-empty-security-origin-expected.txt:
- platform/chromium/http/tests/security/window-named-proto-expected.txt:
- 1:57 PM Changeset in webkit [146515] by
-
- 3 edits2 adds in trunk
SVG text path referencing parent text infinite loops
https://bugs.webkit.org/show_bug.cgi?id=112078
Reviewed by Philip Rogers.
Source/WebCore:
We do not check the target type when adding a resource reference for
SVG Text Path's URI. This goes horribly wrong when the target is the
text path's parent text element. In this patch we check that the target
element of the text path is indeed a path element, as the spec
requires. No other element type is allowed.
Note that RenderSVGTextPath enforces this check in the renderer code
also, so if we get past this check via pending resources, it doesn't
matter. You can't get into this situation with a pending reference
because, by definition, the parent must be defined before the text
path child.
Test: svg/text/textpath-referencing-text-crash.svg
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::buildPendingResource):
LayoutTests:
- svg/text/textpath-referencing-text-crash-expected.txt: Added.
- svg/text/textpath-referencing-text-crash.svg: Added.
- 1:56 PM Changeset in webkit [146514] by
-
- 2 edits in trunk/Tools
[chromium] add missing project dependencies to DRT to fix Mac Valgrind
https://bugs.webkit.org/show_bug.cgi?id=112953
Reviewed by Tony Chang.
When I created the DumpRenderTree_resources target in r144863 I
forgot to declare the needed dependencies on the other resource
targets. Due to a quirk of ordering, this appears to have been fine
w/ ninja but not w/ Xcode (which is still being used on the chromium
mac valgrind bots). Declaring the dependencies fixes the build
failures.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 1:53 PM Changeset in webkit [146513] by
-
- 2 edits in trunk/Source/WebKit2
Build fix.
- NetworkProcess/mac/NetworkResourceLoaderMac.mm: Include CurrentTime.h, as needed to call currentTime().
- 1:49 PM Changeset in webkit [146512] by
-
- 2 edits in trunk/Source/Platform
[Chromium] Removed unused WEBKIT_USE_NEW_WEBFILESYSTEMTYPE flag
https://bugs.webkit.org/show_bug.cgi?id=112931
Reviewed by Adam Barth.
Migration complete; flag no longer needed.
- chromium/public/WebFileSystemType.h:
- 1:43 PM Changeset in webkit [146511] by
-
- 14 edits in trunk/Source
IndexedDB: Remove onVersionChange(string) plumbing
https://bugs.webkit.org/show_bug.cgi?id=112712
Reviewed by Adam Barth.
Source/WebCore:
Delete unused onVersionChange(string) overload.
No new tests - just deleting dead code.
- Modules/indexeddb/IDBDatabase.cpp: Delete onVersionChange(string) overload.
- Modules/indexeddb/IDBDatabase.h: Ditto.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Ditto.
- Modules/indexeddb/IDBDatabaseCallbacks.h: Ditto.
- Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp: Ditto.
- Modules/indexeddb/IDBDatabaseCallbacksImpl.h: Ditto.
Source/WebKit/chromium:
- public/WebIDBDatabaseCallbacks.h: Remove onVersionChange(string) overload.
- src/IDBDatabaseCallbacksProxy.cpp: Ditto.
- src/IDBDatabaseCallbacksProxy.h: Ditto.
- src/WebIDBDatabaseCallbacksImpl.cpp: Ditto.
- src/WebIDBDatabaseCallbacksImpl.h: Ditto.
- tests/IDBAbortOnCorruptTest.cpp: Ditto.
- tests/IDBDatabaseBackendTest.cpp: Ditto.
- 1:35 PM Changeset in webkit [146510] by
-
- 4 edits3 adds in trunk
Correct bisector angle calculation for markers
https://bugs.webkit.org/show_bug.cgi?id=112054
Reviewed by Stephen Chenney.
Source/WebCore:
The SVG marker spec states that mid markers with orient=auto should be aligned with their
x-axis along the bisector of the incoming (in) and outgoing (out) angles. Previously we
calculated this bisector angle as:
bisector = (in + out) / 2;
Angles cannot be averaged this way! Consider in=90deg and out=-180deg: the bisector should
be 135deg but a naive average gives -45deg. This patch corrects for the discontinuity in
angle values with:
bisector = (in + out + 360) / 2 if |in - out| > 180
bisector = (in + out) / 2 otherwise
This patch includes an exhaustive test of angle values.
Test: svg/custom/marker-orient-auto.html
- rendering/svg/SVGMarkerData.h:
(WebCore::SVGMarkerData::currentAngle):
LayoutTests:
- platform/chromium-linux/svg/custom/marker-orient-auto-expected.png: Added.
- platform/chromium-linux/svg/custom/marker-orient-auto-expected.txt: Added.
- platform/chromium/TestExpectations:
- svg/custom/marker-orient-auto.html: Added.
- 1:28 PM Changeset in webkit [146509] by
-
- 6 edits in trunk
Expose the Type field of an RTCStatsReport
https://bugs.webkit.org/show_bug.cgi?id=112951
Patch by Harald Alvestrand <hta@google.com> on 2013-03-21
Reviewed by Adam Barth.
Source/WebCore:
Covered by an extension of an existing test.
- Modules/mediastream/RTCStatsReport.h:
(WebCore::RTCStatsReport::type):
- Modules/mediastream/RTCStatsReport.idl:
LayoutTests:
- fast/mediastream/RTCPeerConnection-stats-expected.txt:
- fast/mediastream/RTCPeerConnection-stats.html:
- 1:27 PM Changeset in webkit [146508] by
-
- 11 edits1 add in trunk/Source/WebCore
Move non-trivial virtual functions out of ResourceHandleClient.h
https://bugs.webkit.org/show_bug.cgi?id=112950
Reviewed by Brady Eidson.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/ResourceHandleClient.cpp: Added. (WebCore::ResourceHandleClient::ResourceHandleClient): (WebCore::ResourceHandleClient::~ResourceHandleClient): (WebCore::ResourceHandleClient::didReceiveBuffer): (WebCore::ResourceHandleClient::getBuffer):
- platform/network/ResourceHandleClient.h:
- 1:19 PM Changeset in webkit [146507] by
-
- 2 edits in trunk/Tools
[WinCairo] Correct assert in Empty BitmapImage Test.
https://bugs.webkit.org/show_bug.cgi?id=112934
Reviewed by Tim Horton.
- TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
(TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
to avoid ref counting assertion when leaving test scope.
- 1:11 PM Changeset in webkit [146506] by
-
- 3 edits in trunk/LayoutTests
Windows rebaseline after r146469.
- platform/win/css3/filters/effect-reference-expected.txt:
- platform/win/css3/filters/effect-reference-hw-expected.txt:
- 1:06 PM Changeset in webkit [146505] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix lexer charPosition computation when "rewind"ing the lexer.
https://bugs.webkit.org/show_bug.cgi?id=112952.
Reviewed by Michael Saboff.
Changed the Lexer to no longer keep a m_charPosition. Instead, we compute
currentCharPosition() from m_code and m_codeStartPlusOffset, where
m_codeStartPlusOffset is the SourceProvider m_codeStart + the SourceCode
start offset. This ensures that the charPosition is always in sync with
m_code.
- parser/Lexer.cpp:
(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):
- parser/Lexer.h:
(JSC::Lexer::currentCharPosition):
(JSC::::lexExpectIdentifier):
- 1:05 PM Changeset in webkit [146504] by
-
- 2 edits in trunk/Tools
[GTK] generate-feature-defines-files is incompatible with Python3
https://bugs.webkit.org/show_bug.cgi?id=112956
Reviewed by Martin Robinson.
Make the generate-feature-defines-files compatible with Python3 by calling the items()
method on the dictionary objects when iterating through said dictionaries.
- gtk/generate-feature-defines-files:
(write_feature_defines_header):
(write_flattened_feature_defines_file):
- 1:03 PM WebKitGTK/2.0.x edited by
- (diff)
- 1:02 PM Changeset in webkit [146503] by
-
- 13 edits1 delete in trunk/Source/WebCore
[SVG] Remove explicit LightSource dispatchers
https://bugs.webkit.org/show_bug.cgi?id=112827
Reviewed by Stephen Chenney.
Convert LightSource setters to dynamic dispatch. This allows us to remove LightSource.cpp
altogether.
No new tests: refactoring only.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/DistantLightSource.h:
(DistantLightSource):
- platform/graphics/filters/LightSource.cpp: Removed.
- platform/graphics/filters/LightSource.h:
(WebCore::LightSource::setAzimuth):
(WebCore::LightSource::setElevation):
(WebCore::LightSource::setX):
(WebCore::LightSource::setY):
(WebCore::LightSource::setZ):
(WebCore::LightSource::setPointsAtX):
(WebCore::LightSource::setPointsAtY):
(WebCore::LightSource::setPointsAtZ):
(WebCore::LightSource::setSpecularExponent):
(WebCore::LightSource::setLimitingConeAngle):
- platform/graphics/filters/PointLightSource.h:
(PointLightSource):
- platform/graphics/filters/SpotLightSource.h:
(SpotLightSource):
- 12:55 PM Changeset in webkit [146502] by
-
- 2 edits in trunk/Source/JavaScriptCore
[BlackBerry] GCActivityCallback: replace JSLock with JSLockHolder
https://bugs.webkit.org/show_bug.cgi?id=112448
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Xan Lopez.
This changed in r121381.
- runtime/GCActivityCallbackBlackBerry.cpp:
(JSC::DefaultGCActivityCallback::doWork):
- 12:51 PM Changeset in webkit [146501] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] Implement support for OpenGLES EXT_unpack_subimage extension
https://bugs.webkit.org/show_bug.cgi?id=108716
If the extension GL_EXT_unpack_subimage is supported, it adds GL_UNPACK_ROW_LENGTH,
GL_UNPACK_SKIP_ROWS and GL_UNPACK_SKIP_PIXELS as valid enums to PixelStore.
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::driverSupportsSubImage):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):
- 12:42 PM Changeset in webkit [146500] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Regression: drawer resizes slowly with animation.
https://bugs.webkit.org/show_bug.cgi?id=112920
Drawer status bar opacity wasn't set to zero on inialization, so no transition event
was fired on first time drawer appeared,thus animation styles wasn't removed properly.
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-21
Reviewed by Vsevolod Vlasov.
- inspector/front-end/Drawer.js:
(WebInspector.Drawer):
- 12:36 PM Changeset in webkit [146499] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] GraphicsLayer: fix code that was accidentally reverted
https://bugs.webkit.org/show_bug.cgi?id=112143
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Rob Buis.
Several changes were accidentally reverted in r144465 due to the
upstreaming of some new code:
- clearBackgroundColor() and m_contentsLayerHasBackgroundColor had been removed in r137798.
- showDebugBorders() had been renamed to isShowingDebugBorder() in r133517.
- A new GraphicsLayer::create() overload had been introduced in r130185.
This patch fixes them all.
- platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayer::create):
(WebCore):
(WebCore::GraphicsLayerBlackBerry::GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::setBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::updateLayerBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):
- platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(GraphicsLayerBlackBerry):
- 12:25 PM Changeset in webkit [146498] by
-
- 6 edits1 add in trunk
[GTK] Move libLevelDB.la setup into a separate GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=112947
Reviewed by Martin Robinson.
.:
- GNUmakefile.am: Include the new GNUmakefile.am, located under Source/ThirdParty/leveldb.
Source/ThirdParty:
- leveldb/GNUmakefile.am: Added, sets up the libLevelDB.la library.
Source/WebCore:
No new tests - no new functionality.
- GNUmakefile.am: Move the libLevelDD.la setup into the new GNUmakefile.am that's placed in
the third-party leveldb source directory.
- GNUmakefile.list.am: Move the LevelDB sources listing there as well.
- 12:25 PM WebKitGTK/AddingNewWebKit2API edited by
- (diff)
- 12:23 PM WebKitGTK/AddingNewWebKit2API edited by
- (diff)
- 12:22 PM Changeset in webkit [146497] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] DrawingBuffer: add clearPlatformLayer() implementation
https://bugs.webkit.org/show_bug.cgi?id=112696
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Rob Buis.
DrawingBuffer::clearPlatformLayer() was added in r139142.
This is not needed in the BlackBerry port, so this patch only
contains a dummy implementation.
- platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:
(WebCore):
(WebCore::DrawingBuffer::clearPlatformLayer):
- 12:19 PM Changeset in webkit [146496] by
-
- 2 edits in trunk/Tools
kill-old-processes spits out error messages on Mac
https://bugs.webkit.org/show_bug.cgi?id=112878
Reviewed by Jessie Berlin.
Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
included in the list of options grep --help shows.
Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
- BuildSlaveSupport/kill-old-processes:
(main):
- 12:14 PM Changeset in webkit [146495] by
-
- 15 edits2 adds in trunk
[SVG] Suppress painting when an empty viewBox is specified
https://bugs.webkit.org/show_bug.cgi?id=112623
Reviewed by Philip Rogers.
Source/WebCore:
Per spec, elements with an empty viewBox should not be rendered:
http://www.w3.org/TR/SVG/coords.html#ViewBoxAttribute.
This patch adds the missing viewBox checks to RenderSVGRoot, RenderSVGViewPortContainer,
RenderSVGResourceMarker and RenderSVGResourceMarker's paint methods.
In order to detect the case of "viewBox present but invalid", the patch also introduces
SVGAnimatedProperty plumbing for tracking property validity: the baseVal setter now takes
an additional optional 'validValue' boolean parameter, which can later be queried via a
macroed getter (LowerProperty##IsValid()).
Test: svg/custom/viewBox-empty.html
- rendering/svg/RenderSVGResourceMarker.cpp:
(WebCore::RenderSVGResourceMarker::draw):
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::paint):
(WebCore):
- rendering/svg/RenderSVGViewportContainer.h:
(RenderSVGViewportContainer):
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::collectPatternAttributes):
- svg/SVGSVGElement.h:
(WebCore::SVGSVGElement::hasEmptyViewBox):
(SVGSVGElement):
Suppress painting if a valid empty viewBox is found.
- svg/SVGFitToViewBox.h:
(WebCore::SVGFitToViewBox::parseAttribute):
Mark the viewBox property as invalid if not successfully parsed.
- svg/SVGExternalResourcesRequired.h:
(SVGExternalResourcesRequired):
- svg/SVGURIReference.h:
(SVGURIReference):
- svg/properties/SVGAnimatedPropertyMacros.h:
(WebCore::SVGSynchronizableAnimatedProperty::SVGSynchronizableAnimatedProperty):
(SVGSynchronizableAnimatedProperty):
(WebCore):
Plumbing for tracking property value validation.
LayoutTests:
- svg/custom/script-tests/svg-viewBox-dynamic.js:
- svg/custom/svg-viewBox-dynamic-expected.txt:
- svg/custom/viewBox-empty-expected.html: Added.
- svg/custom/viewBox-empty.html: Added.
- 12:09 PM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 12:06 PM Changeset in webkit [146494] by
-
- 16 edits1 move in trunk/Source/JavaScriptCore
Objective-C API: wrapperClass holds a static JSClassRef, which causes JSGlobalObjects to leak
https://bugs.webkit.org/show_bug.cgi?id=112856
Reviewed by Geoffrey Garen.
Through a very convoluted path that involves the caching of prototypes on the JSClassRef, we can leak
JSGlobalObjects when inserting an Objective-C object into multiple independent JSContexts.
- API/JSAPIWrapperObject.cpp: Removed.
- API/JSAPIWrapperObject.h:
(JSAPIWrapperObject):
- API/JSAPIWrapperObject.mm: Copied from Source/JavaScriptCore/API/JSAPIWrapperObject.cpp. Made this an
Objective-C++ file so that we can call release on the wrappedObject. Also added a WeakHandleOwner for
JSAPIWrapperObjects. This will also be used in a future patch for https://bugs.webkit.org/show_bug.cgi?id=112608.
(JSAPIWrapperObjectHandleOwner):
(jsAPIWrapperObjectHandleOwner):
(JSAPIWrapperObjectHandleOwner::finalize): This finalize replaces the old finalize that was done through
the C API.
(JSC::JSAPIWrapperObject::finishCreation): Allocate the WeakImpl. Balanced in finalize.
(JSC::JSAPIWrapperObject::setWrappedObject): We now do the retain of the wrappedObject here rather than in random
places scattered around JSWrapperMap.mm
- API/JSObjectRef.cpp: Added some ifdefs for platforms that don't support the Obj-C API.
(JSObjectGetPrivate): Ditto.
(JSObjectSetPrivate): Ditto.
(JSObjectGetPrivateProperty): Ditto.
(JSObjectSetPrivateProperty): Ditto.
(JSObjectDeletePrivateProperty): Ditto.
- API/JSValueRef.cpp: Ditto.
(JSValueIsObjectOfClass): Ditto.
- API/JSWrapperMap.mm: Remove wrapperClass().
(objectWithCustomBrand): Change to no longer use a parent class, which was only used to give the ability to
finalize wrapper objects.
(-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]): Change to no longer use wrapperClass().
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]): Ditto.
(tryUnwrapObjcObject): We now check if the object inherits from JSAPIWrapperObject.
- API/tests/testapi.mm: Added a test that exports an Objective-C object to two different JSContexts and makes
sure that the first one is collected properly by using a weak JSManagedValue for the wrapper in the first JSContext.
- CMakeLists.txt: Build file modifications.
- GNUmakefile.list.am: Ditto.
- JavaScriptCore.gypi: Ditto.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Ditto.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- runtime/JSGlobalObject.cpp: More ifdefs for unsupported platforms.
(JSC::JSGlobalObject::reset): Ditto.
(JSC::JSGlobalObject::visitChildren): Ditto.
- runtime/JSGlobalObject.h: Ditto.
(JSGlobalObject): Ditto.
(JSC::JSGlobalObject::objcCallbackFunctionStructure): Ditto.
- 11:54 AM Changeset in webkit [146493] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Hide toolbar customization experimental setting
https://bugs.webkit.org/show_bug.cgi?id=112942
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._isToolbarCustomizable):
- 11:52 AM Changeset in webkit [146492] by
-
- 10 edits10 deletes in trunk/LayoutTests
[Chromium] Unreviewed gardening.
New test results for effect-reference and effect-reference-hw.
- platform/chromium-linux-x86/css3/filters/effect-reference-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-reference-expected.txt: Removed.
- platform/chromium-linux/css3/filters/effect-reference-expected.png: Removed.
- platform/chromium-linux/css3/filters/effect-reference-expected.txt: Removed.
- platform/chromium-mac-lion/css3/filters/effect-reference-expected.png: Removed.
- platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Removed.
- platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Removed.
- platform/chromium-mac/css3/filters/effect-reference-expected.png:
- platform/chromium-mac/css3/filters/effect-reference-expected.txt:
- platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
- platform/chromium-win-xp/css3/filters/effect-reference-expected.png: Removed.
- platform/chromium-win-xp/css3/filters/effect-reference-expected.txt: Removed.
- platform/chromium-win/css3/filters/effect-reference-expected.png:
- platform/chromium-win/css3/filters/effect-reference-expected.txt:
- platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-win/css3/filters/effect-reference-hw-expected.txt:
- platform/chromium/TestExpectations:
- 11:52 AM Changeset in webkit [146491] by
-
- 2 edits in trunk/Tools
[BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
https://bugs.webkit.org/show_bug.cgi?id=112597
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Xan Lopez.
These were introduced for the Chromium port in r105295. We need
dummy implementations in order to compile the BlackBerry port.
- DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
- 11:45 AM Changeset in webkit [146490] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening.
- platform/gtk/TestExpectations: Remove redundant entry.
- 11:26 AM Changeset in webkit [146489] by
-
- 22 edits9 deletes in trunk/Source
Unreviewed, rolling out r146483.
http://trac.webkit.org/changeset/146483
https://bugs.webkit.org/show_bug.cgi?id=111695
Source/JavaScriptCore:
Breaks debug builds.
- bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.
Source/Platform:
Breaks
- Platform.gypi:
- chromium/public/Platform.h:
(WebKit):
(Platform):
- chromium/public/WebSpeechSynthesisUtterance.h: Removed.
- chromium/public/WebSpeechSynthesisVoice.h: Removed.
- chromium/public/WebSpeechSynthesizer.h: Removed.
- chromium/public/WebSpeechSynthesizerClient.h: Removed.
Source/WebCore:
Breaks
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
(WebCore):
- Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
- Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):
- Modules/speech/SpeechSynthesisUtterance.h:
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(WebCore::SpeechSynthesisUtterance::platformUtterance):
(SpeechSynthesisUtterance):
- Modules/speech/SpeechSynthesisVoice.h:
(SpeechSynthesisVoice):
- WebCore.exp.in:
- WebCore.gypi:
- platform/PlatformSpeechSynthesis.h:
(PlatformSpeechSynthesis):
- platform/PlatformSpeechSynthesisUtterance.cpp:
- platform/PlatformSpeechSynthesisUtterance.h:
(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::client):
- platform/PlatformSpeechSynthesisVoice.cpp:
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):
- platform/PlatformSpeechSynthesisVoice.h:
(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::voiceURI):
(WebCore::PlatformSpeechSynthesisVoice::name):
(WebCore::PlatformSpeechSynthesisVoice::lang):
(WebCore::PlatformSpeechSynthesisVoice::localService):
- platform/PlatformSpeechSynthesizer.cpp:
(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):
- platform/PlatformSpeechSynthesizer.h:
(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(PlatformSpeechSynthesizer):
- platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Removed.
- platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Removed.
- platform/chromium/support/WebSpeechSynthesisVoice.cpp: Removed.
- platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Removed.
- platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Removed.
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::speak):
- platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::create):
(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):
- platform/mock/PlatformSpeechSynthesizerMock.h:
(PlatformSpeechSynthesizerMock):
- 11:19 AM Changeset in webkit [146488] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Consolidate bits of willSendRequest implementation
https://bugs.webkit.org/show_bug.cgi?id=112932
Reviewed by Brady Eidson.
Moved some logic from WebCoreResourceHandleAsDelegate to ResourceHandle for clarity.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
- 11:08 AM Changeset in webkit [146487] by
-
- 2 edits in trunk/Source/Platform
[chromium] Add isOrphan() to the WebLayer API
https://bugs.webkit.org/show_bug.cgi?id=112649
Reviewed by James Robinson.
This method will be used by WebMediaPlayerClientImpl to tell
if the compositing video layer is currently being used to
display the video content or not.
- chromium/public/WebLayer.h:
(WebLayer):
- 11:08 AM Changeset in webkit [146486] by
-
- 17 edits2 adds2 deletes in trunk
Remove AudioGain.idl from compilation.
https://bugs.webkit.org/show_bug.cgi?id=112650
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-03-21
Reviewed by Chris Rogers.
Source/WebCore:
Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#GainNode
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioBufferSourceNode
AudioParam serves the same purpose as AudioGain. Infact, AudioGain inherits
AudioParam class and doesn't have its own member functions/parameters. Also,
AudioGain is not part of WebAudio W3C specifications.
Test: webaudio/gain-basic.html
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
- Modules/webaudio/AudioBufferSourceNode.h:
(AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::gain):
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioGain.h: Removed.
- Modules/webaudio/AudioGain.idl: Removed.
- Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::GainNode):
- Modules/webaudio/GainNode.h:
(WebCore):
(WebCore::GainNode::create):
(GainNode):
(WebCore::GainNode::gain):
- Modules/webaudio/GainNode.idl:
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
- Modules/webaudio/PannerNode.h:
(WebCore::PannerNode::distanceGain):
(WebCore::PannerNode::coneGain):
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
LayoutTests:
Test to verify GainNode attributes.
- webaudio/gain-basic-expected.txt: Added.
- webaudio/gain-basic.html: Added.
- 10:56 AM Changeset in webkit [146485] by
-
- 2 edits in trunk/Tools
Re-enable WinEWS tests following r146376.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 10:31 AM Changeset in webkit [146484] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening.
Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky
- platform/chromium/TestExpectations:
- 10:24 AM Changeset in webkit [146483] by
-
- 21 edits9 adds in trunk/Source
Implement Web Speech Synthesis for Chromium
https://bugs.webkit.org/show_bug.cgi?id=111695
Reviewed by Adam Barth.
Source/Platform:
Exposes a platform API that the embedder can implement to
provide speech synthesis for the Chromium port.
- Platform.gypi:
- chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::speechSynthesizer):
- chromium/public/WebSpeechSynthesisUtterance.h: Added.
(WebKit):
(WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::~WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::isNull):
- chromium/public/WebSpeechSynthesisVoice.h: Added.
(WebCore):
(WebKit):
(WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::~WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::operator=):
- chromium/public/WebSpeechSynthesizer.h: Added.
(WebKit):
(WebSpeechSynthesizer):
(WebKit::WebSpeechSynthesizer::~WebSpeechSynthesizer):
- chromium/public/WebSpeechSynthesizerClient.h: Added.
(WebKit):
(WebSpeechSynthesizerClient):
(WebKit::WebSpeechSynthesizerClient::~WebSpeechSynthesizerClient):
Source/WebCore:
Straightforward implementation of speech synthesis
for Chromium by exposing interfaces for the platform
to implement.
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
(WebCore):
- Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
- Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore):
(WebCore::SpeechSynthesisUtterance::~SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):
- Modules/speech/SpeechSynthesisUtterance.h:
(SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(WebCore::SpeechSynthesisUtterance::platformUtterance):
- Modules/speech/SpeechSynthesisVoice.h:
(WebCore::SpeechSynthesisVoice::~SpeechSynthesisVoice):
- WebCore.exp.in:
- WebCore.gypi:
- platform/PlatformSpeechSynthesis.h:
(PlatformSpeechSynthesis):
- platform/PlatformSpeechSynthesisUtterance.cpp:
(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::create):
- platform/PlatformSpeechSynthesisUtterance.h:
(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setClient):
- platform/PlatformSpeechSynthesisVoice.cpp:
(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):
- platform/PlatformSpeechSynthesisVoice.h:
(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::setVoiceURI):
(WebCore::PlatformSpeechSynthesisVoice::setName):
(WebCore::PlatformSpeechSynthesisVoice::setLang):
(WebCore::PlatformSpeechSynthesisVoice::setLocalService):
(WebCore::PlatformSpeechSynthesisVoice::setIsDefault):
- platform/PlatformSpeechSynthesizer.cpp:
(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::setVoiceList):
(WebCore):
- platform/PlatformSpeechSynthesizer.h:
(WebKit):
(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):
- platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::speak):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore::PlatformSpeechSynthesizer::resume):
(WebCore::PlatformSpeechSynthesizer::cancel):
- platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Added.
(WebKit):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::assign):
(WebKit::WebSpeechSynthesisUtterance::reset):
(WebKit::WebSpeechSynthesisUtterance::operator PassRefPtr<PlatformSpeechSynthesisUtterance>):
(WebKit::WebSpeechSynthesisUtterance::operator PlatformSpeechSynthesisUtterance*):
(WebKit::WebSpeechSynthesisUtterance::text):
(WebKit::WebSpeechSynthesisUtterance::lang):
(WebKit::WebSpeechSynthesisUtterance::voice):
(WebKit::WebSpeechSynthesisUtterance::volume):
(WebKit::WebSpeechSynthesisUtterance::rate):
(WebKit::WebSpeechSynthesisUtterance::pitch):
(WebKit::WebSpeechSynthesisUtterance::startTime):
- platform/chromium/support/WebSpeechSynthesisVoice.cpp: Added.
(WebKit):
(WebKit::WebSpeechSynthesisVoice::assign):
(WebKit::WebSpeechSynthesisVoice::reset):
(WebKit::WebSpeechSynthesisVoice::setVoiceURI):
(WebKit::WebSpeechSynthesisVoice::setName):
(WebKit::WebSpeechSynthesisVoice::setLanguage):
(WebKit::WebSpeechSynthesisVoice::setIsLocalService):
(WebKit::WebSpeechSynthesisVoice::setIsDefault):
(WebKit::WebSpeechSynthesisVoice::operator PassRefPtr<WebCore::PlatformSpeechSynthesisVoice>):
- platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Added.
(WebCore):
(WebCore::WebSpeechSynthesizerClientImpl::WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::~WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::setVoiceList):
(WebCore::WebSpeechSynthesizerClientImpl::didStartSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didFinishSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didPauseSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didResumeSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::speakingErrorOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::wordBoundaryEventOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::sentenceBoundaryEventOccurred):
- platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Added.
(WebCore):
(WebSpeechSynthesizerClientImpl):
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::speak):
- platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):
- platform/mock/PlatformSpeechSynthesizerMock.h:
(PlatformSpeechSynthesizerMock):
- 10:14 AM Changeset in webkit [146482] by
-
- 7 edits4 adds in trunk
[CSS Grid Layout] Properly layout spanning grid items with minmax grid tracks
https://bugs.webkit.org/show_bug.cgi?id=112389
Reviewed by Tony Chang.
Source/WebCore:
This change updates our core minmax resolution function to be spanning grid
items aware. The new implementation of the algorithm doesn't totally match
the specification but it is fairly close that it's a good first pass. The
extra complexity in the specification needs to be carefully examinated
first (not to mention the probable change in the core layout algorithm).
Tests: fast/css-grid-layout/minmax-spanning-resolution-columns.html
fast/css-grid-layout/minmax-spanning-resolution-rows.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Updated this function to account for spanning grid items by:
- iterating over all spanned grid tracks.
- removing any used breadth from all spanned grid tracks.
LayoutTests:
- fast/css-grid-layout/grid-item-spanning-resolution.html:
- fast/css-grid-layout/resources/grid.css:
(.firstRowBothColumn):
(.secondRowBothColumn):
(.bothRowFirstColumn):
(.bothRowSecondColumn):
(.bothRowBothColumn):
Moved the previous classes for maximum reuse.
- fast/css-grid-layout/minmax-spanning-resolution-columns-expected.txt: Added.
- fast/css-grid-layout/minmax-spanning-resolution-columns.html: Added.
- fast/css-grid-layout/minmax-spanning-resolution-rows-expected.txt: Added.
- fast/css-grid-layout/minmax-spanning-resolution-rows.html: Added.
New tests.
- fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
- fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:
Unintended consistent progression from this change, it's unclear why these baselines
change as the tests involve no spanning.
- 9:55 AM Changeset in webkit [146481] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening.
Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky
- platform/chromium/TestExpectations:
- 9:51 AM Changeset in webkit [146480] by
-
- 2 edits in trunk/Tools
Unreviewed. Add Bem Jones-Bey to the list of contributors.
- Scripts/webkitpy/common/config/committers.py:
- 9:45 AM Changeset in webkit [146479] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] New reference returned by g_main_context_new() must be freed
https://bugs.webkit.org/show_bug.cgi?id=112899
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-21
Reviewed by Kenneth Rohde Christiansen.
Fix a memory leak by adopting the new reference returned
by g_main_context_new().
No new tests. No change in behavior.
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createBus):
- 9:32 AM Changeset in webkit [146478] by
-
- 4 edits3 adds in trunk/Source/WebCore
[BlackBerry] Add ScrollingCoordinatorBlackBerry implementation
https://bugs.webkit.org/show_bug.cgi?id=112915
Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-03-21
Reviewed by Rob Buis.
- PlatformBlackBerry.cmake: Add page/scrolling/blackberry to the
indlude dir list.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::create): Create a
ScrollingCoordinatorBlackBerry for the BlackBerry platform.
- page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp: Added.
(WebCore):
(WebCore::ScrollingCoordinatorBlackBerry::ScrollingCoordinatorBlackBerry):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerIsFixedToContainerLayer):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerFixedToContainerLayerEdge):
(WebCore::ScrollingCoordinatorBlackBerry::frameViewFrameRectDidChange):
(WebCore::ScrollingCoordinatorBlackBerry::frameViewContentsSizeDidChange):
- page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.h: Added.
(WebCore):
(ScrollingCoordinatorBlackBerry):
(WebCore::ScrollingCoordinatorBlackBerry::supportsFixedPositionLayers):
- platform/graphics/PlatformLayer.h:
(WebCore): Add PlatformLayer definition for BlackBerry.
- 9:28 AM Changeset in webkit [146477] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening.
Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky
- platform/chromium/TestExpectations:
- 8:57 AM Changeset in webkit [146476] by
-
- 9 edits1 add in trunk
Web Inspector: Paint rectangles shown on hover over Timeline's paint records occasionally have wrong offsets
https://bugs.webkit.org/show_bug.cgi?id=112371
Reviewed by Pavel Feldman.
Source/WebCore:
- pass frame to InspectorTimelineAgent::didPaint();
- convert paint coordinates to root view.
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didPaint):
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
LayoutTests:
- http/tests/inspector/timeline-test.js:
(initialize_Timeline.InspectorTest.startTimeline.InspectorTest._addTimelineEvent):
(initialize_Timeline.InspectorTest.startTimeline):
(initialize_Timeline.addEvent):
(initialize_Timeline.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):
(initialize_Timeline.InspectorTest.stopTimeline):
- inspector/timeline/timeline-paint-expected.txt:
- inspector/timeline/timeline-paint.html:
- 8:49 AM WebKitGTK/2.0.x edited by
- (diff)
- 8:49 AM Changeset in webkit [146475] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: do not use inspector cookie in InspectorInstrumentation::{will,did}Paint
https://bugs.webkit.org/show_bug.cgi?id=112787
Reviewed by Pavel Feldman.
- pass frame, not inspector cookie to InspectorInstrumentation::didPaint;
- use frame to determine timeline agent in InspectorInstrumentation::didPaint.
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):
- page/FrameView.cpp:
(WebCore::FrameView::paintContents):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):
- 8:36 AM Changeset in webkit [146474] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
https://bugs.webkit.org/show_bug.cgi?id=103035
Patch by Sandeep Shedmake <sshedmak@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).
- mr.po: updated.
- 8:30 AM Changeset in webkit [146473] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge 146463 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100590
Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).
- pl.po: Updated.
- 8:28 AM Changeset in webkit [146472] by
-
- 2 edits in trunk/Tools
[GTK] Missing atk in install-dependencies script
https://bugs.webkit.org/show_bug.cgi?id=112272
Reviewed by Gustavo Noronha Silva.
- gtk/install-dependencies: Add missing atk dependency.
- 8:16 AM Changeset in webkit [146471] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Marking http/tests/appcache/abort-cache-ondownloading-resource-404.html as flaky.
Unskipping tests under perf/ to see how they behave.
- platform/gtk/TestExpectations:
- 8:09 AM Changeset in webkit [146470] by
-
- 3 edits2 adds in trunk
[CSS Grid Layout] OOB access in RenderGrid with a grid item with negative position index
https://bugs.webkit.org/show_bug.cgi?id=112853
Reviewed by Tony Chang.
Source/WebCore:
This issue was caused by us casting a negative int to a size_t by mistake. This
would make us not size the grid properly thus yielding to OOB access during the
rest of the layout.
Test: fast/css-grid-layout/grid-item-negative-indexes.html
- rendering/RenderGrid.cpp:
(WebCore::estimatedGridSizeForPosition):
Added this helper function to do the proper estimation and checks that our
position can be represented by a size_t.
(WebCore::RenderGrid::maximumIndexInDirection):
Updated to use estimatedGridSizeForPosition.
LayoutTests:
- fast/css-grid-layout/grid-item-negative-indexes-expected.txt: Added.
- fast/css-grid-layout/grid-item-negative-indexes.html: Added.
- 7:58 AM Changeset in webkit [146469] by
-
- 7 edits1 add in trunk
[skia] feConvolveMatrix should use accelerated path
https://bugs.webkit.org/show_bug.cgi?id=112828
Reviewed by James Robinson.
Source/WebCore:
Covered by layout tests css3/filters/effect-reference*.html.
- WebCore.gypi:
Add FEConvolveMatrixSkia.cpp to the build.
- platform/graphics/filters/FEConvolveMatrix.h:
Enable the skia accelerated path for feConvolveMatrix.
- platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp:
(WebCore::FEConvolveMatrix::createImageFilter):
Implement building/conversion from FEConvolveMatrix to
SkMatrixConvolutionImageFilter.
LayoutTests:
- css3/filters/effect-reference-hw.html:
- css3/filters/effect-reference.html:
Add new test case for feConvolveMatrix as a reference filter.
- platform/chromium/TestExpectations:
Suppress failures until the test can be rebaselined.
- 7:56 AM Changeset in webkit [146468] by
-
- 5 edits in trunk
Source/ThirdParty/leveldb/db/builder.cc does not build on systems without <endian.h>
https://bugs.webkit.org/show_bug.cgi?id=111817
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva.
.:
Improve processing of the autoconf host variable. Setup up the wiring to detect
whether or not we are compiling for Darwin.
- Source/autotools/CheckSystemAndBasicDependencies.m4: Improve host detection.
- Source/autotools/SetupAutomake.m4: Tell automake if we are compiling for Darwin or not.
Source/WebCore:
- GNUmakefile.am: Add the appropriate flags to the LevelDB build if we are on FreeBSD
or OS X.
- 7:53 AM Changeset in webkit [146467] by
-
- 3 edits6 adds in trunk
[CSS Grid Layout] Support default grid items sizing
https://bugs.webkit.org/show_bug.cgi?id=103333
Reviewed by Tony Chang.
Source/WebCore:
Tests: fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html
fast/css-grid-layout/grid-auto-columns-rows-resolution.html
fast/css-grid-layout/grid-auto-columns-rows-update.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::gridTrackSize):
Core of the change: return the grid-auto-{rows|columns} instead of a pre-defined value.
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Fixed a latent bug: we need to iterate over the internal grid representation instead of the
style's rows / columns as the latter doesn't account for implicit rows / columns.
LayoutTests:
- fast/css-grid-layout/grid-auto-columns-rows-resolution-expected.txt: Added.
- fast/css-grid-layout/grid-auto-columns-rows-resolution.html: Added.
This test covers the simple implicit column / row case.
- fast/css-grid-layout/grid-auto-columns-rows-update-expected.txt: Added.
- fast/css-grid-layout/grid-auto-columns-rows-update.html: Added.
This test covers that modifying grid-auto-{rows|columns} updates the grid items' sizes.
- fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution-expected.txt: Added.
- fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html: Added.
This test covers the implicit rows / columns generated by the auto placement. We are failing
2 sub-tests due to a bug involving percentage grid items in grid rows.
- 7:46 AM Changeset in webkit [146466] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip some failing tests.
- platform/qt/TestExpectations:
- 7:43 AM Changeset in webkit [146465] by
-
- 2 edits in trunk/Tools
[GTK] Missing backslash in install-dependencies script
https://bugs.webkit.org/show_bug.cgi?id=112907
Reviewed by Philippe Normand.
- gtk/install-dependencies: Add missing backslash to dependencies
list.
- 7:30 AM Changeset in webkit [146464] by
-
- 11 edits1 add in trunk/Source
HTMLNames should construct strings at compile time
https://bugs.webkit.org/show_bug.cgi?id=112831
Reviewed by Darin Adler.
Source/WebCore:
This patch teaches make_names how to construct strings at compile time,
eliminating a large number of startup mallocs.
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/action_makenames.py:
- Teach the Chromium build how to deal with Perl modules.
- bindings/scripts/StaticString.pm: Added.
- A Perl module for constructing static strings.
(GenerateStrings):
(GenerateValidateStrings):
- dom/QualifiedName.cpp:
(WebCore::createQualifiedName):
- createQualifiedName now takes an already-constructed StringImpl object.
- dom/QualifiedName.h:
- dom/make_names.pl:
(valueForName):
(namesToStrings):
(printNamesCppFile):
(printDefinitions):
- Teach make_names how to use StaticString.pm.
Source/WTF:
- wtf/text/StringImpl.h:
(StringImpl):
(StaticASCIILiteral):
- This struct lets us construct StringImpl objects at compile time.
(WTF::StringImpl::assertHashIsCorrect):
- This function lets us sanity check StringImpl objects created from StaticData.
(WTF::StringImpl::find): Remove a stray ;
(WTF::StringImpl::findIgnoringCase): ditto
(WTF::StringImpl::startsWith): ditto
(WTF::ValueCheck<StringImpl*>):
- wtf/text/AtomicStringImpl.h:
(WTF::ValueCheck<AtomicStringImpl*>):
- 7:09 AM Changeset in webkit [146463] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100590
Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).
- pl.po: Updated.
- 6:50 AM Changeset in webkit [146462] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge 146461 - [as-IN] Translations of WebKitGtk+
https://bugs.webkit.org/show_bug.cgi?id=112791
Patch by Nilamdyuti Goswami <ngoswami@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).
- as.po: Updated.
- 6:49 AM Changeset in webkit [146461] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[as-IN] Translations of WebKitGtk+
https://bugs.webkit.org/show_bug.cgi?id=112791
Patch by Nilamdyuti Goswami <ngoswami@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).
- as.po: Updated.
- 6:43 AM Changeset in webkit [146460] by
-
- 10 edits10 adds in trunk/LayoutTests
[EFL] Rebaseline most "needs rebaseline" sections of EFL test expectations, and update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=112901
https://bugs.webkit.org/show_bug.cgi?id=105437
https://bugs.webkit.org/show_bug.cgi?id=65643
https://bugs.webkit.org/show_bug.cgi?id=14664
https://bugs.webkit.org/show_bug.cgi?id=110654
Unreviewed, rebaselining.
Adding failure expectation for the test added in r133834.
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-03-21
- platform/efl/TestExpectations:
- platform/efl/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/efl/fast/block/float/024-expected.txt:
- platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
- platform/efl/fast/repaint/moving-shadow-on-container-expected.png: Added.
- platform/efl/fast/repaint/moving-shadow-on-container-expected.txt: Added.
- platform/efl/svg/css/arrow-with-shadow-expected.txt:
- platform/efl/svg/css/clippath-with-shadow-expected.txt:
- platform/efl/svg/css/composite-shadow-example-expected.png: Added.
- platform/efl/svg/css/composite-shadow-example-expected.txt: Added.
- platform/efl/svg/css/composite-shadow-with-opacity-expected.png: Added.
- platform/efl/svg/css/composite-shadow-with-opacity-expected.txt: Added.
- platform/efl/svg/custom/feDisplacementMap-01-expected.png: Added.
- platform/efl/svg/custom/feDisplacementMap-01-expected.txt: Added.
- platform/efl/svg/custom/foreign-object-skew-expected.png: Added.
- platform/efl/svg/custom/foreign-object-skew-expected.txt:
- platform/efl/svg/custom/simple-text-double-shadow-expected.png: Added.
- platform/efl/svg/custom/simple-text-double-shadow-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug92647-2-expected.txt:
- 6:19 AM Changeset in webkit [146459] by
-
- 9 edits in trunk/Source
Implement LLInt for CPU(ARM_TRADITIONAL)
https://bugs.webkit.org/show_bug.cgi?id=97589
Reviewed by Zoltan Herczeg.
Enable LLInt for ARMv5 and ARMv7 traditional as well.
Source/JavaScriptCore:
- llint/LLIntOfflineAsmConfig.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- offlineasm/arm.rb:
- offlineasm/backends.rb:
- offlineasm/instructions.rb:
Source/WTF:
- wtf/Platform.h:
- 6:14 AM Changeset in webkit [146458] by
-
- 10 edits2 moves2 adds in trunk/Source/WebCore
[EFL][WebGL] Implement a common GraphicsSurface Implementation.
https://bugs.webkit.org/show_bug.cgi?id=111759
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-21
Reviewed by Kenneth Rohde Christiansen.
Covered by existing WebGL tests.
This is in preparation to add transport surface support for GLES2.
This patch makes it easy to share the core logic of using
Transport Surface and client on GLX and GLES2 backends without
any code duplication.
- PlatformEfl.cmake:
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::releaseResources):
(WebCore::GraphicsContext3DPrivate::prepareBuffer):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::didResizeCanvas):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
- platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
TransportSurface related code is moved to GraphicsSurfaceCommon.
As GraphicsSurface is deleted on resize, added logic to ensure that
current buffer is not deleted before having the shared buffer
with correct size. This would avoid any flashing during resize.
- platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::createTransportSurface):
- platform/graphics/opengl/GLPlatformSurface.h:
- platform/graphics/surfaces/efl/GLTransportSurface.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp.
(WebCore):
(WebCore::GLTransportSurface::GLTransportSurface):
(WebCore::GLTransportSurface::~GLTransportSurface):
(WebCore::GLTransportSurface::updateContents):
(WebCore::GLTransportSurface::setGeometry):
(WebCore::GLTransportSurface::destroy):
(WebCore::GLTransportSurface::draw):
(WebCore::GLTransportSurface::bindArrayBuffer):
(WebCore::GLTransportSurface::updateTransformationMatrix):
(WebCore::GLTransportSurface::initializeShaderProgram):
(WebCore::GLTransportSurfaceClient::createTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::~GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::destroy):
(WebCore::GLTransportSurfaceClient::prepareTexture):
(WebCore::GLTransportSurfaceClient::createTexture):
- platform/graphics/surfaces/efl/GLTransportSurface.h: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.h.
(WebCore):
(GLTransportSurface):
(GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::texture):
(WebCore::GLTransportSurfaceClient::hasAlpha):
Moved TransportSurface to EFL folder as this is being used by EFL port only.
Added a base class for TransportSurfaceClient.
- platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp: Added.
(WebCore):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::destroy):
(WebCore::GraphicsSurfacePrivate::initializeTransportSurface):
(WebCore::GraphicsSurfacePrivate::makeContextCurrent):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::handle):
(WebCore::GraphicsSurfacePrivate::updateClientBuffer):
(WebCore::GraphicsSurfacePrivate::flags):
(WebCore::GraphicsSurfacePrivate::rect):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::textureId):
(WebCore::GraphicsSurfacePrivate::initializeClient):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromTexture):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformSize):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):
GraphicsSurface implementation to be shared by both GLX and GLES2.
- platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
- platform/graphics/surfaces/egl/EGLSurface.h:
(EGLWindowTransportSurface):
- platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore):
(WebCore::resolveGLMethods):
(WebCore::isMesaGLX):
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurfaceClient::GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::~GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::destroy):
(WebCore::GLXTransportSurfaceClient::prepareTexture):
- platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXTransportSurfaceClient):
(WebCore):
GLXTransportSurfaceClient implementation.
- 5:58 AM Changeset in webkit [146457] by
-
- 7 edits1 delete in trunk
Unreviewed, rolling out r146454.
http://trac.webkit.org/changeset/146454
https://bugs.webkit.org/show_bug.cgi?id=112906
compile failures (Requested by antonm on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-21
Source/WebCore:
- WebCore.gypi:
- platform/graphics/filters/FEConvolveMatrix.h:
(FEConvolveMatrix):
- platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp: Removed.
LayoutTests:
- css3/filters/effect-reference-hw.html:
- css3/filters/effect-reference.html:
- platform/chromium/TestExpectations:
- 5:49 AM Changeset in webkit [146456] by
-
- 2 edits in trunk/Source/WebCore
Remove obsolete conditionals around calling SkTypeface::getUnitsPerEm()
https://bugs.webkit.org/show_bug.cgi?id=112846
Reviewed by Stephen White.
Existing complex-text layouttests exercise this code.
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::emSizeInFontUnits):
- 5:28 AM Changeset in webkit [146455] by
-
- 39 edits44 adds14 deletes in trunk/LayoutTests
2013-03-21 Anton Muhin <antonm@chromium.org>
Unreviewed Chromium gardening.
Mass rebaselining.
- fast/repaint/moving-shadow-on-container-expected.txt: Removed.
- platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.png: Added.
- platform/chromium-linux-x86/platform/chromium/fast: Added.
- platform/chromium-linux-x86/platform/chromium/fast/forms: Added.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker: Added.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
- platform/chromium-linux-x86/svg/css/composite-shadow-example-expected.txt:
- platform/chromium-linux-x86/svg/css/composite-shadow-with-opacity-expected.txt:
- platform/chromium-linux-x86/svg/css/shadow-changes-expected.txt: Added.
- platform/chromium-linux-x86/svg/custom/simple-text-double-shadow-expected.txt: Added.
- platform/chromium-linux-x86/svg/repaint: Added.
- platform/chromium-linux-x86/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
- platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
- platform/chromium-linux/svg/css/composite-shadow-example-expected.png:
- platform/chromium-linux/svg/css/composite-shadow-example-expected.txt: Added.
- platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
- platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.png:
- platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.txt: Added.
- platform/chromium-linux/svg/css/shadow-changes-expected.png:
- platform/chromium-linux/svg/css/shadow-changes-expected.txt: Added.
- platform/chromium-linux/svg/custom/simple-text-double-shadow-expected.txt: Added.
- platform/chromium-linux/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
- platform/chromium-mac-lion/fast/repaint/moving-shadow-on-container-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
- platform/chromium-mac-lion/svg/css/composite-shadow-example-expected.png:
- platform/chromium-mac-lion/svg/css/composite-shadow-example-expected.txt: Added.
- platform/chromium-mac-lion/svg/css/composite-shadow-text-expected.png:
- platform/chromium-mac-lion/svg/css/composite-shadow-with-opacity-expected.png:
- platform/chromium-mac-lion/svg/css/composite-shadow-with-opacity-expected.txt: Added.
- platform/chromium-mac-lion/svg/css/shadow-changes-expected.png:
- platform/chromium-mac-lion/svg/css/shadow-changes-expected.txt: Added.
- platform/chromium-mac-lion/svg/custom/simple-text-double-shadow-expected.txt: Added.
- platform/chromium-mac-lion/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
- platform/chromium-mac-snowleopard/svg/css/composite-shadow-example-expected.png:
- platform/chromium-mac-snowleopard/svg/css/composite-shadow-example-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/css/composite-shadow-text-expected.png:
- platform/chromium-mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png:
- platform/chromium-mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/css/shadow-changes-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/custom/simple-text-double-shadow-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
- platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
- platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
- platform/chromium-mac/svg/css/arrow-with-shadow-expected.png:
- platform/chromium-mac/svg/css/composite-shadow-example-expected.png:
- platform/chromium-mac/svg/css/composite-shadow-example-expected.txt: Added.
- platform/chromium-mac/svg/css/composite-shadow-text-expected.png:
- platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.png:
- platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.txt: Added.
- platform/chromium-mac/svg/css/shadow-changes-expected.png:
- platform/chromium-mac/svg/css/shadow-changes-expected.txt:
- platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.txt: Added.
- platform/chromium-mac/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
- platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.png: Added.
- platform/chromium-win-xp/svg/css/composite-shadow-example-expected.txt: Added.
- platform/chromium-win-xp/svg/css/composite-shadow-text-expected.png:
- platform/chromium-win-xp/svg/css/composite-shadow-with-opacity-expected.txt: Added.
- platform/chromium-win-xp/svg/css/shadow-changes-expected.png:
- platform/chromium-win-xp/svg/css/shadow-changes-expected.txt: Added.
- platform/chromium-win-xp/svg/custom/simple-text-double-shadow-expected.txt: Added.
- platform/chromium-win-xp/svg/repaint: Added.
- platform/chromium-win-xp/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
- platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
- platform/chromium-win/svg/css/arrow-with-shadow-expected.png:
- platform/chromium-win/svg/css/composite-shadow-example-expected.png:
- platform/chromium-win/svg/css/composite-shadow-example-expected.txt: Added.
- platform/chromium-win/svg/css/composite-shadow-text-expected.png:
- platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.png:
- platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.txt: Added.
- platform/chromium-win/svg/css/shadow-changes-expected.png:
- platform/chromium-win/svg/css/shadow-changes-expected.txt:
- platform/chromium-win/svg/custom/simple-text-double-shadow-expected.txt:
- platform/chromium-win/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/fast/repaint/moving-shadow-on-container-expected.txt: Added.
- platform/chromium/svg/css/arrow-with-shadow-expected.txt: Removed.
- platform/chromium/svg/css/clippath-with-shadow-expected.txt: Removed.
- platform/efl/fast/repaint/moving-shadow-on-container-expected.txt: Added.
- platform/gtk/svg/css/arrow-with-shadow-expected.txt: Removed.
- platform/gtk/svg/css/clippath-with-shadow-expected.txt: Removed.
- platform/gtk/svg/css/composite-shadow-text-expected.png: Removed.
- platform/mac/svg/css/arrow-with-shadow-expected.txt: Removed.
- platform/mac/svg/css/clippath-with-shadow-expected.txt: Removed.
- platform/mac/svg/css/composite-shadow-text-expected.png: Removed.
- platform/qt/svg/css/arrow-with-shadow-expected.txt: Removed.
- platform/qt/svg/css/clippath-with-shadow-expected.txt: Removed.
- platform/qt/svg/repaint/repaint-webkit-svg-shadow-expected.txt: Removed.
- svg/css/arrow-with-shadow-expected.txt: Added.
- svg/css/clippath-with-shadow-expected.txt: Added.
- svg/css/composite-shadow-text-expected.png: Added.
- 5:16 AM Changeset in webkit [146454] by
-
- 7 edits1 add in trunk
[skia] feConvolveMatrix should use accelerated path
https://bugs.webkit.org/show_bug.cgi?id=112828
Reviewed by James Robinson.
Source/WebCore:
Covered by layout tests css3/filters/effect-reference*.html.
- WebCore.gypi:
Add FEConvolveMatrixSkia.cpp to the build.
- platform/graphics/filters/FEConvolveMatrix.h:
Enable the skia accelerated path for feConvolveMatrix.
- platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp:
(WebCore::FEConvolveMatrix::createImageFilter):
Implement building/conversion from FEConvolveMatrix to
SkMatrixConvolutionImageFilter.
LayoutTests:
- css3/filters/effect-reference-hw.html:
- css3/filters/effect-reference.html:
Add new test case for feConvolveMatrix as a reference filter.
- platform/chromium/TestExpectations:
Suppress failures until the test can be rebaselined.
- 4:54 AM Changeset in webkit [146453] by
-
- 6 edits in trunk/Source/WebCore
Refactoring: Reorganize datetime field element parameters
https://bugs.webkit.org/show_bug.cgi?id=112877
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-21
Reviewed by Kent Tamura.
Before this patch, the field element constructors took minimum/maximum
as a pair of integers, and step/stepbase as a DateTimeNumericFieldElement::Parameters.
This patch makes these constructors to take a Range (for minimum/maximum)
and a Step (for step/stepbase).
No new tests. Just refactoring.
- html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Replaced min/max data members by Ranges.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditBuilder::shouldAMPMFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldDayOfMonthFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldMinuteFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldSecondFieldDisabled):
(WebCore::DateTimeEditBuilder::createStep):
- html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeHourFieldElementBase::DateTimeHourFieldElementBase):
(WebCore::DateTimeHour11FieldElement::DateTimeHour11FieldElement):
(WebCore::DateTimeHour11FieldElement::create):
(WebCore::DateTimeHour12FieldElement::DateTimeHour12FieldElement):
(WebCore::DateTimeHour12FieldElement::create):
(WebCore::DateTimeHour23FieldElement::DateTimeHour23FieldElement):
(WebCore::DateTimeHour23FieldElement::create):
(WebCore::DateTimeHour24FieldElement::DateTimeHour24FieldElement):
(WebCore::DateTimeHour24FieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeWeekFieldElement::DateTimeWeekFieldElement):
(WebCore::DateTimeWeekFieldElement::create):
- html/shadow/DateTimeFieldElements.h:
(DateTimeDayFieldElement):
(DateTimeHourFieldElementBase):
(DateTimeHour11FieldElement):
(DateTimeHour12FieldElement):
(DateTimeHour23FieldElement):
(DateTimeHour24FieldElement):
(DateTimeMillisecondFieldElement):
(DateTimeMinuteFieldElement):
(DateTimeMonthFieldElement):
(DateTimeSecondFieldElement):
(DateTimeWeekFieldElement):
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore):
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::roundDown):
(WebCore::DateTimeNumericFieldElement::roundUp):
- html/shadow/DateTimeNumericFieldElement.h:
(WebCore::DateTimeNumericFieldElement::Step::Step): Renamed from Parameters.
(WebCore::DateTimeNumericFieldElement::Range::Range):
(WebCore::DateTimeNumericFieldElement::Range::isSingleton): Returns true if the range is a singleton range (i.e. contains exactly one value).
(Range): Now it's parameter type, hence public.
(DateTimeNumericFieldElement): Replaced two int members (m_step and m_stepBase) by a Range.
- 4:41 AM Changeset in webkit [146452] by
-
- 5 edits2 adds in trunk
Web Inspector: Track CSS error location information.
https://bugs.webkit.org/show_bug.cgi?id=111314
Source/WebCore:
Added CSS syntax error reporting to some (other rules will be covered later) error recovery grammar rules.
Added code to CSSParser to allow track error location information.
Added empty rule to declaration_list. Needed to not report error about declarations like "body {}".
Added helper grammar rule "errors: error | errors error". Handles the same grammar as "error" but simplifies error location tracking.
Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.
Test: inspector/console/console-css-warnings.html
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::currentLocation):
(WebCore):
(WebCore::CSSParser::realLex):
- css/CSSParser.h:
(CSSParser):
LayoutTests:
Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.
- inspector/console/console-css-warnings-expected.txt: Added.
- inspector/console/console-css-warnings.html: Added.
- 4:17 AM Changeset in webkit [146451] by
-
- 3 edits in trunk/Source/WebCore
Changing "#define YYDEBUG 0" to 1 causing compilation error
https://bugs.webkit.org/show_bug.cgi?id=111178
Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.
Code that reference tokens can't be placed into CSSGrammar.yy.include because it's included before tokens defined.
YYDEBUG can't be used in CSSGrammar.yy.in because the #define is only defined in CSSGrammar.yy.include. This
change simplifies CSS debugging letting manipulate only #define YYDEBUG in CSSGrammar.yy.include and/or in CSSParser.cpp.
- css/CSSGrammar.y.in:
- css/CSSGrammar.y.includes:
- 3:40 AM Changeset in webkit [146450] by
-
- 2 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 2:05 AM Changeset in webkit [146449] by
-
- 13 edits2 deletes in trunk/Source/WebCore
Merge MainResourceLoader into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=104969
Patch by Nate Chapin <Nate Chapin> on 2013-03-21
Reviewed by Adam Barth.
No new tests, refactor only.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::mainResourceLoader):
(WebCore::DocumentLoader::~DocumentLoader): Move main resource clearing from
~MainResourceLoader.
(WebCore::DocumentLoader::mainResourceData):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::notifyFinished): Moved from MainResourceLoader::notifyFinished.
(WebCore):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
(WebCore::DocumentLoader::redirectReceived):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::reportMemoryUsage):
(WebCore::DocumentLoader::dataReceived):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::setDefersLoading):
(WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):
(WebCore::DocumentLoader::addSubresourceLoader):
(WebCore::DocumentLoader::maybeLoadEmpty):
(WebCore::DocumentLoader::startLoadingMainResource): Don't keep separate checks
for normal and empty loads, just use a single boolean.
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::isLoadingMainResource):
- loader/MainResourceLoader.cpp: Removed.
- loader/MainResourceLoader.h: Removed.
- loader/mac/DocumentLoaderMac.cpp:
(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):
- 1:02 AM Changeset in webkit [146448] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Flame Chart. draw background for the FlameChart overview pane with the CPU aggregated data.
https://bugs.webkit.org/show_bug.cgi?id=112823
Reviewed by Yury Semikhatsky.
The idea of the patch is to collect the data about stack depth for the each X
and draw a line with help of this data.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype._drawOverviewCanvas):
(WebInspector.FlameChart.prototype.update):
- 12:52 AM Changeset in webkit [146447] by
-
- 3 edits in trunk/Source/WebKit2
Tiled page overlay layers don't create tiles until the first flush after they switch to being tiled
https://bugs.webkit.org/show_bug.cgi?id=112860
<rdar://problem/13468400>
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea): Add storage for m_clipsToExposedRect.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
The page overlay layer will never have children, so we can use flushCompositingState instead of the ForThisLayerOnly variant.
Pass the visible rect of the page overlay layer (computed by intersecting its bounds with the exposed
rect that comes from the WKView) to flushCompositingState; don't bother setting the visible rect manually.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
Store m_clipsToExposedRect so we can use it in flushLayers.
- 12:49 AM Changeset in webkit [146446] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectation for the test added in r146427.
Removing failure expectations for tests fixed by r146430.
- platform/gtk/TestExpectations:
- 12:42 AM Changeset in webkit [146445] by
-
- 2 edits in trunk/Source/WebKit
Windows build fix after r146430.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 12:42 AM Changeset in webkit [146444] by
-
- 7 edits1 add1 delete in trunk/LayoutTests
Correct some apparent problems in previous rebaselines.
Unreviewed, rebaselining.
- css2.1/20110323/replaced-elements-001-expected.txt: Added.
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-win-xp/css3/flexbox: Removed.
- platform/chromium-win/css3/flexbox/button-expected.png:
- 12:30 AM Changeset in webkit [146443] by
-
- 7 edits in trunk/Tools
EWS bots have stopped uploading results to bugzilla
https://bugs.webkit.org/show_bug.cgi?id=101091
Reviewed by Adam Barth.
The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
this relative file path resoled to a file inside a non-existent directory for "zip".
Fixed the bug by resolving both test results directory and zip archive paths in
LayoutTestResultsReader.archive.
Also made workspace.create_zip print the source_path so that we may debug these issues more easily
in the future.
- Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
- Scripts/webkitpy/common/system/workspace.py:
(Workspace.create_zip): Log the source path when "zip" failed.
- Scripts/webkitpy/common/system/workspace_mock.py:
(MockWorkspace.create_zip): Record zip_path and source_path for testing.
- Scripts/webkitpy/common/system/workspace_unittest.py:
(WorkspaceTest.test_create_zip_exception): Test that.
- Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
(LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
This is the actual bug fix.
- Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(test_archive_last_layout_test_results_with_relative_path): Added a test case.
- 12:15 AM Changeset in webkit [146442] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Settings] Fix JS compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=112879
Reviewed by Pavel Feldman.
Removed erroneous JSDoc.
- inspector/front-end/Settings.js: Removed erroneous JSDoc.
Mar 20, 2013:
- 11:35 PM Changeset in webkit [146441] by
-
- 165 edits21 adds18 deletes in trunk/LayoutTests
[chromium] Rebaseline most "needs rebaseline" sections of Chromium test expectations, and fix a few other wrong expectations.
https://bugs.webkit.org/show_bug.cgi?id=11645
https://bugs.webkit.org/show_bug.cgi?id=89826
https://bugs.webkit.org/show_bug.cgi?id=96597
https://bugs.webkit.org/show_bug.cgi?id=97325
https://bugs.webkit.org/show_bug.cgi?id=101396
https://bugs.webkit.org/show_bug.cgi?id=102624
https://bugs.webkit.org/show_bug.cgi?id=103149
https://bugs.webkit.org/show_bug.cgi?id=106746
https://bugs.webkit.org/show_bug.cgi?id=107339
https://bugs.webkit.org/show_bug.cgi?id=109439
https://bugs.webkit.org/show_bug.cgi?id=110654
https://bugs.webkit.org/show_bug.cgi?id=111319
https://bugs.webkit.org/show_bug.cgi?id=112755
http://crbug.com/67416
http://crbug.com/148638
Unreviewed, test expectations update.
- css2.1/20110323/replaced-elements-001-expected.txt: Removed.
- fast/css/empty-generated-content-expected.txt: Added.
- fast/css/word-space-extra-expected.txt: Added.
- fast/table/025-expected.txt: Added.
- platform/chromium-linux-x86/css3/masking: Added.
- platform/chromium-linux-x86/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
- platform/chromium-linux-x86/fast/forms/date: Removed.
- platform/chromium-linux-x86/fast/forms/time: Removed.
- platform/chromium-linux-x86/platform/chromium/fast: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Removed.
- platform/chromium-linux/css3/masking/clip-path-circle-relative-overflow-expected.png:
- platform/chromium-linux/fast/css/word-space-extra-expected.txt: Removed.
- platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/css2.1/20110323/replaced-elements-001-expected.png:
- platform/chromium-mac-lion/css3/masking: Added.
- platform/chromium-mac-lion/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
- platform/chromium-mac-lion/fast/css/word-space-extra-expected.png: Added.
- platform/chromium-mac-lion/fast/multicol/vertical-rl/float-multicol-expected.png:
- platform/chromium-mac-lion/fast/table/025-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/css2.1/20110323/replaced-elements-001-expected.png:
- platform/chromium-mac-snowleopard/css3/masking: Added.
- platform/chromium-mac-snowleopard/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/word-space-extra-expected.png:
- platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/float-multicol-expected.png:
- platform/chromium-mac-snowleopard/fast/table/025-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/css2.1/20110323/replaced-elements-001-expected.png:
- platform/chromium-mac/css3/masking/clip-path-circle-relative-overflow-expected.png:
- platform/chromium-mac/fast/css/word-space-extra-expected.png:
- platform/chromium-mac/fast/css/word-space-extra-expected.txt: Removed.
- platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png:
- platform/chromium-mac/fast/table/025-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win-xp/css3/masking: Added.
- platform/chromium-win-xp/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.png:
- platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/chromium-win/css3/masking/clip-path-circle-relative-overflow-expected.png:
- platform/chromium-win/fast/css/empty-generated-content-expected.txt:
- platform/chromium-win/fast/css/word-space-extra-expected.png:
- platform/chromium-win/fast/css/word-space-extra-expected.txt:
- platform/chromium-win/fast/events/stopPropagation-submit-expected.txt: Added.
- platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/chromium-win-xp/css2.1/20110323/replaced-elements-001-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/css3/filters/filter-property-parsing-expected.txt: Replaced.
- platform/chromium/fast/css/empty-generated-content-expected.txt: Removed.
- platform/chromium/fast/table/025-expected.txt: Removed.
- platform/mac/css2.1/20110323/replaced-elements-001-expected.txt: Removed.
- platform/mac/fast/css/empty-generated-content-expected.txt: Removed.
- platform/mac/fast/css/word-space-extra-expected.txt: Removed.
- platform/mac/fast/table/025-expected.txt: Removed.
- platform/win-future/css2.1: Added.
- platform/win-future/css2.1/20110323: Added.
- platform/win-future/css2.1/20110323/replaced-elements-001-expected.txt: Added.
- platform/win/fast/css/empty-generated-content-expected.txt: Removed.
- 11:22 PM Changeset in webkit [146440] by
-
- 2 edits in trunk/LayoutTests
Add a flaky crash test expectation per bug 112881.
- platform/win/TestExpectations:
- 11:16 PM Changeset in webkit [146439] by
-
- 11 edits5 moves1 add1 delete in trunk/Tools
[chromium] move WebThemeEngine implementations to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=112751
Reviewed by Adam Barth.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::themeEngine):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebKit):
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::themeEngine):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
(WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
(WebTestRunner):
(WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
(WebTestRunner::WebTestThemeControlWin::box):
(WebTestRunner::WebTestThemeControlWin::line):
(WebTestRunner::WebTestThemeControlWin::triangle):
(WebTestRunner::WebTestThemeControlWin::roundRect):
(WebTestRunner::WebTestThemeControlWin::oval):
(WebTestRunner::WebTestThemeControlWin::circle):
(WebTestRunner::WebTestThemeControlWin::nestedBoxes):
(WebTestRunner::WebTestThemeControlWin::markState):
(WebTestRunner::WebTestThemeControlWin::draw):
(WebTestRunner::WebTestThemeControlWin::drawTextField):
(WebTestRunner::WebTestThemeControlWin::drawProgressBar):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
(WebTestRunner):
(WebTestThemeControlWin):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
(WebTestRunner):
(WebTestThemeEngineMac):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
(WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
(WebTestRunner::WebTestThemeEngineWin::paintButton):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineWin::paintMenuList):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
(WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
(WebTestRunner::WebTestThemeEngineWin::paintTextField):
(WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
(WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
(WebTestRunner::WebTestThemeEngineWin::getSize):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
(WebTestRunner):
(WebTestThemeEngineWin):
(WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
- DumpRenderTree/chromium/TestShell.h:
(WebKit):
- DumpRenderTree/chromium/TestShellMac.mm:
(platformInit):
- DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
- DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
- 10:59 PM Changeset in webkit [146438] by
-
- 5 edits in trunk/Source/WebCore
Make GraphicsLayerCA::backingStoreMemoryEstimate() give a better estimate for tiled layers
https://bugs.webkit.org/show_bug.cgi?id=112864
Reviewed by Tim Horton.
If a GraphicsLayerCA has TiledBacking, ask the TiledBacking how
much memory it's using for tiles, rather than just using
height * width * 4.
Implement retainedTileBackingStoreMemory() in the TileController,
summing the memory used by parented tiles.
The original code was incorrectly multiplying by contentsScale
only once rather than twice (2x contents scale uses 4x as much memory).
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::backingStoreMemoryEstimate):
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::retainedTileBackingStoreMemory):
- 10:53 PM Changeset in webkit [146437] by
-
- 65 edits1 delete in trunk/LayoutTests
[Chromium] Test expectation update for r145055
https://bugs.webkit.org/show_bug.cgi?id=111319
- platform/chromium-linux-x86/fast/forms/time/time-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-win-xp/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium/TestExpectations:
- 10:48 PM WebKit Team edited by
- (diff)
- 9:57 PM Changeset in webkit [146436] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r189497. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20
- DEPS:
- 9:05 PM Changeset in webkit [146435] by
-
- 2 edits2 adds in trunk/LayoutTests
[chromium] Test expectations updates, and rebaseline to parallel r143389.
https://bugs.webkit.org/show_bug.cgi?id=62754
https://bugs.webkit.org/show_bug.cgi?id=99984
https://bugs.webkit.org/show_bug.cgi?id=111004
https://bugs.webkit.org/show_bug.cgi?id=112288
https://bugs.webkit.org/show_bug.cgi?id=112755
Unreviewed, test expectations updates.
- platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
- platform/chromium/TestExpectations:
- 8:43 PM Changeset in webkit [146434] by
-
- 6 edits8 adds in trunk/LayoutTests
Rebaseline some of my recent test changes
https://bugs.webkit.org/show_bug.cgi?id=112843
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-20
Reviewed by Ojan Vafai.
- platform/chromium-mac-lion/css3/flexbox/button-expected.png: Added.
- platform/chromium-mac-lion/fast/forms/color/input-appearance-color-expected.png:
- platform/chromium-mac-snowleopard/css3/flexbox/button-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/color/input-appearance-color-expected.png:
- platform/chromium-mac/css3/flexbox/button-expected.png: Added.
- platform/chromium-mac/css3/flexbox/button-expected.txt: Added.
- platform/chromium-mac/fast/forms/color/input-appearance-color-expected.png:
- platform/chromium-mac/fast/forms/color/input-appearance-color-expected.txt:
- platform/chromium-win/css3/flexbox/button-expected.png: Added.
- platform/chromium-win/css3/flexbox/button-expected.txt: Added.
- platform/chromium/TestExpectations:
- 8:35 PM Changeset in webkit [146433] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r146418.
http://trac.webkit.org/changeset/146418
https://bugs.webkit.org/show_bug.cgi?id=112872
It turns out that these sub pixel tests still do fail on Mac
(Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20
- platform/mac/TestExpectations:
- 7:47 PM Changeset in webkit [146432] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Remove test cases which need to do rebaseline in EFL TestExpectations.
- platform/efl/TestExpectations:
- 7:43 PM Changeset in webkit [146431] by
-
- 10 edits1 delete in trunk/Source
Unreviewed, rolling out r146419.
http://trac.webkit.org/changeset/146419
https://bugs.webkit.org/show_bug.cgi?id=112870
Broke many tests on debug builds (Requested by rniwa_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20
Source/WebCore:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/action_makenames.py:
(main):
- bindings/scripts/StaticString.pm: Removed.
- dom/QualifiedName.cpp:
(WebCore::createQualifiedName):
- dom/QualifiedName.h:
(WebCore):
- dom/make_names.pl:
(printNamesCppFile):
(printDefinitions):
Source/WTF:
- wtf/text/StringImpl.h:
(StringImpl):
- 7:42 PM Changeset in webkit [146430] by
-
- 14 edits1 delete in trunk
[JSC] Implement EnforceRange IDL attribute for integer conversions
https://bugs.webkit.org/show_bug.cgi?id=112506
Patch by Michael Pruett <michael@68k.org> on 2013-03-20
Reviewed by Kentaro Hara.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Implement the EnforceRange attribute for JSC bindings.
The EnforceRange attribute requires a type error to be thrown when
converting an ECMAScript number which is beyond the representable
range of the IDL integer type.
Tests: fast/js/webidl-type-mapping.html
storage/indexeddb/cursor-advance-workers.html
storage/indexeddb/cursor-advance.html
storage/indexeddb/intversion-bad-parameters.html
- WebCore.exp.in:
- bindings/js/JSDOMBinding.cpp:
(WebCore):
(WebCore::enforceRange):
(WebCore::toInt32EnforceRange):
(WebCore::toUInt32EnforceRange):
(WebCore::toInt64):
(WebCore::toUInt64):
- bindings/js/JSDOMBinding.h:
(WebCore::toInt32):
(WebCore):
(WebCore::toUInt32):
- bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionItem):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjId):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableStringValue):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsAttrWithGetterException):
(WebCore::setJSTestTypedefsAttrWithSetterException):
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
LayoutTests:
- fast/js/webidl-type-mapping-expected.txt:
- platform/chromium/fast/js/webidl-type-mapping-expected.txt: Removed.
- 7:33 PM Changeset in webkit [146429] by
-
- 3 edits in trunk/Source/JavaScriptCore
[QNX][ARM] REGRESSION(r135330): Various failures in Octane
https://bugs.webkit.org/show_bug.cgi?id=112863
Patch by Cosmin Truta <ctruta@blackberry.com> on 2013-03-20
Reviewed by Yong Li.
This was fixed in http://trac.webkit.org/changeset/146396 on Linux only.
Enable this fix on QNX.
- assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):
- 7:26 PM Changeset in webkit [146428] by
-
- 2 edits in trunk/LayoutTests
Add flaky test expectations to compositing/geometry/limit-layer-bounds-fixed.html
and fast/dom/MutationObserver/database-callback-delivery.html on Windows per bugs
112867 and 112868.
- platform/win/TestExpectations:
- 6:51 PM Changeset in webkit [146427] by
-
- 4 edits2 adds in trunk
Gesture events should include AllowShadowContent in hit testing
https://bugs.webkit.org/show_bug.cgi?id=112073
Reviewed by Dimitri Glazkov.
Source/WebCore:
Support gesture events for Shadow DOM.
Now 'gesturetap' events can be correctly dispatched in shadow trees.
Test: fast/dom/shadow/gesture-tap.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
LayoutTests:
- fast/dom/shadow/gesture-tap-expected.txt: Added.
- fast/dom/shadow/gesture-tap.html: Added.
- fast/dom/shadow/resources/event-dispatching.js:
(addEventListeners):
- 6:46 PM Changeset in webkit [146426] by
-
- 2 edits3 adds in trunk/LayoutTests
Should add test for bug #112694
https://bugs.webkit.org/show_bug.cgi?id=112859
Reviewed by Filip Pizlo.
New regression test to check that eliminating a var arg DFG Node (array in this case) doesn't
cause a ASSERT or crash.
- fast/js/dfg-array-dead-expected.txt: Added.
- fast/js/dfg-array-dead.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-array-dead.js: Added.
- 6:44 PM Changeset in webkit [146425] by
-
- 4 edits in trunk/Source
Versioning.
- 6:44 PM Changeset in webkit [146424] by
-
- 2 edits in trunk/LayoutTests
Mac rebaseline after r146415. I somehow missed the 1px difference.
- platform/mac/svg/custom/text-ctm-expected.txt:
- 6:39 PM Changeset in webkit [146423] by
-
- 1 copy in tags/Safari-537.35
New tag.
- 5:49 PM Changeset in webkit [146422] by
-
- 5 edits in trunk/Source
../ThirdParty: [WinCairo] Build WinCairo port under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112861
Reviewed by Tim Horton.
- gtest/msvc/gtest-md.vcxproj: Add WinCairo targets.
../WebKit: [WinCairo] Top-level solution change to build under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112861.
Reviewed by Tim Horton.
- WebKit.vcxproj/WebKit.sln: Add final set of WinCairo build
targets.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Add #if/def guards around some media-specific exports that
are not provided by the WinCairo port.
- 5:43 PM Changeset in webkit [146421] by
-
- 2 edits in trunk/LayoutTests
[chromium] Update test expectations to more closely match reality.
https://bugs.webkit.org/show_bug.cgi?id=106609
https://code.google.com/p/chromium/issues/detail?id=222140
Unreviewed, test expectations update.
- platform/chromium/TestExpectations:
- 5:36 PM Changeset in webkit [146420] by
-
- 3 edits1 add in trunk/Tools
[WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
New property sheet that does not link against CoreFoundation and
CFNetwork.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
Use new TestWebKitAPICommonWinCairo property sheet.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
Ditto.
- 5:31 PM Changeset in webkit [146419] by
-
- 10 edits1 add in trunk/Source
HTMLNames should construct strings at compile time
https://bugs.webkit.org/show_bug.cgi?id=112831
Reviewed by Darin Adler.
Source/WebCore:
This patch teaches make_names how to construct strings at compile time,
eliminating a large number of startup mallocs.
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/action_makenames.py:
- Teach the Chromium build how to deal with Perl modules.
- bindings/scripts/StaticString.pm: Added.
- A Perl module for constructing static strings.
(GenerateStrings):
(GenerateValidateStrings):
- dom/QualifiedName.cpp:
(WebCore::createQualifiedName):
- createQualifiedName now takes an already-constructed StringImpl object.
- dom/QualifiedName.h:
- dom/make_names.pl:
(valueForName):
(namesToStrings):
(printNamesCppFile):
(printDefinitions):
- Teach make_names how to use StaticString.pm.
Source/WTF:
- wtf/text/StringImpl.h:
(StringImpl):
(StaticASCIILiteral):
- This struct lets us construct StringImpl objects at compile time.
(WTF::StringImpl::assertValidHash):
- This function lets us sanity check StringImpl objects created from StaticData.
- 5:20 PM Changeset in webkit [146418] by
-
- 2 edits in trunk/LayoutTests
Remove entires added by r138484 now that these tests pass on Mac.
- platform/mac/TestExpectations:
- 5:09 PM Changeset in webkit [146417] by
-
- 6 edits in trunk/Source/WebCore
Remove unnecessary calls to Node::disabled for <meter>, <progress>, and <output>
https://bugs.webkit.org/show_bug.cgi?id=112767
Reviewed by Kent Tamura.
This is part of a refactoring to move Node::disabled to HTMLFormControlElement::disabled.
The concept of disabled is just a form control element one.
HTMLMeterElement, HTMLOutputElement, and HTMLProgressElement never
have disabled() return true, so we can remove the call. In addition,
HTMLMeterElement and HTMLProgressElement no longer inherit from
HTMLFormControlElement, so we don't need to override supportsFocus.
No new tests because no behavior change.
- html/HTMLMeterElement.cpp:
- html/HTMLMeterElement.h:
- html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::supportsFocus):
- html/HTMLProgressElement.cpp:
- html/HTMLProgressElement.h:
- 5:08 PM Changeset in webkit [146416] by
-
- 4 edits3 adds in trunk/Tools
[WinCairo] Unreviewed build fix for VS2010.
Had to add WinCairo-specific property sheets to deal with some
library and path differences with the main Apple port.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
- 5:06 PM Changeset in webkit [146415] by
-
- 2 edits in trunk/LayoutTests
Remove an entry added in r141645 as this test is now passing.
- platform/mac/TestExpectations:
- 5:03 PM Changeset in webkit [146414] by
-
- 3 edits in trunk/LayoutTests
fast/css/empty-generated-content.html needs to be rebaselined after 104462
https://bugs.webkit.org/show_bug.cgi?id=104595
- platform/mac/TestExpectations:
- platform/mac/fast/css/empty-generated-content-expected.txt:
- 4:53 PM Changeset in webkit [146413] by
-
- 6 edits in trunk/LayoutTests
Rebaseline expected results added in r143389 so that they have alpha values.
- platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- svg/as-image/image-preserveAspectRatio-all-expected.png:
- svg/filters/feImage-preserveAspectRatio-all-expected.png:
- 4:49 PM Changeset in webkit [146412] by
-
- 2 edits in trunk/LayoutTests
Remove test expectations added in r133786 as these tests are now passing.
- platform/mac/TestExpectations:
- 4:46 PM Changeset in webkit [146411] by
-
- 2 edits in trunk/LayoutTests
inspector/debugger/debugger-reload-on-pause.html assertion failure on Mac after r141136
https://bugs.webkit.org/show_bug.cgi?id=109232
Unreviewed. Remove the test expectation entry since this test hasn't been crashing lately.
- platform/mac/TestExpectations:
- 4:41 PM Changeset in webkit [146410] by
-
- 3 edits1 copy in trunk/LayoutTests
Mac rebaseline intended to be done in r146409 for r144096.
- platform/mac/TestExpectations:
- platform/mac/css2.1/20110323/replaced-elements-001-expected.png:
- platform/mac/css2.1/20110323/replaced-elements-001-expected.txt: Copied from LayoutTests/css2.1/20110323/replaced-elements-001-expected.txt.
- 4:31 PM Changeset in webkit [146409] by
-
- 3 edits2 copies in trunk/LayoutTests
Mac rebaseline after r144096.
- platform/mac/TestExpectations:
- platform/mac/css3/flexbox/button-expected.png: Copied from LayoutTests/css3/flexbox/button-expected.png.
- platform/mac/css3/flexbox/button-expected.txt: Copied from LayoutTests/css3/flexbox/button-expected.txt.
- platform/mac/svg/custom/foreign-object-skew-expected.png:
- 4:20 PM Changeset in webkit [146408] by
-
- 18 edits9 adds in trunk
Source/WebCore: [css3-text] Parsing -webkit-each-line value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=109021
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-20
Reviewed by Julien Chaffraix.
"each-line" is added for text-indent in CSS3.
http://dev.w3.org/csswg/css3-text/#each-line
This patch is the parsing part to support each-line value for text-indent.
"each-line" means "Indentation affects the first line of the block
container as well as each line after a forced line break, but does
not affect lines after a soft wrap break."
It's prefixed and guarded by CSS3_TEXT flag.
Tests: fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html
fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
style.getPropertyCSSValue(text-indent) returns CSSPrimitiveValue when text-indent has only <length>
or <percentage> value, but returns CSSValueList when text-indent also has -webkit-each-line.
- css/CSSParser.cpp:
(WebCore::isSimpleLengthPropertyID): Removed CSSPropertyTextIndent case.
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTextIndent): Added.
- css/CSSParser.h:
Parsed <length> or <percentage> with -webkit-each-line for text-indent.
- css/CSSValueKeywords.in: Added new -webkit-each-line keyword.
- css/StyleBuilder.cpp:
(ApplyPropertyTextIndent): Added.
(WebCore::ApplyPropertyTextIndent::applyInheritValue):
(WebCore::ApplyPropertyTextIndent::applyInitialValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
(WebCore::ApplyPropertyTextIndent::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
Added codes to handle applying text-indent offset and -webkit-each-line option to our style.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h: Added enum TextIndentLine.
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h: Added m_textIndentLine.
(StyleRareInheritedData):
Added the usual getter / setter / initial methods for m_textIndentLine.
LayoutTests: [css3-text] Parsing -webkit-each-line value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=109021
"each-line" is added for text-indent in CSS3.
http://dev.w3.org/csswg/css3-text/#each-line
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-20
Reviewed by Julien Chaffraix.
- fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt: Added.
- fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited-expected.txt: Added.
- fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html: Added.
- fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html: Added.
- fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent-inherited.js: Added.
(testComputedStyle):
(ownValueTest):
(inheritanceTest):
- fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js: Added.
(testElementStyle):
(testComputedStyle):
(valueSettingTest):
(invalidValueSettingTest):
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt-mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 4:16 PM Changeset in webkit [146407] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indentation of JSString.h
Rubber stamped by Mark Hahnenberg.
- runtime/JSString.h:
- 4:04 PM Changeset in webkit [146406] by
-
- 3 edits in trunk/LayoutTests
dialog-enabled.html and dialog-disabled.html don't really test what they think they do
https://bugs.webkit.org/show_bug.cgi?id=112848
Reviewed by Adam Barth.
- fast/dom/HTMLDialogElement/dialog-disabled.html:
- fast/dom/HTMLDialogElement/dialog-enabled.html:
Set the dialog element enabled setting before parsing <dialog> element.
- 4:03 PM Changeset in webkit [146405] by
-
- 4 edits in trunk/LayoutTests
Mac rebaseline after r142152.
- platform/mac/TestExpectations:
- platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
- platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
- 3:52 PM Changeset in webkit [146404] by
-
- 24 edits in trunk/LayoutTests
Mac rebaseline after r140693.
- editing/selection/extend-by-sentence-001-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/css2.1/t0505-c16-descendant-01-e-expected.png:
- platform/mac/css2.1/t0505-c16-descendant-01-e-expected.txt:
- platform/mac/editing/selection/extend-by-sentence-001-expected.png:
- platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
- platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
- platform/mac/fast/text/capitalize-empty-generated-string-expected.png:
- platform/mac/fast/text/capitalize-empty-generated-string-expected.txt:
- platform/mac/fast/text/whitespace/006-expected.png:
- platform/mac/fast/text/whitespace/006-expected.txt:
- platform/mac/fast/text/whitespace/007-expected.png:
- platform/mac/fast/text/whitespace/007-expected.txt:
- platform/mac/svg/batik/text/xmlSpace-expected.png:
- platform/mac/svg/batik/text/xmlSpace-expected.txt:
- platform/mac/svg/carto.net/combobox-expected.png:
- platform/mac/tables/mozilla/bugs/bug113235-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1188-expected.png:
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.png:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- svg/carto.net/combobox-expected.txt:
- 3:43 PM Changeset in webkit [146403] by
-
- 2 edits2 adds in trunk/LayoutTests
Mac rebaseline after r139282.
- fast/repaint/caret-with-transformation-expected.png: Added.
- fast/repaint/caret-with-transformation-expected.txt: Added.
- 3:40 PM Changeset in webkit [146402] by
-
- 9 edits in trunk
[WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112849
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-20
Reviewed by Sam Weinig.
Source/WebKit2:
The code was added in r137148 for the sole purpose of testing,
and it is not even being properly tested.
Remove the code until someone actually implement the feature in WebKit2.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCanShowMIMEType):
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
(WebPage):
Tools:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- 3:39 PM Changeset in webkit [146401] by
-
- 1 edit3 adds in trunk/LayoutTests
"" + x where x is not a string should be optimized by the DFG to some manner of ToString conversion
https://bugs.webkit.org/show_bug.cgi?id=112845
Reviewed by Mark Hahnenberg.
- fast/js/regress/empty-string-plus-int-expected.txt: Added.
- fast/js/regress/empty-string-plus-int.html: Added.
- fast/js/regress/script-tests/empty-string-plus-int.js: Added.
(foo):
- 3:37 PM Changeset in webkit [146400] by
-
- 4 edits in trunk/Source/JavaScriptCore
"" + x where x is not a string should be optimized by the DFG to some manner of ToString conversion
https://bugs.webkit.org/show_bug.cgi?id=112845
Reviewed by Mark Hahnenberg.
I like to do "" + x. So I decided to make DFG recognize it, and related idioms.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToPrimitive):
(FixupPhase):
(JSC::DFG::FixupPhase::fixupToString):
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::resultOfToPrimitive):
(DFG):
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGPredictionPropagationPhase.h:
(DFG):
- 3:36 PM Changeset in webkit [146399] by
-
- 10 edits7 adds in trunk
Correct coordinated scrolling for RTL iframe and overflow:scroll
https://bugs.webkit.org/show_bug.cgi?id=112088
Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-03-20
Reviewed by James Robinson.
Source/WebCore:
This patch adds appropriate offset in ScrollingCoordinatorChromium to
adjust impl-side scroll position to the range [0, maxPos - minPos].
This also corrects RenderLayer to return correct scroll position for RTL,
explained below:
There are 2 commonly used scroll offset coordinate systems in WebCore.
- The scroll offset is the amount that needs to be translated when painting child elements in a RenderBox. The value can be negative when there is negative overflow (for RTL). The range will be within [overflow_top_left_corner, overflow_bottom_right_corner - client_size]. This system is mainly used for painting and layer positioning.
- The scroll offset will be always non-negative, and the range will be within [0, content_size - client_size]. This system is mainly used for scrollbars.
scrollOrigin is defined to convert between the two systems. scrollOrigin is always
non-negative, and equivalent to -overflow_top_left_corner.
The first system is used for ScrollableArea::scrollPosition/minimumScrollPosition/
maximumScrollPosition function family. So is it implemented in ScrollView/Frameview.
RenderLayer errorneously implemented scrollPosition in the second system,
and worse, returned minimumScrollPosition/maximumScrollPosition were totally non-sense.
This patch corrects RenderLayer to use the first coordinate system.
Test: compositing/rtl/rtl-overflow-scrolling.html
ScrollingCoordinatorChromiumTest.rtlIframe
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorChromium::scrollableAreaScrollLayerDidChange):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::minimumScrollPosition):
(WebCore::RenderLayer::maximumScrollPosition):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
Source/WebKit/chromium:
Added test to ensure RTL iframe has appropriate impl-side scroll position.
- tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::TEST_F):
(WebKit):
- tests/data/rtl-iframe-inner.html: Added.
- tests/data/rtl-iframe.html: Added.
LayoutTests:
This patch corrects scrollOrigin compensation for composited overflow:scroll.
compositing/rtl/rtl-overflow-scrolling.html is added to verify RTL divs
can be correctly scrolled to the left under accelerated scrolling mode.
fast/css/sticky/inline-sticky-abspos-child.html is modified to avoid sub-pixel
issue with Ahem font.
- compositing/rtl/rtl-overflow-scrolling-expected.png: Added.
- compositing/rtl/rtl-overflow-scrolling-expected.txt: Added.
- compositing/rtl/rtl-overflow-scrolling.html: Added.
- fast/css/sticky/inline-sticky-abspos-child-expected.html:
- fast/css/sticky/inline-sticky-abspos-child.html:
- platform/chromium/TestExpectations:
- platform/mac/compositing/rtl/rtl-overflow-scrolling-expected.txt: Added.
- 3:33 PM Changeset in webkit [146398] by
-
- 10 edits6 adds in trunk/Tools
[WinCairo] Build WebKit Tools under VS2010
https://bugs.webkit.org/show_bug.cgi?id=112821
Reviewed by Tim Horton.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
Add WinCairo-specific build target.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
Add WinCairo-specific build target.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
Add WinCairo-specific build target.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
WinCairo-specific build target.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
specific build target.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
WinCairo-specific build target.
- win/record-memory/record-memory.vcxproj: Add WinCairo target.
- win/record-memory/record-memoryDebugWinCairo.props: Added.
- win/record-memory/record-memoryReleaseWinCairo.props: Added.
- 3:19 PM Changeset in webkit [146397] by
-
- 9 edits in trunk/LayoutTests
Mac rebaseline after r140202.
- editing/input/caret-at-the-edge-of-contenteditable-expected.png:
- editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
- editing/input/reveal-caret-of-multiline-input-expected.png:
- fast/spatial-navigation/snav-div-overflow-scrol-hidden-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
- platform/mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
- platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt:
- 3:07 PM Changeset in webkit [146396] by
-
- 3 edits in trunk/Source/JavaScriptCore
ARMv7 replaceWithJump ASSERT failure after r135330.
https://bugs.webkit.org/show_bug.cgi?id=103146
Reviewed by Filip Pizlo.
On Linux, the 24 bit distance range of jumps sometimes does not
enough to cover all targets addresses. This patch supports jumps
outside of this range using a mov/movt/bx 10 byte long sequence.
- assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::revertJumpTo_movT3movtcmpT2):
(JSC::ARMv7Assembler::nopw):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):
- 3:05 PM Changeset in webkit [146395] by
-
- 2 edits in branches/safari-536.30-branch/Tools
Unreviewed. Merge the latest delete-stale-build-files to make bots green.
- BuildSlaveSupport/delete-stale-build-files:
- 3:01 PM Changeset in webkit [146394] by
-
- 4 edits in trunk/Source
REGRESSION(r145592): AutodrainedPool.h. RunLoopTimer.h, SchedulePair.h are being copied into
the wrong location
https://bugs.webkit.org/show_bug.cgi?id=112833
Reviewed by Darin Adler.
Source/WebCore:
Fix an incorrect include path.
- loader/DocumentLoader.h:
RunLoopTimer.h lives in wtf as of r145592.
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
Make sure those three headers are copied with the rest of the WTF headers.
- 2:58 PM Changeset in webkit [146393] by
-
- 3 edits2 adds in trunk
Crash in Document::setFocusedNode if the frame of new focused node is detached in 'change' event handler
https://bugs.webkit.org/show_bug.cgi?id=112653
Reviewed by Dimitri Glazkov.
Source/WebCore:
Test: fast/frames/detach-frame-during-focus.html
- page/FocusController.cpp:
(WebCore::FocusController::setFocusedNode):
A oldDocument->setFocusedNode call might dispatch a 'change' event for
an old focused node, and an event handler code might detach the
newFocusedFrame. So we should check it. Without the check, the following
newDocument->setFocusedNode call would crash because of null
Frame::page().
LayoutTests:
- fast/frames/detach-frame-during-focus-expected.txt: Added.
- fast/frames/detach-frame-during-focus.html: Added.
- 2:41 PM Changeset in webkit [146392] by
-
- 3 edits in trunk/Source/JavaScriptCore
Objective-C API: Fix over-releasing in allocateConstructorAndPrototypeWithSuperClassInfo:
https://bugs.webkit.org/show_bug.cgi?id=112832
Reviewed by Geoffrey Garen.
If either the m_constructor or m_prototype (but not both) is collected, we will call
allocateConstructorAndPrototypeWithSuperClassInfo, which will create a new object to replace the one
that was collected, but at the end of the method we call release on both of them.
This is incorrect since we autorelease the JSValue in the case that the object doesn't need to be
reallocated. Thus we'll end up overreleasing later during the drain of the autorelease pool.
- API/JSWrapperMap.mm:
(objectWithCustomBrand): We no longer alloc here. We instead call the JSValue valueWithValue class method,
which autoreleases for us.
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]): We no longer call release on the
constructor or prototype JSValues.
- API/tests/testapi.mm: Added a new test that crashes on ToT due to over-releasing.
- 2:36 PM Changeset in webkit [146391] by
-
- 2 edits in trunk/Source/WebCore
Assertion in LegacyWebArchive::create() in editing tests
https://bugs.webkit.org/show_bug.cgi?id=112642
Reviewed by Simon Fraser.
Address Simon's review comment. Don't convert String to MIMEType just to convert it back to String.
- platform/mac/PasteboardMac.mm:
(WebCore::fragmentFromWebArchive):
- 2:26 PM Changeset in webkit [146390] by
-
- 9 edits1 add in trunk
[GTK] Build ANGLE sources into a separate library from libWebCore.la
https://bugs.webkit.org/show_bug.cgi?id=112778
Reviewed by Martin Robinson.
.:
- GNUmakefile.am: Include the GNUmakefile.am covering the libANGLE.la library.
Source/ThirdParty/ANGLE:
- GNUmakefile.am: Added, sets up the libANGLE.la library.
Source/WebCore:
No new tests - no change in functionality.
- GNUmakefile.list.am: Remove the ANGLE sources listing, it's now placed in the ANGLE-specific GNUmakefile.am.
Source/WebKit/gtk:
- GNUmakefile.am: Add libLevelDB.la to the libwebkitgtk library if using the OpenGL accelerated backend.
Source/WebKit2:
- GNUmakefile.am: Add libLevelDB.la to the libwebkit2gtk library if using the OpenGL accelerated backend.
- 2:24 PM Changeset in webkit [146389] by
-
- 2 edits in trunk/Source/WebCore
Assertion in LegacyWebArchive::create() in editing tests
https://bugs.webkit.org/show_bug.cgi?id=112642
Reviewed by Enrica Casucci.
It's possible for clipboard to be overriden between the time we retrieve clipboard types and the time
we actually retrieve the Web archive buffer. Add a null check to take this into account.
Also extracted fragmentFromWebArchive for clarity.
- platform/mac/PasteboardMac.mm:
(WebCore::fragmentFromWebArchive): Extracted.
(WebCore::Pasteboard::documentFragment):
- 2:16 PM Changeset in webkit [146388] by
-
- 30 edits in branches/safari-536.30-branch/LayoutTests
<rdar://problem/13465764> Many merged tests are failing
Rubber stamped by Mark Rowe.
Change all instances of "testRunner" back to "layoutTestController".
- editing/style/apply-style-crash.html:
- fast/backgrounds/background-clip-text-on-body.html:
- fast/backgrounds/transformed-body-background.html:
- fast/backgrounds/transformed-body-html-background.html:
- fast/backgrounds/transformed-html-body-background.html:
- fast/block/colspan-under-button-crash.html:
- fast/block/float/float-not-removed-from-pre-block.html:
- fast/block/line-layout/double-line-break-obj-removal-crash.html:
- fast/canvas/canvas-measureText.html:
- fast/css-generated-content/bug-106384.html:
- fast/css/image-set-value-not-removed-crash.html:
- fast/dom/Geolocation/watchPosition-unique.html:
- fast/dom/ready-state-change-crash.html:
- fast/dom/window-load-crash.html:
- fast/forms/textarea/textarea-autofocus-removal-while-focusing-with-style.html:
- fast/frames/frame-unload-crash2.html:
- fast/images/crossfade-client-not-removed-crash.html:
- fast/js/concat-large-strings-crash.html:
- fast/js/concat-large-strings-crash2.html:
- fast/multicol/continuation-crash.html:
- fast/multicol/float-not-removed-crash.html:
- fast/multicol/span/list-multi-column-crash.html:
- fast/parser/foster-parent-adopted.html:
- fast/parser/foster-parent-adopted2.html:
- http/tests/security/xssAuditor/script-tag-with-actual-comma.html:
- http/tests/security/xssAuditor/script-tag-with-source-data-url3.html:
- plugins/plugin-remove-readystatechange.html:
- svg/animations/animate-keytimes-crash.html:
- svg/custom/elementTimeControl-nan-crash.html:
- 2:13 PM Changeset in webkit [146387] by
-
- 3 edits2 adds in trunk
WebSpeech: Crash in WebCore::PlatformSpeechSynthesisUtterance::client / WebCore::SpeechSynthesis::didResumeSpeaking
https://bugs.webkit.org/show_bug.cgi?id=112728
Reviewed by Tim Horton.
When cancel() is called, there was a delay in the platform returning and saying speech was finished, which caused
the m_currentSpeechUtterance variable to get deallocated but not cleared.
This patch fixes up the management of the utterances in SpeechSynthesis and the Mac platform given that
we can't rely on the platform to return immediately on a stop speaking job.
Test: platform/mac/fast/speechsynthesis/speech-synthesis-cancel-crash.html
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::resume):
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper cancel]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:willSpeakWord:ofString:]):
- 1:55 PM Changeset in webkit [146386] by
-
- 3 edits in trunk/Tools
API test gardening AppleWin port.
The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
- 1:47 PM Changeset in webkit [146385] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix Mac release build.
- page/CaptionUserPreferencesMac.mm:
(WebCore::languageIdentifier):
- 1:45 PM Changeset in webkit [146384] by
-
- 1 copy in branches/dfgFourthTier
Unreviewed, branch for work on https://bugs.webkit.org/show_bug.cgi?id=112836
- 1:43 PM Changeset in webkit [146383] by
-
- 8 edits in trunk/Source/JavaScriptCore
It's called "Hash Consing" not "Hash Consting"
https://bugs.webkit.org/show_bug.cgi?id=112768
Rubber stamped by Mark Hahnenberg.
See http://en.wikipedia.org/wiki/Hash_consing
- heap/GCThreadSharedData.cpp:
(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::reset):
- heap/GCThreadSharedData.h:
(GCThreadSharedData):
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::setup):
(JSC::SlotVisitor::reset):
(JSC::JSString::tryHashConsLock):
(JSC::JSString::releaseHashConsLock):
(JSC::JSString::shouldTryHashCons):
(JSC::SlotVisitor::internalAppend):
- heap/SlotVisitor.h:
(SlotVisitor):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
(JSC::JSGlobalData::haveEnoughNewStringsToHashCons):
(JSC::JSGlobalData::resetNewStringsSinceLastHashCons):
- runtime/JSString.h:
(JSC::JSString::finishCreation):
(JSString):
(JSC::JSString::isHashConsSingleton):
(JSC::JSString::clearHashConsSingleton):
(JSC::JSString::setHashConsSingleton):
- 1:29 PM Changeset in webkit [146382] by
-
- 18 edits in trunk/Source/JavaScriptCore
DFG implementation of op_strcat should inline rope allocations
https://bugs.webkit.org/show_bug.cgi?id=112780
Reviewed by Oliver Hunt.
This gets rid of the StrCat node and adds a MakeRope node. The MakeRope node can
take either two or three operands, and allocates a rope string with either two or
three fibers. (The magic choice of three children for non-VarArg nodes happens to
match exactly with the magic choice of three fibers for rope strings.)
ValueAdd on KnownString is replaced with MakeRope with two children.
StrCat gets replaced by an appropriate sequence of MakeRope's.
MakeRope does not do the dynamic check to see if its children are empty strings.
This is replaced by a static check, instead. The downside is that we may use more
memory if the strings passed to MakeRope turn out to dynamically be empty. The
upside is that we do fewer checks in the cases where either the strings are not
empty, or where the strings are statically known to be empty. I suspect both of
those cases are more common, than the case where the string is dynamically empty.
This also results in some badness for X86. MakeRope needs six registers if it is
allocating a three-rope. We don't have six registers to spare on X86. Currently,
the code side-steps this problem by just never usign three-ropes in optimized
code on X86. All other architectures, including X86_64, don't have this problem.
This is a shocking speed-up. 9% progressions on both V8/splay and
SunSpider/date-format-xparb. 1% progression on V8v7 overall, and ~0.5% progression
on SunSpider. 2x speed-up on microbenchmarks that test op_strcat.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGAdjacencyList.h:
(AdjacencyList):
(JSC::DFG::AdjacencyList::removeEdge):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::eliminateIrrelevantPhantomChildren):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::createToString):
(JSC::DFG::FixupPhase::attemptToForceStringArrayModeByToStringConversion):
(JSC::DFG::FixupPhase::convertStringAddUse):
(FixupPhase):
(JSC::DFG::FixupPhase::convertToMakeRope):
(JSC::DFG::FixupPhase::fixupMakeRope):
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileMakeRope):
(DFG):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::~SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::gpr):
(JSC::DFG::SpeculateCellOperand::use):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/JSString.h:
(JSRopeString):
- 1:25 PM Changeset in webkit [146381] by
-
- 7 edits11 adds in trunk/Source/WebKit
[WinCairo] Build the WebKit.dll under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112759
Reviewed by Tim Horton.
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Update project to
build WinCairo variant using new property sheets.
- WebKit.vcxproj/Interfaces/InterfacesDebugWinCairo.props: Added.
- WebKit.vcxproj/Interfaces/InterfacesReleaseWinCairo.props: Added.
- WebKit.vcxproj/WebKit.sln: Update solution to use WinCairo
build targets for WebKit.dll-related projects.
- WebKit.vcxproj/WebKit/WebKit.vcxproj: Update project to build
WinCairo variant using new property sheets.
- WebKit.vcxproj/WebKit/cURL.props: Added.
- WebKit.vcxproj/WebKit/WebKitDebugWinCairo.props: Added.
- WebKit.vcxproj/WebKit/WebKitReleaseWinCairo.props: Added.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
Update project to build WinCairo variant using new property sheets.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorDebugWinCairo.props: Added.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorReleaseWinCairo.props: Added.
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Update project to
build WinCairo variant using new property sheets.
- WebKit.vcxproj/WebKitGUID/WebKitGUIDDebugWinCairo.props: Added.
- WebKit.vcxproj/WebKitGUID/WebKitGUIDReleaseWinCairo.props: Added.
- WebKit.vcxproj/WinCairo.props: Added.
- WebKit.vcxproj/debug_wincairo.props: Added.
- 1:13 PM Changeset in webkit [146380] by
-
- 36 edits in trunk
Allow ports specific text track menu
https://bugs.webkit.org/show_bug.cgi?id=112800
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, existing tests updated for changes.
- English.lproj/Localizable.strings: Add localizable strings for text track names.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): userPrefersCaptions -> shouldShowCaptions.
(WebCore::HTMLMediaElement::setSelectedTextTrack): toggleTrackAtIndex -> setSelectedTextTrack.
(WebCore::HTMLMediaElement::userPrefersCaptions): userPrefersCaptions -> shouldShowCaptions.
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Get preferences from CaptionUserPreferences
instead of from Settings.
(WebCore::HTMLMediaElement::setSelectedTextTrack): Renamed from toggleTrackAtIndex. Now takes
a TextTrack* instead of an int.
(WebCore::HTMLMediaElement::captionPreferencesChanged): Don't force a recalculation unless
captions are enabled/disabled to avoid unnecessary thrash.
- html/HTMLMediaElement.h:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Use the menu to track
map instead of just the track index.
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Build and configure the
menu from the menu to track map.
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Start with a list
of tracks already sorted according to platform specific rules. Build a menu to track map
so tracks are retained while the menu is visible.
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::textTrackPreferencesChanged): Call closedCaptionTracksChanged so the
track menu will be rebuilt before it is shown again.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::containsOnlyForcedSubtitles): New, passthrough to the private track.
(WebCore::InbandTextTrack::isMainProgramContent): Ditto.
(WebCore::InbandTextTrack::isEasyToRead): Ditto.
- html/track/InbandTextTrack.h:
- html/track/TextTrack.h:
- html/track/TextTrackList.cpp:
(WebCore::TextTrackList::contains): New.
- html/track/TextTrackList.h:
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::CaptionUserPreferences): Pull in from .h ditto.
(WebCore::CaptionUserPreferences::~CaptionUserPreferences): Ditto.
(WebCore::CaptionUserPreferences::shouldShowCaptions): Renamed from userPrefersCaptions.
(WebCore::CaptionUserPreferences::setShouldShowCaptions): New.
(WebCore::CaptionUserPreferences::userPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferences::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferences::userPrefersSubtitles): Ditto.
(WebCore::CaptionUserPreferences::setUserPrefersSubtitles): Ditto.
(WebCore::CaptionUserPreferences::userPrefersTextDescriptions): Ditto.
(WebCore::CaptionUserPreferences::setUserPrefersTextDescriptions): Ditto.
(WebCore::CaptionUserPreferences::displayNameForTrack): Ditto.
(WebCore::CaptionUserPreferences::sortedTrackListForMenu): Ditto.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::shouldShowCaptions): Renamed from userPrefersCaptions.
(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): New.
(WebCore::CaptionUserPreferences::userPrefersSubtitles): Ditto.
(WebCore::trackDisplayName): Update logic used to build track title.
(WebCore::CaptionUserPreferencesMac::displayNameForTrack): Call trackDisplayName.
(WebCore::textTrackCompare): Text track title sort comparison function.
(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): New. Sort the list of tracks
according to title, language, and user preferences.
- platform/Language.cpp:
(WebCore::displayNameForLanguageLocale): Don't leak the CFLocale.
- platform/LocalizedStrings.cpp:
(WebCore::textTrackCountryAndLanguageMenuItemText): New.
(WebCore::textTrackLanguageMenuItemText): Ditto.
(WebCore::closedCaptionTrackMenuItemText): Ditto.
(WebCore::sdhTrackMenuItemText): Ditto.
(WebCore::easyReaderTrackMenuItemText): Ditto.
- platform/LocalizedStrings.h:
- platform/graphics/InbandTextTrackPrivate.h:
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::containsOnlyForcedSubtitles): New, return AVFoundation property.
(WebCore::InbandTextTrackPrivateAVFObjC::isMainProgramContent): Ditto.
(WebCore::InbandTextTrackPrivateAVFObjC::isEasyToRead): Ditto.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setShouldDisplayTrackKind): Set setting via CaptionUserPreferences
instead of from Settings.
(WebCore::InternalSettings::shouldDisplayTrackKind): Get setting from CaptionUserPreferences
instead of from Settings.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add new exports.
- win/WebKit.vcproj/WebKitExports.def.in: Ditto.
LayoutTests:
- media/track/track-user-preferences-expected.txt:
- media/track/track-user-preferences.html:
- media/video-controls-captions-trackmenu-localized.html:
- media/video-controls-captions-trackmenu-sorted.html:
- media/video-controls-captions-trackmenu.html:
- platform/mac/media/video-controls-captions-trackmenu-expected.txt:
- platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
- platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
- 1:07 PM Changeset in webkit [146379] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Clean up TemporaryLinkStubs.cpp
https://bugs.webkit.org/show_bug.cgi?id=112820
Reviewed by Philippe Normand.
Clean up the TemporaryLinkStubs.cpp file, removing unnecessary includes and prettifying the code.
No new tests - no new functionality.
- platform/gtk/TemporaryLinkStubs.cpp:
(WebCore):
(WebCore::getSupportedKeySizes):
(WebCore::signedPublicKeyAndChallengeString):
(WebCore::userIdleTime):
- 12:27 PM Changeset in webkit [146378] by
-
- 8 edits in trunk/Source
Remove PlatformEvent::GestureDoubleTap
https://bugs.webkit.org/show_bug.cgi?id=93045
Patch by Yufeng Shen <miletus@chromium.org> on 2013-03-20
Reviewed by Antonio Gomes.
Source/WebCore:
PlatformEvent::GestureDoubleTap is not currently
used in WebCore and replaced by GestureTap with
tap count 2, so remove it.
Test: We are removing something that is not used, so
no new test. All existing tests pass.
- dom/GestureEvent.cpp:
(WebCore::GestureEvent::create):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
- platform/PlatformEvent.h:
- platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::handleGestureEvent):
Source/WebKit/chromium:
PlatformEvent::GestureDoubleTap is not currently
used in WebCore so remove it.
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
- 12:22 PM Changeset in webkit [146377] by
-
- 7 edits in trunk/Source/WebCore
Move repaint methods from RenderObject to RenderBox
https://bugs.webkit.org/show_bug.cgi?id=112773
Reviewed by Julien Chaffraix.
repaintOverhangingFloats and repaintDuringLayoutIfMoved are only ever called
on RenderBoxes, so don't need to be on RenderObject. This also lets us
devirtualize repaintDuringLayoutIfMoved.
- rendering/RenderBox.h:
(WebCore::RenderBox::repaintOverhangingFloats):
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- 12:22 PM Changeset in webkit [146376] by
-
- 2 edits in trunk/Tools
Test fix for Win EWS bots, catch various errors and restart script if necessary.
- EWSTools/start-queue-win.sh:
- 12:19 PM Changeset in webkit [146375] by
-
- 3 edits in trunk/Source/WebCore
Add a feature observer for RenderDeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=112740
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-20
Reviewed by Tony Chang.
No new tests - only adding measurements.
- page/FeatureObserver.h:
Add constants for RenderDeprecatedFlexibleBox, and add separate
constants for its use in the UI and in extensions.
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
Call FeatureObserver. Check the document()->url() to see which
constant to use.
- 12:09 PM Changeset in webkit [146374] by
-
- 2 edits in trunk/Tools
Unreviewed, add myself to committers.py.
- 11:56 AM Changeset in webkit [146373] by
-
- 2 edits in trunk/Source/WebCore
Autosize should use documentRect height instead of scrollHeight
https://bugs.webkit.org/show_bug.cgi?id=112770
Reviewed by David Levin.
Autosizing fails to compute the correct height if the root element is very
small but the document has significant overflow.
No new tests; autosizing is not currently exposed in a testable way on Mac.
- page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
- 11:56 AM Changeset in webkit [146372] by
-
- 2 edits in trunk/Source/WTF
FastMalloc scavenge timer specifies an overly narrow leeway value.
Reviewed by Alexey Proskuryakov.
There's no need to allow only 1ms of leeway on a 2s timer.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::initializeScavenger): Bump the leeway window
to 10% of the scavenge timer.
- 11:50 AM Changeset in webkit [146371] by
-
- 3 edits8 adds in trunk
[CSS Grid Layout] Improper repainting when grid item change their position
https://bugs.webkit.org/show_bug.cgi?id=112749
Reviewed by Ojan Vafai.
Source/WebCore:
Tests: fast/css-grid-layout/grid-element-change-columns-repaint.html
fast/css-grid-layout/grid-element-change-rows-repaint.html
fast/css-grid-layout/grid-item-change-column-repaint.html
fast/css-grid-layout/grid-item-change-row-repaint.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutGridItems):
Added a call to repaintDuringLayoutIfMoved to repaint moving grid items.
LayoutTests:
- fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt: Added.
- fast/css-grid-layout/grid-element-change-columns-repaint.html: Added.
- fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt: Added.
- fast/css-grid-layout/grid-element-change-rows-repaint.html: Added.
Those are added testing for the grid element's change. They were already passing due to
the LayoutRepainter in RenderGrid::layoutBlock.
- fast/css-grid-layout/grid-item-change-column-repaint-expected.txt: Added.
- fast/css-grid-layout/grid-item-change-column-repaint.html: Added.
- fast/css-grid-layout/grid-item-change-row-repaint-expected.txt: Added.
- fast/css-grid-layout/grid-item-change-row-repaint.html: Added.
New testing, was failing before this change.
- 11:35 AM Changeset in webkit [146370] by
-
- 1 edit in branches/chromium/1447/Source/WebCore/bindings/v8/V8LazyEventListener.cpp
Merge 146344 "[v8] unsafe persistent access in V8LazyEventListener"
[v8] unsafe persistent access in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=112807
Patch by Dan Carney <dcarney@google.com> on 2013-03-20
Reviewed by Kentaro Hara.
No new tests.
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::toObjectWrapper):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12512013
- 11:34 AM Changeset in webkit [146369] by
-
- 1 add in branches/chromium/1447/codereview.settings
for drovering
- 11:33 AM Changeset in webkit [146368] by
-
- 1 copy in branches/chromium/1447
branching to merge a v8 fix
- 11:24 AM Changeset in webkit [146367] by
-
- 2 edits in trunk/Source/WebKit
AppleWin VS2010 build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 11:20 AM Changeset in webkit [146366] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] compositing/iframes/scroll-fixed-transformed-element.html fails in manual testing
https://bugs.webkit.org/show_bug.cgi?id=112806
Reviewed by Antonio Gomes.
PR 283363
When scrolling the iframe, the position: fixed element is correctly
positioned, that is, as if it was fixed with respect to the iframe's
viewport. When scrolling the main frame however, the fixed pos element
was positioned as if it was fixed with respect to the main frame's
viewport.
Fixed by falling back to using the WebKit-thread scroll position for
fixed positioning in LayerRenderer, if the override doesn't have a
position currently set, i.e. if we are not currently scrolling the
iframe.
The effects of the bug are only visual, i.e. not detectable by DRT.
Manually testable using compositing/iframes/scroll-fixed-transformed-element.html
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::updateLayersRecursive):
- 11:17 AM Changeset in webkit [146365] by
-
- 2 edits in trunk/Source/WebCore
[V8] Simplify implementation of EnforceRange conversions
https://bugs.webkit.org/show_bug.cgi?id=112758
Patch by Michael Pruett <michael@68k.org> on 2013-03-20
Reviewed by Kentaro Hara.
Factor out EnforceRange conversion into a helper function.
Simplify calculation for truncation.
Tests: fast/js/webidl-type-mapping.html
storage/indexeddb/cursor-advance.html
storage/indexeddb/cursor-advance-workers.html
storage/indexeddb/intversion-bad-parameters.html
- bindings/v8/V8Binding.cpp:
(WebCore::enforceRange):
(WebCore):
(WebCore::toInt32):
(WebCore::toUInt32):
(WebCore::toInt64):
(WebCore::toUInt64):
- 11:06 AM Changeset in webkit [146364] by
-
- 9 edits in trunk/Source
Remove Local/Remote and RTCStatsElement from WebRTCStats API
https://bugs.webkit.org/show_bug.cgi?id=112678
Patch by Harald Alvestrand <hta@google.com> on 2013-03-20
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/WebRTCStatsResponse.h:
(WebRTCStatsResponse):
Source/WebCore:
Pure removal, remaining functionality covered by existing test.
- Modules/mediastream/RTCStatsReport.cpp:
- Modules/mediastream/RTCStatsReport.h:
(RTCStatsReport):
- Modules/mediastream/RTCStatsResponse.cpp:
- Modules/mediastream/RTCStatsResponse.h:
(RTCStatsResponse):
- platform/chromium/support/WebRTCStatsResponse.cpp:
- platform/mediastream/RTCStatsResponseBase.h:
(RTCStatsResponseBase):
- 10:56 AM Changeset in webkit [146363] by
-
- 2 edits in trunk
[Qt] Define MODULE_VERSION
https://bugs.webkit.org/show_bug.cgi?id=112808
Reviewed by Allan Sandfeld Jensen.
Upstream http://codereview.qt-project.org/49052
Use 5.2.0 as this is the next release that will be branched from trunk.
- .qmake.conf:
- 10:33 AM Changeset in webkit [146362] by
-
- 2 edits in trunk/Source/WebCore
ASSERTION FAILED: !m_renderingAutomaticPullNodes.size()
https://bugs.webkit.org/show_bug.cgi?id=112777
Reviewed by Chris Rogers.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::~AudioContext):
- 10:28 AM Changeset in webkit [146361] by
-
- 13 edits2 adds in trunk
Copy-paste should not spellcheck when continuous spellcheck is turned off
https://bugs.webkit.org/show_bug.cgi?id=112464
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-03-20
Reviewed by Ryosuke Niwa.
.:
- Source/autotools/symbols.filter: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.
Source/WebCore:
Test: editing/spelling/spellcheck-paste-continuous-disabled.html
- WebCore.exp.in: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.
- WebCore.order: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.
- editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment): Do not spellcheck if continuous spellcheck is turned off.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Leave continuous spellcheck turned on after a test.
(WebCore::Internals::setContinuousSpellCheckingEnabled): Let tests enable and disable continuous spellcheck.
(WebCore):
- testing/Internals.h: Let tests enable and disable continuous spellcheck.
(Internals):
- testing/Internals.idl: Let tests enable and disable continuous spellcheck.
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.
LayoutTests:
- editing/spelling/spellcheck-paste-continuous-disabled-expected.txt: Added expected results for pasting when continuous spellcheck is turned off.
- editing/spelling/spellcheck-paste-continuous-disabled.html: Added a test for pasting with continuous spellcheck turned off.
- platform/mac-wk2/TestExpectations: Skip spellcheck-paste-continuous-disabled.html, because it is a slight modification of spellcheck-paste-disabled.html, which is also skipped in mac-wk2.
- 10:22 AM Changeset in webkit [146360] by
-
- 9 edits2 adds in trunk
Add support for MediaSource::isTypeSupported()
https://bugs.webkit.org/show_bug.cgi?id=112301
Reviewed by Darin Fisher.
Source/Platform:
- chromium/public/WebMimeRegistry.h:
(WebMimeRegistry): Added supportsMediaSourceMIMEType() method.
Source/WebCore:
Test: http/tests/media/media-source/video-media-source-is-type-supported.html
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::addSourceBuffer): Added isTypeSupported() call to verify parameters
pass into this method.
(WebCore::MediaSource::isTypeSupported):
(WebCore):
- Modules/mediasource/MediaSource.h:
(MediaSource):
- Modules/mediasource/MediaSource.idl: Added isTypeSupported().
- platform/MIMETypeRegistry.h:
(MIMETypeRegistry): Added isSupportedMediaSourceMIMEType().
- platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore):
(WebCore::MIMETypeRegistry::isSupportedMediaSourceMIMEType): Implemented in terms of WebMimeRegistry::isSupportedMediaSourceMIMEType.
LayoutTests:
- http/tests/media/media-source/video-media-source-is-type-supported-expected.txt: Added. Reflects Chromium expectations.
Valid MP4 type strings will return true
instead of false in Chrome builds.
- http/tests/media/media-source/video-media-source-is-type-supported.html: Added.
- 10:18 AM Changeset in webkit [146359] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding another email for me.
- Scripts/webkitpy/common/config/committers.py:
- 9:56 AM Changeset in webkit [146358] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] Unreviewed VS2010 build correction.
- WebCore.vcxproj/WebCore.vcxproj: Enable build of NetworkStorageSessionStub.cpp
for WinCairo port.
- WebCore.vcxproj/WebCore.vcxproj.filters: Correct build type of
CookieJarCurl from 'custom' to 'C++ source file'
- 9:55 AM Changeset in webkit [146357] by
-
- 2 edits in trunk/Source/WebCore
[V8] Rename DOMDataStore::isMainWorldObject
https://bugs.webkit.org/show_bug.cgi?id=112817
Patch by Marja Hölttä <marja@chromium.org> on 2013-03-20
Reviewed by Jochen Eisinger.
No new tests (no changes in functionality).
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::getWrapperFast):
(WebCore::DOMDataStore::getWrapper):
(WebCore::DOMDataStore::getWrapperForMainWorld):
(WebCore::DOMDataStore::setWrapper):
(WebCore::DOMDataStore::canExistInWorker):
- 9:49 AM Changeset in webkit [146356] by
-
- 4 edits in trunk/Source/WebKit2
[Qt][WK2] Clean up sanity checks related to gesture recognition
https://bugs.webkit.org/show_bug.cgi?id=112679
Reviewed by Jocelyn Turcotte.
The only callers of the panGestureActive and pinchGestureActive member
functions of the page viewport controller client are event delivery
related sanity check assers, thus they can be replaced by checking
for the corresponding internal states and therefore the superfluous
members can be removed.
Also update other asserts in the page viewport controller client to
be more accurate about the expected states.
- UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::touchBegin):
(WebKit::PageViewportControllerClientQt::panGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
- UIProcess/qt/PageViewportControllerClientQt.h:
(PageViewportControllerClientQt):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::handleInputEvent):
- 9:45 AM Changeset in webkit [146355] by
-
- 6 edits in trunk/Source/WebKit2
[Qt][WK2] Refactor handling of content suspension to properly cover corner cases
https://bugs.webkit.org/show_bug.cgi?id=111751
Reviewed by Jocelyn Turcotte.
The current suspend / resume infrastructure turned out to be insufficient to cover
all corner cases during transitions between gestures of complex gesture chains.
The requirements for robust suspend / resume handling are:
- Keep the content suspended while the user is continuously interacting,
eg. does not lift the finger between transition from a pan to a pinch gesture
and vice versa.
- The content should not be suspended unnecessarily (like for a tap gesture),
only during panning and scroll animation (flick), as well as pinch zoom and scale
animation (also includes double-tap-to-zoom).
- The content should never end up stuck in suspended state after long gesture
chains and continuous interaction.
This patch reintroduces reference counting based suspension in form of a new
ViewportInteractionTracker member class to make it possible to reliably control the
suspend / resume cycles during scrolling and scaling.
During continuous gestures, while the user is interacting, the reference count is
increased without actually suspending the content to prevent resuming unnecessarily
during continuous interaction. At the same time this also assures that the page is
not suspended for simple tap gestures, which was a side-effect of the previous
approach based on update deferrers.
The newly added functionality replaces boolean members that tried to achive the
above requirements.
Additionally this patch also removes the redundant m_hasSuspendedContent member
from the PageViewportController since WebPageProxy already keeps this information.
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::updateMinimumScaleToFit):
- UIProcess/PageViewportController.h:
(PageViewportController):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::areActiveDOMObjectsAndAnimationsSuspended):
- UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::begin):
(WebKit):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::end):
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::flickMoveStarted):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::pageItemPositionChanged):
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):
(WebKit::PageViewportControllerClientQt::touchBegin):
(WebKit::PageViewportControllerClientQt::touchEnd):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::pinchGestureEnded):
(WebKit::PageViewportControllerClientQt::pinchGestureCancelled):
(WebKit::PageViewportControllerClientQt::didChangeContentsSize):
- UIProcess/qt/PageViewportControllerClientQt.h:
(ViewportInteractionTracker):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::ViewportInteractionTracker):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::inProgress):
(PageViewportControllerClientQt):
- 9:19 AM Changeset in webkit [146354] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Flame Chart. Provide Overview pane for better user expirience.
https://bugs.webkit.org/show_bug.cgi?id=112496
Reviewed by Yury Semikhatsky.
This patch implements basic part of Overview Pane in FlameChart.
The idea of the patch is to move everything into chart-container element.
And put OverviewGrid into new overview-container element.
Drive by change: fix the layout of the flame chart elements.
Drive by change: fix the drag window & drag resizer mechanics
for the case when the parent element has zero offsetLeft.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.OverviewCalculator):
(WebInspector.FlameChart.OverviewCalculator.prototype._updateBoundaries):
(WebInspector.FlameChart.OverviewCalculator.prototype.computePosition):
(WebInspector.FlameChart.OverviewCalculator.prototype.formatTime):
(WebInspector.FlameChart.OverviewCalculator.prototype.maximumBoundary):
(WebInspector.FlameChart.OverviewCalculator.prototype.minimumBoundary):
(WebInspector.FlameChart.OverviewCalculator.prototype.boundarySpan):
(WebInspector.FlameChart.prototype._onWindowChanged):
(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype.update):
- inspector/front-end/OverviewGrid.js:
(WebInspector.OverviewGrid.Window):
(WebInspector.OverviewGrid.Window.prototype._resizerElementStartDragging):
(WebInspector.OverviewGrid.Window.prototype._leftResizeElementDragging):
(WebInspector.OverviewGrid.Window.prototype._rightResizeElementDragging):
(WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._windowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._endWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._setWindowPosition):
(WebInspector.OverviewGrid.Window.prototype._onMouseWheel):
(WebInspector.OverviewGrid.WindowSelector):
- inspector/front-end/TimelineOverviewPane.js:
- inspector/front-end/flameChart.css:
(.chart-container .item-anchor):
(.overview-container):
(.chart-container):
(#flame-chart-overview-grid .resources-dividers-label-bar):
- inspector/front-end/inspectorCommon.css:
(.resources-divider-label):
- 9:07 AM Changeset in webkit [146353] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: Plumbing CSS warnings
https://bugs.webkit.org/show_bug.cgi?id=111334
Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-20
Reviewed by Pavel Feldman.
Adding a framework for plumbing CSS warnings from CSSParser/grammar to the Inspector console.
- css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::syntaxError):
(WebCore):
(WebCore::CSSParser::isLoggingErrors):
(WebCore::CSSParser::logError):
- css/CSSParser.h:
(CSSParser):
(CSSParser::Location):
(WebCore):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseString):
(WebCore::StyleSheetContents::parseStringAtLine):
- css/StyleSheetContents.h:
(StyleSheetContents):
- dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
- page/PageConsole.cpp:
(WebCore::PageConsole::addMessage):
- 9:05 AM Changeset in webkit [146352] by
-
- 1 edit1 delete in trunk/LayoutTests
[Qt] Qt 4.8 expected results removal from Trunk.
Reviewed by Csaba Osztrogonác.
- platform/qt-4.8/TestExpectations: Removed.
- platform/qt-4.8/css1/text_properties/text_transform-expected.txt: Removed.
- platform/qt-4.8/editing/selection/regional-indicators-expected.txt: Removed.
- platform/qt-4.8/fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
- platform/qt-4.8/fast/dom/Range/surround-contents-font-face-crash-expected.txt: Removed.
- platform/qt-4.8/fast/dom/xml-parser-error-message-crash-expected.txt: Removed.
- platform/qt-4.8/fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: Removed.
- platform/qt-4.8/fast/events/xsl-onload-expected.txt: Removed.
- platform/qt-4.8/fast/parser/xml-colon-entity-expected.txt: Removed.
- platform/qt-4.8/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Removed.
- platform/qt-4.8/fast/parser/xslt-with-html-expected.txt: Removed.
- platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Removed.
- platform/qt-4.8/fast/text/find-kana-expected.txt: Removed.
- platform/qt-4.8/fast/text/find-russian-expected.txt: Removed.
- platform/qt-4.8/fast/text/find-soft-hyphen-expected.txt: Removed.
- platform/qt-4.8/fast/url/path-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/subframe-location-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/transform-to-html-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/utf8-chunks-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/xslt-bad-import-uri-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/xslt-doc-noenc-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/xslt-entity-enc-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/xslt-entity-expected.png: Removed.
- platform/qt-4.8/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/xslt-recursion-expected.txt: Removed.
- platform/qt-4.8/http/tests/misc/location-test-xsl-style-sheet-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.png: Removed.
- platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.png: Removed.
- platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Removed.
- platform/qt-4.8/http/tests/xmlhttprequest/methods-expected.txt: Removed.
- platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Removed.
- platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-expected.txt: Removed.
- platform/qt-4.8/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Removed.
- platform/qt-4.8/svg/custom/bug45331-expected.png: Removed.
- platform/qt-4.8/svg/custom/bug45331-expected.txt: Removed.
- platform/qt-4.8/svg/custom/bug78807-expected.txt: Removed.
- platform/qt-4.8/svg/custom/use-invalid-html-expected.txt: Removed.
- platform/qt-4.8/svg/custom/use-invalid-style-expected.txt: Removed.
- platform/qt-4.8/svg/hixie/error/dumpAsText/004-expected.txt: Removed.
- platform/qt-4.8/svg/hixie/error/dumpAsText/005-expected.txt: Removed.
- 8:59 AM Changeset in webkit [146351] by
-
- 27 edits in trunk
[Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
https://bugs.webkit.org/show_bug.cgi?id=112605
Reviewed by James Robinson.
Source/WebCore:
Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.
No new tests: Affected code paths covered by existing tests.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
- html/HTMLCanvasElement.h:
- page/Settings.in:
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
(ImageBuffer):
- platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::storageAllocatedForRecordingChanged):
(WebCore::Canvas2DLayerBridge::storageAllocatedForRecording):
(WebCore::Canvas2DLayerBridge::freeMemoryIfPossible):
(WebCore::Canvas2DLayerBridge::flush):
(WebCore::Canvas2DLayerBridge::skCanvas):
(WebCore::Canvas2DLayerBridge::prepareTexture):
(WebCore::Canvas2DLayerBridge::contextAcquired):
- platform/graphics/chromium/Canvas2DLayerBridge.h:
(WebCore::Canvas2DLayerBridge::create):
(Canvas2DLayerBridge):
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::ImageBuffer):
Source/WebKit/chromium:
Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.
- public/WebSettings.h:
(WebKit::WebSettings::setDeferred2dCanvasEnabled):
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDeferred2dCanvasEnabled):
- tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
- tests/Canvas2DLayerManagerTest.cpp:
(FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge):
Tools:
Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::runFileTest):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
LayoutTests:
Marked some 2d canvas tests as failing. These tests are using the
two point radial gradient API. The bug was already present in
chromium. Starts getting detected in DRT with this change.
Related: crbug.com/222140
- 8:42 AM Changeset in webkit [146350] by
-
- 6 edits in trunk
Drop full URLs from cross-domain access errors caused by 'document.domain' mismatches.
https://bugs.webkit.org/show_bug.cgi?id=112813
Reviewed by Timothy Hatcher.
Source/WebCore:
Following up on http://wkbug.com/112042, this patch brings 'document.domain'
mismatch error messages into line with the newly origin-only default
message. There will probably be two or three more patches in this series
just to keep the rebaselines down to something managably reviewable.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::crossDomainAccessErrorMessage):
Move the default message redefinition up out of the final 'return' so
that 'document.domain' mismatch errors grab the new text.
LayoutTests:
- http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
- http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
- http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
- 8:40 AM Changeset in webkit [146349] by
-
- 10 edits in trunk/Source
Web Inspector: Add promptText param to Page.handleJavaScriptDialog
https://bugs.webkit.org/show_bug.cgi?id=112706
Patch by Ken Kania <kkania@chromium.org> on 2013-03-20
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorClient.h:
(WebCore::InspectorClient::handleJavaScriptDialog):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::handleJavaScriptDialog):
- inspector/InspectorPageAgent.h:
Source/WebKit/chromium:
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::handleJavaScriptDialog):
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
- 8:28 AM Changeset in webkit [146348] by
-
- 1 copy in releases/WebKitGTK/webkit-1.11.92
Tagging the WebKitGTK+ 1.11.92 release
- 8:10 AM Changeset in webkit [146347] by
-
- 3 edits in trunk/Tools
[Qt] Qt 4.8 tool related stuff removal from webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=112699.
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._search_paths):
(QtPort._port_specific_expectations_files):
- Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest._assert_expectations_files):
- 8:09 AM Changeset in webkit [146346] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0
Unreviewed. Update NEWS and Versions.m4 for 1.11.92 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 1.11.92.
- 7:59 AM Changeset in webkit [146345] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix SourceFrame.js compilation warning
https://bugs.webkit.org/show_bug.cgi?id=112804
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Yury Semikhatsky.
No new tests: no change in behavior.
- Explicitly parse lineNumber from object property name.
- Add type annotations to ensure addMessageToSource is monomorphic.
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.clearMessages):
- 7:34 AM Changeset in webkit [146344] by
-
- 2 edits in trunk/Source/WebCore
[v8] unsafe persistent access in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=112807
Patch by Dan Carney <dcarney@google.com> on 2013-03-20
Reviewed by Kentaro Hara.
No new tests.
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::toObjectWrapper):
- 7:32 AM Changeset in webkit [146343] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Enable appropriate vertex attribute arrays in LayerRenderer::useProgram()
https://bugs.webkit.org/show_bug.cgi?id=112757
Reviewed by Rob Buis.
PR 306465
Make the LayerRenderer and associated code more bullet-proof when it
comes to enabling vertex attribute arrays, by enabling them already
when LayerRenderer::useProgram() is called. This fixes a bug where the
video hole punch rectangle wasn't punched when preceding rendering
caused the vertex attribute array at index 0 to be disabled, such as
when rendering the text selection overlay immediately before video.
A number of places where the position attribute index was hard-coded
to 0 were also fixed. This causes no change in behavior, the position
attribute was really at 0, but nonetheless that shouldn't be hardcoded.
The effects of this patch are only manually testable.
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawColor):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::useProgram):
- 7:30 AM Changeset in webkit [146342] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] implement highlightRange method
https://bugs.webkit.org/show_bug.cgi?id=112802
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Vsevolod Vlasov.
- Implement highlightRange/removeHighlight methods in
CodeMirrorTextEditor.
- Update TextEditor interface closure annotations.
No new tests.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.removeHighlight):
(WebInspector.CodeMirrorTextEditor.prototype.highlightRange):
- inspector/front-end/DefaultTextEditor.js:
- inspector/front-end/TextEditor.js:
- 7:28 AM Changeset in webkit [146341] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] show source location for codemirror text editor
https://bugs.webkit.org/show_bug.cgi?id=112798
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Vsevolod Vlasov.
No new tests.
- Implement CodeMirrorTextEditor.copyRange method
- Fire "selectionChange" event for text editor delegate from
CodeMirrorTextEditor.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.copyRange):
(WebInspector.CodeMirrorTextEditor.prototype._cursorActivity):
- 7:18 AM Changeset in webkit [146340] by
-
- 7 edits in trunk
[Qt] Enable kerning by default
https://bugs.webkit.org/show_bug.cgi?id=112704
Reviewed by Jocelyn Turcotte.
Source/WebKit/qt:
Enable default kerning when fast kerning is available.
To support layout tests that depend on kerning being off by default,
a method is added to DumpRenderTreeSupportQt to reset the default.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::resetDefaultTypesettingFeatures):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- WebCoreSupport/InitWebCoreQt.cpp:
(WebKit::initializeWebKitQt):
Tools:
Disable kerning by default, since some reference test expectations
expect kerning to be default off.
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::reset):
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
- 7:06 AM Changeset in webkit [146339] by
-
- 2 edits in trunk/Source/JavaScriptCore
Implement and32 on MIPS platform
https://bugs.webkit.org/show_bug.cgi?id=112665
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-03-20
Reviewed by Zoltan Herczeg.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::and32): Added missing method.
(MacroAssemblerMIPS):
- 6:38 AM Changeset in webkit [146338] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Unreviewed. Fix make distcheck.
- GNUmakefile.am: Add WebKitFeatures.txt and WebKitFeatures.h to
DISTCLEANFILES.
- 6:29 AM Changeset in webkit [146337] by
-
- 3 edits in trunk/Tools
[Qt] Remove empty function stubs from TestRunnerQt.
https://bugs.webkit.org/show_bug.cgi?id=112799
We are reducing the code in TestRunnerQt step by step,
in order to finally replace all of it with the generic
TestRunner implementation.
This patch removes several simple function stubs that
currently do not implement any actual functionality.
Reviewed by Kenneth Rohde Christiansen.
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
- 6:24 AM WebKitGTK/2.0.x edited by
- (diff)
- 6:21 AM Changeset in webkit [146336] by
-
- 1 edit1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merged 146335 - [or] Updated WebKitGTK+ Translation for Odia [or] language.
https://bugs.webkit.org/show_bug.cgi?id=103037
Patch by Manoj Kumar Giri <mgiri@redhat.com> on 2013-03-20
Rubber-stamped by Gustavo Noronha Silva (kov).
- or.po: Added.
- 6:16 AM Changeset in webkit [146335] by
-
- 1 edit1 add in trunk/Source/WebCore/platform/gtk/po
[or] Updated WebKitGTK+ Translation for Odia [or] language.
https://bugs.webkit.org/show_bug.cgi?id=103037
Patch by Manoj Kumar Giri <mgiri@redhat.com> on 2013-03-20
Rubber-stamped by Gustavo Noronha Silva (kov).
- or.po: Added.
- 6:08 AM Changeset in webkit [146334] by
-
- 4 edits in trunk
Unreviewed, rolling out r146331.
http://trac.webkit.org/changeset/146331
https://bugs.webkit.org/show_bug.cgi?id=112795
Does not work as expected (Requested by carewolf on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20
Source/WebCore:
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::initFormatForTextLayout):
LayoutTests:
- platform/qt/TestExpectations:
- 5:43 AM Changeset in webkit [146333] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Resources] Local Storage: "Add item" row height doesn't match underlying grid.
https://bugs.webkit.org/show_bug.cgi?id=112433
Reviewed by Pavel Feldman.
Fixed cell height to correspond grid step.
- inspector/front-end/dataGrid.css:
(.data-grid td): Fixed cell height to correspond grid step.
- 5:26 AM Changeset in webkit [146332] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
https://bugs.webkit.org/show_bug.cgi?id=112687
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-20
Reviewed by Kenneth Rohde Christiansen.
Hide the SearchBar by default on window creation.
- MiniBrowser/efl/main.c:
(window_create):
- 4:53 AM Changeset in webkit [146331] by
-
- 4 edits in trunk
[Qt] New fast/text/word-space-with-kerning-3.html fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=112668
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Kerning is on by default in Qt. This means we need to disable it
when WebCore does not request it.
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::initFormatForTextLayout):
LayoutTests:
- platform/qt/TestExpectations:
- 4:51 AM Changeset in webkit [146330] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: OverviewGrid rename classes according to names of js classes.
https://bugs.webkit.org/show_bug.cgi?id=112786
Reviewed by Yury Semikhatsky.
It is a part of meta bug 'extract OverviewGrid from TimelineOverviewPane'.
As the last step it renames timeline-...... classes to overview-grid-...... classes
and moves them to inspectorCommon.css
- inspector/front-end/OverviewGrid.js:
(WebInspector.OverviewGrid):
(WebInspector.OverviewGrid.Window):
(WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
(WebInspector.OverviewGrid.WindowSelector):
(WebInspector.OverviewGrid.WindowSelector.prototype._createSelectorElement):
- inspector/front-end/inspectorCommon.css:
(.overview-grid-window-selector):
(.overview-grid-window):
(.overview-grid-dividers-background):
(.overview-grid-window-rulers):
(.overview-grid-window-resizer):
- inspector/front-end/timelinePanel.css:
(.timeline-frame-overview .overview-grid-window):
(.timeline-frame-overview .overview-grid-dividers-background):
- 4:50 AM Changeset in webkit [146329] by
-
- 11 edits5 moves1 add1 delete in trunk/Tools
Unreviewed, rolling out r146304.
http://trac.webkit.org/changeset/146304
https://bugs.webkit.org/show_bug.cgi?id=112788
to many expectations to update (Requested by antonm on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
- DumpRenderTree/chromium/TestShell.h:
(WebKit):
- DumpRenderTree/chromium/TestShellMac.mm:
(platformInit):
- DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
- DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
(WebThemeControlDRTWin::WebThemeControlDRTWin):
(WebThemeControlDRTWin::~WebThemeControlDRTWin):
(WebThemeControlDRTWin::box):
(WebThemeControlDRTWin::line):
(WebThemeControlDRTWin::triangle):
(WebThemeControlDRTWin::roundRect):
(WebThemeControlDRTWin::oval):
(WebThemeControlDRTWin::circle):
(WebThemeControlDRTWin::nestedBoxes):
(WebThemeControlDRTWin::markState):
(WebThemeControlDRTWin::draw):
(WebThemeControlDRTWin::drawTextField):
(WebThemeControlDRTWin::drawProgressBar):
- DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
(WebThemeControlDRTWin):
- DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
(WebThemeEngineDRTMac):
- DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebThemeEngineDRTMac::paintScrollbarThumb):
(stateToHIEnableState):
(WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
- DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
(webRectToSkIRect):
(drawControl):
(drawTextField):
(drawProgressBar):
(WebThemeEngineDRTWin::paintButton):
(WebThemeEngineDRTWin::paintMenuList):
(WebThemeEngineDRTWin::paintScrollbarArrow):
(WebThemeEngineDRTWin::paintScrollbarThumb):
(WebThemeEngineDRTWin::paintScrollbarTrack):
(WebThemeEngineDRTWin::paintSpinButton):
(WebThemeEngineDRTWin::paintTextField):
(WebThemeEngineDRTWin::paintTrackbar):
(WebThemeEngineDRTWin::paintProgressBar):
(WebThemeEngineDRTWin::getSize):
- DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
(WebThemeEngineDRTWin):
(WebThemeEngineDRTWin::WebThemeEngineDRTWin):
- 4:43 AM Changeset in webkit [146328] by
-
- 3 edits1 delete in trunk/LayoutTests
Unreviewed, rolling out r146315.
http://trac.webkit.org/changeset/146315
https://bugs.webkit.org/show_bug.cgi?id=112789
followup to 146304 rollout (Requested by antonm on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20
- platform/chromium-mac-snowleopard/css1/box_properties/border_right_inline-expected.png:
- platform/chromium-win-xp/css1/box_properties/border_right_inline-expected.png: Removed.
- platform/chromium-win/css1/box_properties/border_right_inline-expected.png:
- 4:41 AM Changeset in webkit [146327] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r146316.
http://trac.webkit.org/changeset/146316
https://bugs.webkit.org/show_bug.cgi?id=112790
followup to 146304 rollout (Requested by antonm on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20
- platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png:
- 4:31 AM Changeset in webkit [146326] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Switch Drawer animation from JavaScript to CSS transitions.
https://bugs.webkit.org/show_bug.cgi?id=112586
This is prerequisite to make Drawer work in overlay mode.
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-20
Reviewed by Vsevolod Vlasov.
- inspector/front-end/Drawer.js:
(WebInspector.Drawer):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide.this.animationFinished):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.immediatelyFinishAnimation):
(WebInspector.Drawer.prototype._getAnimationStyles):
- inspector/front-end/UIUtils.js:
- inspector/front-end/inspector.css:
(.animate-slow *):
(.animate #main):
(.animate #floating-status-bar-container):
(.animate #drawer):
(.animate #bottom-status-bar-container > *):
- 4:30 AM Changeset in webkit [146325] by
-
- 18 edits in trunk
Web Inspector: [DataGrid] Refactorings.
https://bugs.webkit.org/show_bug.cgi?id=112690
Reviewed by Pavel Feldman.
Source/WebCore:
- Avoid using string literals;
- Remove unused notifications; turn "populate" to method invocation;
- Replace some getters with regular functions.
- inspector/front-end/DataGrid.js: Applied refactorings.
- inspector/front-end/ApplicationCacheItemsView.js: Adopted changes.
- inspector/front-end/BottomUpProfileDataGridTree.js: Ditto.
- inspector/front-end/CPUProfileView.js: Ditto.
- inspector/front-end/CSSSelectorProfileView.js: Ditto.
- inspector/front-end/CookiesTable.js: Ditto.
- inspector/front-end/DirectoryContentView.js: Ditto.
- inspector/front-end/HeapSnapshotDataGrids.js: Ditto.
- inspector/front-end/HeapSnapshotGridNodes.js: Ditto.
- inspector/front-end/NativeMemorySnapshotView.js: Ditto.
- inspector/front-end/NetworkPanel.js: Ditto.
- inspector/front-end/ProfileDataGridTree.js: Ditto.
- inspector/front-end/ResourceWebSocketFrameView.js: Ditto.
- inspector/front-end/TopDownProfileDataGridTree.js: Ditto.
- inspector/front-end/dataGrid.css: Ditto.
LayoutTests:
Adopted changes.
- inspector/profiler/heap-snapshot-test.js: Adopted changes.
- 4:22 AM Changeset in webkit [146324] by
-
- 7 edits in trunk
[Qt] Support -webkit-font-smoothing
https://bugs.webkit.org/show_bug.cgi?id=106009
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Set QFont antialiasing settings based on the font smoothing settings in FontDescription.
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
Source/WebKit/qt:
Export an interface so DRT can also disable font-smoothing like WTR does.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setShouldUseFontSmoothing):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools:
Set shouldUseFontSmoothing to false to match WebKitTestRunner.
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::reset):
- 4:05 AM Changeset in webkit [146323] by
-
- 1 edit3 adds in trunk/LayoutTests
[Qt] Unreviewed rebaselining after r146206.
The webgl-composite-modes test started failing due to
the newly introduced more restrictive pixel tolerance.
It turns out that the expectation was created without multisampling
enabled. However, Qt does implement this.
- platform/qt/fast/canvas/webgl/webgl-composite-modes-expected.png: Added.
- platform/qt/fast/canvas/webgl/webgl-composite-modes-expected.txt: Added.
- 4:04 AM Changeset in webkit [146322] by
-
- 2 edits in trunk/Source/WebKit/efl
ewk_settings_memory_cache_clear should clear JS garbage and release FastMalloc's free pages to OS
https://bugs.webkit.org/show_bug.cgi?id=112536
Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-03-20
Reviewed by Gyuyoung Kim.
Added changes to clear JS garbage and release FastMalloc's free pages to OS
while calling ewk_settings_memory_cache_clear API.
- ewk/ewk_settings.cpp:
(ewk_settings_memory_cache_clear):
- 3:15 AM Changeset in webkit [146321] by
-
- 3 edits in trunk/LayoutTests
[EFL] accessibility/aria-scrollbar-role.html is failing
https://bugs.webkit.org/show_bug.cgi?id=111989
Unreviewed EFL gardening
accessibility/aria-scrollbar-role.html passes after r146312.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-20
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- 3:01 AM Changeset in webkit [146320] by
-
- 6 edits1 add in trunk
[EFL] Disable REQUEST_ANIMATION_FRAME_TIMER to render a new animation frame.
https://bugs.webkit.org/show_bug.cgi?id=112114
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2013-03-20
Reviewed by Kenneth Rohde Christiansen.
.:
Add a manual test to check the running of scripted transition animation.
- ManualTests/animation/transition-on-and-offscreen-animation.html: Added.
Source/WebKit/efl:
Add dummy functions for WK1.
Example test case: ManualTests/animation/transition-on-and-offscreen-animation.html
- WebCoreSupport/ChromeClientEfl.cpp: Add dummy functions for WK1.
(WebCore):
(WebCore::ChromeClientEfl::scheduleAnimation):
(WebCore::ChromeClientEfl::serviceScriptedAnimations):
- WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
Source/WTF:
The issue is that if the animation starts outside of the area covered by keepRects,
the web process does not create tiles of the animation layer and the layer moves
without having any tiles. In order to fix this issue, CoordinatedLayerHost must call
scheduleLayerFlush to create new tiles when the layer enters the area covered by keepRect.
However EFL port didn't call scheduleLayerFlush periodically for animation.
We can tie scripted animations with synchronization of the layer and that already
has been implemented in r123786 by Qt port. This patch is for activating r123786 patch.
The testing is covered by ManualTests/animation/transition-on-and-offscreen-animation.html
- wtf/Platform.h: Disable REQUEST_ANIMATION_FRAME_TIMER.
- 3:01 AM Changeset in webkit [146319] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Allow toolbar customization
https://bugs.webkit.org/show_bug.cgi?id=112440
Adds a tools menu item that allows the user to show/hide
inspector panels on the toolbar.
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-20
Reviewed by Yury Semikhatsky.
- inspector/front-end/InspectorView.js:
- inspector/front-end/Settings.js:
(WebInspector.Settings):
(WebInspector.ExperimentsSettings):
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.addPanel):
(WebInspector.Toolbar.prototype._isPanelVisibleByDefault):
(WebInspector.Toolbar.prototype.set _hidePanel):
(WebInspector.Toolbar.prototype._showPanel):
(WebInspector.Toolbar.prototype._togglePanelsMenu):
- inspector/front-end/inspector.css:
(#toolbar-panels-menu):
(#toolbar-panels-menu:hover):
(#toolbar-panels-menu:active):
- inspector/front-end/inspector.html:
- 2:09 AM Changeset in webkit [146318] by
-
- 26 edits in trunk/Source
Source/JavaScriptCore: Fix incorrect debugger column number value.
https://bugs.webkit.org/show_bug.cgi?id=112741.
Reviewed by Oliver Hunt.
- In lexer, parser, and debugger code, renamed column to charPosition.
- Convert the charPosition to the equivalent column number before passing it to the debugger.
- Changed ScopeNodes to take both a startLocation and an endLocation. This allows FunctionBodyNodes, ProgramNodes, and EvalNodess to emit correct debug hooks with correct starting line and column numbers.
- Fixed the Lexer to not reset the charPosition (previously columnNumber) in Lexer::lex().
- JavaScriptCore.order:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitExpressionInfo):
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::toArgumentList):
(JSC::ConstStatementNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::debug):
- convert charPosition to column for the debugger.
- interpreter/Interpreter.h:
- jit/JITStubs.cpp:
(DEFINE_STUB_FUNCTION(void, op_debug)):
- llint/LLIntSlowPaths.cpp:
(LLINT_SLOW_PATH_DECL(slow_op_debug)):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
- parser/Lexer.cpp:
(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):
- parser/Lexer.h:
(JSC::Lexer::currentCharPosition):
(Lexer):
(JSC::::lexExpectIdentifier):
- parser/NodeConstructors.h:
(JSC::Node::Node):
- parser/Nodes.cpp:
(JSC::StatementNode::setLoc):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
- parser/Nodes.h:
(JSC::Node::charPosition):
(Node):
(StatementNode):
(JSC::StatementNode::lastLine):
(ScopeNode):
(JSC::ScopeNode::startLine):
(JSC::ScopeNode::startCharPosition):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
- parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
- parser/Parser.h:
(JSC::::parse):
- parser/ParserTokens.h:
(JSC::JSTokenLocation::JSTokenLocation):
(JSTokenLocation):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFunctionBody):
Source/WTF: Introducing String::reverseFindLineTerminator().
https://bugs.webkit.org/show_bug.cgi?id=112741.
Reviewed by Oliver Hunt.
This is needed by the JSC debugger code for computing column numbers.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::reverseFindLineTerminator):
- wtf/text/StringImpl.h:
(StringImpl):
(WTF::reverseFindLineTerminator):
- wtf/text/WTFString.h:
(WTF::String::reverseFindLineTerminator):
- 2:08 AM Changeset in webkit [146317] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Settings] Add "storage" parameter to WebInspector.Setting
https://bugs.webkit.org/show_bug.cgi?id=112667
Reviewed by Pavel Feldman.
New parameter will allow more options on how long setting will persist.
Possible options are: localStorage, sessionStorage and no-storage.
Additional change: use delete instead of .removeItem to make it possible
use any object as storage.
- inspector/front-end/Settings.js:
Added "storage" parameter and used is instead of "window.localStorage".
- 1:55 AM Changeset in webkit [146316] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening.
Rebaselining after r146304.
- platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png:
- 1:43 AM Changeset in webkit [146315] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed Chromium gardening.
Rebaselining after r146304.
- platform/chromium-mac-snowleopard/css1/box_properties/border_right_inline-expected.png:
- platform/chromium-win-xp/css1/box_properties/border_right_inline-expected.png: Added.
- platform/chromium-win/css1/box_properties/border_right_inline-expected.png:
- 1:38 AM Changeset in webkit [146314] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Network] Fix the bug of WebSocketFrameView crash.
https://bugs.webkit.org/show_bug.cgi?id=112771.
Patch by Pan Deng <pan.deng@intel.com> on 2013-03-20
Reviewed by Pavel Feldman.
WebSocketFrameView crashes when websocket receives an error message, this
patch fixes this problem, and error message will be shown in dataGrid as expected.
No new tests.
- inspector/front-end/ResourceWebSocketFrameView.js:
(WebInspector.ResourceWebSocketFrameView): Handle the errorMessage case.
- 1:34 AM Changeset in webkit [146313] by
-
- 6 edits in trunk/Source/WebCore
Remove remainings of obsolete LogLevels and MessageSources from inspector JS part.
https://bugs.webkit.org/show_bug.cgi?id=112709
By the way tuned messagesources in ApplicationCacheGroup.
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-20
Reviewed by Pavel Feldman.
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.toMessageElement):
(WebInspector.ConsoleMessageImpl.prototype.toString):
- inspector/front-end/ConsoleModel.js:
- inspector/front-end/ExtensionAPI.js:
(defineCommonExtensionSymbols):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddConsoleMessage):
(WebInspector.ExtensionServer.prototype._makeConsoleMessage):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::didFail):
- 1:12 AM Changeset in webkit [146312] by
-
- 7 edits in trunk
[GTK] accessibility/aria-scrollbar-role.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98358
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-20
Reviewed by Martin Robinson.
Source/WebCore:
Adds support for checking an orientation attribute of accessibility object.
AccessibilityObject that represents ScrollBar element should be ATK_VALUE type.
ScrollBar element can be considered as a Range Widget that is able to expose some
range values.
Test: accessibility/aria-scrollbar-role.html
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(setAtkStateSetFromCoreObject):
(getInterfaceMaskFromObject):
Tools:
Adds support for checking accessibility object's orientation.
Orientation is checked by retrieving proper state of accessibility object.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(checkElementState):
(AccessibilityUIElement::orientation):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::orientation):
LayoutTests:
Fixed failing test.
- platform/gtk/TestExpectations:
- 1:07 AM Changeset in webkit [146311] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fixing a typo in libLevelDB_la_CFLAGS assignment - cxflags -> cflags.
- GNUmakefile.am:
- 1:03 AM Changeset in webkit [146310] by
-
- 3 edits2 adds in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r146305.
- platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/gtk/http/tests/security/contentSecurityPolicy/1.1: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt: Added.
- 12:52 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 12:51 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 12:43 AM Changeset in webkit [146309] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r146089): It broke 20 sputnik tests on ARM traditional and Thumb2
https://bugs.webkit.org/show_bug.cgi?id=112676
Rubber-stamped by Filip Pizlo.
Add one more EABI_32BIT_DUMMY_ARG to make DFG JIT ARM EABI compatible
again after r146089 similar to https://bugs.webkit.org/show_bug.cgi?id=84449
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- 12:16 AM Changeset in webkit [146308] by
-
- 3 edits2 adds in trunk
Absolute position div without width specified does not reflow its text when it is moved (and computed width changes)
https://bugs.webkit.org/show_bug.cgi?id=112052
Source/WebCore:
Reviewed by Emil A Eklund.
If a positioned block has auto width then any movement means the block needs to be resized.
Test: fast/block/positioned-block-auto-width-movement.html
- rendering/style/RenderStyle.cpp:
(WebCore::positionedObjectMoved):
(WebCore::RenderStyle::diff):
LayoutTests:
Reviewed by Emil A Eklund.
- fast/block/positioned-block-auto-width-movement-expected.html: Added.
- fast/block/positioned-block-auto-width-movement.html: Added.
- 12:08 AM Changeset in webkit [146307] by
-
- 30 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK] Add padding to all public class structs for future expansion without breaking ABI
https://bugs.webkit.org/show_bug.cgi?id=112565
Reviewed by Gustavo Noronha Silva.
Use 4 pointers for most of the classes that are unlikely to grow
and 8 for WebKitWebView and WebKitWebContext.
- UIProcess/API/gtk/WebKitBackForwardList.h:
(_WebKitBackForwardListClass):
- UIProcess/API/gtk/WebKitBackForwardListItem.h:
(_WebKitBackForwardListItemClass):
- UIProcess/API/gtk/WebKitContextMenu.h:
(_WebKitContextMenuClass):
- UIProcess/API/gtk/WebKitContextMenuItem.h:
(_WebKitContextMenuItemClass):
- UIProcess/API/gtk/WebKitCookieManager.h:
(_WebKitCookieManagerClass):
- UIProcess/API/gtk/WebKitDownload.h:
(_WebKitDownloadClass):
- UIProcess/API/gtk/WebKitFaviconDatabase.h:
(_WebKitFaviconDatabaseClass):
- UIProcess/API/gtk/WebKitFileChooserRequest.h:
(_WebKitFileChooserRequestClass):
- UIProcess/API/gtk/WebKitFindController.h:
(_WebKitFindControllerClass):
- UIProcess/API/gtk/WebKitFormSubmissionRequest.h:
(_WebKitFormSubmissionRequestClass):
- UIProcess/API/gtk/WebKitGeolocationPermissionRequest.h:
(_WebKitGeolocationPermissionRequestClass):
- UIProcess/API/gtk/WebKitHitTestResult.h:
(_WebKitHitTestResultClass):
- UIProcess/API/gtk/WebKitNavigationPolicyDecision.h:
(_WebKitNavigationPolicyDecisionClass):
- UIProcess/API/gtk/WebKitPlugin.h:
(_WebKitPluginClass):
- UIProcess/API/gtk/WebKitPolicyDecision.h:
(_WebKitPolicyDecisionClass):
- UIProcess/API/gtk/WebKitPrintOperation.h:
(_WebKitPrintOperationClass):
- UIProcess/API/gtk/WebKitResponsePolicyDecision.h:
(_WebKitResponsePolicyDecisionClass):
- UIProcess/API/gtk/WebKitSecurityManager.h:
(_WebKitSecurityManagerClass):
- UIProcess/API/gtk/WebKitSettings.h:
(_WebKitSettingsClass):
- UIProcess/API/gtk/WebKitURIRequest.h:
(_WebKitURIRequestClass):
- UIProcess/API/gtk/WebKitURIResponse.h:
(_WebKitURIResponseClass):
- UIProcess/API/gtk/WebKitURISchemeRequest.h:
(_WebKitURISchemeRequestClass):
- UIProcess/API/gtk/WebKitWebContext.h:
(_WebKitWebContextClass):
- UIProcess/API/gtk/WebKitWebInspector.h:
(_WebKitWebInspectorClass):
- UIProcess/API/gtk/WebKitWebResource.h:
(_WebKitWebResourceClass):
- UIProcess/API/gtk/WebKitWebView.h:
(_WebKitWebViewClass):
- UIProcess/API/gtk/WebKitWebViewBase.h:
(_WebKitWebViewBaseClass):
- UIProcess/API/gtk/WebKitWebViewGroup.h:
(_WebKitWebViewGroupClass):
- UIProcess/API/gtk/WebKitWindowProperties.h:
(_WebKitWindowPropertiesClass):