Timeline

Mar 23, 2013:

10:50 PM Changeset in webkit [146725] by mkwst@chromium.org

• 13 edits in trunk

Drop full URLs from cross-origin access errors caused by sandboxing.
​https://bugs.webkit.org/show_bug.cgi?id=113029

Reviewed by Timothy Hatcher.

Source/WebCore:

Following up on ​http://wkbug.com/112042, this patch brings cross-origin
access error messages into line with the newly origin-only default
message, and changes the error message text to explicitly refer to the
missing 'allow-same-origin' sandbox flag that's the root cause of the
error.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::crossDomainAccessErrorMessage):

Note that we're using the origin of the frames' URLs rather than
their actual origin in these messages. This seems like a reasonable
thing to do, since we know that at least one of the two origins will
be "null" in this scenario.

LayoutTests:

• http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-expected.txt:
• http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
• http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt:
• http/tests/security/sandboxed-iframe-origin-add-expected.txt:
• http/tests/security/sandboxed-iframe-origin-remove-expected.txt:
• http/tests/security/xss-DENIED-sandboxed-iframe-expected.txt:
• platform/chromium/http/tests/security/sandboxed-iframe-modify-self-expected.txt:
• platform/chromium/http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt:

9:48 PM Changeset in webkit [146724] by dmazzoni@google.com

• 21 edits
  9 adds in trunk/Source

Implement Web Speech Synthesis for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=111695

Reviewed by Adam Barth.

Source/Platform:

Exposes a platform API that the embedder can implement to
provide speech synthesis for the Chromium port.

• Platform.gypi:
• chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::speechSynthesizer):

• chromium/public/WebSpeechSynthesisUtterance.h: Added.

(WebKit):
(WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::~WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::isNull):

• chromium/public/WebSpeechSynthesisVoice.h: Added.

(WebCore):
(WebKit):
(WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::~WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::operator=):

• chromium/public/WebSpeechSynthesizer.h: Added.

(WebKit):
(WebSpeechSynthesizer):
(WebKit::WebSpeechSynthesizer::~WebSpeechSynthesizer):

• chromium/public/WebSpeechSynthesizerClient.h: Added.

(WebKit):
(WebSpeechSynthesizerClient):
(WebKit::WebSpeechSynthesizerClient::~WebSpeechSynthesizerClient):

Source/WebCore:

Straightforward implementation of speech synthesis
for Chromium by exposing interfaces for the platform
to implement.

• Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
(WebCore):

• Modules/speech/SpeechSynthesis.h:

(SpeechSynthesis):

• Modules/speech/SpeechSynthesisUtterance.cpp:

(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore):
(WebCore::SpeechSynthesisUtterance::~SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):

• Modules/speech/SpeechSynthesisUtterance.h:

(SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(WebCore::SpeechSynthesisUtterance::platformUtterance):

• Modules/speech/SpeechSynthesisVoice.h:

(WebCore::SpeechSynthesisVoice::~SpeechSynthesisVoice):

• WebCore.exp.in:
• WebCore.gypi:
• platform/PlatformSpeechSynthesis.h:

(PlatformSpeechSynthesis):

• platform/PlatformSpeechSynthesisUtterance.cpp:

(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::create):

• platform/PlatformSpeechSynthesisUtterance.h:

(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setClient):

• platform/PlatformSpeechSynthesisVoice.cpp:

(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):

• platform/PlatformSpeechSynthesisVoice.h:

(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::setVoiceURI):
(WebCore::PlatformSpeechSynthesisVoice::setName):
(WebCore::PlatformSpeechSynthesisVoice::setLang):
(WebCore::PlatformSpeechSynthesisVoice::setLocalService):
(WebCore::PlatformSpeechSynthesisVoice::setIsDefault):

• platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::setVoiceList):
(WebCore):

• platform/PlatformSpeechSynthesizer.h:

(WebKit):
(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):

• platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Added.

(WebCore):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::speak):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore::PlatformSpeechSynthesizer::resume):
(WebCore::PlatformSpeechSynthesizer::cancel):

• platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Added.

(WebKit):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::assign):
(WebKit::WebSpeechSynthesisUtterance::reset):
(WebKit::WebSpeechSynthesisUtterance::operator PassRefPtr<PlatformSpeechSynthesisUtterance>):
(WebKit::WebSpeechSynthesisUtterance::operator PlatformSpeechSynthesisUtterance*):
(WebKit::WebSpeechSynthesisUtterance::text):
(WebKit::WebSpeechSynthesisUtterance::lang):
(WebKit::WebSpeechSynthesisUtterance::voice):
(WebKit::WebSpeechSynthesisUtterance::volume):
(WebKit::WebSpeechSynthesisUtterance::rate):
(WebKit::WebSpeechSynthesisUtterance::pitch):
(WebKit::WebSpeechSynthesisUtterance::startTime):

• platform/chromium/support/WebSpeechSynthesisVoice.cpp: Added.

(WebKit):
(WebKit::WebSpeechSynthesisVoice::assign):
(WebKit::WebSpeechSynthesisVoice::reset):
(WebKit::WebSpeechSynthesisVoice::setVoiceURI):
(WebKit::WebSpeechSynthesisVoice::setName):
(WebKit::WebSpeechSynthesisVoice::setLanguage):
(WebKit::WebSpeechSynthesisVoice::setIsLocalService):
(WebKit::WebSpeechSynthesisVoice::setIsDefault):
(WebKit::WebSpeechSynthesisVoice::operator PassRefPtr<WebCore::PlatformSpeechSynthesisVoice>):

• platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Added.

(WebCore):
(WebCore::WebSpeechSynthesizerClientImpl::WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::~WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::setVoiceList):
(WebCore::WebSpeechSynthesizerClientImpl::didStartSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didFinishSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didPauseSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didResumeSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::speakingErrorOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::wordBoundaryEventOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::sentenceBoundaryEventOccurred):

• platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Added.

(WebCore):
(WebSpeechSynthesizerClientImpl):

• platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::speak):

• platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):

• platform/mock/PlatformSpeechSynthesizerMock.h:

(PlatformSpeechSynthesizerMock):

6:24 PM Changeset in webkit [146723] by dcheng@chromium.org

• 4 edits in trunk

[Qt] editing/pasteboard/can-read-in-dragstart-event.html and /can-read-in-copy-and-cut-events.html are crashing
​https://bugs.webkit.org/show_bug.cgi?id=113126

Reviewed by Ryosuke Niwa.

Source/WebCore:

The ClipboardQt implementation only allows reading or writing, not both. Attempting to read
when the clipboard is only writable will lead to a crash since the corresponding member will
be null. To prevent crashes, change the asserts to early returns. In the long term, the
correct fix is to unify the m_readableData and m_writableData members.

No new tests since no functionality in Qt port should change.

• platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::getData):
(WebCore::ClipboardQt::types):
(WebCore::ClipboardQt::files):

LayoutTests:

• platform/qt/TestExpectations:

1:18 PM Changeset in webkit [146722] by ggaren@apple.com

• 2 edits in trunk/Source/WebKit2

Added a setting for whether JavaScript markup is enabled
​https://bugs.webkit.org/show_bug.cgi?id=112999

Rolled out a line from r146664 that was left over from before I adopted
the Settings.in way of adding a new setting.

Reviewed by Ryosuke Niwa.

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): No need
to initialize / override -- Settings.in settings do this automatically.

Also, dydx noticed that this line of code had a typo, and was totaly wrong.

10:47 AM Changeset in webkit [146721] by commit-queue@webkit.org

• 6 edits in trunk/Source

[GTK][Regression] webkit_dom_html_table_element_insert_row returns value that doesn't pass WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT macro
​https://bugs.webkit.org/show_bug.cgi?id=111714

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-03-23
Reviewed by Martin Robinson.

Source/WebCore:

Add custom kit implementation for HTMLElements so that the HTML
wrappers are used in that case instead of wrapHTMLElement.

• bindings/gobject/WebKitDOMBinding.cpp:

(WebKit::kit):
(WebKit):

• bindings/gobject/WebKitDOMBinding.h:

(WebCore):
(WebKit):

• bindings/scripts/CodeGeneratorGObject.pm:

(UsesManualKitImplementation):

Source/WebKit/gtk:

Add test that checks webkit_dom_html_table_element_insert_row() to
also preproduce this issue.

• tests/testdomdocument.c:

(test_dom_document_insert_row):
(main):

7:44 AM Changeset in webkit [146720] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

Revert "BUILD FIX (r146667): ResourceRequest constructor in SynchronousLoaderClient.cpp is ambiguous on iOS"

This is platform-agnositic code, so the previous solution won't work.

7:41 AM Changeset in webkit [146719] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

BUILD FIX (r146667): ResourceRequest constructor in SynchronousLoaderClient.cpp is ambiguous on iOS

Fixes the following build failure:

Source/WebCore/platform/network/SynchronousLoaderClient.cpp:52:15: error: conversion from 'int' to 'const WebCore::ResourceRequest' is ambiguous

request = 0;

In file included from Source/WebCore/platform/network/SynchronousLoaderClient.cpp:30:
In file included from Source/WebCore/platform/network/ResourceHandle.h:37:
In file included from Source/WebCore/platform/network/ios/QuickLook.h:13:
Source/WebCore/platform/network/cf/ResourceRequest.h:79:9: note: candidate constructor

ResourceRequest(NSURLRequest *);

Source/WebCore/platform/network/cf/ResourceRequest.h:83:9: note: candidate constructor

ResourceRequest(CFURLRequestRef cfRequest)

1 error generated.

• platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::willSendRequest): If
USE(CFNETWORK) is defined, use static_cast<CFURLRequestRef>(0),
otherwise use static_cast<NSURLRequest *>(0).

7:16 AM Changeset in webkit [146718] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

BUILD FIX (r146687): setDefaultMIMEType() is unused in ResourceHandleCFNet.cpp on iOS

Fixes the following build failure:

Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:98:13: error: unused function 'setDefaultMIMEType' [-Werror,-Wunused-function]
static void setDefaultMIMEType(CFURLResponseRef response)

1 error generated.

• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::setDefaultMIMEType): Add #if !PLATFORM(MAC)/#endif
guard.

Mar 22, 2013:

11:36 PM Changeset in webkit [146717] by pkasting@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] Stupid picky bug syntax...

Unreviewed, test expectations updates.

• platform/chromium/TestExpectations:

10:58 PM Changeset in webkit [146716] by pkasting@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] Mark flaky test.
​https://bugs.webkit.org/show_bug.cgi?id=113129

Unreviewed, test expectations updates.

• platform/chromium/TestExpectations:

10:47 PM Changeset in webkit [146715] by pkasting@chromium.org

• 4 edits
  2 deletes in trunk/LayoutTests

[chromium] Last bits of post-Skia-change fallout, plus other bits.
​https://bugs.webkit.org/show_bug.cgi?id=109507
​https://bugs.webkit.org/show_bug.cgi?id=113067
​https://bugs.webkit.org/show_bug.cgi?id=113128
​https://code.google.com/p/chromium/issues/detail?id=67442

Unreviewed, test expectations updates.

Deleted a few new baselines added during Skia rebaselining that were
existing expected failures from bug 109507 whose failure lines were
left in TestExpectations.

Added a flaky test and a failing test (which for some reason has no new
baselines so I can't rebaseline), and removed a passing test.

Re-added some "Pass" expectations I'd previously removed, as they're
necessary after all.

• platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Removed.
• platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
• platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
• platform/chromium/TestExpectations:
• platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.

9:59 PM Changeset in webkit [146714] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Add a timeout expectation to media/track/track-prefer-captions.html after
r146380 on GTK+. The failure is tracked by ​http://webkit.org/b/113127

• platform/gtk/TestExpectations:

9:54 PM Changeset in webkit [146713] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Add crash test expectations to tests added in r146644.
The failures are tracked by ​http://webkit.org/b/113126

• platform/qt/TestExpectations:

9:51 PM Changeset in webkit [146712] by ddkilzer@apple.com

• 2 edits in trunk/Source/JavaScriptCore

BUILD FIX (r145119): Make JSValue* properties default to (assign)
<rdar://problem/13380794>

Reviewed by Mark Hahnenberg.

Fixes the following build failures:

Source/JavaScriptCore/API/tests/testapi.mm:106:1: error: no 'assign', 'retain', or 'copy' attribute is specified - 'assign' is assumed [-Werror,-Wobjc-property-no-attribute]
@property JSValue *onclick;

^{Source/JavaScriptCore/API/tests/testapi.mm:106:1: error: default property attrib ute 'assign' not appropriate for non-GC object [-Werror,-Wobjc-property-no-attribute]
Source/JavaScriptCore/API/tests/testapi.mm:107:1: error: no 'assign', 'retain', or 'copy' attribute is specified - 'assign' is assumed [-Werror,-Wobjc-property-no-attribute]
@property JSValue *weakOnclick;}

Source/JavaScriptCore/API/tests/testapi.mm:107:1: error: default property attribute 'assign' not appropriate for non-GC object [-Werror,-Wobjc-property-no-attribute]
4 errors generated.

• API/tests/testapi.mm: Default to (assign) for JSValue*

properties.

9:20 PM Changeset in webkit [146711] by rniwa@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

testLeakingPrototypesAcrossContexts added in r146682 doesn't compile on Win and fails on Mac
​https://bugs.webkit.org/show_bug.cgi?id=113125

Reviewed by Mark Hahnenberg

Remove the test added in r146682 as it's now failing on Mac.
This is the test that was causing a compilation failure on Windows.

• API/tests/testapi.c:

(main):

8:35 PM Changeset in webkit [146710] by rniwa@webkit.org

• 4 edits in trunk/Source/WebKit

The second part of the build fix for r146702. This should do it.
I had to see the mangled name for the new signature.

Source/WebKit:

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

• WebKit.vcproj/WebKitExports.def.in:

8:34 PM Changeset in webkit [146709] by noel.gordon@gmail.com

• 2 edits in trunk/LayoutTests

[chromium] Mark canvas-toDataURL-webp.html imageOnlyFailure Pass
​https://bugs.webkit.org/show_bug.cgi?id=93310

Unreviewed test expectations update.

libwebp will be updated to 0.3.0 in chrome, changing the encoder
output, after which these test results will need to be updated.

• platform/chromium/TestExpectations:

8:24 PM Changeset in webkit [146708] by rniwa@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Fix the typo: WIN -> WINDOWS.

• API/tests/testapi.c:

(main):

8:12 PM Changeset in webkit [146707] by rniwa@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

I really can't figure out what's wrong with this one.
Temporarily disable the test added by r146682 on Windows since it doesn't compile.

• API/tests/testapi.c:

(main):

8:09 PM Changeset in webkit [146706] by pkasting@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] Mark more tests as crashing.
​https://bugs.webkit.org/show_bug.cgi?id=113067

Unreviewed, test expectations update.

• platform/chromium/TestExpectations:

7:50 PM Changeset in webkit [146705] by rniwa@webkit.org

• 4 edits in trunk/Source/WebKit

Build fix attempt after r146702.

Source/WebKit:

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

• WebKit.vcproj/WebKitExports.def.in:

7:15 PM Changeset in webkit [146704] by cmuppala@apple.com

• 19 edits in trunk

Add runtime setting for hidden page DOM timer throttling and CSS animation suspension
​https://bugs.webkit.org/show_bug.cgi?id=112308

Reviewed by Gavin Barraclough.

Source/WebCore:

No new tests. Only adding settings to enable/disable existing features
and hence existing tests suffice.

• WebCore.exp.in:
• page/Page.cpp:

(WebCore::Page::setVisibilityState): Check if DOM timer throttling
and CSS animation suspension are enabled before turning them on.
(WebCore::Page::hiddenPageDOMTimerThrottlingStateChanged): Start or stop
DOM timer throttling based on page visibility and the new setting state.
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged): Ditto
for CSS animation suspension.

• page/Page.h:
• page/Settings.cpp:

(WebCore::Settings::Settings): Initialize the flags for enabling hidden
page DOM timer throttling and CSS animation suspension to false.
(WebCore::Settings::setHiddenPageDOMTimerThrottlingEnabled): Update flag
and notify page that the state of the setting has changed.
(WebCore::Settings::setHiddenPageCSSAnimationSuspensionEnabled): Ditto.

• page/Settings.h:

(WebCore::Settings::hiddenPageDOMTimerThrottlingEnabled):
(WebCore::Settings::hiddenPageCSSAnimationSuspensionEnabled):

Source/WebKit/mac:

Add private preference for enabling/disabling hidden page DOM timer
throttling and CSS animation suspension. The preference should be
disabled by default to avoid compatibility issues.

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences hiddenPageDOMTimerThrottlingEnabled]):
(-[WebPreferences setHiddenPageDOMTimerThrottlingEnabled:]):
(-[WebPreferences hiddenPageCSSAnimationSuspensionEnabled]):
(-[WebPreferences setHiddenPageCSSAnimationSuspensionEnabled:]):

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Add private preference for enabling/disabling hidden page DOM timer
throttling and CSS animation suspension. The preference should be
enabled by default only on Mac, where WebKit2 is a private API and
hence compatibility is less of a issue.

• Shared/WebPreferencesStore.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetHiddenPageDOMTimerThrottlingEnabled):
(WKPreferencesGetHiddenPageDOMTimerThrottlingEnabled):
(WKPreferencesSetHiddenPageCSSAnimationSuspensionEnabled):
(WKPreferencesGetHiddenPageCSSAnimationSuspensionEnabled):

• UIProcess/API/C/WKPreferencesPrivate.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Allow
WebKitTestRunner to override hiddenPageDOMTimerThrottlingEnabled.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

LayoutTests:

Hidden page DOM timer throttling is disabled by default in WebKit1 and
in WebKit2 for platforms other than Mac. Override the preference to
enable it during the test.

• fast/dom/timer-throttling-hidden-page.html:

7:01 PM Changeset in webkit [146703] by cmuppala@apple.com

• 2 edits in trunk/Tools

Unreviewed. Move self from contributor to committer list.

• Scripts/webkitpy/common/config/committers.py:

6:35 PM Changeset in webkit [146702] by benjamin@webkit.org

• 7 edits in trunk/Source

Remove 2 bad branches from StringHash::equal() and CaseFoldingHash::equal()
​https://bugs.webkit.org/show_bug.cgi?id=113003

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-03-22
Reviewed by Eric Seidel.

Source/WebCore:

Fix two unfortunate use of StringHash and use the correct StringImpl function.

• html/parser/HTMLParserIdioms.cpp:

(WebCore::threadSafeEqual):

• html/parser/HTMLTreeBuilderSimulator.cpp:

(WebCore::tokenExitsSVG):

Source/WTF:

StringHash::equal() and CaseFoldingHash::equal() were both testing for
the nullity of the two input pointers. The catch is: neither traits handle
null pointers, and any client code would have crashed on hash(), before equal()
is called.
Consequently, the two branches had a pass rate of zero when called from a HashMap code.

The function is also never inlined because it is too big (the code of equal() for characters
is always inlined, causing the function to be quite big).

This patch introduces two new functions in the StringImpl API: equalNonNull() and
equalIgnoringCaseNonNull(). Those functions are similar to their equal() equivalent
but make the assumtion the input is never null.

The functions are used for StringHash to avoid the useless branches.

• wtf/text/StringHash.h:

(WTF::StringHash::equal):
(WTF::CaseFoldingHash::equal):

• wtf/text/StringImpl.cpp:

(WTF::stringImplContentEqual):
(WTF::equal):
(WTF::equalNonNull):
(WTF::equalIgnoringCase):
(WTF::equalIgnoringCaseNonNull):
(WTF::equalIgnoringNullity):

• wtf/text/StringImpl.h:

(WTF::equalIgnoringCase):

6:19 PM Changeset in webkit [146701] by aestes@apple.com

• 2 edits in trunk/Source/WebCore

Set the cache partition property on CFURLRequests
​https://bugs.webkit.org/show_bug.cgi?id=113116

Patch by Jeffrey Pfau
Reviewed by David Kilzer.

• platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):

6:17 PM Changeset in webkit [146700] by schenney@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

Adding bug numbers for two failing tests.

• platform/chromium/TestExpectations:

6:10 PM Changeset in webkit [146699] by schenney@chromium.org

• 81 edits
  6 adds
  5 deletes in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

The rest.

• platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
• platform/chromium-linux/fast/borders/border-radius-with-box-shadow-01-expected.png:
• platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png:
• platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
• platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
• platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png:
• platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
• platform/chromium-linux/fast/box-shadow/inset-expected.png:
• platform/chromium-linux/fast/box-shadow/scaled-box-shadow-expected.png: Added.
• platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png:
• platform/chromium-mac-lion/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
• platform/chromium-mac-lion/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
• platform/chromium-mac-lion/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
• platform/chromium-mac-lion/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
• platform/chromium-mac-lion/editing/selection/select-text-overflow-ellipsis-expected.png:
• platform/chromium-mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
• platform/chromium-mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
• platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
• platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
• platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
• platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
• platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
• platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
• platform/chromium-mac-lion/fast/backgrounds/animated-svg-as-mask-expected.png:
• platform/chromium-mac-lion/fast/borders/border-antialiasing-expected.png:
• platform/chromium-mac-lion/fast/borders/border-radius-split-inline-expected.png:
• platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
• platform/chromium-mac-lion/fast/box-shadow/box-shadow-transformed-expected.png:
• platform/chromium-mac-lion/fast/box-shadow/inset-expected.png:
• platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
• platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
• platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
• platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
• platform/chromium-mac-snowleopard/editing/selection/select-text-overflow-ellipsis-expected.png:
• platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
• platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
• platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
• platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
• platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
• platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
• platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
• platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
• platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png:
• platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
• platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-transformed-expected.png:
• platform/chromium-mac/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
• platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
• platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
• platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
• platform/chromium-mac/editing/selection/select-text-overflow-ellipsis-expected.png:
• platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png:
• platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
• platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
• platform/chromium-mac/fast/borders/border-radius-with-box-shadow-01-expected.png:
• platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png:
• platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
• platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
• platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png:
• platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
• platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
• platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
• platform/chromium-mac/fast/box-shadow/inset-expected.png:
• platform/chromium-mac/fast/box-shadow/scaled-box-shadow-expected.png:
• platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
• platform/chromium-mac/fast/box-shadow/shadow-tiling-artifact-expected.png:
• platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png:
• platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
• platform/chromium-win/fast/borders/border-radius-with-box-shadow-01-expected.png:
• platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png:
• platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
• platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
• platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
• platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
• platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
• platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
• platform/chromium-win/fast/box-shadow/inset-expected.png:
• platform/chromium-win/fast/box-shadow/scaled-box-shadow-expected.png:
• platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
• platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png:
• platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png:
• platform/chromium/TestExpectations:
• platform/efl-wk2/fast/borders/border-radius-split-inline-expected.png: Added.
• platform/efl-wk2/fast/box-shadow/basic-shadows-expected.png: Added.
• platform/efl-wk2/fast/box-shadow/box-shadow-transformed-expected.png: Added.
• platform/efl-wk2/fast/box-shadow/inset-expected.png: Added.
• platform/efl-wk2/fast/box-shadow/scaled-box-shadow-expected.png: Added.
• platform/efl/fast/borders/border-radius-split-inline-expected.png: Removed.
• platform/efl/fast/box-shadow/basic-shadows-expected.png: Removed.
• platform/efl/fast/box-shadow/box-shadow-transformed-expected.png: Removed.
• platform/efl/fast/box-shadow/inset-expected.png: Removed.
• platform/efl/fast/box-shadow/scaled-box-shadow-expected.png: Removed.

6:09 PM Changeset in webkit [146698] by rniwa@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Another build fix (after r146693) for r146682.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
• JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

6:07 PM Changeset in webkit [146697] by jchaffraix@webkit.org

• 4 edits
  4 adds in trunk

[CSS Grid Layout] content-sized row tracks with percentage logical height grid items don't resolve properly
​https://bugs.webkit.org/show_bug.cgi?id=113085

Reviewed by Tony Chang.

Source/WebCore:

The core issue is that because overrideContainingBlockLogicalHeight() is unset in
logicalContentHeightForChild, RenderBox::computePercentageLogicalHeight would try to
resolve percentage logical height against the grid element (wrong containing block
as a grid item's containing block is the grid area).

Tests: fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html

fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::logicalContentHeightForChild):
Set our override logical height to -1, so that we don't try to constrain a grid item's logical height
based on resolving (badly) its percentage.

LayoutTests:

• fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution-expected.txt:

Updated the result to pass.

• fast/css-grid-layout/grid-item-multiple-minmax-content-resolution-expected.txt: Added.
• fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html: Added.
• fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution-expected.txt: Added.
• fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html: Added.

Added more testing to ensure that we properly do the resolution.

6:03 PM Changeset in webkit [146696] by schenney@chromium.org

• 65 edits
  2 adds
  1 delete in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

fast/canvas/...
fast/css/...
fast/forms/...
fast/multicol/...

• platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
• platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
• platform/chromium-linux/fast/css/color-correction-on-box-shadow-expected.png:
• platform/chromium-linux/fast/css/color-correction-on-text-shadow-expected.png:
• platform/chromium-linux/fast/css/font-family-pictograph-expected.png:
• platform/chromium-linux/fast/css/font-family-pictograph-expected.txt:
• platform/chromium-linux/fast/css/shadow-multiple-expected.png:
• platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
• platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
• platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
• platform/chromium-mac-lion/fast/css/color-correction-on-box-shadow-expected.png:
• platform/chromium-mac-lion/fast/css/color-correction-on-text-shadow-expected.png:
• platform/chromium-mac-lion/fast/css/empty-pseudo-class-expected.png:
• platform/chromium-mac-lion/fast/css/first-child-pseudo-class-expected.png:
• platform/chromium-mac-lion/fast/css/first-of-type-pseudo-class-expected.png:
• platform/chromium-mac-lion/fast/css/last-child-pseudo-class-expected.png:
• platform/chromium-mac-lion/fast/css/last-of-type-pseudo-class-expected.png:
• platform/chromium-mac-lion/fast/css/only-child-pseudo-class-expected.png:
• platform/chromium-mac-lion/fast/css/only-of-type-pseudo-class-expected.png:
• platform/chromium-mac-lion/fast/css/shadow-multiple-expected.png:
• platform/chromium-mac-lion/fast/dynamic/text-combine-expected.png:
• platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
• platform/chromium-mac-lion/fast/line-grid/line-grid-contains-value-expected.png:
• platform/chromium-mac-lion/fast/multicol/nested-columns-expected.png:
• platform/chromium-mac-lion/fast/multicol/shadow-breaking-expected.png:
• platform/chromium-mac-snowleopard/fast/css/color-correction-on-box-shadow-expected.png:
• platform/chromium-mac-snowleopard/fast/css/color-correction-on-text-shadow-expected.png:
• platform/chromium-mac-snowleopard/fast/css/empty-pseudo-class-expected.png:
• platform/chromium-mac-snowleopard/fast/css/first-child-pseudo-class-expected.png:
• platform/chromium-mac-snowleopard/fast/css/first-of-type-pseudo-class-expected.png:
• platform/chromium-mac-snowleopard/fast/css/last-child-pseudo-class-expected.png:
• platform/chromium-mac-snowleopard/fast/css/last-of-type-pseudo-class-expected.png:
• platform/chromium-mac-snowleopard/fast/css/only-child-pseudo-class-expected.png:
• platform/chromium-mac-snowleopard/fast/css/only-of-type-pseudo-class-expected.png:
• platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
• platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
• platform/chromium-mac-snowleopard/fast/line-grid/line-grid-contains-value-expected.png:
• platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png:
• platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png:
• platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
• platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png:
• platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png:
• platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.png:
• platform/chromium-mac/fast/css/empty-pseudo-class-expected.png:
• platform/chromium-mac/fast/css/first-child-pseudo-class-expected.png:
• platform/chromium-mac/fast/css/first-of-type-pseudo-class-expected.png:
• platform/chromium-mac/fast/css/last-child-pseudo-class-expected.png:
• platform/chromium-mac/fast/css/last-of-type-pseudo-class-expected.png:
• platform/chromium-mac/fast/css/only-child-pseudo-class-expected.png:
• platform/chromium-mac/fast/css/only-of-type-pseudo-class-expected.png:
• platform/chromium-mac/fast/css/shadow-multiple-expected.png:
• platform/chromium-mac/fast/dynamic/text-combine-expected.png:
• platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
• platform/chromium-mac/fast/line-grid/line-grid-contains-value-expected.png:
• platform/chromium-mac/fast/multicol/nested-columns-expected.png:
• platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
• platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
• platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
• platform/chromium-win/fast/css/color-correction-on-box-shadow-expected.png:
• platform/chromium-win/fast/css/color-correction-on-text-shadow-expected.png:
• platform/chromium-win/fast/css/shadow-multiple-expected.png:
• platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
• platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
• platform/chromium/TestExpectations:
• platform/efl-wk2/fast/multicol: Added.
• platform/efl-wk2/fast/multicol/shadow-breaking-expected.png: Added.
• platform/efl/fast/multicol/shadow-breaking-expected.png: Removed.

5:52 PM Changeset in webkit [146695] by schenney@chromium.org

• 44 edits
  9 adds
  17 deletes in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

fast/repaint/...
fast/ruby/...

• fast/repaint/moving-shadow-on-container-expected.png: Added.
• fast/repaint/search-field-cancel-expected.txt: Added.
• platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.png: Removed.
• platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
• platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
• platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
• platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
• platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
• platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
• platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
• platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
• platform/chromium-mac-lion/fast/repaint/box-shadow-h-expected.png:
• platform/chromium-mac-lion/fast/repaint/box-shadow-v-expected.png:
• platform/chromium-mac-lion/fast/repaint/moving-shadow-on-container-expected.png:
• platform/chromium-mac-lion/fast/repaint/moving-shadow-on-path-expected.png:
• platform/chromium-mac-lion/fast/repaint/scale-page-shrink-expected.png: Added.
• platform/chromium-mac-lion/fast/repaint/search-field-cancel-expected.png: Added.
• platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png:
• platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
• platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png:
• platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
• platform/chromium-mac-snowleopard/fast/repaint/box-shadow-h-expected.png:
• platform/chromium-mac-snowleopard/fast/repaint/box-shadow-v-expected.png:
• platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.png:
• platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png:
• platform/chromium-mac-snowleopard/fast/repaint/scale-page-shrink-expected.png: Removed.
• platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.png:
• platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Removed.
• platform/chromium-mac-snowleopard/fast/ruby/base-shorter-than-text-expected.png: Removed.
• platform/chromium-mac-snowleopard/fast/ruby/base-shorter-than-text-expected.txt: Removed.
• platform/chromium-mac-snowleopard/fast/ruby/position-after-expected.png:
• platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
• platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
• platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
• platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
• platform/chromium-mac/fast/repaint/scale-page-shrink-expected.png: Added.
• platform/chromium-mac/fast/repaint/search-field-cancel-expected.png: Added.
• platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
• platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
• platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
• platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
• platform/chromium-mac/fast/repaint/transform-replaced-shadows-expected.png:
• platform/chromium-mac/fast/ruby/position-after-expected.png:
• platform/chromium-win-xp/fast/repaint/box-shadow-h-expected.png: Removed.
• platform/chromium-win-xp/fast/repaint/box-shadow-v-expected.png: Removed.
• platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.png: Removed.
• platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.txt: Removed.
• platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
• platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
• platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
• platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
• platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
• platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
• platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
• platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
• platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
• platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png:
• platform/chromium/TestExpectations:
• platform/chromium/fast/repaint/search-field-cancel-expected.png: Removed.
• platform/chromium/fast/repaint/search-field-cancel-expected.txt: Removed.
• platform/efl-wk2/fast/repaint/moving-shadow-on-container-expected.png: Added.
• platform/efl-wk2/fast/repaint/moving-shadow-on-path-expected.png: Added.
• platform/efl-wk2/fast/repaint/transform-replaced-shadows-expected.png: Added.
• platform/efl/fast/repaint/moving-shadow-on-container-expected.png: Removed.
• platform/efl/fast/repaint/moving-shadow-on-path-expected.png: Removed.
• platform/efl/fast/repaint/transform-replaced-shadows-expected.png: Removed.
• platform/gtk/fast/repaint/moving-shadow-on-container-expected.png: Removed.
• platform/mac/fast/repaint/moving-shadow-on-container-expected.png: Removed.
• platform/mac/fast/repaint/search-field-cancel-expected.txt: Removed.

5:45 PM Changeset in webkit [146694] by zmo@google.com

• 7 edits in trunk/Source/WebCore

Check WEBGL_draw_buffers requirements before exposing the extension
​https://bugs.webkit.org/show_bug.cgi?id=112359

Reviewed by Kenneth Russell.

• html/canvas/EXTDrawBuffers.cpp:

(WebCore::EXTDrawBuffers::supported): call satisfies*().
(WebCore::EXTDrawBuffers::drawBuffersEXT):
(WebCore):
(WebCore::EXTDrawBuffers::satisfiesWebGLRequirements): check WebGL requirements.

• html/canvas/EXTDrawBuffers.h:

(EXTDrawBuffers):

• html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::getDrawBuffer):
(WebCore):

• html/canvas/WebGLFramebuffer.h:

(WebGLFramebuffer):

• html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
(WebCore::WebGLRenderingContext::getMaxDrawBuffers):
(WebCore::WebGLRenderingContext::getMaxColorAttachments):
(WebCore::WebGLRenderingContext::setBackDrawBuffer):
(WebCore::WebGLRenderingContext::restoreCurrentFramebuffer):
(WebCore::WebGLRenderingContext::restoreCurrentTexture2D):
(WebCore::WebGLRenderingContext::supportsDrawBuffers): a cached version of EXTDrawBuffers::supports()

• html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

5:44 PM Changeset in webkit [146693] by roger_fong@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Unreviewed. AppleWin build fix.

• JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
• JavaScriptCore.vcxproj/copy-files.cmd:

5:37 PM Changeset in webkit [146692] by schenney@chromium.org

• 41 edits
  6 adds
  3 deletes in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

fast/text/...

• platform/chromium-linux/fast/text/emphasis-avoid-ruby-expected.png: Added.
• platform/chromium-linux/fast/text/shadow-translucent-fill-expected.png:
• platform/chromium-linux/fast/text/stroking-decorations-expected.png:
• platform/chromium-linux/fast/text/stroking-expected.png:
• platform/chromium-linux/fast/transforms/shadows-expected.png:
• platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.png:
• platform/chromium-mac-lion/fast/text/international/bold-bengali-expected.png:
• platform/chromium-mac-lion/fast/text/international/text-spliced-font-expected.png:
• platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.png:
• platform/chromium-mac-lion/fast/text/justify-ideograph-vertical-expected.png:
• platform/chromium-mac-lion/fast/text/orientation-sideways-expected.png:
• platform/chromium-mac-lion/fast/text/shadow-translucent-fill-expected.png:
• platform/chromium-mac-lion/fast/text/stroking-decorations-expected.png:
• platform/chromium-mac-lion/fast/text/stroking-expected.png:
• platform/chromium-mac-lion/fast/text/whitespace/024-expected.png:
• platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
• platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-001-expected.png:
• platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-002-expected.png:
• platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-003-expected.png:
• platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.png:
• platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png:
• platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
• platform/chromium-mac-snowleopard/fast/text/justify-ideograph-vertical-expected.png:
• platform/chromium-mac-snowleopard/fast/text/shadow-translucent-fill-expected.png:
• platform/chromium-mac-snowleopard/fast/text/whitespace/024-expected.png:
• platform/chromium-mac/fast/text/decorations-with-text-combine-expected.png:
• platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
• platform/chromium-mac/fast/text/shadow-translucent-fill-expected.png:
• platform/chromium-mac/fast/text/stroking-decorations-expected.png:
• platform/chromium-mac/fast/text/stroking-expected.png:
• platform/chromium-mac/fast/text/whitespace/024-expected.png:
• platform/chromium-mac/fast/transforms/shadows-expected.png:
• platform/chromium-win-xp/fast/text/stroking-decorations-expected.png:
• platform/chromium-win-xp/fast/text/stroking-expected.png:
• platform/chromium-win/fast/text/international/bold-bengali-expected.png:
• platform/chromium-win/fast/text/international/bold-bengali-expected.txt:
• platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
• platform/chromium-win/fast/text/stroking-decorations-expected.png:
• platform/chromium-win/fast/text/stroking-expected.png:
• platform/chromium-win/fast/transforms/shadows-expected.png:
• platform/chromium/TestExpectations:
• platform/chromium/fast/text/international/bold-bengali-expected.png: Removed.
• platform/efl-wk2/fast/text/shadow-translucent-fill-expected.png: Added.
• platform/efl/fast/text/shadow-translucent-fill-expected.png: Removed.
• platform/qt-unknown/fast: Added.
• platform/qt-unknown/fast/text: Added.
• platform/qt-unknown/fast/text/international: Added.
• platform/qt-unknown/fast/text/international/text-spliced-font-expected.png: Added.
• platform/qt/fast/text/international/text-spliced-font-expected.png: Removed.

5:31 PM Changeset in webkit [146691] by rniwa@webkit.org

• 6 edits in trunk/Tools

EWS should use a human readable port name when uploading layout test archives
​https://bugs.webkit.org/show_bug.cgi?id=113099

Reviewed by Dirk Pranke.

Use new port's object's name() method to report human readable port names.
This will also help us resolving the bug to apply layout test results posted by EWS.

• Scripts/webkitpy/tool/bot/botinfo.py:

(BotInfo.init): Take port's name.
(BotInfo.summary_text):

• Scripts/webkitpy/tool/bot/botinfo_unittest.py:

(BotInfoTest.test_summary_text):

• Scripts/webkitpy/tool/bot/flakytestreporter.py:

(FlakyTestReporter.init): Preserve the old behavior since we don't have a real port object here.

• Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue.init): Initialize self._port.
(PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
and use that for the attachment filename and the comment posted.

• Scripts/webkitpy/tool/commands/queues_unittest.py:

(PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
"mac-snowleopard" as expected for TestPort.

5:26 PM Changeset in webkit [146690] by schenney@chromium.org

• 4 edits in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

One I missed.

• platform/chromium-mac-lion/svg/custom/preserve-aspect-ratio-syntax-expected.png:
• platform/chromium-mac-snowleopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
• platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:

5:24 PM Changeset in webkit [146689] by roger_fong@apple.com

• 2 edits in trunk/Tools

Unreviewed. Fix AppleWin port following ​https://bugs.webkit.org/show_bug.cgi?id=113100.
Patch by Alexey Proskuryakov.

• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::platformLoadResourceSynchronously):

5:21 PM Changeset in webkit [146688] by mhahnenberg@apple.com

• 2 edits in trunk/Source/JavaScriptCore

-[TinyDOMNode dealloc] should call [super dealloc] when ARC is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=113054

Reviewed by Geoffrey Garen.

• API/tests/testapi.mm:

(-[TinyDOMNode dealloc]):

5:14 PM Changeset in webkit [146687] by roger_fong@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed. Fix AppleWin port following ​https://bugs.webkit.org/show_bug.cgi?id=113100.
Patch by Alexey Proskuryakov.

• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::platformLoadResourceSynchronously):

5:10 PM Changeset in webkit [146686] by kov@webkit.org

• 2 edits in trunk/Source/WebKit/gtk

Trivial fixes to the gyp-build autogen.sh script.

Reviewed by Martin Robinson (mrobinson).

• gyp/autogen.sh: add /bin/sh -e as hashbang, so stricter shells will be happy to

run the script; deal with automake exiting with an error code because there is no
Makefile.am for it to work on.

5:00 PM Changeset in webkit [146685] by timothy_horton@apple.com

• 1 edit
  2 adds in trunk/LayoutTests

Plugin Snapshotting: Auto-start dominant plugins
​​https://bugs.webkit.org/show_bug.cgi?id=113111
<rdar://problem/13475726>

Reviewed by Dean Jackson.

Add a test for ​http://trac.webkit.org/changeset/146679.

• platform/mac-wk2/plugins/snapshotting/autoplay-dominant-expected.txt: Added.
• plugins/snapshotting/autoplay-dominant.html: Added.

4:58 PM Changeset in webkit [146684] by tony@chromium.org

• 3 edits
  2 adds in trunk

REGRESSION (r146272): layout issues for flex boxes that have -webkit-flex-wrap: wrap
​https://bugs.webkit.org/show_bug.cgi?id=113071

Reviewed by Ojan Vafai.

Source/WebCore:

The refactor in r139535 introduced this bug, where a variable name wasn't updated properly.
In combination with r146272, this bug became more visible when nesting multiline flexboxen.

Test: css3/flexbox/multiline-min-preferred-width.html

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths): We want the width of the widest
flexitem, the value in m_minPreferredWidth isn't relevant. Also update the comment for max
preferred width.

LayoutTests:

• css3/flexbox/multiline-min-preferred-width-expected.txt: Added.
• css3/flexbox/multiline-min-preferred-width.html: Added.

4:56 PM Changeset in webkit [146683] by mvujovic@adobe.com

• 3 edits
  4 adds in trunk

[CSS Shaders] Clamp css_MixColor before the blending and compositing steps
​https://bugs.webkit.org/show_bug.cgi?id=113088

Reviewed by Dean Jackson.

Source/WebCore:

The blending and compositing operations from the spec [1] expect that they are operating on
valid color inputs, in the range [0.0, 1.0]. Thus, we should clamp the css_MixColor input to
this range to avoid implementation-dependent behavior for invalid color inputs.

[1]: ​https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blending

Tests: css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html

css3/filters/custom/custom-filter-clamp-css-mix-color.html

• platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):

Clamp css_MixColor as clampedMixColor before using it in the blending and compositing
steps.

LayoutTests:

• css3/filters/custom/custom-filter-clamp-css-mix-color-expected.html: Added.
• css3/filters/custom/custom-filter-clamp-css-mix-color-negative-expected.html: Added.
• css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html: Added.
• css3/filters/custom/custom-filter-clamp-css-mix-color.html: Added.

4:49 PM Changeset in webkit [146682] by mhahnenberg@apple.com

• 10 edits in trunk/Source/JavaScriptCore

opaqueJSClassData should be cached on JSGlobalObject, not the JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=113086

Reviewed by Geoffrey Garen.

opaqueJSClassData stores cached prototypes for JSClassRefs in the C API. It doesn't make sense to
share these prototypes within a JSGlobalData across JSGlobalObjects, and in fact doing so will cause
a leak of the original JSGlobalObject that these prototypes were created in. Therefore we should move
this cache to JSGlobalObject where it belongs and where it won't cause memory leaks.

• API/JSBase.cpp: Needed to add an extern "C" so that testapi.c can use the super secret GC function.
• API/JSClassRef.cpp: We now grab the cached context data from the global object rather than the global data.

(OpaqueJSClass::contextData):

• API/JSClassRef.h: Remove this header because it's unnecessary and causes circular dependencies.
• API/tests/testapi.c: Added a new test that makes sure that using the same JSClassRef in two different contexts

doesn't cause leaks of the original global object.
(leakFinalize):
(nestedAllocateObject): This is a hack to bypass the conservative scan of the GC, which was unnecessarily marking
objects and keeping them alive, ruining the test result.
(testLeakingPrototypesAcrossContexts):
(main):

• API/tests/testapi.mm: extern "C" this so we can continue using it here.
• runtime/JSGlobalData.cpp: Remove JSClassRef related stuff.

(JSC::JSGlobalData::~JSGlobalData):

• runtime/JSGlobalData.h:

(JSGlobalData):

• runtime/JSGlobalObject.h: Add the stuff that JSGlobalData had. We add it to JSGlobalObjectRareData so that

clients who don't use the C API don't have to pay the memory cost of this extra HashMap.
(JSGlobalObject):
(JSGlobalObjectRareData):
(JSC::JSGlobalObject::opaqueJSClassData):

4:48 PM Changeset in webkit [146681] by Martin Robinson

• 2 edits in trunk/Source/WebCore

[GTK] Add WebCoreDOM to the gyp build
​https://bugs.webkit.org/show_bug.cgi?id=112737

Reviewed by Nico Weber.

• WebCore.gyp/WebCoreGTK.gyp: Add WebCoreDOM to the gyp build.

4:47 PM Changeset in webkit [146680] by Martin Robinson

• 3 edits in trunk/Source

[GTK] Add WebCoreHTML to the gyp build
​https://bugs.webkit.org/show_bug.cgi?id=112727

Reviewed by Nico Weber.

• WebCore.gyp/WebCoreGTK.gyp: Add support for building all files under

the HTML directory. This includes splitting off common WebCore dependencies
into an aggregate target and adding a top-level WebCore target.

4:43 PM Changeset in webkit [146679] by timothy_horton@apple.com

• 8 edits in trunk/Source

Plugin Snapshotting: Auto-start dominant plugins
​https://bugs.webkit.org/show_bug.cgi?id=113111
<rdar://problem/13475726>

Reviewed by Dean Jackson.

• html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):
Acknowledge the new "Restarting" DisplayState.

• html/HTMLPlugInElement.h:

Rename PlayingWithPendingMouseClick to RestartingWithPendingMouseClick for accuracy.
Add "Restarting" DisplayState, so we can be aware that the plugin is intentionally restarting and not re-snapshot it.

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::classNameForShadowRoot): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Restart the plugin when it becomes primary.
(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn):
Move the plugin to Restarting unless it's already marked as PendingMouseClick.
(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired): Match the PlayingWithPendingMouseClick rename.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Don't snapshot if we're restarting.

• html/HTMLPlugInImageElement.h: Remove m_isPrimarySnapshottedPlugIn.
• rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paint): Acknowledge the new "Restarting" DisplayState.
(WebCore::RenderSnapshottedPlugIn::getCursor): Acknowledge the new "Restarting" DisplayState.
(WebCore::RenderSnapshottedPlugIn::handleEvent): Match the PlayingWithPendingMouseClick rename.

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::didInitializePlugin):
(WebKit::PluginView::paint):
(WebKit::PluginView::invalidateRect):
(WebKit::PluginView::isAcceleratedCompositingEnabled):
Acknowledge the new "Restarting" DisplayState.

4:43 PM Changeset in webkit [146678] by pkasting@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] Mark test as expected to timeout.
​https://bugs.webkit.org/show_bug.cgi?id=113114

Unreviewed, test expectations update.

• platform/chromium/TestExpectations:

4:40 PM Changeset in webkit [146677] by Martin Robinson

• 8 edits
  2 copies in trunk/Source

[GTK] Add support for building the WebCore bindings to the gyp build
​https://bugs.webkit.org/show_bug.cgi?id=112638

Reviewed by Nico Weber.

Source/JavaScriptCore:

• JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Export all include directories to direct

dependents and fix the indentation of the libjavascriptcore target.

Source/WebCore:

Add targets, actions, and rules for building the WebCore bindings. This is
the first part of the WebCoreGTK build.

• WebCore.gyp/ConvertFileToHeaderWithCharacterArray.gypi: Added.
• WebCore.gyp/MakeNames.gypi: Added.
• WebCore.gyp/WebCoreGTK.gyp: Added WebCore bindings build. This has been adapted

from the Chromium build.

• WebCore.gypi: Updated list of derived sources files and added a parameter

for adjusting the location of the built files. We don't want to force the
Mac build to change, but we'd still like to reuse the scripts that the
Chromium build uses.

Source/WebKit/gtk:

• gyp/Configuration.gypi.in: Added options for enabling SVG and setting the location of

the WebCore derived sources.

• gyp/run-gyp: Include the gyp scripts directory on the Python path and make the WebCoreGTK

gyp file the default for the build.

4:29 PM Changeset in webkit [146676] by Martin Robinson

• 2 edits in trunk/Source/WebKit/gtk

[GTK] [gyp] Expose a few more compiler defines for the gyp build
​https://bugs.webkit.org/show_bug.cgi?id=113109

Reviewed by Gustavo Noronha Silva.

• gyp/Configuration.gypi.in: Expose the version number string and data

directory to the gyp build as command-line arguments.

4:28 PM Changeset in webkit [146675] by Martin Robinson

• 2 edits in trunk/Source/WebKit/gtk

[GTK] [gyp] Feature defines are not space separated
​https://bugs.webkit.org/show_bug.cgi?id=113108

Reviewed by Gustavo Noronha Silva.

• gyp/configure.ac: Properly export feature defines for gyp during

configure phase.

4:23 PM Changeset in webkit [146674] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Build fix in InputHandler
​https://bugs.webkit.org/show_bug.cgi?id=113092

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-03-22
Reviewed by Rob Buis.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementUnfocused):

4:12 PM Changeset in webkit [146673] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit2

After switching to another space and back, video races to catch up with audio
​https://bugs.webkit.org/show_bug.cgi?id=113006

Reviewed by Anders Carlsson.

Add an observer for the NSWorkspaceActiveSpaceDidChangeNotification notification, and trigger
a visibility update when that notification is observed.

• UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]): Unregister the observer.
(-[WKView _activeSpaceDidChange:]): Notify the view that its visibility may have changed.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): Add the observer.

4:11 PM Changeset in webkit [146672] by commit-queue@webkit.org

• 11 edits in trunk/Source

Add client callbacks to notify of changes of associated from controls
​https://bugs.webkit.org/show_bug.cgi?id=110375

Patch by Dane Wallinga <​dgwallinga@chromium.org> on 2013-03-22
Reviewed by Ryosuke Niwa.

Source/WebCore:

Hook FormAssociatedElement, HTMLFormElement to notify EditorClient of form changes after a page has loaded.
Will be used to add autofill support for ajax-y webpages. e.g if while filling out a form, new fields
are dynamically created, autofill can know to re-query the autofill server and keep going.
​https://bugs.webkit.org/show_bug.cgi?id=110375

• dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::didAssociateFormControl):
(WebCore):
(WebCore::Document::didAssociateFormControlsTimerFired):

• dom/Document.h:

(Document):
added method didAssociateFormControl, which batches form changes
and calls out to ChromeClient on a timer.

• html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::resetFormOwner):
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore):

• html/FormAssociatedElement.h:

(FormAssociatedElement):
add calls to Document::didAssociateFormControl when form changes

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::insertedInto):
(WebCore):

• html/HTMLFormElement.h:

add call to Document::didAssociateFormControl

• loader/EmptyClients.h:

(EmptyChromeClient):
(WebCore::EmptyChromeClient::didAssociateFormControls):
(WebCore::EmptyChromeClient::shouldNotifyOnFormChanges):

• page/ChromeClient.h:

(ChromeClient):
add new method didAssociateFormControls

Source/WebKit/chromium:

Implement form association methods of ChromeClient
to inform autofill of form changes after a page has loaded

• public/WebAutofillClient.h:

(WebAutofillClient):
(WebKit::WebAutofillClient::didAssociateInput):
(WebKit::WebAutofillClient::didAddForm):
(WebKit::WebAutofillClient::didAssociateFormControls):

• src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::didAssociateFormControls):
(WebKit):
(WebKit::ChromeClientImpl::shouldNotifyOnFormChanges):

• src/ChromeClientImpl.h:

(ChromeClientImpl):

4:04 PM Changeset in webkit [146671] by zmo@google.com

• 3 edits in branches/chromium/1410/Source/WebCore

Merge 145856 "Check to ensure MultisampleRenderbuffer creation s..."

Check to ensure MultisampleRenderbuffer creation succeeds
​https://bugs.webkit.org/show_bug.cgi?id=111780

Patch by Brandon Jones <​bajones@google.com> on 2013-03-14
Reviewed by Kenneth Russell.

On OSX systems using AMD graphics chips the allocation of large
Multisample Renderbuffers in Chromium would fail without any indication
of failure. Attempting to draw to the buffer resulted in garbage being
rendered onscreen. This could be reproduced by opening a full-page
WebGL app and pressing (Command + "-") several times. This patch adds an
additional check during DrawingBuffer resize to verify that the resized
buffer is valid.

• platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):
(WebCore::DrawingBuffer::checkBufferIntegrity):
(WebCore::DrawingBuffer::reset):

• platform/graphics/gpu/DrawingBuffer.h:

(DrawingBuffer):

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/12843018

4:02 PM Changeset in webkit [146670] by schenney@chromium.org

• 139 edits
  14 adds
  11 deletes in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

The next round.

Too many files to list, plus ...

• platform/chromium/TestExpectations:

4:00 PM Changeset in webkit [146669] by fpizlo@apple.com

• 11 edits in trunk/Source/JavaScriptCore

Fix some minor issues in the DFG's profiling of heap accesses
​https://bugs.webkit.org/show_bug.cgi?id=113010

Reviewed by Goeffrey Garen.

1) If a CodeBlock gets jettisoned by GC, we should count the exit sites.

2) If a CodeBlock clears a structure stub during GC, it should record this, and
the DFG should prefer to not inline that access (i.e. treat it as if it had an
exit site).

3) If a PutById was seen by the baseline JIT, and the JIT attempted to cache it,
but it chose not to, then assume that it will take slow path.

4) If we frequently exited because of a structure check on a weak constant,
don't try to inline that access in the future.

5) Treat all exits that were counted as being frequent.

81% speed-up on Octane/gbemu. Small speed-ups elsewhere, and no regressions.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):
(JSC):
(JSC::CodeBlock::resetStubDuringGCInternal):
(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::jettison):
(JSC::ProgramCodeBlock::jettisonImpl):
(JSC::EvalCodeBlock::jettisonImpl):
(JSC::FunctionCodeBlock::jettisonImpl):
(JSC::CodeBlock::tallyFrequentExitSites):

• bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::tallyFrequentExitSites):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):

• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

• bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::StructureStubInfo):
(StructureStubInfo):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

• dfg/DFGOSRExit.h:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):
(OSRExit):

• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

• runtime/Options.h:

(JSC):

3:49 PM Changeset in webkit [146668] by benjamin@webkit.org

• 2 edits in trunk/Source/WTF

Name correctly the argument of StringImpl::setIsAtomic()
​https://bugs.webkit.org/show_bug.cgi?id=113000

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-03-22
Reviewed by Geoffrey Garen.

• wtf/text/StringImpl.h:

(WTF::StringImpl::setIsAtomic):
The argument was probably an unfortunate copy-paste from setIsIdentifier().
Fix the name.

3:44 PM Changeset in webkit [146667] by ap@apple.com

• 7 edits
  5 adds in trunk/Source/WebCore

Split ResourceHandleMac into multiple files
​https://bugs.webkit.org/show_bug.cgi?id=113100

Reviewed by Geoff Garen.

It's grown too big to navigate, and I'm going to make WebCoreResourceHandleAsDelegate
substantially more complicated yet.

1. Mechanically moved WebCoreResourceHandleAsDelegate into separate files.
2. Refactored WebCoreSynchronousLoaderClient to be cross-platform, and moved it into separate files.

• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• platform/network/SynchronousLoaderClient.cpp: Added.
• platform/network/SynchronousLoaderClient.h: Added.
• platform/network/cf/ResourceHandleCFNet.cpp:
• platform/network/mac/SynchronousLoaderClient.mm: Added.
• platform/network/mac/WebCoreResourceHandleAsDelegate.h: Added.
• platform/network/mac/WebCoreResourceHandleAsDelegate.mm: Added.

3:38 PM Changeset in webkit [146666] by schenney@chromium.org

• 491 edits
  17 adds
  13 deletes in trunk/LayoutTests

[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

SVG and Compositing tests

Too many files to list, plus ...

• platform/chromium/TestExpectations:

3:24 PM Changeset in webkit [146665] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Fix the expected image result as r78910 committed a bad expected result.
See ​http://trac.webkit.org/changeset/78910/trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance-expected.png

• platform/mac/editing/deleting/deletionUI-single-instance-expected.png:

3:19 PM Changeset in webkit [146664] by ggaren@apple.com

• 10 edits in trunk/Source

Added a setting for whether JavaScript markup is enabled
​https://bugs.webkit.org/show_bug.cgi?id=112999

Reviewed by Maciej Stachowiak.

This setting is useful for clients that want protection from script
injection attacks.

../WebCore:

• page/Settings.h:

(Settings): Clarified which clients should call canExecuteScripts().

• page/Settings.in: Added the new setting.

../WebKit2:

• Shared/WebPreferencesStore.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesGetJavaScriptMarkupEnabled):
(WKPreferencesSetJavaScriptMarkupEnabled):
(WKPreferencesGetJavaScriptEnabled):

• UIProcess/API/C/WKPreferences.h:
• UIProcess/API/mac/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup allowsJavaScriptMarkup]):
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]):

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Plumbed through to API.

3:19 PM Changeset in webkit [146663] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Add a failing test expectation to media/track/track-prefer-captions.html on Windows after r146647.
The failure is tracked by the bug 113106.

• platform/win/TestExpectations:

3:06 PM Changeset in webkit [146662] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

[Win] editing/pasteboard/can-read-in-copy-and-cut-events.html fails
​https://bugs.webkit.org/show_bug.cgi?id=113102

Skip a test added by r146644 since writing into clipboard is not supported on Windows port.

• platform/win/TestExpectations:

3:04 PM Changeset in webkit [146661] by roger_fong@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix.

• bindings/scripts/preprocessor.pm:

(applyPreprocessor):

3:03 PM Changeset in webkit [146660] by pdr@google.com

• 2 edits
  8 adds in trunk/LayoutTests

Update svg/custom/marker-orient-auto expectations

Unreviewed update of test expectations.

• platform/chromium-mac-lion/svg/custom/marker-orient-auto-expected.png: Added.
• platform/chromium-mac-lion/svg/custom/marker-orient-auto-expected.txt: Added.
• platform/chromium-mac-snowleopard/svg/custom/marker-orient-auto-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/custom/marker-orient-auto-expected.txt: Added.
• platform/chromium-mac/svg/custom/marker-orient-auto-expected.png: Added.
• platform/chromium-mac/svg/custom/marker-orient-auto-expected.txt: Added.
• platform/chromium-win/svg/custom/marker-orient-auto-expected.png: Added.
• platform/chromium-win/svg/custom/marker-orient-auto-expected.txt: Added.
• platform/chromium/TestExpectations:

2:14 PM Changeset in webkit [146659] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Add failing test expectations for two more position: sticky tests to make Mac EWS happy.

• platform/mac/TestExpectations:

2:12 PM Changeset in webkit [146658] by eric.carlson@apple.com

• 3 edits in branches/safari-536.30-branch/LayoutTests

Update results where white-space changed because of the change from testRunner" to "layoutTestController.

• fast/block/float/float-not-removed-from-pre-block-expected.txt:
• fast/css/image-set-value-not-removed-crash-expected.txt:

2:05 PM Changeset in webkit [146657] by rniwa@webkit.org

• 9 edits in trunk

NRWT: Enable pixel tests when retrying tests
​https://bugs.webkit.org/show_bug.cgi?id=112898

Reviewed by Dirk Pranke.

Tools:

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
if we've forced pixel tests in the retry.
(Manager._run_tests):
(Manager._clean_up_run): Fixed the capitalizations.
(Manager._force_pixel_tests_if_needed): Added.

• Scripts/webkitpy/layout_tests/models/test_run_results.py:

(_interpret_test_failures): Now that this function maybe called multiple times, only set
'image_diff_percent' if it doesn't already exist.

(summarize_results): When the first attempt resulted in a text failure and the second attempt
resulted in image and text failures and we've forced to run pixel tests in the retry run,
treat this as a regular regression instead of a flakiness.

Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
run had image diffs.

• Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:

(summarized_results):

• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
Also removed some dead code.

(RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
is set and pixel_tests_enabled is set to false.
(EndToEndTest.test_reftest_with_two_notrefs):

LayoutTests:

Link to images and image diff in retries when they're only available in retries.

• fast/harness/resources/results-test.js: Added a test case.
• fast/harness/results-expected.txt:
• fast/harness/results.html:

(imageResultsCell): Extracted from tableRow.
(tableRow): Split the actual result into two tokens (first attempt and retry),
and then check if the image failure was detected in the first attempt. If not,
add hyperlinks to the actual results in the retry run.

2:00 PM Changeset in webkit [146656] by pdr@google.com

• 2 edits in trunk/LayoutTests

Update svg/custom/marker-orient-auto-expected test expectation.

Unreviewed update of test expectations.

• platform/chromium/TestExpectations:

1:59 PM Changeset in webkit [146655] by schenney@chromium.org

• 4 edits in trunk/LayoutTests

[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

One more not-expected failure, fixed.

• platform/chromium-mac-lion/fast/multicol/vertical-lr/nested-columns-expected.png:
• platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png:
• platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png:

1:57 PM Changeset in webkit [146654] by schenney@chromium.org

• 3 edits
  4 adds in trunk/LayoutTests

[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

Some more currently failing (not expected) tests.

• platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.png:
• platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
• platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-expected.png:
• platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
• platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
• platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.

1:51 PM Changeset in webkit [146653] by fpizlo@apple.com

• 4 edits
  3 adds in trunk

DFG folding of PutById to SimpleReplace should consider the specialized function case
​https://bugs.webkit.org/show_bug.cgi?id=113093

Reviewed by Geoffrey Garen and Mark Hahnenberg.

Source/JavaScriptCore:

• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

LayoutTests:

• fast/js/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function-expected.txt: Added.
• fast/js/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function.html: Added.
• fast/js/jsc-test-list:
• fast/js/script-tests/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function.js: Added.

(foo):
(baz):
(fuzz):

1:41 PM Changeset in webkit [146652] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Add failing test expectations to the test added by r146644 on Mac.
The failure is tracked by ​http://webkit.org/b/113094.

• platform/mac/TestExpectations:

1:36 PM Changeset in webkit [146651] by roger_fong@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed. Force kill gcc-3.exe during bindings generation tests to avoid process hangs.

This problem is occuring on the WinEWS bots where there are somehow multiple gcc-3 processes existing at the same time.
This is a speculative fix. There should only be 1 gcc-3.exe process running at a time ever.

• bindings/scripts/preprocessor.pm:

(applyPreprocessor):

1:34 PM Changeset in webkit [146650] by timothy_horton@apple.com

• 5 edits in trunk/Tools

Make it possible to run layout tests on Retina MBP
​https://bugs.webkit.org/show_bug.cgi?id=93673

Reviewed by Ryosuke Niwa.

Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
windows on 2x machines still run at 1x.

• DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):
Reset the window resolution to 1x on creation.

• DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
• DumpRenderTree/mac/DumpRenderTreeWindow.mm:

(-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.

• WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
(WTR::PlatformWebView::PlatformWebView):
Add NSWindow details, reset the window resolution to 1x on creation.

1:30 PM Changeset in webkit [146649] by eric.carlson@apple.com

• 6 edits in branches/safari-536.30-branch/LayoutTests

<rdar://problem/13465764> Many merged tests are failing

Change all instances of "testRunner" back to "layoutTestController" in svg files, which
my initial commit missed.

• fast/css/font-size-nan.svg:
• svg/custom/stale-resource-data-crash.svg:
• svg/custom/use-href-update-crash.svg:
• svg/custom/use-rebuild-resources-crash.svg:
• svg/text/alt-glpyh-on-fallback-font-crash.svg:

1:28 PM Changeset in webkit [146648] by wangxianzhu@chromium.org

• 1 edit in branches/chromium/1410/Source/WebCore/rendering/RenderLayerCompositor.cpp

Merge 144642 "Don't apply page scale to clipRect if applyPageSca..."

Don't apply page scale to clipRect if applyPageScaleFactorInCompositor is set to true
​https://bugs.webkit.org/show_bug.cgi?id=111229

Patch by Min Qin <​qinmin@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.

If applyPageScaleFactorInCompositor is set to true, webcore should use css coordinates.
As a result, we shouldn't apply page scale to clipRect in RenderLayerCompositor.
Layout tests set the flag to false, so we don't have anything to test against.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/12797016

1:24 PM Changeset in webkit [146647] by eric.carlson@apple.com

• 11 edits in trunk/Source/WebCore

Cleanup text track selection logic
​https://bugs.webkit.org/show_bug.cgi?id=113062

Reviewed by Jer Noble.

No new tests, covered by existing tests.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Remove.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Don't look at track attributes directly,

use captionPreferences->textTrackSelectionScore to calculate track rank.

(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_processingPreferenceChange here

instead of in captionPreferencesChanged.

(WebCore::HTMLMediaElement::captionPreferencesChanged): Don't suppress calls to setClosedCaptionsVisible,

existing code already makes sure we don't do unnecessary work.

• html/HTMLMediaElement.h:

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Drive by cleanup, don't

process inactive cues.

• html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::changedClosedCaptionsVisibility): Call resetTrackListMenu instead

of updateDisplay so we only mark the menu as needing a recalculation and do the work when
it is displayed.

• page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::shouldShowCaptions): When in testing mode, return true if

the caption or subtitle preference has been set.

(WebCore::CaptionUserPreferences::setShouldShowCaptions): In testing mode, clear the caption

and subtitle preference when passed false.

(WebCore::CaptionUserPreferences::textTrackSelectionScore): Calculate the track score based on

track type preference and preferred language.

(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Score a track according to

the language presence and position in the preferred languages list.

• page/CaptionUserPreferences.h:

• page/CaptionUserPreferencesMac.h:
• page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Calculate track language score

according to user preferences.

• platform/Language.cpp:

(WebCore::indexOfBestMatchingLanguageInList): Repurposed the static bestMatchingLanguage

function to return the location of a language in a Vector.

(WebCore::preferredLanguageFromList): Removed.

• platform/Language.h:

1:16 PM Changeset in webkit [146646] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Build fix for TransformationMatrix
​https://bugs.webkit.org/show_bug.cgi?id=113087

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-22
Reviewed by Martin Robinson.

This is a trivial build fix for clutter ac backend. Clutter AC backend doesn't use
TextureMapper so there is nowhere including TransformationMatrix.h.
For the reason, we include it explicitly.

No new tests because of no functionality change.

• platform/graphics/clutter/GraphicsContext3DPrivate.cpp:
• platform/graphics/clutter/GraphicsContext3DPrivate.h:

(WebCore):

1:14 PM Changeset in webkit [146645] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Coordinates.idl lacks Conditional=GEOLOCATION
​https://bugs.webkit.org/show_bug.cgi?id=112949

Patch by Steve Block <​steveblock@chromium.org> on 2013-03-22
Reviewed by Steve Block.

No new tests, build optimization only.

• page/Coordinates.idl: Added GEOLOCATION conditional guard.

1:04 PM Changeset in webkit [146644] by dcheng@chromium.org

• 12 edits
  4 adds in trunk

Data store should be readable in dragstart/copy/cut events
​https://bugs.webkit.org/show_bug.cgi?id=23695

Reviewed by Tony Chang.

Source/WebCore:

There were several events where data could be written but not read back due to the fact that
different Clipboard method implementations checked permissions inconsistently. This patch
adds helper methods to check if an operation is permitted on a Clipboard and refactors all
direct comparisons against Clipboard::m_policy to use the new helpers instead. This fixes
several bugs where Clipboard::types and Clipboard::getData are not usable inside the
aforementioned events.

Tests: editing/pasteboard/can-read-in-copy-and-cut-events.html

editing/pasteboard/can-read-in-dragstart-event.html

• dom/Clipboard.cpp:

(WebCore::Clipboard::canReadTypes): Formerly restricted to ClipboardReadable and

ClipboardTypesReadable; now allows ClipboardWritable as
well.

(WebCore::Clipboard::canReadData): Formerly restricted to ClipboardReadable; now allows

ClipboardWritable as well.

(WebCore::Clipboard::canWriteData):
(WebCore::Clipboard::canSetDragImage):
(WebCore::Clipboard::hasFileOfType):
(WebCore::Clipboard::hasStringOfType):
(WebCore::Clipboard::setDropEffect):
(WebCore::Clipboard::setEffectAllowed):

• dom/Clipboard.h:

(Clipboard):

• platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::clearData):
(WebCore::ClipboardBlackBerry::clearAllData):
(WebCore::ClipboardBlackBerry::getData):
(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::types):

• platform/chromium/ClipboardChromium.cpp:

(WebCore::DataTransferItemPolicyWrapper::kind):
(WebCore::DataTransferItemPolicyWrapper::type):
(WebCore::DataTransferItemPolicyWrapper::getAsString):
(WebCore::DataTransferItemPolicyWrapper::getAsFile):
(WebCore::ClipboardChromium::clearData):
(WebCore::ClipboardChromium::clearAllData):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::setData):
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::files):
(WebCore::ClipboardChromium::setDragImage):

• platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::clearData):
(WebCore::ClipboardGtk::clearAllData):
(WebCore::ClipboardGtk::getData):
(WebCore::ClipboardGtk::setData):
(WebCore::ClipboardGtk::types):
(WebCore::ClipboardGtk::files):
(WebCore::ClipboardGtk::setDragImage):

• platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::clearData):
(WebCore::ClipboardMac::clearAllData):
(WebCore::ClipboardMac::getData):
(WebCore::ClipboardMac::setData):
(WebCore::ClipboardMac::types):
(WebCore::ClipboardMac::files):
(WebCore::ClipboardMac::setDragImage):

• platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::clearData):
(WebCore::ClipboardQt::clearAllData):
(WebCore::ClipboardQt::getData):
(WebCore::ClipboardQt::setData):
(WebCore::ClipboardQt::types):
(WebCore::ClipboardQt::files):
(WebCore::ClipboardQt::setDragImage):
(WebCore::ClipboardQt::items):

• platform/qt/DataTransferItemListQt.cpp:

(WebCore::DataTransferItemListQt::length):
(WebCore::DataTransferItemListQt::item):
(WebCore::DataTransferItemListQt::deleteItem):
(WebCore::DataTransferItemListQt::clear):
(WebCore::DataTransferItemListQt::add):

• platform/qt/DataTransferItemQt.cpp:

(WebCore::DataTransferItemQt::getAsString):

• platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::clearData):
(WebCore::ClipboardWin::clearAllData):
(WebCore::ClipboardWin::getData):
(WebCore::ClipboardWin::setData):
(WebCore::ClipboardWin::types):
(WebCore::ClipboardWin::files):
(WebCore::ClipboardWin::setDragImage):

LayoutTests:

• editing/pasteboard/can-read-in-copy-and-cut-events-expected.txt: Added.
• editing/pasteboard/can-read-in-copy-and-cut-events.html: Added.
• editing/pasteboard/can-read-in-dragstart-event-expected.txt: Added.
• editing/pasteboard/can-read-in-dragstart-event.html: Added.

1:00 PM Changeset in webkit [146643] by schenney@chromium.org

• 16 edits
  1 add in trunk/LayoutTests

[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

Only the things failing on the bots, not already accounted for.

• platform/chromium-linux/fast/text/international/danda-space-expected.png:
• platform/chromium-mac-lion/fast/multicol/vertical-rl/nested-columns-expected.png:
• platform/chromium-mac-lion/fast/ruby/base-shorter-than-text-expected.png:
• platform/chromium-mac-lion/fast/text/emphasis-combined-text-expected.png:
• platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png:
• platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
• platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png:
• platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
• platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png:
• platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.png:
• platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
• platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
• platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
• platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
• platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
• platform/chromium/TestExpectations:

12:44 PM Changeset in webkit [146642] by abucur@adobe.com

• 2 edits in trunk/Source/WebCore

[CSS Regions] Remove pushLayoutState(RenderFlowThread*) from RenderView
​https://bugs.webkit.org/show_bug.cgi?id=113084

Reviewed by Dirk Schulze.

Remove void pushLayoutState(RenderFlowThread*, bool regionsChanged) from RenderView.h because it's not used.

Tests: Code cleanup. No tests needed.

• rendering/RenderView.h:

(RenderView):

12:34 PM Changeset in webkit [146641] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

Check focused node reference when traversing through history
​https://bugs.webkit.org/show_bug.cgi?id=113082

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-03-22
Reviewed by Rob Buis.

PR312101
Check if we have a valid node and document before attempting to access its frame and
frame selection. This is causing issues when going back to a page after a redirect
where a stale pointer is used.
Further, the focused node should be changed after the frame is fully loaded.

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::restoreViewState):

12:23 PM Changeset in webkit [146640] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebCore

[EFL] Fix build issues to enable CSS Filter and Shaders support.
​https://bugs.webkit.org/show_bug.cgi?id=111274

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2013-03-22
Reviewed by Noam Rosenthal.

This is in preperation to enable CSS Filter and Shaders support.
This patch fixes related build issues to enable the support.

• platform/graphics/surfaces/efl/GLTransportSurface.cpp:
• platform/graphics/texmap/TextureMapper.cpp:
• platform/graphics/texmap/TextureMapper.h:

(WebCore):

• platform/graphics/texmap/TextureMapperGL.cpp:
• platform/graphics/texmap/TextureMapperGL.h:

(WebCore):

• platform/graphics/texmap/TextureMapperShaderProgram.h:

12:11 PM Changeset in webkit [146639] by pkasting@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] Remove Android platform expectations from Chromium TestExpectations.
(Too many bug URLs to list)

Unreivewed, test expectations update.

• platform/chromium/TestExpectations:

12:01 PM Changeset in webkit [146638] by falken@chromium.org

• 4 edits in trunk/Source/WebCore

Implement isEnabledFormControl() for SliderThumbElement and SpinButtonElement in terms of disabled()
​https://bugs.webkit.org/show_bug.cgi?id=112993

Reviewed by Kent Tamura.

This is an intermediate step for refactoring Node::disabled and
Element::isEnabledFormControl. All classes that override
isEnabledFormControl just return !disabled(), except for
SliderThumbElement and SpinButtonElement. This patch changes those two
classes to do so, which shows that the two functions are redundant and
easy to refactor into a single function in a subsequent patch.

No new tests, there should be no behavior change.

• html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::disabled):
(WebCore):
(WebCore::SliderThumbElement::isEnabledFormControl):

• html/shadow/SliderThumbElement.h:

(SliderThumbElement):

• html/shadow/SpinButtonElement.h: The check of shadowHost() is

necessary because it can be detached by JavaScript that runs during
event handling (see r76566)

11:47 AM Changeset in webkit [146637] by mario@webkit.org

• 4 edits in trunk/Source

[GTK] Include the right GL header for GLES2
​https://bugs.webkit.org/show_bug.cgi?id=113034

Reviewed by Martin Robinson.

Include GLES2/gl2.h when using GLES2.

Source/WebKit/gtk:

• WebCoreSupport/AcceleratedCompositingContextGL.cpp:

Source/WebKit2:

• WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

11:38 AM Changeset in webkit [146636] by eric.carlson@apple.com

• 2 edits in branches/safari-536.30-branch/LayoutTests

Add the newline at end of the test results, apparently lost when merging r131709.

• fast/forms/textarea/textarea-autofocus-removal-while-focusing-with-style-expected.txt:

11:30 AM Changeset in webkit [146635] by pdr@google.com

• 3 edits
  2 copies in branches/chromium/1410

Merge 146227 "Separate SVG image size and container size"

Separate SVG image size and container size
​https://bugs.webkit.org/show_bug.cgi?id=112651

Reviewed by Stephen Chenney.

Source/WebCore:

Previously, SVG images could retain their cached size between reloads due to a bug where an
old container size would be re-used if the image's new container size was not available yet.

This patch changes SVGImage::size() to return the intrinsic size of the image before a
container size has been set. SVGImageCache::imageSizeForRenderer will now return the
image's intrinsic size instead of a cached value if the container size cannot be looked up.
In javascript, querying [SVGImage].width will now return either the image's intrinsic size
or the size of 'imageForContainer'.

Test: svg/as-image/svg-container-size-after-reload.html

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::dataChanged):

• svg/graphics/SVGImage.h:

The member variable 'm_intrinsicSize' has been added to track the image's intrinsic
size. This term can be found in: ​http://www.w3.org/TR/css3-images/#default-sizing

• svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageSizeForRenderer):
(WebCore::SVGImageCache::imageForRenderer):

In both of these functions, image has been renamed to imageForContainer here to clarify
that the cached container size is being returned, not the image's intrinsic size.

LayoutTests:

• svg/as-image/svg-container-size-after-reload-expected.txt: Added.
• svg/as-image/svg-container-size-after-reload.html: Added.

TBR=​pdr@google.com
Review URL: ​https://codereview.chromium.org/13008026

11:28 AM Changeset in webkit [146634] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Hit Test doesn't need to be active
​https://bugs.webkit.org/show_bug.cgi?id=113072

Patch by Genevieve Mak <​gmak@rim.com> on 2013-03-22
Reviewed by Rob Buis.

Reviewed Internally By Mike Lattanzio.
PR #306074

• WebKitSupport/ProximityDetector.cpp:

(BlackBerry::WebKit::ProximityDetector::findBestPoint):

11:27 AM Changeset in webkit [146633] by alecflett@chromium.org

• 6 edits
  2 adds in trunk/Source/WebKit/chromium

[chromium] Support Quota API in Worker
​https://bugs.webkit.org/show_bug.cgi?id=112713

Hook up WebKit side of queryUsageAndQuota. Tests
and WebCore code will come in ​https://bugs.webkit.org/show_bug.cgi?id=112972

Reviewed by David Levin.

• WebKit.gyp:
• public/WebCommonWorkerClient.h:

(WebKit::WebCommonWorkerClient::queryUsageAndQuota):

• src/StorageQuotaChromium.cpp:

(WebCore::StorageQuota::queryUsageAndQuota):
(WebCore::StorageQuota::requestQuota):

• src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::queryUsageAndQuota):
(WebKit):

• src/WebWorkerClientImpl.h:
• src/WorkerStorageQuotaCallbacksBridge.cpp: Added.

(WebKit):
(MainThreadStorageQuotaCallbacks):
(WebKit::MainThreadStorageQuotaCallbacks::createLeakedPtr):
(WebKit::MainThreadStorageQuotaCallbacks::~MainThreadStorageQuotaCallbacks):
(WebKit::MainThreadStorageQuotaCallbacks::didQueryStorageUsageAndQuota):
(WebKit::MainThreadStorageQuotaCallbacks::didFail):
(WebKit::MainThreadStorageQuotaCallbacks::didGrantStorageQuota):
(WebKit::MainThreadStorageQuotaCallbacks::MainThreadStorageQuotaCallbacks):
(WorkerStorageQuotaContextObserver):
(WebKit::WorkerStorageQuotaContextObserver::create):
(WebKit::WorkerStorageQuotaContextObserver::notifyStop):
(WebKit::WorkerStorageQuotaContextObserver::WorkerStorageQuotaContextObserver):
(WebKit::WorkerStorageQuotaCallbacksBridge::stop):
(WebKit::WorkerStorageQuotaCallbacksBridge::cleanUpAfterCallback):
(WebKit::WorkerStorageQuotaCallbacksBridge::WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::~WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::postQueryUsageAndQuotaToMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::queryUsageAndQuotaOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didFailOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didQueryStorageUsageAndQuotaOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didFailOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didQueryStorageUsageAndQuotaOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::runTaskOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::runTaskOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::mayPostTaskToWorker):

• src/WorkerStorageQuotaCallbacksBridge.h: Added.

(WebCore):
(WebKit):
(WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::create):

11:13 AM Changeset in webkit [146632] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Add a failure test expectation to media/track/track-user-preferences.html after r146380.
The failure is tracked by the webkit.org/b/113083.

• platform/mac/TestExpectations:

11:08 AM Changeset in webkit [146631] by eric.carlson@apple.com

• 2 edits in branches/safari-536.30-branch/LayoutTests

Merge r135523 to get the updated test results.

2012-11-22 Daniel Bates <​dbates@webkit.org>

JavaScript fails to concatenate large strings
<​https://bugs.webkit.org/show_bug.cgi?id=102963>

Update test result.

• fast/js/concat-large-strings-crash-expected.txt:

10:51 AM Changeset in webkit [146630] by allan.jensen@digia.com

• 5 edits in trunk

[Qt] New fast/text/word-space-with-kerning-3.html fails on Qt.
​https://bugs.webkit.org/show_bug.cgi?id=112668

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Qt adds word-spacing to leading spaces, but WebCore only expects
us to add for trailing spaces. We only corrected for this in width
calculation but do need to also do it for drawing.

Instead of subtracting the extra word-spacing we now configure the
FormatRange not to apply to leading spaces. This means this behavior
will be applied everywhere reliably.

• platform/graphics/Font.h:

(Font):

• platform/graphics/qt/FontQt.cpp:

(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::initFormatForTextLayout):

LayoutTests:

• platform/qt/TestExpectations:

10:41 AM Changeset in webkit [146629] by jsbell@chromium.org

• 2 edits in trunk/Source/WebCore

REGRESSION (r146540?): Crashes in storage/indexeddb/factory-basics-workers.html, storage/indexeddb/transaction-error.html
​https://bugs.webkit.org/show_bug.cgi?id=113019

Reviewed by Tony Chang.

Also manifesting flakily under Chromium's content_shell. It's an ASSERT being hit in
the IDBTransaction destructor. The cause was r146540 which allows a stopped context
to reclaim script wrappers. This allows the IDBTransaction to be deref'd at times where
it previously would have just leaked. Modulate the destructor assertions to account
for this case.

No new tests; failures already manifest as flaky crashes in some ports.

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::~IDBTransaction): If context is stopped, expected state
transitions/cleanup may not have occurred before destructor runs.

10:34 AM Changeset in webkit [146628] by dgrogan@chromium.org

• 4 edits in trunk/Source

IndexedDB: Histogram available disk space on attempt to open database
​https://bugs.webkit.org/show_bug.cgi?id=112862

Reviewed by Tony Chang.

Source/Platform:

• chromium/public/Platform.h:

(WebKit::Platform::availableDiskSpaceInBytes):
(Platform):

Source/WebCore:

ChromeOS suspects they might be hitting disk corruption when the disks
are nearly full. This patch logs the available space to either the
"success" or the "fail" histogram as appropriate so that the
distributions can be compared.

No new tests - I don't know of a good way to test histograms. Local
printf testing didn't turn up any bugs.

• platform/leveldb/LevelDBDatabase.cpp:

(WebCore::HistogramFreeSpace):
(WebCore):
(WebCore::LevelDBDatabase::open):

10:11 AM Changeset in webkit [146627] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Selection overlay clipped incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=113069

Patch by Andrew Lo <​anlo@rim.com> on 2013-03-22
Reviewed by George Staikos.
Internally reviewed by Arvid Nilsson.

As a follow-up to r146278, the clip rect also needs to be
adjusted by the parent's offset when drawing the
selection overlay.

• WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::paintContents):

10:05 AM Changeset in webkit [146626] by Nate Chapin

• 5 edits
  3 adds in trunk

REGRESSION (r146239): Reproducible crash in WebCore::DocumentLoader::responseReceived.
​https://bugs.webkit.org/show_bug.cgi?id=112811

Reviewed by Brady Eidson.

Source/WebCore:

Test: http/tests/cache/x-frame-options-304.html

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

• loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::switchClientsToRevalidatedResource):

• loader/cache/CachedRawResource.h:

LayoutTests:

• http/tests/cache/resources/x-frame-options.php: Added.
• http/tests/cache/x-frame-options-304-expected.txt: Added.
• http/tests/cache/x-frame-options-304.html: Added.

10:03 AM Changeset in webkit [146625] by rniwa@webkit.org

• 3 edits in trunk/Tools

Leak bots shouldn't build
​https://bugs.webkit.org/show_bug.cgi?id=112774

Reviewed by Simon Fraser.

Since leak bots use regular debug builds, there is no need to build on these bots.
Simply downloading builds will dramatically improve the cycle time of these bots.

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
TestFactory instead of BuildAndTestFactory.

9:58 AM Changeset in webkit [146624] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Add flaky crash expectations on some media tests per bugs 113075 and 113076.

• platform/win/TestExpectations:

9:41 AM Changeset in webkit [146623] by wangxianzhu@chromium.org

• 10 edits
  3 copies in branches/chromium/1410

Merge 146129 "Variant of non-primary fell-back SVGFont causes cr..."

Variant of non-primary fell-back SVGFont causes crash.
​https://bugs.webkit.org/show_bug.cgi?id=112367

Reviewed by Stephen Chenney.

Source/WebCore:

Don't go to PlatformFontData path for SimpleFontData::createScaledFontData()
for SVG fonts.

Test: svg/css/font-face-variant-crash.html

• platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::~SimpleFontData):
(WebCore::SimpleFontData::createScaledFontData): Don't go to PlatformFontData path for SVG fonts.
(WebCore):

• platform/graphics/SimpleFontData.h:

(SimpleFontData): Added createScaledFontData and renamed the original createScaledFontData to platformCreateScaledFontData.

BTW, Removed unreferenced commonInit.

• platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Renamed from createScaledFontData.

• platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

• platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

• platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

• platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

• platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

• platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

• platform/graphics/wince/SimpleFontDataWinCE.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

• platform/graphics/wx/SimpleFontDataWx.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

LayoutTests:

• resources/SpaceOnly.otf: Added. A font containing only the space glyph for testing font fallback.
• svg/css/font-face-variant-crash-expected.txt: Added.
• svg/css/font-face-variant-crash.html: Added.

TBR=​wangxianzhu@chromium.org

9:24 AM Changeset in webkit [146622] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION: -webkit-box-reflect does not show on video elements
​https://bugs.webkit.org/show_bug.cgi?id=112397

Reviewed by Eric Carlson.

Work around the ASSERTs generated when setting an AVPlayerLayer's player property
during a CA flush by setting the player property during the next runloop, outside
of a CA flush.

• platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::clone):

9:22 AM Changeset in webkit [146621] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[Curl] Performance fix, avoid loading cookie file on every request.
​https://bugs.webkit.org/show_bug.cgi?id=113023

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-03-22
Reviewed by Brent Fulgham.

We currently load the cookie file on every request, and when setting cookies from JavaScript, by using the option CURLOPT_COOKIEFILE.
This is very inefficient as the cookie file can get quite large, and file I/O is slow.
It is sufficient to load the cookie file on startup, as we use a shared cookie database between the requests.

• platform/network/curl/CookieJarCurl.cpp:

(WebCore::setCookiesFromDOM): Avoid loading cookie file when setting cookies from JavaScript.

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle): Avoid loading cookie file on every request.
(WebCore::ResourceHandleManager::initCookieSession): Load the cookie file to shared database on startup.

9:08 AM Changeset in webkit [146620] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] Update Input field Background Color
​https://bugs.webkit.org/show_bug.cgi?id=113063

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-03-22
Reviewed by George Staikos.

RIM PR 307463.
Internally reviewed by Ed Baker.

• platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintTextFieldOrTextAreaOrSearchField):

8:56 AM Changeset in webkit [146619] by loislo@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: FlameChart. Draw function names over flame chart bar if they fit into the bar.
​https://bugs.webkit.org/show_bug.cgi?id=113052

Reviewed by Vsevolod Vlasov.

The draw function will draw the bar title if the text is less than bar width.
Unfortunately almost all the projects which need to be profiled
use long function names with dots. So if the function name has dots and
doesn't fit into the space then prepareTitle will try to drop the prefix before dot.
If the title has no dots then the function will strip the tail of the title.

• inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._prepareTitle):

8:55 AM Changeset in webkit [146618] by yurys@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed. Update test expectations for a bunch of softwarecompositing tests.

• platform/chromium/TestExpectations:

8:44 AM Changeset in webkit [146617] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Add "hidden" attribute to the recently added APIs in Inspector.json
​https://bugs.webkit.org/show_bug.cgi?id=113061

Added "hidden": true to the APIs introduced since version 1.0.

Patch by Vladislav Kaznacheev <​kaznacheev@chromium.org> on 2013-03-22
Reviewed by Pavel Feldman.

• inspector/Inspector.json:

8:39 AM Changeset in webkit [146616] by schenney@chromium.org

• 4 edits in trunk

Source/WebKit/chromium: Skia flag removal to enable bug fixes and performance improvements.

Unreviewed code enabling.

• skia_webkit.gyp:

LayoutTests: Enabling Skia features/modifications.

Unreviewed Chromium expectations, all of which will be removed later today.

• platform/chromium/TestExpectations:

8:22 AM Changeset in webkit [146615] by vsevik@chromium.org

• 3 edits in trunk/Source/WebCore

Web Inspector: Correctly implement scrollToLine, revealLine and setSelection on CodeMirror editor.
​https://bugs.webkit.org/show_bug.cgi?id=113028

Reviewed by Pavel Feldman.

Added focus event handler to CodeMirror editor view elememnt to support inspector's focus model.
Added selection and scroll listeners to correctly save editor scroll and selection in history.
Implemented revealLine, scrollToLine and setSelection.
Note: CodeMirror's coordsChar method does not work correctly in "local" mode, implemented as binary search
as a temporary workaround.

• inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.defaultFocusedElement):
(WebInspector.CodeMirrorTextEditor.prototype._handleElementFocus):
(WebInspector.CodeMirrorTextEditor.prototype.revealLine):
(WebInspector.CodeMirrorTextEditor.prototype._coordsChar):
(WebInspector.CodeMirrorTextEditor.prototype._topScrolledLine):
(WebInspector.CodeMirrorTextEditor.prototype._bottomScrolledLine):
(WebInspector.CodeMirrorTextEditor.prototype._scroll):
(WebInspector.CodeMirrorTextEditor.prototype._selectionChange):
(WebInspector.CodeMirrorTextEditor.prototype.scrollToLine):
(WebInspector.CodeMirrorTextEditor.prototype.setSelection):
(WebInspector.CodeMirrorTextEditor.prototype.copyRange):

• inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.copyRange):

8:16 AM Changeset in webkit [146614] by vsevik@chromium.org

• 5 edits in trunk/Source/WebCore

Web Inspector: [Regression] Editor scroll is not restored after inspector reload.
​https://bugs.webkit.org/show_bug.cgi?id=113027

Reviewed by Pavel Feldman.

• inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype._isEditorShowing):
(WebInspector.SourceFrame.prototype._innerHighlightLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerRevealLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerScrollToLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerSetSelectionIfNeeded):

8:15 AM WebKitGTK/2.0.x edited by dimstar@opensuse.org

Add bug 113036 to the list. (diff)

8:04 AM Changeset in webkit [146613] by allan.jensen@digia.com

• 5 edits in trunk/Source/WebCore

[Qt] Fix build with OPENCL 1.2
​https://bugs.webkit.org/show_bug.cgi?id=113056

Reviewed by Kenneth Rohde Christiansen.

Switch qmake checks to the modern style which means we can enable OpenCL with
WEBKIT_CONFIG+=opencl.

Upgrade OpenCL 1.1 clCreateImage2D to OpenCL 1.2 clCreateImage calls.

• Target.pri:
• WebCore.pri:
• platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::createOpenCLImageResult):

• platform/graphics/gpu/opencl/FilterContextOpenCL.cpp:

(WebCore::FilterContextOpenCL::createOpenCLImage):

7:59 AM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

7:57 AM Changeset in webkit [146612] by kov@webkit.org

• 1 edit
  1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146611 - Telugu [te] language translation submission for WebKitGTK+ HEAD
​https://bugs.webkit.org/show_bug.cgi?id=103052

Patch by Krishnababu Krothapalli <​kkrothap@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).

• te.po: Added.

7:54 AM Changeset in webkit [146611] by kov@webkit.org

• 1 edit
  1 add in trunk/Source/WebCore/platform/gtk/po

Telugu [te] language translation submission for WebKitGTK+ HEAD
​https://bugs.webkit.org/show_bug.cgi?id=103052

Patch by Krishnababu Krothapalli <​kkrothap@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).

• te.po: Added.

7:45 AM Changeset in webkit [146610] by eae@chromium.org

• 8 edits
  1 add
  2 deletes in trunk/LayoutTests

Unreviewed chromium rebaselines for r146600.

• platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
• platform/chromium-mac-lion/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
• platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
• platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png:
• platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
• platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.txt:
• platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
• platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
• platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.png:
• platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:

7:42 AM Changeset in webkit [146609] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK][AC] Opacity animation doesn't work with clutter backend
​https://bugs.webkit.org/show_bug.cgi?id=110347

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-22
Reviewed by Gustavo Noronha Silva.

The static casting in ternary operator doesn't change actual inputted argument type.
So I replaced it with if-else statement.

Covered by existing animation tests.

• platform/graphics/clutter/PlatformClutterAnimation.cpp:

(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):

7:38 AM Changeset in webkit [146608] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[GTK][AC] Add removing animations procedure with clutter ac backend
​https://bugs.webkit.org/show_bug.cgi?id=110607

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-22
Reviewed by Gustavo Noronha Silva.

This changes is based on mac port implementation. The only different thing is
that updateAnimations is called explicitly in destructor of GraphicsLayerClutter
to remove uncommitted animations. Because even though we call notifyFlushRequired
to remove existing animations in removeAnimation(), removeClutterAnimationFromLayer
has been never reached since the root layer is destroyed before. It means
that we haven't lost a change to remove actual animations from clutterActor.

Covered by existing animation tests.

• platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::removeAnimation):
(WebCore):
(WebCore::GraphicsLayerClutter::removeClutterAnimationFromLayer):

• platform/graphics/clutter/GraphicsLayerClutter.h:

(WebCore::GraphicsLayerClutter::animationIsRunning):
(GraphicsLayerClutter):

7:28 AM Changeset in webkit [146607] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[EFL][WebGL] Optimize AlphaOp for HTMLVideoElement input.
​https://bugs.webkit.org/show_bug.cgi?id=113049

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2013-03-22
Reviewed by Kenneth Rohde Christiansen.

Covered by existing tests.

Changeset 137397 implemented optimisation to avoid any
unnecessary Unmultiply or Premultiply operation in unpack/pack
provided the Image source is from HTMLVideoElement. This patch
enables the same for EFL port.

• platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

7:27 AM Changeset in webkit [146606] by eae@chromium.org

• 8 edits
  5 adds in trunk/LayoutTests

Unreviewed chromium and apple mac rebaselines for r146600.

• platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.png:
• platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
• platform/chromium-mac-lion/fast/transforms/bounding-rect-zoom-expected.txt: Added.
• platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
• platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
• platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.png:
• platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
• platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
• platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
• platform/chromium/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
• platform/chromium/fast/transforms/bounding-rect-zoom-expected.txt: Added.
• platform/mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
• platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:

7:24 AM Changeset in webkit [146605] by timothy@apple.com

• 2 edits in trunk/Source/WebKit2

Fix an assert when opening the Web Inspector window for the first time.

rdar://problem/13471765
​https://webkit.org/b/113053

Reviewed by Eric Carlson.

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow): Assign m_inspectorWindow
earlier so it is ready for when center is called and windowDidMove: gets called.

7:22 AM Changeset in webkit [146604] by ddkilzer@apple.com

• 2 edits in trunk/Source/JavaScriptCore

BUILD FIX (r146558): Build testapi.mm with ARC enabled for armv7s
<​http://webkit.org/b/112608>

Fixes the following build failure:

Source/JavaScriptCore/API/tests/testapi.mm:205:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls]
}

^{1 error generated.}

• Configurations/ToolExecutable.xcconfig: Enable ARC for armv7s

architecture.

6:53 AM Changeset in webkit [146603] by ddkilzer@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Revert "BUILD FIX (r146558): Call [super dealloc] from -[TinyDOMNode dealloc]"

This fixes a build failure introduced by this change:

Source/JavaScriptCore/API/tests/testapi.mm:206:6: error: ARC forbids explicit message send of 'dealloc'

[super dealloc];

^~

1 error generated.

Not sure why this didn't fail locally on my Mac Pro.

• API/tests/testapi.mm:

(-[TinyDOMNode dealloc]): Remove call to [super dealloc].

6:46 AM Changeset in webkit [146602] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Missed one in r146589.

• platform/qt/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Rebaselining after r146531.

6:43 AM Changeset in webkit [146601] by tommyw@google.com

• 13 edits in trunk

Source/WebCore: Clean up the speech recognintion API
​https://bugs.webkit.org/show_bug.cgi?id=112916

Reviewed by Adam Barth.

This patch cleans away deprecated parts, fixes so that stop() can be called more than once and adds
the missing emma attribute on SpeechRecognitionEvent (which is always null).

Patch covered by existing tests.

• Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::stopFunction):
(WebCore::SpeechRecognition::abort):
(WebCore::SpeechRecognition::didEnd):
(WebCore::SpeechRecognition::SpeechRecognition):

• Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

• Modules/speech/SpeechRecognitionEvent.cpp:

(WebCore::SpeechRecognitionEvent::createResult):
(WebCore::SpeechRecognitionEvent::createNoMatch):
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):

• Modules/speech/SpeechRecognitionEvent.h:

(WebCore):
(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::emma):

• Modules/speech/SpeechRecognitionEvent.idl:

Source/WebKit/chromium: Clean up the speach recognintion API
​https://bugs.webkit.org/show_bug.cgi?id=112916

Reviewed by Adam Barth.

• public/WebSpeechRecognizerClient.h:
• src/SpeechRecognitionClientProxy.cpp:
• src/SpeechRecognitionClientProxy.h:

(SpeechRecognitionClientProxy):

LayoutTests: Clean up the speech recognintion API
​https://bugs.webkit.org/show_bug.cgi?id=112916

Reviewed by Adam Barth.

• fast/events/constructors/speech-recognition-event-constructor-expected.txt:
• fast/events/constructors/speech-recognition-event-constructor.html:

6:40 AM Changeset in webkit [146600] by eae@chromium.org

• 8 edits
  2 adds in trunk

Floor cell widths in AutoTableLayout::recalcColumn
​https://bugs.webkit.org/show_bug.cgi?id=112922

Reviewed by Levi Weintraub.

Source/WebCore:

Table cells widths are floored to ensure even distribution of available
space across columns. The code path that computes the width of the
_table_ failed to take this into account and thus can over report the
total width of the table.

Test: fast/sub-pixel/table-with-subpixel-cell-size.html

• rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn): Floor width to match column sizing logic.

LayoutTests:

Add test for table with subpixel cells and update existing baselines as needed.

• fast/sub-pixel/table-with-subpixel-cell-size-expected.html: Added.
• fast/sub-pixel/table-with-subpixel-cell-size.html: Added.
• platform/chromium-linux/fast/text/international/bidi-layout-across-linebreak-expected.png:
• platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
• platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt:
• platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt:
• platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:

6:35 AM Changeset in webkit [146599] by ddkilzer@apple.com

• 2 edits in trunk/Source/JavaScriptCore

BUILD FIX (r146558): Call [super dealloc] from -[TinyDOMNode dealloc]
<​http://webkit.org/b/112608>

Fixes the following build failure:

Source/JavaScriptCore/API/tests/testapi.mm:205:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls]
}

^{1 error generated.}

• API/tests/testapi.mm:

(-[TinyDOMNode dealloc]): Call [super dealloc].

6:27 AM Changeset in webkit [146598] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

BUILD FIX (r146208): Export shouldPrintExceptions methods for iOS

Fixes the following build failure:

Undefined symbols for architecture i386:

"ZN7WebCore11PageConsole24setShouldPrintExceptionsEb", referenced from:

+[WebCoreStatistics setShouldPrintExceptions:] in WebCoreStatistics.o

"ZN7WebCore11PageConsole21shouldPrintExceptionsEv", referenced from:

+[WebCoreStatistics shouldPrintExceptions] in WebCoreStatistics.o

ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)

• WebCore.exp.in: Move symbols so they're exported for iOS as

well.

6:18 AM Changeset in webkit [146597] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk/Source/WebKit

[BlackBerry] Add custom BackForwardList client implementation
​https://bugs.webkit.org/show_bug.cgi?id=113024

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-03-22
Reviewed by Rob Buis.

PR 310030
Internally reviewed by Joe Mason.

Source/WebKit:

• PlatformBlackBerry.cmake: Add new files to compilation.

Source/WebKit/blackberry:

Adds a new class BackForwardListBlackBerry that implements
BackForwardList client and wraps the BackForwardListImpl including
the BlackBerry specific changes to notify the API layer when the
BackForwardList changes.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init): Create a
BackForwardListBlackBerry.
(BlackBerry::WebKit::WebPage::getBackForwardList): Use
BackForwardListBlackBerry instead of BackForwardListImpl.
(BlackBerry::WebKit::WebPage::clearBackForwardList): Ditto.

• WebCoreSupport/BackForwardListBlackBerry.cpp: Added.

(WebCore):
(WebCore::BackForwardListBlackBerry::BackForwardListBlackBerry):
(WebCore::BackForwardListBlackBerry::~BackForwardListBlackBerry):
(WebCore::BackForwardListBlackBerry::current):
(WebCore::BackForwardListBlackBerry::notifyBackForwardListChanged):
(WebCore::BackForwardListBlackBerry::addItem):
(WebCore::BackForwardListBlackBerry::goToItem):
(WebCore::BackForwardListBlackBerry::itemAtIndex):
(WebCore::BackForwardListBlackBerry::backListCount):
(WebCore::BackForwardListBlackBerry::forwardListCount):
(WebCore::BackForwardListBlackBerry::isActive):
(WebCore::BackForwardListBlackBerry::close):
(WebCore::BackForwardListBlackBerry::clear):
(WebCore::BackForwardListBlackBerry::entries):
(WebCore::BackForwardListBlackBerry::currentItem):

• WebCoreSupport/BackForwardListBlackBerry.h: Added.

(WebKit):
(WebCore):
(BackForwardListBlackBerry):
(WebCore::BackForwardListBlackBerry::create):

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
• WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

5:32 AM Changeset in webkit [146596] by kov@webkit.org

• 1 edit
  1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146594 - [kn] Kannada Translation for webkit
​https://bugs.webkit.org/show_bug.cgi?id=106301

Patch by Shankar Prasad <​svenkate@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).

• kn.po: Added.

5:32 AM Changeset in webkit [146595] by kov@webkit.org

• 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146474 - [l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
​https://bugs.webkit.org/show_bug.cgi?id=103035

Patch by Sandeep Shedmake <​sshedmak@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

• mr.po: updated.

5:31 AM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

5:29 AM Changeset in webkit [146594] by kov@webkit.org

• 1 edit
  1 add in trunk/Source/WebCore/platform/gtk/po

[kn] Kannada Translation for webkit
​https://bugs.webkit.org/show_bug.cgi?id=106301

Patch by Shankar Prasad <​svenkate@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).

• kn.po: Added.

5:24 AM Changeset in webkit [146593] by jocelyn.turcotte@digia.com

• 2 edits in trunk/Tools

[Qt] Fix the TestWebKitAPI build
​https://bugs.webkit.org/show_bug.cgi?id=113044

Reviewed by Tor Arne Vestbø.

The generate-forwarding-headers script would only be run
after the targets in InjectedBundle.pri since the second
addStrictSubdirOrderBetween call in
Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
the derived_sources -> injected_bundle order in SUBDIRS.

Fix it by only moving the dependent target at the end of
SUBDIRS, don't touch its dependency.

• qmake/mkspecs/features/functions.prf:

5:14 AM Changeset in webkit [146592] by yurys@chromium.org

• 2 edits in trunk/Source/WebCore

Unreviewed. Fix Chromium Win compilation after r146583.

• bindings/v8/CustomElementHelpers.cpp:

(WebCore::CustomElementHelpers::invokeReadyCallbackIfNeeded):

5:04 AM Changeset in webkit [146591] by loislo@chromium.org

• 4 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Chart has to be zoomed around the mouse pointer.
​https://bugs.webkit.org/show_bug.cgi?id=113031

Reviewed by Yury Semikhatsky.

Overview grid is able to zoom around the mouse pointer.
So the simplest way is to translate x coordinate of the mouse pointer hovered over the chart
to x coordinate in term of overview window and pass it to the zoom function.

Minor unrelated fix: draw small border at bottom of the overview grid.

• inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._onMouseWheel):

• inspector/front-end/OverviewGrid.js:

(WebInspector.OverviewGrid.prototype.zoom):

• inspector/front-end/flameChart.css:

(#flame-chart-overview-container):

4:58 AM Changeset in webkit [146590] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Texmap] TextureMapperImageBuffer should not use rendering code for filters.
​https://bugs.webkit.org/show_bug.cgi?id=113040

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-03-22
Reviewed by Kenneth Rohde Christiansen.

Disable TextureMapperImageBuffer filters, until they can be done the right way.
This should only disrupt accelerated filters in fallback mode, which is a very rare
use case.

No new testable functionality.

• platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::applyFilters):

4:54 AM Changeset in webkit [146589] by zarvai@inf.u-szeged.hu

• 3 edits
  8 moves
  8 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r146469 and r146531. Cleaning up duplicated expecteds.

• platform/qt-5.0-wk1/compositing/iframes/iframe-size-from-zero-expected.txt:
• platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Removed.
• platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.
• platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Removed.
• platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Removed.
• platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Removed.
• platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Removed.
• platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Removed.
• platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Removed.
• platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-expected.png.
• platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
• platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png.
• platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
• platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-expected.png.
• platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
• platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png.
• platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.
• platform/qt/css3/filters/effect-reference-expected.txt:

4:29 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com

(diff)

4:26 AM Changeset in webkit [146588] by commit-queue@webkit.org

• 5 edits in trunk

Web Inspector: Report more CSS errors
​https://bugs.webkit.org/show_bug.cgi?id=113022

Patch by Sergey Ryazanov <​serya@chromium.org> on 2013-03-22
Reviewed by Pavel Feldman.

Source/WebCore:

Reporting next few CSS syntax errors in declaration_list.

• css/CSSGrammar.y.in:

LayoutTests:

• inspector/console/console-css-warnings-expected.txt:
• inspector/console/console-css-warnings.html:

4:00 AM Changeset in webkit [146587] by yurys@chromium.org

• 4 edits in trunk/Source/WebCore

Web Inspector: use individual samples to construct CPU profile flame chart
​https://bugs.webkit.org/show_bug.cgi?id=112569

Reviewed by Pavel Feldman.

Added an optional array of samples to the CPU profile returned over the
protocol. Each sample is id of the profile node corresponding to the top frame
of the sample's stack trace. The array of samples if present is used to draw
the flame chart on the CPU profile panel, otherwise flame chart is drawn based
on the aggregated profile data.

• bindings/js/ScriptProfile.cpp:

(WebCore::ScriptProfile::buildInspectorObjectForSamples):

• bindings/js/ScriptProfile.h:

(ScriptProfile):

• bindings/v8/ScriptProfile.cpp:

(WebCore::buildInspectorObjectFor):
(WebCore):
(WebCore::ScriptProfile::buildInspectorObjectForSamples):

• bindings/v8/ScriptProfile.h:

(ScriptProfile):

• bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::start):

• inspector/Inspector.json:
• inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getCPUProfile):

• inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileView.prototype._getCPUProfileCallback):
(WebInspector.CPUProfileView.prototype._buildIdToNodeMap):

• inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._calculateTimelineData):

3:34 AM Changeset in webkit [146586] by commit-queue@webkit.org

• 2 edits in trunk

Cannot run All Source (target WebProcess) on Xcode.
​https://bugs.webkit.org/show_bug.cgi?id=111042

Patch by Yuki Sekiguchi <​yuki.sekiguchi@access-company.com> on 2013-03-22
Reviewed by Alexey Proskuryakov.

WebProcessShim is renamed by r139066.
However, WebProcessShim is not renamed to SecItemShim in WebKit.xcworkspace.
This make WebProcess.app load WebProcessShim.dylib, and it cause dyld loading error.

• WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme: Renamed WebProcessShim to SecItemShim.

3:08 AM Changeset in webkit [146585] by commit-queue@webkit.org

• 14 edits
  1 move
  1 delete in trunk/Source/WebCore

Use generated bindings for the Coordinates type used by Geolocation
​https://bugs.webkit.org/show_bug.cgi?id=112975

Patch by Steve Block <​steveblock@chromium.org> on 2013-03-22
Reviewed by Kentaro Hara.

No new tests, refactoring only.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Modules/geolocation/Coordinates.cpp: Renamed from Source/WebCore/bindings/js/JSCoordinatesCustom.cpp.

(WebCore):
(WebCore::Coordinates::altitude):
(WebCore::Coordinates::altitudeAccuracy):
(WebCore::Coordinates::heading):
(WebCore::Coordinates::speed):

• Modules/geolocation/Coordinates.h:

(Coordinates):

• Modules/geolocation/Coordinates.idl:
• Target.pri:
• UseJSC.cmake:
• UseV8.cmake:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSBindingsAllInOne.cpp:
• bindings/v8/custom/V8CoordinatesCustom.cpp: Removed.

3:04 AM Changeset in webkit [146584] by commit-queue@webkit.org

• 16 edits
  12 adds in trunk

INPUT_MULTIPLE_FIELDS_UI: Incomplete datetime format should fallback to default
​https://bugs.webkit.org/show_bug.cgi?id=113005

Patch by Kunihiko Sakamoto <​ksakamoto@chromium.org> on 2013-03-22
Reviewed by Kent Tamura.

Source/WebCore:

Use fallback format when datetime format from locale is not complete.

Tests: fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html

fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format.html
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html
fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html
fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html
fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html

• html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(DateTimeFormatValidator): A helper class that parses datetime format and tests existence of fields.
(WebCore::DateTimeFormatValidator::DateTimeFormatValidator):
(WebCore::DateTimeFormatValidator::visitField):
(WebCore::DateTimeFormatValidator::validateFormat): Parses datetime format and validates by calling BaseMultipleFieldsDateAndTimeInputType::isValidFormat.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Checks if dateTimeFormat is valid, and uses fallback format if not.

• html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Declare isValidFormat.

• html/DateInputType.cpp:

(WebCore::DateInputType::isValidFormat): Added.

• html/DateInputType.h:

(DateInputType):

• html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::isValidFormat): Added.

• html/DateTimeInputType.h:

(DateTimeInputType):

• html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::isValidFormat): Added.

• html/DateTimeLocalInputType.h:

(DateTimeLocalInputType):

• html/MonthInputType.cpp:

(WebCore::MonthInputType::isValidFormat): Added.

• html/MonthInputType.h:

(MonthInputType):

• html/TimeInputType.cpp:

(WebCore::TimeInputType::isValidFormat): Added.

• html/TimeInputType.h:

(TimeInputType):

• html/WeekInputType.cpp:

(WebCore::WeekInputType::isValidFormat): Added.

• html/WeekInputType.h:

(WeekInputType):

LayoutTests:

• fast/forms/date-multiple-fields/date-multiple-fields-fallback-format-expected.txt: Added.
• fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html: Added.
• fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format-expected.txt: Added.
• fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format.html: Added.
• fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format-expected.txt: Added.
• fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html: Added.
• fast/forms/month-multiple-fields/month-multiple-fields-fallback-format-expected.txt: Added.
• fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html: Added.
• fast/forms/time-multiple-fields/time-multiple-fields-fallback-format-expected.txt: Added.
• fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html: Added.
• fast/forms/week-multiple-fields/week-multiple-fields-fallback-format-expected.txt: Added.
• fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html: Added.

2:54 AM Changeset in webkit [146583] by morrita@google.com

• 24 edits
  14 adds in trunk

Custom Elements: "readyCallback" lifecycle callback should be called.
​https://bugs.webkit.org/show_bug.cgi?id=112538

Reviewed by Elliott Sprehn.

Source/WebCore:

This change allows each custom element definition to hook up its instantiation,
namely "readyCallback" lifecycle callback.

The change has two parts:

• 1. Tracking which Element objects to be created.
• 2. Invoking appropriate JavaScript functions, which are readyCallback(), before the Element object is visible from page script.

For 1, CustomElementRegistry maintains list of "callback
invocaions". Each list item ("invocation") tracks the element
which has a lifecycle callback to be invoked. Each invocation is
registered when - Any custom element C++ object is instantiated.
See changes on CustomElementConstructor.cpp.

This also happens when @is attribute is set by the parser or node
cloning routine, which can turn a non-custom element into a
type-extended custom element. See changes on Element.cpp.

For 2, CustomElementRegistry basically follows what
MutationObserver is doing, and introduces a method called
deliverLifecycleCallbacks(). This function flushes all pending
callback invocations. You can think it as a dual of
MutationObserver::deliverAllMutations().

The delivery function is called places where MutationObserver's
deliverAllMutations() is called. In addition, it is also called
just before returning from a set of DOM APIs. For example, it is
called just before createElement() returns, so that possibly
created custom element becomes ready through its readyCallback().
Such APIs get "V8DeliverCustomElementCallbacks" IDL attribute. In
principle, APIs which can create new custom element instnaces are
marked. See CustomElementRegistry::CallbackDeliveryScope and
changes on CodeGeneratorV8.pm.

We need this extra work because the readyCallback() needs to give
an illusion so that JavaScript programmers feel like the
readyCallback() callback being called just after it is created,
instead of called on arbitrary late timing like MutationObserver
notifications.

Tests: fast/dom/custom/lifecycle-ready-createElement-recursion.html

fast/dom/custom/lifecycle-ready-createElement-reentrancy.html
fast/dom/custom/lifecycle-ready-creation-api.html
fast/dom/custom/lifecycle-ready-innerHTML.html
fast/dom/custom/lifecycle-ready-parser-only.html
fast/dom/custom/lifecycle-ready-parser-script.html
fast/dom/custom/lifecycle-ready-paste.html

• bindings/scripts/CodeGeneratorV8.pm:
• Hooked up CallbackDeliveryScope through V8DeliverCustomElementCallbacks attriute.

(GenerateCustomElementInvocationScopeIfNeeded):
(GenerateNormalAttrSetter):
(GenerateFunction):

• bindings/scripts/IDLAttributes.txt:
• bindings/v8/CustomElementHelpers.cpp:

(WebCore::CustomElementHelpers::invokeReadyCallbackIfNeeded):
(WebCore::CustomElementHelpers::invokeReadyCallbacksIfNeeded):

• bindings/v8/CustomElementHelpers.h:

(CustomElementHelpers):

• bindings/v8/V8RecursionScope.cpp: Added deliverAllLifecycleCallbacks()

(WebCore::V8RecursionScope::didLeaveScriptContext):

• dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::createElement):
(WebCore::CustomElementConstructor::createElementInternal):

• dom/CustomElementConstructor.h:

(WebCore::CustomElementConstructor::isExtended):
(CustomElementConstructor):

• dom/CustomElementRegistry.cpp: Adding element tracking and invocation execution.

(WebCore::CustomElementInvocation::CustomElementInvocation):
(WebCore::CustomElementInvocation::~CustomElementInvocation):
(WebCore::activeCustomElementRegistries):
(WebCore::CustomElementRegistry::~CustomElementRegistry):
(WebCore::CustomElementRegistry::didGiveTypeExtension):
(WebCore::CustomElementRegistry::didCreateElement):
(WebCore::CustomElementRegistry::activate):
(WebCore::CustomElementRegistry::deactivate):
(WebCore::CustomElementRegistry::deliverLifecycleCallbacks):
(WebCore::CustomElementRegistry::deliverAllLifecycleCallbacks):

• dom/CustomElementRegistry.h:

(CustomElementInvocation):
(WebCore::CustomElementInvocation::element):
(CallbackDeliveryScope):
(WebCore::CustomElementRegistry::CallbackDeliveryScope::CallbackDeliveryScope):
(WebCore::CustomElementRegistry::CallbackDeliveryScope::~CallbackDeliveryScope):
(CustomElementRegistry):
(WebCore::CustomElementRegistry::deliverAllLifecycleCallbacksIfNeeded):

• dom/Document.cpp:

(WebCore::Document::createElement):
(WebCore::Document::didCreateCustomElement):

• dom/Document.h:

(Document):

• dom/Document.idl:
• dom/Element.cpp:

(WebCore::Element::attributeChangedFromParserOrByCloning): Added to catch @is attribute
(WebCore::Element::parserSetAttributes):
(WebCore::Element::cloneAttributesFromElement):

• dom/Element.h:
• dom/Node.idl:
• dom/ShadowRoot.idl:
• html/HTMLElement.idl:
• html/parser/HTMLScriptRunner.cpp: Added deliverAllLifecycleCallbacks()

(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::runScript):

Source/WebKit/chromium:

• src/WebKit.cpp: Added deliverAllLifecycleCallbacks()

Source/WTF:

• wtf/HashSet.h:

(WTF::copyToVector): Generalized to let it accept variants like ListHahsSet instead of only HashSet.

LayoutTests:

• fast/dom/custom/lifecycle-ready-createElement-recursion-expected.txt: Added.
• fast/dom/custom/lifecycle-ready-createElement-recursion.html: Added.
• fast/dom/custom/lifecycle-ready-createElement-reentrancy-expected.txt: Added.
• fast/dom/custom/lifecycle-ready-createElement-reentrancy.html: Added.
• fast/dom/custom/lifecycle-ready-creation-api-expected.txt: Added.
• fast/dom/custom/lifecycle-ready-creation-api.html: Added.
• fast/dom/custom/lifecycle-ready-innerHTML-expected.txt: Added.
• fast/dom/custom/lifecycle-ready-innerHTML.html: Added.
• fast/dom/custom/lifecycle-ready-parser-only-expected.html: Added.
• fast/dom/custom/lifecycle-ready-parser-only.html: Added.
• fast/dom/custom/lifecycle-ready-parser-script-expected.txt: Added.
• fast/dom/custom/lifecycle-ready-parser-script.html: Added.
• fast/dom/custom/lifecycle-ready-paste-expected.txt: Added.
• fast/dom/custom/lifecycle-ready-paste.html: Added.

2:29 AM Changeset in webkit [146582] by tommyw@google.com

• 18 edits in trunk

MediaStream API: Finalize the RTCPeerConnection states
​https://bugs.webkit.org/show_bug.cgi?id=112792

Reviewed by Adam Barth.

Source/Platform:

• chromium/public/WebRTCPeerConnectionHandlerClient.h:

Source/WebCore:

This patch finalized the RTCPeerConnection state and events. These changes
have not yet pushed out to the editors draft; but they are uncontroversial
and agreed upon.

readyState will be deleted; please use the replacement signalingState which is already available.
onstatechange -> onsignalingstatechange
onicechange -> oniceconnectionstatechange
ongatheringchange will be deleted since oniceconnectionstatechange can be used for the same purpose.
RTCIceConnectionState::"starting" -> RTCIceConnectionState::"new"

Patch covered by modified tests.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::iceConnectionState):
(WebCore::RTCPeerConnection::changeSignalingState):
(WebCore::RTCPeerConnection::changeIceGatheringState):
(WebCore::RTCPeerConnection::changeIceConnectionState):

• Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

• Modules/mediastream/RTCPeerConnection.idl:
• dom/EventNames.h:

(WebCore):

• platform/mediastream/RTCPeerConnectionHandlerClient.h:

Source/WebKit/chromium:

• src/AssertMatchingEnums.cpp:

LayoutTests:

• fast/mediastream/RTCPeerConnection-datachannel.html:
• fast/mediastream/RTCPeerConnection-dtmf.html:
• fast/mediastream/RTCPeerConnection-events-expected.txt:
• fast/mediastream/RTCPeerConnection-events.html:
• fast/mediastream/RTCPeerConnection-ice.html:
• fast/mediastream/RTCPeerConnection-state-expected.txt:
• fast/mediastream/RTCPeerConnection-state.html:

2:23 AM Changeset in webkit [146581] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[EFL][WK2] View is not focused when fullscreen mode toggled
​https://bugs.webkit.org/show_bug.cgi?id=113009

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2013-03-22
Reviewed by Laszlo Gombos.

Set focus on view when fullscreen mode enabled/disabled
by FullScreen API.

• MiniBrowser/efl/main.c:

(on_fullscreen_accept):
(on_fullscreen_deny):

2:20 AM Changeset in webkit [146580] by mkwst@chromium.org

• 4 edits in trunk/Source/WebCore

Prefer 'KURL(ParsedURLString, String)' when dealing with known-good data.
​https://bugs.webkit.org/show_bug.cgi?id=112965

Reviewed by Alexey Proskuryakov.

In ​https://bugs.webkit.org/show_bug.cgi?id=112783#c6, Adam noted that
it would be possible to use 'KURL(ParsedURLString, [url])' rather than
'KURL(KURL(), [url])', since we knew that the URL in question is a
value and absolute URL. This patch fixes the obvious instances of this
pattern; there are several more 'KURL(KURL(), String)' calls in
WebCore but these were the only places I was reasonably sure that bad
data couldn't creep in.

• dom/Document.cpp:

(WebCore::Document::updateBaseURL):

'documentURI' is pulled from 'url()->string()'. It's safe.

• page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):

'CallFrame::sourceURL()' is a known valid/absolute URL.

• page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
(WebCore::SecurityOrigin::create):

The strings constructed here are certainly valid.

2:17 AM Changeset in webkit [146579] by kadam@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip a now passing test after r146393.
​https://bugs.webkit.org/show_bug.cgi?id=112904.

• platform/qt/TestExpectations:

2:09 AM Changeset in webkit [146578] by commit-queue@webkit.org

• 3 edits
  1 add in trunk/LayoutTests

[EFL] New baseline for accessibility/platform-name.html
​https://bugs.webkit.org/show_bug.cgi?id=113018

Unreviewed EFL gardening

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-03-22

• platform/efl-wk1/TestExpectations:
• platform/efl-wk2/TestExpectations:
• platform/efl/accessibility/platform-name-expected.txt: Added.

2:00 AM Changeset in webkit [146577] by loislo@chromium.org

• 4 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. move overview window when user scrolls the chart.
​https://bugs.webkit.org/show_bug.cgi?id=113014

Reviewed by Yury Semikhatsky.

I found that I could use scaling mechanics in OverviewGrid for scaling the chart.
But the dragging part was not so simple due to the different approaches in
OverviewGrid and FlameChart. OverviewGrid used _windowLeft and _windowRight
when FlameChart used _xOffset and _xScaleFactor and width.
It was not practical and I rewrote the FlameChart mechanics
and now it also uses _windowLeft _windowRight.

• inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.Calculator.prototype._updateBoundaries):
(WebInspector.FlameChart.Calculator.prototype.computePosition):
(WebInspector.FlameChart.prototype._onWindowChanged):
(WebInspector.FlameChart.prototype._startCanvasDragging):
(WebInspector.FlameChart.prototype._canvasDragging):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._onMouseWheel):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):
(WebInspector.FlameChart.prototype._drawOverviewCanvas):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._updateBoundaries):
(WebInspector.FlameChart.prototype.update):

• inspector/front-end/OverviewGrid.js:

(WebInspector.OverviewGrid.prototype.setWindowPosition):
(WebInspector.OverviewGrid.prototype.setWindow):
(WebInspector.OverviewGrid.prototype.addEventListener):
(WebInspector.OverviewGrid.prototype.zoom):
(WebInspector.OverviewGrid.Window.prototype._zoom):

• inspector/front-end/inspectorCommon.css:

(.overview-grid-window-rulers):

1:56 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

1:52 AM Changeset in webkit [146576] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.0/Tools

Merge r146504 - [GTK] generate-feature-defines-files is incompatible with Python3
​https://bugs.webkit.org/show_bug.cgi?id=112956

Reviewed by Martin Robinson.

Make the generate-feature-defines-files compatible with Python3 by calling the items()
method on the dictionary objects when iterating through said dictionaries.

• gtk/generate-feature-defines-files:

(write_feature_defines_header):
(write_flattened_feature_defines_file):

1:38 AM Changeset in webkit [146575] by commit-queue@webkit.org

• 6 edits
  1 move in trunk/Source/WebCore

Move GeolocationClient.h to Modules/geolocation/
​https://bugs.webkit.org/show_bug.cgi?id=112997

Patch by Steve Block <​steveblock@chromium.org> on 2013-03-22
Reviewed by Kentaro Hara.

No new tests, no functional change.

• GNUmakefile.list.am:
• Modules/geolocation/GeolocationClient.h: Renamed from Source/WebCore/page/GeolocationClient.h.

(WebCore):
(GeolocationClient):
(WebCore::GeolocationClient::~GeolocationClient):

• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:

1:29 AM Changeset in webkit [146574] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Add a flaky crash test expectations on Mac WebKit2 per bug 113020.

• platform/mac-wk2/TestExpectations:

1:24 AM Changeset in webkit [146573] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Skipping fast/dom/custom tests as the custom elements support is not yet enabled

on the GTK port. Adding crashing expectations for two IDB tests that regressed with r146540.

1:12 AM Changeset in webkit [146572] by commit-queue@webkit.org

• 35 edits
  14 deletes in trunk

Unreviewed, rolling out r146534 and r146565.
​http://trac.webkit.org/changeset/146534
​http://trac.webkit.org/changeset/146565
​https://bugs.webkit.org/show_bug.cgi?id=113017

"r146534 caused perf regression on Chromium Linux x64"
(Requested by yurys on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-22

Source/WebCore:

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):
(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateParametersCheck):
(GenerateSingleConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateFunctionCallString):

• bindings/scripts/IDLAttributes.txt:
• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore):

• bindings/v8/CustomElementHelpers.cpp:
• bindings/v8/CustomElementHelpers.h:

(WebCore):
(CustomElementHelpers):

• bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):

• bindings/v8/V8DOMConfiguration.h:

(BatchedMethod):
(V8DOMConfiguration):

• bindings/v8/V8RecursionScope.cpp:

(WebCore::V8RecursionScope::didLeaveScriptContext):

• dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::createElement):

• dom/CustomElementConstructor.h:

(CustomElementConstructor):

• dom/CustomElementRegistry.cpp:

(WebCore::CustomElementRegistry::~CustomElementRegistry):

• dom/CustomElementRegistry.h:

(WebCore):
(CustomElementRegistry):

• dom/Document.cpp:

(WebCore::Document::createElement):
(WebCore::Document::registerElement):

• dom/Document.h:
• dom/Document.idl:
• dom/Element.cpp:

(WebCore::Element::parserSetAttributes):
(WebCore::Element::cloneAttributesFromElement):

• dom/Element.h:
• dom/Element.idl:
• dom/Node.idl:
• dom/ShadowRoot.idl:
• html/HTMLElement.idl:
• html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::runScript):

Source/WebKit/chromium:

• src/WebKit.cpp:

Source/WTF:

• wtf/HashSet.h:

(WTF):
(WTF::copyToVector):

LayoutTests:

• fast/dom/custom/lifecycle-ready-createElement-recursion-expected.txt: Removed.
• fast/dom/custom/lifecycle-ready-createElement-recursion.html: Removed.
• fast/dom/custom/lifecycle-ready-createElement-reentrancy-expected.txt: Removed.
• fast/dom/custom/lifecycle-ready-createElement-reentrancy.html: Removed.
• fast/dom/custom/lifecycle-ready-creation-api-expected.txt: Removed.
• fast/dom/custom/lifecycle-ready-creation-api.html: Removed.
• fast/dom/custom/lifecycle-ready-innerHTML-expected.txt: Removed.
• fast/dom/custom/lifecycle-ready-innerHTML.html: Removed.
• fast/dom/custom/lifecycle-ready-parser-only-expected.html: Removed.
• fast/dom/custom/lifecycle-ready-parser-only.html: Removed.
• fast/dom/custom/lifecycle-ready-parser-script-expected.txt: Removed.
• fast/dom/custom/lifecycle-ready-parser-script.html: Removed.
• fast/dom/custom/lifecycle-ready-paste-expected.txt: Removed.
• fast/dom/custom/lifecycle-ready-paste.html: Removed.

1:07 AM Changeset in webkit [146571] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer] Memory leak in AudioFileReader::createBus()
​https://bugs.webkit.org/show_bug.cgi?id=112925

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2013-03-22
Reviewed by Martin Robinson.

Adopt the reference returned by g_timeout_source_new()
to fix a memory leak.

No new tests. No change in behavior.

• platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

12:52 AM Changeset in webkit [146570] by commit-queue@webkit.org

• 11 edits
  2 moves in trunk/Source/WebCore

Move page/Coordinates.[h|idl] to Modules/geolocation/
​https://bugs.webkit.org/show_bug.cgi?id=112945

Patch by Steve Block <​steveblock@chromium.org> on 2013-03-22
Reviewed by Kentaro Hara.

No new tests, no functional change.

• CMakeLists.txt:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.list.am:
• Modules/geolocation/Coordinates.h: Renamed from Source/WebCore/page/Coordinates.h.

(WebCore):
(Coordinates):
(WebCore::Coordinates::create):
(WebCore::Coordinates::isolatedCopy):
(WebCore::Coordinates::latitude):
(WebCore::Coordinates::longitude):
(WebCore::Coordinates::altitude):
(WebCore::Coordinates::accuracy):
(WebCore::Coordinates::altitudeAccuracy):
(WebCore::Coordinates::heading):
(WebCore::Coordinates::speed):
(WebCore::Coordinates::canProvideAltitude):
(WebCore::Coordinates::canProvideAltitudeAccuracy):
(WebCore::Coordinates::canProvideHeading):
(WebCore::Coordinates::canProvideSpeed):
(WebCore::Coordinates::Coordinates):

• Modules/geolocation/Coordinates.idl: Renamed from Source/WebCore/page/Coordinates.idl.
• Target.pri:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:

12:41 AM Changeset in webkit [146569] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Add a flaky test failure expectation per bug 113012.

• platform/win/TestExpectations:

12:36 AM Changeset in webkit [146568] by rniwa@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Leak bots erroneously report JSC::WatchpointSet as leaking
​https://bugs.webkit.org/show_bug.cgi?id=107781

Reviewed by Filip Pizlo.

Since leaks doesn't support tagged pointers, avoid using it by flipping the bit flag to indicate
the entry is "fat". We set the flag when the entry is NOT fat; i.e. slim.

Replaced FatFlag by SlimFlag and initialized m_bits with this flag to indicate that the entry is
initially "slim".

• runtime/SymbolTable.cpp:

(JSC::SymbolTableEntry::copySlow): Don't set FatFlag since it has been replaced by SlimFlag.
(JSC::SymbolTableEntry::inflateSlow): Ditto.

• runtime/SymbolTable.h:

(JSC::SymbolTableEntry::Fast::Fast): Set SlimFlag by default.
(JSC::SymbolTableEntry::Fast::isNull): Ignore SlimFlag.
(JSC::SymbolTableEntry::Fast::isFat): An entry is fat when m_bits is not entirely zero and SlimFlag
is not set.

(JSC::SymbolTableEntry::SymbolTableEntry): Set SlimFlag by default.
(JSC::SymbolTableEntry::SymbolTableEntry::getFast): Set SlimFlag when creating Fast from a fat entry.
(JSC::SymbolTableEntry::isNull): Ignore SlimFlag.
(JSC::SymbolTableEntry::FatEntry::FatEntry): Strip SlimFlag.
(JSC::SymbolTableEntry::isFat): An entry is fat when m_bits is not entirely zero and SlimFlag is unset.
(JSC::SymbolTableEntry::fatEntry): Don't strip FatFlag as this flag doesn't exist anymore.
(JSC::SymbolTableEntry::pack): Preserve SlimFlag.

(JSC::SymbolTableIndexHashTraits): empty value is no longer zero so don't set emptyValueIsZero true.

12:25 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

12:19 AM Changeset in webkit [146567] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Final Mac rebaseline attempt for r146531 since r146564 wasn't enough.

I'm sorry I made a huge mess here.

• platform/mac/compositing/rtl/rtl-fixed-expected.txt:

12:09 AM Changeset in webkit [146566] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[chromium] Mark virtual/gpu/fast/canvas/canvas-toDataURL-webp.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=93310

Unreviewed test expectations update.

libwebp will be updated to 0.3.0 in chrome changing the encoder
output after which this test will need to be rebaselined.

Patch by James Zern <​jzern@chromium.org> on 2013-03-22

• platform/chromium/TestExpectations: