⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 25, 2013:

11:39 PM Changeset in webkit [146853] by morrita@google.com
  • 6 edits
    2 adds in trunk

Listening touch events on ShadowRoot can crash.
https://bugs.webkit.org/show_bug.cgi?id=113035

Reviewed by Kentaro Hara.

Source/WebCore:

TreeScope destructor clears a document reference on ShadowRoot but
destructors of ContainerNode and Node assumed it being available
and tried to access it for some cleanup purposes.

This change extracts such cleanup to Node::willBeDeletedFrom() and
calls it from ShadowRoot dtor before the document reference gets cleared.

Test: fast/dom/shadow/shadow-root-touch-listener-crash.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::~ContainerNode): Adopted willBeDeletedFrom()

  • dom/Node.cpp:

(WebCore::Node::~Node): Adopted willBeDeletedFrom()
(WebCore::Node::willBeDeletedFrom): Extracted from Node and ContainerNode
(WebCore):

  • dom/Node.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot): Adopted willBeDeletedFrom()

LayoutTests:

  • fast/dom/shadow/shadow-root-touch-listener-crash-expected.txt: Added.
  • fast/dom/shadow/shadow-root-touch-listener-crash.html: Added.
11:35 PM Changeset in webkit [146852] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Remove Lion leaks builder
https://bugs.webkit.org/show_bug.cgi?id=113252

Reviewed by Andreas Kling.

Removed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
11:35 PM Changeset in webkit [146851] by morrita@google.com
  • 6 edits
    2 deletes in trunk/Source/WebCore

Custom Elements Refactoring: The name V8CustomElement is confusing.
https://bugs.webkit.org/show_bug.cgi?id=113165

Reviewed by Kent Tamura.

This change moves functions from V8CustomElement to CustomElementHelpers and
removes V8CustomElement. V8CustomElement is just a heritage of old design
and no longer makes sense.

No new tests. No behavior change.

  • WebCore.gypi:
  • bindings/v8/CustomElementHelpers.cpp:

(WebCore::CustomElementHelpers::createWrapper):
(WebCore):

  • bindings/v8/CustomElementHelpers.h:

(CustomElementHelpers):
(WebCore::CustomElementHelpers::wrap):
(WebCore):
(WebCore::CustomElementHelpers::constructorOf):

  • bindings/v8/V8CustomElement.cpp: Removed.
  • bindings/v8/V8CustomElement.h: Removed.
  • bindings/v8/custom/V8CustomElementConstructorCustom.cpp:

(WebCore::V8CustomElementConstructor::callAsFunctionCallback):

  • dom/make_names.pl:

(printWrapperFactoryCppFile):

11:07 PM Changeset in webkit [146850] by jamesr@google.com
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

Update a few more chromium compositor baselines.

  • platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Removed.
9:51 PM Changeset in webkit [146849] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Timeline] Records sidebar is clipped.
https://bugs.webkit.org/show_bug.cgi?id=113177

Reviewed by Pavel Feldman.

Analysis: depending on CSS injection order sidebar rule that overwrites
"bottom" property may win.

Fix: make timeline-specific rule "important".

  • inspector/front-end/timelinePanel.css:

(.timeline .sidebar): Make "bottom" value "important".

9:04 PM Changeset in webkit [146848] by noel.gordon@gmail.com
  • 4 edits in trunk/LayoutTests

[chromium] Rebaseline canvas-toDataURL-webp test expectations
https://bugs.webkit.org/show_bug.cgi?id=93310

Unreviewed test expectations update.

  • platform/chromium-mac/fast/canvas/canvas-toDataURL-webp-expected.png:
  • platform/chromium-win/fast/canvas/canvas-toDataURL-webp-expected.png:
  • platform/chromium/TestExpectations:
8:28 PM Changeset in webkit [146847] by tkent@chromium.org
  • 35 edits in trunk

Rename ENABLE_INPUT_TYPE_DATETIME
https://bugs.webkit.org/show_bug.cgi?id=113254

Reviewed by Kentaro Hara.

Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
Actually I'd like to remove the code, but we shouldn't remove it yet
because we shipped products with it on some platforms.

.:

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

  • css/html.css:
  • html/DateTimeInputType.cpp:
  • html/DateTimeInputType.h:
  • html/InputType.cpp:

(WebCore::createInputTypeFactoryMap):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableInputTypeDateTime):
(WebKit::WebRuntimeFeatures::isInputTypeDateTimeEnabled):

  • tests/WebViewTest.cpp:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.props:
  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.props:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • platform/chromium/TestExpectations:
8:19 PM Changeset in webkit [146846] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

REGRESSION(r146657): NRWT shouldn't report image only failures when pixel tests are disabled
https://bugs.webkit.org/show_bug.cgi?id=113261

Reviewed by Dirk Pranke.

Fixed the bug by treating ['TEXT', 'IMAGE'] as a flaky pass when the pixel tests is disabled
since the second token implies that we've forced pixel tests in retry and didn't have text failures.

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
  • fast/harness/results-expected.txt:
8:13 PM Changeset in webkit [146845] by mary.wu@torchmobile.com.cn
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] add needReferer in WebPage load() api
https://bugs.webkit.org/show_bug.cgi?id=113167

Reviewed by Rob Buis.

PR310175, internally reviewed by Joe Mason.
Sometimes when client load request, it need to add referer with current frame like
save link/image in option menu, so we add needRef in load() interface in webpage.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPage::load):
(BlackBerry::WebKit::WebPage::loadExtended):
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::download):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

8:11 PM Changeset in webkit [146844] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update Efl test expectations to mark new test as failing.
Efl doesn't implement the Pasteboard class.

  • platform/efl/TestExpectations: Mark editing/pasteboard/copy-image-with-alt-text.html as failing
8:02 PM Changeset in webkit [146843] by danakj@chromium.org
  • 7 edits
    1 delete in trunk/Source

[chromium] Move ownership of compositor VideoLayer to WebMediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=112971

Reviewed by James Robinson.

Source/Platform:

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

  • chromium/public/WebVideoFrame.h:
  • chromium/public/WebVideoFrameProvider.h:

Source/WebKit/chromium:

This moves ownership of the compositor's video layer over to the
implementation of WebMediaPlayer, as well as all interaction
between the media player system and the compositor layer or its
interfaces such as cc::VideoFrameProvider.

Now, the WebMediaPlayer implementation calls setWebLayer() to
provide the WebLayer* to the WebMediaPlayerClientImpl so that
it can be inserted into the GraphicsLayer tree appropriately.

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

Once chromium removes its use of WebVideoFrame and its related
classes, we can remove them from WebKit entirely.

  • WebKit.gypi:
  • public/WebMediaPlayer.h:

(WebKit):

  • public/WebMediaPlayerClient.h:
  • public/WebStreamTextureClient.h:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::setWebLayer):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):
(WebKit::WebMediaPlayerClientImpl::needsWebLayer):
(WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::create):
(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebKit):
(WebMediaPlayerClientImpl):

  • tests/WebMediaPlayerClientImplTest.cpp: Removed.
7:51 PM Changeset in webkit [146842] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r190515. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25

  • DEPS:
7:43 PM Changeset in webkit [146841] by jamesr@google.com
  • 20 edits
    3 copies
    1 add
    10 deletes in trunk/LayoutTests

Update more expectations and baselines for r146826

  • platform/chromium-linux-x86/compositing/iframes/scrolling-iframe-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/iframes/scrolling-iframe-expected.txt.
  • platform/chromium-linux/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/chromium-mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
  • platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Removed.
  • platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Removed.
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt: Removed.
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Removed.
  • platform/chromium-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
  • platform/chromium-win/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
  • platform/chromium-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/backing/no-backing-for-clip-expected.txt: Removed.
  • platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt: Removed.
  • platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt: Removed.
  • platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
  • platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/chromium/compositing/iframes/iframe-resize-expected.txt:
  • platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
  • platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/chromium/compositing/iframes/resizer-expected.txt:
  • platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
7:35 PM Changeset in webkit [146840] by timothy@apple.com
  • 9 edits
    5 adds in trunk

Make the Web Inspector console work in strict mode with JavaScriptCore.

https://webkit.org/b/65829
rdar://problem/11271238

Reviewed by Oliver Hunt.

Source/WebCore:

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::evaluate):
Return the evalFunction directly.

  • inspector/InjectedScriptHost.h:

(WebCore::InjectedScriptHost::evaluateReturnsEvalFunction):
Added. Return true on JSC and false on V8.

  • inspector/InjectedScriptHost.idl:

Added evaluateReturnsEvalFunction and change evaluate to an attribute on JSC.

  • inspector/InjectedScriptSource.js:

(InjectedScript.prototype._evaluateOn): Change from using 'with' statements to creating
a closure that evaluates the expression. The command line APIs are passed as parameters
to the closure so they are in scope but not injected. This allows the code evaluated in
the console to stay in strict mode (if is was already set), or to get strict mode by
prefixing expressions with 'use strict';.

LayoutTests:

  • inspector/debugger/mutation-observer-suspend-while-paused.html: Tweaked.
  • inspector/console/command-line-api-expected.txt: Updated.
  • platform/mac/http/tests/inspector/console-resource-errors-expected.txt: Added.
  • platform/mac/http/tests/inspector/console-websocket-error-expected.txt: Updated.
  • platform/mac/inspector/console/console-eval-syntax-error-expected.txt: Added.
  • platform/mac/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Added.
  • platform/mac/inspector/extensions/extensions-eval-expected.txt: Added.

Added new expectations to match the new console evaluate approach.

7:14 PM Changeset in webkit [146839] by jamesr@google.com
  • 3 edits
    4 copies
    2 moves
    5 adds
    10 deletes in trunk/LayoutTests

Update chromium baselines for windows related to r146826

  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-linux/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-linux/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-mac-lion/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
  • platform/chromium-mac/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-mac/compositing/geometry/preserve-3d-switching-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-win-xp/compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
  • platform/chromium-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
  • platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Removed.
  • platform/chromium/compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/geometry/object-clip-rects-assertion-expected.txt.
7:02 PM Changeset in webkit [146838] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Remove one more line that was intended to be removed in r146657.

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

6:44 PM Changeset in webkit [146837] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r146816, r146821, and r146830.
http://trac.webkit.org/changeset/146816
http://trac.webkit.org/changeset/146821
http://trac.webkit.org/changeset/146830
https://bugs.webkit.org/show_bug.cgi?id=113262

Broke all the Windows tests (Requested by rfong on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

  • platform/win/TestExpectations:
6:36 PM Changeset in webkit [146836] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

Revert bad change to expectation from r146826

  • compositing/geometry/object-clip-rects-assertion-expected.txt:
6:33 PM Changeset in webkit [146835] by tony@chromium.org
  • 25 edits
    2 adds in trunk

Image alt text not included in plain-text version when copying
https://bugs.webkit.org/show_bug.cgi?id=11200

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add a setting to enable copying image alt text to the clipboard and drag and drop pasteboard.
This setting is disabled by default, so each port can enable if they want to match IE10 and
Firefox's behavior.

Test: editing/pasteboard/copy-image-with-alt-text.html

  • editing/Editor.cpp:

(WebCore::Editor::cut): Explicitly ask that the selection on the pasteboard as being for the clipboard.
(WebCore::Editor::copy): Explicitly ask that the selection on the pasteboard as being for the clipboard.
(WebCore::Editor::selectedText): Add a private version of selectedText() that can choose between having image alt text or not.
(WebCore::Editor::selectedTextForClipboard): Ask for image alt text if the setting is enabled.

  • editing/Editor.h:
  • editing/TextIterator.cpp:

(WebCore::TextIterator::TextIterator): Add a bool to keep track of whether or not to emit image alt text.
(WebCore::TextIterator::handleReplacedElement): If there's alt text, point the iterator to it.

  • editing/TextIterator.h:

(TextIterator):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::takeFindStringFromSelection): Use the same text as on the clipboard.
(WebCore::Editor::writeSelectionToPasteboard): Don't include image alt text since this is
used by Services.
(WebCore::Editor::stringSelectionForPasteboard): Don't include image alt text since this is
used by Services.

  • page/DragController.cpp:

(WebCore::DragController::startDrag): Use image alt text (matches Firefox).

  • page/Settings.in: Add a setting that disables image alt text by default.
  • platform/Pasteboard.h:
  • platform/blackberry/PasteboardBlackBerry.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::writeRange): Use clipboard text when writing ranges (used by d&d).

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • platform/efl/PasteboardEfl.cpp:

(WebCore::Pasteboard::writeSelection): Update function param.

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::writeRange): Use clipboard text when writing ranges (used by d&d).

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::writeRange): Use clipboard text when writing ranges (used by d&d).

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::getStringSelection): Use ShouldSerializeSelectedTextForClipboard to determine whether the selected
text is for the clipboard or not.
(WebCore::Pasteboard::writeSelectionForTypes): Pass ShouldSerializeSelectedTextForClipboard through.
(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::writeRange): Use clipboard text when writing ranges (used by d&d).

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::writeRange): Use clipboard text when writing ranges (used by d&d).

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • platform/wince/PasteboardWinCE.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • platform/wx/PasteboardWx.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • rendering/RenderImage.h:

(WebCore::RenderImage::altText): Add a getter for the alt text.

LayoutTests:

  • editing/pasteboard/copy-image-with-alt-text-expected.txt: Added.
  • editing/pasteboard/copy-image-with-alt-text.html: Added.
6:23 PM Changeset in webkit [146834] by jamesr@google.com
  • 3 edits
    9 moves
    13 adds
    2 deletes in trunk/LayoutTests

Update chromium mac 10.6 and 10.8 baselines for r146826.

  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-mac-lion/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-mac/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css3/filters/filtered-compositing-descendant-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/compositing/geometry/composited-in-columns-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/preserve-3d-switching-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/layer-creation/scroll-partial-update-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt.
  • platform/chromium-win/compositing/geometry/composited-in-columns-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/geometry/composited-in-columns-expected.txt.
  • platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Renamed from LayoutTests/platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt.
6:02 PM Changeset in webkit [146833] by dino@apple.com
  • 10 edits
    2 deletes in trunk/Source/WebCore

Remove autostart hashing code from WebCore
https://bugs.webkit.org/show_bug.cgi?id=113242

Reviewed by Tim Horton.

Remove PlugInOriginHash and all the related build entries.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLPlugInImageElement.cpp:
  • plugins/PlugInOriginHash.cpp: Removed.
  • plugins/PlugInOriginHash.h: Removed.
5:40 PM Changeset in webkit [146832] by pkasting@chromium.org
  • 7 edits
    7 adds in trunk/LayoutTests

[chromium] Rebaselining, etc.
https://bugs.webkit.org/show_bug.cgi?id=109507
https://bugs.webkit.org/show_bug.cgi?id=112927

Unreviewed, test expectations update.

  • platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Added.
  • platform/chromium-mac-lion/css3/filters/effect-reference-hw-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-reference-hw-expected.txt: Added.
  • platform/chromium-mac/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
  • platform/chromium-mac/css3/filters/effect-reference-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-expected.txt:
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Added.
  • platform/chromium-win-xp/fast/text/international/bold-bengali-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/bold-bengali-expected.txt: Added.
  • platform/chromium/TestExpectations:
5:36 PM Changeset in webkit [146831] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Offlineasm cloop backend compiles op+branch incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=113146.

Reviewed by Geoffrey Garen.

  • dfg/DFGRepatch.h:

(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

  • These functions never return when the DFG is dsiabled, not just when asserts are enabled. Changing the attribute from NO_RETURN_DUE_TO_ASSERT to NO_RETURN.
  • llint/LLIntOfflineAsmConfig.h:
  • Added some #defines needed to get the cloop building again.
  • offlineasm/cloop.rb:
  • Fix cloopEmitOpAndBranchIfOverflow() and cloopEmitOpAndBranch() to emit code that unconditionally executes the specified operation before doing the conditional branch.
5:27 PM Changeset in webkit [146830] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Wrong place to enable RuntimeEnabledFeature for Windows.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

5:14 PM Changeset in webkit [146829] by mhahnenberg@apple.com
  • 3 edits
    3 adds in trunk

JSObject::enterDictionaryIndexingMode doesn't have a case for ALL_BLANK_INDEXING_TYPES
https://bugs.webkit.org/show_bug.cgi?id=113236

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::enterDictionaryIndexingMode): We forgot blank indexing types.

LayoutTests:

New test case that tests calling Object.freeze on Array.prototype.

  • fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type-expected.txt: Added.
  • fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type.html: Added.
  • fast/js/script-tests/enter-dictionary-indexing-mode-with-blank-indexing-type.js: Added.
5:11 PM Changeset in webkit [146828] by jamesr@google.com
  • 7 edits
    1 move
    29 adds
    5 deletes in trunk/LayoutTests

Update chromium baselines for r146826

  • platform/chromium-linux-x86/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-linux-x86/css3/filters/filtered-compositing-descendant-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-linux/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/chromium-linux/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-linux/css3/filters/filtered-compositing-descendant-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-mac-lion/compositing/geometry/composited-in-columns-expected.txt: Added.
  • platform/chromium-mac-lion/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-mac-lion/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
  • platform/chromium-mac-lion/css3/filters/filtered-compositing-descendant-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/preserve-3d-switching-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/layer-creation/scroll-partial-update-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
4:46 PM Changeset in webkit [146827] by roger_fong@apple.com
  • 3 edits in trunk/Tools

No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
Re-enable WinEWS tests.

  • Scripts/webkitpy/common/config/ports.py:

(WinPort.run_bindings_tests_command):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

4:34 PM Changeset in webkit [146826] by jamesr@google.com
  • 128 edits
    11 deletes in trunk

[chromium] Support GraphicsLayer::setContentsToSolidColor
https://bugs.webkit.org/show_bug.cgi?id=104396

Reviewed by Adrienne Walker.

Source/WebCore:

This enables and implements the GraphicsLayer::setContentsToSolidColor
path for Chromium.

Tested by reftests in compositing/background-color/ and several other
compositing/ tests.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::supportsBackgroundColorContent):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToSolidColor):
(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebKit):
(GraphicsLayerChromium):

Source/WebKit/chromium:

Updates some unit tests for better include discipline.

  • tests/GraphicsLayerChromiumTest.cpp:
  • tests/ImageLayerChromiumTest.cpp:
4:30 PM Changeset in webkit [146825] by vcarbune@chromium.org
  • 8 edits
    3 copies
    2 adds in trunk

TextTrack Extension for WebVTT Regions
https://bugs.webkit.org/show_bug.cgi?id=109820

Reviewed by Eric Carlson.

Source/WebCore:

Implemented the TextTrackRegionList and extended TextTrack with
methods required for proper interaction with TextTrackRegion objects.

Test: media/track/regions-webvtt/text-track-region-list.html

  • WebCore.gypi: Added files for proper building of TextTrackRegionList.
  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore):
(WebCore::TextTrack::ensureTextTrackRegionList): Method for creating a
TextTrackRegionList associated with the current track, if it does exist
already.
(WebCore::TextTrack::regions): Getter for the regions object.
(WebCore::TextTrack::addRegion): Method for adding a region.
(WebCore::TextTrack::removeRegion): Method for removing a region.

  • html/track/TextTrack.h:

(WebCore):
(TextTrack):

  • html/track/TextTrack.idl: Added methods specific for region handling.
  • html/track/TextTrackRegion.cpp:

(WebCore::TextTrackRegion::TextTrackRegion): Initialized the track member variable.
(WebCore::TextTrackRegion::setTrack): Added internal setter for the track attribute.
(WebCore):
(WebCore::TextTrackRegion::updateParametersFromRegion): Method to copy the parameters
from a different region object.

  • html/track/TextTrackRegion.h: Added track member variable and copy method.

(WebCore::TextTrackRegion::track): Getter retrieves now the member variable.
(TextTrackRegion):

  • html/track/TextTrackRegionList.cpp: Implemented methods required by the IDL.

(WebCore):
(WebCore::TextTrackRegionList::TextTrackRegionList):
(WebCore::TextTrackRegionList::length):
(WebCore::TextTrackRegionList::item):
(WebCore::TextTrackRegionList::getRegionById):
(WebCore::TextTrackRegionList::add):
(WebCore::TextTrackRegionList::remove):
(WebCore::TextTrackRegionList::clear):

  • html/track/TextTrackRegionList.h:

(WebCore):
(TextTrackRegionList):
(WebCore::TextTrackRegionList::create):
(WebCore::TextTrackRegionList::~TextTrackRegionList):

  • html/track/TextTrackRegionList.idl: IDL defined by the specification.

LayoutTests:

  • media/track/regions-webvtt/text-track-region-list-expected.txt: Added.
  • media/track/regions-webvtt/text-track-region-list.html: Added.
4:29 PM Changeset in webkit [146824] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source

Unreviewed, rolling out r146819.
http://trac.webkit.org/changeset/146819
https://bugs.webkit.org/show_bug.cgi?id=113249

broke component build (Requested by danakj on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25

Source/Platform:

  • chromium/public/WebVideoFrame.h:

Source/WebKit/chromium:

  • WebKit.gypi:
  • public/WebMediaPlayerClient.h:

(WebKit):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::disableAcceleratedCompositing):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):
(WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::create):
(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebKit):
(WebMediaPlayerClientImpl):

  • tests/WebMediaPlayerClientImplTest.cpp: Added.

(WebKit):
(FakeWebMediaPlayerClientImpl):
(WebKit::FakeWebMediaPlayerClientImpl::create):
(WebKit::FakeWebMediaPlayerClientImpl::FakeWebMediaPlayerClientImpl):
(FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::create):
(WebKit::FakeVideoFrameProviderClient::~FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::didReceiveFrame):
(WebKit::FakeVideoFrameProviderClient::didUpdateMatrix):
(WebKit::FakeVideoFrameProviderClient::stopUsingProvider):
(WebKit::FakeVideoFrameProviderClient::provider):
(WebKit::FakeVideoFrameProviderClient::FakeVideoFrameProviderClient):
(WebKit::TEST):

4:27 PM Changeset in webkit [146823] by dino@apple.com
  • 20 edits in trunk/Source

Cleanup plugin snapshotting autostart decision making
https://bugs.webkit.org/show_bug.cgi?id=113231

Reviewed by Tim Horton.

Source/WebCore:

Move the code that creates a hash of plugin origin info
out of WebCore. All WebCore needs to do now is simply ask its
host layer whether or not a tuple of (pluginOrigin, pageOrigin, mimeType)
should autostart or not.

As a drive-by, the code in subframeLoaderWillCreatePlugIn was not quite
restarting properly when the displayState was Restarting or
RestartingWithPendingMouseClick. It still worked most of the time, but usually
because the code ran soon after a mouse click. Now it should be explicit and
also allowed us to be more clear about snapshotting at the end of the method.

  • html/HTMLPlugInElement.h: No more pluginOriginHash().
  • html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Change signature to accept the tuple

described above, and compare strings rather than hashes.

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Tell host layer the origin

info rather than hash info.

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Remember the url that

the plugin was loaded from. Make some of the logging messages more clear. Test for
plugin and page origin rather than hash.

  • html/HTMLPlugInImageElement.h:

(WebCore::HTMLPlugInImageElement::loadedUrl): New loadedURL member function.

  • page/PlugInClient.h:

(PlugInClient): Change signature of virtual class to accept origin and mimeType info

rather than hash.

Source/WebKit2:

Two major changes to the way snapshotting plugins may autostart.

The first is that previously WebCore was keeping a hash that
represented the combination of page origin, plugin origin and
mime type. WebKit was responsible for deciding if that particular
hash should autostart. Now, WebKit keeps the hash, and WebCore
just asks us whether the combination of origins and mimetype
should start immediately. You can see this change the in WebPluginClient
and WebProcess APIs.

The second change is that we now keep two types of structures
around to decide whether a plugin should autostart. One is the
existing page + plugin origin combination. The other is simply
the plugin origin, which allows plugins from major providers
to autostart no matter what page they were embedded on.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Encode the new parameter.
(WebKit::WebProcessCreationParameters::decode): Decode the new parameter.

  • Shared/WebProcessCreationParameters.h: Also keep a list of strings around.
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetPlugInAutoStartOrigins): The C API to send the list of plugin

origins over to the context.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/Plugins/PlugInAutoStartProvider.cpp:

(WebKit::PlugInAutoStartProvider::addAutoStartOriginHash): Renamed from addAutoStartOrigin.

No functional change other than new names for members.

(WebKit::PlugInAutoStartProvider::autoStartOriginHashesCopy): Ditto.
(WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy): Ditto.
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsTable): Ditto.
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsArray): New method that converts the

incoming ImmutableArray into a Vector of Strings.

(WebKit::PlugInAutoStartProvider::didReceiveUserInteraction): Rename for new members.

  • UIProcess/Plugins/PlugInAutoStartProvider.h: Renaming member variables. Adding

some typedefs to clean up code.

(WebKit::PlugInAutoStartProvider::autoStartOrigins): New accessor.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess): Renaming, and copy the new parameter into the process creation.
(WebKit::WebContext::addPlugInAutoStartOriginHash): Renaming.
(WebKit::WebContext::setPlugInAutoStartOriginHashes): Renaming.
(WebKit::WebContext::setPlugInAutoStartOrigins): New method.

  • UIProcess/WebContext.h: Adds the new setPlugInAutoStartOrigin method.
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::didInitializePlugin): Drive-by fix that was attempting to restart plugins

that were in the process of restarting.

(WebKit::PluginView::pluginDidReceiveUserInteraction): Temporarily suspend update of

expiration time if the user interacts with a plugin.

  • WebProcess/WebCoreSupport/WebPlugInClient.cpp:

(WebKit::WebPlugInClient::shouldAutoStartFromOrigin): Renaming.
(WebKit::WebPlugInClient::didStartFromOrigin): Ditto.

  • WebProcess/WebCoreSupport/WebPlugInClient.h: Renaming.
  • WebProcess/WebProcess.cpp: Drive-by - noticed that we forgot to count seconds in

a timeout threshold.

(WebKit::WebProcess::initializeWebProcess): Also add the list of origins when we initialize.
(WebKit::addCaseFoldedCharacters): Copied from WebCore - adds a String to a hash input.
(WebKit::hashForPlugInOrigin): Copied from WebCore - hashing function.
(WebKit::WebProcess::isPlugInAutoStartOriginHash): Renaming.
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin): Check the list of pure origins first. If

that fails, fall back to the hash list of pairs.

(WebKit::WebProcess::plugInDidStartFromOrigin): Renaming.
(WebKit::WebProcess::didAddPlugInAutoStartOriginHash): Ditto.
(WebKit::WebProcess::resetPlugInAutoStartOriginHashes): Ditto.
(WebKit::WebProcess::plugInDidReceiveUserInteraction): Ditto.

  • WebProcess/WebProcess.h: Renaming some methods, but also adding the input of the new

origin-only list.

  • WebProcess/WebProcess.messages.in: Renaming a message.
4:07 PM Changeset in webkit [146822] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r146793.
http://trac.webkit.org/changeset/146793
https://bugs.webkit.org/show_bug.cgi?id=113248

Fix did not work (Requested by rfong on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25

Source/WebCore:

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

Tools:

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

3:58 PM Changeset in webkit [146821] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Disable fast/exclusions and fast/regions tests on Windows.
https://bugs.webkit.org/show_bug.cgi?id=113244

  • platform/win/TestExpectations:
3:51 PM Changeset in webkit [146820] by commit-queue@webkit.org
  • 14 edits
    3 copies
    3 adds in trunk

WEBGL_compressed_texture_pvrtc needs implementation
https://bugs.webkit.org/show_bug.cgi?id=110497

Patch by Brandon Jones <bajones@google.com> on 2013-03-25
Reviewed by Kenneth Russell.

Source/WebCore:

Test: webgl/conformance/extensions/webgl-compressed-texture-pvrtc.html

Exposes the WEBGL_compressed_texture_pvrtc extension, but is unverified since no desktop hardware supports
the format that I am aware of. Should enable mobile ports to expose the format, however.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLCompressedTexturePVRTC.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebCore::WebGLCompressedTexturePVRTC::WebGLCompressedTexturePVRTC):
(WebCore::WebGLCompressedTexturePVRTC::~WebGLCompressedTexturePVRTC):
(WebCore::WebGLCompressedTexturePVRTC::getName):
(WebCore::WebGLCompressedTexturePVRTC::create):
(WebCore::WebGLCompressedTexturePVRTC::supported):

  • html/canvas/WebGLCompressedTexturePVRTC.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebGLCompressedTexturePVRTC):

  • html/canvas/WebGLCompressedTexturePVRTC.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):

  • html/canvas/WebGLRenderingContext.h:

(WebCore):
(WebGLRenderingContext):

LayoutTests:

  • webgl/conformance/extensions/webgl-compressed-texture-pvrtc-expected.txt: Added.
  • webgl/conformance/extensions/webgl-compressed-texture-pvrtc.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-pvrtc.html: Added.
3:48 PM Changeset in webkit [146819] by danakj@chromium.org
  • 7 edits
    1 delete in trunk/Source

[chromium] Move ownership of compositor VideoLayer to WebMediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=112971

Reviewed by James Robinson.

Source/Platform:

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

  • chromium/public/WebVideoFrame.h:
  • chromium/public/WebVideoFrameProvider.h:

Source/WebKit/chromium:

This moves ownership of the compositor's video layer over to the
implementation of WebMediaPlayer, as well as all interaction
between the media player system and the compositor layer or its
interfaces such as cc::VideoFrameProvider.

Now, the WebMediaPlayer implementation calls setWebLayer() to
provide the WebLayer* to the WebMediaPlayerClientImpl so that
it can be inserted into the GraphicsLayer tree appropriately.

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

Once chromium removes its use of WebVideoFrame and its related
classes, we can remove them from WebKit entirely.

  • WebKit.gypi:
  • public/WebMediaPlayer.h:

(WebKit):

  • public/WebMediaPlayerClient.h:
  • public/WebStreamTextureClient.h:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::setWebLayer):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):
(WebKit::WebMediaPlayerClientImpl::needsWebLayer):
(WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::create):
(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebKit):
(WebMediaPlayerClientImpl):

  • tests/WebMediaPlayerClientImplTest.cpp: Removed.
3:18 PM Changeset in webkit [146818] by roger_fong@apple.com
  • 2 edits in trunk/WebKitLibraries

Unreviewed. Also enable CSS_REGIONS and EXCLUSIONS for VS2010 solution.

  • win/tools/vsprops/FeatureDefines.props:
3:08 PM Changeset in webkit [146817] by rniwa@webkit.org
  • 5 edits in trunk/Tools

REGRESSION(r146657): Test failures reported incorrectly
https://bugs.webkit.org/show_bug.cgi?id=113223

Reviewed by Dirk Pranke.

The bug was caused by BuildBotPrinter not taking the new behavior into account.

Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(RunDetails.init):
(summarize_results): Remove the line I intended to remove in r146657.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(logging_run): Return details instead of the exit code.
(run_and_capture): Ditto.

(RunTest.test_full_results_html):
(RunTest.test_hung_thread):
(RunTest.test_no_tests_found):
(RunTest.test_no_tests_found_2):
(RunTest.test_repeat_each_iterations_num_tests):
(RunTest.test_run_singly_actually_runs_tests):
(RunTest.test_test_list):
(RunTest.test_missing_and_unexpected_results):
(RunTest.test_pixel_test_directories):
(RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
(RunTest.test_crash_with_stderr):
(RunTest.test_no_image_failure_with_image_diff):
(RunTest.test_crash_log):
(RunTest.test_exit_after_n_failures_upload):
(RunTest.test_results_directory_absolute):
(RunTest.test_results_directory_relative):
(RunTest.test_retrying_and_flaky_tests):
(RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
(RunTest.test_retrying_uses_retries_directory):
(RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
(RunTest.test_output_diffs):
(EndToEndTest.test_reftest_with_two_notrefs):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

  • Scripts/webkitpy/layout_tests/views/buildbot_results.py:

(BuildBotPrinter.print_results):
(BuildBotPrinter.print_unexpected_results):
(BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
when we forced pixel tests in retry (i.e. pixel test was initially disabled).

2:01 PM Changeset in webkit [146816] by roger_fong@apple.com
  • 6 edits in trunk

Enable CSS_REGIONS and CSS_EXCLUSIONS and related tests.
https://bugs.webkit.org/show_bug.cgi?id=87519

Reviewed by Timothy Horton.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • platform/win/TestExpectations:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

1:53 PM Changeset in webkit [146815] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WebCore

Remove unused code from Frame class destructor
https://bugs.webkit.org/show_bug.cgi?id=113181

Reviewed by Alexey Proskuryakov.

No new tests. No new functionality.

  • page/Frame.cpp:

(WebCore::Frame::~Frame):

Removed the code which could never have been executed
as m_view had been set to '0'.

1:41 PM Changeset in webkit [146814] by danakj@chromium.org
  • 21 edits in trunk/LayoutTests

Don't use video to trigger compositing for layout tests
https://bugs.webkit.org/show_bug.cgi?id=113228

Reviewed by Adrienne Walker.

These tests used <video> to trigger compositing because a 3d identity
transform would have affected the overlap map differently. This is
no longer the case, so use translateZ(0) to trigger compositing instead,
which makes these tests more reliable and faster.

  • compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
  • compositing/geometry/limit-layer-bounds-fixed-positioned.html:
  • compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-opacity-transition.html:
  • compositing/geometry/limit-layer-bounds-overflow-repaint.html:
  • compositing/geometry/limit-layer-bounds-overflow-root.html:
  • compositing/geometry/limit-layer-bounds-positioned-transition.html:
  • compositing/geometry/limit-layer-bounds-positioned.html:
  • compositing/geometry/limit-layer-bounds-transformed-overflow.html:
  • compositing/geometry/limit-layer-bounds-transformed.html:
  • compositing/layer-creation/scroll-partial-update-expected.txt:
  • compositing/layer-creation/scroll-partial-update.html:
  • platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt:
  • platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt:
1:38 PM Changeset in webkit [146813] by Lucas Forschler
  • 1 edit
    2 copies in tags/Safari-537.35.1/LayoutTests

Merged r146685. <rdar://problem/13475726>

1:36 PM Changeset in webkit [146812] by Lucas Forschler
  • 8 edits in tags/Safari-537.35.1/Source

Merged r146679. <rdar://problem/13475726>

1:33 PM Changeset in webkit [146811] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.1/Source/WebCore

Merged r146563. <rdar://problem/13435161>

1:30 PM Changeset in webkit [146810] by Lucas Forschler
  • 5 edits in tags/Safari-537.35.1/Source/WebKit2

Merged r146551. <rdar://problem/13355759>

1:28 PM Changeset in webkit [146809] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.1/Source/WebKit2

Merged r146542. <rdar://problem/13355808>

1:26 PM Changeset in webkit [146808] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Sheriffing.
https://bugs.webkit.org/show_bug.cgi?id=112927
https://bugs.webkit.org/show_bug.cgi?id=113067
https://bugs.webkit.org/show_bug.cgi?id=113129

Unreviewed, test expectation updates.

Removed crash expectations for fixed bug; added fail expectations for
results the bot won't give us; marked a test as slow.

  • platform/chromium/TestExpectations:
1:26 PM Changeset in webkit [146807] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.1/Source/WebKit2

Merged r146539. <rdar://problem/13355808>

1:23 PM Changeset in webkit [146806] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.1/Source/WebCore

Merged r146373. <rdar://problem/13202277>

1:16 PM Changeset in webkit [146805] by eric@webkit.org
  • 3 edits
    2 adds in trunk

Incorrect parsing due to hash collision
https://bugs.webkit.org/show_bug.cgi?id=113235

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/parser/tag-hash-collision.html

  • html/parser/HTMLIdentifier.cpp:

(WebCore::HTMLIdentifier::findIndex):

LayoutTests:

  • fast/parser/tag-hash-collision-expected.txt: Added.
  • fast/parser/tag-hash-collision.html: Added.
1:15 PM Changeset in webkit [146804] by eric.carlson@apple.com
  • 4 edits in branches/safari-536.30-branch/LayoutTests

<rdar://problem/13465764> Many merged tests are failing

Update three more tests that use "testRunner" instead of "layoutTestController".

  • fast/block/float/intruding-float-not-removed-writing-mode.xhtml:
  • mhtml/shared_buffer_bug.mht:
  • svg/custom/use-invalidate-click-crash.xhtml:
1:14 PM Changeset in webkit [146803] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Compile without SVG will fail
https://bugs.webkit.org/show_bug.cgi?id=113234

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-03-25
Reviewed by Timothy Hatcher.

Only make the cast to SVGStyleElement if we have SVG support built.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

1:11 PM Changeset in webkit [146802] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Enable STORE_FONT_CUSTOM_PLATFORM_DATA for all platforms
https://bugs.webkit.org/show_bug.cgi?id=108438

Reviewed by Andreas Kling.

Remove the conditional code so it is turned on for all platforms.

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::~CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::platformDataFromCustomData):
(WebCore::CachedFont::allClientsRemoved):
(WebCore::CachedFont::reportMemoryUsage):

1:10 PM Changeset in webkit [146801] by eric.carlson@apple.com
  • 4 edits in trunk

REGRESSION(r146380): media/track/track-user-preferences.html
https://bugs.webkit.org/show_bug.cgi?id=113083

Reviewed by Jer Noble.

Source/WebCore:

Ignore track change notifications triggered by automatic track selection so the
configuration is not changed.

No new tests, this fixes an existing test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackGroup): Clear m_processingPreferenceChange after all

track configuration is finished.

(WebCore::HTMLMediaElement::configureTextTrackDisplay): Do nothing if m_processingPreferenceChange

is true.

LayoutTests:

  • platform/mac/TestExpectations: Remove test from expectations.
1:06 PM Changeset in webkit [146800] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

[GTK] [gyp] Build the final piece of WebCore
https://bugs.webkit.org/show_bug.cgi?id=113216

Reviewed by Nico Weber.

  • WebCore.gyp/WebCoreGTK.gyp: Add the rest of the WebCore source files to the WebCore build target.
1:00 PM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
12:57 PM Changeset in webkit [146799] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[WK2][GTK] MiniBrowser won't play video in <embed> tag
https://bugs.webkit.org/show_bug.cgi?id=113107

Reviewed by Martin Robinson.

The wrong clip region is used for windowed plugins, because it's
translated to window frame coords again.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange): Do not move
the current clip region.

12:45 PM Changeset in webkit [146798] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

[GTK] [gyp] Adding support for building WebCore rendering
https://bugs.webkit.org/show_bug.cgi?id=113213

Reviewed by Gustavo Noronha Silva.

  • WebCore.gyp/WebCoreGTK.gyp: Build the rendering directory into a shared library.
12:37 PM Changeset in webkit [146797] by jparent@chromium.org
  • 12 edits in trunk/Tools

Dashboard refactor: Move cross dashboard history related code into history.js.
https://bugs.webkit.org/show_bug.cgi?id=113104

Reviewed by Ojan Vafai.

All functions relating to cross dashboard behavior move from being
globals to methods on the history.History object. Names stay the same,
except many are made private, ones that should have been constants now
are, and the long standing TODO to change "currentState" to
dashboardSpecificState is done.

We now create a global history object in dashboard_base, as an
intermediate measure. Once the dashboard specific code is
added to history, each DB will need to create its own, and this
global will be eliminated.

  • TestResultServer/static-dashboards/aggregate_results.js:

(handleValidHashParameter):
(htmlForBuilder):
(rawValuesHTML):

  • TestResultServer/static-dashboards/dashboard_base.js:

(parseDashboardSpecificParameters):
(defaultValue):
(currentBuilderGroupCategory):
(currentBuilderGroupName):
(handleLocationChange):
(expectationsMap):

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(generatePage):
(.switch.return):
(platformAndBuildType):
(individualTests):
(substringList):
(processMissingAndExtraExpectations):
(pathToFailureLog):
(showPopupForBuild):
(htmlForTestsWithExpectationsButNoFailures):
(shouldHideTest):
(isCrossBuilderView):
(tableHeaders):
(htmlForSingleTestRow):
(htmlForTableColumnHeader):
(generatePageForExpectationsUpdate):
(handleUpdate):
(nextUpdate):
(setUpdateIndex):
(htmlForIndividualTestOnAllBuildersWithResultsLinks):
(.appendExpectationsItem):
(loadExpectations):
(.dummyNode.onload):
(loadExpectationsLayoutTests):
(appendExpectations):
(htmlForNavBar):
(checkBoxToToggleState):
(linkHTMLToToggleState):
(generatePageForBuilder):
(isInvalidKeyForCrossBuilderView):
(handleQueryParameterChange):
(showLegend):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):
(test):

  • TestResultServer/static-dashboards/history.js:

(.):

  • TestResultServer/static-dashboards/history_unittests.js:
  • TestResultServer/static-dashboards/loader.js:

(.):

  • TestResultServer/static-dashboards/loader_unittests.js:
  • TestResultServer/static-dashboards/timeline_explorer.js:

(generatePage):
(initCurrentBuilderTestResults):
(selectBuild):
(showResultsDelta):

  • TestResultServer/static-dashboards/treemap.js:

(generatePage):
(.switch.return):
(handleFocus):

  • TestResultServer/static-dashboards/ui.js:
12:16 PM Changeset in webkit [146796] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove TextIterator argumentless constructor
https://bugs.webkit.org/show_bug.cgi?id=113226

Reviewed by Ryosuke Niwa.

The TextIterator argumentless constructors are never used and wouldn't be useful
since you can't specify a range.

No new tests, removing dead code. There should be no behavior change.

  • editing/TextIterator.cpp: Remove constructors.
  • editing/TextIterator.h:

(TextIterator):
(SimplifiedBackwardsTextIterator):
(CharacterIterator):
(BackwardsCharacterIterator):
(WordAwareIterator):

12:05 PM Changeset in webkit [146795] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Enabled canvas.getContext("webgl") on Desktop Chrome
https://bugs.webkit.org/show_bug.cgi?id=113079

Patch by Brandon Jones <bajones@chromium.org> on 2013-03-25
Reviewed by Dean Jackson.

Test: fast/canvas/webgl/webgl-unprefixed-context-id.html

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextMethodCustom):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

11:51 AM Changeset in webkit [146794] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Windows rebaseline after r146779.

  • platform/win/css3/filters/effect-reference-expected.txt:
  • platform/win/css3/filters/effect-reference-hw-expected.txt:
11:43 AM Changeset in webkit [146793] by roger_fong@apple.com
  • 4 edits in trunk

Unreviewed. Remove some suspicious looking code in an attempt to fix EWS bots.
Enable WinEWS test again.

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

11:40 AM Changeset in webkit [146792] by eric.carlson@apple.com
  • 2 edits in branches/safari-536.30-branch/LayoutTests

Merge r136586.

2012-12-04 Florin Malita <fmalita@chromium.org>

Unreviewed gardening - add missing js-test-pre.js include to avoid use-href-update-crash.svg
failures on platforms that do not define gc().

  • svg/custom/use-href-update-crash.svg:
11:36 AM Changeset in webkit [146791] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.1/Source

Versioning.

11:31 AM Changeset in webkit [146790] by Lucas Forschler
  • 1 copy in tags/Safari-537.35.1

New Tag.

11:19 AM Changeset in webkit [146789] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

[GTK] [gyp] Add support for building the platform directory
https://bugs.webkit.org/show_bug.cgi?id=113212

Reviewed by Nico Weber.

  • WebCore.gyp/WebCoreGTK.gyp: Add support for building the platform directory including

two libraries, one for platform and one for geometry files. This follows the approach
of Chromium.

11:13 AM Changeset in webkit [146788] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

Mac rebaselines after r146779. Also add failing expectations for 4 transition tests per bug 113223.

  • platform/mac/TestExpectations:
  • platform/mac/css3/filters/effect-reference-expected.png:
  • platform/mac/css3/filters/effect-reference-expected.txt:
  • platform/mac/css3/filters/effect-reference-hw-expected.png:
  • platform/mac/css3/filters/effect-reference-hw-expected.txt:
10:57 AM Changeset in webkit [146787] by jochen@chromium.org
  • 4 edits in trunk

Swap both the error and change event queue before processing fullscreen events
https://bugs.webkit.org/show_bug.cgi?id=113194

Reviewed by Jer Noble.

Source/WebCore:

While processing the change events, not only new change events but
also new error events might get generated. However, for the timer, we
should only process preexisting events.

This is covered by fullscreen/full-screen-restrictions.html which times
out depending on the delay between requesting fullscreen and granting
fullscreen.

  • dom/Document.cpp:

(WebCore::Document::fullScreenChangeDelayTimerFired):

LayoutTests:

  • platform/chromium/TestExpectations:
9:51 AM Changeset in webkit [146786] by zarvai@inf.u-szeged.hu
  • 215 edits
    3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining. Making pixel test bot happier after r146206.

  • platform/qt/fast/replaced/max-width-percent-expected.png:
  • platform/qt/fast/replaced/maxheight-percent-expected.png:
  • platform/qt/fast/replaced/maxheight-pxs-expected.png:
  • platform/qt/fast/replaced/maxwidth-percent-expected.png:
  • platform/qt/fast/replaced/maxwidth-pxs-expected.png:
  • platform/qt/fast/replaced/minheight-percent-expected.png:
  • platform/qt/fast/replaced/minheight-pxs-expected.png:
  • platform/qt/fast/replaced/minwidth-percent-expected.png:
  • platform/qt/fast/replaced/minwidth-pxs-expected.png:
  • platform/qt/fast/replaced/object-align-hspace-vspace-expected.png:
  • platform/qt/fast/replaced/percent-height-in-anonymous-block-in-table-expected.png:
  • platform/qt/fast/replaced/percent-height-in-anonymous-block-widget-expected.png:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/qt/fast/replaced/width100percent-button-expected.png:
  • platform/qt/fast/ruby/ruby-inline-table-expected.png:
  • platform/qt/fast/runin/001-expected.png:
  • platform/qt/fast/runin/generated-expected.png:
  • platform/qt/fast/runin/runin-generated-before-content-expected.png:
  • platform/qt/fast/selectors/016-expected.png:
  • platform/qt/fast/selectors/017-expected.png:
  • platform/qt/fast/selectors/061-expected.png:
  • platform/qt/fast/selectors/062-expected.png:
  • platform/qt/fast/selectors/064-expected.png:
  • platform/qt/fast/table/003-expected.png:
  • platform/qt/fast/table/023-expected.png:
  • platform/qt/fast/table/027-vertical-expected.png:
  • platform/qt/fast/table/038-vertical-expected.png:
  • platform/qt/fast/table/040-expected.png:
  • platform/qt/fast/table/040-vertical-expected.png:
  • platform/qt/fast/table/100-percent-cell-width-expected.png:
  • platform/qt/fast/table/add-before-anonymous-child-expected.png:
  • platform/qt/fast/table/auto-100-percent-width-expected.png:
  • platform/qt/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-expected.png:
  • platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-expected.png:
  • platform/qt/fast/table/cell-absolute-child-expected.png:
  • platform/qt/fast/table/click-near-anonymous-table-expected.png:
  • platform/qt/fast/table/empty-cells-expected.png:
  • platform/qt/fast/table/empty-table-percent-height-expected.png:
  • platform/qt/fast/table/fixed-granular-cols-expected.png:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-expected.png:
  • platform/qt/fast/table/generated-caption-expected.png:
  • platform/qt/fast/table/insert-before-anonymous-ancestors-expected.png:
  • platform/qt/fast/table/mozilla-bug10296-vertical-align-1-expected.png:
  • platform/qt/fast/table/mozilla-bug10296-vertical-align-2-expected.png:
  • platform/qt/fast/table/row-height-recalc-expected.png:
  • platform/qt/fast/table/rtl-cell-display-none-assert-expected.png:
  • platform/qt/fast/table/stale-grid-crash-expected.png:
  • platform/qt/fast/table/table-and-parts-outline-expected.png:
  • platform/qt/fast/table/table-display-types-vertical-expected.png:
  • platform/qt/fast/table/text-field-baseline-expected.png:
  • platform/qt/fast/table/unused-percent-heights-expected.png:
  • platform/qt/fast/text/backslash-to-yen-sign-expected.png:
  • platform/qt/fast/text/basic/001-expected.png:
  • platform/qt/fast/text/basic/002-expected.png:
  • platform/qt/fast/text/basic/004-expected.png:
  • platform/qt/fast/text/basic/008-expected.png:
  • platform/qt/fast/text/basic/009-expected.png:
  • platform/qt/fast/text/basic/011-expected.png:
  • platform/qt/fast/text/basic/012-expected.png:
  • platform/qt/fast/text/basic/generic-family-changes-expected.png:
  • platform/qt/fast/text/basic/generic-family-reset-expected.png:
  • platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.png:
  • platform/qt/fast/text/capitalize-empty-generated-string-expected.png:
  • platform/qt/fast/text/complex-text-opacity-expected.png:
  • platform/qt/fast/text/fake-italic-expected.png:
  • platform/qt/fast/text/fallback-traits-fixup-expected.png:
  • platform/qt/fast/text/firstline/001-expected.png:
  • platform/qt/fast/text/font-initial-expected.png:
  • platform/qt/fast/text/hyphenate-limit-before-after-expected.png:
  • platform/qt/fast/text/international/arabic-justify-expected.png:
  • platform/qt/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/qt/fast/text/international/hindi-whitespace-expected.png:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/qt/fast/text/justified-selection-at-edge-expected.png:
  • platform/qt/fast/text/justified-selection-expected.png:
  • platform/qt/fast/text/line-breaks-after-white-space-expected.png:
  • platform/qt/fast/text/shadow-no-blur-expected.png:
  • platform/qt/fast/text/shadow-translucent-fill-expected.png:
  • platform/qt/fast/text/softHyphen-expected.png:
  • platform/qt/fast/text/unicode-variation-selector-expected.png:
  • platform/qt/fast/text/wbr-in-pre-crash-expected.png:
  • platform/qt/fast/text/wbr-styled-expected.png:
  • platform/qt/fast/text/whitespace/002-expected.png:
  • platform/qt/fast/text/whitespace/020-expected.png:
  • platform/qt/fast/text/whitespace/021-expected.png:
  • platform/qt/fast/text/whitespace/022-expected.png:
  • platform/qt/fast/text/whitespace/025-expected.png:
  • platform/qt/fast/text/whitespace/027-expected.png:
  • platform/qt/fast/text/whitespace/030-expected.png:
  • platform/qt/fast/text/whitespace/nbsp-mode-and-linewraps-expected.png:
  • platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/qt/fast/text/whitespace/pre-break-word-expected.png:
  • platform/qt/fast/text/whitespace/pre-wrap-last-char-expected.png:
  • platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png:
  • platform/qt/fast/text/word-break-expected.png:
  • platform/qt/fast/text/zero-font-size-expected.png:
  • platform/qt/fast/transforms/bounding-rect-zoom-expected.png:
  • platform/qt/fast/transforms/diamond-expected.png:
  • platform/qt/fast/transforms/matrix-01-expected.png:
  • platform/qt/fast/transforms/matrix-02-expected.png:
  • platform/qt/fast/transforms/overflow-with-transform-expected.png:
  • platform/qt/fast/transforms/skew-with-unitless-zero-expected.png:
  • platform/qt/fast/transforms/transform-on-inline-expected.png:
  • platform/qt/fast/transforms/transform-positioned-ancestor-expected.png:
  • platform/qt/fast/transforms/transformed-document-element-expected.png:
  • platform/qt/fast/transforms/transforms-with-opacity-expected.png:
  • platform/qt/fast/writing-mode/block-level-images-expected.png:
  • platform/qt/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/qt/fast/writing-mode/english-bt-text-expected.png:
  • platform/qt/fast/writing-mode/english-rl-text-expected.png:
  • platform/qt/fast/writing-mode/horizontal-bt-replaced-selection-expected.png:
  • platform/qt/fast/writing-mode/vertical-lr-replaced-selection-expected.png:
  • platform/qt/fast/writing-mode/vertical-rl-replaced-selection-expected.png:
  • platform/qt/fast/xsl/document-function-expected.png:
  • platform/qt/fonts/cursive-expected.png:
  • platform/qt/fonts/default-expected.png:
  • platform/qt/fonts/fantasy-expected.png:
  • platform/qt/fonts/monospace-expected.png:
  • platform/qt/fonts/sans-serif-expected.png:
  • platform/qt/fonts/serif-expected.png:
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.png:
  • platform/qt/http/tests/misc/frame-access-during-load-expected.png:
  • platform/qt/http/tests/misc/iframe404-expected.png:
  • platform/qt/http/tests/navigation/postredirect-basic-expected.png:
  • platform/qt/http/tests/navigation/postredirect-goback1-expected.png:
  • platform/qt/http/tests/uri/css-href-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png:
  • platform/qt/ietestcenter/css3/text/textshadow-003-expected.png:
  • platform/qt/ietestcenter/css3/text/textshadow-005-expected.png:
  • platform/qt/ietestcenter/css3/text/textshadow-007-expected.png:
  • platform/qt/ietestcenter/css3/text/textshadow-008-expected.png:
  • platform/qt/ietestcenter/css3/text/textshadow-009-expected.png:
  • platform/qt/ietestcenter/css3/text/textshadow-010-expected.png:
  • platform/qt/platform/qt/fast/forms/button-line-break-expected.png:
  • platform/qt/printing/return-from-printing-mode-expected.png:
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/qt/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/qt/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/qt/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-13-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-20-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-25-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
9:49 AM Changeset in webkit [146785] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

[V8] Generate specialized callbacks for the main world
https://bugs.webkit.org/show_bug.cgi?id=112430

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-25
Reviewed by Kentaro Hara.

The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.

This patch generates main world bindings for getters and setters for a
small amount of frequently used functions / functions used by Dromaeo.

Added tests to TestObj.idl and updated bindings tests.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateParametersCheck):
(GenerateSingleConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateFunctionCallString):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldMethodMethod):
(WebCore::TestObjV8Internal::perWorldMethodMethodForMainWorld):
(WebCore::TestObjV8Internal::perWorldMethodMethodCallback):
(WebCore::TestObjV8Internal::perWorldMethodMethodCallbackForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod1Method):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod1MethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod2Method):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod2MethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethod):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodCallback):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodCallbackForMainWorld):
(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore):

  • bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):

  • bindings/v8/V8DOMConfiguration.h:

(BatchedMethod):
(V8DOMConfiguration):

  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.idl:
  • page/DOMWindow.idl:
9:47 AM Changeset in webkit [146784] by dcheng@chromium.org
  • 3 edits
    1 add in trunk

Don't allow drags to start after a mouse press that creates a context menu
https://bugs.webkit.org/show_bug.cgi?id=112079

Reviewed by Tony Chang.

.:

  • ManualTests/context-menu-during-drag-selection.html: Added.

Source/WebCore:

This appears to be the intent of the original code anyway (the comments in the corresponding
context menu handlers indicate that they set m_mousePressed to false in order to suppress
drags from starting). Since exact platform behavior differs quite a bit in this area, this
will also make the behavior more consistent across different WebKit implementations.

Manually testable using context-menu-during-drag-selection.html.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):

9:36 AM Changeset in webkit [146783] by pdr@google.com
  • 2 edits
    1 add in trunk/LayoutTests

[Chromium] Rebaseline svg/custom/marker-orient-auto

Unreviewed rebaseline of test expectations.

  • platform/chromium-linux-x86/svg/custom/marker-orient-auto-expected.png: Added.
  • platform/chromium/TestExpectations:
9:29 AM Changeset in webkit [146782] by vsevik@chromium.org
  • 6 edits in trunk

Web Inspector: [Regression] Provisional breakpoints are not shown on reload.
https://bugs.webkit.org/show_bug.cgi?id=113210

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._restoreBreakpoints):
(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):
(WebInspector.BreakpointManager.prototype._breakpointResolved):

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/debugger/breakpoint-manager-expected.txt:
  • inspector/debugger/breakpoint-manager.html:
9:28 AM Changeset in webkit [146781] by commit-queue@webkit.org
  • 8 edits in trunk

Web Inspector: Remove console warnings for *_ prefixed CSS styles
https://bugs.webkit.org/show_bug.cgi?id=113175

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

Source/WebCore:

Added separate error message for syntax CSS error in declaration list when no property detected.
Added filter for messages starting with '*'.

  • css/CSSGrammar.y.in:

LayoutTests:

  • inspector/console/console-css-warnings-expected.txt:
  • inspector/console/console-css-warnings.html:
9:16 AM Changeset in webkit [146780] by jochen@chromium.org
  • 2 edits in trunk/LayoutTests

Triage more test failures on content_shell

Unreviewed gardening.

  • platform/chromium/ContentShellTestExpectations:
9:10 AM Changeset in webkit [146779] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk

Integration of the Skia displacement mapping into WebKit
https://bugs.webkit.org/show_bug.cgi?id=112927

Patch by Alexis Hetu <sugoi@chromium.org> on 2013-03-25
Reviewed by Stephen White.

Added displacement mapping to effect-reference.html and
effect-reference-hw.html

  • WebCore.gypi:
  • platform/graphics/filters/FEDisplacementMap.h:

(FEDisplacementMap):
Adding Skia specific declarations

  • platform/graphics/filters/skia/FEDisplacementMapSkia.cpp: Added.

(WebCore):
(WebCore::toSkiaMode):
Provides conversion between the WebKit displacement mapping mode and
the Skia displacement mapping mode
(WebCore::FEDisplacementMap::platformApplySkia):
Displacement through the Skia API. (Accelerated only for now)
(WebCore::FEDisplacementMap::createImageFilter):
Displacement image filter creation through the Skia API.

9:05 AM Changeset in webkit [146778] by dominik.rottsches@intel.com
  • 3 edits
    2 deletes in trunk/Tools

[HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
https://bugs.webkit.org/show_bug.cgi?id=112166

HarfBuzz 0.9.14 merged my patch for icu detection without
pkg-config files, as needed by for example Ubuntu 12.04.
This obsoletes our local workaround. Removed it for GTK and EFL.

Reviewed by Martin Robinson.

  • efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
  • efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
  • gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
  • gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
9:01 AM Changeset in webkit [146777] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Graduate some new Inspector APIs to public
https://bugs.webkit.org/show_bug.cgi?id=113176

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

Summary of changes:

DOM.highlightNode.nodeId: required parameter is now optional
Input: domain has been added
Runtime.enable: command has been added
Runtime.executionContextCreated: event has been added
Page.clearGeolocationOverride: command has been added
Page.setGeolocationOverride: command has been added
Page.captureScreenshot: command has been added
Debugger.setBreakpointByUrl.locations: optional response parameter is now required

  • inspector/Inspector.json:
8:56 AM Changeset in webkit [146776] by kadam@inf.u-szeged.hu
  • 341 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated expected png results.

  • platform/qt/css3/selectors3/xhtml/css3-modsel-146a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-146b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-147a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-147b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14e-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-15-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-150-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-153-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-159-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-15c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-16-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-168-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-168a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-169-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-169a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-172a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-172b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-173a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-173b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-18-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-181-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-183-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-18b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-19-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-20-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-21-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-22-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-28-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-29-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-29b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-3-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-30-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-31-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-32-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-33-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-34-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-35-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-36-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-37-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-38-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-3a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-41-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-41a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-42-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-42a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-43-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-43b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-44-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-44b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-45-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-45b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-46-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-46b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-47-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-48-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-49-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-51-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-52-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-53-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-54-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-55-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-56-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-57-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-57b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-59-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-60-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-62-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-63-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-65-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-66-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-67-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-7-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-72-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-72b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-73-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-73b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-74-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-75-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-75b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-76-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-76b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-77-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-77b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-78-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-78b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-79-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-8-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-80-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-81-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-81b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-82-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-82b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-87-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-87b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-9-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-90-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-90b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-93-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-94-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-94b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-95-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-96-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-96b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-97-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-97b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-98-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-98b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-99-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-99b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-d4-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-1-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-10-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-100-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-100b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-101-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-101b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-102-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-102b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-103-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-103b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-104-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-104b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-105-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-105b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-106-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-106b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-107-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-107b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-108-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-108b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-109-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-109b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-11-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-110-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-110b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-111-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-111b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-112-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-112b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-113-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-113b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-114-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-114b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-115-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-115b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-116-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-116b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-117-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-117b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-118-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-119-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-120-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-121-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-122-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-123-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-124-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-124b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-125-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-125b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-126-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-126b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-127-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-127b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-128-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-128b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-129-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-129b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-13-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-130-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-130b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-131-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-131b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-132-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-132b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-133-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-133b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-134-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-134b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-135-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-135b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-136-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-136b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-137-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-137b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-138-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-138b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-139-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-139b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-14-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-140-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-140b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-141-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-141b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-142-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-142b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-143-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-143b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-145a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-145b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-146a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-146b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-147a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-147b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-14c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-14e-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-15-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-150-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-153-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-159-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-15c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-16-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-168-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-168a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-169-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-169a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-172a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-172b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-173a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-173b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-18-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-181-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-183-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-18b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-19-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-20-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-21-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-22-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-28-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-28b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-29-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-29b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-3-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-30-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-31-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-32-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-33-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-34-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-35-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-36-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-37-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-38-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-39-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-39a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-39b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-39c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-3a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-41-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-41a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-42-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-42a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-43-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-43b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-44-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-44b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-45-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-45b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-46-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-46b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-47-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-48-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-49-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-51-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-52-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-53-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-54-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-55-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-56-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-57-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-57b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-59-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-60-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-62-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-63-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-65-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-66-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-67-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-7-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-72-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-72b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-73-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-73b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-74-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-74b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-75-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-75b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-76-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-76b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-77-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-77b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-78-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-78b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-79-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-8-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-80-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-81-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-81b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-82-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-82b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-87-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-87b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-9-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-90-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-90b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-93-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-94-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-94b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-95-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-96-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-96b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-97-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-97b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-98-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-98b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-99-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-99b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-d4-expected.png:
  • platform/qt/css3/unicode-bidi-isolate-basic-expected.png:
8:34 AM Changeset in webkit [146775] by kadam@inf.u-szeged.hu
  • 198 edits
    5 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated expected png resutls after r146206.

  • platform/qt/css3/compositing/effect-background-blend-mode-expected.png: Added.
  • platform/qt/css3/css3-modsel-33-expected.png:
  • platform/qt/css3/css3-modsel-35-expected.png:
  • platform/qt/css3/css3-modsel-36-expected.png:
  • platform/qt/css3/css3-modsel-37-expected.png:
  • platform/qt/css3/filters/custom/custom-filter-color-matrix-expected.png: Added.
  • platform/qt/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
  • platform/qt/css3/filters/effect-invert-hw-expected.png:
  • platform/qt/css3/filters/filter-repaint-child-layers-expected.png: Added.
  • platform/qt/css3/filters/nested-filter-expected.png:
  • platform/qt/css3/filters/regions-expanding-expected.png:
  • platform/qt/css3/flexbox/flexbox-baseline-expected.png:
  • platform/qt/css3/images/cross-fade-background-size-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-1-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-10-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-11-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-13-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-14-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-14c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-14e-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-15-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-150-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-159-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-16-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-168-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-168a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-169-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-169a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-18-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-181-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-183-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-18b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-19-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-20-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-21-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-22-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-28-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-28b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-29-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-29b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-30-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-31-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-32-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-33-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-34-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-35-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-36-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-37-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-38-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-39-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-39a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-39b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-39c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-3a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-41-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-41a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-42-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-42a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-43-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-43b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-44-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-44b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-45-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-45b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-46-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-46b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-54-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-55-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-56-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-59-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-60-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-62-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-63-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-65-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-66-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-67-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-7-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-72-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-72b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-73-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-73b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-74-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-74b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-75-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-75b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-76-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-76b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-77-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-77b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-78-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-78b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-79-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-8-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-80-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-81-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-81b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-82-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-82b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-87-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-87b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-9-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-90-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-90b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-d4-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-1-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-10-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-100-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-100b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-101-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-101b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-102-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-102b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-103-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-103b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-104-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-104b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-105-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-105b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-106-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-106b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-107-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-107b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-108-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-108b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-109-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-109b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-11-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-110-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-110b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-111-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-111b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-112-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-112b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-113-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-113b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-114-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-114b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-115-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-115b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-116-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-116b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-117-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-117b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-118-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-119-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-120-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-121-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-122-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-123-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-124-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-124b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-125-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-125b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-126-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-126b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-127-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-127b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-128-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-128b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-129-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-129b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-13-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-130-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-130b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-131-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-131b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-132-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-132b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-133-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-133b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-134-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-134b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-135-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-135b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-136-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-136b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-137-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-137b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-138-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-138b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-139-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-139b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-140-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-140b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-141-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-141b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-142-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-142b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-143-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-143b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-145a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-145b-expected.png:
8:25 AM Changeset in webkit [146774] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

WTF::binarySearchImpl() should compile with -Wshorten-64-to-32
<http://webkit.org/b/113170>

Reviewed by Dan Bernstein.

Fixes the following build failure:

/usr/local/include/wtf/StdLibExtras.h:190:30: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]

int pos = (size - 1) >> 1;

~ ~~

1 error generated.

  • wtf/StdLibExtras.h:

(WTF::binarySearchImpl): Switch type from int to size_t.

8:09 AM Changeset in webkit [146773] by kadam@inf.u-szeged.hu
  • 123 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated expected png results r146206.

  • platform/qt-5.0-wk2/css2.1/t0905-c414-flt-01-d-g-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t1004-c5524-width-00-b-g-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-002-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-002-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-002-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-003-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-004-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-005-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-007-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-009-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-010-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-011-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-012-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-013-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-014-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-015-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-016-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-017-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-018-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-019-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-020-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-021-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-022-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-023-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-024-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-009-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-010-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-016-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-017-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-022-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-023-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-024-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-029-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-030-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-031-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-013-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-015-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-020-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-022-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-027-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-029-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-034-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-036-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-041-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-043-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-048-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-050-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-055-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-057-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-062-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-064-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-069-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-071-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-076-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-002-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-005-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-006-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-width-005-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-width-007-expected.png:
  • platform/qt/css2.1/20110323/block-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/block-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/block-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/qt/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/qt/css2.1/20110323/border-spacing-applies-to-015-expected.png:
  • platform/qt/css2.1/20110323/empty-inline-003-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-007-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-008-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-009-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-010-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-011-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-012-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-width-011-expected.png:
  • platform/qt/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-002-expected.png:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-003-expected.png:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-004-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-014-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-015-expected.png:
  • platform/qt/css2.1/20110323/margin-applies-to-010-expected.png:
  • platform/qt/css2.1/20110323/replaced-intrinsic-001-expected.png:
  • platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/qt/css2.1/20110323/table-caption-002-expected.png:
  • platform/qt/css2.1/20110323/table-caption-optional-001-expected.png:
  • platform/qt/css2.1/20110323/table-caption-optional-002-expected.png:
  • platform/qt/css2.1/20110323/table-height-algorithm-023-expected.png:
  • platform/qt/css2.1/20110323/table-height-algorithm-024-expected.png:
  • platform/qt/css2.1/20110323/width-non-replaced-inline-001-expected.png:
  • platform/qt/css2.1/t051103-c21-activ-ln-00-e-i-expected.png:
  • platform/qt/css2.1/t051103-c21-hover-ln-00-e-i-expected.png:
  • platform/qt/css2.1/t060403-c21-pseu-cls-00-e-i-expected.png:
  • platform/qt/css2.1/t060403-c21-pseu-id-00-e-i-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/qt/css2.1/t1202-counters-08-b-expected.png:
  • platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
  • platform/qt/css2.1/t1508-c527-font-07-b-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.png:
7:50 AM Changeset in webkit [146772] by kadam@inf.u-szeged.hu
  • 68 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated png results after r146206.

  • platform/qt/css1/basic/class_as_selector-expected.png:
  • platform/qt/css1/basic/comments-expected.png:
  • platform/qt/css1/basic/contextual_selectors-expected.png:
  • platform/qt/css1/basic/grouping-expected.png:
  • platform/qt/css1/basic/id_as_selector-expected.png:
  • platform/qt/css1/box_properties/acid_test-expected.png:
  • platform/qt/css1/box_properties/border_bottom_inline-expected.png:
  • platform/qt/css1/box_properties/border_bottom_width-expected.png:
  • platform/qt/css1/box_properties/border_bottom_width_inline-expected.png:
  • platform/qt/css1/box_properties/border_color-expected.png:
  • platform/qt/css1/box_properties/border_color_inline-expected.png:
  • platform/qt/css1/box_properties/border_inline-expected.png:
  • platform/qt/css1/box_properties/border_left_inline-expected.png:
  • platform/qt/css1/box_properties/border_left_width_inline-expected.png:
  • platform/qt/css1/box_properties/border_right-expected.png:
  • platform/qt/css1/box_properties/border_right_width_inline-expected.png:
  • platform/qt/css1/box_properties/border_style_inline-expected.png:
  • platform/qt/css1/box_properties/border_top_inline-expected.png:
  • platform/qt/css1/box_properties/border_top_width-expected.png:
  • platform/qt/css1/box_properties/border_top_width_inline-expected.png:
  • platform/qt/css1/box_properties/border_width-expected.png:
  • platform/qt/css1/box_properties/border_width_inline-expected.png:
  • platform/qt/css1/box_properties/clear-expected.png:
  • platform/qt/css1/box_properties/float-expected.png:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.png:
  • platform/qt/css1/box_properties/height-expected.png:
  • platform/qt/css1/box_properties/margin-expected.png:
  • platform/qt/css1/box_properties/margin_bottom-expected.png:
  • platform/qt/css1/box_properties/margin_bottom_inline-expected.png:
  • platform/qt/css1/box_properties/margin_left_inline-expected.png:
  • platform/qt/css1/box_properties/margin_right_inline-expected.png:
  • platform/qt/css1/box_properties/margin_top-expected.png:
  • platform/qt/css1/box_properties/margin_top_inline-expected.png:
  • platform/qt/css1/box_properties/padding-expected.png:
  • platform/qt/css1/box_properties/padding_left_inline-expected.png:
  • platform/qt/css1/box_properties/padding_right_inline-expected.png:
  • platform/qt/css1/box_properties/padding_top-expected.png:
  • platform/qt/css1/box_properties/padding_top_inline-expected.png:
  • platform/qt/css1/box_properties/width-expected.png:
  • platform/qt/css1/classification/list_style-expected.png:
  • platform/qt/css1/classification/list_style_image-expected.png:
  • platform/qt/css1/classification/list_style_position-expected.png:
  • platform/qt/css1/classification/list_style_type-expected.png:
  • platform/qt/css1/classification/white_space-expected.png:
  • platform/qt/css1/color_and_background/background-expected.png:
  • platform/qt/css1/color_and_background/background_attachment-expected.png:
  • platform/qt/css1/color_and_background/background_color-expected.png:
  • platform/qt/css1/color_and_background/background_image-expected.png:
  • platform/qt/css1/color_and_background/color-expected.png:
  • platform/qt/css1/font_properties/font_family-expected.png:
  • platform/qt/css1/font_properties/font_size-expected.png:
  • platform/qt/css1/font_properties/font_style-expected.png:
  • platform/qt/css1/font_properties/font_variant-expected.png:
  • platform/qt/css1/font_properties/font_weight-expected.png:
  • platform/qt/css1/formatting_model/canvas-expected.png:
  • platform/qt/css1/formatting_model/floating_elements-expected.png:
  • platform/qt/css1/formatting_model/height_of_lines-expected.png:
  • platform/qt/css1/formatting_model/horizontal_formatting-expected.png:
  • platform/qt/css1/formatting_model/replaced_elements-expected.png:
  • platform/qt/css1/text_properties/letter_spacing-expected.png:
  • platform/qt/css1/text_properties/line_height-expected.png:
  • platform/qt/css1/text_properties/text_align-expected.png:
  • platform/qt/css1/text_properties/vertical_align-expected.png:
  • platform/qt/css1/text_properties/word_spacing-expected.png:
  • platform/qt/css1/units/color_units-expected.png:
  • platform/qt/css1/units/length_units-expected.png:
  • platform/qt/css1/units/percentage_units-expected.png:
7:42 AM Changeset in webkit [146771] by caseq@chromium.org
  • 4 edits in trunk

Web Inspector: [Timeline] set glue records mode off by default
https://bugs.webkit.org/show_bug.cgi?id=113189

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/TimelinePanel.js: /glueRecordsSetting/s/true/false/

LayoutTests:

  • inspector/timeline/timeline-receive-response-event.html: enable glue records mode for the test.
7:29 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu
Removing Amazon bot after its shutdown. (diff)
7:27 AM Changeset in webkit [146770] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

[EFL] Fix build break when media source is enabled
https://bugs.webkit.org/show_bug.cgi?id=113143

Unreviewed. Build error needs to be fixed in order to start to implement
media source functionality.

  • CMakeLists.txt:
  • platform/efl/MIMETypeRegistryEfl.cpp:

(WebCore):
(WebCore::MIMETypeRegistry::isSupportedMediaSourceMIMEType):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::load):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

7:26 AM Changeset in webkit [146769] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Toggling breakpoint with shortcut should be freezed as well while editing.
https://bugs.webkit.org/show_bug.cgi?id=113188

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.toggleBreakpointOnCurrentLine):

7:23 AM Changeset in webkit [146768] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Remove unneeded code from JavaScriptSourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=113182

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):

6:56 AM Changeset in webkit [146767] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Web Inspector: Fonts refactoring
https://bugs.webkit.org/show_bug.cgi?id=113047

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

Unify fonts usage across inspector.
Make inspector default font depend on platform.

Source/WebCore:

  • inspector/front-end/dataGrid.css:

(.data-grid table):
(.data-grid td):

  • inspector/front-end/inspector.css:

(.toolbar-label):
(body.show-toolbar-icons .toolbar-label):
(.console-message .bubble):
(li .status .bubble):
(.source-frame-breakpoint-message):
(.soft-context-menu):

  • inspector/front-end/inspectorCommon.css:

(body):

  • inspector/front-end/networkLogView.css:

(.network-log-grid.data-grid td):
(.network-log-grid.data-grid.small td):

  • inspector/front-end/tabbedPane.css:

(.tabbed-pane-header-tab):
(select.tabbed-pane-header-tabs-drop-down-select):

  • inspector/front-end/timelinePanel.css:

(.memory-counter-value):

Source/WebKit/chromium:

  • src/js/devTools.css:

(body.platform-linux):
(body.platform-mac):
(body.platform-windows):

6:54 AM Changeset in webkit [146766] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Qml WebKit needs preferences to change security knobs
https://bugs.webkit.org/show_bug.cgi?id=111979

Patch by Maxim Ermilov <maxim.ermilov@canonical.com> on 2013-03-25
Reviewed by Jocelyn Turcotte.

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::universalAccessFromFileURLsAllowed):
(QWebPreferences::setUniversalAccessFromFileURLsAllowed):
(QWebPreferences::fileAccessFromFileURLsAllowed):
(QWebPreferences::setFileAccessFromFileURLsAllowed):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:
6:52 AM Changeset in webkit [146765] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Use generate-inspector-protocol-version to list valid public API changes
https://bugs.webkit.org/show_bug.cgi?id=113148

Added --show-changes command line option.
Used existing compare_schemas method to do a reverse compare.
Fixed a number of small problems (missing domain name in the message,
incorrect error messages for command parameters).

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

  • inspector/generate-inspector-protocol-version:

(named_list_to_map):
(removed):
(required):
(compare_schemas):
(compare_domains):
(compare_commands):
(compare_events):
(compare_params_list):
(compare_types):
(self_test):
(self_test.create_test_schema_1):
(self_test.create_test_schema_2):
(self_test.is_subset):
(self_test.errors_match):
(main):

6:42 AM Changeset in webkit [146764] by alecflett@chromium.org
  • 17 edits
    9 adds in trunk

Support Quota API in Workers
https://bugs.webkit.org/show_bug.cgi?id=112972

Reviewed by Adam Barth.

Source/WebCore:

Tests: fast/workers/shared-worker-storagequota-query-usage.html

fast/workers/worker-storagequota-query-usage.html

  • Modules/quota/WorkerNavigatorStorageQuota.cpp: Added.
  • Modules/quota/WorkerNavigatorStorageQuota.h: Added.
  • Modules/quota/WorkerNavigatorStorageQuota.idl: Added.
  • WebCore.gypi: Add entries for WorkerNavigatorStorageQuota.
  • page/WorkerNavigator.h: Add a Navigator supplement that extends the worker navigator.

LayoutTests:

  • fast/workers/resources/shared-worker-common.js:

(handleMessage): Allow port to be dynamically discovered from self.

  • fast/workers/resources/storagequota-query-usage.js: Added.

(worker.onmessage):

  • fast/workers/resources/worker-storagequota-query-usage.js: Added.

(requestUsage.errorCallback):
(requestUsage.usageCallback):
(requestUsage):

  • fast/workers/shared-worker-storagequota-query-usage-expected.txt: Added.
  • fast/workers/shared-worker-storagequota-query-usage.html: Added.
  • fast/workers/worker-storagequota-query-usage-expected.txt: Added.
  • fast/workers/worker-storagequota-query-usage.html: Added.
6:39 AM Changeset in webkit [146763] by mkwst@chromium.org
  • 15 edits in trunk

CSP 1.1: Rename SecurityPolicyViolationEvent::sourceURL to ::sourceFile.
https://bugs.webkit.org/show_bug.cgi?id=113033

Reviewed by Jochen Eisinger.

Source/WebCore:

Bringing our experimental implementation into line with the spec, which
has landed on the de facto standard name Gecko has been sending out for
years and years.

Spec: https://dvcs.w3.org/hg/content-security-policy/rev/e44f4003e158
Thread: http://lists.w3.org/Archives/Public/public-webappsec/2013Mar/0087.html

  • dom/SecurityPolicyViolationEvent.h:

(SecurityPolicyViolationEventInit):
(WebCore::SecurityPolicyViolationEvent::sourceFile):
(WebCore::SecurityPolicyViolationEvent::SecurityPolicyViolationEvent):
(SecurityPolicyViolationEvent):

  • dom/SecurityPolicyViolationEvent.idl:
  • page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):

s/sourceURL/sourceFile/

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script-expected.txt:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script-expected.txt:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html:
6:10 AM Changeset in webkit [146762] by Michelangelo De Simone
  • 8 edits
    20 adds in trunk

[CSS Filters] Using negative drop-shadow radius values has slow performance
https://bugs.webkit.org/show_bug.cgi?id=107848

Source/WebCore:

Setting negative blur radius values in drop-shadow() and box-shadow() led to
significant rendering performance loss. The invalid value overflowed and the
embedder became unresponsive for few seconds.
This impacted SVG too (SVGFEDropShadow and SVGFEGaussianBlur).

Reviewed by Dirk Schulze.

Tests: css3/filters/effect-drop-shadow-negative-radius.html

fast/box-shadow/box-shadow-parsing-invalid.html
svg/filters/feDropShadow-negative-deviation-expected.svg
svg/filters/feDropShadow-negative-deviation.svg
svg/filters/feDropShadow-zero-deviation.svg
svg/filters/feGaussianBlur-negative-deviation-expected.svg
svg/filters/feGaussianBlur-negative-deviation.svg
svg/filters/feGaussianBlur-zero-deviation.svg

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShadow): Negative values are skipped during parsing: as per
CSS Background and Borders specs, negative values shall not be allowed.

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::calculateUnscaledKernelSize): Added "non-negative" assertion for
negative deviations.

  • svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::build): If a negative standard deviation is encountered, don't
build the filter and returns earlier, this avoids unnecessary calls: FEGaussianBlur is not being
created with wrong and potentially overflowing values.

  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::build): Ditto.

LayoutTests:

Added a whole set of new tests for both CSS and SVG to assess the correctness of
blur(), drop-shadow() and box-shadow() blur radius values.

Reviewed by Dirk Schulze.

  • css3/filters/effect-drop-shadow-negative-radius-expected.html: Added.
  • css3/filters/effect-drop-shadow-negative-radius.html: Added.
  • css3/filters/filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/filter-property-parsing-invalid.js:
  • fast/box-shadow/box-shadow-parsing-invalid-expected.txt: Added.
  • fast/box-shadow/box-shadow-parsing-invalid.html: Added.
  • fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: Added.

(testInvalidFilterRule):

  • platform/chromium/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
  • platform/chromium/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
  • platform/chromium/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
  • platform/chromium/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
  • platform/mac/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
  • platform/mac/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
  • platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
  • platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
  • svg/filters/feDropShadow-negative-deviation-expected.svg: Added.
  • svg/filters/feDropShadow-negative-deviation.svg: Added.
  • svg/filters/feDropShadow-zero-deviation.svg: Added.
  • svg/filters/feGaussianBlur-negative-deviation-expected.svg: Added.
  • svg/filters/feGaussianBlur-negative-deviation.svg: Added.
  • svg/filters/feGaussianBlur-zero-deviation.svg: Added.
6:06 AM Changeset in webkit [146761] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] REGRESSION(r146630): 8 text related test asserts on debug builds
https://bugs.webkit.org/show_bug.cgi?id=113179

Reviewed by Jocelyn Turcotte.

Test if range.start is within the valid range before testing the value at that point.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::initFormatForTextLayout):

5:55 AM Changeset in webkit [146760] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Properly handle the rule addition to an XML or SVG document.
https://bugs.webkit.org/show_bug.cgi?id=113185

Reviewed by Pavel Feldman.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

5:38 AM Changeset in webkit [146759] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Web Inspector: support changing local variables in frontend
https://bugs.webkit.org/show_bug.cgi?id=112470

Patch by Peter Rybin <prybin@chromium.org> on 2013-03-25
Reviewed by Yury Semikhatsky.

Source/WebCore:

ScopeRef type is added to RemoteObject and setPropertyValue is patched accordingly.

Test: inspector/debugger/debugger-change-variable.html

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.CallFrame.prototype.get id):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate.didGetDetails):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromScopePayload):
(WebInspector.RemoteObject.prototype.):
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.setVariableValueCallback):
(WebInspector.RemoteObject.prototype._setDeclarativeVariableValue):
(WebInspector.ScopeRef):

  • inspector/front-end/ScopeChainSidebarPane.js:

(WebInspector.ScopeChainSidebarPane.prototype.update):

LayoutTests:

  • inspector/debugger/debugger-change-variable-expected.txt: Added.
  • inspector/debugger/debugger-change-variable.html: Added.
  • platform/chromium/inspector/debugger/debugger-change-variable-expected.txt: Added.
5:20 AM Changeset in webkit [146758] by mkwst@chromium.org
  • 5 edits
    3 copies
    8 adds in trunk

CSP 1.1: Strip URLs in SecurityPolicyViolationEvents, just as we do for POSTed violation reports.
https://bugs.webkit.org/show_bug.cgi?id=113039

Reviewed by Jochen Eisinger.

Source/WebCore:

I'd originally assumed that we didn't need to be quite so careful when
handing URLs to JavaScript via SecurityPolicyViolationEvents. This was
a mistake. Cross-origin URLs aren't accessible to JavaScript currently
and there's no reason that we should begin exposing them via an event.

This patch extracts the stripping logic from the existing reports into
stripURLForUseInReport(), and uses that new method when populating the
event and report objects.

Relatedly, we were doing the wrong thing with 'file:' URLs, which this
patch made clear. Now they're treated the same as 'data:' et al.

Spec: https://dvcs.w3.org/hg/content-security-policy/rev/45f6ccaba0ef

Tests: http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html

http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html
http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::stripURLForUseInReport):

Extract the logic from blockedURI out into a reusable method:
cross-origin URLs are stripped down to the ASCII serialization of
their origin, and non-heirarchical (and 'file:') URLs are stripped
down to the ASCII serialization of their protocol.

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):

Use ::stripURLForUseInReport for blockedURL and sourceFile
attributes in these two methods.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html:
  • http/tests/security/contentSecurityPolicy/resources/securitypolicyviolation-test.js: Added.

Updating tests to cover cross-origin scenarios: load cross-origin
images, and cross-origin scripts that inject images. The former
should strip the image URL down to the origin, the latter the
script URL.

  • http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html: Added.
  • platform/chromium/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.

This patch changes the behavior of 'file:' URLs to behave similarly
to 'data:'/'blob:', etc. We weren't previously testing this, now we
are. We need platform-specific results for Chromium and GTK, since
those ports have enabled CSP_NEXT, which adds a field to the report.

4:35 AM Changeset in webkit [146757] by eustas@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: Fix JSDocs.
https://bugs.webkit.org/show_bug.cgi?id=113025

Reviewed by Pavel Feldman.

Next version of JS compiler finds more inconsistencies
and ambiguous declarations.
Some of them are resolved in this patch.

  • inspector/InjectedScriptSource.js: Fix JSDocs.
  • inspector/front-end/ConsoleModel.js: Ditto.
  • inspector/front-end/CookieParser.js: Ditto.
  • inspector/front-end/FileContentView.js: Ditto.
  • inspector/front-end/HeapSnapshotView.js: Ditto.
  • inspector/front-end/IndexedDBModel.js: Ditto.
  • inspector/front-end/ProfilesPanelDescriptor.js: Ditto.
  • inspector/front-end/utilities.js: Ditto.
4:30 AM Changeset in webkit [146756] by zarvai@inf.u-szeged.hu
  • 196 edits
    1 copy
    14 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Making pixel test bot happier after r146206.

  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.png:
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.png:
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-offscreen-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.png:
  • platform/qt/fast/frames/frame-scrolling-attribute-expected.png:
  • platform/qt/fast/frames/frameset-style-recalc-expected.png:
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/qt/fast/frames/iframe-with-frameborder-expected.png:
  • platform/qt/fast/frames/viewsource-attribute-expected.png:
  • platform/qt/fast/gradients/background-clipped-expected.png:
  • platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
  • platform/qt/fast/gradients/crash-on-zero-radius-expected.png:
  • platform/qt/fast/gradients/radial-centered-expected.png:
  • platform/qt/fast/html/details-nested-1-expected.png:
  • platform/qt/fast/html/details-nested-2-expected.png:
  • platform/qt/fast/html/details-writing-mode-expected.png:
  • platform/qt/fast/html/font-weight-bold-for-b-and-strong-expected.png:
  • platform/qt/fast/html/link-rel-stylesheet-expected.png:
  • platform/qt/fast/html/listing-expected.png:
  • platform/qt/fast/html/marquee-scroll-expected.png:
  • platform/qt/fast/html/marquee-scrollamount-expected.png:
  • platform/qt/fast/images/image-map-anchor-children-expected.png:
  • platform/qt/fast/images/imagemap-circle-focus-ring-expected.png:
  • platform/qt/fast/images/imagemap-focus-ring-expected.png:
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.png:
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png:
  • platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/qt/fast/images/imagemap-polygon-focus-ring-expected.png:
  • platform/qt/fast/inline-block/001-expected.png:
  • platform/qt/fast/inline-block/002-expected.png:
  • platform/qt/fast/inline-block/003-expected.png:
  • platform/qt/fast/inline-block/006-expected.png:
  • platform/qt/fast/inline-block/14498-positionForCoordinates-expected.png:
  • platform/qt/fast/inline-block/contenteditable-baseline-expected.png:
  • platform/qt/fast/inline-block/tricky-baseline-expected.png:
  • platform/qt/fast/inline/25277-2-expected.png:
  • platform/qt/fast/inline/25277-expected.png:
  • platform/qt/fast/inline/continuation-outlines-with-layers-2-expected.png:
  • platform/qt/fast/inline/drawStyledEmptyInlines-expected.png:
  • platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/qt/fast/inline/emptyInlinesWithinLists-expected.png:
  • platform/qt/fast/inline/inline-continuation-borders-expected.png:
  • platform/qt/fast/inline/inline-focus-ring-expected.png:
  • platform/qt/fast/inline/inline-text-quirk-bpm-expected.png:
  • platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png:
  • platform/qt/fast/inline/long-wrapped-line-expected.png:
  • platform/qt/fast/inline/nested-top-alignment-expected.png:
  • platform/qt/fast/inline/vertical-align-text-bottom-expected.png:
  • platform/qt/fast/invalid/003-expected.png:
  • platform/qt/fast/invalid/004-expected.png:
  • platform/qt/fast/invalid/010-expected.png:
  • platform/qt/fast/invalid/014-expected.png:
  • platform/qt/fast/invalid/016-expected.png:
  • platform/qt/fast/invalid/019-expected.png:
  • platform/qt/fast/invalid/021-expected.png:
  • platform/qt/fast/invalid/missing-address-end-tag-expected.png:
  • platform/qt/fast/invalid/missing-dl-end-tag-expected.png:
  • platform/qt/fast/invalid/missing-dt-end-tag-expected.png:
  • platform/qt/fast/invalid/missing-font-end-tag-expected.png:
  • platform/qt/fast/invalid/nestedh3s-expected.png:
  • platform/qt/fast/invalid/td-inside-object-expected.png:
  • platform/qt/fast/layers/inline-dirty-z-order-lists-expected.png:
  • platform/qt/fast/layers/opacity-transforms-expected.png:
  • platform/qt/fast/layers/remove-only-this-layer-update-expected.png:
  • platform/qt/fast/line-grid/line-align-left-edges-expected.png:
  • platform/qt/fast/line-grid/line-align-right-edges-expected.png:
  • platform/qt/fast/line-grid/line-grid-floating-expected.png:
  • platform/qt/fast/line-grid/line-grid-into-floats-expected.png:
  • platform/qt/fast/line-grid/line-grid-positioned-expected.png:
  • platform/qt/fast/lists/001-expected.png:
  • platform/qt/fast/lists/001-vertical-expected.png:
  • platform/qt/fast/lists/002-expected.png:
  • platform/qt/fast/lists/002-vertical-expected.png:
  • platform/qt/fast/lists/007-expected.png:
  • platform/qt/fast/lists/007-vertical-expected.png:
  • platform/qt/fast/lists/008-expected.png:
  • platform/qt/fast/lists/008-vertical-expected.png:
  • platform/qt/fast/lists/anonymous-items-expected.png:
  • platform/qt/fast/lists/big-list-marker-expected.png:
  • platform/qt/fast/lists/li-br-expected.png:
  • platform/qt/fast/lists/li-style-alpha-huge-value-crash-expected.png:
  • platform/qt/fast/lists/list-item-line-height-expected.png:
  • platform/qt/fast/lists/list-style-none-crash-expected.png:
  • platform/qt/fast/lists/ol-display-types-expected.png:
  • platform/qt/fast/lists/ol-start-parsing-expected.png:
  • platform/qt/fast/lists/olstart-expected.png:
  • platform/qt/fast/multicol/block-axis-horizontal-bt-expected.png:
  • platform/qt/fast/multicol/block-axis-horizontal-tb-expected.png:
  • platform/qt/fast/multicol/block-axis-vertical-lr-expected.png:
  • platform/qt/fast/multicol/block-axis-vertical-rl-expected.png:
  • platform/qt/fast/multicol/client-rects-expected.png:
  • platform/qt/fast/multicol/column-break-with-balancing-expected.png:
  • platform/qt/fast/multicol/column-count-with-rules-expected.png:
  • platform/qt/fast/multicol/float-avoidance-expected.png:
  • platform/qt/fast/multicol/float-paginate-complex-expected.png:
  • platform/qt/fast/multicol/float-paginate-expected.png:
  • platform/qt/fast/multicol/layers-in-multicol-expected.png:
  • platform/qt/fast/multicol/margin-collapse-expected.png:
  • platform/qt/fast/multicol/max-height-columns-block-expected.png:
  • platform/qt/fast/multicol/overflow-across-columns-expected.png:
  • platform/qt/fast/multicol/overflow-unsplittable-expected.png:
  • platform/qt/fast/multicol/paginate-block-replaced-expected.png:
  • platform/qt/fast/multicol/positioned-split-expected.png:
  • platform/qt/fast/multicol/positive-leading-expected.png:
  • platform/qt/fast/multicol/progression-reverse-expected.png:
  • platform/qt/fast/multicol/shadow-breaking-expected.png:
  • platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.png:
  • platform/qt/fast/multicol/table-margin-collapse-expected.png:
  • platform/qt/fast/multicol/table-vertical-align-expected.png:
  • platform/qt/fast/multicol/unsplittable-inline-block-expected.png:
  • platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/qt/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-paginate-expected.png:
  • platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
  • platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/qt/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-paginate-expected.png:
  • platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
  • platform/qt/fast/overflow/001-expected.png:
  • platform/qt/fast/overflow/002-expected.png:
  • platform/qt/fast/overflow/003-expected.png:
  • platform/qt/fast/overflow/004-expected.png:
  • platform/qt/fast/overflow/007-expected.png:
  • platform/qt/fast/overflow/008-expected.png:
  • platform/qt/fast/overflow/dynamic-hidden-expected.png:
  • platform/qt/fast/overflow/float-in-relpositioned-expected.png:
  • platform/qt/fast/overflow/hidden-scrollbar-resize-expected.png:
  • platform/qt/fast/overflow/line-clamp-expected.png:
  • platform/qt/fast/overflow/overflow-auto-table-expected.png:
  • platform/qt/fast/overflow/overflow-float-stacking-expected.png:
  • platform/qt/fast/overflow/overflow-focus-ring-expected.png:
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/qt/fast/overflow/overflow-stacking-expected.png:
  • platform/qt/fast/overflow/paged-x-div-with-column-gap-expected.png:
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/qt/fast/overflow/scrollbar-position-update-expected.png:
  • platform/qt/fast/overflow/table-overflow-float-expected.png:
  • platform/qt/fast/overflow/trailing-float-linebox-expected.png:
  • platform/qt/fast/parser/001-expected.png:
  • platform/qt/fast/parser/broken-comments-vs-parsing-mode-expected.png:
  • platform/qt/fast/parser/entity-comment-in-style-expected.png:
  • platform/qt/fast/parser/nofoo-tags-inside-paragraph-expected.png:
  • platform/qt/fast/parser/open-comment-in-style-expected.png:
  • platform/qt/fast/reflections/inline-crash-expected.png:
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.png:
  • platform/qt/fast/reflections/reflection-masks-expected.png:
  • platform/qt/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/qt/fast/reflections/reflection-masks-outset-expected.png:
  • platform/qt/fast/reflections/reflection-nesting-expected.png:
  • platform/qt/fast/reflections/reflection-overflow-hidden-expected.png:
  • platform/qt/fast/regions/flow-content-basic-expected.png:
  • platform/qt/fast/regions/flow-content-basic-vertical-expected.png:
  • platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.png:
  • platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png:
  • platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.png:
  • platform/qt/fast/regions/overflow-in-variable-width-regions-expected.png:
  • platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.png:
  • platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
  • platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png:
  • platform/qt/fast/regions/region-style-block-background-color-expected.png:
  • platform/qt/fast/regions/region-style-block-background-color2-expected.png:
  • platform/qt/fast/regions/text-region-split-small-pagination-expected.png:
  • platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png:
  • platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.png:
  • platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png:
  • platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.png:
  • platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
  • platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png:
  • platform/qt/fast/repaint/background-misaligned-expected.png:
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/qt/fast/repaint/focus-layers-expected.png:
  • platform/qt/fast/repaint/scale-page-shrink-expected.png:
  • platform/qt/fast/repaint/transform-absolute-child-expected.png:
  • platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/qt/fast/repaint/transform-relative-position-expected.png:
  • platform/qt/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/qt/fast/replaced/004-expected.png:
  • platform/qt/fast/replaced/absolute-position-percentage-height-expected.png:
  • platform/qt/fast/replaced/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/qt/fast/replaced/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/qt/fast/replaced/applet-display-none-expected.png:
  • platform/qt/fast/replaced/image-resize-width-expected.png:
4:05 AM Changeset in webkit [146755] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

Cleanup: Tiny nits in ContentSecurityPolicy::reportViolation.
https://bugs.webkit.org/show_bug.cgi?id=112784

Reviewed by Jochen Eisinger.

Just cleanup of three tiny nits I ran across in
ContentSecurityPolicy::reportViolation while doing other work.

  • 'directiveText' and 'effectiveDirective' can't be empty; we pass in values at every callsite. We can safely remove the 'isEmpty()' checks. Moreover, even if they could possibly somehow be empty, we should still include those empty strings in the report, rather than dropping the values entirely.
  • We don't need to hold 'document->referrer()' in a temp variable.
  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):

3:55 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com
(diff)
3:28 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
3:26 AM Changeset in webkit [146754] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

E: webkitgtk3 missing-sentinel Source/[...]/TestMain.cpp:47 g_build_filename takes a NULL sentinel.
https://bugs.webkit.org/show_bug.cgi?id=113036

Patch by Dominique Leuenberger <dimstar@opensuse.org> on 2013-03-25
Reviewed by Martin Robinson.

  • UIProcess/API/gtk/tests/TestMain.cpp:

(removeNonEmptyDirectory):

2:50 AM Changeset in webkit [146753] by eustas@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Overview] Make "drag-to-move" feature more discoverable.
https://bugs.webkit.org/show_bug.cgi?id=113032

Reviewed by Pavel Feldman.

To move overview window user could drag-n-drop over
time "ribbon" on OverviewGrid.

This feature is hard to discover.

Setting "move" cursor will make this feature more discoverable.

  • inspector/front-end/inspectorCommon.css:

Set "move" cursor to draggable area.

  • inspector/front-end/OverviewGrid.js: Ditto.
2:33 AM Changeset in webkit [146752] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Profiles] Remove unused private member.
https://bugs.webkit.org/show_bug.cgi?id=113015

Reviewed by Pavel Feldman.

_profileGroupsForLinks is not used anymore.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._reset): Removed unused member.

2:33 AM Changeset in webkit [146751] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardneing. Skip two tests, because they are failing with timed out.

  • platform/qt/TestExpectations:
2:01 AM Changeset in webkit [146750] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Mark fast/css/font-family-pictograph.html as flaky on Linux

  • platform/chromium/TestExpectations:
1:55 AM Changeset in webkit [146749] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Exception when turning on pretty print without any displayed source in the editor
https://bugs.webkit.org/show_bug.cgi?id=113136

Patch by PhistucK <phistuck@chromium.org> on 2013-03-25
Reviewed by Vsevolod Vlasov.

No new tests.
Added a check for the existence of currently edited document.

  • inspector/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

1:47 AM Changeset in webkit [146748] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

[CSSRegions] Remove RenderRegion::printRegionObjectsStyles
https://bugs.webkit.org/show_bug.cgi?id=113081

Reviewed by Tony Chang.

No change in functionality, remove unused function..

  • rendering/RenderRegion.h:
1:45 AM Changeset in webkit [146747] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Texmap] Memory leak when closing a tab
https://bugs.webkit.org/show_bug.cgi?id=112127

Patch by Hurnjoo Lee <hurnjoo.lee@samsung.com> on 2013-03-25
Reviewed by Noam Rosenthal.

When closing a tab, if there are any updates pending in CoordinatedGraphicsScene's
render queue, the scene is not freed because reference count of m_scene is not zero.

No new tests.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::detach): When bind updates in CoordinatedGraphicsScene,
the reference count of m_scene is increasing, if m_renderQueue is not empty
before closing tab, then m_scene is never freed.
Hence, when closing tab, need to clear m_renderQueue explicitly in order to
destroy m_scene.

1:21 AM Changeset in webkit [146746] by keishi@webkit.org
  • 3 edits
    10 adds in trunk

Clear button visibility is not updated when restoring form state
https://bugs.webkit.org/show_bug.cgi?id=113172

Source/WebCore:

Clear button wasn't showing up when restoring form state.

Reviewed by Kent Tamura.

Tests: fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html

fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState):

LayoutTests:

Reviewed by Kent Tamura.

  • fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html: Added.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html: Added.
12:45 AM Changeset in webkit [146745] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Settings] Use registry to track settings objects.
https://bugs.webkit.org/show_bug.cgi?id=113008

Reviewed by Pavel Feldman.

Currently .createSetting creates new instance any time it is invoked.
When one instance saves value, the other instance do not know about it.

To resolve this issue we can use registry to make .createSetting return
same object for specific key.

  • inspector/front-end/Settings.js:

(WebInspector.Settings.prototype.createSetting): Use registry.

Mar 24, 2013:

9:58 PM Changeset in webkit [146744] by falken@chromium.org
  • 9 edits in trunk/Source/WebCore

Refactoring: Pull Node::disabled() and Node::isInert() down to Element.
https://bugs.webkit.org/show_bug.cgi?id=112085

Reviewed by Hajime Morrita.

Node is too low a level for these methods. The plan is to rename
Element::disabled to isDisabledFormControl and to remove
Element::isEnabledFormControl.

No new tests, just refactoring.

  • dom/Element.cpp:

(WebCore::Element::disabled):
(WebCore):
(WebCore::Element::isInert):

  • dom/Element.h:

(Element):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchSimulatedClick):

  • dom/GestureEvent.cpp:

(WebCore::GestureEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/Node.cpp:

(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):

  • dom/Node.h:

(Node):

9:27 PM Changeset in webkit [146743] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark canvas-toDataURL-webp.html imageOnlyFailure
https://bugs.webkit.org/show_bug.cgi?id=113169

Unreviewed test expectations update.

Start generating test images on the bots now that libwebp 0.3.0
has landed in chromium webkit.

  • platform/chromium/TestExpectations:
8:55 PM Changeset in webkit [146742] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] fast/text/international/danda-space.html is failing
https://bugs.webkit.org/show_bug.cgi?id=113169

Unreviewed test expectations update.

  • platform/chromium/TestExpectations:
7:15 PM Changeset in webkit [146741] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146740 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=113113

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-24
Reviewed by Gustavo Noronha Silva (kov).

  • pl.po: updated translation.
7:14 PM Changeset in webkit [146740] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=113113

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-24
Reviewed by Gustavo Noronha Silva (kov).

  • pl.po: updated translation.
6:57 PM Changeset in webkit [146739] by danakj@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Roll chromium deps to 190311.
https://bugs.webkit.org/show_bug.cgi?id=113161

Unreviewed, rolling deps.

  • DEPS:
5:38 PM Changeset in webkit [146738] by hayato@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Shadow] Add a test of insertionParent for <shadow> element.
https://bugs.webkit.org/show_bug.cgi?id=113021

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/insertion-parent-shadow-expected.txt: Added.
  • fast/dom/shadow/insertion-parent-shadow.html: Added.
5:36 PM Changeset in webkit [146737] by hclam@chromium.org
  • 4 edits in trunk/Source

GIFImageReader should reports parsing error to client
https://bugs.webkit.org/show_bug.cgi?id=113141

Reviewed by Stephen White.

Source/WebCore:

GIFImageReader nows reports parsing error to client (GIFImageDecoder) such that errors can be handled.
In the case of corrupted GIF images GIFImageReader will be deleted and decoding will fail.

Unit test is updated to reflect change in behavior.
Tested with a local corpus which showed better handling of corrupted GIF images.

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::decode):

Source/WebKit/chromium:

Updated unit test that runs on a broken GIF image file, decoding should fail.

  • tests/GIFImageDecoderTest.cpp:

(WebKit::TEST):

4:37 PM Changeset in webkit [146736] by jamesr@google.com
  • 5 edits in trunk/Source

[chromium] Wire windows scrollByPage enum up to compositor thread input handling
https://bugs.webkit.org/show_bug.cgi?id=113117

Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebInputHandlerClient.h:

Source/WebKit/chromium:

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):

  • tests/WebCompositorInputHandlerImplTest.cpp:

(MockWebInputHandlerClient):

4:15 PM Changeset in webkit [146735] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r190276. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-24

  • DEPS:
3:45 PM Changeset in webkit [146734] by mhahnenberg@apple.com
  • 12 edits
    2 adds in trunk/Source/JavaScriptCore

HandleSet should use HeapBlocks for storing handles
https://bugs.webkit.org/show_bug.cgi?id=113145

Reviewed by Geoffrey Garen.

  • GNUmakefile.list.am: Build project changes.
  • JavaScriptCore.gypi: Ditto.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Ditto.
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • heap/BlockAllocator.cpp: Rename the RegionSet to m_fourKBBlockRegionSet because there are

too many block types to include them all in the name now.
(JSC::BlockAllocator::BlockAllocator):

  • heap/BlockAllocator.h:

(BlockAllocator): Add the appropriate override for regionSetFor.
(JSC::WeakBlock):
(JSC::MarkStackSegment):
(JSC::HandleBlock):

  • heap/HandleBlock.h: Added.

(HandleBlock): New class for HandleBlocks.
(JSC::HandleBlock::blockFor): Static method to get the block of the given HandleNode pointer. Allows
us to quickly figure out which HandleSet the HandleNode belongs to without storing the pointer to it
in the HandleNode.
(JSC::HandleBlock::handleSet): Getter.

  • heap/HandleBlockInlines.h: Added.

(JSC::HandleBlock::create):
(JSC::HandleBlock::HandleBlock):
(JSC::HandleBlock::payloadEnd):
(JSC::HandleBlock::payload):
(JSC::HandleBlock::nodes):
(JSC::HandleBlock::nodeAtIndex):
(JSC::HandleBlock::nodeCapacity):

  • heap/HandleSet.cpp:

(JSC::HandleSet::~HandleSet):
(JSC::HandleSet::grow):

  • heap/HandleSet.h:

(HandleNode): Move the internal Node class from HandleSet to be its own public class so it can be
used by HandleBlock.
(HandleSet): Add a typedef so that Node refers to the new HandleNode class.
(JSC::HandleSet::toHandle):
(JSC::HandleSet::toNode):
(JSC::HandleSet::allocate):
(JSC::HandleSet::deallocate):
(JSC::HandleNode::HandleNode):
(JSC::HandleNode::slot):
(JSC::HandleNode::handleSet): Use the new blockFor static function to get the right HandleBlock and lookup
the HandleSet.
(JSC::HandleNode::setPrev):
(JSC::HandleNode::prev):
(JSC::HandleNode::setNext):
(JSC::HandleNode::next):
(JSC::HandleSet::forEachStrongHandle):

  • heap/Heap.h: Friend HandleSet so that it can access the BlockAllocator when allocating HandleBlocks.
12:16 PM Changeset in webkit [146733] by kareng@chromium.org
  • 9 edits
    2 copies in branches/chromium/1451/Source/WebCore

Revert 146458 "[EFL][WebGL] Implement a common GraphicsSurface I..."

[EFL][WebGL] Implement a common GraphicsSurface Implementation.
https://bugs.webkit.org/show_bug.cgi?id=111759

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-21
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

This is in preparation to add transport surface support for GLES2.
This patch makes it easy to share the core logic of using
Transport Surface and client on GLX and GLES2 backends without
any code duplication.

  • PlatformEfl.cmake:
  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::releaseResources):
(WebCore::GraphicsContext3DPrivate::prepareBuffer):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::didResizeCanvas):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):

  • platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

TransportSurface related code is moved to GraphicsSurfaceCommon.
As GraphicsSurface is deleted on resize, added logic to ensure that
current buffer is not deleted before having the shared buffer
with correct size. This would avoid any flashing during resize.

  • platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::createTransportSurface):

  • platform/graphics/opengl/GLPlatformSurface.h:
  • platform/graphics/surfaces/efl/GLTransportSurface.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp.

(WebCore):
(WebCore::GLTransportSurface::GLTransportSurface):
(WebCore::GLTransportSurface::~GLTransportSurface):
(WebCore::GLTransportSurface::updateContents):
(WebCore::GLTransportSurface::setGeometry):
(WebCore::GLTransportSurface::destroy):
(WebCore::GLTransportSurface::draw):
(WebCore::GLTransportSurface::bindArrayBuffer):
(WebCore::GLTransportSurface::updateTransformationMatrix):
(WebCore::GLTransportSurface::initializeShaderProgram):
(WebCore::GLTransportSurfaceClient::createTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::~GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::destroy):
(WebCore::GLTransportSurfaceClient::prepareTexture):
(WebCore::GLTransportSurfaceClient::createTexture):

  • platform/graphics/surfaces/efl/GLTransportSurface.h: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.h.

(WebCore):
(GLTransportSurface):
(GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::texture):
(WebCore::GLTransportSurfaceClient::hasAlpha):

Moved TransportSurface to EFL folder as this is being used by EFL port only.
Added a base class for TransportSurfaceClient.

  • platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp: Added.

(WebCore):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::destroy):
(WebCore::GraphicsSurfacePrivate::initializeTransportSurface):
(WebCore::GraphicsSurfacePrivate::makeContextCurrent):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::handle):
(WebCore::GraphicsSurfacePrivate::updateClientBuffer):
(WebCore::GraphicsSurfacePrivate::flags):
(WebCore::GraphicsSurfacePrivate::rect):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::textureId):
(WebCore::GraphicsSurfacePrivate::initializeClient):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromTexture):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformSize):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):

GraphicsSurface implementation to be shared by both GLX and GLES2.

  • platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):

  • platform/graphics/surfaces/egl/EGLSurface.h:

(EGLWindowTransportSurface):

  • platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore):
(WebCore::resolveGLMethods):
(WebCore::isMesaGLX):
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurfaceClient::GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::~GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::destroy):
(WebCore::GLXTransportSurfaceClient::prepareTexture):

  • platform/graphics/surfaces/glx/GLXSurface.h:

(GLXTransportSurface):
(GLXTransportSurfaceClient):
(WebCore):
GLXTransportSurfaceClient implementation.

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13046002

12:13 PM Changeset in webkit [146732] by kareng@chromium.org
  • 1 add in branches/chromium/1451/codereview.settings

for drovering

12:12 PM Changeset in webkit [146731] by kareng@chromium.org
  • 1 copy in branches/chromium/1451

branching to revert a change for canary.

8:57 AM Changeset in webkit [146730] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[EFL] Add support to check for current Drawable.
https://bugs.webkit.org/show_bug.cgi?id=113103

Patch by KondapallyKalyan <kalyan.kondapally@intel.com> on 2013-03-24
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

In MakeCurrent we do an early return if it is
the current GL context but ignore Surface. This
patch fixes the issue, we now check for both
context and surface before doing an early return
in MakeCurrent.

  • platform/graphics/opengl/GLPlatformContext.cpp:

(WebCore::GLPlatformContext::makeCurrent):
(WebCore::GLPlatformContext::releaseCurrent):
(WebCore::GLPlatformContext::destroy):

  • platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore):
(WebCore::GLPlatformSurface::isCurrentDrawable):
(WebCore::GLPlatformSurface::onMakeCurrent):

  • platform/graphics/opengl/GLPlatformSurface.h:
8:47 AM Changeset in webkit [146729] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r146704): Settings::setHiddenPageDOMTimerThrottlingEnabled() isn't always built
<http://webkit.org/b/112308>

  • WebCore.exp.in: Export

Settings::setHiddenPageDOMTimerThrottlingEnabled()
conditionally based on ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING).

7:43 AM Changeset in webkit [146728] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

[EFL] NetworkStateNotifier::updateState() is called too often
https://bugs.webkit.org/show_bug.cgi?id=113152

Reviewed by Kenneth Rohde Christiansen.

Wait until we have read all the data on the Netlink socket before
reporting a possible network interface change. This way, we make
sure we don't call NetworkStateNotifier::updateState() several
times in a row for no reason.

We also call NetworkStateNotifier::updateState() only if we get a
RTM_NEWADDR event and we are currently offline, or if we get a
RTM_DELADDR and we are currently online. This avoids calling
NetworkStateNotifier::updateState() uselessly as there is no way
the online state can change otherwise.

No new tests, no behavior change for layout tests.

  • platform/network/efl/NetworkStateNotifierEfl.cpp:

(WebCore::NetworkStateNotifier::readSocketCallback):

3:36 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
2:20 AM Changeset in webkit [146727] by Chris Fleizach
  • 5 edits
    2 adds in trunk

AX: Crash in WebCore::AccessibilitySpinButton::incrementButton()
https://bugs.webkit.org/show_bug.cgi?id=111582

Reviewed by Tim Horton.

Source/WebCore:

There are two ways to create a spin button: from a textfield counter or from ARIA.
If an ARIA spin button is created, it was returning true for isSpinButton, so we were
casting to the other kind of spin button, leading to a crash.

We need to be more specific about our class types.

Test: platform/mac/accessibility/aria-spinbutton-crash.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isNativeSpinButton):

  • accessibility/AccessibilitySpinButton.h:

(WebCore::AccessibilitySpinButton::isNativeSpinButton):
(WebCore::toAccessibilitySpinButton):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

  • platform/mac/accessibility/aria-spinbutton-crash-expected.txt: Added.
  • platform/mac/accessibility/aria-spinbutton-crash.html: Added.
12:37 AM Changeset in webkit [146726] by Chris Fleizach
  • 34 edits in trunk/Source/WebCore

AXObjectCache gets recreated during document tear-down.
https://bugs.webkit.org/show_bug.cgi?id=112525

Reviewed by Simon Fraser.

In many cases, a document's AXObjectCache was being created after the
document had detached, which is wasteful and could potentially lead to
crashes because the AXObjectCache has a timer and relies on its document
to exist.

This patch provides a way to get the existing AX object cache, instead of
always creating a new one.
It moves the accessibilityEnabled() checks into the axObjectCache retrieval
for easier readability.
It adds a number of ASSERTs to vieryf that only the correct (top) document is used
for cache manipulation.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::~ContainerNode):

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::existingAXObjectCache):
(WebCore::Document::axObjectCache):
(WebCore::Document::setFocusedNode):

  • dom/Document.h:

(Document):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::isEditableToAccessibility):
(WebCore::Node::attach):
(WebCore::Node::rootEditableElement):
(WebCore::Node::didMoveToNewDocument):

  • editing/AppendNodeCommand.cpp:

(WebCore::sendAXTextChangedIgnoringLineBreaks):

  • editing/DeleteFromTextNodeCommand.cpp:

(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):

  • editing/Editor.cpp:

(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::markAndReplaceFor):

  • editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):

  • editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):

  • editing/atk/FrameSelectionAtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

  • editing/chromium/FrameSelectionChromium.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

  • editing/mac/FrameSelectionMac.mm:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setChecked):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::optionElementChildrenChanged):
(WebCore::HTMLSelectElement::setRecalcListItems):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setInnerTextValue):

  • html/InputType.cpp:

(WebCore::InputType::applyStep):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

  • page/FocusController.cpp:

(WebCore::FocusController::setInitialFocus):

  • page/Frame.cpp:

(WebCore::Frame::disconnectOwnerElement):

  • page/FrameView.cpp:

(WebCore::FrameView::removeFromAXObjectCache):
(WebCore::FrameView::layout):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::axObjectCache):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::~Scrollbar):
(WebCore):
(WebCore::Scrollbar::existingAXObjectCache):

  • platform/Scrollbar.h:

(Scrollbar):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::createRootInlineBox):
(WebCore::RenderBlock::createAndAppendRootInlineBox):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::selectionChanged):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::addChild):
(WebCore::RenderMenuList::didUpdateActiveOption):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

  • rendering/RenderText.cpp:

(WebCore::RenderText::setText):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::willBeDestroyed):

Note: See TracTimeline for information about the timeline view.