Timeline
Mar 29, 2013:
- 10:20 PM Changeset in webkit [147273] by
-
- 1 edit in branches/chromium/1453/Source/WebCore/inspector/front-end/timelinePanel.css
Merge 146849 "Web Inspector: [Timeline] Records sidebar is clipped."
BUG=222683
Web Inspector: [Timeline] Records sidebar is clipped.
https://bugs.webkit.org/show_bug.cgi?id=113177
Reviewed by Pavel Feldman.
Analysis: depending on CSS injection order sidebar rule that overwrites
"bottom" property may win.
Fix: make timeline-specific rule "important".
- inspector/front-end/timelinePanel.css:
(.timeline .sidebar): Make "bottom" value "important".
TBR=eustas@chromium.org
Review URL: https://codereview.chromium.org/13383002
- 10:12 PM Changeset in webkit [147272] by
-
- 4 edits in branches/chromium/1453
Merge 147028 "REGRESSION (r146588): Cannot correctly display Chi..."
BUG=223503
REGRESSION (r146588): Cannot correctly display Chinese SNS Renren
https://bugs.webkit.org/show_bug.cgi?id=113142
Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-27
Reviewed by Pavel Feldman.
Source/WebCore:
Changed CSS grammar to be equivalent to pre-r146588.
CSS error reporting disabled to prevent message overflow.
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::isLoggingErrors):
LayoutTests:
- TestExpectations:
- fast/css/parsing-error-recovery.html:
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13382002
- 9:51 PM Changeset in webkit [147271] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
Unreviewed, release mode build fix.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
- 9:41 PM Changeset in webkit [147270] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Change DO_NOT_INCLUDE_LLVM_CPP_HEADERS to LLVM_DO_NOT_INCLUDE_CPP_HEADERS
https://bugs.webkit.org/show_bug.cgi?id=113634
Reviewed by Dan Bernstein.
- ftl/FTLLLVMHeaders.h:
- 9:15 PM Changeset in webkit [147269] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL JIT should be able run some simple function
https://bugs.webkit.org/show_bug.cgi?id=113481
Reviewed by Geoffrey Garen.
I forgot to make a couple of the requested review changes, so I'm making
them now!
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLJITCode.h:
- 7:54 PM Changeset in webkit [147268] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Unreviewed build fix after r147251
https://bugs.webkit.org/show_bug.cgi?id=113631
Unreviewed build fix.
Add NETWORK_PROCESS guard.
Patch by Seokju Kwon <Seokju Kwon> on 2013-03-29
- UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):
- 7:08 PM Changeset in webkit [147267] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r147263.
http://trac.webkit.org/changeset/147263
https://bugs.webkit.org/show_bug.cgi?id=113632
Breaks test fast/loader/display-image-unset-allows-cached-
image-load.html (Requested by mlam on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-29
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::freshnessLifetime):
- 6:49 PM Changeset in webkit [147266] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. AppleWin VS2010 build fix.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 5:51 PM Changeset in webkit [147265] by
-
- 5 edits2 adds in trunk/Source/WebCore
When releasing a CGImage, we should also remove it from the subimage cache.
https://bugs.webkit.org/show_bug.cgi?id=102453
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-03-29
Reviewed by Simon Fraser.
When we release an image(CGImageRef) from BitmapImage's cachedFrames, if the image was already
cached in subimage cache, it's ref count won't drop to 0 and the image won't be deleted. Usually,
the subimage cache will clear the whole cache in a timer with 1 sec delay. However, if WebCore has
to paint another subimage (not necessarily from the same CGImageRef) before this timer fires, we
will restart the timer and images inside the cache will stay longer than they should.
This patch does two things:
- move SubimageCacheWithTimer and related helper struct into a separate file.
- remove the image from subimage cache when we releasing the CGImageRef, this prevent subimage
cache holding the image after we released it.
No new tests, manually verified the CGImageRef is also removed from subimage cache
when we releasing the image from FrameData::clear.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::FrameData::clear): remove the image from subimage cache before we releasing it.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore):
(WebCore::GraphicsContext::drawNativeImage):
- platform/graphics/cg/SubimageCacheWithTimer.cpp: Added.
(WebCore):
(SubimageRequest):
(WebCore::SubimageRequest::SubimageRequest):
(WebCore::SubimageCacheAdder::hash):
(SubimageCacheAdder):
(WebCore::SubimageCacheAdder::equal):
(WebCore::SubimageCacheAdder::translate):
(WebCore::SubimageCacheWithTimer::SubimageCacheWithTimer):
(WebCore::SubimageCacheWithTimer::invalidateCacheTimerFired):
(WebCore::SubimageCacheWithTimer::getSubimage):
(WebCore::SubimageCacheWithTimer::clearImage):
(WebCore::subimageCache):
- platform/graphics/cg/SubimageCacheWithTimer.h: Added.
(WebCore):
(SubimageCacheWithTimer): Added a data member m_images to record which image and its subimages are cached.
(SubimageCacheEntry):
(SubimageCacheEntryTraits):
(WebCore::SubimageCacheWithTimer::SubimageCacheEntryTraits::isEmptyValue):
(WebCore::SubimageCacheWithTimer::SubimageCacheEntryTraits::constructDeletedValue):
(WebCore::SubimageCacheWithTimer::SubimageCacheEntryTraits::isDeletedValue):
(WebCore::SubimageCacheWithTimer::SubimageCacheHash::hash):
(WebCore::SubimageCacheWithTimer::SubimageCacheHash::equal):
(SubimageCacheHash):
- 5:19 PM Changeset in webkit [147264] by
-
- 4 edits2 adds in branches/dfgFourthTier
fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
https://bugs.webkit.org/show_bug.cgi?id=113452
Rubber stamped by Mark Hahnenberg.
Tools:
- Scripts/copy-webkitlibraries-to-product-directory:
- Scripts/export-llvm-build:
WebKitLibraries:
- LLVMIncludesMountainLion.tar.bz2: Added.
- LLVMLibrariesMountainLion.tar.bz2: Added.
- 5:04 PM Changeset in webkit [147263] by
-
- 2 edits in trunk/Source/WebCore
Let cached resources from file: schemes expire immediately
https://bugs.webkit.org/show_bug.cgi?id=113626
Reviewed by Brady Eidson
When a CachedResource was loaded from a file: URL, we would give it an
indefinite freshness lifetime. This means that we would continue to
serve a stale resource from the memory cache even if the file was
changed on disk. With the introduction of main resource caching, this
behavior broke at least one third-party WebKit app (see <rdar://problem/13313769>).
We should instead let file resources expire immediately. Modern
filesystems implement their own caching, so we should get good
performance for multiple reads of unmodified files without doing our
own caching.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::freshnessLifetime): file: URLs should have a
0 freshness lifetime.
- 4:41 PM Changeset in webkit [147262] by
-
- 4 edits in tags/Safari-537.35.4/Source/WebKit2
Merged r147257. <rdar://problem/13531679>
- 4:32 PM Changeset in webkit [147261] by
-
- 20 edits2 deletes in trunk
Source/WebCore: Flexitems no longer default min-width to min-content
https://bugs.webkit.org/show_bug.cgi?id=111790
Reviewed by Tony Chang.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
Disallow auto as a valid min-size value.
- css/html.css:
(input::-webkit-datetime-edit):
(input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container):
(input[type="range"]::-webkit-slider-runnable-track):
Remove now unnecessary min-width: 0's.
- css/mediaControlsChromium.css:
(audio::-webkit-media-controls-enclosure, video::-webkit-media-controls-enclosure):
(video::-webkit-media-controls-enclosure):
Set a flex-shrink: 0 to avoid shrinking these items below the designated height.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::constrainLogicalHeightByMinMax):
(WebCore::RenderBox::constrainContentBoxLogicalHeightByMinMax):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computeContentLogicalHeight):
(WebCore::RenderBox::computeContentAndScrollbarLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
Remove all the unneeded SizeType arguments now that we don't need to
specially handle MinSize in all these functions.
- rendering/RenderBox.h:
- rendering/RenderButton.cpp:
(WebCore::RenderButton::styleWillChange):
(WebCore::RenderButton::setupInnerStyle):
No longer need to explicitly set min-width:0.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
Remove the code for specially handling auto.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::maxPageLogicalHeight):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
Remove all the now unneeded SizeType arguments.
- rendering/style/RenderStyle.h:
Change the default min-size back to 0.
Source/WebKit2: Crash when "willSendRequest" causes the ResourceLoader to be cancelled.
<rdar://problem/13531679> and https://bugs.webkit.org/show_bug.cgi?id=113616
Patch by Brady Eidson <beidson@apple.com> on 2013-03-29
Reviewed by Alexey Proskuryakov.
These callbacks to the WebCore ResourceLoader can cause the WebResourceLoader to be destroyed.
A RefPtr<> protector fixes that.
Additionally we can invalidate the WebResourceLoader to avoid unnecessary callbacks to the NetworkProcess.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::remove): Call detachFromCoreLoader() on a removed WebResourceLoader.
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::detachFromCoreLoader): Clear out the ResourceLoader pointer.
(WebKit::WebResourceLoader::willSendRequest): Protect this, and don't message back to the NetworkProcess if its not needed.
(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace): Ditto
(WebKit::WebResourceLoader::didReceiveResource): Paranoid hardening - Protect this before delivering the data to the WebCore
ResourceLoader, and null check it before delivering the "didFinishLoader" call.
- WebProcess/Network/WebResourceLoader.h:
LayoutTests: Flexitems no longer default min-width to min-content
https://bugs.webkit.org/show_bug.cgi?id=111790
Reviewed by Tony Chang.
- css3/flexbox/content-height-with-scrollbars.html:
- css3/flexbox/cross-axis-scrollbar.html:
Set flex:none to avoid flex-shrinking.
- css3/flexbox/flex-item-min-size-expected.txt: Removed.
- css3/flexbox/flex-item-min-size.html: Removed.
These tests are now redundant with tests in fast/css-intrinsic-dimensions.
- css3/flexbox/flexbox-baseline.html:
Set flex:none to avoid flex-shrinking.
- css3/flexbox/line-wrapping.html:
Auto-size the flex items so that the column flexboxes have an auto-height.
- css3/flexbox/preferred-widths.html:
Set flex:none to avoid flex-shrinking.
- fast/css/auto-min-size-expected.txt:
- fast/css/auto-min-size.html:
Update to no longer allow parsing auto as a valid value for min-width/min-height.
- 4:30 PM Changeset in webkit [147260] by
-
- 15 edits in trunk
Expose FeatureObserver data to WebKit clients
https://bugs.webkit.org/show_bug.cgi?id=113613
Reviewed by Sam Weinig.
FeatureObserver used to depend on chromium-only HistogramSupport, which is not
really usable on Mac at least.
Instead of adding parallel feature reporting machinery, I'm adding a way to
generically relay the data from FeatureObserver to port code.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::reportMemoryUsage):
- loader/FrameLoader.h: (WebCore::FrameLoader::previousURL): Exposed m_previousURL, renaming it to follow WebKit style.
- page/FeatureObserver.cpp: (WebCore::FeatureObserver::~FeatureObserver): (WebCore::FeatureObserver::updateMeasurements):
- page/FeatureObserver.h: (WebCore::FeatureObserver::accumulatedFeatureBits): Exposed the data to clients, and made reporting through HistogramSupport chromium only for clarity.
- 4:28 PM Changeset in webkit [147259] by
-
- 16 edits14 adds in branches/dfgFourthTier
fourthTier: FTL JIT should be able run some simple function
https://bugs.webkit.org/show_bug.cgi?id=113481
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
This is the initial version of the FTL JIT (Fourth Tier LLVM JIT).
It includes a lowering from the DFG IR to LLVM IR (FTL::lowerDFGToLLVM)
and a "backend" step that invokes the LLVM and wraps the resulting
function in a thunk (FTL::compile).
All LLVM IR building functions are wrapped up into a nicer FTL API.
First they're wrapped in an abbreviated API (FTLAbbreviations.h) and
then again into an object-oriented IR builder (FTLOutput.h).
This runs things. I don't know how fast it runs things. And I don't
make any claims of stability. The FTL is runtime-disabled by default;
you will enable it by doing --useExperimentalFTL=true. Probably if you
do this, you will run slower, because of the heavy thunking we do, the
fact that we don't have anything resembling a sensible tiering story,
and because we only compile ridiculously tiny functions.
Finally, this still requires a custom set of LLVM headers to build.
I am working on getting that up-streamed to LLVM, and separately I'll
make sure that we have a build checked into this branch.
- Configurations/JavaScriptCore.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/Operands.h:
(Operands):
(JSC::Operands::Operands):
- dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::needsTypeCheck):
(AbstractState):
(JSC::DFG::AbstractState::filterEdgeByUse):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::needsTypeCheck):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(DFG):
- dfg/DFGUseKind.h:
(JSC::DFG::shouldNotHaveTypeCheck):
(DFG):
(JSC::DFG::mayHaveTypeCheck):
(JSC::DFG::isDouble):
(JSC::DFG::isCell):
- ftl: Added.
- ftl/FTLAbbreviations.h: Added.
(FTL):
(JSC::FTL::int1Type):
(JSC::FTL::int32Type):
(JSC::FTL::int64Type):
(JSC::FTL::intPtrType):
(JSC::FTL::pointerType):
(JSC::FTL::getParam):
(JSC::FTL::constInt):
(JSC::FTL::appendBasicBlock):
(JSC::FTL::insertBasicBlock):
(JSC::FTL::buildAlloca):
(JSC::FTL::buildAdd):
(JSC::FTL::buildAnd):
(JSC::FTL::buildXor):
(JSC::FTL::buildLoad):
(JSC::FTL::buildStore):
(JSC::FTL::buildZExt):
(JSC::FTL::buildIntCast):
(JSC::FTL::buildIntToPtr):
(JSC::FTL::buildPtrToInt):
(JSC::FTL::buildICmp):
(JSC::FTL::buildSelect):
(JSC::FTL::buildBr):
(JSC::FTL::buildCondBr):
(JSC::FTL::buildRet):
(JSC::FTL::buildUnreachable):
- ftl/FTLCapabilities.cpp: Added.
(FTL):
(JSC::FTL::canCompile):
- ftl/FTLCapabilities.h: Added.
(FTL):
- ftl/FTLCompile.cpp: Added.
(FTL):
(JSC::FTL::compileEntry):
(JSC::FTL::compile):
- ftl/FTLCompile.h: Added.
(FTL):
- ftl/FTLJITCode.cpp: Added.
(FTL):
(JSC::FTL::JITCode::JITCode):
(JSC::FTL::JITCode::~JITCode):
(JSC::FTL::JITCode::addressForCall):
(JSC::FTL::JITCode::executableAddressAtOffset):
(JSC::FTL::JITCode::dataAddressAtOffset):
(JSC::FTL::JITCode::offsetOf):
(JSC::FTL::JITCode::size):
(JSC::FTL::JITCode::contains):
- ftl/FTLJITCode.h: Added.
(FTL):
(JITCode):
- ftl/FTLLLVMHeaders.h: Added.
- ftl/FTLLowerDFGToLLVM.cpp: Added.
(FTL):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::addFlushedLocalOpRoots):
(JSC::FTL::LowerDFGToLLVM::closeOverFlushedLocalOps):
(JSC::FTL::LowerDFGToLLVM::addFlushedLocalOp):
(JSC::FTL::LowerDFGToLLVM::addFlushedLocalEdge):
(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileJSConstant):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileMovHintAndCheck):
(JSC::FTL::LowerDFGToLLVM::compilePhantom):
(JSC::FTL::LowerDFGToLLVM::compileReturn):
(JSC::FTL::LowerDFGToLLVM::speculateBackward):
(JSC::FTL::LowerDFGToLLVM::speculateForward):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::terminate):
(JSC::FTL::LowerDFGToLLVM::backwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::forwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::typeCheck):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::checkNotInt32):
(JSC::FTL::LowerDFGToLLVM::unboxInt32):
(JSC::FTL::LowerDFGToLLVM::boxInt32):
(JSC::FTL::LowerDFGToLLVM::checkNotCell):
(JSC::FTL::LowerDFGToLLVM::checkNotBoolean):
(JSC::FTL::LowerDFGToLLVM::unboxBoolean):
(JSC::FTL::LowerDFGToLLVM::boxBoolean):
(JSC::FTL::LowerDFGToLLVM::speculateInt32):
(JSC::FTL::LowerDFGToLLVM::addressFor):
(JSC::FTL::LowerDFGToLLVM::payloadFor):
(JSC::FTL::LowerDFGToLLVM::tagFor):
(JSC::FTL::LowerDFGToLLVM::globalData):
(JSC::FTL::LowerDFGToLLVM::codeBlock):
(JSC::FTL::lowerDFGToLLVM):
- ftl/FTLLowerDFGToLLVM.h: Added.
(FTL):
- ftl/FTLOutput.h: Added.
(FTL):
(Output):
(JSC::FTL::Output::Output):
(JSC::FTL::Output::~Output):
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::appendTo):
(JSC::FTL::Output::newBlock):
(JSC::FTL::Output::param):
(JSC::FTL::Output::constBool):
(JSC::FTL::Output::constInt32):
(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::constInt64):
(JSC::FTL::Output::add):
(JSC::FTL::Output::bitAnd):
(JSC::FTL::Output::bitXor):
(JSC::FTL::Output::zeroExt):
(JSC::FTL::Output::intCast):
(JSC::FTL::Output::castToInt32):
(JSC::FTL::Output::get):
(JSC::FTL::Output::set):
(JSC::FTL::Output::load):
(JSC::FTL::Output::store):
(JSC::FTL::Output::load32):
(JSC::FTL::Output::load64):
(JSC::FTL::Output::loadPtr):
(JSC::FTL::Output::store32):
(JSC::FTL::Output::store64):
(JSC::FTL::Output::storePtr):
(JSC::FTL::Output::equal):
(JSC::FTL::Output::notEqual):
(JSC::FTL::Output::above):
(JSC::FTL::Output::aboveOrEqual):
(JSC::FTL::Output::below):
(JSC::FTL::Output::belowOrEqual):
(JSC::FTL::Output::greaterThan):
(JSC::FTL::Output::greaterThanOrEqual):
(JSC::FTL::Output::lessThan):
(JSC::FTL::Output::lessThanOrEqual):
(JSC::FTL::Output::isZero64):
(JSC::FTL::Output::notZero64):
(JSC::FTL::Output::testNonZero64):
(JSC::FTL::Output::select):
(JSC::FTL::Output::jump):
(JSC::FTL::Output::branch):
(JSC::FTL::Output::ret):
(JSC::FTL::Output::unreachable):
- ftl/FTLState.h: Added.
(FTL):
(State):
(JSC::FTL::State::State):
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/Options.h:
(JSC):
Source/WTF:
Reviewed by Geoffrey Garen.
- wtf/Platform.h:
Tools:
Reviewed by Geoffrey Garen.
Give the scripts the ability to find an LLVM build and use it.
Also added a script, export-llvm-build, that allows you to take your
own build of LLVM and package it for use by WebKit's build system.
The build system treats a "build" of LLVM as a pair of .tar.bz2's,
one for the library archives and one for the headers. It then unpacks
them into your built products directory in a mannner that is mostly
analogous to how WebKitSystemInterface works.
- Scripts/build-jsc:
- Scripts/copy-webkitlibraries-to-product-directory:
(unpackIfNecessary):
(dittoHeaders):
- Scripts/export-llvm-build: Added.
- 4:24 PM Changeset in webkit [147258] by
-
- 1 edit in branches/chromium/1453/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp
Merge 146950 "IndexedDB: Histogram cause of LevelDB write errors"
IndexedDB: Histogram cause of LevelDB write errors
https://bugs.webkit.org/show_bug.cgi?id=113350
Reviewed by Tony Chang.
Add histogram for source of LevelDB errors on Write in addition to
Open.
No new tests - no good way to test histogram code.
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::histogramLevelDBError):
(WebCore):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::write):
TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/13171005
- 4:02 PM Changeset in webkit [147257] by
-
- 4 edits in trunk/Source/WebKit2
Crash when "willSendRequest" causes the ResourceLoader to be cancelled.
<rdar://problem/13531679> and https://bugs.webkit.org/show_bug.cgi?id=113616
Reviewed by Alexey Proskuryakov.
These callbacks to the WebCore ResourceLoader can cause the WebResourceLoader to be destroyed.
A RefPtr<> protector fixes that.
Additionally we can invalidate the WebResourceLoader to avoid unnecessary callbacks to the NetworkProcess.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::remove): Call detachFromCoreLoader() on a removed WebResourceLoader.
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::detachFromCoreLoader): Clear out the ResourceLoader pointer.
(WebKit::WebResourceLoader::willSendRequest): Protect this, and don't message back to the NetworkProcess if its not needed.
(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace): Ditto
(WebKit::WebResourceLoader::didReceiveResource): Paranoid hardening - Protect this before delivering the data to the WebCore
ResourceLoader, and null check it before delivering the "didFinishLoader" call.
- WebProcess/Network/WebResourceLoader.h:
- 3:32 PM Changeset in webkit [147256] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r191432. Requested by
"Philip Rogers" <pdr@google.com> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-29
- DEPS:
- 3:18 PM Changeset in webkit [147255] by
-
- 1 edit4 adds in trunk/LayoutTests
Add LayoutTests that verify MediaSource.duration behavior.
https://bugs.webkit.org/show_bug.cgi?id=113438
Reviewed by Eric Carlson.
- http/tests/media/media-source/video-media-source-duration-boundaryconditions-expected.txt: Added.
- http/tests/media/media-source/video-media-source-duration-boundaryconditions.html: Added.
- http/tests/media/media-source/video-media-source-duration-expected.txt: Added.
- http/tests/media/media-source/video-media-source-duration.html: Added.
- 3:10 PM Changeset in webkit [147254] by
-
- 4 edits in trunk/LayoutTests
[Chromium] IndexedDB: Update terminated worker connection test
https://bugs.webkit.org/show_bug.cgi?id=113608
Reviewed by Tony Chang.
Update layout test only run under Chromium's content_shell that ensures that
worker termination does not result in stuck connections. The test was using
the obsolete setVersion() API.
- storage/indexeddb/pending-version-change-stuck-works-with-terminate-expected.txt:
- storage/indexeddb/pending-version-change-stuck-works-with-terminate.html:
- storage/indexeddb/resources/pending-version-change-stuck.js:
(test.request.onblocked):
(test):
- 2:56 PM Changeset in webkit [147253] by
-
- 2 edits in trunk/Source/WebKit2
Should never send events to plugins waiting on asynchronous initialization.
<rdar://problem/13538945> and https://bugs.webkit.org/show_bug.cgi?id=113612
Reviewed by Anders Carlsson.
Sending mouse and keyboard events to a plugin in the middle of asynchronous initialization is silly.
A quick audit of the sendSync() messages in PluginProxy suggests the following 8 can just have an early return:
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::handleMouseEvent):
(WebKit::PluginProxy::handleWheelEvent):
(WebKit::PluginProxy::handleMouseEnterEvent):
(WebKit::PluginProxy::handleMouseLeaveEvent):
(WebKit::PluginProxy::handleKeyboardEvent):
(WebKit::PluginProxy::handleEditingCommand):
(WebKit::PluginProxy::isEditingCommandEnabled):
(WebKit::PluginProxy::handlesPageScaleFactor):
- 2:37 PM Changeset in webkit [147252] by
-
- 5 edits in trunk/Source/JavaScriptCore
Objective-C API: Remove -[JSManagedValue managedValueWithValue:owner:]
https://bugs.webkit.org/show_bug.cgi?id=113602
Reviewed by Geoffrey Garen.
Since we put the primary way of keeping track of external object graphs (i.e. "managed" references)
in JSVirtualMachine, there is some overlap in the functionality of that interface and JSManagedValue.
Specifically, we no longer need the methods that include an owner, since ownership is now tracked
by JSVirtualMachine. These JSManagedValues will become weak pointers unless they are used
with [JSVirtualMachine addManagedReference:withOwner:], in which case their lifetime is tied to that
of their owner.
- API/JSManagedValue.h:
- API/JSManagedValue.mm:
(-[JSManagedValue init]):
(-[JSManagedValue initWithValue:]):
(JSManagedValueHandleOwner::isReachableFromOpaqueRoots):
- API/JSVirtualMachine.mm:
(getInternalObjcObject):
- API/tests/testapi.mm:
(-[TextXYZ setOnclick:]):
(-[TextXYZ dealloc]):
- 2:32 PM Changeset in webkit [147251] by
-
- 7 edits in trunk/Source/WebKit2
"Empty cache..." clears the disk cache from each WebProcess.
<rdar://problem/12456652> and https://bugs.webkit.org/show_bug.cgi?id=113603
Reviewed by Sam Weinig.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::terminate): Override ChildProcess::terminate to allow us to finish clearing the cache.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in: Add the ClearCacheForAllOrigins message.
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::clearCacheForAllOrigins): Clear the disk cache.
(WebKit::NetworkProcess::platformTerminate): Wait for the clear to complete.
- UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins): Message the network process, also.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformClearResourceCaches): Don't clear the disk cache if we use the network process.
- 2:13 PM Changeset in webkit [147250] by
-
- 5 edits2 adds in trunk
[CSS Exclusions] shape outside segments not properly calculated for ellipses
https://bugs.webkit.org/show_bug.cgi?id=112587
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-29
Reviewed by Julien Chaffraix.
Source/WebCore:
When converting the line top coordinates from the parent's coordinate
space to the coordinate space of the float, the offset given by the
shape was not being accounted for. This patch accounts for that
offset.
Test: fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftOffsetForLine): Fix the coordinate conversion.
(WebCore::RenderBlock::logicalRightOffsetForLine): Ditto.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Ditto.
LayoutTests:
Check that shapes with a non-zero y value are properly wrapped.
- fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html: Added.
- fast/exclusions/resources/rounded-rectangle.js:
(generateSimulatedShapeOutsideOnFloat): For simulating, we ignore the
x and y values, since we're not attempting to draw the float's content
in the right place, we just want to simulate the shape's effect.
- 1:34 PM Changeset in webkit [147249] by
-
- 4 edits4 adds in trunk
[CSS Exclusions] Incorrect margin corner radii formula
https://bugs.webkit.org/show_bug.cgi?id=111186
Reviewed by Dirk Schulze.
Source/WebCore:
Corrected an error in the forumla for the margin ellipse's radii.
Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html
- rendering/ExclusionRectangle.cpp:
(WebCore::FloatRoundedRect::marginBounds):
LayoutTests:
- fast/exclusions/resources/subpixel-utils.js:
(SubPixelLayout): Added an initSubPixelLayout() function so that inline test code doesn't have to wait until the DOMContentLoaded event.
- fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left-expected.txt: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right-expected.txt: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html: Added.
- 1:26 PM Changeset in webkit [147248] by
-
- 4 edits in tags/Safari-537.35.4/Source/WebKit2
Merged r147179. <rdar://problem/13479890>
- 1:24 PM Changeset in webkit [147247] by
-
- 2 edits in tags/Safari-537.35.4/Source/WebKit2
Merged r147010. <rdar://problem/13479890>
- 1:22 PM Changeset in webkit [147246] by
-
- 5 edits2 copies in tags/Safari-537.35.4/Source/WebKit2
Merged r147006. <rdar://problem/13479890>
- 1:12 PM Changeset in webkit [147245] by
-
- 13 edits2 adds in trunk
min-width/max-width of min-content/max-content don't work correctly if width is specified
https://bugs.webkit.org/show_bug.cgi?id=106143
Reviewed by Tony Chang.
Source/WebCore:
Test: fast/css-intrinsic-dimensions/intrinsic-sized-blocks.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeIntrinsicLogicalWidths):
Expose this so that we don't use the preferred widths when calculating intrinsic width
values since the preferred width will be the regular width value if it is set.
Also, simplified the logic around table cells and scrollbar widths. The old code was
wrong and unnecessarily complicated.
(WebCore::RenderBlock::computePreferredLogicalWidths):
Use the new computeIntrinsicLogicalWidths method.
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
Pass in the min/max values as out params so they can be called from computeIntrinsicLogicalWidths.
Also, make computeBlockPreferredLogicalWidths const.
- rendering/RenderBlock.h:
LayoutTests:
- css3/flexbox/box-sizing.html:
The old result was incorrectly using the preferred width as the min-content width of the flex items.
The new result is correctly resolving the min-content width to 0 and allowing the flex items to shrink.
- fast/css-intrinsic-dimensions/intrinsic-sized-blocks-expected.txt: Added.
- fast/css-intrinsic-dimensions/intrinsic-sized-blocks.html: Added.
- platform/chromium-win/fast/table/overflowHidden-expected.txt:
The new result correctly adds the scrollbar width to the table cell intrinsic width.
The pixel result doesn't need ot be updated because the elements that changed are below
the fold, so they don't show up in the png.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
Add tests that will need rebaselines.
- scrollbars/custom-scrollbar-table-cell-expected.png:
The new result correctly adds the scrollbar width to the table cell intrinsic width.
- 12:56 PM Changeset in webkit [147244] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Use WTF::TemporaryChange rather than manually resetting a flag
https://bugs.webkit.org/show_bug.cgi?id=113594
Reviewed by Tony Chang.
Split out from another patch: rather than m_foo = true; ... m_foo = false; use
the handy WTF::TemporaryChange scoped variable change doohickey.
Test: http/tests/inspector/indexeddb/database-structure.html
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::close):
- 12:51 PM Changeset in webkit [147243] by
-
- 2 edits in trunk/LayoutTests
Marking animation-delay-changed.html and reinserting-svg-into-document.html as flaky.
https://webkit.org/b/113598
https://webkit.org/b/113599
Unreviewed.
- platform/mac/TestExpectations:
- 12:49 PM Changeset in webkit [147242] by
-
- 21 edits in tags/Safari-537.35.4/Source
Merged r146544. <rdar://problem/13479890>
- 12:36 PM Changeset in webkit [147241] by
-
- 3 edits2 adds in trunk
[V8] IndexedDB: Exceptions thrown inconsistently for non-cloneable values
https://bugs.webkit.org/show_bug.cgi?id=113091
Reviewed by Kentaro Hara.
Source/WebCore:
The exception thrown by SerializedScriptValue into the JS engine is not
observable by ScriptState. (We should fix that, but it appears non-trivial.)
Ask the SerializedScriptValue directly if it failed to clone. If so, don't
set an exception - one was already set so let that be processed normally.
Test: storage/indexeddb/clone-exception.html
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::put):
LayoutTests:
- storage/indexeddb/clone-exception-expected.txt: Added.
- storage/indexeddb/clone-exception.html: Added.
- 12:31 PM Changeset in webkit [147240] by
-
- 3 edits in trunk/Source/WebCore
Snapshotted plugins must be able to restart on appropriate mouseup events
https://bugs.webkit.org/show_bug.cgi?id=113577
Reviewed by Tim Horton.
If the page content prevents the default behaviour of a mousedown event, then a snapshotted
plugin would never receive a click event, and thus be unable to restart. We have to also
look for a mouseup that happens with an associated mousedown, and trigger restart. This
won't call any page code - it's just behind the scenes.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): Initialize new member variable.
(WebCore::RenderSnapshottedPlugIn::handleEvent): Track the state of mousedown and up pairs, and restart
if you see an appropriate mouseup.
- rendering/RenderSnapshottedPlugIn.h: New member variable to track mouse state.
- 12:27 PM Changeset in webkit [147239] by
-
- 110 edits853 adds in trunk/Source/ThirdParty
Update the version of gyp in the repository
https://bugs.webkit.org/show_bug.cgi?id=113540
Reviewed by Nico Weber.
- gyp: Update gyp to r1605.
- 12:26 PM Changeset in webkit [147238] by
-
- 2 edits in trunk/Source/WebCore
removeViewportConstrainedLayer() should remove the layer from m_viewportConstrainedLayersNeedingUpdate too
https://bugs.webkit.org/show_bug.cgi?id=113596
Reviewed by Tim Horton.
It's possible, with some combination of position:fixed and opacity transitions
in iframes, to end up with a RenderLayer in m_viewportConstrainedLayersNeedingUpdate
that has been removed from m_viewportConstrainedLayers, which leads to later assertions
and/or crashes.
Fix by removing a layer from m_viewportConstrainedLayersNeedingUpdate when we
remove it from m_viewportConstrainedLayers.
I was not able to come up with a testcase that reliably reproduces this.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::removeViewportConstrainedLayer):
- 12:22 PM Changeset in webkit [147237] by
-
- 19 edits in tags/Safari-537.35.4
Merged r146704. <rdar://problem/13337564>
- 12:14 PM Changeset in webkit [147236] by
-
- 20 edits in trunk
Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
https://bugs.webkit.org/show_bug.cgi?id=112276
Patch by Greg Hughes <ghughes@apple.com> on 2013-03-29
Reviewed by Chris Fleizach.
Source/WebCore:
Added support for accessibility search predicates to accept multiple search keys. The search will return the first item that matches any one of the provided search keys.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore):
- accessibility/AccessibilityObject.h:
(AccessibilitySearchCriteria):
(WebCore::AccessibilitySearchCriteria::AccessibilitySearchCriteria):
(AccessibilityObject):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
Tools:
Added support to test accessibility search predicates with multiple keys.
- DumpRenderTree/AccessibilityUIElement.cpp:
(uiElementForSearchPredicateCallback):
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::uiElementForSearchPredicate):
- DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
(AccessibilityUIElement::uiElementForSearchPredicate):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::uiElementForSearchPredicate):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementForSearchPredicate):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::uiElementForSearchPredicate):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
LayoutTests:
Updated the search predicate test to test passing multiple search keys (link OR heading).
- platform/mac/accessibility/search-predicate-expected.txt:
- platform/mac/accessibility/search-predicate.html:
- 12:13 PM Changeset in webkit [147235] by
-
- 4 edits in tags/Safari-537.35.4/Source
Versioning.
- 12:12 PM Changeset in webkit [147234] by
-
- 5 edits in trunk/Source/JavaScriptCore
Simplified bytecode generation by unforking "condition context" codegen
https://bugs.webkit.org/show_bug.cgi?id=113554
Reviewed by Mark Hahnenberg.
Now, a node that establishes a condition context can always ask its child
nodes to generate into that context.
This has a few advantages:
(*) Removes a bunch of code;
(*) Optimizes a few missed cases like "if (!(x < 2))", "if (!!x)", and
"if (!x !y)"; (*) Paves the way to removing more opcodes.
- bytecode/Opcode.h:
(JSC): Separated out the branching opcodes for clarity.
- bytecompiler/NodesCodegen.cpp:
(JSC::ExpressionNode::emitBytecodeInConditionContext): All expressions
can be emitted in a condition context now -- the default behavior is
to branch based on the expression's value.
(JSC::LogicalNotNode::emitBytecodeInConditionContext):
(JSC::LogicalOpNode::emitBytecodeInConditionContext):
(JSC::ConditionalNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
- parser/Nodes.h:
(JSC::ExpressionNode::isSubtract):
(ExpressionNode):
(LogicalNotNode):
(LogicalOpNode): Removed lots of code for handling expressions
that couldn't generate into a condition context because all expressions
can now.
- 12:12 PM Changeset in webkit [147233] by
-
- 7 edits in trunk/Source
IndexedDB: Bind lifetime of in-memory backing stores to IDBFactory backend
https://bugs.webkit.org/show_bug.cgi?id=110820
Reviewed by Tony Chang.
Source/WebCore:
Backing stores are dropped as soon as all connections are closed. That makes sense for
disk-backed stores to free up memory (although there's a performance trade-off...). But
for memory-backed stores, the expected lifetime should match the lifetime of the factory
so that an open/write/close/re-open/read yields the written data.
Test: Chromium's webkit_unit_tests, IDBFactoryBackendTest.MemoryBackingStoreLifetime
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore): Pass comparator into constructor since it was always
assigned immediately afterwards anyway.
(WebCore::IDBBackingStore::open): Split into three parts - open() which is disk-backed...
(WebCore::IDBBackingStore::openInMemory): ...explit in-memory creation (previously: specified by empty path)
(WebCore::IDBBackingStore::create): ... and the common logic which calls the constructor.
- Modules/indexeddb/IDBBackingStore.h: Headers for the above.
- Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::openBackingStore): Add in-memory backing stores to dependent set.
- Modules/indexeddb/IDBFactoryBackendImpl.h: Add member to track dependent backing stores.
Source/WebKit/chromium:
- tests/IDBBackingStoreTest.cpp:
(WebCore::IDBBackingStoreTest::SetUp): Use openInMemory rather than empty path.
(WebCore::TEST): Added IDBFactoryBackendTest.MemoryBackingStoreLifetime to verify refs.
- 11:54 AM Changeset in webkit [147232] by
-
- 2 edits in trunk/LayoutTests
Mark fast/workers/worker-close-more.html, worker-document-leak.html and
worker-lifecycle.html as flaky on Windows.
Unreviewed.
- platform/win/TestExpectations:
- 11:52 AM Changeset in webkit [147231] by
-
- 2 edits in trunk/WebKitLibraries
Unreviewed. Rollout r146818.
- win/tools/vsprops/FeatureDefines.props:
- 11:49 AM Changeset in webkit [147230] by
-
- 2 edits in trunk/LayoutTests
Mark inspector/debugger/debugger-scripts-reload.html as flaky.
Unreviewed.
- platform/mac/TestExpectations:
- 11:40 AM Changeset in webkit [147229] by
-
- 1 copy in tags/Safari-537.35.4
New Tag.
- 11:10 AM Changeset in webkit [147228] by
-
- 3 edits2 adds in trunk
ASSERT d->m_defersLoading != defers on detik.com and drive.google.com
https://bugs.webkit.org/show_bug.cgi?id=111902
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: http/tests/navigation/same-url-iframes-defer-crash.html
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setDefersLoading): If multiple DocumentLoaders are
using loading the same main resource, ensure only one of them can call
ResourceLoader::setDefersLoading.
LayoutTests:
- http/tests/navigation/same-url-iframes-defer-crash-expected.txt: Added.
- http/tests/navigation/same-url-iframes-defer-crash.html: Added.
- 10:24 AM Changeset in webkit [147227] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Content should not be lost when uiSourceCode's file was removed externally on file system.
https://bugs.webkit.org/show_bug.cgi?id=113581
Reviewed by Pavel Feldman.
- inspector/front-end/IsolatedFileSystem.js:
(WebInspector.IsolatedFileSystem.prototype.errorHandler):
(WebInspector.IsolatedFileSystem.prototype.requestFileContent):
(WebInspector.IsolatedFileSystem.prototype.fileSystemLoaded):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.checkContentUpdated.contentLoaded):
(WebInspector.UISourceCode.prototype.checkContentUpdated):
(WebInspector.UISourceCode.prototype._commitContent):
- 10:06 AM Changeset in webkit [147226] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Prompt before closing dirty tab.
https://bugs.webkit.org/show_bug.cgi?id=113576
Reviewed by Pavel Feldman.
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._maybeCloseTab):
(WebInspector.TabbedEditorContainer.prototype._closeTabs):
(WebInspector.EditorContainerTabDelegate):
(WebInspector.EditorContainerTabDelegate.prototype.closeTabs):
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.setTabDelegate):
(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype.allTabs):
(WebInspector.TabbedPane.prototype.otherTabs):
(WebInspector.TabbedPaneTab.prototype.setDelegate):
(WebInspector.TabbedPaneTab.prototype._tabClicked):
(WebInspector.TabbedPaneTab.prototype._closeTabs):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu.closeOthers):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu.closeAll):
(WebInspector.TabbedPaneTabDelegate):
(WebInspector.TabbedPaneTabDelegate.prototype.closeTabs):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.resetWorkingCopy):
- 9:59 AM Changeset in webkit [147225] by
-
- 2 edits in trunk/Tools
Fix a typo in r147147 to fix Mac EWS.
- Scripts/webkitpy/tool/commands/queues.py:
(PatchProcessingQueue._new_port_name_from_old):
- 9:47 AM Changeset in webkit [147224] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Flame Chart. Remove hopping ancorElement and use anchorBox instead.
https://bugs.webkit.org/show_bug.cgi?id=113579
Reviewed by Pavel Feldman.
Initially I made a fake anchor element and moved it according to the highlighted element position.
It was a hack and after http://trac.webkit.org/changeset/147209 I'm able to remove it.
Drive by fix: the code was moved from onMouseMove to getPopoverAnchor.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._getPopoverAnchor):
-(WebInspector.FlameChart.prototype._onMouseMove)
- inspector/front-end/flameChart.css:
- 9:37 AM Changeset in webkit [147223] by
-
- 41 edits16 copies5 moves128 adds21 deletes in trunk/LayoutTests
[Qt] Unreviewed gardneing. Updated png expected results after r146206.
- platform/qt-5.0-wk2/compositing/color-matching/image-color-matching-expected.png:
- platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-expected.png:
- platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png:
- platform/qt-5.0-wk2/compositing/culling/scrolled-within-boxshadow-expected.png:
- platform/qt-5.0-wk2/compositing/culling/translated-boxshadow-expected.png:
- platform/qt-5.0-wk2/compositing/culling/unscrolled-within-boxshadow-expected.png:
- platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png:
- platform/qt-5.0-wk2/compositing/flat-with-transformed-child-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/generated-content-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/clipping-foreground-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/foreground-layer-expected.png:
- platform/qt-5.0-wk2/compositing/geometry/root-layer-update-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png:
- platform/qt-5.0-wk2/compositing/iframes/composited-iframe-alignment-expected.png: Added.
- platform/qt-5.0-wk2/compositing/iframes/nested-iframe-scrolling-expected.png:
- platform/qt-5.0-wk2/compositing/masks/direct-image-mask-expected.png: Added.
- platform/qt-5.0-wk2/compositing/masks/mask-of-clipped-layer-expected.png:
- platform/qt-5.0-wk2/compositing/masks/masked-ancestor-expected.png:
- platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.png:
- platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.png:
- platform/qt-5.0-wk2/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
- platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/overflow/zero-size-overflow-expected.png:
- platform/qt-5.0-wk2/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
- platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed-expected.png: Added.
- platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
- platform/qt-5.0-wk2/compositing/reflections/reflection-opacity-expected.png: Added.
- platform/qt-5.0-wk2/compositing/reflections/reflection-ordering-expected.png: Added.
- platform/qt-5.0-wk2/compositing/reflections/reflection-positioning-expected.png: Added.
- platform/qt-5.0-wk2/compositing/reflections/reflection-positioning2-expected.png: Added.
- platform/qt-5.0-wk2/compositing/reflections/simple-composited-reflections-expected.png: Added.
- platform/qt-5.0-wk2/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
- platform/qt-5.0-wk2/compositing/repaint/layer-repaint-rects-expected.png: Added.
- platform/qt-5.0-wk2/compositing/repaint/newly-composited-repaint-rect-expected.png:
- platform/qt-5.0-wk2/compositing/repaint/requires-backing-repaint-expected.png:
- platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png:
- platform/qt-5.0-wk2/compositing/self-painting-layers-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/sibling-positioning-expected.png: Added.
- platform/qt-5.0-wk2/compositing/text-on-large-layer-expected.png: Added.
- platform/qt-5.0-wk2/compositing/visibility/visibility-image-layers-expected.png: Added.
- platform/qt-5.0-wk2/compositing/visibility/visibility-simple-video-layer-expected.png:
- platform/qt-5.0-wk2/compositing/z-order/negative-z-index-expected.png:
- platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-expected.png: Removed.
- platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-stacking-expected.png: Added.
- platform/qt-5.0-wk2/css3/filters/composited-reflected-expected.png:
- platform/qt-5.0-wk2/css3/filters/custom/custom-filter-clamp-css-color-matrix-expected.png:
- platform/qt-5.0-wk2/css3/filters/custom/custom-filter-nonseparable-blend-mode-luminosity-expected.png:
- platform/qt-5.0-wk2/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
- platform/qt-5.0-wk2/editing/selection/5076323-1-expected.png:
- platform/qt-5.0-wk2/editing/selection/5099303-expected.png:
- platform/qt-5.0-wk2/editing/selection/5195166-2-expected.png:
- platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/qt-5.0-wk2/fast/backgrounds/size/zero-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/qt-5.0-wk2/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/background-clipped-expected.png: Added.
- platform/qt-5.0-wk2/fast/layers/scroll-rect-to-visible-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/float-paginate-empty-lines-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-multicol-expected.png: Removed.
- platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.png: Removed.
- platform/qt-5.0-wk2/fast/reflections/inline-crash-expected.png: Removed.
- platform/qt-5.0-wk2/fast/reflections/reflection-masks-expected.png: Added.
- platform/qt-5.0-wk2/fast/reflections/reflection-masks-opacity-expected.png: Added.
- platform/qt-5.0-wk2/fast/reflections/reflection-masks-outset-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/background-misaligned-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-in-regions-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scale-page-shrink-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/transform-replaced-shadows-expected.png: Added.
- platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png:
- platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.png:
- platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-row-border-width-expected.png:
- platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png:
- platform/qt-5.0-wk2/fast/text/font-initial-expected.png: Removed.
- platform/qt-5.0-wk2/fast/text/whitespace/003-expected.png: Added.
- platform/qt-5.0-wk2/fast/text/whitespace/006-expected.png: Added.
- platform/qt-5.0-wk2/fast/text/whitespace/008-expected.png: Added.
- platform/qt-5.0-wk2/fast/text/whitespace/009-expected.png: Added.
- platform/qt-5.0-wk2/fast/text/whitespace/012-expected.png: Added.
- platform/qt-5.0-wk2/fast/text/whitespace/013-expected.png:
- platform/qt-5.0-wk2/fast/text/whitespace/014-expected.png:
- platform/qt-5.0-wk2/fast/writing-mode/block-level-images-expected.png: Added.
- platform/qt-5.0-wk2/fast/writing-mode/box-shadow-vertical-lr-expected.png: Added.
- platform/qt-5.0-wk2/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
- platform/qt-5.0-wk2/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Added.
- platform/qt-5.0-wk2/svg/animations/animateMotion-additive-2c-expected.png: Added.
- platform/qt-5.0-wk2/svg/animations/animateMotion-additive-2d-expected.png: Added.
- platform/qt-5.0-wk2/svg/as-background-image/svg-as-background-2-expected.png: Added.
- platform/qt-5.0-wk2/svg/as-border-image/svg-as-border-image-expected.png: Added.
- platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Removed.
- platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-same-image-expected.png: Removed.
- platform/qt-5.0-wk2/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
- platform/qt-5.0-wk2/svg/batik/filters/feTile-expected.png: Added.
- platform/qt-5.0-wk2/svg/batik/text/textDecoration-expected.png: Added.
- platform/qt-5.0-wk2/svg/batik/text/textFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/css/group-with-shadow-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/clip-mask-negative-scale-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/createImageElement-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/createImageElement2-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/image-parent-translation-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/image-rescale-clip-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/image-rescale-scroll-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/js-update-image-and-display2-expected.png:
- platform/qt-5.0-wk2/svg/custom/js-update-image-and-display3-expected.png:
- platform/qt-5.0-wk2/svg/custom/js-update-image-expected.png:
- platform/qt-5.0-wk2/svg/custom/massive-coordinates-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/pattern-in-defs-expected.png:
- platform/qt-5.0-wk2/svg/custom/pattern-rotate-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/pointer-events-image-css-transform-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/pointer-events-image-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/text-image-opacity-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/use-instanceRoot-event-listeners-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Removed.
- platform/qt-5.0-wk2/svg/filters/big-sized-filter-expected.png: Added.
- platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png:
- platform/qt-5.0-wk2/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png: Added.
- platform/qt-5.0-wk2/svg/transforms/text-with-mask-with-svg-transform-expected.png: Removed.
- platform/qt-5.0-wk2/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Removed.
- platform/qt-5.0-wk2/svg/wicd/test-rightsizing-b-expected.png: Added.
- platform/qt-5.0-wk2/svg/wicd/test-scalable-background-image2-expected.png: Added.
- platform/qt-5.0-wk2/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug11026-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug1188-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug12910-2-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug1296-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug15544-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug2981-2-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug4093-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug4284-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug4427-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug625-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug97383-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/core/misc-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/97619-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
- platform/qt-5.0-wk2/transitions/cross-fade-border-image-expected.png: Added.
- 9:07 AM Changeset in webkit [147222] by
-
- 9 edits3 copies1 add in trunk/Source
[EFL][EGL] Add support for creating offscreen surface.
https://bugs.webkit.org/show_bug.cgi?id=113359
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-29
Reviewed by Noam Rosenthal.
This is in preparation for enabling EGL and GLES2
support for EFL port. This patch adds support for using
EGLPixmapSurface as an offscreensurface.
- PlatformEfl.cmake:
- platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::createOffScreenSurface):
- platform/graphics/surfaces/efl/GLTransportSurface.cpp:
(WebCore::GLTransportSurface::createTransportSurface):
- platform/graphics/surfaces/egl/EGLConfigSelector.cpp:
(WebCore::EGLConfigSelector::EGLConfigSelector):
(WebCore::EGLConfigSelector::pixmapContextConfig):
(WebCore::EGLConfigSelector::surfaceContextConfig):
(WebCore::EGLConfigSelector::nativeVisualId):
(WebCore::EGLConfigSelector::reset):
(WebCore::EGLConfigSelector::createConfig):
- platform/graphics/surfaces/egl/EGLConfigSelector.h:
(EGLConfigSelector):
Added logic to select EGLConfig supporting alpha and
opaque as needed. Moved Code related to display to
EGLHelper class.
- platform/graphics/surfaces/egl/EGLHelper.cpp: Added.
(WebCore):
(EGLDisplayConnection):
(WebCore::EGLDisplayConnection::EGLDisplayConnection):
(WebCore::EGLDisplayConnection::~EGLDisplayConnection):
(WebCore::EGLDisplayConnection::display):
(WebCore::EGLDisplayConnection::terminate):
(WebCore::EGLHelper::eglDisplay):
- platform/graphics/surfaces/egl/EGLHelper.h: Copied from Source/WebCore/platform/graphics/surfaces/egl/EGLSurface.h.
(WebCore):
(EGLHelper):
- platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLTransportSurface::createTransportSurface):
(WebCore::EGLTransportSurface::EGLTransportSurface):
(WebCore::EGLTransportSurface::attributes):
(WebCore::EGLTransportSurface::~EGLTransportSurface):
(WebCore::EGLTransportSurface::destroy):
(WebCore::EGLTransportSurface::configuration):
(WebCore::EGLOffScreenSurface::createOffScreenSurface):
(WebCore::EGLOffScreenSurface::EGLOffScreenSurface):
(WebCore::EGLOffScreenSurface::~EGLOffScreenSurface):
(WebCore::EGLOffScreenSurface::attributes):
(WebCore::EGLOffScreenSurface::configuration):
(WebCore::EGLOffScreenSurface::destroy):
- platform/graphics/surfaces/egl/EGLSurface.h:
(WebCore):
(EGLTransportSurface):
(EGLOffScreenSurface):
- platform/graphics/surfaces/egl/EGLXSurface.cpp: Copied from Source/WebCore/platform/graphics/surfaces/egl/EGLSurface.cpp.
(WebCore):
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::~EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::swapBuffers):
(WebCore::EGLWindowTransportSurface::destroy):
(WebCore::EGLPixmapSurface::EGLPixmapSurface):
(WebCore::EGLPixmapSurface::~EGLPixmapSurface):
(WebCore::EGLPixmapSurface::destroy):
- platform/graphics/surfaces/egl/EGLXSurface.h: Copied from Source/WebCore/platform/graphics/surfaces/egl/EGLSurface.h.
(WebCore):
(EGLWindowTransportSurface):
(EGLPixmapSurface):
EGLPixmapSurface implementation.
- 8:50 AM Changeset in webkit [147221] by
-
- 12 edits in trunk
Unreviewed, rolling out r147218.
http://trac.webkit.org/changeset/147218
https://bugs.webkit.org/show_bug.cgi?id=113585
We should rethink UI of this feature. (Requested by vsevik on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-29
Source/WebCore:
- inspector/InjectedScriptSource.js:
(.):
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.populateWithProperties):
- inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.set else):
(WebInspector.RemoteObjectProperty):
- inspector/front-end/inspector.css:
LayoutTests:
- inspector/console/command-line-api-expected.txt:
- inspector/debugger/properties-special-expected.txt:
- inspector/debugger/properties-special.html:
- inspector/runtime/runtime-getProperties-expected.txt:
- inspector/runtime/runtime-getProperties.html:
- platform/chromium/inspector/debugger/properties-special-expected.txt:
- 8:20 AM Changeset in webkit [147220] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: extract common base for 3 timeline overview controls (Events/Frames/Memory)
https://bugs.webkit.org/show_bug.cgi?id=113572
Reviewed by Yury Semikhatsky.
Refactoring, covered by existing tests.
- introduce TimelineOverviewBase as a common base for 3 overview controls;
- make every overview control a view.
This does not yet take advantage of common base (subject of the next patch).
- inspector/front-end/OverviewGrid.js:
(WebInspector.OverviewGrid.prototype.gridElement):
(WebInspector.OverviewGrid.prototype.itemsGraphsElement):
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewBase):
(WebInspector.TimelineOverviewBase.prototype.update):
(WebInspector.TimelineMemoryOverview):
(WebInspector.TimelineEventOverview):
(WebInspector.TimelineEventOverview.prototype._renderBar):
(WebInspector.TimelineFrameOverview):
(WebInspector.TimelineFrameOverview.prototype.update):
(WebInspector.TimelineFrameOverview.prototype._renderBars):
(WebInspector.TimelineFrameOverview.prototype._drawFPSMarks):
(WebInspector.TimelineFrameOverview.prototype._renderBar):
- 8:09 AM Changeset in webkit [147219] by
-
- 5 edits in trunk/LayoutTests
Web Inspector: Update test expectation for resource-har-conversion.html
https://bugs.webkit.org/show_bug.cgi?id=113460
Patch by Seokju Kwon <Seokju Kwon> on 2013-03-29
Reviewed by Vsevolod Vlasov.
The value of pageref and title had been changed after r105596.
(Use page ids, not document URLs in HAR entries to refer to pages.
Use page URL as a title field of a HAR page.)
- http/tests/inspector/resource-har-conversion-expected.txt:
- platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt:
- platform/mac/http/tests/inspector/resource-har-conversion-expected.txt:
- platform/win/http/tests/inspector/resource-har-conversion-expected.txt:
- 8:02 AM Changeset in webkit [147218] by
-
- 12 edits in trunk
Web Inspector: gather accessor property getter and setter under a single tree node
https://bugs.webkit.org/show_bug.cgi?id=113357
Patch by Peter Rybin <prybin@chromium.org> on 2013-03-29
Reviewed by Yury Semikhatsky.
Source/WebCore:
A new tree element class AccessorPropertyTreeElemenet is added.
RemoteObjectProperty can now represent accessor property (if value is null).
New tree element is supported in CSS stylesheet.
Testing code is slightly modified for exploring new tree elements.
- inspector/InjectedScriptSource.js:
(.):
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.populateWithProperties):
(WebInspector.AccessorPropertyTreeElement):
(WebInspector.AccessorPropertyTreeElement.prototype.onattach):
(WebInspector.AccessorPropertyTreeElement.prototype.update):
(WebInspector.AccessorPropertyTreeElement.prototype.onpopulate):
- inspector/front-end/RemoteObject.js:
- inspector/front-end/inspector.css:
(.accessor-property-name):
LayoutTests:
Expectations are fixed with changed functionality and changed tests.
- inspector/debugger/properties-special-expected.txt:
- inspector/debugger/properties-special.html:
- inspector/runtime/runtime-getProperties-expected.txt:
- inspector/runtime/runtime-getProperties.html:
- platform/chromium/inspector/debugger/properties-special-expected.txt:
- 7:21 AM Changeset in webkit [147217] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed Windows gardening.
- platform/win/fast/events/event-attribute-expected.txt: Added.
New baseline after r147205.
- 7:17 AM Changeset in webkit [147216] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed Mac gardening.
- platform/mac/fast/events/event-attribute-expected.txt: Added.
New baseline after r147205.
- 7:15 AM Changeset in webkit [147215] by
-
- 1 edit1 delete in trunk/LayoutTests
[Qt] Removal of misplaced stuff after r146692.
- platform/qt-unknown/fast/text/international/text-spliced-font-expected.png: Removed.
- platform/qt-unknown/svg/carto.net/tabgroup-expected.png: Removed.
- 7:14 AM Changeset in webkit [147214] by
-
- 2 edits6 adds in trunk/PerformanceTests
[CSS Regions] Add performance tests
https://bugs.webkit.org/show_bug.cgi?id=113303
Reviewed by Antti Koivisto.
Add simple performance tests for regions, without nested named flows: a region chain and a flow article.
The regions.js script is used to generate the tests and can set the following parameters: the number of regions,
the number of paragraphs, the regions width, height, max-height and the propability of a forced break after a paragraph.
The tests are skipped for now. They should be enabled once the regions performance is stable enough to create a baseline.
- Layout/RegionsAuto.html: Added. A few regions with a short article. The regions have auto-height and some
paragraphs (80%) have forced breaks after. Stress test for the auto-height algorithm.
- Layout/RegionsAutoMaxHeight.html: Added. A lot of regions with auto-height and max-height. Tests the impact of
max-height on the auto-height algorithm.
- Layout/RegionsFixed.html: Added. A lot of regions with a long article. Some paragraphs (50%) have forced breaks after.
Stress test for the regions layout algorithm.
- Layout/RegionsFixedShort.html: Added. A lot of short regions with a long content. Tests the impact of unforced breaks
on the layout speed.
- Layout/resources/regions.css: Added.
(.articleInFlow):
(.articleNone):
(.region):
(.contentParagraph):
(.breakAfter):
(.regionContainer):
- Layout/resources/regions.js: Added.
(.):
- Skipped:
- 6:56 AM Changeset in webkit [147213] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Flame Chart. Developers will have more clue
if two different profiles will have same colors for same functions.
https://bugs.webkit.org/show_bug.cgi?id=113410
Reviewed by Pavel Feldman.
The code related to color generator was extracted into a separate class.
The instance of the class was stored as static private member of the FlameChart class,
so all the profiles will share the same instance and will use same colors.
The colors itself were slightly adjusted.
Drive by fix: coordinatesToNodeIndex was fixed. The error was introduced in the patch about left padding.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.ColorGenerator):
(WebInspector.FlameChart.ColorGenerator.prototype._colorPairForID):
(WebInspector.FlameChart.prototype._calculateTimelineData):
(WebInspector.FlameChart.prototype._calculateTimelineDataForSamples):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):
- 6:18 AM Changeset in webkit [147212] by
-
- 11 edits in trunk
[BlackBerry] Cleanup the CONTEXT_MENUS in BlackBerry porting
https://bugs.webkit.org/show_bug.cgi?id=113562
Reviewed by George Staikos.
Internally reviewed by Mike Fenton and Gen Mak.
.:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebCore:
No new tests, just disable CONTEXT_MENUS for blackberry porting.
- platform/blackberry/ContextMenuBlackBerry.cpp:
- platform/blackberry/ContextMenuItemBlackBerry.cpp:
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
- WebCoreSupport/ContextMenuClientBlackBerry.cpp:
- WebCoreSupport/ContextMenuClientBlackBerry.h:
- 6:08 AM Changeset in webkit [147211] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Context menu doesn't showup anymore after rebase.
https://bugs.webkit.org/show_bug.cgi?id=113570
Reviewed by George Staikos.
The upstreaming patch for bug: 103058, reverses the return value of
Node::dispatchMouseEvent() to be consistent with Node::dispatchEvent(),
so we should reverse our logic in webkit part that calls it also.
This only applys to master_41 which is a new rebase, don't apply it to master_40.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
- 5:55 AM Changeset in webkit [147210] by
-
- 2 edits in trunk/Source/WebCore
Fix build warning after r147022
https://bugs.webkit.org/show_bug.cgi?id=113567
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-03-29
Reviewed by Kentaro Hara.
Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.
No new tests, no change on behavior.
- page/EventHandler.cpp:
(WebCore::expandSelectionToRespectUserSelectAll):
- 5:40 AM Changeset in webkit [147209] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: ability to use AnchorBox as an anchor for Popover
https://bugs.webkit.org/show_bug.cgi?id=113563
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-29
Reviewed by Pavel Feldman.
No new test: no change in behaviour.
- Ability to pass AnchorBox instead of Element for popover anchor.
- inspector/front-end/Popover.js:
(WebInspector.Popover.prototype._positionElement):
(WebInspector.PopoverHelper.prototype._eventInHoverElement):
- 5:31 AM Changeset in webkit [147208] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: assign Scroll events to rendering category (was painting)
https://bugs.webkit.org/show_bug.cgi?id=113564
Reviewed by Pavel Feldman.
- inspector/front-end/TimelinePresentationModel.js: /ScrollLayer.*category/s/painting/rendering/
(WebInspector.TimelinePresentationModel._initRecordStyles):
- 5:27 AM Changeset in webkit [147207] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing test after r147205.
- platform/qt-5.0-wk1/TestExpectations:
- 4:28 AM Changeset in webkit [147206] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] playback gets bumpy sometimes when on-disk buffering is slow
https://bugs.webkit.org/show_bug.cgi?id=113512
Reviewed by Martin Robinson.
When the HTTP source element is slow downloading data for on-disk
buffering the playback position might reach an unbuffered region
and have bad consequences, pausing the pipeline beforehand
prevents this case to happen.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats):
- 2:59 AM Changeset in webkit [147205] by
-
- 14 edits4 adds in trunk
Add the event handler content attributes that are defined in the spec to HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=86363
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/events/event-attribute.html
We are missing some event handler content attributes from HTMLElement that are defined in the spec.
http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#event-handlers-on-elements,-document-objects,-and-window-objects
- html/HTMLElement.cpp:
(WebCore::HTMLElement::eventNameForAttributeName): Returns event name for a given attribute name by looking it up on a HashMap.
(WebCore::HTMLElement::parseAttribute): Sets up event listeners for content attributes.
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::parseAttribute): Removed event listener content attributes that was added to HTMLElement.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseAttribute): Ditto.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute): Ditto.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseAttribute): Ditto.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseAttribute): Ditto.
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseAttribute): Ditto.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute): Ditto.
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::parseAttribute): Ditto.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::parseAttribute): Ditto.
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::parseAttribute): Ditto.
LayoutTests:
- fast/events/event-attribute-expected.txt: Added.
- fast/events/event-attribute.html: Added. Tests that setting attribute creates event listeners.
- fast/events/form-onchange-expected.txt: Added.
- fast/events/form-onchange.html: Added. Test for Bug 24516.
- 2:44 AM Changeset in webkit [147204] by
-
- 16 edits in trunk
Web Inspector: timeline paint rectangles are off for transformed layers
https://bugs.webkit.org/show_bug.cgi?id=112919
Reviewed by Pavel Feldman.
Source/WebCore:
- pass RenderObject instead of Frame to InspectorInstrumentation::didPaint;
- take transforms into account and convert paint clip rect into quad;
- emit quads, not rects as Paint and Layout record data;
- adjust client to using quads, compute width/height from quad coords.
- inspector/InspectorInstrumentation.cpp: Pass RenderObject, not frame to {will,did}Paint.
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):
(WebCore::InspectorInstrumentation::instrumentingAgentsForRenderer): Added.
- inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didLayout):
(WebCore::InspectorTimelineAgent::didPaint):
(WebCore::InspectorTimelineAgent::localToPageQuad): Convert local clip rect to transformed quad.
(WebCore):
- inspector/InspectorTimelineAgent.h:
(WebCore):
(InspectorTimelineAgent):
- inspector/TimelineRecordFactory.cpp: Emit quads as Paint and Layout records data.
(WebCore::createQuad):
(WebCore):
(WebCore::TimelineRecordFactory::createPaintData):
(WebCore::TimelineRecordFactory::createLayoutData):
- inspector/TimelineRecordFactory.h:
(WebCore):
(TimelineRecordFactory):
- inspector/front-end/TimelinePanel.js: Highlight a quad iff formatted record has highlightQuad field.
(WebInspector.TimelinePanel.prototype._mouseOut):
(WebInspector.TimelinePanel.prototype._mouseMove):
(WebInspector.TimelinePanel.prototype._highlightQuad):
(WebInspector.TimelinePanel.prototype._hideQuadHighlight):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record): Set highlightQuad for Paint and Layout
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
(WebInspector.TimelinePresentationModel.quadWidth):
(WebInspector.TimelinePresentationModel.quadHeight):
- page/FrameView.cpp:
(WebCore::FrameView::paintContents):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):
LayoutTests:
- adjust to changed record format;
- simplify test using InspectorTest.evaluateWithTimeline().
- http/tests/inspector/timeline-test.js:
- inspector/timeline/timeline-layout-expected.txt:
- inspector/timeline/timeline-paint-expected.txt:
- inspector/timeline/timeline-paint.html:
- 2:33 AM Changeset in webkit [147203] by
-
- 6 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Rebaseline after r147164.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Rebaseline after r147164.
- platform/qt/TestExpectations:
- platform/qt/compositing/contents-opaque/control-layer-expected.txt: Rebaseline after r147127.
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Rebaseline after r147164.
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Rebaseline after r147164.
- 2:25 AM Changeset in webkit [147202] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: generalize InspectorDOMAgent::highlightRect() to highlightQuad()
https://bugs.webkit.org/show_bug.cgi?id=112911
Reviewed by Pavel Feldman.
- added Quad type and DOMAgent.highlightQuad() to protocol;
- retained DOMAgent.highlightRect(), but implement it via highlightQuad.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::parseQuad):
(WebCore):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::innerHighlightQuad):
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- inspector/InspectorOverlay.cpp: Mostly just renames of rect to quad.
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::hideHighlight):
(WebCore::InspectorOverlay::highlightQuad):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::reportMemoryUsage):
- inspector/InspectorOverlay.h:
(InspectorOverlay):
- inspector/InspectorOverlayPage.html: Ditto.
- 1:51 AM Changeset in webkit [147201] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding a crashing expectation for the
ttp/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html layout test. Skipping the perf/ tests when
using the debug build.
- platform/gtk/fast/text/shaping/shaping-selection-rect-expected.txt: Rebaselining after r147156.
- 12:59 AM Changeset in webkit [147200] by
-
- 3 edits19 adds in trunk/LayoutTests
[EFL] New baselines for accessibility tests.
https://bugs.webkit.org/show_bug.cgi?id=113510
Unreviewed, EFL gardening.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-29
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
- platform/efl/accessibility/aria-checkbox-text-expected.txt: Added.
- platform/efl/accessibility/aria-combobox-expected.txt: Added.
- platform/efl/accessibility/aria-fallback-roles-expected.txt: Added.
- platform/efl/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
- platform/efl/accessibility/aria-menubar-menuitems-expected.txt: Added.
- platform/efl/accessibility/aria-roles-expected.txt: Added.
- platform/efl/accessibility/aria-tables-expected.txt: Added.
- platform/efl/accessibility/aria-toggle-button-with-title-expected.txt: Added.
- platform/efl/accessibility/canvas-description-and-role-expected.txt: Added.
- platform/efl/accessibility/div-within-anchors-causes-crash-expected.txt: Added.
- platform/efl/accessibility/image-link-expected.txt: Added.
- platform/efl/accessibility/image-map1-expected.txt: Added.
- platform/efl/accessibility/image-map2-expected.txt: Added.
- platform/efl/accessibility/img-alt-tag-only-whitespace-expected.txt: Added.
- platform/efl/accessibility/legend-expected.txt: Added.
- platform/efl/accessibility/menu-list-sends-change-notification-expected.txt: Added.
- platform/efl/accessibility/notification-listeners-expected.txt: Added.
- platform/efl/accessibility/svg-image-expected.txt: Added.
- 12:36 AM Changeset in webkit [147199] by
-
- 3 edits2 adds in trunk
REGRESSION(r143102): Ignore table cell's height attribute when checking if containing block has auto height.
https://bugs.webkit.org/show_bug.cgi?id=113526
Source/WebCore:
It matches shipping Safari and Firefox behaviour.
Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-29
Reviewed by Antti Koivisto.
Test: fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight):
LayoutTests:
Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-29
Reviewed by Antti Koivisto.
- fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height-expected.txt: Added.
- fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html: Added.
Mar 28, 2013:
- 11:31 PM Changeset in webkit [147198] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Cookies] CookiesTable should integrate with DataGrid context menu.
https://bugs.webkit.org/show_bug.cgi?id=113496
Reviewed by Pavel Feldman.
Integrate CookiesTable with DataGrid context menu
instead of overriding it.
- inspector/front-end/CookiesTable.js:
Pass context menu callback to DataGrid constructor.
- inspector/front-end/DataGrid.js:
Added context menu callback constructor parameter. Fixed JSDoc.
- 10:53 PM Changeset in webkit [147197] by
-
- 3 edits in trunk/Tools
[EFL] Build break with latest EFL libraries after r146265
https://bugs.webkit.org/show_bug.cgi?id=113558
Unreviewed build fix.
- TestWebKitAPI/PlatformWebView.h:
- WebKitTestRunner/PlatformWebView.h:
- 10:40 PM Changeset in webkit [147196] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix build break when running --update-efl in WebKit EFL.
- efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
in libgcrypt build.
- 9:33 PM Changeset in webkit [147195] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r147123.
http://trac.webkit.org/changeset/147123
https://bugs.webkit.org/show_bug.cgi?id=113557
wrong TextExpectation removal (Requested by shinyak|gardener
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-28
- platform/chromium/TestExpectations:
- 9:12 PM Changeset in webkit [147194] by
-
- 8 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Test expectations update and rebaselining.
- platform/chromium-mac-lion/fast/lists/003-vertical-expected.png:
- platform/chromium-mac-lion/fast/text/international/text-spliced-font-expected.txt:
- platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt:
- platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.txt:
- platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt:
- platform/chromium-mac/fast/lists/003-vertical-expected.png:
- platform/chromium-mac/fast/text/international/text-spliced-font-expected.txt:
- 8:47 PM Changeset in webkit [147193] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening. Test Expectations update.
- platform/chromium/TestExpectations:
- 6:48 PM Changeset in webkit [147192] by
-
- 3 edits3 deletes in trunk/Source/WebKit/chromium
[chromium] Remove unused WebRegularExpression API
https://bugs.webkit.org/show_bug.cgi?id=113520
Patch by James Robinson <jamesr@chromium.org> on 2013-03-28
Reviewed by Kent Tamura.
Last reference to these files removed in r190880.
- WebKit.gyp:
- public/WebRegularExpression.h: Removed.
- public/WebTextCaseSensitivity.h: Removed.
- src/AssertMatchingEnums.cpp:
- src/WebRegularExpression.cpp: Removed.
- 6:16 PM Changeset in webkit [147191] by
-
- 2 edits in trunk/Source/WebKit2
We leak NetworkConnectionToWebProcess objects.
<rdar://problem/13393118> and https://bugs.webkit.org/show_bug.cgi?id=113551
Reviewed by Anders Carlsson.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didClose): Remove this from the global set
of NetworkConnectionToWebProcess objects.
- 6:09 PM Changeset in webkit [147190] by
-
- 13 edits in trunk/Source/JavaScriptCore
Simplified the bytecode by removing op_loop and op_loop_if_*
https://bugs.webkit.org/show_bug.cgi?id=113548
Reviewed by Filip Pizlo.
Regular jumps will suffice.
These opcodes are identical to branches, except they also do timeout
checking. That style of timeout checking has been broken for a long
time, and when we add back timeout checking, it won't use these opcodes.
- JavaScriptCore.order:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecode/PreciseJumpTargets.cpp:
(JSC::computePreciseJumpTargets):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJump):
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
(JIT):
(JSC):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 6:01 PM Changeset in webkit [147189] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Don't cross editing boundary when touch hold selection expands
https://bugs.webkit.org/show_bug.cgi?id=113537
Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.
Set editing boundary crossing rule to make sure it won't cross
editing boundary when selection expands.
Reviewed Internally By Genevieve Mak and Mike Fenton.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
(BlackBerry::WebKit::SelectionHandler::findNextAnimationOverlayRegion):
- 5:51 PM Changeset in webkit [147188] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
crashes sometimes. Applying the patch from wkbug.com/111902 fixes it
locally for me: skipping it until that patch lands.
- platform/mac/TestExpectations:
Marking http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
as crashy in Debug.
- 5:50 PM Changeset in webkit [147187] by
-
- 2 edits in trunk/Source/WebCore
Fix compiler warning in IDBTransaction::modeToString
https://bugs.webkit.org/show_bug.cgi?id=113547
Reviewed by Darin Adler.
Not all compilers are smart enough to handle this switch. This patch refactors
modeToString to not return from the default case.
No new tests as this is just a compiler fix.
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::modeToString):
- 5:18 PM Changeset in webkit [147186] by
-
- 6 edits in trunk/Source/WebCore
GraphicsLayerCA::recomputeVisibleRects() shouldn't actually set the visible rect
https://bugs.webkit.org/show_bug.cgi?id=113544
Reviewed by Tim Horton.
The functions added in r147058 to update the visible rects of GraphicsLayerCAs
should not have actually set the m_visibleRect on the layer, because this
caused a later call to adjustTiledLayerVisibleRect() to think that the visible
rect had not changed, so it did no expansion.
Clarify the logic to ask the GraphicsLayer whether, given a new visible
rect, it would need to make new tiles (which happens later during a flush).
Add a function to RenderLayerCompositor to call this code (but which has
no callers yet).
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::visibleRectChangeRequiresFlush): Make private.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush):
(WebCore::GraphicsLayerCA::visibleRectChangeRequiresFlush):
- platform/graphics/ca/GraphicsLayerCA.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::noteVisibleRectChanged):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 5:13 PM Changeset in webkit [147185] by
-
- 4 edits in trunk
[HTMLTemplateElement] <template> should be able to be a foster parent
https://bugs.webkit.org/show_bug.cgi?id=113541
Source/WebCore:
Reviewed by Eric Seidel
This adds to the check in findFosterSite to include whether the parent is a DocumentFragment which is a template contents.
Tests added to html5lib suite.
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::findFosterSite):
LayoutTests:
Reviewed by Eric Seidel.
- html5lib/resources/template.dat:
- 5:09 PM Changeset in webkit [147184] by
-
- 17 edits in trunk/Source/JavaScriptCore
Simplified the bytecode by removing op_jmp_scopes
https://bugs.webkit.org/show_bug.cgi?id=113545
Reviewed by Filip Pizlo.
We already have op_pop_scope and op_jmp, so we don't need op_jmp_scopes.
Using op_jmp_scopes was also adding a "jump to self" to codegen for
return statements, which was pretty silly.
- JavaScriptCore.order:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecode/Opcode.h:
(JSC::padOpcodeName):
- bytecode/PreciseJumpTargets.cpp:
(JSC::computePreciseJumpTargets):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitComplexPopScopes):
(JSC::BytecodeGenerator::emitPopScopes):
- bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
- bytecompiler/NodesCodegen.cpp:
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
- jit/JITOpcodes32_64.cpp:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- llint/LLIntSlowPaths.cpp:
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- 4:46 PM Changeset in webkit [147183] by
-
- 9 edits in trunk/LayoutTests
Convert some flexbox layout tests to using flexbox.css
https://bugs.webkit.org/show_bug.cgi?id=113534
Reviewed by Ojan Vafai.
This allows tests to be run without the -webkit prefix for flexbox tests allowing
some of them to run in Firefox.
- css3/flexbox/flex-align-baseline.html:
- css3/flexbox/flex-align-column.html:
- css3/flexbox/flex-align-end.html:
- css3/flexbox/flex-align-max.html:
- css3/flexbox/flex-align-percent-height.html:
- css3/flexbox/flex-align-stretch.html:
- css3/flexbox/flex-align-vertical-writing-mode.html:
- css3/flexbox/flex-align.html:
- 4:43 PM Changeset in webkit [147182] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, fix up some lint errors in TestExpectations.
- platform/chromium/TestExpectations:
- 4:40 PM Changeset in webkit [147181] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Use widget.parent() for plugin WebMouseEvents
https://bugs.webkit.org/show_bug.cgi?id=113543
Reviewed by James Robinson.
In r142571 I switches widget.parent() to widget.root() in the plugin
WebCore event -> WebMouseEvent creator, to make the converter the
inverse of the one going the other way and avoid null pointer crashes.
But the plugin code expects it to be parent() (see
http://crbug.com/223335).
- src/WebInputEventConversion.cpp:
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
- 4:12 PM Changeset in webkit [147180] by
-
- 10 edits in tags/Safari-537.35.3
Merged r146955. <rdar://problem/12324224>
- 4:09 PM Changeset in webkit [147179] by
-
- 4 edits in trunk/Source/WebKit2
Resources are never revalidated/reloaded if a cached response exists on disk.
<rdar://problem/13479890> and https://bugs.webkit.org/show_bug.cgi?id=113542
Reviewed by Alexey Proskuryakov.
Trying to get a cached resource in didReceiveResponse and then aborting the load
meant we never performed any new loads.
We can check and see if the data is cached data inside didReceiveBuffer, instead.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponse): Don't try for cached resources here.
(WebKit::NetworkResourceLoader::didReceiveData): This callback should never be used.
(WebKit::NetworkResourceLoader::didReceiveBuffer): Try to see if this data objected represents
a file based mmaped buffer.
- NetworkProcess/NetworkResourceLoader.h:
Refactor these utility functions to start from either a CFURLCachedResponse or a SharedBuffer:
- NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(CFCachedURLResponseGetMemMappedData):
(CFURLCacheIsMemMappedData):
(WebKit::tryGetShareableHandleFromCFData):
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromCFURLCachedResponse):
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):
- 4:08 PM Changeset in webkit [147178] by
-
- 4 edits in trunk/Source
[Chromium] Don't create SolidColorLayer for full transparent background
https://bugs.webkit.org/show_bug.cgi?id=113524
Reviewed by James Robinson.
Source/WebCore:
Test: GraphicsLayerChromiumTest.setContentsToSolidColor
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToSolidColor):
Source/WebKit/chromium:
- tests/GraphicsLayerChromiumTest.cpp:
(GraphicsLayerChromiumTest::setContentsToSolidColor):
- 4:07 PM Changeset in webkit [147177] by
-
- 2 edits in tags/Safari-537.35.3/Source/WebCore
Merged r147050. <rdar://problem/13205610>
- 4:03 PM Changeset in webkit [147176] by
-
- 5 edits2 copies in tags/Safari-537.35.3
Merged r147018. <rdar://problem/13205610>
- 4:00 PM Changeset in webkit [147175] by
-
- 2 edits in tags/Safari-537.35.3/Source/WebKit2
Merged r146722. <rdar://problem/13205610>
- 3:55 PM Changeset in webkit [147174] by
-
- 10 edits in tags/Safari-537.35.3/Source
Merged r146664. <rdar://problem/13205610>
- 3:48 PM Changeset in webkit [147173] by
-
- 12 edits4 copies in tags/Safari-537.35.3
Merged r146946. <rdar://problem/13486852>
- 3:39 PM Changeset in webkit [147172] by
-
- 4 edits2 moves in trunk
use XMLHttpRequestResponseType enumeration in XMLHttpRequest.idl
https://bugs.webkit.org/show_bug.cgi?id=113518
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Kentaro Hara.
Source/WebCore:
Use enum XMLHttpRequestResponseType type instead of DOMString for
XMLHttpRequest responseType.
Argument validation now happens in the bindings.
XMLHttpRequest::setResponseType should then never receive invalid
arguments. So, replace console message with ASSERT_NOT_REACHED();
Test: fast/xmlhttprequest/xmlhttprequest-set-responsetype.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::setResponseType):
- xml/XMLHttpRequest.idl:
LayoutTests:
Update xmlhttprequest-responsetype-set-invalidtype expected result:
Test all valide responseType. Remove expected console message in case
of invalid responseType. Rename to xmlhttprequest-set-responsetype
- fast/xmlhttprequest/xmlhttprequest-set-responsetype-expected.txt: Renamed from LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt.
- fast/xmlhttprequest/xmlhttprequest-set-responsetype.html: Renamed from LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype.html.
- fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt:
- 3:29 PM Changeset in webkit [147171] by
-
- 326 edits17 copies2 deletes in tags/Safari-537.35.3
Merged r146531. <rdar://problem/12324224>
- 3:25 PM Changeset in webkit [147170] by
-
- 3 edits1 add in trunk
[css3-text] Add platform support for "wavy" text decoration style
https://bugs.webkit.org/show_bug.cgi?id=92868
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-03-28
Reviewed by Benjamin Poulain.
Source/WebCore:
This patch uses GraphicsContext::strokePath() to implement
wavy decoration for the CSS3 property "text-decoration-style".
No new tests as this is covered with existing tests.
- rendering/InlineTextBox.cpp:
(WebCore::textDecorationStyleToStrokeStyle): Remove obsolete comment.
(WebCore::adjustStepToDecorationLength): Add function to adjust
variables used to calculate the lenght of Bezier curves.
(WebCore::strokeWavyTextDecoration): Add function to stroke wavy
decoration based on cubic Bezier curve.
(WebCore::InlineTextBox::paintDecoration): Call
strokeWavyTextDecoration when necessary.
LayoutTests:
Rebaseline chromium-linux expectation for
fast/css3-text/css3-text-decoration/text-decoration-style.html.
- platform/chromium-linux/fast/css3-text/css3-text-decoration/text-decoration-style-expected.png: Added.
- 3:17 PM Changeset in webkit [147169] by
-
- 5 edits in trunk/Source/WebCore
REGRESSION(r147149): breaks binding test on Mac. (Requested by mlam_ on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=113538
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Simon Fraser.
Run run-bindings-tests --reset-results to fix broken tests after
r147149.
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::shortAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetter):
(WebCore::TestObjV8Internal::longAttrAttrSetter):
(WebCore::TestObjV8Internal::longLongAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetter):
(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::createAttrSetter):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetter):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetter):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetter):
(WebCore::TestObjV8Internal::anyAttributeAttrSetter):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetter):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetter):
(WebCore::TestObjV8Internal::enabledPerContextAttr1AttrSetter):
(WebCore::TestObjV8Internal::enabledPerContextAttr2AttrSetter):
(WebCore::TestObjV8Internal::floatArrayAttrSetter):
(WebCore::TestObjV8Internal::doubleArrayAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::strawberryAttrSetter):
(WebCore::TestObjV8Internal::strictFloatAttrSetter):
(WebCore::TestObjV8Internal::idAttrSetter):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrSetter):
(WebCore::TestObjV8Internal::nullableStringValueAttrSetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterForMainWorld):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetter):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetter):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetter):
- 3:07 PM Changeset in webkit [147168] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] REGRESSION (r125500): WebFrameLoaderClient's active m_pluginView can be zeroed by PluginDocuments leaving the page cache
https://bugs.webkit.org/show_bug.cgi?id=113430
<rdar://problem/12729564>
Reviewed by Brady Eidson.
http://trac.webkit.org/changeset/147152 was wrong, and should have been
(as the ChangeLog stated) testing the argument to redirectDataToPlugin,
not the value of m_pluginView.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::redirectDataToPlugin):
- 3:07 PM Changeset in webkit [147167] by
-
- 6 edits1 delete in trunk/Source/WebCore
Unreviewed, rolling out r147130.
http://trac.webkit.org/changeset/147130
https://bugs.webkit.org/show_bug.cgi?id=113539
Not needed now that we do not sleep in preprocessor.pm
(Requested by jamesr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-28
- WebCore.gyp/WebCore.gyp:
- bindings/scripts/CodeGenerator.pm:
(ParseInterface):
- bindings/scripts/IDLParser.pm:
(Parse):
- bindings/scripts/generate-bindings.pl:
- bindings/scripts/generate-preprocessed-idls.pl: Removed.
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- 3:01 PM Changeset in webkit [147166] by
-
- 2 edits in trunk/Tools
Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
Unreviewed.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):
- 2:58 PM Changeset in webkit [147165] by
-
- 6 edits in trunk
Source/WebCore: Don't grant local content permissions for appcache loads.
https://bugs.webkit.org/show_bug.cgi?id=112542
Reviewed by Antti Koivisto.
No new tests, fixing http/tests/appcache/local-content.html
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::commitData): Don't grant local load permissions
to all SubstituteData loads, only give them to loads that were SubstituteData
loads at the time of DocumentLoader construction. This constitutes all
SubstituteData loads except those triggered by appcache.
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument): Move granting local load
permissions for SubstituteData loads to DocumentLoader::commitData().
LayoutTests: Remove expected failure for https://bugs.webkit.org/show_bug.cgi?id=112542
Reviewed by Antti Koivisto.
- platform/qt-5.0-wk1/TestExpectations:
- 2:56 PM Changeset in webkit [147164] by
-
- 15 edits in trunk
X-Frame-Options: Blocked resources should fire load events.
https://bugs.webkit.org/show_bug.cgi?id=113192
Reviewed by Nate Chapin.
Source/WebCore:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
Fire a load event on the frame's owner element when denying access
due to X-Frame-Options header content. This brings us in-line with
Gecko and IE, which both trigger load events currently.
LayoutTests:
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html:
- http/tests/security/XFrameOptions/x-frame-options-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
Add some expectations around the 'load' event to ensure it's fired.
- 2:50 PM Changeset in webkit [147163] by
-
- 11 edits1 add in trunk/Source
Support bottom-right anchored fixed-position elements during a pinch gesture
https://bugs.webkit.org/show_bug.cgi?id=111670
Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-03-28
Reviewed by James Robinson.
Source/Platform:
Added WebLayerPositionConstraint for layers that need position
adjustment during threaded scrolling.
Currently it is only used for fixed-position layers.
- Platform.gypi:
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::setPositionConstraint):
(WebKit::WebLayer::positionConstraint):
(WebKit::WebLayer::setFixedToContainerLayer):
(WebKit::WebLayer::fixedToContainerLayer):
- chromium/public/WebLayerPositionConstraint.h: Added.
(WebKit):
(WebLayerPositionConstraint):
(WebKit::WebLayerPositionConstraint::WebLayerPositionConstraint):
(WebKit::WebLayerPositionConstraint::fixedPosition):
Source/WebCore:
This patch adds support to bottom-right fixed-position elements by
introducing WebLayerPositionConstraint to WebLayer.
No new tests. Can't test until chromium patch landed.
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::updateLayerPositionConstraint):
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::clearPositionConstraintExceptForLayer):
(WebCore):
(WebCore::computePositionConstraint):
(WebCore::ScrollingCoordinatorChromium::updateLayerPositionConstraint):
- page/scrolling/chromium/ScrollingCoordinatorChromium.h:
(ScrollingCoordinatorChromium):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::registerScrollingLayers):
- rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::contentsContainmentLayer):
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
- rendering/RenderLayerCompositor.h:
- 2:50 PM Changeset in webkit [147162] by
-
- 20 edits in tags/Safari-537.35.3/Source
Merged r146823. <rdar://problem/13475462>
- 2:46 PM Changeset in webkit [147161] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] REGRESSION(r88030): Right-click on invalid form controls unexpectedly dispatches 'invalid' events
https://bugs.webkit.org/show_bug.cgi?id=113377
Reviewed by Dimitri Glazkov.
- src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
We don't need to call HTMLFormElement::checkValidity here.
- 2:46 PM Changeset in webkit [147160] by
-
- 1 edit in tags/Safari-537.35.3/Source/WTF/ChangeLog
Fix revision number in ChangeLog.
- 2:45 PM Changeset in webkit [147159] by
-
- 2 edits in tags/Safari-537.35.3/Source/WTF
Merge portion of r146823 needed for <rdar://problem/13475462>
- wtf/HashSet.h:
(WTF):
(WTF::copyToVector):
- 2:44 PM Changeset in webkit [147158] by
-
- 1 edit in trunk/LayoutTests/platform/chromium/TestExpectations
[Chromium] Unreviewed. Test Expectations update.
- platform/chromium/TestExpectations:
- 2:31 PM Changeset in webkit [147157] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary 1 second sleep on windows from preprocessor.pm
https://bugs.webkit.org/show_bug.cgi?id=113536
Unreviewed, partial rollout of r146661.
This rolls out one line of 146661 that slows down the windows build significantly.
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- 2:03 PM Changeset in webkit [147156] by
-
- 5 edits in trunk
Source/WebCore: Enable font measurement optimization for Chromium-mac when there are no font-feature-settings.
Enable measure-once optimization on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=113243
Reviewed by Eric Seidel.
Bugs in Chromium-mac's -webkit-font-feature-settings support prevented us from enabling the
optimization when it was enabled for all other platforms. This was believed to be related to
kerning, but the bug shows up when there are any font-feature-settings specified. For now,
optimizing the common case and only turning off the optimization when there are font-feature-
settings in play.
Updated test fast/text/shaping/shaping-selection-rect.html to avoid breaking due to
https://bugs.webkit.org/show_bug.cgi?id=113418
- rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):
LayoutTests: Disable font measurement optimization for Chromium-mac when there are font-feature-settings.
Enable measure-once optimization on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=113243
Reviewed by Eric Seidel.
- fast/text/shaping/shaping-selection-rect.html: Adding a small-caps case to prevent regressing
- 2:01 PM Changeset in webkit [147155] by
-
- 3 edits2 moves3 adds in trunk
[CSS Exclusions][CSS Regions] Block children do not layout inline content correctly in a region with shape-inside set
https://bugs.webkit.org/show_bug.cgi?id=112177
Reviewed by David Hyatt.
Source/WebCore:
When we had two multiple regions and a shape-inside was applied on the second region, but not on the first region and the content contained
paragraphs, the content was pushed down almost to the bottom in the second region. In a flow thread this behavior caused by the lack of the
proper updating of absoluteLogicalTop in RenderBlock::layoutRunsAndFloatsInRange function.
Tests: fast/regions/shape-inside/shape-inside-on-additional-regions.html
fast/regions/shape-inside/shape-inside-on-regions.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Update the value of absoluteLogicalTop in every run when we are in a flow thread.
LayoutTests:
Add a new subdirectory for regions shape-inside tests. Move old and add new test files to the directory.
- fast/regions/shape-inside: Added.
- fast/regions/shape-inside/shape-inside-on-additional-regions-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-additional-regions.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-expected.html: Renamed from LayoutTests/fast/regions/shape-inside-on-regions-expected.html.
- fast/regions/shape-inside/shape-inside-on-regions.html: Renamed from LayoutTests/fast/regions/shape-inside-on-regions.html.
- 1:52 PM Changeset in webkit [147154] by
-
- 1 edit1 copy1 move2 adds in trunk/LayoutTests
Unreviewed rebaseline.
Adding missing baseline for new test compositing/contents-opaque/control-layer.html
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/contents-opaque/control-layer-expected.txt: Copied from LayoutTests/platform/chromium/compositing/contents-opaque/control-layer-expected.txt.
- platform/chromium-win/compositing/contents-opaque/control-layer-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/contents-opaque/control-layer-expected.txt.
- 1:38 PM Changeset in webkit [147153] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r191172. Requested by
pdr2 via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-28
- DEPS:
- 1:24 PM Changeset in webkit [147152] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] REGRESSION (r125500): WebFrameLoaderClient's active m_pluginView can be zeroed by PluginDocuments leaving the page cache
https://bugs.webkit.org/show_bug.cgi?id=113430
<rdar://problem/12729564>
Reviewed by Brady Eidson.
Ignore redirectDataToPlugin(0), which is only called from PluginDocument::detach(),
and only after r125500. Otherwise, PluginDocuments that are put into the page cache
but leave later can clear a totally different and legitimate PluginView from the
WebFrameLoaderClient, causing data to be lost and PluginDocument loads to stall.
This restores our behavior to the pre-r125500 state, which should be fine, as we
clear WebFrameLoaderClient's m_pluginView when the load fails or finishes. This
matches the changes made in r125500 for every platform other than Chromium and WebKit2.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::redirectDataToPlugin):
- 1:21 PM Changeset in webkit [147151] by
-
- 3 edits in trunk/Source/WebKit2
PDFPlugin: shouldUsePDFPlugin can't use pdfLayerControllerClass() because it asserts if it's not available
https://bugs.webkit.org/show_bug.cgi?id=113533
<rdar://problem/13528720>
Reviewed by Simon Fraser.
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::shouldUsePDFPlugin):
Move shouldUsePDFPlugin to WebPageMac, where it belongs, and explicitly look up PDFLayerController
instead of using pdfLayerControllerClass(), which ASSERT()s if it isn't available.
- 1:21 PM Changeset in webkit [147150] by
-
- 3 edits in trunk/Source/JavaScriptCore
Safari hangs during test262 run in CodeCache::pruneSlowCase
https://bugs.webkit.org/show_bug.cgi?id=113469
Reviewed by Geoffrey Garen.
We can end up hanging for quite some time if we add a lot of small keys to the CodeCache.
By the time we get around to pruning the cache, we have a potentially tens or hundreds of
thousands of small entries, which can cause a noticeable hang when pruning them.
To fix this issue we added a hard cap to the number of entries in the cache because we
could potentially have to remove every element in the map.
- runtime/CodeCache.cpp:
(JSC::CodeCacheMap::pruneSlowCase): We need to prune until we're both under the hard cap and the
capacity in bytes.
- runtime/CodeCache.h:
(CodeCacheMap):
(JSC::CodeCacheMap::numberOfEntries): Convenience accessor function to the number of entries in
the map that does the cast to size_t of m_map.size() for us.
(JSC::CodeCacheMap::canPruneQuickly): Checks that the total number is under the hard cap. We put this
check inside a function to more accurately describe why we're doing the check and to abstract out
the actual calculation in case we want to coalesce calls to pruneSlowCase in the future.
(JSC::CodeCacheMap::prune): Check the number of entries against our hard cap. If it's greater than
the cap then we need to drop down to pruneSlowCase.
- 1:08 PM Changeset in webkit [147149] by
-
- 5 edits in trunk
exceptions are not checked after toInt32 calls in bindings.
https://bugs.webkit.org/show_bug.cgi?id=113218
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Kentaro Hara.
Source/WebCore:
In attribute setter, wrap JSValue to native value conversion in a try
catch block.
Define a new macro binding: V8TRYCATCH_VOID
No new tests: covered by fast/dom/exception-in-binding.html
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter):
- bindings/v8/V8BindingMacros.h:
(WebCore):
LayoutTests:
- platform/chromium/TestExpectations: Enable fast/dom/exception-in-binding.html
- 1:05 PM Changeset in webkit [147148] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening on AppleWin port.
More tests that use mouseScrollBy event which hasn't been implemented yet on Windows.
- platform/win/TestExpectations:
- 1:01 PM Changeset in webkit [147147] by
-
- 2 edits in trunk/Tools
Use the right OS name on Mac EWS instead of mac-future.
Rubber-stamped by Dirk Pranke.
- Scripts/webkitpy/tool/commands/queues.py:
(PatchProcessingQueue._new_port_name_from_old):
(PatchProcessingQueue.begin_work_queue):
(PatchProcessingQueue._upload_results_archive_for_patch):
- 12:59 PM Changeset in webkit [147146] by
-
- 2 edits2 moves in trunk/LayoutTests
Prepare extend-selection-enclosing-block test to support different editing behavior
https://bugs.webkit.org/show_bug.cgi?id=113424
Reviewed by Ryosuke Niwa.
We make this test Mac specific and change
extendAndLogSelectionWithinBlock() to take the platform as a
parameter. When bug 110487 is fixed this should be extended to
test the Windows editing behavior.
- editing/selection/extend-selection-enclosing-block-mac-expected.txt:
Renamed from
LayoutTests/editing/selection/extend-selection-enclosing-block-expected.txt.
- editing/selection/extend-selection-enclosing-block-mac.html:
Renamed from
LayoutTests/editing/selection/extend-selection-enclosing-block.html.
- editing/selection/resources/extend-selection.js:
(extendAndLogSelectionWithinBlock): Extend to receive platform as
a parameter. Only "mac" is supported for now.
- 12:59 PM Changeset in webkit [147145] by
-
- 5 edits in trunk/Source/WebCore
[GTK][AC] Use transform property of ClutterActor
https://bugs.webkit.org/show_bug.cgi?id=113317
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-28
Reviewed by Gustavo Noronha Silva.
ClutterActor has a transform property to set transformation matrix directly
since version 1.12. So we don't need to keep and use the matrix property of GraphicsLayerActor.
No new tests because of no functionality change.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(_GraphicsLayerActorPrivate):
(graphicsLayerActorDispose):
(graphicsLayerActorApplyTransform):
- platform/graphics/clutter/GraphicsLayerActor.h:
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::updateTransform):
- platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::PlatformClutterAnimation::addTransformTransition):
- 12:57 PM Changeset in webkit [147144] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r143834.
http://trac.webkit.org/changeset/143834
https://bugs.webkit.org/show_bug.cgi?id=113530
Multiple use-after-free regressions on ClusterFuzz (Requested
by inferno-sec on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-28
- dom/Attr.cpp:
(WebCore::Attr::Attr):
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):
- dom/Attr.h:
(Attr):
- dom/Element.cpp:
(WebCore::Element::setAttributeInternal):
- dom/Element.h:
(Element):
- 12:52 PM Changeset in webkit [147143] by
-
- 2 edits in trunk/LayoutTests
Use String.trim() in editing/selection/move-vertically-with-paddings-borders.html test
https://bugs.webkit.org/show_bug.cgi?id=113490
Reviewed by Ryosuke Niwa.
- editing/selection/move-vertically-with-paddings-borders.html:
(selectWord): Use String.trim() to drop trailing whitespaces that
might be added depending on the editing behavior. See related bug
110487.
- 12:46 PM Changeset in webkit [147142] by
-
- 4 edits in tags/Safari-537.35.3/Source
Versioning
- 12:42 PM Changeset in webkit [147141] by
-
- 1 copy in tags/Safari-537.35.3
New Tag.
- 12:24 PM Changeset in webkit [147140] by
-
- 5 edits6 adds in trunk
[CSS Grid Layout] Before / start paddings and borders are not accounted for when placing the grid items
https://bugs.webkit.org/show_bug.cgi?id=113351
Reviewed by Tony Chang.
Source/WebCore:
Tests: fast/css-grid-layout/grid-element-border-grid-item.html
fast/css-grid-layout/grid-element-border-padding-grid-item.html
fast/css-grid-layout/grid-element-padding-grid-item.html
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderAndPaddingBefore):
Added this helper function (we do have borderAndPaddingStart but didn't have this
one for some reason).
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::findChildLogicalPosition):
Shifted |offset| by the paddings and borders before / start.
LayoutTests:
- fast/css-grid-layout/resources/grid.css:
(.verticalLR):
(.horizontalBT):
(.directionRTL):
Added more helper classes.
- fast/css-grid-layout/grid-element-border-grid-item-expected.txt: Added.
- fast/css-grid-layout/grid-element-border-grid-item.html: Added.
- fast/css-grid-layout/grid-element-border-padding-grid-item-expected.txt: Added.
- fast/css-grid-layout/grid-element-border-padding-grid-item.html: Added.
- fast/css-grid-layout/grid-element-padding-grid-item-expected.txt: Added.
- fast/css-grid-layout/grid-element-padding-grid-item.html: Added.
- 12:08 PM Changeset in webkit [147139] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Unskip some layout test folder on Windows port.
- platform/win/TestExpectations:
- 12:00 PM Changeset in webkit [147138] by
-
- 2 edits in trunk/Source/WebKit2
Reduce PluginProcess lifetime.
<rdar://problem/12465479> and https://bugs.webkit.org/show_bug.cgi?id=113523
Reviewed by Sam Weinig.
Lower the minimum process lifetime from 30 minutes to 2 minutes.
Lower the "shutdown after last plugin goes away" period from 10 minutes to 1 minute.
- UIProcess/Plugins/PluginProcessProxy.cpp:
- 11:58 AM Changeset in webkit [147137] by
-
- 18 edits2 adds2 deletes in trunk
[GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
https://bugs.webkit.org/show_bug.cgi?id=112546
Reviewed by Martin Robinson.
.:
- GNUmakefile.am: Define the new platform_webcore_cppflags.
Source/Platform:
- GNUmakefile.am: Only specify the very minimal set of inclusion directories, containing the Source/WebCore/platform
directory and its subdirectories. This will allow only for the WebCore-independent GTK-specific sources to be built into
libPlatformGtk.la. Also include the GTK, libsecret and libsoup dependencies' cflags amongst the libPlatformGtk's
CPPFLAGS.
- GNUmakefile.list.am: Removed. The build targets are now listed (and will be listed until the migration) in the
GNUmakefile.list.am under Source/WebCore, following the common sense of specifying the build target in the
GNUmakefile.list.am placed in the same framework directory in which the source file is located.
Source/WebCore:
No new tests - no new functionality.
- GNUmakefile.am: Passing the DATA_DIR value through the cppflags is not required anymore as the affected source is now
built into libPlatformGtk.la.
- GNUmakefile.list.am: Build the GTK-specific source files that are already independent of WebCore into the
libPlatformGtk.la by assigning the build targets listing to the platformgtk_sources variable.
- platform/gtk/GtkVersioning.c: Renamed from Source/Platform/gtk/GtkVersioning.c.
- platform/gtk/GtkVersioning.h: Renamed from Source/Platform/gtk/GtkVersioning.h.
Source/WebKit/gtk:
- GNUmakefile.am: The GtkVersioning.c file has moved back under Source/WebCore/platform.
Source/WebKit2:
- GNUmakefile.am: Reference the platform_webcore_cppflags and GTK, libsecret and libsoup dependencies' cflags amongst the
libPlatformGtk2's CPPFLAGS.
- Scripts/generate-forwarding-headers.pl: Remove the Platform framework from the list of the frameworks to be searched
for forwarding headers, it's at the moment not necessary to be included.
- Shared/gtk/ArgumentCodersGtk.cpp: Adjust the forwarding header for GtkVersioning.h that's been moved back under the
WebCore framework.
- Shared/gtk/WebEventFactory.cpp: Ditto.
- UIProcess/API/gtk/WebKitWebViewBase.cpp: Ditto.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Ditto.
Tools:
- GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
moved back to Source/WebCore/platform. Fix an indentation issue as well.
- 11:44 AM Changeset in webkit [147136] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Don't use WebKit thread scale information in WebPageCompositor.
https://bugs.webkit.org/show_bug.cgi?id=113447
Internal PR 313452
Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.
Potential threading problems are avoided by moving from
WebPage members and mapToTransformed() to the web page
client's userInterfaceViewportAccessor().
As part of this cleaning effort, the WebPageCompositor's
render() method is changed to now take document instead of
pixel coordinates.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositor::render):
- Api/WebPageCompositor.h:
- Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
- 11:38 AM Changeset in webkit [147135] by
-
- 55 edits in trunk/Source
Refactoring: Replace Element::disabled and isEnabledFormControl with isDisabledFormControl
https://bugs.webkit.org/show_bug.cgi?id=113273
Reviewed by Kent Tamura.
Element::disabled is about form controls and Element::isEnabledFormControl
is redundant with it, so replace them with a single function
Element::isDisabledFormControl.
Source/WebCore:
No new tests, there should be no behavior change.
- accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute):
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::canSetFocusAttribute):
- accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::isEnabled):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isEnabled):
(WebCore::AccessibilityNodeObject::actionElement):
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithControl):
- dom/Element.cpp:
(WebCore::Element::isDisabledFormControl):
- dom/Element.h:
(Element):
(WebCore::isDisabledFormControl): Add helper function for convenience.
(WebCore):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick):
- dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::dispatchEvent):
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
- dom/Node.cpp:
(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled):
- html/DOMFormData.cpp:
(WebCore::DOMFormData::DOMFormData):
- html/FileInputType.cpp:
(WebCore::FileInputType::handleDOMActivateEvent):
(WebCore::FileInputType::disabledAttributeChanged):
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::defaultEventHandler):
(WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
(WebCore::HTMLButtonElement::isSuccessfulSubmitButton):
- html/HTMLCollection.cpp:
(WebCore::isMatchingElement):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::updateAncestorDisabledState):
(WebCore::HTMLFormControlElement::isDisabledFormControl):
(WebCore::HTMLFormControlElement::supportsFocus):
- html/HTMLFormControlElement.h:
(HTMLFormControlElement):
(WebCore::HTMLFormControlElement::isDisabledOrReadOnly):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isSuccessfulSubmitButton):
(WebCore::HTMLInputElement::willRespondToMouseClickEvents):
- html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::isDisabledFormControl):
- html/HTMLOptGroupElement.h:
(HTMLOptGroupElement):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::isDisabledFormControl):
- html/HTMLOptionElement.h:
(HTMLOptionElement):
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::defaultEventHandler):
(WebCore::HTMLSelectElement::optionAtIndex):
- html/ImageInputType.cpp:
(WebCore::ImageInputType::handleDOMActivateEvent):
- html/ResetInputType.cpp:
(WebCore::ResetInputType::handleDOMActivateEvent):
- html/SubmitInputType.cpp:
(WebCore::SubmitInputType::handleDOMActivateEvent):
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::isDisabledFormControl):
(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):
- html/shadow/SliderThumbElement.h:
(SliderThumbElement):
- html/shadow/SpinButtonElement.h:
- html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::updateImage):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemIsEnabled):
- rendering/RenderTextControl.cpp:
(WebCore::updateUserModifyProperty):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isEnabled):
- rendering/RenderThemeMac.mm:
(WebCore::getMediaUIPartStateFlags):
- rendering/RenderThemeMacShared.mm:
(WebCore::RenderThemeMacShared::adjustMenuListStyle):
(WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):
- rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::adjustMenuListStyle):
Source/WebKit/blackberry:
- WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::findPasswordFormFields):
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openSelectPopup):
Source/WebKit/chromium:
- src/WebFormControlElement.cpp:
(WebKit::WebFormControlElement::isEnabled):
- src/WebOptionElement.cpp:
(WebKit::WebOptionElement::isEnabled):
- src/WebPasswordFormUtils.cpp:
(WebKit::findPasswordFormFields):
- src/WebSearchableFormData.cpp:
(HTMLNames::findSuitableSearchInputElement):
(HTMLNames::buildSearchString):
Source/WebKit/win:
- DOMHTMLClasses.cpp:
(DOMHTMLInputElement::disabled):
- 11:24 AM Changeset in webkit [147134] by
-
- 2 edits in trunk/Source/WebCore
Remove workaround for <rdar://problem/5321972>.
<rdar://problem/12022862> and https://bugs.webkit.org/show_bug.cgi?id=113516
Reviewed by Sam Weinig.
No new tests (No point in testing the removal of bizarre behavior).
- platform/network/mac/WebCoreURLResponse.mm:
(WebCore::adjustMIMETypeIfNecessary): This workaround isn't needed on Lion+
- 11:13 AM Changeset in webkit [147133] by
-
- 3 edits2 adds in trunk
use CanvasWindingRule enumeration in CanvasRenderingContext2D.idl
https://bugs.webkit.org/show_bug.cgi?id=113456
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Kentaro Hara.
Source/WebCore:
Use enum CanvasWindingRule type instead of DOMString for winding
arguments when needed. Changed methods are: fill, stroke and isPointInPath.
Test: fast/canvas/winding-enumeration.html
- html/canvas/CanvasRenderingContext2D.idl:
LayoutTests:
When calling methods accepting a CanvasWindingRule with an invalid
string, check that a TypeError is thrown.
- fast/canvas/winding-enumeration-expected.txt: Added.
- fast/canvas/winding-enumeration.html: Added.
- 10:47 AM Changeset in webkit [147132] by
-
- 1 edit1 move2 adds1 delete in trunk/LayoutTests
Rebaseline font-face-woff after r147020
Unreviewed gardening.
Updated using garden-o-matic.
- fast/css/font-face-woff-expected.txt: Renamed from LayoutTests/platform/chromium/fast/css/font-face-woff-expected.txt.
- platform/mac/fast/css/font-face-woff-expected.txt: Removed.
- platform/qt/fast/css/font-face-woff-expected.png: Added.
- platform/qt/fast/css/font-face-woff-expected.txt: Added.
- 10:40 AM Changeset in webkit [147131] by
-
- 2 edits in trunk/LayoutTests
Gardening: bypassing inspector/styles/paste-property.html, compositing/iframes/remove-iframe-crash.html.
Not Reviewed.
- platform/mac-wk2/TestExpectations:
- 10:27 AM Changeset in webkit [147130] by
-
- 6 edits1 add in trunk/Source/WebCore
Move preprocessing of idl to pre-pass for gyp
https://bugs.webkit.org/show_bug.cgi?id=113448
Patch by Scott Graham <scottmg@chromium.org> on 2013-03-28
Reviewed by Tony Chang.
Moves the preprocessor invocations when parsing IDL files to a
pre-pass to avoid reinvocations when IDLs are referenced from others.
This reduces the number of invocations of the preprocessor from 20071
to 633, which reduces the runtime from 12m30 to 1m (on a Windows box).
No new tests, this is a build time improvement, and shouldn't have any
visible effect.
- WebCore.gyp/WebCore.gyp:
- bindings/scripts/CodeGenerator.pm:
(ParseInterface):
- bindings/scripts/IDLParser.pm:
(Parse):
- bindings/scripts/generate-bindings.pl:
- bindings/scripts/generate-preprocessed-idls.pl: Added.
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- 10:25 AM Changeset in webkit [147129] by
-
- 1 edit74 adds in trunk/LayoutTests
[Qt] Unreviewed gardneing. Updated png expected results after r146206.
- platform/qt-5.0-wk2/editing/deleting/5126166-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/5206311-1-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/5369009-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/5433862-2-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-3608445-fix-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-at-paragraph-boundaries-002-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-block-contents-003-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-br-002-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-br-003-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-br-004-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-br-006-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-hr-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-image-002-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-listitem-001-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/merge-different-styles-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/pruning-after-merge-2-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/smart-delete-003-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/smart-delete-004-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/type-delete-after-quote-expected.png: Added.
- platform/qt-5.0-wk2/editing/execCommand/4580583-1-expected.png: Added.
- platform/qt-5.0-wk2/editing/execCommand/4924441-expected.png: Added.
- platform/qt-5.0-wk2/editing/execCommand/indent-empty-root-expected.png: Added.
- platform/qt-5.0-wk2/editing/execCommand/insertHorizontalRule-expected.png: Added.
- platform/qt-5.0-wk2/editing/execCommand/insertImage-expected.png: Added.
- platform/qt-5.0-wk2/editing/execCommand/nsresponder-indent-expected.png: Added.
- platform/qt-5.0-wk2/editing/execCommand/nsresponder-outdent-expected.png: Added.
- platform/qt-5.0-wk2/editing/execCommand/remove-list-item-1-expected.png: Added.
- platform/qt-5.0-wk2/editing/inserting/4875189-1-expected.png: Added.
- platform/qt-5.0-wk2/editing/inserting/4875189-2-expected.png: Added.
- platform/qt-5.0-wk2/editing/inserting/4959067-expected.png: Added.
- platform/qt-5.0-wk2/editing/inserting/5418891-expected.png: Added.
- platform/qt-5.0-wk2/editing/inserting/insert-3778059-fix-expected.png: Added.
- platform/qt-5.0-wk2/editing/inserting/insert-3800346-fix-expected.png: Added.
- platform/qt-5.0-wk2/editing/inserting/insert-div-025-expected.png: Added.
- platform/qt-5.0-wk2/editing/inserting/insert-paragraph-02-expected.png: Added.
- platform/qt-5.0-wk2/editing/inserting/paragraph-separator-03-expected.png: Added.
- platform/qt-5.0-wk2/editing/inserting/redo-expected.png: Added.
- platform/qt-5.0-wk2/editing/pasteboard/4076267-expected.png: Added.
- platform/qt-5.0-wk2/editing/pasteboard/4242293-expected.png: Added.
- platform/qt-5.0-wk2/editing/pasteboard/4641033-expected.png: Added.
- platform/qt-5.0-wk2/editing/pasteboard/4944770-1-expected.png: Added.
- platform/qt-5.0-wk2/editing/pasteboard/4944770-2-expected.png: Added.
- platform/qt-5.0-wk2/editing/pasteboard/5032095-expected.png: Added.
- platform/qt-5.0-wk2/editing/pasteboard/5134759-expected.png: Added.
- platform/qt-5.0-wk2/editing/pasteboard/merge-end-borders-expected.png: Added.
- platform/qt-5.0-wk2/editing/pasteboard/merge-start-list-expected.png: Added.
- platform/qt-5.0-wk2/editing/pasteboard/styled-element-markup-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/13804-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/4866671-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/5076323-1-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/5099303-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/5195166-2-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/expanding-selections-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/expanding-selections2-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/extend-by-character-003-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/extend-by-character-005-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/extend-by-sentence-001-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/inline-table-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/mixed-editability-4-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/mixed-editability-5-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/mixed-editability-9-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/move-by-character-003-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/move-by-character-005-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/replace-selection-1-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/table-caret-3-expected.png: Added.
- platform/qt-5.0-wk2/editing/style/4916887-expected.png: Added.
- platform/qt-5.0-wk2/editing/style/5084241-expected.png: Added.
- 10:14 AM Changeset in webkit [147128] by
-
- 3 edits in trunk/LayoutTests
Fix layout test for blending in the background
https://bugs.webkit.org/show_bug.cgi?id=113402
Patch by Mirela Budaes <mbudaes@adobe.com> on 2013-03-28
Reviewed by Dirk Schulze.
Fixed the layout test effect-background-blend-mode.html typo
Also rebaselined the test
- css3/compositing/effect-background-blend-mode.html:
- platform/mac/css3/compositing/effect-background-blend-mode-expected.png:
- 10:03 AM Changeset in webkit [147127] by
-
- 3 edits3 adds in trunk
RenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements
https://bugs.webkit.org/show_bug.cgi?id=113419
Reviewed by Simon Fraser.
Source/WebCore:
Do not consider control elements as opaque. They are typically theme painted, and we cannot assume opaqueness on the behalf of theme. It can be improved by asking the theme if it paints opaque.
Test: compositing/contents-opaque/control-layer.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
- compositing/contents-opaque/control-layer-expected.txt: Added.
- compositing/contents-opaque/control-layer.html: Added.
- platform/chromium/compositing/contents-opaque/control-layer-expected.txt: Added.
- 9:46 AM Changeset in webkit [147126] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Adding failure expectation for a reftest added in r147111
that's failing due to subpixel layout being disabled on the GTK port.
- platform/gtk/TestExpectations:
- 9:38 AM Changeset in webkit [147125] by
-
- 4 edits1 add in trunk/Source/WebKit/gtk
[GTK] [gyp] Improve support for rerunning gyp automatically
https://bugs.webkit.org/show_bug.cgi?id=113360
Reviewed by Gustavo Noronha Silva.
Add support for automatically rerunning gyp when input file changes are detected
while running make.
- gyp/GNUmakefile: Added. A wrapper that invokes the generated makefile.
- gyp/autogen.sh: Add a symlink to the wrapper script.
- gyp/configure.ac: "Freeze" the TOPLEVEL_DIRECTORY command-line argument so that
run-gyp reads it properly when configure is run independently of autogen.sh.
- gyp/run-gyp: Prevent generation of auto-regeneration rules in gyp. They are buggy.
- 9:32 AM Changeset in webkit [147124] by
-
- 2 edits in trunk/Tools
[BlackBerry] Committer Email Updates
https://bugs.webkit.org/show_bug.cgi?id=113435
Patch by Ming Xie <mxie@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.
Add the @blackberry.com email address for all our BlackBerry
WebKit committers. This is the first step for our email address
migration.
- Scripts/webkitpy/common/config/committers.py:
- 9:31 AM Changeset in webkit [147123] by
-
- 2 edits in trunk/LayoutTests
Layout Test inspector/console/console-css-warnings.html is failing on debug.
https://bugs.webkit.org/show_bug.cgi?id=113483
Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-28
Reviewed by Alexander Pavlov.
This test is temporatily disabled in TestExpectations. platform/chromium/TestExpectations override this expectation for chromium/debug.
It removed for now.
- platform/chromium/TestExpectations:
- 9:05 AM Changeset in webkit [147122] by
-
- 3 edits in trunk/Tools
[jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=113508
Reviewed by Martin Robinson.
Prevent the GStreamer plugin scanner to load system-wide
plugins. Only the ones built in JHBuild should be loaded and used
at runtime.
- efl/jhbuildrc:
- gtk/jhbuildrc:
- 9:00 AM Changeset in webkit [147121] by
-
- 3 edits in trunk/Source/WebCore
[GTK][AC] Animating layer disappears while running with clutter backend
https://bugs.webkit.org/show_bug.cgi?id=110470
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-28
Reviewed by Gustavo Noronha Silva.
The reason of this issue is that clutter_actor_remove_child leads to stopping animations
of child actor. ClutterActor's animation could be defined only when it has a parent actor.
So we should avoid the case calling the api as much as we can. At least we don't
need to reset a actor's parent at all if the current parent is same with new one.
If we can't avoid invoking clutter_actor_remove_child for an animating actor, we may apply
a more complicated way to keep the animation. But I haven't faced such a case yet.
Covered by existing animation tests.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorSetSublayers):
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::recursiveCommitChanges):
(WebCore::GraphicsLayerClutter::updateSublayerList):
- 8:48 AM Changeset in webkit [147120] by
-
- 4 edits4 adds in trunk
Non-painting fixed elements should not cause repaints on scroll
https://bugs.webkit.org/show_bug.cgi?id=110430
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/repaint/scroll-fixed-layer-no-content.html
Test: compositing/repaint/scroll-fixed-layer-out-of-view.html
- page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath): Check for no-content and out-of-view flag set by RLC.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Moved the check for no-content above out-of-view because it's faster.
LayoutTests:
- compositing/repaint/scroll-fixed-layer-no-content.html: Added.
- compositing/repaint/scroll-fixed-layer-no-content-expected.txt: Added.
- compositing/repaint/scroll-fixed-layer-out-of-view.html: Added.
- compositing/repaint/scroll-fixed-layer-out-of-view-expected.txt: Added.
- 8:46 AM Changeset in webkit [147119] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening.
Fix bad rebaseline in r147115.
- fast/forms/validationMessage-expected.txt:
- platform/efl/fast/forms/validationMessage-expected.txt:
- 8:35 AM Changeset in webkit [147118] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, revert accidentally added line committed in r147117.
- inspector/front-end/ElementsTreeOutline.js:
- 8:15 AM Changeset in webkit [147117] by
-
- 8 edits in trunk
Web Inspector: [Elements] Syntax-highlight the "Edit as HTML" editor
https://bugs.webkit.org/show_bug.cgi?id=113306
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Use CodeMirror as the raw HTML editor for the "Edit as HTML" menu item
(and all multiline editors for WebInspector.startEditing()).
Drive-by fix for handling the editing when the editor has been invoked on the closing tag.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.commit):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
- inspector/front-end/UIUtils.js:
(WebInspector.EditingConfig.prototype.setMultiline):
(WebInspector.startEditing):
(WebInspector.CodeMirrorCSSLoadView): A bogus view to load-unload CodeMirror-related CSS on demand.
- inspector/front-end/elementsPanel.css:
(#elements-content .CodeMirror):
(#elements-content .CodeMirror pre):
(#elements-content .CodeMirror-lines):
- inspector/front-end/elementsPanel.css: CodeMirror styles for the "Edit as HTML" editor.
- inspector/front-end/externs.js: Declare CodeMirror type with some members, as it is third-party code.
- inspector/front-end/inspector.html: Fix script order (UIUtils.js requires View.js).
LayoutTests:
- inspector/elements/edit-dom-actions.html:
- 7:53 AM Changeset in webkit [147116] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark several tests as failing due to missing WKTR / DRT functionality.
- platform/efl/TestExpectations:
- 7:44 AM Changeset in webkit [147115] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/forms/validationMessage.html after r145024.
- fast/forms/validationMessage-expected.txt:
- 7:41 AM Changeset in webkit [147114] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening of test failures after r147086 and r147090.
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- 7:34 AM Changeset in webkit [147113] by
-
- 7 edits2 adds in trunk
Custom Elements: should support non-HTML namespaces.
https://bugs.webkit.org/show_bug.cgi?id=111693
Reviewed by Dimitri Glazkov.
Source/WebCore:
Some existing code assumes that the element extends HTMLElements.
This change allow it to extend from Element. Note that the
namespace URI of a custom element is determined by given element
prototype: An element will have XHTML namespace if its prototype
chain includes HTMLElements, SVGElement leads SVG namespace and
null otherwise, respectively.
Test: fast/dom/custom/document-register-namespace.html
- bindings/v8/CustomElementHelpers.cpp:
(WebCore::hasValidPrototypeChainFor): Factored out from isValidPrototypeParameter()
(WebCore::CustomElementHelpers::isValidPrototypeParameter): Extend to support non HTMLElement prototype
(WebCore::CustomElementHelpers::findLocalName): Support non-HTML element names.
- bindings/v8/CustomElementHelpers.h:
(CustomElementHelpers):
- dom/CustomElementConstructor.cpp:
(WebCore::CustomElementConstructor::createElementInternal):
- dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::registerElement): No longer hard-codes namespace and picks one based on the prototype value.
- dom/CustomElementRegistry.h:
(CustomElementRegistry):
LayoutTests:
- fast/dom/custom/document-register-namespace-expected.txt: Added.
- fast/dom/custom/document-register-namespace.html: Added.
- 7:28 AM Changeset in webkit [147112] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed EFL gardening.
Add platform specific expectation for http/tests/inspector/console-resource-errors.html.
We get the same result as mac port.
- platform/efl/http/tests/inspector/console-resource-errors-expected.txt: Added.
- 7:20 AM Changeset in webkit [147111] by
-
- 4 edits6 adds in trunk
[CSS Exclusions] Add support for the simple case of padding a polygonal shape-inside
https://bugs.webkit.org/show_bug.cgi?id=112592
Reviewed by Dirk Schulze.
Source/WebCore:
First pass at computing the padded or inset boundary of a polygon. This version does not handle
self-intersecting polygons, or values of shape-padding large enough to change the shape of the
original polygon. The implementation computes an offset edge for each polgon edge, where the offset
edge is parallel to the original edge and separated by shape-padding. The padded polygon's vertices
are the intersections of each pair of adjacent offset edges. When adjacent offset edges do not intersect,
because they share a reflex vertex in the original polygon, an approximation to a circular arc
connects the offset edges.
Tests: fast/exclusions/shape-inside/shape-inside-polygon-padding-001.html
fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html
fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html
- rendering/ExclusionPolygon.cpp:
(WebCore::isReflexVertex): Just moved this function earlier in the file.
(WebCore::inwardEdgeNormal): Unit vector that's perpindicular to the edge and that points inwards.
(WebCore::outwardEdgeNormal): Unit vector that's perpindicular to the edge and that points outwards.
(WebCore::appendArc): Append a linear approximation to a circular arc to a vector of vertices.
(WebCore::computeShapePaddingBounds): Return a polygon whose edges are all inset by shape-padding from m_polygon.
(WebCore::computeShapeMarginBounds): Just a stub, see bug 112917.
(WebCore::ExclusionPolygon::shapePaddingBounds): Lazily use computeShapePaddingBounds() to initialize m_paddingBounds.
(WebCore::ExclusionPolygon::shapeMarginBounds): Lazily use computeShapeMarginBounds() to initialize m_marginBounds.
(WebCore::ExclusionPolygon::getIncludedIntervals): Now based on the value of shapePaddingBounds().
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Now based on the value of shapePaddingBounds().
- rendering/ExclusionPolygon.h:
(WebCore::ExclusionPolygon::ExclusionPolygon):
LayoutTests:
Verify that the CSS shape-padding property works correctly for some simple polygonal shapes:
a rectangle, a rectangle rotated 45 degress, and rectangular shape with a single reflex vertex.
- fast/exclusions/shape-inside/shape-inside-polygon-padding-001-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-polygon-padding-001.html: Added.
- fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html: Added.
- fast/exclusions/shape-inside/shape-inside-polygon-padding-003-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html: Added.
- 7:04 AM Changeset in webkit [147110] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] Handle EXIF orientation for ImageDocuments
https://bugs.webkit.org/show_bug.cgi?id=113423
Internal Bug: PR 293648
Informally Reviewed by Jeff Rogers
Patch by Chris Hutten-Czapski <chutten@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.
Support image orientation in our image draw calls, and advertise
the capability to the calling code. This allows us to respect EXIF
orientation data.
- platform/graphics/BitmapImage.h:
- platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::BitmapImage::draw):
(WebCore):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):
- 6:46 AM Changeset in webkit [147109] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: name timeline overview controls consistently
https://bugs.webkit.org/show_bug.cgi?id=113503
Reviewed by Yury Semikhatsky.
Refactoring, covered by existing tests.
- rename HeapGraph to TimelineMemoryOverview;
- rename TimelineCategoryStrips to TimelineEventOvrview.
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.setMinimumRecordDuration):
(WebInspector.TimelineMemoryOverview):
(WebInspector.TimelineEventOverview):
(WebInspector.TimelineEventOverview.prototype._renderBar):
- 6:43 AM Changeset in webkit [147108] by
-
- 2 edits in trunk/Tools
[GTK] run-launcher --gtk -2 fails on a WK2-only build
https://bugs.webkit.org/show_bug.cgi?id=113386
Reviewed by Carlos Garcia Campos.
- Scripts/webkitdirs.pm:
(builtDylibPathForName): The WebKit2GTK .so name change from 1.0
version to 3.0. Reflect this change so the builtDylibPathForName
function doesn't fail to report the library as found.
- 6:39 AM Changeset in webkit [147107] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Correct glyph contour winding direction when fake-bolding
https://bugs.webkit.org/show_bug.cgi?id=113411
Patch by Eli Fidler <efidler@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.
- platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp:
(WebCore::FontPlatformData::applyState):
- 6:35 AM Changeset in webkit [147106] by
-
- 6 edits in trunk
Web Inspector: Make JavaScriptSourceFrame work correctly with breakpoints when uiSourceCode does not have a scriptFile.
https://bugs.webkit.org/show_bug.cgi?id=113500
Reviewed by Pavel Feldman.
JavaScriptSourceFrame now listens for uiSourceCode working copy related events and supports muting breakpoints without script file.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._workingCopyChanged):
(WebInspector.JavaScriptSourceFrame.prototype._workingCopyCommitted):
(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
(WebInspector.JavaScriptSourceFrame.prototype.dispose):
- 6:25 AM Changeset in webkit [147105] by
-
- 11 edits1 add in trunk/Source/WebCore
Web Inspector: factor out node search controller from inspector.js
https://bugs.webkit.org/show_bug.cgi?id=112689
Reviewed by Pavel Feldman.
This just extracts the existing logic of toggling node search
from inspector.js into a class of its own, InspectElementModeController.
Drive-by: add CtrlOrMeta+Shift+C to help screen.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- inspector/compile-front-end.py:
- inspector/front-end/InspectElementModeController.js: Added.
(WebInspector.InspectElementModeController):
(WebInspector.InspectElementModeController.createShortcut):
(WebInspector.InspectElementModeController.prototype.enabled):
(WebInspector.InspectElementModeController.prototype.disable):
(WebInspector.InspectElementModeController.prototype.toggleSearch.callback):
(WebInspector.InspectElementModeController.prototype.toggleSearch):
(WebInspector.InspectElementModeController.prototype.handleShortcut):
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.enterInspectElementMode):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._createGlobalStatusBarItems):
(WebInspector._registerShortcuts):
(WebInspector.documentKeyDown):
(WebInspector._updateFocusedNode):
- 6:09 AM Changeset in webkit [147104] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Settings] "previouslyViewedFiles" exceeds local storage quota.
https://bugs.webkit.org/show_bug.cgi?id=113375
Reviewed by Pavel Feldman.
Serialized "previouslyViewedFiles" may make local storage overflow.
Two fixed applied:
- limit number of history log items
- limit length of URIs that get serialized; this would affect only data-url URIs.
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.HistoryItem.prototype.serializeToObject):
Added length check.
(WebInspector.TabbedEditorContainer.History.prototype.set _serializeToObject):
Added output array length limit.
- 6:07 AM Changeset in webkit [147103] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Heap snapshots retained size falls out of the grid if column is too narrow
https://bugs.webkit.org/show_bug.cgi?id=113497
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-28
Reviewed by Pavel Feldman.
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
- inspector/front-end/heapProfiler.css:
(.heap-snapshot-view .data-grid div.heap-snapshot-multiple-values):
- 6:06 AM Changeset in webkit [147102] by
-
- 9 edits in trunk
Web Inspector: ResourceScriptFile should check if resource content really matches VM script when determining hasDiverged state.
https://bugs.webkit.org/show_bug.cgi?id=113488
Reviewed by Pavel Feldman.
Source/WebCore:
Enabled support for checking that file content matches VM script in ResourceScriptFile (For script resources only).
This check is never done before content is loaded in corresponding editor to avoid regressing performance.
File - script content matching is done bearing in mind sourceURLs.
Live edit keeps sourceURL in script content now even if it is not present in file's content.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
(WebInspector.JavaScriptSourceFrame.prototype.onTextEditorContentLoaded):
- inspector/front-end/LiveEditSupport.js:
(WebInspector.LiveEditScriptFile.prototype.checkMapping):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ScriptFile.prototype.checkMapping):
(WebInspector.ResourceScriptFile):
(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._isDiverged):
(WebInspector.ResourceScriptFile.prototype._sourceMatchesScriptSource):
(WebInspector.ResourceScriptFile.prototype._sourceEndsWithSourceURL):
(WebInspector.ResourceScriptFile.prototype.checkMapping.callback):
(WebInspector.ResourceScriptFile.prototype.checkMapping):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.SnippetScriptFile.prototype.checkMapping):
LayoutTests:
- http/tests/inspector/debugger-test.js:
- inspector/debugger/file-system-project-mapping-expected.txt:
- inspector/debugger/file-system-project-mapping.html:
- 6:04 AM Changeset in webkit [147101] by
-
- 196 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Updated png expected results after r146206.
- platform/qt/editing/deleting/5126166-expected.png:
- platform/qt/editing/deleting/5206311-1-expected.png:
- platform/qt/editing/deleting/5272440-expected.png:
- platform/qt/editing/deleting/5369009-expected.png:
- platform/qt/editing/deleting/5433862-2-expected.png:
- platform/qt/editing/deleting/delete-3608445-fix-expected.png:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
- platform/qt/editing/deleting/delete-block-contents-003-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-005-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-006-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-007-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-008-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-018-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-020-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-021-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-022-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-023-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-024-expected.png:
- platform/qt/editing/deleting/delete-br-002-expected.png:
- platform/qt/editing/deleting/delete-br-003-expected.png:
- platform/qt/editing/deleting/delete-br-004-expected.png:
- platform/qt/editing/deleting/delete-br-005-expected.png:
- platform/qt/editing/deleting/delete-br-006-expected.png:
- platform/qt/editing/deleting/delete-hr-expected.png:
- platform/qt/editing/deleting/delete-image-002-expected.png:
- platform/qt/editing/deleting/delete-line-003-expected.png:
- platform/qt/editing/deleting/delete-line-004-expected.png:
- platform/qt/editing/deleting/delete-line-end-ws-001-expected.png:
- platform/qt/editing/deleting/delete-line-end-ws-002-expected.png:
- platform/qt/editing/deleting/delete-listitem-001-expected.png:
- platform/qt/editing/deleting/forward-delete-expected.png:
- platform/qt/editing/deleting/merge-different-styles-expected.png:
- platform/qt/editing/deleting/pruning-after-merge-2-expected.png:
- platform/qt/editing/deleting/smart-delete-003-expected.png:
- platform/qt/editing/deleting/smart-delete-004-expected.png:
- platform/qt/editing/deleting/type-delete-after-quote-expected.png:
- platform/qt/editing/execCommand/4580583-1-expected.png:
- platform/qt/editing/execCommand/4924441-expected.png:
- platform/qt/editing/execCommand/5482023-expected.png:
- platform/qt/editing/execCommand/findString-2-expected.png:
- platform/qt/editing/execCommand/indent-empty-root-expected.png:
- platform/qt/editing/execCommand/insertHorizontalRule-expected.png:
- platform/qt/editing/execCommand/insertImage-expected.png:
- platform/qt/editing/execCommand/nsresponder-indent-expected.png:
- platform/qt/editing/execCommand/nsresponder-outdent-expected.png:
- platform/qt/editing/execCommand/paste-1-expected.png:
- platform/qt/editing/execCommand/paste-2-expected.png:
- platform/qt/editing/execCommand/remove-list-item-1-expected.png:
- platform/qt/editing/input/reveal-caret-of-multiline-input-expected.png:
- platform/qt/editing/inserting/4875189-1-expected.png:
- platform/qt/editing/inserting/4875189-2-expected.png:
- platform/qt/editing/inserting/4959067-expected.png:
- platform/qt/editing/inserting/5418891-expected.png:
- platform/qt/editing/inserting/before-after-input-element-expected.png:
- platform/qt/editing/inserting/editable-html-element-expected.png:
- platform/qt/editing/inserting/edited-whitespace-1-expected.png:
- platform/qt/editing/inserting/insert-3654864-fix-expected.png:
- platform/qt/editing/inserting/insert-3778059-fix-expected.png:
- platform/qt/editing/inserting/insert-3800346-fix-expected.png:
- platform/qt/editing/inserting/insert-3851164-fix-expected.png:
- platform/qt/editing/inserting/insert-div-011-expected.png:
- platform/qt/editing/inserting/insert-div-012-expected.png:
- platform/qt/editing/inserting/insert-div-013-expected.png:
- platform/qt/editing/inserting/insert-div-014-expected.png:
- platform/qt/editing/inserting/insert-div-015-expected.png:
- platform/qt/editing/inserting/insert-div-016-expected.png:
- platform/qt/editing/inserting/insert-div-017-expected.png:
- platform/qt/editing/inserting/insert-div-018-expected.png:
- platform/qt/editing/inserting/insert-div-019-expected.png:
- platform/qt/editing/inserting/insert-div-020-expected.png:
- platform/qt/editing/inserting/insert-div-025-expected.png:
- platform/qt/editing/inserting/insert-div-027-expected.png:
- platform/qt/editing/inserting/insert-paragraph-02-expected.png:
- platform/qt/editing/inserting/paragraph-separator-03-expected.png:
- platform/qt/editing/inserting/redo-expected.png:
- platform/qt/editing/pasteboard/4076267-expected.png:
- platform/qt/editing/pasteboard/4242293-expected.png:
- platform/qt/editing/pasteboard/4641033-expected.png:
- platform/qt/editing/pasteboard/4944770-1-expected.png:
- platform/qt/editing/pasteboard/4944770-2-expected.png:
- platform/qt/editing/pasteboard/4989774-expected.png:
- platform/qt/editing/pasteboard/5028447-expected.png:
- platform/qt/editing/pasteboard/5032095-expected.png:
- platform/qt/editing/pasteboard/5134759-expected.png:
- platform/qt/editing/pasteboard/innerText-inline-table-expected.png:
- platform/qt/editing/pasteboard/input-field-1-expected.png:
- platform/qt/editing/pasteboard/merge-after-delete-expected.png:
- platform/qt/editing/pasteboard/merge-end-borders-expected.png:
- platform/qt/editing/pasteboard/merge-start-list-expected.png:
- platform/qt/editing/pasteboard/paste-text-004-expected.png:
- platform/qt/editing/pasteboard/paste-text-008-expected.png:
- platform/qt/editing/pasteboard/paste-text-009-expected.png:
- platform/qt/editing/pasteboard/paste-text-013-expected.png:
- platform/qt/editing/pasteboard/paste-text-014-expected.png:
- platform/qt/editing/pasteboard/paste-text-016-expected.png:
- platform/qt/editing/pasteboard/styled-element-markup-expected.png:
- platform/qt/editing/selection/13804-expected.png:
- platform/qt/editing/selection/4402375-expected.png:
- platform/qt/editing/selection/4776665-expected.png:
- platform/qt/editing/selection/4866671-expected.png:
- platform/qt/editing/selection/4889598-expected.png:
- platform/qt/editing/selection/4895428-2-expected.png:
- platform/qt/editing/selection/4895428-3-expected.png:
- platform/qt/editing/selection/4947387-expected.png:
- platform/qt/editing/selection/4960116-expected.png:
- platform/qt/editing/selection/4960137-expected.png:
- platform/qt/editing/selection/4975120-expected.png:
- platform/qt/editing/selection/4983858-expected.png:
- platform/qt/editing/selection/5076323-1-expected.png:
- platform/qt/editing/selection/5081257-1-expected.png:
- platform/qt/editing/selection/5081257-2-expected.png:
- platform/qt/editing/selection/5099303-expected.png:
- platform/qt/editing/selection/5195166-2-expected.png:
- platform/qt/editing/selection/5240265-expected.png:
- platform/qt/editing/selection/7152-1-expected.png:
- platform/qt/editing/selection/7152-2-expected.png:
- platform/qt/editing/selection/addRange-expected.png:
- platform/qt/editing/selection/caret-ltr-2-expected.png:
- platform/qt/editing/selection/caret-ltr-2-left-expected.png:
- platform/qt/editing/selection/caret-ltr-expected.png:
- platform/qt/editing/selection/caret-ltr-right-expected.png:
- platform/qt/editing/selection/caret-rtl-2-left-expected.png:
- platform/qt/editing/selection/caret-rtl-right-expected.png:
- platform/qt/editing/selection/clear-selection-expected.png:
- platform/qt/editing/selection/contenteditable-click-inside-expected.png:
- platform/qt/editing/selection/drag-select-1-expected.png:
- platform/qt/editing/selection/editable-html-element-expected.png:
- platform/qt/editing/selection/expanding-selections-expected.png:
- platform/qt/editing/selection/expanding-selections2-expected.png:
- platform/qt/editing/selection/extend-by-character-003-expected.png:
- platform/qt/editing/selection/extend-by-character-005-expected.png:
- platform/qt/editing/selection/extend-inside-transforms-backward-expected.png:
- platform/qt/editing/selection/extend-inside-transforms-forward-expected.png:
- platform/qt/editing/selection/focus_editable_html-expected.png:
- platform/qt/editing/selection/inline-table-expected.png:
- platform/qt/editing/selection/mixed-editability-1-expected.png:
- platform/qt/editing/selection/mixed-editability-3-expected.png:
- platform/qt/editing/selection/mixed-editability-4-expected.png:
- platform/qt/editing/selection/mixed-editability-5-expected.png:
- platform/qt/editing/selection/mixed-editability-8-expected.png:
- platform/qt/editing/selection/mixed-editability-9-expected.png:
- platform/qt/editing/selection/move-3875618-fix-expected.png:
- platform/qt/editing/selection/move-3875641-fix-expected.png:
- platform/qt/editing/selection/move-between-blocks-yes-001-expected.png:
- platform/qt/editing/selection/move-by-character-003-expected.png:
- platform/qt/editing/selection/move-by-character-005-expected.png:
- platform/qt/editing/selection/node-removal-1-expected.png:
- platform/qt/editing/selection/node-removal-2-expected.png:
- platform/qt/editing/selection/paragraph-granularity-expected.png:
- platform/qt/editing/selection/range-between-block-and-inline-expected.png:
- platform/qt/editing/selection/replace-selection-1-expected.png:
- platform/qt/editing/selection/select-across-readonly-input-1-expected.png:
- platform/qt/editing/selection/select-across-readonly-input-2-expected.png:
- platform/qt/editing/selection/select-across-readonly-input-3-expected.png:
- platform/qt/editing/selection/select-across-readonly-input-4-expected.png:
- platform/qt/editing/selection/select-across-readonly-input-5-expected.png:
- platform/qt/editing/selection/select-all-003-expected.png:
- platform/qt/editing/selection/select-all-005-expected.png:
- platform/qt/editing/selection/select-all-006-expected.png:
- platform/qt/editing/selection/select-all-iframe-expected.png:
- platform/qt/editing/selection/select-text-overflow-ellipsis-expected.png:
- platform/qt/editing/selection/selectNode-expected.png:
- platform/qt/editing/selection/selectNodeContents-expected.png:
- platform/qt/editing/selection/selection-actions-expected.png:
- platform/qt/editing/selection/selection-button-text-expected.png:
- platform/qt/editing/selection/table-caret-3-expected.png:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
- platform/qt/editing/selection/word-granularity-expected.png:
- platform/qt/editing/selection/wrapped-line-caret-1-expected.png:
- platform/qt/editing/selection/wrapped-line-caret-2-expected.png:
- platform/qt/editing/style/4916887-expected.png:
- platform/qt/editing/style/5084241-expected.png:
- platform/qt/editing/style/apple-style-editable-mix-expected.png:
- platform/qt/editing/style/block-style-001-expected.png:
- platform/qt/editing/style/block-style-002-expected.png:
- platform/qt/editing/style/block-style-003-expected.png:
- platform/qt/editing/style/create-block-for-style-001-expected.png:
- platform/qt/editing/style/create-block-for-style-002-expected.png:
- platform/qt/editing/style/create-block-for-style-003-expected.png:
- platform/qt/editing/style/create-block-for-style-004-expected.png:
- platform/qt/editing/style/create-block-for-style-005-expected.png:
- platform/qt/editing/style/create-block-for-style-006-expected.png:
- platform/qt/editing/style/create-block-for-style-007-expected.png:
- platform/qt/editing/style/create-block-for-style-008-expected.png:
- platform/qt/editing/style/create-block-for-style-009-expected.png:
- platform/qt/editing/style/create-block-for-style-010-expected.png:
- platform/qt/editing/style/create-block-for-style-011-expected.png:
- platform/qt/editing/style/create-block-for-style-012-expected.png:
- platform/qt/editing/style/create-block-for-style-013-expected.png:
- platform/qt/editing/style/designmode-expected.png:
- platform/qt/editing/style/relative-font-size-change-001-expected.png:
- platform/qt/editing/style/relative-font-size-change-002-expected.png:
- platform/qt/editing/style/relative-font-size-change-003-expected.png:
- platform/qt/editing/style/relative-font-size-change-004-expected.png:
- 5:45 AM Changeset in webkit [147100] by
-
- 1 edit2 adds in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening. Rebaselining after r147086.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.
- 5:34 AM Changeset in webkit [147099] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Simplify ResourceScriptFile so that it stores hasDiverged state in it.
https://bugs.webkit.org/show_bug.cgi?id=113489
Reviewed by Pavel Feldman.
ResourceScriptFile._hasDiverged is the one flag that shows whether we have diverged from VM.
It's values is based both on dirty flag on uiSourceCode and information about live edit failures stored in _lastLiveEditFailed field.
Removed willMerge/Diverge events from ScriptFile.
JavaScriptSourceFrame now uses isMergingToVM/DivergingFromVM methods on ScriptFile.
to determine whether breakpointAdded/Removed events should be ignored.
Introduced muted state on JavaScriptSourceFrame to determine whether it should ignore user attempts to set/remove breakpoints.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._didMergeToVM):
(WebInspector.JavaScriptSourceFrame.prototype._didDivergeFromVM):
(WebInspector.JavaScriptSourceFrame.prototype._muteBreakpointsWhileEditing):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._shouldIgnoreExternalBreakpointEvents):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
(WebInspector.JavaScriptSourceFrame.prototype.onTextEditorContentLoaded):
- inspector/front-end/LiveEditSupport.js:
(WebInspector.LiveEditScriptFile.prototype.isMergingToVM):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ScriptFile.prototype.isMergingToVM):
(WebInspector.ResourceScriptFile):
(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._isDiverged):
(WebInspector.ResourceScriptFile.prototype._workingCopyChanged):
(WebInspector.ResourceScriptFile.prototype._update):
(WebInspector.ResourceScriptFile.prototype._divergeFromVM):
(WebInspector.ResourceScriptFile.prototype._mergeToVM):
(WebInspector.ResourceScriptFile.prototype.hasDivergedFromVM):
(WebInspector.ResourceScriptFile.prototype.isMergingToVM):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.SnippetScriptFile.prototype.isMergingToVM):
- 5:31 AM Changeset in webkit [147098] by
-
- 4 edits19 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Updated png expected results after r146206..
- platform/qt-5.0-wk2/fast/backgrounds/mask-box-image-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize08-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/block-mask-overlay-image-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/border-image-scaled-gradient-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/border-image-slice-constrained-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/border-image-slices-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/box-shadow-radius-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/box-shadow-transformed-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/inset-box-shadows-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/inset-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/scaled-box-shadow-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-as-image-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-bg-zoom-expected.png: Added.
- platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.png:
- platform/qt-5.0-wk2/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/listbox-clip-expected.png:
- platform/qt-5.0-wk2/fast/forms/select-background-none-expected.png:
- 5:16 AM Changeset in webkit [147097] by
-
- 7 edits in trunk
Web Inspector: DOMContentLoaded event divider is not shown on Timeline's main view
https://bugs.webkit.org/show_bug.cgi?id=113196
Reviewed by Pavel Feldman.
Source/WebCore:
- keep event divider records in TimelinePresentationModel, not in TimelinePanel;
- process event divider records on every level, not just on top.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.checkVisible):
(WebInspector.TimelinePanel.prototype._resetPanel):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype._innerAddRecord):
(WebInspector.TimelinePresentationModel.prototype.eventDividerRecords):
LayoutTests:
- use TimelinePresentationModel to fetch list of event divider records;
- http/tests/inspector/timeline-test.js:
(initialize_Timeline.InspectorTest.printTimestampRecords):
- inspector/timeline/timeline-load-event-expected.txt:
- inspector/timeline/timeline-load-event.html:
- 5:14 AM Changeset in webkit [147096] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed inspector front-end closure compilation fix.
- inspector/front-end/CookiesTable.js:
- 5:11 AM Changeset in webkit [147095] by
-
- 11 edits in trunk
Web Inspector: [DTE] Paint overlay highlight over line background color
https://bugs.webkit.org/show_bug.cgi?id=113346
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-28
Reviewed by Pavel Feldman.
Source/WebCore:
No new tests: no change in behaviour.
- Append spans instead of text nodes to lineRows.
- Set positioning of all spans inside of webkit-line-content as
relative
- Set z-index property so that overlay highlight is above line
background but under text.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._measureHighlightDescriptor):
(WebInspector.TextEditorMainPanel.prototype._measureSpans):
(WebInspector.TextEditorMainPanel.prototype._renderRanges):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
- inspector/front-end/textEditor.css:
(.webkit-line-content > .text-editor-overlay-highlight):
(.webkit-line-content > *):
LayoutTests:
Updated test expectations to correspond to new DefaultTextEditor's DOM
layout.
- inspector/editor/text-editor-brace-highlighter-expected.txt:
- inspector/editor/text-editor-highlight-api-expected.txt:
- inspector/editor/text-editor-highlight-token-expected.txt:
- inspector/editor/text-editor-long-line-expected.txt:
- inspector/editor/text-editor-remove-chunks-from-dom-expected.txt:
- inspector/editor/text-editor-show-whitespace-expected.txt:
- inspector/editor/text-editor-type-over-decoration-expected.txt:
- 5:02 AM Changeset in webkit [147094] by
-
- 3 edits2 adds in trunk
Web Inspector: [REGRESSION] [Styles] Pasting a property in the "name" field is broken
https://bugs.webkit.org/show_bug.cgi?id=113491
Reviewed by Pavel Feldman.
Source/WebCore:
Update the CSSProperty name and value upon pasting properties into the Styles pane.
Drive-by: start editing the next/new property name after pasting.
Test: inspector/styles/paste-property.html
- inspector/front-end/StylesSidebarPane.js:
(.selectElement):
(.moveDirection.alreadyNew):
LayoutTests:
- inspector/styles/paste-property-expected.txt: Added.
- inspector/styles/paste-property.html: Added.
- 3:54 AM Changeset in webkit [147093] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adjusting the expectation for media/track/track-in-band-legacy-api.html.
- 3:40 AM Changeset in webkit [147092] by
-
- 410 edits3 copies3 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Updated expected png results after r146206.
- platform/qt/fast/backgrounds/001-expected.png:
- platform/qt/fast/backgrounds/background-clip-text-expected.png:
- platform/qt/fast/backgrounds/background-origin-root-element-expected.png:
- platform/qt/fast/backgrounds/gradient-background-leakage-expected.png:
- platform/qt/fast/backgrounds/opacity-on-document-element-expected.png:
- platform/qt/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png:
- platform/qt/fast/block/basic/001-expected.png:
- platform/qt/fast/block/basic/004-expected.png:
- platform/qt/fast/block/basic/005-expected.png:
- platform/qt/fast/block/basic/007-expected.png:
- platform/qt/fast/block/basic/008-expected.png:
- platform/qt/fast/block/basic/010-expected.png:
- platform/qt/fast/block/basic/011-expected.png:
- platform/qt/fast/block/basic/015-expected.png:
- platform/qt/fast/block/basic/016-expected.png:
- platform/qt/fast/block/basic/018-expected.png:
- platform/qt/fast/block/basic/019-expected.png:
- platform/qt/fast/block/basic/min-pref-width-nowrap-floats-expected.png:
- platform/qt/fast/block/basic/minheight-expected.png:
- platform/qt/fast/block/basic/quirk-height-expected.png:
- platform/qt/fast/block/basic/quirk-percent-height-grandchild-expected.png:
- platform/qt/fast/block/basic/white-space-pre-wraps-expected.png:
- platform/qt/fast/block/float/001-expected.png:
- platform/qt/fast/block/float/003-expected.png:
- platform/qt/fast/block/float/004-expected.png:
- platform/qt/fast/block/float/005-expected.png:
- platform/qt/fast/block/float/006-expected.png:
- platform/qt/fast/block/float/010-expected.png:
- platform/qt/fast/block/float/015-expected.png:
- platform/qt/fast/block/float/016-expected.png:
- platform/qt/fast/block/float/017-expected.png:
- platform/qt/fast/block/float/021-expected.png:
- platform/qt/fast/block/float/023-expected.png:
- platform/qt/fast/block/float/024-expected.png:
- platform/qt/fast/block/float/025-expected.png:
- platform/qt/fast/block/float/027-expected.png:
- platform/qt/fast/block/float/029-expected.png:
- platform/qt/fast/block/float/030-expected.png:
- platform/qt/fast/block/float/031-expected.png:
- platform/qt/fast/block/float/avoidance-percent-width-strict-expected.png:
- platform/qt/fast/block/float/avoiding-float-centered-expected.png:
- platform/qt/fast/block/float/editable-text-overlapping-float-expected.png:
- platform/qt/fast/block/float/fit_line_below_floats-expected.png:
- platform/qt/fast/block/float/float-avoidance-expected.png:
- platform/qt/fast/block/float/float-on-zero-height-line-expected.png:
- platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png:
- platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png:
- platform/qt/fast/block/float/marquee-shrink-to-avoid-floats-expected.png:
- platform/qt/fast/block/float/multiple-float-positioning-expected.png:
- platform/qt/fast/block/float/nestedAnonymousBlocks-expected.png:
- platform/qt/fast/block/float/nestedAnonymousBlocks2-expected.png:
- platform/qt/fast/block/float/overhanging-after-height-decrease-offsets-expected.png:
- platform/qt/fast/block/float/overhanging-float-add-in-static-position-block-expected.png:
- platform/qt/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png:
- platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png:
- platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png:
- platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
- platform/qt/fast/block/float/shrink-to-fit-width-expected.png:
- platform/qt/fast/block/float/width-update-after-clear-expected.png:
- platform/qt/fast/block/lineboxcontain/inline-box-expected.png:
- platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.png:
- platform/qt/fast/block/lineboxcontain/inline-replaced-expected.png:
- platform/qt/fast/block/lineboxcontain/replaced-expected.png:
- platform/qt/fast/block/margin-collapse/001-expected.png:
- platform/qt/fast/block/margin-collapse/005-expected.png:
- platform/qt/fast/block/margin-collapse/006-expected.png:
- platform/qt/fast/block/margin-collapse/010-expected.png:
- platform/qt/fast/block/margin-collapse/011-expected.png:
- platform/qt/fast/block/margin-collapse/012-expected.png:
- platform/qt/fast/block/margin-collapse/015-expected.png:
- platform/qt/fast/block/margin-collapse/016-expected.png:
- platform/qt/fast/block/margin-collapse/017-expected.png:
- platform/qt/fast/block/margin-collapse/018-expected.png:
- platform/qt/fast/block/margin-collapse/019-expected.png:
- platform/qt/fast/block/margin-collapse/020-expected.png:
- platform/qt/fast/block/margin-collapse/025-expected.png:
- platform/qt/fast/block/margin-collapse/030-expected.png:
- platform/qt/fast/block/margin-collapse/031-expected.png:
- platform/qt/fast/block/margin-collapse/037-expected.png:
- platform/qt/fast/block/margin-collapse/038-expected.png:
- platform/qt/fast/block/margin-collapse/043-expected.png:
- platform/qt/fast/block/margin-collapse/056-expected.png:
- platform/qt/fast/block/margin-collapse/059-expected.png:
- platform/qt/fast/block/margin-collapse/100-expected.png:
- platform/qt/fast/block/margin-collapse/103-expected.png:
- platform/qt/fast/block/margin-collapse/104-expected.png:
- platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.png:
- platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.png:
- platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.png:
- platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.png:
- platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.png:
- platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.png:
- platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.png:
- platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.png:
- platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.png:
- platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.png:
- platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.png:
- platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.png:
- platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.png:
- platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.png:
- platform/qt/fast/block/positioning/047-expected.png:
- platform/qt/fast/block/positioning/049-expected.png:
- platform/qt/fast/block/positioning/051-expected.png:
- platform/qt/fast/block/positioning/052-expected.png:
- platform/qt/fast/block/positioning/054-expected.png:
- platform/qt/fast/block/positioning/055-expected.png:
- platform/qt/fast/block/positioning/auto/vertical-lr/005-expected.png:
- platform/qt/fast/block/positioning/auto/vertical-rl/005-expected.png:
- platform/qt/fast/block/positioning/height-change-expected.png:
- platform/qt/fast/block/positioning/pref-width-change-expected.png:
- platform/qt/fast/block/positioning/relative-overflow-block-expected.png:
- platform/qt/fast/block/positioning/relative-overflow-replaced-expected.png:
- platform/qt/fast/block/positioning/relative-overflow-replaced-float-expected.png:
- platform/qt/fast/block/positioning/relayout-on-position-change-expected.png:
- platform/qt/fast/block/positioning/window-height-change-expected.png:
- platform/qt/fast/body-propagation/background-image/009-expected.png:
- platform/qt/fast/body-propagation/background-image/009-xhtml-expected.png:
- platform/qt/fast/body-propagation/overflow/001-expected.png:
- platform/qt/fast/body-propagation/overflow/001-xhtml-expected.png:
- platform/qt/fast/body-propagation/overflow/005-declarative-expected.png:
- platform/qt/fast/body-propagation/overflow/005-expected.png:
- platform/qt/fast/body-propagation/overflow/005-xhtml-expected.png:
- platform/qt/fast/borders/bidi-002-expected.png:
- platform/qt/fast/borders/bidi-009a-expected.png:
- platform/qt/fast/borders/bidi-012-expected.png:
- platform/qt/fast/borders/border-color-inherit-expected.png:
- platform/qt/fast/borders/border-radius-huge-assert-expected.png:
- platform/qt/fast/borders/border-radius-inline-flow-expected.png:
- platform/qt/fast/borders/border-radius-split-inline-expected.png:
- platform/qt/fast/borders/borderRadiusArcs01-expected.png:
- platform/qt/fast/borders/borderRadiusDotted05-expected.png:
- platform/qt/fast/borders/borderRadiusDouble01-expected.png:
- platform/qt/fast/borders/borderRadiusDouble02-expected.png:
- platform/qt/fast/borders/borderRadiusDouble03-expected.png:
- platform/qt/fast/borders/borderRadiusGroove01-expected.png:
- platform/qt/fast/borders/borderRadiusGroove02-expected.png:
- platform/qt/fast/borders/borderRadiusInset01-expected.png:
- platform/qt/fast/borders/borderRadiusInvalidColor-expected.png:
- platform/qt/fast/borders/borderRadiusOutset01-expected.png:
- platform/qt/fast/borders/borderRadiusRidge01-expected.png:
- platform/qt/fast/borders/borderRadiusSolid01-expected.png:
- platform/qt/fast/borders/borderRadiusSolid02-expected.png:
- platform/qt/fast/borders/borderRadiusSolid03-expected.png:
- platform/qt/fast/borders/borderRadiusSolid04-expected.png:
- platform/qt/fast/borders/different-color-borders-expected.png:
- platform/qt/fast/borders/fieldsetBorderRadius-expected.png:
- platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.png:
- platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
- platform/qt/fast/borders/rtl-border-05-expected.png:
- platform/qt/fast/borders/table-borders-expected.png:
- platform/qt/fast/borders/webkit-border-radius-expected.png:
- platform/qt/fast/box-shadow/basic-shadows-expected.png:
- platform/qt/fast/box-shadow/box-shadow-radius-expected.png:
- platform/qt/fast/box-shadow/inset-box-shadow-radius-expected.png:
- platform/qt/fast/box-shadow/inset-box-shadows-expected.png:
- platform/qt/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
- platform/qt/fast/box-shadow/spread-multiple-inset-expected.png: Added.
- platform/qt/fast/box-shadow/spread-multiple-normal-expected.png: Added.
- platform/qt/fast/box-sizing/box-sizing-expected.png:
- platform/qt/fast/box-sizing/panels-one-expected.png:
- platform/qt/fast/box-sizing/panels-two-expected.png:
- platform/qt/fast/canvas/canvas-zoom-expected.png:
- platform/qt/fast/clip/001-expected.png:
- platform/qt/fast/clip/002-expected.png:
- platform/qt/fast/clip/003-expected.png:
- platform/qt/fast/clip/004-expected.png:
- platform/qt/fast/clip/005-expected.png:
- platform/qt/fast/clip/006-expected.png:
- platform/qt/fast/clip/007-expected.png:
- platform/qt/fast/clip/008-expected.png:
- platform/qt/fast/clip/009-expected.png:
- platform/qt/fast/clip/010-expected.png:
- platform/qt/fast/clip/011-expected.png:
- platform/qt/fast/clip/012-expected.png:
- platform/qt/fast/clip/013-expected.png:
- platform/qt/fast/clip/014-expected.png:
- platform/qt/fast/clip/015-expected.png:
- platform/qt/fast/clip/nestedTransparencyClip-expected.png:
- platform/qt/fast/clip/outline-overflowClip-expected.png:
- platform/qt/fast/clip/overflow-border-radius-clip-expected.png:
- platform/qt/fast/clip/overflow-border-radius-combinations-expected.png:
- platform/qt/fast/clip/overflow-border-radius-composited-expected.png:
- platform/qt/fast/clip/overflow-border-radius-fixed-position-expected.png:
- platform/qt/fast/clip/overflow-border-radius-transformed-expected.png:
- platform/qt/fast/css-generated-content/001-expected.png:
- platform/qt/fast/css-generated-content/002-expected.png:
- platform/qt/fast/css-generated-content/008-expected.png:
- platform/qt/fast/css-generated-content/009-expected.png:
- platform/qt/fast/css-generated-content/013-expected.png:
- platform/qt/fast/css-generated-content/016-expected.png:
- platform/qt/fast/css-generated-content/after-duplicated-after-split-expected.png:
- platform/qt/fast/css-generated-content/after-order-expected.png:
- platform/qt/fast/css-generated-content/beforeAfter-interdocument-expected.png:
- platform/qt/fast/css-generated-content/inline-display-types-expected.png:
- platform/qt/fast/css-generated-content/table-before-after-child-add-expected.png:
- platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.png:
- platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.png:
- platform/qt/fast/css-generated-content/table-row-before-after-expected.png:
- platform/qt/fast/css-generated-content/table-row-group-to-inline-expected.png:
- platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.png:
- platform/qt/fast/css/002-expected.png:
- platform/qt/fast/css/003-expected.png:
- platform/qt/fast/css/004-expected.png:
- platform/qt/fast/css/005-expected.png:
- platform/qt/fast/css/008-expected.png:
- platform/qt/fast/css/ZeroOpacityLayers-expected.png:
- platform/qt/fast/css/ZeroOpacityLayers2-expected.png:
- platform/qt/fast/css/absolute-poition-in-rtl-parent-expected.png:
- platform/qt/fast/css/attribute-selector-dynamic-expected.png:
- platform/qt/fast/css/attribute-selector-empty-value-expected.png:
- platform/qt/fast/css/background-shorthand-invalid-url-expected.png:
- platform/qt/fast/css/beforeSelectorOnCodeElement-expected.png:
- platform/qt/fast/css/begin-end-contain-selector-empty-value-expected.png:
- platform/qt/fast/css/border-height-expected.png:
- platform/qt/fast/css/border-radius-outline-offset-expected.png:
- platform/qt/fast/css/border-solid-single-edge-antialias-expected.png: Added.
- platform/qt/fast/css/child-style-can-override-visited-style-expected.png:
- platform/qt/fast/css/clip-text-in-scaled-div-expected.png:
- platform/qt/fast/css/color-correction-backgrounds-and-text-expected.png:
- platform/qt/fast/css/continuationCrash-expected.png:
- platform/qt/fast/css/create_element_align-expected.png:
- platform/qt/fast/css/css-imports-expected.png:
- platform/qt/fast/css/css3-modsel-22-expected.png:
- platform/qt/fast/css/css3-nth-child-expected.png:
- platform/qt/fast/css/error-in-last-decl-expected.png:
- platform/qt/fast/css/first-letter-first-line-hover-expected.png:
- platform/qt/fast/css/first-letter-float-after-float-expected.png:
- platform/qt/fast/css/first-letter-float-expected.png:
- platform/qt/fast/css/first-letter-punctuation-expected.png:
- platform/qt/fast/css/first-letter-recalculation-expected.png:
- platform/qt/fast/css/first-letter-visibility-expected.png:
- platform/qt/fast/css/focus-ring-detached-expected.png:
- platform/qt/fast/css/focus-ring-multiline-writingmode-vertical-expected.png:
- platform/qt/fast/css/focus-ring-outline-color-expected.png:
- platform/qt/fast/css/focus-ring-outline-offset-expected.png:
- platform/qt/fast/css/focus-ring-outline-width-expected.png:
- platform/qt/fast/css/font-face-implicit-local-font-expected.png:
- platform/qt/fast/css/font-face-multiple-faces-expected.png:
- platform/qt/fast/css/font-face-multiple-remote-sources-expected.png:
- platform/qt/fast/css/font-smoothing-expected.png:
- platform/qt/fast/css/font_property_normal-expected.png:
- platform/qt/fast/css/hsla-color-expected.png:
- platform/qt/fast/css/import-rule-regression-11590-expected.png:
- platform/qt/fast/css/inline-properties-important-expected.png:
- platform/qt/fast/css/invalid-percentage-property-expected.png:
- platform/qt/fast/css/invalidation-errors-2-expected.png:
- platform/qt/fast/css/invalidation-errors-3-expected.png:
- platform/qt/fast/css/invalidation-errors-expected.png:
- platform/qt/fast/css/last-child-style-sharing-expected.png:
- platform/qt/fast/css/layerZOrderCrash-expected.png:
- platform/qt/fast/css/line-height-overflow-expected.png:
- platform/qt/fast/css/link-outside-head-expected.png:
- platform/qt/fast/css/list-outline-expected.png:
- platform/qt/fast/css/margin-bottom-form-element-quirk-expected.png:
- platform/qt/fast/css/margin-bottom-form-element-strict-expected.png:
- platform/qt/fast/css/namespaces/004-expected.png:
- platform/qt/fast/css/namespaces/005-expected.png:
- platform/qt/fast/css/namespaces/006-expected.png:
- platform/qt/fast/css/namespaces/namespaces-comments-expected.png:
- platform/qt/fast/css/namespaces/namespaces-empty-expected.png:
- platform/qt/fast/css/namespaces/namespaces-invalid-at-expected.png:
- platform/qt/fast/css/negative-leading-expected.png:
- platform/qt/fast/css/non-empty-span-expected.png:
- platform/qt/fast/css/pendingStylesheetFontSize-expected.png:
- platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.png:
- platform/qt/fast/css/position-negative-top-margin-expected.png:
- platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png:
- platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png:
- platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png:
- platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png:
- platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png:
- platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png:
- platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png:
- platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png:
- platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-expected.png:
- platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png:
- platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png:
- platform/qt/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png:
- platform/qt/fast/css/rem-dynamic-scaling-expected.png:
- platform/qt/fast/css/rem-units-on-root-expected.png:
- platform/qt/fast/css/rgb-float-expected.png:
- platform/qt/fast/css/selector-set-attribute-expected.png:
- platform/qt/fast/css/shadow-multiple-expected.png:
- platform/qt/fast/css/style-outside-head-expected.png:
- platform/qt/fast/css/style-parsed-outside-head-expected.png:
- platform/qt/fast/css/table-rules-attribute-groups-with-frame-expected.png:
- platform/qt/fast/css/table-text-align-quirk-expected.png:
- platform/qt/fast/css/table-text-align-strict-expected.png:
- platform/qt/fast/css/target-fragment-match-expected.png:
- platform/qt/fast/css/text-align-expected.png:
- platform/qt/fast/css/text-input-with-webkit-border-radius-expected.png:
- platform/qt/fast/css/text-overflow-ellipsis-text-align-center-expected.png:
- platform/qt/fast/css/text-overflow-ellipsis-text-align-justify-expected.png:
- platform/qt/fast/css/text-overflow-ellipsis-text-align-left-expected.png:
- platform/qt/fast/css/text-overflow-ellipsis-text-align-right-expected.png:
- platform/qt/fast/css/text-transform-select-expected.png:
- platform/qt/fast/css/textCapitalizeEdgeCases-expected.png:
- platform/qt/fast/css/transform-default-parameter-expected.png:
- platform/qt/fast/css/transformed-mask-expected.png:
- platform/qt/fast/css/transition-color-unspecified-expected.png:
- platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png:
- platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png:
- platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png:
- platform/qt/fast/css/visibility-hit-test-expected.png:
- platform/qt/fast/css/zoom-font-size-expected.png:
- platform/qt/fast/doctypes/001-expected.png:
- platform/qt/fast/doctypes/002-expected.png:
- platform/qt/fast/doctypes/003-expected.png:
- platform/qt/fast/doctypes/004-expected.png:
- platform/qt/fast/dom/34176-expected.png:
- platform/qt/fast/dom/Element/null-offset-parent-expected.png:
- platform/qt/fast/dom/HTMLElement/bdo-expected.png:
- platform/qt/fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png:
- platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
- platform/qt/fast/dom/HTMLObjectElement/vspace-hspace-as-number-expected.png:
- platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
- platform/qt/fast/dom/HTMLStyleElement/insert-parser-generated-expected.png:
- platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
- platform/qt/fast/dom/HTMLTableElement/colSpan-expected.png:
- platform/qt/fast/dom/HTMLTableElement/createCaption-expected.png:
- platform/qt/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
- platform/qt/fast/dom/Range/create-contextual-fragment-expected.png:
- platform/qt/fast/dom/Range/surroundContents-1-expected.png:
- platform/qt/fast/dom/Window/open-existing-pop-up-blocking-expected.png:
- platform/qt/fast/dom/anchor-text-expected.png:
- platform/qt/fast/dom/blur-contenteditable-expected.png:
- platform/qt/fast/dom/createDocumentType-expected.png:
- platform/qt/fast/dom/css-rule-functions-expected.png:
- platform/qt/fast/dom/delete-contents-expected.png:
- platform/qt/fast/dom/gc-10-expected.png:
- platform/qt/fast/dom/importNodeHTML-expected.png:
- platform/qt/fast/dom/importNodeXML-expected.png:
- platform/qt/fast/dynamic/002-expected.png:
- platform/qt/fast/dynamic/011-expected.png:
- platform/qt/fast/dynamic/014-expected.png:
- platform/qt/fast/dynamic/015-expected.png:
- platform/qt/fast/dynamic/anonymous-block-orphaned-lines-expected.png:
- platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.png:
- platform/qt/fast/dynamic/first-letter-display-change-expected.png:
- platform/qt/fast/dynamic/float-at-line-break-expected.png:
- platform/qt/fast/dynamic/float-no-longer-overhanging-expected.png:
- platform/qt/fast/dynamic/float-withdrawal-2-expected.png:
- platform/qt/fast/dynamic/float-withdrawal-expected.png:
- platform/qt/fast/dynamic/noninlinebadness-expected.png:
- platform/qt/fast/dynamic/outerHTML-doc-expected.png:
- platform/qt/fast/dynamic/outerHTML-img-expected.png:
- platform/qt/fast/dynamic/subtree-parent-static-y-expected.png:
- platform/qt/fast/dynamic/unicode-bidi-expected.png:
- platform/qt/fast/dynamic/view-overflow-expected.png:
- platform/qt/fast/encoding/utf-16-big-endian-expected.png:
- platform/qt/fast/encoding/utf-16-little-endian-expected.png:
- platform/qt/fast/events/event-listener-on-link-expected.png:
- platform/qt/fast/events/resize-events-expected.png:
- platform/qt/fast/fast-mobile-scrolling/fixed-position-element-expected.png:
- platform/qt/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png:
- platform/qt/fast/flexbox/001-expected.png:
- platform/qt/fast/flexbox/002-expected.png:
- platform/qt/fast/flexbox/003-expected.png:
- platform/qt/fast/flexbox/004-expected.png:
- platform/qt/fast/flexbox/005-expected.png:
- platform/qt/fast/flexbox/006-expected.png:
- platform/qt/fast/flexbox/007-expected.png:
- platform/qt/fast/flexbox/008-expected.png:
- platform/qt/fast/flexbox/009-expected.png:
- platform/qt/fast/flexbox/010-expected.png:
- platform/qt/fast/flexbox/011-expected.png:
- platform/qt/fast/flexbox/012-expected.png:
- platform/qt/fast/flexbox/013-expected.png:
- platform/qt/fast/flexbox/014-expected.png:
- platform/qt/fast/flexbox/015-expected.png:
- platform/qt/fast/flexbox/016-expected.png:
- platform/qt/fast/flexbox/017-expected.png:
- platform/qt/fast/flexbox/018-expected.png:
- platform/qt/fast/flexbox/019-expected.png:
- platform/qt/fast/flexbox/020-expected.png:
- platform/qt/fast/flexbox/021-expected.png:
- platform/qt/fast/flexbox/022-expected.png:
- platform/qt/fast/flexbox/023-expected.png:
- platform/qt/fast/flexbox/024-expected.png:
- platform/qt/fast/flexbox/overhanging-floats-removed-expected.png:
- platform/qt/fast/forms/HTMLOptionElement_label05-expected.png:
- platform/qt/fast/forms/basic-buttons-expected.png:
- platform/qt/fast/forms/basic-textareas-quirks-expected.png:
- platform/qt/fast/forms/button-default-title-expected.png:
- platform/qt/fast/forms/button-inner-block-reuse-expected.png:
- platform/qt/fast/forms/button-table-styles-expected.png:
- platform/qt/fast/forms/button-text-transform-expected.png:
- platform/qt/fast/forms/control-clip-overflow-expected.png:
- platform/qt/fast/forms/disabled-select-change-index-expected.png:
- platform/qt/fast/forms/fieldset-align-expected.png:
- platform/qt/fast/forms/file/file-input-direction-expected.png:
- platform/qt/fast/forms/floating-textfield-relayout-expected.png:
- platform/qt/fast/forms/form-hides-table-expected.png:
- platform/qt/fast/forms/input-appearance-selection-expected.png:
- platform/qt/fast/forms/input-placeholder-paint-order-expected.png:
- platform/qt/fast/forms/listbox-clip-expected.png:
- platform/qt/fast/forms/menulist-clip-expected.png:
- platform/qt/fast/forms/menulist-option-wrap-expected.png:
- platform/qt/fast/forms/negativeLineHeight-expected.png:
- platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- platform/qt/fast/forms/option-strip-whitespace-expected.png:
- platform/qt/fast/forms/placeholder-position-expected.png:
- platform/qt/fast/forms/search-rtl-expected.png:
- platform/qt/fast/forms/select-change-popup-to-listbox-expected.png:
- platform/qt/fast/forms/select-initial-position-expected.png:
- platform/qt/fast/forms/select-item-background-clip-expected.png:
- platform/qt/fast/forms/select-list-box-with-height-expected.png:
- platform/qt/fast/forms/select/optgroup-rendering-expected.png:
- platform/qt/fast/forms/textarea-align-expected.png:
- platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png:
- platform/qt/fast/forms/textarea/textarea-placeholder-paint-order-expected.png:
- 3:07 AM Changeset in webkit [147091] by
-
- 1 edit2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining after r147086.
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.
- 2:50 AM Changeset in webkit [147090] by
-
- 7 edits in trunk
Web Inspector: Auto expand retaining path until there are more than one retainer.
https://bugs.webkit.org/show_bug.cgi?id=112596
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-28
Reviewed by Yury Semikhatsky.
Source/WebCore:
When retainers view gets opened automatically expand retaining path
for objects having just a single retainer.
Test: inspector/profiler/heap-snapshot-summary-retainers.html
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.populateComplete):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.setDataSource):
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren):
LayoutTests:
When retainers view gets opened automatically expand retaining path
for objects having just a single retainer.
- Added a test for the new behavior.
- Replaced hardcoded "populate complete" string with the event object.
- inspector/profiler/heap-snapshot-summary-retainers-expected.txt:
- inspector/profiler/heap-snapshot-summary-retainers.html:
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):
- 2:47 AM Changeset in webkit [147089] by
-
- 412 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Updating PNG expected results after r146206.
- platform/qt/tables/mozilla/bugs/bug46480-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug46480-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug46623-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug46623-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug46924-expected.png:
- platform/qt/tables/mozilla/bugs/bug47432-expected.png:
- platform/qt/tables/mozilla/bugs/bug4849-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug48827-expected.png:
- platform/qt/tables/mozilla/bugs/bug51037-expected.png:
- platform/qt/tables/mozilla/bugs/bug5188-expected.png:
- platform/qt/tables/mozilla/bugs/bug52505-expected.png:
- platform/qt/tables/mozilla/bugs/bug52506-expected.png:
- platform/qt/tables/mozilla/bugs/bug53690-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug53690-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug5538-expected.png:
- platform/qt/tables/mozilla/bugs/bug55527-expected.png:
- platform/qt/tables/mozilla/bugs/bug55694-expected.png:
- platform/qt/tables/mozilla/bugs/bug55789-expected.png:
- platform/qt/tables/mozilla/bugs/bug57300-expected.png:
- platform/qt/tables/mozilla/bugs/bug57828-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug57828-expected.png:
- platform/qt/tables/mozilla/bugs/bug5799-expected.png:
- platform/qt/tables/mozilla/bugs/bug5835-expected.png:
- platform/qt/tables/mozilla/bugs/bug5838-expected.png:
- platform/qt/tables/mozilla/bugs/bug59354-expected.png:
- platform/qt/tables/mozilla/bugs/bug60804-expected.png:
- platform/qt/tables/mozilla/bugs/bug60807-expected.png:
- platform/qt/tables/mozilla/bugs/bug6184-expected.png:
- platform/qt/tables/mozilla/bugs/bug6304-expected.png:
- platform/qt/tables/mozilla/bugs/bug641-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug641-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug647-expected.png:
- platform/qt/tables/mozilla/bugs/bug650-expected.png:
- platform/qt/tables/mozilla/bugs/bug67915-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug68912-expected.png:
- platform/qt/tables/mozilla/bugs/bug68998-expected.png:
- platform/qt/tables/mozilla/bugs/bug69187-expected.png:
- platform/qt/tables/mozilla/bugs/bug69382-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug69382-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug709-expected.png:
- platform/qt/tables/mozilla/bugs/bug7112-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug7112-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug7121-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug7342-expected.png:
- platform/qt/tables/mozilla/bugs/bug7471-expected.png:
- platform/qt/tables/mozilla/bugs/bug7714-expected.png:
- platform/qt/tables/mozilla/bugs/bug78162-expected.png:
- platform/qt/tables/mozilla/bugs/bug80762-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug82946-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug82946-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug8381-expected.png:
- platform/qt/tables/mozilla/bugs/bug8411-expected.png:
- platform/qt/tables/mozilla/bugs/bug88035-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug88035-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug88524-expected.png:
- platform/qt/tables/mozilla/bugs/bug8858-expected.png:
- platform/qt/tables/mozilla/bugs/bug9072-expected.png:
- platform/qt/tables/mozilla/bugs/bug9123-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug9123-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug92143-expected.png:
- platform/qt/tables/mozilla/bugs/bug9271-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug9271-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug92868-expected.png:
- platform/qt/tables/mozilla/bugs/bug93363-expected.png:
- platform/qt/tables/mozilla/bugs/bug963-expected.png:
- platform/qt/tables/mozilla/bugs/bug96334-expected.png:
- platform/qt/tables/mozilla/bugs/bug96343-expected.png:
- platform/qt/tables/mozilla/bugs/bug965-expected.png:
- platform/qt/tables/mozilla/bugs/bug97138-expected.png:
- platform/qt/tables/mozilla/bugs/bug97383-expected.png:
- platform/qt/tables/mozilla/bugs/bug98196-expected.png:
- platform/qt/tables/mozilla/bugs/bug9879-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug99948-expected.png:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
- platform/qt/tables/mozilla/core/borders-expected.png:
- platform/qt/tables/mozilla/core/captions-expected.png:
- platform/qt/tables/mozilla/core/col_span-expected.png:
- platform/qt/tables/mozilla/core/col_widths_auto_autoFixPer-expected.png:
- platform/qt/tables/mozilla/core/col_widths_auto_autoPer-expected.png:
- platform/qt/tables/mozilla/core/col_widths_auto_fix-expected.png:
- platform/qt/tables/mozilla/core/col_widths_auto_fixPer-expected.png:
- platform/qt/tables/mozilla/core/col_widths_auto_per-expected.png:
- platform/qt/tables/mozilla/core/col_widths_fix_autoFix-expected.png:
- platform/qt/tables/mozilla/core/col_widths_fix_autoPer-expected.png:
- platform/qt/tables/mozilla/core/col_widths_fix_fix-expected.png:
- platform/qt/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
- platform/qt/tables/mozilla/core/col_widths_fix_per-expected.png:
- platform/qt/tables/mozilla/core/margins-expected.png:
- platform/qt/tables/mozilla/core/nested1-expected.png:
- platform/qt/tables/mozilla/core/row_span-expected.png:
- platform/qt/tables/mozilla/core/table_frame-expected.png:
- platform/qt/tables/mozilla/core/table_rules-expected.png:
- platform/qt/tables/mozilla/core/table_widths-expected.png:
- platform/qt/tables/mozilla/dom/deleteCol1-expected.png:
- platform/qt/tables/mozilla/dom/deleteCol2-expected.png:
- platform/qt/tables/mozilla/dom/deleteCol3-expected.png:
- platform/qt/tables/mozilla/dom/deleteColGroup1-expected.png:
- platform/qt/tables/mozilla/dom/deleteColGroup2-expected.png:
- platform/qt/tables/mozilla/dom/deleteRowsRebuild1-expected.png:
- platform/qt/tables/mozilla/dom/deleteRowsShrink1-expected.png:
- platform/qt/tables/mozilla/dom/deleteTbodyExpand1-expected.png:
- platform/qt/tables/mozilla/dom/deleteTbodyRebuild1-expected.png:
- platform/qt/tables/mozilla/dom/insertCellsExpand2-expected.png:
- platform/qt/tables/mozilla/dom/insertCellsRebuild1-expected.png:
- platform/qt/tables/mozilla/dom/insertCellsRebuild2-expected.png:
- platform/qt/tables/mozilla/dom/insertColGroups1-expected.png:
- platform/qt/tables/mozilla/dom/insertColGroups2-expected.png:
- platform/qt/tables/mozilla/dom/insertCols1-expected.png:
- platform/qt/tables/mozilla/dom/insertCols2-expected.png:
- platform/qt/tables/mozilla/dom/insertCols3-expected.png:
- platform/qt/tables/mozilla/dom/insertCols4-expected.png:
- platform/qt/tables/mozilla/dom/insertCols5-expected.png:
- platform/qt/tables/mozilla/dom/tableDom-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
- platform/qt/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
- platform/qt/tables/mozilla/marvin/body_tbody-expected.png:
- platform/qt/tables/mozilla/marvin/body_tfoot-expected.png:
- platform/qt/tables/mozilla/marvin/body_thead-expected.png:
- platform/qt/tables/mozilla/marvin/col_span-expected.png:
- platform/qt/tables/mozilla/marvin/colgroup_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/colgroup_align_justify-expected.png:
- platform/qt/tables/mozilla/marvin/colgroup_align_left-expected.png:
- platform/qt/tables/mozilla/marvin/colgroup_align_right-expected.png:
- platform/qt/tables/mozilla/marvin/colgroup_span-expected.png:
- platform/qt/tables/mozilla/marvin/colgroup_valign_baseline-expected.png:
- platform/qt/tables/mozilla/marvin/colgroup_valign_bottom-expected.png:
- platform/qt/tables/mozilla/marvin/colgroup_valign_middle-expected.png:
- platform/qt/tables/mozilla/marvin/colgroup_valign_top-expected.png:
- platform/qt/tables/mozilla/marvin/colgroup_width_pct-expected.png:
- platform/qt/tables/mozilla/marvin/colgroup_width_px-expected.png:
- platform/qt/tables/mozilla/marvin/table_frame_border-expected.png:
- platform/qt/tables/mozilla/marvin/table_frame_box-expected.png:
- platform/qt/tables/mozilla/marvin/table_row_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/table_row_align_left-expected.png:
- platform/qt/tables/mozilla/marvin/table_row_align_right-expected.png:
- platform/qt/tables/mozilla/marvin/table_rules_all-expected.png:
- platform/qt/tables/mozilla/marvin/table_rules_groups-expected.png:
- platform/qt/tables/mozilla/marvin/table_rules_none-expected.png:
- platform/qt/tables/mozilla/marvin/tables_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/tables_align_left-expected.png:
- platform/qt/tables/mozilla/marvin/tables_align_right-expected.png:
- platform/qt/tables/mozilla/marvin/tables_border_0-expected.png:
- platform/qt/tables/mozilla/marvin/tables_border_1-expected.png:
- platform/qt/tables/mozilla/marvin/tables_border_2-expected.png:
- platform/qt/tables/mozilla/marvin/tables_border_3-expected.png:
- platform/qt/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
- platform/qt/tables/mozilla/marvin/tables_caption_align_top-expected.png:
- platform/qt/tables/mozilla/marvin/tables_cellpadding-expected.png:
- platform/qt/tables/mozilla/marvin/tables_cellpadding_pct-expected.png:
- platform/qt/tables/mozilla/marvin/tables_cellspacing-expected.png:
- platform/qt/tables/mozilla/marvin/tables_class-expected.png:
- platform/qt/tables/mozilla/marvin/tables_default-expected.png:
- platform/qt/tables/mozilla/marvin/tables_id-expected.png:
- platform/qt/tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
- platform/qt/tables/mozilla/marvin/tables_style-expected.png:
- platform/qt/tables/mozilla/marvin/tables_td_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/tables_td_align_left-expected.png:
- platform/qt/tables/mozilla/marvin/tables_td_align_right-expected.png:
- platform/qt/tables/mozilla/marvin/tables_td_colspan-expected.png:
- platform/qt/tables/mozilla/marvin/tables_td_height-expected.png:
- platform/qt/tables/mozilla/marvin/tables_td_nowrap-expected.png:
- platform/qt/tables/mozilla/marvin/tables_td_rowspan-expected.png:
- platform/qt/tables/mozilla/marvin/tables_td_width-expected.png:
- platform/qt/tables/mozilla/marvin/tables_th_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/tables_th_align_left-expected.png:
- platform/qt/tables/mozilla/marvin/tables_th_align_right-expected.png:
- platform/qt/tables/mozilla/marvin/tables_th_colspan-expected.png:
- platform/qt/tables/mozilla/marvin/tables_th_height-expected.png:
- platform/qt/tables/mozilla/marvin/tables_th_rowspan-expected.png:
- platform/qt/tables/mozilla/marvin/tables_th_width-expected.png:
- platform/qt/tables/mozilla/marvin/tables_width_percent-expected.png:
- platform/qt/tables/mozilla/marvin/tables_width_px-expected.png:
- platform/qt/tables/mozilla/marvin/tbody_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/tbody_align_char-expected.png:
- platform/qt/tables/mozilla/marvin/tbody_align_justify-expected.png:
- platform/qt/tables/mozilla/marvin/tbody_align_left-expected.png:
- platform/qt/tables/mozilla/marvin/tbody_align_right-expected.png:
- platform/qt/tables/mozilla/marvin/tbody_char-expected.png:
- platform/qt/tables/mozilla/marvin/tfoot_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/tfoot_align_char-expected.png:
- platform/qt/tables/mozilla/marvin/tfoot_align_justify-expected.png:
- platform/qt/tables/mozilla/marvin/tfoot_align_left-expected.png:
- platform/qt/tables/mozilla/marvin/tfoot_align_right-expected.png:
- platform/qt/tables/mozilla/marvin/tfoot_char-expected.png:
- platform/qt/tables/mozilla/marvin/thead_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/thead_align_char-expected.png:
- platform/qt/tables/mozilla/marvin/thead_align_justify-expected.png:
- platform/qt/tables/mozilla/marvin/thead_align_left-expected.png:
- platform/qt/tables/mozilla/marvin/thead_align_right-expected.png:
- platform/qt/tables/mozilla/marvin/thead_char-expected.png:
- platform/qt/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
- platform/qt/tables/mozilla/marvin/x_caption_align_top-expected.png:
- platform/qt/tables/mozilla/marvin/x_col_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/x_col_align_char-expected.png:
- platform/qt/tables/mozilla/marvin/x_col_align_justify-expected.png:
- platform/qt/tables/mozilla/marvin/x_col_span-expected.png:
- platform/qt/tables/mozilla/marvin/x_col_valign_baseline-expected.png:
- platform/qt/tables/mozilla/marvin/x_col_valign_bottom-expected.png:
- platform/qt/tables/mozilla/marvin/x_col_valign_middle-expected.png:
- platform/qt/tables/mozilla/marvin/x_col_valign_top-expected.png:
- platform/qt/tables/mozilla/marvin/x_col_width_pct-expected.png:
- platform/qt/tables/mozilla/marvin/x_col_width_px-expected.png:
- platform/qt/tables/mozilla/marvin/x_col_width_rel-expected.png:
- platform/qt/tables/mozilla/marvin/x_colgroup_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/x_colgroup_align_char-expected.png:
- platform/qt/tables/mozilla/marvin/x_colgroup_align_justify-expected.png:
- platform/qt/tables/mozilla/marvin/x_colgroup_span-expected.png:
- platform/qt/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.png:
- platform/qt/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.png:
- platform/qt/tables/mozilla/marvin/x_colgroup_valign_middle-expected.png:
- platform/qt/tables/mozilla/marvin/x_colgroup_valign_top-expected.png:
- platform/qt/tables/mozilla/marvin/x_colgroup_width_pct-expected.png:
- platform/qt/tables/mozilla/marvin/x_colgroup_width_rel-expected.png:
- platform/qt/tables/mozilla/marvin/x_table-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_border-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_border_none-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_border_px-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_cellpadding-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_cellpadding_pct-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_cellspacing_pct-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_class-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_frame_void-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_id-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_rules_groups-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_rules_none-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_style-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_width_pct-expected.png:
- platform/qt/tables/mozilla/marvin/x_table_width_px-expected.png:
- platform/qt/tables/mozilla/marvin/x_tbody_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/x_tbody_align_char-expected.png:
- platform/qt/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
- platform/qt/tables/mozilla/marvin/x_tbody_align_left-expected.png:
- platform/qt/tables/mozilla/marvin/x_tbody_align_right-expected.png:
- platform/qt/tables/mozilla/marvin/x_tbody_class-expected.png:
- platform/qt/tables/mozilla/marvin/x_tbody_id-expected.png:
- platform/qt/tables/mozilla/marvin/x_tbody_style-expected.png:
- platform/qt/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
- platform/qt/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
- platform/qt/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
- platform/qt/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
- platform/qt/tables/mozilla/marvin/x_td_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/x_td_align_char-expected.png:
- platform/qt/tables/mozilla/marvin/x_td_align_justify-expected.png:
- platform/qt/tables/mozilla/marvin/x_td_align_left-expected.png:
- platform/qt/tables/mozilla/marvin/x_td_align_right-expected.png:
- platform/qt/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
- platform/qt/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
- platform/qt/tables/mozilla/marvin/x_td_height-expected.png:
- platform/qt/tables/mozilla/marvin/x_td_nowrap-expected.png:
- platform/qt/tables/mozilla/marvin/x_td_valign_baseline-expected.png:
- platform/qt/tables/mozilla/marvin/x_td_valign_bottom-expected.png:
- platform/qt/tables/mozilla/marvin/x_td_valign_middle-expected.png:
- platform/qt/tables/mozilla/marvin/x_td_valign_top-expected.png:
- platform/qt/tables/mozilla/marvin/x_td_width-expected.png:
- platform/qt/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
- platform/qt/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
- platform/qt/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
- platform/qt/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
- platform/qt/tables/mozilla/marvin/x_tfoot_class-expected.png:
- platform/qt/tables/mozilla/marvin/x_tfoot_id-expected.png:
- platform/qt/tables/mozilla/marvin/x_tfoot_style-expected.png:
- platform/qt/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
- platform/qt/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
- platform/qt/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
- platform/qt/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_align_char-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_align_justify-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_align_left-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_align_right-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_class-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_height-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_id-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_nowrap-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_style-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_valign_baseline-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_valign_bottom-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_valign_top-expected.png:
- platform/qt/tables/mozilla/marvin/x_th_width-expected.png:
- platform/qt/tables/mozilla/marvin/x_thead_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/x_thead_align_char-expected.png:
- platform/qt/tables/mozilla/marvin/x_thead_align_justify-expected.png:
- platform/qt/tables/mozilla/marvin/x_thead_align_left-expected.png:
- platform/qt/tables/mozilla/marvin/x_thead_align_right-expected.png:
- platform/qt/tables/mozilla/marvin/x_thead_class-expected.png:
- platform/qt/tables/mozilla/marvin/x_thead_id-expected.png:
- platform/qt/tables/mozilla/marvin/x_thead_style-expected.png:
- platform/qt/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
- platform/qt/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
- platform/qt/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
- platform/qt/tables/mozilla/marvin/x_thead_valign_top-expected.png:
- platform/qt/tables/mozilla/marvin/x_tr_align_center-expected.png:
- platform/qt/tables/mozilla/marvin/x_tr_align_char-expected.png:
- platform/qt/tables/mozilla/marvin/x_tr_align_justify-expected.png:
- platform/qt/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
- platform/qt/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
- platform/qt/tables/mozilla/marvin/x_tr_valign_baseline-expected.png:
- platform/qt/tables/mozilla/marvin/x_tr_valign_bottom-expected.png:
- platform/qt/tables/mozilla/marvin/x_tr_valign_middle-expected.png:
- platform/qt/tables/mozilla/marvin/x_tr_valign_top-expected.png:
- platform/qt/tables/mozilla/other/cellspacing-expected.png:
- platform/qt/tables/mozilla/other/nested2-expected.png:
- platform/qt/tables/mozilla/other/nestedTables-expected.png:
- platform/qt/tables/mozilla/other/padding-expected.png:
- platform/qt/tables/mozilla/other/test3-expected.png:
- platform/qt/tables/mozilla/other/test6-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/97619-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug11331-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug11945-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug14489-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug17826-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug18770-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug21518-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug24880-1-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug25707-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-18-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug42043-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug47163-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug61042-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug72393-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug73629-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug9879-1-expected.png:
- platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.png:
- platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
- platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
- platform/qt/tables/mozilla_expected_failures/core/backgrounds-expected.png:
- platform/qt/tables/mozilla_expected_failures/core/captions1-expected.png:
- platform/qt/tables/mozilla_expected_failures/core/captions2-expected.png:
- platform/qt/tables/mozilla_expected_failures/core/captions3-expected.png:
- platform/qt/tables/mozilla_expected_failures/core/col_span2-expected.png:
- platform/qt/tables/mozilla_expected_failures/core/cols1-expected.png:
- platform/qt/tables/mozilla_expected_failures/core/columns-expected.png:
- platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.png:
- platform/qt/tables/mozilla_expected_failures/core/standards1-expected.png:
- platform/qt/tables/mozilla_expected_failures/dom/appendCells1-expected.png:
- platform/qt/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.png:
- platform/qt/tables/mozilla_expected_failures/dom/appendColGroup1-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_frame_above-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_frame_below-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_frame_void-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.png:
- platform/qt/tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.png:
- platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.png:
- platform/qt/tables/mozilla_expected_failures/other/test4-expected.png:
- platform/qt/transforms/2d/compound-transforms-vs-containers-expected.png:
- platform/qt/transforms/2d/transform-borderbox-expected.png:
- platform/qt/transforms/2d/transform-fixed-container-expected.png:
- platform/qt/transforms/2d/transform-origin-borderbox-expected.png:
- platform/qt/transforms/2d/zoom-menulist-expected.png:
- platform/qt/transitions/cross-fade-background-image-expected.png:
- platform/qt/transitions/cross-fade-border-image-expected.png:
- platform/qt/transitions/svg-text-shadow-transition-expected.png:
- 2:33 AM Changeset in webkit [147088] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Fixed property text indentation in Styles sidebar.
https://bugs.webkit.org/show_bug.cgi?id=113409
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-28
Reviewed by Alexander Pavlov.
When the sidebar is too narrow and the property text wraps around it breaks the indentation.
This was introduced in r143207 which spuriously modified DOM elements order.
- inspector/front-end/StylesSidebarPane.js:
- 2:13 AM Changeset in webkit [147087] by
-
- 3 edits2 adds in trunk
Regression: Crash when selecting Hebrew and numbers in a list
https://bugs.webkit.org/show_bug.cgi?id=111894
Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-03-28
Reviewed by Ryosuke Niwa.
Source/WebCore:
There is a crash when trying to click/select an anonymous
renderer.
This is a regression due to r143313 which tries to add border/padding
to the computed caret rect in RenderBox::localCaretRect().
The patch calls on the node() method for the corresponding
renderer. For an anonymous renderer though, node() returns
null. Since no check had been added for this, a crash occurs when
caret rect for an anonymous renderer is being computed.
Test: editing/selection/click-on-anonymous-content-crash.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):
Added a check for validating the return from the node() call.
LayoutTests:
- editing/selection/click-on-anonymous-content-crash-expected.txt: Added.
- editing/selection/click-on-anonymous-content-crash.html: Added.
Added a testcase for verifying that no crash occurs when trying to
select/click an anonymous renderer, in this case the list marker's
renderer.
- 1:59 AM Changeset in webkit [147086] by
-
- 5 edits11 adds in trunk
X-Frame-Options: Multiple headers are ignored completely.
https://bugs.webkit.org/show_bug.cgi?id=113387
Reviewed by Nate Chapin.
Source/WebCore:
If a server sends multiple 'X-Frame-Options' headers, we end up with a
value like 'SAMEORIGIN, SAMEORIGIN'. Currently, we're treating that as
invalid, and ignoring the header. It would be safer to follow Gecko's
lead[1] by:
- Folding duplicated entries into their common value (that is: 'sameorigin, sameorigin' -> 'sameorigin').
- Failing closed in the case of conflicts (that is: 'sameorigin, allowall' -> 'deny').
[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=761655
Tests: http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict.html
http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow.html
http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
Call out to parseXFrameOptionsHeader to get the header's disposition
and deal with each case in a switch statement for clarity. Add a new
console warning for the conflict case described above.
- platform/network/HTTPParsers.cpp:
(WebCore::parseXFrameOptionsHeader):
- platform/network/HTTPParsers.h:
Move X-Frame-Options parsing out into HTTPParsers, as it's getting
more and more complicated. To do this, the patch defines a new enum
to pass around the header's disposition.
LayoutTests:
- http/tests/security/XFrameOptions/resources/x-frame-options-multiple-headers-conflict.cgi: Added.
- http/tests/security/XFrameOptions/resources/x-frame-options-multiple-headers-sameorigin.cgi: Added.
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict.html: Added.
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow-expected.txt: Added.
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow.html: Added.
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow-expected.txt: Added.
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.
- 1:48 AM Changeset in webkit [147085] by
-
- 2 edits in trunk
Unreviewed GTK build fix after r147039.
- Source/autotools/symbols.filter: Export the missing symbols.
- 1:37 AM Changeset in webkit [147084] by
-
- 3 edits2 adds30 deletes in trunk/LayoutTests
[CSS Regions] Convert layout tests region-style-block-background-color[2] to ref-tests
https://bugs.webkit.org/show_bug.cgi?id=86339
Patch by Mihai Tica <mitica@adobe.com> on 2013-03-28
Reviewed by Tony Chang.
This patch converts the pixel test baseline into ref-tests for the following tests:
fast/regions/region-style-block-background-color.html
fast/regions/region-style-block-background-color2.html
- fast/regions/region-style-block-background-color-expected.html: Added.
- fast/regions/region-style-block-background-color.html:
- fast/regions/region-style-block-background-color2-expected.html: Added.
- fast/regions/region-style-block-background-color2.html:
- platform/chromium-linux/fast/regions/region-style-block-background-color-expected.png: Removed.
- platform/chromium-linux/fast/regions/region-style-block-background-color2-expected.png: Removed.
- platform/chromium-mac-lion/fast/regions/region-style-block-background-color-expected.png: Removed.
- platform/chromium-mac-lion/fast/regions/region-style-block-background-color2-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/regions/region-style-block-background-color-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/regions/region-style-block-background-color2-expected.png: Removed.
- platform/chromium-mac/fast/regions/region-style-block-background-color-expected.png: Removed.
- platform/chromium-mac/fast/regions/region-style-block-background-color2-expected.png: Removed.
- platform/chromium-win/fast/regions/region-style-block-background-color-expected.png: Removed.
- platform/chromium-win/fast/regions/region-style-block-background-color-expected.txt: Removed.
- platform/chromium-win/fast/regions/region-style-block-background-color2-expected.png: Removed.
- platform/chromium-win/fast/regions/region-style-block-background-color2-expected.txt: Removed.
- platform/chromium/fast/regions/region-style-block-background-color-expected.txt: Removed.
- platform/chromium/fast/regions/region-style-block-background-color2-expected.txt: Removed.
- platform/efl/fast/regions/region-style-block-background-color-expected.png: Removed.
- platform/efl/fast/regions/region-style-block-background-color-expected.txt: Removed.
- platform/efl/fast/regions/region-style-block-background-color2-expected.png: Removed.
- platform/efl/fast/regions/region-style-block-background-color2-expected.txt: Removed.
- platform/gtk/fast/regions/region-style-block-background-color-expected.png: Removed.
- platform/gtk/fast/regions/region-style-block-background-color-expected.txt: Removed.
- platform/gtk/fast/regions/region-style-block-background-color2-expected.png: Removed.
- platform/gtk/fast/regions/region-style-block-background-color2-expected.txt: Removed.
- platform/mac/fast/regions/region-style-block-background-color-expected.png: Removed.
- platform/mac/fast/regions/region-style-block-background-color-expected.txt: Removed.
- platform/mac/fast/regions/region-style-block-background-color2-expected.png: Removed.
- platform/mac/fast/regions/region-style-block-background-color2-expected.txt: Removed.
- platform/qt/fast/regions/region-style-block-background-color-expected.png: Removed.
- platform/qt/fast/regions/region-style-block-background-color-expected.txt: Removed.
- platform/qt/fast/regions/region-style-block-background-color2-expected.png: Removed.
- platform/qt/fast/regions/region-style-block-background-color2-expected.txt: Removed.
- 1:30 AM Changeset in webkit [147083] by
-
- 4 edits2 copies6 deletes in trunk/LayoutTests
Gardening. Organize expected results, because the generic expected file should be the one that uses JSC.
https://bugs.webkit.org/show_bug.cgi?id=113291.
Reviewed by Csaba Osztrogonác.
- inspector/console/console-eval-syntax-error-expected.txt:
- inspector/debugger/debugger-pause-in-eval-script-expected.txt:
- inspector/extensions/extensions-eval-expected.txt:
- platform/chromium/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Copied from LayoutTests/inspector/debugger/debugger-pause-in-eval-script-expected.txt.
- platform/chromium/inspector/extensions/extensions-eval-expected.txt: Copied from LayoutTests/inspector/extensions/extensions-eval-expected.txt.
- platform/mac/inspector/console/console-eval-syntax-error-expected.txt: Removed.
- platform/mac/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Removed.
- platform/mac/inspector/extensions/extensions-eval-expected.txt: Removed.
- platform/qt/inspector/console/console-eval-syntax-error-expected.txt: Removed.
- platform/qt/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Removed.
- platform/qt/inspector/extensions/extensions-eval-expected.txt: Removed.
- 1:26 AM Changeset in webkit [147082] by
-
- 4 edits in trunk/Source/WebCore
[CSSRegions] Consolidate use of RenderRegion::isValid
https://bugs.webkit.org/show_bug.cgi?id=113154
Reviewed by David Hyatt.
After https://bugs.webkit.org/show_bug.cgi?id=98752, the list of invalid regions is kept separately than the list of valid regions.
A valid region has always a valid flow thread attached. We can use isValid() throughout the RenderRegion code
instead of testing for both isValid() and m_flowThread.
No new tests since there is no change is functionality, just code refactoring.
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::addRegionToNamedFlowThread): Added a new function to keep the code
used in addRegionToThread and checkInvalidRegions.
(WebCore::RenderNamedFlowThread::addRegionToThread):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):
- rendering/RenderNamedFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
(WebCore::RenderRegion::isFirstRegion):
(WebCore::RenderRegion::isLastRegion):
(WebCore::RenderRegion::paintObject):
(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::incrementAutoLogicalHeightCount):
(WebCore::RenderRegion::decrementAutoLogicalHeightCount):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::renderBoxRegionInfo):
(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::logicalTopOfFlowThreadContentRect):
(WebCore::RenderRegion::logicalBottomOfFlowThreadContentRect):
(WebCore::RenderRegion::computePreferredLogicalWidths):
- 1:25 AM Changeset in webkit [147081] by
-
- 3 edits in trunk/Tools
[CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
https://bugs.webkit.org/show_bug.cgi?id=113484
Unreviewed build fix.
Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-28
- TestWebKitAPI/CMakeLists.txt:
- WebKitTestRunner/CMakeLists.txt:
- 1:09 AM Changeset in webkit [147080] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening. Test Expectations update.
- platform/chromium/TestExpectations:
- 12:51 AM Changeset in webkit [147079] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for the EFL and GTK ports.
- runtime/CodeCache.cpp:
(JSC::CodeCacheMap::pruneSlowCase): Pass a 0 casted to the int64_t type instead of 0LL
to the std::max call so the arguments' types match.
- 12:44 AM Changeset in webkit [147078] by
-
- 2 edits in tags/Safari-537.35.2/Source/WebKit2
Merged r147049. <rdar://problem/13522909>
- 12:42 AM Changeset in webkit [147077] by
-
- 27 edits7 copies in tags/Safari-537.35.2
Merged r147039. <rdar://problem/13383835>
- 12:40 AM Changeset in webkit [147076] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Timeline. Refresh is slow when user drags the overview window.
https://bugs.webkit.org/show_bug.cgi?id=113371
Reviewed by Pavel Feldman.
The root of problem is the 300ms delay in scheduleRefresh method.
It was introduced for the case when we add a huge number of records per second.
The scheduleRefresh was written such a way that refresh happened immediately
only for the scrolling operations. Actually we would like to see fast
refresh every time when it is forced by an user action.
In this patch additional flag newRecordWasAdded was added to the
_invalidateAndScheduleRefresh. I made it mandatory because the function
is also used as a callback for an event and it is easy to make a mistake and
interpret the event as the flag.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._onCategoryCheckboxClicked):
(WebInspector.TimelinePanel.prototype._durationFilterChanged):
(WebInspector.TimelinePanel.prototype._repopulateRecords):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype._onRecordsCleared):
(WebInspector.TimelinePanel.prototype._invalidateAndScheduleRefresh):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
(WebInspector.TimelinePanel.prototype._revealRecord):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype.performFilter):
- 12:29 AM Changeset in webkit [147075] by
-
- 14 edits in tags/Safari-537.35.2
Merged r146956. <rdar://problem/13032692>
- 12:08 AM Changeset in webkit [147074] by
-
- 24 edits3 copies in tags/Safari-537.35.2/Source
Merged r146929. <rdar://problem/13194263>
- 12:05 AM Changeset in webkit [147073] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening. Test Expectations update.
- platform/chromium/TestExpectations:
