Context Navigation

← Previous Period
Next Period →

Timeline

Mar 30, 2013:

9:30 PM Changeset in webkit [147285] by abarth@webkit.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unused includes of stdio.h
https://bugs.webkit.org/show_bug.cgi?id=113650

Reviewed by Dimitri Glazkov.

We shouldn't include stdio.h. These includes aren't used anyway.

src/WebInputEvent.cpp:
src/x11/WebScreenInfoFactory.cpp:

9:11 PM Changeset in webkit [147284] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Remove unused include of RegularExpression.h
https://bugs.webkit.org/show_bug.cgi?id=113649

Reviewed by Dimitri Glazkov.

Modules/filesystem/DOMFilePath.cpp:
- This include isn't used.

5:04 PM Changeset in webkit [147283] by fpizlo@apple.com

9 edits
4 adds in branches/dfgFourthTier

fourthTier: FTL JIT should be able to compile the Marsaglia random number generator
https://bugs.webkit.org/show_bug.cgi?id=113635

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Just adding missing functionality.

Also "fixed" OSR exit to use a call to abort() in addition to using Unreachable
since the latter doesn't actually mean trap - quite the opposite, it tells LLVM
that the code can never be reached.

The Marsaglia function runs ~60% faster with FTL, than DFG. Not a terrible start.

JavaScriptCore.xcodeproj/project.pbxproj:
ftl/FTLAbbreviations.h:

(FTL):
(JSC::FTL::voidType):
(JSC::FTL::structType):
(JSC::FTL::functionType):
(JSC::FTL::addFunction):
(JSC::FTL::setLinkage):
(JSC::FTL::setFunctionCallingConv):
(JSC::FTL::addExternFunction):
(JSC::FTL::constIntToPtr):
(JSC::FTL::constBitCast):
(JSC::FTL::buildMul):
(JSC::FTL::buildOr):
(JSC::FTL::buildShl):
(JSC::FTL::buildAShr):
(JSC::FTL::buildCall):
(JSC::FTL::buildExtractValue):
(JSC::FTL::dumpModule):
(JSC::FTL::verifyModule):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLCompile.cpp:

(JSC::FTL::compile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileBitAnd):
(JSC::FTL::LowerDFGToLLVM::compileBitOr):
(JSC::FTL::LowerDFGToLLVM::compileBitRShift):
(JSC::FTL::LowerDFGToLLVM::compileBitLShift):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::compileBranch):
(JSC::FTL::LowerDFGToLLVM::speculateBackward):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):

ftl/FTLOutput.h:

(JSC::FTL::Output::Output):
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::appendTo):
(Output):
(JSC::FTL::Output::mul):
(JSC::FTL::Output::bitOr):
(JSC::FTL::Output::shl):
(JSC::FTL::Output::aShr):
(JSC::FTL::Output::addWithOverflow32):
(JSC::FTL::Output::mulWithOverflow32):
(JSC::FTL::Output::extractValue):
(JSC::FTL::Output::call):
(JSC::FTL::Output::addWithOverflow32Function):
(JSC::FTL::Output::mulWithOverflow32Function):

ftl/FTLState.cpp: Added.

(FTL):
(JSC::FTL::State::dumpState):

ftl/FTLState.h:

(State):

LayoutTests:

Reviewed by Oliver Hunt.

fast/js/regress/marsaglia-expected.txt: Added.
fast/js/regress/marsaglia.html: Added.
fast/js/regress/script-tests/marsaglia.js: Added.

(marsaglia):

12:01 PM Changeset in webkit [147282] by mhahnenberg@apple.com

8 edits
1 add in trunk/Source/JavaScriptCore

Move Region into its own header
https://bugs.webkit.org/show_bug.cgi?id=113617

Reviewed by Geoffrey Garen.

BlockAllocator.h is getting a little crowded. We should move the Region class into its own
header, since it's pretty independent from the BlockAllocator.

GNUmakefile.list.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/BlockAllocator.h:

(JSC):

heap/Region.h: Added.

(JSC):
(DeadBlock):
(JSC::DeadBlock::DeadBlock):
(Region):
(JSC::Region::blockSize):
(JSC::Region::isFull):
(JSC::Region::isEmpty):
(JSC::Region::isCustomSize):
(JSC::Region::create):
(JSC::Region::createCustomSize):
(JSC::Region::Region):
(JSC::Region::~Region):
(JSC::Region::reset):
(JSC::Region::allocate):
(JSC::Region::deallocate):

11:31 AM Changeset in webkit [147281] by tsepez@chromium.org

11 edits in trunk

Cross-Origin copy&paste / drag&drop allowing XSS via srcdoc attribute.
https://bugs.webkit.org/show_bug.cgi?id=113443

Reviewed by Adam Barth.

Source/WebCore:

Tested by LayoutTests/editing/pasteboard/paste-noscript.html

dom/Element.h:

(Element):
(WebCore::Element::isHTMLContentAttribute):
Adds an isHTMLContentAttribute() method to determine whether an attribute can contain
(potentially unsafe) HTML content. Currently, the iframe's srcdoc attribute is the only
such attribute, but clever folks might add more in the future.
Rename stripJavaScriptAttributes() method to stripScriptingAttributes(), to better reflect
the reality that scripting content may appear as above.
Adds missing consts and consolidate isJavaScriptAttribute() method.

dom/Element.cpp:

(WebCore::Element::isJavaScriptURLAttribute):
(WebCore::Element::stripScriptingAttributes):
Consolidated methods.

html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isHTMLContentAttribute):
(WebCore):

html/HTMLFrameElementBase.h:

(HTMLFrameElementBase):
Indicate that for frames, the srcdoc attribute contains HTML content.

html/parser/HTMLConstructionSite.cpp:

(WebCore::setAttributes):

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::setAttributes):

xml/parser/XMLDocumentParserQt.cpp:

(WebCore::setAttributes):
Rename stripJavaScriptAttribute calls to match Element.h

LayoutTests:

editing/pasteboard/paste-noscript-expected.txt:
editing/pasteboard/paste-noscript.html:

Adds a test that an iframe's srcdoc attribute is not pasted.

11:22 AM Changeset in webkit [147280] by tsepez@chromium.org

8 edits in trunk

View-source iframes are dangerous (and not very useful).
https://bugs.webkit.org/show_bug.cgi?id=113345

Reviewed by Adam Barth.

Source/WebCore:

html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):
Conditionalize viewsource attribute on ENABLE(VIEWSOURCE_ATTRIBUTE).

Source/WebKit/chromium:

features.gypi:

Disable VIEWSOURCE_ATTRIBUTE for chromium.

Source/WTF:

wtf/FeatureDefines.h:

Default definition of ENABLE_VIEWSOURCE_ATTRIBUTE is enabled.

LayoutTests:

platform/chromium/TestExpectations:

Update expectations now that chromium excludes iframe's viewsource attribute.

6:08 AM Changeset in webkit [147279] by Philippe Normand

3 edits in trunk/Source/WebCore

[GTK] Should use GStreamer codec installation infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34085

Reviewed by Martin Robinson.

Initial support for the GStreamer codec installer. The player will
handle missing-plugins messages and use the pbutils codec
installer facilities to install the missing GStreamer
plugins. Once the plugins are installed reset the pipeline state.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::mediaPlayerPrivatePluginInstallerResultFunction): This
method is used to notify the player that the missing plugins were installed.
(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Ignore
errors while installing plugins and handle the missing-plugin message.
(WebCore::MediaPlayerPrivateGStreamer::handlePluginInstallerResult):
This method is invoked after the installer finished its task.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

3:41 AM Changeset in webkit [147278] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

g_slist_reverse() may not be required in webKitWebAudioSrcLoop
https://bugs.webkit.org/show_bug.cgi?id=113568

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-03-30
Reviewed by Philippe Normand.

Decremental 'for' loop logic implemented to avoid using g_slist_reverse().

Original code - 2.025230 micro seconds per loop
Original code + patch - 1.964759 micro seconds per loop

This patch is covered by existing webaudio tests.

platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcLoop):

1:59 AM Changeset in webkit [147277] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

Unreviewed buildfix after r147260.

WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

1:34 AM Changeset in webkit [147276] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Layout Test inspector/console/console-css-warnings.html is failing on debug.
https://bugs.webkit.org/show_bug.cgi?id=113483

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-30
Reviewed by Pavel Feldman.
Desable the test (duplicate a rule from TestExpectations to override "webkit.org/b/90488 [ Debug ] inspector [ Slow ]").

inspector/console/console-css-warnings-expected.txt:
platform/chromium/TestExpectations:

1:24 AM Changeset in webkit [147275] by commit-queue@webkit.org

14 edits in trunk/Source

Web Inspector: Fonts refactoring
https://bugs.webkit.org/show_bug.cgi?id=113047

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-30
Reviewed by Pavel Feldman.

Unify fonts usage across inspector.
Make inspector default font depend on platform.

Source/WebCore:

inspector/front-end/breakpointsList.css:
inspector/front-end/dataGrid.css:

(.data-grid):
(.data-grid table):
(.data-grid td):
(.data-grid th.sort-ascending > div::after):
(.data-grid th.sort-descending > div::after):
(.data-grid button):

inspector/front-end/heapProfiler.css:

(.heap-snapshot-view .class-view-toolbar input.class-name-filter):
(.heap-snapshot-view .retainers-view-header):

inspector/front-end/inspector.css:

(.toolbar-item):
(.toolbar-label):
(.console-message .bubble):
(.outline-disclosure > ol):
(.source-code):
(.scope-bar li):
(.sidebar-tree, .sidebar-tree .children):
(.sidebar-tree-section):
(li .status .bubble):
(.sidebar-tree-item.selected):
(.sidebar-tree-item .titles):
(.sidebar-tree-item .subtitle):
(.sidebar-tree-item.selected .subtitle):
(.source-frame-breakpoint-message):
(.soft-context-menu):

inspector/front-end/inspectorCommon.css:

(body):
(.resources-divider-label):

inspector/front-end/navigatorView.css:

(.navigator li):
(.navigator li.selected .selection):
(.navigator .base-navigator-tree-element-title):

inspector/front-end/networkLogView.css:

(.network-log-grid.data-grid td):
(.network-log-grid.data-grid.small td):
(.network-log-grid.data-grid th):
(.network-log-grid.data-grid select):
(.network-graph-label):
(.network-timeline-grid .resources-divider-label):
(.network-log-grid.data-grid .network-summary-bar td):

inspector/front-end/resourcesPanel.css:

(.resources.panel .sidebar li):
(.resources.panel .sidebar li.selected):
(.resources.panel .sidebar li.selected .selection):

inspector/front-end/sidebarPane.css:

(.sidebar-pane > .body .info):
(.sidebar-pane-title):
(.sidebar-pane-toolbar):
(.sidebar-pane-subtitle):

inspector/front-end/tabbedPane.css:

(.tabbed-pane-header-tab):
(.tabbed-pane-header-tab-close-button):
(select.tabbed-pane-header-tabs-drop-down-select):

inspector/front-end/timelinePanel.css:

(.memory-counter-value):

Source/WebKit/chromium:

src/js/devTools.css:

(body.platform-linux):
(body.platform-mac):
(body.platform-windows):

1:14 AM Changeset in webkit [147274] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Remove resource-har-conversion.html from TestExpectation
https://bugs.webkit.org/show_bug.cgi?id=113586

Unreviewed, EFL gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-03-30

platform/efl/TestExpectations: Rebaseline after r147219.

Mar 29, 2013:

10:20 PM Changeset in webkit [147273] by pfeldman@chromium.org

1 edit in branches/chromium/1453/Source/WebCore/inspector/front-end/timelinePanel.css

Merge 146849 "Web Inspector: [Timeline] Records sidebar is clipped."
BUG=222683

Web Inspector: [Timeline] Records sidebar is clipped.
https://bugs.webkit.org/show_bug.cgi?id=113177

Reviewed by Pavel Feldman.

Analysis: depending on CSS injection order sidebar rule that overwrites
"bottom" property may win.

Fix: make timeline-specific rule "important".

inspector/front-end/timelinePanel.css:
(.timeline .sidebar): Make "bottom" value "important".

TBR=eustas@chromium.org
Review URL: https://codereview.chromium.org/13383002

10:12 PM Changeset in webkit [147272] by pfeldman@chromium.org

4 edits in branches/chromium/1453

Merge 147028 "REGRESSION (r146588): Cannot correctly display Chi..."
BUG=223503

REGRESSION (r146588): Cannot correctly display Chinese SNS Renren
https://bugs.webkit.org/show_bug.cgi?id=113142

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-27
Reviewed by Pavel Feldman.

Source/WebCore:

Changed CSS grammar to be equivalent to pre-r146588.
CSS error reporting disabled to prevent message overflow.

css/CSSGrammar.y.in:
css/CSSParser.cpp:
(WebCore::CSSParser::isLoggingErrors):

LayoutTests:

TestExpectations:
fast/css/parsing-error-recovery.html:

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13382002

9:51 PM Changeset in webkit [147271] by fpizlo@apple.com

2 edits in branches/dfgFourthTier/Source/JavaScriptCore

Unreviewed, release mode build fix.

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):

9:41 PM Changeset in webkit [147270] by fpizlo@apple.com

2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Change DO_NOT_INCLUDE_LLVM_CPP_HEADERS to LLVM_DO_NOT_INCLUDE_CPP_HEADERS
https://bugs.webkit.org/show_bug.cgi?id=113634

Reviewed by Dan Bernstein.

ftl/FTLLLVMHeaders.h:

9:15 PM Changeset in webkit [147269] by fpizlo@apple.com

3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL JIT should be able run some simple function
https://bugs.webkit.org/show_bug.cgi?id=113481

Reviewed by Geoffrey Garen.

I forgot to make a couple of the requested review changes, so I'm making
them now!

ftl/FTLCompile.cpp:

(JSC::FTL::compile):

ftl/FTLJITCode.h:

7:54 PM Changeset in webkit [147268] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL] Unreviewed build fix after r147251
https://bugs.webkit.org/show_bug.cgi?id=113631

Unreviewed build fix.

Add NETWORK_PROCESS guard.

Patch by Seokju Kwon <Seokju Kwon> on 2013-03-29

UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):

7:08 PM Changeset in webkit [147267] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r147263.
http://trac.webkit.org/changeset/147263
https://bugs.webkit.org/show_bug.cgi?id=113632

Breaks test fast/loader/display-image-unset-allows-cached-
image-load.html (Requested by mlam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-29

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::freshnessLifetime):

6:49 PM Changeset in webkit [147266] by roger_fong@apple.com

3 edits in trunk/Source/WebCore

Unreviewed. AppleWin VS2010 build fix.

WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:

5:51 PM Changeset in webkit [147265] by commit-queue@webkit.org

5 edits
2 adds in trunk/Source/WebCore

When releasing a CGImage, we should also remove it from the subimage cache.
https://bugs.webkit.org/show_bug.cgi?id=102453

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-03-29
Reviewed by Simon Fraser.

When we release an image(CGImageRef) from BitmapImage's cachedFrames, if the image was already
cached in subimage cache, it's ref count won't drop to 0 and the image won't be deleted. Usually,
the subimage cache will clear the whole cache in a timer with 1 sec delay. However, if WebCore has
to paint another subimage (not necessarily from the same CGImageRef) before this timer fires, we
will restart the timer and images inside the cache will stay longer than they should.

This patch does two things:

move SubimageCacheWithTimer and related helper struct into a separate file.
remove the image from subimage cache when we releasing the CGImageRef, this prevent subimage

cache holding the image after we released it.

No new tests, manually verified the CGImageRef is also removed from subimage cache
when we releasing the image from FrameData::clear.

WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::FrameData::clear): remove the image from subimage cache before we releasing it.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore):
(WebCore::GraphicsContext::drawNativeImage):

platform/graphics/cg/SubimageCacheWithTimer.cpp: Added.

(WebCore):
(SubimageRequest):
(WebCore::SubimageRequest::SubimageRequest):
(WebCore::SubimageCacheAdder::hash):
(SubimageCacheAdder):
(WebCore::SubimageCacheAdder::equal):
(WebCore::SubimageCacheAdder::translate):
(WebCore::SubimageCacheWithTimer::SubimageCacheWithTimer):
(WebCore::SubimageCacheWithTimer::invalidateCacheTimerFired):
(WebCore::SubimageCacheWithTimer::getSubimage):
(WebCore::SubimageCacheWithTimer::clearImage):
(WebCore::subimageCache):

platform/graphics/cg/SubimageCacheWithTimer.h: Added.

(WebCore):
(SubimageCacheWithTimer): Added a data member m_images to record which image and its subimages are cached.
(SubimageCacheEntry):
(SubimageCacheEntryTraits):
(WebCore::SubimageCacheWithTimer::SubimageCacheEntryTraits::isEmptyValue):
(WebCore::SubimageCacheWithTimer::SubimageCacheEntryTraits::constructDeletedValue):
(WebCore::SubimageCacheWithTimer::SubimageCacheEntryTraits::isDeletedValue):
(WebCore::SubimageCacheWithTimer::SubimageCacheHash::hash):
(WebCore::SubimageCacheWithTimer::SubimageCacheHash::equal):
(SubimageCacheHash):

5:19 PM Changeset in webkit [147264] by fpizlo@apple.com

4 edits
2 adds in branches/dfgFourthTier

fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
https://bugs.webkit.org/show_bug.cgi?id=113452

Rubber stamped by Mark Hahnenberg.

Tools:

Scripts/copy-webkitlibraries-to-product-directory:
Scripts/export-llvm-build:

WebKitLibraries:

LLVMIncludesMountainLion.tar.bz2: Added.
LLVMLibrariesMountainLion.tar.bz2: Added.

5:04 PM Changeset in webkit [147263] by aestes@apple.com

2 edits in trunk/Source/WebCore

Let cached resources from file: schemes expire immediately
https://bugs.webkit.org/show_bug.cgi?id=113626

Reviewed by Brady Eidson

When a CachedResource was loaded from a file: URL, we would give it an
indefinite freshness lifetime. This means that we would continue to
serve a stale resource from the memory cache even if the file was
changed on disk. With the introduction of main resource caching, this
behavior broke at least one third-party WebKit app (see <rdar://problem/13313769>).

We should instead let file resources expire immediately. Modern
filesystems implement their own caching, so we should get good
performance for multiple reads of unmodified files without doing our
own caching.

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::freshnessLifetime): file: URLs should have a
0 freshness lifetime.

4:41 PM Changeset in webkit [147262] by Lucas Forschler

4 edits in tags/Safari-537.35.4/Source/WebKit2

Merged r147257. <rdar://problem/13531679>

4:32 PM Changeset in webkit [147261] by ojan@chromium.org

20 edits
2 deletes in trunk

Source/WebCore: Flexitems no longer default min-width to min-content
https://bugs.webkit.org/show_bug.cgi?id=111790

Reviewed by Tony Chang.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
Disallow auto as a valid min-size value.

css/html.css:

(input::-webkit-datetime-edit):
(input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container):
(input[type="range"]::-webkit-slider-runnable-track):
Remove now unnecessary min-width: 0's.

css/mediaControlsChromium.css:

(audio::-webkit-media-controls-enclosure, video::-webkit-media-controls-enclosure):
(video::-webkit-media-controls-enclosure):
Set a flex-shrink: 0 to avoid shrinking these items below the designated height.

rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalHeightByMinMax):
(WebCore::RenderBox::constrainContentBoxLogicalHeightByMinMax):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computeContentLogicalHeight):
(WebCore::RenderBox::computeContentAndScrollbarLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
Remove all the unneeded SizeType arguments now that we don't need to
specially handle MinSize in all these functions.

rendering/RenderBox.h:
rendering/RenderButton.cpp:

(WebCore::RenderButton::styleWillChange):
(WebCore::RenderButton::setupInnerStyle):
No longer need to explicitly set min-width:0.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
Remove the code for specially handling auto.

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength):

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::maxPageLogicalHeight):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
Remove all the now unneeded SizeType arguments.

rendering/style/RenderStyle.h:

Change the default min-size back to 0.

Source/WebKit2: Crash when "willSendRequest" causes the ResourceLoader to be cancelled.
<rdar://problem/13531679> and https://bugs.webkit.org/show_bug.cgi?id=113616

Patch by Brady Eidson <beidson@apple.com> on 2013-03-29
Reviewed by Alexey Proskuryakov.

These callbacks to the WebCore ResourceLoader can cause the WebResourceLoader to be destroyed.
A RefPtr<> protector fixes that.

Additionally we can invalidate the WebResourceLoader to avoid unnecessary callbacks to the NetworkProcess.

WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::remove): Call detachFromCoreLoader() on a removed WebResourceLoader.

WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::detachFromCoreLoader): Clear out the ResourceLoader pointer.
(WebKit::WebResourceLoader::willSendRequest): Protect this, and don't message back to the NetworkProcess if its not needed.
(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace): Ditto
(WebKit::WebResourceLoader::didReceiveResource): Paranoid hardening - Protect this before delivering the data to the WebCore

ResourceLoader, and null check it before delivering the "didFinishLoader" call.

WebProcess/Network/WebResourceLoader.h:

LayoutTests: Flexitems no longer default min-width to min-content
https://bugs.webkit.org/show_bug.cgi?id=111790

Reviewed by Tony Chang.

css3/flexbox/content-height-with-scrollbars.html:
css3/flexbox/cross-axis-scrollbar.html:

Set flex:none to avoid flex-shrinking.

css3/flexbox/flex-item-min-size-expected.txt: Removed.
css3/flexbox/flex-item-min-size.html: Removed.

These tests are now redundant with tests in fast/css-intrinsic-dimensions.

css3/flexbox/flexbox-baseline.html:

Set flex:none to avoid flex-shrinking.

css3/flexbox/line-wrapping.html:

Auto-size the flex items so that the column flexboxes have an auto-height.

css3/flexbox/preferred-widths.html:

Set flex:none to avoid flex-shrinking.

fast/css/auto-min-size-expected.txt:
fast/css/auto-min-size.html:

Update to no longer allow parsing auto as a valid value for min-width/min-height.

4:30 PM Changeset in webkit [147260] by ap@apple.com

15 edits in trunk

Expose FeatureObserver data to WebKit clients
https://bugs.webkit.org/show_bug.cgi?id=113613

Reviewed by Sam Weinig.

FeatureObserver used to depend on chromium-only HistogramSupport, which is not
really usable on Mac at least.

Instead of adding parallel feature reporting machinery, I'm adding a way to
generically relay the data from FeatureObserver to port code.

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::reportMemoryUsage):
loader/FrameLoader.h: (WebCore::FrameLoader::previousURL): Exposed m_previousURL, renaming it to follow WebKit style.

page/FeatureObserver.cpp: (WebCore::FeatureObserver::~FeatureObserver): (WebCore::FeatureObserver::updateMeasurements):
page/FeatureObserver.h: (WebCore::FeatureObserver::accumulatedFeatureBits): Exposed the data to clients, and made reporting through HistogramSupport chromium only for clarity.

4:28 PM Changeset in webkit [147259] by fpizlo@apple.com

16 edits
14 adds in branches/dfgFourthTier

fourthTier: FTL JIT should be able run some simple function
https://bugs.webkit.org/show_bug.cgi?id=113481

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

This is the initial version of the FTL JIT (Fourth Tier LLVM JIT).
It includes a lowering from the DFG IR to LLVM IR (FTL::lowerDFGToLLVM)
and a "backend" step that invokes the LLVM and wraps the resulting
function in a thunk (FTL::compile).

All LLVM IR building functions are wrapped up into a nicer FTL API.
First they're wrapped in an abbreviated API (FTLAbbreviations.h) and
then again into an object-oriented IR builder (FTLOutput.h).

This runs things. I don't know how fast it runs things. And I don't
make any claims of stability. The FTL is runtime-disabled by default;
you will enable it by doing --useExperimentalFTL=true. Probably if you
do this, you will run slower, because of the heavy thunking we do, the
fact that we don't have anything resembling a sensible tiering story,
and because we only compile ridiculously tiny functions.

Finally, this still requires a custom set of LLVM headers to build.
I am working on getting that up-streamed to LLVM, and separately I'll
make sure that we have a build checked into this branch.

Configurations/JavaScriptCore.xcconfig:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/Operands.h:

(Operands):
(JSC::Operands::Operands):

dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::needsTypeCheck):
(AbstractState):
(JSC::DFG::AbstractState::filterEdgeByUse):

dfg/DFGDriver.cpp:

(JSC::DFG::compile):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::needsTypeCheck):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(DFG):

dfg/DFGUseKind.h:

(JSC::DFG::shouldNotHaveTypeCheck):
(DFG):
(JSC::DFG::mayHaveTypeCheck):
(JSC::DFG::isDouble):
(JSC::DFG::isCell):

ftl: Added.
ftl/FTLAbbreviations.h: Added.

(FTL):
(JSC::FTL::int1Type):
(JSC::FTL::int32Type):
(JSC::FTL::int64Type):
(JSC::FTL::intPtrType):
(JSC::FTL::pointerType):
(JSC::FTL::getParam):
(JSC::FTL::constInt):
(JSC::FTL::appendBasicBlock):
(JSC::FTL::insertBasicBlock):
(JSC::FTL::buildAlloca):
(JSC::FTL::buildAdd):
(JSC::FTL::buildAnd):
(JSC::FTL::buildXor):
(JSC::FTL::buildLoad):
(JSC::FTL::buildStore):
(JSC::FTL::buildZExt):
(JSC::FTL::buildIntCast):
(JSC::FTL::buildIntToPtr):
(JSC::FTL::buildPtrToInt):
(JSC::FTL::buildICmp):
(JSC::FTL::buildSelect):
(JSC::FTL::buildBr):
(JSC::FTL::buildCondBr):
(JSC::FTL::buildRet):
(JSC::FTL::buildUnreachable):

ftl/FTLCapabilities.cpp: Added.

(FTL):
(JSC::FTL::canCompile):

ftl/FTLCapabilities.h: Added.

(FTL):

ftl/FTLCompile.cpp: Added.

(FTL):
(JSC::FTL::compileEntry):
(JSC::FTL::compile):

ftl/FTLCompile.h: Added.

(FTL):

ftl/FTLJITCode.cpp: Added.

(FTL):
(JSC::FTL::JITCode::JITCode):
(JSC::FTL::JITCode::~JITCode):
(JSC::FTL::JITCode::addressForCall):
(JSC::FTL::JITCode::executableAddressAtOffset):
(JSC::FTL::JITCode::dataAddressAtOffset):
(JSC::FTL::JITCode::offsetOf):
(JSC::FTL::JITCode::size):
(JSC::FTL::JITCode::contains):

ftl/FTLJITCode.h: Added.

(FTL):
(JITCode):

ftl/FTLLLVMHeaders.h: Added.
ftl/FTLLowerDFGToLLVM.cpp: Added.

(FTL):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::addFlushedLocalOpRoots):
(JSC::FTL::LowerDFGToLLVM::closeOverFlushedLocalOps):
(JSC::FTL::LowerDFGToLLVM::addFlushedLocalOp):
(JSC::FTL::LowerDFGToLLVM::addFlushedLocalEdge):
(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileJSConstant):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileMovHintAndCheck):
(JSC::FTL::LowerDFGToLLVM::compilePhantom):
(JSC::FTL::LowerDFGToLLVM::compileReturn):
(JSC::FTL::LowerDFGToLLVM::speculateBackward):
(JSC::FTL::LowerDFGToLLVM::speculateForward):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::terminate):
(JSC::FTL::LowerDFGToLLVM::backwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::forwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::typeCheck):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::checkNotInt32):
(JSC::FTL::LowerDFGToLLVM::unboxInt32):
(JSC::FTL::LowerDFGToLLVM::boxInt32):
(JSC::FTL::LowerDFGToLLVM::checkNotCell):
(JSC::FTL::LowerDFGToLLVM::checkNotBoolean):
(JSC::FTL::LowerDFGToLLVM::unboxBoolean):
(JSC::FTL::LowerDFGToLLVM::boxBoolean):
(JSC::FTL::LowerDFGToLLVM::speculateInt32):
(JSC::FTL::LowerDFGToLLVM::addressFor):
(JSC::FTL::LowerDFGToLLVM::payloadFor):
(JSC::FTL::LowerDFGToLLVM::tagFor):
(JSC::FTL::LowerDFGToLLVM::globalData):
(JSC::FTL::LowerDFGToLLVM::codeBlock):
(JSC::FTL::lowerDFGToLLVM):

ftl/FTLLowerDFGToLLVM.h: Added.

(FTL):

ftl/FTLOutput.h: Added.

(FTL):
(Output):
(JSC::FTL::Output::Output):
(JSC::FTL::Output::~Output):
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::appendTo):
(JSC::FTL::Output::newBlock):
(JSC::FTL::Output::param):
(JSC::FTL::Output::constBool):
(JSC::FTL::Output::constInt32):
(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::constInt64):
(JSC::FTL::Output::add):
(JSC::FTL::Output::bitAnd):
(JSC::FTL::Output::bitXor):
(JSC::FTL::Output::zeroExt):
(JSC::FTL::Output::intCast):
(JSC::FTL::Output::castToInt32):
(JSC::FTL::Output::get):
(JSC::FTL::Output::set):
(JSC::FTL::Output::load):
(JSC::FTL::Output::store):
(JSC::FTL::Output::load32):
(JSC::FTL::Output::load64):
(JSC::FTL::Output::loadPtr):
(JSC::FTL::Output::store32):
(JSC::FTL::Output::store64):
(JSC::FTL::Output::storePtr):
(JSC::FTL::Output::equal):
(JSC::FTL::Output::notEqual):
(JSC::FTL::Output::above):
(JSC::FTL::Output::aboveOrEqual):
(JSC::FTL::Output::below):
(JSC::FTL::Output::belowOrEqual):
(JSC::FTL::Output::greaterThan):
(JSC::FTL::Output::greaterThanOrEqual):
(JSC::FTL::Output::lessThan):
(JSC::FTL::Output::lessThanOrEqual):
(JSC::FTL::Output::isZero64):
(JSC::FTL::Output::notZero64):
(JSC::FTL::Output::testNonZero64):
(JSC::FTL::Output::select):
(JSC::FTL::Output::jump):
(JSC::FTL::Output::branch):
(JSC::FTL::Output::ret):
(JSC::FTL::Output::unreachable):

ftl/FTLState.h: Added.

(FTL):
(State):
(JSC::FTL::State::State):

runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

runtime/Options.h:

(JSC):

Source/WTF:

Reviewed by Geoffrey Garen.

wtf/Platform.h:

Tools:

Reviewed by Geoffrey Garen.

Give the scripts the ability to find an LLVM build and use it.

Also added a script, export-llvm-build, that allows you to take your
own build of LLVM and package it for use by WebKit's build system.

The build system treats a "build" of LLVM as a pair of .tar.bz2's,
one for the library archives and one for the headers. It then unpacks
them into your built products directory in a mannner that is mostly
analogous to how WebKitSystemInterface works.

Scripts/build-jsc:
Scripts/copy-webkitlibraries-to-product-directory:

(unpackIfNecessary):
(dittoHeaders):

Scripts/export-llvm-build: Added.

4:24 PM Changeset in webkit [147258] by dgrogan@chromium.org

1 edit in branches/chromium/1453/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp

Merge 146950 "IndexedDB: Histogram cause of LevelDB write errors"

IndexedDB: Histogram cause of LevelDB write errors
https://bugs.webkit.org/show_bug.cgi?id=113350

Reviewed by Tony Chang.

Add histogram for source of LevelDB errors on Write in addition to
Open.

No new tests - no good way to test histogram code.

platform/leveldb/LevelDBDatabase.cpp:
(WebCore::histogramLevelDBError):
(WebCore):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::write):

TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/13171005

4:02 PM Changeset in webkit [147257] by beidson@apple.com

4 edits in trunk/Source/WebKit2

Crash when "willSendRequest" causes the ResourceLoader to be cancelled.
<rdar://problem/13531679> and https://bugs.webkit.org/show_bug.cgi?id=113616

Reviewed by Alexey Proskuryakov.

These callbacks to the WebCore ResourceLoader can cause the WebResourceLoader to be destroyed.
A RefPtr<> protector fixes that.

Additionally we can invalidate the WebResourceLoader to avoid unnecessary callbacks to the NetworkProcess.

WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::remove): Call detachFromCoreLoader() on a removed WebResourceLoader.

WebProcess/Network/WebResourceLoader.cpp:

ResourceLoader, and null check it before delivering the "didFinishLoader" call.

WebProcess/Network/WebResourceLoader.h:

3:32 PM Changeset in webkit [147256] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r191432. Requested by
"Philip Rogers" <pdr@google.com> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-29

DEPS:

3:18 PM Changeset in webkit [147255] by acolwell@chromium.org

1 edit
4 adds in trunk/LayoutTests

Add LayoutTests that verify MediaSource.duration behavior.
https://bugs.webkit.org/show_bug.cgi?id=113438

Reviewed by Eric Carlson.

http/tests/media/media-source/video-media-source-duration-boundaryconditions-expected.txt: Added.
http/tests/media/media-source/video-media-source-duration-boundaryconditions.html: Added.
http/tests/media/media-source/video-media-source-duration-expected.txt: Added.
http/tests/media/media-source/video-media-source-duration.html: Added.

3:10 PM Changeset in webkit [147254] by jsbell@chromium.org

4 edits in trunk/LayoutTests

[Chromium] IndexedDB: Update terminated worker connection test
https://bugs.webkit.org/show_bug.cgi?id=113608

Reviewed by Tony Chang.

Update layout test only run under Chromium's content_shell that ensures that
worker termination does not result in stuck connections. The test was using
the obsolete setVersion() API.

storage/indexeddb/pending-version-change-stuck-works-with-terminate-expected.txt:
storage/indexeddb/pending-version-change-stuck-works-with-terminate.html:
storage/indexeddb/resources/pending-version-change-stuck.js:

(test.request.onblocked):
(test):

2:56 PM Changeset in webkit [147253] by beidson@apple.com

2 edits in trunk/Source/WebKit2

Should never send events to plugins waiting on asynchronous initialization.
<rdar://problem/13538945> and https://bugs.webkit.org/show_bug.cgi?id=113612

Reviewed by Anders Carlsson.

Sending mouse and keyboard events to a plugin in the middle of asynchronous initialization is silly.

A quick audit of the sendSync() messages in PluginProxy suggests the following 8 can just have an early return:

WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::handleMouseEvent):
(WebKit::PluginProxy::handleWheelEvent):
(WebKit::PluginProxy::handleMouseEnterEvent):
(WebKit::PluginProxy::handleMouseLeaveEvent):
(WebKit::PluginProxy::handleKeyboardEvent):
(WebKit::PluginProxy::handleEditingCommand):
(WebKit::PluginProxy::isEditingCommandEnabled):
(WebKit::PluginProxy::handlesPageScaleFactor):

2:37 PM Changeset in webkit [147252] by mhahnenberg@apple.com

5 edits in trunk/Source/JavaScriptCore

Objective-C API: Remove -[JSManagedValue managedValueWithValue:owner:]
https://bugs.webkit.org/show_bug.cgi?id=113602

Reviewed by Geoffrey Garen.

Since we put the primary way of keeping track of external object graphs (i.e. "managed" references)
in JSVirtualMachine, there is some overlap in the functionality of that interface and JSManagedValue.
Specifically, we no longer need the methods that include an owner, since ownership is now tracked
by JSVirtualMachine. These JSManagedValues will become weak pointers unless they are used
with [JSVirtualMachine addManagedReference:withOwner:], in which case their lifetime is tied to that
of their owner.

API/JSManagedValue.h:
API/JSManagedValue.mm:

(-[JSManagedValue init]):
(-[JSManagedValue initWithValue:]):
(JSManagedValueHandleOwner::isReachableFromOpaqueRoots):

API/JSVirtualMachine.mm:

(getInternalObjcObject):

API/tests/testapi.mm:

(-[TextXYZ setOnclick:]):
(-[TextXYZ dealloc]):

2:32 PM Changeset in webkit [147251] by beidson@apple.com

7 edits in trunk/Source/WebKit2

"Empty cache..." clears the disk cache from each WebProcess.
<rdar://problem/12456652> and https://bugs.webkit.org/show_bug.cgi?id=113603

Reviewed by Sam Weinig.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::terminate): Override ChildProcess::terminate to allow us to finish clearing the cache.

NetworkProcess/NetworkProcess.h:

NetworkProcess/NetworkProcess.messages.in: Add the ClearCacheForAllOrigins message.

NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::clearCacheForAllOrigins): Clear the disk cache.
(WebKit::NetworkProcess::platformTerminate): Wait for the clear to complete.

UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins): Message the network process, also.

WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformClearResourceCaches): Don't clear the disk cache if we use the network process.

2:13 PM Changeset in webkit [147250] by commit-queue@webkit.org

5 edits
2 adds in trunk

[CSS Exclusions] shape outside segments not properly calculated for ellipses
https://bugs.webkit.org/show_bug.cgi?id=112587

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-29
Reviewed by Julien Chaffraix.

Source/WebCore:

When converting the line top coordinates from the parent's coordinate
space to the coordinate space of the float, the offset given by the
shape was not being accounted for. This patch accounts for that
offset.

Test: fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalLeftOffsetForLine): Fix the coordinate conversion.
(WebCore::RenderBlock::logicalRightOffsetForLine): Ditto.

rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Ditto.

LayoutTests:

Check that shapes with a non-zero y value are properly wrapped.

fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html: Added.
fast/exclusions/resources/rounded-rectangle.js:

(generateSimulatedShapeOutsideOnFloat): For simulating, we ignore the
x and y values, since we're not attempting to draw the float's content
in the right place, we just want to simulate the shape's effect.

1:34 PM Changeset in webkit [147249] by hmuller@adobe.com

4 edits
4 adds in trunk

[CSS Exclusions] Incorrect margin corner radii formula
https://bugs.webkit.org/show_bug.cgi?id=111186

Reviewed by Dirk Schulze.

Source/WebCore:

Corrected an error in the forumla for the margin ellipse's radii.

Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html

fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html

rendering/ExclusionRectangle.cpp:

(WebCore::FloatRoundedRect::marginBounds):

LayoutTests:

fast/exclusions/resources/subpixel-utils.js:

(SubPixelLayout): Added an initSubPixelLayout() function so that inline test code doesn't have to wait until the DOMContentLoaded event.

fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left-expected.txt: Added.
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html: Added.
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right-expected.txt: Added.
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html: Added.

1:26 PM Changeset in webkit [147248] by Lucas Forschler

4 edits in tags/Safari-537.35.4/Source/WebKit2

Merged r147179. <rdar://problem/13479890>

1:24 PM Changeset in webkit [147247] by Lucas Forschler

2 edits in tags/Safari-537.35.4/Source/WebKit2

Merged r147010. <rdar://problem/13479890>

1:22 PM Changeset in webkit [147246] by Lucas Forschler

5 edits
2 copies in tags/Safari-537.35.4/Source/WebKit2

Merged r147006. <rdar://problem/13479890>

1:12 PM Changeset in webkit [147245] by ojan@chromium.org

13 edits
2 adds in trunk

min-width/max-width of min-content/max-content don't work correctly if width is specified
https://bugs.webkit.org/show_bug.cgi?id=106143

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-intrinsic-dimensions/intrinsic-sized-blocks.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeIntrinsicLogicalWidths):
Expose this so that we don't use the preferred widths when calculating intrinsic width
values since the preferred width will be the regular width value if it is set.
Also, simplified the logic around table cells and scrollbar widths. The old code was
wrong and unnecessarily complicated.

(WebCore::RenderBlock::computePreferredLogicalWidths):
Use the new computeIntrinsicLogicalWidths method.

(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
Pass in the min/max values as out params so they can be called from computeIntrinsicLogicalWidths.
Also, make computeBlockPreferredLogicalWidths const.

rendering/RenderBlock.h:

LayoutTests:

css3/flexbox/box-sizing.html:

The old result was incorrectly using the preferred width as the min-content width of the flex items.
The new result is correctly resolving the min-content width to 0 and allowing the flex items to shrink.

fast/css-intrinsic-dimensions/intrinsic-sized-blocks-expected.txt: Added.
fast/css-intrinsic-dimensions/intrinsic-sized-blocks.html: Added.
platform/chromium-win/fast/table/overflowHidden-expected.txt:

The new result correctly adds the scrollbar width to the table cell intrinsic width.
The pixel result doesn't need ot be updated because the elements that changed are below
the fold, so they don't show up in the png.

platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:

Add tests that will need rebaselines.

scrollbars/custom-scrollbar-table-cell-expected.png:

The new result correctly adds the scrollbar width to the table cell intrinsic width.

12:56 PM Changeset in webkit [147244] by jsbell@chromium.org

2 edits in trunk/Source/WebCore

IndexedDB: Use WTF::TemporaryChange rather than manually resetting a flag
https://bugs.webkit.org/show_bug.cgi?id=113594

Reviewed by Tony Chang.

Split out from another patch: rather than m_foo = true; ... m_foo = false; use
the handy WTF::TemporaryChange scoped variable change doohickey.

Test: http/tests/inspector/indexeddb/database-structure.html

Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::close):

12:51 PM Changeset in webkit [147243] by timothy@apple.com

2 edits in trunk/LayoutTests

Marking animation-delay-changed.html and reinserting-svg-into-document.html as flaky.

https://webkit.org/b/113598
https://webkit.org/b/113599

Unreviewed.

platform/mac/TestExpectations:

12:49 PM Changeset in webkit [147242] by Lucas Forschler

21 edits in tags/Safari-537.35.4/Source

Merged r146544. <rdar://problem/13479890>

12:36 PM Changeset in webkit [147241] by jsbell@chromium.org

3 edits
2 adds in trunk

[V8] IndexedDB: Exceptions thrown inconsistently for non-cloneable values
https://bugs.webkit.org/show_bug.cgi?id=113091

Reviewed by Kentaro Hara.

Source/WebCore:

The exception thrown by SerializedScriptValue into the JS engine is not
observable by ScriptState. (We should fix that, but it appears non-trivial.)
Ask the SerializedScriptValue directly if it failed to clone. If so, don't
set an exception - one was already set so let that be processed normally.

Test: storage/indexeddb/clone-exception.html

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):

LayoutTests:

storage/indexeddb/clone-exception-expected.txt: Added.
storage/indexeddb/clone-exception.html: Added.

12:31 PM Changeset in webkit [147240] by dino@apple.com

3 edits in trunk/Source/WebCore

Snapshotted plugins must be able to restart on appropriate mouseup events
https://bugs.webkit.org/show_bug.cgi?id=113577

Reviewed by Tim Horton.

If the page content prevents the default behaviour of a mousedown event, then a snapshotted
plugin would never receive a click event, and thus be unable to restart. We have to also
look for a mouseup that happens with an associated mousedown, and trigger restart. This
won't call any page code - it's just behind the scenes.

rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): Initialize new member variable.
(WebCore::RenderSnapshottedPlugIn::handleEvent): Track the state of mousedown and up pairs, and restart

if you see an appropriate mouseup.

rendering/RenderSnapshottedPlugIn.h: New member variable to track mouse state.

12:27 PM Changeset in webkit [147239] by Martin Robinson

110 edits
853 adds in trunk/Source/ThirdParty

Update the version of gyp in the repository
https://bugs.webkit.org/show_bug.cgi?id=113540

Reviewed by Nico Weber.

gyp: Update gyp to r1605.

12:26 PM Changeset in webkit [147238] by Simon Fraser

2 edits in trunk/Source/WebCore

removeViewportConstrainedLayer() should remove the layer from m_viewportConstrainedLayersNeedingUpdate too
https://bugs.webkit.org/show_bug.cgi?id=113596

Reviewed by Tim Horton.

It's possible, with some combination of position:fixed and opacity transitions
in iframes, to end up with a RenderLayer in m_viewportConstrainedLayersNeedingUpdate
that has been removed from m_viewportConstrainedLayers, which leads to later assertions
and/or crashes.

Fix by removing a layer from m_viewportConstrainedLayersNeedingUpdate when we
remove it from m_viewportConstrainedLayers.

I was not able to come up with a testcase that reliably reproduces this.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::removeViewportConstrainedLayer):

12:22 PM Changeset in webkit [147237] by Lucas Forschler

19 edits in tags/Safari-537.35.4

Merged r146704. <rdar://problem/13337564>

12:14 PM Changeset in webkit [147236] by commit-queue@webkit.org

20 edits in trunk

Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
https://bugs.webkit.org/show_bug.cgi?id=112276

Patch by Greg Hughes <ghughes@apple.com> on 2013-03-29
Reviewed by Chris Fleizach.

Source/WebCore:

Added support for accessibility search predicates to accept multiple search keys. The search will return the first item that matches any one of the provided search keys.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore):

accessibility/AccessibilityObject.h:

(AccessibilitySearchCriteria):
(WebCore::AccessibilitySearchCriteria::AccessibilitySearchCriteria):
(AccessibilityObject):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Tools:

Added support to test accessibility search predicates with multiple keys.

DumpRenderTree/AccessibilityUIElement.cpp:

(uiElementForSearchPredicateCallback):

DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement):

DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: