⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 3, 2013:

11:02 PM Changeset in webkit [147612] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

11:00 PM Changeset in webkit [147611] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.8/Source

Versioning.

10:57 PM Changeset in webkit [147610] by Lucas Forschler
  • 1 copy in tags/Safari-537.35.8

New Tag.

10:55 PM Changeset in webkit [147609] by fpizlo@apple.com
  • 29 edits
    4 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: put DFG data into a DFG::JITCode, and put common DFG and FTL data into something accessible from both DFG::JITCode and FTL::JITCode
​https://bugs.webkit.org/show_bug.cgi?id=113905

Reviewed by Geoffrey Garen.

This removes one pointer from CodeBlock.

It also gives us a framework for having JITType-specific data in CodeBlock, by
putting it into the appropriate JITCode class (either DFG::JITCode or
FTL::JITCode). And it allows us to have DFG and FTL share some common data,
via DFG::CommonData, which is stored in both DFG::JITCode and FTL::JITCode and
always accessible via JITCode::dfgCommon().

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::performTracingFixpointIteration):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitWeakReferences):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::tallyFrequentExitSites):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan):
(JSC::DFGCodeBlocks::mark):

  • dfg/DFGAssemblyHelpers.h:
  • dfg/DFGCommonData.cpp: Added.

(DFG):
(JSC::DFG::CommonData::notifyCompilingStructureTransition):
(JSC::DFG::CommonData::shrinkToFit):

  • dfg/DFGCommonData.h: Added.

(JSC):
(DFG):
(JSC::DFG::WeakReferenceTransition::WeakReferenceTransition):
(WeakReferenceTransition):
(CommonData):
(JSC::DFG::CommonData::CommonData):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

  • dfg/DFGDriver.h:

(DFG):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGJITCode.cpp: Added.

(DFG):
(JSC::DFG::JITCode::JITCode):
(JSC::DFG::JITCode::~JITCode):
(JSC::DFG::JITCode::dfgCommon):
(JSC::DFG::JITCode::dfg):
(JSC::DFG::JITCode::shrinkToFit):

  • dfg/DFGJITCode.h: Added.

(DFG):
(JITCode):
(JSC::DFG::JITCode::appendOSREntryData):
(JSC::DFG::JITCode::osrEntryDataForBytecodeIndex):
(JSC::DFG::JITCode::appendOSRExit):
(JSC::DFG::JITCode::lastOSRExit):
(JSC::DFG::JITCode::appendSpeculationRecovery):
(JSC::DFG::JITCode::appendWatchpoint):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(JITCompiler):
(JSC::DFG::JITCompiler::addWeakReference):
(JSC::DFG::JITCompiler::noticeOSREntry):
(JSC::DFG::JITCompiler::jitCode):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::backwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableEventStream.cpp:
  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::JITCode):
(JSC::FTL::JITCode::~JITCode):
(FTL):
(JSC::FTL::JITCode::initializeCode):
(JSC::FTL::JITCode::addressForCall):
(JSC::FTL::JITCode::executableAddressAtOffset):
(JSC::FTL::JITCode::dataAddressAtOffset):
(JSC::FTL::JITCode::offsetOf):
(JSC::FTL::JITCode::size):
(JSC::FTL::JITCode::contains):
(JSC::FTL::JITCode::ftl):
(JSC::FTL::JITCode::dfgCommon):

  • ftl/FTLJITCode.h:

(JITCode):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileStructureTransitionWatchpoint):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compilePhantomPutStructure):
(JSC::FTL::LowerDFGToLLVM::addWeakReference):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::weakPointer):

  • ftl/FTLState.cpp:

(FTL):
(JSC::FTL::State::State):
(JSC::FTL::State::dumpState):

  • ftl/FTLState.h:

(State):

  • heap/DFGCodeBlocks.cpp:

(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::clearMarks):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):
(JSC::DFGCodeBlocks::traceMarkedCodeBlocks):

  • jit/JITCode.cpp:

(JSC::JITCode::dfgCommon):
(JSC):
(JSC::JITCode::dfg):
(JSC::JITCode::ftl):
(JSC::DirectJITCode::DirectJITCode):
(JSC::DirectJITCode::initializeCodeRef):
(JSC::DirectJITCode::addressForCall):
(JSC::DirectJITCode::executableAddressAtOffset):
(JSC::DirectJITCode::dataAddressAtOffset):
(JSC::DirectJITCode::offsetOf):
(JSC::DirectJITCode::size):
(JSC::DirectJITCode::contains):

  • jit/JITCode.h:

(DFG):
(FTL):
(JSC):
(JITCode):
(DirectJITCode):

10:09 PM Changeset in webkit [147608] by fpizlo@apple.com
  • 4 edits in branches/dfgFourthTier

fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
​https://bugs.webkit.org/show_bug.cgi?id=113921

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The LLVM community wants us to continue including all of LLVM's C++ headers. Change
to using #pragma's to disable warnings that they cannot handle.

  • ftl/FTLLLVMHeaders.h:

Tools:

Reviewed by Oliver Hunt.

The LLVM community wants us to continue including all of LLVM's C++ headers. Change
the export script to do this.

  • Scripts/export-llvm-build:
8:52 PM Changeset in webkit [147607] by gyuyoung.kim@samsung.com
  • 27 edits in trunk

[EFL] Add a decoration image to search input field
​https://bugs.webkit.org/show_bug.cgi?id=113552

Reviewed by Laszlo Gombos.

Source/WebCore:

Though EFL port has a decoration image for search input field, we didn't use it.
Start to show it.

Tests: fast/forms/search-cancel-button-style-sharing.html

fast/forms/search-rtl.html
fast/css/input-search-padding.html
fast/css/text-input-with-webkit-border-radius.html
fast/css/text-overflow-input.html
fast/forms/box-shadow-override.html
fast/forms/control-restrict-line-height.html
fast/forms/input-appearance-height.html
fast/forms/placeholder-position.html
fast/forms/placeholder-pseudo-style.html
fast/forms/search-styled.html
fast/forms/search-vertical-alignment.html
fast/forms/searchfield-heights.html
fast/repaint/search-field-cancel.html
fast/replaced/width100percent-searchfield.html

  • platform/efl/RenderThemeEfl.cpp:

(WebCore):
(WebCore::RenderThemeEfl::supportsDataListUI):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):

LayoutTests:

Rebaseline related to input search field.

  • platform/efl/fast/css/input-search-padding-expected.png:
  • platform/efl/fast/css/input-search-padding-expected.txt:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/efl/fast/css/text-overflow-input-expected.png:
  • platform/efl/fast/css/text-overflow-input-expected.txt:
  • platform/efl/fast/forms/box-shadow-override-expected.png:
  • platform/efl/fast/forms/box-shadow-override-expected.txt:
  • platform/efl/fast/forms/control-restrict-line-height-expected.png:
  • platform/efl/fast/forms/control-restrict-line-height-expected.txt:
  • platform/efl/fast/forms/input-appearance-height-expected.png:
  • platform/efl/fast/forms/input-appearance-height-expected.txt:
  • platform/efl/fast/forms/placeholder-position-expected.png:
  • platform/efl/fast/forms/placeholder-position-expected.txt:
  • platform/efl/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/efl/fast/forms/searchfield-heights-expected.png:
  • platform/efl/fast/forms/searchfield-heights-expected.txt:
  • platform/efl/fast/repaint/search-field-cancel-expected.png:
  • platform/efl/fast/repaint/search-field-cancel-expected.txt:
  • platform/efl/fast/replaced/width100percent-searchfield-expected.png:
  • platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
7:49 PM Changeset in webkit [147606] by Lucas Forschler
  • 1 copy in tags/Safari-537.36

New Tag.

7:16 PM Changeset in webkit [147605] by gyuyoung.kim@samsung.com
  • 8 edits in trunk/LayoutTests

Unreviewed gardening. Below tests aren't related to bug 87619. It just needs to do rebaseline.

  • platform/efl/TestExpectations:
  • platform/efl/fast/forms/number/number-appearance-rtl-expected.png:
  • platform/efl/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
  • platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
6:52 PM Changeset in webkit [147604] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/LayoutTests

fourthTier: Just linking LLVM into JSC causes all plugin tests to fail
​https://bugs.webkit.org/show_bug.cgi?id=113915

Reviewed by nobody.

This is pretty funny. I don't know, yet, what is going on, but I don't want it to block other work.

  • platform/mac/TestExpectations:
6:39 PM Changeset in webkit [147603] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Re-enable WinEWS tests.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

6:16 PM Changeset in webkit [147602] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Input value/placeholder is not redrawn when the input height grows
​https://bugs.webkit.org/show_bug.cgi?id=113845

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/forms/text/text-height-grow.html

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::styleDidChange):
We need relayout of the inner text element.

LayoutTests:

  • fast/forms/text/text-height-grow-expected.html: Added.
  • fast/forms/text/text-height-grow.html: Added.
6:10 PM Changeset in webkit [147601] by glenn@skynav.com
  • 1 edit
    2 adds in trunk/LayoutTests

[GTK] Unreviewed gardening. Rebaseline after r147588.

  • platform/gtk-wk1/fast/writing-mode: Added.
  • platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
6:02 PM Changeset in webkit [147600] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebCore

Add comment to clarify isStackingContext() in RenderLayer.h
​https://bugs.webkit.org/show_bug.cgi?id=113909

Reviewed by Simon Fraser.

It was not obvious how the implementation of isStackingContext()
was correct, a comment is appropriate here for anyone who reads
this code in the future.

Just a change in comment, no test needed.

  • rendering/RenderLayer.h:
5:58 PM Changeset in webkit [147599] by glenn@skynav.com
  • 16 edits
    1 add
    3 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening. Rebaseline after r147588.

  • platform/chromium-mac-lion/fast/text/international/003-expected.png:
  • platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png:
  • platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.txt:
  • platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac/fast/text/international/003-expected.png:
  • platform/chromium-mac/fast/text/international/003-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium-win/fast/text/international/003-expected.png:
  • platform/chromium-win/fast/text/international/003-expected.txt:
  • platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/text/international/003-expected.txt: Removed.
5:45 PM Changeset in webkit [147598] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Don't try to set the exception port for server connections
​https://bugs.webkit.org/show_bug.cgi?id=113910
<rdar://problem/11248925>

Reviewed by Darin Adler.

Treat a SetExceptionPort message to the server connection as an invalid message.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::receiveSourceEventHandler):

5:05 PM Changeset in webkit [147597] by hmuller@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSS Exclusions] Removed ExclusionShape dead code
​https://bugs.webkit.org/show_bug.cgi?id=113904

Reviewed by Dirk Schulze.

No new tests, just removing dead code.

  • rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape):

  • rendering/ExclusionShape.h:

(ExclusionShape):

4:44 PM Changeset in webkit [147596] by roger_fong@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed. AppleWin port gardening.

  • platform/win/TestExpectations:
  • platform/win/fast/lists/inlineBoxWrapperNullCheck-expected.txt: Added.
4:16 PM Changeset in webkit [147595] by psolanki@apple.com
  • 2 edits in trunk/Source/WTF

Enable HAVE_MADV_FREE_REUSE on iOS
​https://bugs.webkit.org/show_bug.cgi?id=113892
<rdar://problem/12787563>

Reviewed by Mark Rowe.

  • wtf/Platform.h:
3:58 PM Changeset in webkit [147594] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Switch MediaPlayerPrivateBlackBerry.cpp's timer to use CLOCK_MONOTONIC
​https://bugs.webkit.org/show_bug.cgi?id=113900

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2013-04-03
Reviewed by Rob Buis.
Internally Reviewed by Jeff Rogers.

Timers should use CLOCK_MONOTONIC to avoid undesirable effects when
the user switches the system time.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::drawBufferingAnimation):

3:54 PM Changeset in webkit [147593] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<​http://webkit.org/b/113898> Eliminate some code duplication by introducing an array of handlers to register / unregister.

Reviewed by Antti Koivisto.

  • UIProcess/mac/WebContextMac.mm:

(OcclusionNotificationHandler): Structure containing the notification name, type and handler.
(WebKit::registerOcclusionNotificationHandlers): Register all of the handlers in the array.
(WebKit::unregisterOcclusionNotificationHandlers): Unregister all of the handlers in the array.

3:54 PM Changeset in webkit [147592] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Enable process suppression when no windows in the application have drawn recently.
<​http://webkit.org/b/113854> / <rdar://problem/13540351>

Reviewed by Darin Adler.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::applicationWindowModificationsStarted): Note that modifications are no longer stopped.
(WebKit::applicationWindowModificationsStopped): Note that modifications have stopped.
(WebKit::registerOcclusionNotificationHandlers): Register handlers for the start and stop notifications.
(WebKit::unregisterOcclusionNotificationHandlers): Unregister handlers for the start and stop notifications.
(WebKit::WebContext::canEnableProcessSuppressionForNetworkProcess): Allow suppression if the application is occluded
or the application has not drawn recently.
(WebKit::WebContext::canEnableProcessSuppressionForWebProcess): Ditto.
(WebKit::WebContext::canEnableProcessSuppressionForGlobalChildProcesses): Ditto.

3:35 PM Changeset in webkit [147591] by commit-queue@webkit.org
  • 9 edits
    4 adds in trunk

Unable to focus on embedded plugins such as Flash via javascript focus()
​https://bugs.webkit.org/show_bug.cgi?id=32292

Patch by Dave Michael <​dmichael@chromium.org> on 2013-04-03
Reviewed by Ryosuke Niwa.

Source/WebCore:

Make embed, object, and applet elements support focus() when
appropriate. Prior to this patch, javascript focus() had no effect on
embed, object, or applet elements unless tabindex or contenteditable is
set. With this patch, focus() will focus the element unless the plugin
content has failed to load (i.e., we are showing either fallback content
or an unavailable plugin indicator).

Test: plugins/focus.html

java/focus.html

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::supportsFocus):
Overridden to return true except when the plugin content has failed to load.

  • html/HTMLPlugInElement.h:

(WebCore::HTMLPlugInElement::useFallbackContent):
Moved up from HTMLPlugInImageElement.
(WebCore::HTMLPlugInElement::supportsFocus):

  • html/HTMLPlugInElement.h:

(WebCore::HTMLPlugInImageElement::useFallbackContent):
Removed. Now the implementation is inherited from HTMLPlugInElement.

LayoutTests:

Add/update testing to ensure embed, object, and applet tags now support
focus except when plugin content did not load.

  • fast/events/resources/tabindex-focus-blur-all-frame1.html: Change embed and object

elements to reference an invalid plugin, to be consistent with applet. These
element types are not focusable when there is valid plugin content.

  • fast/events/resources/tabindex-focus-blur-all-frame2.html: Same as above.
  • fast/events/resources/tabindex-focus-blur-all-iframe1.html: Same as above.
  • fast/events/resources/tabindex-focus-blur-all-iframe2.html: Same as above.
  • java/focus-expected.txt: Added.
  • java/focus.html: Added.
  • plugins/focus-expected.txt: Added.
  • plugins/focus.html: Added.
3:33 PM Changeset in webkit [147590] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.7/Source

Versioning.

3:18 PM Changeset in webkit [147589] by Lucas Forschler
  • 1 copy in tags/Safari-537.35.7

New Tag.

2:53 PM Changeset in webkit [147588] by glenn@skynav.com
  • 12 edits
    5 adds in trunk

Element boundaries prevent Japanese line break opportunities
​https://bugs.webkit.org/show_bug.cgi?id=105692

Reviewed by Darin Adler.

Source/WebCore:

Introduce use of prior context when using text break iterators
in non-ASCII path through nextBreakablePosition(). This enables
the use of line break context across an element boundary for
the non-ASCII path. Use of this context with the ASCII path was
enabled by ​https://bugs.webkit.org/show_bug.cgi?id=17427.

Performance tests of line layout and html5 parsing show that this
patch provides an approximately 4% improvement with Japanese and
no statistically significant regression with ASCII path. Parsing
(html5-full-render) performance is not significantly affected.

Tests: fast/text/line-break-between-text-nodes-cjk.html

fast/text/line-break-between-text-nodes-latin1.html

Expect rebaselines will be needed due to different line breaks:

fast/text/international/003.html
fast/text/international/text-combine-image-test-expected.html
fast/text/writing-mode/Kusa-Makura-background-canvas.html

  • platform/text/TextBreakIterator.cpp:

(WebCore::acquireLineBreakIterator): Pass prior context to non-ICU path.

  • platform/text/TextBreakIterator.h:

(WebCore::LazyLineBreakIterator::priorContextLength): Added.
(WebCore::LazyLineBreakIterator::get): Pass prior context to ICU path.
(WebCore::LazyLineBreakIterator::resetStringAndReleaseIterator): Editorial.

  • platform/text/TextBreakIteratorICU.cpp:

Use prior context from line break iterators. Requires
adding new UTF16 (UChar*) text provider and reimplementing
Latin1 (LChar*) text provider. Implementation is optimized
by using generic functionality that applies to both string
sources.
(WebCore::textPinIndex): Added.
(WebCore::textNativeLength): Added.
(WebCore::textFixPointer): Added.
(WebCore::textClone): Added.
(WebCore::textExtract): Added.
(WebCore::textClose): Added.
(WebCore::textGetContext): Added.
(WebCore::textLatin1GetCurrentContext): Added.
(WebCore::textLatin1MoveInPrimaryContext): Added.
(WebCore::textLatin1SwitchToPrimaryContext): Added.
(WebCore::textLatin1MoveInPriorContext): Added.
(WebCore::textLatin1SwitchToPriorContext): Added.
(WebCore::textInChunkOrOutOfRange): Added.
(WebCore::textLatin1Access): Added.
(WebCore::textInit): Added.
(WebCore::textOpenLatin1): Added.
(WebCore::textUTF16GetCurrentContext): Added.
(WebCore::textUTF16MoveInPrimaryContext): Added.
(WebCore::textUTF16SwitchToPrimaryContext): Added.
(WebCore::textUTF16MoveInPriorContext): Added.
(WebCore::textUTF16SwitchToPriorContext): Added.
(WebCore::textUTF16Access): Added.
(WebCore::textOpenUTF16): Added.
(WebCore::acquireLineBreakIterator): Use new text providers with prior context.

  • platform/text/wchar/TextBreakIteratorWchar.cpp:

(WebCore::acquireLineBreakIterator): Pass prior context to non-ICU path.

  • rendering/break_lines.cpp:

(WebCore::nextBreakablePosition): Use prior context in ICU path.

LayoutTests:

  • fast/text/line-break-between-text-nodes-cjk-expected.html: Added.
  • fast/text/line-break-between-text-nodes-cjk.html: Added.
  • fast/text/line-break-between-text-nodes-latin1-expected.html: Added.
  • fast/text/line-break-between-text-nodes-latin1.html: Added.
  • platform/chromium-linux/fast/text/international/003-expected.png: Rebaselined.
  • platform/chromium-linux/fast/text/international/003-expected.txt: Rebaselined.
  • platform/chromium-linux/fast/text/international/text-combine-image-test-expected.png: Rebaselined.
  • platform/chromium-linux/fast/text/international/text-combine-image-test-expected.txt: Added (previously missing).
  • platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Rebaselined.
  • platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Rebaselined.
2:53 PM Changeset in webkit [147587] by fpizlo@apple.com
  • 13 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Everyone should know about the FTL
​https://bugs.webkit.org/show_bug.cgi?id=113897

Reviewed by Mark Hahnenberg.

In order to get OSR exit to work right, we need the distinction between DFG and
FTL to be clear even after compilation finishes, since they will have subtly
different OSR stories and likely use different data structures.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStubInternal):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):
(JSC::CodeBlock::adjustedExitCountThreshold):
(JSC::CodeBlock::tallyFrequentExitSites):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::ExecState::isInlineCallFrame):

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::JITCode):

  • ftl/FTLState.cpp:

(JSC::FTL::State::dumpState):

  • heap/DFGCodeBlocks.cpp:

(JSC::DFGCodeBlocks::jettison):

  • interpreter/Interpreter.cpp:

(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):

  • jit/JITCode.cpp:

(WTF::printInternal):

  • jit/JITCode.h:

(JSC::JITCode::topTierJIT):
(JSC::JITCode::nextTierJIT):
(JITCode):
(JSC::JITCode::isJIT):
(JSC::JITCode::isLowerTier):
(JSC::JITCode::isHigherTier):
(JSC::JITCode::isLowerOrSameTier):
(JSC::JITCode::isHigherOrSameTier):
(JSC::JITCode::isOptimizingJIT):

  • jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileOptimized):
(JSC::samplingDescription):
(JSC::ProgramExecutable::compileOptimized):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):

2:51 PM Changeset in webkit [147586] by Lucas Forschler
  • 4 edits
    2 adds in branches/safari-534.59-branch/Source/WebKit2

Fix the build after merging 147042.

  • Platform/mac/StringUtilities.h: Added.

(WebKit):

  • Platform/mac/StringUtilities.mm: Added.

(WebKit):
(WebKit::nsStringFromWebCoreString):

  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextCopyPlugInInfoForBundleIdentifier):

  • UIProcess/Plugins/PluginInfoStore.h:

(PluginInfoStore):

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::findPluginWithBundleIdentifier):

2:35 PM Changeset in webkit [147585] by mhahnenberg@apple.com
  • 3 edits in trunk/LayoutTests

get_by_pname can become confused when iterating over objects with static properties
​https://bugs.webkit.org/show_bug.cgi?id=113831

Reviewed by Jer Noble.

Improving the test results to make it more obvious why something failed. Also removed
absolute paths from the test.

  • fast/js/dom-static-property-for-in-iteration-expected.txt:
  • fast/js/dom-static-property-for-in-iteration.html:
2:21 PM Changeset in webkit [147584] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed VS2010 build fix.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
2:08 PM Changeset in webkit [147583] by Christophe Dumez
  • 10 edits
    2 deletes in trunk/Source

[Chromium] Bad cast from BitmapImageSingleFrameSkia to BitmapImage
​https://bugs.webkit.org/show_bug.cgi?id=113492

Reviewed by Stephen White.

Source/WebCore:

Remove BitmapImageSingleFrameSkia and have ImageBufferSkia construct
BitmapImage objects instead via an intermediate NativeImageSkia.

No new tests, covered by existing tests.

  • WebCore.gypi:
  • platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Remove

include for BitmapImageSingleFrameSkia.h header.

  • platform/graphics/skia/BitmapImageSingleFrameSkia.cpp: Removed.
  • platform/graphics/skia/BitmapImageSingleFrameSkia.h: Removed.
  • platform/graphics/skia/ImageBufferSkia.cpp: Construct BitmapImage

objects instead of BitmapImageSingleFrameSkia ones.
(WebCore::ImageBuffer::copyImage):
(WebCore::drawNeedsCopy):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::BitmapImage): Implement BitmapImage constructor
that takes an NativeImageSkia* in argument.
(WebCore):
(WebCore::BitmapImage::draw): Remove m_source.initialized() check as
this will return false for BitmapImage objects constructed from a
NativeImageSkia, due to the lack of decoder.

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::NativeImageSkia): Add parameter to the
NativeImageSkia constructor so that the caller can request a deep copy
instead of a shallow one. This is needed by the ImageBuffer.

  • platform/graphics/skia/NativeImageSkia.h:
  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::setSkBitmap):

Source/WebKit/chromium:

Update test now that BitmapImageSingleFrameSkia no longer exists.
BitmapImage is now used instead.

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):

1:57 PM Changeset in webkit [147582] by fpizlo@apple.com
  • 4 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG should abstract out how it does forward exits, and that code should be simplified
​https://bugs.webkit.org/show_bug.cgi?id=113894

Reviewed by Mark Hahnenberg.

1) We previously had two different ways of convertingToForward, one path for

where we had a ValueRecovery for the current node and one where we didn't.
But the paths were doing exactly the same thing except that if you have a
ValueRecovery, you also find the last applicable mov hint and do some
extra things. This patch combines the two paths and bases both of them on
the previous no-ValueRecovery path, which was simpler to begin with.


2) This moves the logic into DFG::OSRExit, which further simplifies the code

and makes the logic available to the FTL.

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::convertToForward):
(DFG):

  • dfg/DFGOSRExit.h:

(DFG):
(OSRExit):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):

1:44 PM Changeset in webkit [147581] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: resultAnimationElement->m_animatedType
​https://bugs.webkit.org/show_bug.cgi?id=93528

Patch by David Vest <​davve@opera.com> on 2013-04-03
Reviewed by Philip Rogers.

Source/WebCore:

When the order of animation elements change within an animation
group, we can't assume that the resultElement is the same as it
was when the animation was frozen. Make sure to reset the
animation type for the resultElement before updating the
animation.

Test: svg/animations/animation-dependency-crash.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::progress):

LayoutTests:

  • svg/animations/animation-dependency-crash-expected.txt: Added.
  • svg/animations/animation-dependency-crash.html: Added.
1:39 PM Changeset in webkit [147580] by timothy@apple.com
  • 3 edits in trunk/Source/WebCore

Stop unconditionally enabling JavaScript execution when closing the Web Inspector.

​https://webkit.org/b/113889
rdar://problem/12281794

Reviewed by Joseph Pecoraro.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent): Initialize m_originalScriptExecutionDisabled.
(WebCore::InspectorPageAgent::enable): Populate m_originalScriptExecutionDisabled based on current setting.
(WebCore::InspectorPageAgent::disable): Restore previous setting.

  • inspector/InspectorPageAgent.h:

(InspectorPageAgent): Added m_originalScriptExecutionDisabled.

1:13 PM Changeset in webkit [147579] by dino@apple.com
  • 10 edits in trunk/Source

Cross fade into restarted plugin
​https://bugs.webkit.org/show_bug.cgi?id=113868

Reviewed by Tim Horton.

Source/WebCore:

Allow a restarted plugin to fade in over its snapshot, avoiding the abrupt
flash of empty content. The WebCore part of this patch marks the plugin
element as restarted, and draws the snapshot for a short amount of time
as the plugin is restarting. After the plugin has reappeared, we stop drawing
the snapshot.

There is a little bit of drive-by whitespace removal in HTMLPlugInImageElement.

  • html/HTMLPlugInElement.h:

(WebCore::HTMLPlugInElement::restartedPlugin): New method indicating if the plugin has been restarted.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Initialise new timer and member variable.
(WebCore::HTMLPlugInImageElement::setDisplayState): If we are moving into a restarting state, make sure

to remember this and also start a timer so that we show the snapshot for while.

(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired): No need to draw the snapshot from here on.

  • html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): Member variable to remember if we've restarted.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintContents): Only exit early from the paint if we're not a restarting

plugin, otherwise we do want to draw the snapshot if there is one.

  • rendering/RenderLayerBacking.cpp:

(WebCore::isRestartedPlugin): Detects a restarted plugin.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Don't become a simple container

compositing layer if you're a restarted plugin.

Source/WebKit2:

Add a new plugin process type that indicates this is a plugin that
has been restarted from snapshotting. On Apple ports, this allows
us to animate the appearance of the plugin so that it crossfades
with the snapshot. Other ports will have to add their own fading.

  • PluginProcess/PluginProcess.h: New Type: TypeRestartedProcess.
  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

(WebKit::PluginProxy::pluginLayer): When the plugin's CALayer is created, if it

is a restarted plugin, add an opacity animation to fade it in.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Mark restarted plugins with the new process type.

1:05 PM Changeset in webkit [147578] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Adjustments to media controls appearance.
​https://bugs.webkit.org/show_bug.cgi?id=113816
​https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=316398
​https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=316438

Updates to the BlackBerry media controls:

  • extend the timeline slider.
  • move the volume slider for audio elements up so it does not overlap the main panel.
  • upstream some other cosmetic changes to media controls that were not previously upstreamed.

Patch by John Griggs <​jgriggs@blackberry.com> on 2013-04-03
Reviewed by Rob Buis.

BlackBerry-specific, cosmetic change; No new tests required.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::paintMediaPlayButton):
(WebCore::RenderThemeBlackBerry::paintMediaMuteButton):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderThumb):

12:53 PM Changeset in webkit [147577] by mvujovic@adobe.com
  • 5 edits in trunk/LayoutTests

Compositing tests failing after ​http://trac.webkit.org/changeset/147502
​https://bugs.webkit.org/show_bug.cgi?id=113838

Reviewed by Dean Jackson.

Add (contentsOpaque 1) to the DRT text output in some expectations files due to bug 70634
"Mark GraphicsLayers as opaque when possible" [1]. The expectations in the guilty changeset
weren't updated after bug 70634 landed.

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=70634

  • compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
  • platform/mac/TestExpectations:
12:41 PM Changeset in webkit [147576] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/WebKitLibraries

Updated LLVM drops to include LLVM_DO_NOT_INCLUDE_CPP_HEADERS changes.

Rubber stamped by Mark Hahnenberg.

  • LLVMIncludesMountainLion.tar.bz2:
  • LLVMLibrariesMountainLion.tar.bz2:
12:29 PM Changeset in webkit [147575] by Lucas Forschler
  • 2 edits in branches/safari-534.59-branch/Source/WebKit2

Remove include after mis-merge of r147052.

  • UIProcess/API/C/WKAPICast.h:
12:16 PM Changeset in webkit [147574] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

[GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
​https://bugs.webkit.org/show_bug.cgi?id=113883

Reviewed by Martin Robinson.

  • gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
  • gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.

The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.

12:08 PM Changeset in webkit [147573] by hclam@chromium.org
  • 3 edits in branches/chromium/1453/Source/WebCore/platform/image-decoders/gif

Merge 147392 "Simply GIFImageReader error handling"

Simply GIFImageReader error handling
​https://bugs.webkit.org/show_bug.cgi?id=113718

Reviewed by Adam Barth.

When GIFImageReader encounters a parsing error it should just return
without doing any more work. Current code saves a boolean before return,
this is not necessary.

Tested with existing unit tests.
Tested locally with ASAN build with 60k GIF images.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::repetitionCount):

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::decode):

  • platform/image-decoders/gif/GIFImageReader.h:

(GIFImageReader::GIFImageReader):
(GIFImageReader):

TBR=​hclam@chromium.org
Review URL: ​https://codereview.chromium.org/13578002

11:58 AM Changeset in webkit [147572] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13564588> Add a temporary workaround for a build failure.

Fix suggested by Mark Rowe.

  • Shared/mac/ChildProcessMac.mm:
11:47 AM Changeset in webkit [147571] by Lucas Forschler
  • 8 edits in branches/safari-534.59-branch/Source/WebKit2

Merge 147052. <rdar://problem/13528851>

11:38 AM Changeset in webkit [147570] by mhahnenberg@apple.com
  • 5 edits
    2 adds in trunk

get_by_pname can become confused when iterating over objects with static properties
​https://bugs.webkit.org/show_bug.cgi?id=113831

Reviewed by Geoffrey Garen.

get_by_pname doesn't take static properties into account when using a JSPropertyNameIterator to directly
access an object's backing store. One way to fix this is to not cache any properties when iterating over
objects with static properties. This patch fixes the bug that was originally reported on swisscom.ch.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnNonIndexPropertyNames):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::create):

  • runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::numCacheableSlots):
(JSC::PropertyNameArray::setNumCacheableSlots):
(PropertyNameArray):

LayoutTests:

  • fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
  • fast/js/dom-static-property-for-in-iteration.html: Added.
11:27 AM Changeset in webkit [147569] by bfulgham@webkit.org
  • 3 edits in trunk/WebKitLibraries

[Windows, WinCairo] Unreviewed VS2010 Build Correction

  • win/tools/scripts/auto-version2010.sh: Added properties svn:eol-style and svn:executable.
  • win/tools/scripts/feature-defines2010.sh: Added properties svn:eol-style and svn:executable.
11:23 AM Changeset in webkit [147568] by ap@apple.com
  • 5 edits in trunk/Source/WebKit2

[WK2] XMLHttpRequest upload events don't work with NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=113887

Reviewed by Brady Eidson.

Just forward didSendData client call to WebProcess.

  • NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::didSendData): (WebKit::NetworkResourceLoader::didCancelAuthenticationChallenge): Tweaked a comment.
  • WebProcess/Network/WebResourceLoader.cpp: (WebKit::WebResourceLoader::didSendData):
  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in:
11:12 AM Changeset in webkit [147567] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

[Gstreamer] Use gst_buffer_extract() in copyGstreamerBuffersToAudioChannel()
​https://bugs.webkit.org/show_bug.cgi?id=113880

Reviewed by Philippe Normand.

copyGstreamerBuffersToAudioChannel() was mapping the GstBuffer content to memcpy
it to the AudioChannel buffer. This patch leverages gst_buffer_extract() to
simplify the code as it does exactly what we need: gst_buffer_map, memcpy,
gst_buffer_unmap and error handling.

Also replace GstBuffer NULL check by an assertion as we already make sure they
are not NULL before adding them to the list. Additionally, we now call
audioChannel->mutableData() only once instead of once per iteration. It is
a bit better as the getter does some work internally.

No new tests, no behavior change.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::copyGstreamerBuffersToAudioChannel):

10:30 AM Changeset in webkit [147566] by Antoine Quint
  • 6 edits in trunk/Source/WebCore

Web Inspector: DOM.highlightRect() and DOM.highlightQuad() should allow for page coordinates
​https://bugs.webkit.org/show_bug.cgi?id=113869

Add a new "usePageCoordinates" parameter to DOM.highlightRect() and DOM.highlightQuad()
allowing to specify that the rect or quad to highlight should be converted to page
coordinates instead of using the default viewport coordinates.

Reviewed by Timothy Hatcher.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::innerHighlightQuad):
Store the "usePageCoordinates" parameter obtained from the protocol calls onto the
highlight configuration object so that it may be used within the InspectorOverlay.

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::highlightQuad):
Check the highlight configuration for the "usePageCoordinates" parameter and
apply the inverse of the page's scroll offset to the quad if it's true.

  • inspector/InspectorOverlay.h:

(HighlightConfig):
(WebCore::Highlight::setDataFromConfig):
(Highlight):

9:43 AM Changeset in webkit [147565] by kangil.han@samsung.com
  • 2 edits in trunk/Source/WebCore

Add omitted reference operator of VisiblePosition in AccessibilityObject
​https://bugs.webkit.org/show_bug.cgi?id=113879

Reviewed by Darin Adler.

Seems reference operator has been omitted in startOfStyleRange function, so add it.

  • accessibility/AccessibilityObject.cpp:

(WebCore::startOfStyleRange):

9:35 AM Changeset in webkit [147564] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Include Pango in jhbuild-optional.modules
​https://bugs.webkit.org/show_bug.cgi?id=113878

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-03
Reviewed by Martin Robinson.

Since r147547 Pango 1.32.0 is required. Including the module in the
JHBuild optional moduleset.

  • gtk/jhbuild-optional.modules: Add Pango module.
9:27 AM Changeset in webkit [147563] by zeno.albisser@digia.com
  • 5 edits in trunk/Tools

[Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
​https://bugs.webkit.org/show_bug.cgi?id=113864

Moving setDefersLoading from TestRunnerQt to TestRunner
requires access to the non-Qt TestRunner.
As long as we instantiate both TestRunner and TestRunnerQt,
we need a separate getter for the non-Qt TestRunner instance.

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebPage::resetSettings):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(DumpRenderTree::jscTestRunner):

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::setDefersLoading):

Moving setDefersLoading from TestRunnerQt
to TestRunner.

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

9:12 AM Changeset in webkit [147562] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Update the localizable strings file.

Rubber-stamped by Michael Saboff.

  • English.lproj/Localizable.strings:
8:58 AM Changeset in webkit [147561] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r147493): Fix number of arguments to AudioDestinationIOS constructor

Fixes the following build failures:

Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:84:25: error: no matching constructor for initialization of 'WebCore::AudioDestinationIOS'

return adoptPtr(new AudioDestinationIOS(callback, sampleRate));


In file included from Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:36:
Source/WebCore/platform/audio/ios/AudioDestinationIOS.h:44:5: note: candidate constructor not viable: requires 3 arguments, but 2 were provided

AudioDestinationIOS(AudioIOCallback&, unsigned numberOfOutputChannels, double sampleRate);

Source/WebCore/platform/audio/ios/AudioDestinationIOS.h:42:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
class AudioDestinationIOS : public AudioDestination, public AudioSessionListener {


Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:101:22: error: out-of-line definition of 'AudioDestinationIOS' does not match any declaration in 'WebCore::AudioDestinationIOS'
AudioDestinationIOS::AudioDestinationIOS(AudioIOCallback& callback, double sampleRate)


2 errors generated.

  • platform/audio/ios/AudioDestinationIOS.h:

(AudioDestinationIOS): Remove numberOfOutputChannels argument.

8:51 AM Changeset in webkit [147560] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r147494): -[AVAudioSession setCategory:error:] takes NSError

Fixes the following build failure:

Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:151:71: error: cannot initialize a parameter of type 'NSError ' with an lvalue of type 'NSError *'

[[AVAudioSession sharedInstance] setCategory:categoryString error:error];


  • platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::setCategory): Add '&' operator.

8:45 AM Changeset in webkit [147559] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
​https://bugs.webkit.org/show_bug.cgi?id=104779

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-03
Reviewed by Carlos Garcia Campos.

  • Scripts/run-gtk-tests:

(TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
passing in current trunk.

8:45 AM Changeset in webkit [147558] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

CSP blocks inline style when cloning a node
​https://bugs.webkit.org/show_bug.cgi?id=112270

Patch by Felipe Zimmerle <​felipe@zimmerle.org> on 2013-04-03
Reviewed by Adam Barth.

Source/WebCore:

Checks if the Element is being cloned, if so, the application of the
style is allowed otherwise it relies on default permission mechanism.

Test: http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html

  • dom/Element.cpp:

(WebCore::Element::attributeChanged): Added parameter
AttributeModificationReason to the method signature.
(WebCore::Element::cloneAttributesFromElement): It is now calling
attributeChanged with AttributeModificationReason parameter. In this scope
it is always set to ModifiedByCloning.
(WebCode::Element::attributeChangedFromParserOrByCloning):
Added parameter AttributeModificationReason.

  • dom/Element.h: Added AttributeModificationReason enum. Used to specify

whenever an attribute was set by a cloned oject or directly.
AttributeModificationReason added to attributeChanged with the default
value set to ModifiedDirectly.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged): Added
AttributeModificationReason to the method signature.
(WebCore::StyledElement::styleAttributeChanged): Now it is checking the
reason of the update, if the reason is ModifiedDirectly check CSP
before set. If ModifiedByCloning set the attribute ignoring the CSP
policy.

  • dom/StyledElement.h:

(StyledElement): Added AttributeModificationReason parameter to the methods:
attributeChanged and styleAttributeChanged, attributeChanged has
ModifiedDirectly as default value.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::attributeChanged): Added AttributeModificationReason
parameter to the method signature.

  • svg/SVGElement.h:

(SVGElement): Added AttributeModificationReason parameter to the
attributeChanged signature with the default value set to:
ModifiedDirectly.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html: Added.
8:18 AM Changeset in webkit [147557] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] WebKitWebNavigationAction: fix mix between dispose and finalize
​https://bugs.webkit.org/show_bug.cgi?id=113794

Patch by Alban Crequy <​alban.crequy@collabora.co.uk> on 2013-04-03
Reviewed by Gustavo Noronha Silva.

WebKitWebNavigationAction's dispose function was named finalize and was calling
the parent class's finalise function, causing a memory corruption. Change it to
be a proper finalize function instead.

  • webkit/webkitwebnavigationaction.cpp:

(webkit_web_navigation_action_class_init):

8:11 AM Changeset in webkit [147556] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed 32bit buildfix after r147542.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveBinaryData):

8:09 AM Changeset in webkit [147555] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

[Gstreamer] Avoid calls to g_slist_nth_data in webKitWebAudioSrcLoop()
​https://bugs.webkit.org/show_bug.cgi?id=113875

Reviewed by Philippe Normand.

webKitWebAudioSrcLoop() was iterating over 2 GSLists by using a counter and then
calling g_slist_nth_data() to get the element of each GSList. This is inefficient
because calling g_slist_nth_data() will iterate the GSList up until index 'n'.

This patch improves this by keeping pointers to the current element of each list
while iterating, so that we can simply use g_slist_next() to iterate instead
of g_slist_nth_data().

No new tests, no behavior change.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcLoop):

8:04 AM Changeset in webkit [147554] by keishi@webkit.org
  • 4 edits in trunk/Source/WebCore

Actions that require user gesture don't work in window.showModalDialog in Chromium
​https://bugs.webkit.org/show_bug.cgi?id=113777

Reviewed by Jochen Eisinger.

In Chromium the window for showModalDialog is not modal which causes the
UserGestureIndicator to block actions in the sub window. We introduce a
RAII that saves the UserGestureIndicator and state, then resets it before
runModalDialog, and restore it when it's done.

No new tests. Can't cause user gesture inside modal dialog.

  • dom/UserGestureIndicator.cpp:

(WebCore::UserGestureIndicatorDisabler::UserGestureIndicatorDisabler): Saves and resets the topmost indicator and state.
(WebCore):
(WebCore::UserGestureIndicatorDisabler::~UserGestureIndicatorDisabler): Restores topmost indicator and state.

  • dom/UserGestureIndicator.h:

(WebCore):
(UserGestureIndicatorDisabler): RAII to temporarily disable UserGestureIndicator.
(UserGestureIndicator): Allow access to UserGestureIndicatorDisabler.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::showModalDialog): Disable UserGestureIndicator while runModalDialog.

8:02 AM Changeset in webkit [147553] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Fail gracefully if an OpenGL context could not be created.
​https://bugs.webkit.org/show_bug.cgi?id=113784

In case we fail to create or adopt a valid platform OpenGL context
we do not want to provide a GraphicsContext3D instance.
Otherwise we would crash as soon as the instance is being used.

Reviewed by Jocelyn Turcotte.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3D::GraphicsContext3D):

7:36 AM Changeset in webkit [147552] by anilsson@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove defaultViewportArguments check from call site of recomputeVirtualViewportFromViewportArguments
​https://bugs.webkit.org/show_bug.cgi?id=113872

Reviewed by Carlos Garcia Campos.

Carlos pointed out that recomputeVirtualViewportFromViewportArguments
already contains the check, and returns an empty IntSize if it fails.
So pick up on that to make the code a bit more DRY.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

7:23 AM Changeset in webkit [147551] by kadam@inf.u-szeged.hu
  • 15 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated platform specific expected files after r147492.

  • platform/qt/TestExpectations:
  • platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
  • platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
  • platform/qt/fast/encoding/utf-16-big-endian-expected.png:
  • platform/qt/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/qt/fast/encoding/utf-16-little-endian-expected.png:
  • platform/qt/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/qt/fast/forms/input-value-expected.png: Added.
  • platform/qt/fast/forms/input-value-expected.txt:
  • platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.png:
  • platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
  • platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
7:15 AM Changeset in webkit [147550] by pierre.rossi@gmail.com
  • 2 edits in trunk/Tools

Fix HAVE(QTTESTSUPPORT) logic

build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
resulting in HAVE(QTTESTSUPPORT) never being true.
Move that logic down in sanitizeFeatures.

Patch by Pierre Rossi <​pierre.rossi@digia.com> on 2013-04-03
Rubber-stamped by Tor Arne Vestbø.

  • qmake/mkspecs/features/features.prf:
6:23 AM Changeset in webkit [147549] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK][AC] Implement matrix keyframe animations with clutter ac backend
​https://bugs.webkit.org/show_bug.cgi?id=110314

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-03
Reviewed by Gustavo Noronha Silva.

Clutter 1.12 doesn't support additive transform animations yet, So clutter ac backend
uses matrix animations for the case. This patch follows changeset 143369, 143343
to support matrix keyframe animations. I believe this change is easy if you understand
above two changesets.

Covered by existing animation tests.

  • platform/graphics/clutter/PlatformClutterAnimation.cpp:

(WebCore::PlatformClutterAnimation::setValues):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):
(WebCore):
(WebCore::PlatformClutterAnimation::addTransformTransition):

  • platform/graphics/clutter/PlatformClutterAnimation.h:

(PlatformClutterAnimation):

6:20 AM Changeset in webkit [147548] by kov@webkit.org
  • 11 edits
    2 adds in trunk

Should close select popup when the element loses focus
​https://bugs.webkit.org/show_bug.cgi?id=113220

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-04-03
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/select-popup-closes-on-blur.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::menuListDefaultEventHandler): handle the blur event, closing
the popup menu if any.

  • testing/Internals.cpp:

(WebCore::Internals::isSelectPopupVisible): utility to query the select node renderer to
find out whether the popup is open or closed.
(WebCore):

  • testing/Internals.h: add the new method definition.
  • testing/Internals.idl: ditto.

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in: export WebCore::HTMLNames::selectTag for Internals

LayoutTests:

  • fast/forms/select/popup-closes-on-blur-expected.txt: Added.
  • fast/forms/select/popup-closes-on-blur.html: Added.
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
6:20 AM Changeset in webkit [147547] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Bump required versions of some dependencies
​https://bugs.webkit.org/show_bug.cgi?id=113282

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-04-03
Reviewed by Martin Robinson.

.:

This patch updates the following dependencies:

  • libsoup 2.42.0: is the current stable release.
  • glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
  • gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
  • at-spi2 2.5.3: is the version required by gtk+ 3.6.
  • GObject introspection 1.32.0: is the version required by gtk+ 3.6.
  • Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
  • Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
  • gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
  • Source/autotools/Versions.m4:

Tools:

  • gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
6:12 AM Changeset in webkit [147546] by kov@webkit.org
  • 2 edits in trunk/Tools

[GTK] gst-plugins-good fails to build with newer Linux(v4l2)
​https://bugs.webkit.org/show_bug.cgi?id=113809

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-04-03
Reviewed by Philippe Normand.

Newer Linux kernels have removed some deprecated macros from v4l2
headers, causing gst-plugins-good's build to break. We don't need it
right now, so just disable it.

  • gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
5:44 AM Changeset in webkit [147545] by jesus@webkit.org
  • 12 edits in trunk

[Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
​https://bugs.webkit.org/show_bug.cgi?id=113535

Reviewed by Simon Hausmann.

Source/WebCore:

Now Qt uses the CROSS_PLATFORM_CONTEXT_MENUS
USE flag. This flag provides a full cross-platform
representation of a ContextMenu and a ContextMenuItem.
The embedder can then decide how to show this, so neither
WebCore nor WebCore/platform need to know any platform
specifics about menus.

No new tests, no behavior changes.

  • Target.pri:
  • platform/ContextMenu.h:

(ContextMenu):

  • platform/ContextMenuItem.h:
  • platform/qt/ContextMenuItemQt.cpp:

(WebCore::ContextMenuItem::platformContextMenuItem):

  • platform/qt/ContextMenuQt.cpp:

(WebCore::ContextMenu::ContextMenu):
(WebCore::ContextMenu::getContextMenuItems):
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):

Source/WebKit/qt:

Adjust ContextMenuClientQt and QWebPageAdapter to use CROSS_PLATFORM_CONTEXT_MENUS
USE flag by implementing customizeMenu() instead of getCustomMenuFromDefaultItems()
and by calling menu->items() instead of menu->platformDescription().

  • WebCoreSupport/ContextMenuClientQt.cpp:

(WebCore::ContextMenuClientQt::customizeMenu):

  • WebCoreSupport/ContextMenuClientQt.h:

(ContextMenuClientQt):

  • WebCoreSupport/QWebPageAdapter.cpp:

(descriptionForPlatformMenu):
(QWebPageAdapter::updatePositionDependentMenuActions):

Tools:

Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.

  • qmake/mkspecs/features/features.prf:
5:35 AM Changeset in webkit [147544] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Monospace font does not render in proper sizes
​https://bugs.webkit.org/show_bug.cgi?id=93263

Reviewed by Jocelyn Turcotte.

Remove this patch's artificial dependency on Qt 5.1.

  • platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):

5:33 AM Changeset in webkit [147543] by zeno.albisser@digia.com
  • 3 edits in trunk/Tools

[Qt] Move logic of simple forwarding functions to TestRunner.
​https://bugs.webkit.org/show_bug.cgi?id=113863

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::setTextDirection):
(TestRunner::goBack):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::addUserStyleSheet):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

5:15 AM Changeset in webkit [147542] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Refine LOG messages in WebSocket related components
​https://bugs.webkit.org/show_bug.cgi?id=113852

Patch by Takeshi Yoshino <​tyoshino@chromium.org> on 2013-04-03
Reviewed by Kent Tamura.

Refine LOG messages by

  • Make them contain method names to ease identifying where the event occurred.
  • For consistency, make all messages print the pointer of the origin instance.
  • Quote UTF8 data in LOG messages.
  • For overloaded methods, add the type to clarify which one is run
  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::contextDestroyed):
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didReceiveBinaryData):
(WebCore::WebSocket::didReceiveMessageError):
(WebCore::WebSocket::didUpdateBufferedAmount):
(WebCore::WebSocket::didStartClosingHandshake):
(WebCore::WebSocket::didClose):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::subprotocol):
(WebCore::WebSocketChannel::extensions):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::bufferedAmount):
(WebCore::WebSocketChannel::close):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::willOpenSocketStream):
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::didStartLoading):
(WebCore::WebSocketChannel::didReceiveData):
(WebCore::WebSocketChannel::didFinishLoading):
(WebCore::WebSocketChannel::didFail):
(WebCore::WebSocketChannel::appendToBuffer):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::closingTimerFired):

  • Modules/websockets/WebSocketDeflater.cpp:

(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::WebSocketInflater::~WebSocketInflater):

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::readServerHandshake):

  • platform/network/chromium/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandleInternal::connect):
(WebCore::SocketStreamHandleInternal::send):
(WebCore::SocketStreamHandleInternal::close):
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didSendData):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):

4:56 AM Changeset in webkit [147541] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Update QMAKE_MAC_SDK check for Qt 5.1

Relies on QMAKE_MAC_SDK_VERSION set in features.prf

Reviewed by Simon Hausmann.

  • WebCore.pri:
4:56 AM Changeset in webkit [147540] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Disable media support using QuickTime if deployment target != SDK

We link to a single libWebKitSystemInterface static lib, so unless the
deployment target matches the SDK let's not pretend like we'll be able
to run on anything lower than the SDK version.

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/features.prf:
4:15 AM Changeset in webkit [147539] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] assignToHTMLImageElement no longer exists in Qt5
​https://bugs.webkit.org/show_bug.cgi?id=113639

Patch by Kristof Provost <​kristof@codepro.be> on 2013-04-03
Reviewed by Simon Hausmann.

No new tests: covered by ./Source/WebKit/qt/tests/hybridPixmap/test.html

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapRuntime::getClassRef):

4:06 AM Changeset in webkit [147538] by Antoine Quint
  • 5 edits
    1 copy
    1 add in trunk

Web Inspector: crash in WebCore::InspectorLayerTreeAgent::buildObjectForLayer if a layer is created for an anonymous RenderObject (:first-letter)
​https://bugs.webkit.org/show_bug.cgi?id=113768

Source/WebCore:

The InspectorLayerTreeAgent now knows how to deal with anonymous RenderObjects
for the :first-letter and :first-line pseudo-elements.

Reviewed by Timothy Hatcher.

Test: inspector-protocol/layers/layers-anonymous.html

  • inspector/Inspector.json:

Change the Layer type in the LayerTree domain to have more accurate terminology
(pseudo-element vs. pseudo-class) and a new optional isAnonymous flag for layers
associated to anonymous RenderObjects.

  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
Check for anonymous RenderObjects and set the parent renderer's node as the node
for this layer since anonymous renderers have the Document as their node and this
would not be satisfactory to show in a front-end. We also check for anonymous
RenderObjects for the :first-letter and :first-line pseudo-elements and set them
in the pseudoElement property of the Layer object created such that a front-end
could correctly identify what type of pseudo-element for the associated node
yielded this layer.

(WebCore::InspectorLayerTreeAgent::idForNode):
Here we fix the actual crash by first checking if the node provided is null and
returning 0 if there's no such node. This ensures that any scenario where there
is no node associated with the RenderObject simply informs of the front-end that
no such node exists and we do not crash.

LayoutTests:

Reviewed by Timothy Hatcher.

  • inspector-protocol/layers/layers-anonymous-expected.txt: Added.
  • inspector-protocol/layers/layers-anonymous.html: Added.

New test for layers created for CSS anonymous boxes or blocks.

  • inspector-protocol/layers/layers-generated-content.html:

Update test to use the "pseudoElement" property instead of "pseudoClass"
which was the previous, less accurate name.

4:06 AM Changeset in webkit [147537] by anilsson@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Decouple layout viewport from visual viewport
​https://bugs.webkit.org/show_bug.cgi?id=113829

Reviewed by Carlos Garcia Campos.

Setting the visual viewport would force the layout viewport equal to
the visual viewport. Decouple the viewports by allowing the user to
specify a layout viewport when setting the viewport(s). The layout
viewport could be the exact same value passed for visual viewport, if
the old behavior is desired.

Also reevaluate any viewport arguments when (only) the layout viewport
changes in WebPage::setDefaultLayoutSize() since the layout viewport is
used as input to the calculation.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setScreenOrientation):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::setViewportSize):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPage::defaultLayoutSize):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

3:59 AM Changeset in webkit [147536] by zarvai@inf.u-szeged.hu
  • 13 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r147530.

  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
3:24 AM Changeset in webkit [147535] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION(r147117)][Elements] Copy/paste keyboard shortcuts broken in "Edit as HTML"
​https://bugs.webkit.org/show_bug.cgi?id=113798

Reviewed by Yury Semikhatsky.

Stop propagation of "copy" event from the multiline editor's
CodeMirror host element so that it is not handled by
WebInspector.documentCopy().

  • inspector/front-end/UIUtils.js:

(.consumeCopy):
(.cleanUpAfterEditing):

  • inspector/front-end/inspector.js:

(WebInspector.addMainEventListeners):

2:49 AM Changeset in webkit [147534] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] accessibility/ignore-spacer-elements.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=112001

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-04-03
Reviewed by Gyuyoung Kim.

Fixed failing test. The reason of failure is different expectation of childrenCount.

  • accessibility/ignore-spacer-elements.html:
  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
2:48 AM Changeset in webkit [147533] by tasak@google.com
  • 3 edits
    3 adds in trunk

With borders of differing alpha, the corners become squared off
​https://bugs.webkit.org/show_bug.cgi?id=113744

Reviewed by Simon Fraser.

Source/WebCore:

paintTranslucentBorderSides should pick up borders with common color
in order: top, bottom, left and right (not top, right, bottom and
left), because willBeOverdrawn depends on the assumption, borders are
drawn in order: top, bottom, left and right.

Test: fast/borders/border-left-right-same-bottom-different-color.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):

LayoutTests:

  • fast/borders/border-left-right-same-bottom-different-color-expected.txt: Added.
  • fast/borders/border-left-right-same-bottom-different-color.html: Added.
  • platform/chromium-linux/fast/borders/border-left-right-same-bottom-different-color-expected.png: Added.
2:45 AM Changeset in webkit [147532] by kadam@inf.u-szeged.hu
  • 2 edits
    4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated platform specific expected files.

  • platform/qt/TestExpectations: Skipped failing reftest.
  • platform/qt/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added after r147502.
  • platform/qt/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added after r147502.
  • platform/qt/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added after r147502.
  • platform/qt/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added after r147502.
2:31 AM Changeset in webkit [147531] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

[New Multicolumn]Remove assert in RenderMultiColumnFlowThread::createAnonymous
​https://bugs.webkit.org/show_bug.cgi?id=113855

Reviewed by Antti Koivisto.

Remove CSSRegions specific assert from new multicolumn implementation.
No change in functionality, no new tests.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::createAnonymous):

2:28 AM Changeset in webkit [147530] by mkwst@chromium.org
  • 22 edits in trunk

X-Frame-Options: Blocked frames should not inherit their parent's SecurityOrigin.
​https://bugs.webkit.org/show_bug.cgi?id=112903

Reviewed by Adam Barth.

Source/WebCore:

This change brings WebKit in line with IE and Gecko's behavior, both of
which treat the blocked frame as being cross-origin for the purposes of
access checks ('[frame].contentWindow.location.href' is inaccessible,
for example).

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

Rather than redirecting to 'about:blank', redirect to a URL which
does not inherit the SecurityOrigin of the parent.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

Before calling cancelMainResourceLoad, ensure that the frame's
document is sandboxed into a unique origin so that it doesn't inherit
the parent's SecurityOrigin.

LayoutTests:

  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
2:19 AM Changeset in webkit [147529] by mnaganov@chromium.org
  • 9 edits
    1 add in trunk/Source

[Chromium] Implement target-densityDpi viewport property emulation
​https://bugs.webkit.org/show_bug.cgi?id=110835

The value is only used in the Chromium port, when the corresponding
setting is enabled.

This is needed for supporting existing WebView-based applications
that rely on this property.

Reviewed by Adam Barth.

Source/WebCore:

  • dom/ViewportArguments.cpp:

(WebCore::findTargetDensityDPIValue):
(WebCore):
(WebCore::setViewportFeature):

  • dom/ViewportArguments.h:

(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):

Source/WebKit/chromium:

  • public/WebSettings.h:

(WebSettings):

  • src/ChromeClientImpl.cpp:

(WebKit):
(WebKit::calculateTargetDensityDPIFactor):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setSupportDeprecatedTargetDensityDPI):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::supportDeprecatedTargetDensityDPI):

  • tests/WebFrameTest.cpp:
  • tests/data/viewport-target-densitydpi-high.html: Added.
1:56 AM Changeset in webkit [147528] by commit-queue@webkit.org
  • 14 edits in trunk/LayoutTests

Unreviewed, rolling out r147409.
​http://trac.webkit.org/changeset/147409
​https://bugs.webkit.org/show_bug.cgi?id=113856

The baselines should be reverted after r147450. (Requested by
kadam on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-04-03

  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • platform/qt/TestExpectations:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
1:38 AM Changeset in webkit [147527] by Christophe Dumez
  • 82 edits
    3 moves in trunk/LayoutTests

Unreviewed. Rebaseline several tests for Chromium that have better output after
r147492.

  • platform/chromium-linux/editing/selection/select-missing-image-expected.png:
  • platform/chromium-linux/fast/block/float/002-expected.png:
  • platform/chromium-linux/fast/block/float/017-expected.png:
  • platform/chromium-linux/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/chromium-linux/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-linux/fast/flexbox/023-expected.png:
  • platform/chromium-linux/fast/flexbox/024-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.txt:
  • platform/chromium-linux/fast/invalid/012-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac-lion/fast/block/float/002-expected.png:
  • platform/chromium-mac-lion/fast/block/float/017-expected.png:
  • platform/chromium-mac-lion/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/chromium-mac-lion/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/chromium-mac-lion/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-mac-lion/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-mac-lion/fast/flexbox/023-expected.png:
  • platform/chromium-mac-lion/fast/flexbox/024-expected.png:
  • platform/chromium-mac-lion/fast/forms/005-expected.png:
  • platform/chromium-mac-lion/fast/forms/input-value-expected.png:
  • platform/chromium-mac-lion/fast/invalid/012-expected.png:
  • platform/chromium-mac-lion/fast/parser/comment-in-script-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/002-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/017-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-mac-snowleopard/fast/flexbox/023-expected.png:
  • platform/chromium-mac-snowleopard/fast/flexbox/024-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/invalid/012-expected.png:
  • platform/chromium-mac-snowleopard/fast/parser/comment-in-script-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-mac/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac/fast/block/float/002-expected.png:
  • platform/chromium-mac/fast/block/float/017-expected.png:
  • platform/chromium-mac/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/chromium-mac/fast/dom/HTMLImageElement/image-alt-text-expected.txt: Renamed from LayoutTests/platform/chromium/fast/dom/HTMLImageElement/image-alt-text-expected.txt.
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Renamed from LayoutTests/platform/chromium/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt.
  • platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/chromium-mac/fast/flexbox/023-expected.png:
  • platform/chromium-mac/fast/flexbox/024-expected.png:
  • platform/chromium-mac/fast/forms/005-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.txt:
  • platform/chromium-mac/fast/invalid/012-expected.png:
  • platform/chromium-mac/fast/parser/comment-in-script-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.txt: Renamed from LayoutTests/platform/chromium/tables/mozilla/collapsing_borders/bug41262-3-expected.txt.
  • platform/chromium-win/editing/selection/select-missing-image-expected.png:
  • platform/chromium-win/fast/block/float/002-expected.png:
  • platform/chromium-win/fast/block/float/017-expected.png:
  • platform/chromium-win/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/chromium-win/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
  • platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/chromium-win/fast/flexbox/023-expected.png:
  • platform/chromium-win/fast/flexbox/024-expected.png:
  • platform/chromium-win/fast/forms/input-value-expected.png:
  • platform/chromium-win/fast/forms/input-value-expected.txt:
  • platform/chromium-win/fast/invalid/012-expected.png:
  • platform/chromium-win/fast/parser/comment-in-script-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
  • platform/chromium/TestExpectations:
1:31 AM Changeset in webkit [147526] by mkwst@chromium.org
  • 4 edits in trunk/Source/WebCore

Extract URL that doesn't inherit a parent's SecurityOrigin out into a constant.
​https://bugs.webkit.org/show_bug.cgi?id=113780

Reviewed by Jochen Eisinger.

We're scheduling navigations to 'data:text/html,' in XSSAuditor in
order to end up on a page that doesn't inherit its parent's
SecurityOrigin. We'll be reusing this mechainsm to solve
​http://wkbug.com/112903

This patch makes us more explicit about what we're doing and why.
It doesn't change any behavior: XSSAuditor tests should still pass.

  • html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::didBlockScript):

Use SecurityOrigin::urlWithUniqueSecurityOrigin rather than a
literal string to make our intentions clear.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::urlWithUniqueSecurityOrigin):

  • page/SecurityOrigin.h:

Add the new static method.

1:21 AM Changeset in webkit [147525] by rniwa@webkit.org
  • 7 edits in trunk/Source

Remove code for Mac 10.5 and earlier from WTF and WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=113844

Reviewed by Benjamin Poulain.

Removed the code for 10.5 and removed if-def for 10.6.

Source/WebKit2:

  • Shared/mac/PasteboardTypes.mm:

(WebKit::PasteboardTypes::forEditing):

Source/WTF:

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

  • wtf/Platform.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeCurrentThreadInternal):

  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::userDefault):

12:54 AM Changeset in webkit [147524] by Christophe Dumez
  • 14 edits in trunk/LayoutTests

Unreviewed, rebaseline several tests cases for GTK that have better results
after r147492.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/gtk/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
  • platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
  • platform/gtk/fast/encoding/utf-16-big-endian-expected.png:
  • platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/gtk/fast/encoding/utf-16-little-endian-expected.png:
  • platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.png:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:

Apr 2, 2013:

11:56 PM Changeset in webkit [147523] by Chris Fleizach
  • 3 edits in trunk/Source/WebCore

clean up static casts in WebAccessibilityObjectWrapperMac.mm to methods like toAccessibilityList()
​https://bugs.webkit.org/show_bug.cgi?id=113828

Reviewed by Tim Horton.

static_cast changed to toAccessibilityList().

  • accessibility/AccessibilityList.h:

(WebCore::toAccessibilityList):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):

11:52 PM Changeset in webkit [147522] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

Update expectations for fast/css3-text/css3-text-indent/text-indent-each-line.html
​https://bugs.webkit.org/show_bug.cgi?id=113848

Mark as [ Failure ImageOnlyFailure ] for fast/css3-text/css3-text-indent/.

Unreviewed gardening.

Patch by Jaehun Lim <​ljaehun.lim@samsung.com> on 2013-04-02

  • platform/mac/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
11:40 PM Changeset in webkit [147521] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r147370.
​http://trac.webkit.org/changeset/147370
​https://bugs.webkit.org/show_bug.cgi?id=113850

This patch is causing crashes in video tests on all Mac bots.
(Requested by jernoble_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-04-02

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):

11:17 PM Changeset in webkit [147520] by commit-queue@webkit.org
  • 21 edits in trunk

AXRoleDescripton for DL is "list"; should be "description list"
​https://bugs.webkit.org/show_bug.cgi?id=111665

Patch by James Craig <​james@cookiecrook.com> on 2013-04-02
Reviewed by Chris Fleizach.

Source/WebCore:

Defining the role and description strings, and accessors for DL.
This previously relied on getting the role and description from the platform API.

Updated existing test coverage.

  • English.lproj/Localizable.strings:
  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):

  • platform/LocalizedStrings.cpp:

(WebCore::AXDescriptionListText):
(WebCore):

  • platform/LocalizedStrings.h:

(WebCore):

  • platform/blackberry/LocalizedStringsBlackBerry.cpp:

(WebCore::AXDescriptionListText):
(WebCore):

  • platform/chromium/LocalizedStringsChromium.cpp:

(WebCore::AXDescriptionListText):
(WebCore):

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::AXDescriptionListText):
(WebCore):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::AXDescriptionListText):
(WebCore):

  • platform/qt/LocalizedStringsQt.cpp:

(WebCore::AXDescriptionListText):
(WebCore):

Source/WebKit/chromium:

Defining the role and description strings.

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:

Tools:

Defining the role and description strings.

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

LayoutTests:

Updating expectation strings for DL role description.

  • platform/mac/accessibility/lists-expected.txt:
  • platform/mac/accessibility/role-subrole-roledescription-expected.txt:
  • platform/mac/accessibility/role-subrole-roledescription.html:
11:00 PM Changeset in webkit [147519] by eustas@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Network] Split business logic and presentation for initiator column.
​https://bugs.webkit.org/show_bug.cgi?id=113486

Reviewed by Pavel Feldman.

Currently business logic and presentation are mixed.
This prevents making cell renderer static and applying
viewport rendering, because initiator sorting function
depends on data written when cell is rendered.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
Removed business logic. Use "initiatorInfo".
(WebInspector.NetworkDataGridNode.InitiatorComparator):
Use "initiatorInfo".

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.initiatorInfo):
Extracted business logic from "refreshInitiatorCell".

10:39 PM Changeset in webkit [147518] by jer.noble@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed gardening; rebaseline mac expected results after r147470.

  • platform/mac/css3/filters/effect-reference-composite-expected.png: Added.
  • platform/mac/css3/filters/effect-reference-composite-expected.txt: Added.
  • platform/mac/css3/filters/effect-reference-composite-hw-expected.png: Added.
  • platform/mac/css3/filters/effect-reference-composite-hw-expected.txt: Added.
9:56 PM Changeset in webkit [147517] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

needsLeopardMailQuirks should be removed
​https://bugs.webkit.org/show_bug.cgi?id=113749

Reviewed by Benjamin Poulain.

Removed needsLeopardMailQuirks from settings.in after r147447.

  • page/Settings.in:
8:46 PM Changeset in webkit [147516] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] Unskip and update inspector tests
​https://bugs.webkit.org/show_bug.cgi?id=113840

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02

  • platform/efl/TestExpectations:
  • platform/efl/http/tests/inspector/console-websocket-error-expected.txt: Added.
7:50 PM Changeset in webkit [147515] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Unskip filter-fallback-to-software.html on Mac WK2 Release

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-02

  • platform/mac-wk2/TestExpectations:

The test seems to pass in Release. Let's see how the bots feel about that.

6:41 PM Changeset in webkit [147514] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should compile a little sooner
​https://bugs.webkit.org/show_bug.cgi?id=113835

Unreviewed.

Rolled out r147511 because it was based on incorrect performance
measurement.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::optimizationThresholdScalingFactor):

6:32 PM Changeset in webkit [147513] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Source/WebCore: [css3-text] Rendering -webkit-each-line value for text-indent from css3-text
​https://bugs.webkit.org/show_bug.cgi?id=113259

Patch by Jaehun Lim <​ljaehun.lim@samsung.com> on 2013-04-02
Reviewed by Levi Weintraub.

CSS3 TEXT introduces new value, "each-line" for text-indent.
Indentation affects the first line of the block container as well as each line
after a forced line break, but does not affect lines after a soft wrap break.

This patch is the rendering part to support each-line value for text-indent.
It's prefixed and guarded by CSS3_TEXT flag.

Test: fast/css3-text/css3-text-indent/text-indent-each-line.html

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::startOffsetForLine):
(WebCore::RenderBlock::endOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):

Rename a parameter from firstLine to shouldIndentText.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::shouldIndentText): Return boolean according to m_shouldIndentText.
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
(WebCore::LineWidth::fitBelowFloats):

Add enum IndentTextOrNot and m_shouldIndentText.
Use m_shouldIndentText instead of m_isFirstLine.

(WebCore::requiresIndent): Decide whether text indentation is required.
(WebCore::updateLogicalInlinePositions):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests: [css3-text] Rendering -webkit-each-line value for text-indent from css3-text
​https://bugs.webkit.org/show_bug.cgi?id=113259

CSS3 TEXT introduces new value, "each-line" for text-indent.
Indentation affects the first line of the block container as well as each line
after a forced line break, but does not affect lines after a soft wrap break.

Patch by Jaehun Lim <​ljaehun.lim@samsung.com> on 2013-04-02
Reviewed by Levi Weintraub.

  • fast/css3-text/css3-text-indent/text-indent-each-line-expected.html: Added.
  • fast/css3-text/css3-text-indent/text-indent-each-line.html: Added.
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
5:35 PM Changeset in webkit [147512] by Lucas Forschler
  • 8 edits in branches/safari-536.29-branch/Source/WebKit2

Merged 147052 <rdar://problem/13528851>

5:34 PM Changeset in webkit [147511] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should compile a little sooner
​https://bugs.webkit.org/show_bug.cgi?id=113835

Reviewed by Michael Saboff.

2% speedup on SunSpider.

2% speedup on JSRegress.

Neutral on Octane, v8, and Kraken.

The worst-hit single sub-test is kraken-stanford-crypto-ccm.js, which gets
18% slower. Since Kraken is neutral overall in its preferred mean, I
think that's OK for now.

(Our array indexing speculation fails pathologically on
kraken-stanford-crypto-ccm.js. Compiling sooner is a regression because
it triggers those failures sooner. I'm going to file some follow-up bugs
explaining how to fix our speculations on this sub-test, at which point
compiling earlier should become a slight speedup on Kraken overall.)

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::optimizationThresholdScalingFactor): I experimented
with a few different options, including reducing the coefficient 'a'.
A simple linear reduction on instruction count worked best.

5:28 PM Changeset in webkit [147510] by dino@apple.com
  • 2 edits in trunk/LayoutTests

Compositing tests failing after ​http://trac.webkit.org/changeset/147502
​https://bugs.webkit.org/show_bug.cgi?id=113838

Temporarily marking as failing.

  • platform/mac/TestExpectations:
5:08 PM Changeset in webkit [147509] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Disable running tests on Win EWS queue.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

4:34 PM Changeset in webkit [147508] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Be more robust against empty message receiver names in incoming messages
​https://bugs.webkit.org/show_bug.cgi?id=113833
<rdar://problem/13284433>

Reviewed by Beth Dakin.

Turns out that we either send or receive messages whose receiver names are empty. This leads to bad things when we try to look
up the message receiver name in a hash map since the empty name is used to represent an empty hash map value.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::addWorkQueueMessageReceiverOnConnectionWorkQueue):
Sprinkle assertions.

(CoreIPC::Connection::processIncomingMessage):
If the message receiver name is not valid, make sure to call didReceiveInvalidMessage on the client thread.

(CoreIPC::Connection::dispatchDidReceiveInvalidMessage):
Add new helper function.

4:31 PM Changeset in webkit [147507] by glenn@skynav.com
  • 2 edits
    1 add in trunk/PerformanceTests

Need japanese line layout performance test
​https://bugs.webkit.org/show_bug.cgi?id=113811

Reviewed by Ryosuke Niwa.

Will be used by ​https://bugs.webkit.org/show_bug.cgi?id=105692 to test potential performance regression
for Japanese (and other CJK) line break changes.

  • Layout/LineLayoutJapanese.html: Added.
  • Skipped: Skip this test by default.
4:28 PM Changeset in webkit [147506] by glenn@skynav.com
  • 3 edits in trunk/Source/WebCore

Generalize prior line break context state and names.
​https://bugs.webkit.org/show_bug.cgi?id=113823

Reviewed by Darin Adler.

No new tests required due to no behavioral change.

  • platform/text/TextBreakIterator.h:

(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::lastCharacter):
(WebCore::LazyLineBreakIterator::secondToLastCharacter):
(WebCore::LazyLineBreakIterator::setPriorContext):
(WebCore::LazyLineBreakIterator::updatePriorContext):
(WebCore::LazyLineBreakIterator::resetPriorContext):
(WebCore::LazyLineBreakIterator::resetStringAndReleaseIterator):
Store previous characters as prior context buffer used directly
by line break iterator implementation. Rename members to reflect
somewhat more general usage. Also fix bad indentations.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
Use renamed line break iterator methods.

4:17 PM Changeset in webkit [147505] by eae@chromium.org
  • 3 edits
    2 adds in trunk

Padding applied twice for empty generated RenderInlines
​https://bugs.webkit.org/show_bug.cgi?id=113800

Source/WebCore:

Reviewed by Levi Weintraub.

The padding for empty generated content render objects is
incorrectly applied twice. Regression from r140693.

Test: fast/css-generated-content/margin-empty-content.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::inlineLogicalWidth):

LayoutTests:

Reviewed by Levi Weintraub.

Add test for empty generated content with padding.

  • fast/css-generated-content/margin-empty-content-expected.html: Added.
  • fast/css-generated-content/margin-empty-content.html: Added.
4:10 PM Changeset in webkit [147504] by leviw@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: InlineIterator needs to be updated when RenderCombineText shrinks at a line break
​https://bugs.webkit.org/show_bug.cgi?id=113733

Reviewed by Emil A Eklund.

Update stale InlineIterators that point beyond the end of a RenderCombineText that's
shrunk when RenderCombineText::combineText() is called.

Test: fast/text/international/combine-at-line-break-crash.html

  • rendering/BidiRun.h:

(WebCore::BidiRun::BidiRun): Adding an assertion that runs are created within
the bounds of their associated RenderText.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::iteratorIsBeyondEndOfRenderCombineText): Added.
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Update stale iterators.

LayoutTests: InlineIterator needs to be updated when RenderCombineText shrinks at a line break
​https://bugs.webkit.org/show_bug.cgi?id=113732

Reviewed by Emil A Eklund.

  • fast/text/international/combine-at-line-break-crash-expected.txt: Added.
  • fast/text/international/combine-at-line-break-crash.html: Added.
3:51 PM Changeset in webkit [147503] by jochen@chromium.org
  • 3 edits in trunk/LayoutTests

Use cross-port testRunner methods in fast/loader/url-selected-user-gesture.html
​https://bugs.webkit.org/show_bug.cgi?id=113827

Reviewed by Benjamin Poulain.

  • fast/loader/url-selected-user-gesture-expected.txt:
  • fast/loader/url-selected-user-gesture.html:
3:31 PM Changeset in webkit [147502] by mvujovic@adobe.com
  • 18 edits
    6 copies
    12 adds
    2 deletes in trunk

[CSS Filters] Filter outsets clipped on composited layers when filter is applied after first layout
​https://bugs.webkit.org/show_bug.cgi?id=109098

Reviewed by Dean Jackson.

Source/WebCore:

This patch addresses the following issues:
(1) Compositors who can compute their own filter outsets don't need WebKit to inflate the

composited layer bounds. Eventually, all platforms' compositors should be able to
compute their own filter outsets.

(2) When filter outsets change, we need to update composited layer bounds if the filters are

painted in software.

(3) When filter outsets change, we need to recompute the overlap map to promote the correct

layers to composited layers on all platforms.

Tests: css3/filters/composited-layer-bounds-after-sw-blur-animation.html

css3/filters/composited-layer-bounds-with-composited-blur.html
css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change.html
css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow.html
css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow.html

  • platform/graphics/IntRectExtent.h:

(WebCore::IntRectExtent::isZero):
(IntRectExtent):

Make isZero public on IntRectExtent.

  • rendering/RenderLayer.cpp:

(WebCore::hasOrHadFilters):

Helper function used to exit early from filters related code.

(WebCore::RenderLayer::updateFilters):

Move filter updating code from RenderLayer::styleChanged into this new method.

This method calls RenderLayerBacking::updateFilters instead of
RenderLayerBacking::updateGraphicsLayerGeometry. RenderLayerBacking::updateFilters lets
us know whether there was a filter paint mode change (i.e. the filters were painted in
software and are now painted in the compositor, or vice-versa). We need to know this
earlier, in RenderLayer::styleChanged, because we may need to rebuild the compositing
layers due to a filter paint mode change.

(WebCore::RenderLayer::styleChanged):

Add a condition for filters for setCompositingLayersNeedRebuild. If the filter outsets
on a layer changed, we need to rebuild the compositing layers because there could be new
overlap. Likewise, if there are or were filter outsets and the filter paint mode changed
the layer bounds (and child positions) may have changed. In either case, we don't
rebuild the compositing layers if there is an accelerated filter animation running.

Remove old code to detect a filter paint mode change from the end of
RenderLayer::styleChanged because it could never be executed. The old code counted on
RenderLayerBacking::canCompositeFilters to change on its own, but it doesn't change
unless updateFilters gets called. Thus, we could never enter the if statement that
calls setBackingNeedsRepaint.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateFilters):

Now return true if there was a filter paint mode change, so RenderLayer::styleChanged
can decide if it should rebuild the compositing layers.

Call updateOrRemoveFilterEffectRenderer and setContentsNeedDisplay if there was a
render mode change. We need to either destroy or create the software renderer and we
need to repaint the layer contents if there was a render mode change.

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Don't call updateFilters here. Call it earlier in RenderLayer::styleChanged, for reasons
explained above.

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

Make updateFilters public so RenderLayer::styleChanged can call it.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds):

If the platform's compositor computes filter outsets for its layers internally, do not
inflate WebKit's composited bounds for filter outsets. This results in smaller layers
on Safari. Note that we still need to include filter outsets in layer bounds for other
situations like overlap testing in WebKit and when we're painting filters in software.

Source/WTF:

  • wtf/Platform.h:

Add flag for HAVE(COMPOSITOR_FILTER_OUTSETS) macro. This is used to check if a
platform's compositor expands layers internally for filter outsets when it applies
filters like drop-shadow and blur. Currently, only CoreAnimation does has this
capability.

LayoutTests:

  • compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
  • compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:

The above tests needed rebaselining because we're now using smaller layers on Safari.
We aren't inflating layers for filter outsets since CoreAnimation does it for us
already.

  • css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt: Added.
  • css3/filters/composited-layer-bounds-after-sw-blur-animation.html: Added.
  • css3/filters/composited-layer-bounds-with-composited-blur-expected.txt: Added.
  • css3/filters/composited-layer-bounds-with-composited-blur.html: Added.
  • css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt: Added.
  • css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change.html: Added.
  • css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt: Added.
  • css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow.html: Added.
  • css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt: Added.
  • css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow.html: Added.

The above tests are all new. They mostly test edge cases with filter render mode
changes, filter outset changes, and composited layer promotion due to overlap.

Before this patch, composited-layer-bounds-after-sw-blur-animation.html breaks
visibly on Safari WebKit nightly. The blur filter in the test appears clipped before
this patch. The other tests render the same before and after this patch, but now their
layer sizes are smaller.

  • css3/filters/filter-change-repaint-composited-expected.png:
  • css3/filters/filter-change-repaint-composited.html:

This test has been expanded with two more cases, including the original reproduction of
this bug. The test needs rebaselining on Chromium Linux and Win.

  • platform/chromium-win/css3/filters/filter-change-repaint-composited-expected.png: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added.
  • platform/chromium/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added.
  • platform/chromium/css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt: Added.
  • platform/chromium/css3/filters/composited-layer-bounds-with-composited-blur-expected.txt: Added.
  • platform/chromium/css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt: Added.
  • platform/chromium/css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt: Added.
  • platform/chromium/css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt: Added.

We need different expectations for Chromium for the new tests because layer bounds
include filter outsets on Chromium but not on Safari.

  • platform/chromium/css3/filters/filter-change-repaint-composited-expected.png: Added.
  • platform/qt/TestExpectations:

Note that we need baselines on Qt for the new and updated tests.

2:52 PM Changeset in webkit [147501] by benjamin@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed, rolling out r147423.

The change r147402 was reverted by r147450.
The rebaseline introduced by r147423 needs to be reverted.

  • platform/mac-wk2/http/tests/security/XFrameOptions: Removed.
  • platform/mac-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
  • platform/mac/http/tests/security/XFrameOptions: Removed.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
2:49 PM Changeset in webkit [147500] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac][WK2] Don’t let plug-ins use System V shared memory
​https://bugs.webkit.org/show_bug.cgi?id=113466
<rdar://problem/13159030>

Reviewed, tweaked and landed by Alexey Proskuryakov.

Instead of allowing plug-ins to request System V shm, give them a
temporary but usable alternative if they try to request it.

  • PluginProcess/mac/PluginProcessShim.mm:
2:31 PM WebKitGTK/2.0.x edited by Martin Robinson
(diff)
2:24 PM Changeset in webkit [147499] by Martin Robinson
  • 9 edits in trunk

[GTK] Make libsecret optional
​https://bugs.webkit.org/show_bug.cgi?id=113821

Reviewed by Gustavo Noronha Silva.

.:

Add a configuration option to disable credential storage and thus remove
the libsecret dependency. This should make it possible to build WebKit 2.x
on Windows again.

  • Source/autotools/FindDependencies.m4: Only look for libsecret if credential storage is active.
  • Source/autotools/PrintBuildConfiguration.m4: Print whether or not credential storage is active.
  • Source/autotools/ReadCommandLineArguments.m4: Added an option to control credential storage.
  • Source/autotools/SetupAutoconfHeader.m4: Expose credential storage setting to code.

Source/WebCore:

Don't try to use libsecret if credential storage is disabled.

  • platform/gtk/GRefPtrGtk.cpp: Protect libsecret sections.
  • platform/gtk/GRefPtrGtk.h: Ditto.
  • platform/network/gtk/CredentialBackingStore.cpp: Ditto.
2:23 PM Changeset in webkit [147498] by Nate Chapin
  • 2 edits
    8 adds
    4 deletes in trunk/LayoutTests

Unreviewed, chromium gardening.

  • platform/chromium-linux/css3/filters/effect-reference-composite-expected.png: Removed.
  • platform/chromium-linux/css3/filters/effect-reference-composite-expected.txt: Removed.
  • platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.png: Removed.
  • platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.txt: Removed.
  • platform/chromium-mac/css3/filters/effect-reference-composite-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-composite-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-reference-composite-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-composite-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-reference-composite-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-reference-composite-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-reference-composite-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-reference-composite-hw-expected.txt: Added.
  • platform/chromium/TestExpectations:
2:21 PM Changeset in webkit [147497] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] API update for IntRect
​https://bugs.webkit.org/show_bug.cgi?id=113824

Patch by Maxim Mogilnitsky <​mmogilnitsky@rim.com> on 2013-04-02
Reviewed by Rob Buis.

Modifing IntRect and FloatRect API.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::regionForTextQuads):

2:19 PM Changeset in webkit [147496] by benjamin@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed, rolling out r147423.
​http://trac.webkit.org/changeset/147423
​https://bugs.webkit.org/show_bug.cgi?id=113775

The change r147402 was reverted by r147450.
The rebaseline introduced by r147423 needs to be reverted.

  • platform/mac-wk2/http/tests/security/XFrameOptions: Removed.
  • platform/mac-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
  • platform/mac/http/tests/security/XFrameOptions: Removed.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
2:18 PM Changeset in webkit [147495] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[CSS Exclusions] refactor shape-outside code to use isFloatingWithShapeOutside() helper method
​https://bugs.webkit.org/show_bug.cgi?id=113799

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-04-02
Reviewed by Dirk Schulze.

When reviewing my patch for bug 110349, Julien mentioned that the
common test for floating with shape outside should be factored out.
This patch does that.

No new functionality, so no new tests.

  • rendering/ExclusionShapeOutsideInfo.cpp:

(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Use helper method.

  • rendering/RenderBox.h:

(WebCore::RenderBox::exclusionShapeOutsideInfo): Ditto.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly): Ditto.

  • rendering/RenderObject.h:

(WebCore::RenderObject::hasPaintOffset): Ditto.
(WebCore::RenderObject::isFloatingWithShapeOutside): Add method to

encapsulate the common test.

1:49 PM Changeset in webkit [147494] by jer.noble@apple.com
  • 3 edits
    4 adds in trunk/Source/WebCore

Add platform AudioSession and iOS platform-specific code.
​https://bugs.webkit.org/show_bug.cgi?id=113813
<rdar://problem/11701792>

Reviewed by Eric Carlson.

Replace the deprecated AudioToolbox AudioSession APIs with the new AVAudioSession API.
To protect against exposing platform specific intrinsics to cross-platform code, add a
platform generic class AudioSession, with port-specific implementations. A default
implementation is provided.

Add a new listener interface to receive interruption notifications:

  • platform/audio/AudioSessionListener.h: Added.

(WebCore::AudioSessionListener::AudioSessionListener):
(WebCore::AudioSessionListener::~AudioSessionListener):

Add a platform generic AudioSession class:

  • platform/audio/AudioSession.cpp: Added.

(AudioSession::sharedSession): AudioSession is a singleton object, and this is its accessor.
(AudioSession::addListener): Add the parameter to the listeners set.
(AudioSession::removeListener): Remove the parameter from the listers set.
(AudioSession::beganAudioInterruption): Iterate over the parameters.
(AudioSession::endedAudioInterruption): Ditto.
(AudioSession::AudioSession): Empty stub.
(AudioSession::~AudioSession): Ditto.
(AudioSession::setCategory): Ditto.
(AudioSession::category): Ditto.
(AudioSession::sampleRate): Ditto.
(AudioSession::numberOfOutputChannels): Ditto.
(AudioSession::setActive): Ditto.
(AudioSession::preferredBufferDuration): Ditto.
(AudioSession::setPreferredBufferDuration): Ditto.

  • platform/audio/AudioSession.h: Added.

Add IOS-specific AudioSession implementation:

  • platform/audio/ios/AudioSessionIOS.mm: Added.

(-[WebAudioSessionHelper initWithCallback:WebCore::]): Register for interruption notifications.
(-[WebAudioSessionHelper dealloc]): Unregister for interruption notifications.
(-[WebAudioSessionHelper interruption:]): Pass to AudioSession.
(WebCore::AudioSessionPrivate::AudioSessionPrivate): Private storage for AudioSessionIOS.
(WebCore::AudioSession::AudioSession): Create AudioSessionPrivate and WebAudioSessionHelper.
(WebCore::AudioSession::~AudioSession): Simple destructor.
(WebCore::AudioSession::setCategory): Check the current categoryOverride, and refuse to overwrite

"MediaPlayback" with "AmbientSound".

(WebCore::AudioSession::setCategoryOverride): Simple setter.
(WebCore::AudioSession::categoryOverride): Simple getter.
(WebCore::AudioSession::category): Pass to AVAudioSession.
(WebCore::AudioSession::sampleRate): Ditto.
(WebCore::AudioSession::numberOfOutputChannels): Ditto.
(WebCore::AudioSession::setActive): Ditto.
(WebCore::AudioSession::preferredBufferDuration): Ditto.
(WebCore::AudioSession::setPreferredBufferDuration): Ditto.

Use the new AudioSession class in place of explicit AudioToolbox or AVAudioSession calls:

  • platform/audio/ios/AudioDestinationIOS.cpp:

(WebCore::AudioDestination::hardwareSampleRate): Pass to AudioSession.
(WebCore::AudioDestination::maxChannelCount): Ditto.
(WebCore::AudioDestinationIOS::AudioDestinationIOS): Register for listeners and activate.
(WebCore::AudioDestinationIOS::~AudioDestinationIOS): Unregister and deactivate.
(WebCore::AudioDestinationIOS::configure): Use AudioSession to set the buffer length.

  • platform/audio/ios/AudioDestinationIOS.h:

Add the new files to the project:

  • WebCore.xcodeproj/project.pbxproj:
1:47 PM Changeset in webkit [147493] by jer.noble@apple.com
  • 2 edits
    3 adds in trunk/Source/WebCore

Upstream AudioDestinationIOS.
​https://bugs.webkit.org/show_bug.cgi?id=113806

Reviewed by Eric Carlson.

Upstream AudioDestinationIOS from the iOS repository.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/ios/AudioDestinationIOS.cpp: Added.

(WebCore::audioDestinations):
(WebCore::AudioDestination::create):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestination::maxChannelCount):
(WebCore::AudioDestinationIOS::AudioDestinationIOS):
(WebCore::AudioDestinationIOS::~AudioDestinationIOS):
(WebCore::AudioDestinationIOS::configure):
(WebCore::AudioDestinationIOS::audioDestinationInterruptionListener):
(WebCore::AudioDestinationIOS::initializeAudioSession):
(WebCore::AudioDestinationIOS::start):
(WebCore::AudioDestinationIOS::stop):
(WebCore::AudioDestinationIOS::beganAudioInterruption):
(WebCore::AudioDestinationIOS::endedAudioInterruption):
(WebCore::AudioDestinationIOS::render):
(WebCore::AudioDestinationIOS::inputProc):
(WebCore::AudioDestinationIOS::frameSizeChangedProc):

  • platform/audio/ios/AudioDestinationIOS.h: Added.

(AudioDestinationIOS):
(WebCore::AudioDestinationIOS::isPlaying):
(WebCore::AudioDestinationIOS::sampleRate):

1:35 PM Changeset in webkit [147492] by Christophe Dumez
  • 30 edits in trunk

fast/dom/HTMLImageElement/image-alt-text.html and fast/dom/HTMLInputElement/input-image-alt-text.html are failing
​https://bugs.webkit.org/show_bug.cgi?id=94198

Reviewed by Darin Adler.

Source/WebCore:

Fix alt text not being displayed for img elements or input of type
"image" due to insufficient size. imageSizeForError() was adding
padding for the alt text but setImageSizeForAltText() was not. The
issue was occurring in paintReplaced() because the contentWidth() /
contentHeight() would be exactly the same size as the alt text.
However, paintReplaced() first draws an outline rect where the
image should be and then reduces the usable width / height for the
alt text by 2 so that the text does not get printed over the rect
borders. However, after decreasing the usable width / height, there
is no longer enough space to draw the text.

No new tests, already covered by existing tests.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::setImageSizeForAltText): Add padding to the text size
so that the alt text can still be drawn, despite the outline rect
borders. Such padding was already used in imageSizeForError(). Also use
ceilf() for the value returned by Font::width() instead of truncating it.
This is needed because we need to fit the whole text in the image and this
may not be the case if we truncate.
(WebCore::RenderImage::paintReplaced):

LayoutTests:

Rebaseline several test cases that have better result now and add those
tests to TestExpectations for other ports since they will need a
rebaseline.

  • platform/chromium/TestExpectations:
  • platform/efl/fast/block/float/002-expected.png:
  • platform/efl/fast/block/float/017-expected.png:
  • platform/efl/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/efl/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
  • platform/efl/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/efl/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
  • platform/efl/fast/encoding/utf-16-big-endian-expected.png:
  • platform/efl/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/efl/fast/encoding/utf-16-little-endian-expected.png:
  • platform/efl/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/efl/fast/flexbox/023-expected.png:
  • platform/efl/fast/flexbox/024-expected.png:
  • platform/efl/fast/forms/input-value-expected.png:
  • platform/efl/fast/forms/input-value-expected.txt:
  • platform/efl/fast/invalid/012-expected.png:
  • platform/efl/fast/lists/inlineBoxWrapperNullCheck-expected.png:
  • platform/efl/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
  • platform/efl/fast/parser/comment-in-script-expected.png:
  • platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/efl/tables/mozilla/bugs/bug2997-expected.png:
  • platform/efl/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/efl/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
1:24 PM Changeset in webkit [147491] by Raymond Toy
  • 8 edits
    1 add in trunk/Source

Add support for using ARM FFT in WebAudio
​https://bugs.webkit.org/show_bug.cgi?id=109755

Reviewed by Chris Rogers.

Source/WebCore:

No new tests.

  • WebCore.gyp/WebCore.gyp: Add dependency on openmax_dl when use_openmax_dl_fft is enabled.
  • WebCore.gypi: Add source FFTFrameOpenMAXDLAndroid.cpp
  • platform/audio/AudioArray.h:

(WebCore::AudioArray::allocate): Need 32-byte aligntment with the
OpenMAX DL FFT.

  • platform/audio/FFTFrame.h:

(FFTFrame): Support OpenMAX DL FFT

  • platform/audio/FFTFrameStub.cpp: Support OpenMAX DL FFT
  • platform/audio/chromium/FFTFrameOpenMAXDLAndroid.cpp: Added. Implements the

necessary interface using the OpenMAX DL FFT routines.
(WebCore):
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::contextForSize):

Source/WebKit/chromium:

  • features.gypi: Support building with the OpenMAX DL FFT.
1:04 PM Changeset in webkit [147490] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer] Memory leaks in MediaPlayerPrivateGStreamer
​https://bugs.webkit.org/show_bug.cgi?id=113762

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2013-04-02
Reviewed by Philippe Normand.

Don't leak strings returned by gst_element_get_name() and
gst_missing_plugin_message_get_installer_detail().

No new tests. No change in behavior.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

1:00 PM Changeset in webkit [147489] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Add WKContextSetInvalidMessageFunction
​https://bugs.webkit.org/show_bug.cgi?id=113820
<rdar://problem/12679817>

Reviewed by Tim Horton.

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetInvalidMessageFunction):
Call WebContext::didReceiveInvalidMessage.

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::setInvalidMessageCallback):
Set the global variable.

(WebKit::WebContext::didReceiveInvalidMessage):
Construct a message name string and call the invalid message callback.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveInvalidMessage):
Call WebContext::didReceiveInvalidMessage.

12:57 PM Changeset in webkit [147488] by benjamin@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

Rebaseline overflowHidden.html's test results after r147245.

Unreviewed.

The patch r147245 (​https://bugs.webkit.org/show_bug.cgi?id=106143) updated results for

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-02
Reviewed by Tony Chang.
Chromium, but not for the other platforms.

The new results on Mac, EFL and Win match the common reference.

  • platform/efl/fast/table/overflowHidden-expected.txt: Removed.
  • platform/mac/fast/table/overflowHidden-expected.txt: Removed.
  • platform/win-7sp0/fast/table: Removed.
  • platform/win-7sp0/fast/table/overflowHidden-expected.txt: Removed.
12:54 PM Changeset in webkit [147487] by fpizlo@apple.com
  • 3 edits
    1 add in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should have the equivalent of a ValueRecovery
​https://bugs.webkit.org/show_bug.cgi?id=113819

Reviewed by Mark Hahnenberg.

This adds a way of saying that we have a value, we don't want to say what
node the value came from, but we know specifics of how the value is
formatted. This is the LLVM equivalent of DFG's ValueRecovery.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • ftl/FTLFormattedValue.h: Added.

(FTL):
(FormattedValue):
(JSC::FTL::FormattedValue::FormattedValue):
(JSC::FTL::FormattedValue::operator!):
(JSC::FTL::FormattedValue::format):
(JSC::FTL::FormattedValue::value):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
(JSC::FTL::LowerDFGToLLVM::speculateForward):
(JSC::FTL::LowerDFGToLLVM::weakPointer):

12:53 PM Changeset in webkit [147486] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix css style for CC button on android
​https://bugs.webkit.org/show_bug.cgi?id=113815

Patch by Min Qin <​qinmin@chromium.org> on 2013-04-02
Reviewed by Adam Barth.

The default CC button size is 16px as defined in mediaControls.css. Android should use 35px.
This change fixed that problem.
Also fixed a problem that r142947 does not change the display of fullscreen button to -webkit-flex
Android does not run media layout tests currently. Will fix the test expectations when layout tests are run in content shell.

  • css/mediaControlsChromiumAndroid.css:

(video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):

12:52 PM Changeset in webkit [147485] by ap@apple.com
  • 8 edits in trunk/Source

[Mac] Remove WKCreateNSURLConnectionDelegateProxy
​https://bugs.webkit.org/show_bug.cgi?id=113810

Reviewed by Anders Carlsson.

This WKSI function is not used any more.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
12:50 PM Changeset in webkit [147484] by abucur@adobe.com
  • 3 edits in trunk/LayoutTests

[CSS Regions] Remove font-smoothing from fast/regions/region-style-inline-background-color.html
​https://bugs.webkit.org/show_bug.cgi?id=113814

Reviewed by James Robinson.

The test uses font smoothing and makes the test fail on Chromium Mountain Lion. This happens
because of how regions handle overflow and clipping. For now, disable the font smoothing in
the test.

  • fast/regions/region-style-inline-background-color-expected.html:
  • fast/regions/region-style-inline-background-color.html:
12:13 PM Changeset in webkit [147483] by Lucas Forschler
  • 2 edits in trunk/Tools

Disable running tests on the MAC WK2 EWS queue.

Unreviewed.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(MacWK2EWS):

12:06 PM Changeset in webkit [147482] by timothy@apple.com
  • 7 edits in trunk/Source/WebKit

Provide a user default that can be used to disable docking of the Web Inspector.

The user default is "WebKit Web Inspector Setting - inspectorAttachDisabled".

​https://webkit.org/b/113779
rdar://problem/13446021

Reviewed by Joseph Pecoraro.

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

(WebInspectorClient::inspectorAttachDisabled): Added.
(WebInspectorClient::setInspectorAttachDisabled): Added.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient::inspectorAttachDisabled): Added.
(WebInspectorClient::setInspectorAttachDisabled): Added.

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::didResizeMainFrame):
(-[WebInspectorWindowController window]):
(-[WebInspectorWindowController showWindow:]):
Check inspectorAttachDisabled() in places where we attach or update the dock button.

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient::inspectorAttachDisabled): Added.
(WebInspectorClient::setInspectorAttachDisabled): Added.

11:56 AM Changeset in webkit [147481] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should use the right abstract heap for Int32 array accesses
​https://bugs.webkit.org/show_bug.cgi?id=113759

Reviewed by Mark Hahnenberg.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetByVal):

11:54 AM Changeset in webkit [147480] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r147464.
​http://trac.webkit.org/changeset/147464
​https://bugs.webkit.org/show_bug.cgi?id=113812

JSSQLResultSet.cpp:131:24: error: implicit conversion loses
integer precision: 'int64_t' (aka 'long long') to 'int'
[-Werror,-Wshorten-64-to-32] (Requested by xenon on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-04-02

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringValue):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsAttrWithGetterException):
(WebCore::jsTestTypedefsStringAttrWithGetterException):

11:42 AM Changeset in webkit [147479] by pdr@google.com
  • 7 edits in trunk/LayoutTests

Rebaseline svg/as-image/image-respects-pageScaleFactor expectations

Unreviewed rebaseline of test expectations.

  • platform/chromium-linux/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/chromium-mac-lion/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/chromium-mac/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.txt:
11:37 AM Changeset in webkit [147478] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Make Source Frame & status bar a layout boundary
​https://bugs.webkit.org/show_bug.cgi?id=112353

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

No new tests: no change in behaviour.

  • Add View.markAsLayoutBoundary method to mark a view as a layout

boundary. This will force this view to autoupdate its height to actual
pixel value.

  • Mark both CodeMirrorTextEditor and DefaultTextEditor as a layout

boundary.

  • Mark main-status-bar element with a layout-boundary class.
  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):

  • inspector/front-end/DefaultTextEditor.js:
  • inspector/front-end/View.js:

(WebInspector.View.prototype.markAsLayoutBoundary):
(WebInspector.View.prototype._processWillShow):
(WebInspector.View.prototype._processWasShown):
(WebInspector.View.prototype._processOnResize):

  • inspector/front-end/inspector.css:

(.layout-boundary):

  • inspector/front-end/inspector.html:
11:36 AM Changeset in webkit [147477] by danakj@chromium.org
  • 3 edits in trunk/Source/Platform

[chromium] Initialize all fields in WebFilterOperation
​https://bugs.webkit.org/show_bug.cgi?id=113807

Reviewed by James Robinson.

  • chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::WebFilterOperation):

  • chromium/src/WebFilterOperation.cpp:

(WebKit::WebFilterOperation::WebFilterOperation):

11:36 AM Changeset in webkit [147476] by ap@apple.com
  • 9 edits in trunk/Source

<rdar://problem/13551119> [WK2] Crashes in NetworkProcess when canceling loads
​https://bugs.webkit.org/show_bug.cgi?id=113803

Reviewed by Darin Adler.

Stop using a delegate proxy. It hasn't been needed in years, and the extra layer
just adds bugs.

This specific issue gets fixed because connection retains its delegate is retained,
but a proxy does not.

  • WebCore.exp.in:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::releaseDelegate): (WebCore::ResourceHandle::platformLoadResourceSynchronously): Removed code that was dealing with delegate proxy.
11:35 AM Changeset in webkit [147475] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Encapsulate SetEmbedderData/GetEmbedderData
​https://bugs.webkit.org/show_bug.cgi?id=113331

Patch by John J. Barton <​johnjbarton@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

Refactor to encapsulate uses of V8 Set/GetEmbedderData together
with uses of V8 Set/GetAlignedPointerInEmbedderData since these
functions operate on the same underyling array in V8.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::setContextDebugId):
(WebCore::ScriptController::contextDebugId):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::setInjectedScriptContextDebugId):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextDebugData::setContextDebugData):
(WebCore):
(WebCore::V8PerContextDebugData::contextDebugId):
(WebCore::V8PerContextDebugData::createDebugData):
(WebCore::V8PerContextDebugData::getDebugData):
(WebCore::V8PerContextDebugData::setDebugData):

  • bindings/v8/V8PerContextData.h:

(V8PerContextDebugData):
(WebCore):

11:32 AM Changeset in webkit [147474] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Adjust toolbar labels position
​https://bugs.webkit.org/show_bug.cgi?id=113805

Patch by Alexei Filippov <​alph@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

Move the labels 1px up to make them centered.
Also fix font centering in native memory distribution snapshot.

  • inspector/front-end/inspector.css:

(.toolbar-label):

  • inspector/front-end/nativeMemoryProfiler.css:

(.native-snapshot-view .data-grid td):

11:30 AM Changeset in webkit [147473] by Nate Chapin
  • 2 edits in trunk/LayoutTests

Unreviewed, chromium expectations update.

  • platform/chromium/TestExpectations:
11:27 AM Changeset in webkit [147472] by timothy@apple.com
  • 1 edit in trunk/Source/WebCore/rendering/RenderLayer.cpp

Fix Windows build.

11:25 AM Changeset in webkit [147471] by Beth Dakin
  • 13 edits
    2 adds in trunk

Viewport constrained elements should work properly with headers and footers
​https://bugs.webkit.org/show_bug.cgi?id=113743

Reviewed by Simon Fraser.

Source/WebCore:

ScrollableArea::constrainScrollPositionForOverhang() needs to take headerHeight
and footerHeight into account. It also needs to use totalContentsSize() instead of
contentsSize().

Send totalContentsSize() instead of contentsSize() and also send headerHeight()
and footerHeight().

  • page/FrameView.cpp:

(WebCore::FrameView::scrollOffsetForFixedPosition):

  • page/FrameView.h:

(FrameView):

The scrolling tree will also need to know about header and footer heights since it
will need these values to call
ScrollableArea::constrainScrollPositionForOverhang().

  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setHeaderHeight):
(WebCore::ScrollingStateScrollingNode::setFooterHeight):

  • page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::headerHeight):
(ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::footerHeight):

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):

  • page/scrolling/ScrollingTreeScrollingNode.h:

(WebCore::ScrollingTreeScrollingNode::headerHeight):
(WebCore::ScrollingTreeScrollingNode::footerHeight):
(ScrollingTreeScrollingNode):

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollParameters):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinatorMac::setScrollParametersForNode):

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

Use footerHeight when calculating the maxValue and use headerHeight in determining
what the minimum value is.

  • platform/ScrollableArea.cpp:

(WebCore::constrainedScrollPosition):
(WebCore::ScrollableArea::constrainScrollPositionForOverhang):

  • platform/ScrollableArea.h:

(ScrollableArea):

LayoutTests:

  • platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html: Added.
11:23 AM Changeset in webkit [147470] by senorblanco@chromium.org
  • 4 edits
    7 adds in trunk

[Skia] Enable GPU-accelerated Skia path for FEComposite filter.
​https://bugs.webkit.org/show_bug.cgi?id=113797

Reviewed by Adrienne Walker.

Source/WebCore:

Tests: css3/filters/effect-reference-composite-hw.html

css3/filters/effect-reference-composite.html

  • WebCore.gypi:
  • platform/graphics/filters/FEComposite.h:

Enable Skia DAG hook for FEComposite.

  • platform/graphics/filters/skia/FECompositeSkia.cpp: Added.

(WebCore::FEComposite::createImageFilter):
Implement skia DAG builder for FEComposite, and implement generic
skia version of composite filter.

LayoutTests:

  • css3/filters/effect-reference-composite-hw.html: Added.
  • css3/filters/effect-reference-composite.html: Added.
  • platform/chromium-linux/css3/filters/effect-reference-composite-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-reference-composite-expected.txt: Added.
  • platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.txt: Added.
11:20 AM Changeset in webkit [147469] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Avoid using style.display="inline-block"
​https://bugs.webkit.org/show_bug.cgi?id=113802

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

No new tests.

  • Create class "inline-block" which will set "display: inline-block"

style.

  • Use this class with DIV elements to get "inline-block" element.
  • inspector/front-end/ObjectPopoverHelper.js:

(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

  • inspector/front-end/inspector.css:

(.inline-block):

11:18 AM Changeset in webkit [147468] by caseq@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [Timeline] warning markers are not propagated to coalesced records
​https://bugs.webkit.org/show_bug.cgi?id=113789

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/timeline/timeline-coalescing.html

  • inspector/front-end/TimelinePresentationModel.js: set childHasWarning on coalescing record if the record it replaces had warnings.

(WebInspector.TimelinePresentationModel.prototype._replaceWithCoalescedRecord):

LayoutTests:

  • inspector/timeline/timeline-coalescing-expected.txt: Added.
  • inspector/timeline/timeline-coalescing.html: Added.
11:17 AM Changeset in webkit [147467] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Create a selection from two points irregardless of the caret position.
​https://bugs.webkit.org/show_bug.cgi?id=113795

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-04-02
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR276577
If we are to set both the base and extent of a selection, we should maintain the base upon setting the extent.
This prevents us from overwriting the previous calculation when setting extent.
Further, instead of setting and manipulating the selection, simply set up start and end VisiblePositions and
create a new directional selection so as to set the base and extent simultaneously.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setSelection):

11:16 AM Changeset in webkit [147466] by yurys@chromium.org
  • 8 edits
    2 adds in trunk

Web Inspector: memory instrumentation for external strings is broken
​https://bugs.webkit.org/show_bug.cgi?id=113788

Source/WebCore:

Reviewed by Pavel Feldman.

Native memory snapshot now provides information about JS external strings.

Test: inspector/profiler/memory-instrumentation-external-string.html

  • inspector/InspectorMemoryAgent.cpp:

LayoutTests:

Test that native memory snapshot contains information about extenral strings.

Reviewed by Pavel Feldman.

  • inspector/profiler/memory-instrumentation-external-string-expected.txt: Added.
  • inspector/profiler/memory-instrumentation-external-string.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
11:14 AM Changeset in webkit [147465] by yurys@chromium.org
  • 10 edits
    2 adds in trunk

Web Inspector: memory instrumentation for external arrays is broken
​https://bugs.webkit.org/show_bug.cgi?id=113790

Source/WebCore:

Report pointers to external arrays as retaining ones to make sure their
size is counted correctly.

Reviewed by Pavel Feldman.

Test: inspector/profiler/memory-instrumentation-external-array.html

  • inspector/InspectorMemoryAgent.cpp:

Source/WTF:

Reviewed by Pavel Feldman.

  • wtf/MemoryInstrumentationArrayBufferView.h: report buffer pointer as retaining one as

we know that the pointer is not broken.
(WTF::reportMemoryUsage):

LayoutTests:

Test that JS external resources size includes size of JS external arrays
created in the inspected page.

Reviewed by Pavel Feldman.

  • inspector/profiler/memory-instrumentation-external-array-expected.txt: Added.
  • inspector/profiler/memory-instrumentation-external-array.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
11:12 AM Changeset in webkit [147464] by peter@chromium.org
  • 4 edits in trunk/Source/WebCore

[JSC] Don't create a JSValue if it's not going to be used for nullable attributes
​https://bugs.webkit.org/show_bug.cgi?id=112711

Reviewed by Sam Weinig.

When nullable attributes are used, it's possible that we disregard the JSValue
when null should be returned instead. This is a waste, and we should cast the
native type to a JSValue as late as possible.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(NativeValueToLocal):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringValue):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsAttrWithGetterException):
(WebCore::jsTestTypedefsStringAttrWithGetterException):

11:10 AM Changeset in webkit [147463] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[css exclusions] overflow:hidden undoes shape-outside offsets
​https://bugs.webkit.org/show_bug.cgi?id=110349

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-04-02
Reviewed by Julien Chaffraix.

Source/WebCore:

When overflow: hidden was set on a float with shape-outside, the
offset from the shape-outside was being ignored. This was because the
float was being placed in the normal flow, causing the offsets to be
calculated differently. Since floats with shape outside behave like
positioned objects in many places, I have caused them to take the same
behavior as positioned objects in this case as well: the floats with
shape-outside do not get placed in the normal flow when overflow:
hidden is set.

Test: fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly): Floats that have

shape-outside should not be in the normal flow.

LayoutTests:

Add a test to make sure the float is properly positioned with
overflow: hidden.

  • fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden.html: Added.
11:06 AM Changeset in webkit [147462] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.6/Source/WebCore

Merged r147373. <rdar://problem/13202277>

11:04 AM Changeset in webkit [147461] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: resource preview of html/js/css types should be on a grey background
​https://bugs.webkit.org/show_bug.cgi?id=113791

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

No new tests.

  • Add a css rule to set grey background for SourceFrame in resource view.
  • Add "fill" style to SourceFrame element to setup its height.
  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):

  • inspector/front-end/resourceView.css:

(.resource-view .script-view):

11:04 AM Changeset in webkit [147460] by Lucas Forschler
  • 5 edits in tags/Safari-537.35.6/Source

Merged r147359. <rdar://problem/13549181>

11:02 AM Changeset in webkit [147459] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] Editor doesn't have yellow background in DivergedFromVM state
​https://bugs.webkit.org/show_bug.cgi?id=113783

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

No new tests.

Force CodeMirrorTextEditor to have transparent background to inherit
background color from source frame.

  • inspector/front-end/cm/cmdevtools.css:

(.CodeMirror):

11:01 AM Changeset in webkit [147458] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.6/Source

Versioning.

10:59 AM Changeset in webkit [147457] by jparent@chromium.org
  • 10 edits in trunk/Tools

Dashboard refactor: Move dashboard specific history related features to History.
​https://bugs.webkit.org/show_bug.cgi?id=113717

Reviewed by Ojan Vafai.

Each dashboard now creates its own History object, with a custom
configuration. This changes from just overriding global functions
to passing in callbacks for generatePage, handleValidHashParameter,
and handleQueryParameterChange. Same with passing in defaultStateValues
and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
variables.

All functions related to these features are now (mostly) private
function on History.

Loader no longer needs a loadingComplete callback, since it can just
initialize the history object itself.

  • TestResultServer/static-dashboards/aggregate_results.js:

(handleValidHashParameter):

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(generatePage):
(.switch.return):
(handleQueryParameterChange):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):

  • TestResultServer/static-dashboards/history.js:

(.):

  • TestResultServer/static-dashboards/loader.js:

(.):

  • TestResultServer/static-dashboards/loader_unittests.js:
  • TestResultServer/static-dashboards/timeline_explorer.js:

(generatePage):
(initCurrentBuilderTestResults):

  • TestResultServer/static-dashboards/treemap.js:

(generatePage):
(.switch.return):
(handleQueryParameterChange):

10:58 AM Changeset in webkit [147456] by Lucas Forschler
  • 15 edits in tags/Safari-537.35.6

Merged r147260. <rdar://problem/13536343>

10:53 AM Changeset in webkit [147455] by aelias@chromium.org
  • 3 edits in branches/chromium/1410/Source/WebCore

Merge 147389 "Hide non-coordinated scrollbars for Android M26"

Hide non-coordinated scrollbars for Android M26
​https://bugs.webkit.org/show_bug.cgi?id=113738

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-04-01
Reviewed by Simon Fraser.

This patch will hide any non-coordinated scrollbars on Android.
Coordinated scrollbars won't be affected.

Currently all scrollbars are coordinated on Android. The sole purpose
of this patch is to be cherry-picked to the M26 branch.

No new tests. Please revert immediately after landed.

  • platform/ScrollView.cpp:

(WebCore::positionScrollbarLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::positionOverflowControlsLayers):

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/13470017

10:53 AM Changeset in webkit [147454] by jochen@chromium.org
  • 3 edits
    2 adds in trunk

Check whether popups are allowed before creating a new window
​https://bugs.webkit.org/show_bug.cgi?id=113782

Reviewed by Adam Barth.

Source/WebCore:

Otherwise, firing a generated mouse event at an anchor is enough to
work around the popup blocker.

Test: fast/loader/url-selected-user-gesture.html

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy):

LayoutTests:

  • fast/loader/url-selected-user-gesture-expected.txt: Added.
  • fast/loader/url-selected-user-gesture.html: Added.
10:50 AM Changeset in webkit [147453] by jochen@chromium.org
  • 5 edits in trunk

When computing the percentage of the logical height, use the logical top and bottom
​https://bugs.webkit.org/show_bug.cgi?id=113761

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/writing-mode/percentage-height-orthogonal-writing-modes.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):

LayoutTests:

  • fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt:
  • fast/writing-mode/percentage-height-orthogonal-writing-modes.html:
10:50 AM Changeset in webkit [147452] by Lucas Forschler
  • 3 edits in tags/Safari-537.35.6/Source/WebCore

Merged r147240. <rdar://problem/13256956>

10:49 AM Changeset in webkit [147451] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] do not show cursor in read-only mode
​https://bugs.webkit.org/show_bug.cgi?id=113793

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-04-02
Reviewed by Alexander Pavlov.

No new tests.

Pass "nocursor" option to CodeMirror's "readonly" setting.

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.prototype.setReadOnly):

10:47 AM Changeset in webkit [147450] by Nate Chapin
  • 22 edits in trunk

Unreviewed, rolling out r147402.
​http://trac.webkit.org/changeset/147402
​https://bugs.webkit.org/show_bug.cgi?id=112903

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

LayoutTests:

  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
10:45 AM Changeset in webkit [147449] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.6/Source/WebCore

Merged r146995. <rdar://problem/13474743>

10:41 AM Changeset in webkit [147448] by alokp@chromium.org
  • 1 edit
    3 copies in branches/chromium/1453

Merge 147127 "RenderBox::backgroundIsKnownToBeOpaqueInRect may b..."

RenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements
​https://bugs.webkit.org/show_bug.cgi?id=113419

Reviewed by Simon Fraser.

Source/WebCore:

Do not consider control elements as opaque. They are typically theme painted, and we cannot assume opaqueness on the behalf of theme. It can be improved by asking the theme if it paints opaque.

Test: compositing/contents-opaque/control-layer.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

  • compositing/contents-opaque/control-layer-expected.txt: Added.
  • compositing/contents-opaque/control-layer.html: Added.
  • platform/chromium/compositing/contents-opaque/control-layer-expected.txt: Added.

TBR=​alokp@chromium.org
BUG=223490
Review URL: ​https://codereview.chromium.org/13465009

10:35 AM Changeset in webkit [147447] by rniwa@webkit.org
  • 16 edits in trunk/Source/WebKit/mac

WebKit/mac shouldn't have code for Mac 10.5 and earlier
​https://bugs.webkit.org/show_bug.cgi?id=113746

Reviewed by Darin Adler.

Deleted the code for 10.5 and removed if-defs for 10.6.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView createPlugin]):

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView createPlugin]):
(-[WebNetscapePluginView getVariable:forURL:value:length:]):
(-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):

  • WebCoreSupport/WebEditorClient.mm:

(core):
(WebEditorClient::checkTextOfParagraph):
(WebEditorClient::requestCheckingOfString):

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView reflectScrolledClipView:]):

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController _updateMenuAndDockForFullScreen]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
(-[WebHTMLView _frameOrBoundsChanged]):
(+[WebHTMLView _insertablePasteboardTypes]):
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
(writingDirectionKeyBindingsEnabled):
(-[WebHTMLView _lookUpInDictionaryFromMenu:]):
(-[WebHTMLView attachRootLayer:]):

  • WebView/WebHTMLViewInternal.h:
  • WebView/WebPDFDocumentExtras.mm:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebResourceInternal.h:
  • WebView/WebScriptDebugDelegate.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _preferencesChanged:]):
(+[WebView initialize]):
(clientNeedsWebViewInitThreadWorkaround):
(-[WebView validateUserInterfaceItemWithoutDelegate:]):
(-[WebView setGrammarCheckingEnabled:]):
(-[WebView isAutomaticQuoteSubstitutionEnabled]):
(-[WebView isAutomaticLinkDetectionEnabled]):
(-[WebView isAutomaticDashSubstitutionEnabled]):
(-[WebView isAutomaticTextReplacementEnabled]):
(-[WebView isAutomaticSpellingCorrectionEnabled]):
(-[WebView _searchWithSpotlightFromMenu:]):
(WebInstallMemoryPressureHandler):

  • WebView/WebViewPrivate.h:
10:28 AM Changeset in webkit [147446] by fpizlo@apple.com
  • 8 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support fast property stores
​https://bugs.webkit.org/show_bug.cgi?id=113757

Reviewed by Oliver Hunt.

Simplified the task of handling property transitions and reduced amount of code
duplication between the JITs.

Added PutByOffset, PutStructure, PhantomPutStructure, WeakJSConstant, and a
stub form of StructureTransitionWatchpoint to the FTL.

Also simplified the creation of pointer constants, and fixed a bug in
speculateObject().

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::notifyCompilingStructureTransition):
(Graph):

  • dfg/DFGJITCompiler.h:

(JITCompiler):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileWeakJSConstant):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileStructureTransitionWatchpoint):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compilePhantomPutStructure):
(JSC::FTL::LowerDFGToLLVM::compilePutByOffset):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::weakPointer):

  • ftl/FTLOutput.h:

(Output):
(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::absolute):

10:24 AM Changeset in webkit [147445] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

webkit fails IETC grid-column-002
​https://bugs.webkit.org/show_bug.cgi?id=83907

Unreviewed Mac test expectation fix.

  • platform/mac/TestExpectations:

Removed grid-column-002.htm here too.

10:21 AM Changeset in webkit [147444] by Nate Chapin
  • 2 edits in trunk/LayoutTests

Unreviewed, chromium expectations update.

  • platform/chromium/TestExpectations: Mark svg/as-image/image-respects-pageScaleFactor.html as flaky.
10:16 AM Changeset in webkit [147443] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[GTK][AC] Support preserves3D css property for clutter ac backend.
​https://bugs.webkit.org/show_bug.cgi?id=113318

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-02
Reviewed by Gustavo Noronha Silva.

This patch brings preserve-3D css property support to WebKitGtk+ with clutter ac backed.
Most of the code is based on Mac port's implementation. The core concept is that
if a layer has preserve-3d property false, we mark itself and its immediate children
to make them flatten. And then we remove 3D factor in a modelView matrix
when applying it to each actor.

No new tests as this is covered with existing AC tests.

  • platform/graphics/clutter/GraphicsLayerActor.cpp:

(_GraphicsLayerActorPrivate):
(graphics_layer_actor_init):
(graphicsLayerActorApplyTransform):
(graphicsLayerActorNew):
(graphicsLayerActorRemoveFromSuperLayer):
(graphicsLayerActorSetDrawsContent):
(graphicsLayerActorSetFlatten):

  • platform/graphics/clutter/GraphicsLayerActor.h:
  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::platformLayer):
(WebCore::GraphicsLayerClutter::moveOrCopyAnimations):
(WebCore):
(WebCore::GraphicsLayerClutter::setPreserves3D):
(WebCore::GraphicsLayerClutter::flushCompositingState):
(WebCore::GraphicsLayerClutter::recursiveCommitChanges):
(WebCore::GraphicsLayerClutter::commitLayerChangesAfterSublayers):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::updateGeometry):
(WebCore::GraphicsLayerClutter::updateSublayerList):
(WebCore::GraphicsLayerClutter::updateStructuralLayer):
(WebCore::GraphicsLayerClutter::ensureStructuralLayer):
(WebCore::GraphicsLayerClutter::structuralLayerPurpose):
(WebCore::GraphicsLayerClutter::layerForSuperlayer):

  • platform/graphics/clutter/GraphicsLayerClutter.h:

(CommitState):
(WebCore::GraphicsLayerClutter::CommitState::CommitState):
(GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::primaryLayer):

10:10 AM Changeset in webkit [147442] by Lucas Forschler
  • 1 copy in tags/Safari-537.35.6

New Tag.

9:14 AM Changeset in webkit [147441] by adamk@chromium.org
  • 8 edits
    5 adds in trunk

HTML parser should consistently inspect the namespace of elements on the stack of open elements
​https://bugs.webkit.org/show_bug.cgi?id=113723

Reviewed by Adam Barth.

Source/WebCore:

Added HTMLStackItem::matchesHTMLTag method and use that nearly
everywhere instead of HTMLStackItem::hasLocalName. The most important
of these changes is in HTMLElementStack's inScopeCommon() function,
where the use of matchesHTMLTag means that any of the inXXXScope()
calls now only match HTML tags.

Tests: html5lib/generated/run-namespace-sensitivity-data.html

html5lib/generated/run-namespace-sensitivity-write.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::popUntil):
(WebCore::HTMLElementStack::topmost):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::inScope):
(WebCore::HTMLElementStack::inListItemScope):
(WebCore::HTMLElementStack::inTableScope):
(WebCore::HTMLElementStack::inButtonScope):
(WebCore::HTMLElementStack::inSelectScope):

  • html/parser/HTMLElementStack.h:

(WebCore::HTMLElementStack::popUntilPopped):

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::closestElementInScopeWithName):

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::matchesHTMLTag):
(HTMLStackItem):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):

LayoutTests:

  • html5lib/generated/run-namespace-sensitivity-data-expected.txt: Added.
  • html5lib/generated/run-namespace-sensitivity-data.html: Added.
  • html5lib/generated/run-namespace-sensitivity-write-expected.txt: Added.
  • html5lib/generated/run-namespace-sensitivity-write.html: Added.
  • html5lib/resources/namespace-sensitivity.dat: Added.
9:00 AM Changeset in webkit [147440] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

Report memory usage for ShadowDistributedRules.
​https://bugs.webkit.org/show_bug.cgi?id=109882

Reviewed by Dimitri Glazkov.

This is a follow-up patch for r142855.

No new tests, no behavior change for layout tests.

  • css/DocumentRuleSets.cpp:

(WebCore):
(WebCore::ShadowDistributedRules::reportMemoryUsage):
(WebCore::DocumentRuleSets::reportMemoryUsage):

  • css/DocumentRuleSets.h:

(ShadowDistributedRules):

8:58 AM Changeset in webkit [147439] by Chris Fleizach
  • 6 edits
    2 adds in trunk

AX: Need to get line thickness from fraction on web
​https://bugs.webkit.org/show_bug.cgi?id=113720

Reviewed by David Kilzer.

Expose the line thickness property for fractions, which is needed to
help determine the type of equation.

Test: platform/mac/accessibility/mathml-line-fraction.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::mathLineThickness):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::mathLineThickness):
(WebCore):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityMathLineThickness]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

8:48 AM Changeset in webkit [147438] by wangxianzhu@chromium.org
  • 2 edits in branches/chromium/1453/Source

Merge 147178 "[Chromium] Don't create SolidColorLayer for full t..."

[Chromium] Don't create SolidColorLayer for full transparent background
​https://bugs.webkit.org/show_bug.cgi?id=113524

Reviewed by James Robinson.

Source/WebCore:

Test: GraphicsLayerChromiumTest.setContentsToSolidColor

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToSolidColor):

Source/WebKit/chromium:

  • tests/GraphicsLayerChromiumTest.cpp:

(GraphicsLayerChromiumTest::setContentsToSolidColor):

TBR=​wangxianzhu@chromium.org
Review URL: ​https://codereview.chromium.org/13430007

8:43 AM Changeset in webkit [147437] by abucur@adobe.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed.

Enable fast/regions/region-style-inline-background-color.html on Mountain Lion as it started to pass.

  • platform/chromium/TestExpectations:
8:24 AM Changeset in webkit [147436] by aelias@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r147389.
​http://trac.webkit.org/changeset/147389
​https://bugs.webkit.org/show_bug.cgi?id=113738

r147389 was temporary patch for Chromium branch management, needs
revert.

  • platform/ScrollView.cpp:

(WebCore::positionScrollbarLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::positionOverflowControlsLayers):

8:21 AM Changeset in webkit [147435] by senorblanco@chromium.org
  • 4 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

New results for effect-reference-hw, due to slight pixel differences from ​http://src.chromium.org/viewvc/chrome?view=rev&revision=191067

  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium/TestExpectations:
8:18 AM Changeset in webkit [147434] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Hang when calling setCurrentTime on SVG with cyclic animation dependency chain
​https://bugs.webkit.org/show_bug.cgi?id=113485

Patch by David Vest <​davve@opera.com> on 2013-04-02
Reviewed by Stephen Chenney.

Source/WebCore:

If no exact match can be found, approximateBinarySearch may return
either adjacent value to the key. Selecting the lesser value when
there is a greater one may cause interval creation to fail in a
way that causes infinite loops during seeking. Detect and amend
this condition by selecting the greater value when possible.

Test: svg/animations/animation-dependency-hang.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::findInstanceTime):

LayoutTests:

  • svg/animations/animation-dependency-hang-expected.txt: Added.
  • svg/animations/animation-dependency-hang.html: Added.
7:58 AM Changeset in webkit [147433] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: source location gets frozen after inspector reload
​https://bugs.webkit.org/show_bug.cgi?id=113776

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

Put statusBarText item in its own container and update its contents in
ScriptsPanel._updateScriptViewStatusBarItems in similar way it's done
for statusBarItems.

No new tests.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.statusBarText):
(WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):

7:47 AM Changeset in webkit [147432] by jesus@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unneeded cpp file from CMake build. Rubber-stamp by Alexis Menard.

  • CMakeLists.txt: Remove FFTFrameStub.cpp, since adding this file or not

to your build is a platform decision.

7:44 AM Changeset in webkit [147431] by caseq@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [Timeline] unify logic for 3 overview modes in Timeline
​https://bugs.webkit.org/show_bug.cgi?id=113708

Reviewed by Yury Semikhatsky.

  • make TimelineOverviewPane logic independent on overview mode;
  • show only one of 3 controls at one time;
  • attach overview controls to the same parent.
  • inspector/front-end/OverviewGrid.js: remove gridElement() and itemsGraphsElement(), no longer needed.

(WebInspector.OverviewGrid):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._innerSetMode):
(WebInspector.TimelineOverviewPane.prototype._createOverviewControl):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.addFrame):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineOverviewBase.prototype.update):
(WebInspector.TimelineOverviewBase.prototype.reset):
(WebInspector.TimelineOverviewBase.prototype.categoryVisibilityChanged):
(WebInspector.TimelineOverviewBase.prototype.addFrame):
(WebInspector.TimelineOverviewBase.prototype.getWindowTimes):
(WebInspector.TimelineEventOverview):
(WebInspector.TimelineEventOverview.prototype.categoryVisibilityChanged):

  • inspector/front-end/timelinePanel.css:
7:41 AM Changeset in webkit [147430] by jchaffraix@webkit.org
  • 11 edits
    1 add in trunk

webkit fails IETC grid-column-002
​https://bugs.webkit.org/show_bug.cgi?id=83907

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/css-grid-layout/grid-item-column-row-get-set.html

ietestcenter/css3/grid/grid-column-002.htm

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
Don't accept 0 as a valid <integer> position.

LayoutTests:

  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:

Extended our testing to cover setting grid-{start|end|before|after} to 0.

  • ietestcenter/css3/grid/grid-column-002.htm:
  • ietestcenter/css3/grid/testRunnerEnableGrid.js: Added.

Needed to dynamically enable CSS Grid Layout for the test to pass. The file
hosts the boiler-plate code which will be common to all tests.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:

Removed grid-column-002.htm from the test expectations.

7:36 AM Changeset in webkit [147429] by thiago.santos@intel.com
  • 3 edits
    5 adds
    4 deletes in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl-wk2/TestExpectations:
  • platform/efl-wk2/fast/repaint/caret-with-transformation-expected.png: Added.
  • platform/efl-wk2/fast/repaint/caret-with-transformation-expected.txt: Added.
  • platform/efl-wk2/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/efl-wk2/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
  • platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
  • platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
  • platform/efl-wk2/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/efl-wk2/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • platform/efl/TestExpectations:
7:28 AM Changeset in webkit [147428] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: allow referencing of nodes that have not been pushed to the front-end
​https://bugs.webkit.org/show_bug.cgi?id=110921

Patch by Dmitry Gozman <​dgozman@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

Nodes not yet pushed to front-end are referenced by BackendNodeId and retained.
One can group nodes when generating BackendNodeIds to release them all together later.

To resolve node references by BackendNodeId, frontend should use new pushNodeByBackendIdToFrontend method.
This will invalidate the generated BackendNodeId.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::backendNodeIdForNode):
(WebCore::InspectorDOMAgent::releaseBackendNodeIds):
(WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend):

  • inspector/InspectorDOMAgent.h:

(WebCore):
(InspectorDOMAgent):

7:28 AM Changeset in webkit [147427] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Web Inspector: Update test expectation for console-cross-origin-iframe-logging.html
​https://bugs.webkit.org/show_bug.cgi?id=113756

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02
Reviewed by Pavel Feldman.

Simplified errors by not including the whole URL after r145692.

  • http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
  • platform/efl/TestExpectations:
  • platform/qt/TestExpectations:
6:48 AM Changeset in webkit [147426] by abucur@adobe.com
  • 10 edits
    8 adds in trunk

[CSS Regions] Nested auto-height regions don't layout correctly
​https://bugs.webkit.org/show_bug.cgi?id=111969

Reviewed by David Hyatt.

Source/WebCore:

The patch fixes the auto-height regions processing model to work with nested named flows. Currently
this use case doesn't work correctly because the order in which the computed height value is propagated
to the regions is incorrect. For example, in the case of two flows (f1 and f2) and two auto-height
regions (r1 and r2) with r2 a member of f1:

  1. the normal layout phase starts
  2. r1 is laid out with height = 0
  3. f1 is laid out including r2 with height = 0; overrideLogicalHeight for r1 is computed
  4. f2 is laid out; overrideLogicalHeight for r2 is computed
  5. the constrained layout phase starts
  6. r1 is laid out using the overrideLogicalHeight computed in the normal phase
  7. f1 is laid out including r2 with its overrideLogicalHeight
  8. f2 is laid out

The problem appears at step 6 because the overrideLogicalheight computed during step 3 assumes r2
has a height of 0. The patch changes the algorithm to update the auto-height regions in the reverse
order of their flow threads dependecies. Here is a high level overview of the new algorithm,
considering the named flows are sorted in the order of their dependencies:

  1. The flows are laid out from the outer flow to the inner flow. This successfully computes the outer

non-auto-height regions size so the inner flows have the necessary information to correctly fragment
the content.

  1. The flows are laid out from the inner flow to the outer flow. After an inner flow is laid out it

goes into the constrained layout phase and marks the auto-height regions they need layout. This
means the outer flows will relayout if they depend on regions with auto-height regions belonging to
inner flows. This step will correctly compute the overrideLogicalHeights for the auto-height regions.
It's possible for non-auto-height regions to relayout if they depend on auto-height regions. This
will invalidate the inner flow threads and mark them as needing layout.

  1. The last step is to do one last layout if there are pahtological dependencies between non-auto-height

regions and auto-height regions as detected in the previous step.

The patch also removes the layout phase flag from RenderView and moves it to the flow threads. This
happens because a flow needs to update its auto-height regions overrideLogicalHeight while updating
the logical height of the regions belonging to the inner flows that are laid out by the flow (i.e. the
outer flow is in the normal phase while the inner flows are in the constrained layout phase).

There's also a new flag on the RenderFlowThread that is set when the flow needs the constrained layout
phase. This could have been placed on the flow thread controller but I think it will be useful when doing
content balancing for the new multi-column implementation.

Another change is the moment we clear the overrideLogicalHeight value on empty auto-height regions because
we don't have to relayout a flow thread once it's in the constrained phase. We need to have the correct
flow thread portions correctly computed after the artificial forced break is applied at the end of the content.

Tests: fast/regions/autoheight-mixed-nested-complex-regions.html

fast/regions/autoheight-mixed-nested-regions.html
fast/regions/autoheight-mixed-parallel-regions.html
fast/regions/autoheight-nested-regions.html

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):
(WebCore):
(WebCore::FlowThreadController::registerNamedFlowContentNode):
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):
(WebCore::FlowThreadController::updateFlowThreadsChainIfNecessary):
(WebCore::FlowThreadController::updateFlowThreadsNeedingLayout):
(WebCore::FlowThreadController::updateFlowThreadsNeedingTwoStepLayout):
(WebCore::FlowThreadController::resetFlowThreadsWithAutoHeightRegions):
(WebCore::FlowThreadController::updateFlowThreadsIntoConstrainedPhase):

  • rendering/FlowThreadController.h:

(FlowThreadController):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::applyBreakAfterContent): Apply an artificial break at the end of the content.
This way we can detect when the content ends and clear the overrideLogicalHeight on the empty auto-height regions.
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore):
(WebCore::RenderFlowThread::initializeRegionsOverrideLogicalContentHeight):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::pageLogicalWidth):
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::maxPageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::updateLogicalHeight):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore):
(WebCore::RenderView::layoutContentInAutoLogicalHeightRegions):
(WebCore::RenderView::layout):

  • rendering/RenderView.h:

(WebCore):
(RenderView):

LayoutTests:

These tests cover various combinations of dependencies between flows and regions with
or without auto-height.

  • fast/regions/autoheight-mixed-nested-complex-regions-expected.txt: Added.
  • fast/regions/autoheight-mixed-nested-complex-regions.html: Added.
  • fast/regions/autoheight-mixed-nested-regions-expected.txt: Added.
  • fast/regions/autoheight-mixed-nested-regions.html: Added.
  • fast/regions/autoheight-mixed-parallel-regions-expected.txt: Added.
  • fast/regions/autoheight-mixed-parallel-regions.html: Added.
  • fast/regions/autoheight-nested-regions-expected.txt: Added.
  • fast/regions/autoheight-nested-regions.html: Added.
6:46 AM Changeset in webkit [147425] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: ignore minimum record duration filter in Timeline overview
​https://bugs.webkit.org/show_bug.cgi?id=113705

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelineOverviewPane.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._durationFilterChanged):

6:45 AM Changeset in webkit [147424] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

Web Inspector: add tests for grouped messages filtration in console.
​https://bugs.webkit.org/show_bug.cgi?id=113766

Added console groups to console filter test. Fixed minor bugs in other tests.

Patch by Dmitry Zvorygin <​zvorygin@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

  • inspector/console/console-filter-test-expected.txt:
  • inspector/console/console-filter-test.html:
  • inspector/console/console-preserve-log.html:
  • inspector/console/console-tests-expected.txt:
  • inspector/console/console-tests.html:
6:44 AM Changeset in webkit [147423] by mkwst@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

[Mac] Unreviewed gardening.
​https://bugs.webkit.org/show_bug.cgi?id=113775

Tests need platform-specific rebaselines after r147402. :(

  • platform/mac-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
6:19 AM Changeset in webkit [147422] by caseq@chromium.org
  • 9 edits in trunk

Web Inspector: display the number of dirty render objects in Layout timeline event
​https://bugs.webkit.org/show_bug.cgi?id=95331

Reviewed by Pavel Feldman.

Source/WebCore:

Count the render objects that need layout in InspectorTimelineAgent::willLayout()
and display the number in popover over Layout record in Timeline panel.

  • English.lproj/localizedStrings.js:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::didLayout):

  • inspector/TimelineRecordFactory.cpp:

(WebCore):
(WebCore::TimelineRecordFactory::createLayoutData):
(WebCore::TimelineRecordFactory::appendLayoutRoot):

  • inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):

LayoutTests:

  • inspector/timeline/timeline-layout-expected.txt: rebaselined to include new properties;
6:15 AM Changeset in webkit [147421] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] Popover for codemirror
​https://bugs.webkit.org/show_bug.cgi?id=113771

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

Implement methods TextEditor.cursorPositionToCoordinates, TextEditor.coordinatesToCursorPosition and
TextEditor.tokenAtTextPosition in CodeMirrorTextEditor to support popover
functionality. Add css classes to highlight popover anchoring text.

No new tests.

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.prototype.cursorPositionToCoordinates):
(WebInspector.CodeMirrorTextEditor.prototype.coordinatesToCursorPosition):
(WebInspector.CodeMirrorTextEditor.prototype.tokenAtTextPosition):

  • inspector/front-end/cm/cmdevtools.css:

(.CodeMirror .source-frame-eval-expression):
(.CodeMirror .source-frame-eval-expression-end):
(.CodeMirror .source-frame-eval-expression-start):

5:56 AM Changeset in webkit [147420] by thiago.santos@intel.com
  • 2 edits
    60 adds
    1 delete in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl-wk2/TestExpectations:
  • platform/efl-wk2/compositing/contents-opaque/control-layer-expected.txt: Added.
  • platform/efl-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt: Added.
  • platform/efl-wk2/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
  • platform/efl-wk2/compositing/rtl/rtl-overflow-scrolling-expected.png: Added.
  • platform/efl-wk2/compositing/rtl/rtl-overflow-scrolling-expected.txt: Added.
  • platform/efl-wk2/css3/flexbox/flexbox-baseline-expected.png: Added.
  • platform/efl-wk2/css3/flexbox/flexbox-baseline-expected.txt: Added.
  • platform/efl-wk2/editing/pasteboard/copy-paste-content-starting-and-ending-canvas-expected.txt: Added.
  • platform/efl-wk2/editing/pasteboard/pasting-into-p-should-not-nest-p-expected.txt: Added.
  • platform/efl-wk2/editing/selection/move-by-character-6-expected.txt: Removed.
  • platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt: Added.
  • platform/efl-wk2/fast/dom/icon-url-property-expected.txt: Added.
  • platform/efl-wk2/fast/dynamic/002-expected.txt: Added.
  • platform/efl-wk2/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
  • platform/efl-wk2/fast/media/mq-resolution-expected.txt: Added.
  • platform/efl-wk2/fast/media/w3c/test_media_queries-expected.txt: Added.
  • platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/efl-wk2/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/efl-wk2/fast/repaint/moving-shadow-on-path-expected.txt: Added.
  • platform/efl-wk2/fast/table/overflowHidden-expected.txt: Added.
  • platform/efl-wk2/fast/text/complex-text-opacity-expected.png: Added.
  • platform/efl-wk2/fast/text/complex-text-opacity-expected.txt: Added.
  • platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.png: Added.
  • platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
  • platform/efl-wk2/fast/transforms/bounding-rect-zoom-expected.txt: Added.
  • platform/efl-wk2/http/tests/inspector/console-resource-errors-expected.txt: Added.
  • platform/efl-wk2/http/tests/security/xssAuditor/link-opens-new-window-expected.txt: Added.
  • platform/efl-wk2/inspector/styles/paste-property-expected.txt: Added.
  • platform/efl-wk2/svg/css/composite-shadow-example-expected.txt: Added.
  • platform/efl-wk2/svg/css/composite-shadow-with-opacity-expected.txt: Added.
  • platform/efl-wk2/tables/mozilla/bugs/bug73321-expected.txt: Added.
  • platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.png: Added.
  • platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
  • platform/efl-wk2/transforms/2d/hindi-rotated-expected.png: Added.
  • platform/efl-wk2/transforms/2d/hindi-rotated-expected.txt: Added.
5:50 AM Changeset in webkit [147419] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for two Resource Timing layout tests

that regressed with r147387.

5:39 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu
Qt Mountain Lion bot moved to Apple master (diff)
5:16 AM Changeset in webkit [147418] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Implement ScrollingCoordinator::frameViewLayoutUpdated()
​https://bugs.webkit.org/show_bug.cgi?id=113763

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-04-02
Reviewed by Rob Buis.

PR 318945
Internally reviewed by Jakob Petsovits.

And remove the BlackBerry specific methods
frameViewFrameRectDidChange and frameViewContentsSizeDidChange.

  • page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp:

(WebCore::ScrollingCoordinatorBlackBerry::frameViewLayoutUpdated):
Called when the frame view has been laid out. Update the contents
rectangle and visible area of the scroll layer for the given frame
view.

  • page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.h:

(ScrollingCoordinatorBlackBerry):

  • platform/graphics/blackberry/LayerWebKitThread.h:

(WebCore::LayerWebKitThread::setFrameVisibleRect): Return early if
value hasn't changed.
(WebCore::LayerWebKitThread::setFrameContentsSize): Ditto.

5:06 AM Changeset in webkit [147417] by zarvai@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing tests after r147384 and r147388.

  • platform/qt/TestExpectations:
  • platform/qt/fast/table/overflowHidden-expected.txt: Rebaselining after 147374.
3:58 AM Changeset in webkit [147416] by zandobersek@gmail.com
  • 4 edits in trunk

Unreviewed, rolling out r147401.
​http://trac.webkit.org/changeset/147401
​https://bugs.webkit.org/show_bug.cgi?id=113767

The patch makes it extremely hard to set up the dependencies
properly on the GTK builders (Requested by zdobersek on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-04-02

.:

  • Source/autotools/Versions.m4:

Tools:

  • gtk/jhbuild.modules:
3:49 AM Changeset in webkit [147415] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Separate JavaScriptSourceFrame popover from knowledge of editor's DOM
​https://bugs.webkit.org/show_bug.cgi?id=113412

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

  • Use TextEditor.coordinatesToCursorPosition,

TextEditor.cursorPositionToCoordinates and TextEditor.tokenAtTextPosition to figure out
hovering area and create popover anchor.

  • Use TextEditor.highlightRange/TextEditor.removeHighlight methods to

highlight hovering text in editor.

No new tests: no change in behaviour.

  • inspector/front-end/DefaultTextEditor.js:
  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.willHide):
(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype.):
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):

  • inspector/front-end/inspector.css:

(.popover-anchor):
(.source-frame-eval-expression):

3:33 AM Changeset in webkit [147414] by mihnea@adobe.com
  • 10 edits in trunk/Source/WebCore

[CSSRegions] RenderFlowThread should not be created as a Document renderer
​https://bugs.webkit.org/show_bug.cgi?id=113658

Reviewed by Julien Chaffraix.

After ​https://bugs.webkit.org/show_bug.cgi?id=107138, RenderFlowThread should not be constructed as a renderer for Document.
Since it does not have an element associated, it will be constructed using the pattern for anonymous blocks.
However, since I do not want the flow thread to be collapsed as anonymous blocks are, i changed RenderObject::isAnonymousBlock
to return false for a RenderFlowThread (the alternative would have been to patch more call sites to prevent RenderFlowThread
collapsing as anonymous block).

Covered by existing tests.

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):

  • rendering/RenderFlowThread.h:
  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::addChild):

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
(WebCore::RenderMultiColumnFlowThread::createAnonymous):

  • rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::createAnonymous):
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):

  • rendering/RenderNamedFlowThread.h:

(RenderNamedFlowThread):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isAnonymousBlock):

3:21 AM Changeset in webkit [147413] by shinyak@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r147383.
​http://trac.webkit.org/changeset/147383
​https://bugs.webkit.org/show_bug.cgi?id=112369

Speculative rollout because of lots of layout test failure

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::~HTMLDocumentParser):
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::insert):

  • html/parser/HTMLParserScheduler.cpp:

(WebCore::PumpSession::PumpSession):

  • html/parser/HTMLParserScheduler.h:
2:52 AM Changeset in webkit [147412] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [HeapProfiler] Table rows do not appear when resizing.
​https://bugs.webkit.org/show_bug.cgi?id=113760

Reviewed by Yury Semikhatsky.

Analysis: custom-made split-view doesn't notify content panes about
resizing.

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype._updateRetainmentViewHeight):
Notify content pane about resize.

2:50 AM Changeset in webkit [147411] by mihnea@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSSRegions] Clean-up RenderFlowThread::updateRegionsFlowThreadPortionRect
​https://bugs.webkit.org/show_bug.cgi?id=113659

Reviewed by Julien Chaffraix.

RenderRegion::logicalHeightOfAllFlowThreadContent already contains the
override logical content height for auto-height regions in normal layout phase.
Therefore, there is no need to explicitly override region's rect height with
the region's overrideLogicalContentHeight as the region rect already contains
the right value.

No change in functionality, covered by existing tests.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):

2:50 AM Changeset in webkit [147410] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Empty tooltip shown when hovering over popup menu items
​https://bugs.webkit.org/show_bug.cgi?id=113382

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2013-04-02
Reviewed by Gyuyoung Kim.

Do not show the empty tooltip box if the text is null.

  • MiniBrowser/efl/main.c:

(popup_menu_populate):

2:47 AM Changeset in webkit [147409] by zarvai@inf.u-szeged.hu
  • 14 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r147402.

  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • platform/qt/TestExpectations:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
2:33 AM Changeset in webkit [147408] by shinyak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

rebaselined after r147390.

TestExpectation was deleted wrongly. Let me revert it.

  • platform/chromium/TestExpectations:
2:08 AM Changeset in webkit [147407] by shinyak@chromium.org
  • 1 edit
    7 adds
    15 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

rebaselined after r147390.

  • platform/chromium-linux-x86/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Removed.
  • platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug625-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/td_valign_bottom-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
  • platform/chromium-linux/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
  • platform/chromium-mac-lion/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
2:01 AM Changeset in webkit [147406] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[QT] Cleanup after r139447 and r145374.
​https://bugs.webkit.org/show_bug.cgi?id=113671

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02

  • platform/qt/TestExpectations:
1:49 AM Changeset in webkit [147405] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[Qt]REGRESSION?(r63191): http/tests/inspector/resource-har-conversion.html fails
​https://bugs.webkit.org/show_bug.cgi?id=42162

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02
Reviewed by Csaba Osztrogonác.

Copy the results of http/tests/inspector/resource-har-conversion.html
to the qt platform dir.

  • platform/qt/TestExpectations:
  • platform/qt/http/tests/inspector/resource-har-conversion-expected.txt: Added.
1:33 AM Changeset in webkit [147404] by shinyak@chromium.org
  • 159 edits
    7 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

rebaselined after r147390.

  • platform/chromium-linux-x86/tables/mozilla/bugs/bug625-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium/TestExpectations:
1:32 AM Changeset in webkit [147403] by mikhail.pozdnyakov@intel.com
  • 82 edits in trunk/Source/WebKit2

[WK2] Remove repeating code in declaration of WK2 API classes
​https://bugs.webkit.org/show_bug.cgi?id=112782

Reviewed by Benjamin Poulain.

The following two lines of code had been repeated in every WK2 API
object class:
1) static const Type APIType = SomeAPIType;
2) virtual Type type() const { return APIType; }

This patch introduces template class 'TypedAPIObject' inherited
from WebKit::APIObject and it contains the common functionality.
So the new pattern is that API object classes are inherited from
TypedAPIObject (rather than from WebKit::APIObject directly) passing
the corresponding API object type as a template parameter.

The existing API object classes are modified accordingly to the
proposed pattern.

  • Shared/APIObject.h:

(WebKit):
(TypedAPIObject):
(WebKit::TypedAPIObject::~TypedAPIObject):
(WebKit::TypedAPIObject::TypedAPIObject):

  • Shared/ImmutableArray.h:

(ImmutableArray):

  • Shared/ImmutableDictionary.h:

(ImmutableDictionary):

  • Shared/WebArchive.h:

(WebArchive):

  • Shared/WebArchiveResource.h:

(WebArchiveResource):

  • Shared/WebBackForwardListItem.h:

(WebBackForwardListItem):

  • Shared/WebBatteryStatus.h:

(WebBatteryStatus):

  • Shared/WebCertificateInfo.h:
  • Shared/WebConnection.h:

(WebConnection):

  • Shared/WebContextMenuItem.h:

(WebContextMenuItem):

  • Shared/WebData.h:
  • Shared/WebError.h:

(WebKit::WebError::errorCode):

  • Shared/WebGeolocationPosition.h:

(WebGeolocationPosition):

  • Shared/WebGeometry.h:
  • Shared/WebGraphicsContext.h:

(WebGraphicsContext):

  • Shared/WebHitTestResult.h:
  • Shared/WebImage.h:

(WebImage):

  • Shared/WebNetworkInfo.h:

(WebNetworkInfo):

  • Shared/WebNumber.h:
  • Shared/WebOpenPanelParameters.h:

(WebOpenPanelParameters):

  • Shared/WebRenderLayer.h:
  • Shared/WebRenderObject.h:
  • Shared/WebSecurityOrigin.h:
  • Shared/WebSerializedScriptValue.h:

(WebSerializedScriptValue):

  • Shared/WebString.h:
  • Shared/WebURL.h:
  • Shared/WebURLRequest.h:

(WebURLRequest):

  • Shared/WebURLResponse.h:

(WebURLResponse):

  • Shared/WebUserContentURLPattern.h:
  • Shared/mac/ObjCObjectGraph.h:
  • UIProcess/Authentication/AuthenticationChallengeProxy.h:

(AuthenticationChallengeProxy):

  • UIProcess/Authentication/AuthenticationDecisionListener.h:

(AuthenticationDecisionListener):

  • UIProcess/Authentication/WebCredential.h:

(WebCredential):

  • UIProcess/Authentication/WebProtectionSpace.h:

(WebProtectionSpace):

  • UIProcess/Downloads/DownloadProxy.h:

(DownloadProxy):

  • UIProcess/GeolocationPermissionRequestProxy.h:

(GeolocationPermissionRequestProxy):

  • UIProcess/Notifications/NotificationPermissionRequest.h:

(NotificationPermissionRequest):

  • UIProcess/Notifications/WebNotification.h:

(WebNotification):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

  • UIProcess/Plugins/WebPluginSiteDataManager.h:

(WebPluginSiteDataManager):

  • UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

  • UIProcess/WebBackForwardList.h:

(WebBackForwardList):

  • UIProcess/WebBatteryManagerProxy.h:

(WebBatteryManagerProxy):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebCookieManagerProxy.h:

(WebCookieManagerProxy):

  • UIProcess/WebDatabaseManagerProxy.h:

(WebDatabaseManagerProxy):

  • UIProcess/WebEditCommandProxy.h:

(WebEditCommandProxy):

  • UIProcess/WebFrameProxy.h:

(WebFrameProxy):

  • UIProcess/WebGeolocationManagerProxy.h:

(WebGeolocationManagerProxy):

  • UIProcess/WebGrammarDetail.h:

(WebGrammarDetail):

  • UIProcess/WebIconDatabase.h:

(WebIconDatabase):

  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

  • UIProcess/WebKeyValueStorageManagerProxy.h:

(WebKeyValueStorageManagerProxy):

  • UIProcess/WebMediaCacheManagerProxy.h:

(WebMediaCacheManagerProxy):

  • UIProcess/WebNavigationData.h:

(WebNavigationData):

  • UIProcess/WebNetworkInfoManagerProxy.h:

(WebNetworkInfoManagerProxy):

  • UIProcess/WebOpenPanelResultListenerProxy.h:

(WebOpenPanelResultListenerProxy):

  • UIProcess/WebPageGroup.h:

(WebPageGroup):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::WebPreferences):

  • UIProcess/WebPreferences.h:

(WebPreferences):

  • UIProcess/WebResourceCacheManagerProxy.h:

(WebResourceCacheManagerProxy):

  • UIProcess/WebTextChecker.h:

(WebTextChecker):

  • UIProcess/WebVibrationProxy.h:

(WebVibrationProxy):

  • UIProcess/efl/WebPopupItemEfl.h:

(WebPopupItemEfl):

  • UIProcess/efl/WebView.h:
  • UIProcess/soup/WebSoupRequestManagerProxy.h:

(WebSoupRequestManagerProxy):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

(InjectedBundleNodeHandle):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:

(InjectedBundleRangeHandle):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebProcess/InjectedBundle/InjectedBundleBackForwardList.h:
  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h:

(InjectedBundleDOMWindowExtension):

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:

(InjectedBundleNavigationAction):

  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:

(InjectedBundleScriptWorld):

  • WebProcess/WebPage/PageOverlay.h:

(PageOverlay):

  • WebProcess/WebPage/WebFrame.h:

(WebFrame):

  • WebProcess/WebPage/WebInspector.h:

(WebInspector):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPageGroupProxy.h:

(WebPageGroupProxy):

1:28 AM Changeset in webkit [147402] by mkwst@chromium.org
  • 22 edits in trunk

X-Frame-Options: Blocked frames should not inherit their parent's SecurityOrigin.
​https://bugs.webkit.org/show_bug.cgi?id=112903

Reviewed by Adam Barth.

Source/WebCore:

This change brings WebKit in line with IE and Gecko's behavior, both of
which treat the blocked frame as being cross-origin for the purposes of
access checks ('[frame].contentWindow.location.href' is inaccessible,
for example).

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

Rather than redirecting to 'about:blank', redirect to
'data:text/html,<p></p>' which does not inherit the SecurityOrigin
of the parent.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

Before calling cancelMainResourceLoad, ensure that the frame's
document is sandboxed into a unique origin so that it doesn't
inherit the parent's SecurityOrigin.

LayoutTests:

  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
1:25 AM Changeset in webkit [147401] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] Bump required versions of some dependencies
​https://bugs.webkit.org/show_bug.cgi?id=113282

Reviewed by Martin Robinson.

.:

This patch updates the following dependencies:

  • libsoup 2.42.0: is the current stable release.
  • glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
  • gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
  • at-spi2 2.5.3: is the version required by gtk+ 3.6.
  • GObject introspection 1.32.0: is the version required by gtk+ 3.6.
  • Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
  • Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
  • gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
  • Source/autotools/Versions.m4:

Tools:

  • gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1:21 AM Changeset in webkit [147400] by shinyak@chromium.org
  • 224 edits
    2 copies
    13 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

rebaselined after r147390.

  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png.
  • platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/clip-mask-negative-scale-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
  • platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
  • platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
  • platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
1:12 AM Changeset in webkit [147399] by shinyak@chromium.org
  • 121 edits
    2 copies
    1 add in trunk/LayoutTests

[Chromium] Unreviewed gardening.

rebaselined after r147390.

  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
1:02 AM Changeset in webkit [147398] by shinyak@chromium.org
  • 77 edits
    5 adds
    4 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

rebaselined after r147390.

  • platform/chromium-linux-x86/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Removed.
  • platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-win/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-win/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
12:53 AM Changeset in webkit [147397] by shinyak@chromium.org
  • 9 edits
    1 move
    1 add in trunk/LayoutTests

[Chromium] Unreviewed gardening.

rebaselined after r147390.

  • platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-win/css3/images/cross-fade-background-size-expected.png: Renamed from LayoutTests/platform/chromium/css3/images/cross-fade-background-size-expected.png.
12:11 AM Changeset in webkit [147396] by commit-queue@webkit.org
  • 3 edits in trunk

[EFL][CMAKE] Move MOZ_X11 definition from OptionsCommon to OptionsEfl
​https://bugs.webkit.org/show_bug.cgi?id=113685

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-04-02
Reviewed by Martin Robinson.

MOZ_X11 is added unconditionally in OptionsCommon for UNIX
platforms, but not all UNIX platforms use X11 for plugins,
BlackBerry doesn't. The only port using cmake that uses X11 is EFL
and it already has checks for X11, so we can just move the
definition to OptionsEfl.

  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/OptionsEfl.cmake:
Note: See TracTimeline for information about the timeline view.