Timeline
Apr 4, 2013:
- 11:55 PM Changeset in webkit [147714] by
-
- 1 edit1 delete in trunk/Source/WebKit
Remove Webkit/chromium
https://bugs.webkit.org/show_bug.cgi?id=113998
Reviewed by Ryosuke Niwa.
O Knights of Ni, you are just and fair, and we will return with a shrubbery.
- chromium: Removed.
- 11:46 PM Changeset in webkit [147713] by
-
- 2 edits in trunk/Source/WebCore
WinCairo build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=113873
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-04
Reviewed by Brent Fulgham.
Removed double guards for USE(ACCELERATED_COMPOSITING),
and moved methods out of USE(ACCELERATED_COMPOSITING) guard to fix linker errors.
- page/FrameView.cpp:
(WebCore::FrameView::setWantsLayerForTopOverHangArea):
(WebCore::FrameView::setWantsLayerForBottomOverHangArea):
(WebCore::FrameView::setWantsLayerForHeader):
(WebCore::FrameView::setWantsLayerForFooter):
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):
- 11:39 PM Changeset in webkit [147712] by
-
- 1 edit2 deletes in trunk
Remove the top level gyp directory and Platform/chromium
https://bugs.webkit.org/show_bug.cgi?id=113999
Reviewed by Benjamin Poulain.
.:
- Source/Platform: Removed.
- Source/gyp: Removed.
Source/Platform:
- Platform.gyp: Removed.
- Platform.gyp/.gitignore: Removed.
- Platform.gyp/Platform.gyp: Removed.
- Platform.gypi: Removed.
- chromium: Removed.
- chromium/public: Removed.
- chromium/public/Platform.h: Removed.
- chromium/public/WebAnimation.h: Removed.
- chromium/public/WebAnimationCurve.h: Removed.
- chromium/public/WebAnimationDelegate.h: Removed.
- chromium/public/WebAudioBus.h: Removed.
- chromium/public/WebAudioDestinationConsumer.h: Removed.
- chromium/public/WebAudioDevice.h: Removed.
- chromium/public/WebBlobData.h: Removed.
- chromium/public/WebBlobRegistry.h: Removed.
- chromium/public/WebCString.h: Removed.
- chromium/public/WebCanvas.h: Removed.
- chromium/public/WebClipboard.h: Removed.
- chromium/public/WebColor.h: Removed.
- chromium/public/WebCommon.h: Removed.
- chromium/public/WebCompositorOutputSurface.h: Removed.
- chromium/public/WebCompositorSupport.h: Removed.
- chromium/public/WebContentLayer.h: Removed.
- chromium/public/WebContentLayerClient.h: Removed.
- chromium/public/WebCookie.h: Removed.
- chromium/public/WebCookieJar.h: Removed.
- chromium/public/WebData.h: Removed.
- chromium/public/WebDiscardableMemory.h: Removed.
- chromium/public/WebDragData.h: Removed.
- chromium/public/WebExternalTextureLayer.h: Removed.
- chromium/public/WebExternalTextureLayerClient.h: Removed.
- chromium/public/WebFileError.h: Removed.
- chromium/public/WebFileInfo.h: Removed.
- chromium/public/WebFileSystem.h: Removed.
- chromium/public/WebFileSystemCallbacks.h: Removed.
- chromium/public/WebFileSystemEntry.h: Removed.
- chromium/public/WebFileSystemType.h: Removed.
- chromium/public/WebFileUtilities.h: Removed.
- chromium/public/WebFilterOperation.h: Removed.
- chromium/public/WebFilterOperations.h: Removed.
- chromium/public/WebFlingAnimator.h: Removed.
- chromium/public/WebFloatAnimationCurve.h: Removed.
- chromium/public/WebFloatKeyframe.h: Removed.
- chromium/public/WebFloatPoint.h: Removed.
- chromium/public/WebFloatQuad.h: Removed.
- chromium/public/WebFloatRect.h: Removed.
- chromium/public/WebFloatSize.h: Removed.
- chromium/public/WebGamepad.h: Removed.
- chromium/public/WebGamepads.h: Removed.
- chromium/public/WebGestureCurve.h: Removed.
- chromium/public/WebGestureCurveTarget.h: Removed.
- chromium/public/WebGraphicsContext3D.h: Removed.
- chromium/public/WebGraphicsMemoryAllocation.h: Removed.
- chromium/public/WebGraphicsMemoryStats.h: Removed.
- chromium/public/WebHTTPBody.h: Removed.
- chromium/public/WebHTTPHeaderVisitor.h: Removed.
- chromium/public/WebHTTPLoadInfo.h: Removed.
- chromium/public/WebHyphenator.h: Removed.
- chromium/public/WebImage.h: Removed.
- chromium/public/WebImageLayer.h: Removed.
- chromium/public/WebInputHandler.h: Removed.
- chromium/public/WebInputHandlerClient.h: Removed.
- chromium/public/WebLayer.h: Removed.
- chromium/public/WebLayerPositionConstraint.h: Removed.
- chromium/public/WebLayerScrollClient.h: Removed.
- chromium/public/WebLayerTreeView.h: Removed.
- chromium/public/WebLocalizedString.h: Removed.
- chromium/public/WebMediaConstraints.h: Removed.
- chromium/public/WebMediaStream.h: Removed.
- chromium/public/WebMediaStreamCenter.h: Removed.
- chromium/public/WebMediaStreamCenterClient.h: Removed.
- chromium/public/WebMediaStreamSource.h: Removed.
- chromium/public/WebMediaStreamSourcesRequest.h: Removed.
- chromium/public/WebMediaStreamTrack.h: Removed.
- chromium/public/WebMessagePortChannel.h: Removed.
- chromium/public/WebMessagePortChannelClient.h: Removed.
- chromium/public/WebMimeRegistry.h: Removed.
- chromium/public/WebNonCopyable.h: Removed.
- chromium/public/WebPluginListBuilder.h: Removed.
- chromium/public/WebPoint.h: Removed.
- chromium/public/WebPrerender.h: Removed.
- chromium/public/WebPrerenderingSupport.h: Removed.
- chromium/public/WebPrivateOwnPtr.h: Removed.
- chromium/public/WebPrivatePtr.h: Removed.
- chromium/public/WebRTCConfiguration.h: Removed.
- chromium/public/WebRTCDTMFSenderHandler.h: Removed.
- chromium/public/WebRTCDTMFSenderHandlerClient.h: Removed.
- chromium/public/WebRTCDataChannelHandler.h: Removed.
- chromium/public/WebRTCDataChannelHandlerClient.h: Removed.
- chromium/public/WebRTCICECandidate.h: Removed.
- chromium/public/WebRTCPeerConnectionHandler.h: Removed.
- chromium/public/WebRTCPeerConnectionHandlerClient.h: Removed.
- chromium/public/WebRTCSessionDescription.h: Removed.
- chromium/public/WebRTCSessionDescriptionRequest.h: Removed.
- chromium/public/WebRTCStatsRequest.h: Removed.
- chromium/public/WebRTCStatsResponse.h: Removed.
- chromium/public/WebRTCVoidRequest.h: Removed.
- chromium/public/WebRect.h: Removed.
- chromium/public/WebReferrerPolicy.h: Removed.
- chromium/public/WebRenderingStats.h: Removed.
- chromium/public/WebScreenInfo.h: Removed.
- chromium/public/WebScrollbar.h: Removed.
- chromium/public/WebScrollbarLayer.h: Removed.
- chromium/public/WebScrollbarThemeGeometry.h: Removed.
- chromium/public/WebScrollbarThemePainter.h: Removed.
- chromium/public/WebSize.h: Removed.
- chromium/public/WebSocketStreamError.h: Removed.
- chromium/public/WebSocketStreamHandle.h: Removed.
- chromium/public/WebSocketStreamHandleClient.h: Removed.
- chromium/public/WebSolidColorLayer.h: Removed.
- chromium/public/WebSpeechSynthesisUtterance.h: Removed.
- chromium/public/WebSpeechSynthesisVoice.h: Removed.
- chromium/public/WebSpeechSynthesizer.h: Removed.
- chromium/public/WebSpeechSynthesizerClient.h: Removed.
- chromium/public/WebStorageArea.h: Removed.
- chromium/public/WebStorageNamespace.h: Removed.
- chromium/public/WebString.h: Removed.
- chromium/public/WebThread.h: Removed.
- chromium/public/WebThreadSafeData.h: Removed.
- chromium/public/WebTransformAnimationCurve.h: Removed.
- chromium/public/WebTransformKeyframe.h: Removed.
- chromium/public/WebTransformOperations.h: Removed.
- chromium/public/WebURL.h: Removed.
- chromium/public/WebURLError.h: Removed.
- chromium/public/WebURLLoadTiming.h: Removed.
- chromium/public/WebURLLoader.h: Removed.
- chromium/public/WebURLLoaderClient.h: Removed.
- chromium/public/WebURLRequest.h: Removed.
- chromium/public/WebURLResponse.h: Removed.
- chromium/public/WebUnitTestSupport.h: Removed.
- chromium/public/WebVector.h: Removed.
- chromium/public/WebWorkerRunLoop.h: Removed.
- chromium/public/android: Removed.
- chromium/public/android/WebSandboxSupport.h: Removed.
- chromium/public/android/WebThemeEngine.h: Removed.
- chromium/public/default: Removed.
- chromium/public/default/WebThemeEngine.h: Removed.
- chromium/public/linux: Removed.
- chromium/public/linux/WebFontFamily.h: Removed.
- chromium/public/linux/WebFontInfo.h: Removed.
- chromium/public/linux/WebFontRenderStyle.h: Removed.
- chromium/public/linux/WebSandboxSupport.h: Removed.
- chromium/public/mac: Removed.
- chromium/public/mac/WebSandboxSupport.h: Removed.
- chromium/public/mac/WebThemeEngine.h: Removed.
- chromium/public/win: Removed.
- chromium/public/win/WebSandboxSupport.h: Removed.
- chromium/public/win/WebThemeEngine.h: Removed.
- chromium/src: Removed.
- chromium/src/Platform.cpp: Removed.
- chromium/src/WebActiveGestureAnimation.cpp: Removed.
- chromium/src/WebActiveGestureAnimation.h: Removed.
- chromium/src/WebCString.cpp: Removed.
- chromium/src/WebFilterOperation.cpp: Removed.
- chromium/src/WebFilterOperations.cpp: Removed.
- chromium/src/WebFloatQuad.cpp: Removed.
- chromium/src/WebPrerenderingSupport.cpp: Removed.
- chromium/src/WebString.cpp: Removed.
- 11:20 PM Changeset in webkit [147711] by
-
- 2 edits in trunk/Tools
Remove ChromiumPublicApi pattern, and cc/message rules for it.
- Scripts/webkitpy/common/config/watchlist:
- 11:05 PM Changeset in webkit [147710] by
-
- 37 edits in trunk/Source/WebCore
Remove code for 10.5 and earlier from Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=113754
Reviewed by Benjamin Poulain.
Removed the code for 10.5 and removed if-def for 10.6.
- WebCore.xcodeproj/project.pbxproj:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
- platform/LocalizedStrings.cpp:
(WebCore::imageTitle):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setAllowsFontSmoothing):
- platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::clear):
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::boundingRect):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore):
(WebCore::FontPlatformData::ctFont):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::supportsFullscreen):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
- platform/graphics/mac/FontCacheMac.mm:
(WebCore):
(WebCore::fontCacheRegisteredFontsChangedNotificationCallback):
(WebCore::FontCache::platformInit):
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::supportsFullscreen):
(WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):
(WebCore::MediaPlayerPrivateQTKit::cacheMovieScale):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
- platform/graphics/mac/WebLayer.h:
- platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor):
- platform/mac/DisplaySleepDisabler.cpp:
(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
(WebCore):
- platform/mac/DisplaySleepDisabler.h:
(DisplaySleepDisabler):
- platform/mac/EmptyProtocolDefinitions.h:
- platform/mac/HTMLConverter.h:
- platform/mac/HTMLConverter.mm:
- platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenuMac::populate):
- platform/mac/ScrollElasticityController.mm:
(systemUptime):
- platform/mac/SharedTimerMac.mm:
(PowerObserver):
(WebCore::PowerObserver::PowerObserver):
(WebCore::PowerObserver::~PowerObserver):
(WebCore::PowerObserver::didReceiveSystemPowerNotification):
- platform/mac/SuddenTermination.mm:
- platform/mac/WebCoreFullScreenWindow.mm:
(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
- platform/mac/WebFontCache.mm:
(+[WebFontCache getTraits:inFamily:]):
(+[WebFontCache internalFontWithFamily:traits:weight:size:]):
- platform/mac/WebVideoFullscreenController.mm:
(SOFT_LINK_POINTER):
(-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
- platform/mac/WebVideoFullscreenHUDWindowController.mm:
(createControlWithMediaUIControlType):
(-[WebVideoFullscreenHUDWindowController windowDidLoad]):
- platform/network/Credential.h:
- platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
- platform/network/cf/ProxyServerCFNet.cpp:
(WebCore):
(WebCore::proxyServersForURL):
- platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::chooseProxy):
- platform/network/mac/AuthenticationMac.mm:
(WebCore):
- platform/network/mac/WebCoreURLResponse.mm:
(WebCore::adjustMIMETypeIfNecessary):
- platform/text/TextChecking.h:
(WebCore):
- 10:36 PM Changeset in webkit [147709] by
-
- 3 edits in trunk/Tools
Temporarily disable the Python unittests broken by the commit queue not running layout tests
https://bugs.webkit.org/show_bug.cgi?id=113997
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Ryosuke Niwa.
Disable the tests until Ryosuke gets the time and hardware to have
a testing commit-queue.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(CommitQueueTaskTest):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(CommitQueueTest):
- 10:24 PM Changeset in webkit [147708] by
-
- 2 edits in trunk/Source/WebCore
Qt build fix attempt after r147684.
- html/canvas/CanvasRenderingContext.cpp:
- 10:17 PM Changeset in webkit [147707] by
-
- 2 edits in trunk/Tools
Remove Chromium builders from build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=113990
Reviewed by Benjamin Poulain.
Land the part to disable triggering of Chromium builders first so that we may start
deleting more Chromium code that breaks the update step.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 9:57 PM Changeset in webkit [147706] by
-
- 1 edit1 delete in trunk
Nixed the defunct chromium folder from ManualTests
https://bugs.webkit.org/show_bug.cgi?id=113995
Reviewed by Benjamin Poulain.
- ManualTests/chromium: Removed.
- ManualTests/chromium/autofill-popup-shiftupdown.hml: Removed.
- ManualTests/chromium/drag-image-accounts-for-device-scale.html: Removed.
- ManualTests/chromium/modifiers-during-drag-and-drop.html: Removed.
- ManualTests/chromium/no-autofill-on-readonly.html: Removed.
- ManualTests/chromium/onchange-reload-popup.html: Removed.
- ManualTests/chromium/popup-menu-crash.html: Removed.
- ManualTests/chromium/select-close-popup-value-change.html: Removed.
- ManualTests/chromium/suggestions-popup-font-change.html: Removed.
- 9:53 PM Changeset in webkit [147705] by
-
- 2 edits in trunk/Tools
Remove Chromium's DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=113989
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Kent Tamura.
On second thought, let's not go to Camelot. It is a silly place.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- 9:46 PM Changeset in webkit [147704] by
-
- 1 edit1 delete in trunk/Tools
Nixed the defunct chromium folder from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=113993
Reviewed by Ryosuke Niwa.
- DumpRenderTree/chromium: Removed.
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
- DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
- DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
- DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
- DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
- DumpRenderTree/chromium/ImageDiff.cpp: Removed.
- DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
- DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
- DumpRenderTree/chromium/MockPlatform.cpp: Removed.
- DumpRenderTree/chromium/MockPlatform.h: Removed.
- DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
- DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
- DumpRenderTree/chromium/Task.cpp: Removed.
- DumpRenderTree/chromium/Task.h: Removed.
- DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
- DumpRenderTree/chromium/TestEventPrinter.h: Removed.
- DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
- DumpRenderTree/chromium/TestNavigationController.h: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
- DumpRenderTree/chromium/TestRunner: Removed.
- DumpRenderTree/chromium/TestRunner/public: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
- DumpRenderTree/chromium/TestRunner/src: Removed.
- DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
- DumpRenderTree/chromium/TestShell.cpp: Removed.
- DumpRenderTree/chromium/TestShell.h: Removed.
- DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
- DumpRenderTree/chromium/TestShellMac.mm: Removed.
- DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
- DumpRenderTree/chromium/TestShellStub.cpp: Removed.
- DumpRenderTree/chromium/TestShellWin.cpp: Removed.
- DumpRenderTree/chromium/TestShellX11.cpp: Removed.
- DumpRenderTree/chromium/WebViewHost.cpp: Removed.
- DumpRenderTree/chromium/WebViewHost.h: Removed.
- DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
- DumpRenderTree/chromium/android_main_fonts.xml: Removed.
- DumpRenderTree/chromium/config.h: Removed.
- DumpRenderTree/chromium/fonts.conf: Removed.
- 9:40 PM Changeset in webkit [147703] by
-
- 1 edit1 delete in trunk/Source/WTF
Nixed the defunct chromium folder from WTF
https://bugs.webkit.org/show_bug.cgi?id=113992
Reviewed by Ryosuke Niwa.
- wtf/chromium: Removed.
- wtf/chromium/ChromiumThreading.h: Removed.
- wtf/chromium/MainThreadChromium.cpp: Removed.
- 9:39 PM Changeset in webkit [147702] by
-
- 2 edits in trunk/Source/WebCore
alternateFamilyName should return a null, not an empty value
https://bugs.webkit.org/show_bug.cgi?id=113987
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Anders Carlsson.
The string object corresponding semantically to "no-value" is
a null string, not an empty string.
Fix alternateFamilyName() accordingly.
- platform/graphics/FontCache.cpp:
(WebCore::alternateFamilyName):
(WebCore::FontCache::getCachedFontPlatformData):
- 8:46 PM Changeset in webkit [147701] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] DOMSupport::isFixedPositionOrHasFixedPositionAncestor stops traversing render tree when it hits an iframe element
https://bugs.webkit.org/show_bug.cgi?id=113944
Patch by Andrew Lo <anlo@rim.com> on 2013-04-04
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
Internal PR 320732.
When checking whether a RenderObject is fixed position or has a fixed position
ancestor, we traverse the render tree upwards.
When we reach the root of the tree, check whether the root is an
iframe and has an element owner. If so, we also need to continue iterating
up the tree from the owner to see if the iframe is a descendant of a fixed
position element.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isFixedPositionOrHasFixedPositionAncestor):
- 7:52 PM Changeset in webkit [147700] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Add support for getting page contents as string
https://bugs.webkit.org/show_bug.cgi?id=106752
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-04-04
Reviewed by Andreas Kling.
Modified ewk_view_page_contents_get() API to get page contents as string.
EWK_PAGE_CONTENTS_TYPE_STRING is added to Ewk_Page_Contents_Type.
Now, we can use both EWK_PAGE_CONTENTS_TYPE_MHTML and EWK_PAGE_CONTENTS_TYPE_STRING
for getting page contents.
- UIProcess/API/efl/ewk_view.cpp:
(Ewk_Page_Contents_Context):
(ewkViewPageContentsAsMHTMLCallback):
(ewkViewPageContentsAsStringCallback):
(ewk_view_page_contents_get):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(PageContentsAsMHTMLCallback):
(PageContentsAsStringCallback):
(TEST_F):
- 7:51 PM Changeset in webkit [147699] by
-
- 1 edit1 add7 deletes in trunk/LayoutTests
Change class_as_selector-expected.html to be a ref-test
https://bugs.webkit.org/show_bug.cgi?id=113970
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Geoffrey Garen.
The test checks style can be applied to text with a CSS class.
The reference is done by applying a style attribute directly
on each element.
- css1/basic/class_as_selector-expected.html: Added.
- platform/efl/css1/basic/class_as_selector-expected.png: Removed.
- platform/efl/css1/basic/class_as_selector-expected.txt: Removed.
- platform/gtk/css1/basic/class_as_selector-expected.txt: Removed.
- platform/mac/css1/basic/class_as_selector-expected.png: Removed.
- platform/mac/css1/basic/class_as_selector-expected.txt: Removed.
- platform/qt/css1/basic/class_as_selector-expected.png: Removed.
- platform/qt/css1/basic/class_as_selector-expected.txt: Removed.
- 7:48 PM Changeset in webkit [147698] by
-
- 2 edits in trunk/LayoutTests
Unskip 3 backface-visibility tests on OS X
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
- platform/mac/TestExpectations:
The 3 pixel tests pass on WebKit1 and WebKit2.
- 7:43 PM Changeset in webkit [147697] by
-
- 2 edits in trunk/Websites/webkit.org
Update WebKit.org's contact page
https://bugs.webkit.org/show_bug.cgi?id=113968
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Geoffrey Garen.
- contact.html:
-Add a direct link to our archives on Gmane.
-References the ports mailing-lists. This may reduces the emails
erroneously sent to webkit-dev.
-Add a link to our "reporting bug page".
-Get rid of the link to CIA. The website is dead.
- 7:39 PM Changeset in webkit [147696] by
-
- 1 edit1 delete in trunk/Tools
Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
Rubber stamped by Benjamin Poulain.
- RebaselineQueueServer: Removed.
- RebaselineQueueServer/app.yaml: Removed.
- RebaselineQueueServer/handlers: Removed.
- RebaselineQueueServer/handlers/init.py: Removed.
- RebaselineQueueServer/handlers/builderqueue.py: Removed.
- RebaselineQueueServer/handlers/pages.py: Removed.
- RebaselineQueueServer/index.yaml: Removed.
- RebaselineQueueServer/main.py: Removed.
- RebaselineQueueServer/model: Removed.
- RebaselineQueueServer/model/init.py: Removed.
- RebaselineQueueServer/model/queueentry.py: Removed.
- RebaselineQueueServer/static: Removed.
- RebaselineQueueServer/static/builder-frame-empty.html: Removed.
- RebaselineQueueServer/static/styles.css: Removed.
- RebaselineQueueServer/templates: Removed.
- RebaselineQueueServer/templates/builder-picker.html: Removed.
- RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
- RebaselineQueueServer/templates/builder-queue-list.html: Removed.
- RebaselineQueueServer/templates/home.html: Removed.
- 7:35 PM Changeset in webkit [147695] by
-
- 3 edits in trunk/Tools
Fix setup-commit-queue and temporarily disable testing on commit-queue
https://bugs.webkit.org/show_bug.cgi?id=113979
Reviewed by Benjamin Poulain.
Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
- EWSTools/setup-commit-queue.sh:
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask.run):
- 6:32 PM WebKit Team edited by
- Updates yosin@'s knowledge area (diff)
- 6:29 PM Changeset in webkit [147694] by
-
- 2 edits in trunk/Source/WebCore
Work around a bug in the bindings generation script.
- WebCore.xcodeproj/project.pbxproj:
- 6:25 PM Changeset in webkit [147693] by
-
- 4 edits in trunk/Source/WebCore
Don't dispatch delayed click if snapshotted plugin was triggered by a click on the label
https://bugs.webkit.org/show_bug.cgi?id=113982
Reviewed by Tim Horton.
We regressed the way clicks were sent on to restarted plugins when we moved to a
Shadow Root - we were always sending the click. We should only send the click
on if the user clicked on the main plugin content, and not send it when you
click directly on the label.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Keep a reference to the container and label.
(WebCore::HTMLPlugInImageElement::partOfSnapshotLabel): New method that detects if a Node was part
of the snapshot label.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Only record the event if you should forward it on.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): New parameter to userDidClickSnapshot and member variables for shadow content.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::handleEvent): Ask the plugin if the clicked target was the snapshot label.
- 5:59 PM Changeset in webkit [147692] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed EFL build fix.
Add missing include for FloatRect.h.
- platform/efl/PlatformScreenEfl.cpp:
- 5:54 PM Changeset in webkit [147691] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- platform/graphics/GlyphPageTreeNode.cpp:
- 5:44 PM Changeset in webkit [147690] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed EFL build fix.
We had undefined reference to `JSC::CodeOrigin::maximumBytecodeIndex'.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::findClosureCallForReturnPC):
(JSC::CodeBlock::bytecodeOffset):
- 5:37 PM Changeset in webkit [147689] by
-
- 3 edits in trunk/Source/WebCore
Another build fix.
- platform/graphics/FontCache.cpp:
- platform/graphics/SimpleFontData.cpp:
- 5:28 PM Changeset in webkit [147688] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- WebCore.xcodeproj/project.pbxproj:
- 5:26 PM Changeset in webkit [147687] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Adjust fatfinger result priority
https://bugs.webkit.org/show_bug.cgi?id=113957
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-04
Reviewed by Rob Buis.
RIM PR 224781
Internally Reviewed by Genevieve Mak.
Change fatfigner algorithm, return the clickable element rather than
its parent anchor. Modify taphighlight and context menu node selection
accordingly.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::findBestPoint):
- WebKitSupport/FatFingers.h:
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::elementForTapHighlight):
- 5:15 PM Changeset in webkit [147686] by
-
- 2 edits in trunk/Source/WebCore
Removed empty files from the build
https://bugs.webkit.org/show_bug.cgi?id=113978
Reviewed by Anders Carlsson.
Anders made a list of all the empty files that are slowing down the Mac
build, and I grepped them away.
- WebCore.xcodeproj/project.pbxproj:
- 5:08 PM Changeset in webkit [147685] by
-
- 2 edits in trunk/Tools
temporarily make flakiness dashboard work again webkit.org bots
https://bugs.webkit.org/show_bug.cgi?id=113972
Reviewed by Ojan Vafai.
This patch disables the chromium.org layout test bots TestExpectations
parsing temporarily until we can work out the right way to split into
two instances for webkit.org and chromium.org and figure out which
code to delete where :).
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- 5:08 PM Changeset in webkit [147684] by
-
- 42 edits1 copy1 add in trunk/Source/WebCore
Prune unneeded header #includes
https://bugs.webkit.org/show_bug.cgi?id=113973
Reviewed by Geoffrey Garen.
Reduce the amount of headers included by other headers by:
- Moving implicit and explicit constructors and destructors into .cpp files so member variable constructors/destructors don't have to be declared.
- Move CachedResourceClient subclasses out into separate headers so that their respective CachedResource subclasses don't have to be included by the classes that derive from those subclasses.
- Remove headers that were never needed in the first place.
- Modules/webaudio/AudioContext.h:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
- css/CSSFontFaceSource.h:
- html/canvas/CanvasPattern.cpp:
(WebCore::CanvasPattern::create):
(WebCore::CanvasPattern::CanvasPattern):
(WebCore::CanvasPattern::~CanvasPattern):
- html/canvas/CanvasPattern.h:
(WebCore::CanvasPattern::pattern):
(WebCore::CanvasPattern::originClean):
- html/parser/HTMLScriptRunner.h:
- loader/ImageLoader.h:
- loader/LinkLoader.h:
- loader/TextTrackLoader.h:
- loader/cache/CachedFont.cpp:
- loader/cache/CachedFont.h:
- loader/cache/CachedFontClient.h: Added.
(WebCore::CachedFontClient::~CachedFontClient):
(WebCore::CachedFontClient::expectedType):
(WebCore::CachedFontClient::resourceClientType):
(WebCore::CachedFontClient::fontLoaded):
- loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::setResource):
- loader/cache/CachedResourceHandle.h:
(WebCore::CachedResourceHandleBase::get):
(WebCore::CachedResourceHandleBase::operator!):
(WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
(WebCore::CachedResourceHandleBase::operator=):
(WebCore::CachedResourceHandle::CachedResourceHandle):
(WebCore::CachedResourceHandle::get):
(WebCore::CachedResourceHandle::operator->):
(WebCore::CachedResourceHandle::operator=):
(WebCore::CachedResourceHandle::operator==):
(WebCore::CachedResourceHandle::operator!=):
(WebCore::operator==):
(WebCore::operator!=):
- loader/cache/CachedSVGDocument.h:
- loader/cache/CachedSVGDocumentReference.h:
- loader/cache/CachedSVGDocumentClient.h: Added.
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):
- loader/cache/CachedStyleSheetClient.h:
- platform/PlatformScreen.h:
- platform/audio/HRTFElevation.cpp:
- platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::fftSize):
- platform/audio/HRTFKernel.h:
- platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::~ReverbConvolverStage):
- platform/audio/ReverbConvolverStage.h:
- platform/graphics/FontPlatformData.h:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/Path.cpp:
- platform/graphics/Path.h:
- platform/graphics/Pattern.cpp:
- platform/graphics/Pattern.h:
- platform/graphics/filters/FilterOperation.cpp:
(WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
(WebCore::ReferenceFilterOperation::~ReferenceFilterOperation):
(WebCore::ReferenceFilterOperation::setCachedSVGDocumentReference):
- platform/graphics/filters/FilterOperation.h:
- platform/graphics/transforms/AffineTransform.h:
- plugins/DOMMimeType.h:
- rendering/RenderLayerFilterInfo.h:
- rendering/style/StyleCachedShader.h:
- svg/SVGFEImageElement.h:
- svg/SVGFontFaceUriElement.h:
- svg/SVGUseElement.h:
- xml/parser/XMLDocumentParser.h:
- 4:59 PM Changeset in webkit [147683] by
-
- 7 edits in trunk/Source
[Cairo] Stop passing raw pointers to BitmapImage::create()
https://bugs.webkit.org/show_bug.cgi?id=113945
Reviewed by Martin Robinson.
Source/WebCore:
BitmapImage::create() was updated in r147643 to take a PassRefPtr<cairo_surface_t>
in argument instead of a cairo_surface_t*. This patch updates several call sites
so that they now pass in a smart pointer instead of a raw one to avoid silent
converting from cairo_surface_t* to PassRefPtr<cairo_surface_t>.
No new tests, no behavior change.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData): Use RefPtr to m_surface to avoid manual
memory handling.
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
- platform/graphics/cairo/ImageBufferDataCairo.h:
(ImageBufferData):
- platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer):
- platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
Source/WebKit2:
Pass a smart pointer in to BitmapImage::create() instead of a raw one
for the cairo surface. The factory method prototype was updated for
cairo in r147643.
- Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::createImage):
- 4:57 PM Changeset in webkit [147682] by
-
- 4 edits2 adds in trunk
Page content missing when flipping from an empty layer to a tiled layer
https://bugs.webkit.org/show_bug.cgi?id=113977
<rdar://problem/13444219>
Source/WebCore:
Reviewed by Tim Horton.
Some articles on USA Today were missing content on load, when a large GraphicsLayer
which did not draw content needed to draw content (and become tiled in the process).
The bug was an ordering dependency in GraphicsLayerCA::commitLayerChangesBeforeSublayers().
swapFromOrToTiledLayer() sets some dirty flags, but for some properties which have
already been committed in the current flush cycle.
Fix by moving the swapFromOrToTiledLayer() to the top of the commit, which is
safe since it only consults GraphicsLayer properties, not CALayer properties.
Test: compositing/tiling/empty-to-tiled.html
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateContentsScale):
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
LayoutTests:
Reviewed by Tim Horton.
Ref test that adds visible content to a larger layer.
- compositing/tiling/empty-to-tiled-expected.html: Added.
- compositing/tiling/empty-to-tiled.html: Added.
- 4:56 PM Changeset in webkit [147681] by
-
- 2 edits in trunk/Source/WebCore
Regression(r147639) Causes assertion hit in HashTable
https://bugs.webkit.org/show_bug.cgi?id=113954
Reviewed by Benjamin Poulain.
Lookup the key in the hash table again after the recursive call to
getCachedFontPlatformData() as it may have altered the hash map and
invalidated the previous iterator we had.
No new tests, covered by existing tests.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontPlatformData):
- 4:52 PM Changeset in webkit [147680] by
-
- 2 edits in trunk/Tools
Fix webkitpy tests after r147678.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(CommitQueueTest.test_commit_queue):
(test_manual_reject_during_processing):
- 4:35 PM Changeset in webkit [147679] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, fix a test and some results missed in r147675
- media/media-captions-expected.txt:
- media/video-controls-captions-trackmenu-localized.html:
- platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
- 4:18 PM Changeset in webkit [147678] by
-
- 2 edits1 add in trunk/Tools
The commit queue should use Mac MountainLion port
https://bugs.webkit.org/show_bug.cgi?id=113971
Reviewed by Lucas Forschler.
- EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
- Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue):
- 4:16 PM Changeset in webkit [147677] by
-
- 5 edits in trunk/Source/JavaScriptCore
Stop pretending that statements return a value
https://bugs.webkit.org/show_bug.cgi?id=113969
Reviewed by Oliver Hunt.
Expressions have an intrinsic value, which they return to their parent
in the AST.
Statements just execute for effect in sequence.
This patch moves emitBytecode into the ExpressionNode and StatementNode
subclasses, and changes the SatementNode subclass to return void. This
eliminates some cruft where we used to return 0, or try to save a bogus
register and return it, as if a statement had a consuming parent in the
AST.
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitNode):
(BytecodeGenerator):
(JSC::BytecodeGenerator::emitNodeInConditionContext):
- bytecompiler/NodesCodegen.cpp:
(JSC::ConstStatementNode::emitBytecode):
(JSC::BlockNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::CaseClauseNode::emitBytecode):
(JSC::CaseBlockNode::emitBytecodeForBlock):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ScopeNode::emitStatementsBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
(JSC::FuncDeclNode::emitBytecode):
- parser/NodeConstructors.h:
(JSC::PropertyListNode::PropertyListNode):
(JSC::ArgumentListNode::ArgumentListNode):
- parser/Nodes.h:
(Node):
(ExpressionNode):
(StatementNode):
(ConstStatementNode):
(BlockNode):
(EmptyStatementNode):
(DebuggerStatementNode):
(ExprStatementNode):
(VarStatementNode):
(IfNode):
(IfElseNode):
(DoWhileNode):
(WhileNode):
(ForNode):
(ForInNode):
(ContinueNode):
(BreakNode):
(ReturnNode):
(WithNode):
(LabelNode):
(ThrowNode):
(TryNode):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
(FuncDeclNode):
(CaseBlockNode):
(SwitchNode):
- 3:57 PM Changeset in webkit [147676] by
-
- 2 edits in trunk/LayoutTests
Make fast/events/tabindex-focus-blur-all.html disallow Java so the test runs the same regardless of platform/port
https://bugs.webkit.org/show_bug.cgi?id=113950
Patch by Dave Michael <dmichael@chromium.org> on 2013-04-04
Reviewed by Jer Noble.
This hopefully fixes the test failure seen on Apple Mountain Lion WK2:
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r147640%20(7636)/results.html
that was introduced in https://bugs.webkit.org/show_bug.cgi?id=32292
- fast/events/resources/tabindex-focus-blur-all.js: Make the test disallow Java execution. Otherwise, <applet> is focusible on platforms that support Java by default and not focusible elsewhere.
- 3:23 PM Changeset in webkit [147675] by
-
- 35 edits in trunk
[Mac] add "automatic" text track menu item
https://bugs.webkit.org/show_bug.cgi?id=113822
Reviewed by Jer Noble.
Source/WebCore:
No new tests, existing tests updated.
- English.lproj/Localizable.strings: Add new track menu item.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_captionDisplayMode.
(WebCore::HTMLMediaElement::finishParsingChildren): LoadTextTrackResource -> ConfigureTextTracks.
(WebCore::HTMLMediaElement::scheduleDelayedAction): Ditto.
(WebCore::HTMLMediaElement::loadTimerFired): Ditto.
(WebCore::HTMLMediaElement::loadInternal): Ditto. Flag the caption menu as invalid so it will
be rebuilt again.
(WebCore::HTMLMediaElement::mediaPlayerDidAddTrack): LoadTextTrackResource -> ConfigureTextTracks.
(WebCore::HTMLMediaElement::didAddTrack): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Deal with new track display modes.
(WebCore::HTMLMediaElement::HTMLMediaElement::hasClosedCaptions): Minor cleanup.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Add some logging.
(WebCore::HTMLMediaElement::configureTextTracks): Call updateActiveTextTrackCues so cue display
is updated.
(WebCore::HTMLMediaElement::captionPreferencesChanged): Deal with new track display modes.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Add some logging.
- html/HTMLMediaElement.h: Ditto.
- html/shadow/MediaControlElementTypes.cpp: Remove trackIndexAttributeName and trackListIndexForElement.
- html/shadow/MediaControlElementTypes.h: Ditto.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Don't use track index,
everything we need is in the track<->element map now.
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Ditto. Always rebuild the
track list because clear the map each time the menu goes away because it refs every track.
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Don't set the track
index attribute on the menu items, just use the map.
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::changedClosedCaptionsVisibility): resetTrackListMenu is gone.
(WebCore::MediaControlsApple::reset): Ditto.
(WebCore::MediaControlsApple::closedCaptionTracksChanged): Ditto.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::captionMenuOffItem): New, static TextTrack used for the menu "Off" item.
(WebCore::TextTrack::captionMenuAutomaticItem): New, static TextTrack used for the menu "Automatic" item.
- html/track/TextTrack.h:
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::shouldShowCaptions): Removed, we use captionDisplayMode instead.
(WebCore::CaptionUserPreferences::captionDisplayMode): New.
(WebCore::CaptionUserPreferences::setCaptionDisplayMode): New.
(WebCore::CaptionUserPreferences::setPreferredLanguage): Make the parameter a const reference.
(WebCore::CaptionUserPreferences::textTrackSelectionScore): Return 0 if the user doesn't want
captions or subtitles.
(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Take language as a parameter
instead of assuming that it is always the entire language list.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::shouldShowCaptions): Removed, we use captionDisplayMode instead.
(WebCore::CaptionUserPreferencesMac::captionDisplayMode): New.
(WebCore::CaptionUserPreferencesMac::setCaptionDisplayMode): New.
(WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Make the parameter a const reference.
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Deal with "Automatic" mode.
captions or subtitles.
(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Take language as a parameter
instead of assuming that it is always the entire language list.
(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Insert "Off" and "Automatic" items.
- platform/LocalizedStrings.cpp:
(WebCore::textTrackAutomaticMenuItemText): New.
- platform/LocalizedStrings.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::languageOfPrimaryAudioTrack): New.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Return the language
of the main audio track.
LayoutTests:
- media/media-captions.html: Opportunistic fix - don't look at state until we get the 'canplaythrough'
event because the media engine state may not have been processed until that time.
- media/track/track-cue-container-rendering-position.html: Don't assume that a cue has been
rendered immediately when the 'canplaythrough' event comes through.
- media/track/track-cue-rendering-mode-changed.html: Ditto.
- media/track/track-in-band-expected.txt: Don't check if cues have loaded, it doesn't matter
for this test.
- media/track/track-in-band.html: Ditto.
- media/track/track-user-preferences-expected.txt: Changed name of utility function from
menuIndexForLanguage to indexOfMenuItemBeginningWith.
- media/track/track-user-preferences.html: Move menuIndexForLanguage to trackmenu-test.js and
change name to indexOfMenuItemBeginningWith. Clarify the message logged when a track loads
but it should not.
- media/trackmenu-test.js: Move some functions here from track-user-preferences.html
(trackMenuList):
(indexOfMenuItemBeginningWith):
(selectCaptionMenuItem):
- media/video-controls-captions-trackmenu-sorted.html: Update for new menu item.
- media/video-controls-captions-trackmenu.html: Ditto.
- platform/mac/media/video-controls-captions-trackmenu-expected.txt: Ditto.
- platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt: Ditto.
- 3:20 PM Changeset in webkit [147674] by
-
- 1 edit3 deletes in trunk/LayoutTests
[EFL] Unreviewed gardening. Rebaseline after r147588. Remove overridden pixel results.
- platform/efl/fast/text/international/003-expected.png: Removed.
- platform/efl/fast/text/international/text-combine-image-test-expected.png: Removed.
- platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.
- 3:01 PM Changeset in webkit [147673] by
-
- 1 edit6 adds in trunk/LayoutTests
[EFL] Unreviewed gardening. Rebaseline after r147588. Update pixel expectations.
- platform/efl-wk1/fast/text/international/003-expected.png: Added.
- platform/efl-wk1/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- platform/efl-wk2/fast/text/international/003-expected.png: Added.
- platform/efl-wk2/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- 2:57 PM Changeset in webkit [147672] by
-
- 2 edits in trunk/Tools
turn off running tests on chromium linux EWS bots
https://bugs.webkit.org/show_bug.cgi?id=113959
Reviewed by Geoffrey Garen.
Now that the Chromium port is no longer being maintained
there's little point in running the tests. Soon we should
just shut this bot off altogether.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(ChromiumLinuxEWS):
- 2:57 PM Changeset in webkit [147671] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r146580): Assertion using SecurityOrigin::create, URL string is not valid
https://bugs.webkit.org/show_bug.cgi?id=113961
Reviewed by Geoff Garen.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::createFromDatabaseIdentifier): (WebCore::SecurityOrigin::create): Don't use ParsedURLString, because http://host:80/ is normalized to http://host/, so it's not a parsed URL string.
- 2:25 PM Changeset in webkit [147670] by
-
- 4 edits3 adds in trunk
Exception stack unwinding doesn't handle inline callframes correctly
https://bugs.webkit.org/show_bug.cgi?id=113952
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
The basic problem here is that the exception stack unwinding was
attempting to be "clever" and avoid doing a correct stack walk
as it "knew" inline callframes couldn't have exception handlers.
This used to be safe as the exception handling machinery was
designed to fail gently and just claim that no handler existed.
This was "safe" and even "correct" inasmuch as we currently
don't run any code with exception handlers through the dfg.
This patch fixes the logic by simply making everything uniformly
use the safe stack walking machinery, and making the correct
boundary checks occur everywhere that they should.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::findClosureCallForReturnPC):
(JSC::CodeBlock::bytecodeOffset):
- interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::retrieveCallerFromVMCode):
LayoutTests:
Yay tests!
- fast/js/js-correct-exception-handler-expected.txt: Added.
- fast/js/js-correct-exception-handler.html: Added.
- fast/js/script-tests/js-correct-exception-handler.js: Added.
(throwEventually):
(f.g):
(f):
(test):
- 2:16 PM Changeset in webkit [147669] by
-
- 2 edits in trunk/Source/JavaScriptCore
Removed a defunct comment
https://bugs.webkit.org/show_bug.cgi?id=113948
Reviewed by Oliver Hunt.
This is also a convenient way to test the EWS.
- bytecompiler/BytecodeGenerator.cpp:
(JSC):
- 2:08 PM Changeset in webkit [147668] by
-
- 1 edit7 adds3 deletes in trunk/LayoutTests
[EFL] Unreviewed gardening. Rebaseline after r147588.
- platform/efl-wk1/fast/text/international: Added.
- platform/efl-wk1/fast/text/international/003-expected.txt: Added.
- platform/efl-wk1/fast/text/international/text-combine-image-test-expected.txt: Added.
- platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
- platform/efl-wk2/fast/text/international/003-expected.txt: Added.
- platform/efl-wk2/fast/text/international/text-combine-image-test-expected.txt: Added.
- platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
- platform/efl/fast/text/international/003-expected.txt: Removed.
- platform/efl/fast/text/international/text-combine-image-test-expected.txt: Removed.
- platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
- 1:52 PM Changeset in webkit [147667] by
-
- 5 edits in trunk
Unreviewed, rolling out r147662.
http://trac.webkit.org/changeset/147662
https://bugs.webkit.org/show_bug.cgi?id=113955
The change r147662 breaks fast/regions/fixed-pos-elem-in-
region.html (Requested by benjaminp on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-04
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth):
LayoutTests:
- fast/inline/inline-with-empty-inline-children-expected.txt:
- fast/inline/inline-with-empty-inline-children.html:
- 1:46 PM Changeset in webkit [147666] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. AppleWin port gardening.
- platform/win/TestExpectations:
- 1:19 PM Changeset in webkit [147665] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. AppleWin port gardening.
- platform/win/TestExpectations:
- platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- 12:58 PM Changeset in webkit [147664] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r147373): Auto-sizing doesn't always respect minimum width changes
https://bugs.webkit.org/show_bug.cgi?id=113947
<rdar://problem/13579024>
Reviewed by Anders Carlsson.
Reset the FrameView size to the minimum auto-sizing size
before performing auto-sizing. We were already resetting the height,
but not the width, instead using the FrameView's current width.
This means that changing the minimum width without also manually
resizing the FrameView will never see the width change.
Auto-sizing tests are not working on Mac yet.
- page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
- 12:26 PM Changeset in webkit [147663] by
-
- 5 edits12 deletes in trunk/Source
[GTK] Remove the gyp build
https://bugs.webkit.org/show_bug.cgi?id=113942
Reviewed by Gustavo Noronha Silva.
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Removed.
- JavaScriptCore.gyp/redirect-stdout.sh: Removed.
Source/ThirdParty/ANGLE:
- ANGLE.gyp/ANGLE.gyp: Removed.
- ANGLE.gypi: Removed.
Source/WebCore:
- WebCore.gyp/WebCoreGTK.gyp: Removed.
Source/WebKit/gtk:
- gyp/Configuration.gypi.in: Removed.
- gyp/Dependencies.gyp: Removed.
- gyp/GNUmakefile: Removed.
- gyp/autogen.sh: Removed.
- gyp/configure.ac: Removed.
- gyp/run-gyp: Removed.
Source/WTF:
- WTF.gyp/WTFGTK.gyp: Removed.
- 12:23 PM Changeset in webkit [147662] by
-
- 5 edits in trunk
REGRESSION(r142152): Text wraps in menu
https://bugs.webkit.org/show_bug.cgi?id=113706
Reviewed by David Hyatt.
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth): Empty inline elements add their inline border/padding/margin to the width of the
line when we iterate through them in nextLineBreak(), so no need to add them again here when climbing back up
from their first child looking for border/padding/margin to add. (An empty inline element can have floating children.)
LayoutTests:
- fast/inline/inline-with-empty-inline-children-expected.txt:
- fast/inline/inline-with-empty-inline-children.html:
- 12:15 PM Changeset in webkit [147661] by
-
- 2 edits in trunk/Source/WebCore
Changing typing style with font size delta overrides the previous font size delta
https://bugs.webkit.org/show_bug.cgi?id=113923
Reviewed by Andreas Kling.
The bug was caused by a new font size delta value overriding the old one as
opposed to being added to the old value. Fixed that in overrideWithStyle.
Also made overrideWithStyle share code with mergeStyle since there is already
code to merge text-decorations there.
Unfortunately, adding a test for this fix proved to be hard because we don't
expose any API to directly set typing style.
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::overrideWithStyle): Use mergeStyle.
(WebCore::EditingStyle::mergeStyle): Add font size deltas as opposed to simply
using the new value.
- 12:05 PM Changeset in webkit [147660] by
-
- 4 edits2 adds in trunk
AX:File upload button has wrong label
https://bugs.webkit.org/show_bug.cgi?id=113924
Reviewed by David Kilzer.
Source/WebCore:
Allow the label and value to be returned for file upload controls on iOS.
Due to the different AX APIs, we can expose a bit more information on iOS.
Test: platform/iphone-simulator/accessibility/file-upload-button.html
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]):
(-[WebAccessibilityObjectWrapper fileUploadButtonReturnsValueInTitle]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase fileUploadButtonReturnsValueInTitle]):
(-[WebAccessibilityObjectWrapperBase accessibilityTitle]):
LayoutTests:
- platform/iphone-simulator/accessibility/file-upload-button-expected.txt: Added.
- platform/iphone-simulator/accessibility/file-upload-button.html: Added.
- 11:52 AM Changeset in webkit [147659] by
-
- 8 edits in trunk/Source
Expose settings to disable plugin snapshotting autostart and primary detection
https://bugs.webkit.org/show_bug.cgi?id=113918
Reviewed by Tim Horton.
Source/WebCore:
Three new settings:
- snapshotAllPlugIns: Do not apply any heuristics - immediately snapshot a plugin.
- primaryPlugInSnapshotDetectionEnabled: Toggle snapshotting the "main" plugin in the page.
- autostartOriginPlugInSnapshottingEnabled: Toggle snapshotting based on URL origins.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Don't tell the host that we've started
if the autostartOriginPlugInSnapshottingEnabled is false.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Don't restart a primary
plugin if primaryPlugInSnapshotDetectionEnabled is false.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Snapshot immediately if
snapshotAllPlugIns is true. Also, don't test for autostart if
autostartOriginPlugInSnapshottingEnabled is false.
- page/Settings.in: Three new settings values.
Source/WebKit2:
Three new settings: snapshotAllPlugIns, primaryPlugInSnapshotDetectionEnabled and
autostartOriginPlugInSnapshottingEnabled.
These are exposed via WKPreferences (WebKit2 only, since that's the only port actively
using the feature).
- Shared/WebPreferencesStore.h: Add macros for new settings.
- UIProcess/API/C/WKPreferences.cpp: Getters and setters for new settings.
(WKPreferencesSetSnapshotAllPlugIns):
(WKPreferencesGetSnapshotAllPlugIns):
(WKPreferencesSetAutostartOriginPlugInSnapshottingEnabled):
(WKPreferencesGetAutostartOriginPlugInSnapshottingEnabled):
(WKPreferencesSetPrimaryPlugInSnapshotDetectionEnabled):
(WKPreferencesGetPrimaryPlugInSnapshotDetectionEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Forward settings updates.
(WebKit::WebPage::addPluginView): Don't run primary plugin detection if the setting is false.
(WebKit::WebPage::didFinishLoad): Ditto.
- 11:31 AM Changeset in webkit [147658] by
-
- 4 edits in trunk/Source/JavaScriptCore
Simplified bytecode generation by merging prefix and postfix nodes
https://bugs.webkit.org/show_bug.cgi?id=113925
Reviewed by Filip Pizlo.
PostfixNode now inherits from PrefixNode, so when we detect that we're
in a context where postifx and prefix are equivalent, PostFixNode can
just call through to PrefixNode codegen, instead of duplicating the
logic.
- bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):
- parser/NodeConstructors.h:
(JSC::PostfixNode::PostfixNode):
- parser/Nodes.h:
(JSC):
(PrefixNode):
(PostfixNode):
- 11:25 AM Changeset in webkit [147657] by
-
- 2 edits in trunk/Tools
Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
- Scripts/webkitpy/common/config/watchlist:
- 11:22 AM Changeset in webkit [147656] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-win-xp
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:22 AM Changeset in webkit [147655] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-win
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:22 AM Changeset in webkit [147654] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Remove skia code from PluginViewBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=113936
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-04
Reviewed by Rob Buis.
Skia is not used anymore by the BlackBerry port.
- plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::paint):
- 11:22 AM Changeset in webkit [147653] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-mac-snowleopard
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147652] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-mac-mountainlion
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147651] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-mac-lion
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147650] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-mac
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147649] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-linux-x86
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147648] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-linux
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147647] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-android
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:17 AM Changeset in webkit [147646] by
-
- 1 delete in trunk/LayoutTests/platform/chromium
Removed Chromium layout test results.\n\nReviewed by Anders Carlsson.\n\nI'm using a direct svn http command to try to reduce email traffic.
- 11:10 AM Changeset in webkit [147645] by
-
- 3 edits2 adds in trunk
Source/WebCore: Change RenderFrameSet::computeEdgeInfo to use m-rows/m_cols directly
https://bugs.webkit.org/show_bug.cgi?id=113825
Reviewed by Eric Seidel.
Tests: fast/frames/invalid-frameset-compute-edge.html
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::computeEdgeInfo):
LayoutTests: Change RenderFrameSet::computeEdgeInfo to use m-rows/m_cols directly
https://bugs.webkit.org/show_bug.cgi?id=113825
Reviewed by Eric Seidel.
Add test for accessing an invalid frame.
- fast/frames/invalid-frameset-compute-edge-expected.html: Added.
- fast/frames/invalid-frameset-compute-edge.html: Added.
- 11:00 AM Changeset in webkit [147644] by
-
- 2 edits in trunk/Source/WebCore
[GTK][AC] Invalid clear ClutterContent of ClutterActor
https://bugs.webkit.org/show_bug.cgi?id=113758
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-04
Reviewed by Gustavo Noronha Silva.
Using clutter_actor_set_content(actor, 0) is better to clear ClutterContent of ClutterActor.
Actually the ClutterContent referece is cleared in the API if we set 0.
No new tests since no functionality changed.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorUpdateTexture):
- 10:59 AM Changeset in webkit [147643] by
-
- 37 edits4 adds2 deletes in trunk
[Cairo] Fix canvas drawing of SVG-based patterns and remove NativeImageCairo
https://bugs.webkit.org/show_bug.cgi?id=113929
Reviewed by Martin Robinson.
Source/WebCore:
Make (Pass)NativeImagePtr typedefs to (Pass)RefPtr<cairo_surface_t> instead
of NativeImageCairo*. Now that we switch to using smart pointers,
NativeImageCairo is removed as it made no sense to make it ref counted when
it merely held a single ref counted member.
Now that Cairo is using smart pointers for (Pass)NativeImagePtr, this patch
also enables the implementation of SVGImage::nativeImageForCurrentFrame()
for USE(CAIRO) as well. This effectively fixes canvas drawing of SVG-based
patterns for Cairo-based ports.
No new tests, covered by svg/canvas/canvas-pattern-svg.html.
- GNUmakefile.list.am: Remove NativeImageCairo.* for GTK.
- PlatformEfl.cmake: Remove NativeImageCairo.* for EFL.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
Remove NativeImageCairo.* for Win.
- platform/graphics/BitmapImage.cpp:
(WebCore::FrameData::reportMemoryUsage):
Update MemoryClassInfo::addRawBuffer() call now that m_frame is a RefPtr
for USE(CAIRO).
- platform/graphics/BitmapImage.h:
(BitmapImage):
Remove factory method taking a cairo_surface_t* in argument. This is useless
now that PassNativeImagePtr is a typedef to PassRefPtr<cairo_surface_t> and
there is already a factory method taking a PassNativeImagePtr in argument.
- platform/graphics/NativeImagePtr.h:
(WebCore):
Make PassNativeImagePtr a typedef to PassRefPtr<cairo_surface_t> and
NativeImagePtr a typedef to RefPtr<cairo_surface_t>, instead of
NativeImageCairo*. Moving to smart pointers is needed to enable implementation
of SVGImage::nativeImageForCurrentFrame() for Cairo.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::FrameData::clear):
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/cairo/ImageCairo.cpp:
(WebCore::Image::drawPattern):
Update Cairo graphics code to reflect the (Pass)NativeImagePtr type changes.
- platform/graphics/cairo/NativeImageCairo.cpp: Removed.
- platform/graphics/cairo/NativeImageCairo.h: Removed.
- platform/graphics/cairo/PatternCairo.cpp:
(WebCore::Pattern::createPlatformPattern):
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/efl/ImageEfl.cpp:
(WebCore::BitmapImage::getEvasObject):
- platform/graphics/gtk/ImageGtk.cpp:
(WebCore::BitmapImage::getGdkPixbuf):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
- platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::create):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
- platform/gtk/DragImageGtk.cpp:
(WebCore::createDragImageFromImage):
- platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::ImageFrame::asNewNativeImage):
- platform/win/DragImageCairoWin.cpp:
(WebCore::createDragImageFromImage):
Update code to reflect the (Pass)NativeImagePtr type changes.
- svg/graphics/SVGImage.cpp:
(WebCore):
- svg/graphics/SVGImage.h:
Enable SVGImage::nativeImageForCurrentFrame() for USE(CAIRO).
Source/WebKit:
Remove outdated symbols now that NativeImageCairo was removed.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/efl:
Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.
- ewk/ewk_history.cpp:
(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):
- ewk/ewk_settings.cpp:
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_get):
Source/WebKit/gtk:
Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.
- webkit/webkitfavicondatabase.cpp:
(getIconPixbufSynchronously):
Source/WebKit/win:
Remove outdated symbols now that NativeImageCairo was removed.
- WebKit.vcproj/WebKitExports.def.in:
Source/WebKit2:
Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.
- Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::decodeImage):
- UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp:
(WKIconDatabaseTryGetCairoSurfaceForURL):
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(getIconSurfaceSynchronously):
LayoutTests:
Add EFL / GTK pixels results for svg/canvas/canvas-pattern-svg.html now that
the test passes for cairo-based ports.
- platform/efl/svg/canvas/canvas-pattern-svg-expected.png: Added.
- platform/gtk/svg/canvas/canvas-pattern-svg-expected.png: Added.
- 10:48 AM Changeset in webkit [147642] by
-
- 2 edits in trunk/Source/WebCore
[EFL] --minimal build fails with 'error: unused variable'
https://bugs.webkit.org/show_bug.cgi?id=113903
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-04
Reviewed by Gustavo Noronha Silva.
Moved variable definition under #if where it's used
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::restartedCallback):
- 10:30 AM Changeset in webkit [147641] by
-
- 2 edits in trunk/Source/WTF
ObjcRuntimeExtras.h should use variadic templates
https://bugs.webkit.org/show_bug.cgi?id=113941
Reviewed by Andreas Kling.
Reimplement wtfObjcMsgSend and wtfCallIMP as variadic function templates.
- wtf/ObjcRuntimeExtras.h:
(wtfObjcMsgSend):
(wtfCallIMP):
- 9:40 AM Changeset in webkit [147640] by
-
- 4 edits in trunk/Source
Fix the build with GCC 4.8
https://bugs.webkit.org/show_bug.cgi?id=113147
Reviewed by Allan Sandfeld Jensen.
Source/JavaScriptCore:
Initialize JSObject* exception to suppress warnings that make
the build fail because of -Werror=maybe-uninitialized.
- runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
Source/WTF:
Disable diagnostic warning -Wunused-local-typedefs for GCC 4.8
since dummy typedefs are commonly used in the codebase.
- wtf/Compiler.h:
- 9:37 AM Changeset in webkit [147639] by
-
- 12 edits in trunk/Source/WebCore
Global FontPlatformData cache should use OwnPtr.
<http://webkit.org/b/111939>
Reviewed by Anders Carlsson.
Let the global FontPlatformData use OwnPtr instead of raw pointers + deleteAllValues().
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::invalidate):
Tweaked code for OwnPtr. Also made getCachedFontPlatformData() do one hash lookup
instead of two.
- platform/graphics/FontCache.h:
- platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/chromium/FontCacheAndroid.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/skia/FontCacheSkia.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/wince/FontCacheWinCE.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::createFontPlatformData):
FontCache::createFontPlatformData() now returns a PassOwnPtr.
- 9:28 AM Changeset in webkit [147638] by
-
- 2 edits in trunk/Source/WebCore
Render images with low-quality scaling while FrameView is being resized.
<http://webkit.org/b/113764>
<rdar://problem/13555154>
Reviewed by Antti Koivisto.
Have ImageQualityController ask the renderer's containing FrameView if it's currently in live
resize, and if so, paint all images with low-quality scaling. A high-quality repaint will happen
~0.5 sec after live resizing ends, piggybacking on the same mechanism we use to do JS-animated
resizing with low-quality scaling.
This reduces CPU time spent generating new tiles during live window resize, especially on Retina
systems where a lot of upscaling happens on legacy web content.
- rendering/RenderBoxModelObject.cpp:
(ImageQualityController):
Added an m_liveResizeOptimizationIsActive flag that tracks whether the ImageQualityController
is painting everything in low quality due to live window resize. It gets unset when the HQ
repaint timer fires and everything has been repainted properly.
(WebCore::ImageQualityController::highQualityRepaintTimerFired):
When the HQ repaint timer fires, check if the renderer's containing FrameView is still in
live resize, and if so, abort HQ repaint for now and reschedule the timer.
(WebCore::ImageQualityController::ImageQualityController):
(WebCore::ImageQualityController::objectDestroyed):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
- 9:18 AM Changeset in webkit [147637] by
-
- 14 edits in trunk/Source
[Qt] docs: Fix module name format
https://bugs.webkit.org/show_bug.cgi?id=113209
Patch by Sze Howe Koh <szehowe.koh@gmail.com> on 2013-04-04
Reviewed by Jocelyn Turcotte.
Make QDoc-generated documentation follow the conventions at
http://qt-project.org/wiki/Spelling_Module_Names_in_Qt_Documentation
Source/WebKit/qt:
- Api/qwebdatabase.cpp:
- Api/qwebkitglobal.cpp:
- Api/qwebpluginfactory.cpp:
- Api/qwebsettings.cpp:
- WidgetApi/qgraphicswebview.cpp:
- WidgetApi/qwebframe.cpp:
- WidgetApi/qwebpage.cpp:
- WidgetApi/qwebview.cpp:
- docs/qtwebkit-bridge.qdoc:
- docs/qtwebkit-goes-mobile.qdoc:
- docs/qtwebkit.qdoc:
Source/WebKit2:
- UIProcess/API/qt/qquickwebview.cpp:
- 9:17 AM Changeset in webkit [147636] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix closure compiler warnings in IndexedDBModel.js
https://bugs.webkit.org/show_bug.cgi?id=113926
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Alexander Pavlov.
No new tests: no change in behaviour.
- inspector/front-end/IndexedDBModel.js:
- 9:01 AM Changeset in webkit [147635] by
-
- 3 edits2 adds in trunk
REGRESSION (r145870): Can't get insertion point to appear in some input and textareas on wordpress
https://bugs.webkit.org/show_bug.cgi?id=113591
Patch by Xidorn Quan <quanxunzhen@gmail.com> on 2013-04-04
Reviewed by Simon Fraser.
Source/WebCore:
Since a child node could overflow its ancestor, it is not wise to check
one's radii boundary before checking whether the given point intersects
its children. This patch moves the related code down to fix the bug.
Test: fast/borders/border-radius-child.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
LayoutTests:
- fast/borders/border-radius-child-expected.txt: Added.
- fast/borders/border-radius-child.html: Added.
- 8:53 AM Changeset in webkit [147634] by
-
- 2 edits in trunk/Tools
Indentation fix to get webkit-patch working again after r147625
Unreviewed.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):
(MacWK2EWS):
- 8:32 AM Changeset in webkit [147633] by
-
- 2 edits in tags/Safari-537.35.8/Source/WebKit2
Merged r147592. <rdar://problem/13540351>
- 8:29 AM Changeset in webkit [147632] by
-
- 10 edits in tags/Safari-537.35.8/Source
Merged r147579. <rdar://problem/13478573>
- 8:26 AM Changeset in webkit [147631] by
-
- 2 edits in tags/Safari-537.35.8/Source/WebKit2
Merged r147500. <rdar://problem/13159030>
- 8:23 AM Changeset in webkit [147630] by
-
- 6 edits in tags/Safari-537.35.8/Source/WebKit2
Merged r147489. <rdar://problem/12679817>
- 8:20 AM Changeset in webkit [147629] by
-
- 13 edits2 copies in tags/Safari-537.35.8
Merged r147471. <rdar://problem/13522402>
- 8:15 AM Changeset in webkit [147628] by
-
- 4 edits in trunk
[GStreamer] Virtual modifier for MediaPlayer::simulateAudioInterruption must go
https://bugs.webkit.org/show_bug.cgi?id=113851
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-04-04
Reviewed by Eric Carlson.
.:
- Source/autotools/symbols.filter: Added
_ZN7WebCore11MediaPlayer25simulateAudioInterruptionEv symbol.
Source/WebCore:
- platform/graphics/MediaPlayer.h:
(MediaPlayer): Removed virtual modifier to
simulateAudioInterruption.
- 8:14 AM Changeset in webkit [147627] by
-
- 2 edits in tags/Safari-537.35.8/Source/JavaScriptCore
Merged r147079. <rdar://problem/13519289>
- 8:12 AM Changeset in webkit [147626] by
-
- 2 edits in tags/Safari-537.35.8/Source/JavaScriptCore
Merged r147017. <rdar://problem/13519289>
- 8:06 AM Changeset in webkit [147625] by
-
- 2 edits in trunk/Tools
Turn tests back on for Mac WK1/WK2 EWS.
Unreviewed.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):
(MacWK2EWS):
- 6:26 AM Changeset in webkit [147624] by
-
- 3 edits in trunk/Tools
[GTK][WK2] MiniBrowser custom URI scheme support
https://bugs.webkit.org/show_bug.cgi?id=112419
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-04
Reviewed by Carlos Garcia Campos.
Add support for about URIs in MiniBrowser. An example about page is show
with URI "about:minibrowser", the rest of the cases it will show a
proper message explaining that the about page didn't exist.
Internally it uses "minibrowser-about" prefix instead of "about", but
from the user point of view it works with "about" prefix.
- MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
(getInternalURI): Method to convert URIs from "about" prefix to
"minibrowser-about".
(getExternalURI): Opposite method.
(webViewURIChanged): Use "about" prefix to show the URI to users.
(webViewEnterFullScreen): Ditto.
(browser_window_load_uri): Use "minibrowser-about" prefix internally.
- MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
(aboutURISchemeRequestCallback): Callback to manage about calls.
(main): Register the URI scheme to manage about URIs.
- 6:20 AM Changeset in webkit [147623] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Support -webkit-font-smoothing
https://bugs.webkit.org/show_bug.cgi?id=106009
Reviewed by Jocelyn Turcotte.
Remove false dependency on Qt 5.1 for the -webkit-font-smoothing property.
For now we are still keeping the dependency on Font::shouldUseSmoothing().
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- 5:05 AM Changeset in webkit [147622] by
-
- 51 edits5 adds in trunk
Regression(r142765) Broke Custom SVG cursors and SVG canvas drawing for Chromium
https://bugs.webkit.org/show_bug.cgi?id=113420
Reviewed by Stephen White.
Source/WebCore:
Introduce a PassNativeImagePtr typedef that is used in place of NativeImagePtr
for method arguments and return values. This is needed as Skia now maps
NativeImagePtr to RefPtr<NativeImageSkia> and PassNativeImagePtr to
PassRefPtr<NativeImageSkia>. We move towards ref counted smart pointers so that
SVGImage::nativeImageForCurrentFrame() can transfer ownership of the native
image to the caller if needed (e.g. for SVGImage).
Provide nativeImageForCurrentFrame() implementation for SVGImage. SVGImage no
longer holds the native image internally, to save memory. It is therefore created
when nativeImageForCurrentFrame() is called and ownership is passed to the
caller. For now, this implementation is only enabled for Skia as others are using
raw pointers for PassNativeImagePtr.
Test: svg/canvas/canvas-pattern-svg.html
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousNativeIconForPageURL):
Return a PassNativeImagePtr instead of NativeImagePtr.
- loader/icon/IconDatabase.h:
(IconDatabase):
- loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::synchronousNativeIconForPageURL):
Return a PassNativeImagePtr instead of NativeImagePtr.
- platform/chromium/DragImageChromiumSkia.cpp:
(WebCore::createDragImageFromImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead of a raw
one.
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr<NativeImageSkia>
instead of a NativeImagePtr. While these are equivalent, the former is more
readable in Skia-specific code.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::frameAtIndex):
Return a PassNativeImagePtr instead of a NativeImagePtr.
(WebCore::BitmapImage::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::create):
Take a PassNativeImagePtr in argument instead of a NativeImagePtr.
(BitmapImage): Ditto.
- platform/graphics/GraphicsContext.h:
(GraphicsContext): Ditto.
- platform/graphics/GraphicsContext3D.h:
(ImageExtractor):
Keep NativeImageSkia in a RefPtr instead of OwnPtr, now that it is refcounted.
- platform/graphics/Image.h:
(WebCore::Image::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/ImageBuffer.h:
(ImageBuffer):
Have copyNativeImage() return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::createFrameAtIndex):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/ImageSource.h:
Have createFrameAtIndex() return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/NativeImagePtr.h:
Map NativeImagePtr to a RefPtr<NativeImageSkia> instead of NativeImageSkia* for Skia.
Introduce new PassNativeImagePtr that maps to PassRefPtr<NativeImageSkia> for Skia
and is equivalent to NativeImagePtr for other ports. We now use smart pointers for
the native image so that SVGImage::nativeImageForCurrentFrame() can pass ownership
of the native image to the caller, unlike BitmapImage::nativeImageForCurrentFrame().
- platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
(WebCore::BitmapImage::BitmapImage):
Take a PassNativeImagePtr instead of a NativeImagePtr in argument.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage): Ditto.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::copyNativeImage):
Take a PassNativeImagePtr instead of a NativeImagePtr in argument.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead of a raw one.
- platform/graphics/filters/skia/FEBlendSkia.cpp:
(WebCore::FEBlend::platformApplySkia): Ditto.
- platform/graphics/filters/skia/FEColorMatrixSkia.cpp:
(WebCore::FEColorMatrix::platformApplySkia): Ditto.
- platform/graphics/filters/skia/FEComponentTransferSkia.cpp:
(WebCore::FEComponentTransfer::platformApplySkia): Ditto.
- platform/graphics/filters/skia/FEDisplacementMapSkia.cpp:
(WebCore::FEDisplacementMap::platformApplySkia): Ditto.
- platform/graphics/filters/skia/FELightingSkia.cpp:
(WebCore::FELighting::platformApplySkia): Ditto.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/qt/StillImageQt.h:
(StillImage): Ditto.
- platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
No longer need to adopt the return value of asNewNativeImage() now
that it returns a PassRefPtr instead of a raw one.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
Call NativeImageSkia::create() factory method now that the constructor
is private.
- platform/graphics/skia/ImageSkia.cpp:
(WebCore::FrameData::clear):
Just call clear() on m_frame instead of explicitely deleting it now
that it is a RefPtr.
(WebCore::Image::drawPattern):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::checkForSolidColor):
Store return value of frameAtIndex() in a RefPtr instead of a raw one.
(WebCore::BitmapImage::draw):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.
- platform/graphics/skia/NativeImageSkia.cpp:
Add new constructor taking all members in argument. This is used for
cloning a NativeImageSkia object.
(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::deepSkBitmapCopy):
Add convenience function to make a deep copy of a SkBitmap.
- platform/graphics/skia/NativeImageSkia.h:
(WebCore):
(WebCore::NativeImageSkia::create):
(NativeImageSkia):
Make NativeImageSkia subclass RefCounted. Make the constructor private
and add a factory method instead that returns a PassRefPtr.
(WebCore::NativeImageSkia::clone):
Add a clone() method now that NativeImageSkia is refcounted and is no
longer copyable.
- platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformPattern):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.
- platform/graphics/wince/ImageWinCE.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/image-decoders/ImageDecoder.h:
(ImageFrame):
Have asNewNativeImage() return a PassNativeImagePtr instead of a
NativeImagePtr.
(WebCore::ImageFrame::getAddr):
(WebCore::ImageFrame::setSkBitmap):
(WebCore::ImageFrame::getSkBitmap):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):
Update use of m_bitmap now that it is a pointer type and call
NativeImageSkia::create() to construct a NativeImageSkia object now
that the constructor is private.
- platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/image-decoders/openvg/ImageDecoderOpenVG.cpp:
(WebCore::ImageFrame::asNewNativeImage): Ditto.
- platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::ImageFrame):
Initialize m_bitmap in the constructor now that it is a pointer
type and we need NativeImageSkia's default constructor to be
called.
(WebCore::ImageFrame::operator=):
Call NativeImageSkia's new clone() method to copy m_bitmap as
NativeImageSkia is now RefCounted and no longer copyable.
(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
Update use of m_bitmap now that it is a pointer type.
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
Call NativeImageSkia's clone method now that it is no longer
copyable.
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setStatus):
Update use of m_bitmap now that it is a pointer type.
- platform/image-decoders/wx/ImageDecoderWx.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- svg/graphics/SVGImage.cpp:
(WebCore):
(WebCore::SVGImage::nativeImageForCurrentFrame):
Add implementation of nativeImageForCurrentFrame() for SVGImage as
it is needed for SVG custom cursor support and Canvas drawing of
patterns containing SVG images. As SVGImage no longer keep the
native image internally to save memory, the implementation creates
the native image when nativeImageForCurrentFrame() and passes
its ownership to the caller.
- svg/graphics/SVGImage.h:
Override Image::nativeImageForCurrentFrame() and remove dummy
implementation of frameAtIndex() as it is not needed / used.
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::nativeImageForCurrentFrame):
Add implementation of nativeImageForCurrentFrame() which merely
forwards the call to the Image being contained.
- svg/graphics/SVGImageForContainer.h:
Override Image::nativeImageForCurrentFrame().
Source/WebKit/chromium:
Update code now that Image::nativeImageForCurrentFrame() and
ImageFrame::asNewNativeImage() return a smart pointer instead
of a raw one.
- src/WebImageDecoder.cpp:
(WebKit::WebImageDecoder::getFrameAtIndex):
- src/WebImageSkia.cpp:
(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):
(WebKit::WebImage::operator=):
- tests/DeferredImageDecoderTest.cpp:
(WebCore::TEST_F):
- tests/DragImageTest.cpp:
(WebCore::TestImage::TestImage):
(WebCore::TestImage::nativeImageForCurrentFrame):
(TestImage):
- tests/ImageLayerChromiumTest.cpp:
(WebCore::TestImage::TestImage):
(WebCore::TestImage::nativeImageForCurrentFrame):
(TestImage):
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
LayoutTests:
Add layout test to check that drawing canvas patterns containing SVG images works.
- platform/chromium-linux/svg/canvas/canvas-pattern-svg-expected.png: Added.
- svg/canvas/canvas-pattern-svg-expected.txt: Added.
- svg/canvas/canvas-pattern-svg.html: Added.
- 4:11 AM Changeset in webkit [147621] by
-
- 3 edits4 adds in trunk/LayoutTests
[SOUP] inspector/timeline/timeline-receive-response-event.html fails
https://bugs.webkit.org/show_bug.cgi?id=113860
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Xan Lopez.
Copy the results of inspector/timeline/timeline-receive-response-event.html
to the efl and gtk platform dir.
Because test files are bigger than buffer size of ResourceHandleSoup.
- platform/efl/TestExpectations:
- platform/efl/inspector/timeline/timeline-receive-response-event-expected.txt: Added.
- platform/gtk/TestExpectations:
- platform/gtk/inspector/timeline/timeline-receive-response-event-expected.txt: Added.
- 4:10 AM Changeset in webkit [147620] by
-
- 3 edits in trunk/Source/WebCore
[CSSRegions] RenderFlowThread::renderRegionForLine should use a faster search method
https://bugs.webkit.org/show_bug.cgi?id=66921
Reviewed by David Hyatt.
The RenderFlowThread::regionAtBlockOffset() function is a hot path for the code using
flow threads because it translates from block coordinates to regions.
Currently the method is O(n), using a linear search through the regions chain to find the
region where a block offset lands.
The patch improves this search by using an interval tree (PODIntervalTree). Before a flow
thread is laid out, each region is updated to hold the size of the portion of the flow it
will receive. This information is gathered inside the interval tree and used to speedup the
search in RenderFlowThread::regionAtBlockOffset(). The algorithm uses a custom adapter
simplified for looking up offsets inside the interval tree.
For now, the interval tree is cleared every time the flow thread portions list is updated.
The implementation can be improved but induces some cmplexity as we'd have to manually manage
the life cycle of the tree's nodes. The performance gains are good enough as is to make this
only optional.
Another important change is now the flow thread portion rectangles will not overflow when
using auto-height regions (or very large regions). The maximum size of the flow is set to
LayoutUnit::max()/2. Any region forcing a greater size will be capped so the thread
won't overflow.
Performance test results:
/Layout/RegionsAuto:Time ms 699.95 181.20 74.11% Better
/Layout/RegionsAutoMaxHeight:Time ms 2083.00 308.55 85.19% Better
/Layout/RegionsFixed:Time ms 726.10 223.65 69.20% Better
/Layout/RegionsFixedShort:Time ms 869.60 288.25 66.85% Better
Tests: See PerformanceTests/Layout/Regions*
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::RegionSearchAdapter::collectIfNeeded):
(WebCore):
- rendering/RenderFlowThread.h:
(WebCore):
- 4:07 AM Changeset in webkit [147619] by
-
- 2 edits in trunk/LayoutTests
[EFL][Qt] The layout test fast/loader/url-selected-user-gesture.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=113930
Reviewed by Antti Koivisto.
- fast/loader/url-selected-user-gesture.html:
- 3:52 AM Changeset in webkit [147618] by
-
- 5 edits1 add in trunk
[Qt] WebSocket errors should be logged to console
https://bugs.webkit.org/show_bug.cgi?id=113842
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Pass the reason of a failure to SocketStreamError instance
and notify it via SocketStreamHandleClient::didFailSocketStream().
Test : http/tests/inspector/console-websocket-error.html
- platform/network/qt/SocketStreamError.h:
(WebCore::SocketStreamError::SocketStreamError):
- platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore::SocketStreamHandlePrivate::socketErrorCallback):
LayoutTests:
- platform/qt/TestExpectations:
- platform/qt/http/tests/inspector/console-websocket-error-expected.txt: Added.
- 3:47 AM Changeset in webkit [147617] by
-
- 7 edits in trunk/Source/WebKit2
[WK2][EFL] WebView should own view size
https://bugs.webkit.org/show_bug.cgi?id=110753
Reviewed by Andreas Kling.
WebView owns view size. WKViewGetSize and WKViewSetSize API
is exposed accordingly. Usage of EFL-specific ewkView inside
toolkit-agnostic WebView class is reduced.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewGetSize):
(WKViewSetSize):
- UIProcess/API/C/efl/WKView.h:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::setDeviceScaleFactor):
(EwkView::size):
(EwkView::deviceSize):
(EwkView::scheduleUpdateDisplay):
(EwkView::handleEvasObjectCalculate):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::setSize):
(WebKit):
(WebKit::WebView::paintToCurrentGLContext):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::viewSize):
(WebKit::WebView::dipSize):
- UIProcess/efl/WebView.h:
(WebView):
(WebKit::WebView::size):
- 2:40 AM Changeset in webkit [147616] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 1:39 AM Changeset in webkit [147615] by
-
- 2 edits in trunk/Source/WebCore
[ATK] build fails when accessibility is turned off
https://bugs.webkit.org/show_bug.cgi?id=113699
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-04
Reviewed by Gyuyoung Kim.
- editing/atk/FrameSelectionAtk.cpp: Wrapped accessibility code in #if HAVE(ACCESSIBILITY)
- 12:59 AM Changeset in webkit [147614] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix closure compiler warnings in the profiler code HeapSnapshotDataGrids.js
https://bugs.webkit.org/show_bug.cgi?id=113922
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Yury Semikhatsky.
No new tests: no change in behaviour.
- inspector/front-end/HeapSnapshotDataGrids.js:
- 12:30 AM Changeset in webkit [147613] by
-
- 9 edits7 adds in trunk/LayoutTests
[Mac] Unreviewed gardening. Rebaseline after r147588.
- platform/mac-lion/fast/text/international/text-combine-image-test-expected.png:
- platform/mac-lion/fast/text/international/text-combine-image-test-expected.txt:
- platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/mac-wk2/fast/text: Added.
- platform/mac-wk2/fast/text/international: Added.
- platform/mac-wk2/fast/text/international/003-expected.png: Added.
- platform/mac-wk2/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/mac-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- platform/mac/fast/text/international/003-expected.png:
- platform/mac/fast/text/international/003-expected.txt:
- platform/mac/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/mac/fast/text/international/text-combine-image-test-expected.txt:
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
Apr 3, 2013:
- 11:02 PM Changeset in webkit [147612] by
-
- 4 edits in trunk/Source
Versioning.
- 11:00 PM Changeset in webkit [147611] by
-
- 4 edits in tags/Safari-537.35.8/Source
Versioning.
- 10:57 PM Changeset in webkit [147610] by
-
- 1 copy in tags/Safari-537.35.8
New Tag.
- 10:55 PM Changeset in webkit [147609] by
-
- 29 edits4 adds in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: put DFG data into a DFG::JITCode, and put common DFG and FTL data into something accessible from both DFG::JITCode and FTL::JITCode
https://bugs.webkit.org/show_bug.cgi?id=113905
Reviewed by Geoffrey Garen.
This removes one pointer from CodeBlock.
It also gives us a framework for having JITType-specific data in CodeBlock, by
putting it into the appropriate JITCode class (either DFG::JITCode or
FTL::JITCode). And it allows us to have DFG and FTL share some common data,
via DFG::CommonData, which is stored in both DFG::JITCode and FTL::JITCode and
always accessible via JITCode::dfgCommon().
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.cpp:
(JSC):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::performTracingFixpointIteration):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitWeakReferences):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::tallyFrequentExitSites):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan):
(JSC::DFGCodeBlocks::mark):
- dfg/DFGAssemblyHelpers.h:
- dfg/DFGCommonData.cpp: Added.
(DFG):
(JSC::DFG::CommonData::notifyCompilingStructureTransition):
(JSC::DFG::CommonData::shrinkToFit):
- dfg/DFGCommonData.h: Added.
(JSC):
(DFG):
(JSC::DFG::WeakReferenceTransition::WeakReferenceTransition):
(WeakReferenceTransition):
(CommonData):
(JSC::DFG::CommonData::CommonData):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- dfg/DFGDriver.h:
(DFG):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- dfg/DFGGraph.h:
(Graph):
- dfg/DFGJITCode.cpp: Added.
(DFG):
(JSC::DFG::JITCode::JITCode):
(JSC::DFG::JITCode::~JITCode):
(JSC::DFG::JITCode::dfgCommon):
(JSC::DFG::JITCode::dfg):
(JSC::DFG::JITCode::shrinkToFit):
- dfg/DFGJITCode.h: Added.
(DFG):
(JITCode):
(JSC::DFG::JITCode::appendOSREntryData):
(JSC::DFG::JITCode::osrEntryDataForBytecodeIndex):
(JSC::DFG::JITCode::appendOSRExit):
(JSC::DFG::JITCode::lastOSRExit):
(JSC::DFG::JITCode::appendSpeculationRecovery):
(JSC::DFG::JITCode::appendWatchpoint):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JITCompiler):
(JSC::DFG::JITCompiler::addWeakReference):
(JSC::DFG::JITCompiler::noticeOSREntry):
(JSC::DFG::JITCompiler::jitCode):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExit.h:
(OSRExit):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::backwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGVariableEventStream.cpp:
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::JITCode):
(JSC::FTL::JITCode::~JITCode):
(FTL):
(JSC::FTL::JITCode::initializeCode):
(JSC::FTL::JITCode::addressForCall):
(JSC::FTL::JITCode::executableAddressAtOffset):
(JSC::FTL::JITCode::dataAddressAtOffset):
(JSC::FTL::JITCode::offsetOf):
(JSC::FTL::JITCode::size):
(JSC::FTL::JITCode::contains):
(JSC::FTL::JITCode::ftl):
(JSC::FTL::JITCode::dfgCommon):
- ftl/FTLJITCode.h:
(JITCode):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileStructureTransitionWatchpoint):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compilePhantomPutStructure):
(JSC::FTL::LowerDFGToLLVM::addWeakReference):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::weakPointer):
- ftl/FTLState.cpp:
(FTL):
(JSC::FTL::State::State):
(JSC::FTL::State::dumpState):
- ftl/FTLState.h:
(State):
- heap/DFGCodeBlocks.cpp:
(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::clearMarks):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):
(JSC::DFGCodeBlocks::traceMarkedCodeBlocks):
- jit/JITCode.cpp:
(JSC::JITCode::dfgCommon):
(JSC):
(JSC::JITCode::dfg):
(JSC::JITCode::ftl):
(JSC::DirectJITCode::DirectJITCode):
(JSC::DirectJITCode::initializeCodeRef):
(JSC::DirectJITCode::addressForCall):
(JSC::DirectJITCode::executableAddressAtOffset):
(JSC::DirectJITCode::dataAddressAtOffset):
(JSC::DirectJITCode::offsetOf):
(JSC::DirectJITCode::size):
(JSC::DirectJITCode::contains):
- jit/JITCode.h:
(DFG):
(FTL):
(JSC):
(JITCode):
(DirectJITCode):
- 10:09 PM Changeset in webkit [147608] by
-
- 4 edits in branches/dfgFourthTier
fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
https://bugs.webkit.org/show_bug.cgi?id=113921
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
The LLVM community wants us to continue including all of LLVM's C++ headers. Change
to using #pragma's to disable warnings that they cannot handle.
- ftl/FTLLLVMHeaders.h:
Tools:
Reviewed by Oliver Hunt.
The LLVM community wants us to continue including all of LLVM's C++ headers. Change
the export script to do this.
- Scripts/export-llvm-build:
- 8:52 PM Changeset in webkit [147607] by
-
- 27 edits in trunk
[EFL] Add a decoration image to search input field
https://bugs.webkit.org/show_bug.cgi?id=113552
Reviewed by Laszlo Gombos.
Source/WebCore:
Though EFL port has a decoration image for search input field, we didn't use it.
Start to show it.
Tests: fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-rtl.html
fast/css/input-search-padding.html
fast/css/text-input-with-webkit-border-radius.html
fast/css/text-overflow-input.html
fast/forms/box-shadow-override.html
fast/forms/control-restrict-line-height.html
fast/forms/input-appearance-height.html
fast/forms/placeholder-position.html
fast/forms/placeholder-pseudo-style.html
fast/forms/search-styled.html
fast/forms/search-vertical-alignment.html
fast/forms/searchfield-heights.html
fast/repaint/search-field-cancel.html
fast/replaced/width100percent-searchfield.html
- platform/efl/RenderThemeEfl.cpp:
(WebCore):
(WebCore::RenderThemeEfl::supportsDataListUI):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
LayoutTests:
Rebaseline related to input search field.
- platform/efl/fast/css/input-search-padding-expected.png:
- platform/efl/fast/css/input-search-padding-expected.txt:
- platform/efl/fast/css/text-input-with-webkit-border-radius-expected.png:
- platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/efl/fast/css/text-overflow-input-expected.png:
- platform/efl/fast/css/text-overflow-input-expected.txt:
- platform/efl/fast/forms/box-shadow-override-expected.png:
- platform/efl/fast/forms/box-shadow-override-expected.txt:
- platform/efl/fast/forms/control-restrict-line-height-expected.png:
- platform/efl/fast/forms/control-restrict-line-height-expected.txt:
- platform/efl/fast/forms/input-appearance-height-expected.png:
- platform/efl/fast/forms/input-appearance-height-expected.txt:
- platform/efl/fast/forms/placeholder-position-expected.png:
- platform/efl/fast/forms/placeholder-position-expected.txt:
- platform/efl/fast/forms/placeholder-pseudo-style-expected.png:
- platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png:
- platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/efl/fast/forms/searchfield-heights-expected.png:
- platform/efl/fast/forms/searchfield-heights-expected.txt:
- platform/efl/fast/repaint/search-field-cancel-expected.png:
- platform/efl/fast/repaint/search-field-cancel-expected.txt:
- platform/efl/fast/replaced/width100percent-searchfield-expected.png:
- platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
- 7:49 PM Changeset in webkit [147606] by
-
- 1 copy in tags/Safari-537.36
New Tag.
- 7:16 PM Changeset in webkit [147605] by
-
- 8 edits in trunk/LayoutTests
Unreviewed gardening. Below tests aren't related to bug 87619. It just needs to do rebaseline.
- platform/efl/TestExpectations:
- platform/efl/fast/forms/number/number-appearance-rtl-expected.png:
- platform/efl/fast/forms/number/number-appearance-rtl-expected.txt:
- platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
- 6:52 PM Changeset in webkit [147604] by
-
- 2 edits in branches/dfgFourthTier/LayoutTests
fourthTier: Just linking LLVM into JSC causes all plugin tests to fail
https://bugs.webkit.org/show_bug.cgi?id=113915
Reviewed by nobody.
This is pretty funny. I don't know, yet, what is going on, but I don't want it to block other work.
- platform/mac/TestExpectations:
- 6:39 PM Changeset in webkit [147603] by
-
- 2 edits in trunk/Tools
Re-enable WinEWS tests.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 6:16 PM Changeset in webkit [147602] by
-
- 3 edits2 adds in trunk
Input value/placeholder is not redrawn when the input height grows
https://bugs.webkit.org/show_bug.cgi?id=113845
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/forms/text/text-height-grow.html
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::styleDidChange):
We need relayout of the inner text element.
LayoutTests:
- fast/forms/text/text-height-grow-expected.html: Added.
- fast/forms/text/text-height-grow.html: Added.
- 6:10 PM Changeset in webkit [147601] by
-
- 1 edit2 adds in trunk/LayoutTests
[GTK] Unreviewed gardening. Rebaseline after r147588.
- platform/gtk-wk1/fast/writing-mode: Added.
- platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
- 6:02 PM Changeset in webkit [147600] by
-
- 2 edits in trunk/Source/WebCore
Add comment to clarify isStackingContext() in RenderLayer.h
https://bugs.webkit.org/show_bug.cgi?id=113909
Reviewed by Simon Fraser.
It was not obvious how the implementation of isStackingContext()
was correct, a comment is appropriate here for anyone who reads
this code in the future.
Just a change in comment, no test needed.
- rendering/RenderLayer.h:
- 5:58 PM Changeset in webkit [147599] by
-
- 16 edits1 add3 deletes in trunk/LayoutTests
[Chromium] Unreviewed gardening. Rebaseline after r147588.
- platform/chromium-mac-lion/fast/text/international/003-expected.png:
- platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png:
- platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.txt:
- platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-mac/fast/text/international/003-expected.png:
- platform/chromium-mac/fast/text/international/003-expected.txt: Added.
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt:
- platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/chromium-win/fast/text/international/003-expected.png:
- platform/chromium-win/fast/text/international/003-expected.txt:
- platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/fast/text/international/003-expected.txt: Removed.
- 5:45 PM Changeset in webkit [147598] by
-
- 2 edits in trunk/Source/WebKit2
Don't try to set the exception port for server connections
https://bugs.webkit.org/show_bug.cgi?id=113910
<rdar://problem/11248925>
Reviewed by Darin Adler.
Treat a SetExceptionPort message to the server connection as an invalid message.
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::receiveSourceEventHandler):
- 5:05 PM Changeset in webkit [147597] by
-
- 3 edits in trunk/Source/WebCore
[CSS Exclusions] Removed ExclusionShape dead code
https://bugs.webkit.org/show_bug.cgi?id=113904
Reviewed by Dirk Schulze.
No new tests, just removing dead code.
- rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape):
- rendering/ExclusionShape.h:
(ExclusionShape):
- 4:44 PM Changeset in webkit [147596] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed. AppleWin port gardening.
- platform/win/TestExpectations:
- platform/win/fast/lists/inlineBoxWrapperNullCheck-expected.txt: Added.
- 4:16 PM Changeset in webkit [147595] by
-
- 2 edits in trunk/Source/WTF
Enable HAVE_MADV_FREE_REUSE on iOS
https://bugs.webkit.org/show_bug.cgi?id=113892
<rdar://problem/12787563>
Reviewed by Mark Rowe.
- wtf/Platform.h:
- 3:58 PM Changeset in webkit [147594] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Switch MediaPlayerPrivateBlackBerry.cpp's timer to use CLOCK_MONOTONIC
https://bugs.webkit.org/show_bug.cgi?id=113900
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-04-03
Reviewed by Rob Buis.
Internally Reviewed by Jeff Rogers.
Timers should use CLOCK_MONOTONIC to avoid undesirable effects when
the user switches the system time.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):
- 3:54 PM Changeset in webkit [147593] by
-
- 2 edits in trunk/Source/WebKit2
<http://webkit.org/b/113898> Eliminate some code duplication by introducing an array of handlers to register / unregister.
Reviewed by Antti Koivisto.
- UIProcess/mac/WebContextMac.mm:
(OcclusionNotificationHandler): Structure containing the notification name, type and handler.
(WebKit::registerOcclusionNotificationHandlers): Register all of the handlers in the array.
(WebKit::unregisterOcclusionNotificationHandlers): Unregister all of the handlers in the array.
- 3:54 PM Changeset in webkit [147592] by
-
- 2 edits in trunk/Source/WebKit2
Enable process suppression when no windows in the application have drawn recently.
<http://webkit.org/b/113854> / <rdar://problem/13540351>
Reviewed by Darin Adler.
- UIProcess/mac/WebContextMac.mm:
(WebKit::applicationWindowModificationsStarted): Note that modifications are no longer stopped.
(WebKit::applicationWindowModificationsStopped): Note that modifications have stopped.
(WebKit::registerOcclusionNotificationHandlers): Register handlers for the start and stop notifications.
(WebKit::unregisterOcclusionNotificationHandlers): Unregister handlers for the start and stop notifications.
(WebKit::WebContext::canEnableProcessSuppressionForNetworkProcess): Allow suppression if the application is occluded
or the application has not drawn recently.
(WebKit::WebContext::canEnableProcessSuppressionForWebProcess): Ditto.
(WebKit::WebContext::canEnableProcessSuppressionForGlobalChildProcesses): Ditto.
- 3:35 PM Changeset in webkit [147591] by
-
- 9 edits4 adds in trunk
Unable to focus on embedded plugins such as Flash via javascript focus()
https://bugs.webkit.org/show_bug.cgi?id=32292
Patch by Dave Michael <dmichael@chromium.org> on 2013-04-03
Reviewed by Ryosuke Niwa.
Source/WebCore:
Make embed, object, and applet elements support focus() when
appropriate. Prior to this patch, javascript focus() had no effect on
embed, object, or applet elements unless tabindex or contenteditable is
set. With this patch, focus() will focus the element unless the plugin
content has failed to load (i.e., we are showing either fallback content
or an unavailable plugin indicator).
Test: plugins/focus.html
java/focus.html
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::supportsFocus):
Overridden to return true except when the plugin content has failed to load.
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::useFallbackContent):
Moved up from HTMLPlugInImageElement.
(WebCore::HTMLPlugInElement::supportsFocus):
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInImageElement::useFallbackContent):
Removed. Now the implementation is inherited from HTMLPlugInElement.
LayoutTests:
Add/update testing to ensure embed, object, and applet tags now support
focus except when plugin content did not load.
- fast/events/resources/tabindex-focus-blur-all-frame1.html: Change embed and object
elements to reference an invalid plugin, to be consistent with applet. These
element types are not focusable when there is valid plugin content.
- fast/events/resources/tabindex-focus-blur-all-frame2.html: Same as above.
- fast/events/resources/tabindex-focus-blur-all-iframe1.html: Same as above.
- fast/events/resources/tabindex-focus-blur-all-iframe2.html: Same as above.
- java/focus-expected.txt: Added.
- java/focus.html: Added.
- plugins/focus-expected.txt: Added.
- plugins/focus.html: Added.
- 3:33 PM Changeset in webkit [147590] by
-
- 4 edits in tags/Safari-537.35.7/Source
Versioning.
- 3:18 PM Changeset in webkit [147589] by
-
- 1 copy in tags/Safari-537.35.7
New Tag.
- 2:53 PM Changeset in webkit [147588] by
-
- 12 edits5 adds in trunk
Element boundaries prevent Japanese line break opportunities
https://bugs.webkit.org/show_bug.cgi?id=105692
Reviewed by Darin Adler.
Source/WebCore:
Introduce use of prior context when using text break iterators
in non-ASCII path through nextBreakablePosition(). This enables
the use of line break context across an element boundary for
the non-ASCII path. Use of this context with the ASCII path was
enabled by https://bugs.webkit.org/show_bug.cgi?id=17427.
Performance tests of line layout and html5 parsing show that this
patch provides an approximately 4% improvement with Japanese and
no statistically significant regression with ASCII path. Parsing
(html5-full-render) performance is not significantly affected.
Tests: fast/text/line-break-between-text-nodes-cjk.html
fast/text/line-break-between-text-nodes-latin1.html
Expect rebaselines will be needed due to different line breaks:
fast/text/international/003.html
fast/text/international/text-combine-image-test-expected.html
fast/text/writing-mode/Kusa-Makura-background-canvas.html
- platform/text/TextBreakIterator.cpp:
(WebCore::acquireLineBreakIterator): Pass prior context to non-ICU path.
- platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::priorContextLength): Added.
(WebCore::LazyLineBreakIterator::get): Pass prior context to ICU path.
(WebCore::LazyLineBreakIterator::resetStringAndReleaseIterator): Editorial.
- platform/text/TextBreakIteratorICU.cpp:
Use prior context from line break iterators. Requires
adding new UTF16 (UChar*) text provider and reimplementing
Latin1 (LChar*) text provider. Implementation is optimized
by using generic functionality that applies to both string
sources.
(WebCore::textPinIndex): Added.
(WebCore::textNativeLength): Added.
(WebCore::textFixPointer): Added.
(WebCore::textClone): Added.
(WebCore::textExtract): Added.
(WebCore::textClose): Added.
(WebCore::textGetContext): Added.
(WebCore::textLatin1GetCurrentContext): Added.
(WebCore::textLatin1MoveInPrimaryContext): Added.
(WebCore::textLatin1SwitchToPrimaryContext): Added.
(WebCore::textLatin1MoveInPriorContext): Added.
(WebCore::textLatin1SwitchToPriorContext): Added.
(WebCore::textInChunkOrOutOfRange): Added.
(WebCore::textLatin1Access): Added.
(WebCore::textInit): Added.
(WebCore::textOpenLatin1): Added.
(WebCore::textUTF16GetCurrentContext): Added.
(WebCore::textUTF16MoveInPrimaryContext): Added.
(WebCore::textUTF16SwitchToPrimaryContext): Added.
(WebCore::textUTF16MoveInPriorContext): Added.
(WebCore::textUTF16SwitchToPriorContext): Added.
(WebCore::textUTF16Access): Added.
(WebCore::textOpenUTF16): Added.
(WebCore::acquireLineBreakIterator): Use new text providers with prior context.
- platform/text/wchar/TextBreakIteratorWchar.cpp:
(WebCore::acquireLineBreakIterator): Pass prior context to non-ICU path.
- rendering/break_lines.cpp:
(WebCore::nextBreakablePosition): Use prior context in ICU path.
LayoutTests:
- fast/text/line-break-between-text-nodes-cjk-expected.html: Added.
- fast/text/line-break-between-text-nodes-cjk.html: Added.
- fast/text/line-break-between-text-nodes-latin1-expected.html: Added.
- fast/text/line-break-between-text-nodes-latin1.html: Added.
- platform/chromium-linux/fast/text/international/003-expected.png: Rebaselined.
- platform/chromium-linux/fast/text/international/003-expected.txt: Rebaselined.
- platform/chromium-linux/fast/text/international/text-combine-image-test-expected.png: Rebaselined.
- platform/chromium-linux/fast/text/international/text-combine-image-test-expected.txt: Added (previously missing).
- platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Rebaselined.
- platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Rebaselined.
- 2:53 PM Changeset in webkit [147587] by
-
- 13 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Everyone should know about the FTL
https://bugs.webkit.org/show_bug.cgi?id=113897
Reviewed by Mark Hahnenberg.
In order to get OSR exit to work right, we need the distinction between DFG and
FTL to be clear even after compilation finishes, since they will have subtly
different OSR stories and likely use different data structures.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):
(JSC::CodeBlock::adjustedExitCountThreshold):
(JSC::CodeBlock::tallyFrequentExitSites):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::ExecState::isInlineCallFrame):
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::JITCode):
- ftl/FTLState.cpp:
(JSC::FTL::State::dumpState):
- heap/DFGCodeBlocks.cpp:
(JSC::DFGCodeBlocks::jettison):
- interpreter/Interpreter.cpp:
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
- jit/JITCode.cpp:
(WTF::printInternal):
- jit/JITCode.h:
(JSC::JITCode::topTierJIT):
(JSC::JITCode::nextTierJIT):
(JITCode):
(JSC::JITCode::isJIT):
(JSC::JITCode::isLowerTier):
(JSC::JITCode::isHigherTier):
(JSC::JITCode::isLowerOrSameTier):
(JSC::JITCode::isHigherOrSameTier):
(JSC::JITCode::isOptimizingJIT):
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileOptimized):
(JSC::samplingDescription):
(JSC::ProgramExecutable::compileOptimized):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
- 2:51 PM Changeset in webkit [147586] by
-
- 4 edits2 adds in branches/safari-534.59-branch/Source/WebKit2
Fix the build after merging 147042.
- Platform/mac/StringUtilities.h: Added.
(WebKit):
- Platform/mac/StringUtilities.mm: Added.
(WebKit):
(WebKit::nsStringFromWebCoreString):
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextCopyPlugInInfoForBundleIdentifier):
- UIProcess/Plugins/PluginInfoStore.h:
(PluginInfoStore):
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::findPluginWithBundleIdentifier):
- 2:35 PM Changeset in webkit [147585] by
-
- 3 edits in trunk/LayoutTests
get_by_pname can become confused when iterating over objects with static properties
https://bugs.webkit.org/show_bug.cgi?id=113831
Reviewed by Jer Noble.
Improving the test results to make it more obvious why something failed. Also removed
absolute paths from the test.
- fast/js/dom-static-property-for-in-iteration-expected.txt:
- fast/js/dom-static-property-for-in-iteration.html:
- 2:21 PM Changeset in webkit [147584] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed VS2010 build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 2:08 PM Changeset in webkit [147583] by
-
- 10 edits2 deletes in trunk/Source
[Chromium] Bad cast from BitmapImageSingleFrameSkia to BitmapImage
https://bugs.webkit.org/show_bug.cgi?id=113492
Reviewed by Stephen White.
Source/WebCore:
Remove BitmapImageSingleFrameSkia and have ImageBufferSkia construct
BitmapImage objects instead via an intermediate NativeImageSkia.
No new tests, covered by existing tests.
- WebCore.gypi:
- platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Remove
include for BitmapImageSingleFrameSkia.h header.
- platform/graphics/skia/BitmapImageSingleFrameSkia.cpp: Removed.
- platform/graphics/skia/BitmapImageSingleFrameSkia.h: Removed.
- platform/graphics/skia/ImageBufferSkia.cpp: Construct BitmapImage
objects instead of BitmapImageSingleFrameSkia ones.
(WebCore::ImageBuffer::copyImage):
(WebCore::drawNeedsCopy):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
- platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImage::BitmapImage): Implement BitmapImage constructor
that takes an NativeImageSkia* in argument.
(WebCore):
(WebCore::BitmapImage::draw): Remove m_source.initialized() check as
this will return false for BitmapImage objects constructed from a
NativeImageSkia, due to the lack of decoder.
- platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::NativeImageSkia): Add parameter to the
NativeImageSkia constructor so that the caller can request a deep copy
instead of a shallow one. This is needed by the ImageBuffer.
- platform/graphics/skia/NativeImageSkia.h:
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::setSkBitmap):
Source/WebKit/chromium:
Update test now that BitmapImageSingleFrameSkia no longer exists.
BitmapImage is now used instead.
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
- 1:57 PM Changeset in webkit [147582] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should abstract out how it does forward exits, and that code should be simplified
https://bugs.webkit.org/show_bug.cgi?id=113894
Reviewed by Mark Hahnenberg.
1) We previously had two different ways of convertingToForward, one path for
where we had a ValueRecovery for the current node and one where we didn't.
But the paths were doing exactly the same thing except that if you have a
ValueRecovery, you also find the last applicable mov hint and do some
extra things. This patch combines the two paths and bases both of them on
the previous no-ValueRecovery path, which was simpler to begin with.
2) This moves the logic into DFG::OSRExit, which further simplifies the code
and makes the logic available to the FTL.
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::convertToForward):
(DFG):
- dfg/DFGOSRExit.h:
(DFG):
(OSRExit):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
- 1:44 PM Changeset in webkit [147581] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: resultAnimationElement->m_animatedType
https://bugs.webkit.org/show_bug.cgi?id=93528
Patch by David Vest <davve@opera.com> on 2013-04-03
Reviewed by Philip Rogers.
Source/WebCore:
When the order of animation elements change within an animation
group, we can't assume that the resultElement is the same as it
was when the animation was frozen. Make sure to reset the
animation type for the resultElement before updating the
animation.
Test: svg/animations/animation-dependency-crash.html
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::progress):
LayoutTests:
- svg/animations/animation-dependency-crash-expected.txt: Added.
- svg/animations/animation-dependency-crash.html: Added.
- 1:39 PM Changeset in webkit [147580] by
-
- 3 edits in trunk/Source/WebCore
Stop unconditionally enabling JavaScript execution when closing the Web Inspector.
https://webkit.org/b/113889
rdar://problem/12281794
Reviewed by Joseph Pecoraro.
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent): Initialize m_originalScriptExecutionDisabled.
(WebCore::InspectorPageAgent::enable): Populate m_originalScriptExecutionDisabled based on current setting.
(WebCore::InspectorPageAgent::disable): Restore previous setting.
- inspector/InspectorPageAgent.h:
(InspectorPageAgent): Added m_originalScriptExecutionDisabled.
- 1:13 PM Changeset in webkit [147579] by
-
- 10 edits in trunk/Source
Cross fade into restarted plugin
https://bugs.webkit.org/show_bug.cgi?id=113868
Reviewed by Tim Horton.
Source/WebCore:
Allow a restarted plugin to fade in over its snapshot, avoiding the abrupt
flash of empty content. The WebCore part of this patch marks the plugin
element as restarted, and draws the snapshot for a short amount of time
as the plugin is restarting. After the plugin has reappeared, we stop drawing
the snapshot.
There is a little bit of drive-by whitespace removal in HTMLPlugInImageElement.
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::restartedPlugin): New method indicating if the plugin has been restarted.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Initialise new timer and member variable.
(WebCore::HTMLPlugInImageElement::setDisplayState): If we are moving into a restarting state, make sure
to remember this and also start a timer so that we show the snapshot for while.
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired): No need to draw the snapshot from here on.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): Member variable to remember if we've restarted.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintContents): Only exit early from the paint if we're not a restarting
plugin, otherwise we do want to draw the snapshot if there is one.
- rendering/RenderLayerBacking.cpp:
(WebCore::isRestartedPlugin): Detects a restarted plugin.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Don't become a simple container
compositing layer if you're a restarted plugin.
Source/WebKit2:
Add a new plugin process type that indicates this is a plugin that
has been restarted from snapshotting. On Apple ports, this allows
us to animate the appearance of the plugin so that it crossfades
with the snapshot. Other ports will have to add their own fading.
- PluginProcess/PluginProcess.h: New Type: TypeRestartedProcess.
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::PluginProxy::pluginLayer): When the plugin's CALayer is created, if it
is a restarted plugin, add an opacity animation to fade it in.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): Mark restarted plugins with the new process type.
- 1:05 PM Changeset in webkit [147578] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Adjustments to media controls appearance.
https://bugs.webkit.org/show_bug.cgi?id=113816
https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=316398
https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=316438
Updates to the BlackBerry media controls:
- extend the timeline slider.
- move the volume slider for audio elements up so it does not overlap the main panel.
- upstream some other cosmetic changes to media controls that were not previously upstreamed.
Patch by John Griggs <jgriggs@blackberry.com> on 2013-04-03
Reviewed by Rob Buis.
BlackBerry-specific, cosmetic change; No new tests required.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::paintMediaPlayButton):
(WebCore::RenderThemeBlackBerry::paintMediaMuteButton):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderThumb):
- 12:53 PM Changeset in webkit [147577] by
-
- 5 edits in trunk/LayoutTests
Compositing tests failing after http://trac.webkit.org/changeset/147502
https://bugs.webkit.org/show_bug.cgi?id=113838
Reviewed by Dean Jackson.
Add (contentsOpaque 1) to the DRT text output in some expectations files due to bug 70634
"Mark GraphicsLayers as opaque when possible" [1]. The expectations in the guilty changeset
weren't updated after bug 70634 landed.
[1]: https://bugs.webkit.org/show_bug.cgi?id=70634
- compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
- platform/mac/TestExpectations:
- 12:41 PM Changeset in webkit [147576] by
-
- 3 edits in branches/dfgFourthTier/WebKitLibraries
Updated LLVM drops to include LLVM_DO_NOT_INCLUDE_CPP_HEADERS changes.
Rubber stamped by Mark Hahnenberg.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 12:29 PM Changeset in webkit [147575] by
-
- 2 edits in branches/safari-534.59-branch/Source/WebKit2
Remove include after mis-merge of r147052.
- UIProcess/API/C/WKAPICast.h:
- 12:16 PM Changeset in webkit [147574] by
-
- 3 edits in trunk/Tools
[GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
https://bugs.webkit.org/show_bug.cgi?id=113883
Reviewed by Martin Robinson.
- gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
- gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
- 12:08 PM Changeset in webkit [147573] by
-
- 3 edits in branches/chromium/1453/Source/WebCore/platform/image-decoders/gif
Merge 147392 "Simply GIFImageReader error handling"
Simply GIFImageReader error handling
https://bugs.webkit.org/show_bug.cgi?id=113718
Reviewed by Adam Barth.
When GIFImageReader encounters a parsing error it should just return
without doing any more work. Current code saves a boolean before return,
this is not necessary.
Tested with existing unit tests.
Tested locally with ASAN build with 60k GIF images.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::repetitionCount):
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::decode):
- platform/image-decoders/gif/GIFImageReader.h:
(GIFImageReader::GIFImageReader):
(GIFImageReader):
TBR=hclam@chromium.org
Review URL: https://codereview.chromium.org/13578002
- 11:58 AM Changeset in webkit [147572] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13564588> Add a temporary workaround for a build failure.
Fix suggested by Mark Rowe.
- Shared/mac/ChildProcessMac.mm:
- 11:47 AM Changeset in webkit [147571] by
-
- 8 edits in branches/safari-534.59-branch/Source/WebKit2
Merge 147052. <rdar://problem/13528851>
- 11:38 AM Changeset in webkit [147570] by
-
- 5 edits2 adds in trunk
get_by_pname can become confused when iterating over objects with static properties
https://bugs.webkit.org/show_bug.cgi?id=113831
Reviewed by Geoffrey Garen.
get_by_pname doesn't take static properties into account when using a JSPropertyNameIterator to directly
access an object's backing store. One way to fix this is to not cache any properties when iterating over
objects with static properties. This patch fixes the bug that was originally reported on swisscom.ch.
Source/JavaScriptCore:
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnNonIndexPropertyNames):
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::numCacheableSlots):
(JSC::PropertyNameArray::setNumCacheableSlots):
(PropertyNameArray):
LayoutTests:
- fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
- fast/js/dom-static-property-for-in-iteration.html: Added.
- 11:27 AM Changeset in webkit [147569] by
-
- 3 edits in trunk/WebKitLibraries
[Windows, WinCairo] Unreviewed VS2010 Build Correction
- win/tools/scripts/auto-version2010.sh: Added properties svn:eol-style and svn:executable.
- win/tools/scripts/feature-defines2010.sh: Added properties svn:eol-style and svn:executable.
- 11:23 AM Changeset in webkit [147568] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] XMLHttpRequest upload events don't work with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=113887
Reviewed by Brady Eidson.
Just forward didSendData client call to WebProcess.
- NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::didSendData): (WebKit::NetworkResourceLoader::didCancelAuthenticationChallenge): Tweaked a comment.
- WebProcess/Network/WebResourceLoader.cpp: (WebKit::WebResourceLoader::didSendData):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- 11:12 AM Changeset in webkit [147567] by
-
- 2 edits in trunk/Source/WebCore
[Gstreamer] Use gst_buffer_extract() in copyGstreamerBuffersToAudioChannel()
https://bugs.webkit.org/show_bug.cgi?id=113880
Reviewed by Philippe Normand.
copyGstreamerBuffersToAudioChannel() was mapping the GstBuffer content to memcpy
it to the AudioChannel buffer. This patch leverages gst_buffer_extract() to
simplify the code as it does exactly what we need: gst_buffer_map, memcpy,
gst_buffer_unmap and error handling.
Also replace GstBuffer NULL check by an assertion as we already make sure they
are not NULL before adding them to the list. Additionally, we now call
audioChannel->mutableData() only once instead of once per iteration. It is
a bit better as the getter does some work internally.
No new tests, no behavior change.
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::copyGstreamerBuffersToAudioChannel):
- 10:30 AM Changeset in webkit [147566] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: DOM.highlightRect() and DOM.highlightQuad() should allow for page coordinates
https://bugs.webkit.org/show_bug.cgi?id=113869
Add a new "usePageCoordinates" parameter to DOM.highlightRect() and DOM.highlightQuad()
allowing to specify that the rect or quad to highlight should be converted to page
coordinates instead of using the default viewport coordinates.
Reviewed by Timothy Hatcher.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::innerHighlightQuad):
Store the "usePageCoordinates" parameter obtained from the protocol calls onto the
highlight configuration object so that it may be used within the InspectorOverlay.
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::highlightQuad):
Check the highlight configuration for the "usePageCoordinates" parameter and
apply the inverse of the page's scroll offset to the quad if it's true.
- inspector/InspectorOverlay.h:
(HighlightConfig):
(WebCore::Highlight::setDataFromConfig):
(Highlight):
- 9:43 AM Changeset in webkit [147565] by
-
- 2 edits in trunk/Source/WebCore
Add omitted reference operator of VisiblePosition in AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=113879
Reviewed by Darin Adler.
Seems reference operator has been omitted in startOfStyleRange function, so add it.
- accessibility/AccessibilityObject.cpp:
(WebCore::startOfStyleRange):
- 9:35 AM Changeset in webkit [147564] by
-
- 2 edits in trunk/Tools
[GTK] Include Pango in jhbuild-optional.modules
https://bugs.webkit.org/show_bug.cgi?id=113878
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-03
Reviewed by Martin Robinson.
Since r147547 Pango 1.32.0 is required. Including the module in the
JHBuild optional moduleset.
- gtk/jhbuild-optional.modules: Add Pango module.
- 9:27 AM Changeset in webkit [147563] by
-
- 5 edits in trunk/Tools
[Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
https://bugs.webkit.org/show_bug.cgi?id=113864
Moving setDefersLoading from TestRunnerQt to TestRunner
requires access to the non-Qt TestRunner.
As long as we instantiate both TestRunner and TestRunnerQt,
we need a separate getter for the non-Qt TestRunner instance.
Reviewed by Simon Hausmann.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebPage::resetSettings):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree::jscTestRunner):
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::setDefersLoading):
Moving setDefersLoading from TestRunnerQt
to TestRunner.
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
- 9:12 AM Changeset in webkit [147562] by
-
- 2 edits in trunk/Source/WebCore
Update the localizable strings file.
Rubber-stamped by Michael Saboff.
- English.lproj/Localizable.strings:
- 8:58 AM Changeset in webkit [147561] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r147493): Fix number of arguments to AudioDestinationIOS constructor
Fixes the following build failures:
Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:84:25: error: no matching constructor for initialization of 'WebCore::AudioDestinationIOS'
return adoptPtr(new AudioDestinationIOS(callback, sampleRate));
In file included from Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:36:
Source/WebCore/platform/audio/ios/AudioDestinationIOS.h:44:5: note: candidate constructor not viable: requires 3 arguments, but 2 were provided
AudioDestinationIOS(AudioIOCallback&, unsigned numberOfOutputChannels, double sampleRate);
Source/WebCore/platform/audio/ios/AudioDestinationIOS.h:42:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
class AudioDestinationIOS : public AudioDestination, public AudioSessionListener {
Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:101:22: error: out-of-line definition of 'AudioDestinationIOS' does not match any declaration in 'WebCore::AudioDestinationIOS'
AudioDestinationIOS::AudioDestinationIOS(AudioIOCallback& callback, double sampleRate)
2 errors generated.
- platform/audio/ios/AudioDestinationIOS.h:
(AudioDestinationIOS): Remove numberOfOutputChannels argument.
- 8:51 AM Changeset in webkit [147560] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r147494): -[AVAudioSession setCategory:error:] takes NSError
Fixes the following build failure:
Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:151:71: error: cannot initialize a parameter of type 'NSError ' with an lvalue of type 'NSError *'
[[AVAudioSession sharedInstance] setCategory:categoryString error:error];
- platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::setCategory): Add '&' operator.
- 8:45 AM Changeset in webkit [147559] by
-
- 2 edits in trunk/Tools
[GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
https://bugs.webkit.org/show_bug.cgi?id=104779
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-03
Reviewed by Carlos Garcia Campos.
- Scripts/run-gtk-tests:
(TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
passing in current trunk.
- 8:45 AM Changeset in webkit [147558] by
-
- 8 edits2 adds in trunk
CSP blocks inline style when cloning a node
https://bugs.webkit.org/show_bug.cgi?id=112270
Patch by Felipe Zimmerle <felipe@zimmerle.org> on 2013-04-03
Reviewed by Adam Barth.
Source/WebCore:
Checks if the Element is being cloned, if so, the application of the
style is allowed otherwise it relies on default permission mechanism.
Test: http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html
- dom/Element.cpp:
(WebCore::Element::attributeChanged): Added parameter
AttributeModificationReason to the method signature.
(WebCore::Element::cloneAttributesFromElement): It is now calling
attributeChanged with AttributeModificationReason parameter. In this scope
it is always set to ModifiedByCloning.
(WebCode::Element::attributeChangedFromParserOrByCloning):
Added parameter AttributeModificationReason.
- dom/Element.h: Added AttributeModificationReason enum. Used to specify
whenever an attribute was set by a cloned oject or directly.
AttributeModificationReason added to attributeChanged with the default
value set to ModifiedDirectly.
- dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged): Added
AttributeModificationReason to the method signature.
(WebCore::StyledElement::styleAttributeChanged): Now it is checking the
reason of the update, if the reason is ModifiedDirectly check CSP
before set. If ModifiedByCloning set the attribute ignoring the CSP
policy.
- dom/StyledElement.h:
(StyledElement): Added AttributeModificationReason parameter to the methods:
attributeChanged and styleAttributeChanged, attributeChanged has
ModifiedDirectly as default value.
- svg/SVGElement.cpp:
(WebCore::SVGElement::attributeChanged): Added AttributeModificationReason
parameter to the method signature.
- svg/SVGElement.h:
(SVGElement): Added AttributeModificationReason parameter to the
attributeChanged signature with the default value set to:
ModifiedDirectly.
LayoutTests:
- http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html: Added.
- 8:18 AM Changeset in webkit [147557] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] WebKitWebNavigationAction: fix mix between dispose and finalize
https://bugs.webkit.org/show_bug.cgi?id=113794
Patch by Alban Crequy <alban.crequy@collabora.co.uk> on 2013-04-03
Reviewed by Gustavo Noronha Silva.
WebKitWebNavigationAction's dispose function was named finalize and was calling
the parent class's finalise function, causing a memory corruption. Change it to
be a proper finalize function instead.
- webkit/webkitwebnavigationaction.cpp:
(webkit_web_navigation_action_class_init):
- 8:11 AM Changeset in webkit [147556] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed 32bit buildfix after r147542.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveBinaryData):
- 8:09 AM Changeset in webkit [147555] by
-
- 2 edits in trunk/Source/WebCore
[Gstreamer] Avoid calls to g_slist_nth_data in webKitWebAudioSrcLoop()
https://bugs.webkit.org/show_bug.cgi?id=113875
Reviewed by Philippe Normand.
webKitWebAudioSrcLoop() was iterating over 2 GSLists by using a counter and then
calling g_slist_nth_data() to get the element of each GSList. This is inefficient
because calling g_slist_nth_data() will iterate the GSList up until index 'n'.
This patch improves this by keeping pointers to the current element of each list
while iterating, so that we can simply use g_slist_next() to iterate instead
of g_slist_nth_data().
No new tests, no behavior change.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop):
- 8:04 AM Changeset in webkit [147554] by
-
- 4 edits in trunk/Source/WebCore
Actions that require user gesture don't work in window.showModalDialog in Chromium
https://bugs.webkit.org/show_bug.cgi?id=113777
Reviewed by Jochen Eisinger.
In Chromium the window for showModalDialog is not modal which causes the
UserGestureIndicator to block actions in the sub window. We introduce a
RAII that saves the UserGestureIndicator and state, then resets it before
runModalDialog, and restore it when it's done.
No new tests. Can't cause user gesture inside modal dialog.
- dom/UserGestureIndicator.cpp:
(WebCore::UserGestureIndicatorDisabler::UserGestureIndicatorDisabler): Saves and resets the topmost indicator and state.
(WebCore):
(WebCore::UserGestureIndicatorDisabler::~UserGestureIndicatorDisabler): Restores topmost indicator and state.
- dom/UserGestureIndicator.h:
(WebCore):
(UserGestureIndicatorDisabler): RAII to temporarily disable UserGestureIndicator.
(UserGestureIndicator): Allow access to UserGestureIndicatorDisabler.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog): Disable UserGestureIndicator while runModalDialog.
- 8:02 AM Changeset in webkit [147553] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fail gracefully if an OpenGL context could not be created.
https://bugs.webkit.org/show_bug.cgi?id=113784
In case we fail to create or adopt a valid platform OpenGL context
we do not want to provide a GraphicsContext3D instance.
Otherwise we would crash as soon as the instance is being used.
Reviewed by Jocelyn Turcotte.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 7:36 AM Changeset in webkit [147552] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove defaultViewportArguments check from call site of recomputeVirtualViewportFromViewportArguments
https://bugs.webkit.org/show_bug.cgi?id=113872
Reviewed by Carlos Garcia Campos.
Carlos pointed out that recomputeVirtualViewportFromViewportArguments
already contains the check, and returns an empty IntSize if it fails.
So pick up on that to make the code a bit more DRY.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 7:23 AM Changeset in webkit [147551] by
-
- 15 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening. Updated platform specific expected files after r147492.
- platform/qt/TestExpectations:
- platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
- platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- platform/qt/fast/encoding/utf-16-big-endian-expected.png:
- platform/qt/fast/encoding/utf-16-big-endian-expected.txt:
- platform/qt/fast/encoding/utf-16-little-endian-expected.png:
- platform/qt/fast/encoding/utf-16-little-endian-expected.txt:
- platform/qt/fast/forms/input-value-expected.png: Added.
- platform/qt/fast/forms/input-value-expected.txt:
- platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.png:
- platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- 7:15 AM Changeset in webkit [147550] by
-
- 2 edits in trunk/Tools
Fix HAVE(QTTESTSUPPORT) logic
build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
resulting in HAVE(QTTESTSUPPORT) never being true.
Move that logic down in sanitizeFeatures.
Patch by Pierre Rossi <pierre.rossi@digia.com> on 2013-04-03
Rubber-stamped by Tor Arne Vestbø.
- qmake/mkspecs/features/features.prf:
- 6:23 AM Changeset in webkit [147549] by
-
- 3 edits in trunk/Source/WebCore
[GTK][AC] Implement matrix keyframe animations with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=110314
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-03
Reviewed by Gustavo Noronha Silva.
Clutter 1.12 doesn't support additive transform animations yet, So clutter ac backend
uses matrix animations for the case. This patch follows changeset 143369, 143343
to support matrix keyframe animations. I believe this change is easy if you understand
above two changesets.
Covered by existing animation tests.
- platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::PlatformClutterAnimation::setValues):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):
(WebCore):
(WebCore::PlatformClutterAnimation::addTransformTransition):
- platform/graphics/clutter/PlatformClutterAnimation.h:
(PlatformClutterAnimation):
- 6:20 AM Changeset in webkit [147548] by
-
- 11 edits2 adds in trunk
Should close select popup when the element loses focus
https://bugs.webkit.org/show_bug.cgi?id=113220
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-04-03
Reviewed by Kent Tamura.
Source/WebCore:
Test: fast/forms/select-popup-closes-on-blur.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): handle the blur event, closing
the popup menu if any.
- testing/Internals.cpp:
(WebCore::Internals::isSelectPopupVisible): utility to query the select node renderer to
find out whether the popup is open or closed.
(WebCore):
- testing/Internals.h: add the new method definition.
- testing/Internals.idl: ditto.
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in: export WebCore::HTMLNames::selectTag for Internals
LayoutTests:
- fast/forms/select/popup-closes-on-blur-expected.txt: Added.
- fast/forms/select/popup-closes-on-blur.html: Added.
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 6:20 AM Changeset in webkit [147547] by
-
- 4 edits in trunk
[GTK] Bump required versions of some dependencies
https://bugs.webkit.org/show_bug.cgi?id=113282
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-03
Reviewed by Martin Robinson.
.:
This patch updates the following dependencies:
- libsoup 2.42.0: is the current stable release.
- glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
- gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
- at-spi2 2.5.3: is the version required by gtk+ 3.6.
- GObject introspection 1.32.0: is the version required by gtk+ 3.6.
- Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
- Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
- gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
- Source/autotools/Versions.m4:
Tools:
- gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
- 6:12 AM Changeset in webkit [147546] by
-
- 2 edits in trunk/Tools
[GTK] gst-plugins-good fails to build with newer Linux(v4l2)
https://bugs.webkit.org/show_bug.cgi?id=113809
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-04-03
Reviewed by Philippe Normand.
Newer Linux kernels have removed some deprecated macros from v4l2
headers, causing gst-plugins-good's build to break. We don't need it
right now, so just disable it.
- gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
- 5:44 AM Changeset in webkit [147545] by
-
- 12 edits in trunk
[Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
https://bugs.webkit.org/show_bug.cgi?id=113535
Reviewed by Simon Hausmann.
Source/WebCore:
Now Qt uses the CROSS_PLATFORM_CONTEXT_MENUS
USE flag. This flag provides a full cross-platform
representation of a ContextMenu and a ContextMenuItem.
The embedder can then decide how to show this, so neither
WebCore nor WebCore/platform need to know any platform
specifics about menus.
No new tests, no behavior changes.
- Target.pri:
- platform/ContextMenu.h:
(ContextMenu):
- platform/ContextMenuItem.h:
- platform/qt/ContextMenuItemQt.cpp:
(WebCore::ContextMenuItem::platformContextMenuItem):
- platform/qt/ContextMenuQt.cpp:
(WebCore::ContextMenu::ContextMenu):
(WebCore::ContextMenu::getContextMenuItems):
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):
Source/WebKit/qt:
Adjust ContextMenuClientQt and QWebPageAdapter to use CROSS_PLATFORM_CONTEXT_MENUS
USE flag by implementing customizeMenu() instead of getCustomMenuFromDefaultItems()
and by calling menu->items() instead of menu->platformDescription().
- WebCoreSupport/ContextMenuClientQt.cpp:
(WebCore::ContextMenuClientQt::customizeMenu):
- WebCoreSupport/ContextMenuClientQt.h:
(ContextMenuClientQt):
- WebCoreSupport/QWebPageAdapter.cpp:
(descriptionForPlatformMenu):
(QWebPageAdapter::updatePositionDependentMenuActions):
Tools:
Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
- qmake/mkspecs/features/features.prf:
- 5:35 AM Changeset in webkit [147544] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Monospace font does not render in proper sizes
https://bugs.webkit.org/show_bug.cgi?id=93263
Reviewed by Jocelyn Turcotte.
Remove this patch's artificial dependency on Qt 5.1.
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- 5:33 AM Changeset in webkit [147543] by
-
- 3 edits in trunk/Tools
[Qt] Move logic of simple forwarding functions to TestRunner.
https://bugs.webkit.org/show_bug.cgi?id=113863
Reviewed by Simon Hausmann.
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::setTextDirection):
(TestRunner::goBack):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::addUserStyleSheet):
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
- 5:15 AM Changeset in webkit [147542] by
-
- 6 edits in trunk/Source/WebCore
Refine LOG messages in WebSocket related components
https://bugs.webkit.org/show_bug.cgi?id=113852
Patch by Takeshi Yoshino <tyoshino@chromium.org> on 2013-04-03
Reviewed by Kent Tamura.
Refine LOG messages by
- Make them contain method names to ease identifying where the event occurred.
- For consistency, make all messages print the pointer of the origin instance.
- Quote UTF8 data in LOG messages.
- For overloaded methods, add the type to clarify which one is run
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::contextDestroyed):
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didReceiveBinaryData):
(WebCore::WebSocket::didReceiveMessageError):
(WebCore::WebSocket::didUpdateBufferedAmount):
(WebCore::WebSocket::didStartClosingHandshake):
(WebCore::WebSocket::didClose):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::subprotocol):
(WebCore::WebSocketChannel::extensions):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::bufferedAmount):
(WebCore::WebSocketChannel::close):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::willOpenSocketStream):
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::didStartLoading):
(WebCore::WebSocketChannel::didReceiveData):
(WebCore::WebSocketChannel::didFinishLoading):
(WebCore::WebSocketChannel::didFail):
(WebCore::WebSocketChannel::appendToBuffer):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::closingTimerFired):
- Modules/websockets/WebSocketDeflater.cpp:
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::WebSocketInflater::~WebSocketInflater):
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readServerHandshake):
- platform/network/chromium/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandleInternal::connect):
(WebCore::SocketStreamHandleInternal::send):
(WebCore::SocketStreamHandleInternal::close):
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didSendData):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):
- 4:56 AM Changeset in webkit [147541] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Update QMAKE_MAC_SDK check for Qt 5.1
Relies on QMAKE_MAC_SDK_VERSION set in features.prf
Reviewed by Simon Hausmann.
- WebCore.pri:
- 4:56 AM Changeset in webkit [147540] by
-
- 2 edits in trunk/Tools
[Qt] Disable media support using QuickTime if deployment target != SDK
We link to a single libWebKitSystemInterface static lib, so unless the
deployment target matches the SDK let's not pretend like we'll be able
to run on anything lower than the SDK version.
Reviewed by Simon Hausmann.
- qmake/mkspecs/features/features.prf:
- 4:15 AM Changeset in webkit [147539] by
-
- 2 edits in trunk/Source/WebCore
[Qt] assignToHTMLImageElement no longer exists in Qt5
https://bugs.webkit.org/show_bug.cgi?id=113639
Patch by Kristof Provost <kristof@codepro.be> on 2013-04-03
Reviewed by Simon Hausmann.
No new tests: covered by ./Source/WebKit/qt/tests/hybridPixmap/test.html
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntime::getClassRef):
- 4:06 AM Changeset in webkit [147538] by
-
- 5 edits1 copy1 add in trunk
Web Inspector: crash in WebCore::InspectorLayerTreeAgent::buildObjectForLayer if a layer is created for an anonymous RenderObject (:first-letter)
https://bugs.webkit.org/show_bug.cgi?id=113768
Source/WebCore:
The InspectorLayerTreeAgent now knows how to deal with anonymous RenderObjects
for the :first-letter and :first-line pseudo-elements.
Reviewed by Timothy Hatcher.
Test: inspector-protocol/layers/layers-anonymous.html
- inspector/Inspector.json:
Change the Layer type in the LayerTree domain to have more accurate terminology
(pseudo-element vs. pseudo-class) and a new optional isAnonymous flag for layers
associated to anonymous RenderObjects.
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
Check for anonymous RenderObjects and set the parent renderer's node as the node
for this layer since anonymous renderers have the Document as their node and this
would not be satisfactory to show in a front-end. We also check for anonymous
RenderObjects for the :first-letter and :first-line pseudo-elements and set them
in the pseudoElement property of the Layer object created such that a front-end
could correctly identify what type of pseudo-element for the associated node
yielded this layer.
(WebCore::InspectorLayerTreeAgent::idForNode):
Here we fix the actual crash by first checking if the node provided is null and
returning 0 if there's no such node. This ensures that any scenario where there
is no node associated with the RenderObject simply informs of the front-end that
no such node exists and we do not crash.
LayoutTests:
Reviewed by Timothy Hatcher.
- inspector-protocol/layers/layers-anonymous-expected.txt: Added.
- inspector-protocol/layers/layers-anonymous.html: Added.
New test for layers created for CSS anonymous boxes or blocks.
- inspector-protocol/layers/layers-generated-content.html:
Update test to use the "pseudoElement" property instead of "pseudoClass"
which was the previous, less accurate name.
- 4:06 AM Changeset in webkit [147537] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Decouple layout viewport from visual viewport
https://bugs.webkit.org/show_bug.cgi?id=113829
Reviewed by Carlos Garcia Campos.
Setting the visual viewport would force the layout viewport equal to
the visual viewport. Decouple the viewports by allowing the user to
specify a layout viewport when setting the viewport(s). The layout
viewport could be the exact same value passed for visual viewport, if
the old behavior is desired.
Also reevaluate any viewport arguments when (only) the layout viewport
changes in WebPage::setDefaultLayoutSize() since the layout viewport is
used as input to the calculation.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setScreenOrientation):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::setViewportSize):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPage::defaultLayoutSize):
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- 3:59 AM Changeset in webkit [147536] by
-
- 13 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining after r147530.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 3:24 AM Changeset in webkit [147535] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [REGRESSION(r147117)][Elements] Copy/paste keyboard shortcuts broken in "Edit as HTML"
https://bugs.webkit.org/show_bug.cgi?id=113798
Reviewed by Yury Semikhatsky.
Stop propagation of "copy" event from the multiline editor's
CodeMirror host element so that it is not handled by
WebInspector.documentCopy().
- inspector/front-end/UIUtils.js:
(.consumeCopy):
(.cleanUpAfterEditing):
- inspector/front-end/inspector.js:
(WebInspector.addMainEventListeners):
- 2:49 AM Changeset in webkit [147534] by
-
- 4 edits in trunk/LayoutTests
[EFL] accessibility/ignore-spacer-elements.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112001
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-04-03
Reviewed by Gyuyoung Kim.
Fixed failing test. The reason of failure is different expectation of childrenCount.
- accessibility/ignore-spacer-elements.html:
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- 2:48 AM Changeset in webkit [147533] by
-
- 3 edits3 adds in trunk
With borders of differing alpha, the corners become squared off
https://bugs.webkit.org/show_bug.cgi?id=113744
Reviewed by Simon Fraser.
Source/WebCore:
paintTranslucentBorderSides should pick up borders with common color
in order: top, bottom, left and right (not top, right, bottom and
left), because willBeOverdrawn depends on the assumption, borders are
drawn in order: top, bottom, left and right.
Test: fast/borders/border-left-right-same-bottom-different-color.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
LayoutTests:
- fast/borders/border-left-right-same-bottom-different-color-expected.txt: Added.
- fast/borders/border-left-right-same-bottom-different-color.html: Added.
- platform/chromium-linux/fast/borders/border-left-right-same-bottom-different-color-expected.png: Added.
- 2:45 AM Changeset in webkit [147532] by
-
- 2 edits4 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Updated platform specific expected files.
- platform/qt/TestExpectations: Skipped failing reftest.
- platform/qt/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added after r147502.
- platform/qt/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added after r147502.
- platform/qt/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added after r147502.
- platform/qt/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added after r147502.
- 2:31 AM Changeset in webkit [147531] by
-
- 2 edits in trunk/Source/WebCore
[New Multicolumn]Remove assert in RenderMultiColumnFlowThread::createAnonymous
https://bugs.webkit.org/show_bug.cgi?id=113855
Reviewed by Antti Koivisto.
Remove CSSRegions specific assert from new multicolumn implementation.
No change in functionality, no new tests.
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::createAnonymous):
- 2:28 AM Changeset in webkit [147530] by
-
- 22 edits in trunk
X-Frame-Options: Blocked frames should not inherit their parent's SecurityOrigin.
https://bugs.webkit.org/show_bug.cgi?id=112903
Reviewed by Adam Barth.
Source/WebCore:
This change brings WebKit in line with IE and Gecko's behavior, both of
which treat the blocked frame as being cross-origin for the purposes of
access checks ('[frame].contentWindow.location.href' is inaccessible,
for example).
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
Rather than redirecting to 'about:blank', redirect to a URL which
does not inherit the SecurityOrigin of the parent.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
Before calling cancelMainResourceLoad, ensure that the frame's
document is sandboxed into a unique origin so that it doesn't inherit
the parent's SecurityOrigin.
LayoutTests:
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html:
- http/tests/security/XFrameOptions/x-frame-options-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 2:19 AM Changeset in webkit [147529] by
-
- 9 edits1 add in trunk/Source
[Chromium] Implement target-densityDpi viewport property emulation
https://bugs.webkit.org/show_bug.cgi?id=110835
The value is only used in the Chromium port, when the corresponding
setting is enabled.
This is needed for supporting existing WebView-based applications
that rely on this property.
Reviewed by Adam Barth.
Source/WebCore:
- dom/ViewportArguments.cpp:
(WebCore::findTargetDensityDPIValue):
(WebCore):
(WebCore::setViewportFeature):
- dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):
Source/WebKit/chromium:
- public/WebSettings.h:
(WebSettings):
- src/ChromeClientImpl.cpp:
(WebKit):
(WebKit::calculateTargetDensityDPIFactor):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setSupportDeprecatedTargetDensityDPI):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::supportDeprecatedTargetDensityDPI):
- tests/WebFrameTest.cpp:
- tests/data/viewport-target-densitydpi-high.html: Added.
- 1:56 AM Changeset in webkit [147528] by
-
- 14 edits in trunk/LayoutTests
Unreviewed, rolling out r147409.
http://trac.webkit.org/changeset/147409
https://bugs.webkit.org/show_bug.cgi?id=113856
The baselines should be reverted after r147450. (Requested by
kadam on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-03
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- platform/qt/TestExpectations:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 1:38 AM Changeset in webkit [147527] by
-
- 82 edits3 moves in trunk/LayoutTests
Unreviewed. Rebaseline several tests for Chromium that have better output after
r147492.
- platform/chromium-linux/editing/selection/select-missing-image-expected.png:
- platform/chromium-linux/fast/block/float/002-expected.png:
- platform/chromium-linux/fast/block/float/017-expected.png:
- platform/chromium-linux/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-linux/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-linux/fast/flexbox/023-expected.png:
- platform/chromium-linux/fast/flexbox/024-expected.png:
- platform/chromium-linux/fast/forms/input-value-expected.png:
- platform/chromium-linux/fast/forms/input-value-expected.txt:
- platform/chromium-linux/fast/invalid/012-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-mac-lion/editing/selection/select-missing-image-expected.png:
- platform/chromium-mac-lion/fast/block/float/002-expected.png:
- platform/chromium-mac-lion/fast/block/float/017-expected.png:
- platform/chromium-mac-lion/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-mac-lion/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-mac-lion/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-mac-lion/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-mac-lion/fast/flexbox/023-expected.png:
- platform/chromium-mac-lion/fast/flexbox/024-expected.png:
- platform/chromium-mac-lion/fast/forms/005-expected.png:
- platform/chromium-mac-lion/fast/forms/input-value-expected.png:
- platform/chromium-mac-lion/fast/invalid/012-expected.png:
- platform/chromium-mac-lion/fast/parser/comment-in-script-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-mac-snowleopard/fast/block/float/002-expected.png:
- platform/chromium-mac-snowleopard/fast/block/float/017-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-mac-snowleopard/fast/flexbox/023-expected.png:
- platform/chromium-mac-snowleopard/fast/flexbox/024-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
- platform/chromium-mac-snowleopard/fast/invalid/012-expected.png:
- platform/chromium-mac-snowleopard/fast/parser/comment-in-script-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-mac/editing/selection/select-missing-image-expected.png:
- platform/chromium-mac/fast/block/float/002-expected.png:
- platform/chromium-mac/fast/block/float/017-expected.png:
- platform/chromium-mac/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-mac/fast/dom/HTMLImageElement/image-alt-text-expected.txt: Renamed from LayoutTests/platform/chromium/fast/dom/HTMLImageElement/image-alt-text-expected.txt.
- platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Renamed from LayoutTests/platform/chromium/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt.
- platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.txt:
- platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.txt:
- platform/chromium-mac/fast/flexbox/023-expected.png:
- platform/chromium-mac/fast/flexbox/024-expected.png:
- platform/chromium-mac/fast/forms/005-expected.png:
- platform/chromium-mac/fast/forms/input-value-expected.png:
- platform/chromium-mac/fast/forms/input-value-expected.txt:
- platform/chromium-mac/fast/invalid/012-expected.png:
- platform/chromium-mac/fast/parser/comment-in-script-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.txt: Renamed from LayoutTests/platform/chromium/tables/mozilla/collapsing_borders/bug41262-3-expected.txt.
- platform/chromium-win/editing/selection/select-missing-image-expected.png:
- platform/chromium-win/fast/block/float/002-expected.png:
- platform/chromium-win/fast/block/float/017-expected.png:
- platform/chromium-win/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-win/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
- platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- platform/chromium-win/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-win/fast/encoding/utf-16-big-endian-expected.txt:
- platform/chromium-win/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-win/fast/encoding/utf-16-little-endian-expected.txt:
- platform/chromium-win/fast/flexbox/023-expected.png:
- platform/chromium-win/fast/flexbox/024-expected.png:
- platform/chromium-win/fast/forms/input-value-expected.png:
- platform/chromium-win/fast/forms/input-value-expected.txt:
- platform/chromium-win/fast/invalid/012-expected.png:
- platform/chromium-win/fast/parser/comment-in-script-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- platform/chromium/TestExpectations:
- 1:31 AM Changeset in webkit [147526] by
-
- 4 edits in trunk/Source/WebCore
Extract URL that doesn't inherit a parent's SecurityOrigin out into a constant.
https://bugs.webkit.org/show_bug.cgi?id=113780
Reviewed by Jochen Eisinger.
We're scheduling navigations to 'data:text/html,' in XSSAuditor in
order to end up on a page that doesn't inherit its parent's
SecurityOrigin. We'll be reusing this mechainsm to solve
http://wkbug.com/112903
This patch makes us more explicit about what we're doing and why.
It doesn't change any behavior: XSSAuditor tests should still pass.
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
Use SecurityOrigin::urlWithUniqueSecurityOrigin rather than a
literal string to make our intentions clear.
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::urlWithUniqueSecurityOrigin):
- page/SecurityOrigin.h:
Add the new static method.
- 1:21 AM Changeset in webkit [147525] by
-
- 7 edits in trunk/Source
Remove code for Mac 10.5 and earlier from WTF and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=113844
Reviewed by Benjamin Poulain.
Removed the code for 10.5 and removed if-def for 10.6.
Source/WebKit2:
- Shared/mac/PasteboardTypes.mm:
(WebKit::PasteboardTypes::forEditing):
Source/WTF:
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- wtf/Platform.h:
- wtf/ThreadingPthreads.cpp:
(WTF::initializeCurrentThreadInternal):
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault):
- 12:54 AM Changeset in webkit [147524] by
-
- 14 edits in trunk/LayoutTests
Unreviewed, rebaseline several tests cases for GTK that have better results
after r147492.
- platform/gtk/TestExpectations:
- platform/gtk/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/gtk/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
- platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- platform/gtk/fast/encoding/utf-16-big-endian-expected.png:
- platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
- platform/gtk/fast/encoding/utf-16-little-endian-expected.png:
- platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
- platform/gtk/fast/forms/input-value-expected.png:
- platform/gtk/fast/forms/input-value-expected.txt:
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
