⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 7, 2013:

11:53 PM Changeset in webkit [147896] by benjamin@webkit.org
  • 19 edits in trunk/LayoutTests

Regression(r147893) Caused several editing tests to fail
​https://bugs.webkit.org/show_bug.cgi?id=114143

Patch by Christophe Dumez <Christophe Dumez> on 2013-04-07
Reviewed by Benjamin Poulain.

r147893 removed some Android code from WebCore but failed to update the
layout tests accordingly. This patch remove Android-specific tests from
several editing layout tests.

  • editing/deleting/paragraph-in-preserveNewline-expected.txt:
  • editing/deleting/paragraph-in-preserveNewline.html:
  • editing/deleting/whitespace-pre-1-expected.txt:
  • editing/deleting/whitespace-pre-1.html:
  • editing/execCommand/script-tests/toggle-compound-styles.js:
  • editing/execCommand/toggle-compound-styles-expected.txt:
  • editing/selection/5354455-1-expected.txt:
  • editing/selection/5354455-1.html:
  • editing/selection/click-in-margins-inside-editable-div-expected.txt:
  • editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
  • editing/selection/extend-after-mouse-selection-expected.txt:
  • editing/selection/extend-after-mouse-selection.html:
  • editing/selection/programmatic-selection-on-mac-is-directionless-expected.txt:
  • editing/selection/programmatic-selection-on-mac-is-directionless.html:
  • editing/selection/script-tests/click-in-margins-inside-editable-div.js:
  • editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js:
  • editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt:
  • editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:
11:31 PM Changeset in webkit [147895] by vivek.vg@samsung.com
  • 2 edits in trunk

Modify .gitignore file to remove entries for chromium generated files
​https://bugs.webkit.org/show_bug.cgi?id=114141

Reviewed by Gyuyoung Kim.

  • .gitignore:
11:20 PM Changeset in webkit [147894] by benjamin@webkit.org
  • 6 edits in trunk/Source/WTF

Remove the android code from WebKit Template Framework
​https://bugs.webkit.org/show_bug.cgi?id=114138

Reviewed by Dirk Schulze.

  • wtf/Assertions.cpp:
  • wtf/Atomics.h:
  • wtf/MathExtras.h:
  • wtf/Platform.h:
  • wtf/ThreadIdentifierDataPthreads.cpp:
9:20 PM Changeset in webkit [147893] by benjamin@webkit.org
  • 11 edits in trunk/Source/WebCore

Remove the android code from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=114136

Reviewed by Anders Carlsson.

  • WebCore.exp.in:
  • dom/ViewportArguments.cpp:

(WebCore):
(WebCore::setViewportFeature):
(WebCore::viewportErrorMessageTemplate):
(WebCore::viewportErrorMessageLevel):

  • dom/ViewportArguments.h:

(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):

  • editing/EditingBehavior.h:

(WebCore::EditingBehavior::shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom):
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
(WebCore::EditingBehavior::shouldNavigateBackOnBackspace):

  • editing/EditingBehaviorTypes.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureLongTap):
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):

  • page/Settings.cpp:

(WebCore):
(WebCore::editingBehaviorTypeForPlatform):

  • platform/graphics/FontCache.h:

(FontCache):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::getRenderStyleForStrike):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setEditingBehavior):

9:14 PM Changeset in webkit [147892] by oliver@apple.com
  • 32 edits in trunk/Source

Add bounds checking for WTF::Vector::operator[]
​https://bugs.webkit.org/show_bug.cgi?id=89600

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Make a few JSC classes opt-out of release mode bounds checking.

  • assembler/AssemblerBuffer.h:

(AssemblerBuffer):

  • assembler/AssemblerBufferWithConstantPool.h:

(AssemblerBufferWithConstantPool):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::bytecodeOffset):
(JSC):
(JSC::replaceExistingEntries):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::bytecodeOffsetForCallAtIndex):
(JSC::CodeBlock::callReturnIndexVector):
(JSC::CodeBlock::codeOrigins):
(RareData):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedEvalCodeBlock::adoptVariables):
(UnlinkedEvalCodeBlock):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(CallArguments):
(JSC::BytecodeGenerator::instructions):
(BytecodeGenerator):

  • bytecompiler/StaticPropertyAnalysis.h:

(JSC::StaticPropertyAnalysis::create):
(JSC::StaticPropertyAnalysis::StaticPropertyAnalysis):
(StaticPropertyAnalysis):

  • bytecompiler/StaticPropertyAnalyzer.h:

(StaticPropertyAnalyzer):
(JSC::StaticPropertyAnalyzer::StaticPropertyAnalyzer):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • parser/ASTBuilder.h:

(ASTBuilder):

  • runtime/ArgList.h:

(MarkedArgumentBuffer):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSort):

Source/WebCore:

Fix exports

  • WebCore.exp.in:

Source/WTF:

Add a template parameter to Vector<> that controls whether
bounds checking is performed in release builds or not.
Defaults to crashing on overflow.

  • wtf/Forward.h:

(WTF):

  • wtf/Vector.h:

(WTF):
(Vector):
(WTF::Vector::at):
(WTF::Vector::removeLast):
(WTF::::Vector):
(WTF::=):
(WTF::::contains):
(WTF::::find):
(WTF::::reverseFind):
(WTF::::fill):
(WTF::::appendRange):
(WTF::::expandCapacity):
(WTF::::tryExpandCapacity):
(WTF::::resize):
(WTF::::shrink):
(WTF::::grow):
(WTF::::reserveCapacity):
(WTF::::tryReserveCapacity):
(WTF::::reserveInitialCapacity):
(WTF::::shrinkCapacity):
(WTF::::append):
(WTF::::tryAppend):
(WTF::::appendSlowCase):
(WTF::::uncheckedAppend):
(WTF::::appendVector):
(WTF::::insert):
(WTF::::prepend):
(WTF::::remove):
(WTF::::reverse):
(WTF::::releaseBuffer):
(WTF::::checkConsistency):
(WTF::deleteAllValues):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):

9:10 PM Changeset in webkit [147891] by benjamin@webkit.org
  • 3 edits in trunk/LayoutTests

Remove the android part of editing/selection/rtl-move-selection-right-left.html
​https://bugs.webkit.org/show_bug.cgi?id=114137

Reviewed by Anders Carlsson.

  • editing/selection/rtl-move-selection-right-left-expected.txt:
  • editing/selection/rtl-move-selection-right-left.html:
8:16 PM UnmaintainedFeatureList edited by benjamin@webkit.org
(diff)
7:55 PM UnmaintainedFeatureList edited by benjamin@webkit.org
(diff)
7:03 PM UnmaintainedFeatureList edited by timothy@apple.com
(diff)
6:38 PM UnmaintainedFeatureList created by benjamin@webkit.org
6:09 PM Changeset in webkit [147890] by benjamin@webkit.org
  • 3 edits in trunk/Websites/webkit.org

Simplify the page "Getting the Code" on WebKit.org
​https://bugs.webkit.org/show_bug.cgi?id=113980

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-07
Reviewed by Sam Weinig.

  • building/checkout.html:

Instead of interleaving instructions for Mac and Windows, just
copy the things that make sense and have two clear sections.

Also mention Linux, it is the exact same instructions as Mac OS X.

Make svn checkout the alternative to a download of the tarball. It is
almost impossible to do a svn checkout on slow networks nowadays.

6:01 PM Changeset in webkit [147889] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Do not allocate static AtomicStrings when searching for alternate font names
​https://bugs.webkit.org/show_bug.cgi?id=114110

Reviewed by Geoffrey Garen.

FontCache's alternateFamilyName does some font name substitutions
when a font is not found for a given name.

In the vast majority of cases, no substitutions are made and
alternateFamilyName returns the null atom.
Given the usage the function had a couple of problems:
-It created 6 static AtomicString.
-It did a case insensitive comparison with 6 differents strings

before failing.

This patch aims at solving both issues.

Instead of creating all AtomicString statically, the alternate name
are simply created on the fly as needed. Because the operation is so
unfrequent, and it uses the fast constructor, doing so should not slow
down the function.

To avoid comparing the input to every string, every time, the length of
the input is first evaluated, and we only do the necessary string comparisons.

On x86_64, this reduces the binary size by 2128 bytes.

  • platform/graphics/FontCache.cpp:

(WebCore::familyNameEqualIgnoringCase):
When comparing strings, we know:
-The family name is non null.
-The length of both strings is equal.
-The length is not null.
Make the comparison accordingly.

(WebCore::alternateFamilyName):
(WebCore::FontCache::getCachedFontPlatformData):

5:52 PM Changeset in webkit [147888] by benjamin@webkit.org
  • 77 edits
    1 delete in trunk/Source/WebCore

Remove remaining PLATFORM(CHROMIUM)-guarded code in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=114081

Remove the remaining PLATFORM(CHROMIUM) build guards. There are still a couple of guards
that most likely apply only to Chromium, like OS(ANDROID) or USE(SKIA_ON_MAC_CHROMIUM),
but removal of these should go into separate patches.

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2013-04-07

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • config.h:
  • history/PageCache.cpp:

(WebCore):
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::shouldAccelerate):

  • html/HTMLCanvasElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::createFileURLForApplicationCacheResource):
(WebCore::HTMLMediaElement::loadResource):

  • html/HTMLSelectElement.cpp:

(WebCore):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

  • html/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler):

  • html/canvas/EXTDrawBuffers.cpp:

(WebCore::EXTDrawBuffers::satisfiesWebGLRequirements):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::platformLayer):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didBeginFrame):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::notifyFinished):

  • page/FeatureObserver.cpp:

(WebCore::FeatureObserver::~FeatureObserver):

  • platform/AsyncFileSystem.cpp:

(WebCore):

  • platform/ContextMenu.h:

(ContextMenu):

  • platform/ContextMenuItem.h:
  • platform/Cursor.h:
  • platform/DragData.cpp:

(WebCore):

  • platform/DragData.h:
  • platform/DragImage.h:
  • platform/LocalizedStrings.h:

(WebCore):

  • platform/Pasteboard.h:

(Pasteboard):

  • platform/PlatformExportMacros.h:
  • platform/PlatformInstrumentation.h:

(WebCore::PlatformInstrumentation::willDecodeImage):
(WebCore::PlatformInstrumentation::didDecodeImage):
(WebCore::PlatformInstrumentation::willResizeImage):
(WebCore::PlatformInstrumentation::didResizeImage):

  • platform/PlatformMenuDescription.h:

(WebCore):

  • platform/PlatformSpeechSynthesizer.h:

(PlatformSpeechSynthesizer):

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(PlatformWheelEvent):

  • platform/ScrollAnimator.cpp:

(WebCore):
(WebCore::ScrollAnimator::handleWheelEvent):

  • platform/ScrollAnimator.h:

(ScrollAnimator):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateOverhangAreas):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollPositionChanged):

  • platform/Scrollbar.cpp:
  • platform/SecureTextInput.cpp: Removed.
  • platform/SecureTextInput.h:

(WebCore):

  • platform/SuddenTermination.h:

(WebCore):

  • platform/Widget.h:

(Widget):

  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/FloatPoint.h:

(FloatPoint):

  • platform/graphics/FloatRect.h:

(FloatRect):

  • platform/graphics/FloatSize.h:

(FloatSize):

  • platform/graphics/Font.cpp:

(WebCore):
(WebCore::Font::width):

  • platform/graphics/Font.h:

(Font):

  • platform/graphics/FontCache.cpp:

(WebCore):

  • platform/graphics/FontCache.h:

(FontCache):

  • platform/graphics/FontDescription.h:
  • platform/graphics/FontPlatformData.cpp:
  • platform/graphics/GlyphBuffer.h:

(WebCore):
(WebCore::GlyphBuffer::add):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawImageBuffer):

  • platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::supportsBackgroundColorContent):

  • platform/graphics/Icon.h:

(Icon):

  • platform/graphics/ImageSource.cpp:
  • platform/graphics/ImageSource.h:

(WebCore):

  • platform/graphics/IntRect.h:

(IntRect):
(WebCore):

  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/PlatformLayer.h:
  • platform/graphics/SimpleFontData.h:

(SimpleFontData):
(DerivedFontData):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::resizeContext):

  • platform/graphics/gpu/DrawingBuffer.h:

(WebCore):
(DrawingBuffer):

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:
  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

  • platform/image-decoders/ImageDecoder.h:
  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::open):

  • platform/network/BlobRegistry.cpp:

(WebCore::blobRegistry):

  • platform/network/BlobRegistryImpl.cpp:
  • platform/network/NetworkStateNotifier.cpp:
  • platform/network/NetworkStateNotifier.h:

(NetworkStateNotifier):

  • platform/network/NetworkingContext.h:

(NetworkingContext):

  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceRequestBase.cpp:

(WebCore):

  • platform/text/cf/HyphenationCF.cpp:
  • plugins/PluginViewNone.cpp:

(WebCore):

  • testing/Internals.cpp:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

5:43 PM Changeset in webkit [147887] by benjamin@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Use Vector::reserveInitialCapacity() when possible in JavaScriptCore runtime
​https://bugs.webkit.org/show_bug.cgi?id=114111

Reviewed by Andreas Kling.

Almost all the code was already using Vector::reserveInitialCapacity()
and Vector::uncheckedAppend(). Fix the remaining parts.

  • runtime/ArgList.h:

(MarkedArgumentBuffer): The type VectorType is unused.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSort):
Move the variable closer to where it is needed.

  • runtime/JSArray.cpp:

(JSC::JSArray::setLengthWithArrayStorage):

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyNames):

4:56 PM Changeset in webkit [147886] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[EFL] --minimal build fails because of incorrect usage of GENERATE_THEME in CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=113902

Unreviewed.

Patch by Ed Bartosh <​bartosh@gmail.com> on 2013-04-07

  • platform/efl/DefaultTheme/CMakeLists.txt:

Put possibly empty variable after non-empty to avoid space
at the beginning of string parameter

4:41 PM Changeset in webkit [147885] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/efl

[EFL] --minimal build fails with error: expected ;' before return'
​https://bugs.webkit.org/show_bug.cgi?id=113953

Unreviewed.

Patch by Ed Bartosh <​bartosh@gmail.com> on 2013-04-07

  • ewk/ewk_security_origin.cpp:

(ewk_security_origin_web_database_quota_get): Added missing semicolon.

4:00 PM Changeset in webkit [147884] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

[WIN] Fix problems with export macros of AutodrainedPool
​https://bugs.webkit.org/show_bug.cgi?id=114132

Reviewed by Geoffrey Garen.

Exporting an inline function results in an error with the MS compiler.

  • wtf/AutodrainedPool.h:

(AutodrainedPool):
(WTF::AutodrainedPool::AutodrainedPool):
(WTF::AutodrainedPool::~AutodrainedPool):
(WTF::AutodrainedPool::cycle):

3:18 PM Changeset in webkit [147883] by Patrick Gansterer
  • 5 edits
    4 deletes in trunk/Source/WebCore

Add default implementation for KURL::fileSystemPath()
​https://bugs.webkit.org/show_bug.cgi?id=108326

Reviewed by Benjamin Poulain.

The code for KURL::fileSystemPath() has been duplicated in different ports.
Add an implementation of this function to KURL.cpp for this ports and
get rid of the very similar port specific implementation files.

  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformWinCE.cmake:
  • platform/KURL.cpp:

(WebCore):
(WebCore::KURL::fileSystemPath):

  • platform/blackberry/KURLBlackBerry.cpp: Removed.
  • platform/efl/KURLEfl.cpp: Removed.
  • platform/wince/KURLWinCE.cpp: Removed.
  • platform/wx/KURLWx.cpp: Removed.
3:09 PM Changeset in webkit [147882] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

[WinCE] Add workaround for UNUSED_PARAM()
​https://bugs.webkit.org/show_bug.cgi?id=113440

Reviewed by Benjamin Poulain.

The MSVC compiler for Windwos CE throws an error when
an function parameter is passed to UNUSED_PARAM() and
its type is only forward declared.

  • wtf/UnusedParam.h:
3:08 PM Changeset in webkit [147881] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Do not check if WTF_ARM_ARCH_VERSION is defined in WTF_ARM_ARCH_AT_LEAST macro
​https://bugs.webkit.org/show_bug.cgi?id=114127

Reviewed by Benjamin Poulain.

Platform.h defines WTF_ARM_ARCH_VERSION for CPU(ARM) always and removing
the check works around a bug in older Microsoft compiler versions.

  • wtf/Platform.h:
2:28 PM Changeset in webkit [147880] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Marked another webaudio test as flaky.

  • platform/efl/TestExpectations:
2:19 PM Changeset in webkit [147879] by Patrick Gansterer
  • 9 edits in trunk

Remove references to Skia and V8 from CMake files
​https://bugs.webkit.org/show_bug.cgi?id=114130

Reviewed by Geoffrey Garen.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/WebKitPackaging.cmake:

Source/JavaScriptCore:

  • shell/PlatformBlackBerry.cmake:

Source/WebCore:

  • PlatformBlackBerry.cmake:

Source/WebKit:

  • PlatformBlackBerry.cmake:
1:56 PM Changeset in webkit [147878] by ddkilzer@apple.com
  • 21 edits in trunk

Remove the rest of SVG_DOM_OBJC_BINDINGS
<​http://webkit.org/b/114112>

Reviewed by Geoffrey Garen.

.:

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • Remove references to ENABLE_SVG_DOM_OBJC_BINDINGS.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.

Source/WebCore:

  • Configurations/WebCore.xcconfig:
  • Remove EXCLUDED_SOURCE_FILE_NAMES_SVG_DOM_OBJC_BINDINGS. Note that DOMHTMLIFrameElementPrivate.h should not have been in this list because the class contained methods other than just -getSVGDocument.
  • WebCore.xcodeproj/project.pbxproj:
  • Remove DOMHTMLFrameElementPrivate.h since the only method it contained was -[DOMHTMLFrameElement getSVGDocument], which was part of the SVG DOM Objective-C bindings.
  • bindings/objc/DOM.mm:

(kitClass):

  • bindings/objc/DOMEvents.mm:

(kitClass):

  • bindings/objc/ExceptionHandlers.mm:

(WebCore::raiseDOMException):

  • Remove code in ENABLE(SVG_DOM_OBJC_BINDINGS).

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • Remove reference to SVG_DOM_OBJC_BINDINGS.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.

Source/WTF:

  • wtf/FeatureDefines.h:
  • Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • Remove --svg-dom-objc-bindings switch.
  • qmake/mkspecs/features/features.pri:
  • Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
1:27 PM Changeset in webkit [147877] by Christophe Dumez
  • 8 edits in trunk/LayoutTests

Unreviewed gardening.

Rebaseline several test cases that have line number information after r147872.

  • http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt:
  • http/tests/security/window-onerror-exception-in-iframe-expected.txt:
  • inspector/console/alert-toString-exception-expected.txt:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/websql/sql-error-codes-expected.txt:
  • storage/websql/statement-error-callback-expected.txt:
  • storage/websql/transaction-callback-exception-crash-expected.txt:
1:02 PM Changeset in webkit [147876] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip a few test failing due to missing Quota API support.

  • platform/efl/TestExpectations:
12:55 PM Changeset in webkit [147875] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark a few tests as crashing on EFL port.

  • platform/efl/TestExpectations:
12:38 PM Changeset in webkit [147874] by Christophe Dumez
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Generate missing baselines.

  • platform/efl/editing/pasteboard/paste-text-004-expected.png: Added.
  • platform/efl/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
  • platform/efl/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
  • platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
  • platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
12:30 PM Changeset in webkit [147873] by Christophe Dumez
  • 8 edits
    1 add in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline several test cases.

  • platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/efl/fast/forms/datalist/input-list-expected.txt:
  • platform/efl/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/efl/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
  • platform/efl/fast/js/global-constructors-expected.txt:
  • platform/efl/http/tests/inspector/console-websocket-error-expected.txt:
11:47 AM Changeset in webkit [147872] by oliver@apple.com
  • 17 edits in trunk

Inspector should display information about non-object exceptions
​https://bugs.webkit.org/show_bug.cgi?id=114123

Reviewed by Adele Peterson.

Source/JavaScriptCore:

Make sure we store the right stack information, even when throwing
a primitive.

  • interpreter/CallFrame.h:

(JSC::ExecState::clearSupplementaryExceptionInfo):
(ExecState):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::throwException):

Source/WebCore:

Make use of the stack trace for line information when we're reporting
an exception

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

LayoutTests:

All these tests throw primitives as exceptions, and now they have source
and line number information

  • fast/dom/exception-getting-event-handler-expected.txt:
  • fast/dom/javascript-url-exception-isolation-expected.txt:
  • fast/dom/nested-script-exceptions-expected.txt:
  • fast/events/onerror-no-constructor-expected.txt:
  • fast/events/window-onerror13-expected.txt:
  • fast/events/window-onerror16-expected.txt:
  • fast/events/window-onerror2-expected.txt:
  • fast/events/window-onerror8-expected.txt:
  • fast/js/uncaught-exception-line-number-expected.txt:
  • fast/sub-pixel/inline-block-with-padding-expected.txt:
  • platform/mac/fast/AppleScript/001-expected.txt:
11:37 AM Changeset in webkit [147871] by robert@webkit.org
  • 3 edits
    2 adds in trunk

table element may get larger when its contents are recreated
​https://bugs.webkit.org/show_bug.cgi?id=111342

Reviewed by Darin Adler.

Source/WebCore:

Remove anonymous table section wrappers when destroying their children.

Test: fast/table/anonymous-table-section-removed.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):

LayoutTests:

  • fast/table/anonymous-table-section-removed-expected.txt: Added.
  • fast/table/anonymous-table-section-removed.html: Added.
11:31 AM Changeset in webkit [147870] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

[WIN] Fix build without precompiled header after r145827.

  • platform/ContextMenuItem.h:
  • platform/PlatformMenuDescription.h:
11:30 AM Changeset in webkit [147869] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Fix compilation of LocaleWin with !ENABLE(CALENDAR_PICKER) && !ENABLE(DATE_AND_TIME_INPUT_TYPES)

  • platform/text/win/LocaleWin.cpp:

(WebCore::LocaleWin::ensureShortMonthLabels):
(WebCore):
(WebCore::LocaleWin::ensureMonthLabels):

10:07 AM Changeset in webkit [147868] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

[WIN] Fix build without precompiled header after r144216.

  • platform/network/cf/FormDataStreamCFNet.h:
  • platform/network/mac/FormDataStreamMac.h:
9:42 AM Changeset in webkit [147867] by commit-queue@webkit.org
  • 8 edits in trunk

Source/WebCore: [EFL] --minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
​https://bugs.webkit.org/show_bug.cgi?id=114089

Patch by Ed Bartosh <​bartosh@gmail.com> on 2013-04-07
Reviewed by Chris Fleizach.

Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection):

  • editing/FrameSelection.h:

(WebCore):

Tools: [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
​https://bugs.webkit.org/show_bug.cgi?id=114089

Patch by Ed Bartosh <​bartosh@gmail.com> on 2013-04-07
Reviewed by Chris Fleizach.

Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)

  • DumpRenderTree/AccessibilityController.cpp:
  • DumpRenderTree/AccessibilityUIElement.cpp:
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::DumpRenderTreeChrome):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

Apr 6, 2013:

8:52 PM Changeset in webkit [147866] by Laszlo Gombos
  • 4 edits in trunk/Tools

2013-04-06 Laszlo Gombos <Laszlo Gombos>

Build fix after r147857, remove remaining USE(JSC) guards.

Unreviewed.

  • DumpRenderTree/config.h:
  • TestWebKitAPI/config.h:
  • WebKitTestRunner/config.h:
6:59 PM Changeset in webkit [147865] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Rename sheriffbot to webkitbot
​https://bugs.webkit.org/show_bug.cgi?id=114109

Reviewed by Benjamin Poulain.

Renamed since sheriffbot will be used in Blink.

  • Scripts/webkitpy/tool/commands/sheriffbot.py:

(SheriffBot):
(SheriffBot.begin_work_queue):

6:32 PM Changeset in webkit [147864] by benjamin@webkit.org
  • 1 edit
    4 deletes in trunk/Source/WebCore

Get rid of skia
​https://bugs.webkit.org/show_bug.cgi?id=114108

Reviewed by Anders Carlsson.

  • platform/graphics/filters/skia/*: Removed.
  • platform/graphics/skia/*: Removed.
  • platform/image-decoders/skia/*: Removed.
  • platform/image-encoders/skia/*: Removed.
6:31 PM Changeset in webkit [147863] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove the chromium code from platform/graphics/mac
​https://bugs.webkit.org/show_bug.cgi?id=114107

Reviewed by Anders Carlsson.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):

  • platform/graphics/mac/FontMac.mm:

(WebCore::hasBrokenCTFontGetVerticalTranslationsForGlyphs):

6:30 PM Changeset in webkit [147862] by benjamin@webkit.org
  • 8 edits in trunk/Source/WebCore

Clean platform/graphics/cg of the chromium bits
​https://bugs.webkit.org/show_bug.cgi?id=114106

Reviewed by Anders Carlsson.

  • platform/graphics/cg/BitmapImageCG.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::roundToDevicePixels):

  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:

(GraphicsContextPlatformPrivate):

  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/cg/ImageCG.cpp:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/cg/PatternCG.cpp:
4:48 PM Changeset in webkit [147861] by timothy@apple.com
  • 6 edits in trunk

Remove InjectedScriptHost.evaluateReturnsEvalFunction.

​https://webkit.org/b/114099

Source/WebCore:

  • inspector/InjectedScriptHost.h:

(InjectedScriptHost):

  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(InjectedScript.prototype._evaluateOn):

LayoutTests:

Reviewed by Joseph Pecoraro.

  • inspector/console/command-line-api-expected.txt:
4:40 PM Keeping the Tree Green edited by benjamin@webkit.org
(diff)
4:40 PM WebInspector edited by benjamin@webkit.org
(diff)
4:39 PM PortIntegrationArchitectureIssues edited by benjamin@webkit.org
(diff)
4:38 PM QtWebKitGardening edited by benjamin@webkit.org
(diff)
4:38 PM JavaScriptCore edited by benjamin@webkit.org
(diff)
4:38 PM NewRunWebKitTests edited by benjamin@webkit.org
(diff)
4:37 PM HackingOnNewRunWebKitTests edited by benjamin@webkit.org
(diff)
4:36 PM TestExpectations edited by benjamin@webkit.org
(diff)
4:36 PM AddingFeatures edited by benjamin@webkit.org
(diff)
4:36 PM WebKitIDL edited by benjamin@webkit.org
(diff)
4:35 PM LayoutUnit edited by benjamin@webkit.org
(diff)
4:29 PM WikiStart edited by benjamin@webkit.org
(diff)
4:23 PM Changeset in webkit [147860] by benjamin@webkit.org
  • 9 edits in trunk/Source/WebCore

Remove the chromium code from WebCore/platform/mac
​https://bugs.webkit.org/show_bug.cgi?id=114104

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-06
Reviewed by Sam Weinig.

  • platform/mac/NSScrollerImpDetails.h:

(WebCore::isScrollbarOverlayAPIAvailable):

  • platform/mac/NSScrollerImpDetails.mm:
  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate layer]):
(WebCore::scrollAnimationEnabledForSystem):

  • platform/mac/ScrollElasticityController.mm:

(WebCore):

  • platform/mac/ScrollbarThemeMac.h:

(ScrollbarThemeMac):

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeMac::paint):
(WebCore):

  • platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::ensuredView):

  • platform/mac/WebCoreNSCellExtras.h:
4:19 PM Changeset in webkit [147859] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove the Chromium code from Mac's FontPlatformData
​https://bugs.webkit.org/show_bug.cgi?id=114103

Reviewed by Sam Weinig.

  • platform/graphics/FontPlatformData.h:

(WebCore):
(FontPlatformData):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::setFont):
(WebCore::FontPlatformData::ctFont):

3:47 PM Changeset in webkit [147858] by oliver@apple.com
  • 15 edits in trunk

Unify the many and varied stack trace mechanisms, and make the result sane.
​https://bugs.webkit.org/show_bug.cgi?id=114072

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Makes JSC::StackFrame record the bytecode offset and other necessary data
rather than requiring us to perform eager evaluation of the line number, etc.
Then remove most of the users of retrieveLastCaller, as most of them were
using it to create a stack trace in a fairly incomplete and inefficient way.

StackFrame now also has a couple of helpers to get the line and column info.

  • API/JSContextRef.cpp:

(JSContextCreateBacktrace):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDebugHook):

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getBytecodeOffsetForCallFrame):
(JSC::getCallerInfo):
(JSC::StackFrame::line):
(JSC::StackFrame::column):
(JSC::StackFrame::expressionInfo):
(JSC::StackFrame::toString):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::retrieveCallerFromVMCode):

  • interpreter/Interpreter.h:

(StackFrame):
(Interpreter):

  • runtime/Error.cpp:

(JSC::throwError):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

  • runtime/JSGlobalObject.cpp:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):

Source/WebCore:

Now that we've fleshed out the StackFrames from Interpreter::getStackTrace
WebCore can just ask us for a stack trace rather than implementing its own
stack walking.

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

  • inspector/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::isEqual):

  • inspector/ScriptCallFrame.h:

(ScriptCallFrame):
(WebCore::ScriptCallFrame::columnNumber):

Tools:

The commandline jsc executable no longer requires arguments, so
I've made run-jsc work without them.

  • Scripts/run-jsc:
3:42 PM Changeset in webkit [147857] by weinig@apple.com
  • 108 edits in trunk/Source

Removed v8 bindings hooks from IDL files
​https://bugs.webkit.org/show_bug.cgi?id=114091

Patch by Geoffrey Garen <​ggaren@apple.com> on 2013-04-06
Reviewed by Anders Carlsson and Sam Weinig.

Source/JavaScriptCore:

  • heap/HeapStatistics.h:

Source/WebCore:

  • Modules/encryptedmedia/MediaKeySession.idl:
  • Modules/filesystem/DOMWindowFileSystem.idl:
  • Modules/filesystem/WorkerContextFileSystem.idl:
  • Modules/gamepad/NavigatorGamepad.idl:
  • Modules/geolocation/NavigatorGeolocation.idl:
  • Modules/indexeddb/DOMWindowIndexedDatabase.idl:
  • Modules/indexeddb/WorkerContextIndexedDatabase.idl:
  • Modules/mediastream/DOMWindowMediaStream.idl:
  • Modules/mediastream/NavigatorMediaStream.idl:
  • Modules/notifications/DOMWindowNotifications.idl:
  • Modules/notifications/NotificationCenter.idl:
  • Modules/notifications/WorkerContextNotifications.idl:
  • Modules/quota/DOMWindowQuota.idl:
  • Modules/speech/DOMWindowSpeech.idl:
  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/DOMWindowWebAudio.idl:
  • Modules/webdatabase/DOMWindowWebDatabase.idl:
  • Modules/webdatabase/WorkerContextWebDatabase.idl:
  • Modules/websockets/DOMWindowWebSocket.idl:
  • Modules/websockets/WorkerContextWebSocket.idl:
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/ScriptController.h:

(ScriptController):

  • bindings/scripts/test/TestNode.idl:
  • bindings/scripts/test/TestObj.idl:
  • css/CSSFontFaceLoadEvent.idl:
  • css/CSSHostRule.idl:
  • css/CSSRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSValue.idl:
  • css/FontLoader.idl:
  • css/StyleSheet.idl:
  • css/WebKitCSSRegionRule.idl:
  • dom/Clipboard.idl:
  • dom/CustomElementConstructor.idl:
  • dom/CustomEvent.idl:
  • dom/DOMNamedFlowCollection.idl:
  • dom/DOMStringMap.idl:
  • dom/DataTransferItemList.idl:
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/EventTarget.idl:
  • dom/MessageChannel.idl:
  • dom/MouseEvent.idl:
  • dom/MutationRecord.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeList.idl:
  • dom/RequestAnimationFrameCallback.idl:
  • dom/ShadowRoot.idl:
  • dom/Text.idl:
  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTreeNode):
(WebCore::HistoryItem::decodeBackForwardTree):

  • html/DOMSettableTokenList.idl:
  • html/DOMTokenList.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDialogElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFormControlsCollection.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLSpanElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTemplateElement.idl:
  • html/HTMLTrackElement.idl:
  • html/HTMLUnknownElement.idl:
  • html/MediaKeyError.idl:
  • html/MediaKeyEvent.idl:
  • html/MicroDataItemValue.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/DOMPath.idl:
  • html/shadow/HTMLContentElement.idl:
  • html/shadow/HTMLShadowElement.idl:
  • html/track/TextTrack.idl:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):
(WebCore::InspectorIndexedDBAgent::clearObjectStore):
(WebCore):

  • loader/EmptyClients.h:

(EmptyFrameLoaderClient):

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):

  • page/Console.idl:
  • page/DOMWindow.idl:
  • page/DOMWindowPagePopup.idl:
  • page/History.idl:
  • page/Location.idl:
  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):

  • testing/Internals.cpp:

(WebCore::Internals::serializeObject):
(WebCore::Internals::deserializeBuffer):

Source/WTF:

  • wtf/ArrayBuffer.h:

(WTF):
(WTF::ArrayBufferContents::ArrayBufferContents):
(WTF::ArrayBufferContents::transfer):
(ArrayBufferContents):
(ArrayBuffer):
(WTF::ArrayBufferContents::~ArrayBufferContents):

  • wtf/Platform.h:
3:05 PM Changeset in webkit [147856] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows VS2010 build fix.

  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
2:38 PM Changeset in webkit [147855] by zandobersek@gmail.com
  • 20 edits in trunk/Source

Remove the USE(SKIA_ON_MAC_CHROMIUM) guards
​https://bugs.webkit.org/show_bug.cgi?id=114084

Reviewed by Ryosuke Niwa.

Source/WebCore:

Remove the USE(SKIA_ON_MAC_CHROMIUM) guards. The guards were enabled only
for the Chromium port via the features.gypi file that was removed in r147714.

  • platform/graphics/FloatPoint.h:

(FloatPoint):

  • platform/graphics/FloatRect.h:

(FloatRect):

  • platform/graphics/FloatSize.h:

(FloatSize):

  • platform/graphics/FontPlatformData.cpp:

(WebCore):

  • platform/graphics/FontPlatformData.h:

(FontPlatformData):
(WebCore::FontPlatformData::hash):

  • platform/graphics/IntPoint.h:

(IntPoint):

  • platform/graphics/IntRect.h:

(IntRect):
(WebCore):

  • platform/graphics/IntSize.h:

(IntSize):

  • platform/graphics/SimpleFontData.h:

(SimpleFontData):
(WebCore::SimpleFontData::widthForGlyph):

  • platform/graphics/cg/FloatPointCG.cpp:
  • platform/graphics/cg/FloatRectCG.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/IntPointCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/cg/IntSizeCG.cpp:
  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.h:

(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(FontCustomPlatformData):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataUseFeatures.in: Remove the SKIA_ON_MAC_(CHROME|CHROMIUM) reference.
2:21 PM Changeset in webkit [147854] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] build fails with error: 'UINT_MAX' was not declared in this scope
​https://bugs.webkit.org/show_bug.cgi?id=114086

Patch by Ed Bartosh <​bartosh@gmail.com> on 2013-04-06
Reviewed by Tim Horton.

  • DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
2:19 PM Changeset in webkit [147853] by zandobersek@gmail.com
  • 4 edits in trunk/Tools

Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=114083

Reviewed by Ryosuke Niwa.

Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
in TestWebKitAPI and WebKitTestRunner.

  • TestWebKitAPI/config.h:
  • TestWebKitAPI/mac/InjectedBundleControllerMac.mm:

(TestWebKitAPI::InjectedBundleController::platformInitialize):

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

2:18 PM Changeset in webkit [147852] by zandobersek@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove the remaining PLATFORM(CHROMIUM) guard in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=114082

Reviewed by Ryosuke Niwa.

  • runtime/JSExportMacros.h: Remove the remaining PLATFORM(CHROMIUM) guard.
1:04 PM Changeset in webkit [147851] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

--minimal build fails with error: control reaches end of non-void function
​https://bugs.webkit.org/show_bug.cgi?id=114085

Patch by Ed Bartosh <​bartosh@gmail.com> on 2013-04-06
Reviewed by Oliver Hunt.

  • interpreter/Interpreter.cpp: return 0 if JIT is not enabled

(JSC::getBytecodeOffsetForCallFrame):

12:48 PM Changeset in webkit [147850] by robert@webkit.org
  • 5 edits in trunk

REGRESSION(r142152): Text wraps in menu
​https://bugs.webkit.org/show_bug.cgi?id=113706

Reviewed by David Hyatt.

Source/WebCore:

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::inlineLogicalWidth): Empty inline elements add their inline border/padding/margin to the width of the
line when we iterate through them in nextLineBreak(), so no need to add them again here when climbing back up
from their first child looking for border/padding/margin to add. (An empty inline element can have floating children.)

LayoutTests:

  • fast/inline/inline-with-empty-inline-children-expected.txt:
  • fast/inline/inline-with-empty-inline-children.html:
12:17 PM Changeset in webkit [147849] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

Added back a symbol that is exported.

11:58 AM Changeset in webkit [147848] by ggaren@apple.com
  • 3 edits in trunk/Source/WebKit2

Try to fix the WebKit2 build.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit):

  • NetworkProcess/NetworkResourceLoader.h:

(NetworkResourceLoader): Removed a defunct function.

11:54 AM Changeset in webkit [147847] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

Removed symbols that aren't exported.

11:24 AM Changeset in webkit [147846] by ggaren@apple.com
  • 14 edits in trunk

Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
​https://bugs.webkit.org/show_bug.cgi?id=114094

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

  • API/JSContextRef.cpp:

(JSContextCreateBacktrace):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDebugHook):

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::retrieveCallerFromVMCode):

  • interpreter/Interpreter.h:

(StackFrame):
(JSC::StackFrame::toString):
(JSC::StackFrame::friendlyLineNumber):
(Interpreter):

  • runtime/Error.cpp:

(JSC::throwError):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

  • runtime/JSGlobalObject.cpp:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):

Source/WebCore:

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

  • inspector/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::isEqual):

  • inspector/ScriptCallFrame.h:

(ScriptCallFrame):
(WebCore::ScriptCallFrame::lineNumber):

Tools:

  • Scripts/run-jsc:
11:24 AM Changeset in webkit [147845] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r145849.

  • WebCoreSupport/EditorClientWinCE.cpp:
11:23 AM Changeset in webkit [147844] by Patrick Gansterer
  • 4 edits in trunk/Source/WebKit

[CMake] Remove general include directories from platform specific files

Move the include directories, which are required by all CMake ports
to the general CMakeLists.txt to fix the build for Windows CE port.

  • CMakeLists.txt:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
11:15 AM Changeset in webkit [147843] by andersca@apple.com
  • 8 edits
    2 deletes in trunk/Source/WebCore

Remove VisitedLinks.{cpp|h}
​https://bugs.webkit.org/show_bug.cgi?id=114095

Reviewed by Geoffrey Garen.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/VisitedLinks.cpp: Removed.
  • platform/VisitedLinks.h: Removed.
11:10 AM Changeset in webkit [147842] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r146932.

  • profiler/ProfilerDatabase.cpp:

(Profiler):

11:07 AM Changeset in webkit [147841] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Another build fix.

Actually remove the right files from WebCore.vcxproj.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
11:03 AM Changeset in webkit [147840] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Fix build.

ThreadableLoaderClientWrapper was still calling didReceiveCachedMetadata; I didn't notice it
because the file was not in the Xcode project so I went ahead and added it.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/ThreadableLoaderClientWrapper.h:
10:55 AM Changeset in webkit [147839] by andersca@apple.com
  • 19 edits
    2 deletes in trunk/Source/WebCore

Remove dead CachedMetadata code
​https://bugs.webkit.org/show_bug.cgi?id=114093

Reviewed by Geoffrey Garen.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/CachedMetadata.cpp: Removed.
  • loader/CachedMetadata.h: Removed.
  • loader/ResourceLoader.h:

(ResourceLoader):

  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:

(SubresourceLoader):

  • loader/ThreadableLoaderClient.h:
  • loader/WorkerThreadableLoader.cpp:
  • loader/WorkerThreadableLoader.h:

(MainThreadBridge):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

  • loader/cache/CachedResource.h:

(WebCore):
(CachedResource):

  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:

(ResourceHandle):

  • platform/network/ResourceHandleClient.h:

(ResourceHandleClient):

9:57 AM Changeset in webkit [147838] by andersca@apple.com
  • 7 edits
    2 deletes in trunk/Source/WebCore

Remove more dead Chromium code
​https://bugs.webkit.org/show_bug.cgi?id=114090

Reviewed by Alp Toker.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/StatsCounter.cpp: Removed.
  • platform/StatsCounter.h: Removed.
3:06 AM Changeset in webkit [147837] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r143046.

  • platform/graphics/wince/ImageWinCE.cpp:

(WebCore::Image::drawPattern):

2:54 AM Changeset in webkit [147836] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Do not call getenv() on Windows CE where it does not exist.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

2:31 AM Changeset in webkit [147835] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[WinCE] Do not call missing method createDragImageFromImage()
​https://bugs.webkit.org/show_bug.cgi?id=110421

Patch by Mark Salisbury <​mark.salisbury@hp.com> on 2013-04-06

  • platform/win/ClipboardWin.cpp:
2:22 AM Changeset in webkit [147834] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[WinCE] Compile missing NetworkStorageSession methods
​https://bugs.webkit.org/show_bug.cgi?id=110419

Patch by Mark Salisbury <​mark.salisbury@hp.com> on 2013-04-05

  • PlatformWinCE.cmake:
Note: See TracTimeline for information about the timeline view.