Timeline
Apr 10, 2013:
- 11:29 PM Changeset in webkit [148176] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix, fixing the WebKit2 build.
- GNUmakefile.list.am:
- 11:22 PM Changeset in webkit [148175] by
-
- 17 edits in trunk/Source/WebCore
Remove some includes of CachedImage.h
https://bugs.webkit.org/show_bug.cgi?id=114411
Reviewed by Dan Bernstein.
- css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a definition of a class it holds, but default construction does not.
- rendering/RenderImageResource.cpp:
- rendering/RenderImageResource.h: Moved definitions of virtual functions to a .cpp file. There is no win from having them inline, and now we don't need CachedImage.h in the header.
- bindings/js/JSNodeCustom.cpp:
- dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard):
- platform/mac/ClipboardMac.h:
- rendering/InlineFlowBox.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderListItem.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderTableCol.cpp:
- rendering/RenderTableRow.cpp:
- rendering/RenderTableSection.cpp:
- svg/graphics/SVGImageCache.cpp: Removed unnecessary includes.
- platform/mac/PasteboardMac.mm:
- rendering/RenderSnapshottedPlugIn.cpp: Added ones where they are now necessary.
- 11:19 PM Changeset in webkit [148174] by
-
- 2 edits in trunk/Tools
Unreviewed.
- GNUmakefile.am: Removing extra whitespace that's producing warnings.
- 11:04 PM Changeset in webkit [148173] by
-
- 4 edits in trunk/Tools
[webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
https://bugs.webkit.org/show_bug.cgi?id=114410
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.add_list): Remove optional return_exit_code argument. Remove return value.
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.add): Remove optional return_exit_code argument.
(SCM.add_list): Remove optional return_exit_code argument.
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.add_list): Remove optional return_exit_code argument. Remove return value.
- 10:47 PM Changeset in webkit [148172] by
-
- 8 edits19 adds in trunk
Allow direct compositing of background images
https://bugs.webkit.org/show_bug.cgi?id=108203
Patch by No'am Rosenthal <Noam Rosenthal> on 2013-04-10
Reviewed by Simon Fraser.
Source/WebCore:
Use setContentsToImage for background images, if the GraphicsLayer has only a background
bitmap image and nothing else. Compute the contentsRect/contentsTileRect from the box model.
Added new properties to GraphicsLayer, contentsTilePhase and contentsTileSize, which controls the "single tile rect",
which allows us to compute the pattern-space transform of a tile, thus allowing background-size
and other characteristics of background images.
This feature is explicitly disabled when there is any composition with a background color or if
there are several background images, as in that case having a single backing store has some
advantages over directly compositing in hardware.
Currently, this feature is disabled for all ports, allowing ports to implement their backend
and decide when to enable it.
Note that RenderBoxModelObject::getGeometryForBackgroundImage crops the contents rect to the
area that contains the tiles, which allows us to assume full tiling in GraphicsLayer.
In this way contentsTileSize/Phase is equivalent to GraphicsContext::drawTiledImage.
Tests: compositing/patterns/direct-pattern-compositing-add-text.html
compositing/patterns/direct-pattern-compositing-change.html
compositing/patterns/direct-pattern-compositing-contain.html
compositing/patterns/direct-pattern-compositing-cover.html
compositing/patterns/direct-pattern-compositing-load.html
compositing/patterns/direct-pattern-compositing-padding.html
compositing/patterns/direct-pattern-compositing-position.html
compositing/patterns/direct-pattern-compositing-rotation.html
compositing/patterns/direct-pattern-compositing-size.html
compositing/patterns/direct-pattern-compositing.html
- platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
(WebCore::GraphicsLayer::setContentsTileSize):
(WebCore::GraphicsLayer::setContentsTilePhase):
(WebCore::GraphicsLayer::contentsTileSize):
(WebCore::GraphicsLayer::contentsTilePhase):
(WebCore::GraphicsLayer::supportsContentsTiling):
Add a contentsTileRect property that enables tile-repeat of background images.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::imageChanged):
Pass background image changes to the layer backing.
- rendering/RenderBoxModelObject.cpp:
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::getGeometryForBackgroundImage):
Expose a function that performs the geometry calculations needed to determine
the tileRect for a background image. This function is also responsible
for cropping the contentsRect to fit the area that is drawn into.
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents):
(WebCore::RenderLayerBacking::resetContentsRect):
(WebCore::hasBoxDecorationsOrBackgroundImage):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundColor):
(WebCore::canCreateTiledImage):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::backgroundRectForBox):
Allow background images to be directly composited if conditions allow (see bug description).
LayoutTests:
Added several ref-tests as preparation for supporting direct compositing of background
images.
- compositing/patterns/direct-pattern-compositing-add-text-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-add-text.html: Added.
- compositing/patterns/direct-pattern-compositing-change-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-change.html: Added.
- compositing/patterns/direct-pattern-compositing-contain-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-contain.html: Added.
- compositing/patterns/direct-pattern-compositing-cover-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-cover.html: Added.
- compositing/patterns/direct-pattern-compositing-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-load-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-load.html: Added.
- compositing/patterns/direct-pattern-compositing-padding-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-padding.html: Added.
- compositing/patterns/direct-pattern-compositing-position-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-position.html: Added.
- compositing/patterns/direct-pattern-compositing-size-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-size.html: Added.
- compositing/patterns/direct-pattern-compositing.html: Added.
- 9:59 PM Changeset in webkit [148171] by
-
- 2 edits in trunk/Tools
Remove myself from the watchlists, I'm getting too much bug mail. :)
- Scripts/webkitpy/common/config/watchlist:
- 8:53 PM Changeset in webkit [148170] by
-
- 5 edits in trunk/Source/WebCore
Replace ENABLE_LEGACY_WEB_AUDIO preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114351
Reviewed by Ryosuke Niwa.
The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/AudioParam.idl:
- Modules/webaudio/OscillatorNode.idl:
- 8:23 PM Changeset in webkit [148169] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Build warning in didReceiveMessage() generated by messages.py
https://bugs.webkit.org/show_bug.cgi?id=112513
Reviewed by Anders Carlsson.
Legacy receiver makes -Wunused-parameter build warnings. This patch is to fix them.
- Scripts/webkit2/messages.py:
(generate_message_handler):
- 8:21 PM Changeset in webkit [148168] by
-
- 2 edits in trunk/Source/WebCore
Replace ENABLE_DIRECTORY_UPLOAD preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114350
Reviewed by Ryosuke Niwa.
The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
- fileapi/File.idl:
- 8:17 PM Changeset in webkit [148167] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unify JSC Parser's error and error message
https://bugs.webkit.org/show_bug.cgi?id=114363
Reviewed by Geoffrey Garen.
The parser kept the error state over two attributes:
error and errorMessage. They were changed in sync,
but had some discrepancy (for example, the error message
was always defined to something).
This patch unifies the two. There is an error if
if the error message is non-null or if the parsing finished
before the end.
This also gets rid of the allocation of the error message
when instantiating a parser.
- parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseInner):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseForStatement):
(JSC::::parseSwitchStatement):
(JSC::::parsePrimaryExpression):
- parser/Parser.h:
(JSC::Parser::updateErrorMessage):
(JSC::Parser::updateErrorWithNameAndMessage):
(JSC::Parser::hasError):
(Parser):
- 8:12 PM Changeset in webkit [148166] by
-
- 2 edits in trunk/Source/WTF
[WTF] Get rid of truncated thread name warnings for non-Windows platforms
https://bugs.webkit.org/show_bug.cgi?id=114266
Reviewed by Ryosuke Niwa.
Hide the annoying message from ports that are not really interested
about it.
- wtf/Threading.cpp:
(WTF::createThread):
- 6:59 PM Changeset in webkit [148165] by
-
- 2 edits in trunk/Source/WebKit2
[CMAKE] Build fix after StorageArea refactoring
https://bugs.webkit.org/show_bug.cgi?id=114398
Unreviewed build fix.
Change StorageAreaImpl.messages.in with StorageAreaMap.messages.in.
Add StorageAreaMap.cpp in CMakeLists.txt.
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-10
- CMakeLists.txt:
- 6:36 PM Changeset in webkit [148164] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r148158.
http://trac.webkit.org/changeset/148158
https://bugs.webkit.org/show_bug.cgi?id=114405
We need to migrate status data (Requested by rniwa on
#webkit).
- Scripts/webkitpy/common/net/statusserver.py:
(StatusServer):
- 6:27 PM Changeset in webkit [148163] by
-
- 2 edits in trunk/Source/WebCore
Cleanup local variables in Editor::markAndReplaceFor
https://bugs.webkit.org/show_bug.cgi?id=114383
Reviewed by Enrica Casucci.
Added resultEndLocation, which is the sum of resultLocation and resultLength.
Also replaced ambiguousBoundaryOffset by useAmbiguousBoundaryOffset since the ambiguous offset is always
selectionOffset -1 to avoid the extra house keeping and obnoxious -1 check.
- editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):
- 6:25 PM Changeset in webkit [148162] by
-
- 5 edits in trunk/Source/JavaScriptCore
Set trap is not being called for API objects
https://bugs.webkit.org/show_bug.cgi?id=114403
Reviewed by Anders Carlsson.
Intercept putByIndex on the callback object and add tests
to make sure we don't regress in future.
- API/JSCallbackObject.h:
(JSCallbackObject):
- API/JSCallbackObjectFunctions.h:
(JSC::::putByIndex):
(JSC):
- API/tests/testapi.c:
(PropertyCatchalls_setProperty):
- API/tests/testapi.js:
- 6:22 PM Changeset in webkit [148161] by
-
- 7 edits in trunk/Source/WebKit2
Make StorageAreaImpl a wrapper around StorageAreaMap
https://bugs.webkit.org/show_bug.cgi?id=114404
Reviewed by Oliver Hunt.
Prepare for moving all the code that deals with local storage values to StorageAreaMap,
and make StorageAreaImpl a dumb wrapper that simply calls through to the map.
- WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::create):
(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::~StorageAreaImpl):
(WebKit::StorageAreaImpl::storageType):
(WebKit::StorageAreaImpl::length):
(WebKit::StorageAreaImpl::key):
(WebKit::StorageAreaImpl::getItem):
(WebKit::StorageAreaImpl::setItem):
(WebKit::StorageAreaImpl::contains):
- WebProcess/Storage/StorageAreaImpl.h:
(WebKit::StorageAreaImpl::storageAreaID):
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::generateStorageMapID):
(WebKit::StorageAreaMap::create):
(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::storageType):
(WebKit::StorageAreaMap::length):
(WebKit::StorageAreaMap::key):
(WebKit::StorageAreaMap::item):
(WebKit::StorageAreaMap::setItem):
(WebKit::StorageAreaMap::contains):
(WebKit::StorageAreaMap::didSetItem):
(WebKit::StorageAreaMap::dispatchStorageEvent):
- WebProcess/Storage/StorageAreaMap.h:
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::storageArea):
- WebProcess/Storage/StorageNamespaceImpl.h:
(StorageNamespaceImpl):
- 6:03 PM Changeset in webkit [148160] by
-
- 5 edits in trunk/Source/WebKit2
Rename StorageManager messages to refer to the StorageMap instead of the StorageArea
https://bugs.webkit.org/show_bug.cgi?id=114401
Reviewed by Ryosuke Niwa.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createStorageMap):
(WebKit::StorageManager::destroyStorageMap):
(WebKit::StorageManager::setItem):
- UIProcess/Storage/StorageManager.h:
- UIProcess/Storage/StorageManager.messages.in:
- WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::~StorageAreaImpl):
- 5:20 PM Changeset in webkit [148159] by
-
- 13 edits399 deletes in trunk
Mass remove all the empty directories
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-10
Rubberstamped by Ryosuke Niwa.
PerformanceTests:
- Bindings/resources: Removed.
Source/JavaScriptCore:
- qt/api: Removed.
- qt/benchmarks/qscriptengine: Removed.
- qt/benchmarks/qscriptvalue: Removed.
- qt/tests/qscriptengine: Removed.
- qt/tests/qscriptstring: Removed.
- qt/tests/qscriptvalue: Removed.
- qt/tests/qscriptvalueiterator: Removed.
Source/ThirdParty/ANGLE:
- src/libGLESv2/geometry: Removed.
Source/WebCore:
- Modules/intents: Removed.
- Modules/protocolhandler: Removed.
- Modules/speech/mac: Removed.
- accessibility/efl: Removed.
- accessibility/gtk: Removed.
- bridge/jni/jsc: Removed.
- editing/android: Removed.
- editing/gtk: Removed.
- history/android: Removed.
- page/android: Removed.
- platform/android: Removed.
- platform/clutter: Removed.
- platform/graphics/blackberry/skia: Removed.
- platform/graphics/harfbuzz/ng: Removed.
- platform/graphics/pango: Removed.
- platform/image-decoders/cg: Removed.
- platform/image-decoders/qt: Removed.
- platform/network/android: Removed.
- platform/network/soup/cache/webkit: Removed.
- platform/text/android: Removed.
- platform/text/wince: Removed.
- platform/track: Removed.
Source/WebKit/efl:
- DefaultTheme/widget/button: Removed.
- DefaultTheme/widget/check: Removed.
- DefaultTheme/widget/combo: Removed.
- DefaultTheme/widget/entry: Removed.
- DefaultTheme/widget/file: Removed.
- DefaultTheme/widget/mediacontrol/fullscreenbutton: Removed.
- DefaultTheme/widget/mediacontrol/mutebutton: Removed.
- DefaultTheme/widget/mediacontrol/playpausebutton: Removed.
- DefaultTheme/widget/mediacontrol/seekbackwardbutton: Removed.
- DefaultTheme/widget/mediacontrol/seekforwardbutton: Removed.
- DefaultTheme/widget/mediacontrol/togglecaptionsbutton: Removed.
- DefaultTheme/widget/progressbar: Removed.
- DefaultTheme/widget/radio: Removed.
- DefaultTheme/widget/scrollbar: Removed.
- DefaultTheme/widget/search/cancel: Removed.
- DefaultTheme/widget/search/decoration: Removed.
- DefaultTheme/widget/search/field: Removed.
- DefaultTheme/widget/slider: Removed.
- DefaultTheme/widget/spinner: Removed.
Source/WebKit/gtk:
- gyp: Removed.
- po: Removed.
Source/WebKit/mac:
- ForwardingHeaders/wtf/unicode/icu: Removed.
Source/WebKit/qt:
- tests/qdeclarativewebview/resources: Removed.
Source/WebKit2:
- Platform/CoreIPC/gtk: Removed.
- Platform/CoreIPC/qt: Removed.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32: Removed.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.64: Removed.
- PluginProcess/gtk: Removed.
- Shared/API/c/win: Removed.
- Shared/Plugins/Netscape/win: Removed.
- Shared/cg/win: Removed.
- Shared/win: Removed.
- UIProcess/API/C/win: Removed.
- UIProcess/API/gtk/webkit: Removed.
- UIProcess/Launcher/win: Removed.
- UIProcess/Plugins/gtk: Removed.
- UIProcess/Plugins/win: Removed.
- UIProcess/texmap: Removed.
- UIProcess/win: Removed.
- WebProcess/Authentication/mac: Removed.
- WebProcess/Cookies/efl: Removed.
- WebProcess/Cookies/gtk: Removed.
- WebProcess/Downloads/cf/win: Removed.
- WebProcess/Downloads/cfnet: Removed.
- WebProcess/Downloads/curl: Removed.
- WebProcess/Downloads/efl: Removed.
- WebProcess/Downloads/gtk: Removed.
- WebProcess/Downloads/mac: Removed.
- WebProcess/Downloads/qt: Removed.
- WebProcess/Downloads/soup: Removed.
- WebProcess/FullScreen/gtk: Removed.
- WebProcess/FullScreen/mac: Removed.
- WebProcess/FullScreen/qt: Removed.
- WebProcess/FullScreen/win: Removed.
- WebProcess/InjectedBundle/API/c/win: Removed.
- WebProcess/InjectedBundle/win: Removed.
- WebProcess/KeyValueStorage: Removed.
- WebProcess/Network/CustomProtocols/mac: Removed.
- WebProcess/Plugins/Netscape/gtk: Removed.
- WebProcess/Plugins/Netscape/win: Removed.
- WebProcess/WebCoreSupport/win: Removed.
- WebProcess/WebPage/LayerTreeCoordinator: Removed.
- WebProcess/WebPage/ca/mac: Removed.
- WebProcess/WebPage/ca/win: Removed.
- WebProcess/WebPage/win: Removed.
- WebProcess/win: Removed.
- qt/Resources: Removed.
Source/WTF:
- wtf/qt/compat: Removed.
- wtf/unicode/glib: Removed.
- wtf/unicode/qt4: Removed.
- wtf/unicode/wince: Removed.
Tools:
- BuildSlaveSupport/gtk/crashmon/log: Removed.
- BuildSlaveSupport/gtk/xvfb/log: Removed.
- DumpRenderTree/ForwardingHeaders/wtf: Removed.
- DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
- MiniBrowser/gtk/WebBundle: Removed.
- MiniBrowser/win: Removed.
- QtTestPlatformPlugin/mac: Removed.
- Scripts/webkitpy/tool/bot/testdata: Removed.
- Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
- efl/ImageDiff: Removed.
- iExploder/htdocs: Removed.
- iExploder/iexploder-1.7.2/output: Removed.
- iExploder/tools: Removed.
- qmake/config.tests/libexecdir: Removed.
- qmake/config.tests/libjpeg: Removed.
- qmake/config.tests/libpng: Removed.
WebKitLibraries:
- win/bin: Removed.
- win/lib/WebKitSystemInterface: Removed.
LayoutTests:
- css2.1/reference: Removed.
- css3/flexbox/script-tests: Removed.
- css3/viewport-relative-lengths: Removed.
- editing/deleting/resources: Removed.
- editing/inserting/resources: Removed.
- editing/style/resources: Removed.
- editing/text-iterator/resources: Removed.
- fast/dom/CSSStyleDeclaration/resources: Removed.
- fast/dom/EntityReference/resources: Removed.
- fast/dom/HTMLFontElement/resources: Removed.
- fast/dom/HTMLFormElement/resources: Removed.
- fast/dom/HTMLSelectElement/resources: Removed.
- fast/dom/HTMLTableElement/resources: Removed.
- fast/dom/HTMLTableRowElement/resources: Removed.
- fast/dom/HTMLTableSectionElement/resources: Removed.
- fast/dom/MediaStream/script-tests: Removed.
- fast/dom/Node/resources: Removed.
- fast/dom/Proximity: Removed.
- fast/dom/Selection/resources: Removed.
- fast/dom/Text/resources: Removed.
- fast/events/spatial-navigation/resources: Removed.
- fast/events/transformaction: Removed.
- fast/forms/script-tests: Removed.
- fast/loading/resources: Removed.
- fast/mutation: Removed.
- fast/regex/resources: Removed.
- fast/speech/script-tests: Removed.
- fast/xhtmlmp: Removed.
- http/tests/inspector/resources/compiler-source-mapping-provider: Removed.
- http/tests/media/media-source/webm: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5: Removed.
- http/tests/w3c/webperf/submission/resource-timing/html: Removed.
- http/tests/w3c/webperf/submission/user-timing: Removed.
- http/tests/xhtmlmp: Removed.
- http/tests/xmlhttprequest/web-apps/recursion: Removed.
- inspector/performance/resources: Removed.
- inspector/protocol/resources: Removed.
- inspector/resources: Removed.
- media/track/captions: Removed.
- platform/efl-wk1/dom/xhtml/level3/core: Removed.
- platform/efl-wk1/fast/dom/DOMException: Removed.
- platform/efl-wk1/mathml/presentation: Removed.
- platform/efl-wk1/svg/dynamic-updates: Removed.
- platform/efl-wk2/dom/xhtml/level3/core: Removed.
- platform/efl-wk2/fast/block/basic: Removed.
- platform/efl-wk2/fast/dom/DOMException: Removed.
- platform/efl-wk2/fast/frames: Removed.
- platform/efl-wk2/http/tests/loading: Removed.
- platform/efl/fast/css3-text-decoration/repaint: Removed.
- platform/efl/fast/dom/HTMLTemplateElement: Removed.
- platform/efl/fast/files: Removed.
- platform/efl/fast/forms/mailto: Removed.
- platform/efl/fast/innerHTML: Removed.
- platform/efl/fast/viewport: Removed.
- platform/efl/inspector/editor: Removed.
- platform/gtk/css3/calc: Removed.
- platform/gtk/editing/pasteboard/resources: Removed.
- platform/gtk/fast/innerHTML: Removed.
- platform/gtk/fast/js/regress: Removed.
- platform/gtk/fast/viewport: Removed.
- platform/gtk/http/tests/webarchive: Removed.
- platform/gtk/http/tests/websocket/tests: Removed.
- platform/gtk/ietestcenter/css3/grid: Removed.
- platform/gtk/platform/gtk/fonts: Removed.
- platform/gtk/sputnik/Unicode/Unicode_510: Removed.
- platform/gtk/svg/hittest: Removed.
- platform/gtk/tables/hittesting: Removed.
- platform/mac-future/accessibility: Removed.
- platform/mac-lion/animations: Removed.
- platform/mac-lion/compositing/visible-rect: Removed.
- platform/mac-lion/css1/units: Removed.
- platform/mac-lion/css3/selectors3: Removed.
- platform/mac-lion/editing/execCommand: Removed.
- platform/mac-lion/editing/inserting: Removed.
- platform/mac-lion/editing/pasteboard: Removed.
- platform/mac-lion/fast/block/float: Removed.
- platform/mac-lion/fast/block/margin-collapse: Removed.
- platform/mac-lion/fast/frames: Removed.
- platform/mac-lion/fast/inline: Removed.
- platform/mac-lion/fast/layers: Removed.
- platform/mac-lion/fast/lists: Removed.
- platform/mac-lion/fast/overflow: Removed.
- platform/mac-lion/fast/text/basic: Removed.
- platform/mac-lion/ietestcenter/css3: Removed.
- platform/mac-lion/tables/mozilla: Removed.
- platform/mac-lion/transforms: Removed.
- platform/mac-snowleopard/css3/filters/custom: Removed.
- platform/mac-snowleopard/fast/canvas/webgl: Removed.
- platform/mac-snowleopard/fast/html: Removed.
- platform/mac-snowleopard/fast/loader: Removed.
- platform/mac-snowleopard/fast/regions: Removed.
- platform/mac-snowleopard/http/tests/media: Removed.
- platform/mac-snowleopard/mathml/presentation: Removed.
- platform/mac-snowleopard/sputnik/Unicode/Unicode_510: Removed.
- platform/mac-snowleopard/svg/batik/filters: Removed.
- platform/mac-snowleopard/svg/batik/masking: Removed.
- platform/mac-snowleopard/svg/batik/text: Removed.
- platform/mac-wk2/compositing/geometry: Removed.
- platform/mac-wk2/compositing/iframes: Removed.
- platform/mac-wk2/css3/filters/custom: Removed.
- platform/mac-wk2/fast/css: Removed.
- platform/mac-wk2/fast/dynamic: Removed.
- platform/mac-wk2/fast/harness: Removed.
- platform/mac-wk2/fast/multicol/vertical-rl: Removed.
- platform/mac-wk2/http/tests/appcache: Removed.
- platform/mac-wk2/http/tests/inspector: Removed.
- platform/mac-wk2/http/tests/misc: Removed.
- platform/mac-wk2/mathml: Removed.
- platform/mac-wk2/media: Removed.
- platform/mac-wk2/platform/mac/accessibility: Removed.
- platform/mac-wk2/tables/mozilla: Removed.
- platform/mac/css3/calc: Removed.
- platform/mac/css3/filters/custom: Removed.
- platform/mac/dom/xhtml/level2/html: Removed.
- platform/mac/fast/dom/shadow: Removed.
- platform/mac/fast/files: Removed.
- platform/mac/fast/forms/label: Removed.
- platform/mac/fast/innerHTML: Removed.
- platform/mac/fast/inspector: Removed.
- platform/mac/http/tests/xmlhttprequest/web-apps: Removed.
- platform/mac/inspector/console: Removed.
- platform/mac/inspector/debugger: Removed.
- platform/mac/inspector/extensions: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/sticky: Removed.
- platform/mac/sputnik/Unicode/Unicode_510: Removed.
- platform/mac/svg/animations: Removed.
- platform/mac/tables/mozilla/images: Removed.
- platform/mac/tiled-drawing/fixed: Removed.
- platform/mac/tiled-drawing/fixed-background: Removed.
- platform/mac/tiled-drawing/sticky: Removed.
- platform/qt-5.0-wk1/compositing/backing: Removed.
- platform/qt-5.0-wk1/compositing/filters: Removed.
- platform/qt-5.0-wk1/compositing/images: Removed.
- platform/qt-5.0-wk1/compositing/masks: Removed.
- platform/qt-5.0-wk1/compositing/rtl: Removed.
- platform/qt-5.0-wk1/compositing/tiling: Removed.
- platform/qt-5.0-wk1/compositing/visibility: Removed.
- platform/qt-5.0-wk1/css3/filters: Removed.
- platform/qt-5.0-wk1/editing/inserting: Removed.
- platform/qt-5.0-wk1/fast/dom/Window: Removed.
- platform/qt-5.0-wk2/compositing/backing: Removed.
- platform/qt-5.0-wk2/compositing/shadows: Removed.
- platform/qt-5.0-wk2/css1/basic: Removed.
- platform/qt-5.0-wk2/css1/box_properties: Removed.
- platform/qt-5.0-wk2/fast/block/basic: Removed.
- platform/qt-5.0-wk2/fast/block/float: Removed.
- platform/qt-5.0-wk2/fast/block/margin-collapse: Removed.
- platform/qt-5.0-wk2/fast/block/positioning/auto: Removed.
- platform/qt-5.0-wk2/fast/dom/HTMLHeadElement: Removed.
- platform/qt-5.0-wk2/fast/dom/HTMLTableElement: Removed.
- platform/qt-5.0-wk2/fast/dom/HTMLTextAreaElement: Removed.
- platform/qt-5.0-wk2/fast/dom/Window: Removed.
- platform/qt-5.0-wk2/fast/dynamic: Removed.
- platform/qt-5.0-wk2/fast/forms/datalist: Removed.
- platform/qt-5.0-wk2/fast/forms/mailto: Removed.
- platform/qt-5.0-wk2/fast/forms/number: Removed.
- platform/qt-5.0-wk2/fast/frames: Removed.
- platform/qt-5.0-wk2/fast/html: Removed.
- platform/qt-5.0-wk2/fast/images/png-suite: Removed.
- platform/qt-5.0-wk2/fast/inline: Removed.
- platform/qt-5.0-wk2/fast/lists: Removed.
- platform/qt-5.0-wk2/fast/multicol/span: Removed.
- platform/qt-5.0-wk2/fast/multicol/vertical-lr: Removed.
- platform/qt-5.0-wk2/fast/parser: Removed.
- platform/qt-5.0-wk2/fast/text/international: Removed.
- platform/qt-5.0-wk2/fullscreen/fullscreen: Removed.
- platform/qt-5.0-wk2/http/tests/websocket/test/hybi: Removed.
- platform/qt-5.0-wk2/platform/qt/plugins: Removed.
- platform/qt-5.0-wk2/svg/dom: Removed.
- platform/qt-5.0/animations: Removed.
- platform/qt-5.0/css1/text_properties: Removed.
- platform/qt-5.0/css2.1/20110323: Removed.
- platform/qt-5.0/editing/deleting: Removed.
- platform/qt-5.0/editing/inserting: Removed.
- platform/qt-5.0/editing/pasteboard: Removed.
- platform/qt-5.0/fast/borders: Removed.
- platform/qt-5.0/fast/css: Removed.
- platform/qt-5.0/fast/dom/DeviceMotion: Removed.
- platform/qt-5.0/fast/dom/DeviceOrientation: Removed.
- platform/qt-5.0/fast/dom/HTMLProgressElement: Removed.
- platform/qt-5.0/fast/dom/HTMLTextAreaElement: Removed.
- platform/qt-5.0/fast/dynamic: Removed.
- platform/qt-5.0/fast/html: Removed.
- platform/qt-5.0/fast/inline: Removed.
- platform/qt-5.0/fast/js: Removed.
- platform/qt-5.0/fast/multicol: Removed.
- platform/qt-5.0/fast/parser: Removed.
- platform/qt-5.0/fast/repaint: Removed.
- platform/qt-5.0/fast/replaced: Removed.
- platform/qt-5.0/fast/table/border-collapsing: Removed.
- platform/qt-5.0/fast/writing-mode: Removed.
- platform/qt-5.0/fast/xsl: Removed.
- platform/qt-5.0/svg/as-background-image: Removed.
- platform/qt-5.0/svg/custom: Removed.
- platform/qt-5.0/svg/hixie/intrinsic: Removed.
- platform/qt-5.0/svg/text: Removed.
- platform/qt-5.0/svg/wicd: Removed.
- platform/qt-5.0/svg/zoom/page: Removed.
- platform/qt-5.0/tables/mozilla/bugs: Removed.
- platform/qt-5.0/transitions: Removed.
- platform/qt-arm/fast/block: Removed.
- platform/qt-arm/fast/dom: Removed.
- platform/qt-arm/transforms: Removed.
- platform/qt-linux/fast/css: Removed.
- platform/qt-mac/editing: Removed.
- platform/qt-mac/fast/block/float: Removed.
- platform/qt-mac/plugins: Removed.
- platform/qt-win/fast/events: Removed.
- platform/qt.5-0/fast/text/whitespace: Removed.
- platform/qt/compositing/tiling: Removed.
- platform/qt/fast/css/dumpAsText: Removed.
- platform/qt/fast/encoding/dumpAsText: Removed.
- platform/qt/fast/forms/mailto: Removed.
- platform/qt/fast/innerHTML: Removed.
- platform/qt/fast/inspector: Removed.
- platform/qt/fast/js/regress: Removed.
- platform/qt/fast/media/w3c: Removed.
- platform/qt/http/tests/plugins: Removed.
- platform/qt/http/tests/security/aboutBlank: Removed.
- platform/qt/http/tests/security/cookies: Removed.
- platform/qt/http/tests/security/mixedContent: Removed.
- platform/qt/http/tests/security/xssAuditor: Removed.
- platform/qt/http/tests/xmlhttprequest/workers: Removed.
- platform/qt/inspector/console: Removed.
- platform/qt/inspector/debugger: Removed.
- platform/qt/inspector/extensions: Removed.
- platform/qt/mathml/presentation: Removed.
- platform/qt/scrollingcoordinator: Removed.
- platform/qt/svg/hixie/error/dumpAsText: Removed.
- platform/qt/tables/mozilla/images: Removed.
- platform/qt/traversal: Removed.
- platform/win-7sp0/fast/harness: Removed.
- platform/win-wk2/css2.1: Removed.
- platform/win-wk2/editing/deleting: Removed.
- platform/win-wk2/editing/selection: Removed.
- platform/win-wk2/fast/css: Removed.
- platform/win-wk2/fast/forms: Removed.
- platform/win-wk2/fast/repaint: Removed.
- platform/win-wk2/fast/ruby: Removed.
- platform/win-wk2/fast/text/international: Removed.
- platform/win-wk2/http/tests/inspector-enabled: Removed.
- platform/win-wk2/http/tests/security: Removed.
- platform/win-wk2/http/tests/uri: Removed.
- platform/win-wk2/media: Removed.
- platform/win-wk2/platform/win/inverted-colors: Removed.
- platform/win-wk2/platform/win/plugins: Removed.
- platform/win-wk2/plugins/npruntime: Removed.
- platform/win-wk2/svg/W3C-I18N: Removed.
- platform/win-wk2/svg/W3C-SVG-1.1-SE: Removed.
- platform/win-wk2/svg/text: Removed.
- platform/win-wk2/svg/zoom/page: Removed.
- platform/win/canvas/philip/tests: Removed.
- platform/win/compositing/geometry: Removed.
- platform/win/compositing/overflow: Removed.
- platform/win/editing/style: Removed.
- platform/win/editing/undo: Removed.
- platform/win/fast/block/basic: Removed.
- platform/win/fast/css/getComputedStyle: Removed.
- platform/win/fast/css3-text-decoration/getComputedStyle: Removed.
- platform/win/fast/dom/Element: Removed.
- platform/win/fast/dom/HTMLTextAreaElement: Removed.
- platform/win/fast/dom/Window: Removed.
- platform/win/fast/events/resources: Removed.
- platform/win/fast/frames/seamless: Removed.
- platform/win/fast/layers: Removed.
- platform/win/fast/loader: Removed.
- platform/win/fast/overflow: Removed.
- platform/win/fast/parser: Removed.
- platform/win/fast/table: Removed.
- platform/win/fast/transforms: Removed.
- platform/win/inspector/debugger: Removed.
- platform/win/platform/win/accessibility: Removed.
- platform/win/tables/mozilla/bugs: Removed.
- platform/win/tables/mozilla/other: Removed.
- platform/win/tables/mozilla_expected_failures/bugs: Removed.
- platform/wk2/tables/mozilla/bugs: Removed.
- pointer-lock/resources: Removed.
- storage/indexeddb/script-tests: Removed.
- svg/dom/SVGStyleElement/resources: Removed.
- webintents/resources: Removed.
- 5:15 PM Changeset in webkit [148158] by
-
- 2 edits in trunk/Tools
Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114397
Reviewed by Benjamin Poulain.
- Scripts/webkitpy/common/net/statusserver.py:
(StatusServer):
- 5:10 PM Changeset in webkit [148157] by
-
- 2 edits in trunk/Source/WebKit2
[CMAKE] Build fix after r148147, r148148
https://bugs.webkit.org/show_bug.cgi?id=114395
Unreviewed build fix.
Use StorageAreaImpl, StorageNamespaceImpl instead of StorageAreaProxy, StorageNamespaceProxy.
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-10
- CMakeLists.txt:
- 5:09 PM Changeset in webkit [148156] by
-
- 5 edits in trunk/Websites/bugs.webkit.org
Make old EWS bubbles less opaque to disambiguate two set of bubbles.
Rubber-stamped by Benjamin Poulain.
- code-review.js:
- template/en/custom/attachment/edit.html.tmpl:
- template/en/custom/attachment/list.html.tmpl:
- template/en/custom/attachment/reviewform.html.tmpl:
- 5:04 PM Changeset in webkit [148155] by
-
- 2 edits in trunk/Source/WebCore
Log when the animation timer fires
https://bugs.webkit.org/show_bug.cgi?id=114393
Reviewed by Dean Jackson.
Logging to the Animations log channel when the updateAnimationTimer
fires is useful, because it indicates whether we're running
software animations.
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::updateAnimationTimer):
- 5:02 PM Changeset in webkit [148154] by
-
- 5 edits1 move2 adds in trunk/Source/WebKit2
Add a stubbed out StorageAreaMap class
https://bugs.webkit.org/show_bug.cgi?id=114392
Reviewed by Andreas Kling.
The intention is that StorageAreaMap is going to take over responsibility for storing the storage values in the
web process, as well as dispatching events. A StorageAreaMap will be shared between multiple StorageAreaImpl objects,
for example if multiple frames with the same origin use local storage.
- DerivedSources.make:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::dispatchEvents):
(WebKit::StorageManager::setItem):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::~StorageAreaImpl):
- WebProcess/Storage/StorageAreaMap.cpp: Added.
(WebKit):
(WebKit::StorageAreaMap::create):
(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::~StorageAreaMap):
(WebKit::StorageAreaMap::didSetItem):
(WebKit::StorageAreaMap::dispatchStorageEvent):
- WebProcess/Storage/StorageAreaMap.h: Added.
(WebKit):
(StorageAreaMap):
- WebProcess/Storage/StorageAreaMap.messages.in: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaImpl.messages.in.
- 5:00 PM Changeset in webkit [148153] by
-
- 5 edits in trunk/Websites/bugs.webkit.org
Bugzilla should show bubbles from webkit-queues.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114391
Reviewed by Benjamin Poulain.
Include iframe from webkit-queues.appspot.com as well as one for webkit-commit-queue.appspot.com.
- code-review.js:
- template/en/custom/attachment/edit.html.tmpl:
- template/en/custom/attachment/list.html.tmpl:
- template/en/custom/attachment/reviewform.html.tmpl:
- 4:53 PM Changeset in webkit [148152] by
-
- 2 edits in trunk/Tools
Remove abarth from watchlists
https://bugs.webkit.org/show_bug.cgi?id=114390
Reviewed by Ryosuke Niwa.
I'm trying to cut down on the amount of bugmail I get so that I'll have
more of a chance to notice a piece of bugmail directed at me.
- Scripts/webkitpy/common/config/watchlist:
- 4:44 PM Changeset in webkit [148151] by
-
- 3 edits in trunk/Tools
webkit-test-results.appspot.com loads the dashboard for Chromium by default
https://bugs.webkit.org/show_bug.cgi?id=114381
Reviewed by Benjamin Poulain.
Changed the defaults.
- TestResultServer/static-dashboards/builders.js:
- TestResultServer/static-dashboards/dashboard_base.js:
(currentBuilderGroupCategory):
- 4:34 PM Changeset in webkit [148150] by
-
- 4 edits2 adds in branches/safari-536.30-branch
Merge 136250. <rdar://problem/13335010>
- 4:25 PM Changeset in webkit [148149] by
-
- 2 edits in trunk/Source/WebCore
Inspector highlights are offset when the WKView has a header
https://bugs.webkit.org/show_bug.cgi?id=114389
-and corresponding-
<rdar://problem/13522434>
Reviewed by Sam Weinig.
rootViewToContents() and contentsToRootView() need to factor in the
headerHeight(), much like windowToContents() and contentsToWindow() do already.
- platform/ScrollView.cpp:
(WebCore::ScrollView::rootViewToContents):
(WebCore::ScrollView::contentsToRootView):
- 4:22 PM Changeset in webkit [148148] by
-
- 6 edits3 moves in trunk/Source/WebKit2
Rename StorageAreaProxy to StorageAreaImpl.
Rubber-stamped by Beth Dakin.
- DerivedSources.make:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::dispatchEvents):
(WebKit::StorageManager::setItem):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Storage/StorageAreaImpl.cpp: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp.
- WebProcess/Storage/StorageAreaImpl.h: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.h.
- WebProcess/Storage/StorageAreaImpl.messages.in: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.messages.in.
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::storageArea):
- WebProcess/Storage/StorageNamespaceImpl.h:
(WebKit):
(StorageNamespaceImpl):
- 4:21 PM Changeset in webkit [148147] by
-
- 5 edits2 moves in trunk/Source/WebKit2
Rename StorageNamespaceProxy to StorageNamespaceImpl.
Rubber-stamped by Beth Dakin.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::create):
(WebKit::StorageAreaProxy::StorageAreaProxy):
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- WebProcess/Storage/StorageNamespaceImpl.cpp: Renamed from Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.cpp.
- WebProcess/Storage/StorageNamespaceImpl.h: Renamed from Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.h.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::sessionStorageNamespace):
- 4:11 PM Changeset in webkit [148146] by
-
- 6 edits in trunk/Tools
Remove Chromium EWS bots from the queue status server
https://bugs.webkit.org/show_bug.cgi?id=113988
Reviewed by Benjamin Poulain.
Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
- QueueStatusServer/app.yaml:
- QueueStatusServer/config/queues.py:
- QueueStatusServer/model/queues.py:
(Queue.short_name):
(Queue.display_name):
- QueueStatusServer/model/queues_unittest.py:
(QueueTest.test_short_name):
(QueueTest.test_display_name):
(QueueTest.test_name_with_underscores):
- QueueStatusServer/templates/activebots.html:
- 3:47 PM Changeset in webkit [148145] by
-
- 4 edits in trunk/Source/WebCore
Flesh out the Animations logging
https://bugs.webkit.org/show_bug.cgi?id=114388
Reviewed by Dean Jackson.
Log state changes and transition/animation creation and destruction
to the Animations log channel.
- page/animation/AnimationBase.cpp:
(WebCore::nameForState):
(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::goIntoEndingOrLoopingState):
(WebCore::AnimationBase::freezeAtTime):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
- page/animation/KeyframeAnimation.h:
(WebCore::KeyframeAnimation::keyframes):
(KeyframeAnimation):
- 3:45 PM Changeset in webkit [148144] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/13047266> External XML entities are not loaded with modern libxml2
https://bugs.webkit.org/show_bug.cgi?id=114377
Reviewed by Darin Adler.
Covered by http/tests/security/xss-DENIED-xml-external-entity.xhtml when using
new enough libxml2.
- xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::switchToUTF16): Added a FIXME with an idea for improvement. (WebCore::XMLParserContext::createStringParser): Apply XML_PARSE_NOENT in a non-hacky way, so that the new libxml2 check doesn't fail. (WebCore::XMLParserContext::createMemoryParser): Updated an unhelpful and incorrect comment (XML_PARSE_NODICT actually means "Do not reuse the context dictionary").
- 3:35 PM Changeset in webkit [148143] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] Un-pollute TCADA methods with "PageOverlayLayerMap::iterator end"
https://bugs.webkit.org/show_bug.cgi?id=114387
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::paintContents):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
- 3:25 PM Changeset in webkit [148142] by
-
- 4 edits3 adds in trunk
JSObject::getOwnNonIndexPropertyNames calculates numCacheableSlots incorrectly
https://bugs.webkit.org/show_bug.cgi?id=114235
Reviewed by Filip Pizlo.
If the object doesn't have any properties but the prototype does, we'll assume those prototype properties are
accessible in the base object's backing store, which is bad.
Source/JavaScriptCore:
- runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnNonIndexPropertyNames):
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::setNumCacheableSlotsForObject):
(JSC::PropertyNameArray::setBaseObject):
(PropertyNameArray):
LayoutTests:
- fast/js/get-by-pname-only-prototype-properties-expected.txt: Added.
- fast/js/get-by-pname-only-prototype-properties.html: Added.
- fast/js/script-tests/get-by-pname-only-prototype-properties.js: Added.
(foo):
- 3:18 PM Changeset in webkit [148141] by
-
- 3 edits in trunk/Source/WebKit2
[wk2] REGRESSION: Find highlight does not update when the view is resized
https://bugs.webkit.org/show_bug.cgi?id=114382
<rdar://problem/13599797>
Reviewed by Simon Fraser.
Invalidate the page overlays from TiledCoreAnimationDrawingArea::updateGeometry.
This will have no effect if the page overlay hasn't previously asked to be painted
(as drawsContent will remain false on the layer).
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea): Add invalidateAllPageOverlays.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::invalidateAllPageOverlays): Factor this out of didChangeScrollOffsetForAnyFrame.
(WebKit::TiledCoreAnimationDrawingArea::didChangeScrollOffsetForAnyFrame): Call invalidateAllPageOverlays.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry): Call invalidateAllPageOverlays.
- 2:53 PM Changeset in webkit [148140] by
-
- 2 edits in trunk/Source/WebCore
[Mac] in-band tracks sometimes not recognized
https://bugs.webkit.org/show_bug.cgi?id=114380
Reviewed by Jer Noble.
No new tests, covered by existing in-band tests.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Don't call selectMediaOption,
availableMediaCharacteristicsWithMediaSelectionOptions is unlikely to be loaded at this time.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Disable automatic text track
selection.
(WebCore::assetMetadataKeyNames): Watch for the status of availableMediaCharacteristicsWithMediaSelectionOptions
to change.
- 2:22 PM Changeset in webkit [148139] by
-
- 3 edits2 adds in trunk
[CSS Exclusions] Zoom causes shape-inside to fail when shape-padding is specified
https://bugs.webkit.org/show_bug.cgi?id=113730
Reviewed by Dirk Schulze.
Source/WebCore:
Snap computed margin and polygon boundaries to the LayoutUnit grid to ensure
that they fall within the shape's LayoutUnit bounding box.
Test: fast/exclusions/shape-inside/shape-inside-polygon-zoom.html
- rendering/ExclusionPolygon.cpp:
(WebCore::snapVerticesToLayoutUnitGrid): Convert the FloatPoint coordinates to LayoutUnits and then back to floats.
(WebCore::computeShapePaddingBounds): Now calls snapVerticesToLayoutUnitGrid() before creating a FloatPolygon.
(WebCore::computeShapeMarginBounds): Ditto.
LayoutTests:
Verify that content lays out within a padded shape-inside polygon when the
document has been zoomed.
- fast/exclusions/shape-inside/shape-inside-polygon-zoom-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-polygon-zoom.html: Added.
- 2:11 PM Changeset in webkit [148138] by
-
- 2 edits in trunk/Source/WebCore
One more unreviewed buildfix after r148123.
- platform/graphics/filters/CustomFilterMeshGenerator.h:
- 1:57 PM Changeset in webkit [148137] by
-
- 8 edits in trunk/Source
FindBanner matches are offset when the WKView has a header or footer
https://bugs.webkit.org/show_bug.cgi?id=114314
-and corresponding-
<rdar://problem/13522434>
Reviewed by Simon Fraser.
Source/WebCore:
There were already a few places in the code where we needed to adjust the
scrollOffset() to pretend that (0,0) is that the top of the Document rather than
the top of the header. To fix the FindBanner issues, we need to know that version
of the offset in a few more places, so I added a function on ScrollView to fetch
it called scrollOffsetRelativeToDocument().
New function subtracts out the headerHeight() to treat the top of
the document as (0,0).
- WebCore.exp.in:
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollOffsetRelativeToDocument):
Use scrollOffsetRelativeToDocument() where we were previously making this
calculation. Also re-name an inaccurately named variable where we are actually
converting FROM a document offset to a ScrollableArea offset.
(WebCore::ScrollView::windowToContents):
- platform/ScrollView.h:
(ScrollView):
getRectToExpose needs to know about the actual visibleContentRect and the
visibleContentRect that is relative to the Document. So this
patch adds a new parameter to getRectToExpose for that purpose.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::getRectToExpose):
- rendering/RenderLayer.h:
Source/WebKit2:
When calculating the matching rects, also adjust to the scroll offset that is
relative to the Document.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::rectsForTextMatches):
- 1:45 PM Changeset in webkit [148136] by
-
- 7 edits2 adds in trunk
when ARIA button contains a link, label text is ignored (affects main buttons on m.facebook.com)
https://bugs.webkit.org/show_bug.cgi?id=113906
Reviewed by Tim Horton.
Source/WebCore:
If an element does not expose any children, then it's safe to include all of its sub children when determining
the visible text.
The bug is that all elements were ignoring focusable elements (like <a>) when determining visible children text
Test: accessibility/link-inside-button-accessible-text.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::shouldUseAccessiblityObjectInnerText):
- accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isDescendantOfBarrenParent):
(AccessibilityObject):
LayoutTests:
The static-text-role-uses-text-under-element.html relies on similar logic to this bug.
I realized that it was verifying the wrong thing and if we had looked closely at this layout test
we would have caught this regression earlier most likely.
- accessibility/link-inside-button-accessible-text-expected.txt: Added.
- accessibility/link-inside-button-accessible-text.html: Added.
- platform/mac/accessibility/static-text-role-uses-text-under-element-expected.txt:
- platform/mac/accessibility/static-text-role-uses-text-under-element.html:
- 1:38 PM Changeset in webkit [148135] by
-
- 2 edits in trunk/Source/WebCore
AX: Make sure all AX methods called from outside call prepareAccessibility
https://bugs.webkit.org/show_bug.cgi?id=113818
Reviewed by Darin Adler.
Make sure any calls that can be made from outside WebCore are protected with the
prepareAccessibility method.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityMathRootIndexObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathRadicandObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathNumeratorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathDenominatorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathBaseObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSubscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSuperscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathUnderObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathOverObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedOpenString]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedCloseString]):
(-[WebAccessibilityObjectWrapper accessibilityIsMathTopObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathType]):
- 1:30 PM Changeset in webkit [148134] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove code duplicates from MacroAssemblerARM
https://bugs.webkit.org/show_bug.cgi?id=104457
Reviewed by Oliver Hunt.
Reuse some existing methods to avoid duplicated code.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::store8):
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::swap):
(JSC::MacroAssemblerARM::add32):
(JSC::MacroAssemblerARM::sub32):
- 1:21 PM Changeset in webkit [148133] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed buildfix after r148123.
- inspector/InspectorInstrumentation.h:
(WebCore):
- 1:05 PM Changeset in webkit [148132] by
-
- 10 edits in trunk/Tools
Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114370
Reviewed by Ryosuke Niwa.
Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
Unfortunately, there's no way to test this until this is committed and there is
a master restart.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- TestResultServer/generate_builders_json.py:
- TestResultServer/static-dashboards/dashboard_base.js:
- TestResultServer/static-dashboards/loader.js:
- 1:02 PM Changeset in webkit [148131] by
-
- 3 edits2 adds in trunk
Clicking on the volume slider of HTML5 elements is pausing sometimes
https://bugs.webkit.org/show_bug.cgi?id=112548
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-04-10
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/click-volume-bar-not-pausing.html
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
Calling the setDefaultHandled() method on the event prevents it
from being incorrectly propagated from the volume button up to the
MediaDocument.
LayoutTests:
Added test.
- media/click-volume-bar-not-pausing-expected.txt: Added.
- media/click-volume-bar-not-pausing.html: Added.
- 1:01 PM Changeset in webkit [148130] by
-
- 3 edits3 adds in trunk
DFG: Negative size for new Array() interpreted as large unsigned int
https://bugs.webkit.org/show_bug.cgi?id=114366
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Added new check in operationNewArrayWithSize() for a negative
size. If size is negative throw a "RangeError: Array size is not a
small enough positive integer" exception.
- dfg/DFGOperations.cpp:
LayoutTests:
New test to make sure DFG generated code for new Array() with a
computed negative size throws an exception.
- fast/js/dfg-negative-array-size-expected.txt: Added.
- fast/js/dfg-negative-array-size.html: Added.
- fast/js/script-tests/dfg-negative-array-size.js: Added.
- 12:56 PM Changeset in webkit [148129] by
-
- 17 edits2 moves in trunk/Source
[BlackBerry] Rename BlackBerry specific Texture class
https://bugs.webkit.org/show_bug.cgi?id=95781
Reviewed by Rob Buis.
Texture was a bit too generic and prone to name conflicts. Renamed it
to LayerTexture.
Source/WebCore:
No change in behavior, no new tests.
PR 322882
- PlatformBlackBerry.cmake:
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawSurface):
(WebCore::LayerCompositingThread::contentsTexture):
- platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
- platform/graphics/blackberry/LayerCompositingThreadClient.h:
(WebCore):
(WebCore::LayerCompositingThreadClient::contentsTexture):
- platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRenderer::applyActions):
- platform/graphics/blackberry/LayerFilterRenderer.h:
(LayerFilterRenderer):
- platform/graphics/blackberry/LayerRendererSurface.h:
(WebCore::LayerRendererSurface::texture):
(LayerRendererSurface):
- platform/graphics/blackberry/LayerTexture.cpp: Renamed from Source/WebCore/platform/graphics/blackberry/Texture.cpp.
(WebCore):
(WebCore::LayerTexture::LayerTexture):
(WebCore::LayerTexture::~LayerTexture):
(WebCore::LayerTexture::updateContents):
(WebCore::LayerTexture::setContentsToColor):
(WebCore::LayerTexture::protect):
- platform/graphics/blackberry/LayerTexture.h: Renamed from Source/WebCore/platform/graphics/blackberry/Texture.h.
(WebCore):
(LayerTexture):
(WebCore::LayerTexture::create):
(WebCore::LayerTexture::textureId):
(WebCore::LayerTexture::isDirty):
(WebCore::LayerTexture::hasTexture):
(WebCore::LayerTexture::isColor):
(WebCore::LayerTexture::isOpaque):
(WebCore::LayerTexture::isProtected):
(WebCore::LayerTexture::protect):
(WebCore::LayerTexture::unprotect):
(WebCore::LayerTexture::size):
(WebCore::LayerTexture::width):
(WebCore::LayerTexture::height):
(WebCore::LayerTexture::bytesPerPixel):
(WebCore::LayerTexture::sizeInBytes):
(WebCore::LayerTexture::setTextureId):
(WebCore::LayerTexture::setSize):
- platform/graphics/blackberry/LayerTile.cpp:
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):
(WebCore::LayerTile::setTexture):
- platform/graphics/blackberry/LayerTile.h:
(WebCore::LayerTile::texture):
(LayerTile):
- platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::drawTile):
(WebCore::LayerTiler::contentsTexture):
- platform/graphics/blackberry/LayerTiler.h:
(LayerTiler):
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::updateContents):
(TextureJob):
- platform/graphics/blackberry/TextureCacheCompositingThread.cpp:
(WebCore::TextureProtector::TextureProtector):
(TextureProtector):
(WebCore::TextureCacheCompositingThread::allocateTextureId):
(WebCore::freeTextureId):
(WebCore::TextureCacheCompositingThread::textureResized):
(WebCore::TextureCacheCompositingThread::textureSizeInBytesChanged):
(WebCore::TextureCacheCompositingThread::textureDestroyed):
(WebCore::TextureCacheCompositingThread::install):
(WebCore::TextureCacheCompositingThread::resizeTexture):
(WebCore::TextureCacheCompositingThread::evict):
(WebCore::TextureCacheCompositingThread::textureAccessed):
(WebCore::TextureCacheCompositingThread::prune):
(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::textureForColor):
(WebCore::TextureCacheCompositingThread::updateContents):
- platform/graphics/blackberry/TextureCacheCompositingThread.h:
(WebCore::TextureCacheCompositingThread::createTexture):
(TextureCacheCompositingThread):
(WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
(ZombieTexture):
Source/WebKit/blackberry:
PR 322882
- Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
- Api/WebOverlay_p.h:
(WebOverlayLayerCompositingThreadClient):
- 12:38 PM Changeset in webkit [148128] by
-
- 2 edits in trunk/Source/WebCore
Disallow programmatic movement of the browser window while user gestures are in progress.
<http://webkit.org/b/114271>
<rdar://problem/13226530>
Reviewed by Oliver Hunt.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):
- 12:33 PM Changeset in webkit [148127] by
-
- 3 edits in trunk/Source/JavaScriptCore
WinCairo build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=114358
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-10
Reviewed by Brent Fulgham.
Export the symbol WTF::MD5::checksum().
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 12:24 PM Changeset in webkit [148126] by
-
- 3 edits in trunk/Tools
[Qt] Fix regression to test-webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=114368
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
(PortFactory.get): Remove obsolete chromium port related code.
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.default_child_processes): Prevent type error if can't determine total memory.
- 12:18 PM Changeset in webkit [148125] by
-
- 2 edits in trunk/Source/WebKit2
Fixed build failure in Plugin.h: FloatPoint was not in namespace WebCore
make[1]: * Waiting for unfinished jobs....
In file included from Source/WebKit2/PluginProcess/PluginCreationParameters.h:31:0,
from Source/WebKit2/PluginProcess/PluginCreationParameters.cpp:27:
./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:58: error: 'FloatPoint' in namespace 'WebCore' does not name a type
./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:77: error: ISO C++ forbids declaration of 'parameter' with no type [-fpermissive]
cc1plus: warning: unrecognized command line option "-Wno-c++11-extensions" [enabled by default]
make[1]: * [Source/WebKit2/PluginProcess/libwebkit2gtk_3_0_la-PluginCreationParameters.lo] Error 1
It now passes that make target.
https://bugs.webkit.org/show_bug.cgi?id=111862
Patch by Tobias Mueller <tobiasmue@gnome.org> on 2013-04-10
Reviewed by Darin Adler.
- WebProcess/Plugins/Plugin.h:
(WebCore): Added FloatPoint to the WebCore namespace
- 12:16 PM Changeset in webkit [148124] by
-
- 2 edits in trunk/Source/WebCore
Refactor Editor::markAndReplaceFor before fixing autocorrection bugs
https://bugs.webkit.org/show_bug.cgi?id=114344
Reviewed by Enrica Casucci.
This patch refactors Editor::markAndReplaceFor so that we can start fixing bugs in a sane state.
Extracted isAutomaticTextReplacementType and correctSpellcheckingPreservingTextCheckingParagraph,
and made convenience local variables const.
In particular, shouldMarkSpelling used to be assigned of false when shouldShowCorrectionPanel was true
in a middle of a function but this was removed in favor of explicitly checking this condition later
since shouldMarkSpelling was only referenced once after the assignment.
- editing/Editor.cpp:
(WebCore::isAutomaticTextReplacementType): Extracted.
(WebCore::correctSpellcheckingPreservingTextCheckingParagraph): Extracted. Used highestAncestor
and rangeFromLocationAndLength to match the rest of the up-to-date editing code.
(WebCore::Editor::markAndReplaceFor): See above.
- 12:11 PM Changeset in webkit [148123] by
-
- 38 edits in trunk
Remove unneeded headers from FrameLoader.h
https://bugs.webkit.org/show_bug.cgi?id=114223
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Update for WTF changes.
- bytecode/SpeculatedType.h:
- runtime/JSCJSValue.h:
Source/WebCore:
Remove unneeded headers from FrameLoader.h and add them back into the respective .cpp files where needed.
- dom/Document.cpp:
- history/CachedFrame.cpp:
- history/PageCache.cpp:
- inspector/InspectorResourceAgent.cpp:
- loader/DocumentLoader.cpp:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad):
- loader/FrameLoader.h:
(WebCore):
(WebCore::FrameLoader::policyChecker):
(WebCore::FrameLoader::history):
(WebCore::FrameLoader::icon):
- loader/MixedContentChecker.h:
- loader/icon/IconLoader.cpp:
- page/History.cpp:
- page/Page.cpp:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- testing/Internals.cpp:
Source/WebKit/blackberry:
Include HistoryController.h from WebCore.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
Source/WebKit/mac:
Include HistoryController.h from WebCore.
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebView.mm:
Source/WebKit/win:
Include HistoryController.h from WebCore.
- WebView.cpp:
Source/WebKit2:
Include HistoryController.h from WebCore.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebPage/WebPage.cpp:
Source/WTF:
- wtf/Forward.h:
Add PrintStream.
- wtf/HashTable.h:
Don't include DataLog.h unless DUMP_HASHTABLE_STATS_PER_TABLE is 1.
Tools:
Add back headers implicitly included by other headers.
- WebKitTestRunner/WorkQueueManager.cpp:
- 12:03 PM Changeset in webkit [148122] by
-
- 2 edits in trunk/Source/WebCore
Minor code cleanup in AnimationBase::progress
https://bugs.webkit.org/show_bug.cgi?id=114371
Reviewed by Dean Jackson.
Convert some "return; else if" to just "return; if".
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::progress):
- 11:56 AM Changeset in webkit [148121] by
-
- 3 edits2 adds in trunk
Empty inline continuations should only get lineboxes if the padding applies to their side of the inline
https://bugs.webkit.org/show_bug.cgi?id=113896
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/inline/inline-with-empty-inline-continuations.html
Where an empty inline is split across anonymous blocks we should only give lineboxes to the 'sides' of the
inline that have borders, padding or margin.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::shouldApplyStartBorderPaddingOrMargin):
(WebCore):
(WebCore::shouldApplyEndBorderPaddingOrMargin):
(WebCore::hasInlineDirectionBordersPaddingOrMargin):
(WebCore::alwaysRequiresLineBox):
LayoutTests:
- fast/inline/inline-with-empty-inline-continuations-expected.txt: Added.
- fast/inline/inline-with-empty-inline-continuations.html: Added.
- 11:53 AM Changeset in webkit [148120] by
-
- 4 edits2 adds in trunk
[CSS Exclusions] Increasing padding does not correctly layout child blocks
https://bugs.webkit.org/show_bug.cgi?id=112929
Reviewed by David Hyatt.
If a child block has changed dimension inside a shape and it has affected the block siblings
we need to relayout the content inside the shape.
Source/WebCore:
Test: fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout): Add condition for dimension change.
(WebCore::RenderBlock::layoutBlock): Call updateRegionsAndExclusionsAfterChildLayout with the new parameter.
- rendering/RenderBlock.h:
(RenderBlock): Add extra parameter to updateRegionsAndExclusionsAfterChildLayout(...)
LayoutTests:
- fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html: Added.
- 11:51 AM Changeset in webkit [148119] by
-
- 42 edits2 deletes in trunk/Source
Removed bitrotted TimeoutChecker code
https://bugs.webkit.org/show_bug.cgi?id=114336
Reviewed by Alexey Proskuryakov.
This mechanism hasn't worked for a while.
MarkL is working on a new version of this feature with a distinct
implementation.
- API/APIShims.h:
(JSC::APIEntryShim::~APIEntryShim):
(JSC::APIEntryShim::init):
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGGPRInfo.h:
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/JSInterfaceJIT.h:
(JSInterfaceJIT):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
- runtime/JSGlobalObject.cpp:
- runtime/JSONObject.cpp:
(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::walk):
- runtime/TimeoutChecker.cpp: Removed.
- runtime/TimeoutChecker.h: Removed.
../WebCore:
This mechanism hasn't worked for a while.
MarkL is working on a new version of this feature with a distinct
implementation.
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):
- bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::call):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneBase::CloneBase):
(WebCore::CloneSerializer::serialize):
(WebCore::CloneDeserializer::deserialize):
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
../WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setTimeoutForJavaScriptExecution):
../WebKit/mac:
This mechanism hasn't worked for a while.
MarkL is working on a new version of this feature with a distinct
implementation.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::evaluate):
../WebKit/qt:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createDocumentLoader):
../WebKit2:
This mechanism hasn't worked for a while.
MarkL is working on a new version of this feature with a distinct
implementation.
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::construct):
(WebKit::NPJSObject::invoke):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::evaluate):
- 11:50 AM Changeset in webkit [148118] by
-
- 2 edits in trunk/Source/WebCore
Replace ENABLE_JAVASCRIPT_DEBUGGER preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114352
Reviewed by Timothy Hatcher.
The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
- page/Console.idl:
- 11:48 AM Changeset in webkit [148117] by
-
- 3 edits2 adds in trunk
Layers with opacity and blur filters are reported as opaque to the compositor
https://bugs.webkit.org/show_bug.cgi?id=114295
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/contents-opaque/filter.html
Some filters like opacity and blur might still trigger transparency in the layer, even though the
background is opaque. I've added the special case in RenderLayer::backgroundIsKnownToBeOpaqueInRect to check
for filters that might have transparency. Note that this special case is required only for software drawn
filters, as the transparency is going to be backed in the GraphicsLayer content. Composited filters can
figure it out in the compositor.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
Added test to check for blur and opacity filters drawn in software mode which needs
to force the layer report non-opaque to the compositor.
- compositing/contents-opaque/filter-expected.txt: Added.
- compositing/contents-opaque/filter.html: Added.
- 11:37 AM Changeset in webkit [148116] by
-
- 2 edits in tags/Safari-537.35.11/Source/WebCore
Rollout r148109.
- 11:26 AM Changeset in webkit [148115] by
-
- 4 edits2 adds in trunk
[Texmap] In certain situations nested blending with overflow:hidden displays clipped results
https://bugs.webkit.org/show_bug.cgi?id=114290
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-10
Reviewed by Allan Sandfeld Jensen.
Source/WebCore:
Always apply the clip when binding a surface, even if it hasn't changed.
Otherwise when binding a nested surface and rebinding its container surface,
the clip wouldn't apply.
Test: compositing/overlap-blending/nested-overlap-overflow.html
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::bind):
LayoutTests:
Added a ref-test that exposes an issue with TextureMapper overlap blending when composited.
This ref-test does not show correct results on Mac, skipped in TestExpectations and created a bug.
- compositing/overlap-blending/nested-overlap-overflow-expected.html: Added.
- compositing/overlap-blending/nested-overlap-overflow.html: Added.
- platform/mac/TestExpectations: Skipped new tests and created bug.
- 11:17 AM Changeset in webkit [148114] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
I should know better than to lie in ChangeLog entries.
- 11:14 AM Changeset in webkit [148113] by
-
- 4 edits in trunk/Source/WebKit2
<rdar://problem/13617144> WKNavigationData needs to expose the destination of the navigation
Introduce WKNavigationDataCopyNavigationDestinationURL to access the destination of the navigation.
Reviewed by Darin Adler.
- UIProcess/API/C/WKNavigationData.cpp:
(WKNavigationDataCopyURL): Add a note about returning the URL from the original request for sake of
backwards-compatibility.
(WKNavigationDataCopyNavigationDestinationURL): Return the URL from our underlying WebNavigationDataStore.
- UIProcess/API/C/WKNavigationData.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::updateGlobalHistory): Store the current URL in to the WebNavigationDataStore
object. WKNavigationData can retrieve the value that we were previously storing here via the originalRequest.
- 11:14 AM Changeset in webkit [148112] by
-
- 4 edits in trunk/Source/WebKit2
<rdar://problem/13617104> WKPageCopySessionState needs to provide more context to the filter callback
Introduce a new value type for WKPageSessionStateFilterCallback that represents the passing
of whole WKBackForwardListItemRefs to the filter callback. This allows clients to consider
more than the original URL of the item when filtering entries from the session state.
Reviewed by Darin Adler.
- UIProcess/API/C/WKPage.cpp:
(WKPageGetSessionBackForwardListItemValueType): Return a static string representing our new value type.
- UIProcess/API/C/WKPage.h:
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Call the filter function with each of the
possible value types in turn, respecting the first false value, if any, that is returned.
- 11:07 AM Changeset in webkit [148111] by
-
- 4 edits in trunk/Source/WebCore
Use minimal tiles during live resize
https://bugs.webkit.org/show_bug.cgi?id=114364
Reviewed by Darin Adler.
We currently update non-visible speculative tiles during resizing. We should just drop them.
- page/FrameView.cpp:
(WebCore::FrameView::willStartLiveResize):
(WebCore::FrameView::willEndLiveResize):
- page/FrameView.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::computeTileCoverage):
Use minimal coverage in live resize state.
- 11:05 AM Changeset in webkit [148110] by
-
- 2 edits1 add in trunk/Tools
[GTK] Include a crash-fixing patch for the at-spi2-atk dependency
https://bugs.webkit.org/show_bug.cgi?id=114365
Reviewed by Martin Robinson.
Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
The patch addresses crashes in the tally_event_reply method. It is already committed into the
at-spi2-atk source tree and will be available with the next stable release, after which the
patch should be removed and the dependency version bumped.
- gtk/jhbuild.modules:
- gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
- 11:03 AM Changeset in webkit [148109] by
-
- 2 edits in tags/Safari-537.35.11/Source/WebCore
Merged r147977. <rdar://problem/13604480>
- 10:55 AM Changeset in webkit [148108] by
-
- 4 edits in tags/Safari-537.35.11/Source
Versioning.
- 10:51 AM Changeset in webkit [148107] by
-
- 1 copy in tags/Safari-537.35.11
New Tag.
- 10:47 AM Changeset in webkit [148106] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (r148073): WebKit Nightly r148082 crashes on launch in JSObjectSetPrivate
https://bugs.webkit.org/show_bug.cgi?id=114341
Reviewed by Alexey Proskuryakov.
Make JSObjectSetPrivate use uncheckedToJS as some clients
clear their private data during finalization for some reason.
- API/JSObjectRef.cpp:
(JSObjectSetPrivate):
- 10:36 AM BuildingGtk edited by
- Warn that the instructions aren't really useful for building a release … (diff)
- 10:13 AM Changeset in webkit [148105] by
-
- 19 edits4 adds in trunk
Blob content type normalization.
https://bugs.webkit.org/show_bug.cgi?id=111380
Patch by Victor Costan <costan@gmail.com> on 2013-04-10
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Tests: http/tests/fast/files/blob-constructor.js
http/tests/fileapi/xhr-send-form-data-filename-escaping.html
http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html
- WebCore.exp.in: exported Blob::isNormalizedContentType()
- bindings/js/JSBlobCustom.cpp:
(WebCore::JSBlobConstructor::constructJSBlob): remove checks on Blob type, BlobBuilder will normalize it
- fileapi/Blob.cpp:
(BlobType): utilities for normalizing a Blob's type according to the File API spec
(WebCore::BlobType::isValid): content type validity checks in the File API spec
(WebCore::BlobType::normalize): implements the normalization rules in the File API spec
(WebCore::BlobType::isNormalized): useful for ASSERTing that a Blob type has been normalized
(WebCore): implement Blob type normalization according to the File API spec
(WebCore::Blob::Blob): normalize the Blob type in the data URL
(WebCore::Blob::slice): normalize the Blob type argument
- fileapi/Blob.h:
(BlobType): utilities for normalizing a Blob's type according to the File API spec
(WebCore::Blob::create): assert that the deserialized Blob's type was normalized
- fileapi/File.cpp:
(WebCore::createBlobDataForFileWithType): assert that the File's MIME type is a normalized Blob type
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::BlobBuilder::getBlob): normalize the Blob's type before building it
- platform/network/BlobData.h:
(WebCore::BlobData::setContentType): assert that the Blob type has been normalized
- platform/network/FormData.cpp:
(WebCore::FormData::appendKeyValuePairItems): assert that Blob's type has been normalized
- platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::addContentTypeToMultiPartHeader): assert that the Content-Type field is normalized
- xml/XMLHttpRequest.cpp: when responseType is blob, normalize Content-Type before passing to Blob constructor
LayoutTests:
- http/tests/fast/files/script-tests/blob-constructor.js: added/updated test cases for Blob type normalization
- http/tests/fast/files/blob-constructor-expected.txt: added/updated test cases for Blob type normalization
- http/tests/fileapi/xhr-send-form-data-filename-escaping-expected.txt: Added.
- http/tests/fileapi/xhr-send-form-data-filename-escaping.html: Added.
- http/tests/fileapi/xhr-send-form-data-mimetype-normalization-expected.txt: Added.
- http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html: Added.
- http/tests/local/formdata/resources/send-form-data-common.js:
(dumpResponse): return the HTTP response text so it can be used in JS test code
(sendFormData): passthrough the HTTP response text returned by dumpResponse()
(testSendingFormData): passthrough the HTTP response text returned by dumpResponse()
- http/tests/xmlhttprequest/post-blob-content-type-async-expected.txt: updated expectation for invalid Content-Type
- http/tests/xmlhttprequest/post-blob-content-type-sync-expected.txt: updated expectation for invalid Content-Type
- http/tests/xmlhttprequest/post-blob-content-type-tests.js: updated expectation for invalid Content-Type
- 10:11 AM Changeset in webkit [148104] by
-
- 13 edits8 deletes in trunk/LayoutTests
Rebaseline four tiled drawing tests affeted by r148049.
Move results from platform/mac/platform/mac-wk2/tiled-drawing to platform/mac-wk2/tiled-drawing
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view-expected.txt:
- platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt: Removed.
- platform/mac/platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt: Removed.
- 9:50 AM Changeset in webkit [148103] by
-
- 2 edits in trunk/Tools
[WinCairo] Unreviewed build fix. Correct DropBox download link.
- Scripts/update-webkit-wincairo-libs: Revise download URL to
match change in DropBox server behavior.
- 9:32 AM Changeset in webkit [148102] by
-
- 3 edits in trunk/Source/WebCore
TileController doesn't remove tiles when the view is resized, leading to stale content
https://bugs.webkit.org/show_bug.cgi?id=114323
<rdar://problem/13520671>
Reviewed by Simon Fraser.
Ensure that tiles are removed if the view shrinks, so that they are not displayed
with stale content if the view later grows again (they will not be repainted by WebCore
while out-of-view).
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::revalidateTiles):
- 9:28 AM Changeset in webkit [148101] by
-
- 2 edits in trunk/Source/WebCore
Update the localizable strings file.
Rubber-stamped by Dan Bernstein.
- English.lproj/Localizable.strings:
- 9:27 AM Changeset in webkit [148100] by
-
- 3 edits in trunk/Source/WebCore
Replace ENABLE_CHANNEL_MESSAGING preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114346
Reviewed by Geoffrey Garen.
The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
- 9:25 AM Changeset in webkit [148099] by
-
- 32 edits in trunk/Source/WebCore
Update all float attributes in HTMLMediaElement to double
https://bugs.webkit.org/show_bug.cgi?id=113615
Reviewed by Geoffrey Garen
Patch by Aaron Colwell
No new tests. Primary behavior doesn't change. Just time, playbackRate, and volume precision.
All existing LayoutTests/media tests still pass.
- WebCore.exp.in: Remove function that no longer need to be exported.
- html/HTMLMediaElement.cpp: Change all float attributes to double.
- html/HTMLMediaElement.h: Ditto.
- html/HTMLMediaElement.idl: Ditto.
- html/MediaController.cpp: Ditto.
- html/MediaController.h: Ditto.
- html/MediaControllerInterface.h: Ditto.
- html/TimeRanges.cpp: Ditto.
- html/TimeRanges.idl: Ditto.
- html/shadow/MediaControlElementTypes.cpp: Ditto.
- html/shadow/MediaControlElementTypes.h: Ditto.
- html/shadow/MediaControlElements.cpp: Ditto.
- html/shadow/MediaControlElements.h: Ditto.
- html/shadow/MediaControls.cpp: Ditto.
- html/shadow/MediaControlsApple.cpp: Ditto.
- html/shadow/MediaControlsBlackBerry.cpp: Ditto.
- html/shadow/MediaControlsBlackBerry.h: Ditto.
- html/shadow/MediaControlsGtk.cpp: Ditto.
- html/track/TextTrackCue.cpp: Ditto.
- html/track/TextTrackCue.h: Ditto.
- platform/Clock.h: Ditto.
- platform/ClockGeneric.cpp: Ditto.
- platform/ClockGeneric.h: Ditto.
- platform/graphics/MediaPlayer.cpp: Ditto.
- platform/graphics/MediaPlayer.h: Ditto.
- platform/graphics/MediaPlayerPrivate.h: Ditto.
- platform/mac/PlatformClockCA.cpp: Ditto.
- platform/mac/PlatformClockCA.h: Ditto.
- platform/mac/PlatformClockCM.h: Ditto.
- platform/mac/PlatformClockCM.mm: Ditto.
- 9:16 AM Changeset in webkit [148098] by
-
- 3 edits in trunk/Source/WebCore
Replace ENABLE_MICRODATA preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114349
Reviewed by Geoffrey Garen.
The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
- dom/Document.idl:
- html/HTMLElement.idl:
- 9:13 AM Changeset in webkit [148097] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r148034): IconDatabase::updateIconRecord crashes with null iconData and iconBitmap.
https://bugs.webkit.org/show_bug.cgi?id=114356
Reviewed by Tim Horton.
When loading an icon fails (for example, when a non-existent URI is
passed to the loader), updateIconRecord can be called with both
iconData and iconBitmap having no data.
This used to be fine before r148034, but causes an assertion now.
No new tests, existing tests such as fast/encoding/mispositioned-meta.html
were crashing.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::updateIconRecord): Change the ASSERT() to check
for a NAND condition that only fails if both iconData and iconBitmap
are not 0.
- 8:44 AM Changeset in webkit [148096] by
-
- 2 edits in trunk/Tools
Removed an annoying message from svn-create-patch
https://bugs.webkit.org/show_bug.cgi?id=114332
Reviewed by Alexey Proskuryakov.
I see this message basically every time I write a patch, so it must not
be true.
- Scripts/svn-create-patch:
(generateDiff):
- 8:10 AM Changeset in webkit [148095] by
-
- 5 edits in trunk/Source/WebKit/qt
[Qt] Add API in QWebSettings for setting the CSS media type
https://bugs.webkit.org/show_bug.cgi?id=113853
Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-04-10
Reviewed by Jocelyn Turcotte.
- Api/qwebsettings.cpp:
(QWebSettingsPrivate):
(QWebSettingsPrivate::apply):
(QWebSettings::setCSSMediaType):
(QWebSettings::cssMediaType):
- Api/qwebsettings.h:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::overrideMediaType):
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage):
(tst_QWebPage::cssMediaTypeGlobalSetting):
(tst_QWebPage::cssMediaTypePageSetting):
- 7:58 AM Changeset in webkit [148094] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] Update a dirty region which is not covered with keepRect.
https://bugs.webkit.org/show_bug.cgi?id=113752
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2013-04-10
Reviewed by Jocelyn Turcotte.
There can be a dirty region which is not covered with keepRect.
However the dirty could be inside the tile area. In this case,
currently we ignore the dirty by intersecting with keepRect
and the dirty region will not be invalidated until the tile is
recreated. We must expand the keep rect to its intersecting tiles
to make sure that the dirty region is applied to existing tiles.
No tests needed, change is unobservable.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::invalidate):
- 7:36 AM Changeset in webkit [148093] by
-
- 4 edits in trunk/Source
Remove ENABLE_3D_PLUGIN
https://bugs.webkit.org/show_bug.cgi?id=108002
Source/WebCore:
Remove ENABLE_3D_PLUGIN, it was only used by Chromium.
Reviewed by Antti Koivisto.
No new tests, removing dead code.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadPlugin):
Source/WTF:
Reviewed by Antti Koivisto.
Remove ENABLE_3D_PLUGIN, it was only used by Chromium.
- wtf/FeatureDefines.h:
- 6:47 AM Changeset in webkit [148092] by
-
- 1 edit57 adds in trunk/LayoutTests
[CSS Regions] Add tests for lists and counters
https://bugs.webkit.org/show_bug.cgi?id=103975
Reviewed by Antti Koivisto.
Lists and counters work correctly with regions since r148026 (http://trac.webkit.org/changeset/148026).
This patch adds W3C formatted ref tests to our battery.
- fast/regions/counters/extract-list-items-001-expected.html: Added.
- fast/regions/counters/extract-list-items-001.html: Added.
- fast/regions/counters/extract-list-items-002-expected.html: Added.
- fast/regions/counters/extract-list-items-002.html: Added.
- fast/regions/counters/extract-list-items-003-expected.html: Added.
- fast/regions/counters/extract-list-items-003.html: Added.
- fast/regions/counters/extract-list-items-004-expected.html: Added.
- fast/regions/counters/extract-list-items-004.html: Added.
- fast/regions/counters/extract-list-items-005-expected.html: Added.
- fast/regions/counters/extract-list-items-005.html: Added.
- fast/regions/counters/extract-list-items-006-expected.html: Added.
- fast/regions/counters/extract-list-items-006.html: Added.
- fast/regions/counters/extract-list-items-007-expected.html: Added.
- fast/regions/counters/extract-list-items-007.html: Added.
- fast/regions/counters/extract-list-items-008-expected.html: Added.
- fast/regions/counters/extract-list-items-008.html: Added.
- fast/regions/counters/extract-list-items-009-expected.html: Added.
- fast/regions/counters/extract-list-items-009.html: Added.
- fast/regions/counters/extract-list-items-010-expected.html: Added.
- fast/regions/counters/extract-list-items-010.html: Added.
- fast/regions/counters/extract-list-items-011-expected.html: Added.
- fast/regions/counters/extract-list-items-011.html: Added.
- fast/regions/counters/extract-list-items-012-expected.html: Added.
- fast/regions/counters/extract-list-items-012.html: Added.
- fast/regions/counters/extract-list-items-013-expected.html: Added.
- fast/regions/counters/extract-list-items-013.html: Added.
- fast/regions/counters/extract-list-items-014-expected.html: Added.
- fast/regions/counters/extract-list-items-014.html: Added.
- fast/regions/counters/extract-list-items-015-expected.html: Added.
- fast/regions/counters/extract-list-items-015.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-expected.html: Added.
- fast/regions/counters/extract-numbered-paragraphs.html: Added.
- fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Added.
- fast/regions/counters/extract-numbered-spans-display-only-some.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-001.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-002.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-003.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Added.
- fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Added.
- fast/regions/counters/extract-unordered-lists-in-regions.html: Added.
- 5:18 AM Changeset in webkit [148091] by
-
- 10 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening. Rebaselining after r148049.
- platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
- 4:48 AM Changeset in webkit [148090] by
-
- 6 edits4 adds in trunk
[Texmap] Hierarchy of layers with opacity may result in wrong blending.
https://bugs.webkit.org/show_bug.cgi?id=113732
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-10
Reviewed by Allan Sandfeld Jensen.
Source/WebCore:
This is a combination of three issues with nested intermediate surfaces:
- glScissor inside an intermediate surface should not be mirrored.
- The current surface should be passed to the next surface in paintOptions.
- When clipping for the non-overlap region, the containing surface offset
should be applied.
Though the changes are separate, they cannot be tested separately as neither
fixes a testable case on its own.
Tests: compositing/overlap-blending/nested-non-overlap-clipping.html
compositing/overlap-blending/nested-overlap.html
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::ClipStack::reset):
(WebCore::TextureMapperGL::ClipStack::apply):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::clearIfNeeded):
- platform/graphics/texmap/TextureMapperGL.h:
(ClipStack):
Do not mirror the scissor clip when painting to an FBO.
Also a minor refactor to avoid reading the viewport values from the driver.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
Apply the offset when clipping for a non-overlap region.
(WebCore::TextureMapperLayer::paintIntoSurface):
Make sure the current surface is passed to the next one.
LayoutTests:
Added two ref-tests for nested composited overlaps.
This ref-test does not work on Mac due to a slight mismatch opacity value on CoreAnimation.
A new bug has been posted, and TestExpectations has been updated.
- compositing/overlap-blending/nested-non-overlap-clipping-expected.html: Added.
- compositing/overlap-blending/nested-non-overlap-clipping.html: Added.
- compositing/overlap-blending/nested-overlap-expected.html: Added.
- compositing/overlap-blending/nested-overlap.html: Added.
- platform/mac/TestExpectations: Skipped new tests and created bug.
- 4:34 AM Changeset in webkit [148089] by
-
- 19 edits2 copies2 adds in trunk
Create fewer tiles when page is loading
https://bugs.webkit.org/show_bug.cgi?id=114294
Source/WebCore:
Reviewed by Anders Carlsson.
We currently create speculative tiles immediately. Page is often changing rapidly during loading and
keeping the speculative tiles up to date creates extra work.
Tests: platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html
platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadProgressingStatusChanged):
- page/FrameView.cpp:
(WebCore::FrameView::adjustTiledBackingCoverage):
(WebCore::FrameView::setWasScrolledByUser):
User scrolling enables speculative tiling no matter what the load status.
- page/FrameView.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::computeTileCoverage):
(WebCore::RenderLayerBacking::adjustTiledBackingCoverage):
Cover only the viewport during loading.
LayoutTests:
Reviewed by Anders Carlsson.
Reduced initial tile counts and new tests for speculative tiles.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html: Added.
- platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-speculative-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html: Added.
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
- platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
- 3:48 AM Changeset in webkit [148088] by
-
- 14 edits in trunk
[GTK] Add support for Page Visibility
https://bugs.webkit.org/show_bug.cgi?id=97324
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-04-10
Reviewed by Sam Weinig.
.:
Page Visibility has been enabled for GTK port.
New GTK unittest has been added.
- Source/autotools/SetupWebKitFeatures.m4:
Source/WebKit/gtk:
Implemented access to page visibility API for GTK test runner.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setPageVisibility):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
Source/WebKit2:
Added new unittest to test page visibility using GTK Widget visibility API.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewPageVisibility):
(beforeAll):
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::showInWindow):
- UIProcess/API/gtk/tests/WebViewTest.h:
Tools:
Implemented test runner API for page visibility layout tests.
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
- platform/gtk/TestExpectations:
- 2:47 AM Changeset in webkit [148087] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] RenderThemeBlackBerry: get rid of all the SKIA code
https://bugs.webkit.org/show_bug.cgi?id=114339
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-10
Reviewed by Carlos Garcia Campos.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderThumb):
- 2:17 AM Changeset in webkit [148086] by
-
- 2 edits in trunk/Tools
[ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
https://bugs.webkit.org/show_bug.cgi?id=114342
Reviewed by Gyuyoung Kim.
Commit 148033 only added an implementation for the Mac port, which made
other ports fail most tests since loading the injected bundle failed
with a missing symbol.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::pathDescription):
- 2:06 AM Changeset in webkit [148085] by
-
- 9 edits1 move1 add1 delete in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining after r148049.
- platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt: Removed.
- platform/qt/compositing/iframes/page-cache-layer-tree-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/iframes/page-cache-layer-tree-expected.txt.
- platform/qt/fast/multicol/shadow-breaking-expected.txt:
- platform/qt/svg/css/composite-shadow-text-expected.png:
- platform/qt/svg/css/composite-shadow-text-expected.txt:
- platform/qt/svg/css/group-with-shadow-expected.txt:
- platform/qt/svg/css/path-with-shadow-expected.txt:
- platform/qt/svg/css/shadow-and-opacity-expected.txt:
- platform/qt/svg/css/shadow-breaking-expected.png: Added.
- platform/qt/svg/css/text-shadow-multiple-expected.txt:
- platform/qt/transitions/svg-text-shadow-transition-expected.txt:
- 12:55 AM Changeset in webkit [148084] by
-
- 2 edits in trunk/Tools
[EFL] Add spell checking option to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=114282
Patch by Artur Moryc <a.moryc@samsung.com> on 2013-04-10
Reviewed by Ryosuke Niwa.
Spell checking is enabled by adding a flag (t/text-checking)
with launching MiniBrowser.
- MiniBrowser/efl/main.c:
(window_create):
(elm_main):
- 12:39 AM Changeset in webkit [148083] by
-
- 5 edits in trunk
REGRESSION (r146518): WebKit2APITests/TestInspector is failing
https://bugs.webkit.org/show_bug.cgi?id=113281
Reviewed by Darin Adler.
Source/WebKit2:
Changes to the WebInspectorProxy opening processing in r146518 caused the change in how the GTK-specific
WebInspectorProxy code operates, specifically the 'bring-to-front' signal is not emitted anymore when opening the
inspector due to the WebInspectorProxy::bringToFront method now only bringing the inspector window to front if it exists
and opening it (and thus unable to bring it to front) otherwise.
Closing of the inspector through the didClose method is now done immediately after sending the WebInspector::Close()
message to the WebProcess rather than waiting for the WebProcess to communicate back the order of closing. Due to this
the relevant code in the test cases had to be changed to not run the loop but rather just check that the closing was
successful.
(InspectorTest::InspectorTest): Remove the initialization of the now redundant m_quitOnBringToFront member variable.
(InspectorTest::bringToFront): Quit the loop without checking the removed member variable.
(InspectorTest::closed): Do not quit the loop as it is not run anymore.
(InspectorTest::showIdle): A helper method that asynchronously calls the webkit_web_inspector_show method, removing some
unnecessary complexity about under what exact circumstances to quit the loop in open-window/bring-to-front callbacks.
(InspectorTest::show): Replaces the showAndWaitUntilFinished method, adding an idle invocation of the showIdle helper
method and running the loop.
(InspectorTest::close): Formerly closeAndWaitUntilClosed, now does not run the loop anymore as there's no need for it.
(testInspectorDefault): Only the window opening event is now expected upon showing the inspector for the first time.
Adjusting callsites to use InspectorTest::show and InspectorTest::close instead of
InspectorTest::showAndWaitUntilFinished and InspectorTest::showAndWaitUntilFinished.
(CustomInspectorTest::destroyWindow): Formerly destroyWindowAndWaitUntilClosed, the closing is not asynchronous anymore
so the loop is not run.
(testInspectorManualAttachDetach): Only the window opening event is now expected upon showing the inspector for the first time.
Adjusting callsites to use InspectorTest::show and InspectorTest::close instead of
InspectorTest::showAndWaitUntilFinished and InspectorTest::showAndWaitUntilFinished.
(testInspectorCustomContainerDestroyed): Adjusting callsites to use InspectorTest::show and CustomInspectorTest::destroyWindow
instead of InspectorTest::showAndWaitUntilFinished and CustomInspectorTest::destroyWindowAndWaitUntilClosed.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::show): When showing a connected WebInspectorProxy, call the bringToFront method which will
open the inspector if it's not yet visible or bring it to the front otherwise.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
- 12:38 AM Changeset in webkit [148082] by
-
- 3 edits in trunk/Source/WebKit2
[GTK][WK2] Implement WebInspectorProxy::platformInspectedWindowWidth
https://bugs.webkit.org/show_bug.cgi?id=113498
Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-04-10
Reviewed by Martin Robinson.
The method was introduced in r147004.
- UIProcess/API/gtk/tests/TestInspector.cpp: Specify the gMinimumAttachedInspectorWidth variable, reflecting the value
of WebInspectorProxy::minimumAttachedWidth. Use it as the width to which the inspected view should be resized in
InspectorTest::resizeViewAndAttach.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformInspectedWindowHeight): Use the gtk_widget_get_allocated_height method to return the
widget height.
(WebKit::WebInspectorProxy::platformInspectedWindowWidth): Newly implemented, similarly uses the
gtk_widget_get_allocated_width method to return the widget width.
- 12:36 AM Changeset in webkit [148081] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r147719): Failures in two a11y tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=114259
Reviewed by Ryosuke Niwa.
No new tests - covered by existing tests.
Partially revert r147719, restoring the possible creation of the AXObject cache
and the subsequent call to its handleFocusedUIElementChanged method. Removing this
code caused regressions in accessibility tests on the GTK port, so the comment about
the AXObject cache is adjusted accordingly.
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
- 12:18 AM Changeset in webkit [148080] by
-
- 11 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r148049.
- platform/gtk/fast/multicol/shadow-breaking-expected.txt:
- platform/gtk/svg/css/composite-shadow-text-expected.txt:
- platform/gtk/svg/css/group-with-shadow-expected.txt:
- platform/gtk/svg/css/path-with-shadow-expected.txt:
- platform/gtk/svg/css/shadow-and-opacity-expected.txt:
- platform/gtk/svg/css/shadow-changes-expected.txt:
- platform/gtk/svg/css/text-gradient-shadow-expected.txt:
- platform/gtk/svg/css/text-shadow-multiple-expected.txt:
- platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt:
- platform/gtk/transitions/svg-text-shadow-transition-expected.txt:
Apr 9, 2013:
- 11:59 PM Changeset in webkit [148079] by
-
- 3 edits3 adds in trunk
[GStreamer] playbin uri getter is invalid
https://bugs.webkit.org/show_bug.cgi?id=113884
Reviewed by Martin Robinson.
Source/WebCore:
When loading a new media location use the url stored as a member
variable instead of the one stored as a playbin property. The uri
property semantic changed in playbin since 0.10.36+. One should
now use current-uri but to avoid ifdefs depending on GStreamer
version we simply use the url already known as member variable.
Test: http/tests/media/video-redirect.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
LayoutTests:
New test for Quicktime reference movie redirect
support.
- http/tests/media/resources/redirect-to-counting-captioned.mov: Added.
- http/tests/media/video-redirect-expected.txt: Added.
- http/tests/media/video-redirect.html: Added.
- 11:45 PM Changeset in webkit [148078] by
-
- 2 edits in trunk/Source/WebKit2
WKFrameIsDisplayingMarkupDocument should return true for Web Archives
https://bugs.webkit.org/show_bug.cgi?id=114291
Reviewed by Dean Jackson.
Also return true for the Web Archive MIME type since a Web Archive
is displaying a markup document by nature.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::isDisplayingMarkupDocument):
- 10:21 PM Changeset in webkit [148077] by
-
- 2 edits in trunk/Tools
Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
Unreviewed.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_build_check):
- 10:12 PM Changeset in webkit [148076] by
-
- 12 edits in trunk
[JSC] Script run from an isolated world should bypass a page's CSP
https://bugs.webkit.org/show_bug.cgi?id=100815
Reviewed by Oliver Hunt.
Source/WebCore:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
- bindings/js/ScriptController.h: Test the current caller's DOM wrapper
world to decide whether CSP should be enforced.
Like most of CSP, this is a stupid policy because it doesn't address
second-order effects like <script> parsing or event handler execution,
which might be triggered indirectly by privileged scripts. These indirect
effects are still broken. Oh well.
LayoutTests:
Enabled these tests, now that they pass.
I removed all the nonsense in these tests about setting an isolated world's
CSP and origin manually, since we have no use for those features.
- http/tests/security/isolatedWorld/bypass-main-world-csp-expected.txt:
- http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr-expected.txt:
- http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr.html:
- http/tests/security/isolatedWorld/bypass-main-world-csp.html:
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 9:59 PM Changeset in webkit [148075] by
-
- 11 edits11 deletes in trunk/Tools
[webkitpy] Remove chromium ports.
https://bugs.webkit.org/show_bug.cgi?id=114326
Reviewed by Dirk Pranke.
As a side effect, also:
- remove chromium builders from webkitpy.layout_tests.port.builders
- remove chromium builders from rebaseline
- rewrite chromium dependent tests in rebaseline_unittest
- remove chromium platform from garden-o-matic
- select apple platform as default platform in garden-o-matic
- remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_move_baselines):
(BaselineOptimizerTest.test_efl):
(BaselineOptimizerTest.test_no_add_mac_future):
(BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_complex_shadowing):
(BaselineOptimizerTest.test_virtual_ports_filtered):
- Scripts/webkitpy/layout_tests/port/builders.py:
- Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/factory.py:
(platform_options):
(PortFactory):
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_qt):
(FactoryTest.test_get_from_builder_name):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_build_check):
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_expectations_path):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(Rebaseline._builders_to_pull_from):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(_BaseTestCase):
(_BaseTestCase.setUp):
(TestRebaselineTest.setUp):
(TestRebaselineTest.test_baseline_directory):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test):
(test_rebaseline_test_and_print_scm_changes):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
(TestRebaselineExpectations.test_rebaseline_expectations):
- 6:59 PM Changeset in webkit [148074] by
-
- 2 edits in trunk/Source/WebCore
Remove chromium exceptions from WebCore's gitattributes
https://bugs.webkit.org/show_bug.cgi?id=114327
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09
Reviewed by Darin Adler.
- .gitattributes:
- 6:23 PM Changeset in webkit [148073] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add liveness tests to JSC API entry points
https://bugs.webkit.org/show_bug.cgi?id=114318
Reviewed by Geoffrey Garen.
Add simple checks for the existence of a method table on any
JSCells passed across the API. This in turn forces a structure
validity test.
- API/APICast.h:
(toJS):
(toJSForGC):
(unsafeToJS):
- API/JSObjectRef.cpp:
(JSObjectGetPrivate):
- 6:11 PM Changeset in webkit [148072] by
-
- 3 edits2 adds in trunk
Update Document's event listener type bitfield when adopting a Node
https://bugs.webkit.org/show_bug.cgi?id=114322
Reviewed by Darin Adler.
Source/WebCore:
Without this, moving a Node between documents can silently deactivate
an event listener, if it's one of the types that whose creation is
optimized away by Document::hasListenerType.
An alternate approach would be to simply copy the old document's
bitfield over. It's a tradeoff between making adoption fast and making
the operation of any operation depending on these event types fast.
The latter seems like the right optimization given that adoption
doesn't happen very often.
Test: fast/events/event-listener-moving-documents.html
- dom/Node.cpp:
(WebCore::Node::didMoveToNewDocument): For each event listener type on the adopted node, update the new document's list of listener types.
LayoutTests:
- fast/events/event-listener-moving-documents-expected.txt: Added.
- fast/events/event-listener-moving-documents.html: Added.
- 5:57 PM Changeset in webkit [148071] by
-
- 5 edits in trunk/Source/WebCore
Add logging channel for animations
https://bugs.webkit.org/show_bug.cgi?id=114325
Reviewed by Simon Fraser.
- platform/Logging.cpp: Add LogAnimations.
(WebCore::getChannelFromName): Return LogAnimations for "Animations".
- platform/Logging.h: Add LogAnimations.
- platform/mac/LoggingMac.mm:
(WebCore::initializeLoggingChannelsIfNecessary): Copy preference.
- platform/win/LoggingWin.cpp:
(WebCore::initializeLoggingChannelsIfNecessary): Copy preference.
- 5:32 PM Changeset in webkit [148070] by
-
- 18 edits9 adds in trunk
[CSS3] Parsing the property, text-justify.
https://bugs.webkit.org/show_bug.cgi?id=100058
Reviewed by Andreas Kling.
This patch implements the parsing side of the "text-justify" property specified
in CSS3 working draft, with "-webkit-" prefix, under ENABLE_CSS3_TEXT flag.
Specification link : http://www.w3.org/TR/css3-text/#text-justify
Source/WebCore:
Tests: fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html
fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextJustify):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StylePropertySet.cpp:
(WebCore):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
LayoutTests:
- fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-expected.txt: Added.
- fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited-expected.txt: Added.
- fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html: Added.
- fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html: Added.
- fast/css3-text/css3-text-justify/getComputedStyle/script-tests/getComputedStyle-text-justify-inherited.js: Added.
(testComputedStyle):
(ownValueTest):
(inheritanceTest):
- fast/css3-text/css3-text-justify/getComputedStyle/script-tests/getComputedStyle-text-justify.js: Added.
(testElementStyle):
(testComputedStyle):
(valueSettingTest):
(invalidValueSettingTest):
- platform/mac/TestExpectations: ditto
- platform/qt-4.8/TestExpectations: ditto
- platform/qt-mac/TestExpectations: ditto
- platform/qt/TestExpectations: ditto
- 5:17 PM Changeset in webkit [148069] by
-
- 3 edits in trunk/Source/WebCore
[GTK][AC] Adding contentsLayer for image and video
https://bugs.webkit.org/show_bug.cgi?id=113912
Reviewed by Gustavo Noronha Silva.
contentsLayer is a ClutterActor, which is added to the main layer
as a child when GraphicsLayer needs to render an image or video.
No new tests, already covered by existing AC tests.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorUpdateTexture):
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore):
(WebCore::GraphicsLayerClutter::setContentsToImage): Pass a Cairo surface to GraphicsLayer.
(WebCore::GraphicsLayerClutter::setContentsNeedsDisplay):
(WebCore::GraphicsLayerClutter::setContentsRect):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::setupContentsLayer):
(WebCore::GraphicsLayerClutter::updateContentsImage): Set the Cairo surface for contentsLayer
to upload it as a texture.
(WebCore::GraphicsLayerClutter::updateContentsNeedsDisplay):
(WebCore::GraphicsLayerClutter::updateContentsRect):
(WebCore::GraphicsLayerClutter::updateSublayerList):
- platform/graphics/clutter/GraphicsLayerClutter.h:
(WebCore::GraphicsLayerClutter::hasContentsLayer):
(GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::contentsLayer):
- 5:04 PM Changeset in webkit [148068] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION: Blob URLs broken with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=114320
Reviewed by Brady Eidson.
Update BlobResourceHandle to use modern resource client calls.
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::readSync): Don't call notifyReceiveData if there is no data (it's especially egregious when length is -1, signaling an error). (WebCore::BlobResourceHandle::notifyResponseOnSuccess): Use didReceiveResponseAsync when a client wants async callbacks. This is not very clean, as we don't wait for response, but should be workable for blobs. (WebCore::BlobResourceHandle::notifyResponseOnError): Ditto. (WebCore::BlobResourceHandle::notifyReceiveData): Use didReceiveBuffer (clients that only implement didReceiveData will have it automatically unwrapped).
- 5:03 PM Changeset in webkit [148067] by
-
- 2 edits in trunk/Source/JavaScriptCore
Rollout last patch as it destroyed everything
- 5:00 PM Changeset in webkit [148066] by
-
- 2 edits in trunk/LayoutTests
r148048 revealed that compositing/plugins/invalidate_rect.html was
only succeeded through chance, and cannot work as designed because
plugin painting is async on some platforms. Mark it as flakey.
- platform/mac/TestExpectations:
- 4:57 PM Changeset in webkit [148065] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r123837): Full screen transition is broken at apple.com
https://bugs.webkit.org/show_bug.cgi?id=95650
Reviewed by Simon Fraser.
Cancel any outstanding animations on <video> elements as they enter full screen, so as to
not confuse the WebKit/WebKit2 full screen window animation about the starting and destination
screen rects.
- css/fullscreen.css:
(video:-webkit-full-screen, audio:-webkit-full-screen):
- 4:52 PM Changeset in webkit [148064] by
-
- 3 edits in trunk/Source/WebCore
hang in mediaSelectionGroupForMediaCharacteristic
https://bugs.webkit.org/show_bug.cgi?id=114054
Reviewed by Eric Carlson.
No new tests; Fixes sporadic hangs in media/ tests.
-[AVURLAsset mediaSelectionGroupForMediaCharacteristic:] can deadlock in certain situations: When AVURLAsset
posts a synchronous AVAssetResourceLoader notification to the main thread, calling -mediaSelectionGroupForMediaCharacteristic:
on the main thread requires IO to occur if the media characteristics are not yet loaded. Instead of blocking,
bail out early if the media characteristics are not yet known.
Add a new method, safeMediaSelectionGroupForLegibleMedia(), which first checks selection group availability
before calling mediaSelectionGroupForMediaCharacteristic:.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
(MediaPlayerPrivateAVFoundationObjC):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForLegibleMedia): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Use new safe method.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Ditto.
- 4:29 PM Changeset in webkit [148063] by
-
- 3 edits in trunk/Source/WebCore
AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Unreviewed build fix for iOS.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityPath]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
- 4:28 PM Changeset in webkit [148062] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add liveness tests to JSC API entry points
https://bugs.webkit.org/show_bug.cgi?id=114318
Reviewed by Filip Pizlo.
Add simple checks for the existence of a method table on any
JSCells passed across the API. This in turn forces a structure
validity test.
- API/APICast.h:
(toJS):
(toJSForGC):
- 4:22 PM Changeset in webkit [148061] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed correctness fix: use lroundf instead of lround for a float to int conversion.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):
- 4:04 PM Changeset in webkit [148060] by
-
- 2 edits in trunk/Source/WebCore
Change requisite hardware checks for enabling antialiasing.
https://bugs.webkit.org/show_bug.cgi?id=114101
<rdar://problem/12342776>.
m_maySupportMultisampling should be true by default for all platforms/hardware now except older versions of AMD.
Reviewed by Dean Jackson.
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):
- 3:55 PM Changeset in webkit [148059] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r148010.
http://trac.webkit.org/changeset/148010
https://bugs.webkit.org/show_bug.cgi?id=114310
Causes problems with focus rings (Requested by anttik on
#webkit).
Source/WebCore:
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyComputeLength::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
LayoutTests:
- fast/borders/border-width-less-then-a-unit-of-pt-expected.html: Removed.
- fast/borders/border-width-less-then-a-unit-of-pt.html: Removed.
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- 3:52 PM Changeset in webkit [148058] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, another fix for the Windows build after r148050.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::setFontSize): Use lround().
- 3:37 PM Changeset in webkit [148057] by
-
- 4 edits in trunk/LayoutTests
Rebaseline tests affected by r148049 or r148048.
- compositing/layer-creation/rotate3d-overlap-expected.txt:
- compositing/repaint/resize-repaint-expected.txt:
- compositing/repaint/resize-repaint.html: Allow the test to run
outside WTR/DRT.
- 3:31 PM Changeset in webkit [148056] by
-
- 5 edits2 adds in trunk
[CSS Exclusions] Properly position multiple stacked floats with non rectangular shape outside
https://bugs.webkit.org/show_bug.cgi?id=110372
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-04-09
Reviewed by Dean Jackson.
Source/WebCore:
Stacked floats get positioned based on the bounding box of the shape,
not on the shape contours itself. This patch causes that to happen.
Test: fast/exclusions/shape-outside-floats/shape-outside-floats-stacked.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat): Use the
"BoundingBoxOffset" mode so that we compute offsets based on the shape
bounding boxes of previous floats, not the shape contour.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Check the
ShapeOutsideFloatOffsetMode to determine if the offset should be
adjusted for the shape contour or not.
(WebCore::RenderBlock::logicalRightOffsetForLine): Ditto.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForLine): Add parameter for offset mode.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Ditto.
(RenderBlock):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): If the
new float is being added on top of a previous float on the same line,
undo the offset for the previous float's shape contour so that we
position the new float based on the bounding box.
LayoutTests:
Tests demonstrating stacked floats properly working with shape-outside.
- fast/exclusions/shape-outside-floats/shape-outside-floats-stacked-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-stacked.html: Added.
- 3:02 PM Changeset in webkit [148055] by
-
- 2 edits in trunk/Tools
newcommitbot (WKR) requires a subversion checkout
https://bugs.webkit.org/show_bug.cgi?id=114309
Reviewed by Benjamin Poulain.
Directly talk to the subversion server instead of relying on a local checkout.
This allows us to run WKR off of a git clone.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):
(NewCommitBot.process_work_item):
- 2:35 PM Changeset in webkit [148054] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r147454): Youtube annotation links to new window broken
https://bugs.webkit.org/show_bug.cgi?id=114242
<rdar://problem/13609940>
Reviewed by Beth Dakin.
Set the current user gesture to "DefinitelyProcessingNewUserGesture" if popups are allowed.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performFrameLoadURLRequest):
- 2:30 PM Changeset in webkit [148053] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix the Windows build after r148050.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Use lround().
- 2:28 PM Changeset in webkit [148052] by
-
- 2 edits in trunk/Source/WebCore
[wk2] IconDatabase images should be decoded in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=112524
<rdar://problem/10133914>
Reviewed by Simon Fraser.
Move an ASSERT that dereferenced a pointer inside the null-check for that pointer.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::setIconBitmapForIconURL):
- 2:25 PM Changeset in webkit [148051] by
-
- 4 edits in trunk/Tools
webkitbot refers to sheriffbot in help
https://bugs.webkit.org/show_bug.cgi?id=114307
Reviewed by Benjamin Poulain.
Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Help):
(Help.execute):
(RollChromiumDEPS.execute):
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help):
- Scripts/webkitpy/tool/bot/sheriff.py:
(Sheriff.name):
- 1:56 PM Changeset in webkit [148050] by
-
- 24 edits2 adds in trunk
[Mac] user caption styles not applied to correct element
https://bugs.webkit.org/show_bug.cgi?id=114230
Reviewed by Jer Noble.
Source/WebCore:
Test: media/track/track-css-user-override.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Drive by clean-up so we don't log excessively.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement): Initialize
new member variables.
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Set cue font size when it is
inserted into the tree.
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Update the font size of
all active cues.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Set size-relative CSS properties
after a time because this can be called during layout.
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::textTrackPreferencesChanged): Call closedCaptionTracksChanged before updateSizes.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::setFontSize): New, set the cue's font size.
- html/track/TextTrackCue.h:
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): Set cue properties on the cue element
instead of on the cue box to match what we do for the "cue" pseudo element.
(WebCore::TextTrackCueGeneric::setFontSize): New, set the cue's font size.
- html/track/TextTrackCueGeneric.h:
- html/track/TextTrackList.cpp:
(TextTrackList::remove): Drive-by cleanup, don't ASSERT when the media element is NULL.
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::setCaptionsStyleSheetOverride): New, allow user CSS overrides
to be tested in DRT.
(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride): New, generate a user style
sheet override. Moved here from CaptionUserPreferencesMac.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS): Don't ignore background color importance.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Implement even when we don't
have the media accessibility framework so this can be tested in DRT. Apply all cue properties
to the element used for the "cue" pseudo element.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::didLoadingProgress): Drive-by cleanup, remove logging
because this method is called so frequently and the logging is not especially useful.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Only log when the ready/network
state changes because this method is called so frequently.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer): Drive-by cleanup, remove logging
because this method is called so frequently and the logging is not especially useful.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Make the logging more useful.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Reset captions style sheet override.
(WebCore::Internals::captionsStyleSheetOverride): New, return the captions style sheet override.
(WebCore::Internals::setCaptionsStyleSheetOverride): New, override the captions style sheet override.
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- media/track/track-css-user-override-expected.txt: Added.
- media/track/track-css-user-override.html: Added.
- media/track/track-cue-container-rendering-position-expected.txt:
- media/track/track-cue-container-rendering-position.html:
- media/track/track-cue-rendering-expected.txt:
- media/track/track-cue-rendering.html: Font size is not applied instantly when a video element is
resized, so check after a very short delay.
- 1:52 PM Changeset in webkit [148049] by
-
- 66 edits2 adds in trunk
Repaint rect too small on elements with shadows
https://bugs.webkit.org/show_bug.cgi?id=114225
Source/WebCore:
Reviewed by Dain Adler.
We assumed that shadows (box-shadow, text-shadow, svg shadows)
only required inflating the repaint rect by the blur radius of
the shadow. However, this is incorrect; the shadow can extend
further, which resulted in clipped or incorrectly invalidated
shadows.
Fix by disambiguating the blur radius (which is 2x the standard
deviation of the Gaussian distribution used to generate the blur),
from the painting extent, which is how far the shadow visually
projects. Using a 1.4 multiplier of the blur radius is a good
approximation for the painting extent.
Renamed ShadowData::blur() to ShadowData::radius(), and added
ShadowData::paintingExtent(). Use the latter in all places
which relate to invalidation.
Test: fast/box-shadow/shadow-repaint.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::applyShadowToGraphicsContext):
(WebCore::InlineTextBox::paintDecoration):
- rendering/RenderBoxModelObject.cpp:
(WebCore::applyBoxShadowForBackground):
(WebCore::areaCastingShadowInHole):
(WebCore::RenderBoxModelObject::paintBoxShadow):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowInsetExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):
- rendering/style/ShadowData.cpp:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::operator==):
(WebCore::calculateShadowExtent):
- rendering/style/ShadowData.h:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::radius):
(WebCore::ShadowData::paintingExtent):
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
LayoutTests:
Reviewed by Darin Alder.
New test for invalidation with box-shadow. Update test results affected
by shadow extent.
- compositing/geometry/foreground-layer-expected.txt:
- compositing/iframes/composited-parent-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- compositing/iframes/connect-compositing-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe2-expected.txt:
- compositing/iframes/connect-compositing-iframe3-expected.txt:
- compositing/iframes/enter-compositing-iframe-expected.txt:
- compositing/iframes/iframe-resize-expected.txt:
- compositing/iframes/invisible-nested-iframe-show-expected.txt:
- compositing/iframes/overlapped-iframe-expected.txt:
- compositing/iframes/page-cache-layer-tree-expected.txt:
- compositing/iframes/scrolling-iframe-expected.txt:
- compositing/visible-rect/iframe-and-layers-expected.txt:
- fast/box-shadow/shadow-repaint-expected.txt: Added.
- fast/box-shadow/shadow-repaint.html: Added.
- platform/mac/fast/multicol/shadow-breaking-expected.png:
- platform/mac/fast/multicol/shadow-breaking-expected.txt:
- platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
- platform/mac/fast/repaint/moving-shadow-on-path-expected.png:
- platform/mac/fast/repaint/moving-shadow-on-path-expected.txt:
- platform/mac/svg/css/arrow-with-shadow-expected.png:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
- platform/mac/svg/css/clippath-with-shadow-expected.png:
- platform/mac/svg/css/composite-shadow-example-expected.png:
- platform/mac/svg/css/composite-shadow-example-expected.txt:
- platform/mac/svg/css/composite-shadow-text-expected.txt:
- platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
- platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
- platform/mac/svg/css/group-with-shadow-expected.png:
- platform/mac/svg/css/group-with-shadow-expected.txt:
- platform/mac/svg/css/mask-with-shadow-expected.png:
- platform/mac/svg/css/path-with-shadow-expected.png:
- platform/mac/svg/css/path-with-shadow-expected.txt:
- platform/mac/svg/css/shadow-and-opacity-expected.png:
- platform/mac/svg/css/shadow-and-opacity-expected.txt:
- platform/mac/svg/css/shadow-changes-expected.png:
- platform/mac/svg/css/shadow-changes-expected.txt:
- platform/mac/svg/css/shadow-with-large-radius-expected.png:
- platform/mac/svg/css/shadow-with-negative-offset-expected.png:
- platform/mac/svg/css/stars-with-shadow-expected.png:
- platform/mac/svg/css/stars-with-shadow-expected.txt:
- platform/mac/svg/css/text-gradient-shadow-expected.png:
- platform/mac/svg/css/text-gradient-shadow-expected.txt:
- platform/mac/svg/css/text-shadow-multiple-expected.png:
- platform/mac/svg/custom/repaint-shadow-expected.png:
- platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.txt:
- svg/css/arrow-with-shadow-expected.txt:
- svg/css/circle-in-mask-with-shadow-expected.txt:
- svg/css/clippath-with-shadow-expected.txt:
- svg/css/mask-with-shadow-expected.txt:
- svg/css/shadow-with-large-radius-expected.txt:
- svg/css/shadow-with-negative-offset-expected.txt:
- svg/css/text-shadow-multiple-expected.txt:
- svg/custom/repaint-shadow-expected.txt:
- svg/filters/shadow-on-rect-with-filter-expected.txt:
- svg/repaint/repaint-webkit-svg-shadow-container-expected.txt:
- 1:52 PM Changeset in webkit [148048] by
-
- 2 edits in trunk/Source/WebCore
window.internals.repaintRectsAsText() is hard to use because it doesn't force layout
https://bugs.webkit.org/show_bug.cgi?id=114219
Reviewed by Beth Dakin.
Force layout when setTracksRepaints() is set to true, to flush out any pending
repaints from a layout that hasn't happened yet. Also force layout in
trackedRepaintRectsAsText(), so that any pending layout happpens and thus
repaints.
- page/FrameView.cpp:
(WebCore::FrameView::setTracksRepaints):
(WebCore::FrameView::trackedRepaintRectsAsText):
- 1:48 PM Changeset in webkit [148047] by
-
- 10 edits2 adds in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should provide utilities for common OSR exit tasks
https://bugs.webkit.org/show_bug.cgi?id=114306
Reviewed by Mark Hahnenberg.
Just abstract out some things that the FTL will want to use as well.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler.h:
(OSRExitCompiler):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp: Added.
(DFG):
(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
- dfg/DFGOSRExitCompilerCommon.h: Added.
(DFG):
- 1:47 PM Changeset in webkit [148046] by
-
- 3 edits in trunk/Tools
Kill old processes between runs on WinEWS bots.
Temporarily disable tests to let bots catch up again.
- EWSTools/start-queue-win.sh:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 1:42 PM Changeset in webkit [148045] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLInt conditional branch compilation fault on MIPS.
https://bugs.webkit.org/show_bug.cgi?id=114264
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-04-09
Reviewed by Filip Pizlo.
Fix conditional branch compilation in LLInt offlineasm.
- offlineasm/mips.rb:
- 1:35 PM Changeset in webkit [148044] by
-
- 2 edits in trunk/Source/WebCore
AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Unreviewed build fix (again).
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
- 1:35 PM Changeset in webkit [148043] by
-
- 3 edits in trunk/Source/WebKit2
If we fail to decode a message name, pass the message length as the name
https://bugs.webkit.org/show_bug.cgi?id=114305
<rdar://problem/13605703>
Reviewed by Sam Weinig.
- Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::length):
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::processIncomingMessage):
- 1:18 PM Changeset in webkit [148042] by
-
- 2 edits in trunk/Source/WebCore
AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Unreviewed build fix.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(WebTransformCGPathToNSBezierPath):
- 1:06 PM Changeset in webkit [148041] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Main page is rendered at wrong large scale after back from any zooming article at read.thestar.com
https://bugs.webkit.org/show_bug.cgi?id=114296
Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
PR: 308655
We were relying on the load state Committed to reset m_userPerformedManualZoom
and m_userPerformedManualScroll; however, the main resources of the
articles on read.thestar.com were preloaded and the WebPage didn't get
any load state change callbacks when going back to the main page from
the articles. Therefore, m_userPerformedManualZoom had never been reset
in this case and we picked up the wrong scale when restoring the main page.
Rset m_userPerformedManualScroll and m_userPerformedManualScroll when
we are going back or forward.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::goBackOrForward):
- 12:56 PM Changeset in webkit [148040] by
-
- 2 edits in trunk/LayoutTests
Mark mouse-events-scaled-iframe.html as flaky
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09
- platform/mac-wk2/TestExpectations:
- 12:55 PM Changeset in webkit [148039] by
-
- 2 edits in trunk/Source/WebCore
AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Reviewed by Tim Horton.
Minor fix from review feedback.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
- 12:48 PM Changeset in webkit [148038] by
-
- 7 edits in trunk/Source/WebKit2
Don't create another plugin process for restarted plugins
https://bugs.webkit.org/show_bug.cgi?id=114233
Reviewed by Geoff Garen.
A snapshotting plugin starts in a separate process from
regular plugins. This can be a little confusing to users
because they might see two plugin processes. We can set
the minimum life and timeout on the snapshotting process
to much smaller values, since the process doesn't need
to live that long. This will reduce some potential
confusion. Also, since there is another plugin process
running real plugins, it should be paged in if it needs
to restart.
There was, however, a bug in the process management. A
restarted plugin received a special PluginProcess::Type,
so that it could cross fade into the page nicely. This
caused it to start a *third* plugin process. Instead
mark a restarted flag directly on the PluginProxy and
revert back to two process types.
- PluginProcess/PluginProcess.h: Remove TypeRestartedProcess.
- UIProcess/Plugins/PluginProcessProxy.cpp: Add two new
timeout values for snapshotting processes.
(WebKit::PluginProcessProxy::didFinishLaunching): Chose which
of the timeout pairs to use.
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::PluginProxy::pluginLayer): Don't look at the process type, instead
look at the process flag to see if we are restarted.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::create): Copy the new flag into constructor.
(WebKit::PluginProxy::PluginProxy): Remember the flag.
- WebProcess/Plugins/PluginProxy.h: Add a new m_restartedProcess flag.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): When we are creating the proxy, separate
the concept of snapshotting and restarting.
- 12:18 PM Changeset in webkit [148037] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should better abstract floating point arguments
https://bugs.webkit.org/show_bug.cgi?id=114300
Reviewed by Mark Hahnenberg.
- dfg/DFGFPRInfo.h:
(FPRInfo):
(JSC::DFG::FPRInfo::toArgumentRegister):
- 12:16 PM Changeset in webkit [148036] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSObject::getOwnNonIndexPropertyNames calculates numCacheableSlots incorrectly
https://bugs.webkit.org/show_bug.cgi?id=114235
Reviewed by Geoffrey Garen.
Due to the way that numCacheableSlots is currently calculated, checking an object's prototype for enumerable
properties causes us not to cache any properties at all. We should only cache properties on the object itself
since we currently don't take advantage of any sort of name caching for properties in the prototype chain.
This fix undoes a ~2% SunSpider regression caused by http://trac.webkit.org/changeset/147570.
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnNonIndexPropertyNames):
- 12:10 PM Changeset in webkit [148035] by
-
- 4 edits in trunk/Tools
[webkitpy] Remove chromium deprecated port support.
https://bugs.webkit.org/show_bug.cgi?id=114228
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
(ChromiumPort): Removed.
(ChromiumAndroidPort): Removed.
(ChromiumXVFBPort): Removed.
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_chromium_port): Removed.
(DeprecatedPortTest.test_chromium_android_port): Removed.
(DeprecatedPortTest.test_chromium_xvfb_port): Removed.
- Scripts/webkitpy/tool/steps/update_unittest.py:
(UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
(UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
- 12:09 PM FeatureFlags edited by
- HTML Notifications were finally removed. (diff)
- 12:04 PM Changeset in webkit [148034] by
-
- 12 edits in trunk/Source
[wk2] IconDatabase images should be decoded in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=112524
<rdar://problem/10133914>
Reviewed by Oliver Hunt.
In the interests of keeping decoding of data coming in from the greater Internet
in the WebProcess, move decoding of favicons from the UIProcess to the WebProcess.
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::setIconBitmapForIconURL):
Receive a ShareableBitmap handle from the WebProcess instead of a DataReference.
Use the new setIconBitmapForIconURL IconDatabase method.
- UIProcess/WebIconDatabase.h:
(WebIconDatabase):
Rename setIconDataForIconURL to setIconBitmapForIconURL.
- UIProcess/WebIconDatabase.messages.in: Ditto.
- WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
In the WebProcess, decode the incoming icon and draw it into a ShareableBitmap.
No testable behavior change.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::updateIconRecord):
Added updateIconRecord, which factors most of setIconDataForIconURL out so it can
be shared with setIconBitmapForIconURL. This function will set either a bitmap or
raw image data for the given icon URL.
(WebCore::IconDatabase::setIconBitmapForIconURL):
Added; make a copy of the bitmap for thread-safety purposes, and call updateIconRecord.
(WebCore::IconDatabase::setIconDataForIconURL):
Factored out of what is now updateIconRecord.
- loader/icon/IconDatabase.h:
(IconDatabase): Add setIconBitmapForIconURL and updateIconRecord.
- loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::setIconBitmapForIconURL): Added.
- loader/icon/IconRecord.cpp:
(WebCore::IconRecord::setImage): Set the image for an icon record directly (as opposed
to setting the image data, which causes the image to be decoded in the WebProcess).
- loader/icon/IconRecord.h:
(IconRecord): Add setImage.
- 11:53 AM Changeset in webkit [148033] by
-
- 22 edits4 adds in trunk
AX: The bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Reviewed by David Kilzer.
Source/WebCore:
This allows bounding paths to be returned for some web elements (image map areas and SVG shapes).
This provides more accuracy when assistive technologies highlight elements.
The Mac and iOS platforms share some code to help transform paths to their screen coordinates.
Tests: platform/iphone-simulator/accessibility/element-paths.html
platform/mac/accessibility/element-paths.html
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
(WebCore):
(WebCore::AccessibilityImageMapLink::elementPath):
(WebCore::AccessibilityImageMapLink::elementRect):
- accessibility/AccessibilityImageMapLink.h:
(AccessibilityImageMapLink):
(WebCore::AccessibilityImageMapLink::supportsPath):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::elementPath):
(WebCore::AccessibilityObject::supportsPath):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::AccessibilityRenderObject::supportsPath):
(WebCore::AccessibilityRenderObject::elementPath):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityPath]):
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
(-[WebAccessibilityObjectWrapper convertRectToScreenSpace:]):
(-[WebAccessibilityObjectWrapper accessibilityActivationPoint]):
(-[WebAccessibilityObjectWrapper accessibilityFrame]):
(-[WebAccessibilityObjectWrapper frameForTextMarkers:]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
(WebCore):
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(PathConversionInfo):
(ConvertPathToScreenSpaceFunction):
(-[WebAccessibilityObjectWrapperBase convertPathToScreenSpace:]):
(-[WebAccessibilityObjectWrapperBase convertPointToScreenSpace:]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
(WebTransformCGPathToNSBezierPath):
(-[WebAccessibilityObjectWrapper bezierPathFromPath:]):
(-[WebAccessibilityObjectWrapper path]):
(-[WebAccessibilityObjectWrapper position]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools:
Add a pathDescription property for testing so that it's possible
to verify that a path is being returned correctly.
- DumpRenderTree/AccessibilityUIElement.cpp:
(getPathDescriptionCallback):
(AccessibilityUIElement::pathDescription):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(_CGPathEnumerationIteration):
(AccessibilityUIElement::pathDescription):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::pathDescription):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::pathDescription):
(WTR):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::pathDescription):
(WTR):
LayoutTests:
Add new tests for Mac and iOS to verify that path output works.
Modify existing tests to indicate that there is a new AXAttribute, AXPath.
- platform/iphone-simulator/accessibility/element-paths-expected.txt: Added.
- platform/iphone-simulator/accessibility/element-paths.html: Added.
- platform/mac/accessibility/document-links-expected.txt:
- platform/mac/accessibility/element-paths-expected.txt: Added.
- platform/mac/accessibility/element-paths.html: Added.
- platform/mac/accessibility/image-map2-expected.txt:
- 11:04 AM Changeset in webkit [148032] by
-
- 2 edits2 deletes in trunk/Source
Remove the WebKit copy of GLU and the file using it
https://bugs.webkit.org/show_bug.cgi?id=114249
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09
Reviewed by Darin Adler.
Source/ThirdParty:
- glu/.gitignore: Removed.
- glu/LICENSE.txt: Removed.
- glu/README.webkit: Removed.
- glu/glu.gyp: Removed.
- glu/gluos.h: Removed.
- glu/internal_glu.h: Removed.
- glu/libtess/GNUmakefile: Removed.
- glu/libtess/Imakefile: Removed.
- glu/libtess/README: Removed.
- glu/libtess/alg-outline: Removed.
- glu/libtess/dict-list.h: Removed.
- glu/libtess/dict.c: Removed.
- glu/libtess/dict.h: Removed.
- glu/libtess/geom.c: Removed.
- glu/libtess/geom.h: Removed.
- glu/libtess/memalloc.c: Removed.
- glu/libtess/memalloc.h: Removed.
- glu/libtess/mesh.c: Removed.
- glu/libtess/mesh.h: Removed.
- glu/libtess/normal.c: Removed.
- glu/libtess/normal.h: Removed.
- glu/libtess/priorityq-heap.c: Removed.
- glu/libtess/priorityq-heap.h: Removed.
- glu/libtess/priorityq-sort.h: Removed.
- glu/libtess/priorityq.c: Removed.
- glu/libtess/priorityq.h: Removed.
- glu/libtess/render.c: Removed.
- glu/libtess/render.h: Removed.
- glu/libtess/sweep.c: Removed.
- glu/libtess/sweep.h: Removed.
- glu/libtess/tess.c: Removed.
- glu/libtess/tess.h: Removed.
- glu/libtess/tessmono.c: Removed.
- glu/libtess/tessmono.h: Removed.
Source/WebCore:
- platform/graphics/gpu/LoopBlinnPathProcessor.cpp: Removed.
- 10:45 AM Changeset in webkit [148031] by
-
- 4 edits in trunk/Source/WebCore
Throttle resize events during live window resize.
<http://webkit.org/b/114292>
<rdar://problem/13411454>
Reviewed by Geoffrey Garen.
Limit resize events to one at max every 0.2 seconds during live window resize.
This mitigates heavy CPU usage during resize on pages with complex onresize handlers.
If there's a pending resize event when the live resize ends, it fires immediately.
- page/FrameView.cpp:
(WebCore::FrameView::sendResizeEvent):
Factored out dispatch of the resize event after layout so we can call it on a timer
instead of immediately while live window resize is active.
(WebCore::FrameView::FrameView):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::delayedResizeEventTimerFired):
(WebCore::FrameView::willEndLiveResize):
(WebCore::FrameView::scheduleResizeEvent):
- page/FrameView.h:
- platform/ScrollableArea.h:
Made willStartLiveResize() and willEndLiveResize() virtual so we can override
them on FrameView.
- 10:31 AM FeatureFlags edited by
- (diff)
- 10:05 AM Changeset in webkit [148030] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 10:04 AM FeatureFlags edited by
- Add info on the CSS Exclusions flag (diff)
- 10:03 AM Changeset in webkit [148029] by
-
- 1 copy in tags/Safari-536.29.13
New Tag.
- 9:52 AM Changeset in webkit [148028] by
-
- 2 edits in trunk/Source/WebCore
Add webp to supported image mime types if WEBP feature is enabled/used
https://bugs.webkit.org/show_bug.cgi?id=112819
Patch by Jeff Rogers <jrogers@rim.com> on 2013-04-09
Reviewed by Darin Adler.
Add WebP to list of supported image types in MIMETypeRegistry if enabled.
No new tests: WebP image decoding already covered by exisiting tests.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
- 9:46 AM Changeset in webkit [148027] by
-
- 3 edits4 adds in trunk
Whitespace in particular source code changes rendering; does not in Firefox
https://bugs.webkit.org/show_bug.cgi?id=100943
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-04-09
Reviewed by Darin Adler.
Source/WebCore:
A render inline which requires a line box is considered a possible
trailing object. So, ensureLineBoxInsideIgnoredSpaces will be called
for it, even if it is placed after a text render ending with a single
space.
Tests: fast/text/whitespace/trailing-space-before-empty-span-1.html
fast/text/whitespace/trailing-space-before-empty-span-2.html
- rendering/RenderBlockLineLayout.cpp:
(TrailingObjects):
(WebCore::TrailingObjects::appendBoxIfNeeded):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/text/whitespace/trailing-space-before-empty-span-1-expected.html: Added.
- fast/text/whitespace/trailing-space-before-empty-span-1.html: A test
with a span whose text ends with a single span. A following span
is empty but requires a line box (because it has some padding).
The second span should be rendered.
- fast/text/whitespace/trailing-space-before-empty-span-2-expected.html: Added.
- fast/text/whitespace/trailing-space-before-empty-span-2.html: Same
test as trailing-space-before-empty-span-1.html except that second
span contains whitespace only text.
- 9:39 AM Keeping the Tree Green edited by
- (diff)
- 9:22 AM FeatureFlags edited by
- Add info about CSS_SHADERS. (diff)
- 8:27 AM Changeset in webkit [148026] by
-
- 13 edits in trunk
Use DOM ordering for list counts
https://bugs.webkit.org/show_bug.cgi?id=110352
Reviewed by Elliott Sprehn.
Source/WebCore:
Currently the list items ordering is made by traversing the render tree. This gives bad results for:
- list items flown inside regions because they are not rendered as descendants of their DOM list ancestors.
- list items matched to insertion points inside a shadow tree. The insertion point may be a child of a
list so the numbering gets broken.
To implement correct DOM ordering I've taken into account the fact that pseudo-elements can have display: list-item
so they should be included when traversing the DOM tree. I've added helper methods on the NodeTraversal
namespace that should allow easily traversing the tree including the pseudo-elements (e.g. firstChildWithPseudo
for an element with pseudo-before will return the before PseudoElement). Using these helper methods I've implemented
pre-order traversal methods aware of the pseudo-elements.
An effect of this change is how the list items inside shadow tree update their counting. With the patch, if there's
no <ol> or <ul> element on the ancestor chain of a <li> element to the shadow root, the list node will be considered the
first parent of the <li> or the shadow root if there is no ancestor.
The RenderListItem class now makes use of this new method of traversal, replacing the one based on the render tree.
To simplify the CSS counters implementation, I've changed the traversal functions inside RenderCounter to also make use
of this method. The CSS counters and the list items now have the same traversal algorithm.
In later patches I'll add tests that should cover the regions and shadow DOM use cases.
Tests bug for shadow DOM: https://bugs.webkit.org/show_bug.cgi?id=113193
Tests bug for regions: https://bugs.webkit.org/show_bug.cgi?id=103975
Tests: no new tests is this patch; added the correct expectations for fast/lists/positioned-count-crash.html
and fast/dom/shadow/shadow-and-list-elements.html
- dom/Node.cpp:
(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::Node::pseudoAwareFirstChild):
(WebCore::Node::pseudoAwareLastChild):
- dom/Node.h:
(Node):
- dom/NodeTraversal.cpp:
(WebCore):
(WebCore::NodeTraversal::previousIncludingPseudo):
(NodeTraversal):
(WebCore::NodeTraversal::nextIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):
- dom/NodeTraversal.h:
(ElementTraversal):
(NodeTraversal):
(WebCore::ElementTraversal::previousIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
(WebCore::ElementTraversal::pseudoAwarePreviousSibling):
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::attach):
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):
- rendering/RenderCounter.cpp:
(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):
- rendering/RenderListItem.cpp:
(WebCore):
(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):
- rendering/RenderListItem.h:
(RenderListItem):
LayoutTests:
The fast/dom/shadow/shadow-and-list-elements-expected.html has changed because the list items
inside the shadow tree no longer see the root <ol> element.
The test fast/lists/positioned-count-crash.html has the correct rendering after changing
the list counting to be in DOM order.
- fast/dom/shadow/shadow-and-list-elements-expected.html:
- fast/lists/positioned-count-crash-expected.txt:
- 7:50 AM Changeset in webkit [148025] by
-
- 16 edits in trunk
[EFL] Declare TEST_THEME_DIR in a single place.
https://bugs.webkit.org/show_bug.cgi?id=114285
Reviewed by Anders Carlsson.
.:
Instead of adding the `THEME_DIR' preprocessor variable in many
different CMakeList.txt files in the tree, declare it in
OptionsEfl.cmake so that we avoid needlessly duplicating code around.
While here, rename it to `TEST_THEME_DIR', which is the name used our
WebKit2 infrastructure, to better reflect the purpose of this value.
- Source/cmake/OptionsEfl.cmake: Add the TEST_THEME_DIR preprocessor
definition.
Source/WebKit2:
- PlatformEfl.cmake: Remove definition of `TEST_THEME_DIR', which is
now defined in OptionsEfl.cmake.
Tools:
Adapt to the renaming of
THEME_DIR' toTEST_THEME_DIR'.
- DumpRenderTree/efl/CMakeLists.txt:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::createInspectorView):
(DumpRenderTreeChrome::initialize):
(DumpRenderTreeChrome::onDownloadRequest):
- EWebLauncher/CMakeLists.txt:
- EWebLauncher/main.c:
(findThemePath):
- EWebLauncher/url_bar.c:
(url_bar_add):
- MiniBrowser/efl/CMakeLists.txt:
- MiniBrowser/efl/main.c:
(window_create):
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
- WebKitTestRunner/PlatformEfl.cmake:
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):
- 7:48 AM Changeset in webkit [148024] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] InputHandler: fix calls to HTMLInputElement methods
https://bugs.webkit.org/show_bug.cgi?id=114283
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-09
Reviewed by Rob Buis.
Fix calls with wrong names.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertInputType):
- 7:35 AM Changeset in webkit [148023] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] --minimal build fails with error:
setSeamlessIFramesEnabled' is not a member ofWebCore::RuntimeEnabledFeatures'
https://bugs.webkit.org/show_bug.cgi?id=113951
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-09
Reviewed by Laszlo Gombos.
Wrapped code related to iframe seamless into #if ENABLE(IFRAME_SEAMLESS)
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setSeamlessIFramesEnabled):
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
- 7:31 AM Changeset in webkit [148022] by
-
- 5 edits3 adds in trunk
[CoordinatedGraphics] serviceScriptedAnimations expects time in seconds
https://bugs.webkit.org/show_bug.cgi?id=112582
Reviewed by Andreas Kling.
Source/WebKit/qt:
We've been exposing different time unit for requestAnimationFrame because
of wrong conversion before serviceScriptedAnimations function calls.
Fixed it to use seconds instead of milliseconds.
- WebCoreSupport/ChromeClientQt.cpp: Remove unnecessary conversion.
Source/WebKit2:
We've been exposing different time unit for requestAnimationFrame because
of wrong conversion before serviceScriptedAnimations function calls.
Fixed it to use seconds instead of milliseconds.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::syncDisplayState): Remove unnecessary conversion.
LayoutTests:
Add test to measure if the time interval is coherent with the unit
of DOMTimeStamp (milliseconds) by comparing it with Date.now() interval.
- fast/animation/request-animation-frame-time-unit-expected.txt: Added.
- fast/animation/request-animation-frame-time-unit.html: Added.
- fast/animation/script-tests/request-animation-frame-time-unit.js: Added.
- 7:14 AM Changeset in webkit [148021] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Remove obsolete QtWebPageFindClient forward declaration from qquickwebview_p.h.
https://bugs.webkit.org/show_bug.cgi?id=114284
Reviewed by Andreas Kling.
The class QtWebPageFindClient was removed in r142073 when the functionality
was folded into QQuickWebViewPrivate.
- UIProcess/API/qt/qquickwebview_p.h:
(WebKit):
- 7:13 AM Changeset in webkit [148020] by
-
- 3 edits in trunk/Source/WebCore
[Texmap] TextureMapperLayer refactor for readiblity
https://bugs.webkit.org/show_bug.cgi?id=114278
Reviewed by Noam Rosenthal.
Removes non-needed return values, function parameters and changes
boolean values with enums for readibility.
No behavioral changes, thus no tests.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::sortByZOrder):
(WebCore::TextureMapperLayer::computeOverlapRegions):
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
(WebCore::commitSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):
(WebCore::TextureMapperLayer::paintRecursive):
- platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
- 6:45 AM Changeset in webkit [148019] by
-
- 8 edits in trunk
[WebSocket] Ignore incoming message in CLOSING state
https://bugs.webkit.org/show_bug.cgi?id=85934
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-04-09
Reviewed by Kent Tamura.
Source/WebCore:
Change WebSocket implementation to suit the new WebSocket API, which
states that we should ignore messages in CLOSING state.
No new tests, updating existing tests.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveMessage):
LayoutTests:
- http/tests/websocket/tests/hybi/client-close-expected.txt: Rebaseline.
- http/tests/websocket/tests/hybi/client-close.html: Change expected results.
- http/tests/websocket/tests/hybi/client-close_wsh.py: Embed message in close frame
instead of using regular message sending call.
- http/tests/websocket/tests/hybi/fragmented-frames.html: Call WebSocket.close()
only after receiving all messages from server.
- http/tests/websocket/tests/hybi/unmasked-frames.html: Remove extra
WebSocket.close() call that caused regression.
- 6:26 AM Changeset in webkit [148018] by
-
- 4 edits in trunk
[GTK][AC] upversion of clutter and its dependecy
https://bugs.webkit.org/show_bug.cgi?id=114016
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-09
Reviewed by Gustavo Noronha Silva.
Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
.:
- Source/autotools/Versions.m4:
Tools:
- gtk/jhbuild-optional.modules:
- 6:13 AM Changeset in webkit [148017] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add Localized strings after r144154 and r135127
https://bugs.webkit.org/show_bug.cgi?id=114269
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-09
Reviewed by Timothy Hatcher.
No new tests, no behavior change.
- English.lproj/localizedStrings.js:
- 5:55 AM Changeset in webkit [148016] by
-
- 1 delete in trunk/LayoutTests/platform/efl-wk2/tables/mozilla_expected_failures
Remove empty directories
- 5:53 AM Changeset in webkit [148015] by
-
- 4 edits2 deletes in trunk/LayoutTests
[EFL] Move tables/mozilla_expected_failures/bugs/bug89315.html's expectations to efl/.
There is no point in keeping the rebaselined results WK2-only. While
here, actually unskip the test and provide a more accurate pixel result
(the previous one was fine, but this one passes with --tolerance=0).
- platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.png: Removed.
- platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Removed.
- platform/efl/TestExpectations:
- platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- 5:13 AM Changeset in webkit [148014] by
-
- 2 edits in trunk/Source/WebKit2
Fix GTK WebKit2 build after r148005.
https://bugs.webkit.org/show_bug.cgi?id=114270
Reviewed by Andreas Kling.
Fix GTK build break that went through the buildbot undetected.
- UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
(webkit_file_chooser_request_get_selected_files):
- 5:11 AM Changeset in webkit [148013] by
-
- 4 edits in trunk/Source/WebCore
Throttle compositing layer flushes in subframes
https://bugs.webkit.org/show_bug.cgi?id=114267
Reviewed by Andreas Kling.
Throttle compositing layer flushes in all frames, not just the main one.
This especially reduces flushes/repaints generated by ads in iframes.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadProgressingStatusChanged):
- page/FrameView.cpp:
(WebCore::FrameView::updateLayerFlushThrottlingInAllFrames):
- page/FrameView.h:
- 5:00 AM Changeset in webkit [148012] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening.
Now unskip a few compositing-related tests which are not failing
anymore.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 4:53 AM Changeset in webkit [148011] by
-
- 6 edits in trunk/Source/WebKit2
[Qt][WK2] Remove direct references to WebPageProxy from QQuickWebPage.
https://bugs.webkit.org/show_bug.cgi?id=112850
Reviewed by Andreas Kling.
Removes direct references to WebPageProxy from QQuickWebPage and prepares the
class for the move to QRawWebView. The access to the device scale factor and
CoordinatedGraphicsScene is provided through QQuickWebViewPrivate, and therefore
accessors to these properties are temporarily added. Eventually, this access will
be provided through QRawWebView when the move is complete.
This also moves the pointer to QtWebPageEventHandler from QQuickWebPagePrivate
to QQuickWebViewPrivate as it is mainly used from there.
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paint):
(QQuickWebPage::updatePaintNode):
- UIProcess/API/qt/qquickwebpage_p.h:
- UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::handleMouseEvent):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewPrivate::coordinatedGraphicsScene):
(QQuickWebViewPrivate::deviceScaleFactor):
(QQuickWebViewPrivate::setIntrinsicDeviceScaleFactor):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::itemChange):
(QQuickWebView::touchEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
- UIProcess/API/qt/qquickwebview_p_p.h:
(WebCore):
(WebKit):
(QQuickWebViewPrivate):
- 4:51 AM Changeset in webkit [148010] by
-
- 9 edits2 adds in trunk
Table border doesn't show up
https://bugs.webkit.org/show_bug.cgi?id=13709
Patch by Suchit Agrawal <a.suchit@samsung.com> on 2013-04-09
Reviewed by Antti Koivisto.
Source/WebCore:
Border issue is fixed when border width is less than 0.8pt
Border width is stored as unsigned. Border width (specified by
author) is converted into pixels and some times this pixel value
goes less than 1px. In this case, border width becomes 0px when
pixel value (double type) assigned to unsigned type.
Border width should not fall to 0px unless it is specified by
author.
Test: fast/borders/border-width-less-then-a-unit-of-pt.html
- css/StyleBuilder.cpp:
ApplyPropetyComputeLength class is replaced with 3 classes :
ApplyPropertyComputeBorderWidth, ApplyPropertyComputeTextSpacing
and ApplyPropertyComputeTransformOriginZ.
(WebCore::ApplyPropertyComputeBorderWidth::applyValue):
(WebCore::ApplyPropertyComputeBorderWidth::createHandler):
This class handles all width properties like border, outline,
etc. These all properties stores value in integer types.
Pixel value rounded of to 1px if value less than 1px and greater
than 0px.
(WebCore):
(ApplyPropertyComputeTextSpacing):
(WebCore::ApplyPropertyComputeTextSpacing::setValue):
(WebCore::ApplyPropertyComputeTextSpacing::applyValue):
(WebCore::ApplyPropertyComputeTextSpacing::createHandler):
This class handles all spacing properties like word-spacing,
letter-spacing etc.
(ApplyPropertyComputeTransformOriginZ):
(WebCore::ApplyPropertyComputeTransformOriginZ::setValue):
(WebCore::ApplyPropertyComputeTransformOriginZ::applyValue):
(WebCore::ApplyPropertyComputeTransformOriginZ::createHandler):
This class handles TransformOriginZ Property.
(WebCore::StyleBuilder::StyleBuilder):
ApplyProprtyComputeLength class usage changed with defined new
classes as per class definition.
LayoutTests:
This test file have border width, outline offset, outline width, border
spacing and column rule width properties test cases.
- fast/borders/border-width-less-then-a-unit-of-pt-expected.html: Added.
- fast/borders/border-width-less-then-a-unit-of-pt.html: Added.
Test case table/mozilla_expected_failures/bug89315.html need to do rebaseline
in efl, gtk and mac.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
Updated the test result for table/mozilla_expected_failures/bug89315.html
Border is expected for table in test table/mozilla_expected_failures/bug89315.html
- platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- 4:50 AM Changeset in webkit [148009] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unskip and update inspector tests
https://bugs.webkit.org/show_bug.cgi?id=114263
Unreviewed gardening.
Removed fast/events/autoscroll.html after r147830.
Unskip inspector/timeline/timeline-animation-frame.html that is now passing.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-09
- platform/qt/TestExpectations:
- 4:48 AM Changeset in webkit [148008] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Use C API to enable Navigator Qt Object.
https://bugs.webkit.org/show_bug.cgi?id=112810
Reviewed by Andreas Kling.
Replace the direct reference to the WebPageProxy with use of
C API.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::setNavigatorQtObjectEnabled):
- 4:42 AM Changeset in webkit [148007] by
-
- 3 edits in trunk/LayoutTests
[EFL] More gardening.
Unskip some tests which have stopped crashing after r147759,
147933 and others.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 4:34 AM Changeset in webkit [148006] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening. Unskip some tests that have been passing for a while.
- platform/efl/TestExpectations:
- 4:13 AM Changeset in webkit [148005] by
-
- 7 edits in trunk/Source/WebKit2
[WK2] Add C API to copy selected files from WebOpenPanelParameters.
https://bugs.webkit.org/show_bug.cgi?id=112339
Reviewed by Andreas Kling.
Replaces the existing WebOpenPanelParameters::selectedFileNames() method
to return a copy of the selected file names and exposes it through the
C API. This is done in order to reduce the direct use of WebKit2 internal
classes. The implementation is very similar to the one in
WebOpenPanelParameters::acceptMIMETypes().
This also updates the GTK port, which is the other user of selectedFileNames.
- Shared/WebOpenPanelParameters.cpp:
(WebKit::WebOpenPanelParameters::selectedFileNames):
(WebKit):
- Shared/WebOpenPanelParameters.h:
(WebOpenPanelParameters):
- UIProcess/API/C/WKOpenPanelParameters.cpp:
(WKOpenPanelParametersCopySelectedFileNames):
- UIProcess/API/C/WKOpenPanelParameters.h:
- UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
(webkit_file_chooser_request_get_selected_files):
- UIProcess/qt/QtWebPageUIClient.cpp:
(WebKit::QtWebPageUIClient::runOpenPanel):
- 4:01 AM Changeset in webkit [148004] by
-
- 2 edits in trunk/Source/WTF
[CMake] Remove conditional source file lists in WTF
https://bugs.webkit.org/show_bug.cgi?id=114250
Reviewed by Laszlo Gombos.
Use the #ifdef in the source file instead of conditional adding
files to the list of source files. This allows us to remove the
information of enabled features from CMake in next step.
- wtf/CMakeLists.txt:
- 3:44 AM Changeset in webkit [148003] by
-
- 2 edits in trunk/Source/WebCore
Initialization skipped error on WinCario after r147643
https://bugs.webkit.org/show_bug.cgi?id=114258
Reviewed by Csaba Osztrogonác.
Build fix. Adding extra block statement to avoid error C2362 on WinCario
- platform/win/DragImageCairoWin.cpp:
(WebCore::createDragImageFromImage):
- 3:15 AM Changeset in webkit [148002] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding failure expectations for two a11y tests that regressed with r147719.
- 3:11 AM Changeset in webkit [148001] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r147995.
http://trac.webkit.org/changeset/147995
https://bugs.webkit.org/show_bug.cgi?id=114261
Wrong gardening. (Requested by gyuyoung on #webkit).
- platform/efl/TestExpectations:
- 3:03 AM Changeset in webkit [148000] by
-
- 15 edits in trunk/Source
[WK2] Remove build warnings for unused parameters
https://bugs.webkit.org/show_bug.cgi?id=114234
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-09
Reviewed by Andreas Kling.
Fix build warnings -Wunused-parameter.
Source/WebCore:
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::openInMemory):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::CreateIndexAbortOperation::perform):
(WebCore::DeleteIndexAbortOperation::perform):
(WebCore::CreateObjectStoreAbortOperation::perform):
(WebCore::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::decodeBool):
(WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
- Modules/indexeddb/IDBLevelDBCoding.h:
(WebCore::IDBLevelDBCoding::encodeIntSafely):
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::canSet):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::ComparatorAdapter::FindShortestSeparator):
(WebCore::ComparatorAdapter::FindShortSuccessor):
Source/WebKit2:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::requestNetworkingStatistics):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::removeItem):
(WebKit::StorageAreaProxy::clear):
(WebKit::StorageAreaProxy::dispatchSessionStorageEvent):
(WebKit::StorageAreaProxy::dispatchLocalStorageEvent):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::didUninstallPageOverlay):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didFinishLoad):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin):
- 2:24 AM Changeset in webkit [147999] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Marking a bunch of CSS layout tests as flaky timeouts,
most likely due to libsoup dependency bump.
- 2:07 AM Changeset in webkit [147998] by
-
- 17 edits21 adds in trunk
[WK2] Drop WebProcess capabilities on Linux using seccomp filters
https://bugs.webkit.org/show_bug.cgi?id=89875
Reviewed by Maciej Stachowiak.
.:
Added the bits to EFL/CMake buildsystem to find the libseccomp
library.
- Source/cmake/FindLibSeccomp.cmake: Added.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebCore:
Make the DATA_DIR global since it is now needed for WebCore and WebKit2.
It is now used to set a sandbox policy for the EFL port.
- PlatformEfl.cmake:
Source/WebKit2:
Introduce the foundations of the SeccompFilter-based sandbox. The
hardening of the WebProcess (and potentially PluginProcess, etc)
works by a combination of the two things:
- Blocking syscalls that are not used, reducing the size of the attack
surface.
- Trapping sensitive syscalls and delegating the execution of these
syscalls to a separated trusted process subject to a set of policies.
The initial implementation traps the open()-family of syscalls on WebKit
EFL's and Qt's WebProcess, but it could be easily used by any Linux port,
since the code is suppose to be Linux-compliant. The list of syscalls handled
by the broker process should definitely grow as we mature the
implementation. Other syscalls needs to be handled to get this sandbox
fully functional, like unlink(), mkdir(), etc.
The broker process should be initialized as early as possible on the
sandboxed process main() function, because it only does a fork(), which
is cheap on Linux. That also aims to minimize the resident memory footprint
of the broker process.
Opening of files for upload and saving downloads is not supported yet,
since it should be handled to the UIProcess in a similar fashion as
the Mac port does.
- PlatformEfl.cmake:
- Shared/linux/SeccompFilters/OpenSyscall.cpp: Added.
(WebKit):
(WebKit::OpenSyscall::createFromOpenatContext):
(WebKit::OpenSyscall::createFromCreatContext):
(WebKit::OpenSyscall::OpenSyscall):
(WebKit::OpenSyscall::setResult):
(WebKit::OpenSyscall::execute):
(WebKit::OpenSyscall::encode):
(WebKit::OpenSyscall::decode):
(WebKit::OpenSyscallResult::OpenSyscallResult):
(WebKit::OpenSyscallResult::~OpenSyscallResult):
(WebKit::OpenSyscallResult::encode):
(WebKit::OpenSyscallResult::decode):
- Shared/linux/SeccompFilters/OpenSyscall.h: Added.
(CoreIPC):
(WebKit):
(OpenSyscall):
(WebKit::OpenSyscall::setPath):
(WebKit::OpenSyscall::setFlags):
(WebKit::OpenSyscall::setMode):
(OpenSyscallResult):
(WebKit::OpenSyscallResult::fd):
(WebKit::OpenSyscallResult::errorNumber):
- Shared/linux/SeccompFilters/SeccompBroker.cpp: Added.
(WebKit):
(SeccompBrokerClient):
(WebKit::sendMessage):
(WebKit::receiveMessage):
(WebKit::SIGSYSHandler):
(WebKit::registerSIGSYSHandler):
(WebKit::SeccompBrokerClient::shared):
(WebKit::SeccompBrokerClient::SeccompBrokerClient):
(WebKit::SeccompBrokerClient::~SeccompBrokerClient):
(WebKit::SeccompBrokerClient::dispatch):
(WebKit::SeccompBrokerClient::handleIfOpeningOnlineCPUCount):
(WebKit::SeccompBroker::launchProcess):
(WebKit::SeccompBroker::initialize):
(WebKit::SeccompBroker::runLoop):
- Shared/linux/SeccompFilters/SeccompBroker.h: Added.
(WebKit):
(SeccompBroker):
(WebKit::SeccompBroker::setSyscallPolicy):
(WebKit::SeccompBroker::SeccompBroker):
- Shared/linux/SeccompFilters/SeccompFilters.cpp: Added.
(WebKit):
(WebKit::SeccompFilters::SeccompFilters):
(WebKit::SeccompFilters::~SeccompFilters):
(WebKit::SeccompFilters::addRule):
(WebKit::SeccompFilters::initialize):
- Shared/linux/SeccompFilters/SeccompFilters.h: Added.
(WebKit):
(SeccompFilters):
(WebKit::SeccompFilters::context):
(WebKit::SeccompFilters::platformInitialize):
- Shared/linux/SeccompFilters/SigactionSyscall.cpp: Added.
(WebKit):
(WebKit::SigactionSyscall::createFromContext):
- Shared/linux/SeccompFilters/SigactionSyscall.h: Added.
(WebKit):
(SigactionSyscall):
- Shared/linux/SeccompFilters/SigprocmaskSyscall.cpp: Added.
(WebKit):
(WebKit::SigprocmaskSyscall::createFromContext):
- Shared/linux/SeccompFilters/SigprocmaskSyscall.h: Added.
(WebKit):
(SigprocmaskSyscall):
- Shared/linux/SeccompFilters/Syscall.cpp: Added.
(WebKit):
(WebKit::Syscall::createFromContext):
(WebKit::Syscall::createFromDecoder):
(WebKit::Syscall::Syscall):
(WebKit::SyscallResult::createFromDecoder):
(WebKit::SyscallResult::SyscallResult):
- Shared/linux/SeccompFilters/Syscall.h: Added.
(CoreIPC):
(WebKit):
(Syscall):
(WebKit::Syscall::~Syscall):
(WebKit::Syscall::type):
(WebKit::Syscall::setContext):
(WebKit::Syscall::context):
(SyscallResult):
(WebKit::SyscallResult::~SyscallResult):
(WebKit::SyscallResult::type):
- Shared/linux/SeccompFilters/SyscallPolicy.cpp: Added.
(WebKit):
(WebKit::removeTrailingSlash):
(WebKit::SyscallPolicy::hasPermissionForPath):
(WebKit::SyscallPolicy::addFilePermission):
(WebKit::SyscallPolicy::addDirectoryPermission):
(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):
- Shared/linux/SeccompFilters/SyscallPolicy.h: Added.
(WebKit):
(SyscallPolicy):
- Target.pri:
- WebKit2.pri:
- WebProcess/efl/SeccompFiltersWebProcessEfl.cpp: Added.
(WebKit):
(WebKit::SeccompFiltersWebProcessEfl::SeccompFiltersWebProcessEfl):
(WebKit::SeccompFiltersWebProcessEfl::platformInitialize):
- WebProcess/efl/SeccompFiltersWebProcessEfl.h: Added.
(WebKit):
(SeccompFiltersWebProcessEfl):
- WebProcess/qt/SeccompFiltersWebProcessQt.cpp: Added.
(WebKit):
(WebKit::SeccompFiltersWebProcessQt::SeccompFiltersWebProcessQt):
(WebKit::SeccompFiltersWebProcessQt::platformInitialize):
- WebProcess/qt/SeccompFiltersWebProcessQt.h: Added.
(WebKit):
(SeccompFiltersWebProcessQt):
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
Tools:
Add unit tests to verify if the handling of the open, openat, creat syscall
is being done right. We check if the Read/Write/ReadAndWrite permissions
are respected, if the canonical path is being resolved and if
the permissions are falling back to the topmost parent directory with a
policy set when the directory being opened has no policy.
We also test if any attempt of blocking SIGSYS is silently ignored.
SIGSYS cannot be blocked because in it's handler is where we hook
syscalls to the broker process.
Also added libseccomp to EFL's jhbuild to make the life of developers
willing to help easier.
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
(TestWebKitAPI):
(SeccompEnvironment):
(TestWebKitAPI::SeccompEnvironment::SetUp):
(TestWebKitAPI::SeccompEnvironment::TearDown):
(TestWebKitAPI::dummyHandler):
(TestWebKitAPI::TEST):
(TestWebKitAPI::stressTest):
- efl/jhbuild.modules:
- qmake/mkspecs/features/features.pri:
- 1:49 AM Changeset in webkit [147997] by
-
- 2 edits in trunk
Unreviewed. Fix GTK+ 32 bit build.
- Source/autotools/symbols.filter: Add some symbols that are
mangled differently in 32 bits due to size_t.
- 1:35 AM FeatureFlags edited by
- subpixel layout update (diff)
- 1:33 AM FeatureFlags edited by
- (diff)
- 1:31 AM FeatureFlags edited by
- (diff)
- 1:12 AM Changeset in webkit [147996] by
-
- 5 edits2 adds2 deletes in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations:
- platform/gtk/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
- platform/gtk/fast/js/exception-linenums-in-html-3-expected.png: Removed.
- platform/gtk/fast/js/missing-style-end-tag-js-expected.png: Removed.
- platform/gtk/fast/text/international/003-expected.png:
- platform/gtk/fast/text/international/003-expected.txt:
- platform/gtk/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/gtk/fast/text/international/text-combine-image-test-expected.txt:
- 1:04 AM FeatureFlags edited by
- CSS Regions (diff)
- 12:48 AM Changeset in webkit [147995] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
fast/dom/shadow/selections-in-shadow.html is passed on EFL layout test now.
- platform/efl/TestExpectations:
- 12:35 AM Changeset in webkit [147994] by
-
- 22 edits in trunk
REGRESSION: Autocorrection doesn't work in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=113846
Reviewed by Alexey Proskuryakov.
Tools:
The problem was that we were replacing NSSpellCheck's dictionary with our own
in DumpRenderTree but we were not adding necessary corrections to the dictionary.
Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
and "would" respectively in DumpRenderTree.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
LayoutTests:
Removed failing expectations from tests that require "mesage" to be corrected to "message".
Also modified to dynamically assert the marker positions so that we may catch regressions
without pixel results (we still dump pixel results via dumpAsText(true) for sanity check).
- platform/mac/TestExpectations:
- platform/mac/editing/spelling/autocorrection-contraction-expected.png:
- platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
- platform/mac/editing/spelling/click-autocorrected-word-expected.png:
- platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/click-autocorrected-word.html:
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/delete-into-autocorrected-word.html:
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png:
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html:
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png:
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html:
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png:
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html:
- platform/mac-wk2/TestExpectations:
- 12:30 AM Changeset in webkit [147993] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL] Mark not implemented methods in TextCheckerEfl.
https://bugs.webkit.org/show_bug.cgi?id=112261
Reviewed by Anders Carlsson.
There's no need to call client's methods in TextCheckerEfl.cpp if they are not
implemented. Mark them as not implemented until we provide proper implementation.
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::checkGrammarOfString):
(WebKit::TextChecker::spellingUIIsShowing):
(WebKit::TextChecker::toggleSpellingUIIsShowing):
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
- 12:20 AM Changeset in webkit [147992] by
-
- 4 edits in trunk
Do not set CMAKE_BUILD_TYPE if it is not defined
https://bugs.webkit.org/show_bug.cgi?id=114243
Reviewed by Geoffrey Garen.
Setting the CMAKE_BUILD_TYPE causes some problem with Visual Studio.
Adopt the current usage of the variable to better CMake style.
- CMakeLists.txt:
- Source/cmake/OptionsCommon.cmake:
- Source/cmake/OptionsEfl.cmake:
- 12:12 AM Changeset in webkit [147991] by
-
- 1 edit4 deletes in trunk/Tools
Remove the gyp files for Tools
https://bugs.webkit.org/show_bug.cgi?id=114248
Reviewed by Ryosuke Niwa.
- DumpRenderTree/DumpRenderTree.gyp: Removed.
- DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
- DumpRenderTree/DumpRenderTree.gypi: Removed.
- TestWebKitAPI/TestWebKitAPI.gyp: Removed.
- TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
- TestWebKitAPI/TestWebKitAPI.gypi: Removed.
- 12:07 AM Changeset in webkit [147990] by
-
- 1 edit1 delete in trunk/Source/JavaScriptCore
Remove yarr.gyp
https://bugs.webkit.org/show_bug.cgi?id=114247
Reviewed by Benjamin Poulain.
- yarr/yarr.gyp: Removed.
