Timeline

Apr 11, 2013:

11:11 PM Changeset in webkit [148263] by ap@apple.com

• 10 edits
  1 add in trunk/Source/WebCore

Reduce includes of CachedSVGDocument.h
​https://bugs.webkit.org/show_bug.cgi?id=114489

Reviewed by Jon Honeycutt.

• loader/cache/CachedSVGDocumentReference.cpp: Added.
• loader/cache/CachedSVGDocumentReference.h: Moved function implementations to newly added .cpp file, and removed an include of CachedSVGDocument.h.

• css/WebKitCSSSVGDocumentValue.h: Just removed an unnecessary include.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:

11:04 PM Changeset in webkit [148262] by zandobersek@gmail.com

• 18 edits in trunk

Unreviewed, rolling out r148247.
​http://trac.webkit.org/changeset/148247
​https://bugs.webkit.org/show_bug.cgi?id=114490

Cairo dep fails to build on builders due to missing EGL
headers (Requested by zdobersek on #webkit).

Patch by Commit Queue <​rniwa@webkit.org> on 2013-04-11

.:

• Source/autotools/FindDependencies.m4:
• Source/autotools/PrintBuildConfiguration.m4:
• Source/autotools/SetupWebKitFeatures.m4:

Source/WebCore:

• platform/graphics/GraphicsContext.cpp:

(WebCore):

• platform/graphics/ImageBuffer.cpp:

(WebCore):

• platform/graphics/cairo/GLContext.h:

(GLContext):

• platform/graphics/cairo/GraphicsContextCairo.cpp:
• platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore):

• platform/graphics/cairo/ImageBufferDataCairo.h:

(ImageBufferData):

• platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::~GLContextEGL):

• platform/graphics/egl/GLContextEGL.h:
• platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::GLContextGLX):
(WebCore::GLContextGLX::~GLContextGLX):

• platform/graphics/glx/GLContextGLX.h:

(GLContextGLX):

Tools:

• Scripts/webkitdirs.pm:

(buildAutotoolsProject):

• gtk/jhbuild.modules:

10:03 PM Changeset in webkit [148261] by thakis@chromium.org

• 2 edits in trunk/Source/WebCore

Remove debugging code that is no longer used with current mac sdks.
​https://bugs.webkit.org/show_bug.cgi?id=114486

Reviewed by Dan Bernstein.

This code compared MAC_OS_X_VERSION_MAX_ALLOWED and friends to
107 and 106 instead of the correct 1070 and 1060. Instead of fixing
this, rip the code out completely: Since WebKit now only targets
current systems, the ifdef is always false anyways.

No tests, as this only removes debugging code.

• platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit):

9:21 PM Changeset in webkit [148260] by oliver@apple.com

• 14 edits in trunk/Source/WebCore

Fix windows build and land new binding test results

8:42 PM Changeset in webkit [148259] by benjamin@webkit.org

• 5 edits in trunk/Source/JavaScriptCore

Merge CharacterClassTable into CharacterClass
​https://bugs.webkit.org/show_bug.cgi?id=114409

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-11
Reviewed by Darin Adler.

CharacterClassTable is only a pointer and a boolean.
It is a little overkill to make a separate allocation
for that.

• create_regex_tables:
• yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::matchCharacterClass):

• yarr/YarrPattern.cpp:

(JSC::Yarr::CharacterClassConstructor::charClass):

• yarr/YarrPattern.h:

(CharacterClass):
(JSC::Yarr::CharacterClass::CharacterClass):

7:38 PM Changeset in webkit [148258] by commit-queue@webkit.org

• 3 edits
  12 adds in trunk

Selection gaps don't repaint correctly with transforms
​https://bugs.webkit.org/show_bug.cgi?id=111000

Patch by Shezan Baig <Shezan Baig> on 2013-04-11
Reviewed by Simon Fraser.

Source/WebCore:

When computing offsetFromRepaintContainer, we need to add UseTransforms
to the MapCoordinateFlags argument. Note that ApplyContainerFlip is
the default value for the flag, so this change effectively only adds
the UseTransforms flag.

Tests: fast/repaint/selection-gap-absolute-child.html

fast/repaint/selection-gap-fixed-child.html
fast/repaint/selection-gap-flipped-absolute-child.html
fast/repaint/selection-gap-flipped-fixed-child.html
fast/repaint/selection-gap-transformed-absolute-child.html
fast/repaint/selection-gap-transformed-fixed-child.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint):

LayoutTests:

• fast/repaint/selection-gap-absolute-child-expected.txt: Added.
• fast/repaint/selection-gap-absolute-child.html: Added.
• fast/repaint/selection-gap-fixed-child-expected.txt: Added.
• fast/repaint/selection-gap-fixed-child.html: Added.
• fast/repaint/selection-gap-flipped-absolute-child-expected.txt: Added.
• fast/repaint/selection-gap-flipped-absolute-child.html: Added.
• fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
• fast/repaint/selection-gap-flipped-fixed-child.html: Added.
• fast/repaint/selection-gap-transformed-absolute-child-expected.txt: Added.
• fast/repaint/selection-gap-transformed-absolute-child.html: Added.
• fast/repaint/selection-gap-transformed-fixed-child-expected.txt: Added.
• fast/repaint/selection-gap-transformed-fixed-child.html: Added.

6:43 PM Changeset in webkit [148257] by oliver@apple.com

• 21 edits in trunk/Source

Add more type validation to debug builds
​https://bugs.webkit.org/show_bug.cgi?id=114478

Reviewed by Mark Hahnenberg.

Source/WebCore:

Add a bunch more type checks to the JS DOM bindings.

• Modules/mediastream/MediaStream.idl:
• Modules/webaudio/AudioDestinationNode.idl:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMBinding.h:

(WebCore::getExistingWrapper):
(WebCore):
(WebCore::createNewWrapper):

• bindings/scripts/CodeGeneratorJS.pm:

(GetNativeTypeForConversions):
(GetGnuVTableRefForInterface):
(GetGnuVTableNameForInterface):
(GetGnuMangledNameForInterface):
(GetGnuVTableOffsetForType):
(GetWinVTableRefForInterface):
(GetWinVTableNameForInterface):
(GetWinMangledNameForInterface):
(GetNamespaceForInterface):
(GetImplementationLacksVTableForInterface):
(GetSkipVTableValidationForInterface):
(GenerateImplementation):

• bindings/scripts/IDLAttributes.txt:
• css/CSSRuleList.idl:
• css/CSSStyleDeclaration.idl:
• dom/Clipboard.idl:
• dom/DOMStringMap.idl:
• dom/MutationRecord.idl:
• dom/NodeList.idl:
• html/DOMTokenList.idl:
• html/track/TextTrack.idl:
• inspector/ScriptProfileNode.idl:
• storage/Storage.idl:
• xml/XPathNSResolver.idl:

Source/WTF:

Add BINDING_VALIDATION flag and make RELEASE_ASSERT use UNLIKELY.

• wtf/Assertions.h:
• wtf/Platform.h:

5:50 PM Changeset in webkit [148256] by rniwa@webkit.org

• 12 edits
  1 delete in trunk/Source/WebCore

Remove ResourceLoadInfo
​https://bugs.webkit.org/show_bug.cgi?id=113302

Reviewed by Benjamin Poulain.

Co-authored by Christophe Dumez.

Removed ResourceLoadInfo since it had been only used by Chromium port.

• GNUmakefile.list.am:
• Target.pri:
• WebCore.order:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForResourceResponse):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

• platform/network/ResourceLoadInfo.h: Removed.
• platform/network/ResourceResponseBase.cpp:

(WebCore):
(WebCore::ResourceResponseBase::reportMemoryUsage):

• platform/network/ResourceResponseBase.h:

(ResourceResponseBase):

5:50 PM Changeset in webkit [148255] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Remove passing test expectations for ietestcenter/css3/grid/grid-items-003.htm since it started failing on
Mountain Lion WebKit2 bots after a slave reboot as well.

• platform/mac-wk2/TestExpectations:

5:47 PM Changeset in webkit [148254] by Lucas Forschler

• 4 edits in trunk/Source

Submission Notes.

5:39 PM Changeset in webkit [148253] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

REGRESSION (r146956): ASSERTion failure: WebKit::WebProcess::pageWillLeaveWindow
​https://bugs.webkit.org/show_bug.cgi?id=114481
<rdar://problem/13534784>

Reviewed by Simon Fraser.

Inform the WebProcess of WebPages which are already in a window when created.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

5:20 PM Changeset in webkit [148252] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Another Mac Lion build fix attempt after r148197.

• page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:

5:08 PM Changeset in webkit [148251] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Unable to paste twice in input field when specific CSS present
​https://bugs.webkit.org/show_bug.cgi?id=108675

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2013-04-11
Reviewed by Ryosuke Niwa.

Source/WebCore:

When we are pre-rendering text in ReplaceSelectionCommand, we shouldn't care
whether the content is clipped by its ancestors or not. This bug was caused
by the fact the plainText() method returned an empty string because the text
was fully clipped by its ancestors. Make plainText ignore style visibility.

Test: editing/inserting/insert-text-into-text-field.html

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):

LayoutTests:

• editing/inserting/insert-text-into-text-field-expected.txt: Added.
• editing/inserting/insert-text-into-text-field.html: Added.

4:55 PM Changeset in webkit [148250] by andersca@apple.com

• 8 edits in trunk/Source/WebKit2

Add support for clearing storage areas
​https://bugs.webkit.org/show_bug.cgi?id=114479

Reviewed by Beth Dakin.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::StorageArea):
Store the quota size so we can recreate the underlying StorageMap when clearing.

(WebKit::StorageManager::StorageArea::clear):
Create a new storage map and dispatch events.

(WebKit::StorageManager::clear):
Find the right storage area and call clear.

• UIProcess/Storage/StorageManager.messages.in:

Add Clear message.

• WebProcess/Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::clear):
Call the storage map.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::clear):
Reset the cached values and send a clear message.

(WebKit::StorageAreaMap::resetValues):
New helper function.

(WebKit::StorageAreaMap::didClear):
New stub.

• WebProcess/Storage/StorageAreaMap.messages.in:

Add DidClear message.

4:51 PM Changeset in webkit [148249] by Beth Dakin

• 4 edits in trunk/Source/WebKit2

WebKit should set the header and footer layers' contentsScale when the device
scale factor changes
​https://bugs.webkit.org/show_bug.cgi?id=114471
-and corresponding-
<rdar://problem/13621288>

Reviewed by Simon Fraser.

Update the header and footer contentsScale when the device scale factor has
changed.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDeviceScaleFactor):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::updateHeaderAndFooterLayersForDeviceScaleChange):

4:46 PM Changeset in webkit [148248] by commit-queue@webkit.org

• 2 edits in trunk

[GTK] Webkit fails to build with MinGW compiler after changeset 146468
​https://bugs.webkit.org/show_bug.cgi?id=114473

Patch by Paweł Forysiuk <​tuxator@o2.pl> on 2013-04-11
Reviewed by Martin Robinson.

• Source/autotools/CheckSystemAndBasicDependencies.m4: Fix typo.

4:39 PM Changeset in webkit [148247] by Martin Robinson

• 18 edits in trunk

[GTK] Add accelerated 2D canvas support using cairo-gl
​https://bugs.webkit.org/show_bug.cgi?id=104672

Reviewed by Alejandro G. Castro.

.:

Detect that we can activate accelerated canvas when CairoGL is present and
TextureMapperGL is enabled.

• Source/autotools/FindDependencies.m4: Look for CairoGL.
• Source/autotools/PrintBuildConfiguration.m4: Print the status of accelerated canvas activation.
• Source/autotools/SetupWebKitFeatures.m4: Set the feature.

Source/WebCore:

No new tests. We do not yet have the ability to run tests against
accelerated content.

• platform/graphics/GraphicsContext.cpp:

(WebCore): We don't use the stub implementation of isAcceleratedContext any longer.

• platform/graphics/ImageBuffer.cpp:

(WebCore): Ditto for ImageBuffer::platformLayer.

• platform/graphics/cairo/GLContext.h:

(GLContext): Added method to get a cairo_device_t from the context.

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::isAcceleratedContext): Return true when we are a CairoGL surface.

• platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBufferData::ImageBufferData): Initialize the size and the texture to 0.
(WebCore::createCairoGLSurface): Added this helper.
(WebCore::ImageBuffer::ImageBuffer): When we are in accelerated rendering mode, create
a CairoGL surface.
(WebCore::ImageBuffer::platformTransformColorSpace): Do not implement this for accelerated
contexts yet.
(WebCore::mapSurfaceToImage): Added this helper, since we don't require Cairo 1.12 yet,
which provides an builtin implementation.
(WebCore::unmapSurfaceFromImage): Ditto.
(WebCore::getImageData): Map the surface to an image surface first.
(WebCore::ImageBuffer::putByteArray): Ditto.
(WebCore::ImageBufferData::paintToTextureMapper): Connect the accelerated canvas into the
TextureMapper infrastructure.
(WebCore::ImageBuffer::platformLayer): This lets the TextureMapper at the ImageBufferData.

• platform/graphics/cairo/ImageBufferDataCairo.h:

(ImageBufferData): Subclass TexturMapperPlatformLayer where appropriate.

• platform/graphics/egl/GLContextEGL.cpp: Added implementation of cairoDevice.
• platform/graphics/egl/GLContextEGL.h: Ditto.
• platform/graphics/glx/GLContextGLX.cpp: Ditto
• platform/graphics/glx/GLContextGLX.h: Ditto.

Tools:

Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
dependencies, don't override value of the setting determined by configure.
This will make it easier for people using build-webkit, but not the
WebKit JHBuild.

• Scripts/webkitdirs.pm:

(buildAutotoolsProject): Add a blacklist for settings to never override.

• gtk/jhbuild.modules: Build CairoGL.

4:31 PM Changeset in webkit [148246] by rniwa@webkit.org

• 2 edits in trunk/Tools

build.webkit.org should link to webkit-queues instead of webkit-commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=114477

Reviewed by Benjamin Poulain.

• BuildSlaveSupport/build.webkit.org-config/templates/root.html:

4:26 PM Changeset in webkit [148245] by andersca@apple.com

• 10 edits in trunk/Source

Implement removing storage area items
​https://bugs.webkit.org/show_bug.cgi?id=114472

Reviewed by Beth Dakin.

Source/WebCore:

Export StorageMap::removeItem.

• WebCore.exp.in:

Source/WebKit2:

• UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::setItem):
Rename connection to sourceConnection.

(WebKit::StorageManager::StorageArea::removeItem):
Remove the item from the map and dispatch events if needed.

(WebKit::StorageManager::removeItem):
Find the right storage area, remove the item and send back a DidRemoveItem message.

• UIProcess/Storage/StorageManager.messages.in:

Add RemoveItem message.

• WebProcess/Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::removeItem):
Call StorageAreaMap::removeItem.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::removeItem):
Send a RemoveItem message to the storage manager.

(WebKit::StorageAreaMap::didRemoveItem):
Add empty stub.

• WebProcess/Storage/StorageAreaMap.messages.in:

Add DidRemoveItem message.

4:25 PM Changeset in webkit [148244] by commit-queue@webkit.org

• 5 edits
  1 add in trunk

TextTrackList's .onremovetrack is missing from IDL
​https://bugs.webkit.org/show_bug.cgi?id=103421

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-04-11
Reviewed by Eric Carlson.

Source/WebCore:

Fixed test media/track/opera/interfaces/TextTrackList/onremovetrack.html

• html/track/TextTrackList.cpp:

(TextTrackList::remove):
(TextTrackList::scheduleRemoveTrackEvent):

• html/track/TextTrackList.h:

(TextTrackList):

• html/track/TextTrackList.idl:

LayoutTests:

• media/track/opera/interfaces/TextTrackList/onremovetrack-expected.txt: Added.

4:24 PM WebKit Team edited by silviapf@chromium.org

added my irc handles and new employer (diff)

4:20 PM Changeset in webkit [148243] by rniwa@webkit.org

• 2 edits in trunk/Tools

Leaks builder should not be triggered upon new commits
​https://bugs.webkit.org/show_bug.cgi?id=114475

Reviewed by Jessie Berlin.

Don't trigger them on new checkins wait for Mountaion Lion (Build), which already triggers
the leak builder when builds are done.

• BuildSlaveSupport/build.webkit.org-config/config.json:

4:18 PM WebKitGTK/2.0.x edited by Martin Robinson

(diff)

4:09 PM Changeset in webkit [148242] by commit-queue@webkit.org

• 1 edit
  18 adds in trunk/Source/WebCore

[BlackBerry] Upstream the filesystem code
​https://bugs.webkit.org/show_bug.cgi?id=114437

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-11
Reviewed by Rob Buis.

This patch contains contributions from many members of the
BlackBerry WebKit team.

• platform/blackberry/AsyncFileWriterBlackBerry.cpp: Added.

(WebCore):
(WebCore::AsyncFileWriterBlackBerry::write):

• platform/blackberry/AsyncFileWriterBlackBerry.h: Added.

(WTF):
(WTF::BlackBerry::Platform::WebFileWriter):
(WebCore):

• platform/blackberry/DOMFileSystemBlackBerry.cpp: Added.

(WebCore):
(WebCore::DOMFileSystemBase::createFileSystemURL):
(WebCore::DOMFileSystemBase::crackFileSystemURL):
(WebCore::DOMFileSystemBase::supportsToURL):
(WebCore::DOMFileSystemBase::isValidType):

• platform/blackberry/LocalFileSystemBlackBerry.cpp: Added.

(WebCore):
(WebCore::fileSystemTypeString):
(WebCore::openFileSystem):
(WebCore::LocalFileSystem::deleteFileSystem):
(WebCore::LocalFileSystem::readFileSystem):
(WebCore::LocalFileSystem::requestFileSystem):

• platform/blackberry/PlatformAsyncFileSystemCallbacks.cpp: Added.

(WebCore):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyOpenFileSystem):
(WebCore::PlatformAsyncFileSystemCallbacks::notifySucceed):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyFail):
(WebCore::getFileMetadata):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyReadMetadata):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyCreateSnapshotFileAndReadMetadata):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyReadDirectory):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyCreateFileWriter):
(WebCore::PlatformAsyncFileSystemCallbacks::createAsyncFileSystem):
(WebCore::PlatformAsyncFileSystemCallbacks::createAsyncFileWriter):
(WebCore::PlatformAsyncFileSystemCallbacks::deleteMe):

• platform/blackberry/PlatformAsyncFileSystemCallbacks.h: Added.

(WebCore):

• platform/blackberry/PlatformBlob.cpp: Added.

(WebCore):
(WebCore::PlatformBlob::nextDataItem):

• platform/blackberry/PlatformBlob.h: Added.

(WebCore):

• platform/blackberry/PlatformFileWriterClient.cpp: Added.

(WebCore):
(WebCore::PlatformFileWriterClient::notifyWrite):
(WebCore::PlatformFileWriterClient::notifyTruncate):
(WebCore::PlatformFileWriterClient::notifyFail):

• platform/blackberry/PlatformFileWriterClient.h: Added.

(WebCore):
(WTF):
(WTF::WebCore::PlatformFileWriterClient):

• platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp: Added.

(WebCore):
(WebCore::WorkerAsyncFileSystemBlackBerry::WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::~WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::waitForOperationToComplete):
(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::moveOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::copyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursivelyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readMetadataOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createFileOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::fileExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::directoryExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadataOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystem):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystem):
(WebCore::WorkerAsyncFileSystemBlackBerry::move):
(WebCore::WorkerAsyncFileSystemBlackBerry::copy):
(WebCore::WorkerAsyncFileSystemBlackBerry::remove):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursively):
(WebCore::WorkerAsyncFileSystemBlackBerry::readMetadata):
(WebCore::WorkerAsyncFileSystemBlackBerry::createFile):
(WebCore::WorkerAsyncFileSystemBlackBerry::createDirectory):
(WebCore::WorkerAsyncFileSystemBlackBerry::fileExists):
(WebCore::WorkerAsyncFileSystemBlackBerry::directoryExists):
(WebCore::WorkerAsyncFileSystemBlackBerry::readDirectory):
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriter):
(WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadata):

• platform/blackberry/WorkerAsyncFileSystemBlackBerry.h: Added.

(WebCore):
(WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::create):

• platform/blackberry/WorkerAsyncFileWriterBlackBerry.cpp: Added.

(WebCore):
(WebCore::WorkerAsyncFileWriterBlackBerry::writeOnMainThread):
(WebCore::WorkerAsyncFileWriterBlackBerry::truncateOnMainThread):
(WebCore::WorkerAsyncFileWriterBlackBerry::abortOnMainThread):
(WebCore::WorkerAsyncFileWriterBlackBerry::write):
(WebCore::WorkerAsyncFileWriterBlackBerry::truncate):
(WebCore::WorkerAsyncFileWriterBlackBerry::abort):
(WebCore::WorkerAsyncFileWriterBlackBerry::waitForOperationToComplete):
(WebCore::WorkerAsyncFileWriterBlackBerry::platformWriterClient):

• platform/blackberry/WorkerAsyncFileWriterBlackBerry.h: Added.

(WebCore):

• platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.cpp: Added.

(WebCore):
(WebCore::performTaskOnMainThread):
(WebCore::postTaskToMainThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyStop):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyOpenFileSystem):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifySucceed):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyFail):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadMetadata):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadDirectory):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateFileWriter):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::createAsyncFileSystem):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::createAsyncFileWriter):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::deleteMe):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::postTaskToWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyOpenFileSystemOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifySucceedOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyFailOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadMetadataOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadDirectoryEntryOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateFileWriterOnWorkerThread):

• platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.h: Added.

(WebCore):

• platform/blackberry/WorkerPlatformFileWriterClient.cpp: Added.

(WebCore):
(WebCore::WorkerPlatformFileWriterClient::notifyWriteOnWorkerThread):
(WebCore::WorkerPlatformFileWriterClient::notifyFailOnWorkerThread):
(WebCore::WorkerPlatformFileWriterClient::notifyTruncateOnWorkerThread):
(WebCore::WorkerPlatformFileWriterClient::notifyWrite):
(WebCore::WorkerPlatformFileWriterClient::notifyTruncate):
(WebCore::WorkerPlatformFileWriterClient::notifyFail):
(WebCore::WorkerPlatformFileWriterClient::postTaskToWorkerThreadIfNeeded):

• platform/blackberry/WorkerPlatformFileWriterClient.h: Added.

(WebCore):
(WTF):
(WTF::WebCore::WorkerPlatformFileWriterClient):

4:04 PM Changeset in webkit [148241] by roger_fong@apple.com

• 3 edits in trunk/WebKitLibraries

Build fix.

• win/include/WebKitSystemInterface/WebKitSystemInterface.h:
• win/lib/WebKitSystemInterface.lib:

3:56 PM Changeset in webkit [148240] by ap@apple.com

• 4 edits in trunk/WebKitLibraries

<rdar://problem/10416316> [Mac] WebSocket doesn't work with authenticating proxies
​https://bugs.webkit.org/show_bug.cgi?id=114464

Update WebKitSystemInterface.

• WebKitSystemInterface.h:
• libWebKitSystemInterfaceLion.a:
• libWebKitSystemInterfaceMountainLion.a:

3:17 PM Changeset in webkit [148239] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Mac Lion build fix attempt after r148197.

• page/scrolling/mac/ScrollingStateNodeMac.mm:

2:50 PM Changeset in webkit [148238] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

InjectedBundleNodeHandle::imageForRect doesn't respect device scale factor or highlighting option
​https://bugs.webkit.org/show_bug.cgi?id=114466
<rdar://problem/13508513>

Reviewed by Simon Fraser.

Respect the device scale factor when creating the snapshot image.
Clear the snapshot image before drawing into it.
Respect SnapshotOptionsExcludeSelectionHighlighting.

• WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::imageForRect):

2:42 PM Changeset in webkit [148237] by ap@apple.com

• 4 edits in trunk/Source/WebCore

<rdar://problem/10416316> [Mac] WebSocket doesn't work with authenticating proxies
​https://bugs.webkit.org/show_bug.cgi?id=114464

Reviewed by Brady Eidson.

• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm: Updated for new wkCopyCONNECTProxyResponse signature.

• platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::executePACFileURL): Fixed a typo in a comment. (WebCore::SocketStreamHandle::addCONNECTCredentials): Don't crash even if the rest of the fix didn't work (which would be the case on some OS versions). (WebCore::SocketStreamHandle::readStreamCallback): Replaced most breaks with returns, because breaks were confusing in such a huge switch. Changed null proxyResponse to not be treated as authentication success, because it's not. Merged two parts of WaitingForConnect state handling for clarity. (WebCore::SocketStreamHandle::writeStreamCallback): Don't blindly assume that we can start WebSocket handshake after kCFStreamEventCanAcceptBytes. Perhaps it's nothing but a failed CONNECT, and a read callback still needs to send authentication. Without this, establishing connections was flaky. Added a check for Closed state, matching read callback.

2:41 PM Changeset in webkit [148236] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

MutationRecord is not exposed
​https://bugs.webkit.org/show_bug.cgi?id=114288

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2013-04-11
Reviewed by Darin Adler.

Source/WebCore:

Expose MutationRecord on DOMWindow. This patch is copied from a patch
by Adam Klein. ​https://codereview.chromium.org/13861028

Test: fast/dom/MutationObserver/mutation-record-constructor.html

• page/DOMWindow.idl:

LayoutTests:

This test is copied from a patch by Adam Klein.
​https://codereview.chromium.org/13861028
The test expectation of "typeof MutationRecord" is changed from
"function" to "object". (See bug 114457)

• fast/dom/MutationObserver/mutation-record-constructor-expected.txt: Added.
• fast/dom/MutationObserver/mutation-record-constructor.html: Added.

2:28 PM Changeset in webkit [148235] by Lucas Forschler

• 3 edits
  2 copies in branches/safari-536.30-branch

Merged r136554. <rdar://problem/13334986>

2:01 PM Changeset in webkit [148234] by Beth Dakin

• 2 edits in trunk/Source/WebCore

Cannot scroll to footer on a page with overflow:hidden on the body
​https://bugs.webkit.org/show_bug.cgi?id=114462
-and corresponding-
<rdar://problem/13530042>

Reviewed by Simon Fraser.

Add a new scenario in which we want to overrideHidden -- whenever we are the
mainFrame and there is a header or footer.

• page/FrameView.cpp:

(WebCore::FrameView::applyOverflowToViewport):

2:01 PM WebKitGTK/2.0.x edited by kalevlember@gmail.com

Added r148230 as proposed merge (diff)

1:57 PM WebKitGTK/2.0.x edited by kalevlember@gmail.com

Added r147963 as proposed merge (diff)

1:53 PM Changeset in webkit [148233] by rniwa@webkit.org

• 12 edits in trunk/Source

Unreviewed, rolling out r148034, r148052, r148097, and
r148194.
​http://trac.webkit.org/changeset/148034
​http://trac.webkit.org/changeset/148052
​http://trac.webkit.org/changeset/148097
​http://trac.webkit.org/changeset/148194
​https://bugs.webkit.org/show_bug.cgi?id=114463

broke mutiresolution favicons, among other things (Requested
by thorton on #webkit).

Source/WebCore:

• loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::setIconDataForIconURL):

• loader/icon/IconDatabase.h:

(IconDatabase):

• loader/icon/IconDatabaseBase.h:
• loader/icon/IconRecord.cpp:
• loader/icon/IconRecord.h:

(IconRecord):

Source/WebKit2:

• UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::setIconDataForIconURL):

• UIProcess/WebIconDatabase.h:

(WebIconDatabase):

• UIProcess/WebIconDatabase.messages.in:
• WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:

(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::destroy):

1:51 PM Changeset in webkit [148232] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[GTK][AC] Implement GraphicsLayerClutter::moveOrCopyAnimations
​https://bugs.webkit.org/show_bug.cgi?id=114019

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-11
Reviewed by Gustavo Noronha Silva.

Fill moveOrCopyAnimations that is based on Mac port implementation.

Tests: animations/3d/change-transform-in-end-event.html

animations/3d/transform-origin-vs-functions.html
compositing/animation/state-at-end-event-transform-layer.html

• platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::moveOrCopyLayerAnimation):
(WebCore):
(WebCore::GraphicsLayerClutter::moveOrCopyAnimations):

• platform/graphics/clutter/GraphicsLayerClutter.h:

1:34 PM Changeset in webkit [148231] by andersca@apple.com

• 4 edits in trunk/Source

Implement StorageManager::getValues
​https://bugs.webkit.org/show_bug.cgi?id=114461

Reviewed by Beth Dakin.

Source/WebCore:

Expose the item hash map.

• storage/StorageMap.h:

(WebCore::StorageMap::items):

Source/WebKit2:

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::items):
(WebKit::StorageManager::getValues):
Return the items from the right storage area.

1:22 PM Changeset in webkit [148230] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] Windows build failure after r136056
​https://bugs.webkit.org/show_bug.cgi?id=114121

Patch by Kalev Lember <​kalevlember@gmail.com> on 2013-04-11
Reviewed by Martin Robinson.

• TestWebKitAPI/config.h: Make sure defines are correct for other

Windows ports than apple-win.

1:14 PM Changeset in webkit [148229] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Clean up related storage areas when a connection is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=114459

Reviewed by Beth Dakin.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::processWillCloseConnection):
Dispatch invalidateConnectionInternal on the work queue.

(WebKit::StorageManager::createStorageMap):
(WebKit::StorageManager::destroyStorageMap):
Rename m_storageAreas to m_storageAreasByConnection.

(WebKit::StorageManager::invalidateConnectionInternal):
Go over all known storage areas and remove this connection as a listener.

(WebKit::StorageManager::findStorageArea):
Rename m_storageAreas to m_storageAreasByConnection.

• UIProcess/Storage/StorageManager.h:

Rename m_storageAreas to m_storageAreasByConnection.

1:08 PM Changeset in webkit [148228] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] Use the platform list of languages with fonts instead of hardcoding
​https://bugs.webkit.org/show_bug.cgi?id=114452

Patch by Eli Fidler <​efidler@blackberry.com> on 2013-04-11
Reviewed by Rob Buis.

BlackBerry PR 325244
Internally reviewed by Jeff Rogers

No functional change, but platform font changes won't need a WebKit change
going forward.

• page/blackberry/SettingsBlackBerry.cpp:

(WebCore::Settings::initializeDefaultFontFamilies):

1:05 PM Changeset in webkit [148227] by krit@webkit.org

• 8 edits
  6 adds in trunk

[CSS Shaders] Parse parameters descriptor
​https://bugs.webkit.org/show_bug.cgi?id=114455

Reviewed by Dean Jackson.

Source/WebCore:

Add support for the 'parameters' descriptor in the filter at-rule to support
parameterization of CSS Shaders.

​https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-parameters

Tests: css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid.html

css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

• css/CSSParser.cpp: Added 'parameters' property and fail parsing if not inside

of an @filter rule.

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilterRuleParameters): New helper function to verify

values.

(WebCore):

• css/CSSParser.h:
• css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

• css/CSSPropertyNames.in: Added new property name 'parameters'.
• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

Tests for the 'parameters' descriptor on @filter rule.

• css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt: Added.
• css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid.html: Added.
• css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt: Added.
• css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid.html: Added.
• css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js: Added.

(testInvalidParametersProperty):

• css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js: Added.

(testParametersProperty):

1:01 PM Changeset in webkit [148226] by fpizlo@apple.com

• 2 edits in trunk/PerformanceTests/SunSpider

Get rid of the 10ms delay between test executions
​https://bugs.webkit.org/show_bug.cgi?id=114458
<rdar://problem/13631112>

Reviewed by Darin Adler and Geoffrey Garen.

More details on this in the bug. Long story short, I don't know why the 10ms delay is
there, and it appears to be the root of some noisyness and unreliability in the results.
Removing it makes results more consistent, which is a good thing.

• resources/driver-TEMPLATE.html:

12:56 PM Changeset in webkit [148225] by zhajiang@rim.com

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Initial scale changes depending on the order of page navigations
​https://bugs.webkit.org/show_bug.cgi?id=114448

Patch by Jacky Jiang <​zhajiang@rim.com>.
Reviewed by Rob Buis.

PR: 323941
During page transitions, absoluteVisibleOverflowSize() and contentsSize()
in fixedLayoutSize() were based on the old page when we just started or
committed provisinal load. In that case, fixedLayoutSize() is very old
page dependent and can cause inconsistent behaviors. For example, if
the old page contents width is 4000, we will get DEFAULT_MAX_LAYOUT_WIDTH 1024
as the new page's fixedLayoutSize; however, we will get 768 if we
navigate to the new page directly.
To fix that, return default layout size if the page doesn't have
virtual viewport and m_loadState is Provisional.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):

12:37 PM Changeset in webkit [148224] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Default Implementation of toString for NPObject shouldn't return NPClass & NPObject address as String
​https://bugs.webkit.org/show_bug.cgi?id=114450

Patch by Arunprasad Rajkumar <​arunprasadr@nds.com> on 2013-04-11
Reviewed by Anders Carlsson.

• bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::stringValue):

12:17 PM Changeset in webkit [148223] by robert@webkit.org

• 3 edits
  2 adds in trunk

REGRESSION (142152): ensure we skip past out-of-flow objects when detecting whitespace to ignore after leading empty inlines
​https://bugs.webkit.org/show_bug.cgi?id=114311

Reviewed by Emil A Eklund.

Source/WebCore:

When we hit an empty inline in line layout and try to detect whether it has any whitespace after it that we ought to ignore, then
we need to skip past out-of-flow and floating objects when looking for that whitespace. Failure to do so will result in us
adding the width from the first space we encounter to our line width and over-estimating the real width of the line.

We're hitting this bug now because we have broadened the category of empty inlines that get lineboxes so we go into line layout
and have to deal with them and their subsequent whitespace there. Previously this sort of whitespace would have been simply
consumed by |skipLeadingWhitespace|.

Test: fast/inline/out-of-flow-objects-and-whitespace-after-empty-inline.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::shouldSkipWhitespaceAfterStartObject):

LayoutTests:

• fast/inline/out-of-flow-objects-and-whitespace-after-empty-inline-expected.txt: Added.
• fast/inline/out-of-flow-objects-and-whitespace-after-empty-inline.html: Added.

12:14 PM Changeset in webkit [148222] by ojan@chromium.org

• 2 edits in trunk/Tools

Remove myself from watchlists.

• Scripts/webkitpy/common/config/watchlist:

11:56 AM Changeset in webkit [148221] by rniwa@webkit.org

• 18 edits in trunk

Autocorrected text doesn't have a marker of type autocorrected
​https://bugs.webkit.org/show_bug.cgi?id=114337

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by markAndReplaceFor's text replacement errornously assuming that there are
no other text checking result starting at the same offset. That resulted in us adjusting location
offsets of the subsequent results pointing at the replaced text, hit an assertion, and blow up.

Fixed the bug by skipping all remaining results for the replaced text since they're no longer
applicable.

Tests: Existing autocorection tests have been updated to assert new behavior.

• editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):

LayoutTests:

Updated tests to assert the existence of "autocorrected" markers.

• platform/mac/editing/spelling/click-autocorrected-word-expected.png:
• platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
• platform/mac/editing/spelling/click-autocorrected-word.html:
• platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
• platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
• platform/mac/editing/spelling/delete-into-autocorrected-word.html:
• platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png:
• platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
• platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html:
• platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png:
• platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
• platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html:
• platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png:
• platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:
• platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html:

11:54 AM Changeset in webkit [148220] by Michelangelo De Simone

• 8 edits
  6 adds in trunk

[CSS Shaders] Parse the geometry descriptor
​https://bugs.webkit.org/show_bug.cgi?id=110815

Source/WebCore:

Added initial parsing for the "geometry" descriptor, as per specification:
​https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#geometry
This descriptor allows to specify the mesh geometry for custom filters.

Reviewed by Dirk Schulze.

Tests: css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid.html

css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGeometry): New method that parses the geometry
descriptor (grid()).
(WebCore):

• css/CSSParser.h:
• css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

• css/CSSPropertyNames.in: Added conditional "geometry" property.
• css/CSSValueKeywords.in: Added conditional "attached" value keyword; detached

was already there.

LayoutTests:

Positive and negative parsing tests for the "geometry" descriptor as
per specification:
​https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#geometry

Reviewed by Dirk Schulze.

• css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid-expected.txt: Added.
• css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid.html: Added.
• css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid-expected.txt: Added.
• css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid.html: Added.
• css3/filters/custom-with-at-rule-syntax/script-tests/parsing-geometry-property-invalid.js: Added.

(testInvalidGeometryProperty):

• css3/filters/custom-with-at-rule-syntax/script-tests/parsing-geometry-property-valid.js: Added.

(testGeometryProperty):

11:43 AM Changeset in webkit [148219] by andersca@apple.com

• 6 edits in trunk/Source

Make StorageAreaMap dispatch session storage events
​https://bugs.webkit.org/show_bug.cgi?id=114454

Reviewed by Beth Dakin.

Source/WebCore:

Export storage symbols and headers needed by WebKit2.

• WebCore.exp.in:
• WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::dispatchStorageEvent):
Depending on the storage area type, call dispatchSessionStorageEvent or dispatchLocalStorageEvent.

(WebKit::StorageAreaMap::dispatchSessionStorageEvent):
Enumerate all the frames in our page and dispatch the event to the relevant ones.

(WebKit::StorageAreaMap::dispatchLocalStorageEvent):
Add empty stub for now.

11:39 AM Changeset in webkit [148218] by zandobersek@gmail.com

• 2 edits in trunk

Unreviewed.

• Source/autotools/symbols.filter: Stop exporting redundant symbols.

11:27 AM Changeset in webkit [148217] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Removing expectations for a bunch of tests that are passing.

11:19 AM Changeset in webkit [148216] by rniwa@webkit.org

• 2 edits in trunk/Tools

Build fix. Don't hard-code queues.webkit.org at least during the transition.

• QueueStatusServer/templates/statusbubble.html:

10:44 AM Changeset in webkit [148215] by andersca@apple.com

• 9 edits in trunk/Source/WebKit2

Implement more logic in StorageAreaMap
​https://bugs.webkit.org/show_bug.cgi?id=114451

Reviewed by Alexey Proskuryakov.

• Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add new overload.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::addListener):
(WebKit::StorageManager::StorageArea::removeListener):
These take storage map IDs.

(WebKit::StorageManager::StorageArea::setItem):
Rename storageAreaID to sourceStorageAreaID.

(WebKit::StorageManager::StorageArea::dispatchEvents):
Remove the code that would not dispatch to the source connection, there may still be storage areas interested in those events.

(WebKit::StorageManager::setItem):
This now takes the source storage area ID.

(WebKit::StorageManager::findStorageArea):
This takes a storage map ID.

• UIProcess/Storage/StorageManager.messages.in:

SetItem now takes the source storage area ID as well.

• WebProcess/Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::setItem):
Pass the source frame to StorageAreaMap::setItem.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::StorageAreaMap):
Send CreateStorageMap and add the object as a message receiver.

(WebKit::StorageAreaMap::~StorageAreaMap):
Send DestroyStorageMap and remove the object as a message receiver.

(WebKit::StorageAreaMap::length):
(WebKit::StorageAreaMap::key):
(WebKit::StorageAreaMap::item):
(WebKit::StorageAreaMap::contains):
Load values and forward calls to the storage map.

(WebKit::StorageAreaMap::setItem):
This now takes the source frame as well. Update the local storage map and send a SetItem message.

(WebKit::StorageAreaMap::loadValuesIfNeeded):
Get the values from the storage manager.

(WebKit::StorageAreaMap::dispatchStorageEvent):
This now takes the source storage area ID.

• WebProcess/Storage/StorageAreaMap.messages.in:

DispatchStorageEvent now takes the source storage area ID.

10:18 AM Changeset in webkit [148214] by beidson@apple.com

• 5 edits in trunk

Web/Plugin process deadlock initializing async plugins.
<rdar://problem/13525232> and ​https://bugs.webkit.org/show_bug.cgi?id=114217

Rubberstamped by Anders Carlsson.

Rollout r147953 and r147968 as we identified other causes for this.

Source/WebKit2:

• PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPluginAsynchronously):

• WebProcess/Plugins/PluginProxy.messages.in:

LayoutTests:

• platform/mac-wk2/TestExpectations:

10:02 AM Changeset in webkit [148213] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[WK2] Run toString & valueOf LayoutTests for WebKit2 also
​https://bugs.webkit.org/show_bug.cgi?id=114433

Patch by Arunprasad Rajkumar <​arunprasadr@nds.com> on 2013-04-11
Reviewed by Anders Carlsson.

• platform/wk2/TestExpectations:

9:55 AM Changeset in webkit [148212] by rniwa@webkit.org

• 2 edits in trunk/Tools

Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
​https://bugs.webkit.org/show_bug.cgi?id=114397

Reviewed by Benjamin Poulain.

Reland the patch since Alan appears to have finished the migration.

• Scripts/webkitpy/common/net/statusserver.py:

(StatusServer):

9:52 AM Changeset in webkit [148211] by allan.jensen@digia.com

• 2 edits in trunk/Source/WebCore

handleMouseMoveEvent should let hit-testing hit-test scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=114430

Reviewed by Antonio Gomes.

Allow hit-testing to hit-test frame scrollbars so handleMouseMoveEvent
does not have to do it itself.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseMoveEvent):

9:38 AM Changeset in webkit [148210] by commit-queue@webkit.org

• 7 edits
  2 adds in trunk

[Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=76796

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-04-11
Reviewed by Chris Fleizach.

Source/WebCore:

When using caret-browsing with the right and left arrows, the
behaviour of menuLists should be the same as listBoxes. This means
not default-handling the event and passing it up the stack instead.

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::menuListDefaultEventHandler):

Tools:

Make the Gtk window for the DRT a toplevel so that it gets the
focus from the window manager when the test starts.

• DumpRenderTree/gtk/DumpRenderTree.cpp:

(main):

LayoutTests:

Adding a new test to verify that it is possible to arrow out of
combo boxes when caret browsing is enabled. Updated failing tests
to reflect changed accessibility events in the DRT.

• platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Updated.
• platform/gtk/accessibility/caret-browsing-select-focus-expected.txt: Added.
• platform/gtk/accessibility/caret-browsing-select-focus.html: Added.
• platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Updated.

9:32 AM Changeset in webkit [148209] by ap@apple.com

• 17 edits in trunk/Source

Remove some ResourceHandle.h includes
​https://bugs.webkit.org/show_bug.cgi?id=114416

Reviewed by Ryosuke Niwa.

Source/WebCore:

• loader/CrossOriginAccessControl.h:
• loader/CrossOriginPreflightResultCache.h:

These files don't need ResourceHandle.h, just ResourceHandleTypes.h.

• loader/TextTrackLoader.cpp:
• loader/ThreadableLoader.h:
• loader/appcache/ApplicationCacheGroup.h:
• loader/cache/MemoryCache.h:
• loader/mac/ResourceLoaderMac.mm:
• page/Settings.cpp:
• platform/network/AuthenticationChallengeBase.cpp:
• platform/network/cf/CookieJarCFNet.cpp:
• platform/network/cf/ResourceRequestCFNet.cpp:
• xml/XSLTProcessorLibxslt.cpp:
• xml/parser/XMLDocumentParser.cpp:
• xml/parser/XMLDocumentParserLibxml2.cpp:

Just straightforward removal of includes.

Source/WebKit2:

• WebProcess/Network/NetworkProcessConnection.cpp: Added an include that is now

necessary.

9:19 AM Changeset in webkit [148208] by allan.jensen@digia.com

• 9 edits in trunk

Use CSS4 image-rendering to determing image scaling quality
​https://bugs.webkit.org/show_bug.cgi?id=113405

Reviewed by Simon Fraser.

Source/WebCore:

Implement the new CSS4 image-rendering property values.

Image scaling now uses low-quality (pixelated) scaling for
crisp-edges, pixelated and optimizeSpeed values, and always
use high quality (smooth) scaling for -webkit-smooth and
optimizeQuality. The latter can be used to disable low quality
scaling during CSS animations or live resizing.

The new values are protected with a new CSS4_IMAGES feature, but
the crisp-edge value has been introduced before to displace the
deprecated -webkit-optimize-contrast value, and optimizeSpeed
and optimizeQuality values are supported for SVG compatibility.

• css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EImageRendering):

• css/CSSValueKeywords.in:
• rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::shouldPaintAtLowQuality):

• rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::paintReplaced):

• rendering/style/RenderStyleConstants.h:

Tools:

Introduce new flag to enable experimental support for CSS4 Images.

• Scripts/webkitperl/FeatureList.pm:

9:19 AM Changeset in webkit [148207] by msaboff@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Added UNLIKELY() suggested in ​https://bugs.webkit.org/show_bug.cgi?id=114366
after checking in the original change.

Rubber-stamped by Jessie Berlin.

• dfg/DFGOperations.cpp:

9:02 AM Changeset in webkit [148206] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Build fix: use of uninitialized variable in ScrollingStateTree
​https://bugs.webkit.org/show_bug.cgi?id=114443

Patch by Adenilson Cavalcanti <​cavalcantii@gmail.com> on 2013-04-11
Reviewed by Anders Carlsson.

Initialize pointer to zero before use, fixes build.
No new tests, no changes on behavior.

• page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::attachNode):

8:55 AM Changeset in webkit [148205] by krit@webkit.org

• 8 edits
  6 adds in trunk

[CSS Shaders] Parse mix descriptor
​https://bugs.webkit.org/show_bug.cgi?id=114414

Reviewed by Antti Koivisto.

Source/WebCore:

Add support for the 'mix' descriptor in the filter at-rule to support blend modes
and composite operators in CSS Shaders.
Each pixel in the fragment shader will be blended and composited with the
backdrop by taking these values into account.

​https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-mix

Tests: css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid.html

css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

• css/CSSParser.cpp: Added 'mix' property and fail parsing if not inside

of an @filter rule.

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilterRuleMix): New helper function to verify

values.

(WebCore):

• css/CSSParser.h:
• css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

• css/CSSPropertyNames.in: Added new property name 'mix'.
• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

Tests for the 'mix' descriptor on @filter rule.

• css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid-expected.txt: Added.
• css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid.html: Added.
• css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid-expected.txt: Added.
• css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid.html: Added.
• css3/filters/custom-with-at-rule-syntax/script-tests/parsing-mix-property-invalid.js: Added.

(testInvalidMixProperty):

• css3/filters/custom-with-at-rule-syntax/script-tests/parsing-mix-property-valid.js: Added.

(testMixProperty):

8:09 AM Changeset in webkit [148204] by abecsi@webkit.org

• 2 edits in trunk/Source/ThirdParty/ANGLE

[Qt][Mac] Linking fails with Qt 5.1
​https://bugs.webkit.org/show_bug.cgi?id=114435

Reviewed by Tor Arne Vestbø.

Qt 5.1 enables C++11 by default when using clang on Mac
and links against the libc++ standard library. As a result
building the QtWebKit shared library fails when linking
agains the ANGLE intermediate static library because libc++
misses some symbols needed by ANGLE.
Disable C++11 for the ANGLE intermediate library to fix the build.

• ANGLE.pri:

7:51 AM Changeset in webkit [148203] by commit-queue@webkit.org

• 5 edits in trunk

Parent box with background-size auto and gradient image does not get properly repainted when child box is resized.
​https://bugs.webkit.org/show_bug.cgi?id=114424

Source/WebCore:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-11
Reviewed by Antti Koivisto.

Initiate full repaint on fill layer, when the image is generated and the background
property defines auto size.
​http://www.w3.org/TR/css3-background/#background-size
'If the image has neither an intrinsic width nor an intrinsic height, its size is determined as for 'contain'.'

Extended fast/repaint/background-shorthand-with-gradient-and-height-changes.html
to cover this case too.

• rendering/RenderObject.cpp:

(WebCore::mustRepaintFillLayers):

LayoutTests:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-11
Reviewed by Antti Koivisto.

• fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt:
• fast/repaint/background-shorthand-with-gradient-and-height-changes.html:

7:42 AM Changeset in webkit [148202] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK][AC] use a smart pointer for GList and ClutterCanvas
​https://bugs.webkit.org/show_bug.cgi?id=114057

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-11
Reviewed by Gustavo Noronha Silva.

We can make simple code & prevent possible memory leak by using a proper smart pointer.
Especially if we get children by clutter_actor_get_children, we should free it after using.

No functionality changed.

• platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorUpdateTexture):
(graphicsLayerActorRemoveAll):

7:36 AM Changeset in webkit [148201] by anilsson@rim.com

• 3 edits in trunk/Source/WebCore

[BlackBerry][CSS Filters] Blur filter fails to recompute blur size when layer size changes
​https://bugs.webkit.org/show_bug.cgi?id=114272

Reviewed by Rob Buis.

Blur appeared blocky or pixelated when surface changed size after
creating the filter actions. The initial image size was used to
determine the blur size (expressed in texture coordinate system).
Fixed by recomputing the blur size when the surface size changes, using
a new Uniform1f subclass that can use a functor to compute the uniform
value per-frame.

This fixes css3/filters/effect-blur-hw.html. This can only be verified
by manual inspection because the BlackBerry port is not currently using
pixel tests.

PR 323730

• platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore):
(SurfaceFunctor):
(WebCore::SurfaceFunctor::SurfaceFunctor):
(InverseSurfaceWidth):
(WebCore::InverseSurfaceWidth::InverseSurfaceWidth):
(WebCore::InverseSurfaceWidth::operator()):
(InverseSurfaceHeight):
(WebCore::InverseSurfaceHeight::InverseSurfaceHeight):
(WebCore::LayerFilterRenderer::actionsForOperations):

• platform/graphics/blackberry/LayerFilterRenderer.h:

(Uniform1f):
(WebCore):
(Uniform1fWithFunctor):
(WebCore::Uniform1fWithFunctor::create):
(WebCore::Uniform1fWithFunctor::Uniform1fWithFunctor):
(WebCore::Uniform1fWithFunctor::apply):
(WebCore::Uniform1f::createWithFunctor):

7:28 AM Changeset in webkit [148200] by anilsson@rim.com

• 4 edits in trunk/Source/WebCore

[BlackBerry] Accelerated compositing debug rectangle incorrectly drawn for layers with surfaces
​https://bugs.webkit.org/show_bug.cgi?id=114275

Reviewed by Carlos Garcia Campos.

The drawDebugBorder method was updated to mirror the logic in
compositeLayersRecursive, i.e. if we're compositing a surface to the
screen, use the transformed bounds stored in the surface. The bounds
stored in the layer should only be used when drawing the layer to the
surface.

Speaking of which, also update the code to skip border drawing when
drawing a layer to a surface. Drawing the borders inside the surface
would only result in messing up the surface contents, especially when
CSS filters like blur were the reason for having a surface in the first
place - the border would be blurred and hard to discern.

Only manually testable, the debug border is disabled during layout
tests.

PR 323746

• platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::drawDebugBorder):

• platform/graphics/blackberry/LayerRendererSurface.cpp:

(WebCore::LayerRendererSurface::drawRect):
(WebCore::LayerRendererSurface::transformedBounds): Added.
(WebCore):

• platform/graphics/blackberry/LayerRendererSurface.h:

(LayerRendererSurface):

7:27 AM Changeset in webkit [148199] by anilsson@rim.com

• 2 edits in trunk/Source/WebCore

[BlackBerry] Compiler warning in LayerWebKitThread.cpp
​https://bugs.webkit.org/show_bug.cgi?id=114277

Reviewed by Carlos Garcia Campos.

All the relevant WTF::Vector APIs use size_t, storing the position in
an int resulted in a compiler warning. Fixed by switching to size_t.

No change in behavior, no new tests.

PR 323753

• platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::remove):
(WebCore::LayerWebKitThread::replaceSublayer):

6:39 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

6:36 AM Changeset in webkit [148198] by Carlos Garcia Campos

• 3 edits
  8 adds in releases/WebKitGTK/webkit-2.0

Merge r148182 - FrameLoaderClient::assignIdentifierToInitialRequest() not called for the main resource when loaded from the memory cache
​https://bugs.webkit.org/show_bug.cgi?id=112418

Source/WebCore:

Reviewed by Darin Adler.

When the main resource is loaded from the memory cache the
response is not added to the ResponseVector of the document
loader, so that when committing the provisional load the remaining
delegate messages are not called because the ResponseVector of the
document loader is empty. When the main resource is loaded from
the memory cache, there's no resource loader, and the client is
notified about the response received using
ResourceLoadNotifier::dispatchDidReceiveResponse() directly
instead of ResourceLoadNotifier::didReceiveResponse() which is the
one adding the response to the ResponseVector of the document
loader. So, the problem can be fixed by adding the response to the
ResponseVector before calling dispatchDidReceiveResponse() when
loading the main resource without a resource loade

Test: loader/go-back-cached-main-resource.html

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

LayoutTests:

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-11
Reviewed by Darin Adler.

• loader/go-back-cached-main-resource-expected.txt: Added.
• loader/go-back-cached-main-resource.html: Added.
• loader/resources/first-page.html: Added.
• loader/resources/other-page.html: Added.
• platform/gtk-wk1/loader/go-back-cached-main-resource-expected.txt: Added.
• platform/wk2/loader/go-back-cached-main-resource-expected.txt: Added.

6:16 AM Changeset in webkit [148197] by mikhail.pozdnyakov@intel.com

• 15 edits
  2 adds in trunk/Source/WebCore

[CoordinatedGraphics] Use ScrollingStateTree to handle fixed elements positioning while scrolling
​https://bugs.webkit.org/show_bug.cgi?id=114353

Reviewed by Noam Rosenthal.

ScrollingCoordinatorCoordinatedGraphics should implement threaded scrolling interface and
re-use threaded scrolling approach (ScrollingStateTree and ViewportConstraints) to handle
fixed/sticky elements positioning while scrolling. The rationals are below.

Before the change ScrollingCoordinatorCoordinatedGraphics was implementing Chromium-specific
interface which is going to be removed eventually as there is no ScrollingCoordinatorChromium
existing.

Tested by existing manual tests (fixed-position.html for example.

• CMakeLists.txt:
• Target.pri:

Included ScrollingStateTree files.

• page/scrolling/ScrollingStateFixedNode.cpp:
• page/scrolling/ScrollingStateFixedNode.h:
• page/scrolling/ScrollingStateNode.cpp:
• page/scrolling/ScrollingStateNode.h:
• page/scrolling/ScrollingStateScrollingNode.cpp:
• page/scrolling/ScrollingStateScrollingNode.h:
• page/scrolling/ScrollingStateStickyNode.cpp:
• page/scrolling/ScrollingStateStickyNode.h:
• page/scrolling/ScrollingStateTree.cpp:
• page/scrolling/ScrollingStateTree.h:

Removed ENABLE(THREADED_SCROLLING) code guards.

• page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:

(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::~ScrollingCoordinatorCoordinatedGraphics):
(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::attachToStateTree):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::detachFromStateTree):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::clearStateTree):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::updateViewportConstrainedNode):

• page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:

ScrollingCoordinatorCoordinatedGraphics is using threaded scrolling approach to handle fixed
elements positioning while scrolling.

(WebCore):
(ScrollingCoordinatorCoordinatedGraphics):

• page/scrolling/coordinatedgraphics/ScrollingStateNodeCoordinatedGraphics.cpp: Added.

(WebCore):
(WebCore::ScrollingStateNode::platformScrollLayer):
(WebCore::ScrollingStateNode::setScrollPlatformLayer):
(WebCore::ScrollingStateNode::setScrollLayer):

• page/scrolling/coordinatedgraphics/ScrollingStateScrollingNodeCoordinatedGraphics.cpp: Added.

(WebCore):
(WebCore::ScrollingStateScrollingNode::counterScrollingPlatformLayer):
(WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer):

5:49 AM Changeset in webkit [148196] by zarvai@inf.u-szeged.hu

• 1 edit
  1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening. Remove platform specific expected after r148195.

• platform/qt/fast/events/backspace-navigates-back-expected.txt: Removed.

4:46 AM Changeset in webkit [148195] by allan.jensen@digia.com

• 7 edits in trunk/Source

[Qt] EventHandler should handle Space and BackSpace
​https://bugs.webkit.org/show_bug.cgi?id=114428

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Enable default space-handling for Qt.

• page/EventHandler.cpp:

Source/WebKit/qt:

Remove our own handling of space and backspace.

• WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::handleScrolling):

• WidgetApi/qwebpage.cpp:

(QWebPagePrivate::keyPressEvent):

Source/WebKit2:

Remove our own handling of space and backspace.

• WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

4:37 AM Changeset in webkit [148194] by rakuco@webkit.org

• 2 edits in trunk/Source/WebCore

IconDatabase: Simplify boolean logic in assertion.
​https://bugs.webkit.org/show_bug.cgi?id=114425

Reviewed by Andreas Kling.

Follow-up to r148097; drop the overzealous use of !! to turn a
PassRefPtr into a boolean.

• loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::updateIconRecord):

4:28 AM Changeset in webkit [148193] by zarvai@inf.u-szeged.hu

• 2 edits
  4 adds in trunk/LayoutTests

[Qt] Unreviewed gardending. Greening bots.

• platform/qt-5.0-wk1/loader/go-back-cached-main-resource-expected.txt: Rebaselining after r148182.
• platform/qt-5.0-wk2/loader/go-back-cached-main-resource-expected.txt: Rebaselining after r148182.
• platform/qt/TestExpectations:

4:11 AM Changeset in webkit [148192] by anilsson@rim.com

• 14 edits in trunk/Source

[BlackBerry] LayerTexture refactoring
​https://bugs.webkit.org/show_bug.cgi?id=114276

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Remove the GpuHandle and HostType typedefs from LayerTexture, they
don't make any sense now that we removed the Skia code paths. With Skia
they used to be an OpenGL texture ID and an SkBitmap respectively, but
now it's just BlackBerry::Platform::Graphics::Buffer all around.

This allows us to rename textureId() into buffer() which is more to the
point. The texture ID concept is now up for grabs and can be used to
consolidate all the various code for extracting an OpenGL texture from
a BlackBerry::Platform::Graphics::Buffer. This opportunity is seized in
LayerTexture::platformTexture(), a name which makes more sense than
textureId() for anyone familiar with the GraphicsContext3D code. We can
also leverage the Platform3DObject typedef to avoid including gl2.h.

The vertex attribute state was getting trampled when interacting with
BlackBerry::Platform::Graphics in the LayerFilterRenderer. Some
additional GL state save/restore incantations when accessing the OpenGL
texture for a LayerTexture in the new LayerTexture::platformTexture()
method fixes various CSS Filters test cases.

Since we removed the Skia integration from LayerTiler, nobody cares
about the dirty rect, tile rect or opaqueness of the tile contents. So
remove those parameters from the updateContents code path.

No change in behavior except for fixing CSS Filters tests like
css3/filters/effect-blur-hw.html. This can only be verified by manually
looking at the tests, we don't have pixel test support to catch this
kind of regression.

PR 322882

• platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawSurface):

• platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRenderer::ping):
(WebCore::LayerFilterRenderer::pong):
(WebCore::LayerFilterRenderer::pushSnapshot):
(WebCore::LayerFilterRenderer::popSnapshot):
(WebCore::LayerFilterRenderer::applyActions):

• platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::useSurface):

• platform/graphics/blackberry/LayerTexture.cpp:

(WebCore::LayerTexture::LayerTexture):
(WebCore::LayerTexture::updateContents):
(WebCore::LayerTexture::setContentsToColor):
(WebCore::LayerTexture::protect):
(WebCore::LayerTexture::platformTexture):
(WebCore):

• platform/graphics/blackberry/LayerTexture.h:

(WebCore::LayerTexture::isDirty):
(WebCore::LayerTexture::buffer):
(LayerTexture):
(WebCore::LayerTexture::setBuffer):

• platform/graphics/blackberry/LayerTile.cpp:

(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):

• platform/graphics/blackberry/LayerTile.h:

(WebCore::LayerTile::hasTexture):
(LayerTile):

• platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTile):

• platform/graphics/blackberry/LayerTiler.h:

(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::updateContents):
(TextureJob):
(LayerTiler):

• platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureCacheCompositingThread::createBuffer):
(WebCore::TextureCacheCompositingThread::collectGarbage):
(WebCore::TextureCacheCompositingThread::install):
(WebCore::TextureCacheCompositingThread::resizeTexture):
(WebCore::TextureCacheCompositingThread::evict):
(WebCore::TextureCacheCompositingThread::textureForContents):
(WebCore::TextureCacheCompositingThread::updateContents):

• platform/graphics/blackberry/TextureCacheCompositingThread.h:

(TextureCacheCompositingThread):
(WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
(ZombieTexture):

Source/WebKit/blackberry:

Adapt to the LayerTexture refactoring down in WebCore.

PR 322882

• Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):

4:04 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

4:00 AM Changeset in webkit [148191] by Carlos Garcia Campos

• 40 edits
  2 moves
  2 adds
  2 deletes in releases/WebKitGTK/webkit-2.0/Source

Merge r147924 - [GTK] DOM objects created wrapping a base class have incorrect GObject type
​https://bugs.webkit.org/show_bug.cgi?id=113132

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Some of the DOM methods can create a concrete instance of another
object, but return a base class. GObject bindings provide custom
kit implementations for Node, Element, Event and EvenTarget, so
any concrete HTMLElement wrapped as an HTMLElement ends up
wrapping the right WebCore object but in the wrong GObject type.
This affects not only HTMLElements, but any polymorphic object
wrapped using a base class.
This patch changes the way objects are created, so that all
classes have their own kit implementation, but for polymorphic
objects the kit implementation of the base class is always
used. The kit method of polymorphic base classes use a generic
wrap method instead of the wrapFoo method like all other
classes. In the static code we provide the implementation of the
generic wrap method for every polimorphic base class, falling back
to their wrapFoo method if the concrete object can't be used to
wrap the object.
Both WebKitDOMBinding and WebKitHTMLElementWrapperFactory now provide
implementations of wrap and have been renamed to WebKitDOMPrivate
and WebKitDOMHTMLPrivate.

• bindings/gobject/GNUmakefile.am:
• bindings/gobject/WebKitDOMBinding.cpp: Removed.
• bindings/gobject/WebKitDOMEventTarget.cpp:

(WebKit::kit): Moved kit implementation from WebKitDOMBinding for
consistency with all other objects that have their own kit.
(WebKit::core): Updated to match the core implementation fo all
other objects.

• bindings/gobject/WebKitDOMEventTargetPrivate.h:

(WebCore):
(WebKit):

• bindings/gobject/WebKitDOMHTMLPrivate.cpp: Added.

(WebKit): Use preprocessor macros to define and set the wrap
functions of all HTML elements, removing a lot of boilerplate code
and making it easier to add new wrap functions in the future.
(WebKit::wrap):

• bindings/gobject/WebKitDOMHTMLPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.h.

(WebCore):
(WebKit):

• bindings/gobject/WebKitDOMObject.cpp:
• bindings/gobject/WebKitDOMPrivate.cpp: Added.

(WebKit):
(WebKit::wrap):

• bindings/gobject/WebKitDOMPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitDOMBinding.h.

(WebCore):
(WebKit):

• bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Removed.
• bindings/scripts/CodeGeneratorGObject.pm:

(IsBaseType): Helper function to check if a type is a base class.
(GetBaseClass): Helper function to get the base class for a given
parent type.
(GenerateFunction): Remove special case for EventTarget since the
kit prototype of EventTarget is in its private header like all
other objects.
(GenerateCFile): Add a kit implementation for all objects.
(IsPolymorphic): Helper function to check if the given type is the
base class of a polymorphic object.
(Generate): Include the private header of the base class for
polymorphic objects.
(WriteData): Remove the special case for WebKitDOMNode since now
all objects has a kit method.

• bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:

(WebKit::kit):

• bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:

(WebKit):

• bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:

(WebKit):

• bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:

(WebKit):

• bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h:

(WebKit):

• bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h:

(WebKit):

• bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h:

(WebKit):

• bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h:

(WebKit):

• bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:

(WebKit):

• bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:

(WebKit):

• bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h:

(WebKit):

• bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:

(WebKit::kit):

• bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h:

(WebKit):

• bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:

(WebKit):

• bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsPrivate.h:

(WebKit):

• bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:

(WebKit):

• bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestTypedefsPrivate.h:

(WebKit):

Source/WebKit/gtk:

Remove WebKitDOMBindindg.h include from several files because it's
been renamed and it was not actually needed.

• WebCoreSupport/ChromeClientGtk.cpp:
• WebCoreSupport/EditorClientGtk.cpp:
• webkit/webkithittestresult.cpp:

3:00 AM Changeset in webkit [148190] by rniwa@webkit.org

• 3 edits in trunk/Tools

Remove code for Chromium from wkbuild.py
​https://bugs.webkit.org/show_bug.cgi?id=114423

Reviewed by Benjamin Poulain.

• BuildSlaveSupport/build.webkit.org-config/wkbuild.py:

(_should_file_trigger_build):

• BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:

(ShouldBuildTest):

2:49 AM Changeset in webkit [148189] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[BlackBerry] RenderThemeBlackBerry: upstream missing code
​https://bugs.webkit.org/show_bug.cgi?id=114343

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-11
Reviewed by Xan Lopez.

Add implementations of sliderTickSize() and
sliderTickOffsetFromTrackCenter(), as well as a missing header.

• platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore):
(WebCore::RenderThemeBlackBerry::sliderTickSize):
(WebCore::RenderThemeBlackBerry::sliderTickOffsetFromTrackCenter):

• platform/blackberry/RenderThemeBlackBerry.h:

(RenderThemeBlackBerry):

2:17 AM Changeset in webkit [148188] by allan.jensen@digia.com

• 4 edits in trunk/Source/WebCore

HitTestRequest::AllowFrameScrollbars does not test main frame scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=112563

Reviewed by Antonio Gomes.

Move the frame scrollbar testing from RenderPart to RenderView, so that it is
tested by all frame and not just child frames. At the same time remove the
main frame test from the one current callsite using the option.

Tested by fast/events/touch/gesture/gesture-scrollbar.html.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

• rendering/RenderPart.cpp:

(WebCore::RenderPart::nodeAtPoint):

• rendering/RenderView.cpp:

(WebCore::RenderView::hitTest):

2:09 AM Changeset in webkit [148187] by Philippe Normand

• 2 edits in trunk/Tools

Unreviewed, update my IRC nickname.

• Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.

2:00 AM Changeset in webkit [148186] by commit-queue@webkit.org

• 19 edits in trunk

Incorrect evaluation of resolution media queries
​https://bugs.webkit.org/show_bug.cgi?id=114029

Patch by Rune Lillesveen <​rune@opera.com> on 2013-04-11
Reviewed by Kenneth Rohde Christiansen.

.:

Removed setResolutionOverride from exports.

• Source/autotools/symbols.filter:

Source/WebCore:

The implementation used the physical resolution to evaluate the
resolution media features. Changed to use the actual CSS resolution,
also known as the device-pixel-ratio, instead. Unified the code for
evaluating the resolution and device-pixel-ratio media features.

No new tests, covered by existing tests.

• WebCore.exp.in:
• css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isResolution):

• css/MediaQueryEvaluator.cpp:

(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):

• page/Screen.cpp:
• page/Screen.h:
• page/Settings.cpp:

(WebCore):

• page/Settings.h:

(Settings):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

• testing/InternalSettings.h:

(Backup):
(InternalSettings):

• testing/InternalSettings.idl:

Source/WebKit:

Removed setResolutionOverride from exports.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

Removed setResolutionOverride from exports.

• WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

Modified tests to change CSS resolution instead of physical resolution.

• fast/media/mq-resolution.html:

1:46 AM Changeset in webkit [148185] by rniwa@webkit.org

• 15 edits
  1 delete in trunk/Tools

Remove the rest of Chromium code from webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=114420

Reviewed by Benjamin Poulain.

• Scripts/webkitpy/common/config/urls.py:

(view_revision_url):

• Scripts/webkitpy/common/host.py:

(Host._engage_awesome_locale_hacks):
(Host.initialize_scm):
(Host):

• Scripts/webkitpy/common/host_mock.py:

(MockHost.init):
(MockHost.checkout):

• Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
• Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase._insert_generic_metadata):

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._tokenize_line):

• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(ExpectationSyntaxTests.test_bare_name_and_bugs):
(ExpectationSyntaxTests.test_warnings):

• Scripts/webkitpy/layout_tests/port/base.py:

(Port.skips_perf_test):
(Port.path_to_test_expectations_file):
(Port._port_flag_for_scripts):

• Scripts/webkitpy/style/checkers/cpp.py:

(check_function_definition):
(check_include_line):

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_check_wtf_includes):
(WebKitStyleTest.test_webkit_export_check):

• Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.test_valid_expectations):

• Scripts/webkitpy/tool/bot/irc_command.py:

(Rollout.execute):

• Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_whois):

• Scripts/webkitpy/tool/bot/ircbot_unittest.py:

(IRCBotTest.test_help):

• Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

(SheriffBotTest.test_command_aliases):

1:29 AM Changeset in webkit [148184] by rniwa@webkit.org

• 2 edits in trunk/Tools

roll-chromium-deps doesn't roll DEPS
​https://bugs.webkit.org/show_bug.cgi?id=114421

Reviewed by Antti Koivisto.

Roll DEPS. Rolling DEPS. Rolled DEPS.

• Scripts/webkitpy/tool/bot/irc_command.py:

(RollChromiumDEPS.execute):

1:27 AM Changeset in webkit [148183] by glenn@skynav.com

• 3 edits in trunk/Tools

[webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
​https://bugs.webkit.org/show_bug.cgi?id=114418

Reviewed by Ryosuke Niwa.

• Scripts/webkitpy/common/checkout/scm/scm_mock.py:

(MockSCM.add): Remove optional remove_exit_code argument.
(MockSCM.add_list): Remove optional remove_exit_code argument and return value.

• Scripts/webkitpy/tool/servers/rebaselineserver.py:

(_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
(_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.

1:25 AM Changeset in webkit [148182] by Carlos Garcia Campos

• 3 edits
  8 adds in trunk

FrameLoaderClient::assignIdentifierToInitialRequest() not called for the main resource when loaded from the memory cache
​https://bugs.webkit.org/show_bug.cgi?id=112418

Source/WebCore:

Reviewed by Darin Adler.

When the main resource is loaded from the memory cache the
response is not added to the ResponseVector of the document
loader, so that when committing the provisional load the remaining
delegate messages are not called because the ResponseVector of the
document loader is empty. When the main resource is loaded from
the memory cache, there's no resource loader, and the client is
notified about the response received using
ResourceLoadNotifier::dispatchDidReceiveResponse() directly
instead of ResourceLoadNotifier::didReceiveResponse() which is the
one adding the response to the ResponseVector of the document
loader. So, the problem can be fixed by adding the response to the
ResponseVector before calling dispatchDidReceiveResponse() when
loading the main resource without a resource loade

Test: loader/go-back-cached-main-resource.html

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

LayoutTests:

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-11
Reviewed by Darin Adler.

• loader/go-back-cached-main-resource-expected.txt: Added.
• loader/go-back-cached-main-resource.html: Added.
• loader/resources/first-page.html: Added.
• loader/resources/other-page.html: Added.
• platform/gtk-wk1/loader/go-back-cached-main-resource-expected.txt: Added.
• platform/wk2/loader/go-back-cached-main-resource-expected.txt: Added.

12:45 AM Changeset in webkit [148181] by rniwa@webkit.org

• 2 edits in trunk/Tools

Fix roll-chromium-deps and hi.

• Scripts/webkitpy/tool/bot/irc_command.py:

(Hi.execute):
(RollChromiumDEPS.execute):

12:40 AM Changeset in webkit [148180] by rniwa@webkit.org

• 10 edits
  7 deletes in trunk/Tools

Remove webkitpy code to roll Chromium DEPS
​https://bugs.webkit.org/show_bug.cgi?id=114415

Reviewed by Benjamin Poulain.

Removed the code to roll Chromium DEPS in WebKit.

• Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.bug_id_for_this_commit):

• Scripts/webkitpy/common/checkout/checkout_mock.py:

(MockCheckout.commit_message_for_this_commit):

• Scripts/webkitpy/common/checkout/checkout_unittest.py:

(CheckoutTest.test_suggested_reviewers):

• Scripts/webkitpy/common/checkout/deps.py: Removed.
• Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
• Scripts/webkitpy/tool/bot/irc_command.py:

(RollChromiumDEPS): Teach webkitbot a sense of humor.
(RollChromiumDEPS.execute):

• Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_create_bug):

• Scripts/webkitpy/tool/bot/ircbot_unittest.py:

(IRCBotTest.test_revert):

• Scripts/webkitpy/tool/bot/sheriff.py:

(Sheriff.post_rollout_patch):

• Scripts/webkitpy/tool/commands/init.py:
• Scripts/webkitpy/tool/commands/roll.py: Removed.
• Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
• Scripts/webkitpy/tool/steps/init.py:
• Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
• Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
• Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.

12:20 AM Changeset in webkit [148179] by Csaba Osztrogonác

• 3 edits in trunk/Source/WebKit2

Unreviewed Qt buildfixes after r148147, r148148 and r148154.

• DerivedSources.pri:
• Target.pri:

12:06 AM Changeset in webkit [148178] by Lucas Forschler

• 1 copy in tags/Safari-537.37

New Tag.

12:03 AM Changeset in webkit [148177] by glenn@skynav.com

• 3 edits in trunk/Tools

[webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
​https://bugs.webkit.org/show_bug.cgi?id=114386

Reviewed by Benjamin Poulain.

Subversion client 1.7 uses a new locking scheme that invalidates the technique used
in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
can be implemented. Further, 1.7 changed svn add to not add intermediate directories
by default and to return exit code 1 if a file/dir had already been added.

• Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(test_svn_lock): Skip body of test if subversion client 1.7 or later.

• Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.

Apr 10, 2013:

11:29 PM Changeset in webkit [148176] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix, fixing the WebKit2 build.

• GNUmakefile.list.am:

11:22 PM Changeset in webkit [148175] by ap@apple.com

• 17 edits in trunk/Source/WebCore

Remove some includes of CachedImage.h
​https://bugs.webkit.org/show_bug.cgi?id=114411

Reviewed by Dan Bernstein.

• css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a definition of a class it holds, but default construction does not.

• rendering/RenderImageResource.cpp:
• rendering/RenderImageResource.h: Moved definitions of virtual functions to a .cpp file. There is no win from having them inline, and now we don't need CachedImage.h in the header.

• bindings/js/JSNodeCustom.cpp:
• dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard):
• platform/mac/ClipboardMac.h:
• rendering/InlineFlowBox.cpp:
• rendering/RenderBox.cpp:
• rendering/RenderListItem.cpp:
• rendering/RenderListMarker.cpp:
• rendering/RenderTableCol.cpp:
• rendering/RenderTableRow.cpp:
• rendering/RenderTableSection.cpp:
• svg/graphics/SVGImageCache.cpp: Removed unnecessary includes.

• platform/mac/PasteboardMac.mm:
• rendering/RenderSnapshottedPlugIn.cpp: Added ones where they are now necessary.

11:19 PM Changeset in webkit [148174] by zandobersek@gmail.com

• 2 edits in trunk/Tools

Unreviewed.

• GNUmakefile.am: Removing extra whitespace that's producing warnings.

11:04 PM Changeset in webkit [148173] by glenn@skynav.com

• 4 edits in trunk/Tools

[webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
​https://bugs.webkit.org/show_bug.cgi?id=114410

Reviewed by Ryosuke Niwa.

• Scripts/webkitpy/common/checkout/scm/git.py:

(Git.add_list): Remove optional return_exit_code argument. Remove return value.

• Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.add): Remove optional return_exit_code argument.
(SCM.add_list): Remove optional return_exit_code argument.

• Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.add_list): Remove optional return_exit_code argument. Remove return value.

10:47 PM Changeset in webkit [148172] by commit-queue@webkit.org

• 8 edits
  19 adds in trunk

Allow direct compositing of background images
​https://bugs.webkit.org/show_bug.cgi?id=108203

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-04-10
Reviewed by Simon Fraser.

Source/WebCore:

Use setContentsToImage for background images, if the GraphicsLayer has only a background
bitmap image and nothing else. Compute the contentsRect/contentsTileRect from the box model.
Added new properties to GraphicsLayer, contentsTilePhase and contentsTileSize, which controls the "single tile rect",
which allows us to compute the pattern-space transform of a tile, thus allowing background-size
and other characteristics of background images.

This feature is explicitly disabled when there is any composition with a background color or if
there are several background images, as in that case having a single backing store has some
advantages over directly compositing in hardware.

Currently, this feature is disabled for all ports, allowing ports to implement their backend
and decide when to enable it.

Note that RenderBoxModelObject::getGeometryForBackgroundImage crops the contents rect to the
area that contains the tiles, which allows us to assume full tiling in GraphicsLayer.
In this way contentsTileSize/Phase is equivalent to GraphicsContext::drawTiledImage.

Tests: compositing/patterns/direct-pattern-compositing-add-text.html

compositing/patterns/direct-pattern-compositing-change.html
compositing/patterns/direct-pattern-compositing-contain.html
compositing/patterns/direct-pattern-compositing-cover.html
compositing/patterns/direct-pattern-compositing-load.html
compositing/patterns/direct-pattern-compositing-padding.html
compositing/patterns/direct-pattern-compositing-position.html
compositing/patterns/direct-pattern-compositing-rotation.html
compositing/patterns/direct-pattern-compositing-size.html
compositing/patterns/direct-pattern-compositing.html

• platform/graphics/GraphicsLayer.h:

(GraphicsLayer):
(WebCore::GraphicsLayer::setContentsTileSize):
(WebCore::GraphicsLayer::setContentsTilePhase):
(WebCore::GraphicsLayer::contentsTileSize):
(WebCore::GraphicsLayer::contentsTilePhase):
(WebCore::GraphicsLayer::supportsContentsTiling):

Add a contentsTileRect property that enables tile-repeat of background images.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::imageChanged):

Pass background image changes to the layer backing.

• rendering/RenderBoxModelObject.cpp:
• rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::getGeometryForBackgroundImage):

Expose a function that performs the geometry calculations needed to determine
the tileRect for a background image. This function is also responsible
for cropping the contentsRect to fit the area that is drawn into.

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents):
(WebCore::RenderLayerBacking::resetContentsRect):
(WebCore::hasBoxDecorationsOrBackgroundImage):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundColor):
(WebCore::canCreateTiledImage):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::backgroundRectForBox):

Allow background images to be directly composited if conditions allow (see bug description).

LayoutTests:

Added several ref-tests as preparation for supporting direct compositing of background
images.

• compositing/patterns/direct-pattern-compositing-add-text-expected.html: Added.
• compositing/patterns/direct-pattern-compositing-add-text.html: Added.
• compositing/patterns/direct-pattern-compositing-change-expected.html: Added.
• compositing/patterns/direct-pattern-compositing-change.html: Added.
• compositing/patterns/direct-pattern-compositing-contain-expected.html: Added.
• compositing/patterns/direct-pattern-compositing-contain.html: Added.
• compositing/patterns/direct-pattern-compositing-cover-expected.html: Added.
• compositing/patterns/direct-pattern-compositing-cover.html: Added.
• compositing/patterns/direct-pattern-compositing-expected.html: Added.
• compositing/patterns/direct-pattern-compositing-load-expected.html: Added.
• compositing/patterns/direct-pattern-compositing-load.html: Added.
• compositing/patterns/direct-pattern-compositing-padding-expected.html: Added.
• compositing/patterns/direct-pattern-compositing-padding.html: Added.
• compositing/patterns/direct-pattern-compositing-position-expected.html: Added.
• compositing/patterns/direct-pattern-compositing-position.html: Added.
• compositing/patterns/direct-pattern-compositing-size-expected.html: Added.
• compositing/patterns/direct-pattern-compositing-size.html: Added.
• compositing/patterns/direct-pattern-compositing.html: Added.

9:59 PM Changeset in webkit [148171] by eric@webkit.org

• 2 edits in trunk/Tools

Remove myself from the watchlists, I'm getting too much bug mail. :)

• Scripts/webkitpy/common/config/watchlist:

8:53 PM Changeset in webkit [148170] by Patrick Gansterer

• 5 edits in trunk/Source/WebCore

Replace ENABLE_LEGACY_WEB_AUDIO preprocessor statements in IDL files with Conditional attribute
​https://bugs.webkit.org/show_bug.cgi?id=114351

Reviewed by Ryosuke Niwa.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

• Modules/webaudio/AudioBufferSourceNode.idl:
• Modules/webaudio/AudioContext.idl:
• Modules/webaudio/AudioParam.idl:
• Modules/webaudio/OscillatorNode.idl:

8:23 PM Changeset in webkit [148169] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Source/WebKit2

[WK2] Build warning in didReceiveMessage() generated by messages.py
​https://bugs.webkit.org/show_bug.cgi?id=112513

Reviewed by Anders Carlsson.

Legacy receiver makes -Wunused-parameter build warnings. This patch is to fix them.

• Scripts/webkit2/messages.py:

(generate_message_handler):

8:21 PM Changeset in webkit [148168] by Patrick Gansterer

• 2 edits in trunk/Source/WebCore

Replace ENABLE_DIRECTORY_UPLOAD preprocessor statements in IDL files with Conditional attribute
​https://bugs.webkit.org/show_bug.cgi?id=114350

Reviewed by Ryosuke Niwa.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

• fileapi/File.idl:

8:17 PM Changeset in webkit [148167] by benjamin@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Unify JSC Parser's error and error message
​https://bugs.webkit.org/show_bug.cgi?id=114363

Reviewed by Geoffrey Garen.

The parser kept the error state over two attributes:
error and errorMessage. They were changed in sync,
but had some discrepancy (for example, the error message
was always defined to something).

This patch unifies the two. There is an error if
if the error message is non-null or if the parsing finished
before the end.

This also gets rid of the allocation of the error message
when instantiating a parser.

• parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseInner):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseForStatement):
(JSC::::parseSwitchStatement):
(JSC::::parsePrimaryExpression):

• parser/Parser.h:

(JSC::Parser::updateErrorMessage):
(JSC::Parser::updateErrorWithNameAndMessage):
(JSC::Parser::hasError):
(Parser):

8:12 PM Changeset in webkit [148166] by thiago.santos@intel.com

• 2 edits in trunk/Source/WTF

[WTF] Get rid of truncated thread name warnings for non-Windows platforms
​https://bugs.webkit.org/show_bug.cgi?id=114266

Reviewed by Ryosuke Niwa.

Hide the annoying message from ports that are not really interested
about it.

• wtf/Threading.cpp:

(WTF::createThread):

6:59 PM Changeset in webkit [148165] by ryuan.choi@samsung.com

• 2 edits in trunk/Source/WebKit2

[CMAKE] Build fix after StorageArea refactoring
​https://bugs.webkit.org/show_bug.cgi?id=114398

Unreviewed build fix.

Change StorageAreaImpl.messages.in with StorageAreaMap.messages.in.
Add StorageAreaMap.cpp in CMakeLists.txt.

Patch by Jaehun Lim <​ljaehun.lim@samsung.com> on 2013-04-10

• CMakeLists.txt:

6:36 PM Changeset in webkit [148164] by rniwa@webkit.org

• 2 edits in trunk/Tools

Unreviewed, rolling out r148158.
​http://trac.webkit.org/changeset/148158
​https://bugs.webkit.org/show_bug.cgi?id=114405

We need to migrate status data (Requested by rniwa on
#webkit).

• Scripts/webkitpy/common/net/statusserver.py:

(StatusServer):

6:27 PM Changeset in webkit [148163] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Cleanup local variables in Editor::markAndReplaceFor
​https://bugs.webkit.org/show_bug.cgi?id=114383

Reviewed by Enrica Casucci.

Added resultEndLocation, which is the sum of resultLocation and resultLength.

Also replaced ambiguousBoundaryOffset by useAmbiguousBoundaryOffset since the ambiguous offset is always
selectionOffset -1 to avoid the extra house keeping and obnoxious -1 check.

• editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):

6:25 PM Changeset in webkit [148162] by oliver@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Set trap is not being called for API objects
​https://bugs.webkit.org/show_bug.cgi?id=114403

Reviewed by Anders Carlsson.

Intercept putByIndex on the callback object and add tests
to make sure we don't regress in future.

• API/JSCallbackObject.h:

(JSCallbackObject):

• API/JSCallbackObjectFunctions.h:

(JSC::::putByIndex):
(JSC):

• API/tests/testapi.c:

(PropertyCatchalls_setProperty):

• API/tests/testapi.js:

6:22 PM Changeset in webkit [148161] by andersca@apple.com

• 7 edits in trunk/Source/WebKit2

Make StorageAreaImpl a wrapper around StorageAreaMap
​https://bugs.webkit.org/show_bug.cgi?id=114404

Reviewed by Oliver Hunt.

Prepare for moving all the code that deals with local storage values to StorageAreaMap,
and make StorageAreaImpl a dumb wrapper that simply calls through to the map.

• WebProcess/Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::create):
(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::~StorageAreaImpl):
(WebKit::StorageAreaImpl::storageType):
(WebKit::StorageAreaImpl::length):
(WebKit::StorageAreaImpl::key):
(WebKit::StorageAreaImpl::getItem):
(WebKit::StorageAreaImpl::setItem):
(WebKit::StorageAreaImpl::contains):

• WebProcess/Storage/StorageAreaImpl.h:

(WebKit::StorageAreaImpl::storageAreaID):

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::generateStorageMapID):
(WebKit::StorageAreaMap::create):
(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::storageType):
(WebKit::StorageAreaMap::length):
(WebKit::StorageAreaMap::key):
(WebKit::StorageAreaMap::item):
(WebKit::StorageAreaMap::setItem):
(WebKit::StorageAreaMap::contains):
(WebKit::StorageAreaMap::didSetItem):
(WebKit::StorageAreaMap::dispatchStorageEvent):

• WebProcess/Storage/StorageAreaMap.h:
• WebProcess/Storage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::storageArea):

• WebProcess/Storage/StorageNamespaceImpl.h:

(StorageNamespaceImpl):

6:03 PM Changeset in webkit [148160] by andersca@apple.com

• 5 edits in trunk/Source/WebKit2

Rename StorageManager messages to refer to the StorageMap instead of the StorageArea
​https://bugs.webkit.org/show_bug.cgi?id=114401

Reviewed by Ryosuke Niwa.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::createStorageMap):
(WebKit::StorageManager::destroyStorageMap):
(WebKit::StorageManager::setItem):

• UIProcess/Storage/StorageManager.h:
• UIProcess/Storage/StorageManager.messages.in:
• WebProcess/Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::~StorageAreaImpl):

5:20 PM Changeset in webkit [148159] by benjamin@webkit.org

• 13 edits
  399 deletes in trunk

Mass remove all the empty directories

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-10
Rubberstamped by Ryosuke Niwa.

PerformanceTests:

• Bindings/resources: Removed.

Source/JavaScriptCore:

• qt/api: Removed.
• qt/benchmarks/qscriptengine: Removed.
• qt/benchmarks/qscriptvalue: Removed.
• qt/tests/qscriptengine: Removed.
• qt/tests/qscriptstring: Removed.
• qt/tests/qscriptvalue: Removed.
• qt/tests/qscriptvalueiterator: Removed.

Source/ThirdParty/ANGLE:

• src/libGLESv2/geometry: Removed.

Source/WebCore:

• Modules/intents: Removed.
• Modules/protocolhandler: Removed.
• Modules/speech/mac: Removed.
• accessibility/efl: Removed.
• accessibility/gtk: Removed.
• bridge/jni/jsc: Removed.
• editing/android: Removed.
• editing/gtk: Removed.
• history/android: Removed.
• page/android: Removed.
• platform/android: Removed.
• platform/clutter: Removed.
• platform/graphics/blackberry/skia: Removed.
• platform/graphics/harfbuzz/ng: Removed.
• platform/graphics/pango: Removed.
• platform/image-decoders/cg: Removed.
• platform/image-decoders/qt: Removed.
• platform/network/android: Removed.
• platform/network/soup/cache/webkit: Removed.
• platform/text/android: Removed.
• platform/text/wince: Removed.
• platform/track: Removed.

Source/WebKit/efl:

• DefaultTheme/widget/button: Removed.
• DefaultTheme/widget/check: Removed.
• DefaultTheme/widget/combo: Removed.
• DefaultTheme/widget/entry: Removed.
• DefaultTheme/widget/file: Removed.
• DefaultTheme/widget/mediacontrol/fullscreenbutton: Removed.
• DefaultTheme/widget/mediacontrol/mutebutton: Removed.
• DefaultTheme/widget/mediacontrol/playpausebutton: Removed.
• DefaultTheme/widget/mediacontrol/seekbackwardbutton: Removed.
• DefaultTheme/widget/mediacontrol/seekforwardbutton: Removed.
• DefaultTheme/widget/mediacontrol/togglecaptionsbutton: Removed.
• DefaultTheme/widget/progressbar: Removed.
• DefaultTheme/widget/radio: Removed.
• DefaultTheme/widget/scrollbar: Removed.
• DefaultTheme/widget/search/cancel: Removed.
• DefaultTheme/widget/search/decoration: Removed.
• DefaultTheme/widget/search/field: Removed.
• DefaultTheme/widget/slider: Removed.
• DefaultTheme/widget/spinner: Removed.

Source/WebKit/gtk:

• gyp: Removed.
• po: Removed.

Source/WebKit/mac:

• ForwardingHeaders/wtf/unicode/icu: Removed.

Source/WebKit/qt:

• tests/qdeclarativewebview/resources: Removed.

Source/WebKit2:

• Platform/CoreIPC/gtk: Removed.
• Platform/CoreIPC/qt: Removed.
• PluginProcess/EntryPoint/mac/XPCService/PluginService.32: Removed.
• PluginProcess/EntryPoint/mac/XPCService/PluginService.64: Removed.
• PluginProcess/gtk: Removed.
• Shared/API/c/win: Removed.
• Shared/Plugins/Netscape/win: Removed.
• Shared/cg/win: Removed.
• Shared/win: Removed.
• UIProcess/API/C/win: Removed.
• UIProcess/API/gtk/webkit: Removed.
• UIProcess/Launcher/win: Removed.
• UIProcess/Plugins/gtk: Removed.
• UIProcess/Plugins/win: Removed.
• UIProcess/texmap: Removed.
• UIProcess/win: Removed.
• WebProcess/Authentication/mac: Removed.
• WebProcess/Cookies/efl: Removed.
• WebProcess/Cookies/gtk: Removed.
• WebProcess/Downloads/cf/win: Removed.
• WebProcess/Downloads/cfnet: Removed.
• WebProcess/Downloads/curl: Removed.
• WebProcess/Downloads/efl: Removed.
• WebProcess/Downloads/gtk: Removed.
• WebProcess/Downloads/mac: Removed.
• WebProcess/Downloads/qt: Removed.
• WebProcess/Downloads/soup: Removed.
• WebProcess/FullScreen/gtk: Removed.
• WebProcess/FullScreen/mac: Removed.
• WebProcess/FullScreen/qt: Removed.
• WebProcess/FullScreen/win: Removed.
• WebProcess/InjectedBundle/API/c/win: Removed.
• WebProcess/InjectedBundle/win: Removed.
• WebProcess/KeyValueStorage: Removed.
• WebProcess/Network/CustomProtocols/mac: Removed.
• WebProcess/Plugins/Netscape/gtk: Removed.
• WebProcess/Plugins/Netscape/win: Removed.
• WebProcess/WebCoreSupport/win: Removed.
• WebProcess/WebPage/LayerTreeCoordinator: Removed.
• WebProcess/WebPage/ca/mac: Removed.
• WebProcess/WebPage/ca/win: Removed.
• WebProcess/WebPage/win: Removed.
• WebProcess/win: Removed.
• qt/Resources: Removed.

Source/WTF:

• wtf/qt/compat: Removed.
• wtf/unicode/glib: Removed.
• wtf/unicode/qt4: Removed.
• wtf/unicode/wince: Removed.

Tools:

• BuildSlaveSupport/gtk/crashmon/log: Removed.
• BuildSlaveSupport/gtk/xvfb/log: Removed.
• DumpRenderTree/ForwardingHeaders/wtf: Removed.
• DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
• MiniBrowser/gtk/WebBundle: Removed.
• MiniBrowser/win: Removed.
• QtTestPlatformPlugin/mac: Removed.
• Scripts/webkitpy/tool/bot/testdata: Removed.
• Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
• efl/ImageDiff: Removed.
• iExploder/htdocs: Removed.
• iExploder/iexploder-1.7.2/output: Removed.
• iExploder/tools: Removed.
• qmake/config.tests/libexecdir: Removed.
• qmake/config.tests/libjpeg: Removed.
• qmake/config.tests/libpng: Removed.

WebKitLibraries:

• win/bin: Removed.
• win/lib/WebKitSystemInterface: Removed.

LayoutTests:

• css2.1/reference: Removed.
• css3/flexbox/script-tests: Removed.
• css3/viewport-relative-lengths: Removed.
• editing/deleting/resources: Removed.
• editing/inserting/resources: Removed.
• editing/style/resources: Removed.
• editing/text-iterator/resources: Removed.
• fast/dom/CSSStyleDeclaration/resources: Removed.
• fast/dom/EntityReference/resources: Removed.
• fast/dom/HTMLFontElement/resources: Removed.
• fast/dom/HTMLFormElement/resources: Removed.
• fast/dom/HTMLSelectElement/resources: Removed.
• fast/dom/HTMLTableElement/resources: Removed.
• fast/dom/HTMLTableRowElement/resources: Removed.
• fast/dom/HTMLTableSectionElement/resources: Removed.
• fast/dom/MediaStream/script-tests: Removed.
• fast/dom/Node/resources: Removed.
• fast/dom/Proximity: Removed.
• fast/dom/Selection/resources: Removed.
• fast/dom/Text/resources: Removed.
• fast/events/spatial-navigation/resources: Removed.
• fast/events/transformaction: Removed.
• fast/forms/script-tests: Removed.
• fast/loading/resources: Removed.
• fast/mutation: Removed.
• fast/regex/resources: Removed.
• fast/speech/script-tests: Removed.
• fast/xhtmlmp: Removed.
• http/tests/inspector/resources/compiler-source-mapping-provider: Removed.
• http/tests/media/media-source/webm: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html5: Removed.
• http/tests/w3c/webperf/submission/resource-timing/html: Removed.
• http/tests/w3c/webperf/submission/user-timing: Removed.
• http/tests/xhtmlmp: Removed.
• http/tests/xmlhttprequest/web-apps/recursion: Removed.
• inspector/performance/resources: Removed.
• inspector/protocol/resources: Removed.
• inspector/resources: Removed.
• media/track/captions: Removed.
• platform/efl-wk1/dom/xhtml/level3/core: Removed.
• platform/efl-wk1/fast/dom/DOMException: Removed.
• platform/efl-wk1/mathml/presentation: Removed.
• platform/efl-wk1/svg/dynamic-updates: Removed.
• platform/efl-wk2/dom/xhtml/level3/core: Removed.
• platform/efl-wk2/fast/block/basic: Removed.
• platform/efl-wk2/fast/dom/DOMException: Removed.
• platform/efl-wk2/fast/frames: Removed.
• platform/efl-wk2/http/tests/loading: Removed.
• platform/efl/fast/css3-text-decoration/repaint: Removed.
• platform/efl/fast/dom/HTMLTemplateElement: Removed.
• platform/efl/fast/files: Removed.
• platform/efl/fast/forms/mailto: Removed.
• platform/efl/fast/innerHTML: Removed.
• platform/efl/fast/viewport: Removed.
• platform/efl/inspector/editor: Removed.
• platform/gtk/css3/calc: Removed.
• platform/gtk/editing/pasteboard/resources: Removed.
• platform/gtk/fast/innerHTML: Removed.
• platform/gtk/fast/js/regress: Removed.
• platform/gtk/fast/viewport: Removed.
• platform/gtk/http/tests/webarchive: Removed.
• platform/gtk/http/tests/websocket/tests: Removed.
• platform/gtk/ietestcenter/css3/grid: Removed.
• platform/gtk/platform/gtk/fonts: Removed.
• platform/gtk/sputnik/Unicode/Unicode_510: Removed.
• platform/gtk/svg/hittest: Removed.
• platform/gtk/tables/hittesting: Removed.
• platform/mac-future/accessibility: Removed.
• platform/mac-lion/animations: Removed.
• platform/mac-lion/compositing/visible-rect: Removed.
• platform/mac-lion/css1/units: Removed.
• platform/mac-lion/css3/selectors3: Removed.
• platform/mac-lion/editing/execCommand: Removed.
• platform/mac-lion/editing/inserting: Removed.
• platform/mac-lion/editing/pasteboard: Removed.
• platform/mac-lion/fast/block/float: Removed.
• platform/mac-lion/fast/block/margin-collapse: Removed.
• platform/mac-lion/fast/frames: Removed.
• platform/mac-lion/fast/inline: Removed.
• platform/mac-lion/fast/layers: Removed.
• platform/mac-lion/fast/lists: Removed.
• platform/mac-lion/fast/overflow: Removed.
• platform/mac-lion/fast/text/basic: Removed.
• platform/mac-lion/ietestcenter/css3: Removed.
• platform/mac-lion/tables/mozilla: Removed.
• platform/mac-lion/transforms: Removed.
• platform/mac-snowleopard/css3/filters/custom: Removed.
• platform/mac-snowleopard/fast/canvas/webgl: Removed.
• platform/mac-snowleopard/fast/html: Removed.
• platform/mac-snowleopard/fast/loader: Removed.
• platform/mac-snowleopard/fast/regions: Removed.
• platform/mac-snowleopard/http/tests/media: Removed.
• platform/mac-snowleopard/mathml/presentation: Removed.
• platform/mac-snowleopard/sputnik/Unicode/Unicode_510: Removed.
• platform/mac-snowleopard/svg/batik/filters: Removed.
• platform/mac-snowleopard/svg/batik/masking: Removed.
• platform/mac-snowleopard/svg/batik/text: Removed.
• platform/mac-wk2/compositing/geometry: Removed.
• platform/mac-wk2/compositing/iframes: Removed.
• platform/mac-wk2/css3/filters/custom: Removed.
• platform/mac-wk2/fast/css: Removed.
• platform/mac-wk2/fast/dynamic: Removed.
• platform/mac-wk2/fast/harness: Removed.
• platform/mac-wk2/fast/multicol/vertical-rl: Removed.
• platform/mac-wk2/http/tests/appcache: Removed.
• platform/mac-wk2/http/tests/inspector: Removed.
• platform/mac-wk2/http/tests/misc: Removed.
• platform/mac-wk2/mathml: Removed.
• platform/mac-wk2/media: Removed.
• platform/mac-wk2/platform/mac/accessibility: Removed.
• platform/mac-wk2/tables/mozilla: Removed.
• platform/mac/css3/calc: Removed.
• platform/mac/css3/filters/custom: Removed.
• platform/mac/dom/xhtml/level2/html: Removed.
• platform/mac/fast/dom/shadow: Removed.
• platform/mac/fast/files: Removed.
• platform/mac/fast/forms/label: Removed.
• platform/mac/fast/innerHTML: Removed.
• platform/mac/fast/inspector: Removed.
• platform/mac/http/tests/xmlhttprequest/web-apps: Removed.
• platform/mac/inspector/console: Removed.
• platform/mac/inspector/debugger: Removed.
• platform/mac/inspector/extensions: Removed.
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background: Removed.
• platform/mac/platform/mac-wk2/tiled-drawing/sticky: Removed.
• platform/mac/sputnik/Unicode/Unicode_510: Removed.
• platform/mac/svg/animations: Removed.
• platform/mac/tables/mozilla/images: Removed.
• platform/mac/tiled-drawing/fixed: Removed.
• platform/mac/tiled-drawing/fixed-background: Removed.
• platform/mac/tiled-drawing/sticky: Removed.
• platform/qt-5.0-wk1/compositing/backing: Removed.
• platform/qt-5.0-wk1/compositing/filters: Removed.
• platform/qt-5.0-wk1/compositing/images: Removed.
• platform/qt-5.0-wk1/compositing/masks: Removed.
• platform/qt-5.0-wk1/compositing/rtl: Removed.
• platform/qt-5.0-wk1/compositing/tiling: Removed.
• platform/qt-5.0-wk1/compositing/visibility: Removed.
• platform/qt-5.0-wk1/css3/filters: Removed.
• platform/qt-5.0-wk1/editing/inserting: Removed.
• platform/qt-5.0-wk1/fast/dom/Window: Removed.
• platform/qt-5.0-wk2/compositing/backing: Removed.
• platform/qt-5.0-wk2/compositing/shadows: Removed.
• platform/qt-5.0-wk2/css1/basic: Removed.
• platform/qt-5.0-wk2/css1/box_properties: Removed.
• platform/qt-5.0-wk2/fast/block/basic: Removed.
• platform/qt-5.0-wk2/fast/block/float: Removed.
• platform/qt-5.0-wk2/fast/block/margin-collapse: Removed.
• platform/qt-5.0-wk2/fast/block/positioning/auto: Removed.
• platform/qt-5.0-wk2/fast/dom/HTMLHeadElement: Removed.
• platform/qt-5.0-wk2/fast/dom/HTMLTableElement: Removed.
• platform/qt-5.0-wk2/fast/dom/HTMLTextAreaElement: Removed.
• platform/qt-5.0-wk2/fast/dom/Window: Removed.
• platform/qt-5.0-wk2/fast/dynamic: Removed.
• platform/qt-5.0-wk2/fast/forms/datalist: Removed.
• platform/qt-5.0-wk2/fast/forms/mailto: Removed.
• platform/qt-5.0-wk2/fast/forms/number: Removed.
• platform/qt-5.0-wk2/fast/frames: Removed.
• platform/qt-5.0-wk2/fast/html: Removed.
• platform/qt-5.0-wk2/fast/images/png-suite: Removed.
• platform/qt-5.0-wk2/fast/inline: Removed.
• platform/qt-5.0-wk2/fast/lists: Removed.
• platform/qt-5.0-wk2/fast/multicol/span: Removed.
• platform/qt-5.0-wk2/fast/multicol/vertical-lr: Removed.
• platform/qt-5.0-wk2/fast/parser: Removed.
• platform/qt-5.0-wk2/fast/text/international: Removed.
• platform/qt-5.0-wk2/fullscreen/fullscreen: Removed.
• platform/qt-5.0-wk2/http/tests/websocket/test/hybi: Removed.
• platform/qt-5.0-wk2/platform/qt/plugins: Removed.
• platform/qt-5.0-wk2/svg/dom: Removed.
• platform/qt-5.0/animations: Removed.
• platform/qt-5.0/css1/text_properties: Removed.
• platform/qt-5.0/css2.1/20110323: Removed.
• platform/qt-5.0/editing/deleting: Removed.
• platform/qt-5.0/editing/inserting: Removed.
• platform/qt-5.0/editing/pasteboard: Removed.
• platform/qt-5.0/fast/borders: Removed.
• platform/qt-5.0/fast/css: Removed.
• platform/qt-5.0/fast/dom/DeviceMotion: Removed.
• platform/qt-5.0/fast/dom/DeviceOrientation: Removed.
• platform/qt-5.0/fast/dom/HTMLProgressElement: Removed.
• platform/qt-5.0/fast/dom/HTMLTextAreaElement: Removed.
• platform/qt-5.0/fast/dynamic: Removed.
• platform/qt-5.0/fast/html: Removed.
• platform/qt-5.0/fast/inline: Removed.
• platform/qt-5.0/fast/js: Removed.
• platform/qt-5.0/fast/multicol: Removed.
• platform/qt-5.0/fast/parser: Removed.
• platform/qt-5.0/fast/repaint: Removed.
• platform/qt-5.0/fast/replaced: Removed.
• platform/qt-5.0/fast/table/border-collapsing: Removed.
• platform/qt-5.0/fast/writing-mode: Removed.
• platform/qt-5.0/fast/xsl: Removed.
• platform/qt-5.0/svg/as-background-image: Removed.
• platform/qt-5.0/svg/custom: Removed.
• platform/qt-5.0/svg/hixie/intrinsic: Removed.
• platform/qt-5.0/svg/text: Removed.
• platform/qt-5.0/svg/wicd: Removed.
• platform/qt-5.0/svg/zoom/page: Removed.
• platform/qt-5.0/tables/mozilla/bugs: Removed.
• platform/qt-5.0/transitions: Removed.
• platform/qt-arm/fast/block: Removed.
• platform/qt-arm/fast/dom: Removed.
• platform/qt-arm/transforms: Removed.
• platform/qt-linux/fast/css: Removed.
• platform/qt-mac/editing: Removed.
• platform/qt-mac/fast/block/float: Removed.
• platform/qt-mac/plugins: Removed.
• platform/qt-win/fast/events: Removed.
• platform/qt.5-0/fast/text/whitespace: Removed.
• platform/qt/compositing/tiling: Removed.
• platform/qt/fast/css/dumpAsText: Removed.
• platform/qt/fast/encoding/dumpAsText: Removed.
• platform/qt/fast/forms/mailto: Removed.
• platform/qt/fast/innerHTML: Removed.
• platform/qt/fast/inspector: Removed.
• platform/qt/fast/js/regress: Removed.
• platform/qt/fast/media/w3c: Removed.
• platform/qt/http/tests/plugins: Removed.
• platform/qt/http/tests/security/aboutBlank: Removed.
• platform/qt/http/tests/security/cookies: Removed.
• platform/qt/http/tests/security/mixedContent: Removed.
• platform/qt/http/tests/security/xssAuditor: Removed.
• platform/qt/http/tests/xmlhttprequest/workers: Removed.
• platform/qt/inspector/console: Removed.
• platform/qt/inspector/debugger: Removed.
• platform/qt/inspector/extensions: Removed.
• platform/qt/mathml/presentation: Removed.
• platform/qt/scrollingcoordinator: Removed.
• platform/qt/svg/hixie/error/dumpAsText: Removed.
• platform/qt/tables/mozilla/images: Removed.
• platform/qt/traversal: Removed.
• platform/win-7sp0/fast/harness: Removed.
• platform/win-wk2/css2.1: Removed.
• platform/win-wk2/editing/deleting: Removed.
• platform/win-wk2/editing/selection: Removed.
• platform/win-wk2/fast/css: Removed.
• platform/win-wk2/fast/forms: Removed.
• platform/win-wk2/fast/repaint: Removed.
• platform/win-wk2/fast/ruby: Removed.
• platform/win-wk2/fast/text/international: Removed.
• platform/win-wk2/http/tests/inspector-enabled: Removed.
• platform/win-wk2/http/tests/security: Removed.
• platform/win-wk2/http/tests/uri: Removed.
• platform/win-wk2/media: Removed.
• platform/win-wk2/platform/win/inverted-colors: Removed.
• platform/win-wk2/platform/win/plugins: Removed.
• platform/win-wk2/plugins/npruntime: Removed.
• platform/win-wk2/svg/W3C-I18N: Removed.
• platform/win-wk2/svg/W3C-SVG-1.1-SE: Removed.
• platform/win-wk2/svg/text: Removed.
• platform/win-wk2/svg/zoom/page: Removed.
• platform/win/canvas/philip/tests: Removed.
• platform/win/compositing/geometry: Removed.
• platform/win/compositing/overflow: Removed.
• platform/win/editing/style: Removed.
• platform/win/editing/undo: Removed.
• platform/win/fast/block/basic: Removed.
• platform/win/fast/css/getComputedStyle: Removed.
• platform/win/fast/css3-text-decoration/getComputedStyle: Removed.
• platform/win/fast/dom/Element: Removed.
• platform/win/fast/dom/HTMLTextAreaElement: Removed.
• platform/win/fast/dom/Window: Removed.
• platform/win/fast/events/resources: Removed.
• platform/win/fast/frames/seamless: Removed.
• platform/win/fast/layers: Removed.
• platform/win/fast/loader: Removed.
• platform/win/fast/overflow: Removed.
• platform/win/fast/parser: Removed.
• platform/win/fast/table: Removed.
• platform/win/fast/transforms: Removed.
• platform/win/inspector/debugger: Removed.
• platform/win/platform/win/accessibility: Removed.
• platform/win/tables/mozilla/bugs: Removed.
• platform/win/tables/mozilla/other: Removed.
• platform/win/tables/mozilla_expected_failures/bugs: Removed.
• platform/wk2/tables/mozilla/bugs: Removed.
• pointer-lock/resources: Removed.
• storage/indexeddb/script-tests: Removed.
• svg/dom/SVGStyleElement/resources: Removed.
• webintents/resources: Removed.

5:15 PM Changeset in webkit [148158] by rniwa@webkit.org

• 2 edits in trunk/Tools

Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
​https://bugs.webkit.org/show_bug.cgi?id=114397

Reviewed by Benjamin Poulain.

• Scripts/webkitpy/common/net/statusserver.py:

(StatusServer):

5:10 PM Changeset in webkit [148157] by ryuan.choi@samsung.com

• 2 edits in trunk/Source/WebKit2

[CMAKE] Build fix after r148147, r148148
​https://bugs.webkit.org/show_bug.cgi?id=114395

Unreviewed build fix.

Use StorageAreaImpl, StorageNamespaceImpl instead of StorageAreaProxy, StorageNamespaceProxy.

Patch by Jaehun Lim <​ljaehun.lim@samsung.com> on 2013-04-10

• CMakeLists.txt:

5:09 PM Changeset in webkit [148156] by rniwa@webkit.org

• 5 edits in trunk/Websites/bugs.webkit.org

Make old EWS bubbles less opaque to disambiguate two set of bubbles.

Rubber-stamped by Benjamin Poulain.

• code-review.js:
• template/en/custom/attachment/edit.html.tmpl:
• template/en/custom/attachment/list.html.tmpl:
• template/en/custom/attachment/reviewform.html.tmpl:

5:04 PM Changeset in webkit [148155] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Log when the animation timer fires
​https://bugs.webkit.org/show_bug.cgi?id=114393

Reviewed by Dean Jackson.

Logging to the Animations log channel when the updateAnimationTimer
fires is useful, because it indicates whether we're running
software animations.

• page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimationTimer):

5:02 PM Changeset in webkit [148154] by andersca@apple.com

• 5 edits
  1 move
  2 adds in trunk/Source/WebKit2

Add a stubbed out StorageAreaMap class
​https://bugs.webkit.org/show_bug.cgi?id=114392

Reviewed by Andreas Kling.

The intention is that StorageAreaMap is going to take over responsibility for storing the storage values in the
web process, as well as dispatching events. A StorageAreaMap will be shared between multiple StorageAreaImpl objects,
for example if multiple frames with the same origin use local storage.

• DerivedSources.make:
• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::dispatchEvents):
(WebKit::StorageManager::setItem):

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::~StorageAreaImpl):

• WebProcess/Storage/StorageAreaMap.cpp: Added.

(WebKit):
(WebKit::StorageAreaMap::create):
(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::~StorageAreaMap):
(WebKit::StorageAreaMap::didSetItem):
(WebKit::StorageAreaMap::dispatchStorageEvent):

• WebProcess/Storage/StorageAreaMap.h: Added.

(WebKit):
(StorageAreaMap):

• WebProcess/Storage/StorageAreaMap.messages.in: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaImpl.messages.in.

5:00 PM Changeset in webkit [148153] by rniwa@webkit.org

• 5 edits in trunk/Websites/bugs.webkit.org

Bugzilla should show bubbles from webkit-queues.appspot.com
​https://bugs.webkit.org/show_bug.cgi?id=114391

Reviewed by Benjamin Poulain.

Include iframe from webkit-queues.appspot.com as well as one for webkit-commit-queue.appspot.com.

• code-review.js:
• template/en/custom/attachment/edit.html.tmpl:
• template/en/custom/attachment/list.html.tmpl:
• template/en/custom/attachment/reviewform.html.tmpl:

4:53 PM Changeset in webkit [148152] by abarth@webkit.org

• 2 edits in trunk/Tools

Remove abarth from watchlists
​https://bugs.webkit.org/show_bug.cgi?id=114390

Reviewed by Ryosuke Niwa.

I'm trying to cut down on the amount of bugmail I get so that I'll have
more of a chance to notice a piece of bugmail directed at me.

• Scripts/webkitpy/common/config/watchlist:

4:44 PM Changeset in webkit [148151] by rniwa@webkit.org

• 3 edits in trunk/Tools

webkit-test-results.appspot.com loads the dashboard for Chromium by default
​https://bugs.webkit.org/show_bug.cgi?id=114381

Reviewed by Benjamin Poulain.

Changed the defaults.

• TestResultServer/static-dashboards/builders.js:
• TestResultServer/static-dashboards/dashboard_base.js:

(currentBuilderGroupCategory):

4:34 PM Changeset in webkit [148150] by Lucas Forschler

• 4 edits
  2 adds in branches/safari-536.30-branch

Merge 136250. <rdar://problem/13335010>

4:25 PM Changeset in webkit [148149] by Beth Dakin

• 2 edits in trunk/Source/WebCore

Inspector highlights are offset when the WKView has a header
​https://bugs.webkit.org/show_bug.cgi?id=114389
-and corresponding-
<rdar://problem/13522434>

Reviewed by Sam Weinig.

rootViewToContents() and contentsToRootView() need to factor in the
headerHeight(), much like windowToContents() and contentsToWindow() do already.

• platform/ScrollView.cpp:

(WebCore::ScrollView::rootViewToContents):
(WebCore::ScrollView::contentsToRootView):

4:22 PM Changeset in webkit [148148] by andersca@apple.com

• 6 edits
  3 moves in trunk/Source/WebKit2

Rename StorageAreaProxy to StorageAreaImpl.

Rubber-stamped by Beth Dakin.

• DerivedSources.make:
• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::dispatchEvents):
(WebKit::StorageManager::setItem):

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/Storage/StorageAreaImpl.cpp: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp.
• WebProcess/Storage/StorageAreaImpl.h: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.h.
• WebProcess/Storage/StorageAreaImpl.messages.in: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.messages.in.
• WebProcess/Storage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::storageArea):

• WebProcess/Storage/StorageNamespaceImpl.h:

(WebKit):
(StorageNamespaceImpl):

4:21 PM Changeset in webkit [148147] by andersca@apple.com

• 5 edits
  2 moves in trunk/Source/WebKit2

Rename StorageNamespaceProxy to StorageNamespaceImpl.

Rubber-stamped by Beth Dakin.

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::create):
(WebKit::StorageAreaProxy::StorageAreaProxy):

• WebProcess/Storage/StorageAreaProxy.h:

(StorageAreaProxy):

• WebProcess/Storage/StorageNamespaceImpl.cpp: Renamed from Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.cpp.
• WebProcess/Storage/StorageNamespaceImpl.h: Renamed from Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.h.
• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::sessionStorageNamespace):

4:11 PM Changeset in webkit [148146] by rniwa@webkit.org

• 6 edits in trunk/Tools

Remove Chromium EWS bots from the queue status server
​https://bugs.webkit.org/show_bug.cgi?id=113988

Reviewed by Benjamin Poulain.

Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.

• QueueStatusServer/app.yaml:
• QueueStatusServer/config/queues.py:
• QueueStatusServer/model/queues.py:

(Queue.short_name):
(Queue.display_name):

• QueueStatusServer/model/queues_unittest.py:

(QueueTest.test_short_name):
(QueueTest.test_display_name):
(QueueTest.test_name_with_underscores):

• QueueStatusServer/templates/activebots.html:

3:47 PM Changeset in webkit [148145] by Simon Fraser

• 4 edits in trunk/Source/WebCore

Flesh out the Animations logging
​https://bugs.webkit.org/show_bug.cgi?id=114388

Reviewed by Dean Jackson.

Log state changes and transition/animation creation and destruction
to the Animations log channel.

• page/animation/AnimationBase.cpp:

(WebCore::nameForState):
(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::goIntoEndingOrLoopingState):
(WebCore::AnimationBase::freezeAtTime):

• page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):

• page/animation/KeyframeAnimation.h:

(WebCore::KeyframeAnimation::keyframes):
(KeyframeAnimation):

3:45 PM Changeset in webkit [148144] by ap@apple.com

• 2 edits in trunk/Source/WebCore

<rdar://problem/13047266> External XML entities are not loaded with modern libxml2
​https://bugs.webkit.org/show_bug.cgi?id=114377

Reviewed by Darin Adler.

Covered by http/tests/security/xss-DENIED-xml-external-entity.xhtml when using
new enough libxml2.

• xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::switchToUTF16): Added a FIXME with an idea for improvement. (WebCore::XMLParserContext::createStringParser): Apply XML_PARSE_NOENT in a non-hacky way, so that the new libxml2 check doesn't fail. (WebCore::XMLParserContext::createMemoryParser): Updated an unhelpful and incorrect comment (XML_PARSE_NODICT actually means "Do not reuse the context dictionary").

3:35 PM Changeset in webkit [148143] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

[wk2] Un-pollute TCADA methods with "PageOverlayLayerMap::iterator end"
​https://bugs.webkit.org/show_bug.cgi?id=114387

Reviewed by Simon Fraser.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::paintContents):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):

3:25 PM Changeset in webkit [148142] by mhahnenberg@apple.com

• 4 edits
  3 adds in trunk

JSObject::getOwnNonIndexPropertyNames calculates numCacheableSlots incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=114235

Reviewed by Filip Pizlo.

If the object doesn't have any properties but the prototype does, we'll assume those prototype properties are
accessible in the base object's backing store, which is bad.

Source/JavaScriptCore:

• runtime/JSObject.cpp:

(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnNonIndexPropertyNames):

• runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::setNumCacheableSlotsForObject):
(JSC::PropertyNameArray::setBaseObject):
(PropertyNameArray):

LayoutTests:

• fast/js/get-by-pname-only-prototype-properties-expected.txt: Added.
• fast/js/get-by-pname-only-prototype-properties.html: Added.
• fast/js/script-tests/get-by-pname-only-prototype-properties.js: Added.

(foo):

3:18 PM Changeset in webkit [148141] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit2

[wk2] REGRESSION: Find highlight does not update when the view is resized
​https://bugs.webkit.org/show_bug.cgi?id=114382
<rdar://problem/13599797>

Reviewed by Simon Fraser.

Invalidate the page overlays from TiledCoreAnimationDrawingArea::updateGeometry.
This will have no effect if the page overlay hasn't previously asked to be painted
(as drawsContent will remain false on the layer).

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea): Add invalidateAllPageOverlays.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::invalidateAllPageOverlays): Factor this out of didChangeScrollOffsetForAnyFrame.
(WebKit::TiledCoreAnimationDrawingArea::didChangeScrollOffsetForAnyFrame): Call invalidateAllPageOverlays.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry): Call invalidateAllPageOverlays.

2:53 PM Changeset in webkit [148140] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

[Mac] in-band tracks sometimes not recognized
​https://bugs.webkit.org/show_bug.cgi?id=114380

Reviewed by Jer Noble.

No new tests, covered by existing in-band tests.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Don't call selectMediaOption,

availableMediaCharacteristicsWithMediaSelectionOptions is unlikely to be loaded at this time.

(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Disable automatic text track

selection.

(WebCore::assetMetadataKeyNames): Watch for the status of availableMediaCharacteristicsWithMediaSelectionOptions

to change.

2:22 PM Changeset in webkit [148139] by hmuller@adobe.com

• 3 edits
  2 adds in trunk

[CSS Exclusions] Zoom causes shape-inside to fail when shape-padding is specified
​https://bugs.webkit.org/show_bug.cgi?id=113730

Reviewed by Dirk Schulze.

Source/WebCore:

Snap computed margin and polygon boundaries to the LayoutUnit grid to ensure
that they fall within the shape's LayoutUnit bounding box.

Test: fast/exclusions/shape-inside/shape-inside-polygon-zoom.html

• rendering/ExclusionPolygon.cpp:

(WebCore::snapVerticesToLayoutUnitGrid): Convert the FloatPoint coordinates to LayoutUnits and then back to floats.
(WebCore::computeShapePaddingBounds): Now calls snapVerticesToLayoutUnitGrid() before creating a FloatPolygon.
(WebCore::computeShapeMarginBounds): Ditto.

LayoutTests:

Verify that content lays out within a padded shape-inside polygon when the
document has been zoomed.

• fast/exclusions/shape-inside/shape-inside-polygon-zoom-expected.html: Added.
• fast/exclusions/shape-inside/shape-inside-polygon-zoom.html: Added.

2:11 PM Changeset in webkit [148138] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

One more unreviewed buildfix after r148123.

• platform/graphics/filters/CustomFilterMeshGenerator.h:

1:57 PM Changeset in webkit [148137] by Beth Dakin

• 8 edits in trunk/Source

FindBanner matches are offset when the WKView has a header or footer
​https://bugs.webkit.org/show_bug.cgi?id=114314
-and corresponding-
<rdar://problem/13522434>

Reviewed by Simon Fraser.

Source/WebCore:

There were already a few places in the code where we needed to adjust the
scrollOffset() to pretend that (0,0) is that the top of the Document rather than
the top of the header. To fix the FindBanner issues, we need to know that version
of the offset in a few more places, so I added a function on ScrollView to fetch
it called scrollOffsetRelativeToDocument().

New function subtracts out the headerHeight() to treat the top of
the document as (0,0).

• WebCore.exp.in:
• platform/ScrollView.cpp:

(WebCore::ScrollView::scrollOffsetRelativeToDocument):

Use scrollOffsetRelativeToDocument() where we were previously making this
calculation. Also re-name an inaccurately named variable where we are actually
converting FROM a document offset to a ScrollableArea offset.
(WebCore::ScrollView::windowToContents):

• platform/ScrollView.h:

(ScrollView):

getRectToExpose needs to know about the actual visibleContentRect and the
visibleContentRect that is relative to the Document. So this
patch adds a new parameter to getRectToExpose for that purpose.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::getRectToExpose):

• rendering/RenderLayer.h:

Source/WebKit2:

When calculating the matching rects, also adjust to the scroll offset that is
relative to the Document.

• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::rectsForTextMatches):

1:45 PM Changeset in webkit [148136] by Chris Fleizach

• 7 edits
  2 adds in trunk

when ARIA button contains a link, label text is ignored (affects main buttons on m.facebook.com)
​https://bugs.webkit.org/show_bug.cgi?id=113906

Reviewed by Tim Horton.

Source/WebCore:

If an element does not expose any children, then it's safe to include all of its sub children when determining
the visible text.
The bug is that all elements were ignoring focusable elements (like <a>) when determining visible children text

Test: accessibility/link-inside-button-accessible-text.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::shouldUseAccessiblityObjectInnerText):

• accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isDescendantOfBarrenParent):
(AccessibilityObject):

LayoutTests:

The static-text-role-uses-text-under-element.html relies on similar logic to this bug.

I realized that it was verifying the wrong thing and if we had looked closely at this layout test
we would have caught this regression earlier most likely.

• accessibility/link-inside-button-accessible-text-expected.txt: Added.
• accessibility/link-inside-button-accessible-text.html: Added.
• platform/mac/accessibility/static-text-role-uses-text-under-element-expected.txt:
• platform/mac/accessibility/static-text-role-uses-text-under-element.html:

1:38 PM Changeset in webkit [148135] by Chris Fleizach

• 2 edits in trunk/Source/WebCore

AX: Make sure all AX methods called from outside call prepareAccessibility
​https://bugs.webkit.org/show_bug.cgi?id=113818

Reviewed by Darin Adler.

Make sure any calls that can be made from outside WebCore are protected with the
prepareAccessibility method.

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityMathRootIndexObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathRadicandObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathNumeratorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathDenominatorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathBaseObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSubscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSuperscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathUnderObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathOverObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedOpenString]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedCloseString]):
(-[WebAccessibilityObjectWrapper accessibilityIsMathTopObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathType]):

1:30 PM Changeset in webkit [148134] by Patrick Gansterer

• 2 edits in trunk/Source/JavaScriptCore

Remove code duplicates from MacroAssemblerARM
​https://bugs.webkit.org/show_bug.cgi?id=104457

Reviewed by Oliver Hunt.

Reuse some existing methods to avoid duplicated code.

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::store8):
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::swap):
(JSC::MacroAssemblerARM::add32):
(JSC::MacroAssemblerARM::sub32):

1:21 PM Changeset in webkit [148133] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Unreviewed buildfix after r148123.

• inspector/InspectorInstrumentation.h:

(WebCore):

1:05 PM Changeset in webkit [148132] by ojan@chromium.org

• 10 edits in trunk/Tools

Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
​https://bugs.webkit.org/show_bug.cgi?id=114370

Reviewed by Ryosuke Niwa.

Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
Unfortunately, there's no way to test this until this is committed and there is
a master restart.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
• TestResultServer/generate_builders_json.py:
• TestResultServer/static-dashboards/dashboard_base.js:
• TestResultServer/static-dashboards/loader.js:

1:02 PM Changeset in webkit [148131] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Clicking on the volume slider of HTML5 elements is pausing sometimes
​https://bugs.webkit.org/show_bug.cgi?id=112548

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-04-10
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/click-volume-bar-not-pausing.html

• html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
Calling the setDefaultHandled() method on the event prevents it
from being incorrectly propagated from the volume button up to the
MediaDocument.

LayoutTests:

Added test.

• media/click-volume-bar-not-pausing-expected.txt: Added.
• media/click-volume-bar-not-pausing.html: Added.

1:01 PM Changeset in webkit [148130] by msaboff@apple.com

• 3 edits
  3 adds in trunk

DFG: Negative size for new Array() interpreted as large unsigned int
​https://bugs.webkit.org/show_bug.cgi?id=114366

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Added new check in operationNewArrayWithSize() for a negative
size. If size is negative throw a "RangeError: Array size is not a
small enough positive integer" exception.

• dfg/DFGOperations.cpp:

LayoutTests:

New test to make sure DFG generated code for new Array() with a
computed negative size throws an exception.

• fast/js/dfg-negative-array-size-expected.txt: Added.
• fast/js/dfg-negative-array-size.html: Added.
• fast/js/script-tests/dfg-negative-array-size.js: Added.

12:56 PM Changeset in webkit [148129] by anilsson@rim.com

• 17 edits
  2 moves in trunk/Source

[BlackBerry] Rename BlackBerry specific Texture class
​https://bugs.webkit.org/show_bug.cgi?id=95781

Reviewed by Rob Buis.

Texture was a bit too generic and prone to name conflicts. Renamed it
to LayerTexture.

Source/WebCore:

No change in behavior, no new tests.

PR 322882

• PlatformBlackBerry.cmake:
• platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawSurface):
(WebCore::LayerCompositingThread::contentsTexture):

• platform/graphics/blackberry/LayerCompositingThread.h:

(LayerCompositingThread):

• platform/graphics/blackberry/LayerCompositingThreadClient.h:

(WebCore):
(WebCore::LayerCompositingThreadClient::contentsTexture):

• platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRenderer::applyActions):

• platform/graphics/blackberry/LayerFilterRenderer.h:

(LayerFilterRenderer):

• platform/graphics/blackberry/LayerRendererSurface.h:

(WebCore::LayerRendererSurface::texture):
(LayerRendererSurface):

• platform/graphics/blackberry/LayerTexture.cpp: Renamed from Source/WebCore/platform/graphics/blackberry/Texture.cpp.

(WebCore):
(WebCore::LayerTexture::LayerTexture):
(WebCore::LayerTexture::~LayerTexture):
(WebCore::LayerTexture::updateContents):
(WebCore::LayerTexture::setContentsToColor):
(WebCore::LayerTexture::protect):

• platform/graphics/blackberry/LayerTexture.h: Renamed from Source/WebCore/platform/graphics/blackberry/Texture.h.

(WebCore):
(LayerTexture):
(WebCore::LayerTexture::create):
(WebCore::LayerTexture::textureId):
(WebCore::LayerTexture::isDirty):
(WebCore::LayerTexture::hasTexture):
(WebCore::LayerTexture::isColor):
(WebCore::LayerTexture::isOpaque):
(WebCore::LayerTexture::isProtected):
(WebCore::LayerTexture::protect):
(WebCore::LayerTexture::unprotect):
(WebCore::LayerTexture::size):
(WebCore::LayerTexture::width):
(WebCore::LayerTexture::height):
(WebCore::LayerTexture::bytesPerPixel):
(WebCore::LayerTexture::sizeInBytes):
(WebCore::LayerTexture::setTextureId):
(WebCore::LayerTexture::setSize):

• platform/graphics/blackberry/LayerTile.cpp:

(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):
(WebCore::LayerTile::setTexture):

• platform/graphics/blackberry/LayerTile.h:

(WebCore::LayerTile::texture):
(LayerTile):

• platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::drawTile):
(WebCore::LayerTiler::contentsTexture):

• platform/graphics/blackberry/LayerTiler.h:

(LayerTiler):
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::updateContents):
(TextureJob):

• platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureProtector::TextureProtector):
(TextureProtector):
(WebCore::TextureCacheCompositingThread::allocateTextureId):
(WebCore::freeTextureId):
(WebCore::TextureCacheCompositingThread::textureResized):
(WebCore::TextureCacheCompositingThread::textureSizeInBytesChanged):
(WebCore::TextureCacheCompositingThread::textureDestroyed):
(WebCore::TextureCacheCompositingThread::install):
(WebCore::TextureCacheCompositingThread::resizeTexture):
(WebCore::TextureCacheCompositingThread::evict):
(WebCore::TextureCacheCompositingThread::textureAccessed):
(WebCore::TextureCacheCompositingThread::prune):
(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::textureForColor):
(WebCore::TextureCacheCompositingThread::updateContents):

• platform/graphics/blackberry/TextureCacheCompositingThread.h:

(WebCore::TextureCacheCompositingThread::createTexture):
(TextureCacheCompositingThread):
(WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
(ZombieTexture):

Source/WebKit/blackberry:

PR 322882

• Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):

• Api/WebOverlay_p.h:

(WebOverlayLayerCompositingThreadClient):

12:38 PM Changeset in webkit [148128] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Disallow programmatic movement of the browser window while user gestures are in progress.
<​http://webkit.org/b/114271>
<rdar://problem/13226530>

Reviewed by Oliver Hunt.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):

12:33 PM Changeset in webkit [148127] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

WinCairo build fails to link.
​https://bugs.webkit.org/show_bug.cgi?id=114358

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-04-10
Reviewed by Brent Fulgham.

Export the symbol WTF::MD5::checksum().

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
• JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

12:24 PM Changeset in webkit [148126] by glenn@skynav.com

• 3 edits in trunk/Tools

[Qt] Fix regression to test-webkitpy.
​https://bugs.webkit.org/show_bug.cgi?id=114368

Reviewed by Ryosuke Niwa.

• Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
(PortFactory.get): Remove obsolete chromium port related code.

• Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.default_child_processes): Prevent type error if can't determine total memory.

12:18 PM Changeset in webkit [148125] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Fixed build failure in Plugin.h: FloatPoint was not in namespace WebCore

make[1]: * Waiting for unfinished jobs....
In file included from Source/WebKit2/PluginProcess/PluginCreationParameters.h:31:0,

from Source/WebKit2/PluginProcess/PluginCreationParameters.cpp:27:

./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:58: error: 'FloatPoint' in namespace 'WebCore' does not name a type
./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:77: error: ISO C++ forbids declaration of 'parameter' with no type [-fpermissive]
cc1plus: warning: unrecognized command line option "-Wno-c++11-extensions" [enabled by default]
make[1]: * [Source/WebKit2/PluginProcess/libwebkit2gtk_3_0_la-PluginCreationParameters.lo] Error 1

It now passes that make target.

​https://bugs.webkit.org/show_bug.cgi?id=111862

Patch by Tobias Mueller <​tobiasmue@gnome.org> on 2013-04-10
Reviewed by Darin Adler.

• WebProcess/Plugins/Plugin.h:

(WebCore): Added FloatPoint to the WebCore namespace

12:16 PM Changeset in webkit [148124] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Refactor Editor::markAndReplaceFor before fixing autocorrection bugs
​https://bugs.webkit.org/show_bug.cgi?id=114344

Reviewed by Enrica Casucci.

This patch refactors Editor::markAndReplaceFor so that we can start fixing bugs in a sane state.
Extracted isAutomaticTextReplacementType and correctSpellcheckingPreservingTextCheckingParagraph,
and made convenience local variables const.

In particular, shouldMarkSpelling used to be assigned of false when shouldShowCorrectionPanel was true
in a middle of a function but this was removed in favor of explicitly checking this condition later
since shouldMarkSpelling was only referenced once after the assignment.

• editing/Editor.cpp:

(WebCore::isAutomaticTextReplacementType): Extracted.

(WebCore::correctSpellcheckingPreservingTextCheckingParagraph): Extracted. Used highestAncestor
and rangeFromLocationAndLength to match the rest of the up-to-date editing code.

(WebCore::Editor::markAndReplaceFor): See above.

12:11 PM Changeset in webkit [148123] by andersca@apple.com

• 38 edits in trunk

Remove unneeded headers from FrameLoader.h
​https://bugs.webkit.org/show_bug.cgi?id=114223

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Update for WTF changes.

• bytecode/SpeculatedType.h:
• runtime/JSCJSValue.h:

Source/WebCore:

Remove unneeded headers from FrameLoader.h and add them back into the respective .cpp files where needed.

• dom/Document.cpp:
• history/CachedFrame.cpp:
• history/PageCache.cpp:
• inspector/InspectorResourceAgent.cpp:
• loader/DocumentLoader.cpp:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad):

• loader/FrameLoader.h:

(WebCore):
(WebCore::FrameLoader::policyChecker):
(WebCore::FrameLoader::history):
(WebCore::FrameLoader::icon):

• loader/MixedContentChecker.h:
• loader/icon/IconLoader.cpp:
• page/History.cpp:
• page/Page.cpp:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• testing/Internals.cpp:

Source/WebKit/blackberry:

Include HistoryController.h from WebCore.

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

Source/WebKit/mac:

Include HistoryController.h from WebCore.

• WebCoreSupport/WebFrameLoaderClient.mm:
• WebView/WebView.mm:

Source/WebKit/win:

Include HistoryController.h from WebCore.

• WebView.cpp:

Source/WebKit2:

Include HistoryController.h from WebCore.

• WebProcess/Plugins/PDF/SimplePDFPlugin.h:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
• WebProcess/WebPage/WebPage.cpp:

Source/WTF:

• wtf/Forward.h:

Add PrintStream.

• wtf/HashTable.h:

Don't include DataLog.h unless DUMP_HASHTABLE_STATS_PER_TABLE is 1.

Tools:

Add back headers implicitly included by other headers.

• WebKitTestRunner/WorkQueueManager.cpp:

12:03 PM Changeset in webkit [148122] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Minor code cleanup in AnimationBase::progress
​https://bugs.webkit.org/show_bug.cgi?id=114371

Reviewed by Dean Jackson.

Convert some "return; else if" to just "return; if".

• page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::progress):

11:56 AM Changeset in webkit [148121] by robert@webkit.org

• 3 edits
  2 adds in trunk

Empty inline continuations should only get lineboxes if the padding applies to their side of the inline
​https://bugs.webkit.org/show_bug.cgi?id=113896

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/inline/inline-with-empty-inline-continuations.html

Where an empty inline is split across anonymous blocks we should only give lineboxes to the 'sides' of the
inline that have borders, padding or margin.

• rendering/RenderBlockLineLayout.cpp:

(WebCore::shouldApplyStartBorderPaddingOrMargin):
(WebCore):
(WebCore::shouldApplyEndBorderPaddingOrMargin):
(WebCore::hasInlineDirectionBordersPaddingOrMargin):
(WebCore::alwaysRequiresLineBox):

LayoutTests:

• fast/inline/inline-with-empty-inline-continuations-expected.txt: Added.
• fast/inline/inline-with-empty-inline-continuations.html: Added.

11:53 AM Changeset in webkit [148120] by zoltan@webkit.org

• 4 edits
  2 adds in trunk

[CSS Exclusions] Increasing padding does not correctly layout child blocks
​https://bugs.webkit.org/show_bug.cgi?id=112929

Reviewed by David Hyatt.

If a child block has changed dimension inside a shape and it has affected the block siblings
we need to relayout the content inside the shape.

Source/WebCore:

Test: fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout): Add condition for dimension change.
(WebCore::RenderBlock::layoutBlock): Call updateRegionsAndExclusionsAfterChildLayout with the new parameter.

• rendering/RenderBlock.h:

(RenderBlock): Add extra parameter to updateRegionsAndExclusionsAfterChildLayout(...)

LayoutTests:

• fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout-expected.html: Added.
• fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html: Added.

11:51 AM Changeset in webkit [148119] by ggaren@apple.com

• 42 edits
  2 deletes in trunk/Source

Removed bitrotted TimeoutChecker code
​https://bugs.webkit.org/show_bug.cgi?id=114336

Reviewed by Alexey Proskuryakov.

../JavaScriptCore:

This mechanism hasn't worked for a while.

MarkL is working on a new version of this feature with a distinct
implementation.

• API/APIShims.h:

(JSC::APIEntryShim::~APIEntryShim):
(JSC::APIEntryShim::init):

• GNUmakefile.list.am:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
• JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• dfg/DFGGPRInfo.h:
• jit/JIT.cpp:
• jit/JIT.h:
• jit/JITStubs.cpp:
• jit/JITStubs.h:
• jit/JSInterfaceJIT.h:

(JSInterfaceJIT):

• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

• runtime/JSGlobalData.h:
• runtime/JSGlobalObject.cpp:
• runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::walk):

• runtime/TimeoutChecker.cpp: Removed.
• runtime/TimeoutChecker.h: Removed.

../WebCore:

This mechanism hasn't worked for a while.

MarkL is working on a new version of this feature with a distinct
implementation.

• bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

• bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

• bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonJSGlobalData):

• bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

• bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

• bindings/js/JSMutationCallback.cpp:

(WebCore::JSMutationCallback::call):

• bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::executeFunctionInContext):

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneBase::CloneBase):
(WebCore::CloneSerializer::serialize):
(WebCore::CloneDeserializer::deserialize):

• bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

• bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):

../WebKit/blackberry:

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setTimeoutForJavaScriptExecution):

../WebKit/mac:

This mechanism hasn't worked for a while.

MarkL is working on a new version of this feature with a distinct
implementation.

• Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::evaluate):

../WebKit/qt:

• WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createDocumentLoader):

../WebKit2:

This mechanism hasn't worked for a while.

MarkL is working on a new version of this feature with a distinct
implementation.

• WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::construct):
(WebKit::NPJSObject::invoke):

• WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::evaluate):

11:50 AM Changeset in webkit [148118] by Patrick Gansterer

• 2 edits in trunk/Source/WebCore

Replace ENABLE_JAVASCRIPT_DEBUGGER preprocessor statements in IDL files with Conditional attribute
​https://bugs.webkit.org/show_bug.cgi?id=114352

Reviewed by Timothy Hatcher.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

• page/Console.idl:

11:48 AM Changeset in webkit [148117] by Alexandru Chiculita

• 3 edits
  2 adds in trunk

Layers with opacity and blur filters are reported as opaque to the compositor
​https://bugs.webkit.org/show_bug.cgi?id=114295

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/contents-opaque/filter.html

Some filters like opacity and blur might still trigger transparency in the layer, even though the
background is opaque. I've added the special case in RenderLayer::backgroundIsKnownToBeOpaqueInRect to check
for filters that might have transparency. Note that this special case is required only for software drawn
filters, as the transparency is going to be backed in the GraphicsLayer content. Composited filters can
figure it out in the compositor.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

Added test to check for blur and opacity filters drawn in software mode which needs
to force the layer report non-opaque to the compositor.

• compositing/contents-opaque/filter-expected.txt: Added.
• compositing/contents-opaque/filter.html: Added.

11:37 AM Changeset in webkit [148116] by Lucas Forschler

• 2 edits in tags/Safari-537.35.11/Source/WebCore

Rollout r148109.

11:26 AM Changeset in webkit [148115] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

[Texmap] In certain situations nested blending with overflow:hidden displays clipped results
​https://bugs.webkit.org/show_bug.cgi?id=114290

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-10
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

Always apply the clip when binding a surface, even if it hasn't changed.
Otherwise when binding a nested surface and rebinding its container surface,
the clip wouldn't apply.

Test: compositing/overlap-blending/nested-overlap-overflow.html

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::bind):

LayoutTests:

Added a ref-test that exposes an issue with TextureMapper overlap blending when composited.
This ref-test does not show correct results on Mac, skipped in TestExpectations and created a bug.

• compositing/overlap-blending/nested-overlap-overflow-expected.html: Added.
• compositing/overlap-blending/nested-overlap-overflow.html: Added.
• platform/mac/TestExpectations: Skipped new tests and created bug.

11:17 AM Changeset in webkit [148114] by mrowe@apple.com

• 1 edit in trunk/Source/WebKit2/ChangeLog

I should know better than to lie in ChangeLog entries.

11:14 AM Changeset in webkit [148113] by mrowe@apple.com

• 4 edits in trunk/Source/WebKit2

<rdar://problem/13617144> WKNavigationData needs to expose the destination of the navigation

Introduce WKNavigationDataCopyNavigationDestinationURL to access the destination of the navigation.

Reviewed by Darin Adler.

• UIProcess/API/C/WKNavigationData.cpp:

(WKNavigationDataCopyURL): Add a note about returning the URL from the original request for sake of
backwards-compatibility.
(WKNavigationDataCopyNavigationDestinationURL): Return the URL from our underlying WebNavigationDataStore.

• UIProcess/API/C/WKNavigationData.h:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::updateGlobalHistory): Store the current URL in to the WebNavigationDataStore
object. WKNavigationData can retrieve the value that we were previously storing here via the originalRequest.

11:14 AM Changeset in webkit [148112] by mrowe@apple.com

• 4 edits in trunk/Source/WebKit2

<rdar://problem/13617104> WKPageCopySessionState needs to provide more context to the filter callback

Introduce a new value type for WKPageSessionStateFilterCallback that represents the passing
of whole WKBackForwardListItemRefs to the filter callback. This allows clients to consider
more than the original URL of the item when filtering entries from the session state.

Reviewed by Darin Adler.

• UIProcess/API/C/WKPage.cpp:

(WKPageGetSessionBackForwardListItemValueType): Return a static string representing our new value type.

• UIProcess/API/C/WKPage.h:
• UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Call the filter function with each of the
possible value types in turn, respecting the first false value, if any, that is returned.

11:07 AM Changeset in webkit [148111] by Antti Koivisto

• 4 edits in trunk/Source/WebCore

Use minimal tiles during live resize
​https://bugs.webkit.org/show_bug.cgi?id=114364

Reviewed by Darin Adler.

We currently update non-visible speculative tiles during resizing. We should just drop them.

• page/FrameView.cpp:

(WebCore::FrameView::willStartLiveResize):
(WebCore::FrameView::willEndLiveResize):

• page/FrameView.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::computeTileCoverage):

Use minimal coverage in live resize state.

11:05 AM Changeset in webkit [148110] by zandobersek@gmail.com

• 2 edits
  1 add in trunk/Tools

[GTK] Include a crash-fixing patch for the at-spi2-atk dependency
​https://bugs.webkit.org/show_bug.cgi?id=114365

Reviewed by Martin Robinson.

Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
The patch addresses crashes in the tally_event_reply method. It is already committed into the
at-spi2-atk source tree and will be available with the next stable release, after which the
patch should be removed and the dependency version bumped.

• gtk/jhbuild.modules:
• gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.

11:03 AM Changeset in webkit [148109] by Lucas Forschler

• 2 edits in tags/Safari-537.35.11/Source/WebCore

Merged r147977. <rdar://problem/13604480>

10:55 AM Changeset in webkit [148108] by Lucas Forschler

• 4 edits in tags/Safari-537.35.11/Source

Versioning.

10:51 AM Changeset in webkit [148107] by Lucas Forschler

• 1 copy in tags/Safari-537.35.11

New Tag.

10:47 AM Changeset in webkit [148106] by oliver@apple.com

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r148073): WebKit Nightly r148082 crashes on launch in JSObjectSetPrivate
​https://bugs.webkit.org/show_bug.cgi?id=114341

Reviewed by Alexey Proskuryakov.

Make JSObjectSetPrivate use uncheckedToJS as some clients
clear their private data during finalization for some reason.

• API/JSObjectRef.cpp:

(JSObjectSetPrivate):

10:36 AM BuildingGtk edited by Martin Robinson

Warn that the instructions aren't really useful for building a release … (diff)

10:13 AM Changeset in webkit [148105] by commit-queue@webkit.org

• 19 edits
  4 adds in trunk

Blob content type normalization.
​https://bugs.webkit.org/show_bug.cgi?id=111380

Patch by Victor Costan <​costan@gmail.com> on 2013-04-10
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: http/tests/fast/files/blob-constructor.js

http/tests/fileapi/xhr-send-form-data-filename-escaping.html
http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html

• WebCore.exp.in: exported Blob::isNormalizedContentType()
• bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob): remove checks on Blob type, BlobBuilder will normalize it

• fileapi/Blob.cpp:

(BlobType): utilities for normalizing a Blob's type according to the File API spec
(WebCore::BlobType::isValid): content type validity checks in the File API spec
(WebCore::BlobType::normalize): implements the normalization rules in the File API spec
(WebCore::BlobType::isNormalized): useful for ASSERTing that a Blob type has been normalized
(WebCore): implement Blob type normalization according to the File API spec
(WebCore::Blob::Blob): normalize the Blob type in the data URL
(WebCore::Blob::slice): normalize the Blob type argument

• fileapi/Blob.h:

(BlobType): utilities for normalizing a Blob's type according to the File API spec
(WebCore::Blob::create): assert that the deserialized Blob's type was normalized

• fileapi/File.cpp:

(WebCore::createBlobDataForFileWithType): assert that the File's MIME type is a normalized Blob type

• fileapi/WebKitBlobBuilder.cpp:

(WebCore::BlobBuilder::getBlob): normalize the Blob's type before building it

• platform/network/BlobData.h:

(WebCore::BlobData::setContentType): assert that the Blob type has been normalized

• platform/network/FormData.cpp:

(WebCore::FormData::appendKeyValuePairItems): assert that Blob's type has been normalized

• platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::addContentTypeToMultiPartHeader): assert that the Content-Type field is normalized

• xml/XMLHttpRequest.cpp: when responseType is blob, normalize Content-Type before passing to Blob constructor

LayoutTests:

• http/tests/fast/files/script-tests/blob-constructor.js: added/updated test cases for Blob type normalization
• http/tests/fast/files/blob-constructor-expected.txt: added/updated test cases for Blob type normalization
• http/tests/fileapi/xhr-send-form-data-filename-escaping-expected.txt: Added.
• http/tests/fileapi/xhr-send-form-data-filename-escaping.html: Added.
• http/tests/fileapi/xhr-send-form-data-mimetype-normalization-expected.txt: Added.
• http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html: Added.
• http/tests/local/formdata/resources/send-form-data-common.js:

(dumpResponse): return the HTTP response text so it can be used in JS test code
(sendFormData): passthrough the HTTP response text returned by dumpResponse()
(testSendingFormData): passthrough the HTTP response text returned by dumpResponse()

• http/tests/xmlhttprequest/post-blob-content-type-async-expected.txt: updated expectation for invalid Content-Type
• http/tests/xmlhttprequest/post-blob-content-type-sync-expected.txt: updated expectation for invalid Content-Type
• http/tests/xmlhttprequest/post-blob-content-type-tests.js: updated expectation for invalid Content-Type

10:11 AM Changeset in webkit [148104] by Simon Fraser

• 13 edits
  8 deletes in trunk/LayoutTests

Rebaseline four tiled drawing tests affeted by r148049.

Move results from platform/mac/platform/mac-wk2/tiled-drawing to platform/mac-wk2/tiled-drawing

• platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
• platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
• platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
• platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
• platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
• platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
• platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
• platform/mac-wk2/tiled-drawing/fixed/four-bars-expected.txt:
• platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer-expected.txt:
• platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
• platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view-expected.txt:
• platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt:
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt: Removed.
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt: Removed.
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt: Removed.
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt: Removed.
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt: Removed.
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt: Removed.
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt: Removed.
• platform/mac/platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt: Removed.

9:50 AM Changeset in webkit [148103] by bfulgham@webkit.org

• 2 edits in trunk/Tools

[WinCairo] Unreviewed build fix. Correct DropBox download link.

• Scripts/update-webkit-wincairo-libs: Revise download URL to

match change in DropBox server behavior.

9:32 AM Changeset in webkit [148102] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebCore

TileController doesn't remove tiles when the view is resized, leading to stale content
​https://bugs.webkit.org/show_bug.cgi?id=114323
<rdar://problem/13520671>

Reviewed by Simon Fraser.

Ensure that tiles are removed if the view shrinks, so that they are not displayed
with stale content if the view later grows again (they will not be repainted by WebCore
while out-of-view).

• platform/graphics/ca/mac/TileController.h:
• platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::revalidateTiles):

9:28 AM Changeset in webkit [148101] by jberlin@webkit.org

• 2 edits in trunk/Source/WebCore

Update the localizable strings file.

Rubber-stamped by Dan Bernstein.

• English.lproj/Localizable.strings:

9:27 AM Changeset in webkit [148100] by Patrick Gansterer

• 3 edits in trunk/Source/WebCore

Replace ENABLE_CHANNEL_MESSAGING preprocessor statements in IDL files with Conditional attribute
​https://bugs.webkit.org/show_bug.cgi?id=114346

Reviewed by Geoffrey Garen.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

• page/DOMWindow.idl:
• workers/WorkerContext.idl:

9:25 AM Changeset in webkit [148099] by eric.carlson@apple.com

• 32 edits in trunk/Source/WebCore

Update all float attributes in HTMLMediaElement to double
​https://bugs.webkit.org/show_bug.cgi?id=113615

Reviewed by Geoffrey Garen
Patch by Aaron Colwell

No new tests. Primary behavior doesn't change. Just time, playbackRate, and volume precision.
All existing LayoutTests/media tests still pass.

• WebCore.exp.in: Remove function that no longer need to be exported.

• html/HTMLMediaElement.cpp: Change all float attributes to double.
• html/HTMLMediaElement.h: Ditto.
• html/HTMLMediaElement.idl: Ditto.
• html/MediaController.cpp: Ditto.
• html/MediaController.h: Ditto.
• html/MediaControllerInterface.h: Ditto.
• html/TimeRanges.cpp: Ditto.
• html/TimeRanges.idl: Ditto.
• html/shadow/MediaControlElementTypes.cpp: Ditto.
• html/shadow/MediaControlElementTypes.h: Ditto.
• html/shadow/MediaControlElements.cpp: Ditto.
• html/shadow/MediaControlElements.h: Ditto.
• html/shadow/MediaControls.cpp: Ditto.
• html/shadow/MediaControlsApple.cpp: Ditto.
• html/shadow/MediaControlsBlackBerry.cpp: Ditto.
• html/shadow/MediaControlsBlackBerry.h: Ditto.
• html/shadow/MediaControlsGtk.cpp: Ditto.
• html/track/TextTrackCue.cpp: Ditto.
• html/track/TextTrackCue.h: Ditto.
• platform/Clock.h: Ditto.
• platform/ClockGeneric.cpp: Ditto.
• platform/ClockGeneric.h: Ditto.
• platform/graphics/MediaPlayer.cpp: Ditto.
• platform/graphics/MediaPlayer.h: Ditto.
• platform/graphics/MediaPlayerPrivate.h: Ditto.
• platform/mac/PlatformClockCA.cpp: Ditto.
• platform/mac/PlatformClockCA.h: Ditto.
• platform/mac/PlatformClockCM.h: Ditto.
• platform/mac/PlatformClockCM.mm: Ditto.

9:16 AM Changeset in webkit [148098] by Patrick Gansterer

• 3 edits in trunk/Source/WebCore

Replace ENABLE_MICRODATA preprocessor statements in IDL files with Conditional attribute
​https://bugs.webkit.org/show_bug.cgi?id=114349

Reviewed by Geoffrey Garen.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

• dom/Document.idl:
• html/HTMLElement.idl:

9:13 AM Changeset in webkit [148097] by rakuco@webkit.org

• 2 edits in trunk/Source/WebCore

REGRESSION(r148034): IconDatabase::updateIconRecord crashes with null iconData and iconBitmap.
​https://bugs.webkit.org/show_bug.cgi?id=114356

Reviewed by Tim Horton.

When loading an icon fails (for example, when a non-existent URI is
passed to the loader), updateIconRecord can be called with both
iconData and iconBitmap having no data.

This used to be fine before r148034, but causes an assertion now.

No new tests, existing tests such as fast/encoding/mispositioned-meta.html
were crashing.

• loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::updateIconRecord): Change the ASSERT() to check
for a NAND condition that only fails if both iconData and iconBitmap
are not 0.

8:44 AM Changeset in webkit [148096] by ggaren@apple.com

• 2 edits in trunk/Tools

Removed an annoying message from svn-create-patch
​https://bugs.webkit.org/show_bug.cgi?id=114332

Reviewed by Alexey Proskuryakov.

I see this message basically every time I write a patch, so it must not
be true.

• Scripts/svn-create-patch:

(generateDiff):

8:10 AM Changeset in webkit [148095] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit/qt

[Qt] Add API in QWebSettings for setting the CSS media type
​https://bugs.webkit.org/show_bug.cgi?id=113853

Patch by Jose Lejin PJ <​jose.lejin@gmail.com> on 2013-04-10
Reviewed by Jocelyn Turcotte.

• Api/qwebsettings.cpp:

(QWebSettingsPrivate):
(QWebSettingsPrivate::apply):
(QWebSettings::setCSSMediaType):
(QWebSettings::cssMediaType):

• Api/qwebsettings.h:
• WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::overrideMediaType):

• tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage):
(tst_QWebPage::cssMediaTypeGlobalSetting):
(tst_QWebPage::cssMediaTypePageSetting):

7:58 AM Changeset in webkit [148094] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Texmap] Update a dirty region which is not covered with keepRect.
​https://bugs.webkit.org/show_bug.cgi?id=113752

Patch by JungJik Lee <​jungjik.lee@samsung.com> on 2013-04-10
Reviewed by Jocelyn Turcotte.

There can be a dirty region which is not covered with keepRect.
However the dirty could be inside the tile area. In this case,
currently we ignore the dirty by intersecting with keepRect
and the dirty region will not be invalidated until the tile is
recreated. We must expand the keep rect to its intersecting tiles
to make sure that the dirty region is applied to existing tiles.

No tests needed, change is unobservable.

• platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::invalidate):

7:36 AM Changeset in webkit [148093] by Laszlo Gombos

• 4 edits in trunk/Source

Remove ENABLE_3D_PLUGIN
​https://bugs.webkit.org/show_bug.cgi?id=108002

Source/WebCore:

Remove ENABLE_3D_PLUGIN, it was only used by Chromium.

Reviewed by Antti Koivisto.

No new tests, removing dead code.

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadPlugin):

Source/WTF:

Reviewed by Antti Koivisto.

Remove ENABLE_3D_PLUGIN, it was only used by Chromium.

• wtf/FeatureDefines.h:

6:47 AM Changeset in webkit [148092] by abucur@adobe.com

• 1 edit
  57 adds in trunk/LayoutTests

[CSS Regions] Add tests for lists and counters
​https://bugs.webkit.org/show_bug.cgi?id=103975

Reviewed by Antti Koivisto.

Lists and counters work correctly with regions since r148026 (​http://trac.webkit.org/changeset/148026).
This patch adds W3C formatted ref tests to our battery.

• fast/regions/counters/extract-list-items-001-expected.html: Added.
• fast/regions/counters/extract-list-items-001.html: Added.
• fast/regions/counters/extract-list-items-002-expected.html: Added.
• fast/regions/counters/extract-list-items-002.html: Added.
• fast/regions/counters/extract-list-items-003-expected.html: Added.
• fast/regions/counters/extract-list-items-003.html: Added.
• fast/regions/counters/extract-list-items-004-expected.html: Added.
• fast/regions/counters/extract-list-items-004.html: Added.
• fast/regions/counters/extract-list-items-005-expected.html: Added.
• fast/regions/counters/extract-list-items-005.html: Added.
• fast/regions/counters/extract-list-items-006-expected.html: Added.
• fast/regions/counters/extract-list-items-006.html: Added.
• fast/regions/counters/extract-list-items-007-expected.html: Added.
• fast/regions/counters/extract-list-items-007.html: Added.
• fast/regions/counters/extract-list-items-008-expected.html: Added.
• fast/regions/counters/extract-list-items-008.html: Added.
• fast/regions/counters/extract-list-items-009-expected.html: Added.
• fast/regions/counters/extract-list-items-009.html: Added.
• fast/regions/counters/extract-list-items-010-expected.html: Added.
• fast/regions/counters/extract-list-items-010.html: Added.
• fast/regions/counters/extract-list-items-011-expected.html: Added.
• fast/regions/counters/extract-list-items-011.html: Added.
• fast/regions/counters/extract-list-items-012-expected.html: Added.
• fast/regions/counters/extract-list-items-012.html: Added.
• fast/regions/counters/extract-list-items-013-expected.html: Added.
• fast/regions/counters/extract-list-items-013.html: Added.
• fast/regions/counters/extract-list-items-014-expected.html: Added.
• fast/regions/counters/extract-list-items-014.html: Added.
• fast/regions/counters/extract-list-items-015-expected.html: Added.
• fast/regions/counters/extract-list-items-015.html: Added.
• fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Added.
• fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Added.
• fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Added.
• fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Added.
• fast/regions/counters/extract-numbered-paragraphs-expected.html: Added.
• fast/regions/counters/extract-numbered-paragraphs.html: Added.
• fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Added.
• fast/regions/counters/extract-numbered-spans-display-only-some.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-001.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-002.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-003.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Added.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Added.
• fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Added.
• fast/regions/counters/extract-unordered-lists-in-regions.html: Added.

5:18 AM Changeset in webkit [148091] by zarvai@inf.u-szeged.hu

• 10 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening. Rebaselining after r148049.

• platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
• platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:

4:48 AM Changeset in webkit [148090] by commit-queue@webkit.org

• 6 edits
  4 adds in trunk

[Texmap] Hierarchy of layers with opacity may result in wrong blending.
​https://bugs.webkit.org/show_bug.cgi?id=113732

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-10
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

This is a combination of three issues with nested intermediate surfaces:

• glScissor inside an intermediate surface should not be mirrored.
• The current surface should be passed to the next surface in paintOptions.
• When clipping for the non-overlap region, the containing surface offset

should be applied.

Though the changes are separate, they cannot be tested separately as neither
fixes a testable case on its own.

Tests: compositing/overlap-blending/nested-non-overlap-clipping.html

compositing/overlap-blending/nested-overlap.html

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::ClipStack::reset):
(WebCore::TextureMapperGL::ClipStack::apply):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::clearIfNeeded):

• platform/graphics/texmap/TextureMapperGL.h:

(ClipStack):

Do not mirror the scissor clip when painting to an FBO.
Also a minor refactor to avoid reading the viewport values from the driver.

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintUsingOverlapRegions):

Apply the offset when clipping for a non-overlap region.

(WebCore::TextureMapperLayer::paintIntoSurface):

Make sure the current surface is passed to the next one.

LayoutTests:

Added two ref-tests for nested composited overlaps.
This ref-test does not work on Mac due to a slight mismatch opacity value on CoreAnimation.
A new bug has been posted, and TestExpectations has been updated.

• compositing/overlap-blending/nested-non-overlap-clipping-expected.html: Added.
• compositing/overlap-blending/nested-non-overlap-clipping.html: Added.
• compositing/overlap-blending/nested-overlap-expected.html: Added.
• compositing/overlap-blending/nested-overlap.html: Added.
• platform/mac/TestExpectations: Skipped new tests and created bug.

4:34 AM Changeset in webkit [148089] by Antti Koivisto

• 19 edits
  2 copies
  2 adds in trunk

Create fewer tiles when page is loading
​https://bugs.webkit.org/show_bug.cgi?id=114294

Source/WebCore:

Reviewed by Anders Carlsson.

We currently create speculative tiles immediately. Page is often changing rapidly during loading and
keeping the speculative tiles up to date creates extra work.

Tests: platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html

platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadProgressingStatusChanged):

• page/FrameView.cpp:

(WebCore::FrameView::adjustTiledBackingCoverage):
(WebCore::FrameView::setWasScrolledByUser):

User scrolling enables speculative tiling no matter what the load status.

• page/FrameView.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::computeTileCoverage):
(WebCore::RenderLayerBacking::adjustTiledBackingCoverage):

Cover only the viewport during loading.

LayoutTests:

Reviewed by Anders Carlsson.

Reduced initial tile counts and new tests for speculative tiles.

• platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
• platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
• platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt: Added.
• platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html: Added.
• platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
• platform/mac-wk2/tiled-drawing/tile-coverage-speculative-expected.txt: Added.
• platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html: Added.
• platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
• platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
• platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
• platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:

3:48 AM Changeset in webkit [148088] by mario@webkit.org

• 14 edits in trunk

[GTK] Add support for Page Visibility
​https://bugs.webkit.org/show_bug.cgi?id=97324

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-04-10
Reviewed by Sam Weinig.

.:

Page Visibility has been enabled for GTK port.
New GTK unittest has been added.

• Source/autotools/SetupWebKitFeatures.m4:

Source/WebKit/gtk:

Implemented access to page visibility API for GTK test runner.

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setPageVisibility):

• WebCoreSupport/DumpRenderTreeSupportGtk.h:

Source/WebKit2:

Added new unittest to test page visibility using GTK Widget visibility API.

• UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewPageVisibility):
(beforeAll):

• UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::showInWindow):

• UIProcess/API/gtk/tests/WebViewTest.h:

Tools:

Implemented test runner API for page visibility layout tests.

• DumpRenderTree/gtk/TestRunnerGtk.cpp:

(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):

• Scripts/webkitperl/FeatureList.pm:

LayoutTests:

• platform/gtk/TestExpectations:

2:47 AM Changeset in webkit [148087] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] RenderThemeBlackBerry: get rid of all the SKIA code
​https://bugs.webkit.org/show_bug.cgi?id=114339

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-10
Reviewed by Carlos Garcia Campos.

• platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderThumb):

2:17 AM Changeset in webkit [148086] by rakuco@webkit.org

• 2 edits in trunk/Tools

[ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
​https://bugs.webkit.org/show_bug.cgi?id=114342

Reviewed by Gyuyoung Kim.

Commit 148033 only added an implementation for the Mac port, which made
other ports fail most tests since loading the injected bundle failed
with a missing symbol.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::pathDescription):

2:06 AM Changeset in webkit [148085] by zarvai@inf.u-szeged.hu

• 9 edits
  1 move
  1 add
  1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r148049.

• platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt: Removed.
• platform/qt/compositing/iframes/page-cache-layer-tree-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/iframes/page-cache-layer-tree-expected.txt.
• platform/qt/fast/multicol/shadow-breaking-expected.txt:
• platform/qt/svg/css/composite-shadow-text-expected.png:
• platform/qt/svg/css/composite-shadow-text-expected.txt:
• platform/qt/svg/css/group-with-shadow-expected.txt:
• platform/qt/svg/css/path-with-shadow-expected.txt:
• platform/qt/svg/css/shadow-and-opacity-expected.txt:
• platform/qt/svg/css/shadow-breaking-expected.png: Added.
• platform/qt/svg/css/text-shadow-multiple-expected.txt:
• platform/qt/transitions/svg-text-shadow-transition-expected.txt:

12:55 AM Changeset in webkit [148084] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[EFL] Add spell checking option to MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=114282

Patch by Artur Moryc <​a.moryc@samsung.com> on 2013-04-10
Reviewed by Ryosuke Niwa.

Spell checking is enabled by adding a flag (t/text-checking)
with launching MiniBrowser.

• MiniBrowser/efl/main.c:

(window_create):
(elm_main):

12:39 AM Changeset in webkit [148083] by zandobersek@gmail.com

• 5 edits in trunk

REGRESSION (r146518): WebKit2APITests/TestInspector is failing
​https://bugs.webkit.org/show_bug.cgi?id=113281

Reviewed by Darin Adler.

Source/WebKit2:

Changes to the WebInspectorProxy opening processing in r146518 caused the change in how the GTK-specific
WebInspectorProxy code operates, specifically the 'bring-to-front' signal is not emitted anymore when opening the
inspector due to the WebInspectorProxy::bringToFront method now only bringing the inspector window to front if it exists
and opening it (and thus unable to bring it to front) otherwise.

Closing of the inspector through the didClose method is now done immediately after sending the WebInspector::Close()
message to the WebProcess rather than waiting for the WebProcess to communicate back the order of closing. Due to this
the relevant code in the test cases had to be changed to not run the loop but rather just check that the closing was
successful.

(InspectorTest::InspectorTest): Remove the initialization of the now redundant m_quitOnBringToFront member variable.
(InspectorTest::bringToFront): Quit the loop without checking the removed member variable.
(InspectorTest::closed): Do not quit the loop as it is not run anymore.
(InspectorTest::showIdle): A helper method that asynchronously calls the webkit_web_inspector_show method, removing some
unnecessary complexity about under what exact circumstances to quit the loop in open-window/bring-to-front callbacks.
(InspectorTest::show): Replaces the showAndWaitUntilFinished method, adding an idle invocation of the showIdle helper
method and running the loop.
(InspectorTest::close): Formerly closeAndWaitUntilClosed, now does not run the loop anymore as there's no need for it.
(testInspectorDefault): Only the window opening event is now expected upon showing the inspector for the first time.
Adjusting callsites to use InspectorTest::show and InspectorTest::close instead of
InspectorTest::showAndWaitUntilFinished and InspectorTest::showAndWaitUntilFinished.
(CustomInspectorTest::destroyWindow): Formerly destroyWindowAndWaitUntilClosed, the closing is not asynchronous anymore
so the loop is not run.
(testInspectorManualAttachDetach): Only the window opening event is now expected upon showing the inspector for the first time.
Adjusting callsites to use InspectorTest::show and InspectorTest::close instead of
InspectorTest::showAndWaitUntilFinished and InspectorTest::showAndWaitUntilFinished.
(testInspectorCustomContainerDestroyed): Adjusting callsites to use InspectorTest::show and CustomInspectorTest::destroyWindow
instead of InspectorTest::showAndWaitUntilFinished and CustomInspectorTest::destroyWindowAndWaitUntilClosed.

• UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::show): When showing a connected WebInspectorProxy, call the bringToFront method which will
open the inspector if it's not yet visible or bring it to the front otherwise.

Tools:

• Scripts/run-gtk-tests:

(TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.

12:38 AM Changeset in webkit [148082] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebKit2

[GTK][WK2] Implement WebInspectorProxy::platformInspectedWindowWidth
​https://bugs.webkit.org/show_bug.cgi?id=113498

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2013-04-10
Reviewed by Martin Robinson.

The method was introduced in r147004.

• UIProcess/API/gtk/tests/TestInspector.cpp: Specify the gMinimumAttachedInspectorWidth variable, reflecting the value

of WebInspectorProxy::minimumAttachedWidth. Use it as the width to which the inspected view should be resized in
InspectorTest::resizeViewAndAttach.

• UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformInspectedWindowHeight): Use the gtk_widget_get_allocated_height method to return the
widget height.
(WebKit::WebInspectorProxy::platformInspectedWindowWidth): Newly implemented, similarly uses the
gtk_widget_get_allocated_width method to return the widget width.

12:36 AM Changeset in webkit [148081] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r147719): Failures in two a11y tests on GTK
​https://bugs.webkit.org/show_bug.cgi?id=114259

Reviewed by Ryosuke Niwa.

No new tests - covered by existing tests.

Partially revert r147719, restoring the possible creation of the AXObject cache
and the subsequent call to its handleFocusedUIElementChanged method. Removing this
code caused regressions in accessibility tests on the GTK port, so the comment about
the AXObject cache is adjusted accordingly.

• dom/Document.cpp:

(WebCore::Document::setFocusedNode):

12:18 AM Changeset in webkit [148080] by zandobersek@gmail.com

• 11 edits in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r148049.

• platform/gtk/fast/multicol/shadow-breaking-expected.txt:
• platform/gtk/svg/css/composite-shadow-text-expected.txt:
• platform/gtk/svg/css/group-with-shadow-expected.txt:
• platform/gtk/svg/css/path-with-shadow-expected.txt:
• platform/gtk/svg/css/shadow-and-opacity-expected.txt:
• platform/gtk/svg/css/shadow-changes-expected.txt:
• platform/gtk/svg/css/text-gradient-shadow-expected.txt:
• platform/gtk/svg/css/text-shadow-multiple-expected.txt:
• platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt:
• platform/gtk/transitions/svg-text-shadow-transition-expected.txt: