Timeline

Apr 13, 2013:

9:13 PM Changeset in webkit [148380] by weinig@apple.com

• 2 edits in trunk/Source/WebCore

Fix three crashes seen on the bots after "Make Frame's ScriptController an OwnPtr and remove the #include"

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
Check that the frame is not null (as it can be in cases like http/tests/xmlhttprequest/detaching-frame-2.html).
We used to be getting lucky, in that shouldBypassMainWorldContentSecurityPolicy(), the function that is ultimately
called, only operates on global state. Now that we need to actually dereference the Frame to get the ScriptController,
we see this crash.

9:06 PM Changeset in webkit [148379] by rniwa@webkit.org

• 2 edits in trunk/Tools

Build fix attempt for webkitbot. Unicodify everything.

• Scripts/webkitpy/tool/bot/irc_command.py:

(Whois.execute):

8:55 PM Changeset in webkit [148378] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Selection direction is not preserved when applying styles
​https://bugs.webkit.org/show_bug.cgi?id=110979

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2013-04-13
Reviewed by Ryosuke Niwa.

Source/WebCore:

The patch is based on the one submitted by Shezan Baig.

If the starting selection was directional and its base was not first,
switch newStart and newEnd when setting the ending direction. Otherwise,
leave the order unchanged.

Test: editing/style/preserve-selection-direction.html

• editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::updateStartEnd):

LayoutTests:

Add a test, based on the work by Shezan Baig

• editing/style/preserve-selection-direction-expected.txt: Added.
• editing/style/preserve-selection-direction.html: Added.

8:02 PM Changeset in webkit [148377] by ap@apple.com

• 2 edits in trunk/Source/WebCore

Added svn:ignore for inspector/CodeGeneratorInspectorStrings.pyc

• inspector: Added property svn:ignore.

7:12 PM Changeset in webkit [148376] by weinig@apple.com

• 5 edits in trunk/Source/WebKit2

Add ObjC API for setting initialization data for the WKWebProcessPlugIn
​https://bugs.webkit.org/show_bug.cgi?id=103846

Reviewed by Darin Adler.

• UIProcess/API/mac/WKProcessGroup.h:

Adds a new optional processGroupWillCreateConnectionToWebProcessPlugIn: method for the WKProcessGroupDelegate protocol,
which allows the user to pass (via an autoreleased return value) initialization data to the web process plugin.

• UIProcess/API/mac/WKProcessGroup.mm:

(getInjectedBundleInitializationUserData):
(setUpInectedBundleClient):
(-[WKProcessGroup initWithInjectedBundleURL:]):
(-[WKProcessGroup dealloc]):
Use the existing WKContextInjectedBundleClient infrastructure to pass the initialization data to the bundle
via the new ObjCObjectGraph APIObject.

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:

Adds webProcessPlugIn:initializeWithObject: to the WKWebProcessPlugIn protocol, replacing webProcessPlugInInitialize:.

• WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::load):
Pass the initialization data to the web process plugin.

7:00 PM Changeset in webkit [148375] by ddkilzer@apple.com

• 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore

Attempt to fix Windows build after r148370

Try to fix the following build failure:

4>JSStringJoiner.cpp
4>..\..\runtime\JSStringJoiner.cpp(112) : error C2653: 'CheckedState' : is not a class or namespace name
4>..\..\runtime\JSStringJoiner.cpp(112) : error C2065: 'DidOverflow' : undeclared identifier
4>..\..\runtime\JSStringJoiner.cpp(112) : warning C4805: '==' : unsafe mix of type 'bool' and type unknown-type in operation

• runtime/JSStringJoiner.h: Include <wtf/CheckedArithmetic.h>.

6:27 PM Changeset in webkit [148374] by weinig@apple.com

• 2 edits in trunk/Source/WebKit2

Attempt Build Fix.

• WebProcess/Plugins/Netscape/NPJSObject.cpp:

5:54 PM Changeset in webkit [148373] by weinig@apple.com

• 88 edits in trunk/Source

Make Frame's ScriptController an OwnPtr and remove the #include
​https://bugs.webkit.org/show_bug.cgi?id=114105

Reviewed by Dean Jackson.

Source/WebCore:

• Modules/websockets/WebSocket.cpp:
• bindings/generic/BindingSecurity.cpp:
• bindings/js/JSEventListener.cpp:
• bindings/js/JSLazyEventListener.cpp:
• bindings/js/PageScriptDebugServer.cpp:
• bindings/js/ScriptEventListener.cpp:
• bindings/js/ScriptState.cpp:
• bindings/objc/DOM.mm:
• bindings/objc/DOMAbstractView.mm:
• bindings/objc/DOMInternal.mm:
• dom/DocumentStyleSheetCollection.cpp:
• dom/EventTarget.cpp:
• dom/ScriptElement.cpp:
• history/CachedFrame.cpp:
• html/HTMLCanvasElement.cpp:
• html/HTMLDocument.cpp:
• html/HTMLElement.cpp:
• html/HTMLFormElement.cpp:
• html/HTMLPlugInElement.cpp:
• html/HTMLPlugInImageElement.cpp:
• html/parser/HTMLParserOptions.cpp:
• inspector/InspectorAgent.cpp:
• inspector/InspectorController.cpp:
• inspector/InspectorFrontendClientLocal.cpp:
• inspector/InspectorFrontendHost.cpp:
• inspector/InspectorInstrumentation.cpp:
• inspector/InspectorOverlay.cpp:
• inspector/InspectorPageAgent.cpp:
• inspector/PageRuntimeAgent.cpp:
• loader/DocumentWriter.cpp:
• loader/NavigationScheduler.cpp:
• loader/SubframeLoader.cpp:
• loader/cache/CachedResourceLoader.cpp:
• page/DOMWindow.cpp:
• page/EventSource.cpp:
• page/Frame.cpp:
• page/Frame.h:
• page/Navigator.cpp:
• page/Page.cpp:
• page/PageGroup.cpp:
• xml/XMLHttpRequest.cpp:
• xml/XMLTreeViewer.cpp:

Source/WebKit/mac:

• Plugins/Hosted/HostedNetscapePluginStream.mm:
• Plugins/WebNetscapePluginStream.mm:
• Plugins/WebPluginContainerCheck.mm:
• WebCoreSupport/WebGeolocationClient.mm:
• WebCoreSupport/WebInspectorClient.mm:
• WebView/WebFrame.mm:

Source/WebKit2:

• Shared/WebHitTestResult.cpp:
• Shared/WebHitTestResult.h:
• UIProcess/Plugins/PlugInAutoStartProvider.cpp:
• UIProcess/WebContext.h:
• UIProcess/WebPageProxy.h:
• WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
• WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
• WebProcess/Plugins/Netscape/NPJSObject.cpp:
• WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
• WebProcess/Plugins/PDF/PDFPlugin.h:
• WebProcess/Plugins/PluginView.cpp:
• WebProcess/Storage/StorageAreaImpl.cpp:
• WebProcess/Storage/StorageAreaMap.cpp:
• WebProcess/WebPage/WebFrame.cpp:
• WebProcess/WebPage/WebPage.cpp:

5:46 PM Changeset in webkit [148372] by rniwa@webkit.org

• 5 edits in trunk/Tools

webkitbot should provide full name, email address, and IRC nicknames on whois
​https://bugs.webkit.org/show_bug.cgi?id=114494

Reviewed by Benjamin Poulain.

A response like the one below is useless. Improve it:
webkitbot: rniwa: zdobersek is zdobersek (​zandobersek@gmail.com). Why do you ask?

We now report full name, email address, committer/reviewer status, and IRC nickname.

Also teach webkitbot how to respond to ping.

• Scripts/webkitpy/tool/bot/irc_command.py:

(PingPong): Moved
(PingPong.execute):
(Whois._full_record_and_nick): Renamed and rewritten.
(Whois.execute):

• Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_whois): Updated test cases as needed.

• Scripts/webkitpy/tool/bot/ircbot_unittest.py:

(IRCBotTest.test_help): Added ping.

• Scripts/webkitpy/tool/commands/newcommitbot.py:

(NewCommitBot): Teached WKR how to respond to hi.

5:28 PM Changeset in webkit [148371] by rniwa@webkit.org

• 5 edits in trunk/Websites/bugs.webkit.org

Delete bubbles from webkit-commit-queue.appspot.com now that we've completed the transition
​https://bugs.webkit.org/show_bug.cgi?id=114476

Reviewed by Gyuyoung Kim.

• code-review.js:
• template/en/custom/attachment/edit.html.tmpl:
• template/en/custom/attachment/list.html.tmpl:
• template/en/custom/attachment/reviewform.html.tmpl:

4:15 PM Changeset in webkit [148370] by ddkilzer@apple.com

• 7 edits in branches/safari-536.30-branch

Merge 145580, 145587, 145594, r145595, r145647, 145759. Part 2/2 for <rdar://problem/13438603>.

4:15 PM Changeset in webkit [148369] by ddkilzer@apple.com

• 2 edits
  1 add in branches/safari-536.30-branch/Source/WTF

Merge r141499, r141950, r141965. Part 1/2 for <rdar://problem/13438603>.

Add Source/WTF/wtf/EnumClass.h

3:28 PM Changeset in webkit [148368] by andersca@apple.com

• 14 edits
  1 add in trunk

Add form delegate method that's invoked right before sending a submit event to a form element
​https://bugs.webkit.org/show_bug.cgi?id=114575

Reviewed by Dan Bernstein.

Source/WebCore:

• WebCore.exp.in:

Export a symbol.

• WebCore.xcodeproj/project.pbxproj:

Make DOMHTMLFormElementInternal.h a private header.

Source/WebKit/mac:

• MigrateHeaders.make:

Copy DOMHTMLFormElementInternal.h over to WebKit.

• WebCoreSupport/WebFrameLoaderClient.mm:

(makeFormFieldValuesDictionary):
New helper function that returns the values of a form in dictionary form.

(WebFrameLoaderClient::dispatchWillSendSubmitEvent):
Call the right delegate method.

(WebFrameLoaderClient::dispatchWillSubmitForm):
Use the helper function.

• WebView/WebDelegateImplementationCaching.h:
• WebView/WebDelegateImplementationCaching.mm:

(CallFormDelegate):
Add another overload.

• WebView/WebFormDelegate.h:
• WebView/WebFormDelegate.m:

(-[WebFormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
Add a default implementation.

Tools:

Add a test.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm: Added.

(-[FormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

• TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::toSTD):
Don't crash when a null NSString is passed to toSTD.

3:01 PM Changeset in webkit [148367] by robert@webkit.org

• 3 edits
  4 adds in trunk

Whitespace between nowrap elements ignored after collapsed trailing space in a text run
​https://bugs.webkit.org/show_bug.cgi?id=17705

Reviewed by Ryosuke Niwa.

Source/WebCore:

Bug 93448 and r138654 fixed the treatment of line-breaks between nowrap elements. This augments
that fix by recognizing that we have a potential break not only in situations where the next character is a
space and the current character is not, but also where the next character is a space and the current character
*is* a space *and* we are ignoring spaces. This is so because any spaces we have ignored up to this point
after the actual word end will get collapsed away even if we don't end up taking the line break.

In a nutshell, if we allow whitespace collapsing 'word ' and 'word' are equivalent when before a whitespace
character, so treat the first as well as the second as a potential linebreak.

Test: fast/text/whitespace/inline-whitespace-wrapping-5.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

• fast/text/whitespace/inline-whitespace-wrapping-5-expected.html: Added.
• fast/text/whitespace/inline-whitespace-wrapping-5.html: Added.
• fast/text/whitespace/inline-whitespace-wrapping-6-expected.html: Added.
• fast/text/whitespace/inline-whitespace-wrapping-6.html: Added.

2:49 PM Changeset in webkit [148366] by Lucas Forschler

• 4 edits
  3 copies in branches/safari-536.30-branch

Merged r136845. <rdar://problem/13334927>

2:11 PM QtWebKit edited by Ｖ字龍

Add QupZilla Web Browser which also uses QtWebKit (diff)

1:03 PM Changeset in webkit [148365] by akling@apple.com

• 19 edits in trunk/Source

Rename/tweak some StylePropertySet/CSSStyleDeclaration copying functions.
<​http://webkit.org/b/114569>

Reviewed by Anders Carlsson.

• StylePropertySet::copy() -> mutableCopy()

This function now returns a MutableStylePropertySet, and this is also reflected in the name.

• CSSStyleDeclaration::copy() -> copyProperties()

Renamed to reflect that it's the properties being copied, not the CSSStyleDeclaration.
They also now return MutableStylePropertySets.

• StylePropertySet::copyPropertiesInSet()
• CSSStyleDeclaration::copyPropertiesInSet()

These functions now return MutableStylePropertySets.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::copyProperties):
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

• css/CSSComputedStyleDeclaration.h:

(CSSComputedStyleDeclaration):

• css/CSSStyleDeclaration.h:

(CSSStyleDeclaration):

• css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::copyProperties):

• css/PropertySetCSSStyleDeclaration.h:
• css/StylePropertySet.cpp:

(WebCore::StylePropertySet::mutableCopy):
(WebCore::StylePropertySet::copyPropertiesInSet):

• css/StylePropertySet.h:

(StylePropertySet):

• css/StyleRule.cpp:

(WebCore::StyleRule::StyleRule):
(WebCore::StyleRule::mutableProperties):
(WebCore::StyleRulePage::StyleRulePage):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::StyleRuleFontFace):
(WebCore::StyleRuleFontFace::mutableProperties):
(WebCore::StyleRuleViewport::StyleRuleViewport):
(WebCore::StyleRuleViewport::mutableProperties):
(WebCore::StyleRuleFilter::StyleRuleFilter):
(WebCore::StyleRuleFilter::mutableProperties):

• css/ViewportStyleResolver.cpp:

(WebCore::ViewportStyleResolver::addViewportRule):

• css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::mutableProperties):

• dom/Element.cpp:

(WebCore::UniqueElementData::UniqueElementData):

• dom/StyledElement.cpp:

(WebCore::StyledElement::ensureMutableInlineStyle):

• editing/ApplyStyleCommand.cpp:

(WebCore::copyStyleOrCreateEmpty):

• editing/EditingStyle.cpp:

(WebCore::copyEditingProperties):
(WebCore::editingStyleFromComputedStyle):
(WebCore::EditingStyle::EditingStyle):
(WebCore::EditingStyle::init):
(WebCore::EditingStyle::copy):
(WebCore::EditingStyle::mergeStyle):
(WebCore::getPropertiesNotIn):

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::copyTypingStyle):

11:19 AM Changeset in webkit [148364] by Lucas Forschler

• 8 edits in branches/safari-536.30-branch/Source/WebKit2

Merged r147512. <rdar://problem/13380323>

11:00 AM Changeset in webkit [148363] by krit@webkit.org

• 11 edits
  2 moves in trunk/Source/WebCore

Rename StyleBuilder to DeprecatedStyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=114532

Reviewed by Benjamin Poulain.

The StyleBuilder code is hard to read and maintain. People should
not add new properties to this class. To make this clear, this
patch renames the class to DeprecatedStyleBuilder.

Pure refactoring, no change in functionality.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSAllInOne.cpp:
• css/DeprecatedStyleBuilder.cpp: Renamed from Source/WebCore/css/StyleBuilder.cpp.
• css/DeprecatedStyleBuilder.h: Renamed from Source/WebCore/css/StyleBuilder.h.
• css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::reportMemoryUsage):

• css/StyleResolver.h:

(StyleResolver):

• rendering/style/RenderStyle.h:

10:56 AM Changeset in webkit [148362] by rniwa@webkit.org

• 2 edits in trunk/Tools

Python test fix attempt after r148360.

• Scripts/webkitpy/tool/multicommandtool_unittest.py:

(test_command_help):

10:53 AM Changeset in webkit [148361] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Update Mac WebKit2 test expectations for flaky and failing tests.

• platform/mac-wk2/TestExpectations:

10:39 AM Changeset in webkit [148360] by rniwa@webkit.org

• 19 edits in trunk/Tools

Merge AbstractDeclarativeCommand into Command as a comment suggests
​https://bugs.webkit.org/show_bug.cgi?id=114559

Reviewed by Antti Koivisto.

Merged two classes as the comment right above AbstractDeclarativeCommand suggested.
We need to merge a lot more classes to make webkitpy hackable.

• Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:

(AbstractLocalServerCommand):
(AbstractLocalServerCommand.init):

• Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:

(AbstractSequencedCommand):
(AbstractSequencedCommand.init):

• Scripts/webkitpy/tool/commands/adduserstogroups.py:

(AddUsersToGroups):

• Scripts/webkitpy/tool/commands/analyzechangelog.py:

(AnalyzeChangeLog):
(AnalyzeChangeLog.init):

• Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
• Scripts/webkitpy/tool/commands/bugfortest.py:

(BugForTest):

• Scripts/webkitpy/tool/commands/bugsearch.py:

(BugSearch):

• Scripts/webkitpy/tool/commands/chromechannels.py:

(ChromeChannels):
(init):

• Scripts/webkitpy/tool/commands/download.py:

(AbstractPatchProcessingCommand):

• Scripts/webkitpy/tool/commands/findusers.py:

(FindUsers):

• Scripts/webkitpy/tool/commands/openbugs.py:

(OpenBugs):

• Scripts/webkitpy/tool/commands/queries.py:

(BugsToCommit):
(PatchesInCommitQueue):
(PatchesToCommitQueue):
(PatchesToCommitQueue.init):
(PatchesToReview):
(PatchesToReview.init):
(PatchesToReview.execute):
(WhatBroke):
(ResultsFor):
(FailureReason):
(FindFlakyTests):
(TreeStatus):
(CrashLog):
(PrintExpectations):
(PrintExpectations.init):
(PrintBaselines):
(PrintBaselines.init):

• Scripts/webkitpy/tool/commands/queues.py:

(AbstractQueue.init):

• Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractRebaseliningCommand):

• Scripts/webkitpy/tool/commands/suggestnominations.py:

(SuggestNominations):
(SuggestNominations.init):

• Scripts/webkitpy/tool/commands/upload.py:

(CommitMessageForCurrentDiff):
(CommitMessageForCurrentDiff.init):
(CleanPendingCommit):
(CleanReviewQueue):
(AssignToCommitter):
(PostCommits):
(PostCommits.init):
(MarkBugFixed):
(MarkBugFixed.init):
(CreateBug):
(CreateBug.init):

• Scripts/webkitpy/tool/multicommandtool.py:

(Command):
(Command.init):
(Command.main):
(HelpCommand):
(HelpCommand.init):

• Scripts/webkitpy/tool/multicommandtool_unittest.py:

(TrivialCommand):
(TrivialCommand.init):
(LikesToRetry):
(LikesToRetry.init):
(CommandTest.test_name_with_arguments):
(CommandTest.test_required_arguments):
(test_command_help):

9:43 AM Changeset in webkit [148359] by akling@apple.com

• 6 edits in trunk/Source/WebCore

Remove unused method CSSStyleDeclaration::makeMutable().
<​http://webkit.org/b/114567>

Reviewed by Anders Carlsson.

• css/CSSComputedStyleDeclaration.cpp:
• css/CSSComputedStyleDeclaration.h:

(CSSComputedStyleDeclaration):

• css/CSSStyleDeclaration.h:

(CSSStyleDeclaration):

• css/PropertySetCSSStyleDeclaration.cpp:
• css/PropertySetCSSStyleDeclaration.h:

9:38 AM Changeset in webkit [148358] by Antoine Quint

• 3 edits
  2 adds in trunk

Width of last of consecutive tabs may be incorrect with "white-space: pre-wrap"
​https://bugs.webkit.org/show_bug.cgi?id=114562

Reviewed by Dan Bernstein.

Source/WebCore:

When we measure the last word of a RenderText, make sure we use the correct x
position taking into account the current accumulated word measurements up to
this character. This is of particular importance in the case of tabs where the
measured width would differ based on the x position.

Test: fast/text/tab-last-word-in-renderer-pre-wrap.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

LayoutTests:

• fast/text/tab-last-word-in-renderer-pre-wrap-expected.html: Added.
• fast/text/tab-last-word-in-renderer-pre-wrap.html: Added.

9:07 AM Changeset in webkit [148357] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Windows, WinCairo] ImageBufferCairo.cpp fails to compile after 148247, 148264.
​https://bugs.webkit.org/show_bug.cgi?id=114540

Patch by Mark Salisbury <​mark.salisbury@hp.com> on 2013-04-13
Reviewed by Brent Fulgham.

• platform/graphics/cairo/ImageBufferCairo.cpp:

7:09 AM Changeset in webkit [148356] by Patrick Gansterer

• 2 edits in trunk/Source/JavaScriptCore

Add missing export macro to SymbolTableEntry::freeFatEntrySlow()

• runtime/SymbolTable.h:

(SymbolTableEntry):

5:04 AM Changeset in webkit [148355] by commit-queue@webkit.org

• 5 edits in trunk

[EFL] --minimal build fails with error: 'ViewModeInvalid' is not a member of 'WebCore::Page'
​https://bugs.webkit.org/show_bug.cgi?id=114048

Patch by Ed Bartosh <​bartosh@gmail.com> on 2013-04-13
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Wrapped view-mode media related code into #if ENABLE(VIEW_MODE_CSS_MEDIA)

• WebCoreSupport/AssertMatchingEnums.cpp:
• ewk/ewk_view.cpp:

(ewk_view_mode_set):

Tools:

Wrapped view media related code in #if ENABLE(VIEW_MODE_CSS_MEDIA)

• DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::setViewModeMediaFeature):

2:47 AM Changeset in webkit [148354] by rniwa@webkit.org

• 2 edits
  2 deletes in trunk/Tools

Merge watchlistloader into host since it's an unnecessary indirection
​https://bugs.webkit.org/show_bug.cgi?id=114555

Reviewed by Antti Koivisto.

We don't need a class to load a file.

• Scripts/webkitpy/common/host.py:

(Host.watch_list):

• Scripts/webkitpy/common/watchlist/watchlistloader.py: Removed.
• Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Removed.

1:16 AM Changeset in webkit [148353] by rniwa@webkit.org

• 4 edits in trunk/Tools

Rename JSONResultsGeneratorBase to JSONResultsGenerator
​https://bugs.webkit.org/show_bug.cgi?id=114553

Reviewed by Philippe Normand.

Renamed now that we've got rid of the old JSONResultsGenerator in r148352.

• Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator):

• Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGenerator):

• Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

(JSONGeneratorTest._test_json_generation):
(JSONGeneratorTest._verify_json_results):

1:02 AM Changeset in webkit [148352] by rniwa@webkit.org

• 8 edits in trunk/Tools

Remove more Chromium specific code from webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=114552

Reviewed by Philippe Normand.

• Scripts/webkitpy/common/host.py:

(Host.checkout):

• Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase):
(JSONResultsGeneratorBase.init):
(JSONResultsGeneratorBase._is_results_all_of_type):

• Scripts/webkitpy/layout_tests/port/base.py:

(Port):
(Port.expected_filename):

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):

• Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue._new_port_name_from_old):
(CommitQueue.did_pass_testing_ews):

• Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._results_url):
(Rebaseline._builder_with_name):

• Scripts/webkitpy/tool/mocktool.py:

(MockTool.irc):

12:56 AM Changeset in webkit [148351] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r148311.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(resizeWebKitWebViewBaseFromAllocation): Passing IntSize() as the scroll offset
argument to the DrawingAreaProxy::setSize method.

12:53 AM Changeset in webkit [148350] by fpizlo@apple.com

• 4 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Fix release build.

• dfg/DFGOSRExitCompilerCommon.cpp:
• ftl/FTLExitValue.cpp:
• ftl/FTLOSRExitCompiler.cpp:

12:40 AM Changeset in webkit [148349] by zandobersek@gmail.com

• 3 edits in trunk/Tools

Fix flakiness dashboard unit test failures
​https://bugs.webkit.org/show_bug.cgi?id=114518

Reviewed by Ryosuke Niwa.

Fix the current failures in unit tests for the flakiness dashboard by adjusting failing
test cases to simulate loading the builders list from the webkit.org build master, replacing
the Chromium builders and platforms that are used in tests with builders and platforms for the
Apple Mac Lion WebKit2 port, and removing two test cases that were testing Chromium-specific
functionality of the dashboard.

This is sort of an interlude to the flakiness dashboard cleanup, with the removal of Chromium-specific
code and hopefully general simplification of the dashboard codebase coming in near future.

• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):
(test):

• TestResultServer/static-dashboards/loader_unittests.js:

12:38 AM Changeset in webkit [148348] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix after r148305.

• GNUmakefile.list.am: Adding the TrackListBase build targets to the build.

12:38 AM Changeset in webkit [148347] by fpizlo@apple.com

• 35 edits
  26 adds in branches/dfgFourthTier/Source

fourthTier: FTL should have OSR exit
​https://bugs.webkit.org/show_bug.cgi?id=113623

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This implements OSR exit, and hilariously, it actually works. The idea is to have
LLVM call a no-return function on the off-ramp, passing it everything we know about
bytecode state that isn't already flushed to the call frame. Our own JIT takes care
of the rest.

We can now run all of SunSpider, V8, and Kraken with the FTL enabled.

The details are described in FTLOSRExit.h.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• assembler/AbstractMacroAssembler.h:

(Address):
(JSC::AbstractMacroAssembler::Address::withOffset):

• assembler/LinkBuffer.h:

(JSC::LinkBuffer::offsetOf):
(LinkBuffer):

• assembler/MacroAssemblerX86Common.h:
• assembler/RepatchBuffer.h:

(JSC::RepatchBuffer::RepatchBuffer):
(JSC::RepatchBuffer::~RepatchBuffer):
(RepatchBuffer):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::tallyFrequentExitSites):

• bytecode/Operands.h:

(Operands):
(JSC):
(JSC::::dump):

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):

• dfg/DFGGPRInfo.h:

(DFG):
(GPRInfo):

• dfg/DFGMinifiedNode.h:

(JSC::DFG::belongsInMinifiedGraph):

• dfg/DFGNodeType.h:

(JSC::DFG::needsOSRBackwardRewiring):
(DFG):
(JSC::DFG::needsOSRForwardRewiring):

• dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):
(DFG):
(JSC::DFG::OSRExit::convertToForward):

• dfg/DFGOSRExit.h:

(OSRExit):

• dfg/DFGOSRExitBase.cpp: Added.

(DFG):
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):
(JSC::DFG::OSRExitBase::doSearchForForwardConversion):

• dfg/DFGOSRExitBase.h: Added.

(DFG):
(JSC::DFG::OSRExitBase::OSRExitBase):
(OSRExitBase):
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSite):

• dfg/DFGOSRExitCompiler.cpp:
• dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

• dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):

• dfg/DFGOSRExitCompilerCommon.h:

(DFG):

• dfg/DFGOSRExitPreparation.cpp: Added.

(DFG):
(JSC::DFG::prepareCodeOriginForOSRExit):

• dfg/DFGOSRExitPreparation.h: Added.

(DFG):

• dfg/DFGOperations.cpp:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

• dfg/DFGValueSource.h:

(JSC::DFG::ValueSource::forSpeculation):

• dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

• ftl/FTLAbbreviations.h:

(JSC::FTL::functionType):
(FTL):
(JSC::FTL::typeOf):
(JSC::FTL::appendBasicBlock):
(JSC::FTL::insertBasicBlock):
(JSC::FTL::buildCall):
(JSC::FTL::setTailCall):

• ftl/FTLCArgumentGetter.cpp: Added.

(FTL):
(JSC::FTL::CArgumentGetter::loadNextAndBox):

• ftl/FTLCArgumentGetter.h: Added.

(FTL):
(JSC::FTL::isArgumentRegister):
(CArgumentGetter):
(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):
(JSC::FTL::CArgumentGetter::nextAddress):

• ftl/FTLCompile.cpp:

(JSC::FTL::compile):

• ftl/FTLExitArgument.cpp: Added.

(FTL):
(JSC::FTL::ExitArgument::dump):

• ftl/FTLExitArgument.h: Added.

(FTL):
(ExitArgumentRepresentation):
(ExitArgument):
(JSC::FTL::ExitArgument::ExitArgument):
(JSC::FTL::ExitArgument::operator!):
(JSC::FTL::ExitArgument::format):
(JSC::FTL::ExitArgument::argument):
(JSC::FTL::ExitArgument::withFormat):
(JSC::FTL::ExitArgument::representation):

• ftl/FTLExitArgumentForOperand.cpp: Added.

(FTL):
(JSC::FTL::ExitArgumentForOperand::dump):

• ftl/FTLExitArgumentForOperand.h: Added.

(FTL):
(ExitArgumentForOperand):
(JSC::FTL::ExitArgumentForOperand::ExitArgumentForOperand):
(JSC::FTL::ExitArgumentForOperand::operator!):
(JSC::FTL::ExitArgumentForOperand::exitArgument):
(JSC::FTL::ExitArgumentForOperand::operand):
(JSC::FTL::lesserArgumentIndex):

• ftl/FTLExitArgumentList.h: Added.

(FTL):

• ftl/FTLExitThunkGenerator.cpp: Added.

(FTL):
(JSC::FTL::ExitThunkGenerator::ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::~ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::emitThunk):

• ftl/FTLExitThunkGenerator.h: Added.

(FTL):
(ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::didThings):

• ftl/FTLExitValue.cpp: Added.

(FTL):
(JSC::FTL::ExitValue::dump):

• ftl/FTLExitValue.h: Added.

(FTL):
(ExitValue):
(JSC::FTL::ExitValue::ExitValue):
(JSC::FTL::ExitValue::operator!):
(JSC::FTL::ExitValue::dead):
(JSC::FTL::ExitValue::inJSStack):
(JSC::FTL::ExitValue::inJSStackAsInt32):
(JSC::FTL::ExitValue::inJSStackAsDouble):
(JSC::FTL::ExitValue::constant):
(JSC::FTL::ExitValue::exitArgument):
(JSC::FTL::ExitValue::kind):
(JSC::FTL::ExitValue::isDead):
(JSC::FTL::ExitValue::isInJSStackSomehow):
(JSC::FTL::ExitValue::isConstant):
(JSC::FTL::ExitValue::isArgument):

• ftl/FTLFormattedValue.h:

(FTL):
(JSC::FTL::noValue):
(JSC::FTL::int32Value):
(JSC::FTL::uInt32Value):
(JSC::FTL::booleanValue):
(JSC::FTL::jsValueValue):
(JSC::FTL::doubleValue):

• ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::initializeExitThunks):
(FTL):
(JSC::FTL::JITCode::exitThunks):

• ftl/FTLJITCode.h:

(JITCode):

• ftl/FTLLowerDFGToLLVM.cpp:

(FTL):
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileMovHint):
(JSC::FTL::LowerDFGToLLVM::compileZombieHint):
(JSC::FTL::LowerDFGToLLVM::compileMovHintAndCheck):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::speculateBackward):
(JSC::FTL::LowerDFGToLLVM::speculateForward):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::terminate):
(JSC::FTL::LowerDFGToLLVM::backwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::forwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::typeCheck):
(JSC::FTL::LowerDFGToLLVM::appendTypeCheck):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::isLive):
(JSC::FTL::LowerDFGToLLVM::use):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::tryToSetConstantExitArgument):
(JSC::FTL::LowerDFGToLLVM::addExitArgument):
(JSC::FTL::LowerDFGToLLVM::linkOSRExitsAndCompleteInitializationBlocks):
(JSC::FTL::LowerDFGToLLVM::observeMovHint):

• ftl/FTLOSRExit.cpp: Added.

(FTL):
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::codeLocationForRepatch):
(JSC::FTL::OSRExit::convertToForward):

• ftl/FTLOSRExit.h: Added.

(FTL):
(OSRExit):

• ftl/FTLOSRExitCompilationInfo.h: Added.

(FTL):
(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):
(OSRExitCompilationInfo):

• ftl/FTLOSRExitCompiler.cpp: Added.

(FTL):
(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):

• ftl/FTLOSRExitCompiler.h: Added.

(FTL):

• ftl/FTLOutput.h:

(JSC::FTL::Output::newBlock):
(JSC::FTL::Output::intToPtr):
(JSC::FTL::Output::load):
(JSC::FTL::Output::store):
(Output):
(JSC::FTL::Output::call):
(JSC::FTL::Output::convertToTailCall):
(FTL):

• ftl/FTLState.h:

(State):

• ftl/FTLThunks.cpp: Added.

(FTL):
(JSC::FTL::osrExitGenerationThunkGenerator):

• ftl/FTLThunks.h: Added.

(JSC):
(FTL):

• ftl/FTLValueFormat.cpp: Added.

(WTF):
(WTF::printInternal):

• ftl/FTLValueFormat.h: Added.

(FTL):
(WTF):

• ftl/FTLValueSource.cpp: Added.

(FTL):
(JSC::FTL::ValueSource::dump):

• ftl/FTLValueSource.h: Added.

(FTL):
(ValueSource):
(JSC::FTL::ValueSource::ValueSource):
(JSC::FTL::ValueSource::kind):
(JSC::FTL::ValueSource::operator!):
(JSC::FTL::ValueSource::node):

Source/WTF:

Reviewed by Oliver Hunt.

Finally make toCString() somewhat variadic.

• wtf/StringPrintStream.h:

(WTF):
(WTF::toCString):

Apr 12, 2013:

9:39 PM Changeset in webkit [148346] by rniwa@webkit.org

• 2 edits in branches/safari-536.30-branch/Source/WebKit2

Merged r148284. <rdar://problem/13335003>

9:23 PM Changeset in webkit [148345] by rniwa@webkit.org

• 3 edits in branches/safari-536.30-branch/Source/WebCore

Merged 140893. <rdar://problem/13334946>

9:18 PM Changeset in webkit [148344] by rniwa@webkit.org

• 5 edits in branches/safari-536.30-branch/Source/WebCore

Merged r141315. <rdar://problem/13334946>

9:15 PM Changeset in webkit [148343] by rniwa@webkit.org

• 4 edits in branches/safari-536.30-branch/Source/WebCore

Merged r140886. <rdar://problem/13334946>

8:52 PM Changeset in webkit [148342] by rniwa@webkit.org

• 8 edits in branches/safari-536.30-branch/Source/WebCore

Merged r140892. <rdar://problem/13334946>

8:15 PM Changeset in webkit [148341] by rniwa@webkit.org

• 4 edits in branches/safari-536.30-branch/Source/WebCore

Merged r140891. <rdar://problem/13334946>

8:09 PM Changeset in webkit [148340] by rniwa@webkit.org

• 9 edits
  2 copies in branches/safari-536.30-branch

Merged r140748. <rdar://problem/13334946>

7:38 PM Changeset in webkit [148339] by rniwa@webkit.org

• 2 edits in branches/safari-536.30-branch/Source/WebKit2

Merged r141445. <rdar://problem/13266396>

7:32 PM Changeset in webkit [148338] by rniwa@webkit.org

• 2 edits in branches/safari-536.30-branch/Source/WebKit2

Merged r141445. <rdar://problem/13335003>

7:08 PM Changeset in webkit [148337] by Lucas Forschler

• 1 edit
  2 copies in branches/safari-536.30-branch/LayoutTests

Merged r136596. <rdar://problem/13334868>

7:02 PM Changeset in webkit [148336] by Lucas Forschler

• 2 edits
  6 copies in branches/safari-536.30-branch/LayoutTests

Merged r133701. <rdar://problem/13334976>

7:00 PM Changeset in webkit [148335] by Lucas Forschler

• 2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r129814. <rdar://problem/13334978>

6:52 PM Changeset in webkit [148334] by Lucas Forschler

• 5 edits in branches/safari-536.30-branch/LayoutTests

Merged r128747. <rdar://problem/13266379>

6:47 PM Changeset in webkit [148333] by Lucas Forschler

• 3 edits in branches/safari-536.30-branch/LayoutTests

Merged r123167. <rdar://problem/13266379>

6:44 PM Changeset in webkit [148332] by roger_fong@apple.com

• 3 edits in branches/safari-536.30-branch/Source/WebCore

Merged r143565, <rdar://problem/13334867>

6:37 PM Changeset in webkit [148331] by barraclough@apple.com

• 7 edits in trunk/Source/WebKit2

Add private interface to WKView to asynchronously update the drawing area size
​https://bugs.webkit.org/show_bug.cgi?id=114549

Reviewed by Simon Fraser.

This will allow a client using the WKView to resize the contents without blocking waiting for the web process to repaint.

• UIProcess/API/mac/WKView.mm:

(-[WKView _setDrawingAreaSize:]):

• if the new size of teh drawing area does not match the frame size, position it according to the contentAnchor.

(-[WKView updateLayer]):

• Don't let a subsequent frame size change block on a prior async resize.

(-[WKView forceAsyncDrawingAreaSizeUpdate:]):

• resize the drawing area asynchronously, even if frame size udpates are disabled.

(-[WKView waitForAsyncDrawingAreaSizeUpdate]):

• wait for asynchronous updates to complete.

• UIProcess/API/mac/WKViewPrivate.h:
  • declare new methods.

• UIProcess/DrawingAreaProxy.cpp:

(WebKit):

• UIProcess/DrawingAreaProxy.h:

(DrawingAreaProxy):
(WebKit::DrawingAreaProxy::waitForPossibleGeometryUpdate):

• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:

(TiledCoreAnimationDrawingAreaProxy):

• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForPossibleGeometryUpdate):

• pass timeout for waitForPossibleGeometryUpdate as a parameter.

6:25 PM Changeset in webkit [148330] by jberlin@webkit.org

• 2 edits in trunk/Source/WebKit2

32-bit build fix.

• UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):

6:09 PM Changeset in webkit [148329] by jpfau@apple.com

• 8 edits in trunk

Query directly for cache partition names
​https://bugs.webkit.org/show_bug.cgi?id=114538

Reviewed by David Kilzer.

Source/WebKit2:

Call back into WebKitSystemInterface to ask it for the cache
partition names instead of trying to figure them out.

• WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::getCacheOrigins):
(WebKit):
(WebKit::WebResourceCacheManager::returnCacheOrigins):

• WebProcess/ResourceCache/WebResourceCacheManager.h:

(WebResourceCacheManager):

• WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:

(WebKit::WebResourceCacheManager::cfURLCacheHostNames):
(WebKit):
(WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):

WebKitLibraries:

• WebKitSystemInterface.h:
• libWebKitSystemInterfaceLion.a:
• libWebKitSystemInterfaceMountainLion.a:

6:02 PM Changeset in webkit [148328] by ddkilzer@apple.com

• 2 edits in trunk/Tools

BUILD FIX: Make AccessibilityUIElementIOS.mm build on iOS

Reviewed by Chris Fleizach.

• DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Declare

-_accessibilityPath from the WebAccessibilityObjectWrapper
class.
(_CGPathEnumerationIteration): Remove unused CGPoint* variable.

5:55 PM Changeset in webkit [148327] by timothy_horton@apple.com

• 5 edits
  2 adds in branches/safari-536.30-branch

Merge r132856. <rdar://problem/13334380>

5:49 PM Changeset in webkit [148326] by timothy_horton@apple.com

• 4 edits
  2 adds in branches/safari-536.30-branch

Merge r131488. <rdar://problem/13334380>

5:46 PM Changeset in webkit [148325] by rniwa@webkit.org

• 3 edits
  2 copies in branches/safari-536.30-branch

Merged r130717. <rdar://problem/13334846>

5:37 PM Changeset in webkit [148324] by barraclough@apple.com

• 2 edits in trunk/Source/WebKit2

Build fix - too soon!

• UIProcess/API/mac/WKViewPrivate.h:

5:33 PM Changeset in webkit [148323] by roger_fong@apple.com

• 5 edits in trunk/Source/WebCore

Update AVFoundationCF code following ​http://trac.webkit.org/changeset/148291.
​https://bugs.webkit.org/show_bug.cgi?id=114548.

Reviewed by Eric Carlson.

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::seekToTime):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMinTimeSeekable):
(WebCore):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:

(MediaPlayerPrivateAVFoundationCF):

5:15 PM Changeset in webkit [148322] by barraclough@apple.com

• 2 edits in trunk/Source/WebKit2

Build fix - too soon!

• UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):

5:15 PM Changeset in webkit [148321] by rniwa@webkit.org

• 2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r136619. <rdar://problem/13335066>

5:09 PM Changeset in webkit [148320] by rniwa@webkit.org

• 5 edits in branches/safari-536.30-branch

Merged r117463. <rdar://problem/13335066>

5:03 PM Changeset in webkit [148319] by Lucas Forschler

• 2 edits
  2 deletes in branches/safari-536.30-branch/LayoutTests

Merged r138692. <rdar://problem/13334855>

4:58 PM Changeset in webkit [148318] by Lucas Forschler

• 1 edit
  4 copies
  3 adds
  1 delete in branches/safari-536.30-branch/LayoutTests

Merged r138686. <rdar://problem/13334855>

4:55 PM Changeset in webkit [148317] by jpfau@apple.com

• 2 edits in trunk/Tools

Unreviewed, remove an old email address for myself.

• Scripts/webkitpy/common/config/committers.py:

4:47 PM Changeset in webkit [148316] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Demystify some code in RenderLayer::updateScrollableAreaSet()
​https://bugs.webkit.org/show_bug.cgi?id=114543

Reviewed by Tim Horton.

Clean up some code that called functions with important side effects
inside a ternary operator, and clean up the #ifdefs.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollableAreaSet):

4:46 PM Changeset in webkit [148315] by Lucas Forschler

• 7 edits
  15 copies
  2 deletes in branches/safari-536.30-branch

Merged r138654. <rdar://problem/13334855>

4:43 PM Changeset in webkit [148314] by mhahnenberg@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Block freeing thread should call Region::destroy instead of delete
​https://bugs.webkit.org/show_bug.cgi?id=114544

Reviewed by Oliver Hunt.

Since Region doesn't have a virtual destructor, calling delete will not properly clean up all of
the state of the Region. We should call destroy() instead.

• heap/BlockAllocator.cpp:

(JSC::BlockAllocator::releaseFreeRegions):
(JSC::BlockAllocator::blockFreeingThreadMain):

4:42 PM Changeset in webkit [148313] by fpizlo@apple.com

• 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: switch to using MCJIT and disable frame pointer elimination
​https://bugs.webkit.org/show_bug.cgi?id=114542

Reviewed by Oliver Hunt and Michael Saboff.

• ftl/FTLCompile.cpp:

(JSC::FTL::compile):

• runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

4:29 PM Changeset in webkit [148312] by benjamin@webkit.org

• 11 edits
  1 add in trunk

[WK2] WebPageProxy loadURL() won't work when called just after terminateProcess()
​https://bugs.webkit.org/show_bug.cgi?id=110743

Patch by Adenilson Cavalcanti <​cavalcantii@gmail.com> on 2013-04-12
Reviewed by Benjamin Poulain.

Source/WebKit2:

A call to loadURL() just after terminating WebProcess will fail thanks to
WebPageProxy being in an undefined state since it is in the middle of its own
cleanup after process termination.

To properly fix this, not only WebPageProxy cleanup should be made
at WebProcess termination request, but also WebProcessProxy needs
to only return to its caller after terminating the process and
closing connections. Otherwise, WebPageProxy can even be able to
detect that WebProcess is no longer running, but a call to respawn
the process will fail.

To fix these issues, this patch moves the cleanup code to a shared private function
that is used for both the cases i.e. user termination and real crash. WebProcess
shutdown is done using a new method that ensures that all cleanup was done before
returning.

A last change introduced in this patch is that for user requested termination,
clients are no longer notified of a crash (since it is not a crash).

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::terminateProcess):
(WebKit::WebPageProxy::processDidCrash):
(WebKit):
(WebKit::WebPageProxy::resetStateAfterProcessExited):

• UIProcess/WebPageProxy.h:

(WebPageProxy):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::userRequestedTerminate):
(WebKit):

• UIProcess/WebProcessProxy.h:

(WebProcessProxy):

Tools:

Adding a new test file to check if loading a page just after WebProcess
has crashed (or was terminated) works. The test executes the
following steps (Load, Crash, Load), thus stressing WebProcess
reattach and process termination code path.

• TestWebKitAPI/GNUmakefile.am:
• TestWebKitAPI/PlatformEfl.cmake:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:

(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Added.

(TestWebKitAPI):
(WebKit2CrashLoader):
(TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
(TestWebKitAPI::WebKit2CrashLoader::loadUrl):
(TestWebKitAPI::WebKit2CrashLoader::crashWebProcess):
(TestWebKitAPI::didFinishLoad):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/WebKit2.pro:

4:18 PM Changeset in webkit [148311] by barraclough@apple.com

• 15 edits in trunk/Source/WebKit2

Add contentAnchor to WKView
​http://bugs.webkit.org/show_bug.cgi?id=114469

Currently if you call setFrameSize: while frame size updates are disabled, or if the geometry
update times out, then the previously rendered page content will be rendered anchored to the
top left corner of the frame.

This is appropriate if the frame is being resized from the bottom right corner. In order to
achieve a more desirable appearance if the frame is being resized from another corner we
should allow the corner at which the content anchors to be specified.

Reviewed by Simon Fraser.

• UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):

• If the content anchor has been set, then updating the frame size moves the origin within the layer.

(-[WKView _setDrawingAreaSize:]):

• Instruct the drawing area to paint at the correct position within the layer.

(-[WKView _setAcceleratedCompositingModeRootLayer:]):

• If the root layer is cleared this implicitly resets any origin position we had set within it.

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

• initialize new data members.

(-[WKView setContentAnchor:]):
(-[WKView contentAnchor]):

• Accessor implementation for @property contentAnchor.

• UIProcess/API/mac/WKViewPrivate.h:

(NS_ENUM):

• Added WKContentAnchor enum type, and @property contentAnchor.

• UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::setSize):

• Don't suppress geometry updates where the layer poistion has changed.

• UIProcess/DrawingAreaProxy.h:

(DrawingAreaProxy):

• Added m_layerPosition, layerPosition argument to setSize

• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:

(TiledCoreAnimationDrawingAreaProxy):

• Added m_lastSentLayerPosition

• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):

• Don't suppress geometry updates where the layer poistion has changed.

(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):

• Pass layer position in UpdateGeometry message.

• WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::updateGeometry):

• Added layerPosition argument to updateGeometry

• WebProcess/WebPage/DrawingArea.messages.in:
  • Added layerPosition argument to updateGeometry

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

• Added layerPosition argument to updateGeometry

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):

• Added layerPosition argument to updateGeometry

4:11 PM Changeset in webkit [148310] by ap@apple.com

• 3 edits
  3 adds in trunk

<rdar://problem/13277362> REGRESSION (r141981): Crash when closing a Google Docs document
​https://bugs.webkit.org/show_bug.cgi?id=114541

Reviewed by Brady Eidson.

Test: http/tests/ssl/ping-with-unsafe-redirect.html

• loader/FrameNetworkingContext.h: (WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect): Added a null check. All NetworkingContext functions except for this one had it already.

4:07 PM Changeset in webkit [148309] by Lucas Forschler

• 1 edit in branches/safari-536.30-branch/LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl

Update from testRunner to layoutTestController

4:07 PM Changeset in webkit [148308] by Lucas Forschler

• 2 edits in branches/safari-536.30-branch/LayoutTests

Update from testRunner to layoutTestController

3:50 PM Changeset in webkit [148307] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Unreviewed. Don't forget to skip the test in WebKit2 for now.

• platform/mac-wk2/TestExpectations:

3:46 PM Changeset in webkit [148306] by rniwa@webkit.org

• 10 edits
  2 adds in trunk

[Mac] REGRESSION: Auto substitution strips new lines
​https://bugs.webkit.org/show_bug.cgi?id=114537

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by SpellingCorrectionCommand's use of InsertTextCommand. This command can't insert
new lines and there's even an assertion for it. Use TypingCommand::insertText instead.

Since TypingCommand::insertText calls appliedEditing on its own, we need to avoid calling that again in
CompositeEditCommand::apply after SpellingCorrectionCommand::doApply. Replaced the check in apply to use
callsAppliedEditingInDoApply instead of isTypingCommand, and added callsAppliedEditingInDoApply to both
TypingCommand and SpellingCorrectionCommand to return true (it returns false by default).

Test: platform/mac/editing/spelling/autocorrection-with-multi-line-text.html

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::apply): Use TypingCommand::insertText instead of InsertTextCommand
(WebCore::CompositeEditCommand::callsAppliedEditingInDoApply): Added. Returns false.

• editing/CompositeEditCommand.h:

(CompositeEditCommand):

• editing/SpellingCorrectionCommand.cpp:

(WebCore::SpellingCorrectionCommand::doApply):
(WebCore::SpellingCorrectionCommand::callsAppliedEditingInDoApply): Added. Returns true.

• editing/SpellingCorrectionCommand.h:

(SpellingCorrectionCommand):

• editing/TypingCommand.cpp:

(WebCore::TypingCommand::callsAppliedEditingInDoApply): Added. Returns true.

• editing/TypingCommand.h:

(TypingCommand):

Tools:

Add a rule to replace "helloleworld" by "hello\nworld" for testing purpose.

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

LayoutTests:

Added a regression test. Unfortunately, we can't setup text substituion in DumpRenderTree
so use NSSpellChecker to exercise the relevant code path.

• platform/mac/editing/spelling/autocorrection-with-multi-line-text-expected.txt: Added.
• platform/mac/editing/spelling/autocorrection-with-multi-line-text.html: Added.

3:04 PM Changeset in webkit [148305] by commit-queue@webkit.org

• 16 edits
  1 copy
  1 add in trunk/Source/WebCore

Refactor TextTrack and TextTrackList to make it easier to add audio and video tracks
​https://bugs.webkit.org/show_bug.cgi?id=114330

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-04-12
Reviewed by Jer Noble.

No new tests because this doesn't add new functionality.

• CMakeLists.txt: Only compile text track files if ENABLE(VIDEO_TRACK), and add TrackListBase
• Target.pri: Add TrackListBase
• WebCore.vcproj/WebCore.vcproj: Correct InbandTextTrackPrivate.h's location and add TrackListBase
• WebCore.xcodeproj/project.pbxproj: Add TrackListBase
• html/HTMLMediaElement.cpp: Renamed "track" functions to "textTrack"

(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack): Renamed.
(WebCore::HTMLMediaElement::mediaPlayerDidRemoveTextTrack): Renamed.
(WebCore::HTMLMediaElement::addTextTrack): Renamed.
(WebCore::HTMLMediaElement::removeTextTrack): Renamed.
(WebCore::HTMLMediaElement::removeAllInbandTracks): Use renamed functions.
(WebCore::HTMLMediaElement::didAddTextTrack): Renamed.
(WebCore::HTMLMediaElement::didRemoveTextTrack): Renamed.

• html/HTMLMediaElement.h:

Renamed "track" functions to "textTrack" and only forward-declare TextTrackList if ENABLE(VIDEO_TRACK)

• html/HTMLTrackElement.cpp: Renamed "track" functions to "textTrack"

(WebCore::HTMLTrackElement::insertedInto):
(WebCore::HTMLTrackElement::removedFrom):

• html/track/TextTrack.cpp:

Move media element, label, language and kind into TrackBase and move EventTarget functions into TextTrack.
(WebCore::TextTrack::TextTrack): Added.
(WebCore::TextTrack::interfaceName): Added.
(WebCore::TextTrack::scriptExecutionContext): Added.
(WebCore::TextTrack::eventTargetData): Added.
(WebCore::TextTrack::ensureEventTargetData): Added.
(WebCore::TextTrack::isValidKind): Added to support TrackBase::setKind()
(WebCore::TextTrack::setKind): Override to support textTrackKindChanged()
(WebCore::TextTrack::isRendered): Use kind(), label() and language() instead of m_kind, etc.
(WebCore::TextTrack::platformTextTrack): Ditto.
(WebCore::TextTrack::isMainProgramContent): Ditto.

• html/track/TextTrack.h:

Same as TextTrack.cpp, plus added defaultKindKeyword() so TrackBase::setKind() will work and added
toTextTrack().

• html/track/TextTrackList.cpp:

Move functionality into TrackListBase, add toTextTrack() casts, use
TrackBase where necesssary and use owner() instead of m_owner.

Moved EventTarget functions into TrackListBase.
(TextTrackList::TextTrackList):
(TextTrackList::getTrackIndexRelativeToRenderedTracks):
(TextTrackList::item):
(TextTrackList::invalidateTrackIndexesAfterTrack):
(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::contains):

• html/track/TextTrackList.h:

Move EventTarget, RefCounted and m_inbandTracks into TrackListBase.
Override length(), contains() and remove().

• html/track/TrackBase.cpp: Remove EventTarget functions.

(WebCore::TrackBase::TrackBase):
Remove EventTarget, add label and language
(WebCore::TrackBase::setKind): Added

• html/track/TrackBase.h:

Don't extend EventTarget (AudioTrack and VideoTrack aren't). Handle
kind, label, language and media element.
(WebCore::TrackBase::setMediaElement): Added.
(WebCore::TrackBase::mediaElement): Added.
(WebCore::TrackBase::kind): Added.
(WebCore::TrackBase::label): Added.
(WebCore::TrackBase::setLabel): Added.
(WebCore::TrackBase::language): Added.
(WebCore::TrackBase::setLanguage): Added.

• html/track/TrackListBase.cpp:

Added. Handles functionality common to TextTrackList, AudioTrackList and
VideoTrackList.
(TrackListBase::TrackListBase): Added.
(TrackListBase::~TrackListBase): Added.
(TrackListBase::length): Added.
(TrackListBase::remove): Added.
(TrackListBase::contains): Added.
(TrackListBase::scheduleAddTrackEvent): Added.
(TrackListBase::scheduleRemoveTrackEvent): Added.
(TrackListBase::scheduleChangeEvent): Added.
(TrackListBase::asyncEventTimerFired): Added.

• html/track/TrackListBase.h:

Copied from Source/WebCore/html/track/TextTrackList.h. Handles
functionality common to TextTrackList, AudioTrackList and VideoTrackList.
(WebCore::TrackListBase::scriptExecutionContext): Added.
(WebCore::TrackListBase::clearOwner): Added.
(WebCore::TrackListBase::owner): Added.
(WebCore::TrackListBase::isFiringEventListeners): Added.

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::addTextTrack): Renamed (was addTrack)
(WebCore::MediaPlayer::removeTextTrack): Renamed (was removeTrack)

• platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerDidAddTextTrack): Renamed (was mediaPlayerDidAddTrack)
(WebCore::MediaPlayerClient::mediaPlayerDidRemoveTextTrack): Renamed (was mediaPlayerDidRemoveTrack)

2:54 PM Changeset in webkit [148304] by rniwa@webkit.org

• 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r148296 and r148297.
​http://trac.webkit.org/changeset/148296
​http://trac.webkit.org/changeset/148297
​https://bugs.webkit.org/show_bug.cgi?id=114536

Needs more thought (Requested by ap on #webkit).

• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:

2:39 PM Changeset in webkit [148303] by oliver@apple.com

• 18 edits in trunk/Source/WebCore

make the codegenerator actually emit polymorphism check in the "no vtable" path
​https://bugs.webkit.org/show_bug.cgi?id=114533

Reviewed by David Kilzer.

Make the "no vtable" check correct so that we actually plant a polymorphism
check. Update a few interfaces to have the correct validation attributes.

• Modules/webdatabase/SQLTransaction.idl:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::toJS):

• bindings/scripts/test/TestInterface.idl:
• html/track/TextTrackCue.idl:
• svg/SVGAnimatedAngle.idl:
• svg/SVGAnimatedBoolean.idl:
• svg/SVGAnimatedEnumeration.idl:
• svg/SVGAnimatedInteger.idl:
• svg/SVGAnimatedLength.idl:
• svg/SVGAnimatedLengthList.idl:
• svg/SVGAnimatedNumber.idl:
• svg/SVGAnimatedNumberList.idl:
• svg/SVGAnimatedPreserveAspectRatio.idl:
• svg/SVGAnimatedRect.idl:
• svg/SVGAnimatedString.idl:
• svg/SVGAnimatedTransformList.idl:

1:44 PM Changeset in webkit [148302] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Enable selecting text in single line input field without selection point being actually on the targeted text vertically
​https://bugs.webkit.org/show_bug.cgi?id=114515

Patch by Yongxin Dai <​yodai@rim.com> on 2013-04-12
Reviewed by Rob Buis.

PR #317924.
Internally reviewed by Mike Fenton.

It was still hard to select text in URL bar with an inverted selection handle.
We improve the issue by replacing the Y coordinate of selection point with Y
coordinate of start caret for single line input filed. Thus, the Y coordinate
is always valid regardless of the actual location of the selection handle.

• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::startCaretViewportRect):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

• WebKitSupport/SelectionHandler.h:

(SelectionHandler):

1:28 PM Changeset in webkit [148301] by oliver@apple.com

• 14 edits in trunk/Source/WebCore

Make CodeGeneratorJS plant comments to explain failures in the binding validation
​https://bugs.webkit.org/show_bug.cgi?id=114528

Reviewed by Sam Weinig.

No change in behaviour, just make the generated bindings include comments
to aid diagnosing issues that may be non-obvious.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::toJS):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::toJS):

1:17 PM Changeset in webkit [148300] by timothy_horton@apple.com

• 8 edits in trunk/Source

REGRESSION (r138858): GIFs don't start playing when they come out of background tabs
​https://bugs.webkit.org/show_bug.cgi?id=108864
<rdar://problem/13140489>

Reviewed by Antti Koivisto.

Don't repaint the world when animations resume; instead, FrameView
will cause all animated images to repaint. This line also had no effect for
TiledCoreAnimationDrawingArea, which does not implement setNeedsDisplay.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::resumeActiveDOMObjectsAndAnimations):

• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::resumeAnimatingImagesForLoader): Added.
Iterate through all of the loader's cached resources. If they are bitmap images
which claim to be animatable, notify the image's observers that the animation advanced
by one frame. In reality, the image is still on the same frame, but will now be repainted,
restarting the animation loop.

• loader/cache/CachedImage.h:
• page/FrameView.cpp:

(WebCore::FrameView::setIsInWindow):
When the FrameView is brought into a window, repaint all animated images.

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::canAnimate): Added.
Return whether or not the image should animate (claims to animate, has not already
finished its animation, and has an ImageObserver) *and* has more than one frame.

• platform/graphics/BitmapImage.h:

(BitmapImage): Add canAnimate.

1:10 PM Changeset in webkit [148299] by roger_fong@apple.com

• 2 edits in trunk/Tools

Re-enable WinEWS tests.

• Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

12:35 PM Changeset in webkit [148298] by Martin Robinson

• 13 edits in trunk/Source/WebCore

r148197 broke the GTK+ build
​https://bugs.webkit.org/show_bug.cgi?id=114525

Reviewed by Anders Carlsson.

Re-add the ENABLE(SCROLLING_THREAD) guards to scrolling thread files
and extend them with USE(COORDINATED_GRAPHICS). This code is unused
by other configurations currently.

• page/scrolling/ScrollingStateFixedNode.cpp: Re-add guards.
• page/scrolling/ScrollingStateFixedNode.h: Ditto.
• page/scrolling/ScrollingStateNode.cpp: Ditto.
• page/scrolling/ScrollingStateNode.h: Ditto.
• page/scrolling/ScrollingStateScrollingNode.cpp: Ditto.
• page/scrolling/ScrollingStateScrollingNode.h: Ditto.
• page/scrolling/ScrollingStateStickyNode.cpp: Ditto.
• page/scrolling/ScrollingStateStickyNode.h: Ditto.
• page/scrolling/ScrollingStateTree.cpp: Ditto.
• page/scrolling/ScrollingStateTree.h: Ditto.
• page/scrolling/mac/ScrollingStateNodeMac.mm: Ditto.
• page/scrolling/mac/ScrollingStateScrollingNodeMac.mm: Ditto.

12:28 PM Changeset in webkit [148297] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/13334446> [Mac] Tweak sandbox profile.

Apply a post-landing review comment.

• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:

12:14 PM Changeset in webkit [148296] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/13334446> [Mac] Tweak sandbox profile.

Reviewed by Jessie Berlin.

• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:

12:09 PM Changeset in webkit [148295] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

(AVFoundation) WebKit fails to detect live stream.
​https://bugs.webkit.org/show_bug.cgi?id=114474

Reviewed by Eric Carlson.

Remove a workaround (added by r88944) for an error in an Apple.com javascript
media controller. The error has been fixed, and the workaround is causing problems
with other media streams.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):

11:57 AM Changeset in webkit [148294] by Carlos Garcia Campos

• 15 edits
  6 adds
  4 deletes in trunk

[GTK] Split GtkAuthenticationDialog in two widgets
​https://bugs.webkit.org/show_bug.cgi?id=103644

Reviewed by Xan Lopez.

Source/WebCore:

The current GtkAuthenticationDialog implements both the common
logic and widgets to implement a real GtkDialog and a widget to be
embedded in any container. WebKit1 uses a GtkDialog while WebKit2
embeds the dialog in the WebView. This patch splits the code to
leave in Platform only the code that is actually common, leaving
the widget implementation to the WebKit layer, using a dialog in
WebKit1 and embedding auth widget in the WebView in WebKit2.

• GNUmakefile.list.am: Add new files to compilation.
• platform/gtk/GtkAuthenticationDialog.cpp: Removed.
• platform/gtk/GtkAuthenticationDialog.h: Removed.
• platform/gtk/WebKitAuthenticationWidget.cpp: Added.

(_WebKitAuthenticationWidgetPrivate):
(packTwoColumnLayoutInBox):
(createLabel):
(createEntry):
(webkitAuthenticationWidgetInitialize):
(webkitAuthenticationWidgetFinalize):
(webkit_authentication_widget_init):
(webkit_authentication_widget_class_init):
(webkitAuthenticationWidgetNew):
(webkitAuthenticationWidgetCreateCredential):
(webkitAuthenticationWidgetGetChallenge):

• platform/gtk/WebKitAuthenticationWidget.h: Added.

(_WebKitAuthenticationWidget):
(_WebKitAuthenticationWidgetClass):

Source/WebKit/gtk:

• GNUmakefile.am: Add new files to compilation.
• WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
Use helper createAuthenticationDialog() to create and show the
auth dialog.

• webkit/webkitauthenticationdialog.cpp: Added.

(authenticationDialogResponseCallback):
(createAuthenticationDialog):

• webkit/webkitauthenticationdialog.h: Added.
• webkit/webkitsoupauthdialog.cpp:

(sessionAuthenticate): Ditto.

Source/WebKit2:

• GNUmakefile.list.am: Add new files to compilation.
• UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.cpp: Removed.
• UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.h: Removed.
• UIProcess/API/gtk/WebKitAuthenticationDialog.cpp: Added.

(webkitAuthenticationDialogAuthenticate): Use the
AuthenticationChallengeProxy to authenticate and destroy the dialog.
(okButtonClicked): Call webkitAuthenticationDialogAuthenticate()
with the credential.
(cancelButtonClicked): Call
webkitAuthenticationDialogAuthenticate() with a NULL credential to
continue without credential.
(webkitAuthenticationDialogInitialize): Build the UI.
(webkitAuthenticationDialogDraw): Draw a background.
(webkitAuthenticationDialogMap): Grab default button.
(webkitAuthenticationDialogConstructed): Create a GtkStyleContext
with the GtkWindow path to draw the widget background like a real
dialog.
(webkit_authentication_dialog_class_init):
(webkitAuthenticationDialogNew): Create a new
WebKitAuthenticationDialog widget.

• UIProcess/API/gtk/WebKitAuthenticationDialog.h: Added.
• UIProcess/API/gtk/WebKitLoaderClient.cpp:
• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewHandleAuthenticationChallenge): Create a
WebKitAuthenticationDialog widget and pass add it to the
container.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate): Updated to use the widget directly.
(webkitWebViewChildIsInternalWidget): Ditto.
(webkitWebViewBaseAddAuthenticationDialog): Ditto.
(webkitWebViewBaseCancelAuthenticationDialog): Ditto.
(webkitWebViewBaseContainerRemove): Ditto.
(webkitWebViewBaseContainerForall): Ditto.
(resizeWebKitWebViewBaseFromAllocation): Ditto.
(webkitWebViewBaseFocus): Ditto.
(webkitWebViewBaseDestroy): Destroy the auth widget is present.
(webkit_web_view_base_class_init): Add implementation for
GtkWidgetClass::destroy.

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

Tools:

• gtk/generate-gtkdoc:

(get_webkit2_options): Do not generate api docs for
WebKitAuthenticationDialog which is private in WebKit2.
(get_webkit1_options): Do not generate api docs for
webkitauthenticationdialog which is private in WebKit1.

11:45 AM Changeset in webkit [148293] by Martin Robinson

• 2 edits in trunk

[GTK] Lower the pango dependency
​https://bugs.webkit.org/show_bug.cgi?id=114520

Reviewed by Carlos Garcia Campos.

• Source/autotools/Versions.m4: Only depend on Pango 1.30.0 instead of

Pango 1.32.0. 1.32.0 isn't strictly necessary and the version of GTK+ that
we depend on (3.6.0) depends on 1.30.0.

11:43 AM Changeset in webkit [148292] by rniwa@webkit.org

• 2 edits in trunk/Tools

WebKit Queues should capitalize K in Wk2
​https://bugs.webkit.org/show_bug.cgi?id=114524

Reviewed by Philippe Normand.

• QueueStatusServer/model/queues.py:

(Queue.display_name):

11:39 AM Changeset in webkit [148291] by jer.noble@apple.com

• 9 edits in trunk/Source/WebCore

Add support for MediaPlayer::minTimeSeekable()
​https://bugs.webkit.org/show_bug.cgi?id=114484

Reviewed by Eric Carlson.

Plumb a new minTimeSeekable() method through MediaPlayer and
MediaPlayerPrivate and use this new method in the existing
HTMLMediaElement::minTimeSeekable() method.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::minTimeSeekable): Pass to MediaPlayer.

• platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::minTimeSeekable): Return 0.
(WebCore::MediaPlayer::minTimeSeekable): Pass to MediaPlayerPrivate.

• platform/graphics/MediaPlayer.h:
• platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::seekable): Define in terms of

minTimeSeekable()

(WebCore::MediaPlayerPrivateInterface::minTimeSeekable): Default to 0.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):

Initialize new m_cachedMinTimeSeekable ivar.

(WebCore::MediaPlayerPrivateAVFoundation::maxTimeSeekableDouble):

Renamed from maxTimeSeekable().

(WebCore::MediaPlayerPrivateAVFoundation::minTimeSeekable): Added.

Cache value of platformMinTimeSeekable().

(WebCore::MediaPlayerPrivateAVFoundation::seekableTimeRangesChanged):

Reset m_cachedMinTimeSeekable.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime): float -> double.
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMinTimeSeekable):

Added. Retrieve the lowest value from -[m_playerItem seekableTimeRanges].

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeSeekable):

float -> double.

11:36 AM Changeset in webkit [148290] by andersca@apple.com

• 2 edits in trunk/Source/WebKit/win

All tests crash on Windows
​https://bugs.webkit.org/show_bug.cgi?id=114522

Reviewed by Ryosuke Niwa.

In the MSVC++ ABI, a member function pointer will have a different size depending on whether the
class it belongs to is defined or not. Because of this, when passing member function pointers as parameters
it's important to ensure that the class is known by both the caller and the callee.

• WebFrame.cpp:

Include PolicyChecker.h

11:06 AM Changeset in webkit [148289] by rniwa@webkit.org

• 20 edits
  2 adds
  60 deletes in trunk

Unreviewed, rolling out r147942, r148026, and r148092.
​http://trac.webkit.org/changeset/147942
​http://trac.webkit.org/changeset/148026
​http://trac.webkit.org/changeset/148092
​https://bugs.webkit.org/show_bug.cgi?id=114521

"r147942 is buggy. Rollback all the patches depending on it."
(Requested by abucur on #webkit).

Source/WebCore:

• dom/ContainerNode.cpp:

(WebCore::willRemoveChildren):
(WebCore):
(WebCore::ContainerNode::removeChildren):

• dom/Document.cpp:

(WebCore::Document::nodeChildrenWillBeRemoved):
(WebCore):

• dom/Document.h:

(Document):

• dom/Node.cpp:
• dom/Node.h:

(Node):

• dom/NodeTraversal.cpp:
• dom/NodeTraversal.h:

(ElementTraversal):
(NodeTraversal):

• dom/Range.cpp:

(WebCore::boundaryNodeChildrenWillBeRemoved):
(WebCore):
(WebCore::Range::nodeChildrenWillBeRemoved):

• dom/Range.h:
• html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

• html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):

• rendering/RenderCounter.cpp:

(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):

• rendering/RenderListItem.cpp:

(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):

• rendering/RenderListItem.h:

(RenderListItem):

LayoutTests:

• fast/dom/MutationObserver/added-out-of-order-expected.txt:
• fast/dom/MutationObserver/added-out-of-order.html:
• fast/dom/Range/range-remove-children-event-expected.txt: Removed.
• fast/dom/Range/range-remove-children-event.html: Removed.
• fast/dom/containerNode-expected.txt: Added.
• fast/dom/containerNode.html: Added.
• fast/dom/shadow/shadow-and-list-elements-expected.html:
• fast/events/mutation-during-innerHTML-expected.txt: Removed.
• fast/events/mutation-during-innerHTML.html: Removed.
• fast/lists/positioned-count-crash-expected.txt:
• fast/regions/counters/extract-list-items-001-expected.html: Removed.
• fast/regions/counters/extract-list-items-001.html: Removed.
• fast/regions/counters/extract-list-items-002-expected.html: Removed.
• fast/regions/counters/extract-list-items-002.html: Removed.
• fast/regions/counters/extract-list-items-003-expected.html: Removed.
• fast/regions/counters/extract-list-items-003.html: Removed.
• fast/regions/counters/extract-list-items-004-expected.html: Removed.
• fast/regions/counters/extract-list-items-004.html: Removed.
• fast/regions/counters/extract-list-items-005-expected.html: Removed.
• fast/regions/counters/extract-list-items-005.html: Removed.
• fast/regions/counters/extract-list-items-006-expected.html: Removed.
• fast/regions/counters/extract-list-items-006.html: Removed.
• fast/regions/counters/extract-list-items-007-expected.html: Removed.
• fast/regions/counters/extract-list-items-007.html: Removed.
• fast/regions/counters/extract-list-items-008-expected.html: Removed.
• fast/regions/counters/extract-list-items-008.html: Removed.
• fast/regions/counters/extract-list-items-009-expected.html: Removed.
• fast/regions/counters/extract-list-items-009.html: Removed.
• fast/regions/counters/extract-list-items-010-expected.html: Removed.
• fast/regions/counters/extract-list-items-010.html: Removed.
• fast/regions/counters/extract-list-items-011-expected.html: Removed.
• fast/regions/counters/extract-list-items-011.html: Removed.
• fast/regions/counters/extract-list-items-012-expected.html: Removed.
• fast/regions/counters/extract-list-items-012.html: Removed.
• fast/regions/counters/extract-list-items-013-expected.html: Removed.
• fast/regions/counters/extract-list-items-013.html: Removed.
• fast/regions/counters/extract-list-items-014-expected.html: Removed.
• fast/regions/counters/extract-list-items-014.html: Removed.
• fast/regions/counters/extract-list-items-015-expected.html: Removed.
• fast/regions/counters/extract-list-items-015.html: Removed.
• fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Removed.
• fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Removed.
• fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Removed.
• fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Removed.
• fast/regions/counters/extract-numbered-paragraphs-expected.html: Removed.
• fast/regions/counters/extract-numbered-paragraphs.html: Removed.
• fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Removed.
• fast/regions/counters/extract-numbered-spans-display-only-some.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-001.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-002.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-003.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Removed.
• fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Removed.
• fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Removed.
• fast/regions/counters/extract-unordered-lists-in-regions.html: Removed.

10:58 AM Changeset in webkit [148288] by jer.noble@apple.com

• 13 edits
  2 adds in trunk

TimeRanges::nearest() returns incorrect results.
​https://bugs.webkit.org/show_bug.cgi?id=114483

Reviewed by Eric Carlson.

.:

Add symbols needed by WebCoreTestSupport to exports list.

• Source/autotools/symbols.filter:

Source/WebCore:

Test: media/timeranges-nearest.html

TimeRanges::nearest() has had an incorrect algorithm since its
addition, which has gone unnoticed because no media engine supports
seekable ranges with greater than one entry, and no media engine
seekable ranges with startTime values > 0.

Fix the algorithm used to walk a TimeRanges object; return the closest
time, not the smallest delta between range and target time.

• html/TimeRanges.cpp:

(TimeRanges::nearest):

Add some internal functions to allow us to write LayoutTests for
TimeRanges objects:

• WebCore.exp.in:
• testing/Internals.cpp:

(WebCore::Internals::createTimeRanges):
(WebCore::Internals::closestTimeToTimeRanges):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

Add symbols needed by WebCoreTestSupport to the exports list.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

Add symbols needed by WebCoreTestSupport to the exports list.

• WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

• media/timeranges-nearest-expected.txt: Added.
• media/timeranges-nearest.html: Added.

10:40 AM Changeset in webkit [148287] by oliver@apple.com

• 2 edits in trunk/Source/WTF

Remove bogus change

10:24 AM Changeset in webkit [148286] by Carlos Garcia Campos

• 4 edits in trunk/Source/WebKit2

[GTK] Web Process crash when the UI process finishes too early
​https://bugs.webkit.org/show_bug.cgi?id=112729

Reviewed by Anders Carlsson.

The problem is when creating the GSocket in the WorkQeue for the
socket descriptor. GLib considers a programmer error to create a
GSocket providing an invalid socket and finishes the process with
g_error(). We are actually providing a valid socket when creating
the GSocket, but it can be invalidated by the worker thread while
the GSocket is being created. This is because
registerEventSourceHandler is called from the main thread and
unregisterEventSourceHandler can be called from the worker
thread. We are currently registering two event handlers, one to
read data from the socket and another one to close the CoreIPC
connection when the socket connection is broken. Every event
source registered uses its own GSocket (even if the file
descriptor is actually the same), so that when the UI process
finishes too early, the first event handler can be executed in the
worker thread, closing the socket descriptor, while the main
thread is creating the GSocket for the second one.
We don't really need to use a separate event handler to monitor
the connection, because GSocket always notifies when condition is
G_IO_HUP and G_IO_ERR even if they haven't been explicitly set in
g_socket_create_source(). We can register socket event sources
differently, providing also a function to be called when the
connection is closed, using a single socket and the same even source.

• Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::open): Register a single socket event
handler providing also a function to be called when the connection
is closed.

• Platform/WorkQueue.h:

(WorkQueue):

• Platform/gtk/WorkQueueGtk.cpp: The EventSource class has been

split, moving everyting specific to socket event source to a
derived class SocketEventSource.
(WorkQueue::EventSource::EventSource):
(WorkQueue::EventSource::performWork):
(WorkQueue::EventSource::performWorkOnce):
(WorkQueue::EventSource::performWorkOnTermination):
(WorkQueue::EventSource::deleteEventSource):
(WorkQueue::EventSource):
(WorkQueue::SocketEventSource):
(WorkQueue::SocketEventSource::SocketEventSource):
(WorkQueue::SocketEventSource::cancel):
(WorkQueue::SocketEventSource::didClose):
(WorkQueue::SocketEventSource::checkCondition):
(WorkQueue::SocketEventSource::eventCallback):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatchOnSource):

10:23 AM Changeset in webkit [148285] by eric.carlson@apple.com

• 23 edits
  2 adds in trunk

Support "forced" subtitles
​https://bugs.webkit.org/show_bug.cgi?id=114460

Reviewed by Jer Noble.

Source/WebCore:

Test: media/track/track-forced-subtitles.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackGroup): Enable a forced track if nothing else is enabled.
(WebCore::HTMLMediaElement::configureTextTracks): Include forced tracks with captions+subtitles.

• html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::InbandTextTrack): Deal with kind=forced.

• html/track/TextTrack.cpp:

(WebCore::TextTrack::forcedKeyword): New keyword.
(WebCore::TextTrack::isValidKindKeyword): Include forced.
(WebCore::TextTrack::platformTextTrack): Ditto.

• html/track/TextTrack.h:

• page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::primaryAudioTrackLanguageOverride): New override to support testing.

• page/CaptionUserPreferences.h:

• page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Support forced tracks.

• platform/graphics/InbandTextTrackPrivate.h:

• platform/graphics/PlatformTextTrack.h: Add Forced, minor cleanup.

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processCue): Drive-by enhancement: log cue position.

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::kind): Support forced.
(WebCore::InbandTextTrackPrivateAVFObjC::label): Drive-by cleanup.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Don't filter out forced tracks.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Log the language returned.

• testing/Internals.cpp:

(WebCore::Internals::setPrimaryAudioTrackLanguageOverride): New.
(WebCore::Internals::setCaptionDisplayMode): New.

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• media/content/CC+Subtitles.m4v: Added.
• media/track/track-forced-subtitles-in-band-expected.txt: Added.
• media/track/track-forced-subtitles-in-band.html: Added.
• media/trackmenu-test.js:

• platform/efl/TestExpectations: Skip new test.
• platform/gtk/TestExpectations: Ditto.
• platform/mac/TestExpectations: Ditto.
• platform/qt/TestExpectations: Ditto.
• platform/win/TestExpectations: Ditto.

10:06 AM Changeset in webkit [148284] by ap@apple.com

• 3 edits in trunk/Source/WebKit2

<rdar://problem/13126204> [Mac] Tweak sandbox profile.

Reviewed by Anders Carlsson.

• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
• WebProcess/com.apple.WebProcess.sb.in:

9:54 AM Changeset in webkit [148283] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

[Mac] Some ligatures are applied across different fronts
​https://bugs.webkit.org/show_bug.cgi?id=113604

Reviewed by Darin Adler.

The bug was caused by applyFontTransforms applying ligatures without updating the font data in the glyph buffer.

Suppose we have characters AB and A uses font X and B uses font Y. Further suppose that we have ligatures for AB
in Y. The problem was that WithIterator::advanceInternal calls applyFontTransforms on AB to apply this ligature
even though A and B use different fonts. Since X doesn't contain the same ligature for A to be paired with that
of B in X, we get a blank A.

Fixed the bug by resetting lastGlyphCount after calling applyFontTransforms. This ensures that we don't call
applyFontTransforms across different fonts.

No new tests since this requires a variant of Osaka font that doesn't come with OS X.

The bug 114482 tracks the effort to add a test for this bug fix. I've already asked someone to create a custom
font for us so that we can test this bug fix but that's going to a while.

• platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal):

9:52 AM Changeset in webkit [148282] by rniwa@webkit.org

• 26 edits
  6 deletes in trunk

[Mac] Enable spellchecking tests added in r141471
​https://bugs.webkit.org/show_bug.cgi?id=108525

Reviewed by Darin Adler.

Source/WebCore:

Made automatic quote substitution, dash substitution, text replacement, and spelling correction
togglable via internals object. These functions are no-op when text replacement is not used.

This allows us to disable automatic spelling correction in spellcheck tests.

Enabled several tests added in r141471.

• WebCore.exp.in:
• testing/Internals.cpp:

(WebCore::Internals::setContinuousSpellCheckingEnabled): Don't null check editor() since it's not
null whenever frame() is not null.
(WebCore::Internals::setAutomaticQuoteSubstitutionEnabled): Added.
(WebCore::Internals::setAutomaticLinkDetectionEnabled): Added.
(WebCore::Internals::setAutomaticDashSubstitutionEnabled): Added.
(WebCore::Internals::setAutomaticTextReplacementEnabled): Added.
(WebCore::Internals::setAutomaticSpellingCorrectionEnabled): Added.

• testing/Internals.h:
• testing/Internals.idl:

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):
(resetDefaultsToConsistentValues):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Updated the tests not to assume spelling correction suggestions were listed in a context menu since
only Chromium port did this.

• editing/spelling/resources/util.js:

(initSpellTest): Disable automatic text replacements.

• editing/spelling/spelling-with-underscore-selection-expected.txt: Removed.
• editing/spelling/spelling-with-underscore-selection.html: Removed.

This test erroneously assumed a specific word breaking behavior that doesn't include the underscore
when selecting a word especially since Chromium was the only port that was running these tests.

• editing/spelling/spelling-double-clicked-word-with-underscores-expected.txt: Removed.
• editing/spelling/spelling-double-clicked-word-with-underscores.html: Removed.

Ditto.

• editing/spelling/spelling-should-select-single-word-expected.txt: Removed.
• editing/spelling/spelling-should-select-single-word.html: Removed.

Removed since this test doesn't do anything useful without the assertion for the context menu.

• editing/spelling/spelling-double-clicked-word-expected.txt:
• editing/spelling/spelling-double-clicked-word.html:
• editing/spelling/spelling-exactly-selected-word-expected.txt:
• editing/spelling/spelling-exactly-selected-word.html:
• editing/spelling/spelling-with-punctuation-selection-expected.txt:
• editing/spelling/spelling-with-punctuation-selection.html:
• editing/spelling/spelling-with-whitespace-selection-expected.txt:
• editing/spelling/spelling-with-whitespace-selection.html:

• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:
• platform/qt/TestExpectations:
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:
• platform/wk2/TestExpectations:

9:33 AM Changeset in webkit [148281] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit2

[GTK][WK2] Add document-loaded signal to WebKitWebPage
​https://bugs.webkit.org/show_bug.cgi?id=110614

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-12
Reviewed by Carlos Garcia Campos.

Add a new signal document-loaded to WebKitWebPage that will be emitted
when the DOM document has been loaded for the main frame.

• UIProcess/API/gtk/tests/TestWebExtensions.cpp:

(documentLoadedCallback):
(testDocumentLoadedSignal):
(beforeAll): Add test for document-loaded signal.

• UIProcess/API/gtk/tests/WebExtensionTest.cpp:

(documentLoadedCallback):
(pageCreatedCallback):
(methodCallCallback): Add new D-Bus signal DocumentLoaded in order to
test document-loaded signal.

• WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(webkit_web_page_class_init):
(webkitWebPageCreate): Add document-loaded signal and emit it when
didFinishDocumentLoadForFrame is called.

9:19 AM Changeset in webkit [148280] by oliver@apple.com

• 2 edits in trunk/Source/WTF

[Qt][Win] r148257 broke the build
​https://bugs.webkit.org/show_bug.cgi?id=114512

Build fix.

• wtf/Platform.h:

9:07 AM Changeset in webkit [148279] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[GTK] Webkit fails to build webkit2gtk-tests-resources.gresource.
​https://bugs.webkit.org/show_bug.cgi?id=114485

Patch by Hanyee Kim <​choco@company100.net> on 2013-04-12
Reviewed by Martin Robinson.

Generating webkit2gtk-tests-resources.gresource can be failed due to
the non-existing target directory.
We need to make target directory before generating it.

• UIProcess/API/gtk/tests/GNUmakefile.am:

8:13 AM Changeset in webkit [148278] by akling@apple.com

• 8 edits in trunk/Source/WebKit2

REGRESSION(r145869): Right-click on SWF contents displays the context menu at the wrong place.
<​http://webkit.org/b/113836>
<rdar://problem/13587624>

Reviewed by Anders "Wesley Crusher" Carlsson.

Mac plugins expect flipped-Y screen coordinates, while DOM APIs speak in unflipped coordinates,
and we were mixing them up in the window frame caching optimization.

Solve this by having the UIProcess send both flipped and unflipped window frames to the WebProcess.
The flipped frame is passed on to plugins, and the unflipped frame is used for window.screenX/Y etc.

• UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowAndViewFrames]):

No need to retrieve the window frame here as WebPageProxy::windowAndViewFramesChanged() will
always override it anyway.

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::windowAndViewFramesChanged):

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::windowRect):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowAndViewFramesChanged):

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::windowFrameInUnflippedScreenCoordinates):

• WebProcess/WebPage/WebPage.messages.in:

7:05 AM Changeset in webkit [148277] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash running layout tests
​https://bugs.webkit.org/show_bug.cgi?id=114503

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-04-12
Reviewed by Xan Lopez.

Hit an assertion in ~GuardedPointerBase when DRT is
deleted. DumpRenderTree class derives from
BlackBerry::Platform::LayoutTestClient that derives from
BlackBerry::Platform::GuardedPointerBase, so the DRT pointer
should no be released with delete but with
BlackBerry::Platform::deleteGuardedObject().

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):

6:50 AM Changeset in webkit [148276] by commit-queue@webkit.org

• 5 edits in trunk/Tools

[GTK] Enable WebKit2 building on GTK EWSs
​https://bugs.webkit.org/show_bug.cgi?id=114500

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-12
Reviewed by Philippe Normand.

Add configuration in order to be able to setup GTK EWSs building
WebKit2. A new queue gtk-wk2-ews is added.

• QueueStatusServer/config/queues.py:
• Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
(GtkWK2Port):
(GtkWK2Port.build_webkit_command):
(GtkWK2Port.run_webkit_tests_command):

• Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest):
(DeprecatedPortTest.test_gtk_wk2_port):

• Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(GtkWK2EWS):

6:22 AM Changeset in webkit [148275] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[BlackBerry] Upstream the filesystem code
​https://bugs.webkit.org/show_bug.cgi?id=114437

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-12
Reviewed by Rob Buis.

These are the changes for AsyncFileSystemBlackBerry.

This patch contains contributions from many members of the
BlackBerry WebKit team.

• platform/blackberry/AsyncFileSystemBlackBerry.cpp:

(WebCore::AsyncFileSystem::isAvailable):
(WebCore):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystemBlackBerry::openFileSystem):
(WebCore::AsyncFileSystem::deleteFileSystem):
(WebCore::AsyncFileSystemBlackBerry::AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::~AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::move):
(WebCore::AsyncFileSystemBlackBerry::copy):
(WebCore::AsyncFileSystemBlackBerry::remove):
(WebCore::AsyncFileSystemBlackBerry::removeRecursively):
(WebCore::AsyncFileSystemBlackBerry::readMetadata):
(WebCore::AsyncFileSystemBlackBerry::createFile):
(WebCore::AsyncFileSystemBlackBerry::createDirectory):
(WebCore::AsyncFileSystemBlackBerry::fileExists):
(WebCore::AsyncFileSystemBlackBerry::directoryExists):
(WebCore::AsyncFileSystemBlackBerry::readDirectory):
(WebCore::AsyncFileSystemBlackBerry::createWriter):
(WebCore::AsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadata):
(WebCore::AsyncFileSystemBlackBerry::fileSystemURLToPath):

• platform/blackberry/AsyncFileSystemBlackBerry.h:

(WTF):
(WTF::BlackBerry::Platform::WebFileSystem):
(WebCore::AsyncFileSystemBlackBerry::create):
(AsyncFileSystemBlackBerry):

6:10 AM Changeset in webkit [148274] by mikhail.pozdnyakov@intel.com

• 11 edits
  4 copies in trunk/Source/WebKit2

[WK2][EFL] WebView: Add callbacks to the WKViewClient to handle page viewport update
​https://bugs.webkit.org/show_bug.cgi?id=110463

Reviewed by Anders Carlsson.

• UIProcess/efl/ViewClientEfl.h:

(ViewClientEfl):

• UIProcess/efl/WebView.cpp:

(WebKit::WebView::didChangeViewportProperties):

• UIProcess/efl/WebViewClient.cpp:

(WebKit::WebViewClient::didChangeViewportAttributes):
(WebKit):

• UIProcess/efl/WebViewClient.h:

Added didChangeViewportAttributes callback to the WKViewClient to
handle page viewport updates.

• CMakeLists.txt:
• Shared/API/c/WKBase.h:
• Shared/APIObject.h:
• UIProcess/API/C/WKAPICast.h:

(WebKit):

• UIProcess/API/C/WKViewportAttributes.cpp: Added.

(WKViewportAttributesGetTypeID):

• UIProcess/API/C/WKViewportAttributes.h: Added.
• UIProcess/API/C/efl/WKView.h:
• UIProcess/WebViewportAttributes.cpp: Added.

(WebKit):
(WebKit::WebViewportAttributes::WebViewportAttributes):
(WebKit::WebViewportAttributes::~WebViewportAttributes):

• UIProcess/WebViewportAttributes.h: Added.

(WebKit):
(WebViewportAttributes):
(WebKit::WebViewportAttributes::create):
(WebKit::WebViewportAttributes::originalAttributes):
(WebKit::WebViewportAttributes::type):

Added WKViewportAttributesRef - WK2 C API object that is wrapping
WebCore::ViewportAttributes structure and is passed in didChangeViewportAttributes
WKViewClient callback.

• UIProcess/efl/ViewClientEfl.cpp:

(WebKit::ViewClientEfl::didChangeViewportAttributes):
(WebKit):

Added implementaion of didChangeViewportAttributes WKViewClient
callback so that existing EFL WK2 funtionality is kept.

3:54 AM Changeset in webkit [148273] by jocelyn.turcotte@digia.com

• 2 edits in trunk/Source/WebCore

Apply our MSVC 2012 optimizer bug workaround to all minor releases
​https://bugs.webkit.org/show_bug.cgi?id=114436

Reviewed by Alexey Proskuryakov.

The bug has only been partially fixed in Update 2 but our Update 1 workaround
still avoids the crash.

• platform/text/TextEncodingRegistry.cpp:

(WebCore::TextEncodingNameHash::equal):

3:28 AM Changeset in webkit [148272] by mrowe@apple.com

• 2 edits in trunk/Source/WebCore

And again, with the correct case this time.

• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:

3:22 AM Changeset in webkit [148271] by mrowe@apple.com

• 2 edits in trunk/Source/WebCore

Build fix.

• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:

Add missing #include and forward declaration.

2:03 AM Changeset in webkit [148270] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash running layout tests when WebPage is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=114497

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-04-12
Reviewed by Xan Lopez.

PR 324649
Internally reviewed by Konrad Piascik and Rob Buis.

Use a bool member to keep track of whether the inspector is
enabled or not instead of relaying on the enable developer extras
setting, that can be set in other places than enableWebInspector().

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
m_inspectorEnabled.
(BlackBerry::WebKit::WebPage::enableWebInspector): Return early if
inspector is already enabled and set m_inspectorEnabled to true.
(BlackBerry::WebKit::WebPage::disableWebInspector): Return early
if inspector is not enabled and set m_inspectorEnabled to false.
(BlackBerry::WebKit::WebPage::isWebInspectorEnabled): Check the
current value of m_inspectorEnabled instead of the developer
extras setting.

• Api/WebPage_p.h:

(WebPagePrivate): Add m_inspectorEnabled.

1:55 AM Changeset in webkit [148269] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

Unreviewed functionality fix for ports enabling the MicroData feature.

• html/DOMSettableTokenList.idl: Add the SkipVTableValidation IDL attribute to the DOMSettableTokenList interface.

This removes crashes in the MicroData layout tests that are occurring on EFL and GTK builders, the two ports being
the only ports that enable this feature.

1:17 AM Changeset in webkit [148268] by zarvai@inf.u-szeged.hu

• 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

• platform/qt/TestExpectations:
• platform/qt/fast/js/global-constructors-expected.txt: Rebaselining after r148236.

1:12 AM Changeset in webkit [148267] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[GTK] The style of visited links doesn't change in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=112175

Reviewed by Benjamin Poulain.

The problem is that visited links were not tracked by the web
process. There's a web process initial parameter to set whether
web process should track visited links or not and it's disabled by
default.

• UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess): Always set
shouldTrackVisitedLinks to true.

12:55 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas

(diff)

12:38 AM Changeset in webkit [148266] by rniwa@webkit.org

• 1 edit
  2 deletes in trunk/Tools

Remove Chromium scripts
​https://bugs.webkit.org/show_bug.cgi?id=114492

Reviewed by Benjamin Poulain.

• Scripts/run-chromium-webkit-unit-tests: Removed.
• Scripts/update-webkit-chromium: Removed.

12:15 AM Changeset in webkit [148265] by ap@apple.com

• 15 edits
  1 add in trunk/Source/WebCore

Move CachedRawResourceClient into a separate file
​https://bugs.webkit.org/show_bug.cgi?id=114491

Reviewed by Mark Rowe.

• GNUmakefile.list.am:
• Target.pri:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• loader/DocumentLoader.cpp:
• loader/DocumentLoader.h:
• loader/DocumentThreadableLoader.h:
• loader/archive/cf/LegacyWebArchive.cpp:
• loader/cache/CachedRawResource.cpp:
• loader/cache/CachedRawResource.h:
• loader/cache/CachedRawResourceClient.h: Added.
• loader/icon/IconLoader.h:
• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:

12:14 AM Changeset in webkit [148264] by zandobersek@gmail.com

• 18 edits in trunk

Unreviewed, rolling out r148262.
​http://trac.webkit.org/changeset/148262
​https://bugs.webkit.org/show_bug.cgi?id=114493

Cairo dep should now build, rolling r148247 back in (Requested
by zdobersek on #webkit).

Patch by Commit Queue <​rniwa@webkit.org> on 2013-04-12

.:

• Source/autotools/FindDependencies.m4:
• Source/autotools/PrintBuildConfiguration.m4:
• Source/autotools/SetupWebKitFeatures.m4:

Source/WebCore:

• platform/graphics/GraphicsContext.cpp:

(WebCore):

• platform/graphics/ImageBuffer.cpp:

(WebCore):

• platform/graphics/cairo/GLContext.h:

(GLContext):

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore):

• platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBufferData::ImageBufferData):
(WebCore):
(WebCore::createCairoGLSurface):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::mapSurfaceToImage):
(WebCore::unmapSurfaceFromImage):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBufferData::paintToTextureMapper):
(WebCore::ImageBuffer::platformLayer):

• platform/graphics/cairo/ImageBufferDataCairo.h:

(ImageBufferData):

• platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::~GLContextEGL):
(WebCore::GLContextEGL::cairoDevice):
(WebCore):

• platform/graphics/egl/GLContextEGL.h:
• platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::GLContextGLX):
(WebCore::GLContextGLX::~GLContextGLX):
(WebCore::GLContextGLX::cairoDevice):
(WebCore):

• platform/graphics/glx/GLContextGLX.h:

(GLContextGLX):

Tools:

• Scripts/webkitdirs.pm:

(buildAutotoolsProject):

• gtk/jhbuild.modules: