⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 14, 2013:

11:58 PM Changeset in webkit [148416] by Christophe Dumez
  • 14 edits
    6 deletes in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline several SVG tests for EFL port.

  • platform/efl-wk2/svg/css/group-with-shadow-expected.png:
  • platform/efl-wk2/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/efl/svg/css/arrow-with-shadow-expected.png:
  • platform/efl/svg/css/arrow-with-shadow-expected.txt: Removed.
  • platform/efl/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • platform/efl/svg/css/clippath-with-shadow-expected.txt: Removed.
  • platform/efl/svg/css/composite-shadow-example-expected.png:
  • platform/efl/svg/css/composite-shadow-example-expected.txt:
  • platform/efl/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/efl/svg/css/composite-shadow-with-opacity-expected.txt:
  • platform/efl/svg/css/group-with-shadow-expected.txt:
  • platform/efl/svg/css/path-with-shadow-expected.txt:
  • platform/efl/svg/css/shadow-and-opacity-expected.txt:
  • platform/efl/svg/css/shadow-with-large-radius-expected.txt: Removed.
  • platform/efl/svg/css/shadow-with-negative-offset-expected.txt: Removed.
  • platform/efl/svg/css/text-gradient-shadow-expected.txt:
  • platform/efl/svg/css/text-shadow-multiple-expected.txt:
  • platform/efl/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
  • platform/efl/transitions/svg-text-shadow-transition-expected.txt:
8:13 PM CommitterTips edited by glenn@skynav.com
Clarify that "Unreviewed" should be present if no "Reviewed by" is present. (diff)
7:22 PM Changeset in webkit [148415] by ddkilzer@apple.com
  • 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore

Revert "Attempt to fix Windows build after r148370"

This reverts commit r148375.

  • runtime/JSStringJoiner.h: Remove include of

<wtf/CheckedArithmetic.h>.

6:29 PM Changeset in webkit [148414] by commit-queue@webkit.org
  • 12 edits in trunk

[css3-text] Parsing -webkit-hanging value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=113680

Source/WebCore:

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-14
Reviewed by Andreas Kling.

This patch is the parsing part to support hanging value for text-indent.
"hanging" means "Inverts which lines are affected."
It's prefixed and guarded by CSS3_TEXT flag.

No new tests, this patch updates existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseTextIndent): Parsed "-webkit-hanging" with "-webkit-each-line".

  • css/CSSValueKeywords.in: Added "-webkit-hanging" keyword.
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyTextIndent::applyInheritValue):
(WebCore::ApplyPropertyTextIndent::applyInitialValue):
(WebCore::ApplyPropertyTextIndent::applyValue):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h: Added enum TextIndentType.
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h: Added m_textIndentType.

(StyleRareInheritedData):

Added the usual getter / setter / initial methods for m_textIndentType.

LayoutTests:

"hanging" is added for text-indent in CSS3.
http://dev.w3.org/csswg/css3-text/#hanging

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-14
Reviewed by Andreas Kling.

  • fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt:
  • fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js:

(valueSettingTest):

4:32 PM Changeset in webkit [148413] by weinig@apple.com
  • 9 edits
    2 adds in trunk/Source

Move Mac specific snapshotting code into its own file
https://bugs.webkit.org/show_bug.cgi?id=114597

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:

(-[DOMRange renderedImageForcingBlackText:]):

  • page/Frame.h:
  • page/mac/FrameMac.mm:

(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):

  • page/mac/FrameSnapshottingMac.h: Added.
  • page/mac/FrameSnapshottingMac.mm: Added.

(WebCore::imageFromRect):
(WebCore::selectionImage):
(WebCore::rangeImage):
(WebCore::snapshotDragImage):

  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::dragNSImage):
Move the four Mac specific snapshotting functions in Frame.h into FrameSnapshottingMac.h/mm and turn
them into free standing functions.

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _selectionDraggingImage]):
(-[WebHTMLView selectionImageForcingBlackText:]):

2:50 PM Changeset in webkit [148412] by akling@apple.com
  • 2 edits in trunk/LayoutTests

Re-skip editing/spelling/spelling-changed-text.html on Mac/WK1.

  • platform/mac/TestExpectations:
2:13 PM Changeset in webkit [148411] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Hawtfix Mac build.

  • WebCore.exp.in:
1:32 PM Changeset in webkit [148410] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Only MutableStylePropertySets should be able to have CSSOM wrappers.
<http://webkit.org/b/114595>

Reviewed by Antti Koivisto.

Tighten typing so that only MutableStylePropertySets can have CSSOM wrappers associated.
This allows us to get rid of the out-of-line base class destructor.

  • WebCore.exp.in:
  • css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::~MutableStylePropertySet):
(WebCore::MutableStylePropertySet::cssStyleDeclaration):
(WebCore::MutableStylePropertySet::ensureInlineCSSStyleDeclaration):

  • css/StylePropertySet.h:

(StylePropertySet):
(MutableStylePropertySet):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::inlineStyleCSSOMWrapper):

1:05 PM Changeset in webkit [148409] by ddkilzer@apple.com
  • 4 edits in branches/safari-536.30-branch/Source/WTF

Try to fix Windows Elgar build again after r148370

Merge r148401.

Add EnumClass.h to the MSVC project.

2013-04-14 David Kilzer <ddkilzer@apple.com>

Add EnumClass.h to project files
<http://webkit.org/b/114582>

Rubber-stamped by Dan Bernstein.

  • WTF.pro: Add EnumClass.h to project.
  • WTF.vcproj/WTF.vcproj: Ditto.
  • WTF.vcxproj/WTF.vcxproj: Ditto.
  • WTF.vcxproj/WTF.vcxproj.filters: Ditto.
  • WTF.xcodeproj/project.pbxproj: Ditto.
12:19 PM Changeset in webkit [148408] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unused function declaration StylePropertySet::setNeedsStyleRecalc().

Rubber-stamped by Antti Koivisto.

  • css/StylePropertySet.h:

(StylePropertySet):

12:17 PM Changeset in webkit [148407] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Regression(r148274): Broke rendering in the browser
https://bugs.webkit.org/show_bug.cgi?id=114593

Reviewed by Anders Carlsson.

r148274 added a new "didChangeViewportAttributes" callback to
WKView but did not hook it up in ViewClientEfl. This patch
fixes this and makes rendering work again in the browser.

  • UIProcess/efl/ViewClientEfl.cpp:

(WebKit::ViewClientEfl::ViewClientEfl):

12:09 PM Changeset in webkit [148406] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Move StylePropertySet internal storage access helpers to subclass.
<http://webkit.org/b/114592>

Reviewed by Antti Koivisto.

Removed mutablePropertyVector() since most call sites are inside MutableStylePropertySet
and can access m_propertyVector directly. The few ones that aren't can just cast.

For ImmutableStylePropertySet, moved value/metadata array accessors to the subclass
and remove "immutable" from their names.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::immutableCopyIfNeeded):
(WebCore::ImmutableStylePropertySet::ImmutableStylePropertySet):
(WebCore::ImmutableStylePropertySet::~ImmutableStylePropertySet):
(WebCore::MutableStylePropertySet::MutableStylePropertySet):
(WebCore::MutableStylePropertySet::removeProperty):
(WebCore::MutableStylePropertySet::removePrefixedOrUnprefixedProperty):
(WebCore::MutableStylePropertySet::setProperty):
(WebCore::MutableStylePropertySet::appendPrefixingVariantProperty):
(WebCore::MutableStylePropertySet::parseDeclaration):
(WebCore::MutableStylePropertySet::addParsedProperties):
(WebCore::MutableStylePropertySet::clear):
(WebCore::MutableStylePropertySet::removePropertiesInSet):
(WebCore::MutableStylePropertySet::findCSSPropertyWithID):
(WebCore::MutableStylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::reportMemoryUsage):

  • css/StylePropertySet.h:

(PropertyReference):
(StylePropertySet):
(ImmutableStylePropertySet):
(WebCore::ImmutableStylePropertySet::valueArray):
(WebCore::ImmutableStylePropertySet::metadataArray):
(WebCore::StylePropertySet::PropertyReference::propertyMetadata):
(WebCore::StylePropertySet::PropertyReference::propertyValue):
(WebCore::StylePropertySet::propertyCount):

11:25 AM Changeset in webkit [148405] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

Try to fix non-apple windows builds

10:56 AM Changeset in webkit [148404] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Specialize propertyCount() in StylePropertySet subclasses.
<http://webkit.org/b/114590>

Reviewed by Antti Koivisto.

Avoid branching on m_isMutable in code that already knows which type of set it is.

  • css/StylePropertySet.h:

(WebCore::ImmutableStylePropertySet::propertyCount):
(ImmutableStylePropertySet):
(WebCore::MutableStylePropertySet::propertyCount):
(MutableStylePropertySet):

10:49 AM Changeset in webkit [148403] by akling@apple.com
  • 9 edits in trunk/Source/WebCore

Move property setting/removing functions to MutableStylePropertySet.
<http://webkit.org/b/114589>

Reviewed by Antti Koivisto.

Move all functions for setting/removing properties from StylePropertySet to MutableStylePropertySet.
Had to change SVGElement::animatedSMILStyleProperties() & friends to hand out MutableStylePropertySet*
which was always the internal type anyway.

  • css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::removeShorthandProperty):
(WebCore::MutableStylePropertySet::removeProperty):
(WebCore::MutableStylePropertySet::removePrefixedOrUnprefixedProperty):
(WebCore::MutableStylePropertySet::setProperty):
(WebCore::MutableStylePropertySet::appendPrefixingVariantProperty):
(WebCore::MutableStylePropertySet::setPrefixingVariantProperty):
(WebCore::MutableStylePropertySet::mergeAndOverrideOnConflict):
(WebCore::MutableStylePropertySet::removeBlockProperties):
(WebCore::MutableStylePropertySet::removePropertiesInSet):
(WebCore::MutableStylePropertySet::findCSSPropertyWithID):
(WebCore::MutableStylePropertySet::removeEquivalentProperties):

  • css/StylePropertySet.h:

(StylePropertySet):
(MutableStylePropertySet):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::triStateOfStyle):
(WebCore::removePropertiesInStyle):
(WebCore::reconcileTextDecorationProperties):

  • svg/SVGAnimateElement.cpp:

(WebCore::applyCSSPropertyToTarget):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::animatedSMILStyleProperties):
(WebCore::SVGElement::ensureAnimatedSMILStyleProperties):

  • svg/SVGElement.h:

(SVGElement):

  • svg/SVGElementRareData.h:

(WebCore::SVGElementRareData::animatedSMILStyleProperties):
(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):
(SVGElementRareData):

10:33 AM Changeset in webkit [148402] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

EditingStyle should have a MutableStylePropertySet internally.
<http://webkit.org/b/114588>

Reviewed by Anders Carlsson.

Switch EditingStyle::m_mutableStyle to a RefPtr<MutableStylePropertySet>.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::copyBlockProperties):

  • css/StylePropertySet.h:

(StylePropertySet):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::setStyle):
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::StyleChange::StyleChange):
(WebCore::setTextDecorationProperty):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
(WebCore::getPropertiesNotIn):

  • editing/EditingStyle.h:

(WebCore::EditingStyle::style):
(EditingStyle):
(StyleChange):

9:49 AM Changeset in webkit [148401] by ddkilzer@apple.com
  • 6 edits in trunk/Source/WTF

Add EnumClass.h to project files
<http://webkit.org/b/114582>

Rubber-stamped by Dan Bernstein.

  • WTF.pro: Add EnumClass.h to project.
  • WTF.vcproj/WTF.vcproj: Ditto.
  • WTF.vcxproj/WTF.vcxproj: Ditto.
  • WTF.vcxproj/WTF.vcxproj.filters: Ditto.
  • WTF.xcodeproj/project.pbxproj: Ditto.
9:43 AM Changeset in webkit [148400] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Move addParsedProperty/addParsedProperties to MutableStylePropertySet.
<http://webkit.org/b/114587>

Reviewed by Antti Koivisto.

All CSSParser methods that mutate an existing StylePropertySet now take a MutableStylePropertySet*
instead of a StylePropertySet*.

  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::parseKeywordValue):
(WebCore::parseTranslateTransformValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):

  • css/CSSParser.h:

(CSSParser):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setProperty):
(WebCore::MutableStylePropertySet::addParsedProperties):
(WebCore::MutableStylePropertySet::addParsedProperty):

  • css/StylePropertySet.h:

(StylePropertySet):
(MutableStylePropertySet):

  • css/ViewportStyleResolver.h:

(ViewportStyleResolver):

9:21 AM Changeset in webkit [148399] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CSSParser should return ImmutableStylePropertySets.
<http://webkit.org/b/114585>

Reviewed by Anders Carlsson.

The StylePropertySets created by CSSParser were already immutable.
Let this be reflected in the pointer types returned.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseInlineStyleDeclaration):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::createStylePropertySet):

  • css/CSSParser.h:

(CSSParser):

9:14 AM Changeset in webkit [148398] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Move StylePropertySet::createImmutable() to ImmutableStylePropertySet.
<http://webkit.org/b/114584>

Reviewed by Anders Carlsson.

StylePropertySet::createImmutable() -> ImmutableStylePropertySet::create()
Also, immutableCopyIfNeeded() now returns a PassRefPtr<ImmutableStylePropertySet>.

  • css/CSSParser.cpp:

(WebCore::CSSParser::createStylePropertySet):

  • css/StylePropertySet.cpp:

(WebCore::ImmutableStylePropertySet::create):
(WebCore::StylePropertySet::immutableCopyIfNeeded):

  • css/StylePropertySet.h:

(StylePropertySet):
(ImmutableStylePropertySet):

8:46 AM Changeset in webkit [148397] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Move parseDeclaration() and clear() to MutableStylePropertySet.
<http://webkit.org/b/114583>

Reviewed by Anders Carlsson.

...and remove ASSERT(isMutable()) from the function bodies.

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::removedFrom):

Use clear() directly instead of taking an empty string through the CSS parser.

  • css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::parseDeclaration):
(WebCore::MutableStylePropertySet::clear):

  • css/StylePropertySet.h:

(StylePropertySet):
(MutableStylePropertySet):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::setInlineStyleFromString):

8:19 AM Changeset in webkit [148396] by akling@apple.com
  • 23 edits in trunk/Source

Move CSSOM classes to using MutableStylePropertySet over StylePropertySet.
<http://webkit.org/b/114581>

Reviewed by Anders Carlsson.

Source/WebCore:

Moved ensureCSSStyleDeclaration() and ensureInlineCSSStyleDeclaration() from StylePropertySet
to MutableStylePropertySet.

StyleRule & co now return a MutableStylePropertySet* from mutableProperties() to aid with...

CSSStyleDeclaration now only deals with MutableStylePropertySets. This was already the case
in practice, we just didn't have any compile-time foot-shooting protection.
In other words, if there's a CSSOM wrapper for a given StylePropertySet, it's guaranteed to
be mutable, and the pointer types now reflect this.

  • WebCore.exp.in:
  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::StyleRuleCSSStyleDeclaration::StyleRuleCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::reattach):

  • css/PropertySetCSSStyleDeclaration.h:

(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(PropertySetCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::create):
(StyleRuleCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):

  • css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::ensureCSSStyleDeclaration):
(WebCore::MutableStylePropertySet::ensureInlineCSSStyleDeclaration):

  • css/StylePropertySet.h:

(StylePropertySet):
(MutableStylePropertySet):

  • css/StyleRule.cpp:

(WebCore::StyleRule::mutableProperties):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::mutableProperties):
(WebCore::StyleRuleViewport::mutableProperties):
(WebCore::StyleRuleFilter::mutableProperties):

  • css/StyleRule.h:

(StyleRule):
(StyleRuleFontFace):
(StyleRulePage):
(StyleRuleViewport):
(StyleRuleFilter):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::mutableProperties):

  • css/WebKitCSSKeyframeRule.h:

(StyleKeyframe):

  • dom/Attr.cpp:

(WebCore::Attr::style):

  • dom/Attr.h:

(Attr):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::copyTypingStyle):

  • editing/FrameSelection.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::shouldApplyStyle):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldApplyStyle):

  • WebView/WebFrame.mm:

(-[WebFrame _typingStyle]):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldApplyStyle):

7:24 AM Changeset in webkit [148395] by akling@apple.com
  • 24 edits in trunk/Source/WebCore

Move create() methods from StylePropertySet to MutableStylePropertySet.
<http://webkit.org/b/114574>

Reviewed by Antti Koivisto.

Move the two create() methods that create MutableStylePropertySets from StylePropertySet
to MutableStylePropertySet, and make them actually return MutableStylePropertySets.
Switch to using {Pass,}RefPtr<MutableStylePropertySet> where appropriate to keep things building.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFaceValue):

  • css/DOMWindowCSS.cpp:

(WebCore::DOMWindowCSS::supports):

  • css/ElementRuleCollector.cpp:

(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):

  • css/FontLoader.cpp:

(WebCore::FontLoader::resolveFontStyle):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::copyPropertiesInSet):
(WebCore::MutableStylePropertySet::create):

  • css/StylePropertySet.h:

(StylePropertySet):
(MutableStylePropertySet):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::resolveVariables):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

  • dom/Attr.cpp:

(WebCore::Attr::style):

  • dom/Document.cpp:

(WebCore::Document::createCSSStyleDeclaration):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::ensureMutableInlineStyle):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):

  • editing/ApplyStyleCommand.cpp:

(WebCore::copyStyleOrCreateEmpty):

  • editing/EditingStyle.cpp:

(WebCore::editingStyleFromComputedStyle):
(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::EditingStyle::setProperty):
(WebCore::EditingStyle::extractAndRemoveTextDirection):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::forceInline):

  • editing/Editor.cpp:

(WebCore::Editor::setBaseWritingDirection):

  • editing/EditorCommand.cpp:

(WebCore::executeApplyStyle):
(WebCore::executeToggleStyleInList):
(WebCore::executeApplyParagraphStyle):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):

  • html/HTMLTableElement.cpp:

(WebCore::leakBorderStyle):
(WebCore::HTMLTableElement::createSharedCellStyle):
(WebCore::leakGroupBorderStyle):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

  • svg/SVGElementRareData.h:

(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

5:37 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
5:35 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
5:34 AM Changeset in webkit [148394] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0

Merge r148293 - [GTK] Lower the pango dependency
https://bugs.webkit.org/show_bug.cgi?id=114520

Reviewed by Carlos Garcia Campos.

  • Source/autotools/Versions.m4: Only depend on Pango 1.30.0 instead of

Pango 1.32.0. 1.32.0 isn't strictly necessary and the version of GTK+ that
we depend on (3.6.0) depends on 1.30.0.

5:33 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
5:32 AM Changeset in webkit [148393] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Tools

Merge r147946 - [GTK] Bump gnome-themes-standard to 3.6.0
https://bugs.webkit.org/show_bug.cgi?id=114155

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-08
Reviewed by Martin Robinson.

  • gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the

dependency of gnome-themes-standard accordingly.

5:32 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
5:31 AM Changeset in webkit [148392] by Carlos Garcia Campos
  • 2 edits
    1 add in releases/WebKitGTK/webkit-2.0/Tools

Merge r148110 - [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
https://bugs.webkit.org/show_bug.cgi?id=114365

Reviewed by Martin Robinson.

Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
The patch addresses crashes in the tally_event_reply method. It is already committed into the
at-spi2-atk source tree and will be available with the next stable release, after which the
patch should be removed and the dependency version bumped.

  • gtk/jhbuild.modules:
  • gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
5:29 AM Changeset in webkit [148391] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Tools

Merge r147574 - [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
https://bugs.webkit.org/show_bug.cgi?id=113883

Reviewed by Martin Robinson.

  • gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.

The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.

5:27 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
5:24 AM Changeset in webkit [148390] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Tools

Merge r147547 - [GTK] Bump required versions of some dependencies
https://bugs.webkit.org/show_bug.cgi?id=113282

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-03
Reviewed by Martin Robinson.

.:

This patch updates the following dependencies:

  • libsoup 2.42.0: is the current stable release.
  • glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
  • gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
  • at-spi2 2.5.3: is the version required by gtk+ 3.6.
  • GObject introspection 1.32.0: is the version required by gtk+ 3.6.
  • Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
  • Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
  • gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
  • Source/autotools/Versions.m4:

Tools:

  • gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
5:23 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
5:19 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
5:18 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
5:17 AM Changeset in webkit [148389] by Carlos Garcia Campos
  • 4 edits
    15 deletes in releases/WebKitGTK/webkit-2.0

Merge r147963 - [WIN] Remove WebKit2 source code
https://bugs.webkit.org/show_bug.cgi?id=114096

Reviewed by Anders Carlsson.

Source/WebKit2:

Remove conditional includes for the windows platform.

  • Shared/API/c/WKBase.h:
  • UIProcess/API/C/WKAPICast.h:

Tools:

Remove the windows specific parts of the MiniBrowser.

  • MiniBrowser/MiniBrowser.vcproj: Removed.
  • MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
  • MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
  • MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
  • MiniBrowser/win/BrowserView.cpp: Removed.
  • MiniBrowser/win/BrowserView.h: Removed.
  • MiniBrowser/win/BrowserWindow.cpp: Removed.
  • MiniBrowser/win/BrowserWindow.h: Removed.
  • MiniBrowser/win/MiniBrowser.cpp: Removed.
  • MiniBrowser/win/MiniBrowser.h: Removed.
  • MiniBrowser/win/MiniBrowser.rc: Removed.
  • MiniBrowser/win/main.cpp: Removed.
  • MiniBrowser/win/resource.h: Removed.
  • MiniBrowser/win/stdafx.cpp: Removed.
  • MiniBrowser/win/stdafx.h: Removed.
5:15 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
5:15 AM Changeset in webkit [148388] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Tools

Merge r148230 - [GTK] Windows build failure after r136056
https://bugs.webkit.org/show_bug.cgi?id=114121

Patch by Kalev Lember <kalevlember@gmail.com> on 2013-04-11
Reviewed by Martin Robinson.

  • TestWebKitAPI/config.h: Make sure defines are correct for other

Windows ports than apple-win.

5:14 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
5:13 AM Changeset in webkit [148387] by Carlos Garcia Campos
  • 1 edit
    1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge r147814 - Translation of WebKitGTK+ for Malayalam (ml)
https://bugs.webkit.org/show_bug.cgi?id=113280

Patch by Ani Peter <peter.ani@gmail.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.

  • ml.po: Added.
5:11 AM Changeset in webkit [148386] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge r147812 - webkit translations for gujarati
https://bugs.webkit.org/show_bug.cgi?id=113190

Patch by Sweta Kothari <swkothar@redhat.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.

  • gu.po:
4:36 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
4:33 AM Changeset in webkit [148385] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge r147811 - [l10n] [hi] Updated WebKit Translation in Hindi [hi] language
https://bugs.webkit.org/show_bug.cgi?id=113180

Patch by Rajesh Ranjan <rajeshkajha@yahoo.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.

  • hi.po:
4:28 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
4:26 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
4:25 AM Changeset in webkit [148384] by Carlos Garcia Campos
  • 1 edit
    1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge r147015 - Tamil translation for Gnome 3.6
https://bugs.webkit.org/show_bug.cgi?id=96995

Patch by Shantha kumar <shkumar@redhat.com> on 2013-03-27
Reviewed by Gustavo Noronha Silva (kov).

  • ta.po: Added.
4:24 AM Changeset in webkit [148383] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge r147003 - Updated Slovenian translation
https://bugs.webkit.org/show_bug.cgi?id=113151

Patch by Matej Urbančič <mateju@svn.gnome.org> on 2013-03-27
Reviewed by Gustavo Noronha Silva (kov).

  • sl.po: translation update.
4:05 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
4:01 AM Changeset in webkit [148382] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r148286 - [GTK] Web Process crash when the UI process finishes too early
https://bugs.webkit.org/show_bug.cgi?id=112729

Reviewed by Anders Carlsson.

The problem is when creating the GSocket in the WorkQeue for the
socket descriptor. GLib considers a programmer error to create a
GSocket providing an invalid socket and finishes the process with
g_error(). We are actually providing a valid socket when creating
the GSocket, but it can be invalidated by the worker thread while
the GSocket is being created. This is because
registerEventSourceHandler is called from the main thread and
unregisterEventSourceHandler can be called from the worker
thread. We are currently registering two event handlers, one to
read data from the socket and another one to close the CoreIPC
connection when the socket connection is broken. Every event
source registered uses its own GSocket (even if the file
descriptor is actually the same), so that when the UI process
finishes too early, the first event handler can be executed in the
worker thread, closing the socket descriptor, while the main
thread is creating the GSocket for the second one.
We don't really need to use a separate event handler to monitor
the connection, because GSocket always notifies when condition is
G_IO_HUP and G_IO_ERR even if they haven't been explicitly set in
g_socket_create_source(). We can register socket event sources
differently, providing also a function to be called when the
connection is closed, using a single socket and the same even source.

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::open): Register a single socket event
handler providing also a function to be called when the connection
is closed.

  • Platform/WorkQueue.h:

(WorkQueue):

  • Platform/gtk/WorkQueueGtk.cpp: The EventSource class has been

split, moving everyting specific to socket event source to a
derived class SocketEventSource.
(WorkQueue::EventSource::EventSource):
(WorkQueue::EventSource::performWork):
(WorkQueue::EventSource::performWorkOnce):
(WorkQueue::EventSource::performWorkOnTermination):
(WorkQueue::EventSource::deleteEventSource):
(WorkQueue::EventSource):
(WorkQueue::SocketEventSource):
(WorkQueue::SocketEventSource::SocketEventSource):
(WorkQueue::SocketEventSource::cancel):
(WorkQueue::SocketEventSource::didClose):
(WorkQueue::SocketEventSource::checkCondition):
(WorkQueue::SocketEventSource::eventCallback):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatchOnSource):

1:10 AM Changeset in webkit [148381] by Christophe Dumez
  • 11 edits in trunk/Source

Source/WebKit/efl: Unreviewed build fix for WebKit1 EFL after r148373 due to missing
header includes.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/EditorClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • WebCoreSupport/InspectorClientEfl.cpp:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_view.cpp:
  • ewk/ewk_view_private.h:

(WebCore):

Source/WebKit2: Unreviewed build fix for WebKit2 EFL after r148373 due to missing
header includes.

  • UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
  • UIProcess/efl/InputMethodContextEfl.cpp:

Apr 13, 2013:

9:13 PM Changeset in webkit [148380] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix three crashes seen on the bots after "Make Frame's ScriptController an OwnPtr and remove the #include"

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
Check that the frame is not null (as it can be in cases like http/tests/xmlhttprequest/detaching-frame-2.html).
We used to be getting lucky, in that shouldBypassMainWorldContentSecurityPolicy(), the function that is ultimately
called, only operates on global state. Now that we need to actually dereference the Frame to get the ScriptController,
we see this crash.

9:06 PM Changeset in webkit [148379] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix attempt for webkitbot. Unicodify everything.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Whois.execute):

8:55 PM Changeset in webkit [148378] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Selection direction is not preserved when applying styles
https://bugs.webkit.org/show_bug.cgi?id=110979

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2013-04-13
Reviewed by Ryosuke Niwa.

Source/WebCore:

The patch is based on the one submitted by Shezan Baig.

If the starting selection was directional and its base was not first,
switch newStart and newEnd when setting the ending direction. Otherwise,
leave the order unchanged.

Test: editing/style/preserve-selection-direction.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::updateStartEnd):

LayoutTests:

Add a test, based on the work by Shezan Baig

  • editing/style/preserve-selection-direction-expected.txt: Added.
  • editing/style/preserve-selection-direction.html: Added.
8:02 PM Changeset in webkit [148377] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Added svn:ignore for inspector/CodeGeneratorInspectorStrings.pyc

  • inspector: Added property svn:ignore.
7:12 PM Changeset in webkit [148376] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

Add ObjC API for setting initialization data for the WKWebProcessPlugIn
https://bugs.webkit.org/show_bug.cgi?id=103846

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKProcessGroup.h:

Adds a new optional processGroupWillCreateConnectionToWebProcessPlugIn: method for the WKProcessGroupDelegate protocol,
which allows the user to pass (via an autoreleased return value) initialization data to the web process plugin.

  • UIProcess/API/mac/WKProcessGroup.mm:

(getInjectedBundleInitializationUserData):
(setUpInectedBundleClient):
(-[WKProcessGroup initWithInjectedBundleURL:]):
(-[WKProcessGroup dealloc]):
Use the existing WKContextInjectedBundleClient infrastructure to pass the initialization data to the bundle
via the new ObjCObjectGraph APIObject.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:

Adds webProcessPlugIn:initializeWithObject: to the WKWebProcessPlugIn protocol, replacing webProcessPlugInInitialize:.

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::load):
Pass the initialization data to the web process plugin.

7:00 PM Changeset in webkit [148375] by ddkilzer@apple.com
  • 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore

Attempt to fix Windows build after r148370

Try to fix the following build failure:

4>JSStringJoiner.cpp
4>..\..\runtime\JSStringJoiner.cpp(112) : error C2653: 'CheckedState' : is not a class or namespace name
4>..\..\runtime\JSStringJoiner.cpp(112) : error C2065: 'DidOverflow' : undeclared identifier
4>..\..\runtime\JSStringJoiner.cpp(112) : warning C4805: '==' : unsafe mix of type 'bool' and type unknown-type in operation

  • runtime/JSStringJoiner.h: Include <wtf/CheckedArithmetic.h>.
6:27 PM Changeset in webkit [148374] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Attempt Build Fix.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
5:54 PM Changeset in webkit [148373] by weinig@apple.com
  • 88 edits in trunk/Source

Make Frame's ScriptController an OwnPtr and remove the #include
https://bugs.webkit.org/show_bug.cgi?id=114105

Reviewed by Dean Jackson.

Source/WebCore:

  • Modules/websockets/WebSocket.cpp:
  • bindings/generic/BindingSecurity.cpp:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSLazyEventListener.cpp:
  • bindings/js/PageScriptDebugServer.cpp:
  • bindings/js/ScriptEventListener.cpp:
  • bindings/js/ScriptState.cpp:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMAbstractView.mm:
  • bindings/objc/DOMInternal.mm:
  • dom/DocumentStyleSheetCollection.cpp:
  • dom/EventTarget.cpp:
  • dom/ScriptElement.cpp:
  • history/CachedFrame.cpp:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLDocument.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/HTMLPlugInImageElement.cpp:
  • html/parser/HTMLParserOptions.cpp:
  • inspector/InspectorAgent.cpp:
  • inspector/InspectorController.cpp:
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorOverlay.cpp:
  • inspector/InspectorPageAgent.cpp:
  • inspector/PageRuntimeAgent.cpp:
  • loader/DocumentWriter.cpp:
  • loader/NavigationScheduler.cpp:
  • loader/SubframeLoader.cpp:
  • loader/cache/CachedResourceLoader.cpp:
  • page/DOMWindow.cpp:
  • page/EventSource.cpp:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/Navigator.cpp:
  • page/Page.cpp:
  • page/PageGroup.cpp:
  • xml/XMLHttpRequest.cpp:
  • xml/XMLTreeViewer.cpp:

Source/WebKit/mac:

  • Plugins/Hosted/HostedNetscapePluginStream.mm:
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginContainerCheck.mm:
  • WebCoreSupport/WebGeolocationClient.mm:
  • WebCoreSupport/WebInspectorClient.mm:
  • WebView/WebFrame.mm:

Source/WebKit2:

  • Shared/WebHitTestResult.cpp:
  • Shared/WebHitTestResult.h:
  • UIProcess/Plugins/PlugInAutoStartProvider.cpp:
  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.h:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/Storage/StorageAreaImpl.cpp:
  • WebProcess/Storage/StorageAreaMap.cpp:
  • WebProcess/WebPage/WebFrame.cpp:
  • WebProcess/WebPage/WebPage.cpp:
5:46 PM Changeset in webkit [148372] by rniwa@webkit.org
  • 5 edits in trunk/Tools

webkitbot should provide full name, email address, and IRC nicknames on whois
https://bugs.webkit.org/show_bug.cgi?id=114494

Reviewed by Benjamin Poulain.

A response like the one below is useless. Improve it:
webkitbot: rniwa: zdobersek is zdobersek (zandobersek@gmail.com). Why do you ask?

We now report full name, email address, committer/reviewer status, and IRC nickname.

Also teach webkitbot how to respond to ping.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(PingPong): Moved
(PingPong.execute):
(Whois._full_record_and_nick): Renamed and rewritten.
(Whois.execute):

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_whois): Updated test cases as needed.

  • Scripts/webkitpy/tool/bot/ircbot_unittest.py:

(IRCBotTest.test_help): Added ping.

  • Scripts/webkitpy/tool/commands/newcommitbot.py:

(NewCommitBot): Teached WKR how to respond to hi.

5:28 PM Changeset in webkit [148371] by rniwa@webkit.org
  • 5 edits in trunk/Websites/bugs.webkit.org

Delete bubbles from webkit-commit-queue.appspot.com now that we've completed the transition
https://bugs.webkit.org/show_bug.cgi?id=114476

Reviewed by Gyuyoung Kim.

  • code-review.js:
  • template/en/custom/attachment/edit.html.tmpl:
  • template/en/custom/attachment/list.html.tmpl:
  • template/en/custom/attachment/reviewform.html.tmpl:
4:15 PM Changeset in webkit [148370] by ddkilzer@apple.com
  • 7 edits in branches/safari-536.30-branch

Merge 145580, 145587, 145594, r145595, r145647, 145759. Part 2/2 for <rdar://problem/13438603>.

4:15 PM Changeset in webkit [148369] by ddkilzer@apple.com
  • 2 edits
    1 add in branches/safari-536.30-branch/Source/WTF

Merge r141499, r141950, r141965. Part 1/2 for <rdar://problem/13438603>.

Add Source/WTF/wtf/EnumClass.h

3:28 PM Changeset in webkit [148368] by andersca@apple.com
  • 14 edits
    1 add in trunk

Add form delegate method that's invoked right before sending a submit event to a form element
https://bugs.webkit.org/show_bug.cgi?id=114575

Reviewed by Dan Bernstein.

Source/WebCore:

  • WebCore.exp.in:

Export a symbol.

  • WebCore.xcodeproj/project.pbxproj:

Make DOMHTMLFormElementInternal.h a private header.

Source/WebKit/mac:

  • MigrateHeaders.make:

Copy DOMHTMLFormElementInternal.h over to WebKit.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(makeFormFieldValuesDictionary):
New helper function that returns the values of a form in dictionary form.

(WebFrameLoaderClient::dispatchWillSendSubmitEvent):
Call the right delegate method.

(WebFrameLoaderClient::dispatchWillSubmitForm):
Use the helper function.

  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebDelegateImplementationCaching.mm:

(CallFormDelegate):
Add another overload.

  • WebView/WebFormDelegate.h:
  • WebView/WebFormDelegate.m:

(-[WebFormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
Add a default implementation.

Tools:

Add a test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm: Added.

(-[FormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::toSTD):
Don't crash when a null NSString is passed to toSTD.

3:01 PM Changeset in webkit [148367] by robert@webkit.org
  • 3 edits
    4 adds in trunk

Whitespace between nowrap elements ignored after collapsed trailing space in a text run
https://bugs.webkit.org/show_bug.cgi?id=17705

Reviewed by Ryosuke Niwa.

Source/WebCore:

Bug 93448 and r138654 fixed the treatment of line-breaks between nowrap elements. This augments
that fix by recognizing that we have a potential break not only in situations where the next character is a
space and the current character is not, but also where the next character is a space and the current character
*is* a space *and* we are ignoring spaces. This is so because any spaces we have ignored up to this point
after the actual word end will get collapsed away even if we don't end up taking the line break.

In a nutshell, if we allow whitespace collapsing 'word ' and 'word' are equivalent when before a whitespace
character, so treat the first as well as the second as a potential linebreak.

Test: fast/text/whitespace/inline-whitespace-wrapping-5.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/text/whitespace/inline-whitespace-wrapping-5-expected.html: Added.
  • fast/text/whitespace/inline-whitespace-wrapping-5.html: Added.
  • fast/text/whitespace/inline-whitespace-wrapping-6-expected.html: Added.
  • fast/text/whitespace/inline-whitespace-wrapping-6.html: Added.
2:49 PM Changeset in webkit [148366] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-536.30-branch

Merged r136845. <rdar://problem/13334927>

2:11 PM QtWebKit edited by V字龍
Add QupZilla Web Browser which also uses QtWebKit (diff)
1:03 PM Changeset in webkit [148365] by akling@apple.com
  • 19 edits in trunk/Source

Rename/tweak some StylePropertySet/CSSStyleDeclaration copying functions.
<http://webkit.org/b/114569>

Reviewed by Anders Carlsson.

  • StylePropertySet::copy() -> mutableCopy()

This function now returns a MutableStylePropertySet, and this is also reflected in the name.

  • CSSStyleDeclaration::copy() -> copyProperties()

Renamed to reflect that it's the properties being copied, not the CSSStyleDeclaration.
They also now return MutableStylePropertySets.

  • StylePropertySet::copyPropertiesInSet()
  • CSSStyleDeclaration::copyPropertiesInSet()

These functions now return MutableStylePropertySets.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::copyProperties):
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

  • css/CSSComputedStyleDeclaration.h:

(CSSComputedStyleDeclaration):

  • css/CSSStyleDeclaration.h:

(CSSStyleDeclaration):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::copyProperties):

  • css/PropertySetCSSStyleDeclaration.h:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::mutableCopy):
(WebCore::StylePropertySet::copyPropertiesInSet):

  • css/StylePropertySet.h:

(StylePropertySet):

  • css/StyleRule.cpp:

(WebCore::StyleRule::StyleRule):
(WebCore::StyleRule::mutableProperties):
(WebCore::StyleRulePage::StyleRulePage):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::StyleRuleFontFace):
(WebCore::StyleRuleFontFace::mutableProperties):
(WebCore::StyleRuleViewport::StyleRuleViewport):
(WebCore::StyleRuleViewport::mutableProperties):
(WebCore::StyleRuleFilter::StyleRuleFilter):
(WebCore::StyleRuleFilter::mutableProperties):

  • css/ViewportStyleResolver.cpp:

(WebCore::ViewportStyleResolver::addViewportRule):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::mutableProperties):

  • dom/Element.cpp:

(WebCore::UniqueElementData::UniqueElementData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::ensureMutableInlineStyle):

  • editing/ApplyStyleCommand.cpp:

(WebCore::copyStyleOrCreateEmpty):

  • editing/EditingStyle.cpp:

(WebCore::copyEditingProperties):
(WebCore::editingStyleFromComputedStyle):
(WebCore::EditingStyle::EditingStyle):
(WebCore::EditingStyle::init):
(WebCore::EditingStyle::copy):
(WebCore::EditingStyle::mergeStyle):
(WebCore::getPropertiesNotIn):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::copyTypingStyle):

11:19 AM Changeset in webkit [148364] by Lucas Forschler
  • 8 edits in branches/safari-536.30-branch/Source/WebKit2

Merged r147512. <rdar://problem/13380323>

11:00 AM Changeset in webkit [148363] by krit@webkit.org
  • 11 edits
    2 moves in trunk/Source/WebCore

Rename StyleBuilder to DeprecatedStyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=114532

Reviewed by Benjamin Poulain.

The StyleBuilder code is hard to read and maintain. People should
not add new properties to this class. To make this clear, this
patch renames the class to DeprecatedStyleBuilder.

Pure refactoring, no change in functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/DeprecatedStyleBuilder.cpp: Renamed from Source/WebCore/css/StyleBuilder.cpp.
  • css/DeprecatedStyleBuilder.h: Renamed from Source/WebCore/css/StyleBuilder.h.
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleResolver.h:

(StyleResolver):

  • rendering/style/RenderStyle.h:
10:56 AM Changeset in webkit [148362] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Python test fix attempt after r148360.

  • Scripts/webkitpy/tool/multicommandtool_unittest.py:

(test_command_help):

10:53 AM Changeset in webkit [148361] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Update Mac WebKit2 test expectations for flaky and failing tests.

  • platform/mac-wk2/TestExpectations:
10:39 AM Changeset in webkit [148360] by rniwa@webkit.org
  • 19 edits in trunk/Tools

Merge AbstractDeclarativeCommand into Command as a comment suggests
https://bugs.webkit.org/show_bug.cgi?id=114559

Reviewed by Antti Koivisto.

Merged two classes as the comment right above AbstractDeclarativeCommand suggested.
We need to merge a lot more classes to make webkitpy hackable.

  • Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:

(AbstractLocalServerCommand):
(AbstractLocalServerCommand.init):

  • Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:

(AbstractSequencedCommand):
(AbstractSequencedCommand.init):

  • Scripts/webkitpy/tool/commands/adduserstogroups.py:

(AddUsersToGroups):

  • Scripts/webkitpy/tool/commands/analyzechangelog.py:

(AnalyzeChangeLog):
(AnalyzeChangeLog.init):

  • Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
  • Scripts/webkitpy/tool/commands/bugfortest.py:

(BugForTest):

  • Scripts/webkitpy/tool/commands/bugsearch.py:

(BugSearch):

  • Scripts/webkitpy/tool/commands/chromechannels.py:

(ChromeChannels):
(init):

  • Scripts/webkitpy/tool/commands/download.py:

(AbstractPatchProcessingCommand):

  • Scripts/webkitpy/tool/commands/findusers.py:

(FindUsers):

  • Scripts/webkitpy/tool/commands/openbugs.py:

(OpenBugs):

  • Scripts/webkitpy/tool/commands/queries.py:

(BugsToCommit):
(PatchesInCommitQueue):
(PatchesToCommitQueue):
(PatchesToCommitQueue.init):
(PatchesToReview):
(PatchesToReview.init):
(PatchesToReview.execute):
(WhatBroke):
(ResultsFor):
(FailureReason):
(FindFlakyTests):
(TreeStatus):
(CrashLog):
(PrintExpectations):
(PrintExpectations.init):
(PrintBaselines):
(PrintBaselines.init):

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractQueue.init):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractRebaseliningCommand):

  • Scripts/webkitpy/tool/commands/suggestnominations.py:

(SuggestNominations):
(SuggestNominations.init):

  • Scripts/webkitpy/tool/commands/upload.py:

(CommitMessageForCurrentDiff):
(CommitMessageForCurrentDiff.init):
(CleanPendingCommit):
(CleanReviewQueue):
(AssignToCommitter):
(PostCommits):
(PostCommits.init):
(MarkBugFixed):
(MarkBugFixed.init):
(CreateBug):
(CreateBug.init):

  • Scripts/webkitpy/tool/multicommandtool.py:

(Command):
(Command.init):
(Command.main):
(HelpCommand):
(HelpCommand.init):

  • Scripts/webkitpy/tool/multicommandtool_unittest.py:

(TrivialCommand):
(TrivialCommand.init):
(LikesToRetry):
(LikesToRetry.init):
(CommandTest.test_name_with_arguments):
(CommandTest.test_required_arguments):
(test_command_help):

9:43 AM Changeset in webkit [148359] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Remove unused method CSSStyleDeclaration::makeMutable().
<http://webkit.org/b/114567>

Reviewed by Anders Carlsson.

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSComputedStyleDeclaration.h:

(CSSComputedStyleDeclaration):

  • css/CSSStyleDeclaration.h:

(CSSStyleDeclaration):

  • css/PropertySetCSSStyleDeclaration.cpp:
  • css/PropertySetCSSStyleDeclaration.h:
9:38 AM Changeset in webkit [148358] by Antoine Quint
  • 3 edits
    2 adds in trunk

Width of last of consecutive tabs may be incorrect with "white-space: pre-wrap"
https://bugs.webkit.org/show_bug.cgi?id=114562

Reviewed by Dan Bernstein.

Source/WebCore:

When we measure the last word of a RenderText, make sure we use the correct x
position taking into account the current accumulated word measurements up to
this character. This is of particular importance in the case of tabs where the
measured width would differ based on the x position.

Test: fast/text/tab-last-word-in-renderer-pre-wrap.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

LayoutTests:

  • fast/text/tab-last-word-in-renderer-pre-wrap-expected.html: Added.
  • fast/text/tab-last-word-in-renderer-pre-wrap.html: Added.
9:07 AM Changeset in webkit [148357] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Windows, WinCairo] ImageBufferCairo.cpp fails to compile after 148247, 148264.
https://bugs.webkit.org/show_bug.cgi?id=114540

Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-04-13
Reviewed by Brent Fulgham.

  • platform/graphics/cairo/ImageBufferCairo.cpp:
7:09 AM Changeset in webkit [148356] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Add missing export macro to SymbolTableEntry::freeFatEntrySlow()

  • runtime/SymbolTable.h:

(SymbolTableEntry):

5:04 AM Changeset in webkit [148355] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] --minimal build fails with error: 'ViewModeInvalid' is not a member of 'WebCore::Page'
https://bugs.webkit.org/show_bug.cgi?id=114048

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-13
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Wrapped view-mode media related code into #if ENABLE(VIEW_MODE_CSS_MEDIA)

  • WebCoreSupport/AssertMatchingEnums.cpp:
  • ewk/ewk_view.cpp:

(ewk_view_mode_set):

Tools:

Wrapped view media related code in #if ENABLE(VIEW_MODE_CSS_MEDIA)

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::setViewModeMediaFeature):

2:47 AM Changeset in webkit [148354] by rniwa@webkit.org
  • 2 edits
    2 deletes in trunk/Tools

Merge watchlistloader into host since it's an unnecessary indirection
https://bugs.webkit.org/show_bug.cgi?id=114555

Reviewed by Antti Koivisto.

We don't need a class to load a file.

  • Scripts/webkitpy/common/host.py:

(Host.watch_list):

  • Scripts/webkitpy/common/watchlist/watchlistloader.py: Removed.
  • Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Removed.
1:16 AM Changeset in webkit [148353] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Rename JSONResultsGeneratorBase to JSONResultsGenerator
https://bugs.webkit.org/show_bug.cgi?id=114553

Reviewed by Philippe Normand.

Renamed now that we've got rid of the old JSONResultsGenerator in r148352.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGenerator):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

(JSONGeneratorTest._test_json_generation):
(JSONGeneratorTest._verify_json_results):

1:02 AM Changeset in webkit [148352] by rniwa@webkit.org
  • 8 edits in trunk/Tools

Remove more Chromium specific code from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=114552

Reviewed by Philippe Normand.

  • Scripts/webkitpy/common/host.py:

(Host.checkout):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase):
(JSONResultsGeneratorBase.init):
(JSONResultsGeneratorBase._is_results_all_of_type):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port):
(Port.expected_filename):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):

  • Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue._new_port_name_from_old):
(CommitQueue.did_pass_testing_ews):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._results_url):
(Rebaseline._builder_with_name):

  • Scripts/webkitpy/tool/mocktool.py:

(MockTool.irc):

12:56 AM Changeset in webkit [148351] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r148311.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(resizeWebKitWebViewBaseFromAllocation): Passing IntSize() as the scroll offset
argument to the DrawingAreaProxy::setSize method.

12:53 AM Changeset in webkit [148350] by fpizlo@apple.com
  • 4 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Fix release build.

  • dfg/DFGOSRExitCompilerCommon.cpp:
  • ftl/FTLExitValue.cpp:
  • ftl/FTLOSRExitCompiler.cpp:
12:40 AM Changeset in webkit [148349] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

Fix flakiness dashboard unit test failures
https://bugs.webkit.org/show_bug.cgi?id=114518

Reviewed by Ryosuke Niwa.

Fix the current failures in unit tests for the flakiness dashboard by adjusting failing
test cases to simulate loading the builders list from the webkit.org build master, replacing
the Chromium builders and platforms that are used in tests with builders and platforms for the
Apple Mac Lion WebKit2 port, and removing two test cases that were testing Chromium-specific
functionality of the dashboard.

This is sort of an interlude to the flakiness dashboard cleanup, with the removal of Chromium-specific
code and hopefully general simplification of the dashboard codebase coming in near future.

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):
(test):

  • TestResultServer/static-dashboards/loader_unittests.js:
12:38 AM Changeset in webkit [148348] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix after r148305.

  • GNUmakefile.list.am: Adding the TrackListBase build targets to the build.
12:38 AM Changeset in webkit [148347] by fpizlo@apple.com
  • 35 edits
    26 adds in branches/dfgFourthTier/Source

fourthTier: FTL should have OSR exit
https://bugs.webkit.org/show_bug.cgi?id=113623

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This implements OSR exit, and hilariously, it actually works. The idea is to have
LLVM call a no-return function on the off-ramp, passing it everything we know about
bytecode state that isn't already flushed to the call frame. Our own JIT takes care
of the rest.

We can now run all of SunSpider, V8, and Kraken with the FTL enabled.

The details are described in FTLOSRExit.h.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/AbstractMacroAssembler.h:

(Address):
(JSC::AbstractMacroAssembler::Address::withOffset):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::offsetOf):
(LinkBuffer):

  • assembler/MacroAssemblerX86Common.h:
  • assembler/RepatchBuffer.h:

(JSC::RepatchBuffer::RepatchBuffer):
(JSC::RepatchBuffer::~RepatchBuffer):
(RepatchBuffer):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::tallyFrequentExitSites):

  • bytecode/Operands.h:

(Operands):
(JSC):
(JSC::::dump):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):

  • dfg/DFGGPRInfo.h:

(DFG):
(GPRInfo):

  • dfg/DFGMinifiedNode.h:

(JSC::DFG::belongsInMinifiedGraph):

  • dfg/DFGNodeType.h:

(JSC::DFG::needsOSRBackwardRewiring):
(DFG):
(JSC::DFG::needsOSRForwardRewiring):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):
(DFG):
(JSC::DFG::OSRExit::convertToForward):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGOSRExitBase.cpp: Added.

(DFG):
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):
(JSC::DFG::OSRExitBase::doSearchForForwardConversion):

  • dfg/DFGOSRExitBase.h: Added.

(DFG):
(JSC::DFG::OSRExitBase::OSRExitBase):
(OSRExitBase):
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSite):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):

  • dfg/DFGOSRExitCompilerCommon.h:

(DFG):

  • dfg/DFGOSRExitPreparation.cpp: Added.

(DFG):
(JSC::DFG::prepareCodeOriginForOSRExit):

  • dfg/DFGOSRExitPreparation.h: Added.

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

  • dfg/DFGValueSource.h:

(JSC::DFG::ValueSource::forSpeculation):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

  • ftl/FTLAbbreviations.h:

(JSC::FTL::functionType):
(FTL):
(JSC::FTL::typeOf):
(JSC::FTL::appendBasicBlock):
(JSC::FTL::insertBasicBlock):
(JSC::FTL::buildCall):
(JSC::FTL::setTailCall):

  • ftl/FTLCArgumentGetter.cpp: Added.

(FTL):
(JSC::FTL::CArgumentGetter::loadNextAndBox):

  • ftl/FTLCArgumentGetter.h: Added.

(FTL):
(JSC::FTL::isArgumentRegister):
(CArgumentGetter):
(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):
(JSC::FTL::CArgumentGetter::nextAddress):

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLExitArgument.cpp: Added.

(FTL):
(JSC::FTL::ExitArgument::dump):

  • ftl/FTLExitArgument.h: Added.

(FTL):
(ExitArgumentRepresentation):
(ExitArgument):
(JSC::FTL::ExitArgument::ExitArgument):
(JSC::FTL::ExitArgument::operator!):
(JSC::FTL::ExitArgument::format):
(JSC::FTL::ExitArgument::argument):
(JSC::FTL::ExitArgument::withFormat):
(JSC::FTL::ExitArgument::representation):

  • ftl/FTLExitArgumentForOperand.cpp: Added.

(FTL):
(JSC::FTL::ExitArgumentForOperand::dump):

  • ftl/FTLExitArgumentForOperand.h: Added.

(FTL):
(ExitArgumentForOperand):
(JSC::FTL::ExitArgumentForOperand::ExitArgumentForOperand):
(JSC::FTL::ExitArgumentForOperand::operator!):
(JSC::FTL::ExitArgumentForOperand::exitArgument):
(JSC::FTL::ExitArgumentForOperand::operand):
(JSC::FTL::lesserArgumentIndex):

  • ftl/FTLExitArgumentList.h: Added.

(FTL):

  • ftl/FTLExitThunkGenerator.cpp: Added.

(FTL):
(JSC::FTL::ExitThunkGenerator::ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::~ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::emitThunk):

  • ftl/FTLExitThunkGenerator.h: Added.

(FTL):
(ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::didThings):

  • ftl/FTLExitValue.cpp: Added.

(FTL):
(JSC::FTL::ExitValue::dump):

  • ftl/FTLExitValue.h: Added.

(FTL):
(ExitValue):
(JSC::FTL::ExitValue::ExitValue):
(JSC::FTL::ExitValue::operator!):
(JSC::FTL::ExitValue::dead):
(JSC::FTL::ExitValue::inJSStack):
(JSC::FTL::ExitValue::inJSStackAsInt32):
(JSC::FTL::ExitValue::inJSStackAsDouble):
(JSC::FTL::ExitValue::constant):
(JSC::FTL::ExitValue::exitArgument):
(JSC::FTL::ExitValue::kind):
(JSC::FTL::ExitValue::isDead):
(JSC::FTL::ExitValue::isInJSStackSomehow):
(JSC::FTL::ExitValue::isConstant):
(JSC::FTL::ExitValue::isArgument):

  • ftl/FTLFormattedValue.h:

(FTL):
(JSC::FTL::noValue):
(JSC::FTL::int32Value):
(JSC::FTL::uInt32Value):
(JSC::FTL::booleanValue):
(JSC::FTL::jsValueValue):
(JSC::FTL::doubleValue):

  • ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::initializeExitThunks):
(FTL):
(JSC::FTL::JITCode::exitThunks):

  • ftl/FTLJITCode.h:

(JITCode):

  • ftl/FTLLowerDFGToLLVM.cpp:

(FTL):
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileMovHint):
(JSC::FTL::LowerDFGToLLVM::compileZombieHint):
(JSC::FTL::LowerDFGToLLVM::compileMovHintAndCheck):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::speculateBackward):
(JSC::FTL::LowerDFGToLLVM::speculateForward):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::terminate):
(JSC::FTL::LowerDFGToLLVM::backwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::forwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::typeCheck):
(JSC::FTL::LowerDFGToLLVM::appendTypeCheck):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::isLive):
(JSC::FTL::LowerDFGToLLVM::use):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::tryToSetConstantExitArgument):
(JSC::FTL::LowerDFGToLLVM::addExitArgument):
(JSC::FTL::LowerDFGToLLVM::linkOSRExitsAndCompleteInitializationBlocks):
(JSC::FTL::LowerDFGToLLVM::observeMovHint):

  • ftl/FTLOSRExit.cpp: Added.

(FTL):
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::codeLocationForRepatch):
(JSC::FTL::OSRExit::convertToForward):

  • ftl/FTLOSRExit.h: Added.

(FTL):
(OSRExit):

  • ftl/FTLOSRExitCompilationInfo.h: Added.

(FTL):
(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):
(OSRExitCompilationInfo):

  • ftl/FTLOSRExitCompiler.cpp: Added.

(FTL):
(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):

  • ftl/FTLOSRExitCompiler.h: Added.

(FTL):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::newBlock):
(JSC::FTL::Output::intToPtr):
(JSC::FTL::Output::load):
(JSC::FTL::Output::store):
(Output):
(JSC::FTL::Output::call):
(JSC::FTL::Output::convertToTailCall):
(FTL):

  • ftl/FTLState.h:

(State):

  • ftl/FTLThunks.cpp: Added.

(FTL):
(JSC::FTL::osrExitGenerationThunkGenerator):

  • ftl/FTLThunks.h: Added.

(JSC):
(FTL):

  • ftl/FTLValueFormat.cpp: Added.

(WTF):
(WTF::printInternal):

  • ftl/FTLValueFormat.h: Added.

(FTL):
(WTF):

  • ftl/FTLValueSource.cpp: Added.

(FTL):
(JSC::FTL::ValueSource::dump):

  • ftl/FTLValueSource.h: Added.

(FTL):
(ValueSource):
(JSC::FTL::ValueSource::ValueSource):
(JSC::FTL::ValueSource::kind):
(JSC::FTL::ValueSource::operator!):
(JSC::FTL::ValueSource::node):

Source/WTF:

Reviewed by Oliver Hunt.

Finally make toCString() somewhat variadic.

  • wtf/StringPrintStream.h:

(WTF):
(WTF::toCString):

Note: See TracTimeline for information about the timeline view.