Timeline
Apr 15, 2013:
- 11:12 PM Changeset in webkit [148495] by
-
- 7 edits in trunk
Web Inspector: Make var and function declarations work again in the Console.
https://webkit.org/b/114534
rdar://problem/13614477
Reviewed by Oliver Hunt.
Source/WebCore:
- inspector/InjectedScriptSource.js:
(InjectedScript.prototype._evaluateOn): Use 'with' when not evaluating
on a call frame.
LayoutTests:
- inspector/console/command-line-api-expected.txt:
- inspector/console/console-eval-syntax-error-expected.txt:
- inspector/extensions/extensions-eval-expected.txt:
- platform/mac/http/tests/inspector/console-resource-errors-expected.txt:
Updated test results.
- 10:56 PM Changeset in webkit [148494] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add missing Localized strings
https://bugs.webkit.org/show_bug.cgi?id=114656
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
Reviewed by Timothy Hatcher.
No tests because no behavior change is expected.
- English.lproj/localizedStrings.js:
- 10:31 PM Changeset in webkit [148493] by
-
- 3 edits2 adds in branches/safari-536.30-branch
Merged r139444.
Source/WebCore:
2013-01-11 Stephen Chenney <schenney@chromium.org>
Objects can be re-added to the AXObjectCache during removal
https://bugs.webkit.org/show_bug.cgi?id=104171
The problem occurs when a label's corresponding element is a sibling
that precedes it in the render tree, and the corresponding element is
removed. The corresponding element's AX render object is removed, but
then recreated when accessibilityIsIgnored() invokes correspondingControl()
on the label. The corresponding renderer then has an AX render object
that survives beyond the deleted renderer, leading to invalid memory
accesses.
The solution is to rearrange the calls to delete the renderer's AX
render object only when we are sure it will no longer be required.
Reviewed by Simon Fraser.
Test: accessibility/corresponding-control-deleted-crash.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed): Move the call to remove the
renderer from the AXCache to after the renderer is removed from the
render tree. This means that the AXObject still exists during renderer
removal, as we require.
LayoutTests:
Checked in a failing expected result for corresponding-control-deleted-crash.html,
since the test requires author shadow DOM to be enabled.
2013-01-11 Stephen Chenney <schenney@chromium.org>
Objects can be re-added to the AXObjectCache during removal
https://bugs.webkit.org/show_bug.cgi?id=104171
Reviewed by Simon Fraser.
New test which asserts with !m_hasAXObject in RenderObject::~RenderObject without the patch. Requires Shadow DOM enabled.
- accessibility/corresponding-control-deleted-crash-expected.txt: Added.
- accessibility/corresponding-control-deleted-crash.html: Added.
- 10:09 PM Changeset in webkit [148492] by
-
- 4 edits2 adds in branches/safari-536.30-branch
Merged r131670.
2012-10-17 Tom Sepez <tsepez@chromium.org>
Crash in ContainerNode::removeAllChildren()
https://bugs.webkit.org/show_bug.cgi?id=98443
Reviewed by Eric Carlson.
Source/WebCore:
This patch makes the errorEventSender added in WebKit Revision 112190 interact
with the updatedHasPendingLoadEvent() mechanism in the same manner as the other
existing event senders.
Test: http/tests/security/video-poster-cross-origin-crash2.html
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::updatedHasPendingEvent):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingLoadEvent):
- loader/ImageLoader.h:
(ImageLoader):
LayoutTests:
- http/tests/security/video-poster-cross-origin-crash2-expected.txt: Added.
- http/tests/security/video-poster-cross-origin-crash2.html: Added.
- 9:37 PM Changeset in webkit [148491] by
-
- 5 edits in branches/safari-536.30-branch
Merged r142063.
2013-02-06 Tom Sepez <tsepez@chromium.org>
document.referrer leakage with XSS Auditor page block
https://bugs.webkit.org/show_bug.cgi?id=109089
Reviewed by Adam Barth.
Source/WebCore:
Pass "about:blank" as referrer instead of "" so that the actual page
is not leaked when empty referrers are replaced later on in the
request.
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
LayoutTests:
Test prints the referrer to show it isn't leaked.
- http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag.html:
- 8:41 PM Changeset in webkit [148490] by
-
- 3 edits in trunk/Source/WTF
Unreviewed, rolling out r148488.
http://trac.webkit.org/changeset/148488
https://bugs.webkit.org/show_bug.cgi?id=114660
Roll back in r148462 since it was a false positive. (Requested
by rniwa on #webkit).
- wtf/FastMalloc.cpp:
(WTF):
(WTF::setThreadHeap):
(WTF::TCMalloc_ThreadCache::GetThreadHeap):
(WTF::TCMalloc_ThreadCache::InitTSD):
- wtf/ThreadSpecificWin.cpp:
(WTF::destructorsList):
(WTF::destructorsMutex):
(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):
- 8:37 PM Changeset in webkit [148489] by
-
- 3 edits in trunk/Source/JavaScriptCore
Windows clean build fix after r148479.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 7:55 PM Changeset in webkit [148488] by
-
- 3 edits in trunk/Source/WTF
Unreviewed, rolling out r148462.
http://trac.webkit.org/changeset/148462
https://bugs.webkit.org/show_bug.cgi?id=114658
Broke Windows builds (Requested by rniwa on #webkit).
- wtf/FastMalloc.cpp:
(WTF):
(WTF::setThreadHeap):
(WTF::TCMalloc_ThreadCache::GetThreadHeap):
(WTF::TCMalloc_ThreadCache::InitTSD):
- wtf/ThreadSpecificWin.cpp:
(WTF::destructorsList):
(WTF::destructorsMutex):
(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):
- 7:52 PM Changeset in webkit [148487] by
-
- 6 edits in trunk/Source/WebCore
Rename restartedPlugin to isRestartedPlugin. This was
review feedback from r148038 that I thought I fixed
everywhere but failed.
https://bugs.webkit.org/show_bug.cgi?id=114233
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::isRestartedPlugin): Prefix with "is".
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::setDisplayState):
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired):
- html/HTMLPlugInImageElement.h:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintContents):
- rendering/RenderLayerBacking.cpp:
(WebCore::isRestartedPlugin):
- 7:15 PM Changeset in webkit [148486] by
-
- 3 edits in trunk/Source/WebCore
Remove V8 attribtues from IDLAttributes.txt
https://bugs.webkit.org/show_bug.cgi?id=114651
Reviewed by Sam Weinig.
No tests because no behavior change is expected.
- bindings/scripts/IDLAttributes.txt: Remove V8 attribtues.
- html/track/TextTrackList.idl: Remove a stray V8-specific attribute
(so I guess this change is not useless)
- 6:38 PM Changeset in webkit [148485] by
-
- 27 edits2 adds in branches/safari-536.30-branch
Merged r139111.
2013-01-08 Tom Sepez <tsepez@chromium.org>
Copy-paste preserves <embed> tags containing active content.
https://bugs.webkit.org/show_bug.cgi?id=77625
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: editing/pasteboard/paste-noplugin.html
- dom/FragmentScriptingPermission.h:
(WebCore::scriptingContentIsAllowed):
(WebCore::pluginContentIsAllowed):
Add new permission to restrict plugin pasting. Add inline functions to check
the implications of each permission rather than having a list of raw comparisions
sprinkled throughout the code.
- editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
Revert back to unsafe plugin pasting regardless of caller's intentions when
the settings allow it.
- dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertScriptElement):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::endElementNs):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseEndElement):
Use new inline functions to check implications of permissions rather than raw
comparisions.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
Check if plugin pasting is allowed before inserting applet/embed/oject elements.
- page/Settings.in:
Declaration of new unsafePluginPastingEnabled setting.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::documentFragment):
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asFragment):
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/qt/DragDataQt.cpp:
(WebCore::DragData::asFragment):
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::fragmentFromCFHTML):
(WebCore::fragmentFromHTML):
- platform/wx/PasteboardWx.cpp:
(WebCore::Pasteboard::documentFragment):
Pass DisallowScriptingAndPluginContent enum value.
Source/WebKit/chromium:
Adds chromium API to new unsafePluginPastingEnabled setting.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setUnsafePluginPastingEnabled):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
LayoutTests:
- editing/pasteboard/paste-noplugin-expected.txt: Added.
- editing/pasteboard/paste-noplugin.html: Added.
- 6:34 PM Changeset in webkit [148484] by
-
- 6 edits in trunk
WebKit should not expose AXSubrole:AXDescriptionList on Mountain Lion as it causes a regression in VoiceOver behavior
https://bugs.webkit.org/show_bug.cgi?id=113975
Patch by James Craig <james@cookiecrook.com> on 2013-04-15
Reviewed by Chris Fleizach.
Serve NSAccessibilityDescriptionListSubrole or NSAccessibilityDefinitionListSubrole
depending on platform. Updated existing test coverage.
Source/WebCore:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper subrole]):
LayoutTests:
- platform/mac/accessibility/lists-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription.html:
- 6:20 PM Changeset in webkit [148483] by
-
- 3 edits3 moves in trunk
Source/WebKit/mac: plugins/get-url-beforeunload-destroys-plugin.html crashes in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=114653
<rdar://problem/13659541>
Reviewed by Sam Weinig.
Protect the NetscapePluginInstanceProxy since it can otherwise go away.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::performRequest):
LayoutTests: plugins/get-url-beforeunload-destroys-plugin.html crashes in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=114653
Reviewed by Sam Weinig.
Move this test back now that it passes in WK1.
- http/tests/plugins/get-url-beforeunload-destroys-plugin-expected.txt: Renamed from LayoutTests/platform/mac-wk2/http/tests/plugins/get-url-beforeunload-destroys-plugin-expected.txt.
- http/tests/plugins/get-url-beforeunload-destroys-plugin.html: Renamed from LayoutTests/platform/mac-wk2/http/tests/plugins/get-url-beforeunload-destroys-plugin.html.
- http/tests/plugins/resources/notify-done.html: Renamed from LayoutTests/platform/mac-wk2/http/tests/plugins/resources/notify-done.html.
- 6:05 PM Changeset in webkit [148482] by
-
- 9 edits in trunk/Source
Plugins that resize might need to be snapshotted.
https://bugs.webkit.org/show_bug.cgi?id=102157
<rdar://problem/12696259>
Reviewed by Tim Horton.
Source/WebCore:
A plugin could avoid snapshotting if it started very
small (below the threshold where we autostart), and then
resized to be large (above the threshold). Detect this
case and tell the plugin to snapshot.
There unfortunately is a bit of state to track when doing
this. We have to start the snapshotting in a post-layout
task, so we carry a flag to say we're checking size but
not wanting the plugin to update (which would restart it).
We also might be a plugin that would have already restarted
due to a similar plugin being clicked or detected as dominant.
So this patch introduces a member variable that tracks what
decision has been made on snapshotting.
I also added some more logging to be more clear about what is
happening to plugins going through the snapshot process, and
changed the order of the tests in the algorithm so that domain
detection comes before examining the size.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Initialise
the two new member variables.
(WebCore::HTMLPlugInImageElement::setDisplayState): Mark a restarted
plugin as NeverSnapshot. This means that if it later resizes above the
threshold, it won't trigger the snapshot detection.
(WebCore::HTMLPlugInImageElement::checkSnapshotStatus): Renamed from
updateSnapshotInfo. This now updates the snapshot, but also runs
the check for size changes.
(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Gather all plugins
that look like a restarting plugin, not just those snapshotted. That
way they can all be marked as NeverSnapshot.
(WebCore::HTMLPlugInImageElement::restartSimilarPlugIns): Bless every
plugin that looks similar, whether or not it is snapshotted.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): More logging.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Ditto.
(WebCore::HTMLPlugInImageElement::checkSizeChangeForSnapshotting): New
method. If the plugin was below the threshold and is now above it,
begin the snapshotting process.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Plugins
that were marked as NeverSnapshot should start immediately. Move the origin
test earlier in the method. If a plugin avoided snapshotting due to size,
remember the size.
(WebCore::HTMLPlugInImageElement::subframeLoaderDidCreatePlugIn): Mark the
plugin as NeverSnapshot.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): Four new member variables:
- the decision we made regarding snapshotting (or not), uses the SnapshotDecision enum
- the size when it avoided snapshotting
- a flag to indicate the post layout update was triggered due to a size change
(WebCore::HTMLPlugInImageElement::needsCheckForSizeChange): New method.
(WebCore::HTMLPlugInImageElement::setNeedsCheckForSizeChange): New method.
(WebCore::HTMLPlugInImageElement::snapshotDecision): Return the decision
regarding snapshotting or not snapshotting.
- page/FrameView.cpp:
(WebCore::FrameView::addWidgetToUpdate): Guard updating the widget. We don't
want to do it when we're checking for a size change in the plugin.
(WebCore::FrameView::updateWidget): Call new name.
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::beginSnapshottingRunningPlugin): Empty virtual
method to snapshot a running plugin.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout): If the plugin has increased in
size add it to the post layout list so that it will be checked.
Source/WebKit2:
Allow a running plugin to be snapshotted. All this
means is that we start the snapshot timer again.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::beginSnapshottingRunningPlugin): Restart
the timer.
- WebProcess/Plugins/PluginView.h: Virtual method declaration.
- 6:01 PM Changeset in webkit [148481] by
-
- 3 edits2 adds in trunk
activating a focused link to an in-page fragment ID should transfer focus to the target of the link when possible
https://bugs.webkit.org/show_bug.cgi?id=17450
Reviewed by Maciej Stachowiak.
Source/WebCore:
When a fragment is scrolled to due to an activation event or on load, focus should attempt to
move to the fragment if possible.
Test: fast/dom/fragment-activation-focuses-target.html
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
LayoutTests:
- fast/dom/fragment-activation-focuses-target.html: Added.
- 5:30 PM Changeset in webkit [148480] by
-
- 21 edits in trunk/Source/WebCore
Remove V8-specific extended attributes from IDL files
https://bugs.webkit.org/show_bug.cgi?id=114523
Reviewed by Geoffrey Garen.
No tests because no behavior change is expected.
- Modules/encryptedmedia/MediaKeyMessageEvent.idl:
- Modules/encryptedmedia/MediaKeyNeededEvent.idl:
- Modules/encryptedmedia/MediaKeySession.idl:
- Modules/encryptedmedia/MediaKeys.idl:
- Modules/filesystem/HTMLInputElementFileSystem.idl:
- Modules/indexeddb/IDBAny.idl:
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBuffer.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediastream/MediaStream.idl:
- Modules/webaudio/AudioDestinationNode.idl:
- html/track/TextTrackCue.idl:
- html/track/TextTrackCueList.idl:
- html/track/TextTrackList.idl:
- html/track/TextTrackRegion.idl:
- html/track/TextTrackRegionList.idl:
- html/track/TrackEvent.idl:
- storage/Storage.idl:
- svg/SVGDocument.idl:
- svg/SVGElement.idl:
- workers/WorkerContext.idl:
- xml/XMLHttpRequest.idl:
- xml/XPathNSResolver.idl:
- 5:22 PM Changeset in webkit [148479] by
-
- 25 edits1 copy in trunk/Source
ScriptWrappable subclasses shouldn't have to include WeakInlines.h
https://bugs.webkit.org/show_bug.cgi?id=114641
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
Move back the Weak constructor, destructor and clear() to Weak.h. Add a new weakClearSlowCase function
and put it in Weak.cpp.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- heap/Weak.cpp: Added.
- heap/Weak.h:
- heap/WeakInlines.h:
- heap/WeakSetInlines.h:
Source/WebCore:
Remove ScriptWrappableInlines.h includes, they're not needed anymore.
- css/WebKitCSSMatrix.cpp:
- dom/ClientRect.cpp:
- dom/ClientRectList.cpp:
- dom/Clipboard.cpp:
- dom/DOMStringMap.cpp:
- dom/Event.cpp:
- dom/MutationRecord.cpp:
- fileapi/FileList.cpp:
- page/BarInfo.cpp:
- plugins/DOMMimeTypeArray.cpp:
- plugins/DOMPlugin.cpp:
- plugins/DOMPluginArray.cpp:
- storage/Storage.cpp:
- 5:10 PM Changeset in webkit [148478] by
-
- 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore
Build fix for Windows.
<rdar://problem/13438603>
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- 4:46 PM Changeset in webkit [148477] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] build fix after r148434
https://bugs.webkit.org/show_bug.cgi?id=114647
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
Reviewed by Benjamin Poulain.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::showContextMenu):
- 4:26 PM Changeset in webkit [148476] by
-
- 3 edits in branches/safari-536.30-branch/Source/WebCore
Build fix for r148472.
- 4:17 PM Changeset in webkit [148475] by
-
- 15 edits in trunk/Source/JavaScriptCore
HeapTimer lifetime should be less complicated
https://bugs.webkit.org/show_bug.cgi?id=114529
Reviewed by Oliver Hunt.
Right now our HeapTimer lifetime is rather complicated. HeapTimers are "owned" by the JSGlobalData,
but there's an issue in that there can be races between a thread that is trying to tear down a JSGlobalData
and the HeapTimer's fire function. Our current code for tearing down HeapTimers is an intricate and delicate
dance which probably contains subtle bugs.
We can make our lives easier by changing things around a bit.
1) We should free the API lock from being solely owned by the JSGlobalData so we don't have to worry about
grabbing the lock out of invalid memory when our HeapTimer callback fires.
2) We should also make it so that we deref the JSGlobalData first, then unlock the API lock so that when we
have the lock, the JSGlobalData is in one of two states: fully valid or completely destroyed, and we know exactly which one.
3) The JSLock can tell us this information by keeping a back pointer to the JSGlobalData. When the JSGlobalData's
destructor is called, it clears this pointer in the JSLock. Other clients of the API lock can then check
this pointer to determine whether or not the JSGlobalData is still around.
4) The CFRunLoopTimer will use the API lock as its context rather than the HeapTimer itself. The only way
the HeapTimer's callback can get to the HeapTimer is through the API lock's JSGlobalData pointer.
5) The CFRunLoopTimerContext struct has two fields for retain and release callbacks for the context's info field.
We'll provide these callbacks to ref() and deref() the JSLock as necessary. Thus, the timer becomes the other
owner of the JSLock apart from the JSGlobalData.
- API/APIShims.h: Remove the cruft that was required by the previous design, such as RefGlobalDataTag.
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(APIEntryShimWithoutLock):
(JSC::APIEntryShim::APIEntryShim):
(JSC::APIEntryShim::~APIEntryShim): Protect the API lock with a RefPtr, deref the JSGlobalData, which could destroy it,
then unlock the API lock. This ordering prevents others from obtaining the API lock while the JSGlobalData is in the
middle of being torn down.
(JSC::APIEntryShim::init): We now take the lock, then ref the JSGlobalData, which is the opposite order of when we
tear down the shim.
- heap/Heap.cpp:
(JSC::Heap::setActivityCallback): Use PassOwnPtr now.
(JSC::Heap::activityCallback): Ditto.
(JSC::Heap::sweeper): Ditto.
(JSC):
- heap/Heap.h:
(Heap):
- heap/HeapTimer.cpp:
(JSC::retainAPILock): Retain callback for CFRunLoopTimerContext struct.
(JSC::releaseAPILock): Release callback for the CFRunLoopTimerContext struct.
(JSC::HeapTimer::HeapTimer): Use the API lock as the context's info field rather than the HeapTimer.
(JSC::HeapTimer::timerDidFire): Grab the API lock. Return early if the JSGlobalData has already been destroyed.
Otherwise, figure out which kind of HeapTimer we are based on the CFRunLoopTimerRef passed to the callback and
call the HeapTimer's callback.
- heap/HeapTimer.h:
(HeapTimer):
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::create): PassOwnPtr all the things.
- heap/IncrementalSweeper.h:
(IncrementalSweeper):
- jsc.cpp:
(jscmain): We use an APIEntryShim instead of a RefPtr for the JSGlobalData because we need to
tear down the JSGlobalData while we still hold the lock, which the APIEntryShim handles correctly.
- runtime/GCActivityCallback.h:
(DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::create):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData): Notify the API lock that the JSGlobalData is being torn down.
- runtime/JSGlobalData.h:
(JSGlobalData):
(JSC::JSGlobalData::apiLock):
- runtime/JSLock.cpp:
(JSC::JSLockHolder::JSLockHolder): Ref, then lock (just like the API shim).
(JSC):
(JSC::JSLock::willDestroyGlobalData):
(JSC::JSLockHolder::init):
(JSC::JSLockHolder::~JSLockHolder): Protect, deref, then unlock (just like the API shim).
(JSC::JSLock::JSLock):
- runtime/JSLock.h: Add back pointer to the JSGlobalData and a callback for when the JSGlobalData is being
torn down that clears this pointer to notify other clients (i.e. timer callbacks) that the JSGlobalData is no
longer valid.
(JSLockHolder):
(JSLock):
(JSC::JSLock::globalData):
- testRegExp.cpp:
(realMain): We use an APIEntryShim instead of a RefPtr for the JSGlobalData because we need to
tear down the JSGlobalData while we still hold the lock, which the APIEntryShim handles correctly.
- 4:04 PM Changeset in webkit [148474] by
-
- 14 edits1 add in trunk/Source
LLInt SH4 backend implementation
https://bugs.webkit.org/show_bug.cgi?id=112886
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-15
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- dfg/DFGOperations.cpp:
(JSC):
- jit/JITStubs.cpp:
- llint/LLIntOfflineAsmConfig.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- offlineasm/arm.rb:
- offlineasm/ast.rb:
- offlineasm/backends.rb:
- offlineasm/instructions.rb:
- offlineasm/mips.rb:
- offlineasm/risc.rb:
- offlineasm/sh4.rb: Added.
Source/WTF:
- wtf/Platform.h:
- 3:56 PM Changeset in webkit [148473] by
-
- 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore
Merged r141029. <rdar://problem/13334878>
- 3:26 PM Changeset in webkit [148472] by
-
- 5 edits in branches/safari-536.30-branch/Source/WebCore
r138821, <rdar://problem/13334928>
- 3:19 PM Changeset in webkit [148471] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebCore
Merged r138990.
2013-01-07 Tom Sepez <tsepez@chromium.org>
Document::initSecurityContext() gives parent security context to iframes with invalid URLs.
https://bugs.webkit.org/show_bug.cgi?id=104960
Reviewed by Adam Barth.
Change covers the case of an invalid non-empty URL. We know nothing
about that kind of URL and choose not to inherit origins.
- dom/Document.cpp:
(WebCore::shouldInheritSecurityOriginFromOwner):
- 3:07 PM Changeset in webkit [148470] by
-
- 5 edits2 copies in branches/safari-536.30-branch
Merge r143454. <rdar://problem/13334919>
- 2:42 PM Changeset in webkit [148469] by
-
- 4 edits2 copies in branches/safari-536.30-branch
Merge r143454. <rdar://problem/13334874>
- 2:25 PM Changeset in webkit [148468] by
-
- 2 edits in trunk/Source/WebCore
Call directly RenderBlock::deleteLineBoxTree
https://bugs.webkit.org/show_bug.cgi?id=102761
Reviewed by Darin Adler.
Instead of implementing RenderLineBoxList::deleteLineBoxTree logic inside
RenderBlock::determineStartPosition, we can reuse the code. The commentaries added
in the changeset #86628 are not valid anymore, nextRootBox is casting m_nextLineBox
and nextLineBox is returning m_nextLineBox.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):
- 2:19 PM Changeset in webkit [148467] by
-
- 4 edits in trunk/Source/WebCore
Remove files related to quota and proximity events from the Xcode project
https://bugs.webkit.org/show_bug.cgi?id=114635
Reviewed by Benjamin Poulain.
- WebCore.xcodeproj/project.pbxproj:
- history/PageCache.cpp:
- page/DOMWindow.cpp:
- 2:07 PM Changeset in webkit [148466] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash from null m_webSettings in WebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=114633
RIM PR 303745
Patch by Liam Quinn <lquinn@blackberry.com> on 2013-04-15
Reviewed by Rob Buis.
Internally reviewed by Leo Yang.
Speculative fix suggested by George Staikos--initialize m_webSettings first thing in the init() method.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
- 2:05 PM Changeset in webkit [148465] by
-
- 17 edits in branches/safari-536.30-branch
Merge r142759. <rdar://problem/13334873>
- 2:04 PM Changeset in webkit [148464] by
-
- 2 edits in trunk/Source/WebKit2
After switching to another space and back, video races to catch up with audio
https://bugs.webkit.org/show_bug.cgi?id=114634
Reviewed by Tim Horton.
In Mountain Lion and previous, report that a view is "not visible" when its window
is not in the active space. This causes us to notify AVFoundation that its CAImageQueues
will not be serviced and results in not having the "catch up" behavior when returning
to the browser's space.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isViewVisible):
- 1:32 PM Changeset in webkit [148463] by
-
- 17 edits in trunk
[CMake] Add WTF_USE_*_UNICODE variables
https://bugs.webkit.org/show_bug.cgi?id=114556
Reviewed by Brent Fulgham.
WTF_USE_ICU_UNICODE and WTF_USE_WCHAR_UNICODE are used to
reduce duplication in the platform specific CMake files.
.:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWinCE.cmake:
Source/JavaScriptCore:
- CMakeLists.txt:
- PlatformEfl.cmake:
Source/WebCore:
- CMakeLists.txt:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
Source/WTF:
- wtf/CMakeLists.txt:
- wtf/PlatformBlackBerry.cmake:
- wtf/PlatformEfl.cmake:
- wtf/PlatformWinCE.cmake:
- 1:23 PM Changeset in webkit [148462] by
-
- 3 edits in trunk/Source/WTF
[WIN] Remove remaining calls to pthread from WTF
https://bugs.webkit.org/show_bug.cgi?id=114563
Reviewed by Brent Fulgham.
Replace pthread_key_create with threadSpecificKeyCreate and
pthread_setspecific with threadSpecificSet from ThreadSpecific.h.
These functions provide a windows-specific implementation for the pthread functions,
but require that the thread has been created with WTF::createThread(),
which is the case for all threads created within WebKit.
To call this function from fastMalloc we must not call fastMalloc in them.
To fulfill this constraint ThreadSpecificWin will allocated its memory through the
original malloc implementation and use the stack for local and static variables.
Keep the Darwin implementation as it is, since it contains some performance tweaks.
- wtf/FastMalloc.cpp:
- wtf/ThreadSpecificWin.cpp:
(WTF::destructorsList):
(WTF::destructorsMutex):
(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):
- 1:13 PM Changeset in webkit [148461] by
-
- 2 edits in trunk/Tools
WKR gets stuck when there are many merges
https://bugs.webkit.org/show_bug.cgi?id=114632
Reviewed by Andreas Kling.
Move the last revision forward when it exists in a branch.
Otherwise, we'll be stuck looping over revisions made to merge patches.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):
- 1:09 PM Changeset in webkit [148460] by
-
- 4 edits in branches/safari-536.30-branch/Source/WebCore
Merge 133840, 134191, 134197, <rdar://problem/13334895>
- 1:05 PM Changeset in webkit [148459] by
-
- 9 edits in branches/safari-536.30-branch/Source/WebCore
Merged r140127. <rdar://problem/13334953>
- 12:46 PM Changeset in webkit [148458] by
-
- 2 edits in trunk/Source/WebCore
HTMLMediaElement::removeTextTrack should clear track client
https://bugs.webkit.org/show_bug.cgi?id=114630
Reviewed by Jer Noble.
No new tests, this is clean-up that prevents a potential crash.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removeTextTrack): Clear the track client.
- 12:39 PM Changeset in webkit [148457] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebCore
Merge r138213, <rdar://problem/13335063>
- 12:32 PM Changeset in webkit [148456] by
-
- 2 edits in trunk/Source/WebKit/win
Crash when favicon is requested
https://bugs.webkit.org/show_bug.cgi?id=114624
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-15
Reviewed by Brent Fulgham.
- WebIconDatabase.cpp:
(WebIconDatabase::getOrCreateDefaultIconBitmap): Added NULL pointer check.
- 12:04 PM Changeset in webkit [148455] by
-
- 7 edits1 delete in branches/safari-536.30-branch
Rollout r145643.
- 11:27 AM Changeset in webkit [148454] by
-
- 4 edits2 adds in branches/safari-536.30-branch
Merge r142816, <rdar://problem/13334866>
- 11:23 AM Changeset in webkit [148453] by
-
- 3 edits2 adds in trunk
An inline element with an absolutely positioned child does not correctly calculate/render padding and margin
https://bugs.webkit.org/show_bug.cgi?id=47554
Reviewed by David Hyatt.
Source/WebCore:
When looking for padding/margin to add from the start of a child's parent skip past any leading positioned siblings as
we don't add the padding/margin of the common parent when skipping past them in |skipLeadingWhitespace|. We
don't need to worry about the case of trailing positioned objects as we will account for their parent's
border/margin/padding when we encounter them in |nextSegmentBreak|.
Test: fast/inline/padding-before-leading-positioned-element-contributes-width.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::previousInFlowSibling):
(WebCore):
(WebCore::inlineLogicalWidth):
LayoutTests:
- fast/inline/padding-before-leading-positioned-element-contributes-width-expected.txt: Added.
- fast/inline/padding-before-leading-positioned-element-contributes-width.html: Added.
- 11:19 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:16 AM Changeset in webkit [148452] by
-
- 1 edit1 add in trunk/LayoutTests
Flaky Test: http/tests/ssl/ping-with-unsafe-redirect.html
https://bugs.webkit.org/show_bug.cgi?id=114616
Land expected results for the test.
- http/tests/ssl/ping-with-unsafe-redirect-expected.txt: Added.
- 11:02 AM Changeset in webkit [148451] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Forward userGesture when creating a new window
https://bugs.webkit.org/show_bug.cgi?id=114622
Patch by Andy Chen <andchen@blackberry.com> on 2013-04-15
Reviewed by Rob Buis.
Client could use this info to decide whether the popup should
be blocked.
PR 291898
Reviewed internally by Mike Fenton
- Api/WebPageClient.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
- 10:59 AM Changeset in webkit [148450] by
-
- 3 edits2 adds in branches/safari-536.30-branch
Merge r142922, <rdar://problem/13334860>
- 10:52 AM Changeset in webkit [148449] by
-
- 2 edits in trunk/Tools
[GTK] Missing a few packages for building on stock Fedora
https://bugs.webkit.org/show_bug.cgi?id=113916
Reviewed by Philippe Normand.
- gtk/install-dependencies: add packages that are missing.
- 10:46 AM Changeset in webkit [148448] by
-
- 3 edits2 adds in branches/safari-536.30-branch
Merged r138988, <rdar://problem/13334838>
- 10:13 AM Changeset in webkit [148447] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=114623
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-15
Reviewed by Brent Fulgham.
- platform/network/curl/CookieJarCurl.cpp: Added required header files.
- 10:09 AM Changeset in webkit [148446] by
-
- 2 edits in trunk/Tools
REGRESSION (r148360): Failure in webkitpy.tool.multicommandtool_unittest.MultiCommandToolTest.test_command_help
https://bugs.webkit.org/show_bug.cgi?id=114602
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/tool/multicommandtool_unittest.py:
(CommandTest.test_required_arguments): Reset the static argument_names variable on the TrivialCommand
interface so its value doesn't leak into the following tests.
- 10:06 AM Changeset in webkit [148445] by
-
- 2 edits in trunk
[GTK] REGRESSION(r147499): HTTP auth dialog doesn't remember passwords anymore
https://bugs.webkit.org/show_bug.cgi?id=114613
Reviewed by Carlos Garcia Campos.
- Source/autotools/SetupAutoconfHeader.m4: Correct definition of ENABLE_CREDENTIAL_STORAGE
so that the ENABLE(CREDENTIAL_STORAGE) macro work properly.
- 9:22 AM Changeset in webkit [148444] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- 9:07 AM Changeset in webkit [148443] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r148236.
- 8:52 AM Changeset in webkit [148442] by
-
- 2 edits in trunk/Source/WebCore
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Patch by Rob Buis <rbuis@rim.com> on 2013-04-15
Reviewed by Darin Adler.
It does not seem needed to initialize jpeg_create_compress struct to zero,
all that is needed is set the err field. See for instance SkImageDecoder_libjpeg.cpp.
- platform/image-encoders/JPEGImageEncoder.cpp:
(WebCore::compressRGBABigEndianToJPEG):
- 8:39 AM Changeset in webkit [148441] by
-
- 3 edits in trunk/Tools
Deprecate land-cowboy in favor of land-cowhand
https://bugs.webkit.org/show_bug.cgi?id=104470
Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-04-15
Reviewed by Darin Adler.
Move the LandCowboy command implementation under the LandCowhand command and deprecate the former.
- Scripts/webkitpy/tool/commands/download.py:
(LandCowhand):
(LandCowboy):
(LandCowboy._prepare_state):
- Scripts/webkitpy/tool/commands/download_unittest.py:
(test_land_cowhand): Adjust the unit tests by testing both LandCowhand and LandCowboy,
also checking the deprecation message in the output of the latter.
- 8:28 AM Changeset in webkit [148440] by
-
- 3 edits1 delete in trunk/Source/WebCore
[GTK] Remove platform specific implementation of KURL::fileSystemPath()
https://bugs.webkit.org/show_bug.cgi?id=114133
Reviewed by Martin Robinson.
r147883 added a generic implementation of this function,
which can be used by all ports to share the code.
- GNUmakefile.list.am:
- platform/KURL.cpp:
(WebCore):
- platform/gtk/KURLGtk.cpp: Removed.
- 8:28 AM Changeset in webkit [148439] by
-
- 3 edits in trunk/Source/WebKit2
Schedule rendering at regular interval (60fps)
https://bugs.webkit.org/show_bug.cgi?id=114617
Patch by Seulgi Kim <seulgikim@company100.net> on 2013-04-15
Reviewed by Martin Robinson.
Schedule rendering reguarly regardless of the time taken to render a
frame. Otherwise, next flush delayed by the amount of the rendering
time.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::LayerTreeHostGtk):
(WebKit::LayerTreeHostGtk::layerFlushTimerFired):
(WebKit::LayerTreeHostGtk::flushAndRenderLayers):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- 8:25 AM Changeset in webkit [148438] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r148373.
- WebCoreSupport/EditorClientWinCE.cpp:
- 8:22 AM Changeset in webkit [148437] by
-
- 2 edits in trunk/Source/WebCore
Debug buildfix after r148433.
https://bugs.webkit.org/show_bug.cgi?id=108295
Reviewed by Allan Sandfeld Jensen.
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::children): Added.
- 7:16 AM Changeset in webkit [148436] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt/TestExpectations:
- 7:02 AM Changeset in webkit [148435] by
-
- 2 edits in trunk/Tools
Improve Windows cmd.exe detection
https://bugs.webkit.org/show_bug.cgi?id=114620
Patch by Jonathan Liu <net147@gmail.com> on 2013-04-15
Reviewed by Jocelyn Turcotte.
The current detection code handles Windows cmd.exe and Cygwin shell
but not does not handle MSYS shell correctly. Simplify and improve the
detection by checking MINGW_IN_SHELL instead as used in other places
(e.g. qt_functions.prf).
- qmake/mkspecs/features/default_pre.prf:
- 6:43 AM Changeset in webkit [148434] by
-
- 12 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API in ewk_context_menu
https://bugs.webkit.org/show_bug.cgi?id=109698
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-04-15
Reviewed by Andreas Kling.
EFL port unlike others does not handle context menus inside WebKit but exposes an API:
ewk_context_menu and ewk_context_menu_item, and leaves context menu to application.
Currently EFL port's context menu API uses internal C++ classes, while it should use WK2 C API,
to avoid violating layering.
This patch changes EFL context menu API to use only WK2 C API.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::showContextMenu):
- UIProcess/API/efl/EwkView.h:
(WebKit):
(EwkView):
- UIProcess/API/efl/ewk_context_menu.cpp:
(EwkContextMenu::EwkContextMenu):
(EwkContextMenu::contextMenuItemSelected):
(ewk_context_menu_item_select):
(getWKTagFromEwkAction):
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(EwkContextMenuItem::EwkContextMenuItem):
(getEwkActionFromWKTag):
- UIProcess/API/efl/ewk_context_menu_item.h:
- UIProcess/API/efl/ewk_context_menu_item_private.h:
(EwkContextMenuItem::create):
(EwkContextMenuItem):
- UIProcess/API/efl/ewk_context_menu_private.h:
(EwkContextMenu::create):
(EwkContextMenu):
- UIProcess/efl/ContextMenuClientEfl.cpp:
(showContextMenu):
(hideContextMenu):
(ContextMenuClientEfl::ContextMenuClientEfl):
- UIProcess/efl/ContextMenuClientEfl.h:
(WebKit::ContextMenuClientEfl::view):
- UIProcess/efl/WebContextMenuProxyEfl.cpp:
(WebKit::WebContextMenuProxyEfl::showContextMenu):
(WebKit::WebContextMenuProxyEfl::hideContextMenu):
- UIProcess/efl/WebContextMenuProxyEfl.h:
(WebContextMenuProxyEfl):
- 6:24 AM Changeset in webkit [148433] by
-
- 6 edits in trunk/Source/WebCore
Coordinated Graphics: Remove GraphicsLayerTextureMapper dependency from CoordinatedGraphicsScene.
https://bugs.webkit.org/show_bug.cgi?id=108295
Since all the changes to the TextureMapperLayer tree now come in a single IPC message via
CoordinatedGraphicsState, we don't need the additional buffering done in GraphicsLayerTextureMapper.
This reduces unnecessary function calls, and also streamlines GraphicsLayerTextureMapper to be used
only in WebKit1 (without CoordinatedGraphics).
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-15
Reviewed by Allan Sandfeld Jensen.
No new tests, refactor only.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::setDrawsContent):
(WebCore::GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded):
(WebCore::GraphicsLayerTextureMapper::updateDebugBorderAndRepaintCount):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):
(WebCore):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
Removed references to m_hasOwnBackingStore, which was done to separate the CoordinatedGraphics
path from the WK1 path.
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::drawsContent):
(WebCore::TextureMapperLayer::contentsAreVisible):
(WebCore::TextureMapperLayer::size):
(WebCore::TextureMapperLayer::opacity):
(WebCore::TextureMapperLayer::transform):
(WebCore::TextureMapperLayer::isShowingRepaintCounter):
(WebCore::TextureMapperLayer::fixedToViewport):
(TextureMapperLayer):
Added a few public functions needed by CoordinatedGraphicsScene.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::layerShouldHaveBackingStore):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):
(WebCore::CoordinatedGraphicsScene::adjustPositionForFixedLayers):
(WebCore::CoordinatedGraphicsScene::createCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::syncCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::destroyCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerRepaintCountIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerChildrenIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerFiltersIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::getLayerByIDIfExists):
(WebCore::CoordinatedGraphicsScene::createLayer):
(WebCore::CoordinatedGraphicsScene::deleteLayer):
(WebCore::CoordinatedGraphicsScene::setRootLayerID):
(WebCore::CoordinatedGraphicsScene::prepareContentBackingStore):
(WebCore::CoordinatedGraphicsScene::createBackingStoreIfNeeded):
(WebCore::CoordinatedGraphicsScene::removeBackingStoreIfNeeded):
(WebCore::CoordinatedGraphicsScene::resetBackingStoreSizeToLayerSize):
(WebCore::CoordinatedGraphicsScene::createTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::removeTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::updateTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):
(WebCore::CoordinatedGraphicsScene::commitSceneState):
(WebCore::CoordinatedGraphicsScene::ensureRootLayer):
(WebCore::CoordinatedGraphicsScene::setLayerAnimationsIfNeeded):
(WebCore::CoordinatedGraphicsScene::findScrollableContentsLayerAt):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::layerByID):
(WebCore::CoordinatedGraphicsScene::rootLayer):
Use TextureMapperLayer instead of GraphicsLayer and GraphicsLayerTextureMapper.
- 6:00 AM Changeset in webkit [148432] by
-
- 5 edits in trunk/Source/WebCore
Dynamically triggered subframe loads are causing tile churn
https://bugs.webkit.org/show_bug.cgi?id=114440
Reviewed by Andreas Kling.
In some cases we switch in and out of minimal tiles multiple times during page loading. This
creates tile churn where we create speculative tiles and then throw them out. This can be
caused by various reasons including dynamically created subframes.
- page/FrameView.cpp:
(WebCore::FrameView::setIsVisuallyNonEmpty):
Stay in minimal tiles modes until there is some visual contents. This avoids switching out from minimal
tiles while awaiting response for the initial requests.
- page/FrameView.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::computeTileCoverage):
- rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::didSwitchToFullTileCoverageDuringLoading):
(WebCore::RenderLayerBacking::setDidSwitchToFullTileCoverageDuringLoading):
Only switch into minimal coverage mode once per page load.
(RenderLayerBacking):
- 5:02 AM Changeset in webkit [148431] by
-
- 5 edits4 adds in trunk
color-index media feature not supported
https://bugs.webkit.org/show_bug.cgi?id=114468
Patch by Rune Lillesveen <rune@opera.com> on 2013-04-15
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Support the color-index media feature. Currently assumes that no WebKit
browser will have an output device that uses a color lookup table.
Tests: fast/media/mq-color-index-01.html
fast/media/mq-color-index-02.html
- css/MediaFeatureNames.h:
(MediaFeatureNames):
- css/MediaQueryEvaluator.cpp:
(WebCore::color_indexMediaFeatureEval):
(WebCore):
(WebCore::min_color_indexMediaFeatureEval):
(WebCore::max_color_indexMediaFeatureEval):
- css/MediaQueryExp.cpp:
(WebCore::featureWithPositiveInteger):
(WebCore::featureWithoutValue):
LayoutTests:
Added testcases for checking support and handling invalid values for
the color-index media feature.
- fast/media/mq-color-index-01-expected.html: Added.
- fast/media/mq-color-index-01.html: Added.
- fast/media/mq-color-index-02-expected.txt: Added.
- fast/media/mq-color-index-02.html: Added.
- 4:49 AM Changeset in webkit [148430] by
-
- 6 edits in trunk/Source
[CoordGfx] Background color should not be part of GraphicsLayerState
https://bugs.webkit.org/show_bug.cgi?id=113785
Source/WebCore:
Page background is independent from layer state, send it to the UI
as soon as possible.
Should not cause observable change in behavior so no new tests.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::commitSceneState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
Source/WebKit2:
Reviewed by Andreas Kling.
Page background is independent from layer state, send it to the UI
as soon as possible.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::setBackgroundColor):
- 4:11 AM QtWebKitBuildBots edited by
- Updating some bot information. (diff)
- 4:08 AM Changeset in webkit [148429] by
-
- 2 edits in trunk/Tools
[webkitpy] Use $NUMBER_OF_PROCESSORS in Executive.cpu_count()
https://bugs.webkit.org/show_bug.cgi?id=114506
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-15
Reviewed by Philippe Normand.
- Scripts/webkitpy/common/system/executive.py:
(Executive.cpu_count): Modify function in order to use the environment
variable $NUMBER_OF_PROCESSORS if it is defined and it is an integer
greater than 0.
- 3:58 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:57 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:54 AM Changeset in webkit [148428] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge r147967 - Bug 110293 uses read -d which is a non-portable bashism
https://bugs.webkit.org/show_bug.cgi?id=113349
Reviewed by Gustavo Noronha Silva.
- Source/autotools/SetupWebKitFeatures.m4: Pass the default feature set to the
feature script in a more portable way.
- 3:50 AM Changeset in webkit [148427] by
-
- 5 edits in trunk
[BlackBerry] ASSERT in StyleResolver::ensureScopeResolver()
https://bugs.webkit.org/show_bug.cgi?id=114615
Patch by Xan Lopez <xlopez@igalia.com> on 2013-04-15
Reviewed by Carlos Garcia Campos.
Source/WebKit/blackberry:
Add a method to enable the style scoped feature to our
DumpRenderTreeSupport class.
- WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::setStyleScopedEnabled):
- WebKitSupport/DumpRenderTreeSupport.h:
(DumpRenderTreeSupport):
Tools:
Enable the style scoped feature if we have support for it.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
- 3:36 AM Changeset in webkit [148426] by
-
- 3 edits in trunk/LayoutTests
[EFL] Unskip some inspector tests related to styles
https://bugs.webkit.org/show_bug.cgi?id=114609
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
- platform/efl-wk2/TestExpectations: Old issues. Fixed on the latest codebase.
- platform/efl/TestExpectations: Fixed by r128637.
- 3:35 AM QtWebKitGardening edited by
- Rename sheriffbot to webkitbot (diff)
- 3:33 AM CommitterTips edited by
- Rename sheriffbot to webkitbot (diff)
- 3:11 AM Changeset in webkit [148425] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Filesystem callback notifyCreateSnapshotFileAndReadMetadata can be called on the wring thread
https://bugs.webkit.org/show_bug.cgi?id=114610
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-15
Reviewed by Xan Lopez.
Override notifyCreateSnapshotFileAndReadMetadata to make sure the
callback is called on the right thread.
Fixes a crash in several fast/filesystem test in debug builds.
- platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.cpp:
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateSnapshotFileAndReadMetadata):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateSnapshotFileAndReadMetadataOnWorkerThread):
- platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.h:
- 2:31 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:28 AM Changeset in webkit [148424] by
-
- 9 edits in releases/WebKitGTK/webkit-2.0
Merge r147499 - [GTK] Make libsecret optional
https://bugs.webkit.org/show_bug.cgi?id=113821
Reviewed by Gustavo Noronha Silva.
.:
Add a configuration option to disable credential storage and thus remove
the libsecret dependency. This should make it possible to build WebKit 2.x
on Windows again.
- Source/autotools/FindDependencies.m4: Only look for libsecret if credential storage is active.
- Source/autotools/PrintBuildConfiguration.m4: Print whether or not credential storage is active.
- Source/autotools/ReadCommandLineArguments.m4: Added an option to control credential storage.
- Source/autotools/SetupAutoconfHeader.m4: Expose credential storage setting to code.
Source/WebCore:
Don't try to use libsecret if credential storage is disabled.
- platform/gtk/GRefPtrGtk.cpp: Protect libsecret sections.
- platform/gtk/GRefPtrGtk.h: Ditto.
- platform/network/gtk/CredentialBackingStore.cpp: Ditto.
- 2:18 AM Changeset in webkit [148423] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry][CSS Filters] Non-image content disappears when filter applied
https://bugs.webkit.org/show_bug.cgi?id=114498
Reviewed by Carlos Garcia Campos.
Applying a filter to a div with simple text content caused the div to
disappear.
In https://bugs.webkit.org/show_bug.cgi?id=114276, we added some GL
state save/restore code for vertex attributes to make sure the state
changes done by BlackBerry::Platform::Graphics don't interfere with
GL code executing in WebKit. However, saving and restoring vertex
attribute state won't do much good if those attributes were never
enabled to begin with. Fixed by enabling vertex attributes
appropriately when setting them, so that state can be saved and
restored.
All the CSS Filters layout tests apply the filters to simple rectangles
or images, there's nothing sufficiently complex that we manage to
trigger this GL state conflict in the BlackBerry port. This suggests
adding a new platform-specific layout test would be appropriate, but
since we don't use pixel tests yet, such a test would not help detect
regressions. Ultimately we decided against adding a layout test for
this bug at this time.
- platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRenderer::applyActions):
- 2:16 AM Changeset in webkit [148422] by
-
- 2 edits in trunk/Tools
[Qt] QtMultimedia not used when GStreamer is not found
https://bugs.webkit.org/show_bug.cgi?id=111842
Reviewed by Philippe Normand.
Fallback to using QtMultimedia when native libraries are not found.
- qmake/mkspecs/features/features.prf:
- 2:11 AM Changeset in webkit [148421] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
spelling-with-whitespace-selection.html passes after r148282.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 2:02 AM Changeset in webkit [148420] by
-
- 10 edits in trunk/Source/WebKit2
[WK2] Add new callbacks and a function for WebKit2 context menu API
https://bugs.webkit.org/show_bug.cgi?id=111552
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-04-15
Reviewed by Anders Carlsson.
Add contextMenuHide and contextMenuShow callbacks to WKPageContextMenuClient
and WKPageContextMenuSelected API so context menus can be handled outside
WebKit. API version of this client was bumped so older client version still
can be used
- Shared/APIClientTraits.cpp:
(WebKit):
- Shared/APIClientTraits.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSelectContextMenuItem):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/gtk/WebKitContextMenuClient.cpp:
(attachContextMenuClientToView):
- UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
(WebKit::WebPageContextMenuClient::showContextMenu):
(WebKit):
(WebKit::WebPageContextMenuClient::hideContextMenu):
- UIProcess/WebPageContextMenuClient.h:
(WebPageContextMenuClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::internalShowContextMenu):
- UIProcess/efl/ContextMenuClientEfl.cpp:
(ContextMenuClientEfl::ContextMenuClientEfl):
- 1:20 AM Changeset in webkit [148419] by
-
- 2 edits in trunk/LayoutTests
[EFL] inspector/styles/styles-history.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=98777
Unreviewed gardening.
Unskip inspector/styles/styles-history.html as it was fixed by r131895.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
- platform/efl/TestExpectations:
- 12:27 AM Changeset in webkit [148418] by
-
- 1 edit1 delete in trunk/LayoutTests
[EFL] Remove inspector/styles/paste-property-expected.txt from efl-wk2
https://bugs.webkit.org/show_bug.cgi?id=114604
Unreviewed gardening.
Remove an improper file after r147420.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
- platform/efl-wk2/inspector/styles/paste-property-expected.txt: Removed.
- 12:06 AM Changeset in webkit [148417] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/js/global-constructors.html for EFL port due to
addition of MutationRecordConstructor.
- platform/efl/fast/js/global-constructors-expected.txt:
Apr 14, 2013:
- 11:58 PM Changeset in webkit [148416] by
-
- 14 edits6 deletes in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline several SVG tests for EFL port.
- platform/efl-wk2/svg/css/group-with-shadow-expected.png:
- platform/efl-wk2/svg/filters/shadow-on-rect-with-filter-expected.png:
- platform/efl/svg/css/arrow-with-shadow-expected.png:
- platform/efl/svg/css/arrow-with-shadow-expected.txt: Removed.
- platform/efl/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
- platform/efl/svg/css/clippath-with-shadow-expected.txt: Removed.
- platform/efl/svg/css/composite-shadow-example-expected.png:
- platform/efl/svg/css/composite-shadow-example-expected.txt:
- platform/efl/svg/css/composite-shadow-with-opacity-expected.png:
- platform/efl/svg/css/composite-shadow-with-opacity-expected.txt:
- platform/efl/svg/css/group-with-shadow-expected.txt:
- platform/efl/svg/css/path-with-shadow-expected.txt:
- platform/efl/svg/css/shadow-and-opacity-expected.txt:
- platform/efl/svg/css/shadow-with-large-radius-expected.txt: Removed.
- platform/efl/svg/css/shadow-with-negative-offset-expected.txt: Removed.
- platform/efl/svg/css/text-gradient-shadow-expected.txt:
- platform/efl/svg/css/text-shadow-multiple-expected.txt:
- platform/efl/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
- platform/efl/transitions/svg-text-shadow-transition-expected.txt:
- 8:13 PM CommitterTips edited by
- Clarify that "Unreviewed" should be present if no "Reviewed by" is present. (diff)
- 7:22 PM Changeset in webkit [148415] by
-
- 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore
Revert "Attempt to fix Windows build after r148370"
This reverts commit r148375.
- runtime/JSStringJoiner.h: Remove include of
<wtf/CheckedArithmetic.h>.
- 6:29 PM Changeset in webkit [148414] by
-
- 12 edits in trunk
[css3-text] Parsing -webkit-hanging value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=113680
Source/WebCore:
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-14
Reviewed by Andreas Kling.
This patch is the parsing part to support hanging value for text-indent.
"hanging" means "Inverts which lines are affected."
It's prefixed and guarded by CSS3_TEXT flag.
No new tests, this patch updates existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseTextIndent): Parsed "-webkit-hanging" with "-webkit-each-line".
- css/CSSValueKeywords.in: Added "-webkit-hanging" keyword.
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyTextIndent::applyInheritValue):
(WebCore::ApplyPropertyTextIndent::applyInitialValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h: Added enum TextIndentType.
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h: Added m_textIndentType.
(StyleRareInheritedData):
Added the usual getter / setter / initial methods for m_textIndentType.
LayoutTests:
"hanging" is added for text-indent in CSS3.
http://dev.w3.org/csswg/css3-text/#hanging
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-14
Reviewed by Andreas Kling.
- fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt:
- fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js:
(valueSettingTest):
- 4:32 PM Changeset in webkit [148413] by
-
- 9 edits2 adds in trunk/Source
Move Mac specific snapshotting code into its own file
https://bugs.webkit.org/show_bug.cgi?id=114597
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm:
(-[DOMRange renderedImageForcingBlackText:]):
- page/Frame.h:
- page/mac/FrameMac.mm:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
- page/mac/FrameSnapshottingMac.h: Added.
- page/mac/FrameSnapshottingMac.mm: Added.
(WebCore::imageFromRect):
(WebCore::selectionImage):
(WebCore::rangeImage):
(WebCore::snapshotDragImage):
- platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::dragNSImage):
Move the four Mac specific snapshotting functions in Frame.h into FrameSnapshottingMac.h/mm and turn
them into free standing functions.
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _selectionDraggingImage]):
(-[WebHTMLView selectionImageForcingBlackText:]):
- 2:50 PM Changeset in webkit [148412] by
-
- 2 edits in trunk/LayoutTests
Re-skip editing/spelling/spelling-changed-text.html on Mac/WK1.
- platform/mac/TestExpectations:
- 2:13 PM Changeset in webkit [148411] by
-
- 2 edits in trunk/Source/WebCore
Hawtfix Mac build.
- WebCore.exp.in:
- 1:32 PM Changeset in webkit [148410] by
-
- 5 edits in trunk/Source/WebCore
Only MutableStylePropertySets should be able to have CSSOM wrappers.
<http://webkit.org/b/114595>
Reviewed by Antti Koivisto.
Tighten typing so that only MutableStylePropertySets can have CSSOM wrappers associated.
This allows us to get rid of the out-of-line base class destructor.
- WebCore.exp.in:
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::~MutableStylePropertySet):
(WebCore::MutableStylePropertySet::cssStyleDeclaration):
(WebCore::MutableStylePropertySet::ensureInlineCSSStyleDeclaration):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- dom/StyledElement.cpp:
(WebCore::StyledElement::inlineStyleCSSOMWrapper):
- 1:05 PM Changeset in webkit [148409] by
-
- 4 edits in branches/safari-536.30-branch/Source/WTF
Try to fix Windows Elgar build again after r148370
Merge r148401.
Add EnumClass.h to the MSVC project.
2013-04-14 David Kilzer <ddkilzer@apple.com>
Add EnumClass.h to project files
<http://webkit.org/b/114582>
Rubber-stamped by Dan Bernstein.
- WTF.pro: Add EnumClass.h to project.
- WTF.vcproj/WTF.vcproj: Ditto.
- WTF.vcxproj/WTF.vcxproj: Ditto.
- WTF.vcxproj/WTF.vcxproj.filters: Ditto.
- WTF.xcodeproj/project.pbxproj: Ditto.
- 12:19 PM Changeset in webkit [148408] by
-
- 2 edits in trunk/Source/WebCore
Remove unused function declaration StylePropertySet::setNeedsStyleRecalc().
Rubber-stamped by Antti Koivisto.
- css/StylePropertySet.h:
(StylePropertySet):
- 12:17 PM Changeset in webkit [148407] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Regression(r148274): Broke rendering in the browser
https://bugs.webkit.org/show_bug.cgi?id=114593
Reviewed by Anders Carlsson.
r148274 added a new "didChangeViewportAttributes" callback to
WKView but did not hook it up in ViewClientEfl. This patch
fixes this and makes rendering work again in the browser.
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::ViewClientEfl):
- 12:09 PM Changeset in webkit [148406] by
-
- 3 edits in trunk/Source/WebCore
Move StylePropertySet internal storage access helpers to subclass.
<http://webkit.org/b/114592>
Reviewed by Antti Koivisto.
Removed mutablePropertyVector() since most call sites are inside MutableStylePropertySet
and can access m_propertyVector directly. The few ones that aren't can just cast.
For ImmutableStylePropertySet, moved value/metadata array accessors to the subclass
and remove "immutable" from their names.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::immutableCopyIfNeeded):
(WebCore::ImmutableStylePropertySet::ImmutableStylePropertySet):
(WebCore::ImmutableStylePropertySet::~ImmutableStylePropertySet):
(WebCore::MutableStylePropertySet::MutableStylePropertySet):
(WebCore::MutableStylePropertySet::removeProperty):
(WebCore::MutableStylePropertySet::removePrefixedOrUnprefixedProperty):
(WebCore::MutableStylePropertySet::setProperty):
(WebCore::MutableStylePropertySet::appendPrefixingVariantProperty):
(WebCore::MutableStylePropertySet::parseDeclaration):
(WebCore::MutableStylePropertySet::addParsedProperties):
(WebCore::MutableStylePropertySet::clear):
(WebCore::MutableStylePropertySet::removePropertiesInSet):
(WebCore::MutableStylePropertySet::findCSSPropertyWithID):
(WebCore::MutableStylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::reportMemoryUsage):
- css/StylePropertySet.h:
(PropertyReference):
(StylePropertySet):
(ImmutableStylePropertySet):
(WebCore::ImmutableStylePropertySet::valueArray):
(WebCore::ImmutableStylePropertySet::metadataArray):
(WebCore::StylePropertySet::PropertyReference::propertyMetadata):
(WebCore::StylePropertySet::PropertyReference::propertyValue):
(WebCore::StylePropertySet::propertyCount):
- 11:25 AM Changeset in webkit [148405] by
-
- 2 edits in trunk/Source/WTF
Try to fix non-apple windows builds
- 10:56 AM Changeset in webkit [148404] by
-
- 2 edits in trunk/Source/WebCore
Specialize propertyCount() in StylePropertySet subclasses.
<http://webkit.org/b/114590>
Reviewed by Antti Koivisto.
Avoid branching on m_isMutable in code that already knows which type of set it is.
- css/StylePropertySet.h:
(WebCore::ImmutableStylePropertySet::propertyCount):
(ImmutableStylePropertySet):
(WebCore::MutableStylePropertySet::propertyCount):
(MutableStylePropertySet):
- 10:49 AM Changeset in webkit [148403] by
-
- 9 edits in trunk/Source/WebCore
Move property setting/removing functions to MutableStylePropertySet.
<http://webkit.org/b/114589>
Reviewed by Antti Koivisto.
Move all functions for setting/removing properties from StylePropertySet to MutableStylePropertySet.
Had to change SVGElement::animatedSMILStyleProperties() & friends to hand out MutableStylePropertySet*
which was always the internal type anyway.
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::removeShorthandProperty):
(WebCore::MutableStylePropertySet::removeProperty):
(WebCore::MutableStylePropertySet::removePrefixedOrUnprefixedProperty):
(WebCore::MutableStylePropertySet::setProperty):
(WebCore::MutableStylePropertySet::appendPrefixingVariantProperty):
(WebCore::MutableStylePropertySet::setPrefixingVariantProperty):
(WebCore::MutableStylePropertySet::mergeAndOverrideOnConflict):
(WebCore::MutableStylePropertySet::removeBlockProperties):
(WebCore::MutableStylePropertySet::removePropertiesInSet):
(WebCore::MutableStylePropertySet::findCSSPropertyWithID):
(WebCore::MutableStylePropertySet::removeEquivalentProperties):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::removePropertiesInStyle):
(WebCore::reconcileTextDecorationProperties):
- svg/SVGAnimateElement.cpp:
(WebCore::applyCSSPropertyToTarget):
- svg/SVGElement.cpp:
(WebCore::SVGElement::animatedSMILStyleProperties):
(WebCore::SVGElement::ensureAnimatedSMILStyleProperties):
- svg/SVGElement.h:
(SVGElement):
- svg/SVGElementRareData.h:
(WebCore::SVGElementRareData::animatedSMILStyleProperties):
(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):
(SVGElementRareData):
- 10:33 AM Changeset in webkit [148402] by
-
- 5 edits in trunk/Source/WebCore
EditingStyle should have a MutableStylePropertySet internally.
<http://webkit.org/b/114588>
Reviewed by Anders Carlsson.
Switch EditingStyle::m_mutableStyle to a RefPtr<MutableStylePropertySet>.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::copyBlockProperties):
- css/StylePropertySet.h:
(StylePropertySet):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::setStyle):
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::StyleChange::StyleChange):
(WebCore::setTextDecorationProperty):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
(WebCore::getPropertiesNotIn):
- editing/EditingStyle.h:
(WebCore::EditingStyle::style):
(EditingStyle):
(StyleChange):
- 9:49 AM Changeset in webkit [148401] by
-
- 6 edits in trunk/Source/WTF
Add EnumClass.h to project files
<http://webkit.org/b/114582>
Rubber-stamped by Dan Bernstein.
- WTF.pro: Add EnumClass.h to project.
- WTF.vcproj/WTF.vcproj: Ditto.
- WTF.vcxproj/WTF.vcxproj: Ditto.
- WTF.vcxproj/WTF.vcxproj.filters: Ditto.
- WTF.xcodeproj/project.pbxproj: Ditto.
- 9:43 AM Changeset in webkit [148400] by
-
- 6 edits in trunk/Source/WebCore
Move addParsedProperty/addParsedProperties to MutableStylePropertySet.
<http://webkit.org/b/114587>
Reviewed by Antti Koivisto.
All CSSParser methods that mutate an existing StylePropertySet now take a MutableStylePropertySet*
instead of a StylePropertySet*.
- css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::parseKeywordValue):
(WebCore::parseTranslateTransformValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):
- css/CSSParser.h:
(CSSParser):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::setProperty):
(WebCore::MutableStylePropertySet::addParsedProperties):
(WebCore::MutableStylePropertySet::addParsedProperty):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- css/ViewportStyleResolver.h:
(ViewportStyleResolver):
- 9:21 AM Changeset in webkit [148399] by
-
- 3 edits in trunk/Source/WebCore
CSSParser should return ImmutableStylePropertySets.
<http://webkit.org/b/114585>
Reviewed by Anders Carlsson.
The StylePropertySets created by CSSParser were already immutable.
Let this be reflected in the pointer types returned.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseInlineStyleDeclaration):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::createStylePropertySet):
- css/CSSParser.h:
(CSSParser):
- 9:14 AM Changeset in webkit [148398] by
-
- 4 edits in trunk/Source/WebCore
Move StylePropertySet::createImmutable() to ImmutableStylePropertySet.
<http://webkit.org/b/114584>
Reviewed by Anders Carlsson.
StylePropertySet::createImmutable() -> ImmutableStylePropertySet::create()
Also, immutableCopyIfNeeded() now returns a PassRefPtr<ImmutableStylePropertySet>.
- css/CSSParser.cpp:
(WebCore::CSSParser::createStylePropertySet):
- css/StylePropertySet.cpp:
(WebCore::ImmutableStylePropertySet::create):
(WebCore::StylePropertySet::immutableCopyIfNeeded):
- css/StylePropertySet.h:
(StylePropertySet):
(ImmutableStylePropertySet):
- 8:46 AM Changeset in webkit [148397] by
-
- 5 edits in trunk/Source/WebCore
Move parseDeclaration() and clear() to MutableStylePropertySet.
<http://webkit.org/b/114583>
Reviewed by Anders Carlsson.
...and remove ASSERT(isMutable()) from the function bodies.
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::removedFrom):
Use clear() directly instead of taking an empty string through the CSS parser.
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::parseDeclaration):
(WebCore::MutableStylePropertySet::clear):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleFromString):
- 8:19 AM Changeset in webkit [148396] by
-
- 23 edits in trunk/Source
Move CSSOM classes to using MutableStylePropertySet over StylePropertySet.
<http://webkit.org/b/114581>
Reviewed by Anders Carlsson.
Source/WebCore:
Moved ensureCSSStyleDeclaration() and ensureInlineCSSStyleDeclaration() from StylePropertySet
to MutableStylePropertySet.
StyleRule & co now return a MutableStylePropertySet* from mutableProperties() to aid with...
CSSStyleDeclaration now only deals with MutableStylePropertySets. This was already the case
in practice, we just didn't have any compile-time foot-shooting protection.
In other words, if there's a CSSOM wrapper for a given StylePropertySet, it's guaranteed to
be mutable, and the pointer types now reflect this.
- WebCore.exp.in:
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::StyleRuleCSSStyleDeclaration::StyleRuleCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::reattach):
- css/PropertySetCSSStyleDeclaration.h:
(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(PropertySetCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::create):
(StyleRuleCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::ensureCSSStyleDeclaration):
(WebCore::MutableStylePropertySet::ensureInlineCSSStyleDeclaration):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- css/StyleRule.cpp:
(WebCore::StyleRule::mutableProperties):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::mutableProperties):
(WebCore::StyleRuleViewport::mutableProperties):
(WebCore::StyleRuleFilter::mutableProperties):
- css/StyleRule.h:
(StyleRule):
(StyleRuleFontFace):
(StyleRulePage):
(StyleRuleViewport):
(StyleRuleFilter):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::mutableProperties):
- css/WebKitCSSKeyframeRule.h:
(StyleKeyframe):
- dom/Attr.cpp:
(WebCore::Attr::style):
- dom/Attr.h:
(Attr):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::copyTypingStyle):
- editing/FrameSelection.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
Source/WebKit/gtk:
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::shouldApplyStyle):
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldApplyStyle):
- WebView/WebFrame.mm:
(-[WebFrame _typingStyle]):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::shouldApplyStyle):
- 7:24 AM Changeset in webkit [148395] by
-
- 24 edits in trunk/Source/WebCore
Move create() methods from StylePropertySet to MutableStylePropertySet.
<http://webkit.org/b/114574>
Reviewed by Antti Koivisto.
Move the two create() methods that create MutableStylePropertySets from StylePropertySet
to MutableStylePropertySet, and make them actually return MutableStylePropertySets.
Switch to using {Pass,}RefPtr<MutableStylePropertySet> where appropriate to keep things building.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFaceValue):
- css/DOMWindowCSS.cpp:
(WebCore::DOMWindowCSS::supports):
- css/ElementRuleCollector.cpp:
(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
- css/FontLoader.cpp:
(WebCore::FontLoader::resolveFontStyle):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::copyPropertiesInSet):
(WebCore::MutableStylePropertySet::create):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::resolveVariables):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- dom/Attr.cpp:
(WebCore::Attr::style):
- dom/Document.cpp:
(WebCore::Document::createCSSStyleDeclaration):
- dom/StyledElement.cpp:
(WebCore::StyledElement::ensureMutableInlineStyle):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
- editing/ApplyStyleCommand.cpp:
(WebCore::copyStyleOrCreateEmpty):
- editing/EditingStyle.cpp:
(WebCore::editingStyleFromComputedStyle):
(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::EditingStyle::setProperty):
(WebCore::EditingStyle::extractAndRemoveTextDirection):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::forceInline):
- editing/Editor.cpp:
(WebCore::Editor::setBaseWritingDirection):
- editing/EditorCommand.cpp:
(WebCore::executeApplyStyle):
(WebCore::executeToggleStyleInList):
(WebCore::executeApplyParagraphStyle):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):
- html/HTMLTableElement.cpp:
(WebCore::leakBorderStyle):
(WebCore::HTMLTableElement::createSharedCellStyle):
(WebCore::leakGroupBorderStyle):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
- page/DragController.cpp:
(WebCore::DragController::concludeEditDrag):
- svg/SVGElementRareData.h:
(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):
- 5:37 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:35 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:34 AM Changeset in webkit [148394] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge r148293 - [GTK] Lower the pango dependency
https://bugs.webkit.org/show_bug.cgi?id=114520
Reviewed by Carlos Garcia Campos.
- Source/autotools/Versions.m4: Only depend on Pango 1.30.0 instead of
Pango 1.32.0. 1.32.0 isn't strictly necessary and the version of GTK+ that
we depend on (3.6.0) depends on 1.30.0.
- 5:33 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:32 AM Changeset in webkit [148393] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r147946 - [GTK] Bump gnome-themes-standard to 3.6.0
https://bugs.webkit.org/show_bug.cgi?id=114155
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-08
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
dependency of gnome-themes-standard accordingly.
- 5:32 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:31 AM Changeset in webkit [148392] by
-
- 2 edits1 add in releases/WebKitGTK/webkit-2.0/Tools
Merge r148110 - [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
https://bugs.webkit.org/show_bug.cgi?id=114365
Reviewed by Martin Robinson.
Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
The patch addresses crashes in the tally_event_reply method. It is already committed into the
at-spi2-atk source tree and will be available with the next stable release, after which the
patch should be removed and the dependency version bumped.
- gtk/jhbuild.modules:
- gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
- 5:29 AM Changeset in webkit [148391] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r147574 - [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
https://bugs.webkit.org/show_bug.cgi?id=113883
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
- 5:27 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:24 AM Changeset in webkit [148390] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r147547 - [GTK] Bump required versions of some dependencies
https://bugs.webkit.org/show_bug.cgi?id=113282
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-03
Reviewed by Martin Robinson.
.:
This patch updates the following dependencies:
- libsoup 2.42.0: is the current stable release.
- glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
- gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
- at-spi2 2.5.3: is the version required by gtk+ 3.6.
- GObject introspection 1.32.0: is the version required by gtk+ 3.6.
- Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
- Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
- gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
- Source/autotools/Versions.m4:
Tools:
- gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
- 5:23 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:19 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:18 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:17 AM Changeset in webkit [148389] by
-
- 4 edits15 deletes in releases/WebKitGTK/webkit-2.0
Merge r147963 - [WIN] Remove WebKit2 source code
https://bugs.webkit.org/show_bug.cgi?id=114096
Reviewed by Anders Carlsson.
Source/WebKit2:
Remove conditional includes for the windows platform.
- Shared/API/c/WKBase.h:
- UIProcess/API/C/WKAPICast.h:
Tools:
Remove the windows specific parts of the MiniBrowser.
- MiniBrowser/MiniBrowser.vcproj: Removed.
- MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
- MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
- MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
- MiniBrowser/win/BrowserView.cpp: Removed.
- MiniBrowser/win/BrowserView.h: Removed.
- MiniBrowser/win/BrowserWindow.cpp: Removed.
- MiniBrowser/win/BrowserWindow.h: Removed.
- MiniBrowser/win/MiniBrowser.cpp: Removed.
- MiniBrowser/win/MiniBrowser.h: Removed.
- MiniBrowser/win/MiniBrowser.rc: Removed.
- MiniBrowser/win/main.cpp: Removed.
- MiniBrowser/win/resource.h: Removed.
- MiniBrowser/win/stdafx.cpp: Removed.
- MiniBrowser/win/stdafx.h: Removed.
- 5:15 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:15 AM Changeset in webkit [148388] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r148230 - [GTK] Windows build failure after r136056
https://bugs.webkit.org/show_bug.cgi?id=114121
Patch by Kalev Lember <kalevlember@gmail.com> on 2013-04-11
Reviewed by Martin Robinson.
- TestWebKitAPI/config.h: Make sure defines are correct for other
Windows ports than apple-win.
- 5:14 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:13 AM Changeset in webkit [148387] by
-
- 1 edit1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147814 - Translation of WebKitGTK+ for Malayalam (ml)
https://bugs.webkit.org/show_bug.cgi?id=113280
Patch by Ani Peter <peter.ani@gmail.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
- ml.po: Added.
- 5:11 AM Changeset in webkit [148386] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147812 - webkit translations for gujarati
https://bugs.webkit.org/show_bug.cgi?id=113190
Patch by Sweta Kothari <swkothar@redhat.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
- gu.po:
- 4:36 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:33 AM Changeset in webkit [148385] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147811 - [l10n] [hi] Updated WebKit Translation in Hindi [hi] language
https://bugs.webkit.org/show_bug.cgi?id=113180
Patch by Rajesh Ranjan <rajeshkajha@yahoo.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
- hi.po:
- 4:28 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:26 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:25 AM Changeset in webkit [148384] by
-
- 1 edit1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147015 - Tamil translation for Gnome 3.6
https://bugs.webkit.org/show_bug.cgi?id=96995
Patch by Shantha kumar <shkumar@redhat.com> on 2013-03-27
Reviewed by Gustavo Noronha Silva (kov).
- ta.po: Added.
- 4:24 AM Changeset in webkit [148383] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147003 - Updated Slovenian translation
https://bugs.webkit.org/show_bug.cgi?id=113151
Patch by Matej Urbančič <mateju@svn.gnome.org> on 2013-03-27
Reviewed by Gustavo Noronha Silva (kov).
- sl.po: translation update.
- 4:05 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:01 AM Changeset in webkit [148382] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r148286 - [GTK] Web Process crash when the UI process finishes too early
https://bugs.webkit.org/show_bug.cgi?id=112729
Reviewed by Anders Carlsson.
The problem is when creating the GSocket in the WorkQeue for the
socket descriptor. GLib considers a programmer error to create a
GSocket providing an invalid socket and finishes the process with
g_error(). We are actually providing a valid socket when creating
the GSocket, but it can be invalidated by the worker thread while
the GSocket is being created. This is because
registerEventSourceHandler is called from the main thread and
unregisterEventSourceHandler can be called from the worker
thread. We are currently registering two event handlers, one to
read data from the socket and another one to close the CoreIPC
connection when the socket connection is broken. Every event
source registered uses its own GSocket (even if the file
descriptor is actually the same), so that when the UI process
finishes too early, the first event handler can be executed in the
worker thread, closing the socket descriptor, while the main
thread is creating the GSocket for the second one.
We don't really need to use a separate event handler to monitor
the connection, because GSocket always notifies when condition is
G_IO_HUP and G_IO_ERR even if they haven't been explicitly set in
g_socket_create_source(). We can register socket event sources
differently, providing also a function to be called when the
connection is closed, using a single socket and the same even source.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::open): Register a single socket event
handler providing also a function to be called when the connection
is closed.
- Platform/WorkQueue.h:
(WorkQueue):
- Platform/gtk/WorkQueueGtk.cpp: The EventSource class has been
split, moving everyting specific to socket event source to a
derived class SocketEventSource.
(WorkQueue::EventSource::EventSource):
(WorkQueue::EventSource::performWork):
(WorkQueue::EventSource::performWorkOnce):
(WorkQueue::EventSource::performWorkOnTermination):
(WorkQueue::EventSource::deleteEventSource):
(WorkQueue::EventSource):
(WorkQueue::SocketEventSource):
(WorkQueue::SocketEventSource::SocketEventSource):
(WorkQueue::SocketEventSource::cancel):
(WorkQueue::SocketEventSource::didClose):
(WorkQueue::SocketEventSource::checkCondition):
(WorkQueue::SocketEventSource::eventCallback):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatchOnSource):
- 1:10 AM Changeset in webkit [148381] by
-
- 11 edits in trunk/Source
Source/WebKit/efl: Unreviewed build fix for WebKit1 EFL after r148373 due to missing
header includes.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/EditorClientEfl.cpp:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
- WebCoreSupport/InspectorClientEfl.cpp:
- ewk/ewk_frame.cpp:
- ewk/ewk_view.cpp:
- ewk/ewk_view_private.h:
(WebCore):
Source/WebKit2: Unreviewed build fix for WebKit2 EFL after r148373 due to missing
header includes.
- UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
- UIProcess/efl/InputMethodContextEfl.cpp:
