Timeline
Apr 20, 2013:
- 11:57 PM Changeset in webkit [148809] by
-
- 405 edits21 adds in trunk/LayoutTests/platform/gtk/tables
Unreviewed GTK gardening. Part 1 of updating baselines for tests under the tables directory
after enabling the subpixel layout for the GTK port.
- 11:27 PM Changeset in webkit [148808] by
-
- 205 edits22 adds in trunk/LayoutTests/platform/gtk/svg
Unreviewed GTK gardening. Updating baselines for tests under svg/batik, svg/canvas, svg/carto.net, svg/clip-path,
svg/css, svg/custom and svg/hixie after enabling the subpixel layout.
- 11:23 PM Changeset in webkit [148807] by
-
- 534 edits54 adds in trunk/LayoutTests/platform/gtk/svg
Unreviewed GTK gardening. Updating baselines for tests under svg/W3C-* after enabling the subpixel layout.
- 10:53 PM Changeset in webkit [148806] by
-
- 510 edits84 adds in trunk/LayoutTests/platform/gtk/svg
Unreviewed GTK gardening. Updating baselines for tests under svg/custom, svg/dom, svg/in-html,
svg/overflow, svg/repaint and svg/transforms after enabling the subpixel layout.
- 10:43 PM Changeset in webkit [148805] by
-
- 256 edits156 adds in trunk/LayoutTests/platform/gtk/svg
Unreviewed GTK gardening. Updating baselines for tests under svg/as-*, svg/filters, svg/stroke,
svg/text, svg/wicd and svg/zoom directories after enabling subpixel layout for the GTK port.
Patch #7 of approx. 24,
svn commitis used directly to avoid the webkit-patch and ChangeLog overhead.
- 10:13 PM Changeset in webkit [148804] by
-
- 31 edits2 adds in branches/dfgFourthTier/Source
fourthTier: value profiles and array profiles should be thread-safe enough to be accessible in a concurrent compilation thread
https://bugs.webkit.org/show_bug.cgi?id=114906
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This introduces thread safety to value profiles, array profiles, and
array allocation profiles.
We already have three separate operations that happen on profiles:
(1) writing, which the JIT, LLInt, and OSR exit do; (2) updating,
which happens during GC, from OSR entry slow-paths, and in the DFG;
and (3) reading, which happens in the DFG. For example, the JIT/LLInt
and OSR exit write to ValueProfile::m_buckets, which gets synthesized
into ValueProfile::m_prediction (and other fields) during update, and
the latter gets read by the DFG. Note that (2) must also happen in
the DFG since only the DFG knows which code blocks it will inline,
and those blocks' profiles may not have otherwise been updated via
any other mechanism.
I refer to these three operations as writing, updating, and reading.
Consequently, both profile updating and profile reading may happen
asynchronously, if the JIT is asynchronous.
The locking protocol for profiles works as follows:
- Writing does not require locking, but is only allowed on the main thread. We require that these fields can be stored atomically by the profiling code, even without locks. For value profiles, this only works on 64-bit platforms, currently. For array profiles, which consist of multiple separate fields, this means that an asynchronous update of the profile may see slight inconsistencies (like a structure that doesn't quite match the array modes bits), but these should be harmless: at worst, the DFG will specialize too much and we'll have OSR exits.
- Updating a value profile requires holding a lock, but must assume that the fields written by the profiling code in JIT/LLInt may be written to without locking.
- Reading a value profile requires holding a lock.
The one major exception to these rules is the ArrayAllocationProfile,
which requires no locking. We do this because it's used so often and
in places where we don't necessarily have access to the owning
CodeBlock, so if we did want it to be locked it would have to have
its own lock. Also, I believe that it is sound to just make this
profile racy and not worry about locking at all. All that was needed
were some changes to ensure that we explicitly read some raced-over
fields only once.
Two additional interesting things in this change:
- To make it easy to see which profile methods require locking, they take a const CodeBlockLocker& as an argument. I saw this idiom for identifying which methods require which locks to be held being used in LLVM, and I quite like it.
- Lazy operand value profiles, which are created lazily and at any time, require the CodeBlockLock to be held when they are being created. Writes to them are lockless and main-thread-only, but as with other profiles, updates and reads require locking.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/ArrayAllocationProfile.cpp:
(JSC::ArrayAllocationProfile::updateIndexingType):
- bytecode/ArrayAllocationProfile.h:
(JSC::ArrayAllocationProfile::selectIndexingType):
- bytecode/ArrayProfile.cpp:
(JSC::ArrayProfile::computeUpdatedPrediction):
(JSC::ArrayProfile::briefDescription):
- bytecode/ArrayProfile.h:
(ArrayProfile):
(JSC::ArrayProfile::expectedStructure):
(JSC::ArrayProfile::structureIsPolymorphic):
(JSC::ArrayProfile::hasDefiniteStructure):
(JSC::ArrayProfile::observedArrayModes):
(JSC::ArrayProfile::mayInterceptIndexedAccesses):
(JSC::ArrayProfile::mayStoreToHole):
(JSC::ArrayProfile::outOfBounds):
(JSC::ArrayProfile::usesOriginalArrayStructures):
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpValueProfiling):
(JSC::CodeBlock::dumpArrayProfiling):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::updateAllArrayPredictions):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::updateAllPredictionsAndCheckIfShouldOptimizeNow):
(CodeBlock):
- bytecode/CodeBlockLock.h: Added.
(JSC):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/LazyOperandValueProfile.cpp:
(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):
(JSC::CompressedLazyOperandValueProfileHolder::add):
(JSC::LazyOperandValueProfileParser::LazyOperandValueProfileParser):
(JSC::LazyOperandValueProfileParser::~LazyOperandValueProfileParser):
(JSC):
(JSC::LazyOperandValueProfileParser::initialize):
(JSC::LazyOperandValueProfileParser::prediction):
- bytecode/LazyOperandValueProfile.h:
(CompressedLazyOperandValueProfileHolder):
(LazyOperandValueProfileParser):
- bytecode/MethodOfGettingAValueProfile.cpp:
(JSC::MethodOfGettingAValueProfile::getSpecFailBucket):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- bytecode/ResolveGlobalStatus.cpp:
(JSC::ResolveGlobalStatus::computeFor):
- bytecode/ValueProfile.h:
(JSC::ValueProfileBase::briefDescription):
(ValueProfileBase):
(JSC::ValueProfileBase::computeUpdatedPrediction):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::fromObserved):
- dfg/DFGArrayMode.h:
(ArrayMode):
(JSC::DFG::ArrayMode::withProfile):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGOSRExitPreparation.cpp:
(JSC::DFG::prepareCodeOriginForOSRExit):
- dfg/DFGPredictionInjectionPhase.cpp:
(JSC::DFG::PredictionInjectionPhase::run):
- jit/JITInlines.h:
(JSC::JIT::chooseArrayMode):
- jit/JITStubs.cpp:
(JSC::tryCachePutByID):
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::lazyLinkFor):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::setUpCall):
- profiler/ProfilerBytecodeSequence.cpp:
(JSC::Profiler::BytecodeSequence::BytecodeSequence):
- runtime/JSScope.cpp:
(JSC::JSScope::resolveContainingScopeInternal):
(JSC::JSScope::resolvePut):
Source/WTF:
Reviewed by Oliver Hunt.
Add ability to abstract whether or not the CodeBlock requires locking at all,
since some platforms may not support the byte spin-locking and/or may not want
to, if they turn off concurrent JIT.
- WTF.xcodeproj/project.pbxproj:
- wtf/ByteSpinLock.h:
- wtf/NoLock.h: Added.
(WTF):
(NoLock):
(WTF::NoLock::lock):
(WTF::NoLock::unlock):
(WTF::NoLock::isHeld):
- wtf/Platform.h:
- 9:38 PM Changeset in webkit [148803] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
Unreviewed, 32-bit build fix.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::tallyFrequentExitSites):
- 8:47 PM EFLWebKitBuildBots edited by
- (diff)
- 8:44 PM EFLWebKitBuildBots edited by
- (diff)
- 8:32 PM Changeset in webkit [148802] by
-
- 22 edits1 add in trunk
[Part 5] Parse color value for custom() function parameters
https://bugs.webkit.org/show_bug.cgi?id=114902
Reviewed by Dean Jackson.
Source/WebCore:
Custom filter parameters should support color values. Added parsing
and style resolving bits to support color values. A later patch will
add the color values to the shader program.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-parameters
Modified existing tests to cover changes.
- GNUmakefile.list.am: Added CustomFilterColorParameter to support color values
as custom filter parameters.
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForCustomFilterColorParameter):
(WebCore):
(WebCore::valueForCustomFilterParameter):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseCustomFilterParameters):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::parseCustomFilterColorParameter):
(WebCore):
(WebCore::StyleResolver::parseCustomFilterParameter):
- css/StyleResolver.h:
(StyleResolver):
- platform/graphics/filters/CustomFilterColorParameter.h: Added.
(WebCore):
(WebCore::blendFunc):
(CustomFilterColorParameter):
(WebCore::CustomFilterColorParameter::create):
(WebCore::CustomFilterColorParameter::blend):
(WebCore::CustomFilterColorParameter::color):
(WebCore::CustomFilterColorParameter::setColor):
(WebCore::CustomFilterColorParameter::operator==):
(WebCore::CustomFilterColorParameter::CustomFilterColorParameter):
(WebCore::CustomFilterColorParameter::~CustomFilterColorParameter):
- platform/graphics/filters/CustomFilterParameter.h:
(CustomFilterParameter):
- platform/graphics/filters/CustomFilterRenderer.cpp:
(WebCore::CustomFilterRenderer::bindProgramParameters):
LayoutTests:
Added tests for color parameters on custom fiter function and parameter descriptor.
- css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-invalid.js:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-valid.js:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js:
- 4:25 PM Changeset in webkit [148801] by
-
- 937 edits275 adds in trunk/LayoutTests/platform/gtk/editing
Unreviewed GTK gardening. Updating baselines for editing tests after enabling subpixel layout for the GTK port.
- 4:11 PM Changeset in webkit [148800] by
-
- 549 edits79 adds in trunk/LayoutTests/platform/gtk/css3
Unreviewed GTK gardening. Updating baselines for the remaining tests under the css3 directory
after enabling the subpixel layout for the GTK port.
- 4:03 PM Changeset in webkit [148799] by
-
- 822 edits114 adds in trunk/LayoutTests/platform/gtk/css3/selectors3
Unreviewed GTK gardening. Updating baselines for the css3/selectors/html and css3/selectors/xml tests
after enabling the subpixel layout. Patch #3 of many more.
- 3:51 PM Changeset in webkit [148798] by
-
- 1372 edits104 adds in trunk/LayoutTests/platform/gtk/css2.1
Unreviewed GTK gardening, updating css2.1 baselines after enabling the subpixel layout.
- 1:13 PM Changeset in webkit [148797] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed gardening. Rebaseline after r148792. Fix mac-wk2 text.
- platform/mac-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
- 1:11 PM Changeset in webkit [148796] by
-
- 2 edits in trunk/PerformanceTests/SunSpider
SunSpider/string-tagcloud should be more lenient in validating its results, since they depend on Math.log, which isn't formally specified
https://bugs.webkit.org/show_bug.cgi?id=114895
Reviewed by Michael Saboff.
- tests/sunspider-1.0/string-tagcloud.js:
- 12:55 PM Changeset in webkit [148795] by
-
- 170 edits126 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaseline #1 after enabling the subpixel layout, covering the animations, css1, fonts, fullscreen,
transforms and transitions directories.
- 12:22 PM Changeset in webkit [148794] by
-
- 2 edits1 add in trunk/Tools
[GTK] Fix baseline positioning issue by updating Freetype
https://bugs.webkit.org/show_bug.cgi?id=106775
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: Bump the Freetype Jhbuild dependency to 2.4.11.
- gtk/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added. This is the Freetype
patch (committed as e0469372) that fixes rounding issues for smaller fonts. It is bound to be included
in the 2.4.12 release of Freetype (not released yet) but is provided here as its effect on baselines is
considered positive and will reduce the amout of future rebaselining.
- 12:21 PM Changeset in webkit [148793] by
-
- 2 edits in trunk
Enable sub-pixel layout for the GTK port
https://bugs.webkit.org/show_bug.cgi?id=94792
Reviewed by Martin Robinson.
- Source/autotools/SetupWebKitFeatures.m4: Enable the subpixel layout.
- 12:20 PM Changeset in webkit [148792] by
-
- 6 edits1 copy in trunk/LayoutTests
Unreviewed gardening. Rebaseline after r148791. Update text expectations.
- platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/mac-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Copied from LayoutTests/platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt.
- platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- 9:41 AM Changeset in webkit [148791] by
-
- 4 edits4 adds in trunk
REGRESSION (r147588): Line breaks occur in the middle of Hebrew words at haaertz.co.il and other websites
https://bugs.webkit.org/show_bug.cgi?id=114721
Reviewed by Dean Jackson.
Source/WebCore:
Tests: fast/text/line-break-after-empty-inline-hebrew.html
fast/text/line-break-after-inline-latin1.html
If prior context changes content or length after creating line break iterator, then need to
create new iterator with new prior context instead of using cached iterator with old prior context.
- platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator): Initialize members to cache reference to initialized prior context.
(WebCore::LazyLineBreakIterator::get): Create new iterator if prior context content reference changes.
(WebCore::LazyLineBreakIterator::resetStringAndReleaseIterator): Reset cached prior context references.
(LazyLineBreakIterator): Add members to cache reference to initialized prior context.
LayoutTests:
- fast/text/line-break-after-empty-inline-hebrew-expected.txt: Added.
- fast/text/line-break-after-empty-inline-hebrew.html: Added.
- fast/text/line-break-after-inline-latin1-expected.txt: Added.
- fast/text/line-break-after-inline-latin1.html: Added.
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Rebaseline.
- 3:27 AM Changeset in webkit [148790] by
-
- 8 edits in trunk/Source
LLint should be able to use x87 instead of SSE for floating pointer
https://bugs.webkit.org/show_bug.cgi?id=112239
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Implements LLInt floating point operations in x87, to ensure we support
x86 without SSE2.
X86 (except 64bit) now defaults to using x87 instructions in order to
support all 32bit x86 back to i686. The implementation uses the fucomi
instruction from i686 which sets the new minimum.
The FPU registers must always be empty on entering or exiting a function.
We make sure to only use two X87 registers, and they are always emptied
before calling deeper functions or returning from the LLInt.
- jit/JITStubs.cpp:
(JSC): Empty FPU registers before exiting.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/instructions.rb:
- offlineasm/x86.rb:
Source/WTF:
Disable GTK workaround now that LLInt does not require SSE2.
- wtf/Platform.h:
- 2:53 AM Changeset in webkit [148789] by
-
- 2 edits in trunk
[Qt][Mac] Remove obsolete workaround for debug builds
https://bugs.webkit.org/show_bug.cgi?id=114750
Reviewed by Jocelyn Turcotte.
This workaround made default builds fail with recent Qt5 because
it removed the major version number from the library name, producing
QtWebKitWidgets, whereas the linking command line tried to link
against Qt5WebKitWidgets.
Debug builds are possible with and without framework-enabled builds
of Qt, but the debug versions of the Qt libraries have to be present.
Debug builds with a release version of Qt are not possible on Mac
since for debug builds qmake produces a linker command line where
all the Qt libraries have the "_debug" suffix, therefore if the debug
libraries are missing the build fails.
- Source/widgetsapi.pri:
- 1:23 AM Changeset in webkit [148788] by
-
- 8 edits in trunk
[GTK] Fix unit test webkit2/WebKitFindController/hide
https://bugs.webkit.org/show_bug.cgi?id=89810
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-20
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
The test had some hacks in order to compare a page with highlighted
results after using the find command with the original page. Now it uses
the snapshots API that allows to make the test simpler and more
reliable.
- UIProcess/API/gtk/tests/TestMain.h:
(Test::cairoSurfacesEqual): Moved helper function to compare two cairo
surfaces from TestWebKitWebView.
(Test):
- UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
(testFindControllerHide): Modify test to use snapshots.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSnapshot): Move basic snapshop methods to WebViewTest to
share them with TestWebKitFindController test.
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::WebViewTest): Initialize cairo surface.
(WebViewTest::~WebViewTest): Destroy cairo surface.
(onSnapshotReady): Callback to set the cairo surface when the snapshot
is ready.
(WebViewTest::getSnapshotAndWaitUntilReady): Method that takes a
snapshot and returns the cairo surface when it is ready.
- UIProcess/API/gtk/tests/WebViewTest.h: Add new method headers and
attribute for the cairo surface.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Unskip test webkit2/WebKitFindController/hide.
Apr 19, 2013:
- 9:38 PM Changeset in webkit [148787] by
-
- 4 edits in trunk/Source/WebCore
[EFL] Arrow of combo box are drawn twice
https://bugs.webkit.org/show_bug.cgi?id=113917
Reviewed by Gyuyoung Kim.
combo_button_icon part is for arrow so that images of combo_button part should
not contain arrow.
No new tests required due to no behavioral change.
- platform/efl/DefaultTheme/widget/combo/combo_focus_button.png:
- platform/efl/DefaultTheme/widget/combo/combo_hover_button.png:
- platform/efl/DefaultTheme/widget/combo/combo_press_button.png:
- 6:03 PM Changeset in webkit [148786] by
-
- 3 edits in trunk/LayoutTests
[css exclusions] Fix up shape-inside-recursive-layout test case
https://bugs.webkit.org/show_bug.cgi?id=114890
Reviewed by Dirk Schulze.
The children of the old-flexbox, new-flexbox, and grid shape-inside containers
should have their display value set to -webkit-inline-box, -webkit-inline-flex,
and -webkit-inline-grid respectively. These values should not be set for
the containers themselves, as we are interested in the behavior of descendants
of the shape-inside container.
- fast/exclusions/shape-inside/shape-inside-recursive-layout-expected.html:
- fast/exclusions/shape-inside/shape-inside-recursive-layout.html:
- 6:03 PM Changeset in webkit [148785] by
-
- 38 edits12 copies1 move5 adds in trunk/Source/WebCore
Add interfaces and stubs for audio and video tracks
https://bugs.webkit.org/show_bug.cgi?id=113965
Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-19
Reviewed by Jer Noble.
No new tests because there's no implementations, so there's nothing
interesting to test.
- CMakeLists.txt: Add AudioTrack, VideoTrack, AudioTrackList and VideoTrackList.
- DerivedSources.cpp: Same.
- DerivedSources.make: Same.
- DerivedSources.pri: Same.
- GNUmakefile.list.am: Same.
- Target.pri: Same.
- UseJSC.cmake: Same.
- WebCore.vcproj/WebCore.vcproj: Same.
- WebCore.xcodeproj/project.pbxproj: Same.
- bindings/gobject/GNUmakefile.am: Same.
- bindings/js/JSAudioTrackCustom.cpp: Added, based on JSTestTrackCustom
- bindings/js/JSAudioTrackListCustom.cpp: Same.
- bindings/js/JSBindingsAllInOne.cpp: Add AudioTrack, VideoTrack, AudioTrackList and VideoTrackList.
- bindings/js/JSVideoTrackCustom.cpp: Added, based on JSTestTrackCustom
- bindings/js/JSVideoTrackListCustom.cpp: Same.
- dom/EventTarget.h: Make AudioTrackList and VideoTrackList event targets.
- dom/EventTargetFactory.in: Same.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Add m_audioTracks and m_videoTracks
(WebCore::HTMLMediaElement::~HTMLMediaElement): Clear clients for audio and video tracks
(WebCore::HTMLMediaElement::audioTrackEnabledChanged): Added.
(WebCore::HTMLMediaElement::videoTrackSelectedChanged): Added.
(WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack): Added, based on mediaPlayerDidAddTextTrack
(WebCore::HTMLMediaElement::mediaPlayerDidAddVideoTrack): Same.
(WebCore::HTMLMediaElement::mediaPlayerDidRemoveAudioTrack): Added, based on mediaPlayerDidRemoveTextTrack
(WebCore::HTMLMediaElement::mediaPlayerDidRemoveVideoTrack): Same.
(WebCore::HTMLMediaElement::addAudioTrack): Added, based on addTextTrack
(WebCore::HTMLMediaElement::addVideoTrack): Same.
(WebCore::HTMLMediaElement::removeAudioTrack): Added, based on removeTextTrack
(WebCore::HTMLMediaElement::removeVideoTrack): Added, based on removeTextTrack
(WebCore::HTMLMediaElement::removeAllInbandTracks): Remove audio and video tracks too
(WebCore::HTMLMediaElement::audioTracks): Added, based on textTracks
(WebCore::HTMLMediaElement::videoTracks): Added, based on textTracks
(WebCore::HTMLMediaElement::reportMemoryUsage): Add audio and video tracks
- html/HTMLMediaElement.h: Add audioTracks and videoTracks and related functions
- html/HTMLMediaElement.idl: Add audioTracks and videoTracks
- html/track/AudioTrack.cpp: Added, based on TextTrack and InbandTextTrack.
- html/track/AudioTrack.h: Same.
- html/track/AudioTrack.idl: Added.
- html/track/AudioTrackList.cpp: Added, based on TextTrackList
- html/track/AudioTrackList.h: Same.
- html/track/AudioTrackList.idl: Added.
- html/track/TextTrackList.h: Add missing OVERRIDE on interfaceName()
- html/track/VideoTrack.cpp: Added, based on TextTrack and InbandTextTrack.
- html/track/VideoTrack.h: Same.
- html/track/VideoTrack.idl: Added.
- html/track/VideoTrackList.cpp: Added, based on TextTrackList
- html/track/VideoTrackList.h: Same.
- html/track/VideoTrackList.idl: Added.
- platform/graphics/AudioTrackPrivate.h: Added, based on InbandTextTrackPrivate.h
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::addAudioTrack): Added, based on addTextTrack
(WebCore::MediaPlayer::removeAudioTrack): Added, based on removeTextTrack
(WebCore::MediaPlayer::addVideoTrack): Added, based on addTextTrack
(WebCore::MediaPlayer::removeVideoTrack): Added, based on removeTextTrack
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerDidAddAudioTrack): Added, based on mediaPlayerDidAddTextTrack
(WebCore::MediaPlayerClient::mediaPlayerDidAddVideoTrack): Same
(WebCore::MediaPlayerClient::mediaPlayerDidRemoveAudioTrack): Added, based on mediaPlayerDidRemoveTextTrack
(WebCore::MediaPlayerClient::mediaPlayerDidRemoveVideoTrack): Same
- platform/graphics/VideoTrackPrivate.h: Added, based on InbandTextTrackPrivate.h
- 5:27 PM Changeset in webkit [148784] by
-
- 32 edits in trunk/PerformanceTests/SunSpider
Whenever it is cheap and non-invasive, SunSpider tests should validate their results to ensure that the browser runs them correctly
https://bugs.webkit.org/show_bug.cgi?id=114852
Reviewed by Geoffrey Garen.
This adds low-overhead checking of the results of each SunSpider tests. This is not
meant to be an exhaustive test that everything was executed correctly, but rather a
simple sanity check that will catch glaring mistakes. The philosophy here is that we're
not trying to prevent all forms of cheating, or that we're trying to prove the
browser's correctness. Moreover, these checks are meant to incur minimal overhead;
they currently clock in at <2% slow-down in SunSpider 1.0.
The test expectations were generated using the LLInt on command-line, and I've verified
that Firefox 20, Chrome 26, IE 10, Safari 6, and ToT with all of the JITs agree. Note
that some tests cannot be precisely validated because they use Math functions, which
ECMAScript chooses to not formally specify - those functions like sin() and friends are
allowed to return implementation-dependent results. Also some tests cannot be validated
at all because their behavior is either intentionally random or is timezone-dependent.
But 23 out of 26 tests now have some kind of validation.
I've updated the harnesses to show erroneous runs when displaying results.
- resources/TEMPLATE.html:
- resources/driver-TEMPLATE.html:
- resources/sunspider-analyze-results.js:
(formatResult):
(resultLine):
(printOutput):
- resources/sunspider-compare-results.js:
(.formatMean):
(.resultLine):
(.printOutput):
(sunspiderCompareResults):
- resources/sunspider-standalone-driver.js:
- tests/sunspider-1.0/3d-cube.js:
(Init):
- tests/sunspider-1.0/3d-morph.js:
- tests/sunspider-1.0/3d-raytrace.js:
- tests/sunspider-1.0/access-binary-trees.js:
- tests/sunspider-1.0/access-fannkuch.js:
- tests/sunspider-1.0/access-nbody.js:
- tests/sunspider-1.0/access-nsieve.js:
(sieve):
- tests/sunspider-1.0/bitops-3bit-bits-in-byte.js:
- tests/sunspider-1.0/bitops-bits-in-byte.js:
- tests/sunspider-1.0/bitops-bitwise-and.js:
- tests/sunspider-1.0/bitops-nsieve-bits.js:
- tests/sunspider-1.0/controlflow-recursive.js:
- tests/sunspider-1.0/crypto-aes.js:
- tests/sunspider-1.0/crypto-md5.js:
- tests/sunspider-1.0/crypto-sha1.js:
- tests/sunspider-1.0/date-format-tofte.js:
- tests/sunspider-1.0/date-format-xparb.js:
- tests/sunspider-1.0/math-cordic.js:
- tests/sunspider-1.0/math-partial-sums.js:
(partial):
- tests/sunspider-1.0/math-spectral-norm.js:
- tests/sunspider-1.0/regexp-dna.js:
- tests/sunspider-1.0/string-base64.js:
- tests/sunspider-1.0/string-fasta.js:
(fastaRepeat):
(fastaRandom):
- tests/sunspider-1.0/string-tagcloud.js:
- tests/sunspider-1.0/string-unpack-code.js:
- tests/sunspider-1.0/string-validate-input.js:
- 5:15 PM Changeset in webkit [148783] by
-
- 9 edits5 deletes in trunk/Source/WebKit2
Unreviewed, revert r148782. It was not reviewed by a WebKit2 owner.
- PluginProcess/mac/PluginProcessShim.mm:
- Shared/mac/CookieStorageShim.cpp: Removed.
- Shared/mac/CookieStorageShim.h: Removed.
- Shared/mac/CookieStorageShimLibrary.cpp: Removed.
- Shared/mac/CookieStorageShimLibrary.h: Removed.
- Shared/mac/DYLDInterpose.h: Removed.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- WebProcess/mac/SecItemShimLibrary.mm:
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
- 4:32 PM Changeset in webkit [148782] by
-
- 9 edits3 copies2 adds in trunk/Source/WebKit2
WWDC session videos don’t play at developer.apple.com
https://bugs.webkit.org/show_bug.cgi?id=114858
Reviewed by Eric Carlson.
AVFoundation uses CFNetwork to store and retrieve cookies from the global store.
However, in the case where network access happens in the NetworkProcess, session
cookies are stored in-memory, and are not accessable in the WebProcess. Until such
a time as AVFoundation can provide an API which would allow us to provide cookies
for a specific request, we will interpose the CFNetwork method which they use to
retrieve the cookie string from the cookie store for their pending request.
Duplicate the previous SecItemShim target to a new, WebProcessShim target. This
target includes the SecItemShim functionality, but will add a new shim for cookie
retrieval:
- Shared/mac/CookieStorageShimLibrary.h: Added
(CookieStorageShimCallbacks):
- Shared/mac/CookieStorageShimLibrary.cpp: Added.
(WebKit::ShimProtector::ShimProtector): A simple stack-based counter class.
(WebKit::ShimProtector::~ShimProtector):
(WebKit::ShimProtector::count):
(WebKit::shimCFHTTPCookieStorageCopyRequestHeaderFieldsForURL): Interpose
the CFNetwork call, and pass to the registered callback.
(WebKit::WebKitCookieStorageShimInitialize): Register the callbacks.
Add a helper singleton class which will talk to the shim through the
registered callbacks:
- Shared/mac/CookieStorageShim.h: Added
(WebKit::CookieStorageShim::CookieStorageShim):
- Shared/mac/CookieStorageShim.cpp: Added.
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Pass the request
over to the NetworkProcess.
(WebKit::CookieStorageShim::shared): Simple singleton.
(WebKit::CookieStorageShim::initialize): Call the library initializer.
Initialize the shim only when the WebProcess is delegating network loading
to the NetworkProcess:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Rename the WebProcess's shim from SecItemShim -> WebProcessShim:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions):
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
As the DYLD_INTERPOSE macro is used in multiple files now, put it in its
own header:
- Shared/mac/DYLDInterpose.h: Added.
- PluginProcess/mac/PluginProcessShim.mm:
- WebProcess/mac/SecItemShimLibrary.mm:
Add new files to the project:
- WebKit2.xcodeproj/project.pbxproj:
- 4:28 PM Changeset in webkit [148781] by
-
- 7 edits2 adds in trunk
[CSS Exclusions] Implement empty segments for multiple-segment shape-insides
https://bugs.webkit.org/show_bug.cgi?id=100049
Reviewed by David Hyatt.
Source/WebCore:
Content should not overflow a shape-inside segment, even if that means no content
will be placed in that segment. Overflow may be pushed to outside the shape. This
patch removes the restriction that every line must consume at least some text
input while inside a shape-inside. Content that does not fit is pushed down until
it does, either inside the shape or just below it.
Test: fast/exclusions/shape-inside/shape-inside-empty-segments.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::constructBidiRunsForSegment): Do not include empty segments for
consideration, as the actual BidiRuns construction expects to consume at
least one character.
(WebCore::constructBidiRunsForLine): Ditto.
(WebCore::firstPositiveWidth): Find the first positive word measurement width,
as there may be some empty word break measurements inserted.
(WebCore::adjustLogicalLineTop): Move the current line down, if necessary, to
fit it within the shape inside.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): If nothing fit in the
current segment, find the first available position for the smallest item
at the beginning of the text.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Return an empty segment
for a line that is inside the shape, but has no segments.
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Do not consume
input to meet minimum size requirements if you are inside a shape.
LayoutTests:
Testing that shape-insides do not place content where it will not fit. Also
fixing up some previous tests and expectations.
- fast/exclusions/resources/multi-segment-polygon.js:
(simulateWithText): Enable multi-line shape expectations using arrays.
- fast/exclusions/resources/simple-rectangle.js:
(createRectangleTest): Add overflow: break-word property to tests.
(createRectangleTestResult): Ditto.
- fast/exclusions/shape-inside/shape-inside-empty-expected.html: Adjust results
for tests where content should be pushed down.
- fast/exclusions/shape-inside/shape-inside-empty-segments-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-empty-segments.html: Added.
- fast/exclusions/shape-inside/shape-inside-empty.html: Shapes with height but
no width should still push content down below the shape.
- 4:12 PM Changeset in webkit [148780] by
-
- 9 edits in tags/Safari-537.38.2/Source
Merged r148779. <rdar://problem/13696616>
- 4:03 PM Changeset in webkit [148779] by
-
- 9 edits in trunk/Source
Remove uses of WebKit_Source from AppleWin build in WTF and JavaScriptCore.
- JavaScriptCore.vcxproj/JavaScriptCore.make:
- JavaScriptCore.vcxproj/build-generated-files.sh:
- JavaScriptCore.vcxproj/copy-files.cmd:
- JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
- WTF.vcxproj/WTF.make:
- WTF.vcxproj/copy-files.cmd:
- WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py:
(react_to_vsprops_changes):
(react_to_webkit1_interface_changes):
- 4:03 PM Changeset in webkit [148778] by
-
- 2 edits in trunk/Tools
Build fixes for the flakiness dashboard.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- 3:47 PM Changeset in webkit [148777] by
-
- 2 edits in trunk/Source/WebCore
Add a missing null pointer check after r148759.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
- 3:38 PM Changeset in webkit [148776] by
-
- 4 edits in tags/Safari-537.38.2/Source
Versioning.
- 3:35 PM Changeset in webkit [148775] by
-
- 1 copy in tags/Safari-537.38.2
New Tag.
- 3:16 PM Changeset in webkit [148774] by
-
- 2 edits in trunk/LayoutTests
[Mac] [WK2] Layout Test fast/regions/fixed-pos-elem-in-region.html is flaky on Debug builders
https://bugs.webkit.org/show_bug.cgi?id=114571
- platform/mac-wk2/TestExpectations:
The bots are also seeing image failures flakily, so add that expectation.
- 2:32 PM Changeset in webkit [148773] by
-
- 2 edits in trunk/LayoutTests
[Mac Lion] media/W3C/video/events/event_canplay.html is flakey, sometimes times out
https://bugs.webkit.org/show_bug.cgi?id=114889
- platform/mac-lion/TestExpectations:
Mark it as such.
- 2:17 PM Changeset in webkit [148772] by
-
- 3 edits in trunk/Source/WebCore
Use Vector instead of StringBuilder for CSSPreloadScanner's buffers
https://bugs.webkit.org/show_bug.cgi?id=114794
Reviewed by Ryosuke Niwa.
Cleanup for other String changes.
CSSPreloadScanner only handles UChar, StringBuilder was a little
overkill.
- html/parser/CSSPreloadScanner.cpp:
(WebCore):
(WebCore::ruleEqualIgnoringCase):
(WebCore::CSSPreloadScanner::emitRule):
- html/parser/CSSPreloadScanner.h:
- 2:13 PM Changeset in webkit [148771] by
-
- 2 edits in trunk/Source/WTF
Remove the declaration of MemoryObjectInfo from StringImpl
https://bugs.webkit.org/show_bug.cgi?id=114788
Reviewed by Andreas Kling.
- wtf/text/StringImpl.h: The declaration is an other left over from chromium.
- 2:10 PM Changeset in webkit [148770] by
-
- 2 edits in trunk/Source/WebCore
StyledMarkupAccumulator::appendText() should not allocate an intermediary StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=114847
Reviewed by Geoffrey Garen.
For some reason StyledMarkupAccumulator::appendText() was allocating a separate buffer
for invoking appendStyleNodeOpenTag. This is a bad idea.
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
(WebCore::StyledMarkupAccumulator::appendText):
- 2:06 PM Changeset in webkit [148769] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Support the SourceMap header, X-SourceMap was deprecated
https://bugs.webkit.org/show_bug.cgi?id=114888
Check first for SourceMap, then fallback to X-SourceMap. Leaving in
support for the deprecated header because most tools and articles
online mention that version and have not yet updated.
Reviewed by Timothy Hatcher.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::sourceMapURLForResource):
- 2:06 PM Changeset in webkit [148768] by
-
- 9 edits5 adds in trunk
Web Inspector: Backend should detect sourceMappingURLs in CSS Resources
https://bugs.webkit.org/show_bug.cgi?id=114854
Source/WebCore:
Reviewed by Timothy Hatcher.
Test: http/tests/inspector/network/css-source-mapping-url.html
- inspector/Inspector.json:
- Page.getResourceTree - add sourceMapURL to resource payloads
- Network.loadingFinished and Network.requestServedFromMemoryCache, include extra resource info object with possible sourceMapURL.
- inspector/ContentSearchUtils.h:
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::scriptCommentPattern):
(WebCore::ContentSearchUtils::stylesheetCommentPattern):
(WebCore::ContentSearchUtils::findMagicComment):
(WebCore::ContentSearchUtils::findScriptSourceURL):
(WebCore::ContentSearchUtils::findScriptSourceMapURL):
(WebCore::ContentSearchUtils::findStylesheetSourceMapURL):
Separate Script and Stylesheet regex pattern creation, but
share the search function using the pattern.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
(WebCore::InspectorDebuggerAgent::didParseSource):
Update function names. Check for the SourceMap header before
checking for a sourceMappingURL comment.
- inspector/InspectorPageAgent.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::sourceMapURLForResource):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
Provide the sourceMapURL for Page.getResourceTree.
- inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForExtraResourceInfo):
(WebCore::buildObjectForCachedResource):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
Include ExtraResourceInfo objects in finish loading and
request served from cache.
LayoutTests:
Test a different ways we would expect to see a sourceMapURL for
stylesheet resources.
Reviewed by NOBODY (OOPS!).
- http/tests/inspector/network/css-source-mapping-url-expected.txt: Added.
- http/tests/inspector/network/css-source-mapping-url.html: Added.
- http/tests/inspector/network/resources/source-map-test-style.css: Added.
- http/tests/inspector/network/resources/source-map-test-style.css.map: Added.
- http/tests/inspector/network/resources/source-map-test-style.scss: Added.
- 2:02 PM Changeset in webkit [148767] by
-
- 4 edits in trunk/Source/JavaScriptCore
Rename JSStringJoiner::build() to join()
https://bugs.webkit.org/show_bug.cgi?id=114845
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-19
Reviewed by Geoffrey Garen.
The method name build() came from StringBuilder history. It does not make much
sense on the StringJoiner.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
- runtime/JSStringJoiner.cpp:
(JSC::JSStringJoiner::join):
- runtime/JSStringJoiner.h:
(JSStringJoiner):
- 1:56 PM Changeset in webkit [148766] by
-
- 2 edits in trunk/Source/WTF
Make StringImpl::cost const
https://bugs.webkit.org/show_bug.cgi?id=114790
Reviewed by Andreas Kling.
- wtf/text/StringImpl.h:
(WTF::StringImpl::cost):
- 1:41 PM Changeset in webkit [148765] by
-
- 5 edits in trunk/Source/WebCore
Remove non-overlap testing code in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=85521
Reviewed by Simon Fraser.
m_compositingConsultsOverlap is always true in the current
code. This patch removes this flag, and removes dead code that is
never executed because it was never false.
No new tests, no change in behavior. The cleanup is covered by
existing tests.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
removed if-statement that is always true.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldClipCompositedBounds):
removed if-statement that would never get triggered.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
removed m_compositingConsultsOverlap, and retained the code as if the flag were "true".
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 1:32 PM Changeset in webkit [148764] by
-
- 8 edits in tags/Safari-537.38.1/Source
Merged r148760. <rdar://problem/13696616>
- 1:30 PM Changeset in webkit [148763] by
-
- 4 edits in tags/Safari-537.38.1/Source
Versioning.
- 1:29 PM Changeset in webkit [148762] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Find-on-page should do the scoping again when highlight policy changed
https://bugs.webkit.org/show_bug.cgi?id=114885
Patch by Andy Chen <andchen@blackberry.com> on 2013-04-19
Reviewed by Rob Buis.
PR 195773
Internally reviewed by Mike Fenton.
For find on page, we need to treat it as a new search if highlightAllMatches
changes but the text is not changed.
- WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
- 1:26 PM Changeset in webkit [148761] by
-
- 1 copy in tags/Safari-537.38.1
New Tag.
- 1:14 PM Changeset in webkit [148760] by
-
- 8 edits in trunk/Source
Unreviewed. WebKit_Source is incorrectly set.
- WTF.vcxproj/WTF.make:
- JavaScriptCore.vcxproj/JavaScriptCore.make:
- WebCore.vcxproj/WebCore.make:
- WebKit.vcxproj/WebKit.make:
- 12:58 PM Changeset in webkit [148759] by
-
- 2 edits in trunk/Source/WebCore
Make loops in RenderObject::containingBlock homogeneous in their forms to simplify
https://bugs.webkit.org/show_bug.cgi?id=114853
Reviewed by David Hyatt.
This patch prepares us to avoid computing containing blocks during a depth-first traversal of the render tree.
Extracted inline functions out of RenderBlock::containingBlock to make the code simpler. Also moved the code
to obtain the nearest containing block out of the loop for a relatively positioned inline.
- rendering/RenderObject.cpp:
(WebCore::isNonReplacedInlineInFlowPosition): Extracted.
(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject): Extracted.
(WebCore::isNonRenderBlockInline): Extracted.
(WebCore::RenderObject::containingBlock): Refactored as stated above.
- 12:45 PM Changeset in webkit [148758] by
-
- 2 edits in trunk/Source/WebCore
WebKit should not decode or support PDF favicons
https://bugs.webkit.org/show_bug.cgi?id=114650
<rdar://problem/10133914>
Reviewed by Dan Bernstein.
Drop the image data on the floor if it begins with the PDF magic number.
No other browser I can find on OS X supports PDF favicons (by experimentation),
and we do not properly display them.
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::notifyFinished):
- 12:00 PM Changeset in webkit [148757] by
-
- 9 edits18 deletes in trunk/Source/WebCore
Remove the OpenVG backend
https://bugs.webkit.org/show_bug.cgi?id=114881
Reviewed by Tim Horton.
- platform/graphics/FloatRect.h:
(FloatRect): Remove #ifdefs for OpenVG backend.
- platform/graphics/GraphicsContext.cpp:
(WebCore): Ditto.
- platform/graphics/GraphicsContext.h:
- platform/graphics/NativeImagePtr.h:
(WebCore): Ditto.
- platform/graphics/Path.cpp:
(WebCore): Ditto.
- platform/graphics/Path.h:
- platform/graphics/openvg/EGLDisplayOpenVG.cpp: Removed.
- platform/graphics/openvg/EGLDisplayOpenVG.h: Removed.
- platform/graphics/openvg/EGLUtils.h: Removed.
- platform/graphics/openvg/GraphicsContextOpenVG.cpp: Removed.
- platform/graphics/openvg/ImageOpenVG.cpp: Removed.
- platform/graphics/openvg/PainterOpenVG.cpp: Removed.
- platform/graphics/openvg/PainterOpenVG.h: Removed.
- platform/graphics/openvg/PathOpenVG.cpp: Removed.
- platform/graphics/openvg/PlatformPathOpenVG.h: Removed.
- platform/graphics/openvg/SharedResourceOpenVG.cpp: Removed.
- platform/graphics/openvg/SharedResourceOpenVG.h: Removed.
- platform/graphics/openvg/SurfaceOpenVG.cpp: Removed.
- platform/graphics/openvg/SurfaceOpenVG.h: Removed.
- platform/graphics/openvg/TiledImageOpenVG.cpp: Removed.
- platform/graphics/openvg/TiledImageOpenVG.h: Removed.
- platform/graphics/openvg/VGUtils.cpp: Removed.
- platform/graphics/openvg/VGUtils.h: Removed.
- platform/graphics/transforms/AffineTransform.h:
(AffineTransform): Ditto.
- platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix): Ditto.
- platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Removed.
- 11:12 AM Changeset in webkit [148756] by
-
- 3 edits in trunk/Source/WebKit2
Add JoinExistingSession to the WebContext XPC.
<rdar://problem/13541540> and https://bugs.webkit.org/show_bug.cgi?id=114882
Reviewed by Sam Weinig.
This fixes <keygen> and maybe other things.
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
- 10:55 AM Changeset in webkit [148755] by
-
- 9 edits1 add1 delete in trunk
[GTK] JSCore.gir.in has a few problems
https://bugs.webkit.org/show_bug.cgi?id=114710
Reviewed by Philippe Normand.
.:
- GNUmakefile.am: Move common GIR initialization here from WebKit1.
- configure.ac: Updated to reflect new JSC gir file location.
Source/JavaScriptCore:
- GNUmakefile.am: Add the gobject introspection steps for JavaScriptCore here,
because they are shared between WebKit1 and WebKit2.
- JavaScriptCore.gir.in: Added. Moved from the WebKit1 directory. Now written
as foreign interfaces and referencing the javascriptcoregtk library.
Source/WebKit/gtk:
- GNUmakefile.am: Updated to reflect new name and location of JavaScriptCore-x.0.gir.
- JSCore.gir.in: Removed.
Source/WebKit2:
- GNUmakefile.am: Updated to reflect new location of JavaScriptCore gir file. Share the
same autotools data task as the WebKit1 and JavaScriptCore gir installations.
- 10:25 AM Changeset in webkit [148754] by
-
- 2 edits in trunk/Source/WebCore
ContainerNode::removeChildren should first detach the children then remove them
https://bugs.webkit.org/show_bug.cgi?id=113433
Reviewed by Ryosuke Niwa.
Currently, ContainerNode::removeChildren initially removes the nodes from the DOM tree and then
calls detach() on each of them. This is anti-intuitive and can lead to subtle bugs because the
detached renderers are not backed by a valid DOM tree any more. With the patch, the nodes are first
detached and then removed from the DOM.
The patch also lets the tree in a consistent state after each node removal by clearing the previous
sibling pointer of the node following the one removed.
I haven't found any proof the performance will get worse if the detachment happens when the children
are still in the DOM tree.
Tests: No changed visible functionality.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
- 10:17 AM Changeset in webkit [148753] by
-
- 11 edits2 adds in trunk/Source/WebCore
Refactor transform code in StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=114874
Reviewed by Andreas Kling.
Move transform code frome StyleResolver into own files.
Refactoring, no changes in functionality.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
- css/StyleResolver.h:
- css/TransformFunctions.cpp: Added.
(WebCore):
(WebCore::transformOperationType):
(WebCore::convertToFloatLength):
(WebCore::transformsForValue):
- css/TransformFunctions.h: Added.
(WebCore):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- 10:05 AM May 2013 Meeting edited by
- (diff)
- 10:03 AM Changeset in webkit [148752] by
-
- 7 edits in trunk/Source/WebCore
Rename TextTrackList owner to element for consistency
https://bugs.webkit.org/show_bug.cgi?id=79822
Reviewed by Eric Carlson.
No new tests. Covered by existing tests.
- bindings/js/JSTextTrackListCustom.cpp:
(WebCore::JSTextTrackListOwner::isReachableFromOpaqueRoots):
(WebCore::JSTextTrackList::visitChildren):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
- html/track/TextTrackList.cpp:
(TextTrackList::append):
(TextTrackList::remove):
- html/track/TextTrackList.h:
(WebCore::TextTrackList::create):
- html/track/TrackListBase.cpp:
(TrackListBase::TrackListBase):
(TrackListBase::remove):
- html/track/TrackListBase.h:
(WebCore::TrackListBase::clearElement):
(WebCore::TrackListBase::element):
(TrackListBase):
- 9:40 AM Changeset in webkit [148751] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed Gardening.
- platform/efl/TestExpectations: Adding failure expectations for two tests
which are failing on EFL bots.
- 9:17 AM Changeset in webkit [148750] by
-
- 3 edits in trunk/Source/WebCore
[Mac] ComplexTextController is slow with large numbers of text runs.
<http://webkit.org/b/114875>
<rdar://problem/13337036>
Reviewed by Dan Bernstein.
Instead of iterating over the text runs in indexOfCurrentRun() to figure out the leftmost glyph,
create a lookup table of [run# -> distance in glyphs] at ComplexTextController construction time.
This avoids O(n2) behavior in indexOfCurrentRun().
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::indexOfCurrentRun):
- platform/graphics/mac/ComplexTextController.h:
- 9:03 AM Changeset in webkit [148749] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Minimize calls to GailTextUtil in AtkText implementation
https://bugs.webkit.org/show_bug.cgi?id=114868
Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-04-19
Reviewed by Martin Robinson.
Create a new helper function to concentrate inside of it the calls to
gail_text_util_get_text(), so we can get rid of it later more easily.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetTextForOffset): New helper function.
(webkitAccessibleTextGetTextAfterOffset): Rely on the new function.
(webkitAccessibleTextGetTextAtOffset): Ditto.
(webkitAccessibleTextGetTextBeforeOffset): Ditto.
- 9:01 AM Changeset in webkit [148748] by
-
- 15 edits in trunk/Source
[Texmap] Implementation for pattern compositing
https://bugs.webkit.org/show_bug.cgi?id=109588
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-19
Reviewed by Allan Sandfeld Jensen.
Source/WebCore:
Enable pattern compositing (background images) for CoordinatedGraphics/TextureMapperGL.
Use the existing patternTransform shader uniform, multiplying it by a matrix calculated
using the contentsRect, tileSize and tilePhase.
Covered by existing tests in compositing/patterns.
- platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
Conditionally enable pattern compositing for coordinated graphics.
- platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::TextureMapper):
- platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::setPatternTransform):
(WebCore::TextureMapper::setWrapMode):
(WebCore::TextureMapper::wrapMode):
(WebCore::TextureMapper::patternTransform):
Add wrapMode and patternTransform properties to the TextureMapper state.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
Paint with GL_REPEAT and a pattern transform when needed.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computePatternTransformIfNeeded):
(WebCore):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::setContentsRect):
(WebCore::TextureMapperLayer::setContentsTileSize):
(WebCore::TextureMapperLayer::setContentsTilePhase):
Apply the patternTransform from the tile size/phase.
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::TextureMapperLayer):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::setShouldMapBackingStoreToContentsRect):
(State):
(WebCore::TextureMapperLayer::State::State):
Allow the client to configure whether a layer uses its bounds or its
contents rect to paint the backing store.
This is needed now since layers with background images, unlike layers
with regular images, may have bounds that are greater than the contents
rect.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setContentsTileSize):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::setContentsTilePhase):
(WebCore::CoordinatedGraphicsLayer::setShouldSupportContentsTiling):
(WebCore::GraphicsLayer::supportsContentsTiling):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(CoordinatedGraphicsLayerState):
Logic to pass the tileSize/tilePhase from CoordinatedGraphicsLayer
to TextureMapperLayer.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
Don't reset the layer's image contents when this is a directly composited image.
Source/WebKit2:
Serialize the two new properties from CoordinatedGraphicsLayer to CoordinatedGraphicsScene.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
Encode/decode the new tiling properties.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
Enable pattern compositing for coordinated graphics.
This is needed since we don't want to enable pattern compositing for
WebKit1 yet.
- 8:34 AM Changeset in webkit [148747] by
-
- 2 edits1 delete in trunk/LayoutTests
[EFL] Unreviewed Gardening.
Marking compositing reftests added in r148172 as ImageOnlyFailure.
Also, skip failing tests on EFL bots.
- platform/efl/TestExpectations:
- platform/efl/compositing/geometry/foreground-layer-expected.txt: Removed.
- 8:21 AM Changeset in webkit [148746] by
-
- 2 edits in trunk/LayoutTests
Fix expectations added in r148720.
- fast/js/stack-trace-expected.txt:
- 7:53 AM Changeset in webkit [148745] by
-
- 3 edits in trunk/Tools
[GTK] Make the 32 bits bot only build and run API tests
https://bugs.webkit.org/show_bug.cgi?id=113532
Reviewed by Martin Robinson.
- BuildSlaveSupport/build.webkit.org-config/config.json: make the 32 bits bot use the new BuildAndAPITest type
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(BuildAndAPITestFactory): new factory that builds and runs API tests, only used by the GTK+ 32 bits bot at the
moment;
(BuildAndAPITestFactory.init): add API tests step for platforms that have it.
- 7:32 AM Changeset in webkit [148744] by
-
- 2 edits in trunk/Tools
[Qt] Only use thin archives on Linux
Rubber-stamped by Jocelyn Turcotte.
Since "thin archive" is a feature of GNU's ar
we limit the usage to Linux to avoid problems
with other configurations (eg. macx-g++).
- qmake/mkspecs/features/default_pre.prf:
- 6:54 AM Changeset in webkit [148743] by
-
- 3 edits in trunk/Source/WebCore
[GTK][AC] Manage actor's children by using clutter's own way.
https://bugs.webkit.org/show_bug.cgi?id=114257
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-19
Reviewed by Gustavo Noronha Silva.
I believe we don't need to maintain a children list of GList. We can do it
by using clutter APIs like clutter_actor_get_children, clutter_actor_get_first_child, etc.
No new tests since no functionality changed.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphics_layer_actor_init):
(graphicsLayerActorAllocate):
(graphicsLayerActorPaint):
(graphicsLayerActorRemoveAll):
(graphicsLayerActorGetnChildren):
(graphicsLayerActorReplaceSublayer):
(graphicsLayerActorInsertSublayer):
- platform/graphics/clutter/GraphicsLayerActor.h:
(_GraphicsLayerActor):
- 6:51 AM Changeset in webkit [148742] by
-
- 5 edits in trunk/Source/WebCore
[GTK][AC] Support masksToBounds for clutter AC backend.
https://bugs.webkit.org/show_bug.cgi?id=114113
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-19
Reviewed by Gustavo Noronha Silva.
We can support the masksToBounds property by using clutter_actor_set_clip simply.
Covered by existing AC tests.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorSetMasksToBounds):
- platform/graphics/clutter/GraphicsLayerActor.h:
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::setMasksToBounds):
(WebCore):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::setupContentsLayer):
(WebCore::GraphicsLayerClutter::updateMasksToBounds):
- platform/graphics/clutter/GraphicsLayerClutter.h:
(GraphicsLayerClutter):
- 6:32 AM Changeset in webkit [148741] by
-
- 2 edits in trunk/Source/WTF
OSAllocatorPosix: fix build warnings about unused parameters in QNX
https://bugs.webkit.org/show_bug.cgi?id=114859
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-19
Reviewed by Carlos Garcia Campos.
- wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted):
- 5:43 AM Changeset in webkit [148740] by
-
- 6 edits1 add in trunk/Source/WebKit
[EFL] Add method in ewk_settings for setting the CSS media type
https://bugs.webkit.org/show_bug.cgi?id=113284
Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-04-19
Reviewed by Gyuyoung Kim.
Source/WebKit:
test_ewk_setting is added.
- PlatformEfl.cmake:
Source/WebKit/efl:
Added APIs to set and get CSS media type.
Added unit tests for these APIs.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::overrideMediaType):
- ewk/ewk_settings.cpp:
(ewk_settings_css_media_type_set):
(ewk_settings_css_media_type_get):
- ewk/ewk_settings.h:
- tests/test_ewk_setting.cpp: Added.
(TEST_F):
- 4:47 AM Changeset in webkit [148739] by
-
- 2 edits in trunk/Source/WebKit/blackberry
fixed debug broken from previous patch
https://bugs.webkit.org/show_bug.cgi?id=114844
Patch by Xuefei Ren <xren@blackberry.com> on 2013-04-19
Reviewed by Rob Buis.
- WebKitSupport/RenderQueue.cpp:
(BlackBerry::WebKit::RenderQueue::scrollZoomJobsCompleted):
Add the parameter outstandingJobs which is used in ASSERT(),it was
removed in the r148677 by misstake.now I need to fix it.
- 4:30 AM Changeset in webkit [148738] by
-
- 3 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Added new baseline.
- platform/qt/editing/selection/select-across-readonly-input-1-expected.txt: Updated after r148594.
- platform/qt/fast/sub-pixel/inline-block-with-padding-expected.txt: Added after r148604.
- platform/qt/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added after r148604.
- platform/qt/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Added after r148604.
- 3:37 AM Changeset in webkit [148737] by
-
- 4 edits in trunk
[GTK][WK2] accessibility/language-attribute.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106342
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-04-19
Reviewed by Gyuyoung Kim.
Tools:
Adds support for getting language information.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::language):
LayoutTests:
Unskipping accessibility/language-attribute.html.
- platform/gtk-wk2/TestExpectations:
- 2:59 AM Changeset in webkit [148736] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] EditorClientBlackBerry: Fix parameter name
https://bugs.webkit.org/show_bug.cgi?id=114856
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-19
Reviewed by Carlos Garcia Campos.
Build fix due to a typo in a parameter name.
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::requestCheckingOfString):
- 1:48 AM FeatureFlags edited by
- (diff)
- 1:47 AM Changeset in webkit [148735] by
-
- 4 edits in trunk/Tools
[Dashboard] Remove the isToTWebKit member variable from the BuilderGroup interface
https://bugs.webkit.org/show_bug.cgi?id=114805
Reviewed by Benjamin Poulain.
Remove the isToTWebKit member variable from the BuilderGroup and all its usages as it now defaults to true for every
builder group. The isTipOfTreeWebKitBuilder method now returns true by default but should be removed in a follow-up patch.
The BuilderGroup constructor does not accept the isToTWebKit parameter anymore so all the callsites are adjusted accordingly.
- TestResultServer/static-dashboards/builders.js:
(BuilderGroup):
(loadBuildersList):
- TestResultServer/static-dashboards/dashboard_base.js:
(isTipOfTreeWebKitBuilder):
(expectationsMap):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):
- 1:43 AM Changeset in webkit [148734] by
-
- 2 edits in trunk/Tools
[Dashboard] htmlForIndividualTests unit test should include its dummy builder under the webkit.org builder master
https://bugs.webkit.org/show_bug.cgi?id=114804
Reviewed by Benjamin Poulain.
The htmlForIndividualTests unit test should include its dummy builder under the sole supported webkit.org builder master
just so the unit tests properly functions.
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- 1:42 AM Changeset in webkit [148733] by
-
- 3 edits in trunk/Tools
[Dashboard] Remove Chromium-specific helper functions that were used in the builder-loading code
https://bugs.webkit.org/show_bug.cgi?id=114803
Reviewed by Benjamin Poulain.
Remove three Chromium-specific helper functions that were used to determine Chromium DEPS, Content Shell and WebKit ToT
test runners. These are not required anymore and thus removed along with a couple of unit tests that were testing these
methods' correct behavior.
- TestResultServer/static-dashboards/builders.js:
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- 1:41 AM Changeset in webkit [148732] by
-
- 2 edits in trunk/Tools
[Dashboard] Remove the Chromium-specific builder masters
https://bugs.webkit.org/show_bug.cgi?id=114802
Reviewed by Benjamin Poulain.
Remove all the Chromium-specific builder masters, the webkit.org builder master is the only one currently supported.
- TestResultServer/static-dashboards/builders.js:
- 1:40 AM Changeset in webkit [148731] by
-
- 24 edits6 deletes in trunk
Remove unmaintained feature REQUEST_AUTOCOMPLETE
https://bugs.webkit.org/show_bug.cgi?id=114846
Patch by Dan Beam <dbeam@chromium.org> on 2013-04-19
Reviewed by Kent Tamura.
Source/WebCore:
- GNUmakefile.list.am: Remove AutocompleteErrorEvent.h include.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore): Remove requestAutocomplete() runtime feature.
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures): Remove requestAutocomplete() runtime feature.
- dom/AutocompleteErrorEvent.h: Removed.
- dom/AutocompleteErrorEvent.idl: Removed.
- dom/EventNames.h: Remove
autocompleteandautocompleteerrorevent names.
(WebCore):
- dom/EventNames.in: Remove
autocompleteandautocompleteerrorevent names. - html/HTMLAttributeNames.in: Remove
onautocompleteandonautocompleteerrorform attributes. - html/HTMLFormElement.cpp: Remove requestAutocomplete() related code.
(WebCore::HTMLFormElement::HTMLFormElement): Remove timer and event queue for requestAutocomplete() related events.
(WebCore::HTMLFormElement::parseAttribute): Remove parsing ofonautocompleteandonautocompleterror.
- html/HTMLFormElement.h: Remove requestAutocomplete() related members.
(HTMLFormElement):
- html/HTMLFormElement.idl: Remove public requestAutocomplete() API method.
- loader/EmptyClients.cpp: Remove stub implementation.
(WebCore):
- loader/EmptyClients.h: Remove stub interface.
(EmptyFrameLoaderClient):
- loader/FrameLoaderClient.h: Remove didRequestAutocomplete() from interface.
(FrameLoaderClient):
- page/DOMWindow.idl: Remove
AutocompleteErrorEventfrom window DOM interface.
Source/WTF:
- wtf/FeatureDefines.h: Remove REQUEST_AUTOCOMPLETE as a feature definition.
LayoutTests:
- fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Removed.
- fast/events/constructors/autocomplete-error-event-constructor.html: Removed.
- fast/events/event-creation.html: Remove AutocompleteErrorEvent test code.
- fast/forms/form-request-autocomplete-expected.txt: Removed.
- fast/forms/form-request-autocomplete.html: Removed.
- fast/js/constructor-length.html: Remove AutocompleteErrorEvent test code.
- fast/js/script-tests/global-constructors.js: Remove AutocompleteErrorEvent constructor.
- platform/blackberry/fast/js/constructor-length-expected.txt: Remove test expectations.
- platform/gtk/fast/js/constructor-length-expected.txt: Remove test expectations.
- platform/mac/fast/js/constructor-length-expected.txt: Remove test expectations.
- platform/qt/fast/js/constructor-length-expected.txt: Remove test expectations.
- 1:40 AM Changeset in webkit [148730] by
-
- 2 edits in trunk/Tools
[Dashboard] Remove all the Chromium-specific builder groups
https://bugs.webkit.org/show_bug.cgi?id=114801
Reviewed by Benjamin Poulain.
Remove all the Chromium-specific builder groups, all of these are not supported anymore.
- TestResultServer/static-dashboards/builders.js:
- 1:39 AM Changeset in webkit [148729] by
-
- 2 edits in trunk/Tools
[Dashboard] Only accept the 'group' parameter if present in the layout tests builders group
https://bugs.webkit.org/show_bug.cgi?id=114799
Reviewed by Benjamin Poulain.
The layout tests builder group is the only one supported, all the other Chromium-specific builder groups are
bound to be removed.
- TestResultServer/static-dashboards/history.js:
(.):
- 1:37 AM Changeset in webkit [148728] by
-
- 2 edits in trunk/Tools
[Dashboard] Remove Chromium-specific builder loading code from loadBuildersList
https://bugs.webkit.org/show_bug.cgi?id=114797
Reviewed by Benjamin Poulain.
Remove anything Chromium-specific from the builder-loading code, specifically removing support for loading builder data
for anything other that the layout-tests type and removing support for loading builder data from builders connected
to the Chromium-specific builder groups which are no longer supported.
- TestResultServer/static-dashboards/builders.js:
- 1:36 AM Changeset in webkit [148727] by
-
- 2 edits in trunk/Tools
[Dashboard] The currentBuilderGroupCategory method should return the layout tests builder groups by default
https://bugs.webkit.org/show_bug.cgi?id=114796
Reviewed by Benjamin Poulain.
With the Chromium builders no longer uploading results and the layout-tests test type the only one supported by the
WebKit's dashboard, the currentBuilderGroupCategory can now return LAYOUT_TESTS_BUILDER_GROUPS as the default builder
group category.
- TestResultServer/static-dashboards/dashboard_base.js:
(currentBuilderGroupCategory):
- 1:33 AM Changeset in webkit [148726] by
-
- 2 edits in trunk/Tools
[Dashboard] Narrow down the test types list to only layout-tests
https://bugs.webkit.org/show_bug.cgi?id=114795
Reviewed by Ryosuke Niwa.
Remove all the redundant test types that the webkit.org builders do not upload results for. All of the removed
test types were specific to the Chromium builders.
- TestResultServer/static-dashboards/dashboard_base.js:
- 1:28 AM Changeset in webkit [148725] by
-
- 2 edits in trunk/Tools
[Dashboard] The revision rows for aggregate results should no longer include Chromium revisions
https://bugs.webkit.org/show_bug.cgi?id=114760
Reviewed by Benjamin Poulain.
With the Chromium builders no longer present there's no need to display the Chromium revision range under the
aggregate results. Only the first half of the htmlForRevisionRows method (the one returning the table row listing the
WebKit revisions) is now relevant - the method is therefor removed and its callsites updated to directly call the
htmlForTableRow method that returns the table row containing all the relevant WebKit revisions.
- TestResultServer/static-dashboards/aggregate_results.js:
(htmlForSummaryTable):
(htmlForTestType):
- 1:25 AM Changeset in webkit [148724] by
-
- 2 edits in trunk/Tools
[Dashboard] Remove Chromium-specific cases from the construction of the chart HTML for aggregate results
https://bugs.webkit.org/show_bug.cgi?id=114759
Reviewed by Benjamin Poulain.
Aggregate results are not viewable for Chromium builders anymore, meaning the WebKit revisions are shown by default.
This means the code in the chartHTML method can be simplified, defaulting the revision key to WEBKIT_REVISIONS_KEY
and the revision label to 'WebKit Revision'.
- TestResultServer/static-dashboards/aggregate_results.js:
(chartHTML):
- 12:14 AM EFLWebKitBuildBots edited by
- (diff)
