Timeline
Apr 22, 2013:
- 11:51 PM Changeset in webkit [148945] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Assertion Failures in Coordinated Graphics after r148433
https://bugs.webkit.org/show_bug.cgi?id=114731
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-22
Reviewed by Gyuyoung Kim.
The assert is incorrect. In some cases in coordinated graphics we may have a backing store
and drawsContent would be set to false.
No new tests.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintSelf):
- 11:36 PM Changeset in webkit [148944] by
-
- 29 edits2 adds in trunk
table's text aligned on top instead of center because of rowspan
https://bugs.webkit.org/show_bug.cgi?id=18092
Patch by Suchit Agrawal <a.suchit@samsung.com> on 2013-04-22
Reviewed by Beth Dakin.
Source/WebCore:
Last row in the rowspan is not getting the height of rowspan cell because there is not
enough rows present below rowspan cell and we are strictly applying height of rowspan
to the row which should lay last in the rowspan based of rowspan value.
When row contains rowspan cell and it is last row of the table then
rowspan height is adding to last row of the table.
Test: fast/table/Rowspan-value-more-than-number-of-rows-present.html
It calculates logical height of the rows in the table.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
LayoutTests:
Added test cases, based on rowspan issue.
- fast/table/Rowspan-value-more-than-number-of-rows-present-expected.txt: Added.
- fast/table/Rowspan-value-more-than-number-of-rows-present.html: Added.
Test cases need to do rebaseline in efl, gtk and mac platforms.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
Test case results are updated in qt platform.
- platform/qt/fast/table/giantRowspan-expected.png:
- platform/qt/fast/table/giantRowspan-expected.txt:
- platform/qt/fast/table/giantRowspan2-expected.png:
- platform/qt/fast/table/giantRowspan2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug133756-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug133756-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug220536-expected.png:
- platform/qt/tables/mozilla/bugs/bug220536-expected.txt:
- platform/qt/tables/mozilla/bugs/bug8858-expected.txt:
- platform/qt/tables/mozilla/core/bloomberg-expected.png:
- platform/qt/tables/mozilla/core/bloomberg-expected.txt:
- platform/qt/tables/mozilla/core/row_span-expected.png:
- platform/qt/tables/mozilla/core/row_span-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- tables/mozilla/core/bloomberg-expected.txt:
- tables/mozilla/core/row_span-expected.txt:
- tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- 9:52 PM Changeset in webkit [148943] by
-
- 4 edits4 adds in trunk
[CSS Regions] Region's float parent doesn't size according to region size but to content node size
https://bugs.webkit.org/show_bug.cgi?id=111332
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/regions/intrinsic-sized-regions.html
fast/regions/region-with-float-parent.html
The patch ensures that the computation of region's preferred widths
takes into account the region width/min-width if these values are specified.
Also implemented the computation of intrinsic widths for a region,
based on the min/max preferred widths of the associated flow thread.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderRegion::computePreferredLogicalWidths):
- rendering/RenderRegion.h:
(RenderRegion):
LayoutTests:
Added tests for intrinsic and preferred width computation for region.
- fast/regions/intrinsic-sized-regions-expected.txt: Added.
- fast/regions/intrinsic-sized-regions.html: Added.
- fast/regions/region-with-float-parent-expected.txt: Added.
- fast/regions/region-with-float-parent.html: Added.
- 9:47 PM Changeset in webkit [148942] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix a typo in MacroAssemblerARMv7.h.
https://bugs.webkit.org/show_bug.cgi?id=115011.
Reviewed by Geoffrey Garen.
- assembler/ARMAssembler.h: Fix a comment.
- assembler/ARMv7Assembler.h: Added some comments.
- assembler/MacroAssemblerARMv7.h:
- ARMAssembler::PL should be ARMv7Assembler::ConditionPL.
- 8:32 PM Changeset in webkit [148941] by
-
- 3 edits in trunk/Source/WTF
[CMake] Move NullPtr.cpp from PlatformWinCE.cmake to CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=114557
Reviewed by Laszlo Gombos.
This file is not specific to Windwos CE. Move it the the general
CMakeLists.txt so other ports can use it to. It does not affect
ports which do not need it, since it contains a preprocessor guard.
- wtf/CMakeLists.txt:
- wtf/PlatformWinCE.cmake:
- 7:33 PM Changeset in webkit [148940] by
-
- 4 edits in trunk/Source/WebKit
Speculative Windows build fix.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
- 7:03 PM Changeset in webkit [148939] by
-
- 7 edits in trunk/LayoutTests
Remove references to the inspector/profiler/memory-instrumentation tests removed in r148921
Rubber-stamped by Benjamin Poulain.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 6:10 PM Changeset in webkit [148938] by
-
- 5 edits in trunk/Source/WebKit2
Need WebKit SPI to detect whether a page contains form controls
<rdar://problem/13686661>
https://bugs.webkit.org/show_bug.cgi?id=115003
Reviewed by Beth Dakin.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameContainsAnyFormControls):
- WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormControls):
- WebProcess/WebPage/WebFrame.h:
- 5:43 PM Changeset in webkit [148937] by
-
- 2 edits in trunk/Source/WebKit2
[Mac] REGRESSION (r142806): "Just Leaking" Console errors on launch
https://bugs.webkit.org/show_bug.cgi?id=115002
<rdar://problem/13254212>
Reviewed by Sam Weinig.
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm: (WebKit::BootstrapMain): Added an autorelease pool for code that uses Objective-C.
- 5:16 PM Changeset in webkit [148936] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Create an equivalent of Structure::get() that can work from a compilation thread
https://bugs.webkit.org/show_bug.cgi?id=114987
Reviewed by Geoffrey Garen.
This completes the work started by r148570. That patch made it possible to do
Structure::get() without modifying Structure. This patch takes this further, and
makes this thread-safe (for non-uncacheable-dictionaries) via
Structure::getConcurrently(). This method not only doesn't modify Structure, but
also ensures that any concurrent attempts to add to, remove from, or steal the
table from that structure doesn't mess up the result of the call. The call may
return invalidOffset even if a property is *just* about to be added, but it will
never do the reverse: if it returns a property then you can be sure that the
structure really does have that property and always will have it.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
- runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::findConcurrently):
(JSC):
(JSC::PropertyTable::add):
(JSC::PropertyTable::remove):
(JSC::PropertyTable::reinsert):
(JSC::PropertyTable::rehash):
- runtime/PropertyTable.cpp:
(JSC::PropertyTable::PropertyTable):
- runtime/Structure.cpp:
(JSC::Structure::findStructuresAndMapForMaterialization):
(JSC::Structure::getConcurrently):
- runtime/Structure.h:
(Structure):
- runtime/StructureInlines.h:
(JSC::Structure::getConcurrently):
- 5:16 PM Changeset in webkit [148935] by
-
- 3 edits in trunk/Source/WebKit/gtk
Try to fix the build after enabling gobject-introspection
- GNUmakefile.am: Disable --warn-error for WebKit1 until we can work out all gir failures.
- webkit/webkitwebplugin.cpp: Skip this API for introspection because it return a GSList
of pointer (non-boxed) types.
- 5:10 PM Changeset in webkit [148934] by
-
- 2 edits in trunk/Tools
<http://webkit.org/b/114989> Add a user default to allow use of the Safari binary rather than SafariForWebKitDevelopment
Reviewed by Anders Carlsson.
- Scripts/webkitdirs.pm:
(skipSafariExecutableEntitlementChecks): Look for the SkipSafariExecutableEntitlementChecks default in the
/Library/Preferences/org.webkit.BuildConfiguration preference domain.
(safariPathFromSafariBundle): If the user default is set asking us to skip the entitlement checks, return
the path to the regular Safari binary.
- 4:50 PM Changeset in webkit [148933] by
-
- 4 edits in trunk/Source/WebCore
Debug build fix.
Rubber-stamped by Ryosuke Niwa.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
- inspector/InspectorMemoryAgent.h:
(WebCore):
(WebCore::InspectorMemoryAgent::create):
(InspectorMemoryAgent):
- 4:42 PM Changeset in webkit [148932] by
-
- 2 edits in trunk/Source/WebCore
Address review feedback I forgot to address in r148929
https://bugs.webkit.org/show_bug.cgi?id=114480
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest): Rework the "what" comment into a more useful "why" comment.
- 4:40 PM Changeset in webkit [148931] by
-
- 2 edits in trunk/Tools
Unreviewed Efl build fix after r148921
- TestWebKitAPI/CMakeLists.txt:
- 4:34 PM Changeset in webkit [148930] by
-
- 3 edits in trunk/Source/WebCore
Second Mac debug build fix after r148921
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-22
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
- inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):
- 4:28 PM Changeset in webkit [148929] by
-
- 5 edits14 adds in trunk
REGRESSION (r141136): Wiki "Random article" function very broken.
<rdar://problem/13229985> and https://bugs.webkit.org/show_bug.cgi?id=114480
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: http/tests/navigation/redirect-to-random-url-versus-memory-cache.html
If we are performing a conditional GET to revalidate a resource and there's a redirect,
check to see if the redirect is to a different URL than the final URL of the resource.
If the URLs differ then we should make the redirect-request unconditional and do a normal load.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::makeUnconditional):
- platform/network/ResourceRequestBase.h:
(ResourceRequestBase):
LayoutTests:
- http/tests/navigation/redirect-to-random-url-versus-memory-cache-expected.txt: Added.
- http/tests/navigation/redirect-to-random-url-versus-memory-cache.html: Added.
- http/tests/navigation/resources/randomredirects/0.php: Added.
- http/tests/navigation/resources/randomredirects/1.php: Added.
- http/tests/navigation/resources/randomredirects/2.php: Added.
- http/tests/navigation/resources/randomredirects/3.php: Added.
- http/tests/navigation/resources/randomredirects/4.php: Added.
- http/tests/navigation/resources/randomredirects/5.php: Added.
- http/tests/navigation/resources/randomredirects/6.php: Added.
- http/tests/navigation/resources/randomredirects/7.php: Added.
- http/tests/navigation/resources/randomredirects/8.php: Added.
- http/tests/navigation/resources/randomredirects/9.php: Added.
- http/tests/navigation/resources/randomredirects/randomredirect.php: Added.
- 4:27 PM Changeset in webkit [148928] by
-
- 2 edits in trunk/Source/WebKit/win
Another Windows build fix after r148921
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-22
- AccessibleBase.cpp: Add missing header include.
- 4:26 PM Changeset in webkit [148927] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
Skip svg/custom/mask-invalidation.svg on Mac
<rdar://problem/13711076>
Patch by David Farler <dfarler@apple.com> on 2013-04-22
- platform/mac/Skipped:
Skip svg/custom/mask-invalidation.svg
- 4:25 PM Changeset in webkit [148926] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add branchAdd32 missing implementation in SH4 base JIT.
This should fix SH4 build, broken since r148893.
https://bugs.webkit.org/show_bug.cgi?id=114993.
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-22
Reviewed by Oliver Hunt.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchAdd32):
(MacroAssemblerSH4):
- 4:12 PM Changeset in webkit [148925] by
-
- 2 edits in trunk/Source/WebCore
Mac debug build fix after r148921
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-22
- page/animation/CompositeAnimation.cpp:
- 4:08 PM Changeset in webkit [148924] by
-
- 3 edits in trunk/Source/JavaScriptCore
Windows build fix after r148921
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-22
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 4:06 PM Changeset in webkit [148923] by
-
- 3 edits3 adds in trunk
[Cairo] Canvas-shadow behavior is not being as expected
https://bugs.webkit.org/show_bug.cgi?id=108897
Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-04-22
Reviewed by Martin Robinson.
Source/WebCore:
Use the pattern-extend-mode "CAIRO_EXTEND_NONE" instead of "CAIRO_EXTEND_PAD" in
PlatformContextCairo::drawSurfaceToContext().
In the function PlatformContextCairo::drawSurfaceToContext(), a pattern is being
created from the source surface and this pattern is drawn onto the destination
context. There is no gradient involved. Hence the extend mode for filling the
pattern should be "CAIRO_EXTEND_NONE". If we use the extend mode
"CAIRO_EXTEND_PAD" in PlatformContextCairo::drawSurfaceToContext(), the original
image area is also filled with the shadow color which is not the expected behavior.
Test: fast/canvas/canvas-image-shadow.html
- platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::drawSurfaceToContext):
LayoutTests:
Test to verify the shadow of an image drawn on canvas.
This test uses an image whose size is smaller than,
the size of the rectangle which should be filled with the image.
- fast/canvas/canvas-image-shadow-expected.txt: Added.
- fast/canvas/canvas-image-shadow.html: Added.
- fast/canvas/green.png: Added.
- fast/canvas/script-tests/canvas-image-shadow.js: Added.
(draw):
- 3:56 PM Changeset in webkit [148922] by
-
- 11 edits in trunk/Source/WebKit2
Web process should decide when to continue main resource loads
https://bugs.webkit.org/show_bug.cgi?id=114995
Reviewed by Sam Weinig.
Main resource loads can be converted to downloads, so we need the ability to let the web process decide when
to continue loading after a response has been received.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
For non-main resources, just call continueDidReceiveResponse directly; there's no need to ping-pong to the web process in that case.
(WebKit::NetworkResourceLoader::continueDidReceiveResponse):
Just call ResourceHandle::continueDidReceiveResponse.
- NetworkProcess/NetworkResourceLoader.messages.in:
Add ContinueDidReceiveResponse message.
- NetworkProcess/SchedulableLoader.cpp:
(WebKit::SchedulableLoader::SchedulableLoader):
Initialize m_isLoadingMainResource.
- NetworkProcess/SchedulableLoader.h:
(WebKit::SchedulableLoader::isLoadingMainResource):
Add getter.
(SchedulableLoader):
Move m_shouldClearReferrerOnHTTPSToHTTPRedirect next to the rest of the booleans.
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):
- Shared/Network/NetworkResourceLoadParameters.h:
(NetworkResourceLoadParameters):
Add isMainResource flag.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleSubresourceLoad):
Pass the cached resource to scheduleLoad.
(WebKit::WebResourceLoadScheduler::schedulePluginStreamLoad):
Pass null to scheduleLoad.
(WebKit::WebResourceLoadScheduler::scheduleLoad):
Initialize isMainResource.
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
If this is a main resource load, send back a ContinueDidReceiveResponse message.
- 3:52 PM Changeset in webkit [148921] by
-
- 395 edits30 deletes in trunk
Remove the memory instrumentation code
https://bugs.webkit.org/show_bug.cgi?id=114931
Reviewed by Andreas Kling.
.:
- Source/autotools/symbols.filter:
Source/JavaScriptCore:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
Source/WebCore:
The Memory Instrumentation code is unfinished and has already
become out of sync the objects it is supposed to represent.
The current approach does not seem maintainable, it is better to
remove it before someone gets hurt.
By removing the code, the binary become 1240976 bytes smaller.
Yep, almost 1 Mb, bringing WebCore to the size it has 5 months ago :)
- MostWebCoreFiles: remove the support for memory instrumentation.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/mac:
- WebView/WebRenderLayer.mm:
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
Source/WTF:
On Mac x86_64, the code removal cause the binary to be
9224 bytes smaller.
- GNUmakefile.list.am:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/Forward.h:
- wtf/ListHashSet.h:
(ListHashSet):
(ListHashSetNodeAllocator):
(WTF::ListHashSetNodeAllocator::pool):
(WTF::ListHashSetNodeAllocator::pastPool):
- wtf/MemoryInstrumentation.cpp: Removed.
- wtf/MemoryInstrumentation.h: Removed.
- wtf/MemoryInstrumentationArrayBufferView.h: Removed.
- wtf/MemoryInstrumentationHashCountedSet.h: Removed.
- wtf/MemoryInstrumentationHashMap.h: Removed.
- wtf/MemoryInstrumentationHashSet.h: Removed.
- wtf/MemoryInstrumentationListHashSet.h: Removed.
- wtf/MemoryInstrumentationSequence.h: Removed.
- wtf/MemoryInstrumentationString.h: Removed.
- wtf/MemoryInstrumentationVector.h: Removed.
- wtf/MemoryObjectInfo.h: Removed.
- wtf/text/AtomicString.h:
- wtf/text/StringImpl.h:
(WTF::StringImpl::isASCIILiteral):
- wtf/text/WTFString.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: Removed.
LayoutTests:
- inspector/profiler/memory-instrumentation-cached-images-expected.txt: Removed.
- inspector/profiler/memory-instrumentation-cached-images.html: Removed.
- inspector/profiler/memory-instrumentation-canvas-expected.txt: Removed.
- inspector/profiler/memory-instrumentation-canvas.html: Removed.
- inspector/profiler/memory-instrumentation-external-array-expected.txt: Removed.
- inspector/profiler/memory-instrumentation-external-array.html: Removed.
- inspector/profiler/memory-instrumentation-external-string-expected.txt: Removed.
- inspector/profiler/memory-instrumentation-external-string.html: Removed.
- inspector/profiler/memory-instrumentation-test.js: Removed.
- 3:39 PM Changeset in webkit [148920] by
-
- 3 edits2 adds in trunk
Do not reuse ExclusionShapeInsideInfo in a recursive region layout
https://bugs.webkit.org/show_bug.cgi?id=114467
Reviewed by David Hyatt.
Source/WebCore:
Elements that respect shape-inside that have inline children should not reuse an
ExclusionShapeInsideInfo for their children's layout. This patch adds the test
for regions. See the details for non-region layout in bug 104582.
https://bugs.webkit.org/show_bug.cgi?id=104582
Test: fast/regions/shape-inside/shape-inside-recursive-layout.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Do not look up a region's
ExclusionShapeInsideInfo if a block is already respecting shape-inside.
LayoutTests:
Test that for various types of inline containers do not reuse
ExclusionShapeInsideInfo when laying out their children.
- fast/regions/shape-inside/shape-inside-recursive-layout-expected.html: Added.
- fast/regions/shape-inside/shape-inside-recursive-layout.html: Added.
- 3:36 PM Changeset in webkit [148919] by
-
- 3 edits in trunk/Source/WebKit2
Plugin Snapshotting: Don't consume insane amounts of time detecting the primary plugin
https://bugs.webkit.org/show_bug.cgi?id=114994
<rdar://problem/13696269>
Reviewed by Anders Carlsson.
On some pages, we currently waste a lot of time on every subframe load
and every addPluginView doing primary plugin detection. This patch
attempts to address this via a few minor changes:
- Only allow detection after the main frame's didFinishLoad comes, instead of the first subframe.
- Only explicitly detect on the main frame's didFinishLoad (not subframes).
- Coalesce calls to determinePrimarySnapshottedPlugIn from both addPluginView
(in case JS is adding lots of plugins in a loop) and didFinishLoad.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::addPluginView): Coalesce calls to determinePrimarySnapshottedPlugIn.
(WebKit::WebPage::didFinishLoad):
Coalesce calls to determinePrimarySnapshottedPlugIn.
Bail on subframe loads, we're only interested in the main frame being complete.
(WebKit::WebPage::determinePrimarySnapshottedPlugInTimerFired):
Call determinePrimarySnapshottedPlugIn.
- WebProcess/WebPage/WebPage.h:
Add m_determinePrimarySnapshottedPlugInTimer and determinePrimarySnapshottedPlugInTimerFired
- 3:29 PM Changeset in webkit [148918] by
-
- 2 edits in trunk/LayoutTests
Fix r148773.
- platform/mac-lion/TestExpectations:
- 3:21 PM Changeset in webkit [148917] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13334446> [Mac] Tweak sandbox profiles.
Reviewed by Anders Carlsson.
Unbreak Lion, which doesn't provide detailed control over IPC.
- WebProcess/com.apple.WebProcess.sb.in:
- 3:15 PM Changeset in webkit [148916] by
-
- 9 edits in trunk
[GTK] Enable introspection always for developer builds
https://bugs.webkit.org/show_bug.cgi?id=114983
Reviewed by Gustavo Noronha Silva.
.:
- Source/autotools/SetupAutoconfHeader.m4: No longer expose the ENABLE_INTROSPECTION
autoconf header variable. It isn't used and it means that when introspection is enabled
or disabled, there is an unnecessary full rebuild.
Source/WebKit/gtk:
- GNUmakefile.am: Make warnings during gir scanning cause the build to fail. Eliminate
warnings about deprecated API that the g-ir-scanner uses when generating
the scanner program. Use --quiet to avoid printing lots of output to
non-verbose builds.
Source/WebKit2:
- GNUmakefile.am: Make warnings during gir scanning cause the build to fail. Eliminate
warnings about deprecated API that the g-ir-scanner uses when generating
the scanner program. Use --quiet.
Tools:
- Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary): Always enable introspection
when using build-webkit.
- gtk/jhbuildrc: Enable documentation for all jhbuild modules and explicitly
choose the memory gsettings backend while in the jhbuild. This eliminates
warnings from programs that fall back to the memory backend.
- 3:07 PM Changeset in webkit [148915] by
-
- 3 edits in trunk/LayoutTests
[css exclusions] shape-inside-recursive-layout.html should not yet test display: inline-grid
https://bugs.webkit.org/show_bug.cgi?id=114986
Reviewed by Dirk Schulze.
Because the inline-grid value is not yet supported, the test case is falling back to
display: block. This causes an incorrect layout, as block and inline content react to
shape-inside differently.
- fast/exclusions/shape-inside/shape-inside-recursive-layout-expected.html:
- fast/exclusions/shape-inside/shape-inside-recursive-layout.html:
- 2:54 PM Changeset in webkit [148914] by
-
- 6 edits in trunk/Source
[GTK] Fix remaining introspection warnings
https://bugs.webkit.org/show_bug.cgi?id=114980
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
- bindings/gobject/WebKitDOMCustom.h: Add scope and transfer annotations and flesh
out gtkdoc for completeness.
- bindings/gobject/WebKitDOMEventTarget.h:
(_WebKitDOMEventTargetIface): Ditto and also align virtual method names with those used
for the concrete ones.
Source/WebKit/gtk:
- webkit/webkitspellchecker.h:
(_WebKitSpellCheckerInterface): Align the name of the check_spelling_of_string virtual
method with the concrete method to avoid a g-ir-scanner warning.
- webkit/webkitversion.h.in: Skip WEBKITGTK_API_VERSION for introspection because it
doesn't follow the appropriate namespace name.
- 2:45 PM Changeset in webkit [148913] by
-
- 7 edits in trunk/Source/WebKit2
Make it easier to extend NetworkResourceLoadParameters
https://bugs.webkit.org/show_bug.cgi?id=114992
Reviewed by Sam Weinig.
Turn NetworkResourceLoadParameters into a struct which matches all our other parameter classes in WebKit2. Fill in the struct manually
instead of having a constructor with 9 parameters.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
(WebKit::NetworkConnectionToWebProcess::performSynchronousLoad):
- NetworkProcess/SchedulableLoader.cpp:
(WebKit::SchedulableLoader::SchedulableLoader):
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):
- Shared/Network/NetworkResourceLoadParameters.h:
(NetworkResourceLoadParameters):
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::loadResourceSynchronously):
- 2:19 PM Changeset in webkit [148912] by
-
- 11 edits2 adds in trunk/Source
PDFPlugin: Support unlocking encrypted PDFs
https://bugs.webkit.org/show_bug.cgi?id=114938
<rdar://problem/12872888>
Reviewed by Alexey Proskuryakov and Oliver Hunt.
If we try to load an encrypted PDF, we need to provide a sane mechanism
through which the user can provide the password. Add a slightly-below-center
password field to match PDFKit's normal behavior.
- WebKit2.xcodeproj/project.pbxproj: Add PDFPluginPasswordField.{h,mm}
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add attemptToUnlockWithPassword:
- WebProcess/Plugins/PDF/PDFPlugin.h:
Add createPasswordEntryForm, attemptToUnlockPDF, m_passwordField.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(annotationStyle): Make #annotationContainer a flexbox that centers its contents.
This won't affect the normal absolutely-positioned form fields, but the inline
password field will be centered vertically and horizontally.
(WebKit::PDFPlugin::pdfDocumentDidLoad):
If the document is locked when loaded, create a password field.
(WebKit::PDFPlugin::createPasswordEntryForm):
Create a PDFPluginPasswordField and attach it to the document.
(WebKit::PDFPlugin::attemptToUnlockPDF):
Try to unlock the PDF with the given password. If this succeeds, remove
the password field and relayout the scroll view.
(WebKit::PDFPlugin::calculateSizes):
Make the document 0x0 if it is locked, preventing scrolling.
(WebKit::PDFPlugin::handleMouseEvent):
Don't pass mouse events to PDFLayerController while it is locked,
as it has no useful events to provide, and will try to present a
dialog asking for the password if we let a click through.
- WebProcess/Plugins/PDF/PDFPluginAnnotation.h:
(WebKit::PDFPluginAnnotation::eventListener): Added.
- WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::handleEvent):
Move event-handling code here from PDFPluginAnnotationEventListener::handleEvent
so that subclasses can override this instead of having to have their own
event listeners (this is also why we now expose eventListener()).
(WebKit::PDFPluginAnnotation::PDFPluginAnnotationEventListener::handleEvent):
Forward the event to our owning PDFPluginAnnotation.
- WebProcess/Plugins/PDF/PDFPluginPasswordField.h: Added.
(WebKit::PDFPluginPasswordField::PDFPluginPasswordField):
- WebProcess/Plugins/PDF/PDFPluginPasswordField.mm: Added.
(WebKit::PDFPluginPasswordField::create):
(WebKit::PDFPluginPasswordField::~PDFPluginPasswordField):
Unregister for keyup.
(WebKit::PDFPluginPasswordField::createAnnotationElement):
Register for keyup, and set our element's class to "password".
(WebKit::PDFPluginPasswordField::updateGeometry):
Added. Override updateGeometry and do nothing, as the password field
has a geometry defined by CSS instead of by the PDF content.
(WebKit::PDFPluginPasswordField::handleEvent):
If the enter/return key is pressed, attempt to unlock the PDF. Also,
we do not call either of our superclass' implementations of handleEvent,
because blurring the password field should not destroy it, and tabbing
between fields has no relevance when there can only be one field.
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener):
Removed. We now share our superclass' event listener.
(WebKit::PDFPluginTextAnnotation::textAnnotation): Const.
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::~PDFPluginTextAnnotation):
PDFPluginTextAnnotation no longer has its own event listener,
so there's nothing left to clear here. Just make sure to unregister
our event from PDFPluginAnnotation's shared event listener!
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
Ensure that we can create a PDFPluginTextAnnotation with a null annotation.
(WebKit::PDFPluginTextAnnotation::commit): Use value().
(WebKit::PDFPluginTextAnnotation::value):
Factor retrieving the value of the form control out of commit().
(WebKit::PDFPluginTextAnnotation::handleEvent):
Call up to PDFPluginAnnotation's handler so that defocus destroys the annotation.
Export HTMLNames::typeAttr.
- WebCore.exp.in:
- 1:46 PM Changeset in webkit [148911] by
-
- 3 edits in trunk/Source/WebKit2
Slow/beachballing when using the find bar on a page with plug-ins
https://bugs.webkit.org/show_bug.cgi?id=114990
<rdar://problem/12832313>
Reviewed by Tim Horton.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::notifyWidget):
Call shouldCreateTransientPaintingSnapshot().
(WebKit::PluginView::shouldCreateTransientPaintingSnapshot):
Don't create a painting snapshot if we're asked to paint the find indicator.
- WebProcess/Plugins/PluginView.h:
Add new member function.
- 1:40 PM Changeset in webkit [148910] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/13334446> [Mac] Tweak sandbox profiles.
Reviewed by Sam Weinig.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- WebProcess/com.apple.WebProcess.sb.in:
- 1:39 PM Changeset in webkit [148909] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Update about:config lists
https://bugs.webkit.org/show_bug.cgi?id=114967
Patch by Eli Fidler <efidler@blackberry.com> on 2013-04-22
Reviewed by Rob Buis.
- WebCoreSupport/AboutDataEnableFeatures.in:
- WebCoreSupport/AboutDataHaveFeatures.in:
- WebCoreSupport/AboutDataUseFeatures.in:
- 1:39 PM Changeset in webkit [148908] by
-
- 2 edits in trunk/Source/WebCore
Use-after-free in CompositeEditCommand::cloneParagraphUnderNewElement
https://bugs.webkit.org/show_bug.cgi?id=114911
Reviewed by Oliver Hunt.
Back ported https://src.chromium.org/viewvc/blink?revision=148680&view=revision.
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
- 1:29 PM Changeset in webkit [148907] by
-
- 4 edits2 adds in trunk
[Mac] "automatic" track selection should only select a track that matches user language
https://bugs.webkit.org/show_bug.cgi?id=114976
Reviewed by Jer Noble.
Source/WebCore:
Test: media/track/track-automatic-subtitles.html
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): When in "automatic" mode, only
consider text tracks that match the user's preferred language when the primary audio track
does not.
LayoutTests:
- media/track/track-automatic-subtitles-expected.txt: Added.
- media/track/track-automatic-subtitles.html: Added.
- platform/mac/TestExpectations: Skip track-user-preferences.html, the logic is no longer
correct for the Mac port.
- 1:02 PM Changeset in webkit [148906] by
-
- 2 edits in trunk/Source/WebCore
Cancelling load may cause deadlock in -[AVPlayerItem release]
https://bugs.webkit.org/show_bug.cgi?id=114962
Reviewed by Eric Carlson.
Work around a bug in AVAssetResourceLoader by using a generic, non-main dispatch queue
to recieve AVAssetResourceLoaderDelegate callbacks, and then marshalling those
callbacks to the main thread asynchronously.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::globalLoaderDelegateQueue): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Use the new global queue.
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
Marshall the request to the main queue, and return YES (wait) immediately.
- 1:01 PM Changeset in webkit [148905] by
-
- 3 edits in trunk/Source/WebKit2
Don't kill our XPC services in response to memory pressure
https://bugs.webkit.org/show_bug.cgi?id=114985
<rdar://problem/13229217>
Reviewed by Mark Rowe.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
Call xpc_transaction_begin() so we'll never be killed by the kernel when there's memory pressure;
we prefer to manage our own lifetime thank you very much!
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::platformInitialize):
Remove call to disable sudden termination.
- 12:54 PM Changeset in webkit [148904] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13681842> [Mac] Tweak WebProcess sandbox profile to use
system-graphics function when available.
Reviewed by Sam Weinig.
- WebProcess/com.apple.WebProcess.sb.in:
- 12:52 PM Changeset in webkit [148903] by
-
- 13 edits in trunk
[GTK] Set up libPlatform.la
https://bugs.webkit.org/show_bug.cgi?id=114168
Reviewed by Martin Robinson.
.:
- GNUmakefile.am: Define the platform_cppflags and platform_sources variables.
Source/Platform:
- GNUmakefile.am: Set up the libPlatform.la static library to build the source files listed in platform_sources.
As with the libPlatformGtk.la library, only the Source/WebCore/platform and its subdirectories are allowed to be
searched for headers to include, providing a convenient way to detect any platform violations. These directories
are listed in the platform_webcore_cppflags variable.
Source/WebCore:
No new tests - no new functionality.
- GNUmakefile.am: Also add the LevelDB-specific cppflags to the platform_cppflags if required as the LevelDB
code is now built into the new libPlatform.la library.
- GNUmakefile.list.am: Build a small set of non-GTK-specific platform source files that are already free of
platform violations into the new libPlatform.la library.
Source/WebKit/gtk:
- GNUmakefile.am: Add the new libPlatform.la library to the libwebkitgtk library.
Source/WebKit2:
- GNUmakefile.am: Add the new libPlatform.la library to the libwebkitgtk library. Link the WebKitPluginProcess
executable against libPlatform.la as well.
Tools:
- GNUmakefile.am: Link the DumpRenderTree executable against both libPlatform.la and libPlatformGtk.la libraries.
- 12:47 PM Changeset in webkit [148902] by
-
- 6 edits7 adds in trunk/Source/WebKit2
Hard code plug-in sandbox profile lookup directories and move
the profiles to WebKit2.
Reviewed by Anders Carlsson.
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
(WebKit::PluginProcessMainDelegate::getExtraInitializationData):
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(WebKit::PluginServiceInitializerDelegate::getExtraInitializationData):
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
Stop passing the sandbox-profile-directory-path to the plug-in process.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::loadSandboxProfileForDirectory):
(WebKit::loadSandboxProfile):
(WebKit::PluginProcess::initializeSandbox):
Hard code the plug-in sandbox profile lookup to only look in the WebKit2 bundle
and /System/Library/Sandbox/Profiles/.
- Resources/PlugInSandboxProfiles: Added.
Add profiles.
- WebKit2.xcodeproj/project.pbxproj:
Copy the profiles to the bundle.
- 12:37 PM Changeset in webkit [148901] by
-
- 4 edits in trunk/Source/WebKit2
Refactor creation of the full screen window into an (overridable) method.
https://bugs.webkit.org/show_bug.cgi?id=110369
Reviewed by Eric Carlson.
Add a new WKView method -(NSWindow)createFullScreenWindow which can be overridden
by subclasses to provide custom full screen windows to the WKFullScreenWindowController.
- UIProcess/API/mac/WKView.mm:
(-[WKView fullScreenWindowController]):
(-[WKView createFullScreenWindow]):
- UIProcess/API/mac/WKViewPrivate.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController initWithWindow:]):
- 12:13 PM Changeset in webkit [148900] by
-
- 2 edits in trunk/Source/WTF
StringImpl.h should compile with -Wshorten-64-to-32
<http://webkit.org/b/114970>
Reviewed by Darin Adler.
Fixes the following warnings with -Wshorten-64-to-32:
StringImpl.h:317:25: error: implicit conversion loses integer precision: 'uintptr_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
unsigned hash = reinterpret_cast<uintptr_t>(this);
- wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl): Add static_cast<uint32_t>() to
formalize taking the lower 32-bits of the pointer value on
64-bit architectures.
- 11:40 AM Changeset in webkit [148899] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix broken 32-bit build to green the bots.
https://bugs.webkit.org/show_bug.cgi?id=114968.
Unreviewed.
Basically, I moved a JIT::emit_op_loop_hint() and JIT::emitSlow_op_loop_hint()
into common code where they belong, instead of the 64-bit specific section.
Also fixed some SH4 assertions failures which were also caused by
https://bugs.webkit.org/show_bug.cgi?id=114963. Thanks to Julien Brianceau
for pointing this out.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchAdd32):
- jit/JITOpcodes.cpp:
(JSC):
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
- 11:23 AM Changeset in webkit [148898] by
-
- 5 edits in trunk
Range.getClientRects() should not include rects for partially selected elements
https://bugs.webkit.org/show_bug.cgi?id=76839
Reviewed by Sam Weinig.
Source/WebCore:
CSSOM says that Range.getClientRects() should include the border boxes
of each element selected by the range. However, we were also
incorrectly including border boxes for partially selected elements.
For instance, consider the following selection:
<div>line one<br>line two</div>
-------------
The <div> is two lines tall, but only the first line is selected.
Despite this, we'd include the <div>'s border box since its start tag
was included in the selection.
Fix this by excluding partially selected elements. This is accomplished
by skipping over elements that come after the start boundary point of
the range but are ancestors of the end boundary point.
Added test cases to LayoutTests/fast/dom/Range/getClientRects.html.
- dom/Range.cpp:
(WebCore::Range::getBorderAndTextQuads):
LayoutTests:
- fast/dom/Range/getClientRects-expected.txt: Updated expected result.
- fast/dom/Range/getClientRects.html: Added new test cases.
- 11:21 AM Changeset in webkit [148897] by
-
- 2 edits in trunk/Source/JavaScriptCore
2013-04-22 Oliver Hunt <oliver@apple.com>
Perform null check before trying to use the result of readline()
RS=Gavin
- jsc.cpp: (runInteractive):
- 11:19 AM Changeset in webkit [148896] by
-
- 2 edits in trunk/Source/JavaScriptCore
2013-04-22 Oliver Hunt <oliver@apple.com>
Fix assertions to account for new Vector layout
RS=Gavin
- llint/LLIntData.cpp: (JSC::LLInt::Data::performAssertions):
- 11:11 AM Changeset in webkit [148895] by
-
- 3 edits in trunk/LayoutTests
Unreviewed Mac gardening. Update a test and results now that forced text
tracks are supported.
- media/track/track-in-band-expected.txt:
- media/track/track-in-band.html:
- 10:56 AM Changeset in webkit [148894] by
-
- 3 edits2 adds in trunk
Crash on OS X when shift clicking outside of input
https://bugs.webkit.org/show_bug.cgi?id=104058
Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-04-22
Reviewed by Chang Shu.
Source/WebCore:
Shift clicking outside of a focused div while removing the focused div from
the dom tree at the same time may hit a null visible position, which should
not be used to calculate the text distance with the new selection's start and
end position. Otherwise, the browser may crash.
Test: editing/selection/crash-on-shift-click.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick):
LayoutTests:
Add test for shift click crash issue.
- editing/selection/crash-on-shift-click-expected.txt: Added.
- editing/selection/crash-on-shift-click.html: Added.
- 10:37 AM Changeset in webkit [148893] by
-
- 12 edits in trunk/Source/JavaScriptCore
Change baseline JIT watchdog timer check to use the proper fast slow path
infrastructure.
https://bugs.webkit.org/show_bug.cgi?id=114963.
Reviewed by Oliver Hunt.
SH4 parts contributed by Julien Brianceau.
- assembler/ARMAssembler.h:
- assembler/MacroAssemblerARM.h:
- assembler/MacroAssemblerARMv7.h:
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branchAdd32):
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchAdd32):
- assembler/MacroAssemblerX86Common.h:
- assembler/SH4Assembler.h:
- jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
(JSC::JIT::emitEnterOptimizationCheck):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
(JSC::JIT::emit_op_enter):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_enter):
- 10:02 AM Changeset in webkit [148892] by
-
- 2 edits in trunk/Source/WebCore
Scrollbar should not depend on EventHandler, Frame and FrameView
https://bugs.webkit.org/show_bug.cgi?id=114941
Reviewed by Darin Adler.
It's a layering violation that Scrollbar uses EventHandler, Frame
and FrameView. Frame is used to get the EventHandler that is used
to set mousePressed to false after a Scrollbar::mouseUp(). This is
not really needed, since EventHandler already sets m_mousePressed
to false when calling Scrollbar::mouseUp(). The PopupMenu windows
implementation also calls Scrollbar::mouseUp(), but that scrollbar
is not inside a FrameView.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::isScrollViewScrollbar):
isScrollViewScrollbar() is a method of ScrollView so we don't need
to cast to FrameView.
(WebCore::Scrollbar::mouseUp): Remove EventHandler ussage.
- 10:00 AM Changeset in webkit [148891] by
-
- 7 edits in trunk/Source
Shrink baseline size of WTF::Vector on 64-bit by switching to unsigned capacity and size.
<http://webkit.org/b/97268>
<rdar://problem/12376519>
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Update LLInt WTF::Vector offset constants to match the new memory layout.
- llint/LowLevelInterpreter.asm:
Source/WebCore:
- CMakeLists.txt: Add a workaround for GCC 4.6.x in Release mode so it
does not crash.
Source/WTF:
Shrink Vector by 8 bytes on 64-bit by using 32-bit capacity and size.
Vector now inherits from VectorBuffer instead of having a VectorBuffer member;
this is necessary for m_size to fall into the padding after the base class members.
The WTF::Vector API still uses size_t.
Based on Blink r148313 by <cevans@chromium.org>.
- wtf/SizeLimits.cpp:
- wtf/Vector.h:
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(VectorBufferBase):
(WTF::VectorBuffer::shouldReallocateBuffer):
(Vector):
(WTF::Vector::Vector):
(WTF::Vector::capacity):
(WTF::Vector::at):
(WTF::Vector::data):
(WTF::Vector::swap):
(WTF::::Vector):
(WTF::::reserveCapacity):
(WTF::::tryReserveCapacity):
(WTF::::reserveInitialCapacity):
(WTF::::shrinkCapacity):
(WTF::::releaseBuffer):
- 9:43 AM Changeset in webkit [148890] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] URL decode data: URLs before passing to the platform media player.
https://bugs.webkit.org/show_bug.cgi?id=114887
Patch by John Griggs <jgriggs@blackberry.com> on 2013-04-22
Reviewed by Rob Buis.
Pass data URL through URL decoding before passing to platform media player. PR 313635.
Reviewed internally by Liam Quinn
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::load):
- 9:40 AM Changeset in webkit [148889] by
-
- 1 edit1 copy1 move2 adds in trunk/LayoutTests
Fix an incorrect rebaseline done in r148830.
Instead of updating the cross platform wk2 results, r148830 should have added efl wk2
specific results. Move the previous mac wk2 specific results into the mac wk2 platform
directory.
- platform/efl-wk2/loader/go-back-cached-main-resource-expected.txt: Renamed from LayoutTests/platform/wk2/loader/go-back-cached-main-resource-expected.txt.
- platform/mac-wk2/loader/go-back-cached-main-resource-expected.txt: Downloaded from the mac-wk2 bots.
- 9:32 AM Changeset in webkit [148888] by
-
- 2 edits in trunk/Source/WTF
Memory barrier support should also ensure that we always do a compiler fence
https://bugs.webkit.org/show_bug.cgi?id=114934
Reviewed by Michael Saboff.
This is a cherry-pick merge of the WTF part of r148836 from the dfgFourthTier
branch. It fixes a memory ordering bug that is likely asymptomatic, but
nonetheless real: TCSpinLock expects that using a memoryBarrierBeforeUnlock()
prior to setting lockword_ to 0 will ensure that the assignment to lockword_
won't get floated above any of the stores in the critical section. While that
memory barrier does indeed do the right thing on ARM, it doesn't do the right
thing on other architectures: it turns into empty code that the compiler blows
away, which is fine for the hardware since X86 won't reorder that store - but
it's not fine for the compiler, which may still do its own reorderings.
The WTF part of r148836 fixes this by using a compiler fence: an empty asm
volatile block that is marked as clobbering memory.
Instead of doing a separate surgical fix in trunk, I decided to merge the
whole WTF change over, to make merging easier in the future.
Performance testing of this change in dfgFourthTier showed no regression.
- wtf/Atomics.h:
(WTF::compilerFence):
(WTF::armV7_dmb):
(WTF::armV7_dmb_st):
(WTF::loadLoadFence):
(WTF::loadStoreFence):
(WTF::storeLoadFence):
(WTF::storeStoreFence):
(WTF::memoryBarrierAfterLock):
(WTF::memoryBarrierBeforeUnlock):
(WTF::x86_mfence):
- 9:03 AM Changeset in webkit [148887] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add webkit_web_context_set_disk_cache_directory to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111848
Reviewed by Anders Carlsson.
This allow applications to set a custom directory for the disk
cache.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_disk_cache_directory):
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
- UIProcess/API/gtk/tests/TestMain.cpp:
(removeNonEmptyDirectory):
(main): Use a different temporary disk cache directory for every
test.
- 8:57 AM Changeset in webkit [148886] by
-
- 6 edits in trunk/Source/WebKit2
[SOUP] Soup disk cache should respect the diskCacheDirectory from the process initial parameters
https://bugs.webkit.org/show_bug.cgi?id=111845
Reviewed by Anders Carlsson.
Move the cache initialization to platformInitializeWebProcess() to
create the cache using the directory received from the UI
process. This allows to add public API to set a different disk
cache directory from the UI process.
- UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformDefaultDiskCacheDirectory): Return
default disk cache directory.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultDiskCacheDirectory): Ditto.
- WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl): Remove soup cache initialization.
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk): Ditto.
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Initialize
soup cache.
- 8:43 AM Changeset in webkit [148885] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Update BatteryClientBlackBerry to use our port's new listener interface
https://bugs.webkit.org/show_bug.cgi?id=114892
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-04-22
Reviewed by Rob Buis.
PR 328147
Modify the client so we only have one listener for battery change events.
The dispatch of different event listeners are handled by BatteryController.
- WebCoreSupport/BatteryClientBlackBerry.cpp:
(WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
(WebCore::BatteryClientBlackBerry::startUpdating):
(WebCore::BatteryClientBlackBerry::stopUpdating):
(WebCore::BatteryClientBlackBerry::onStatusChange):
- WebCoreSupport/BatteryClientBlackBerry.h:
(BatteryClientBlackBerry):
- 8:31 AM Changeset in webkit [148884] by
-
- 2 edits in trunk/Source/WTF
WTF::AtomicString::find() should take unsigned 'start' argument
<http://webkit.org/b/114958>
Reviewed by Darin Adler.
Fixes the following warnings with -Wshorten-64-to-32:
AtomicString.h:113:76: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
size_t find(UChar c, size_t start = 0) const { return m_string.find(c, start); }
AtomicString.h:115:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
{ return m_string.find(s, start, caseSentitive); }
AtomicString.h:117:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
{ return m_string.find(s, start, caseSentitive); }
- wtf/text/AtomicString.h:
(WTF::AtomicString::find): Change type of 'start' argument from
size_t to unsigned.
- 8:20 AM Changeset in webkit [148883] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Fix build warning when GESTURE_EVENTS is ON.
https://bugs.webkit.org/show_bug.cgi?id=114812
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-04-22
Reviewed by Andreas Kling.
Handle GestureSingleTap in the event type switch.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformHandleMouseEvent):
- 8:02 AM Changeset in webkit [148882] by
-
- 3 edits in trunk/LayoutTests
Update layout test verifying Tab behaves correctly after linking to fragment ID
https://bugs.webkit.org/show_bug.cgi?id=114645
Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-04-22
Reviewed by Chris Fleizach.
- fast/dom/fragment-activation-focuses-target.html: Updated test.
- fast/dom/fragment-activation-focuses-target-expected.txt: Updated expectations.
- 7:26 AM Changeset in webkit [148881] by
-
- 16 edits in trunk
fix build warning(unused parameter)
https://bugs.webkit.org/show_bug.cgi?id=114855
Patch by Xuefei Ren <xren@blackberry.com> on 2013-04-22
Reviewed by Rob Buis.
Source/WebCore:
remove warning(unused parameter) in
Source/WebCore/platform/graphics/blackberry
- platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
(WebCore::CanvasLayerCompositingThreadClient::drawTextures):
(WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
(WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):
- platform/graphics/blackberry/FontBlackBerry.cpp:
(WebCore::Font::offsetForPositionForComplexText):
- platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getTraitsInFamily):
- platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp:
(WebCore::GlyphPage::fill):
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
- platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
- platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::flushAndDraw):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::platformTransformColorSpace):
- platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::drawTile):
- platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::clipPath):
- platform/graphics/blackberry/PatternBlackBerry.cpp:
(WebCore::Pattern::platformPattern):
Source/WebKit/blackberry:
remove warning(unused parameter) in
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::extractedTextRequest):
Tools:
remove warning(unused parameter) in
Tools/DumpRenderTree/blackberry/EventSender.cpp
- DumpRenderTree/blackberry/EventSender.cpp:
(getDragModeCallback):
- 7:24 AM Changeset in webkit [148880] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] ASSERT in FrameLoaderClient::convertMainResourceLoadToDownload
https://bugs.webkit.org/show_bug.cgi?id=114741
Patch by Xan Lopez <xlopez@igalia.com> on 2013-04-22
Reviewed by George Staikos.
Consider the case where a ResourceHandle won't have a FilterStream
object associated (for example, Blob objects) instead of ASSERTing
pointlessly when asking our network layer for such an object.
This partially fixes fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
- 7:19 AM Changeset in webkit [148879] by
-
- 5 edits2 adds in trunk
[BlackBerry] Add additional datalist support.
https://bugs.webkit.org/show_bug.cgi?id=114883
Reviewed by Rob Buis.
PR 210083.
Source/WebCore:
Extend support for datalist to include all non-popup input types.
Re-enabling fast/forms/datalist/input-list
Internally Reviewed by Otto Cheung.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::supportsDataListUI):
Source/WebKit/blackberry:
Properly set state when opening a Date/Time popup and simplify
the logic for showing datalist options.
Internally Reviewed by Otto Cheung.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openDatePopup):
(BlackBerry::WebKit::InputHandler::showTextInputTypeSuggestionBox):
LayoutTests:
Fix results for fast/forms/datalist/input-list.
Internally Reviewed by Otto Cheung.
- platform/blackberry/fast/forms/datalist/input-list-expected.txt: Added.
- 5:39 AM Changeset in webkit [148878] by
-
- 1 edit56 adds in trunk/LayoutTests
[CSS Regions] Add tests for lists and counters
https://bugs.webkit.org/show_bug.cgi?id=103975
Reviewed by Andreas Kling.
Lists and counters work correctly with regions since r148026 (http://trac.webkit.org/changeset/148026).
This patch adds W3C formatted ref tests to our battery.
- fast/regions/counters/extract-list-items-001-expected.html: Added.
- fast/regions/counters/extract-list-items-001.html: Added.
- fast/regions/counters/extract-list-items-002-expected.html: Added.
- fast/regions/counters/extract-list-items-002.html: Added.
- fast/regions/counters/extract-list-items-003-expected.html: Added.
- fast/regions/counters/extract-list-items-003.html: Added.
- fast/regions/counters/extract-list-items-004-expected.html: Added.
- fast/regions/counters/extract-list-items-004.html: Added.
- fast/regions/counters/extract-list-items-005-expected.html: Added.
- fast/regions/counters/extract-list-items-005.html: Added.
- fast/regions/counters/extract-list-items-006-expected.html: Added.
- fast/regions/counters/extract-list-items-006.html: Added.
- fast/regions/counters/extract-list-items-007-expected.html: Added.
- fast/regions/counters/extract-list-items-007.html: Added.
- fast/regions/counters/extract-list-items-008-expected.html: Added.
- fast/regions/counters/extract-list-items-008.html: Added.
- fast/regions/counters/extract-list-items-009-expected.html: Added.
- fast/regions/counters/extract-list-items-009.html: Added.
- fast/regions/counters/extract-list-items-010-expected.html: Added.
- fast/regions/counters/extract-list-items-010.html: Added.
- fast/regions/counters/extract-list-items-011-expected.html: Added.
- fast/regions/counters/extract-list-items-011.html: Added.
- fast/regions/counters/extract-list-items-012-expected.html: Added.
- fast/regions/counters/extract-list-items-012.html: Added.
- fast/regions/counters/extract-list-items-013-expected.html: Added.
- fast/regions/counters/extract-list-items-013.html: Added.
- fast/regions/counters/extract-list-items-014-expected.html: Added.
- fast/regions/counters/extract-list-items-014.html: Added.
- fast/regions/counters/extract-list-items-015-expected.html: Added.
- fast/regions/counters/extract-list-items-015.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Added.
- fast/regions/counters/extract-numbered-paragraphs-expected.html: Added.
- fast/regions/counters/extract-numbered-paragraphs.html: Added.
- fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Added.
- fast/regions/counters/extract-numbered-spans-display-only-some.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-001.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-002.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-003.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Added.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Added.
- fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Added.
- fast/regions/counters/extract-unordered-lists-in-regions.html: Added.
- 4:51 AM Changeset in webkit [148877] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening. css3-device-adaptation doesn't work for WK1 EFL properly.
- platform/efl-wk1/TestExpectations: Added tests related to css3-device-adaptation.
- 4:42 AM Changeset in webkit [148876] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark IndexedDB test as crashing in Release mode and fix duplicate line in
TestExpectations.
- platform/efl/TestExpectations:
- 3:56 AM Changeset in webkit [148875] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL WK1 gardening. Skip pasteboard tests because EFL WK1 doesn't support it yet.
- platform/efl-wk1/TestExpectations:
- 3:51 AM Changeset in webkit [148874] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip several compositing test cases on EFL WK2 due to regression in
r148748.
- platform/efl-wk2/TestExpectations:
- 3:41 AM Changeset in webkit [148873] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Add several regressions to TestExpectations to make the tree green.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 3:32 AM Changeset in webkit [148872] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Fix expected result for several test cases.
- platform/efl/TestExpectations:
- 3:07 AM Changeset in webkit [148871] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Unskipping the fast/sub-pixel layout tests.
Removing failure expectations for tests that are passing after the subpixel layout was enabled.
- 2:58 AM Changeset in webkit [148870] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Add dummy implementations of DragData::droppedFileSystemId()
https://bugs.webkit.org/show_bug.cgi?id=114861
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.
- platform/blackberry/DragDataBlackBerry.cpp:
(WebCore):
(WebCore::DragData::droppedFileSystemId):
- 2:20 AM Changeset in webkit [148869] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 2:14 AM Changeset in webkit [148868] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Unskip fast/exclusions tests after r148594.
- platform/qt/TestExpectations:
- 2:11 AM Changeset in webkit [148867] by
-
- 2 edits in trunk/Tools
[BlackBerry] Add dummy implementation of AccessibilityController::accessibleElementById()
https://bugs.webkit.org/show_bug.cgi?id=114939
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.
This was added in r129308.
- DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
(AccessibilityController::accessibleElementById):
- 2:07 AM Changeset in webkit [148866] by
-
- 2 edits in trunk/LayoutTests
[EFL] accessibility/language-attribute.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112030
Unreviewed, EFL gardening.
Unskipping accessibility/language-attribute.html after r148737.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-04-22
- platform/efl-wk2/TestExpectations:
- 2:05 AM Changeset in webkit [148865] by
-
- 15 edits6 adds in trunk
Source/WebCore: [CSS Regions] Elements in a region should be assignable to a named flow
https://bugs.webkit.org/show_bug.cgi?id=74144
Patch by Mihai Maerean <Mihai Maerean> on 2013-04-22
Reviewed by David Hyatt.
DOM children of a region must not be rendered as children of the region, but can be collected in flow threads.
NodeRenderingContext::parentRenderer now creates the parent render flow thread if it doesn't exist.
Element::moveToFlowThreadIsNeeded is a virtual method that is overriden in PseudoElement to return false and
in SVGElement so only svg root elements can directly be collected by a render flow thread.
RenderObject::canDOMChildrenHaveRenderParent exists to optimize the code so nodes inside regions (and maybe
other types of renderers in the future) can still have renderers if they need to be in a flow thread while the
rest of renderers that can't have children skip the new instructions.
Tests: fast/regions/flow-body-in-html.html . To test the duplicate bug #103685.
fast/regions/region-content-flown-into-region.html
fast/regions/universal-selector-children-to-the-same-region.html . To test the duplicate bug #103685.
- dom/Element.cpp:
(WebCore::Element::moveToFlowThreadIsNeeded):
- dom/Element.h:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer): the renderer that will be the parent for this node's renderer.
In the case of RenderFlowThreads, it may need to create it.
(WebCore::NodeRenderingContext::shouldCreateRenderer): In a region, only the children that need to be in a flow
thread should have a renderer.
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::moveToFlowThread):
- dom/NodeRenderingContext.h:
(NodeRenderingContext):
- dom/PseudoElement.h: pseudo-elements cannot be directly collected into a named flow.
- dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::updateTextRenderer): Because calling textRendererIsNeeded(NodeRenderingContext(...)) on a
non-const l-value NodeRenderingContext cannot be done on a temporary object on the stack.
- dom/Text.h:
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow):
- rendering/FlowThreadController.h:
- rendering/RenderObject.h:
(WebCore::RenderObject::canDOMChildrenHaveRenderParent): Even if this render object can't have render children,
the children in the DOM tree may have a render parent (that is different from this render object).
- rendering/RenderRegion.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::moveToFlowThreadIsNeeded): Allow only svg root elements to be directly collected by a
render flow thread.
- svg/SVGElement.h:
LayoutTests: [CSS Regions] Elements in a region should be assignable to a named flow
https://bugs.webkit.org/show_bug.cgi?id=74144
Reviewed by David Hyatt.
- fast/regions/flow-body-in-html-expected.txt: Added.
Patch by Mihai Maerean <Mihai Maerean> on 2013-04-22
- fast/regions/flow-body-in-html.html: Added. To test the duplicate bug #103685.
- fast/regions/region-content-flown-into-region-expected.txt: Added.
- fast/regions/region-content-flown-into-region.html: Added.
- fast/regions/universal-selector-children-to-the-same-region-expected.txt: Added.
- fast/regions/universal-selector-children-to-the-same-region.html: Added. To test the duplicate bug #103685.
- 1:59 AM Changeset in webkit [148864] by
-
- 2 edits in trunk/Source/WebCore
Gradient: add PlatformGradient definition for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=114727
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.
- platform/graphics/Gradient.h:
(Graphics):
- 1:58 AM FeatureFlags edited by
- (diff)
- 1:32 AM Changeset in webkit [148863] by
-
- 13 edits in trunk
Use DOM ordering for list counts
https://bugs.webkit.org/show_bug.cgi?id=110352
Reviewed by Elliott Sprehn.
Source/WebCore:
Currently the list items ordering is made by traversing the render tree. This gives bad results for:
- list items flown inside regions because they are not rendered as descendants of their DOM list ancestors.
- list items matched to insertion points inside a shadow tree. The insertion point may be a child of a
list so the numbering gets broken.
To implement correct DOM ordering I've taken into account the fact that pseudo-elements can have display: list-item
so they should be included when traversing the DOM tree. I've added helper methods on the NodeTraversal
namespace that should allow easily traversing the tree including the pseudo-elements (e.g. firstChildWithPseudo
for an element with pseudo-before will return the before PseudoElement). Using these helper methods I've implemented
pre-order traversal methods aware of the pseudo-elements.
An effect of this change is how the list items inside shadow tree update their counting. With the patch, if there's
no <ol> or <ul> element on the ancestor chain of a <li> element to the shadow root, the list node will be considered the
first parent of the <li> or the shadow root if there is no ancestor.
The RenderListItem class now makes use of this new method of traversal, replacing the one based on the render tree.
To simplify the CSS counters implementation, I've changed the traversal functions inside RenderCounter to also make use
of this method. The CSS counters and the list items now have the same traversal algorithm.
In later patches I'll add tests that should cover the regions and shadow DOM use cases.
Tests bug for shadow DOM: https://bugs.webkit.org/show_bug.cgi?id=113193
Tests bug for regions: https://bugs.webkit.org/show_bug.cgi?id=103975
Tests: no new tests is this patch; added the correct expectations for fast/lists/positioned-count-crash.html
and fast/dom/shadow/shadow-and-list-elements.html
- dom/Node.cpp:
(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::Node::pseudoAwareFirstChild):
(WebCore::Node::pseudoAwareLastChild):
- dom/Node.h:
(Node):
- dom/NodeTraversal.cpp:
(WebCore):
(WebCore::NodeTraversal::previousIncludingPseudo):
(NodeTraversal):
(WebCore::NodeTraversal::nextIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):
- dom/NodeTraversal.h:
(ElementTraversal):
(NodeTraversal):
(WebCore::ElementTraversal::previousIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
(WebCore::ElementTraversal::pseudoAwarePreviousSibling):
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::attach):
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):
- rendering/RenderCounter.cpp:
(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):
- rendering/RenderListItem.cpp:
(WebCore):
(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):
- rendering/RenderListItem.h:
(RenderListItem):
LayoutTests:
The fast/dom/shadow/shadow-and-list-elements-expected.html has changed because the list items
inside the shadow tree no longer see the root <ol> element.
The test fast/lists/positioned-count-crash.html has the correct rendering after changing
the list counting to be in DOM order.
- fast/dom/shadow/shadow-and-list-elements-expected.html:
- fast/lists/positioned-count-crash-expected.txt:
- 12:57 AM Changeset in webkit [148862] by
-
- 2 edits in trunk/Source/WebCore
Fix multiple definition of ImageBuffer::platformLayer() in the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=114936
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.
We already have a definition in ImageBufferBlackBerry.cpp.
- platform/graphics/ImageBuffer.cpp:
(WebCore):
- 12:49 AM Changeset in webkit [148861] by
-
- 2 edits in trunk/LayoutTests
[GTK] Cleanup TestExpectations to pass --lint-test-files
https://bugs.webkit.org/show_bug.cgi?id=114927
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-22
- platform/gtk/TestExpectations:
- 12:29 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:25 AM Changeset in webkit [148860] by
-
- 9 edits in trunk
[WebKit2] Plugins without a MIME Type fail to load
https://bugs.webkit.org/show_bug.cgi?id=112834
Reviewed by Benjamin Poulain.
Source/WebKit2:
The problem is that when the plugin is created and the MIME Type
is empty, since the MIME Type guessed in the UI process using the
plugin extension is not passed to the WebProcess, when the plugin
is instantiated, the value of NPMIMEType parameter passed to
NPP_New is NULL, and NPERR_INVALID_INSTANCE_ERROR is returned.
GetPluginPath message has been renamed to FindPlugin, since it
doesn't only return the path but also the new MIME Type and load
policy.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin): Receive an output newMIMEType
parameter that is passed to PluginModuleInfo::findPlugin() so that
in case of guessing the MIME Type, the new one is passed back to
the WebProcess.
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin): Pass the MIME Type
from the parameters to WebPage::createPlugin.
(WebKit::WebFrameLoaderClient::recreatePlugin): Pass a newMIMEType
parameter to WebPage::createPlugin.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): Add newMIMEType out parameter and
pass it to the FindPlugin message.
(WebKit::WebPage::canPluginHandleResponse): Pass newMIMEType to
FindPlugin message.
- WebProcess/WebPage/WebPage.h:
(WebPage):
LayoutTests:
- platform/wk2/TestExpectations: Unskip
plugins/no-mime-with-valid-extension.html.
Apr 21, 2013:
- 11:54 PM Changeset in webkit [148859] by
-
- 3 edits2 adds in trunk
Division by zero in CSSGradientValue::addStops()
https://bugs.webkit.org/show_bug.cgi?id=114807
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-21
Reviewed by Dean Jackson.
Source/WebCore:
The normalization of the color stop positions of a linear gradient
doesn't take into account that the first and last position can be
the same. In such case the positions are computed dividing by 0.
Clamp the positions to 1 without moving the end points in such
case to match what other browsers do. This ensures that positions
passed to the platform gradient are in the 0-1 range which fixes a
crash due to an assert in BlackBerry port running test
fast/forms/type-after-focus-rule-shrink-width.html.
Test: fast/gradients/css3-color-stop-invalid.html
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
LayoutTests:
- fast/gradients/css3-color-stop-invalid-expected.html: Added.
- fast/gradients/css3-color-stop-invalid.html: Added.
- 11:52 PM Changeset in webkit [148858] by
-
- 2 edits in trunk/Tools
Unreviewed EFL build fix after r148855.
- TestWebKitAPI/PlatformEfl.cmake:
- 11:21 PM Changeset in webkit [148857] by
-
- 9 edits in trunk/Source
Improve StringImpl code density for older ARM hardware
https://bugs.webkit.org/show_bug.cgi?id=114898
Reviewed by Geoffrey Garen.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
Source/WTF:
Reduce the number of instructions needed for StringImpl::deref
on older ARM hardware.
The extra indirection should have a negligible impact on x86_64.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::destroy):
- wtf/text/StringImpl.h:
(StringImpl):
(WTF::StringImpl::deref):
- 11:06 PM Changeset in webkit [148856] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r148851.
http://trac.webkit.org/changeset/148851
https://bugs.webkit.org/show_bug.cgi?id=114935
EFL Buildbot reports fail after gardening on r148851
(Requested by gyuyoung on #webkit).
- platform/efl/TestExpectations:
- 11:00 PM Changeset in webkit [148855] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Mark WKViewClientWebProcessCallbacks API test as failing
https://bugs.webkit.org/show_bug.cgi?id=114922
Reviewed by Gyuyoung Kim.
Mark WKViewClientWebProcessCallbacks API test as failing on WK2 EFL.
- TestWebKitAPI/PlatformEfl.cmake:
- 10:54 PM Changeset in webkit [148854] by
-
- 3 edits in trunk/Source/WebCore
Fix some minor bad use of strings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=114907
Reviewed by Darin Adler.
- editing/Editor.cpp:
(WebCore::Editor::selectedText): This was implicitly getting the emptyString()
for the argument "".
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::takeResults): ditto.
- 10:32 PM Changeset in webkit [148853] by
-
- 2 edits in branches/dfgFourthTier/Tools
fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
https://bugs.webkit.org/show_bug.cgi?id=114933
Reviewed by Andy Estes.
This makes it easy to get set up for tandem LLVM builds.
- Scripts/copy-webkitlibraries-to-product-directory:
- 9:39 PM Changeset in webkit [148852] by
-
- 26 edits2 copies in trunk
[Part 4] Parse the custom() function in -webkit-filter: parse the matN() functions
https://bugs.webkit.org/show_bug.cgi?id=71444
Reviewed by Dean Jackson.
Source/WebCore:
Custom filter parameters should support mat2 to mat4 value functions. Added parsing
and style resolving bits to support the matrix function values. A later patch will
add the matrices to the shader program.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-parameters
Modified existing tests to cover changes.
- GNUmakefile.list.am: Added WebKitCSSMatFunctionValue to individual build systems.
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForCustomFilterMatParameter):
(WebCore):
(WebCore::valueForCustomFilterParameter):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseMatValue):
(WebCore):
(WebCore::CSSParser::parseCustomFilterParameters):
- css/CSSParser.h:
(WebCore):
- css/CSSValue.cpp:
(WebCore::CSSValue::reportMemoryUsage):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):
- css/CSSValue.h:
(WebCore::CSSValue::isWebKitCSSMatFunctionValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::parseCustomFilterArrayParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
- css/StyleResolver.h:
(StyleResolver):
- css/WebKitCSSMatFunctionValue.cpp:
(WebCore::WebKitCSSMatFunctionValue::WebKitCSSMatFunctionValue):
(WebCore::WebKitCSSMatFunctionValue::customCssText):
(WebCore::WebKitCSSMatFunctionValue::cloneForCSSOM):
(WebCore::WebKitCSSMatFunctionValue::equals):
(WebCore::WebKitCSSMatFunctionValue::reportDescendantMemoryUsage):
- css/WebKitCSSMatFunctionValue.h:
(WebKitCSSMatFunctionValue):
(WebCore::WebKitCSSMatFunctionValue::create):
- platform/graphics/filters/CustomFilterArrayParameter.h:
(WebCore::CustomFilterArrayParameter::create):
(WebCore::CustomFilterArrayParameter::CustomFilterArrayParameter):
- platform/graphics/filters/CustomFilterParameter.h:
(CustomFilterParameter):
- platform/graphics/filters/CustomFilterRenderer.cpp:
(WebCore::CustomFilterRenderer::bindProgramParameters):
LayoutTests:
Added tests for mat2 to mat4 parameter functions on custom fiter function and
parameter descriptor.
- css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-invalid.js:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-valid.js:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js:
- 7:16 PM Changeset in webkit [148851] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. Remove test cases which are expected failed, but passed now.
- platform/efl/TestExpectations:
- 4:59 PM Changeset in webkit [148850] by
-
- 4 edits1 add in branches/dfgFourthTier
fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
https://bugs.webkit.org/show_bug.cgi?id=114926
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Use a phony file that includes a phony header to force JavaScriptCore to be relinked
if necessary. The external LLVM-importing scripts will touch the header if the libraries
are known to have changed.
- JavaScriptCore.xcodeproj/project.pbxproj:
- ftl/WebKitLLVMLibraryAnchor.cpp: Added.
Tools:
Reviewed by Geoffrey Garen.
If the LLVM libraries change, then touch a phony header, which will force relink
of JavaScriptCore.
- Scripts/copy-webkitlibraries-to-product-directory:
(unpackIfNecessary):
- 4:26 PM Changeset in webkit [148849] by
-
- 32 edits in trunk
JS Lexer and Parser should be more informative when they encounter errors
https://bugs.webkit.org/show_bug.cgi?id=114924
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Add new tokens to represent the various ways that parsing and lexing have failed.
This gives us the ability to produce better error messages in some cases,
and to indicate whether or not the failure was due to invalid source, or simply
early termination.
The jsc prompt now makes use of this so that you can write functions that
are more than one line long.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
- jsc.cpp:
(stringFromUTF):
(jscSource):
(runInteractive):
- parser/Lexer.cpp:
(JSC::::parseFourDigitUnicodeHex):
(JSC::::parseIdentifierSlowCase):
(JSC::::parseString):
(JSC::::parseStringSlowCase):
(JSC::::lex):
- parser/Lexer.h:
(UnicodeHexValue):
(JSC::Lexer::UnicodeHexValue::UnicodeHexValue):
(JSC::Lexer::UnicodeHexValue::valueType):
(JSC::Lexer::UnicodeHexValue::isValid):
(JSC::Lexer::UnicodeHexValue::value):
(Lexer):
- parser/Parser.h:
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
(JSC::::parse):
- parser/ParserError.h:
(ParserError):
(JSC::ParserError::ParserError):
- parser/ParserTokens.h:
- runtime/Completion.cpp:
(JSC):
(JSC::checkSyntax):
- runtime/Completion.h:
(JSC):
LayoutTests:
Update test results to cover improved error messages.
- fast/js/kde/parse-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T5-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T10-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T5-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T7-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T8-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T9-expected.txt:
- sputnik/Conformance/13_Function_Definition/S13_A7_T3-expected.txt:
- 4:26 PM Changeset in webkit [148848] by
-
- 2 edits in branches/dfgFourthTier/Tools
fourthTier: developing LLVM in tandem with WebKit should be fun and easy
https://bugs.webkit.org/show_bug.cgi?id=114925
Reviewed by Geoffrey Garen.
This enables building LLVM along with WebKit, so that build-jsc and build-webkit
will also optionally build LLVM and quickly symlink LLVM's built products into
the right places.
Most WebKit and JSC hackers will want to rely on the checked-in already-built
versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
increasingly common use-case for me, and it may become a common use case for a
handful of others. Currently, this is really painful: you first have to build
LLVM, then you have to export-llvm-build (which takes a while), and then you
have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
variables are set to point to the thing you exported. The whole process loses
track of dependencies very quickly: making a tiny change in LLVM requires
packaging, and then unpackaging, a large number of potentially large headers and
static libraries. Not only is this slow but it then causes the WebKit build
system to rebuild anything that transitively includes any LLVM header, which is
now quite a few files. While this sort of use pattern is still worthwhile if
you're trying to package a binary drop and test it, it's not great if you're
just trying to do experimental development that involves making small changes
in both trees.
This change fixes this use case while keeping the old use cases intact. You can
do tandem development using one of two modes:
Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
the LLVM directory you're using. Once this is done, any invocation of a WebKit
build via build-jsc or build-webkit will also build LLVM, and then quickly
symlink things into place without perturbing dependency tracking.
Internal LLVM directory: if you check out llvm into a directory called 'llvm'
right off of the WebKit source tree, then the build system will automatically
use this.
Here's how this takes care of dependencies:
Headers: the include/llvm and include/llvm-c directories are symlinked into
$productsDir/usr/local/include. And then everything just works.
Libraries: the build system detects, by reading LLVM's Makefile.config, which
mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
the .a files into $productsDir/<thingy>. It will ranlib those libraries only
if they have changed, by checking both the modification time and also whether
the last time we had a symlink, that symlink was from the same directory.
This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
but that build wasn't yet ranlib'd.
One problem that this does not yet solve is that xcodebuild will not relink
JavaScriptCore if the only thing that changed was the libraries. I will work
on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
- Scripts/copy-webkitlibraries-to-product-directory:
(unpackIfNecessary):
(fileContains):
(fileContentsEquals):
- 1:52 PM Changeset in webkit [148847] by
-
- 2 edits in trunk/LayoutTests
Regression(r148672): fast/events/touch/frame-hover-update.html fails
https://bugs.webkit.org/show_bug.cgi?id=114912
Reviewed by Allan Sandfeld Jensen.
Fix relative path to js-test-post.js in fast/events/touch/frame-hover-update.html.
- fast/events/touch/frame-hover-update.html:
- 1:28 PM Changeset in webkit [148846] by
-
- 3 edits in trunk/LayoutTests
Rewrite fast/workers/dedicated-worker-lifecycle.html to verify that
the GC is able to reclaim orphaned Workers on a timely basis.
https://bugs.webkit.org/show_bug.cgi?id=114893.
Reviewed by Geoffrey Garen.
- fast/workers/resources/dedicated-worker-lifecycle.js:
(orphanAllWorkers):
(runTests.worker.onmessage):
(runTests):
(orphanedWorkerExited.worker.onmessage):
(orphanedWorkerExited):
- fast/workers/resources/worker-util.js:
(waitUntilThreadCountMatchesCondition):
(waitUntilThreadCountMatches):
(waitUntilThreadCountDoesNotExceed):
- 12:51 PM Changeset in webkit [148845] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark css1/cascade/cascade_order.html as flaky.
- platform/efl/TestExpectations:
- 12:48 PM Changeset in webkit [148844] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark several webgl tests as flaky.
Mark several ref tests as failing (started between r148032 and r148102).
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 12:15 PM Changeset in webkit [148843] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark websocket tests as flaky and webgl/conformance/rendering/gl-scissor-test.html
as failing.
- platform/efl-wk2/TestExpectations:
- 11:53 AM Changeset in webkit [148842] by
-
- 4 edits in branches/safari-536.30-branch/Source
Versioning.
- 11:51 AM Changeset in webkit [148841] by
-
- 1 copy in tags/Safari-536.30.2
New Tag.
- 11:36 AM Changeset in webkit [148840] by
-
- 4 edits2 adds in trunk
[GStreamer] Media attribute preload="none" is not honored
https://bugs.webkit.org/show_bug.cgi?id=114357
Reviewed by Philippe Normand.
Source/WebCore:
Fix the logic that prevents live streams from being buffered to not make preload="none" ignored.
Test: http/tests/media/video-preload.html
We need a http test because the bug does not triggered with local files.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
Remove m_originalPreloadWasAutoAndWasOverridden because it is not necessary and it is causing this bug.
Currently if the tag has preload="none" attribute we set m_preload to Auto in the constructor. After that
MedaPlayer calls setPreload(None), so we set m_originalPreloadWasAutoAndWasOverridden to true and later
reset m_preload to Auto. The error prone factor here is that the m_preload member is repeated in the
private class and setPreload is also used there. This seems to be necessary because we need to be able
to ignore preloading if this is a live stream. Fortunately the original parsed value is available in the
constructor, so we can use that. This will give the correct value that we should override only in the case
of a live stream and that's it, we don't need to reset it later to Auto.
Furthermore, we should ignore setting preload to auto from js if it is a live stream. This patch also handles
this with an early return in setPreload.
LayoutTests:
- http/tests/media/video-preload-expected.txt: Added.
- http/tests/media/video-preload.html: Added.
- 10:46 AM Changeset in webkit [148839] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark several tests as failing on EFL port due to the bump to libsoup
2.42.0.
- platform/efl/TestExpectations:
- 10:34 AM Changeset in webkit [148838] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark several test cases as failing on EFL port and filed bugs for them.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 10:19 AM Changeset in webkit [148837] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark websocket tests as flaky on EFL WK2.
- platform/efl-wk2/TestExpectations:
- 10:11 AM Changeset in webkit [148836] by
-
- 17 edits2 adds in branches/dfgFourthTier/Source
fourthTier: It should be possible to query WatchpointSets, and add Watchpoints, even if the compiler is running in another thread
https://bugs.webkit.org/show_bug.cgi?id=114909
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
The idea here is that a concurrent compiler will use watchpoint sets as follows:
During concurrent compilation: It will create Watchpoints, and query WatchpointSets only
for the purpose of profiling. That is, it will use decide whether it is profitable to
compile the code "as if" the watchpoint sets are valid.
During synchronous linking: By "linking" I don't necessarily mean the LinkBuffer stuff,
but just the very bitter end of compilation where we make the JIT code callable. This
can happen after LinkBuffer stuff. Anyway, this will have to happen synchronously, and
at that point we can (a) check that all WatchpointSets that we assumed were valid are
still valid and (b) if they are then we add the watchpoints to those sets. If any of the
sets are invalid, we give up on this compilation and try again later.
The querying of WatchpointSets is engineered to say that the set is still valid if it
is so *right now*, but this is done in a racy way and so it may say so spuriously: we
may, with hopefully low probability, have a set that says it is valid even though it was
just invalidated. The goal is only to ensure that (i) a set never claims to be invalid
if it is actually valid, (ii) a set doesn't claim to be valid if it was invalidated
before compilation even began, and (iii) querying the validity of a set doesn't cause us
to crash.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/Watchpoint.cpp:
(JSC::InlineWatchpointSet::inflateSlow):
- bytecode/Watchpoint.h:
(WatchpointSet):
(InlineWatchpointSet):
(JSC::InlineWatchpointSet::hasBeenInvalidated):
(JSC::InlineWatchpointSet::isThin):
(JSC::InlineWatchpointSet::isFat):
(JSC::InlineWatchpointSet::fat):
- dfg/DFGDesiredWatchpoints.cpp: Added.
(DFG):
(JSC::DFG::DesiredWatchpoints::DesiredWatchpoints):
(JSC::DFG::DesiredWatchpoints::~DesiredWatchpoints):
(JSC::DFG::DesiredWatchpoints::addLazily):
(JSC::DFG::DesiredWatchpoints::reallyAdd):
(JSC::DFG::DesiredWatchpoints::areStillValid):
- dfg/DFGDesiredWatchpoints.h: Added.
(DFG):
(JSC::DFG::WatchpointForGenericWatchpointSet::WatchpointForGenericWatchpointSet):
(WatchpointForGenericWatchpointSet):
(GenericDesiredWatchpoints):
(JSC::DFG::GenericDesiredWatchpoints::GenericDesiredWatchpoints):
(JSC::DFG::GenericDesiredWatchpoints::addLazily):
(JSC::DFG::GenericDesiredWatchpoints::reallyAdd):
(JSC::DFG::GenericDesiredWatchpoints::areStillValid):
(DesiredWatchpoints):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addLazily):
(JITCompiler):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLCompile.h:
(FTL):
- ftl/FTLState.h:
(State):
- runtime/JSFunction.h:
(JSFunction):
(JSC::JSFunction::allocationProfileWatchpointSet):
- runtime/Structure.h:
(Structure):
(JSC::Structure::transitionWatchpointSet):
Source/WTF:
Reviewed by Oliver Hunt.
Harden our notions of memory fences, now that we're doing racy algorithms.
- wtf/Atomics.h:
(WTF):
(WTF::compilerFence):
(WTF::armV7_dmb):
(WTF::armV7_dmb_st):
(WTF::loadLoadFence):
(WTF::loadStoreFence):
(WTF::storeLoadFence):
(WTF::storeStoreFence):
(WTF::memoryBarrierAfterLock):
(WTF::memoryBarrierBeforeUnlock):
(WTF::x86_mfence):
- 9:14 AM Changeset in webkit [148835] by
-
- 2 edits in trunk/LayoutTests
fast/media/mq-resolution.html throws TypeError when calling setPageScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=114914
Reviewed by Antonio Gomes.
Update fast/media/mq-resolution.html to call setPageScaleFactor() method on
window.internals instead of window.internals.settings. This method was moved
out of settings in r136055.
- fast/media/mq-resolution.html:
- 9:13 AM Changeset in webkit [148834] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebCore
Rollout r145656. <rdar://problem/13691099>
- 8:11 AM Changeset in webkit [148833] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/forms/validation-message-appearance.html and fix expectation
for editing/pasteboard/paste-text-004.html.
- platform/efl/TestExpectations:
- platform/efl/fast/forms/validation-message-appearance-expected.png: Added.
- platform/efl/fast/forms/validation-message-appearance-expected.txt:
- 8:02 AM Changeset in webkit [148832] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark more compositing test cases as crashing due to r148433 for
EFL port.
- platform/efl/TestExpectations:
- 7:22 AM Changeset in webkit [148831] by
-
- 2 edits in trunk/LayoutTests
Regression(r148672): fast/events/touch/frame-hover-update.html fails
https://bugs.webkit.org/show_bug.cgi?id=114912
Reviewed by Allan Sandfeld Jensen.
Fix relative path to js-test-pre.js in the test case.
- fast/events/touch/frame-hover-update.html:
- 7:10 AM Changeset in webkit [148830] by
-
- 5 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline several test cases for EFL port.
- platform/efl-wk2/http/tests/inspector/console-resource-errors-expected.txt:
- platform/efl/fast/backgrounds/background-position-parsing-expected.png:
- platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
- platform/wk2/loader/go-back-cached-main-resource-expected.txt:
- 6:54 AM Changeset in webkit [148829] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Remove duplicate entry in EFL's TestExpectations for:
inspector/debugger/dynamic-script-tag.html
- platform/efl/TestExpectations:
- 6:50 AM Changeset in webkit [148828] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark more compisiting / webgl tests as crashing due to r148433 for
EFL port.
- platform/efl/TestExpectations:
- 5:56 AM Changeset in webkit [148827] by
-
- 51 deletes in trunk/LayoutTests/platform/gtk
Unreviewed GTK gardening. Removing the remaining redundant baselines.
- 5:54 AM Changeset in webkit [148826] by
-
- 208 edits51 adds in trunk/LayoutTests/platform/gtk
Unreviewed GTK gardening. Updating baselines for tests under accessibility, fast/backgrounds, fast/body-propagation,
fast/doctypes, fast/fast-mobile-scrolling, fast/inspector-support, fast/loader, fast/tokenizer and fast/xsl directories
after enabling the subpixel layout.
- 5:46 AM Changeset in webkit [148825] by
-
- 726 edits124 adds in trunk/LayoutTests/platform/gtk/fast
Unreviewed GTK gardening. Updating baselines for tests under fast/block, fast/borders, fast/box-shadow,
fast/box-sizing, fast/canvas, fast/clip and fast/compact directories after enabling subpixel layout.
- 4:06 AM Changeset in webkit [148824] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark several compositing test as crashing on EFL port due to
r148433.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 3:07 AM Changeset in webkit [148823] by
-
- 15 edits in trunk/Source
Widget should not depend on AXObjectCache
https://bugs.webkit.org/show_bug.cgi?id=114514
Reviewed by Chris Fleizach.
Source/WebCore:
Move AXObjectCache usage from platform files to FrameView.
- WebCore.exp.in: Update symbols.
- page/FrameView.cpp:
(WebCore::FrameView::didAddScrollbar): Handle scrollbar updates in
AXObjectCache.
(WebCore::FrameView::willRemoveScrollbar): Handle scrollbar
updates in AXObjectCache and remove the scrollbar from the cache.
- page/FrameView.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar): Use
didAddScrollbar/willRemoveScrollbar
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::didAddScrollbar): This is the old
didAddVerticalScrollbar and didAddHorizontalScrollbar joined in a
single method that receives a ScrollbarOrientation parameter.
(WebCore::ScrollableArea::willRemoveScrollbar): This is the old
willRemoveVerticalScrollbar and
willRemoveHorizontalScrollbarScrollbar joined in a single method
that receives a ScrollbarOrientation parameter.
- platform/ScrollableArea.h:
(ScrollableArea):
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::~Scrollbar): Remove AXObjectCache usage.
- platform/Scrollbar.h:
- platform/Widget.h:
(Widget): Remove axObjectCache() method.
- platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar): Use didAddScrollbar.
(WebCore::RenderLayer::destroyScrollbar): Use willRemoveScrollbar.
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::createScrollbar): Use didAddScrollbar.
(WebCore::RenderListBox::destroyScrollbar): Use willRemoveScrollbar.
Source/WebKit2:
Update to API changes.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::createScrollbar):
- WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
(WebKit::SimplePDFPlugin::createScrollbar):
(WebKit::SimplePDFPlugin::destroyScrollbar):
- 2:26 AM Changeset in webkit [148822] by
-
- 529 edits121 adds in trunk/LayoutTests/platform/gtk/fast
Unreviewed GTK gardening. Updating baselines for tests under fast/css, fast/css-generated-content,
fast/css3-text and fast/dom directories after enabling the subpixel layout.
- 2:18 AM Changeset in webkit [148821] by
-
- 611 edits171 adds in trunk/LayoutTests/platform/gtk/fast
Unreviewed GTK gardening. Updating baselines for tests under fast/dynamic, fast/encoding, fast/events,
fast/flexbox, fast/forms, fast/frames, fast/gradients, fast/hidpi and fast/html directories after enabling subpixel layout.
- 2:04 AM Changeset in webkit [148820] by
-
- 2 edits in trunk/Source/JavaScriptCore
Refactor identical inline functions in JSVALUE64 and JSVALUE32_64 sections
out into the common section.
https://bugs.webkit.org/show_bug.cgi?id=114910.
Reviewed by Filip Pizlo.
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::callOperation):
- 1:23 AM Changeset in webkit [148819] by
-
- 305 edits170 adds in trunk/LayoutTests/platform/gtk/fast
Unreviewed GTK gardening. Updating baselines for tests under fast/images, fast/inline, fast/inline-block,
fast/invalid, fast/js, fast/layers, fast/line-grid, fast/lists and fast/multicol directories after enabling subpixel layout.
- 1:15 AM Changeset in webkit [148818] by
-
- 379 edits80 adds in trunk/LayoutTests/platform/gtk/fast
Unreviewed GTK gardening. Updating baselines for tests under fast/overflow, fast/parser, fast/reflections,
fast/regions and fast/repaint directories after enabling subpixel layout.
- 1:05 AM Changeset in webkit [148817] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening. Remove duplicated tests.
- platform/efl/TestExpectations:
- 12:48 AM Changeset in webkit [148816] by
-
- 645 edits157 adds in trunk/LayoutTests/platform/gtk
Unreviewed GTK gardening. Updating baselines for tests under fast/replaced, fast/ruby, fast/runin,
fast/scrolling, fast/selectors, fast/spatial-navigation, fast/subpixel and mathml directories after enabling subpixel layout.
- 12:38 AM Changeset in webkit [148815] by
-
- 547 edits178 adds in trunk/LayoutTests/platform/gtk
Unreviewed GTK gardening. Updating baselines for tests under fast/text, fast/transforms, fast/writing-mode,
ietestcenter, media, plugins and scrollbars directories after enabling the subpixel layout.
- 12:29 AM Changeset in webkit [148814] by
-
- 20 deletes in trunk/LayoutTests/platform/gtk/svg
Unreviewed GTK gardening. Removing redundant baselines under the svg/ directory.
- 12:27 AM Changeset in webkit [148813] by
-
- 175 edits17 adds in trunk/LayoutTests/platform/gtk/svg/dynamic-updates
Unreviewed GTK gardening. Part 2 of updating baselines for tests under svg/dynamic-updates after enabling the subpixel layout.
- 12:22 AM Changeset in webkit [148812] by
-
- 138 edits33 adds2 deletes in trunk/LayoutTests/platform/gtk/svg/dynamic-updates
Unreviewed GTK gardening. Part 1 of updating baselines for tests under svg/dynamic-updates after enabling the subpixel layout.
- 12:15 AM Changeset in webkit [148811] by
-
- 668 edits52 adds in trunk/LayoutTests/platform/gtk/tables/mozilla/bugs
Unreviewed GTK gardening. Part 3 of updating baselines for tests under the tables/ directory
after enabling the subpixel layout.
- 12:06 AM Changeset in webkit [148810] by
-
- 658 edits30 adds in trunk/LayoutTests/platform/gtk/tables/mozilla
Unreviewed GTK gardening. Part 2 of updating baselines for tests under the tables/ directory
after enabling the subpixel layout.
