Timeline

Apr 27, 2013:

9:53 PM Changeset in webkit [149256] by jberlin@webkit.org

• 2 edits in trunk/Source/WebKit2

Build fix.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveBuffer):
Do not declare another variable with the same name.

8:51 PM Changeset in webkit [149255] by Darin Adler

• 171 edits in trunk/Source

Move from constructor and member function adoptCF/NS to free function adoptCF/NS.
​https://bugs.webkit.org/show_bug.cgi?id=115307

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• heap/HeapTimer.cpp:

(JSC::HeapTimer::HeapTimer):

• runtime/VM.cpp:

(JSC::enableAssembler):
Use adoptCF free function.

Source/WebCore:

This change was done by a global replace followed by compiling and inspecting for
cases that needed to be tweaked by hand.

• accessibility/ios/AXObjectCacheIOS.mm:

(WebCore::AXObjectCache::attachWrapper):

• accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::attachWrapper):

• bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::methodNamed):
(JSC::Bindings::ObjcClass::fieldNamed):

• bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcField::ObjcField):

• editing/mac/EditorMac.mm:

(WebCore::Editor::fontAttributesForSelectionStart):

• history/cf/HistoryPropertyList.cpp:

(WebCore::HistoryPropertyListWriter::releaseData):

• html/HTMLMediaElement.cpp:

(WebCore::createFileURLForApplicationCacheResource):

• loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::rawDataRepresentation):

• loader/archive/cf/LegacyWebArchiveMac.mm:

(WebCore::LegacyWebArchive::createPropertyListRepresentation):

• loader/mac/ResourceLoaderMac.mm:

(WebCore::ResourceLoader::willCacheResponse):

• page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::userPrefersCaptions):
(WebCore::CaptionUserPreferencesMac::userPrefersSubtitles):
(WebCore::CaptionUserPreferencesMac::captionsWindowCSS):
(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS):
(WebCore::CaptionUserPreferencesMac::captionsTextColor):
(WebCore::CaptionUserPreferencesMac::captionsDefaultFontCSS):
(WebCore::CaptionUserPreferencesMac::preferredLanguages):
(WebCore::trackDisplayName):

• platform/Language.cpp:

(WebCore::displayNameForLanguageLocale):

• platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagSearchWeb):
(WebCore::imageTitle):

• platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):

• platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::AudioFileReader):

• platform/cf/KURLCFNet.cpp:

(WebCore::KURL::fileSystemPath):

• platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::maybeTransferPlatformData):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsToImage):

• platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:

(WebCore::LayerFlushScheduler::schedule):

• platform/graphics/ca/mac/PlatformCAAnimationMac.mm:

(PlatformCAAnimation::PlatformCAAnimation):

• platform/graphics/ca/mac/PlatformCAFiltersMac.mm:

(PlatformCAFilters::filterValueForOperation):

• platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::addAnimationForKey):
(PlatformCALayer::setBackgroundColor):
(PlatformCALayer::setBorderColor):

• platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::getCGImageArray):

• platform/graphics/cg/ColorCG.cpp:

(WebCore::cachedCGColor):

• platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::setURLForRect):

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::createIOSurface):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::putByteArray):
(WebCore::CGImageEncodeToData):
(WebCore::CGImageToDataURL):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):

• platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData):
(WebCore::ImageBufferData::putData):

• platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::imageWithColorSpace):
(WebCore::Image::drawPattern):

• platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::setData):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):

• platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::dataChanged):

• platform/graphics/cg/PathCG.cpp:

(WebCore::createScratchContext):
(WebCore::Path::contains):

• platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):
(WebCore::createFeatureSettingDictionary):
(WebCore::cascadeToLastResortFontDescriptor):
(WebCore::cascadeToLastResortAndDisableSwashesFontDescriptor):
(WebCore::FontPlatformData::ctFont):
(WebCore::FontPlatformData::description):

• platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::DrawingBuffer):

• platform/graphics/mac/ComplexTextControllerCoreText.mm:

(-[WebCascadeList objectAtIndex:]):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

• platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

• platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill):

• platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

• platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawFocusRing):
(WebCore::linearRGBColorSpaceRef):

• platform/graphics/mac/ImageMac.mm:

(WebCore::BitmapImage::getTIFFRepresentation):
(WebCore::BitmapImage::getNSImage):

• platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
(WebCore::addFileTypesToCache):

• platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

• platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::fontHasVerticalGlyphs):
(WebCore::SimpleFontData::getCompositeFontReferenceFontData):
(WebCore::SimpleFontData::platformCharWidthInit):
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

• platform/graphics/mac/WebGLLayer.mm:

(-[WebGLLayer copyImageSnapshotWithColorSpace:]):

• platform/mac/ContentFilterMac.mm:

(WebCore::ContentFilter::ContentFilter):

• platform/mac/ContextMenuItemMac.mm:

(WebCore::ContextMenuItem::ContextMenuItem):

• platform/mac/CursorMac.mm:

(WebCore::createCustomCursor):
(WebCore::createNamedCursor):

• platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):

• platform/mac/DragImageMac.mm:

(WebCore::dissolveDragImageToFraction):
(WebCore::createDragImageFromImage):

• platform/mac/HTMLConverter.mm:

(+[WebHTMLConverter editingAttributedStringFromRange:]):

• platform/mac/Language.mm:

(WebCore::httpStyleLanguageCode):
(WebCore::platformUserPreferredLanguages):

• platform/mac/LocalizedStringsMac.cpp:

(WebCore::localizedString):

• platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::getDataSelection):
(WebCore::Pasteboard::writeSelectionForTypes):
(WebCore::fragmentFromWebArchive):

• platform/mac/PlatformClockCM.mm:

(PlatformClockCM::PlatformClockCM):
(PlatformClockCM::initializeWithTimingSource):

• platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::addTypes):
(WebCore::PlatformPasteboard::setTypes):
(WebCore::PlatformPasteboard::setPathnamesForType):

• platform/mac/PlatformSpeechSynthesizerMac.mm:

(WebCore::PlatformSpeechSynthesizer::speak):

• platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenuMac::populate):
(WebCore::PopupMenuMac::show):

• platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateExpansionTransitionWithDuration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):

• platform/mac/SharedBufferMac.mm:

(WebCore::SharedBuffer::createCFData):

• platform/mac/WebCoreNSStringExtras.mm:

(stringEncodingForResource):

• platform/network/ProtectionSpace.cpp:

(WebCore::ProtectionSpace::receivesCredentialSecurely):

• platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::platformBadResponseError):

• platform/network/cf/CredentialStorageCFNet.cpp:

(WebCore::CredentialStorage::getFromPersistentStorage):

• platform/network/cf/DNSCFNet.cpp:

(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):

• platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::advanceCurrentStream):

• platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::overrideCookieStorage):

• platform/network/cf/ProxyServerCFNet.cpp:

(WebCore::proxyAutoConfigurationResultCallback):
(WebCore::processProxyServers):
(WebCore::addProxyServersForURL):

• platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformLazyInit):
(WebCore::ResourceError::cfError):

• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::handleDataArray):

• platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::setHeaderFields):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::setStorageSession):

• platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::cfURLResponse):
(WebCore::ResourceResponse::platformLazyInit):

• platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::executePACFileURL):
(WebCore::SocketStreamHandle::chooseProxy):
(WebCore::SocketStreamHandle::createStreams):
(WebCore::SocketStreamHandle::addCONNECTCredentials):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::reportErrorToClient):

• platform/network/mac/AuthenticationMac.mm:

(WebCore::mac):
(WebCore::AuthenticationChallenge::setAuthenticationClient):

• platform/network/mac/CookieJarMac.mm:

(WebCore::filterCookies):

• platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):

• platform/network/mac/ResourceErrorMac.mm:

(WebCore::createNSErrorFromResourceErrorBase):
(WebCore::ResourceError::nsError):

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):

• platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::updateNSURLRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):

• platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::initNSURLResponse):
(WebCore::ResourceResponse::nsURLResponse):
(WebCore::ResourceResponse::platformLazyInit):

• platform/network/mac/UTIUtilities.mm:

(WebCore::mimeTypeFromUTITree):

• platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary):

• platform/text/cf/HyphenationCF.cpp:

(WebCore::::createValueForNullKey):
(WebCore::lastHyphenLocation):

• platform/text/mac/HyphenationMac.mm:

(WebCore::::createValueForKey):
(WebCore::lastHyphenLocation):

• platform/text/mac/LocaleMac.mm:

(WebCore::determineLocale):
(WebCore::LocaleMac::LocaleMac):
(WebCore::LocaleMac::initializeLocaleData):

• platform/text/mac/TextBreakIteratorInternalICUMac.mm:

(WebCore::textBreakLocalePreference):
(WebCore::canonicalLanguageIdentifier):

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::RenderThemeMac::levelIndicatorFor):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::popupButton):
(WebCore::RenderThemeMac::search):
(WebCore::RenderThemeMac::searchMenuTemplate):
(WebCore::RenderThemeMac::sliderThumbHorizontal):
(WebCore::RenderThemeMac::sliderThumbVertical):
(WebCore::RenderThemeMac::textField):
Use adoptNS and adoptCF free functions.

Source/WebKit/cf:

• WebCoreSupport/WebInspectorClientCF.cpp:

(populateSetting): Use adoptCF.

Source/WebKit/mac:

This change was done by a global replace followed by compiling and inspecting for
cases that needed to be tweaked by hand.

• DefaultDelegates/WebDefaultContextMenuDelegate.mm:

(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):

• Misc/WebNSFileManagerExtras.mm:

(-[NSFileManager _webkit_startupVolumeName]):

• Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):

• Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::spawnPluginHost):
(WebKit::NetscapePluginHostManager::instantiatePlugin):

• Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::beginModal):
(WKPCBooleanAndDataReply):

• Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::print):
(WebKit::NetscapePluginInstanceProxy::snapshot):
(WebKit::NetscapePluginInstanceProxy::status):
(WebKit::NetscapePluginInstanceProxy::loadURL):
(WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
(WebKit::NetscapePluginInstanceProxy::enumerate):
(WebKit::NetscapePluginInstanceProxy::marshalValue):
(WebKit::NetscapePluginInstanceProxy::marshalValues):
(WebKit::NetscapePluginInstanceProxy::demarshalValue):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):

• Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView setAttributeKeys:andValues:]):
(-[WebHostedNetscapePluginView createPlugin]):

• Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebBaseNetscapePluginView cacheSnapshot]):
(WebKit::getAuthenticationInfo):

• Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage initWithPath:]):

• Plugins/WebNetscapePluginEventHandlerCarbon.mm:

(WebNetscapePluginEventHandlerCarbon::startTimers):

• Plugins/WebNetscapePluginEventHandlerCocoa.mm:

(WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
(WebNetscapePluginEventHandlerCocoa::handleTSMEvent):

• Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _initWithPath:]):

• Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::WebNetscapePluginStream):
(WebNetscapePluginStream::deliverData):
(WebNetscapePluginStream::deliverDataToFile):
(WebNetscapePluginStream::didReceiveData):

• Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView createPlugin]):
(-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):

• Storage/WebDatabaseManagerClient.mm:

(WebDatabaseManagerClient::dispatchDidModifyOrigin):
(WebDatabaseManagerClient::dispatchDidModifyDatabase):

• Storage/WebStorageTrackerClient.mm:

(WebStorageTrackerClient::dispatchDidModifyOrigin):

• WebCoreSupport/CorrectionPanel.mm:

(CorrectionPanel::handleAcceptedReplacement):

• WebCoreSupport/WebApplicationCache.mm:

(+[WebApplicationCache originsWithCache]):

• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::didRunInsecureContent):

• WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):

• WebView/WebFullScreenController.mm:

(-[WebFullScreenController enterFullScreen:]):

• WebView/WebPDFDocumentExtras.mm:

(allScriptsInPDFDocument):

• WebView/WebPreferences.mm:

(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences initWithCoder:]):

• WebView/WebScriptDebugger.mm:

(WebScriptDebugger::initGlobalCallFrame):
(WebScriptDebugger::callEvent):

• WebView/WebView.mm:

(-[WebView previousValidKeyView]):
Use adoptNS and adoptCF free functions.

Source/WebKit2:

This change was done by a global replace followed by compiling and inspecting for
cases that needed to be tweaked by hand.

• Platform/cg/CGUtilities.cpp:

(WebKit::paintBitmapContext):

• Platform/mac/ModuleMac.mm:

(WebKit::Module::load):
(WebKit::Module::platformFunctionPointer):

• PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::initializeSandbox):

• Shared/API/c/mac/WKURLRequestNS.mm:

(WKURLRequestCreateWithNSURLRequest):

• Shared/API/c/mac/WKURLResponseNS.mm:

(WKURLResponseCreateWithNSURLResponse):

• Shared/Downloads/mac/DownloadMac.mm:

(WebKit::Download::start):
(WebKit::Download::startWithHandle):

• Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:

(WebKit::ChildProcessMain):

• Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::getPluginArchitecture):
(WebKit::contentsOfPropertyListAtURL):
(WebKit::getMIMETypesFromPluginBundle):
(WebKit::getStringListResource):
(WebKit::NetscapePluginModule::getPluginInfo):

• Shared/ShareableResource.cpp:

(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):

• Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::decode):
(CoreIPC::encode):

• Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::makeCGImageCopy):
(WebKit::ShareableBitmap::makeCGImage):
(WebKit::ShareableBitmap::createCGImage):

• Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::decode):

• Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::dump):

• Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

• UIProcess/API/mac/FindIndicatorWindow.mm:

(WebKit::FindIndicatorWindow::setFindIndicator):
(WebKit::FindIndicatorWindow::startFadeOutTimerFired):

• UIProcess/API/mac/PDFViewController.mm:

(-[WKPDFView initWithFrame:PDFViewController:]):
(WebKit::PDFViewController::PDFViewController):
(WebKit::convertPostScriptDataSourceToPDF):
(WebKit::PDFViewController::setPDFDocumentData):

• UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::setDragImage):

• UIProcess/API/mac/WKBrowsingContextController.mm:

(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):

• UIProcess/API/mac/WKConnection.mm:

(didReceiveMessage):

• UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView drawRect:]):

• UIProcess/API/mac/WKView.mm:

(-[WKView browsingContextController]):
(-[WKView _setAcceleratedCompositingModeRootLayer:]):
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):
(-[WKView fullScreenWindowController]):
(-[WKView _executeSavedCommandBySelector:]):
(-[WKView printOperationWithPrintInfo:forFrame:]):

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::createProcess):

• UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::pluginPathsInDirectory):
(WebKit::PluginInfoStore::getMIMETypeForExtension):

• UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::beginModal):

• UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation):

• UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::sessionStateData):
(WebKit::WebPageProxy::restoreFromSessionStateData):
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):

• UIProcess/cf/WebPreferencesCF.cpp:

(WebKit::cfStringFromWebCoreString):
(WebKit::setStringValueIfInUserDefaults):
(WebKit::setBoolValueIfInUserDefaults):
(WebKit::setUInt32ValueIfInUserDefaults):
(WebKit::setDoubleValueIfInUserDefaults):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
(WebKit::WebPreferences::platformUpdateDoubleValueForKey):
(WebKit::WebPreferences::platformUpdateFloatValueForKey):

• UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::resetScrolledRect):
(WebKit::BackingStore::backingStoreContext):

• UIProcess/mac/CorrectionPanel.mm:

(WebKit::CorrectionPanel::handleAcceptedReplacement):

• UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):

• UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):

• UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultDiskCacheDirectory):

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::populate):

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):

• UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::populate):
(WebKit::WebPopupMenuProxyMac::showPopupMenu):

• WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::load):

• WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::updatePluginLayer):

• WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

(WebKit::PluginProxy::pluginLayer):

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::PDFPlugin):
(WebKit::PDFPlugin::createScrollbar):
(WebKit::PDFPlugin::pdfDocumentDidLoad):
(WebKit::PDFPlugin::writeItemsToPasteboard):

• WebProcess/Plugins/PDF/SimplePDFPlugin.mm:

(getAllScriptsInPDFDocument):
(WebKit::SimplePDFPlugin::pdfDocumentDidLoad):
(WebKit::SimplePDFPlugin::streamDidReceiveData):
(WebKit::SimplePDFPlugin::manualStreamDidReceiveData):

• WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::clearCacheForOrigin):

• WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:

(WebKit::WebResourceCacheManager::cfURLCacheHostNames):
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames):

• WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(WebKit::createNSError):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawPagesToPDF):

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange):
(WebKit::cachedResponseForURL):
(WebKit::WebPage::drawPagesToPDFFromPDFDocument):

• WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformSetCacheModel):
Use adoptCF and adoptNS free functions.

Source/WTF:

• wtf/RunLoopTimerCF.cpp:

(WTF::RunLoopTimerBase::start):

• wtf/SchedulePair.h:

(WTF::SchedulePair::SchedulePair):

• wtf/SchedulePairMac.mm:

(WTF::SchedulePair::SchedulePair):

• wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::userDefault):
Use adoptCF free function.

8:43 PM Changeset in webkit [149254] by rniwa@webkit.org

• 3 edits
  2 adds in trunk

Pressing mouse button inside a dragstart event causes a crash
​https://bugs.webkit.org/show_bug.cgi?id=115296

Reviewed by Darin Adler.

Source/WebCore:

Add a missing null pointer check. We should better encapsulate the states in DragState in the long term
but this is good enough for now.

Test: fast/events/mousedown-inside-dragstart-should-not-cause-crash.html

• page/EventHandler.cpp:

(WebCore::EventHandler::handleDrag):

LayoutTests:

Added a regression test. While the bug report involves opening inspector and setting a breakpoint,
a simpler reduction that uses eventSender significantly reduces the complexity.

• fast/events/mousedown-inside-dragstart-should-not-cause-crash-expected.txt: Added.
• fast/events/mousedown-inside-dragstart-should-not-cause-crash.html: Added.

8:38 PM Changeset in webkit [149253] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/13757007> Crashes in NetworkResourceLoader::didReceiveResponseAsync
​https://bugs.webkit.org/show_bug.cgi?id=115318

Reviewed by Darin Adler.

sendAbortingOnFailure may actually fail, and abort the request, making m_handle null.

• NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::didReceiveResponseAsync): Null check m_handle after sending a message, because the request will cancelled when connection is invalid. (WebKit::NetworkResourceLoader::didReceiveBuffer): Assert that m_handle matches the handle that we are called with. (WebKit::NetworkResourceLoader::didFinishLoading): Ditto. (WebKit::NetworkResourceLoader::didFail): Ditto. (WebKit::NetworkResourceLoader::willSendRequestAsync): Ditto. (WebKit::NetworkResourceLoader::didSendData): Ditto. (WebKit::NetworkResourceLoader::shouldUseCredentialStorage): Ditto. (WebKit::NetworkResourceLoader::shouldUseCredentialStorageAsync): Ditto. (WebKit::NetworkResourceLoader::didReceiveAuthenticationChallenge): Ditto. (WebKit::NetworkResourceLoader::didCancelAuthenticationChallenge): Ditto. (WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync): Ditto.

8:37 PM Changeset in webkit [149252] by andersca@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:

8:22 PM Changeset in webkit [149251] by ap@apple.com

• 5 edits in trunk/Source/WebKit2

<rdar://problem/13757687> Threads get stuck in NetworkProcess when canceling loads
​https://bugs.webkit.org/show_bug.cgi?id=115319

Reviewed by Darin Adler.

WebResourceLoader was second-guessing NetworkProcess as to whether it needs a response
to DidReceiveResponseWithCertificateInfo, and it was guessing wrong if the load was
alrady canceled on WebProcess side.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponseAsync):

• WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):

• WebProcess/Network/WebResourceLoader.h:
• WebProcess/Network/WebResourceLoader.messages.in:

6:17 PM Changeset in webkit [149250] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix when disabling video and video-track.

• platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

5:09 PM Changeset in webkit [149249] by ggaren@apple.com

• 3 edits in trunk/Source/WebCore

WebGL shouldn't allocate a "length" Identifier just to move some numbers around
​https://bugs.webkit.org/show_bug.cgi?id=115317

Reviewed by Dean Jackson.

Saw this while debugging an ammo.js bug.

• bindings/js/JSArrayBufferViewHelper.h:

(WebCore::setWebGLArrayWithTypedArrayArgument):
(WebCore::setWebGLArrayHelper):
(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore::constructArrayBufferView):

• bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toVector): Use the pre-computed "length" identifier instead of
allocating a new one for each vector operation. There are lots more
optimizations we could do here. This is a start.

4:14 PM Changeset in webkit [149248] by fpizlo@apple.com

• 9 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: SymbolTable should be thread-safe
​https://bugs.webkit.org/show_bug.cgi?id=115301

Reviewed by Geoffrey Garen.

Makes SymbolTable thread-safe. Relies on SymbolTableEntry already being immutable,
other than the WatchpointSet; but the WatchpointSet already has a righteous
concurrency protocol. So, this patch just protects the SymbolTable's HashMap.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::nameForRegister):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar):

• runtime/Executable.cpp:

(JSC::ProgramExecutable::addGlobalVar):

• runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnNonIndexPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):

• runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):

• runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

• runtime/SymbolTable.cpp:

(JSC::SymbolTable::SymbolTable):
(JSC::SymbolTable::~SymbolTable):

• runtime/SymbolTable.h:

(JSC::SymbolTable::find):
(JSC::SymbolTable::get):
(JSC::SymbolTable::inlineGet):
(JSC::SymbolTable::begin):
(JSC::SymbolTable::end):
(JSC::SymbolTable::size):
(JSC::SymbolTable::add):
(JSC::SymbolTable::set):
(JSC::SymbolTable::contains):

4:14 PM Changeset in webkit [149247] by ggaren@apple.com

• 26 edits in trunk

Cleaned up pre/post inc/dec in bytecode
​https://bugs.webkit.org/show_bug.cgi?id=115222

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

A few related changes here:

(*) Removed post_inc and post_dec. The two-result form was awkward to
reason about. Being explicit about the intermediate mov and to_number
reduces DFG overhead, removes some fragile ASSERTs from the DFG, and
fixes a const bug. Plus, we get to blow away 262 lines of code.

(*) Renamed pre_inc and pre_dec to inc and dec, since there's only one
version now.

(*) Renamed to_jsnumber to to_number, to match the ECMA name.

(*) Tightened up the codegen and runtime support for to_number.

• JavaScriptCore.order: Order!

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

• bytecode/Opcode.h:

(JSC::padOpcodeName):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitInc):
(JSC::BytecodeGenerator::emitDec):

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitToNumber):
(BytecodeGenerator): Removed post_inc and post_dec.

• bytecompiler/NodesCodegen.cpp:

(JSC::emitPreIncOrDec): Updated for rename.

(JSC::emitPostIncOrDec): Issue an explicit mov and to_number when needed.
These are rare, and they boil away in the DFG.

(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve): For const, use an explicit mov instead
of any special forms. This fixes a bug where we would do string
add/subtract instead of number.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

• jit/JIT.h:
• jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_inc):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emitSlow_op_dec):

• jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_inc):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emitSlow_op_dec): Removed post_inc/dec, and updated for renames.

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_number):
(JSC::JIT::emitSlow_op_to_number): Removed a test for number cells. There's
no such thing!

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_to_number): Use LowestTag to avoid making assumptions
about the lowest valued tag.

(JSC::JIT::emitSlow_op_to_number): Updated for renames.

• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

• jit/JITStubs.h:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• llint/LLIntSlowPaths.h:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• parser/NodeConstructors.h:

(JSC::UnaryPlusNode::UnaryPlusNode): Removed post_inc/dec, and updated for renames.

• runtime/Operations.cpp:

(JSC::jsIsObjectType): Removed a test for number cells. There's
no such thing!

LayoutTests:

• fast/js/const-expected.txt:
• fast/js/resources/const.js: Added tests for some const cases we used

to get wrong.

4:02 PM Changeset in webkit [149246] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

Regression tests that reference a non-local resource crash with NetworkProcess enabled
​https://bugs.webkit.org/show_bug.cgi?id=115290

Reviewed by Sam Weinig.

Covered by fast/dom/icon-url-change.html and many other existing tests.

• WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::remove): Handle this case. Architecturally, it
would be better if SubresourceLoad::create just created an object an didn't do
further checks before returning a pointer, but changing that is beyond the scope
of the fix.

1:55 PM Changeset in webkit [149245] by andersca@apple.com

• 5 edits in trunk/Source/WebCore

Remove two more StorageTask types
​https://bugs.webkit.org/show_bug.cgi?id=115312

Reviewed by Dean Jackson.

• storage/StorageTask.cpp:

(WebCore::StorageTask::performTask):

• storage/StorageTask.h:
• storage/StorageTracker.cpp:

(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::deleteOrigin):

• storage/StorageTracker.h:

1:44 PM Changeset in webkit [149244] by andersca@apple.com

• 5 edits in trunk/Source/WebCore

Get rid of more uses of StorageTask
​https://bugs.webkit.org/show_bug.cgi?id=115311

Reviewed by Dean Jackson.

Make StorageAreaSync derive from ThreadSafeRefCounted as well, since it's passed between threads.

• storage/StorageAreaSync.h:
• storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::scheduleImport):
(WebCore::StorageSyncManager::scheduleSync):
(WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase):

• storage/StorageTask.cpp:

(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::performTask):

• storage/StorageTask.h:

(StorageTask):

1:32 PM Changeset in webkit [149243] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Indent StorageAreaSync to match the style guidelines.

Rubber-stamped by Andreas Kling.

• storage/StorageAreaSync.h:

1:28 PM Changeset in webkit [149242] by andersca@apple.com

• 6 edits in trunk/Source/WebCore

Replace uses of StorageTask with StorageThread::dispatch and WTF::bind
​https://bugs.webkit.org/show_bug.cgi?id=115309

Reviewed by Andreas Kling.

• storage/StorageTask.cpp:

(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::performTask):

• storage/StorageTask.h:
• storage/StorageThread.cpp:

(WebCore::StorageThread::terminate):
(WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads):

• storage/StorageThread.h:
• storage/StorageTracker.cpp:

(WebCore::StorageTracker::importOriginIdentifiers):
(WebCore::StorageTracker::deleteAllOrigins):

12:59 PM Changeset in webkit [149241] by andersca@apple.com

• 5 edits in trunk/Source/WebCore

Add StorageThread::dispatch
​https://bugs.webkit.org/show_bug.cgi?id=115308

Reviewed by Andreas Kling.

StorageThread::dispatch takes a Function<void ()> and runs it on the storage thread. This will be used to eventually get rid of StorageTask.

• storage/StorageTask.cpp:

(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::performTask):

• storage/StorageTask.h:

(WebCore::StorageTask::createDispatch):

• storage/StorageThread.cpp:

(WebCore::StorageThread::dispatch):

• storage/StorageThread.h:

(StorageThread):

11:25 AM Changeset in webkit [149240] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r149114): cache flush for SH4 arch may flush an extra page.
​https://bugs.webkit.org/show_bug.cgi?id=115305

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-04-27
Reviewed by Andreas Kling.

• assembler/SH4Assembler.h:

(JSC::SH4Assembler::cacheFlush):

11:23 AM Changeset in webkit [149239] by fpizlo@apple.com

• 5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: WatchpointSet should make racy uses easier to reason about
​https://bugs.webkit.org/show_bug.cgi?id=115299

Reviewed by Anders Carlsson.

The compiler often does things like:

1c) Observe something that would imply that a WatchpointSet ought to be invalid

2c) Check that it is invalid

The main thread often does things like:

1m) Fire the watchpoint set

2m) Do some other thing that would cause the compiler to assume that the WatchpointSet
ought to be invalid

An example is structure transitions, where (1c) is the compiler noticing that a
put_by_id inline cache is in a transition state, with the source structure being S;
(2c) is the compiler asserting that S's watchpoint set is invalid; (1m) is the main
thread firing S's watchpoint set before it does the first transition away from S; and
(2m) is the main thread caching the put_by_id transition away from S.

This is totally fine, except that (1c) and (2c), and (1m) and (2m) could be reordered.
Probably, in most cases, this ought to do enough things that the main thread probably
already has some fencing. But the compiler thread definitely doesn't have fencing. In
any case, we should play it safe and just have additional fencing in all of the
relevant places.

We already have some idioms to put load-load and store-store fences in the right
places. But this change just makes WatchpointSet take care of this for us, thus
reducing the chances of us getting this wrong.

• bytecode/Watchpoint.cpp:

(JSC::WatchpointSet::notifyWriteSlow):

• bytecode/Watchpoint.h:

(WatchpointSet):
(JSC::WatchpointSet::isStillValid):
(JSC::WatchpointSet::hasBeenInvalidated):
(JSC::InlineWatchpointSet::hasBeenInvalidated):
(JSC::InlineWatchpointSet::notifyWrite):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGDesiredWatchpoints.h:

(JSC::DFG::GenericDesiredWatchpoints::shouldAssumeMixedState):

11:18 AM Changeset in webkit [149238] by rakuco@webkit.org

• 2 edits in trunk/Tools

[EFL] Unreviewed Intel bots fix after r149231.

• efl/jhbuild.modules: Disable the libxml Python bindings since the

bots don't have Python's development files installed. libxml should
detect this kind of thing better.

10:08 AM Changeset in webkit [149237] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r147261): Audio controls background not displayed after loading audio file
​https://bugs.webkit.org/show_bug.cgi?id=115221

Reviewed by Darin Adler.

As in r147261, set a flex-shrink: 0 to avoid shrinking the media controls panel
below the specified height.

No new tests; fixes the media/media-document-audio-repaint.html test.

• css/mediaControlsQuickTime.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

9:51 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com

Adding a merge proposal for 2.0.2. (diff)

Apr 26, 2013:

11:43 PM Changeset in webkit [149236] by ggaren@apple.com

• 16 edits
  2 adds in trunk

Source/JavaScriptCore: Re-landing <​http://trac.webkit.org/changeset/148999>

Filled out more cases of branch folding in bytecode when emitting
expressions into a branching context
​https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Phil Pizlo.

We can't fold the number == 1 case to boolean because all non-zero numbers
down-cast to true, but only 1 is == to true.

Source/WTF: Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
​https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Filip Pizlo.

Added a helper constructor for TriState so clients can make one without
branching or making assumptions about the integer values of TriStates.

• wtf/TriState.h:

(WTF::triState):
(WTF):

LayoutTests: Re-landing <​http://trac.webkit.org/changeset/148999>

Filled out more cases of branch folding in bytecode when emitting
expressions into a branching context
​https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Phil Pizlo.

Added a more exhaustive correctness test.

• fast/js/branch-fold-correctness-expected.txt: Added.
• fast/js/branch-fold-correctness.html: Added.

11:33 PM Changeset in webkit [149235] by fpizlo@apple.com

• 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

Fix indentation of SymbolTable.h

Rubber stamped by Mark Hahnenberg.

• runtime/SymbolTable.h:

11:28 PM Changeset in webkit [149234] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Correct indentation of SymbolTable.h

Rubber stamped by Mark Hahnenberg.

• runtime/SymbolTable.h:

10:44 PM Changeset in webkit [149233] by fpizlo@apple.com

• 16 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: CFA should defend against results seeming inconsistent due to a watchpoint firing during compilation
​https://bugs.webkit.org/show_bug.cgi?id=115083

Reviewed by Geoffrey Garen.

This ruggedizes our racyness with respect to watchpoints. We want to be able to assert,
in some places, that a watchpoint-based optimization has only occurred if the
watchpoint set was still valid. But currently we *can* soundly do watchpoint-based
optimizations even for invalid watchpoints, so long as we recorded in the IR that we
had done so; this will then lead to the code being insta-jettisoned after compilation
completes. Obviously, we don't want this to happen often - but we do want to allow it
precisely in the case of watchpoint races.

This adds the ability to assert that we hadn't over-watchpointed ourselves, with and
exemption for races.

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

• dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::setFuturePossibleStructure):
(JSC::DFG::AbstractValue::filterFuturePossibleStructure):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addStructureTransitionCheck):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):

• dfg/DFGDesiredWatchpoints.h:

(GenericDesiredWatchpoints):
(JSC::DFG::GenericDesiredWatchpoints::isStillValid):
(JSC::DFG::GenericDesiredWatchpoints::shouldAssumeMixedState):
(JSC::DFG::GenericDesiredWatchpoints::isValidOrMixed):
(JSC::DFG::DesiredWatchpoints::isStillValid):
(JSC::DFG::DesiredWatchpoints::shouldAssumeMixedState):
(JSC::DFG::DesiredWatchpoints::isValidOrMixed):
(DesiredWatchpoints):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::masqueradesAsUndefinedWatchpointIsStillValid):
(Graph):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

• dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addLazily):
(JITCompiler):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):

• dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::DFG::SpeculativeJIT::speculationWatchpointForMasqueradesAsUndefined):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLCompile.cpp:

(JSC::FTL::compile):

• ftl/FTLState.h:

(State):

10:30 PM Changeset in webkit [149232] by jer.noble@apple.com

• 5 edits
  3 adds in trunk

Video playback has corruption on the edges of the video
​https://bugs.webkit.org/show_bug.cgi?id=115216

Reviewed by Simon Fraser.

Source/WebCore:

Test: media/video-poster-background.html

RenderImage correctly answers foregroundIsKnownToBeOpaqueInRect() method
when a poster image is displayed, but once the video begins playing and
the poster image is no longer displayed, RenderImage will continue to
answer 'true' even when the video does not occupy the entire render box.
Override foregroundIsKnownToBeOpaqueInRect() in order to more correctly
answer the question for the video layer.

• rendering/RenderImage.h: Make foregroundIsKnownToBeOpaqueInRect() protected

(vs. private).

• rendering/RenderVideo.cpp:

(WebCore::RenderVideo::foregroundIsKnownToBeOpaqueInRect): Added. Return

true if the rect parameter is entirely contained by the video box.

• rendering/RenderVideo.h:

LayoutTests:

• media/content/test.jpg: Added.
• media/video-poster-background-expected.html: Added.
• media/video-poster-background.html: Added.

9:41 PM Changeset in webkit [149231] by ryuan.choi@samsung.com

• 2 edits in trunk/Tools

[EFL] Build break using jhbuild on ubuntu 13.04
​https://bugs.webkit.org/show_bug.cgi?id=115225

Reviewed by Gyuyoung Kim.

libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
libxml 2.9.0 has a bug to make regression which r138422 mentioned.
So this patch bumped libxml version to 2.9.1.

• efl/jhbuild.modules:

6:31 PM Changeset in webkit [149230] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

[WK2][EFL] Build break after r149212
​https://bugs.webkit.org/show_bug.cgi?id=115294

Patch by Yael Aharon <​yael.aharon@intel.com> on 2013-04-26
Reviewed by Simon Fraser.
r144672 bumped up the revision of WKContextClient API, and introduced a version array
APIClientTraits<WKContextClient>::interfaceSizesByVersion .
In r149212, the version was bumped back down and the version array was emptied but not removed.
This causes a warning "array subscript is below array bounds", and in EFL the warning is
treated as error.

• Shared/APIClientTraits.cpp:

(WebKit):

• Shared/APIClientTraits.h:

5:51 PM Changeset in webkit [149229] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed. Skipping some more tests that still need rebaselining after disabling subpixel layout on mac.
​http://bugs.webkit.org/show_bug.cgi?id=115292

• TestExpectations:

5:51 PM Changeset in webkit [149228] by jpfau@apple.com

• 2 edits in trunk/Tools

delete-stale-build-files does not clear .d files
​http://bugs.webkit.org/show_bug.cgi?id=115293

Reviewed by Ryosuke Niwa.

• BuildSlaveSupport/delete-stale-build-files:

(main): Add .d to the file type list

5:38 PM Changeset in webkit [149227] by roger_fong@apple.com

• 2 edits in trunk/WebKitLibraries

Disable sub-pixel-layout on Apple Windows port, VS2005 edition.

• win/tools/vsprops/FeatureDefines.vsprops:

5:35 PM Changeset in webkit [149226] by hmuller@adobe.com

• 12 edits in trunk/Source/WebCore

[CSS Exclusions] ExclusionShape bounding box methods should return LayoutRects
​https://bugs.webkit.org/show_bug.cgi?id=115117

Reviewed by Dirk Schulze.

Redefined the ExclusionShape API in terms of LayoutUnits, instead of floats: all of the
ExclusionShape methods now have LayoutUnit parameters and return LayoutUnit values.
This is more natural, since the callers work exclusively in LayoutUnits.

This is strictly a refactoring, no new tests were needed.

• rendering/ExclusionPolygon.cpp:

(WebCore::ExclusionPolygon::getExcludedIntervals):
(WebCore::ExclusionPolygon::getIncludedIntervals):
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop):

• rendering/ExclusionPolygon.h:
• rendering/ExclusionRectangle.cpp:

(WebCore::ExclusionRectangle::getExcludedIntervals):
(WebCore::ExclusionRectangle::getIncludedIntervals):
(WebCore::ExclusionRectangle::firstIncludedIntervalLogicalTop):

• rendering/ExclusionRectangle.h:
• rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape):

• rendering/ExclusionShape.h:

(LineSegment):
(ExclusionShape):

• rendering/ExclusionShapeInfo.cpp:

(WebCore):
(WebCore::::computedShape):

• rendering/ExclusionShapeInfo.h:

(WebCore):
(WebCore::ExclusionShapeInfo::shapeLogicalTop):
(WebCore::ExclusionShapeInfo::shapeLogicalBottom):
(ExclusionShapeInfo):

• rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop):

• rendering/ExclusionShapeInsideInfo.h:
• rendering/ExclusionShapeOutsideInfo.h:

5:17 PM Changeset in webkit [149225] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Nil-check the results of -[AVPlayerItemVideoOutput copyPixelBufferForItemTime:itemTimeForDisplay:].
​https://bugs.webkit.org/show_bug.cgi?id=115265

Reviewed by Eric Carlson.

copyPixelBufferForItemTime:itemTimeForDisplay: can return nil, even
when hasNewPixelBufferForItemTime: returns YES. Check the results
before passing the buffer on to VTPixelTransferSessionTransferImage()
which does not NULL-check its parameters.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createPixelBuffer):

5:09 PM Changeset in webkit [149224] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed. Skipping some tests that still need rebaselining after disabling subpixel layout on mac.
​http://bugs.webkit.org/show_bug.cgi?id=115292

• TestExpectations:

4:45 PM Changeset in webkit [149223] by roger_fong@apple.com

• 2 edits in trunk/Source/WebCore

Uninflate caret rect.
​http://bugs.webkit.org/show_bug.cgi?id=114997.
<rdar://problem/12629007>.

Reviewed by Timothy Horton.

Inflation was causing painting errors with focus rings.
It is no longer needed after disabling subpixel layout.

• editing/FrameSelection.cpp:

(WebCore::repaintCaretForLocalRect):

4:40 PM Changeset in webkit [149222] by roger_fong@apple.com

• 3 edits
  66 adds in trunk/LayoutTests

Unreviewed. More rebaselines for mac after disabling sub-pixel layout.

4:40 PM Changeset in webkit [149221] by roger_fong@apple.com

• 2 edits in trunk/WebKitLibraries

Disable sub-pixel-layout on Apple Windows port.

• win/tools/vsprops/FeatureDefines.props:

4:17 PM Changeset in webkit [149220] by roger_fong@apple.com

• 216 edits
  1 delete in trunk

Make Apple Windows VS2010 build results into and get dependencies from 32 suffixed folders.
Make the DebugSuffix configuration use _debug dependencies.

4:06 PM Changeset in webkit [149219] by Martin Robinson

• 5 edits in trunk/Source/WebKit2

[GTK] Add methods to add a user style sheet to the WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=99081

Reviewed by Carlos Garcia Campos, Gustavo Noronha Silva, and Benjamin Poulain.

Add methods to WebKitWebViewGroup to add and remove user style sheets.
This allows clients to inject style sheets into pages with a set of
rules for when those style sheets apply.

• UIProcess/API/gtk/WebKitWebViewGroup.cpp:

(toImmutableArray): Added this helper which converts the GList* parameters into
ImmutableArrays for use with the WebKit2 internal API.
(webkit_web_view_group_add_user_style_sheet): Added new API for adding a style sheet.
(webkit_web_view_group_remove_all_user_style_sheets): Add new API for clearing out all style sheets.

• UIProcess/API/gtk/WebKitWebViewGroup.h: Added new method declarations.
• UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new API to the documentation.
• UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp: Added a test for the new API.

(isStyleSheetInjectedForURLAtPath): Function to check whether the style sheet has been injected for a given URL.
(fillURLListFromPaths): Helper which converts paths passed via varargs into a whitelist or blacklist.
(removeOldInjectedStyleSheetsAndResetLists): Function to start afresh.
(testWebViewGroupInjectedStyleSheet): The actual test.
(serverCallback): Server callback for use with the test. We cannot use loadHTML or
loadAlternateHTML, because that checks the whitelist and blacklist against about:blank.
(beforeAll): Initialize the server and new test.
(afterAll): Clean up the server.

3:29 PM Changeset in webkit [149218] by roger_fong@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix.

• platform/LayoutUnit.h:

(WebCore::LayoutUnit::LayoutUnit):

3:22 PM Changeset in webkit [149217] by ap@apple.com

• 8 edits in trunk/Source/WebKit2

2013-04-26 Simon Cooper <​scooper@apple.com>

Permit ~/Library or ~/Library/Preferences to be symlinks
​https://bugs.webkit.org/show_bug.cgi?id=115142
<rdar://problem/12953603>

Reviewed by Alexey Proskuryakov.

Pass in two new parameters which are the resolved paths to ~/Library
and ~/Library/Preferences. Added new expansion functions and
substituted the new functions for home-regex, home-subpath and
home-literal for places referencing resources in "~/Library" or
"~/Library/Preferences".

• Resources/PlugInSandboxProfiles/com.apple.QuickTime Plugin.plugin.sb:
• Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
• Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:
• Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
• Resources/PlugInSandboxProfiles/com.microsoft.SilverlightPlugin.sb:
• Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb:
• Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::initializeSandbox):

3:20 PM Changeset in webkit [149216] by msaboff@apple.com

• 4 edits in trunk/Source/WebCore

WebCore ObjC bridge is missing support for bool type
​https://bugs.webkit.org/show_bug.cgi?id=115276

Reviewed by Geoffrey Garen.

Added code to handle conversion between ObjC and JS booleans.

• bridge/objc/objc_instance.mm:

(ObjcInstance::invokeObjcMethod):

• bridge/objc/objc_utility.h:
• bridge/objc/objc_utility.mm:

(JSC::Bindings::convertValueToObjcValue):
(JSC::Bindings::convertObjcValueToValue):
(JSC::Bindings::objcValueTypeForType):

3:15 PM Changeset in webkit [149215] by mrowe@apple.com

• 1 edit in tags/Safari-537.39.1/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm

Build fix.

3:15 PM Changeset in webkit [149214] by mrowe@apple.com

• 4 edits in tags/Safari-537.39.1/Source

Versioning.

3:09 PM Changeset in webkit [149213] by mrowe@apple.com

• 1 copy in tags/Safari-537.39.1

New tag.

2:54 PM Changeset in webkit [149212] by ap@apple.com

• 4 edits in trunk/Source/WebKit2

[WK2] WKContextClient doesn't need to be versioned yet
​https://bugs.webkit.org/show_bug.cgi?id=115279

Reviewed by Anders Carlsson.

• Shared/APIClientTraits.cpp:
• Shared/APIClientTraits.h:
• UIProcess/API/C/WKContext.h:

2:39 PM Changeset in webkit [149211] by andersca@apple.com

• 8 edits in trunk/Source/WebKit2

Downloads need to be converted from the NSURLConnection, not canceled and restarted, when using the NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=115277
<rdar://problem/12890184>

Reviewed by Sam Weinig.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
Ask the download manager to convert the main resource load to a download.

• NetworkProcess/NetworkConnectionToWebProcess.messages.in:

Add new message.

• NetworkProcess/NetworkResourceLoader.h:

(WebKit::NetworkResourceLoader::handle):
Add getter.

• Shared/Downloads/mac/DownloadMac.mm:

(dispatchOnMainThread):
Helper function that ensures that a given block is called on the main thread.

(-[WKDownloadAsDelegate downloadDidBegin:]):
(-[WKDownloadAsDelegate download:didReceiveAuthenticationChallenge:]):
(-[WKDownloadAsDelegate download:didReceiveResponse:]):
(-[WKDownloadAsDelegate download:didReceiveDataOfLength:]):
(-[WKDownloadAsDelegate download:shouldDecodeSourceDataOfMIMEType:]):
(-[WKDownloadAsDelegate download:decideDestinationWithSuggestedFilename:]):
(-[WKDownloadAsDelegate download:didCreateDestination:]):
(-[WKDownloadAsDelegate downloadDidFinish:]):
(-[WKDownloadAsDelegate download:didFailWithError:]):
Use dispatchOnMainThread.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
Remove code that cancels the current load and starts a new download.

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::convertMainResourceLoadToDownload):
Send the ConvertMainResourceLoadToDownload message to the network process.

2:25 PM Changeset in webkit [149210] by roger_fong@apple.com

• 865 edits
  359 adds
  262 deletes in trunk/LayoutTests

Unreviewed. Rebaseline a bunch of tests and run optimize-baselines after disabling sub-pixel layout on mac.
​https://bugs.webkit.org/show_bug.cgi?id=114999.

2:19 PM Changeset in webkit [149209] by roger_fong@apple.com

• 9 edits in trunk/Source

Disable sub-pixel layout on mac.
​https://bugs.webkit.org/show_bug.cgi?id=114999.

Reviewed by Simon Fraser.

• Configurations/FeatureDefines.xcconfig:
• WebCore.exp.in:

Export symbol needed to be added for IntRect(const LayoutRect&) constructor,
which is now being used in pixelSnappedIntRect(const LayoutRect&) in LayoutRect.h after disabling sub-pixel layout.

2:13 PM Changeset in webkit [149208] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

Inspector window is often blank when opened
​https://bugs.webkit.org/show_bug.cgi?id=115220
<rdar://problem/13735496>

Reviewed by Tim Horton.

After disabling tiled scrolling and accelerated drawing in r149006, the
Inspector window was often missing its content after opening. This only
happened when the user has a preference on disk to use accelerated drawing
in the Inspector.

The missing content was caused by a failure to connect the correct contextID
for remote layer hosting. On window creation, we hook up a context using
WindowServer layer hosting (the default), but then switch back to app-hosted
layers for the Inspector window. This switching happens in didUpdateBackingStoreState(),
but that can be re-entered via its call to sendUpdateBackingStoreState(). In
that cause, on unwinding the stack it would call enterAcceleratedCompositingMode()
with a stale layerTreeContext.

Fix by moving the code that exits/enters accelerated compositing mode to before
the call to sendUpdateBackingStoreState() that can cause re-entrancy. That avoids
use of a possibly stale layerTreeContext.

• UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):

2:13 PM Changeset in webkit [149207] by Simon Fraser

• 4 edits in trunk/Source

Layer-backed WebViews don't repaint content outside the visible area
​https://bugs.webkit.org/show_bug.cgi?id=115275

Reviewed by Beth Dakin.

Source/WebCore:

Export ScrollView::setPaintsEntireContents(bool).

• WebCore.exp.in:

Source/WebKit/mac:

When a client of WebView makes the WebView be layer-backed, then
AppKit propagaes the layer-backing down to the WebHTMLView (but
no further).

In this situation, we had a bug where content that was not
in the visible content rect would not get repainted, because
WebCore clips repaints to the visible rect.

Fix by calling ScrollView::setPaintsEntireContents(bool) from
-[WebHTMLView setLayer:], saying that we need
to paint the entire contents if we have a layer.

• WebView/WebHTMLView.mm:

(-[WebHTMLView setLayer:]):

1:34 PM Changeset in webkit [149206] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Check for valid element in elementTouched
​https://bugs.webkit.org/show_bug.cgi?id=115205

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-04-26
Reviewed by Rob Buis.

Internally reviewed by Genevieve Mak.

PR 331546
We might receive a null ptr from nodeAsElementIfApplicable which
is passed in here. Check to make sure it's valid before using.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::elementTouched):

1:12 PM Changeset in webkit [149205] by oliver@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Make stack tracing more robust
​https://bugs.webkit.org/show_bug.cgi?id=115272

Reviewed by Geoffrey Garen.

CallFrame already handles stack walking confusion robustly,
so we should make sure that the actual walk handles that as well.

• interpreter/Interpreter.cpp:

(JSC::getCallerInfo):

12:42 PM Changeset in webkit [149204] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

Crashes under ResourceHandle::continueDidReceiveResponse when loading blobs
​https://bugs.webkit.org/show_bug.cgi?id=115273

Reviewed by Anders Carlsson.

Covered by multiple existing tests (when using NetworkProcess), including:

• http/tests/fileapi/blob-url-in-subframe.html
• http/tests/fileapi/create-blob-url-from-data-url.html

• NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::continueDidReceiveResponse): Work around BlobResourceHandle badness.

12:09 PM Changeset in webkit [149203] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Change RenderMeter::valueRatio() visibility to public
​https://bugs.webkit.org/show_bug.cgi?id=115266

This function is currently unused.
However, it is necessary to implement a RenderTheme capable of rendering Meter elements.

Patch by Daker Fernandes Pinheiro <​daker.pinheiro@openbossa.org> on 2013-04-26
Reviewed by Alexis Menard.

No new tests, because no behaviour is changed.

• rendering/RenderMeter.h:

(RenderMeter):

12:08 PM Changeset in webkit [149202] by timothy@apple.com

• 6 edits
  1 add in trunk/Source

Add Runtime.parse to the Inspector protocol.

This will be used to parse console expressions for errors
before evaluating them fully.

​https://webkit.org/b/115242

Reviewed by Oliver Hunt.

• ForwardingHeaders/parser/ParserError.h: Added.
• inspector/Inspector.json:
• inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::parse):

• inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

12:04 PM Changeset in webkit [149201] by benjamin@webkit.org

• 2 edits in trunk/Source/WebCore

Fix the copyright years after r149057

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-26

• page/DiagnosticLoggingKeys.cpp: I accidentally removed a year from

the copyright in r149057.

11:57 AM Changeset in webkit [149200] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Web Inspector: Crash due to null items from getDOMStorageItems
​https://bugs.webkit.org/show_bug.cgi?id=115176

Patch by Konrad Piascik <​kpiascik@blackberry.com> on 2013-04-26
Reviewed by Joseph Pecoraro.

Source/WebCore:

findStorageArea was returning a null storageArea causing the items
input paramater to not be set. This was happening without any error
being set at all. Set an error to prevent a crash when we try to
convert the result to a JSON string.

Added tests to check if session and local storage are empty that
they are still functional.

• inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):

LayoutTests:

Tests to check that if local and session storage are empty
that they still work corerctly.

• inspector/storage-panel-dom-storage-empty-expected.txt: Added.
• inspector/storage-panel-dom-storage-empty.html: Added.

11:40 AM Changeset in webkit [149199] by ap@apple.com

• 3 edits in trunk/Source/WebKit2

[WK2] Remove NetworkResourceLoader::cleanupOnMainThread
​https://bugs.webkit.org/show_bug.cgi?id=115268

Reviewed by Brady Eidson.

All cleanup() callers are now on main thread, and this indirection only complicates debugging.

• NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::connectionToWebProcessDidClose): (WebKit::NetworkResourceLoader::abortInProgressLoad): (WebKit::NetworkResourceLoader::didFinishLoading): (WebKit::NetworkResourceLoader::didFail):
• NetworkProcess/NetworkResourceLoader.h:

11:24 AM Changeset in webkit [149198] by aestes@apple.com

• 3 edits in trunk/Source/WebKit2

[WebKit2] CustomProtocolManager's m_registeredSchemes HashSet can be accessed by multiple threads
​https://bugs.webkit.org/show_bug.cgi?id=115267

Reviewed by Alexey Proskuryakov.

• Shared/Network/CustomProtocols/CustomProtocolManager.h: Added a Mutex to protect m_registeredSchemes.
• Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::registerScheme): Acquired the mutex before accessing m_registeredSchemes.
(WebKit::CustomProtocolManager::unregisterScheme): Ditto.
(WebKit::CustomProtocolManager::supportsScheme): Ditto.

11:10 AM Changeset in webkit [149197] by eric.carlson@apple.com

• 2 edits in trunk/LayoutTests

[Mac] media/track/track-mode.html sometimes trigger InvalidStateError
​https://bugs.webkit.org/show_bug.cgi?id=115045

Reviewed by Alexey Proskuryakov.

• media/track/track-mode.html: Don't assume that the video element is ready for seeking

after a 100ms timeout.

10:51 AM Changeset in webkit [149196] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

Blobs are not associated with connection when there are no sandbox extensions
​https://bugs.webkit.org/show_bug.cgi?id=115264

Reviewed by Brady Eidson.

Covered by multiple fast/files tests when using NetworkProcess.

• NetworkProcess/FileAPI/NetworkBlobRegistry.cpp: (WebKit::NetworkBlobRegistry::registerBlobURL): Fixed a logic error.

10:41 AM Changeset in webkit [149195] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[GTK] Clean up the TestWebKitAPI GNUmakefile.am
​https://bugs.webkit.org/show_bug.cgi?id=115233

Reviewed by Martin Robinson.

Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.

• TestWebKitAPI/GNUmakefile.am:

9:55 AM Changeset in webkit [149194] by aestes@apple.com

• 11 edits
  3 copies
  2 adds in trunk

[WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
​https://bugs.webkit.org/show_bug.cgi?id=115223

Reviewed by Darin Adler.

Source/WebKit2:

When WebKit performs a synchronous load on the Mac, it spins a nested
run loop in a mode that only accepts input from the NSURLConnection
performing the load. When the load is for a custom protocol in WebKit2,
we proxy it to the UI process via CoreIPC messages, but the response
messages from the UI process are never processed as long as the run
loop is in a non-common mode (and we wouldn't want to process messages
that could re-enter WebCore in the middle of loading, anyway). Since
these messages never make it back to the NSURLConnection handling the
request, the connection eventually times out.

Fix this by using a work queue to handle custom protocol messages in
the networking process. The work queue can process incoming custom
protocol messages while the main thread is blocked.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeConnection): Called
initializeConnection() on all the NetworkProcess's supplements.

• Shared/ChildProcessSupplement.h: Added a base class for

NetworkProcessSupplement and WebProcessSupplement which defines
initializeConnection and provides an empty default implementation.
(WebKit::ChildProcessSupplement::~ChildProcessSupplement):
(WebKit::ChildProcessSupplement::initializeConnection):

• Shared/Network/CustomProtocols/CustomProtocolManager.h:
• Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::CustomProtocolManager): Instantiated a
work queue for message processing.
(WebKit::CustomProtocolManager::initializeConnection): Added the work
queue as a message receiver on the CoreIPC connection.
(WebKit::CustomProtocolManager::initialize): If we're in the web
process and the network process is being used, unregister and destroy
the work queue we previously created. It'd be better to not create it
in the first place, but we have to register our work queue with the
CoreIPC connection before it is established, which is before the UI
process has told us whether the network process is in use.

• Shared/Network/NetworkProcessSupplement.h: Inherited from

ChildProcessSupplement.

• WebKit2.xcodeproj/project.pbxproj: Added ChildProcessSupplement.h.
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection): Called
initializeConnection() on all the WebProcess's supplements.

• WebProcess/WebProcessSupplement.h: Inherited from

ChildProcessSupplement.

Tools:

Added an API test.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
• TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.

(TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
when it loads a request with a custom protocol.

• TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
• TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the

NSURLProtocol subclass to TestProtocol.{h, mm} and did some
miscellaneous cleanup.

• TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
• TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.

(+[TestProtocol canInitWithRequest:]):
(+[TestProtocol canonicalRequestForRequest:]):
(+[TestProtocol requestIsCacheEquivalent:toRequest:]):
(+[TestProtocol scheme]):
(-[TestProtocol startLoading]):
(-[TestProtocol stopLoading]):

9:24 AM Changeset in webkit [149193] by Martin Robinson

• 49 edits in trunk

Remove the remaining Skia #ifdefs
​https://bugs.webkit.org/show_bug.cgi?id=114886

Reviewed by Benjamin Poulain.

Source/WebCore:

• html/HTMLCanvasElement.cpp: Remove Skia #ifdef references.
• platform/graphics/BitmapImage.cpp: Ditto.
• platform/graphics/FloatPoint.h: Ditto.
• platform/graphics/FloatRect.h: Ditto.
• platform/graphics/FontCache.h: Ditto.
• platform/graphics/Gradient.cpp: Ditto.
• platform/graphics/Gradient.h: Ditto.
• platform/graphics/GraphicsContext.cpp: Ditto.
• platform/graphics/GraphicsContext.h: Ditto.
• platform/graphics/GraphicsContext3D.h: Ditto.
• platform/graphics/ImageBuffer.cpp: Ditto.
• platform/graphics/ImageBuffer.h: Ditto.
• platform/graphics/ImageBufferData.h: Ditto.
• platform/graphics/IntPoint.h: Ditto.
• platform/graphics/IntRect.h: Ditto.
• platform/graphics/NativeImagePtr.h: Ditto.
• platform/graphics/Path.h: Ditto.
• platform/graphics/Pattern.cpp: Ditto.
• platform/graphics/Pattern.h: Ditto.
• platform/graphics/filters/FEBlend.h: Ditto.
• platform/graphics/filters/FEColorMatrix.h: Ditto.
• platform/graphics/filters/FEComponentTransfer.h: Ditto.
• platform/graphics/filters/FEComposite.h: Ditto.
• platform/graphics/filters/FEConvolveMatrix.h: Ditto.
• platform/graphics/filters/FEDisplacementMap.h: Ditto.
• platform/graphics/filters/FEGaussianBlur.h: Ditto.
• platform/graphics/filters/FELighting.h: Ditto.
• platform/graphics/filters/FEMorphology.h: Ditto.
• platform/graphics/filters/FEOffset.h: Ditto.
• platform/graphics/filters/FilterEffect.cpp: Ditto.
• platform/graphics/filters/FilterEffect.h: Ditto.
• platform/graphics/transforms/AffineTransform.h: Ditto.
• platform/graphics/transforms/TransformationMatrix.h: Ditto.
• platform/image-decoders/ImageDecoder.cpp: Ditto.
• platform/image-decoders/ImageDecoder.h: Ditto.
• platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Ditto.
• platform/image-decoders/webp/WEBPImageDecoder.cpp: Ditto.
• platform/mac/LocalCurrentGraphicsContext.h: Ditto.
• platform/mac/LocalCurrentGraphicsContext.mm: Ditto.
• rendering/svg/RenderSVGResourceSolidColor.cpp: Ditto.
• svg/graphics/SVGImage.cpp: Ditto.
• svg/graphics/SVGImage.h: Ditto.

Source/WebKit/blackberry:

• Api/WebPage.cpp: Remove Skia #ifdef references.
• WebCoreSupport/AboutDataUseFeatures.in: Ditto.

Source/WTF:

• wtf/Platform.h:

Tools:

• DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:

(createBitmapContextFromWebView): Remove Skia #ifdef references.

9:16 AM Changeset in webkit [149192] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[GTK] Compilation of ProcessLauncherGtk.cpp fails due to unresolved symbols
​https://bugs.webkit.org/show_bug.cgi?id=115240

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2013-04-26
Reviewed by Martin Robinson.

• UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: Includes sys/socket.h if OS is Linux

9:15 AM Changeset in webkit [149191] by ddkilzer@apple.com

• 2 edits in trunk/LayoutTests

Sort jsc-test-list

$ sort -f -o LayoutTests/fast/js/jsc-test-list LayoutTests/fast/js/jsc-test-list

• fast/js/jsc-test-list: Sort case-insensitively.

9:15 AM Changeset in webkit [149190] by ddkilzer@apple.com

• 2 edits in trunk/LayoutTests

Upstream iOS changes to jsc-test-list

Reviewed by Michael Saboff.

• fast/js/jsc-test-list: Add tests.

9:12 AM Changeset in webkit [149189] by kadam@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip two failing tests.

• platform/qt/TestExpectations:

9:08 AM Changeset in webkit [149188] by allan.jensen@digia.com

• 2 edits in trunk/Source/WebCore

Assert in JSC::Heap::unprotect when closing facebook.com web site
​https://bugs.webkit.org/show_bug.cgi?id=115058

Reviewed by Darin Adler.

Grab a JSLock before calling RootObject::invalidate().

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):

8:17 AM Changeset in webkit [149187] by eric.carlson@apple.com

• 6 edits in trunk/Source/WebCore

[Mac] in-band cues sometimes have incorrect duration
​https://bugs.webkit.org/show_bug.cgi?id=115200

Reviewed by Jer Noble.

No new tests, this is not possible to test in DRT.

• html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::addGenericCue): Don't add completed cues to the map.
(WebCore::InbandTextTrack::removeGenericCue): Log when a cue is removed from the track.

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF): Initialize m_pendingCueStatus.
(WebCore::InbandTextTrackPrivateAVF::processCue): Never call update() on a cue that is delivered

while seeking.

(WebCore::InbandTextTrackPrivateAVF::beginSeeking): Flush all incomplete cues, remember that

we are seeking.

(WebCore::InbandTextTrackPrivateAVF::resetCueValues):

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::seek): Call track->beginSeeking() instead of resetCueValues().
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Call track->endSeeking().

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::kind): Include class name in Kind enum values to

avoid compile error.

8:14 AM Changeset in webkit [149186] by akling@apple.com

• 21 edits in trunk/Source/WebCore

Remove wxWebKit from WebCore.
<​http://webkit.org/b/115255>

Reviewed by Anders Carlsson.

• DerivedSources.make:
• WebCorePrefix.h:
• bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::port):

• config.h:
• html/HTMLFormElement.cpp:
• platform/ContextMenu.h:

(ContextMenu):

• platform/ContextMenuItem.h:
• platform/Cursor.h:
• platform/DragData.h:
• platform/DragImage.h:
• platform/FileSystem.h:
• platform/PlatformExportMacros.h:
• platform/PlatformKeyboardEvent.h:

(PlatformKeyboardEvent):

• platform/PlatformMenuDescription.h:
• platform/PlatformMouseEvent.h:

(PlatformMouseEvent):

• platform/PlatformWheelEvent.h:

(PlatformWheelEvent):

• platform/ScrollView.cpp:
• platform/ScrollView.h:

(ScrollView):

• platform/Widget.h:
• platform/win/SharedTimerWin.cpp:

8:13 AM Changeset in webkit [149185] by commit-queue@webkit.org

• 6 edits
  3 adds in trunk

use-after-free removing a frame from its parent in a beforeload event of an OBJECT element
​https://bugs.webkit.org/show_bug.cgi?id=113964

Source/WebCore:

Object elements have the tendecny to modify or even fully remove
the containing Document inside beforeload callback. While Document is removed,
RenderArena gets destroyed. Retained RenderWidgets fails to function with NULL arena.

Protect RendereArena from getting wiped out, when Document is removed
during FrameView::updateWidget().

Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-26
Reviewed by Antti Koivisto.

Test: fast/frames/crash-remove-iframe-during-object-beforeload.html

• dom/Document.cpp:

(WebCore::Document::attach):

• dom/Document.h:

(Document):

• page/FrameView.cpp:

(WebCore::FrameView::updateWidgets):

• rendering/RenderArena.h:

(RenderArena):
(WebCore::RenderArena::create):

LayoutTests:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-26
Reviewed by Antti Koivisto.

• fast/frames/crash-remove-iframe-during-object-beforeload-expected.txt: Added.
• fast/frames/crash-remove-iframe-during-object-beforeload.html: Added.
• fast/frames/resources/remove-this-during-object-beforeload.html: Added.

7:56 AM Changeset in webkit [149184] by mikhail.pozdnyakov@intel.com

• 2 edits in trunk/Source/WTF

Add move semantics to RefPtr
​https://bugs.webkit.org/show_bug.cgi?id=115033

Reviewed by Anders Carlsson.

Add move constructors and move assignment operators to RefPtr when
COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES).
This obviates unnecessary reffing/ureffing when RefPtr is created
or assigned from rvalue references.

• wtf/RefPtr.h:

(RefPtr):
(WTF::RefPtr::RefPtr):
(WTF::RefPtr::operator=):

7:32 AM Changeset in webkit [149183] by mhahnenberg@apple.com

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r149165): It made many tests crash on 32 bit
​https://bugs.webkit.org/show_bug.cgi?id=115227

Reviewed by Csaba Osztrogonác.

m_reservation is uninitialized when ENABLE(SUPER_REGION) is false.

• heap/SuperRegion.cpp:

(JSC::SuperRegion::~SuperRegion):

6:59 AM Changeset in webkit [149182] by mary.wu@torchmobile.com.cn

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Should check if it's cached resource before download
​https://bugs.webkit.org/show_bug.cgi?id=115101

Reviewed by Rob Buis.

Since main resource maybe cached, if user want to save the resource, we first check
if it's cached. If yes, don't need to initiate a fresh load again, but get the
cached resource data out to save.

RIM bug# 324003, internally reviewed by Charles Wei.

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):

6:20 AM Changeset in webkit [149181] by zandobersek@gmail.com

• 3 edits
  20 adds in trunk/LayoutTests

[GTK] Enable Web Audio layout tests on WK2, provide platform-specific expected output
​https://bugs.webkit.org/show_bug.cgi?id=114513

Reviewed by Philippe Normand.

Unskip the Web Audio layout tests for GTK WK2 and generate platform-specific baselines for the tests.
The audio baselines are not audibly different from the generic baselines, but it can be expected that
different backends won't produce the same binary output.

The remaining failures are marked as such in the TestExpectations, each failure having the appropriate
bug handle covering the issue. The tests are still skipped for GTK WK1 as DumpRenderTree is still missing
infrastructure support for running these tests.

• platform/gtk-wk1/TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/webaudio/audiobuffersource-loop-points-expected.wav: Added.
• platform/gtk/webaudio/audiobuffersource-playbackrate-expected.wav: Added.
• platform/gtk/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
• platform/gtk/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
• platform/gtk/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.wav: Added.
• platform/gtk/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Added.
• platform/gtk/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.wav: Added.
• platform/gtk/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Added.
• platform/gtk/webaudio/codec-tests/wav/24bit-44khz-expected.wav: Added.
• platform/gtk/webaudio/oscillator-custom-expected.wav: Added.
• platform/gtk/webaudio/oscillator-sawtooth-expected.wav: Added.
• platform/gtk/webaudio/oscillator-sine-expected.wav: Added.
• platform/gtk/webaudio/oscillator-square-expected.wav: Added.
• platform/gtk/webaudio/oscillator-triangle-expected.wav: Added.

6:16 AM Changeset in webkit [149180] by mary.wu@torchmobile.com.cn

• 5 edits in trunk

[BlackBerry] Clean up load interface in WebPage
​https://bugs.webkit.org/show_bug.cgi?id=113267

Reviewed by Rob Buis.

Source/WebKit/blackberry:

Remove unused loadExtended(), combine load() and download() api in WebPage.
RIM Bug# 315535, internally reviewed by Joe Mason.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::load):

• Api/WebPage.h:

Tools:

Update DumpRenderTree with change of load() interface in WebPage.
RIM Bug# 315535, internally reviewed by Joe Mason.

• DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::runTest):

6:09 AM Changeset in webkit [149179] by Claudio Saavedra

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed gardnering. Unskip passing test.

• platform/gtk/TestExpectations: Unskip http/tests/inspector/compiler-source-mapping-debug.html

6:07 AM Changeset in webkit [149178] by akling@apple.com

• 8 edits
  3 deletes in trunk/Source/WTF

Remove wxWebKit from WTF.
<​http://webkit.org/b/115249>

Reviewed by Antti Koivisto.

• wscript: Removed.
• wtf/ArrayBufferView.h:

(ArrayBufferView):

• wtf/CurrentTime.cpp:
• wtf/DisallowCType.h:
• wtf/ExportMacros.h:
• wtf/FeatureDefines.h:
• wtf/Platform.h:
• wtf/text/WTFString.h:

(String):

• wtf/wx/MainThreadWx.cpp: Removed.
• wtf/wx/StringWx.cpp: Removed.

6:03 AM Changeset in webkit [149177] by Christophe Dumez

• 2 edits in trunk/Source/WebCore

Optimize function and interface object length computation in bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=115247

Reviewed by Kentaro Hara.

Introduce new GetFunctionLength() function that efficiently compute the length
of a function (i.e. its number of mandatory parameters).

We now call GetFunctionLength() instead of GenerateFunctionParametersCheck()
whenever we care only interested in the function length and not the actual
expression for checking the parameters. This is much more efficient as
GenerateFunctionParametersCheck() does a lot more processing than we need in
this case.

No new tests, no behavior change.

• bindings/scripts/CodeGeneratorJS.pm:

(GetFunctionLength):
(GenerateImplementation):
(GenerateConstructorHelperMethods):

6:02 AM Changeset in webkit [149176] by zandobersek@gmail.com

• 1 edit
  1 delete in trunk/Tools

Remove the HeapGraphSerializer unit test
​https://bugs.webkit.org/show_bug.cgi?id=115231

Reviewed by Andreas Kling.

Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.

• TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.

5:09 AM FeatureFlags edited by akling@apple.com

(diff)

4:48 AM Changeset in webkit [149175] by akling@apple.com

• 5 edits in trunk/Source/WebCore

Web Audio: Remove reduplicative addInput() in AnalyserNode.
<​http://webkit.org/b/115244>

From Blink r149155 by <​james.wei@intel.com>:

The parent class BasicInspectorNode already called addInput() and addOutput().
So it is reduplicative to call them in AnalyserNode.

• Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::AnalyserNode):

• Modules/webaudio/AudioBasicInspectorNode.cpp:

(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):

• Modules/webaudio/AudioBasicInspectorNode.h:

(AudioBasicInspectorNode):

• Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):

3:30 AM Changeset in webkit [149174] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/efl

[EFL] Add unit test cases for ewk_settings APIs
​https://bugs.webkit.org/show_bug.cgi?id=114897

Patch by Jose Lejin PJ <​jose.lejin@gmail.com> on 2013-04-26
Reviewed by Gyuyoung Kim.

Added unit tests for ewk_settings APIs.

• tests/test_ewk_setting.cpp:

(TEST_F):

2:42 AM Changeset in webkit [149173] by allan.jensen@digia.com

• 20 edits
  4 adds in trunk

Mouseenter and mouseleave events not supported
​https://bugs.webkit.org/show_bug.cgi?id=18930

Reviewed by David Hyatt.

Source/WebCore:

Implements mouseenter and mouseleave events from W3C DOM Level 3 Events.
These event are already supported by all other major browsers.

To avoid performance regressions the new events are only dispatched when
there are event listeners for them.

Tests: fast/events/mouseenter-mouseleave-capture.html

fast/events/mouseenter-mouseleave.html

• bindings/scripts/CodeGenerator.pm:
• dom/Document.cpp:

(WebCore::Document::prepareMouseEvent):
(WebCore::Document::updateHoverActiveState):

• dom/Document.h:

(Document):

• dom/Document.idl:
• dom/Element.h:

(Element):

• dom/Element.idl:
• dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::containsCapturing):

• dom/EventListenerMap.h:

(EventListenerMap):

• dom/EventNames.h:
• dom/EventTarget.h:

(EventTarget):
(WebCore::EventTarget::hasCapturingEventListeners):

• dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::toElement):
(WebCore::MouseEvent::fromElement):

• html/HTMLAttributeNames.in:
• html/HTMLElement.cpp:

(WebCore::HTMLElement::eventNameForAttributeName):

• page/DOMWindow.h:

(DOMWindow):

• page/DOMWindow.idl:
• svg/SVGElement.cpp:

(WebCore::SVGElement::parseAttribute):

• svg/SVGElementInstance.h:

(SVGElementInstance):

• svg/SVGElementInstance.idl:

LayoutTests:

To new tests that mouseenter and mouseleave works in both bubbling and capture phase.

• fast/events/mouseenter-mouseleave-capture-expected.txt: Added.
• fast/events/mouseenter-mouseleave-capture.html: Added.
• fast/events/mouseenter-mouseleave-expected.txt: Added.
• fast/events/mouseenter-mouseleave.html: Added.

2:36 AM Changeset in webkit [149172] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Fix SH4 build broken since r149159.
​https://bugs.webkit.org/show_bug.cgi?id=115229

Add BranchTruncateType enum in SH4 port and handle it in branchTruncateDoubleToInt32.

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-04-26
Reviewed by Allan Sandfeld Jensen.

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchTruncateDoubleToInt32):

2:16 AM Changeset in webkit [149171] by Christophe Dumez

• 5 edits in trunk/LayoutTests

[Qt] REGRESSION(r149001): It made two fast/dom/DeviceMotion tests fail.
​https://bugs.webkit.org/show_bug.cgi?id=115235

Reviewed by Kentaro Hara.

Update window-property.html test cases for DeviceMotion and DeviceOrientation.
The global constructors are no longer enumerable after r149001.

• fast/dom/DeviceMotion/script-tests/window-property.js:
• fast/dom/DeviceMotion/window-property-expected.txt:
• fast/dom/DeviceOrientation/script-tests/window-property.js:
• fast/dom/DeviceOrientation/window-property-expected.txt:

12:38 AM WebKitIDL edited by Christophe Dumez

Drop Supplemental in favor of partial interfaces due to r149170 (diff)

12:35 AM WebKitIDL edited by Christophe Dumez

[Callback] only applies to parameters, not interfaces (diff)

12:29 AM Changeset in webkit [149170] by Christophe Dumez

• 33 edits in trunk/Source/WebCore

Add support for Web IDL partial interfaces to the bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=115228

Reviewed by Kentaro Hara.

Add support for Web IDL partial interfaces to the bindings generator:
​http://dev.w3.org/2006/webapi/WebIDL/#dfn-partial-interface

Also drop support for the the WebKit-specific [Supplemental] extended
attribute and use partial interfaces instead in existing IDL files.

No new tests, no behavior change.

• Modules/battery/NavigatorBattery.idl:
• Modules/filesystem/DOMWindowFileSystem.idl:
• Modules/filesystem/DataTransferItemFileSystem.idl:
• Modules/filesystem/HTMLInputElementFileSystem.idl:
• Modules/filesystem/WorkerContextFileSystem.idl:
• Modules/gamepad/NavigatorGamepad.idl:
• Modules/geolocation/NavigatorGeolocation.idl:
• Modules/indexeddb/DOMWindowIndexedDatabase.idl:
• Modules/indexeddb/WorkerContextIndexedDatabase.idl:
• Modules/mediastream/DOMWindowMediaStream.idl:
• Modules/mediastream/NavigatorMediaStream.idl:
• Modules/navigatorcontentutils/NavigatorContentUtils.idl:
• Modules/networkinfo/NavigatorNetworkInfoConnection.idl:
• Modules/notifications/DOMWindowNotifications.idl:
• Modules/notifications/WorkerContextNotifications.idl:
• Modules/quota/DOMWindowQuota.idl:
• Modules/quota/NavigatorStorageQuota.idl:
• Modules/quota/WorkerNavigatorStorageQuota.idl:
• Modules/speech/DOMWindowSpeech.idl:
• Modules/speech/DOMWindowSpeechSynthesis.idl:
• Modules/vibration/NavigatorVibration.idl:
• Modules/webaudio/DOMWindowWebAudio.idl:
• Modules/webdatabase/DOMWindowWebDatabase.idl:
• Modules/webdatabase/WorkerContextWebDatabase.idl:
• Modules/websockets/DOMWindowWebSocket.idl:
• Modules/websockets/WorkerContextWebSocket.idl:
• bindings/scripts/IDLAttributes.txt:
• bindings/scripts/IDLParser.pm:

(parsePartialDefinition):

• bindings/scripts/generate-bindings.pl:
• bindings/scripts/preprocess-idls.pl:

(getPartialInterfaceNameFromIDLFile):

• bindings/scripts/test/TestSupplemental.idl:
• page/DOMWindowPagePopup.idl: