Timeline
May 5, 2013:
- 10:43 PM Changeset in webkit [149584] by
-
- 2 edits in trunk/Source/WebKit2
WEB SPEECH: deny file-read-data /Library/Speech/Synthesizers
https://bugs.webkit.org/show_bug.cgi?id=115621
Reviewed by Alexey Proskuryakov.
Allow access to the location where 3rd party speech synthesizers are stored.
- WebProcess/com.apple.WebProcess.sb.in:
- 9:10 PM Changeset in webkit [149583] by
-
- 13 edits in trunk/Source
Remove Vector::prepend
https://bugs.webkit.org/show_bug.cgi?id=115618
Reviewed by Geoffrey Garen.
Source/WebCore:
Replace calls to Vector::prepend with either Vector::insert,
or a combination of Vector::append and Vector::reverse.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::scrollToGlobalPoint):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
- css/CSSValueList.h:
(WebCore::CSSValueList::prepend):
- dom/Document.cpp:
(WebCore::Document::iconURLs):
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::prependContext):
- editing/VisibleUnits.cpp:
(WebCore::previousBoundary):
(WebCore::nextBoundary):
- history/HistoryItem.cpp:
(WebCore::HistoryItem::padDailyCountsForNewVisit):
(WebCore::HistoryItem::collapseDailyVisitsToWeekly):
- inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::addInspectedObject):
- platform/graphics/SVGGlyph.cpp:
(WebCore::charactersWithArabicForm):
Source/WTF:
Given the performance characteristics of prepending something to a Vector, not having prepend
will hopefully make developers think about whether prepending is necessary at all. For example,
the functions in HexNumber.h were easily converted to using Vector::append and then Vector::reverse.
- wtf/HexNumber.h:
(WTF::appendUnsignedAsHex):
(WTF::appendUnsignedAsHexFixedSize):
- wtf/Vector.h:
(Vector):
- 5:22 PM Changeset in webkit [149582] by
-
- 5 edits in trunk/Source/WebCore
Remove empty function SQLiteFileSystem::registerSQLiteVFS() and its callers
https://bugs.webkit.org/show_bug.cgi?id=115619
Reviewed by Dan Bernstein.
- Modules/webdatabase/DatabaseTracker.cpp:
- platform/sql/SQLiteFileSystem.cpp:
- platform/sql/SQLiteFileSystem.h:
- storage/StorageTracker.cpp:
- 4:25 PM Changeset in webkit [149581] by
-
- 4 edits2 adds in trunk
AX: aria-checked not exposed correctly on menuitemcheckbox or menuitemradio roles
https://bugs.webkit.org/show_bug.cgi?id=115499
Reviewed by Tim Horton.
Source/WebCore:
Expose isChecked() for menu item objects.
Return the Mac-platform specific value that you find on menu items for "checked" menu items.
Test: platform/mac/accessibility/aria-menuitem-checked-value.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isChecked):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
LayoutTests:
- platform/mac/accessibility/aria-menuitem-checked-value-expected.txt: Added.
- platform/mac/accessibility/aria-menuitem-checked-value.html: Added.
- 3:11 PM Changeset in webkit [149580] by
-
- 4 edits in trunk/Source
[wk2] Page Overlays: deviceScaleFactor doesn't update when the display changes
https://bugs.webkit.org/show_bug.cgi?id=115577
<rdar://problem/13762583>
Reviewed by Darin Adler.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setDeviceScaleFactor):
Invalidate the page overlay layers' device scale factor when
TiledCoreAnimationDrawingArea is notified that it has changed.
- WebCore.exp.in:
Export GraphicsLayer::noteDeviceOrPageScaleFactorChangedIncludingDescendants
- 12:03 PM Changeset in webkit [149579] by
-
- 42 edits in trunk
Remove the Vector::append overload that takes a Vector
https://bugs.webkit.org/show_bug.cgi?id=115535
Reviewed by Andreas Kling.
Source/WebCore:
Use Vector::appendVector instead.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::putRecord):
(WebCore::IDBBackingStore::putIndexDataForRecord):
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeStringWithLength):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::encodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
(WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
(WebCore::IDBLevelDBCoding::DataVersionKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
(WebCore::IDBLevelDBCoding::IndexDataKey::encode):
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::clear):
(WebCore::AudioContext::scheduleNodeDeletion):
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addTableCellChild):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::cells):
- css/RuleFeature.cpp:
(WebCore::RuleFeatureSet::add):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::addToMatchedPropertiesCache):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
- dom/Range.cpp:
(WebCore::Range::getBorderAndTextQuads):
- html/FormController.cpp:
(WebCore::FormController::getReferencedFilePaths):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setLineDash):
- html/parser/HTMLFormattingElementList.cpp:
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
- html/track/WebVTTToken.h:
(WebCore::WebVTTToken::addNewClass):
(WebCore::WebVTTToken::addNewAnnotation):
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::preferredLanguages):
- platform/FileChooser.cpp:
(WebCore::FileChooserSettings::acceptTypes):
- platform/SharedBufferChunkReader.cpp:
(WebCore::SharedBufferChunkReader::nextChunk):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::getSitesInMediaCache):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateSublayerList):
- platform/mac/PasteboardMac.mm:
(WebCore::createWritableTypesForImage):
(WebCore::writableTypesForImage):
(WebCore::Pasteboard::writeSelectionForTypes):
- platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::generateUniqueBoundaryString):
- plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::defaultPluginDirectories):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::constructBidiRunsForSegment):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::OverlapMap::popCompositingContainer):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::splitColumn):
- svg/SVGGlyphMap.h:
(WebCore::SVGGlyphMap::collectGlyphsForString):
- xml/XPathNodeSet.h:
(WebCore::XPath::NodeSet::append):
Source/WebKit2:
Use Vector::appendVector instead.
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::registerBlobURL):
- NetworkProcess/SchedulableLoader.cpp:
(WebKit::SchedulableLoader::SchedulableLoader):
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::SyncMessageState::dispatchMessages):
- UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
(WebKit::PluginInfoStore::pluginsDirectories):
Source/WTF:
The Vector::append overload that takes a Vector conflicts with rvalues in C++11, so remove it and
replace calls to it with calls to appendVector.
- wtf/Vector.h:
(Vector):
Tools:
Use Vector::appendVector instead.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(concatenateAttributeAndValue):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::concatenateAttributeAndValue):
- 10:48 AM Changeset in webkit [149578] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Windows build.
Make plugIns.js have a non-zero length.
- Resources/plugIns.js:
May 4, 2013:
- 10:20 PM Changeset in webkit [149577] by
-
- 3 edits in trunk
Fix incorrect ChangeLog dates on previous commit.
- 9:43 PM Changeset in webkit [149576] by
-
- 26 edits4 adds in trunk
Animations and Transitions should not start when globally suspended
https://bugs.webkit.org/show_bug.cgi?id=114915
Reviewed by Sam Weinig.
.:
Export AnimationController::isSuspended().
- Source/autotools/symbols.filter:
Source/WebCore:
When the Document's AnimationController was suspended, we still
started new transitions and animations. Change this so that
animations enter a paused-but-new state, where they are frozen
until the AnimationController resumes. At that time, it is as
if they had just appeared: any delay counts down before
the animation starts.
For transitions, the change in value must still happen, but
it does so immediately. No transitionend event should be fired.
This produces a slightly confusing behaviour, because any
in-progress transitions are suspended, but any new style changes
happen instantly. This might sound contradictory, but in general
suspending the document is a rare (and dangerous) thing to do.
Previously, the Document would call resumeAnimations as it loaded,
effectively starting all the animations. This meant if you suspended
animations before loading a document, it was ignored as soon as the
load finished. Now there is a separate method startAnimationsIfNotSuspended
which checks to see if the document is suspended as it loads.
In order to handle this case, I added a new state to the Animation
machinery: AnimationStatePausedNew. This is an animation that was created
in the suspended state.
Tests: animations/added-while-suspended.html
transitions/started-while-suspended.html
- WebCore.exp.in: Export AnimationController::isSuspended().
- dom/Document.cpp:
(WebCore::Document::implicitClose):
resumeAnimationsForDocument() -> startAnimationsIfNotSuspended()
- page/animation/AnimationBase.cpp:
(WebCore::nameForState): New name for AnimationStatePausedNew.
(WebCore::AnimationBase::updateStateMachine): Handle new state AnimationStatePausedNew. The
most important change is that when go from PausedNew to Running, we jump back into
the New state and continue from there.
(WebCore::AnimationBase::updatePlayState): suspended -> isSuspended
- page/animation/AnimationBase.h: New state: AnimationStatePausedNew
(WebCore::AnimationBase::waitingToStart): Add AnimationStatePausedNew.
(WebCore::AnimationBase::paused): Add AnimationStatePausedNew.
(WebCore::AnimationBase::isNew): Add AnimationStatePausedNew.
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate): Initialise m_suspended.
(WebCore::AnimationControllerPrivate::clear): suspended -> isSuspended
(WebCore::AnimationControllerPrivate::updateAnimations): Ditto.
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer): Ditto.
(WebCore::AnimationControllerPrivate::suspendAnimations): Update m_suspended.
(WebCore::AnimationControllerPrivate::resumeAnimations): Ditto.
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::startAnimationsIfNotSuspended): New method that will
only resume animations if we were not globally suspended.
(WebCore::AnimationController::isSuspended): New method.
(WebCore::AnimationController::suspendAnimations): Add logging.
(WebCore::AnimationController::resumeAnimations): Add logging.
(WebCore::AnimationController::suspendAnimationsForDocument): Add logging.
(WebCore::AnimationController::resumeAnimationsForDocument): Add logging.
(WebCore::AnimationController::startAnimationsIfNotSuspended): Calls private method.
- page/animation/AnimationController.h:
(AnimationController): Add isSuspended() and animationsForDocumentMayStart().
- page/animation/AnimationControllerPrivate.h:
(WebCore::AnimationControllerPrivate::isSuspended): New method.
(AnimationControllerPrivate): Add m_isSuspended member.
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::CompositeAnimation): Moved from header - initialise m_isSuspended.
(WebCore::CompositeAnimation::updateTransitions): Do not create ImplicitAnimation if suspended.
(WebCore::CompositeAnimation::updateKeyframeAnimations): Move to AnimationStatePausedNew if suspended.
(WebCore::CompositeAnimation::suspendAnimations): m_suspended -> m_isSuspended
(WebCore::CompositeAnimation::resumeAnimations): Ditto.
- page/animation/CompositeAnimation.h:
(WebCore::CompositeAnimation::isSuspended): Renamed from suspended()
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate): If we're in the AnimationStatePausedNew state, then
we need to go to the first frame (to handle fill mode).
- testing/Internals.cpp:
(WebCore::Internals::animationsAreSuspended): New exposed method to reflect AnimationController.
- testing/Internals.h: Add animationsAreSuspended.
- testing/Internals.idl: Ditto.
Source/WebKit:
Export AnimationController::isSuspended
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/mac:
The WebView private API cssAnimationsSuspended did not necessarily
reflect the reality of the Frame's AnimationController value because it
was caching rather than asking directly. While the WebCore part of this
patch ensured loading the Document wouldn't resume all animations, it
is still better to ask directly.
- WebView/WebView.mm:
(-[WebView cssAnimationsSuspended]): Call into AnimationController.
(-[WebView setCSSAnimationsSuspended:]): Ditto.
- WebView/WebViewData.h: Remove cssAnimationsSuspended boolean.
- WebView/WebViewData.mm: Ditto.
(-[WebViewPrivate init]):
Source/WebKit/win:
Export AnimationController::isSuspended
- WebKit.vcproj/WebKitExports.def.in:
LayoutTests:
Two new tests. Add an animation or transition to
the document when the global animation controller is suspended.
In the animation case, nothing should happen until the
animations are resumed. In the transition case, the style
change should happen immediately and not fire any events.
- animations/added-while-suspended-expected.txt: Added.
- animations/added-while-suspended.html: Added.
- animations/suspend-transform-animation.html: Make sure to resume suspended animations
before quitting the test.
- transitions/started-while-suspended-expected.txt: Added.
- transitions/started-while-suspended.html: Added.
- transitions/suspend-transform-transition.html: Make sure to resume suspended animations
before quitting the test.
- 7:39 PM Changeset in webkit [149575] by
-
- 3 edits in trunk/Source/WebKit2
Fix * placement in a few functions as noticed by Mark Rowe.
Rubber-stamped by Dan Bernstein.
- WebProcess/WebPage/PageBanner.h:
(PageBanner):
- WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::create):
(WebKit::PageBanner::PageBanner):
- 7:35 PM Changeset in webkit [149574] by
-
- 7 edits4 moves in trunk/Source
Move PopupMenuMac and SearchPopupMenuMac to Source/WebKit/mac
matching where they are in WebKit2.
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/PopupMenuMac.h: Removed.
- platform/mac/PopupMenuMac.mm: Removed.
- platform/mac/SearchPopupMenuMac.h: Removed.
- platform/mac/SearchPopupMenuMac.mm: Removed.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- WebCoreSupport/PopupMenuMac.h: Copied from WebCore/platform/mac/PopupMenuMac.h.
- WebCoreSupport/PopupMenuMac.mm: Copied from WebCore/platform/mac/PopupMenuMac.mm.
- WebCoreSupport/SearchPopupMenuMac.h: Copied from WebCore/platform/mac/SearchPopupMenuMac.h.
- WebCoreSupport/SearchPopupMenuMac.mm: Copied from WebCore/platform/mac/SearchPopupMenuMac.mm.
- WebCoreSupport/WebChromeClient.mm:
- 7:32 PM Changeset in webkit [149573] by
-
- 4 edits1 add in trunk
REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
<rdar://problem/13702008>
https://bugs.webkit.org/show_bug.cgi?id=115607
Reviewed by Benjamin Poulain.
Source/WebKit2:
API Test: WebKit2.CloseThenTerminate
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetStateAfterProcessExited):
Don't try to reset the state if the page is closed, it won't work and its not worth it.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
- 6:53 PM Changeset in webkit [149572] by
-
- 2 edits in trunk/Source/WebCore
Get rid of special cases in AddIncludesForTypeInImpl
https://bugs.webkit.org/show_bug.cgi?id=115602
Reviewed by Benjamin Poulain.
Get rid of the special cases in AddIncludesForTypeInImpl subroutine in the
JS bindings generator. Those are no longer needed and special cases should
be avoided in the generator.
No new tests, no behavior change.
- bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForTypeInImpl):
- 6:47 PM Changeset in webkit [149571] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Clean up unused spellcheck code
https://bugs.webkit.org/show_bug.cgi?id=115560
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-04
Reviewed by Benjamin Poulain.
Internally reviewed by Mike Lattanzio
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
- Api/WebPage.h:
- WebKitSupport/InputHandler.cpp:
- WebKitSupport/InputHandler.h:
(InputHandler):
- 6:34 PM Changeset in webkit [149570] by
-
- 2 edits in trunk/Source/WebCore
Get rid of AddIncludesForSVGAnimatedType in bindings generator
https://bugs.webkit.org/show_bug.cgi?id=115603
Reviewed by Benjamin Poulain.
Remove AddIncludesForSVGAnimatedType subroutine from the bindings generator
as it is a special case which is no longer needed.
No new tests, no behavior change.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- 2:44 PM Changeset in webkit [149569] by
-
- 11 edits1 add in trunk/Source/WebCore
Update code generators to handle a new JavaScript file for snapshotted plug-ins
https://bugs.webkit.org/show_bug.cgi?id=115596
Reviewed by Dean Jackson.
In preparation for https://webkit.org/b/115548, adding a new JS file at
Resources/plugIns.js that we will use to provide presentation for the
snapshotted plug-ins overlay.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Resources/plugIns.js: Added.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- 1:29 PM Changeset in webkit [149568] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r149563.
http://trac.webkit.org/changeset/149563
https://bugs.webkit.org/show_bug.cgi?id=115587
Broke LLInt build.
- wtf/text/StringImpl.h:
(StringImpl):
- 1:25 PM Changeset in webkit [149567] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r142647): Flaky Test: fast/frames/crash-remove-iframe-during-object-beforeload.html
<http://webkit.org/b/115322>
<rdar://problem/13810719>
Reviewed by Anders Carlsson.
Don't cache the FrameView::renderView() in a local since updating Widgets may blow it away.
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
- 1:22 PM Changeset in webkit [149566] by
-
- 6 edits in trunk/Source/WebCore
Remove GraphicsContext::strokeArc(), which is unused.
From Blink r149608 by <jbroman@chromium.org>
<http://src.chromium.org/viewvc/blink?view=revision&revision=149608>
This is no longer used since almost a year ago, when HAVE(PATH_BASED_BORDER_RADIUS_DRAWING) was inlined.
- platform/graphics/GraphicsContext.h:
- platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/cg/GraphicsContextCG.cpp:
- platform/graphics/wince/GraphicsContextWinCE.cpp:
- 1:10 PM Changeset in webkit [149565] by
-
- 3 edits in trunk/Source/WebCore
Remove unused CSSSelector::isCustomPseudoType().
From Blink r149574 by <dominicc@chromium.org>
<http://src.chromium.org/viewvc/blink?view=revision&revision=149574>
- css/CSSSelector.h:
- css/CSSSelector.cpp:
- 12:42 PM Changeset in webkit [149564] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG::ByteCodeParser doesn't need ExecState*
https://bugs.webkit.org/show_bug.cgi?id=115582
Reviewed by Geoffrey Garen.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(ByteCodeParser):
(JSC::DFG::parse):
- dfg/DFGByteCodeParser.h:
(DFG):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- 12:36 PM Changeset in webkit [149563] by
-
- 2 edits in trunk/Source/WTF
No need to declare JSC::LLInt::Data as friend class of WTF::StringImpl
https://bugs.webkit.org/show_bug.cgi?id=115587
Patch by Xan Lopez <xlopez@igalia.com> on 2013-05-04
Reviewed by Andreas Kling.
No need to declare LLInt::Data as friend class of WTF::StringImpl,
it does not use any private method/data member of the latter.
- wtf/text/StringImpl.h:
(StringImpl):
- 12:04 PM Changeset in webkit [149562] by
-
- 7 edits in trunk/Source/WebKit/mac
Get rid of -[NSMutableDictionary _webkit_setObject:forUncopiedKey:]
https://bugs.webkit.org/show_bug.cgi?id=115592
Reviewed by Beth Dakin.
Using CFDictionarySetValue to set a key without having to copy it is not supported. Use NSMapTable with strong pointers instead.
- Misc/WebNSDictionaryExtras.h:
- Misc/WebNSDictionaryExtras.m:
- Panels/WebPanelAuthenticationHandler.h:
(NSURLAuthenticationChallenge):
- Panels/WebPanelAuthenticationHandler.m:
(-[WebPanelAuthenticationHandler init]):
(-[WebPanelAuthenticationHandler enqueueChallenge:forWindow:]):
(-[WebPanelAuthenticationHandler tryNextChallengeForWindow:]):
(-[WebPanelAuthenticationHandler startAuthentication:window:]):
(-[WebPanelAuthenticationHandler cancelAuthentication:]):
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView destroyPlugin]):
(-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
(-[WebNetscapePluginView loadPluginRequest:]):
- 11:46 AM Changeset in webkit [149561] by
-
- 2 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=115574
Crash using new WKBundlePageSetHeaderBanner() API to set a banner to null
Reviewed by Darin Adler.
Don't call addToPage() on a null banner.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setHeaderPageBanner):
(WebKit::WebPage::setFooterPageBanner):
- 9:29 AM Changeset in webkit [149560] by
-
- 4 edits in trunk/Source/WebCore
Remove ShadowRoot's previous/next ShadowRoot pointers.
<http://webkit.org/b/115588>
Reviewed by Anders Carlsson.
ShadowRoot no longer inherits from DoublyLinkedListNode<ShadowRoot> because that code wasn't
doing anything anymore. Shrinks ShadowRoot by two pointers.
- dom/ElementShadow.h:
- dom/ShadowRoot.cpp:
(SameSizeAsShadowRoot):
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):
- dom/ShadowRoot.h:
- 8:27 AM Changeset in webkit [149559] by
-
- 2 edits in trunk/Source/WebCore
RenderObject: don't change GraphicsContext state when not drawing dashed/dotted lines.
From Blink r149546 by <jbroman@chromium.org>
<http://src.chromium.org/viewvc/blink?view=revision&revision=149546>
Previously, there was asymmetry between changing and restoring state (certain state
would be restored only if thickness was positive, i.e. a line was actually drawn.)
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
- 8:18 AM Changeset in webkit [149558] by
-
- 2 edits in trunk/Tools
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
- 8:03 AM Changeset in webkit [149557] by
-
- 3 edits in trunk/Source/WebCore
Remove CSS selector profiler branches from ElementRuleCollector loop.
<http://webkit.org/b/115581>
Reviewed by Antti Koivisto.
Templatize the method so we don't have to check for active inspector frontends on every
pass through the loop.
Time spent in this loop goes down from 0.5% to 0.2% on iTunes Store, WebCore binary size
goes up 480 bytes (sorry Benjamin, I'll make it up to you.)
- css/ElementRuleCollector.h:
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::ElementRuleCollector::doCollectMatchingRulesForList):
- 7:16 AM May 2013 Meeting edited by
- Added transcript for the Status of JSC session. (diff)
- 7:00 AM Changeset in webkit [149556] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
- 4:17 AM WebKitGTK/TrackingMemoryErrors edited by
- (diff)
- 4:15 AM WebKitGTK/TrackingMemoryErrors edited by
- (diff)
- 3:55 AM WebKitGTK/TrackingMemoryErrors edited by
- (diff)
- 3:52 AM WebKitGTK/TrackingMemoryErrors edited by
- (diff)
- 3:47 AM WebKitGTK/TrackingMemoryErrors edited by
- (diff)
- 3:44 AM WebKitGTK/TrackingMemoryErrors edited by
- (diff)
- 3:26 AM WebKitGTK/TrackingMemoryErrors created by
- 3:19 AM WebKitGTK edited by
- (diff)
- 2:22 AM May 2013 Meeting edited by
- Added Profiling in JavaScriptCore notes (diff)
- 12:54 AM Changeset in webkit [149555] by
-
- 2 edits in trunk/Tools
[GTK] Catch select.error exceptions in parse_output_lines
https://bugs.webkit.org/show_bug.cgi?id=115253
Reviewed by Gustavo Noronha Silva.
Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
error code and the error message) and the loop is re-entered.
- gtk/common.py:
(parse_output_lines):
- 12:50 AM Changeset in webkit [149554] by
-
- 2 edits in trunk/Tools
[GTK] Set up the TestWebCore in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=115237
Reviewed by Gustavo Noronha Silva.
Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
a workaround for the layer violations and circular dependencies between various static libraries. Linking against
either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
- TestWebKitAPI/GNUmakefile.am:
- 12:44 AM Changeset in webkit [149553] by
-
- 3 edits2 adds in trunk
REGRESSION(r140907): Incorrect baseline on cells after updating vertical-align
https://bugs.webkit.org/show_bug.cgi?id=115432
Reviewed by Julien Chaffraix.
Source/WebCore:
If a cell changes vertical-align any intrinsic padding it has is now redundant. It
needs to calculate its new height from RenderTableRow::layout() and then find its
new intrinsic padding in RenderTableSection::layoutRows().
Test: fast/table/correct-baseline-after-style-change.html
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleDidChange):
LayoutTests:
- fast/table/correct-baseline-after-style-change-expected.html: Added.
- fast/table/correct-baseline-after-style-change.html: Added.
- 12:30 AM Changeset in webkit [149552] by
-
- 4 edits in trunk/Source/JavaScriptCore
There should be a runtime option to constrain what functions get DFG compiled
https://bugs.webkit.org/show_bug.cgi?id=115576
Reviewed by Mark Hahnenberg.
Added OptionRange to Options to allow checking that something is within an option
or not. The new OptionClass supports range strings in the form of [!]<low>[:<high>].
If only one value is given, then it will be used for both low and high. A leading
'!' inverts the check. If no range is given, then checking for a value within a range
will always return true. Added the option "bytecodeRangeToDFGCompile" that takes an
OptionRange string to select the bytecode range of code blocks to DFG compile.
- dfg/DFGDriver.cpp:
(JSC::DFG::compile): Added new check for bytecode count within bytecodeRangeToDFGCompile
range.
- runtime/Options.cpp:
(JSC::parse): Added overloaded parse() for OptionRange.
(JSC::OptionRange::init): Parse range string and then initialize the range.
(JSC::OptionRange::isInRange): Function used by consumer to check if a value is within
the specified range.
(JSC::Options::dumpOption): Added code to dump OptionRange options.
- runtime/Options.h:
(OptionRange): New class.
(JSC::OptionRange::operator= ): This is really used as a default ctor for use within
the Option static array initialization.
(JSC::OptionRange::rangeString): This is used for debug. It assumes that the char*
passed into OptionRange::init is valid when this function is called.
- 12:23 AM Changeset in webkit [149551] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13806836> Tweak sandbox profile.
Reviewed by Dan Bernstein.
- WebProcess/com.apple.WebProcess.sb.in:
