Timeline
May 8, 2013:
- 11:39 PM Changeset in webkit [149794] by
-
- 2 edits in trunk/Source/WebCore
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Patch by Rob Buis <rbuis@rim.com> on 2013-05-08
Reviewed by Brent Fulgham.
Get rid of the following warning for BlackBerry:
NavigatorContentUtils.cpp:60:78: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
by not compiling any of the code to add protocols to the protocol whitelist.
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::initProtocolHandlerWhitelist):
- 11:38 PM Changeset in webkit [149793] by
-
- 2 edits in trunk/Source/WebCore
[Windows] The function seekFile() is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=115246
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-05-08
Reviewed by Brent Fulgham.
Implemented seekFile() function for Windows.
- platform/win/FileSystemWin.cpp:
(WebCore::seekFile):
- 11:31 PM Changeset in webkit [149792] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Fix a typo in Settings.js
https://bugs.webkit.org/show_bug.cgi?id=115849
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08
Reviewed by Joseph Pecoraro.
No new tests, no behavior change.
- inspector/front-end/Settings.js:
(WebInspector.Settings):
- 10:26 PM Changeset in webkit [149791] by
-
- 3 edits in trunk/Source/WebCore
SecurityOrigin doesn’t need to forward declare or include Document
https://bugs.webkit.org/show_bug.cgi?id=115847
Reviewed by Alexey Proskuryakov.
Merge https://chromium.googlesource.com/chromium/blink/+/fc7a88caa9c41f3471d8994a530643e5225f82fc.
Removed unused Document forward declaration+include from SecurityOrigin.
- page/SecurityOrigin.cpp:
- page/SecurityOrigin.h:
- 9:58 PM EFLWebKit edited by
- Update dependency pkgs (diff)
- 9:50 PM Changeset in webkit [149790] by
-
- 2 edits in trunk/Tools
[EFL] Remove unnecessary pkgs in EFL jhbuild
https://bugs.webkit.org/show_bug.cgi?id=114908
Reviewed by Laszlo Gombos.
p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
handle them using jhbuild. We can reduce build time when using --update-efl.
- efl/jhbuild.modules:
- 8:52 PM Changeset in webkit [149789] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX: Don't use adoptCF() with NSDictionary * object
Fixes the following build failure:
In file included from Source/WebCore/platform/network/mac/ResourceErrorMac.mm:27:
In file included from Source/WebCore/platform/network/cf/ResourceError.h:31:
/usr/local/include/wtf/RetainPtr.h:81:13: error: static_assert failed "Don't use adoptCF with Objective-C pointer types, use adoptNS."
static_assert(!std::is_convertible<T, id>::value, "Don't use adoptCF with Objective-C pointer types, use adoptNS.");
/usr/local/include/wtf/RetainPtr.h:274:16: note: in instantiation of member function 'WTF::RetainPtr<NSDictionary *>::RetainPtr' requested here
return RetainPtr<T>(AdoptCF, o);
Source/WebCore/platform/network/mac/ResourceErrorMac.mm:214:44: note: in instantiation of function template specialization 'WTF::adoptCF<NSDictionary *>' requested here
RetainPtr<NSDictionary> userInfo = adoptCF((NSDictionary *) CFErrorCopyUserInfo(error));
1 error generated.
- platform/network/mac/ResourceErrorMac.mm:
(WebCore::ResourceError::nsError): Switch from adoptCF() to
adoptNS(). This is in USE(CFNETWORK) code, so it's not
exercised on the Mac.
- 8:12 PM Changeset in webkit [149788] by
-
- 4 edits in trunk/Source
Versioning.
- 8:00 PM Changeset in webkit [149787] by
-
- 1 copy in tags/Safari-537.41
New Tag.
- 7:12 PM Changeset in webkit [149786] by
-
- 2 edits in trunk/Tools
[EFL] Disable SHADOW DOM feature in FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=115834
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08
Reviewed by Gyuyoung Kim.
- Scripts/webkitperl/FeatureList.pm:
- 6:11 PM Changeset in webkit [149785] by
-
- 3 edits in trunk/Source/WebCore
Remove Editor::setSelectionOffsets
https://bugs.webkit.org/show_bug.cgi?id=115831
Reviewed by Andreas Kling.
Removed the function added in r120985 for Chromium Android port.
- editing/Editor.cpp:
- editing/Editor.h:
- 6:02 PM Changeset in webkit [149784] by
-
- 2 edits in trunk/Source/WebKit2
Fix a typo in a comment.
Rubber-stamped by Darin Adler.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
- 5:49 PM Changeset in webkit [149783] by
-
- 2 edits in trunk/Source/WebKit2
Remove bogus StorageAreaMap assertions
https://bugs.webkit.org/show_bug.cgi?id=115838
Reviewed by Sam Weinig.
It is possible for didGetValues, and didClear to be called even if m_hasPendingClear is false so remove the assertions.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::didGetValues):
(WebKit::StorageAreaMap::didClear):
- 5:24 PM Changeset in webkit [149782] by
-
- 2 edits in trunk/LayoutTests
[EFL] Get rid of duplicate entry line in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=115828
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08
- platform/efl/TestExpectations:
- 5:20 PM Changeset in webkit [149781] by
-
- 2 edits in trunk/Source/WebKit2
Handle incoming clear operations
https://bugs.webkit.org/show_bug.cgi?id=115829
Reviewed by Sam Weinig.
Handle clear by building up a new storage map with our pending changes.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::applyChange):
- 4:51 PM Changeset in webkit [149780] by
-
- 2 edits in trunk/Source/WebCore
Potential use-after-free of Frame
https://bugs.webkit.org/show_bug.cgi?id=115774
Reviewed by Simon Fraser.
Merge https://chromium.googlesource.com/chromium/blink/+/c5b4a6db82e8280c7fc55ee3dc3a84c6b026e66e.
- page/Frame.cpp:
(WebCore::Frame::setPrinting):
(WebCore::Frame::setPageAndTextZoomFactors):
(WebCore::Frame::deviceOrPageScaleFactorChanged):
- 4:43 PM Changeset in webkit [149779] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed build fix, AppleWin port.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::seek):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
(WebCore):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
- 4:38 PM Changeset in webkit [149778] by
-
- 24 edits in trunk/Source/WebCore
Heap-use-after-free in WebCore::AudioNodeOutput::pull
https://bugs.webkit.org/show_bug.cgi?id=111362
Reviewed by Chris Rogers.
- Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::createFromAudioFileData):
- Modules/webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):
- Modules/webaudio/AudioNodeInput.h:
(AudioNodeInput):
- Modules/webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateInternalBus):
(WebCore::AudioNodeOutput::pull):
(WebCore::AudioNodeOutput::bus):
- Modules/webaudio/AudioNodeOutput.h:
(AudioNodeOutput):
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
- Modules/webaudio/OfflineAudioDestinationNode.h:
(OfflineAudioDestinationNode):
- platform/audio/AudioBus.cpp:
(WebCore::AudioBus::createBufferFromRange):
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):
- platform/audio/AudioBus.h:
(AudioBus):
- platform/audio/AudioFileReader.h:
(WebCore):
- platform/audio/AudioResampler.cpp:
(WebCore::AudioResampler::AudioResampler):
(WebCore::AudioResampler::configureChannels):
- platform/audio/AudioResampler.h:
(AudioResampler):
- platform/audio/HRTFElevation.cpp:
(WebCore::getConcatenatedImpulseResponsesForSubject):
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
- platform/audio/MultiChannelResampler.cpp:
- platform/audio/Reverb.cpp:
(WebCore::Reverb::initialize):
- platform/audio/Reverb.h:
(Reverb):
- platform/audio/efl/AudioBusEfl.cpp:
(WebCore::AudioBus::loadPlatformResource):
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(AudioFileReader):
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):
- platform/audio/gtk/AudioBusGtk.cpp:
(WebCore::AudioBus::loadPlatformResource):
- platform/audio/mac/AudioBusMac.mm:
(WebCore::AudioBus::loadPlatformResource):
- platform/audio/mac/AudioFileReaderMac.cpp:
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):
- platform/audio/mac/AudioFileReaderMac.h:
(AudioFileReader):
- platform/audio/qt/AudioBusQt.cpp:
(WebCore::AudioBus::loadPlatformResource):
- 4:31 PM Changeset in webkit [149777] by
-
- 6 edits in trunk/Source/WebKit2
Don't apply changes while we're clearing the database
https://bugs.webkit.org/show_bug.cgi?id=115826
Reviewed by Darin Adler.
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::openDatabase):
Only call didOpenDatabaseWithOrigin if we actually did open the database.
(WebKit::LocalStorageDatabase::updateDatabaseWithChangedItems):
Create the database if needed.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::getValues):
Send back a DidGetValues message.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::StorageAreaMap):
Initialize m_hasPendingClear.
(WebKit::StorageAreaMap::clear):
Set m_hasPendingClear to true.
(WebKit::StorageAreaMap::resetValues):
Set m_hasPendingClear back to false.
(WebKit::StorageAreaMap::loadValuesIfNeeded):
Set m_hasPendingClear to true so we'll ignore any changes that are already part of the returned items.
(WebKit::StorageAreaMap::didGetValues):
Set m_hasPendingClear back to false.
(WebKit::StorageAreaMap::didClear):
Set m_hasPendingClear back to false.
(WebKit::StorageAreaMap::applyChange):
Don't apply the change if m_hasPendingClear is true.
- WebProcess/Storage/StorageAreaMap.messages.in:
Add DidGetValues message.
- 4:15 PM Changeset in webkit [149776] by
-
- 2 edits in trunk/Tools
Add Scheduler for Mac MtnLion 32bit Release builder.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 4:08 PM Changeset in webkit [149775] by
-
- 2 edits in trunk/Tools
Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
https://bugs.webkit.org/show_bug.cgi?id=115808
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-05-08
Reviewed by Darin Adler.
The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
was left outdated after r127191, when the m_string member was changed
from UString to String. This patch calls the right pretty printer for it.
- gdb/webkit.py:
(JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
WTFImplPrettyPrinter.
- 3:41 PM Changeset in webkit [149774] by
-
- 5 edits2 adds in trunk
[WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
https://bugs.webkit.org/show_bug.cgi?id=115790
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
NSMutableSet does not support adding or removing nil objects, and
WTF::HashSet does not support adding, removing, or checking for null
WTF::Strings.
For the NSMutableSet case, make sure that we don't try to add or remove
nil NSStrings.
For the WTF::HashSet case, NSURL will return a nil NSString if we ask
it for its scheme when it is invalid, which we will convert to a null
WTF::String. Don't try to check if our HashSet of registered schemes
contains a null String.
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::registerScheme): Assert that the scheme
isn't null. We reject null schemes at the WKBrowsingContextController level.
(WebKit::CustomProtocolManager::unregisterScheme): Ditto.
(WebKit::CustomProtocolManager::supportsScheme): If scheme is null, return false.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(+[WKBrowsingContextController registerSchemeForCustomProtocol:]): Do not register a nil scheme.
(+[WKBrowsingContextController unregisterSchemeForCustomProtocol:]): Ditto.
Tools:
Added two API tests:
1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::decidePolicyForNavigationAction):
(CustomProtocolInvalidSchemeTest):
(TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
- 3:40 PM Changeset in webkit [149773] by
-
- 2 edits in trunk/Tools
Teach buildbot how to compile 32-bit on Mac.
Reviewed by Ryosuke Niwa.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
(ExtractTestResultsAndLeaks):
- 3:34 PM Changeset in webkit [149772] by
-
- 3 edits in trunk/Source/WebKit2
Apply remote changes to storage maps locally
https://bugs.webkit.org/show_bug.cgi?id=115825
Reviewed by Beth Dakin.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::resetValues):
Clear the pending values map.
(WebKit::StorageAreaMap::didSetItem):
If we failed to set the item, forget everything we know about this storage map.
Otherwise, remove the pending item.
(WebKit::StorageAreaMap::didRemoveItem):
Remove the pending item.
(WebKit::StorageAreaMap::shouldApplyChangeForKey):
Helper function that returns whether a change for a given key should be applied.
(WebKit::StorageAreaMap::applyChange):
Apply the change. Currently only adds and removes are handled.
(WebKit::StorageAreaMap::dispatchStorageEvent):
Apply the change locally as well if needed.
- WebProcess/Storage/StorageAreaMap.h:
- 3:26 PM Changeset in webkit [149771] by
-
- 2 edits1 copy in trunk/WebKitLibraries
Update WebKitLibraries/win to handle different architectures properly.
- win/lib32: Copied from win/lib.
- win/tools/WinTools.make:
- 3:08 PM Changeset in webkit [149770] by
-
- 2 edits in trunk/Source/WTF
Simplify RetainPtrObjectHashTraits
https://bugs.webkit.org/show_bug.cgi?id=115822
Reviewed by Benjamin Poulain.
RetainPtrObjectHashTraits is inherited from SimpleClassHashTraits
instead of GenericHashTraits re-using more shared functionality.
- wtf/RetainPtr.h:
(WTF::RetainPtrObjectHashTraits::emptyValue):
- 3:05 PM Changeset in webkit [149769] by
-
- 26 edits in trunk
[BlackBerry] Fix usage of BlackBerry::Platform::String
https://bugs.webkit.org/show_bug.cgi?id=115781
Patch by Eli Fidler <efidler@blackberry.com> on 2013-05-08
Reviewed by Rob Buis.
BlackBerry PRs 304193 and 327181
Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
We currently have a problem where we're passing UTF-8 encoded data into
the char* constructors of BlackBerry::Platform::String. This means the string
thinks its data is not UTF-8.
Source/WebCore:
- platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::writeURL):
(WebCore::ClipboardBlackBerry::writePlainText):
- platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::getBackingStoreCookies):
- platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::CookieParser):
(WebCore::CookieParser::parseOneCookie):
- platform/blackberry/CursorBlackBerry.cpp:
(WebCore::Cursor::Cursor):
- platform/blackberry/PlatformBlob.cpp:
(WebCore::PlatformBlob::nextDataItem):
- platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:
(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::moveOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::copyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursivelyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readMetadataOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createFileOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::fileExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::directoryExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadataOnMainThread):
- platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::Image::loadPlatformResource):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
(WebCore::toWebMediaStreamSource):
(WebCore::toWebMediaStreamDescriptor):
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
- platform/network/blackberry/rss/RSSFilterStream.cpp:
(WebCore::RSSFilterStream::notifyStatusReceived):
(WebCore::RSSFilterStream::notifyHeadersReceived):
(WebCore::RSSFilterStream::convertContentToHtml):
(WebCore::RSSFilterStream::charset):
(WebCore::RSSFilterStream::removeHeader):
(WebCore::RSSFilterStream::updateHeader):
(WebCore::RSSFilterStream::updateRSSHeaders):
- platform/network/blackberry/rss/RSSFilterStream.h:
- platform/text/blackberry/StringBlackBerry.cpp:
(WTF::String::operator BlackBerry::Platform::String):
Source/WebKit/blackberry:
- Api/JavaScriptVariant.cpp:
(BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
- Api/WebKitTextCodec.cpp:
(BlackBerry::WebKit::base64Encode):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::textEncoding):
(BlackBerry::WebKit::WebPage::textHasAttribute):
(BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
- Api/WebPage.h:
- Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
- WebKitSupport/DefaultTapHighlight.cpp:
(WebKit):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
(BlackBerry::WebKit::DefaultTapHighlight::hide):
Tools:
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::dumpHistoryItem):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::setUserStyleSheetLocation):
- DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
(LoadHTMLStringItem::invoke):
- 3:02 PM Changeset in webkit [149768] by
-
- 6 edits in trunk/Source
Assert at compile time that we don't pass Objective-C object pointers to adoptCF
https://bugs.webkit.org/show_bug.cgi?id=115823
Reviewed by Geoffrey Garen.
Source/WebCore:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
Use adoptNS for CALayer.
Source/WebKit2:
Fix adoptNS/adoptCF mismatches. For the adopt(leakRef()) case we'd ideally want a static_pointer_cast overload for RetainPtr,
but this will do for now.
- Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::decode):
Source/WTF:
static_assert in adoptCF that the object passed in is not an Objective-C object.
- wtf/RetainPtr.h:
- 2:56 PM Changeset in webkit [149767] by
-
- 2 edits in trunk/Tools
Tools: add new BlackBerry include dirs.
https://bugs.webkit.org/show_bug.cgi?id=115514
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-08
Reviewed by Rob Buis.
iType include dirs are missing, and HarfBuzz needs to be fixed.
- Scripts/webkitdirs.pm:
(blackberryCMakeArguments):
- 1:53 PM Changeset in webkit [149766] by
-
- 4 edits2 adds in trunk
TextTrackCue should support empty content
https://bugs.webkit.org/show_bug.cgi?id=115821
Reviewed by Jer Noble.
Source/WebCore:
Test: media/track/track-cue-empty-text-crash.html
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Don't bother trying to render
cues with no content.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::getCueAsHTML): Return early if there isn't a node tree.
(WebCore::TextTrackCue::createCueRenderingTree): Ditto.
(WebCore::TextTrackCue::determineTextDirection): Ditto.
(WebCore::TextTrackCue::updateDisplayTree): Return early if there isn't a cue rendering tree.
LayoutTests:
- media/track/track-cue-empty-text-crash-expected.txt: Added.
- media/track/track-cue-empty-text-crash.html: Added.
- 1:48 PM Changeset in webkit [149765] by
-
- 5 edits2 adds in trunk/Source/WebKit2
Add SPI to determine if a plugin is sandboxed
https://bugs.webkit.org/show_bug.cgi?id=115810
Reviewed by Anders Carlsson.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::initializeSandbox):
- Shared/Plugins/mac/PluginSandboxProfile.h: Added.
- Shared/Plugins/mac/PluginSandboxProfile.mm: Added.
(WebKit::pluginSandboxProfileDefaultDirectory):
(WebKit::pluginSandboxProfileDirectories):
(WebKit::pluginSandboxProfileName):
(WebKit::pluginSandboxCommonProfile):
(WebKit::pluginSandboxProfileForDirectory):
(WebKit::pluginSandboxProfile):
(WebKit::pluginHasSandboxProfileForDirectory):
(WebKit::pluginHasSandboxProfile):
Move sandbox code to its own file and refactor to use cocoa. Also adds pluginHasSandboxProfile function
which uses the newly refactored code.
- UIProcess/API/C/mac/WKContextPrivateMac.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKPlugInInfoIsSandboxedKey):
(createInfoDictionary):
Add WKPlugInInfoIsSandboxedKey.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- 1:45 PM Changeset in webkit [149764] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed AppleWin build fix.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
(MediaPlayerPrivateAVFoundationCF):
(WebCore::MediaPlayerPrivateAVFoundationCF::currentTrack):
- 1:33 PM Changeset in webkit [149763] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Patch by Rob Buis <rbuis@rim.com> on 2013-05-08
Reviewed by Philip Rogers.
Get rid of the following warning for BlackBerry:
BackingStoreClient.cpp:54:21: warning: unused parameter 'parentFrame' [-Wunused-parameter]
by using ASSERT_UNUSED instead of ASSERT.
- WebKitSupport/BackingStoreClient.cpp:
(BlackBerry::WebKit::BackingStoreClient::create):
- 1:06 PM Changeset in webkit [149762] by
-
- 2 edits in trunk/Source/WebKit2
Safari unexpectedly quits with invalid message from the web process with message ID 0x323002f (WebPageProxy.DecidePolicyForNavigationAction)
https://bugs.webkit.org/show_bug.cgi?id=115814
<rdar://problem/12331258>
Reviewed by Andreas Kling.
To ensure that any asynchronous messages are delivered to the UI process before
synchronous messages (except when doing so would lead to a deadlock), Call
setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage on the UI process connections.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
- 1:02 PM Changeset in webkit [149761] by
-
- 4 edits in trunk/Source/WebKit2
Coalesce WKView visibleRect changes
https://bugs.webkit.org/show_bug.cgi?id=115792
<rdar://problem/13776842>
Reviewed by Simon Fraser.
The system can call renewGState much more often than we actually want
to update the WebProcess' notion of the exposed rect. Most importantly,
within an autolayout pass it is called many times, and often sees
[WKView visibleRect] be an intermediate value which will never be
flushed to the screen. We only care about the final value, so we should
wait until AppKit has finished - with a zero-delay timer - to inform the
WebProcess of exposed rect changes.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Add exposedRectChangedTimer.
(WebKit::WebPageProxy::close):
Cancel exposedRectChangedTimer when tearing down the WebPageProxy.
- UIProcess/WebPageProxy.h:
(WebPageProxy):
Add exposedRectChangedTimerFired, the timer itself, and two rects:
the most recent exposed rect from the WKView, and the last one we actually
sent across to the WebProcess.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::viewExposedRectChanged):
Instead of immediately sending exposed rect changes to the WebProcess,
start a zero-delay timer to do so.
(WebKit::WebPageProxy::exposedRectChangedTimerFired):
Once the zero-delay timer fires, send the new exposed rect to the WebProcess.
- 12:47 PM Changeset in webkit [149760] by
-
- 2 edits in trunk/Source/WTF
Remove RetainPtr::adoptNS and RetainPtr::adoptCF
https://bugs.webkit.org/show_bug.cgi?id=115817
Reviewed by Jessie Berlin.
These functions are now unused so remove them. The preferred way to create a RetainPtr with an
adopted reference is to use the adoptNS/adoptCF free functions.
Rewrite the move assignment operators to just call CFRelease explicitly.
- wtf/RetainPtr.h:
- 12:39 PM Changeset in webkit [149759] by
-
- 12 edits in trunk
[GTK] Plumb the Automake build system for the Battery Status API feature
https://bugs.webkit.org/show_bug.cgi?id=115718
Reviewed by Martin Robinson.
.:
- Source/autotools/FindDependencies.m4: Check for the upower-glib dependency if the feature is enabled.
- Source/autotools/PrintBuildConfiguration.m4: Print out the feature status.
- Source/autotools/ReadCommandLineArguments.m4: Check for the --enable-battery-status option. The deafult,
when the option is not given, is to disable the feature.
- Source/autotools/SetupWebKitFeatures.m4: Treat the ENABLE_BATTERY_STATUS define as configurable.
- Source/autotools/symbols.filter: Export a couple of symbols that are used in the WebCore internals library.
Source/WebCore:
No new tests - no new functionality. The feature is not enabled yet, though all the relevant tests
pass when it is.
- GNUmakefile.am: Add the Modules/battery directory to the list of search paths for header inclusions.
Include the same directory under the IDL_PATH variable so the IDL files it contains are processed.
List these IDL files using a wildcard under the EXTRA_DIST list.
- GNUmakefile.list.am: Add the build targets for the module source files, IDLs and resulting JS bindings.
- bindings/gobject/GNUmakefile.am: Add the build targets for the GObject DOM bindings.
Tools:
- Scripts/webkitdirs.pm:
(buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
through the --(enable|disable)-battery-status flag passed to configure.
- 12:28 PM Changeset in webkit [149758] by
-
- 3 edits2 adds in trunk/LayoutTests
Add layout test that lists all global constructors
https://bugs.webkit.org/show_bug.cgi?id=115724
Reviewed by Ryosuke Niwa.
Update fast/js/global-constructors-attributes.html so that it lists all
global constructors instead of just a few.
- fast/js/global-constructors-attributes-expected.txt:
- fast/js/script-tests/global-constructors-attributes.js:
(classNameForObject):
(constructorPropertiesOnWindow):
- platform/efl/fast/js/global-constructors-attributes-expected.txt: Added.
- platform/gtk/fast/js/global-constructors-attributes-expected.txt: Added.
- 12:26 PM Changeset in webkit [149757] by
-
- 2 edits in trunk/Tools
new-run-webkit-websocketserver doesn't work after Chromium removal
https://bugs.webkit.org/show_bug.cgi?id=115816
Reviewed by Joseph Pecoraro.
Fix the bug by instantiating the correct port object.
- Scripts/new-run-webkit-websocketserver:
(main):
- 12:19 PM Changeset in webkit [149756] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening, mac port.
These tests should use testRunner, not layoutTestController.
- fast/js/parse-error-external-script-in-eval.html:
- fast/js/parse-error-external-script-in-new-Function.html:
- 12:11 PM Changeset in webkit [149755] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. AppleWin VS2010 build fix.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 11:54 AM Changeset in webkit [149754] by
-
- 4 edits in trunk
REGRESSION(r149700): fast/css-generated-content/close-quote-negative-depth.html
https://bugs.webkit.org/show_bug.cgi?id=115776
Reviewed by Anders Carlsson.
Source/WebCore:
I changed depth to more closely match what is in the CSS3 specification.
There may be a more optimal way to make it work, but this seems the most straightforward.
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::RenderQuote): Initialize m_depth to -1 because that depth
is consistent with the empty string that is the initial value of the text. The
real depth will be calculated when the node is attached.
(WebCore::RenderQuote::originalText): Removed the "depth - 1" logic that
used to be done for close quotes. Instead, the updateDepth function now correctly
subtracts one for the close quote itself, not just afterward. Also added an early
exit when the depth is negative; these changes together fix the bug.
(WebCore::RenderQuote::attachQuote): Added a call to updateDepth even for the render
quote head, we now need that to set the depth either to 0 or to -1.
(WebCore::RenderQuote::detachQuote): Removed code to set m_depth to 0; if we are not
resetting the text then m_depth should be left matching the text, otherwise updateDepth
might not do its job correctly if the quote is later re-attached. What matters is that
m_depth and the text are in sync.
(WebCore::RenderQuote::updateDepth): Changed updating logic in two ways. First,
compute the depth in a local variable rather than computing it in a data member
after first saving off the old value of the data member. That's clearer style.
Second, add the code to change negative depths to zero when propagating to the
next quote in the chain, which matches how the standard is written, and decrement
the depth of the close quote itself, not the quote after the close quote.
LayoutTests:
- TestExpectations: Expect success again on this test.
- 11:52 AM Changeset in webkit [149753] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Unreviewed. Fix duplicate builddir.
- 11:46 AM Changeset in webkit [149752] by
-
- 2 edits in trunk/Tools
Configure buildbot for 32bit builder.
https://bugs.webkit.org/show_bug.cgi?id=115769
Reviewed by Ryosuke Niwa.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 11:19 AM Changeset in webkit [149751] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13776220> 13A451: PluginProcess(2225) deny file-read-data ~/Library/InputManagers
<rdar://problem/13642510> PluginProcess logs sandbox violations initializing TextServices
Reviewed by Anders Carlsson.
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: Allow more TextServices and NSInputManager directories.
- 10:35 AM Changeset in webkit [149750] by
-
- 2 edits in trunk/Tools
Unreviewed. Add my apple.com e-mail address to contributors.
- 10:16 AM Changeset in webkit [149749] by
-
- 3 edits2 adds in trunk
Prevent crash when track is deleted during video element deletion.
https://bugs.webkit.org/show_bug.cgi?id=106183
Reviewed by Dean Jackson.
Source/WebCore:
Test: media/track/track-remove-crash.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removedFrom): Set m_inActiveDocument to false so we
do not process text track cues or dispatch related events.
LayoutTests:
- media/track/track-remove-crash-expected.txt: Added.
- media/track/track-remove-crash.html: Added.
- 10:03 AM Changeset in webkit [149748] by
-
- 1 edit1 delete in trunk/Source/WebKit2
Remove BinarySemaphoreWin.cpp.
Rubber-stamped by Beth Dakin.
BinarySemaphoreWin has been moved to WTF, but the original was never removed.
- Platform/CoreIPC/win/BinarySemaphoreWin.cpp: Removed.
- 9:54 AM Changeset in webkit [149747] by
-
- 1 edit1 delete in trunk/Source/WTF
Remove ThreadingNone.cpp
Rubber-stamped by Beth Dakin.
ThreadingNone.cpp is empty and not used anywhere.
- wtf/ThreadingNone.cpp: Removed.
- 9:52 AM Changeset in webkit [149746] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove chromium test results added in r149743
- platform/chromium/fast/js/parse-error-external-script-in-eval-expected.txt: Removed.
- platform/chromium/fast/js/parse-error-external-script-in-new-Function-expected.txt: Removed.
- 9:46 AM Changeset in webkit [149745] by
-
- 2 edits in trunk/Tools
BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(concatenateAttributeAndValue): Switch to appendVector().
- 9:41 AM Changeset in webkit [149744] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Unreviewed buildfix after r149741.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible):
- 9:33 AM Changeset in webkit [149743] by
-
- 1 edit11 adds in trunk/LayoutTests
Add layout tests for test cases in Bug 5206
<http://webkit.org/b/5206>
Reviewed by Eric Seidel.
These issues were likely fixed in r89257 for Bug 62613.
- fast/js/parse-error-external-script-in-eval-expected.txt: Added.
- fast/js/parse-error-external-script-in-eval.html: Added.
- fast/js/parse-error-external-script-in-new-Function-expected.txt: Added.
Note that the line number in this result is relative to the line
number of the second argument to the new Function() method.
- fast/js/parse-error-external-script-in-new-Function.html: Added.
- fast/js/resources/parse-error-external-script-in-eval.js: Added.
- fast/js/resources/parse-error-external-script-in-new-Function.js: Added.
- platform/chromium/fast/js/parse-error-external-script-in-eval-expected.txt: Added.
- platform/chromium/fast/js/parse-error-external-script-in-new-Function-expected.txt: Added.
- 9:17 AM Changeset in webkit [149742] by
-
- 2 edits in trunk/Source/WTF
Remove HashMap::deleteAllKeys
https://bugs.webkit.org/show_bug.cgi?id=115806
Reviewed by Brent Fulgham.
This function was not used anywhere so let's get rid of it.
- wtf/HashMap.h:
- 9:06 AM Changeset in webkit [149741] by
-
- 17 edits in trunk
[Mac] Inband text tracks are not in track menu on Lion
https://bugs.webkit.org/show_bug.cgi?id=115740
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, covered by existing tests.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Remove m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_closedCaptionsVisible
to false immediately, it will be reset to the appropriate value if necessary.
(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
- html/HTMLMediaElement.h:
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Remove
HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT) requirement. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
AVFOUNDATION_MEDIA_SELECTION_GROUP
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Ditto.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seek): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::trackModeChanged): Ditto.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Ditto.
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h: Ditto.
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::kind): Don't look at media characteristics,
a legacy CC track is always Captions.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isClosedCaptions): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::containsOnlyForcedSubtitles): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isMainProgramContent): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isEasyToRead): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label): Use different AVFoundation API on 10.7.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): AVFOUNDATION_TEXT_TRACK_SUPPORT ->
AVFOUNDATION_MEDIA_SELECTION_GROUP.
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible): Do nothing. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
AVFOUNDATION_MEDIA_SELECTION_GROUP.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Support legacy CC tracks
only on 10.8. AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): AVFOUNDATION_TEXT_TRACK_SUPPORT ->
AVFOUNDATION_MEDIA_SELECTION_GROUP
Source/WTF:
- wtf/Platform.h: AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP
LayoutTests:
- platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt:
- 8:19 AM Changeset in webkit [149740] by
-
- 3 edits2 adds in trunk
Allow blank spaces before colon (:) on CSS variable definition
https://bugs.webkit.org/show_bug.cgi?id=115802
Reviewed by Darin Adler.
Source/WebCore:
Test: css3/css-variable-definition.html
Modified the grammar to allow blank spaces before the colon on CSS
variable definitions.
- css/CSSGrammar.y.in:
LayoutTests:
New test to check that spaces are allowed before the color on CSS
variable definitions.
- css3/css-variable-definition-expected.html: Added.
- css3/css-variable-definition.html: Added.
- 8:08 AM Changeset in webkit [149739] by
-
- 2 edits in trunk/Source/WTF
HashTraits<RefPtr<P> >::peek should consider empty value
https://bugs.webkit.org/show_bug.cgi?id=115799
Reviewed by Darin Adler.
HashTraits<RefPtr<P> >::peek() should consider passing of empty value which is
raw pointer equal to '0', and return it right away instead of converting it to RefPtr
and invoking get().
- wtf/HashTraits.h:
- 8:07 AM Changeset in webkit [149738] by
-
- 2 edits in trunk/Source/WTF
Avoid unnecessary arguments copying inside GenericHashTraits methods
https://bugs.webkit.org/show_bug.cgi?id=115733
Reviewed by Darin Adler.
Before the change both WTF::GenericHashTraits::passOut and WTF::GenericHashTraits::passOut
used to return the given argument always by value and that caused implicit extra
copying of the argument. It was OK as long as argument type T was POD, as compiler
could optimize it, but in case T was a class having non-trivial copy constructor the
extra copying of the argument could not have been obviated.
The proposed solution is to provide overloaded functions that accept non-temporary
values and return them by reference thus avoiding extra copying.
The proposed solution made an impact on the size of libjavascriptcore_efl.so (EFL
release build): the size decreased from 6554992 bytes to 6554560 bytes.
- wtf/HashTraits.h:
(WTF::GenericHashTraits::passOut):
(WTF::GenericHashTraits::peek):
- 7:36 AM Changeset in webkit [149737] by
-
- 1 edit16 adds in trunk/LayoutTests
[Qt] Unreviewed gardening after r149292.
https://bugs.webkit.org/show_bug.cgi?id=115372
- platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt: Added.
- platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt: Added.
- platform/qt-5.0-wk2/fast/css-grid-layout/grid-item-change-column-repaint-expected.txt: Added.
- platform/qt-5.0-wk2/fast/css-grid-layout/grid-item-change-row-repaint-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/layer-full-repaint-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-flipped-writing-mode-table-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/reflection-table-layout-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/selection-gap-absolute-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/selection-gap-fixed-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/selection-gap-flipped-absolute-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/selection-gap-transformed-absolute-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/selection-gap-transformed-fixed-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/transform-table-layout-expected.txt: Added.
- platform/qt-5.0-wk2/svg/repaint/repaint-webkit-svg-shadow-container-expected.txt: Added.
- 7:28 AM WebKitGTK/2.0.x edited by
- Adding a couple reasonably simple GStreamer backend fixes (diff)
- 6:44 AM Changeset in webkit [149736] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed EFL gardening
https://bugs.webkit.org/show_bug.cgi?id=115791
Unreviewed EFL gardening
Skip fast/regions/ test cases which are failing after r149668.
Patch by Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> on 2013-05-08
- platform/efl/TestExpectations:
- 6:41 AM Changeset in webkit [149735] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Does memory buffering even with preload set to none
https://bugs.webkit.org/show_bug.cgi?id=115754
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-05-08
Reviewed by Philippe Normand.
Covered by existing tests.
Revision 148840 fixed on-disk buffering being done when preload is set to none,
but memory buffering is still being done. That is because setting the state to
paused causes GStreamer to start loading the media, to gather information. Only
doing that when committing the load avoids that while maintaining the tested
behaviour unchanged.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load): move setting pause state to commitLoad.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): see above.
- 6:07 AM Changeset in webkit [149734] by
-
- 2 edits in trunk/Source/WebCore
SVGStyledElement::getPresentationAttribute() does not need to be virtual.
From Blink r149888 by <cevans@chromium.org>
<http://src.chromium.org/viewvc/blink?view=revision&revision=149888>
- svg/SVGStyledElement.h:
- 6:00 AM Changeset in webkit [149733] by
-
- 2 edits in trunk/Source/WebCore
Crash when loading link to audio file
https://bugs.webkit.org/show_bug.cgi?id=115794
Reviewed by Jocelyn Turcotte.
Do not access a null pointer frame.
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
- 5:56 AM Changeset in webkit [149732] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping some failing fast/region tests.
https://bugs.webkit.org/show_bug.cgi?id=115785
- platform/qt/TestExpectations:
- 5:20 AM Changeset in webkit [149731] by
-
- 2 edits in trunk/Tools
[Qt][WTR] Fix the build on Mac after r149692
Unreviewed build fix.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
- 4:54 AM Changeset in webkit [149730] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip two spelling tests as they started passing after r149366.
- platform/efl-wk2/TestExpectations:
Unskip spelling-exactly-selected-word.html and
spelling-with-punctuation-selection.html
- platform/efl/TestExpectations:
Remove spelling tests from efl/TestExpectations as the failing tests
are already skipped for both efl-wk1 and global wk2.
- 3:59 AM Changeset in webkit [149729] by
-
- 20 edits in trunk/Source/WebCore
Remove unused [TransferList] extended attribute
https://bugs.webkit.org/show_bug.cgi?id=115788
Reviewed by Kentaro Hara.
Remove [TransferList] extended attribute and corresponding tests as it has no
effect on the generated JSC bindings.
No new tests, no behavior change.
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
(WebDOMTestSerializedScriptValueInterface):
- bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
- bindings/scripts/test/CPP/WebDOMTestTypedefs.h:
(WebDOMTestTypedefs):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(JSTestSerializedScriptValueInterfacePrototype):
(JSTestSerializedScriptValueInterfaceConstructor):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore):
- bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
- bindings/scripts/test/ObjC/DOMTestTypedefs.h:
- bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
- bindings/scripts/test/TestSerializedScriptValueInterface.idl:
- bindings/scripts/test/TestTypedefs.idl:
- 3:38 AM Changeset in webkit [149728] by
-
- 3 edits in trunk/Tools
Unreviewed. Added Anton Obzhirov to the list of contributors and myself
to the watchlist for Accessibility.
- Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
- Scripts/webkitpy/common/config/watchlist: Added myself.
- 3:37 AM WebKitIDL edited by
- Remove [TransferList] (diff)
- 3:16 AM Changeset in webkit [149727] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip remaining Shadow DOM tests on the EFL port.
- platform/efl/TestExpectations:
- 2:50 AM Changeset in webkit [149726] by
-
- 2 edits in trunk/Tools
[Qt] Build fails with clang
https://bugs.webkit.org/show_bug.cgi?id=115741
Reviewed by Benjamin Poulain.
Since r149112 std::move is used in AtomicString for compilers that
support rvalue references and this requires a standard library
implementing c++11 move semantics.
We only explicitely require c++11 for WebKit2, but since clang supports
rvalue references the build of subtargets using AtomicString fails because
of missing std::move.
It is safe to add CONFIG += c++11 for the whole project when using clang
since we explicitely disable c++11 for ANGLE that had probems with libc++.
- qmake/mkspecs/features/unix/default_pre.prf:
- 2:41 AM Changeset in webkit [149725] by
-
- 3 edits in trunk/Tools
Fix one more place that needed to use adoptCF/NS
https://bugs.webkit.org/show_bug.cgi?id=115778
Reviewed by Benjamin Poulain.
Not sure why I missed this code last time, but found a bit more code that needs
to switch to the newer style adoptCF/NS.
- WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
(convertWebResourceDataToString): Use adoptCF.
(convertWebResourceResponseToDictionary): Ditto.
(createXMLStringFromWebArchiveData): Ditto.
- WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
(createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
- 2:23 AM Changeset in webkit [149724] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding failure expectations for CSS Regions tests
that regressed when converted into reftests in r149668.
- 1:55 AM Changeset in webkit [149723] by
-
- 7 edits in trunk
Make optional arguments in CanvasRenderingContext2D match the spec.
https://bugs.webkit.org/show_bug.cgi?id=115723
Patch by Dongseong Hwang <dongseong.hwang@intel.com> on 2013-05-08
Reviewed by Dean Jackson.
Source/WebCore:
WebKit r98985 set many arguments optional although the canvas spec[1] does not
indicate. So this patch corrects CanvasRenderingContext2D.idl to match the spec.
[1] http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas/
Covered by existing tests:
canvas/philip/tests/2d.missingargs.html
fast/canvas/canvas-overloads-strokeRect.html
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html
- html/canvas/CanvasRenderingContext2D.idl:
LayoutTests:
When tests use <canvas> API with not enough arguments, TypeError
exception is fired now. So three tests are changed to match the canvas
spec.
- fast/canvas/canvas-overloads-strokeRect-expected.txt:
- fast/canvas/script-tests/canvas-overloads-strokeRect.js:
- platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
- 1:54 AM WebKitIDL edited by
- Rename JSCustomIsReachable to CustomIsReachable and … (diff)
- 1:50 AM WebKitIDL edited by
- Remove JSCustomHeader (diff)
- 1:48 AM WebKitIDL edited by
- Remove remaining mentions of V8 (diff)
- 1:45 AM WebKitIDL edited by
- Remove V8DoNotCheckSignature (diff)
- 1:45 AM WebKitIDL edited by
- Remove V8CustomIsReachable (diff)
- 1:43 AM WebKitIDL edited by
- Remove [URL] (diff)
- 1:42 AM WebKitIDL edited by
- Remove V8GenerateIsReachable and JSGenerateIsReachable (diff)
- 1:40 AM WebKitIDL edited by
- Remove V8DependentLifeTime (diff)
- 1:39 AM WebKitIDL edited by
- Remove V8CustomIndexedGetter (diff)
- 1:38 AM WebKitIDL edited by
- Remove dead section from TOC (diff)
- 1:36 AM WebKitIDL edited by
- Remove V8EnabledAtRuntime, V8EnabledPerContext from TOC (diff)
- 1:35 AM WebKitIDL edited by
- Remove V8Unforgeable and V8OnProto (diff)
- 1:33 AM WebKitIDL edited by
- Remove V8ReadOnly (diff)
- 1:29 AM WebKitIDL edited by
- Remove mentions of JSCustom and V8Custom (diff)
- 1:28 AM Changeset in webkit [149722] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r149271.
http://trac.webkit.org/changeset/149271
https://bugs.webkit.org/show_bug.cgi?id=115780
The mangled symbols are now enforced through LDFLAGS
(Requested by zdobersek on #webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2013-05-08
- BuildSlaveSupport/gtk/daemontools-buildbot.conf:
- 1:19 AM WebKitIDL edited by
- Rename V8SkipVTableValidation to SkipVTableValidation (diff)
- 1:16 AM WebKitIDL edited by
- Remove mentions of toV8() (diff)
- 1:14 AM Changeset in webkit [149721] by
-
- 2 edits in trunk/Tools
[Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
https://bugs.webkit.org/show_bug.cgi?id=115636
Reviewed by Ryosuke Niwa.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
while Chromium-specific, can't be removed just yet as there's more code that uses it.
- 1:14 AM WebKitIDL edited by
- Use more monospace (diff)
- 1:06 AM Changeset in webkit [149720] by
-
- 6 edits in trunk/Source/WebKit2
[WK2] Make the WebNetworkInfoManager a supplement to the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=115716
Reviewed by Andreas Kling.
WebNetworkInfoManager should inherit from WebProcessSupplement and should be used
as such by the WebProcess. This removes the need for the m_networkInfoManager member
variable in the WebProcess class and brings the WebNetworkInfoManager in line with
other manager classes of which instances are controlled by the WebProcess class.
- WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:
(WebKit::WebNetworkInfoManager::supplementName): Specify the supplement's name.
(WebKit):
- WebProcess/NetworkInfo/WebNetworkInfoManager.h:
(WebKit): Alphabetically reorder the two forwarding declarations.
(WebNetworkInfoManager): Inherit from the WebProcessSupplement interface.
- WebProcess/WebCoreSupport/WebNetworkInfoClient.cpp:
(WebKit::WebNetworkInfoClient::bandwidth): Access the WebNetworkInfoManager as a supplement.
(WebKit::WebNetworkInfoClient::metered): Ditto.
(WebKit::WebNetworkInfoClient::startUpdating): Ditto.
(WebKit::WebNetworkInfoClient::stopUpdating): Ditto.
(WebKit::WebNetworkInfoClient::networkInfoControllerDestroyed): Ditto.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess): Add the WebNetworkInfoManager instance as a supplement.
- WebProcess/WebProcess.h:
(WebProcess): Remove the m_networkInfoManager member variable and its getter method.
- 1:02 AM Changeset in webkit [149719] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Correct documentation for ewk_settings APIs
https://bugs.webkit.org/show_bug.cgi?id=115507
Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-05-08
Reviewed by Gyuyoung Kim.
Corrected documentation for ewk_settings APIs.
- ewk/ewk_settings.h:
- 1:01 AM WebKitIDL edited by
- Use more monospace (diff)
- 12:58 AM Changeset in webkit [149718] by
-
- 3 edits in trunk/Source/WebCore
Remove unused method and de-virtualize others in Element.h
https://bugs.webkit.org/show_bug.cgi?id=115770
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/c2c2ff9cb69f46f5cc9d289b2bfbdb8ab5bd3e49
The de-virtualization possibilities were noted whilst "FINALizing" the Node
hierarchy. If a method is successfully marked FINAL but then fails when marked
OVERRIDE as well, the method by definition does not need to be virtual.
- WebCore.exp.in:
- dom/Element.h:
(WebCore::Element::hasAuthorShadowRoot):
- 12:52 AM WebKitIDL edited by
- Use more monospace (diff)
- 12:51 AM Changeset in webkit [149717] by
-
- 6 edits in trunk/Source/WebKit2
[WK2] Make the WebBatteryManager a supplement to the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=115715
Reviewed by Andreas Kling.
WebBatteryManager should inherit from WebProcessSupplement and should be used as such
by the WebProcess. This removes the need for the m_batteryManager member variable in
the WebProcess class and brings the WebBatteryManager in line with other manager classes
of which instances are controlled by the WebProcess class.
- WebProcess/Battery/WebBatteryManager.cpp:
(WebKit::WebBatteryManager::supplementName): Specify the supplement's name.
(WebKit):
- WebProcess/Battery/WebBatteryManager.h:
(WebBatteryManager): Inherit from the WebProcessSupplement interface.
- WebProcess/WebCoreSupport/WebBatteryClient.cpp:
(WebKit::WebBatteryClient::startUpdating): Access the WebBatteryManager as a supplement.
(WebKit::WebBatteryClient::stopUpdating): Ditto.
(WebKit::WebBatteryClient::batteryControllerDestroyed): Ditto.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess): Add the WebBatteryManager instance as a supplement.
- WebProcess/WebProcess.h:
(WebProcess): Remove the m_batteryManager member variable and its getter method.
- 12:44 AM WebKitIDL edited by
- Use more monospace (diff)
- 12:40 AM Changeset in webkit [149716] by
-
- 94 edits in trunk
Source/WebCore: Use adoptCF and adoptNS in more places
https://bugs.webkit.org/show_bug.cgi?id=115657
Reviewed by Sam Weinig.
This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.
- platform/cf/win/CertificateCFWin.cpp:
(WebCore::copyCertificateToData):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMinTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeLoaded):
(WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes):
(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged):
(WebCore::AVFWrapper::createAssetForURL):
(WebCore::AVFWrapper::createPlayer):
(WebCore::AVFWrapper::createPlayerItem):
(WebCore::AVFWrapper::setAsset):
(WebCore::AVFWrapper::platformLayer):
(WebCore::AVFWrapper::createAVCFVideoLayer):
(WebCore::AVFWrapper::createImageGenerator):
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::language):
- platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(toCACFTimingFunction):
(PlatformCAAnimation::PlatformCAAnimation):
(PlatformCAAnimation::setFromValue):
(PlatformCAAnimation::setToValue):
(PlatformCAAnimation::setValues):
(PlatformCAAnimation::setKeyTimes):
(PlatformCAAnimation::setTimingFunctions):
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::setBackgroundColor):
(PlatformCALayer::setBorderColor):
- platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::PlatformCALayerWinInternal):
(PlatformCALayerWinInternal::addTile):
- platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
(WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost):
- platform/graphics/gstreamer/PlatformVideoWindowMac.mm:
(PlatformVideoWindow::PlatformVideoWindow):
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::getPostScriptName):
(WebCore::FontPlatformData::platformDataInit):
- platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawWindowsBitmap):
- platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::create):
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::rfc2616DateStringFromTime):
(WebCore::QTCFDictionaryCreateWithDataCallback):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
- platform/graphics/win/WKCAImageQueue.cpp:
(WebCore::WKCAImageQueue::WKCAImageQueue):
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::qcmsOutputDeviceProfile):
- platform/network/cf/AuthenticationCF.cpp:
(WebCore::core):
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::cookieDomain):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):
(WebCore::filterCookies):
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::certificatePath):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::urlFromPath):
(WebCore::getURL):
- platform/win/LocalizedStringsWin.cpp:
(WebCore::createWebKitBundle):
(WebCore::localizedString):
- platform/win/SearchPopupMenuWin.cpp:
(WebCore::SearchPopupMenuWin::saveRecentSearches):
(WebCore::SearchPopupMenuWin::loadRecentSearches):
- plugins/mac/PluginPackageMac.cpp:
(WebCore::stringListFromResourceId):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):
- plugins/mac/PluginViewMac.mm:
(WebCore::PluginView::platformStart):
- rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::platformFocusRingColor):
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):
Use adoptCF and adoptNS throughout.
Source/WebKit/win: Use adoptCF and adoptNS in more places
https://bugs.webkit.org/show_bug.cgi?id=115657
Reviewed by Sam Weinig.
This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.
- CFDictionaryPropertyBag.cpp:
(CFDictionaryPropertyBag::Write):
- WebCache.cpp:
(WebCache::statistics):
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::localizedStringsURL):
- WebDatabaseManager.cpp:
(WebDatabaseManager::dispatchDidModifyDatabase):
- WebDownloadCFNet.cpp:
(WebDownload::init):
(WebDownload::initWithRequest):
(WebDownload::initToResumeWithBundle):
(WebDownload::cancelForResume):
(WebDownload::useCredential):
(WebDownload::didReceiveAuthenticationChallenge):
- WebError.cpp:
(WebError::sslPeerCertificate):
- WebHistory.cpp:
(createUserInfoFromArray):
(createUserInfoFromHistoryItem):
(WebHistory::WebHistory):
(WebHistory::loadFromURL):
(WebHistory::loadHistoryGutsFromURL):
(WebHistory::saveToURL):
(WebHistory::saveHistoryGuts):
(WebHistory::removeAllItems):
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::itemForURL):
(WebHistory::addItemToDateCaches):
(getDayBoundaries):
- WebIconDatabase.cpp:
(postDidAddIconNotification):
- WebLocalizableStrings.cpp:
(cfBundleForStringsBundle):
- WebMutableURLRequest.cpp:
(WebMutableURLRequest::mutableCopy):
- WebPreferences.cpp:
(cfNumber):
(WebPreferences::initializeDefaultSettings):
(WebPreferences::valueForKey):
(WebPreferences::setStringValue):
(WebPreferences::load):
(WebPreferences::migrateWebKitPreferencesToCFPreferences):
(WebPreferences::setPreferenceForTest):
- WebView.cpp:
(WebView::setCacheModel):
(WebView::notifyPreferencesChanged):
Use adoptCF and adoptNS.
Source/WebKit2: Use adoptCF and adoptNS in more places
https://bugs.webkit.org/show_bug.cgi?id=115657
Reviewed by Sam Weinig.
- Shared/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::useCredential):
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::didDecideDestination):
Use adoptCF and adoptNS.
Tools: Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
https://bugs.webkit.org/show_bug.cgi?id=115657
Reviewed by Sam Weinig.
This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.
- DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
(convertWebResourceDataToString):
(convertWebResourceResponseToDictionary):
(createXMLStringFromWebArchiveData):
- DumpRenderTree/cg/ImageDiffCG.cpp:
(createImageFromStdin):
(createDifferenceImage):
(main):
- DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(printPNG):
(dumpBitmap):
- DumpRenderTree/cg/PixelDumpSupportCG.h:
(BitmapContext::BitmapContext):
- DumpRenderTree/mac/MockWebNotificationProvider.mm:
(-[MockWebNotificationProvider init]):
- DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContext):
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::addDisallowedURL):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::localStorageDiskUsageForOrigin):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::copyDecodedHostName):
(TestRunner::copyEncodedHostName):
(TestRunner::queueLoad):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setValueForUser):
(TestRunner::overridePreference):
(TestRunner::setPersistentUserStyleSheetLocation):
(TestRunner::execCommand):
(TestRunner::findString):
(TestRunner::isCommandEnabled):
(TestRunner::addOriginAccessWhitelistEntry):
(TestRunner::removeOriginAccessWhitelistEntry):
(TestRunner::addUserScript):
(TestRunner::addUserStyleSheet):
(TestRunner::evaluateInWebInspector):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::apiTestNewWindowDataLoadBaseURL):
(-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
(TestRunner::authenticateSession):
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):
- DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
(createCFURLResponseFromResponseData):
- DumpRenderTree/mac/WorkQueueItemMac.mm:
(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(ScriptItem::invoke):
- DumpRenderTree/win/DumpRenderTree.cpp:
(substringFromIndex):
(urlSuitableForTestResult):
(lastPathComponent):
(sharedCFURLCache):
- DumpRenderTree/win/ImageDiffCairo.cpp:
(createImageFromStdin):
(main):
- DumpRenderTree/win/PixelDumpSupportWin.cpp:
(createBitmapContextFromWebView):
- DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setPersistentUserStyleSheetLocation):
- TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
- TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
(TestWebKitAPI::createWindow):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
(TestWebKitAPI::AcceptsFirstMouse::runTest):
- TestWebKitAPI/Tests/mac/AttributedString.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/BackForwardList.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
(TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
- TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
(TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
- TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/InspectorBar.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
- TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::MIMETypeForWKURLResponse):
- TestWebKitAPI/mac/WebKitAgnosticTest.mm:
(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
- WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
(WTR::testPathFromURL):
- WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
- WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::createCGContextFromImage):
(WTR::dumpBitmap):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseScrollBy):
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::windowSnapshotImage):
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeTestPluginDirectory):
Use adoptCF and adoptNS.
- 12:36 AM WebKitIDL edited by
- Start using monospace for IDL extended attributes (diff)
- 12:24 AM WebKitIDL edited by
- Remove deprecated "in" keyword from IDL examples (diff)
- 12:05 AM Changeset in webkit [149715] by
-
- 2 edits in trunk/LayoutTests
Add an image only failure expectation to fast/css-generated-content/close-quote-negative-depth.html per
bug 115776 after r149700. r149707 tried to fix its regression but this test is still failing.
- 12:04 AM WebKitIDL edited by
- Update documentation for optional and [Default] (diff)
- 12:03 AM Changeset in webkit [149714] by
-
- 2 edits in trunk
[Automake] Pass --no-demangle to the linker by default to get the mangled symbols
https://bugs.webkit.org/show_bug.cgi?id=115732
Reviewed by Gustavo Noronha Silva.
- GNUmakefile.am: Pass the --no-demangle option to the linker by default. This is done by appending
the flag to the LDFLAGS variable. While the AM_LDFLAGS variable would be more appropriate, it's not
at all used when linking installable libraries like libwebkitgtk and libwebkit2gtk, so the LDFLAGS
variable is used instead.
- 12:00 AM Changeset in webkit [149713] by
-
- 2 edits in trunk/Source/WebKit/mac
<rdar://problem/13633007> WebKit and others fail to build headers due to build root dependency
Reviewed by Sam Weinig.
- Configurations/WebKit.xcconfig: Look for WebCore's headers within the SDK if we're building against one.
May 7, 2013:
- 11:24 PM Changeset in webkit [149712] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Remove the ewk_settings_shadow_dom_enable_set/get APIs from unit test
https://bugs.webkit.org/show_bug.cgi?id=115771
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-05-07
Reviewed by Gyuyoung Kim.
Unit test is failing since r149702. Remove the test case related to shadow dom.
- tests/test_ewk_setting.cpp:
- 10:08 PM Changeset in webkit [149711] by
-
- 5 edits in trunk/Source/WebKit/blackberry
Clean up load interface in WebPage
https://bugs.webkit.org/show_bug.cgi?id=115622
Patch by Xuefei Ren <xren@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.
Internal PR:315535
Internal reviewed by Mary Wu
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::load):
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::startDownload):
- 8:18 PM Changeset in webkit [149710] by
-
- 3 edits in trunk/Source/WebCore
Make CanvasStyle's CMYKAValues allocated on the heap and move the pointer in the union.
https://bugs.webkit.org/show_bug.cgi?id=115764
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-07
Reviewed by Andreas Kling.
CMYKA input is uncommon enough that we should not pay the price for
every CanvasStyle.
Make those values heap allocated and put the pointer in the union. Since
the RGBA32 values are needed for CMYKA, a RGBA32 value is added to the structure.
- html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::~CanvasStyle):
(WebCore::CanvasStyle::isEquivalentColor):
(WebCore::CanvasStyle::isEquivalentCMYKA):
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
- html/canvas/CanvasStyle.h:
(CanvasStyle):
(CMYKAValues):
(WebCore::CanvasStyle::CMYKAValues::CMYKAValues):
(WebCore::CanvasStyle::color):
(WebCore):
- 7:41 PM Changeset in webkit [149709] by
-
- 3 edits in trunk/Source/WebCore
Use OwnPtr instead of deleteAllValues for requests in PluginView
https://bugs.webkit.org/show_bug.cgi?id=115731
Reviewed by Sam Weinig.
- plugins/PluginView.cpp:
(WebCore::PluginView::~PluginView): Removed the call to deleteAllValues.
(WebCore::PluginView::requestTimerFired): Use release to remove an OwnPtr
from m_requests rather than an explicit delete. Also use !isEmpty instead
of size > 0.
(WebCore::PluginView::scheduleRequest): Changed argument type to PassOwnPtr.
(WebCore::PluginView::load): Use adoptPtr to call scheduleRequest.
- plugins/PluginView.h: Changed argument type of scheduleRequest to
PassOwnPtr, and m_requests to a Vector<OwnPtr>.
- 7:03 PM Changeset in webkit [149708] by
-
- 18 edits2 deletes in trunk/Source
Remove SelectRuleFeatureSet
https://bugs.webkit.org/show_bug.cgi?id=115757
Reviewed by Benjamin Poulain.
This is dead code.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore):
(WebCore::Element::didAffectSelector):
- dom/Element.h:
(Element):
- dom/ElementShadow.h:
(WebCore::ElementShadow::invalidateDistribution):
- html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::ContentDistributor):
(WebCore):
- html/shadow/ContentDistributor.h:
(ContentDistributor):
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::insertedInto):
(WebCore::InsertionPoint::removedFrom):
- html/shadow/InsertionPoint.h:
(InsertionPoint):
- html/shadow/SelectRuleFeatureSet.cpp: Removed.
- html/shadow/SelectRuleFeatureSet.h: Removed.
- testing/Internals.cpp:
(WebCore):
- testing/Internals.idl:
- 6:47 PM Changeset in webkit [149707] by
-
- 3 edits in trunk/Source/WebCore
Store the quotes in the same allocation as the QuotesData object
https://bugs.webkit.org/show_bug.cgi?id=115768
Reviewed by Andreas Kling.
Since the QuotesData object is immutable we don't need a Vector to store the quote pairs,
they can just be stored after the class data.
- rendering/style/QuotesData.cpp:
(WebCore::sizeForQuotesDataWithQuoteCount):
Helper function for computing the allocation size.
(WebCore::QuotesData::create):
Use fastMalloc + placement new.
(WebCore::QuotesData::QuotesData):
Use placement new to allocate the quote pairs.
(WebCore::QuotesData::~QuotesData):
Destroy the quote pairs.
(WebCore::QuotesData::openQuote):
Stop using Vector.
(WebCore::QuotesData::closeQuote):
Ditto.
(WebCore::operator==):
Ditto.
- rendering/style/QuotesData.h:
- 6:42 PM Changeset in webkit [149706] by
-
- 2 edits in trunk/Source/WebCore
We should not ref() the RefPtr twice in CanvasStyle
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-07
Reviewed by Darin Adler.
- html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
We leak the ref of PassRefPtr, we should not ref() it a second time.
- 6:41 PM Changeset in webkit [149705] by
-
- 14 edits in trunk/Source/WebCore
Devirtualize Document class type checking
https://bugs.webkit.org/show_bug.cgi?id=115755
Reviewed by Benjamin Poulain.
Merge https://chromium.googlesource.com/chromium/blink/+/dae5adc768d5ce6bff301df6515745da8ea24950
Document has a bunch of virtual bool is*Document() methods on it, but it also has
two bools for XHTML and HTML documents which is silly. We can merge them all
together into an enum of values and devirtualize the type checking methods.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::createElement):
- dom/Document.h:
(WebCore::Document::create):
(WebCore::Document::createXHTML):
(WebCore::Document::isHTMLDocument):
(WebCore::Document::isXHTMLDocument):
(WebCore::Document::isImageDocument):
(WebCore::Document::isSVGDocument):
(WebCore::Document::isPluginDocument):
(WebCore::Document::isMediaDocument):
(WebCore::Document):
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::HTMLDocument):
- html/HTMLDocument.h:
(WebCore::HTMLDocument):
- html/ImageDocument.cpp:
(WebCore::ImageDocument::ImageDocument):
- html/ImageDocument.h:
(WebCore::ImageDocument):
- html/MediaDocument.cpp:
(WebCore::MediaDocument::MediaDocument):
- html/MediaDocument.h:
(WebCore::MediaDocument):
- html/PluginDocument.cpp:
(WebCore::PluginDocument::PluginDocument):
- html/PluginDocument.h:
(WebCore::PluginDocument):
- loader/PlaceholderDocument.h:
(WebCore::PlaceholderDocument::PlaceholderDocument):
- svg/SVGDocument.cpp:
(WebCore::SVGDocument::SVGDocument):
- svg/SVGDocument.h:
(WebCore::SVGDocument):
- 6:35 PM Changeset in webkit [149704] by
-
- 2 edits in trunk/Tools
Fix a memory leak introduced in r149692
https://bugs.webkit.org/show_bug.cgi?id=115766
Patch by Alex Christensen <achristensen@apple.com> on 2013-05-07
Reviewed by Mark Rowe.
In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any
matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
- 6:26 PM Changeset in webkit [149703] by
-
- 2 edits in trunk/Tools
[Win] Fix storage leak in Windows DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=115651
Reviewed by Sam Weinig.
- DumpRenderTree/win/DumpRenderTree.cpp:
(lastPathComponent): Added a missing call to adoptCF.
- 6:13 PM Changeset in webkit [149702] by
-
- 3 edits in trunk
[CMAKE] Remove SHADOW_DOM from cmakeconfig.h.cmake
https://bugs.webkit.org/show_bug.cgi?id=115712
Reviewed by Andreas Kling.
Nobody uses SHADOW_DOM in cmake.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- 5:11 PM Changeset in webkit [149701] by
-
- 3 edits in trunk/Source/WebKit2
Add SPI to get an array of all the installed plug-ins
https://bugs.webkit.org/show_bug.cgi?id=115688
Reviewed by Anders Carlsson.
- UIProcess/API/C/mac/WKContextPrivateMac.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(createInfoDictionary):
Extract creation of info dictionary into helper.
(WKContextCopyPlugInInfoForBundleIdentifier):
Modified to use the new helper.
(WKContextGetInfoForInstalledPlugIns):
Added.
- 4:07 PM Changeset in webkit [149700] by
-
- 7 edits in trunk/Source/WebCore
Begin unraveling the mess that is QuotesData
https://bugs.webkit.org/show_bug.cgi?id=115765
Reviewed by Andreas Kling.
Change QuotesData to be an immutable object and fix other things that are broken.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
QuotesData::addPair is gone. Instead, create the Vector up front and pass it to QuotesData.
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::originalText):
Update for renames.
- rendering/style/QuotesData.cpp:
(WebCore::QuotesData::create):
Remove the create overload that wasn't used. Add a new create overload that takes a Vector.
(WebCore::QuotesData::openQuote):
Rename this from getOpenQuote and clean it up.
(WebCore::QuotesData::closeQuote):
Rename this from getCloseQuote and clean it up.
(WebCore::operator==):
Replace the equals member function with a proper equality operator.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
Stop calling QuotesData::equals. Use the same idiom as used for other properties.
(WebCore::RenderStyle::setQuotes):
- rendering/style/StyleRareInheritedData.cpp:
Use operator==.
(WebCore::quotesDataEquivalent):
Add helper function.
(WebCore::StyleRareInheritedData::operator==):
Call quotesDataEquivalent.
- 3:54 PM Changeset in webkit [149699] by
-
- 3 edits1 add1 delete in trunk/LayoutTests
[CSS Exclusions] shape-inside, shape-padding, polygon test failing when subpixel layout is disabled
https://bugs.webkit.org/show_bug.cgi?id=115649
Reviewed by Dirk Schulze.
Another correction of a padded shape test that failed when subpixel layout was disabled.
This test puts a cross pattern made of five Ahem characters on three lines, within a padded
diamond polygon. The left edges of each line depend on the intersection of the padded polygon's
edges with the top of each line, which makes predicting the exact values unreliable. So we
just verify that the left edges of each line are within a pixel of the ideal value. This
change is very similar to the one made for bug 115490.
- fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.html: Removed.
- fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.txt: Added.
- fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html:
- platform/mac/TestExpectations:
- 3:41 PM Changeset in webkit [149698] by
-
- 3 edits3 adds in trunk
Support -webkit-system-font on OS X.
https://bugs.webkit.org/show_bug.cgi?id=115758
<rdar://problem/13433854>
- 3:26 PM Changeset in webkit [149697] by
-
- 2 edits in trunk/Tools
fixed a memory leak introduced by bug 42324 by using a RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=115760
Patch by Alex Christensen <achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
fixed memory leak, added UNUSED_PARAM macros
- 3:14 PM Changeset in webkit [149696] by
-
- 3 edits in trunk/Source/WebCore
Move CanvasGradient and CanvasPattern in the union of CanvasStyle
https://bugs.webkit.org/show_bug.cgi?id=115759
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-07
Reviewed by Andreas Kling.
The Gradient and Pattern are exclusive with the other values, but they
were left out of the union because they are ref-counted.
This patch moves them in the union, and simply does the ref-counting manually.
- html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::~CanvasStyle):
- html/canvas/CanvasStyle.h:
(CanvasStyle):
(WebCore::CanvasStyle::canvasGradient):
(WebCore::CanvasStyle::canvasPattern):
- 3:06 PM Changeset in webkit [149695] by
-
- 3 edits in trunk/Source/WebCore
Remove custom allocator support from PODArena
https://bugs.webkit.org/show_bug.cgi?id=115762
Reviewed by Andreas Kling.
Nobody uses PODArena with a custom allocator, so just get rid of it and always use fastMalloc/fastFree.
- platform/PODArena.h:
(WebCore::PODArena::PODArena):
(WebCore::PODArena::allocateBase):
(WebCore::PODArena::Chunk::Chunk):
(WebCore::PODArena::Chunk::~Chunk):
(Chunk):
- platform/PODFreeListArena.h:
(WebCore::PODFreeListArena::allocate):
(WebCore::PODFreeListArena::FreeListChunk::FreeListChunk):
- 3:04 PM Changeset in webkit [149694] by
-
- 12 edits in trunk/Source
Clean up KeyframeValueList and related classes
https://bugs.webkit.org/show_bug.cgi?id=115738
Reviewed by Simon Fraser.
Source/WebCore:
Add static create() functions to the AnimationValue subclasses, and change a bunch of parameters
and return values that can never be null from pointer types to reference types to better indicate this.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::filterOperationsAt):
(WebCore::GraphicsLayer::validateFilterOperations):
(WebCore::operationsAt):
(WebCore::GraphicsLayer::validateTransformOperations):
- platform/graphics/GraphicsLayer.h:
(AnimationValue):
(WebCore::AnimationValue::AnimationValue):
(WebCore::FloatAnimationValue::create):
(FloatAnimationValue):
(WebCore::FloatAnimationValue::FloatAnimationValue):
(WebCore::TransformAnimationValue::create):
(TransformAnimationValue):
(WebCore::TransformAnimationValue::value):
(WebCore::TransformAnimationValue::TransformAnimationValue):
(WebCore::FilterAnimationValue::create):
(WebCore::FilterAnimationValue::value):
(WebCore::FilterAnimationValue::FilterAnimationValue):
(FilterAnimationValue):
(WebCore::KeyframeValueList::~KeyframeValueList):
(KeyframeValueList):
(WebCore::KeyframeValueList::at):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::animationHasStepsTimingFunction):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerCA::setAnimationEndpoints):
(WebCore::GraphicsLayerCA::setAnimationKeyframes):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::setFilterAnimationEndpoints):
(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
Source/WebKit2:
Update for WebCore changes.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::decode):
- 2:52 PM Changeset in webkit [149693] by
-
- 7 edits in trunk/Source
Add and remove databases and origins from the database tracker
https://bugs.webkit.org/show_bug.cgi?id=115752
Reviewed by Andreas Kling.
Source/WebCore:
Add symbols needed by WebKit2.
- WebCore.exp.in:
Source/WebKit2:
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::LocalStorageDatabase):
Rename m_databaseFilename to m_databasePath.
(WebKit::LocalStorageDatabase::tryToOpenDatabase):
Rename m_databaseFilename to m_databasePath.
- UIProcess/Storage/LocalStorageDatabase.h:
Rename m_databaseFilename to m_databasePath.
- UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::databasePath):
Rename databaseFilename to databasePath.
(WebKit::LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin):
Call addDatabaseWithOriginIdentifier.
(WebKit::LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin):
Call removeDatabaseWithOriginIdentifier.
(WebKit::LocalStorageDatabaseTracker::trackerDatabasePath):
Call databasePath instead of databaseFile.
(WebKit::LocalStorageDatabaseTracker::openTrackerDatabase):
Bail if the database is already open.
(WebKit::LocalStorageDatabaseTracker::updateTrackerDatabaseFromLocalStorageDatabaseFiles):
Call addDatabaseWithOriginIdentifier if this is an origin we don't know about.
(WebKit::LocalStorageDatabaseTracker::addDatabaseWithOriginIdentifier):
Add the database to the Origins table.
(WebKit::LocalStorageDatabaseTracker::removeDatabaseWithOriginIdentifier):
remove the database from the Origins table and delete it.
(WebKit::LocalStorageDatabaseTracker::pathForDatabaseWithOriginIdentifier):
Helper function that looks up a database path given its identifier.
- UIProcess/Storage/LocalStorageDatabaseTracker.h:
Rename databaseFile to databasePath.
- 2:26 PM Changeset in webkit [149692] by
-
- 6 edits4 adds in trunk/Tools
WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
https://bugs.webkit.org/show_bug.cgi?id=42324
<rdar://problem/8193633>
Patch by Alex Christensen <achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.
- Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
- Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
Added dumpDOMAsWebArchive code that is called when dumping.
(WTR::InjectedBundlePage::dump):
Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
- Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
Added dumpDOMAsWebArchive declaration.
- Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::dumpDOMAsWebArchive):
Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
- Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
- Tools/WebKitTestRunner/cf: Added.
- Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
(convertMIMEType):
(convertWebResourceDataToString):
(normalizeHTTPResponseHeaderFields):
(normalizeWebResourceURL):
(convertWebResourceResponseToDictionary):
(compareResourceURLs):
(createXMLStringFromWebArchiveData):
- Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
Copied from Tools/DumpRenderTree/cf for used symbol declarations.
- Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
Copied from Tools/DumpRenderTree/mac for used functions.
(createCFURLResponseFromResponseData):
(supportedNonImageMIMETypes):
- 2:12 PM Changeset in webkit [149691] by
-
- 3 edits in trunk/Source/WebCore
Still possible to fire paint-related LayoutMilestones before CA has committed the
changes
https://bugs.webkit.org/show_bug.cgi?id=115753
-and corresponding-
<rdar://problem/13822315>
Reviewed by Simon Fraser.
To ensure we wait for the CA commit, we should wait until the end of the runloop
with a zero-delay timer.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::paintRelatedMilestonesTimerFired):
(WebCore):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 2:09 PM Changeset in webkit [149690] by
-
- 2 edits in trunk/Source/WebCore
Bug 115694 - Fix bad cast to RenderHTMLCanvas
https://bugs.webkit.org/show_bug.cgi?id=115694
Reviewed by Ryosuke Niwa.
Don't cast to RenderHTML until we check what kind of object it is.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- 1:30 PM Changeset in webkit [149689] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Increase the padding size for caret based scrolling.
https://bugs.webkit.org/show_bug.cgi?id=115749
Reviewed by Rob Buis.
PR 322670.
Increasing the padding size for scrolling in order to optimize the
number of scrolls required during typing.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 1:07 PM Performance Tests edited by
- (diff)
- 12:42 PM Changeset in webkit [149688] by
-
- 7 edits in trunk/Source
The storage database tracker should know when databases come and go
https://bugs.webkit.org/show_bug.cgi?id=115748
Reviewed by Andreas Kling.
Source/WebCore:
Export symbol needed by WebKit2.
- WebCore.exp.in:
Source/WebKit2:
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::openDatabase):
If we've opened the database successfully, call LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin.
(WebKit::LocalStorageDatabase::tryToOpenDatabase):
Remove a FIXME; we run all storage related things on the same thread.
(WebKit::LocalStorageDatabase::close):
Close the database. If it's empty, call LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin.
(WebKit::LocalStorageDatabase::databaseIsEmpty):
Helper function for determining whether a database is empty.
- UIProcess/Storage/LocalStorageDatabase.h:
- UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::databaseFilename):
Add ".localstorage" to the filename.
(WebKit::LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin):
(WebKit::LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin):
Add empty stubs.
- 12:11 PM Changeset in webkit [149687] by
-
- 3 edits in trunk/Source/WebKit2
Add JoinExistingSession to the Networking XPC.
<rdar://problem/12902288> and https://bugs.webkit.org/show_bug.cgi?id=114991
Reviewed by Sam Weinig.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist:
- 12:08 PM Changeset in webkit [149686] by
-
- 2 edits in trunk/Tools
Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=115745
Patch by Alex Christensen <achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.
- DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
(compareResourceURLs):
Updated style.
- 11:52 AM Changeset in webkit [149685] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Maintain touch event state throughout processing
https://bugs.webkit.org/show_bug.cgi?id=115663
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.
Internally reviewed by Otto Cheung and Genevieve Mak.
PR 297691
By maintaining our touch event state, we can get a better idea
of what triggered an update to selection and respond appropriately.
On touch press we set userTouchTriggered to give the UI thread
some context.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- 11:42 AM Changeset in webkit [149684] by
-
- 3 edits in trunk/Source/WebCore
Use OwnPtr instead of deleteAllValues in SVGResourcesCache
https://bugs.webkit.org/show_bug.cgi?id=115729
Reviewed by Benjamin Poulain.
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::~SVGResourcesCache): Removed call to deleteAllValues.
(WebCore::SVGResourcesCache::addResourcesFromRenderObject): Use adoptPtr and release
to create new SVGResources object.
(WebCore::SVGResourcesCache::removeResourcesFromRenderObject): Use take to remove
the SVGResources from the map rather than a get combined with delete/take.
(WebCore::SVGResourcesCache::cachedResourcesForRenderObject): Removed unneeded
call to contains, since get already returns 0 if there is no item in the map.
(WebCore::SVGResourcesCache::resourceDestroyed): Use typedef for the map type so
we don't have to repeat the type.
- rendering/svg/SVGResourcesCache.h: Added typedef CacheMap, and changed value
type to OwnPtr.
- 11:30 AM Changeset in webkit [149683] by
-
- 4 edits in trunk/Source
REGRESSION(r149647): Assertion failure in LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal
https://bugs.webkit.org/show_bug.cgi?id=115711
Reviewed by Andreas Kling.
Source/WebCore:
Export SQLiteDatabase::close.
- WebCore.exp.in:
Source/WebKit2:
Handle setting the local storage directory more than once.
- UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal):
Close the database (if necessary) and clear the origins map before importing the origin identifiers.
- 11:12 AM Changeset in webkit [149682] by
-
- 4 edits in trunk/Source/WebKit2
Re-establish autostart timeout extension on user interaction
https://bugs.webkit.org/show_bug.cgi?id=113232
Change WebProcess::pluginDidReceiveUserInteraction to use a tuple of
(pluginOrigin, pageOrigin, mimeType) arguments like the other similar
WebProcess methods and gather these arguments from the PlugInView's
plug-in element.
Reviewed by Dean Jackson.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginDidReceiveUserInteraction):
Cast the m_pluginElement to a HTMLPlugInImageElement so we can obtain the
tuple of (pluginOrigin, pageOrigin, mimeType) to pass to pluginDidReceiveUserInteraction().
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::plugInDidReceiveUserInteraction):
- WebProcess/WebProcess.h:
(WebProcess):
Update method signature to a tuple of (pluginOrigin, pageOrigin, mimeType)
and obtain the plug-in origin hash from that.
- 10:58 AM Changeset in webkit [149681] by
-
- 26 edits1 delete in trunk/LayoutTests
Combine html and js parts fast/url script-tests
https://bugs.webkit.org/show_bug.cgi?id=115739
Rubber-stamped by Brady Eidson.
- fast/url/anchor.html:
- fast/url/file-http-base.html:
- fast/url/file.html:
- fast/url/host-lowercase-per-scheme.html:
- fast/url/host.html:
- fast/url/idna2003.html:
- fast/url/idna2008.html:
- fast/url/invalid-urls-utf8.html:
- fast/url/ipv4.html:
- fast/url/ipv6.html:
- fast/url/mailto.html:
- fast/url/path-url.html:
- fast/url/path.html:
- fast/url/port.html:
- fast/url/query.html:
- fast/url/relative-unix.html:
- fast/url/relative-win.html:
- fast/url/relative.html:
- fast/url/safari-extension.html:
- fast/url/scheme.html:
- fast/url/script-tests: Removed.
- fast/url/script-tests/TEMPLATE.html: Removed.
- fast/url/script-tests/anchor.js: Removed.
- fast/url/script-tests/file-http-base.js: Removed.
- fast/url/script-tests/file.js: Removed.
- fast/url/script-tests/host.js: Removed.
- fast/url/script-tests/idna2003.js: Removed.
- fast/url/script-tests/idna2008.js: Removed.
- fast/url/script-tests/ipv4.js: Removed.
- fast/url/script-tests/ipv6.js: Removed.
- fast/url/script-tests/mailto.js: Removed.
- fast/url/script-tests/path-url.js: Removed.
- fast/url/script-tests/path.js: Removed.
- fast/url/script-tests/port.js: Removed.
- fast/url/script-tests/query.js: Removed.
- fast/url/script-tests/relative-unix.js: Removed.
- fast/url/script-tests/relative-win.js: Removed.
- fast/url/script-tests/relative.js: Removed.
- fast/url/script-tests/scheme.js: Removed.
- fast/url/script-tests/segments-from-data-url.js: Removed.
- fast/url/script-tests/segments.js: Removed.
- fast/url/script-tests/standard-url.js: Removed.
- fast/url/script-tests/trivial-segments.js: Removed.
- fast/url/script-tests/trivial.js: Removed.
- fast/url/segments-from-data-url.html:
- fast/url/segments.html:
- fast/url/standard-url.html:
- fast/url/trivial-segments.html:
- fast/url/trivial.html:
- 10:45 AM Changeset in webkit [149680] by
-
- 3 edits in trunk/Source/WebKit2
Each local storage database should know its origin
https://bugs.webkit.org/show_bug.cgi?id=115737
Reviewed by Andreas Kling.
Store the security origin in a member variable. It'll be used to communicate database state changes to the tracker.
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::create):
(WebKit::LocalStorageDatabase::LocalStorageDatabase):
- UIProcess/Storage/LocalStorageDatabase.h:
(LocalStorageDatabase):
- 10:42 AM Changeset in webkit [149679] by
-
- 8 edits in trunk
Add an 'isReadOnly' member to IDL parse tree structure
https://bugs.webkit.org/show_bug.cgi?id=115704
Reviewed by Kentaro Hara.
Source/WebCore:
Add an 'isReadOnly' member to IDL parse tree structure by merging
https://chromium.googlesource.com/chromium/blink/+/d6add80ecd08bcd88a6ae0e1698d929830b3bd8b
and update Objective-C, C++, and GObject binding generators to use isReadOnly.
- bindings/scripts/CodeGeneratorCPP.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorGObject.pm:
(GetWriteableProperties):
(GenerateProperty):
(GenerateFunctions):
- bindings/scripts/CodeGeneratorJS.pm:
(IsReadonly):
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/IDLParser.pm:
(parseAttributeRest):
(parseExceptionField):
(parseAttributeRestOld):
Tools:
Use newly added isReadOnly attribute.
- WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
(_generateHeaderFile):
(_generateImplementationFile):
(_staticValuesGetterImplementation):
- 10:10 AM Changeset in webkit [149678] by
-
- 3 edits in trunk/Source/WebKit2
Remove some unnecessary soft linking in NetworkProcess. (Take 2)
<rdar://problem/13821779> and https://bugs.webkit.org/show_bug.cgi?id=115683
Reviewed by Dean Jackson and owned by Andreas Kling.
As a followup to r149651, include the private headers conditionally.
Also, fix a bug introduced with r149651 (bool vs CFBooleanRef).
- NetworkProcess/mac/DiskCacheMonitor.mm:
- NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):
- 9:54 AM Changeset in webkit [149677] by
-
- 3 edits in trunk/Source/WebCore
Use OwnPtr instead of deleteAllValues in SMILTimeContainer
https://bugs.webkit.org/show_bug.cgi?id=115730
Reviewed by Geoffrey Garen.
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::~SMILTimeContainer): Removed call to deleteAllValues.
(WebCore::SMILTimeContainer::schedule): Use add instead of get/set to put a new
AnimationsVector into the map as needed.
(WebCore::SMILTimeContainer::setElapsed): Added get since values are OwnPtr now.
(WebCore::SMILTimeContainer::updateAnimations): Ditto.
- svg/animation/SMILTimeContainer.h: Changed value type of GroupedAnimationsMap
to OwnPtr instead of raw pointer.
- 9:53 AM Changeset in webkit [149676] by
-
- 3 edits in trunk/Source/JavaScriptCore
Take advantage of pre-decrement and post-increment opcodes for sh4 base JIT.
https://bugs.webkit.org/show_bug.cgi?id=115722
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-07
Reviewed by Oliver Hunt.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load8PostInc):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load16Unaligned):
(JSC::MacroAssemblerSH4::load16PostInc):
(JSC::MacroAssemblerSH4::storeDouble):
(JSC::MacroAssemblerSH4::load32WithUnalignedHalfWords):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::movwMemRegIn):
(SH4Assembler):
(JSC::SH4Assembler::movbMemRegIn):
(JSC::SH4Assembler::printInstr):
- 9:24 AM Changeset in webkit [149675] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Read-only fields should not get keyboard focus
https://bugs.webkit.org/show_bug.cgi?id=115725
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
PR332887
Prevent keyboard focus and FCC from displaying when the user taps on a
read-only field. Further, ensure form controls skip over these fields
with the next/previous buttons.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementIsReadOnly):
(DOMSupport):
- WebKitSupport/DOMSupport.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
(BlackBerry::WebKit::InputHandler::setInputModeEnabled):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::isActiveTextEdit):
(WebKit):
- WebKitSupport/InputHandler.h:
- 9:18 AM Changeset in webkit [149674] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Expand spellcheck logging
https://bugs.webkit.org/show_bug.cgi?id=115482
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
Fix some build errors when SpellingLog was turned on and expand on the debug
statements to be more verbose. Set up timers and print the duration of each
iteration as we traverse the text to create a range to send out for checking.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
- WebKitSupport/SpellingHandler.cpp:
(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
- 9:01 AM Changeset in webkit [149673] by
-
- 30 edits1 delete in trunk
Remove AlwaysInline.h from WTF
https://bugs.webkit.org/show_bug.cgi?id=115727
Reviewed by Brent Fulgham.
The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
to keep AlwaysInline.h around anymore.
Source/JavaScriptCore:
- jit/JSInterfaceJIT.h:
- parser/Lexer.h:
- runtime/JSCJSValue.h:
- runtime/SymbolTable.h:
Source/WebCore:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSDOMWindowCustom.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- platform/graphics/filters/FEConvolveMatrix.h:
- rendering/InlineIterator.h:
- rendering/InlineTextBox.cpp:
- rendering/RenderBlockLineLayout.cpp:
- rendering/RenderText.cpp:
Source/WTF:
- WTF.vcproj/WTF.vcproj:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/AlwaysInline.h: Removed.
- wtf/BloomFilter.h:
- wtf/FastMalloc.cpp:
- wtf/PassRefPtr.h:
- wtf/dtoa.cpp:
- wtf/gobject/GRefPtr.h:
Tools:
- DumpRenderTree/qt/DumpRenderTreeMain.cpp:
- WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
- 8:53 AM Changeset in webkit [149672] by
-
- 2 edits in trunk/Source/WebCore
[Curl] POST requests sometimes fail.
https://bugs.webkit.org/show_bug.cgi?id=111844
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-05-07
Reviewed by Brent Fulgham.
Curl adds the header 'Expect: 100-Continue' when sending a POST request.
When we receive the header 'HTTP/1.1 100 Continue', we should not call
ResourceHandleClient::didReceiveResponse(), as this will cancel the request,
because the MIME type is empty in this case, causing the POST request to fail.
This header is only sent as an info header, or provisional response.
In addition, this patch changes the classification of http code 304 (Not modified).
It is not reported as a redirect anymore, but as a response
(ResourceHandleClient::didReceiveResponse() is called.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::isHttpInfo): Added helper method to determine if http code is http info.
(WebCore::isHttpRedirect): Added helper method to determine if http code is http redirect.
(WebCore::headerCallback): Just return when receiving the header'HTTP/1.1 100 Continue'.
- 8:33 AM Changeset in webkit [149671] by
-
- 3 edits in trunk/Source/WebKit/qt
Crash when calling QWebFrame::evaluateJavaScript
https://bugs.webkit.org/show_bug.cgi?id=113434
Reviewed by Simon Hausmann.
Ensure we hold the JSLock when converting JSValue to JSValueRef.
- Api/qwebelement.cpp:
(setupScriptContext):
(QWebElement::evaluateJavaScript):
- WebCoreSupport/QWebFrameAdapter.cpp:
(QWebFrameAdapter::evaluateJavaScript):
- 8:13 AM Changeset in webkit [149670] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Add ewk APIs for setting and getting user agent
https://bugs.webkit.org/show_bug.cgi?id=114429
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-05-07
Reviewed by Andreas Kling.
Provide ewk_view_user_agent_get/set APIs which wraps WK APIs.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::setUserAgent):
- UIProcess/API/efl/EwkView.h:
(EwkView::userAgent):
(EwkView):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_user_agent_get):
(ewk_view_user_agent_set):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 8:07 AM Changeset in webkit [149669] by
-
- 2 edits in trunk/Source/WebCore
[X11][BlackBerry] Check if MOZ_X11 is defined instead of XP_UNIX npruntime_internal.h
https://bugs.webkit.org/show_bug.cgi?id=113687
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-07
Reviewed by Anders Carlsson.
It's assumed that all UNIX platforms use X11 for plugins, which is
not the case of BlackBerry.
- bridge/npruntime_internal.h: Use MOZ_X11 instead of XP_UNIX.
- 7:41 AM Changeset in webkit [149668] by
-
- 3 edits4 adds32 deletes in trunk/LayoutTests
[CSS Regions] Convert remaining fast/regions/webkit-flow* pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=115422
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-07
Reviewed by Andreas Kling.
Converted following tests from pixel tests to ref tests:
- webkit-flow-double-pagination-float-push
- webkit-flow-float-pushed-to-last-region
- webkit-flow-float-unable-to-push
- webkit-flow-floats-inside-regions-bounds
- fast/regions/webkit-flow-double-pagination-float-push-expected.html: Added.
- fast/regions/webkit-flow-float-pushed-to-last-region-expected.html: Added.
- fast/regions/webkit-flow-float-pushed-to-last-region.html:
- fast/regions/webkit-flow-float-unable-to-push-expected.html: Added.
- fast/regions/webkit-flow-float-unable-to-push.html:
- fast/regions/webkit-flow-floats-inside-regions-bounds-expected.html: Added.
- platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
- platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
- platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
- platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
- platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
- platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
- platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
- platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
- platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
- platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
- platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
- platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
- platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
- platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
- platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
- platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
- platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
- platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
- platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
- platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
- platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
- platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
- platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
- platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
- platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
- 4:01 AM Changeset in webkit [149667] by
-
- 2 edits in trunk/Tools
[Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
https://bugs.webkit.org/show_bug.cgi?id=114808
Reviewed by Jocelyn Turcotte.
QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
(https://codereview.qt-project.org/#change,54234)
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
- 12:42 AM Changeset in webkit [149666] by
-
- 3 edits in trunk/Source/WebKit/gtk
[GTK] Initialize WebKitWebPlugin path to prevent double-free
https://bugs.webkit.org/show_bug.cgi?id=115624
Patch by Tomas Popela <tpopela@redhat.com> on 2013-05-07
Reviewed by Carlos Garcia Campos.
Use GOwnPtr for WebKitWebPlugin path to prevent double-free
situations. Also use GOwnPtr for GError in webkit_web_plugin_get_path.
- webkit/webkitwebplugin.cpp:
(webkit_web_plugin_finalize):
(webkit_web_plugin_get_path):
- webkit/webkitwebpluginprivate.h:
- 12:23 AM Changeset in webkit [149665] by
-
- 41 edits in trunk/Source
HashTraits<RefPtr<P> >::PeekType should be raw pointer for better performance
https://bugs.webkit.org/show_bug.cgi?id=115646
Reviewed by Darin Adler.
Source/JavaScriptCore:
- bytecompiler/StaticPropertyAnalyzer.h:
(JSC::StaticPropertyAnalyzer::putById):
Updated accordingly to new HashMap<.., RefPtr>::get() semantics.
Source/WebCore:
No new tests, no new functionality.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::remove):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::objectFromAXID):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::getImage):
- css/InspectorCSSOMWrappers.cpp:
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingSVGDocuments):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::rootEditableElementForSelectionOnMouseDown):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elementForAlias):
- html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::findInsertionPointFor):
- loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::resourceForURL):
- loader/archive/ArchiveResourceCollection.cpp:
(WebCore::ArchiveResourceCollection::archiveResourceForURL):
- page/PageGroup.cpp:
(WebCore::PageGroup::transientLocalStorage):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::pauseTransitionAtTime):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateMaskLayer):
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::getBlobDataFromURL):
- plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::pluginForMIMEType):
(WebCore::PluginDatabase::MIMETypeForExtension):
- rendering/RenderCounter.cpp:
(WebCore::makeCounterNode):
(showCounterRendererTree):
- svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::getEffectById):
Updated accordingly to new HashMap<.., RefPtr>::get() semantics.
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::pluginInstance):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::cancelStreamLoad):
Updated accordingly to new HashMap<.., RefPtr>::get() semantics.
Source/WebKit2:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::hostForURL):
- Shared/ImmutableDictionary.h:
(WebKit::ImmutableDictionary::get):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):
(WebKit::StorageManager::findStorageArea):
- UIProcess/WebContext.h:
(WebKit::WebContext::supplement):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::webBackForwardItem):
(WebKit::WebProcessProxy::webFrame):
- UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::ewkDownloadJob):
- WebProcess/Network/WebResourceLoadScheduler.h:
(WebKit::WebResourceLoadScheduler::webResourceLoaderForIdentifier):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::streamFromID):
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::cancelStreamLoad):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::itemForID):
(WebKit::WebBackForwardListProxy::itemAtIndex):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::webUndoStep):
(WebKit::WebPage::didFinishCheckingText):
(WebKit::WebPage::didCancelCheckingText):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webPage):
(WebKit::WebProcess::webPageGroup):
Updated accordingly to new HashMap<.., RefPtr>::get() semantics.
Source/WTF:
HashTraits<RefPtr<P> >::PeekType should be raw pointer so that we
can obviate multiple RefPtr copying when invoking HashMap<.., RefPtr>::get()
method.
- wtf/HashTraits.h:
