Timeline

May 9, 2013:

8:29 PM Changeset in webkit [149861] by fpizlo@apple.com

• 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG shouldn't allocate in the GC heap
​https://bugs.webkit.org/show_bug.cgi?id=115598

Reviewed by Geoffrey Garen.

I believe that we've now fixed this, and this patch just adds the relevant assertion.

• runtime/JSCellInlines.h:

(JSC::JSCell::JSCell):

7:45 PM Changeset in webkit [149860] by fpizlo@apple.com

• 12 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: CodeBlock should be RefCounted
​https://bugs.webkit.org/show_bug.cgi?id=115594

Reviewed by Geoffrey Garen.

This makes it possible to have the currently-being-compiled CodeBlock not be
installed in Executable, while also allowing it to point to its intended
alternative(). So long as we were using ownership and not reference counting, it
would have been difficult to have both CodeBlock::m_alternative and
Executable::m_codeBlockForBlah point to the previous CodeBlock.

I also took the opportunity to clean up a bunch of code that appears to have
rotted.

• assembler/MacroAssemblerCodeRef.h:

(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::operator==):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::releaseAlternative):
(JSC::CodeBlock::setAlternative):
(CodeBlock):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):

• heap/DFGCodeBlocks.cpp:

(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):

• heap/DFGCodeBlocks.h:

(DFGCodeBlocks):

• heap/Heap.cpp:

(JSC::Heap::jettisonDFGCodeBlock):

• heap/Heap.h:
• jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

• runtime/Executable.cpp:

(JSC::jettisonCodeBlock):
(JSC::EvalExecutable::jitCompile):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

• runtime/Executable.h:

(EvalExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::codeBlockFor):

• runtime/ExecutionHarness.h:

(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

6:46 PM Changeset in webkit [149859] by commit-queue@webkit.org

• 6 edits in trunk/LayoutTests

Unskipped the webarchive tests for Mac that are not skipped for a reason other than
dumpDOMAsWebArchive not being implemented, which was fixed in r149692.
​https://bugs.webkit.org/show_bug.cgi?id=115819

Patch by Alex Christensen <​achristensen@apple.com> on 2013-05-09
Reviewed by Benjamin Poulain.

• platform/efl-wk2/TestExpectations:

Skip webarchive tests.

• platform/gtk-wk2/TestExpectations:

Skip webarchive tests.

• platform/qt-5.0-mac-wk2/TestExpectations:

Skip webarchive tests.

• platform/qt-5.0-wk2/TestExpectations:

Skip webarchive tests.

• platform/wk2/TestExpectations:

Removed universal skipping of webarchive tests, noted which tests are still skipped with bug numbers.

5:57 PM Changeset in webkit [149858] by Chris Fleizach

• 10 edits
  2 adds in trunk

AX: VoiceOver is no longer seeing items in poorly formed tables
​https://bugs.webkit.org/show_bug.cgi?id=115837

Reviewed by Darin Adler.

Source/WebCore:

In case the author didn't include the rows of a table as the
direct children, a table needs to dive down its descendant chain
until the rows are found.

I also took the opportunity to clean up a bit around what the different
meanings of table are in the accessibility classes.

Test: accessibility/poorly-formed-aria-table.html

• accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addRowDescendant):
(WebCore::AccessibilityARIAGrid::addChildren):

• accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

• accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::parentTable):
(WebCore):

• accessibility/AccessibilityARIAGridRow.h:

(AccessibilityARIAGridRow):

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isTable):

• accessibility/AccessibilityTable.h:

(AccessibilityTable):
(WebCore::AccessibilityTable::isTable):
(WebCore::toAccessibilityTable):

• accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::parentTable):

LayoutTests:

• accessibility/poorly-formed-aria-table-expected.txt: Added.
• accessibility/poorly-formed-aria-table.html: Added.

5:12 PM Changeset in webkit [149857] by zoltan@webkit.org

• 6 edits in trunk/LayoutTests

[Qt] REGRESSION (r148975) shape-inside-percentage.html and shape-inside-overflow-fixed-dimensions.html are failing after r148975
​https://bugs.webkit.org/show_bug.cgi?id=115053

Reviewed by Alexandru Chiculita.

I changed the tests to use Ahem font (overflow will be the same on every port) and modify the markup in order to be the similar
for the two tests. The change fixes both tests and make them passing on Qt as well. I removed the tests from the TestExpectations.

• fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html:
• fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html:
• fast/exclusions/shape-inside/shape-inside-percentage-expected.html:
• fast/exclusions/shape-inside/shape-inside-percentage.html:
• platform/qt/TestExpectations:

4:55 PM Changeset in webkit [149856] by commit-queue@webkit.org

• 3 edits
  4 adds in trunk

REGRESSION: Disabled multiline select element now responds to (certain) clicks
​https://bugs.webkit.org/show_bug.cgi?id=115710

Patch by Yael Aharon <​yael.aharon@intel.com> on 2013-05-09
Reviewed by Kent Tamura.

Source/WebCore:

After ​http://trac.webkit.org/changeset/140286, select elements can scroll whether they
are disabled or not. While they scroll, they also change the selected item.
This patch allows the select element to scroll, but does not change the selection
if the select element is disabled.

Test: fast/forms/select/listbox-disabled-scroll-no-onchange.html
Test: fast/forms/select/listbox-disabled-no-autoscroll.html

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::autoscroll):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::stopAutoscroll):

LayoutTests:

Test that a disabled element does not change selection while scrolling.

• fast/forms/select/listbox-disabled-scroll-no-onchange-expected.txt: Added.
• fast/forms/select/listbox-disabled-scroll-no-onchange.html: Added.
• fast/forms/select/listbox-disabled-no-autoscroll.html: Added.
• fast/forms/select/listbox-disabled-no-autoscroll-expected.html: Added.

4:47 PM Changeset in webkit [149855] by Patrick Gansterer

• 4 edits in trunk/Tools

[WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
​https://bugs.webkit.org/show_bug.cgi?id=92371

Reviewed by Brent Fulgham.

Use JavaScriptThreading.cpp where the same functionality is
implemented too. This reduces the dependency on the pthread
library. Also replace assert() with WebKit ASSERT().

• DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
• DumpRenderTree/win/DumpRenderTree.cpp:

(dumpHistoryItem):
(dumpBackForwardList):

• DumpRenderTree/win/DumpRenderTree.vcproj:

4:41 PM Changeset in webkit [149854] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Clean up SecurityOrigin::databaseIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=115882

Reviewed by Beth Dakin.

Remove m_encodedHost and just call encodeHost from databaseIdentifier().
Also, use a StringBuilder when constructing the database identifier to avoid allocating
temporary String objects over and over.

• page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore):
(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
(WebCore::SecurityOrigin::databaseIdentifier):

• page/SecurityOrigin.h:

(SecurityOrigin):

4:21 PM Changeset in webkit [149853] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Remove m_securityOrigin from XMLHttpRequest
​https://bugs.webkit.org/show_bug.cgi?id=115881

Reviewed by Alexey Proskuryakov.

The security origin passed to XMLHttpRequest::create was always null, so just get rid of the member variable completely.

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::securityOrigin):

• xml/XMLHttpRequest.h:

(XMLHttpRequest):

4:03 PM Changeset in webkit [149852] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Fix build.

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

3:50 PM Changeset in webkit [149851] by fpizlo@apple.com

• 16 edits
  4 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG should have its own notion of StructureChain, and it should be possible to validate it after compilation finishes
​https://bugs.webkit.org/show_bug.cgi?id=115841

Reviewed by Oliver Hunt.

This adds IntendedStructureChain, which is like StructureChain, except that it holds a bit
more information and can be validated independantly of its owning Structure and lexical
GlobalObject, since it remembers both of those things. It's also malloc'd and RefCounted
rather than GC'd, so it can be allocated in a concurrent compilation thread.

Gave this class a bunch of methods to allow the following idiom:

• Snapshot a structure chain concurrently. This structure chain may end up being wrong in case of races, but in that case we will find out when we try to validate it.

• Perform validation on the structure chain itself, without recomputing the chain. Previously, many chain validation methods (prototypeChainMayInterceptStoreTo() for example) recomputed the chain, and hence, were inherently racy: you could build one chain and then validate against a different chain, and hence not realize that the chain you did build was actually broken for your purposes, because the chain you checked was a different one.

• Validate that the chain is still the right one at any time, allowing the cancellation of compilation if there was a race.

Also added DFG::DesiredStructureChains, which tracks those intended structure chains that
the compiler had already chosen to use. If any of those are invalid at link time, throw
out the compilation.

• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

• bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::chain):
(GetByIdStatus):

• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):

• bytecode/PutByIdStatus.h:

(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::structureChain):
(PutByIdStatus):

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGDesiredStructureChains.cpp: Added.

(DFG):
(JSC::DFG::DesiredStructureChains::DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::~DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::areStillValid):

• dfg/DFGDesiredStructureChains.h: Added.

(DFG):
(DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::addLazily):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::isStillValid):
(DFG):

• dfg/DFGGraph.h:

(Graph):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):

• ftl/FTLLink.cpp:

(JSC::FTL::link):

• runtime/IntendedStructureChain.cpp: Added.

(JSC):
(JSC::IntendedStructureChain::IntendedStructureChain):
(JSC::IntendedStructureChain::~IntendedStructureChain):
(JSC::IntendedStructureChain::isStillValid):
(JSC::IntendedStructureChain::matches):
(JSC::IntendedStructureChain::chain):
(JSC::IntendedStructureChain::mayInterceptStoreTo):
(JSC::IntendedStructureChain::isNormalized):
(JSC::IntendedStructureChain::terminalPrototype):

• runtime/IntendedStructureChain.h: Added.

(JSC):
(IntendedStructureChain):
(JSC::IntendedStructureChain::head):
(JSC::IntendedStructureChain::size):
(JSC::IntendedStructureChain::at):
(JSC::IntendedStructureChain::operator[]):
(JSC::IntendedStructureChain::last):

• runtime/Structure.cpp:

(JSC::Structure::prototypeChainMayInterceptStoreTo):

• runtime/Structure.h:

(Structure):

• runtime/StructureInlines.h:

(JSC::Structure::storedPrototypeObject):
(JSC):
(JSC::Structure::storedPrototypeStructure):

3:40 PM Changeset in webkit [149850] by Christophe Dumez

• 3 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r149836.

It broke at least EFL and GTK builds. Move new static members initialization
outside the class. Those need to have a definition outside the class because
their address is used (e.g. CodeCacheMap::nonGlobalWorkingSetMaxEntries).

• runtime/CodeCache.cpp:

(JSC):

• runtime/CodeCache.h:

(CodeCacheMap):

3:39 PM Changeset in webkit [149849] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Enable UI process storage
​https://bugs.webkit.org/show_bug.cgi?id=115879
<rdar://problem/12239765>

Reviewed by Beth Dakin.

• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

Flip the switch.

3:37 PM Changeset in webkit [149848] by andersca@apple.com

• 121 edits in trunk/Source/WebKit2

Remove extra spaces between right angle brackets in template declarations
​https://bugs.webkit.org/show_bug.cgi?id=115877

Reviewed by Beth Dakin.

C++11 doesn't require spaces between right angle brackets so remove all of them.

• NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerBlobURL):
(WebKit::NetworkBlobRegistry::sandboxExtensions):

• NetworkProcess/FileAPI/NetworkBlobRegistry.h:

(NetworkBlobRegistry):

• NetworkProcess/HostRecord.h:

(HostRecord):

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::registerBlobURL):

• NetworkProcess/NetworkConnectionToWebProcess.h:

(NetworkConnectionToWebProcess):

• NetworkProcess/NetworkProcess.h:

(NetworkProcess):

• NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::servePendingRequests):
(WebKit::NetworkResourceLoadScheduler::removeScheduledLoaders):

• NetworkProcess/NetworkResourceLoadScheduler.h:
• NetworkProcess/SchedulableLoader.cpp:

(WebKit::SchedulableLoader::SchedulableLoader):

• NetworkProcess/SchedulableLoader.h:

(SchedulableLoader):

• Platform/CoreIPC/ArgumentCoders.h:
• Platform/CoreIPC/Connection.cpp:

(Connection::SyncMessageState):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):

• Platform/CoreIPC/Connection.h:

(Connection):

• Platform/WorkQueue.h:

(WorkQueue):

• PluginProcess/PluginProcess.h:

(PluginProcess):

• Scripts/webkit2/messages_unittest.py:

(CoreIPC):

• Shared/BlockingResponseMap.h:

(BlockingResponseMap):

• Shared/ChildProcessProxy.h:

(ChildProcessProxy):

• Shared/ImmutableArray.cpp:

(WebKit::ImmutableArray::ImmutableArray):

• Shared/ImmutableArray.h:

(WebKit::ImmutableArray::adopt):
(ImmutableArray):

• Shared/ImmutableDictionary.cpp:

(WebKit::ImmutableDictionary::keys):

• Shared/ImmutableDictionary.h:

(ImmutableDictionary):

• Shared/Network/CustomProtocols/CustomProtocolManager.h:

(CustomProtocolManager):

• Shared/SecurityOriginData.cpp:

(WebKit::performAPICallbackWithSecurityOriginDataVector):

• Shared/SessionState.cpp:
• Shared/StatisticsData.h:

(StatisticsData):

• Shared/UserMessageCoders.h:

(WebKit::UserMessageDecoder::baseDecode):

• Shared/WebArchive.cpp:

(WebKit::WebArchive::WebArchive):
(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):

• Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):

• Shared/WebOpenPanelParameters.cpp:

(WebKit::WebOpenPanelParameters::acceptMIMETypes):
(WebKit::WebOpenPanelParameters::selectedFileNames):

• Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::encode):

• SharedWorkerProcess/SharedWorkerProcess.h:

(SharedWorkerProcess):

• UIProcess/API/mac/WKPrintingView.h:

(WebFrameProxy):

• UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView _drawPreview:]):

• UIProcess/API/mac/WKView.mm:

(WebKit):

• UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::processDidClose):

• UIProcess/Downloads/DownloadProxyMap.h:

(DownloadProxyMap):

• UIProcess/GeolocationPermissionRequestManagerProxy.h:

(GeolocationPermissionRequestManagerProxy):

• UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:

(DynamicLinkerEnvironmentExtractor):

• UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:

(CustomProtocolManagerProxy):

• UIProcess/Network/NetworkProcessProxy.h:

(NetworkProcessProxy):

• UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h:

(NotificationPermissionRequestManagerProxy):

• UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

• UIProcess/Plugins/PluginProcessManager.h:

(PluginProcessManager):

• UIProcess/Plugins/PluginProcessProxy.h:

(PluginProcessProxy):

• UIProcess/Plugins/WebPluginSiteDataManager.cpp:

(WebKit::WebPluginSiteDataManager::didGetSitesWithData):

• UIProcess/Plugins/WebPluginSiteDataManager.h:

(WebPluginSiteDataManager):

• UIProcess/SharedWorkers/SharedWorkerProcessManager.h:

(SharedWorkerProcessManager):

• UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:

(SharedWorkerProcessProxy):

• UIProcess/StatisticsRequest.cpp:

(WebKit::StatisticsRequest::completedRequest):

• UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::dispatchEvents):
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
(WebKit::StorageManager::createLocalStorageMap):
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::destroyStorageMap):
(WebKit::StorageManager::invalidateConnectionInternal):
(WebKit::StorageManager::findStorageArea):
(WebKit::StorageManager::getOrCreateLocalStorageNamespace):

• UIProcess/Storage/StorageManager.h:

(StorageManager):

• UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

• UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):

• UIProcess/WebBackForwardList.h:

(WebKit):

• UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::enableProcessTermination):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):

• UIProcess/WebContext.h:

(WebContext):

• UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies):

• UIProcess/WebCookieManagerProxy.h:

(WebCookieManagerProxy):

• UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):

• UIProcess/WebDatabaseManagerProxy.h:

(WebDatabaseManagerProxy):

• UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):

• UIProcess/WebFormClient.h:

(WebFormClient):

• UIProcess/WebKeyValueStorageManagerProxy.h:

(WebKeyValueStorageManagerProxy):

• UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didChangeBackForwardList):

• UIProcess/WebLoaderClient.h:

(WebLoaderClient):

• UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache):

• UIProcess/WebMediaCacheManagerProxy.h:

(WebMediaCacheManagerProxy):

• UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::showContextMenu):

• UIProcess/WebPageProxy.cpp:

(ExceededDatabaseQuotaRecords):
(WebKit::WebPageProxy::relatedPages):
(WebKit::WebPageProxy::didChangeBackForwardList):
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::processNextQueuedWheelEvent):
(WebKit::WebPageProxy::findStringMatches):
(WebKit::WebPageProxy::willSubmitForm):
(WebKit::WebPageProxy::pluginInformationDictionary):
(WebKit::WebPageProxy::didFindStringMatches):
(WebKit::WebPageProxy::didReceiveEvent):

• UIProcess/WebPageProxy.h:

(WebPageProxy):

• UIProcess/WebPageProxy.messages.in:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::didBecomeUnresponsive):
(WebKit::WebProcessProxy::interactionOccurredWhileUnresponsive):
(WebKit::WebProcessProxy::didBecomeResponsive):
(WebKit::WebProcessProxy::disconnectFramesFromPage):
(WebKit::WebProcessProxy::frameCountInPage):

• UIProcess/WebProcessProxy.h:

(WebProcessProxy):

• UIProcess/WebResourceCacheManagerProxy.h:

(WebResourceCacheManagerProxy):

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::populateNSMenu):
(WebKit::nsMenuItemVector):

• WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:

(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):

• WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

• WebProcess/IconDatabase/WebIconDatabaseProxy.h:

(WebIconDatabaseProxy):

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::originsWithApplicationCache):

• WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:

(WebKit::InjectedBundleBackForwardListItem::children):

• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):

• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:

(InjectedBundlePageEditorClient):

• WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::willSendSubmitEvent):
(WebKit::InjectedBundlePageFormClient::willSubmitForm):

• WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:

(InjectedBundlePageFormClient):

• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):

• WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::internallyFailedLoadTimerFired):
(WebKit::WebResourceLoadScheduler::networkProcessCrashed):

• WebProcess/Network/WebResourceLoadScheduler.h:

(WebResourceLoadScheduler):

• WebProcess/Notifications/NotificationPermissionRequestManager.h:

(NotificationPermissionRequestManager):

• WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

• WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::invalidate):

• WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:

(NPRuntimeObjectMap):

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::stopAllStreams):

• WebProcess/Plugins/Netscape/NetscapePlugin.h:

(NetscapePlugin):

• WebProcess/Plugins/Netscape/NetscapePluginStream.h:

(NetscapePluginStream):

• WebProcess/Plugins/PDF/SimplePDFPlugin.mm:

(getAllScriptsInPDFDocument):
(WebKit::SimplePDFPlugin::runScriptsInPDFDocument):

• WebProcess/Plugins/PluginProcessConnectionManager.h:

(PluginProcessConnectionManager):

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::cancelAllStreams):

• WebProcess/Plugins/PluginView.h:

(PluginView):

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::dispatchSessionStorageEvent):
(WebKit::StorageAreaMap::dispatchLocalStorageEvent):

• WebProcess/Storage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::storageArea):

• WebProcess/Storage/StorageNamespaceImpl.h:

(StorageNamespaceImpl):

• WebProcess/Storage/WebKeyValueStorageManager.cpp:

(WebKit::keyValueStorageOriginIdentifiers):

• WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::getDatabaseOrigins):

• WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::getClientPasteboardDataForRange):

• WebProcess/WebCoreSupport/WebEditorClient.h:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

• WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::WebEditorClient::documentFragmentFromAttributedString):

• WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findStringMatches):

• WebProcess/WebPage/FindController.h:

(FindController):

• WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit):

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::childFrames):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::trackedRepaintRects):

• WebProcess/WebPage/WebPage.h:

(WebKit):
(WebPage):

• WebProcess/WebPage/mac/LayerTreeHostMac.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
(WebKit::WebProcess::focusedWebPage):
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::didClose):
(WebKit::WebProcess::webPageGroup):
(WebKit::addCaseFoldedCharacters):
(WebKit::getWebCoreMemoryCacheStatistics):
(WebKit::WebProcess::setTextCheckerState):

• WebProcess/WebProcess.h:

(WebProcess):

3:26 PM Changeset in webkit [149847] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Implement WebPlatformStrategies::transientLocalStorageNamespace
​https://bugs.webkit.org/show_bug.cgi?id=115876
<rdar://problem/13852871>

Reviewed by Beth Dakin.

• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::transientLocalStorageNamespace):
Return a session storage namespace for a random page when UI process storage is enabled,
otherwise call the base class implementation.

3:09 PM Changeset in webkit [149846] by roger_fong@apple.com

• 1 edit
  2 adds
  1 delete in trunk/LayoutTests

Unreviewed mac gardening.

• platform/mac/inspector/command-line-api-expected.txt: Removed.
• platform/mac/inspector/console: Added.
• platform/mac/inspector/console/command-line-api-expected.txt: Added.

2:47 PM Changeset in webkit [149845] by Christophe Dumez

• 17 edits in trunk

[NoInterfaceObject] extended attribute should be removed for several interfaces
​https://bugs.webkit.org/show_bug.cgi?id=115852

Reviewed by Benjamin Poulain.

Source/WebCore:

Remove [NoInterfaceObject] extended attribute from the following Web IDL
interfaces: SecurityPolicy, History, Location, Navigator, Performance,
PerformanceEntry, PerformanceMark, PerformanceMeasure, PerformanceNavigation,
PerformanceResourceTiming, PerformanceTiming and Screen.

These interfaces should not have the [NoInterfaceObject] extended attribute
according to their respective specifications:

• ​http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-history-interface
• ​http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-location-interface
• ​https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#securitypolicy
• ​http://www.w3.org/html/wg/drafts/html/master/webappapis.html#the-navigator-object
• ​http://www.w3.org/TR/navigation-timing/#performance
• ​https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html#sec-PerformanceEntry-interface
• ​http://www.w3.org/TR/navigation-timing/#performancenavigation
• ​http://www.w3.org/TR/navigation-timing/#performancetiming
• ​http://www.w3.org/TR/user-timing/#performancemark
• ​http://www.w3.org/TR/user-timing/#performancemeasure
• ​http://www.w3c-test.org/webperf/specs/ResourceTiming/#performanceresourcetiming
• ​http://dev.w3.org/csswg/cssom-view/#the-screen-interface

The new behavior is consistent with the specifications, Firefox and soon Blink.

No new tests, already covered by existing tests.

• page/DOMSecurityPolicy.idl:
• page/History.idl:
• page/Location.idl:
• page/Navigator.idl:
• page/Performance.idl:
• page/PerformanceEntry.idl:
• page/PerformanceMark.idl:
• page/PerformanceMeasure.idl:
• page/PerformanceNavigation.idl:
• page/PerformanceResourceTiming.idl:
• page/PerformanceTiming.idl:
• page/Screen.idl:

LayoutTests:

Rebaseline several layout tests whose output has changed now that a few more
global constructors are exposed.

• fast/dom/dom-constructors-expected.txt:
• fast/js/global-constructors-attributes-expected.txt:
• platform/efl/fast/js/global-constructors-attributes-expected.txt:

2:45 PM Changeset in webkit [149844] by robert@webkit.org

• 4 edits
  1 move
  3 deletes in trunk

REGRESSION (Safari 3-Safari 4): Replaced element with percent height in table has incorrect height
​https://bugs.webkit.org/show_bug.cgi?id=26394

Reviewed by David Hyatt.

Source/WebCore:

Text controls or any object that has scrollable content should not flex inside a table cell.
This makes our behaviour the same as IE, FF and Opera (Presto).

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

LayoutTests:

• fast/replaced/table-percent-height-text-controls-expected.txt: Renamed from LayoutTests/platform/mac/fast/replaced/table-percent-height-text-controls-expected.txt.
• fast/replaced/table-percent-height-text-controls.html:
• platform/gtk/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.
• platform/qt/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.
• platform/win/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.

2:35 PM Changeset in webkit [149843] by Patrick Gansterer

• 2 edits
  1 move in trunk/Tools

[DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
​https://bugs.webkit.org/show_bug.cgi?id=92505

Reviewed by Brent Fulgham.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
• DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.

(javaScriptThreadsMutex):
(javaScriptThreads):
(runJavaScriptThread):
(startJavaScriptThreads):
(stopJavaScriptThreads):

• DumpRenderTree/pthreads: Removed.
• DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.

2:34 PM Changeset in webkit [149842] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Build fix.

• WebCore.exp.in:

2:18 PM Changeset in webkit [149841] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Update srcipt paths in editing/shadow/rightclick-on-meter-in-shadow-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=96223

Patch by Xiaobo Wang <​xbwang@torchmobile.com.cn> on 2013-05-09
Reviewed by Rob Buis.

The original paths don't exist at all.

• editing/shadow/rightclick-on-meter-in-shadow-crash.html:

2:03 PM Changeset in webkit [149840] by andersca@apple.com

• 14 edits in trunk/Source/WebCore

Add a StorageStrategy hook for creating transient local storage namespaces
​https://bugs.webkit.org/show_bug.cgi?id=115870

Reviewed by Geoffrey Garen.

• WebCore.exp.in:

Export symbol needed by WebKit2.

• dom/Document.cpp:

(WebCore::Document::topOrigin):

• dom/Document.h:
• dom/ScriptExecutionContext.h:
• workers/WorkerContext.h:

Remove const qualifier from topOrigin() to avoid ugly const_casts when assigning into a RefPtr<SecurityOrigin> variable.

• page/PageGroup.cpp:

(WebCore::PageGroup::transientLocalStorage):
Do a single hash lookup instead of three and use the SecurityOrigin itself as the hash key instead of a string representation of it.

• page/PageGroup.h:

Update HashMap declaration.

• storage/StorageNamespace.cpp:

(WebCore::StorageNamespace::transientLocalStorageNamespace):
Add new implementation that will optionally call out to the storage strategy.

• storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::transientLocalStorageNamespace):
Move the default implementation here from PageGroup.

• storage/StorageStrategy.cpp:

(WebCore::StorageStrategy::transientLocalStorageNamespace):
Call the default implementation.

1:54 PM Changeset in webkit [149839] by enrica@apple.com

• 4 edits in trunk/Source/WebCore

A change in system environment should force all CSS properties to be recomputed.
​https://bugs.webkit.org/show_bug.cgi?id=115872
<rdar://problem/13781171>

Reviewed by Antti Koivisto.

When a change in the global environment occurs, for example system colors,
we need to make sure all the CSS properties are recomputed and not fetched
from the cache. For this reason we invalidate the properties cache.
I've also renamed the function to give it a more meaningful name.

• page/Page.cpp:

(WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment):

• page/Page.h:
• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::platformColorsDidChange):

1:35 PM Changeset in webkit [149838] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Reoptimize free-standing :focus/link/visited/-webkit-any-link selectors.
<​http://webkit.org/b/115590>

Reviewed by Darin Adler.

Common pseudo selectors should go into their respective rule buckets instead of ending up in the universal one.

• css/RuleSet.cpp:

(WebCore::RuleSet::findBestRuleSetAndAdd):

Check tag selectors with * local name (usually created for namespace) for a suitable narrower bucket too.

1:31 PM Changeset in webkit [149837] by roger_fong@apple.com

• 1 edit
  3 adds in trunk/LayoutTests

Unreviewed mac port gardening.

• platform/mac-lion/fast/js: Added.
• platform/mac-lion/fast/js/global-constructors-attributes-expected.txt: Added.
• platform/mac/inspector/command-line-api-expected.txt: Added.

1:03 PM Changeset in webkit [149836] by oliver@apple.com

• 17 edits
  3 adds in trunk

Code cache stores bogus var references for functions in eval code
​https://bugs.webkit.org/show_bug.cgi?id=115747

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

Non-global eval now uses a per-CodeBlock cache, and only use it
when we're at the top of a function's scope. This means that we
will no longer cache the parsing of a single string across
multiple functions, and we won't cache when we're nested inside
constructs like |with| and |catch| where previously we would, which
is good because caching in those cases is unsound.

• bytecode/EvalCodeCache.h:

(JSC):
(JSC::EvalCodeCache::getSlow):
(JSC::EvalCodeCache::get):

• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::codeCacheForEval):
(UnlinkedCodeBlock):
(RareData):

• debugger/Debugger.cpp:

(JSC::evaluateInGlobalCallFrame):

• debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluate):

• interpreter/Interpreter.cpp:

(JSC::eval):

• runtime/CodeCache.cpp:

(JSC::CodeCache::CodeCache):
(JSC::CodeCache::generateBytecode):
(JSC):
(JSC::CodeCache::getCodeBlock):

• runtime/CodeCache.h:

(JSC::CodeCacheMap::CodeCacheMap):
(CodeCacheMap):
(JSC::CodeCacheMap::canPruneQuickly):
(JSC::CodeCacheMap::prune):
(JSC::CodeCache::create):
(CodeCache):

• runtime/Executable.cpp:

(JSC::EvalExecutable::EvalExecutable):
(JSC::EvalExecutable::compileInternal):

• runtime/Executable.h:

(JSC::EvalExecutable::create):
(EvalExecutable):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createEvalCodeBlock):

• runtime/JSGlobalObject.h:

(JSGlobalObject):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

(VM):

LayoutTests:

Many tests

• fast/js/eval-cache-scoped-lookup-expected.txt: Added.
• fast/js/eval-cache-scoped-lookup.html: Added.
• fast/js/script-tests/eval-cache-scoped-lookup.js: Added.

(first):
(a.string_appeared_here.second):
(third):
(fifth):
(sixth):
(seventh):
(eighth):
(nineth):
(tenth):
(eleventh):

12:41 PM Changeset in webkit [149835] by mhahnenberg@apple.com

• 1 edit in trunk/LayoutTests/ChangeLog

Fixing botched rebase of ChangeLog

12:38 PM Changeset in webkit [149834] by mhahnenberg@apple.com

• 4 edits
  3 adds in trunk

DFGArrayMode::fromObserved is too liberal when it sees different Array and NonArray shapes
​https://bugs.webkit.org/show_bug.cgi?id=115805

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

It checks the observed ArrayModes to see if we have seen any ArrayWith* first. If so, it assumes it's
an Array::Array, even if we've also observed any NonArrayWith* in the ArrayProfile. This leads to the
code generated by jumpSlowForUnwantedArrayMode to check the indexing type against (shape | IsArray)
instead of just shape, which can cause us to exit a lot in the case that we saw a NonArray.

To fix this we need to add a case that checks for both ArrayWith* and NonArrayWith* cases first, which
should then use Array::PossiblyArray, then do the checks we were already doing.

• bytecode/ArrayProfile.h:

(JSC::hasSeenArray):
(JSC::hasSeenNonArray):

• dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::fromObserved):

LayoutTests:

Added regression test for array access over polymorphic array vs. non-array indexing types.
With the fix, we get 3.666x faster on this microbenchmark.

Reviewed by Geoffrey Garen.

• fast/js/regress/array-nonarray-polymorphic-access-expected.txt: Added.
• fast/js/regress/array-nonarray-polymorphic-access.html: Added.
• fast/js/regress/script-tests/array-nonarray-polymorphic-access.js: Added.

(f):
(run):

12:24 PM Changeset in webkit [149833] by Darin Adler

• 7 edits in trunk/Source

RenderQuote has giant function for language to quotes map
​https://bugs.webkit.org/show_bug.cgi?id=115807

Reviewed by Anders Carlsson.

Source/WebCore:

• rendering/RenderQuote.cpp:

(WebCore::RenderQuote::RenderQuote): Updated for m_isAttached name change.
(WebCore::RenderQuote::~RenderQuote): Updated for name change, and also split
assertion with && in it into two separate assertions.
(WebCore::checkNumberOfDistinctQuoteCharacters): Added. Helper function that is used
to check that the number of distinct quote characters is small enough to fit into
our fixed size array below.
(WebCore::quotesForLanguage): Replaces the old quotesDataLanguageMap function.
Returns a pointer to a struct that contains the four quote characters. This new
function doesn't have the massive amount of code that the old one did. We use the
standard library bsearch function to do a binary search.
(WebCore::stringForQuoteCharacter): Added. This returns a string for a given quote
character; one string for any given character.
(WebCore::quotationMarkString): Added. Returns the string for the quotation mark.
(WebCore::apostropheStringImpl): Added. Returns the string for the apostrophe.
(WebCore::RenderQuote::originalText): Rewrote this to include all the logic that
used to be in the quotesData function.
(WebCore::RenderQuote::attachQuote): Tweak assertions as above. Removed unneeded
special case for the first quote in a RenderView; sharing the code is better and
there is no significant performance difference. Also use m_isAttached directly
when looking at predecessores so there is no need for an isAttached function.
(WebCore::RenderQuote::detachQuote): Updated assertions and for name change.
(WebCore::RenderQuote::updateDepth): Ditto.

• rendering/RenderQuote.h: Removed unneeded includes. Marked the class FINAL since

we call the originalText function in the class and we don't want to do a virtual
function dispatch for that. Removed uneeded const from an argument. Removed a
stray semicolon. Removed the quotesData and isAttached functions, since they are no
longer needed. Renamed m_attached to m_isAttached.

• rendering/style/QuotesData.cpp: Removed the overload of QuotesData::create that

takes four quote strings. This was only used to build up the quotes table.

• rendering/style/QuotesData.h: Ditto.

Source/WTF:

• wtf/unicode/CharacterNames.h: Added a couple of character names.

12:03 PM Changeset in webkit [149832] by andersca@apple.com

• 15 edits in trunk/Source/WebKit2

Use explicit qualifiers for names in the std:: namespace
​https://bugs.webkit.org/show_bug.cgi?id=115868

Reviewed by Andreas Kling.

• Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::encode):

• UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerClearAllSiteData):

• UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::findPluginForExtension):

• UIProcess/WebFrameProxy.cpp:
• UIProcess/WebProcessProxy.cpp:
• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parsePostBuffer):

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::loadURL):

• WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::deliverDataToPlugin):

• WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
• WebProcess/WebPage/DrawingAreaImpl.cpp:
• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::countStringMatches):
(WebKit::FindController::updateFindUIAfterPageScroll):

• WebProcess/WebPage/WebPage.cpp:
• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::drawPDFPage):

• WebProcess/mac/WebProcessMac.mm:

12:00 PM Changeset in webkit [149831] by mifenton@rim.com

• 8 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update iInRegionScroller, WebKitTextCodec and WebPageCompositor
to match check-webkit-style updates.

• Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):

• Api/InRegionScroller_p.h:
• Api/WebKitTextCodec.cpp:

(BlackBerry::WebKit::transcode):

• Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::render):

• Api/WebPageCompositor.h:
• Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

• Api/WebSettings_p.h:

11:49 AM Changeset in webkit [149830] by commit-queue@webkit.org

• 14 edits
  3 adds in trunk

shouldUsePluginDocument() needs to be respected when a document is created
​https://bugs.webkit.org/show_bug.cgi?id=110308

Patch by Max Feil <​mfeil@rim.com> on 2013-05-09
Reviewed by Rob Buis.

Source/WebCore:

In DOMImplementation::createDocument() we should create
a PluginDocument for mime types that return "true" for
shouldAlwaysUsePluginDocument(), even if there is no pluginData
for them. This lets a client choose plugins for which the "missing
plugin" text or icon should appear more consistently. Otherwise
plugins referenced by iFrames will be treated as an HTMLDocument,
possibly resulting in binary files rendered as gibberish text.

Layout test platform/blackberry/plugins/swf-as-src-of-iframe.html

• dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

Source/WebKit/blackberry:

This patch implements shouldAlwaysUsePluginDocument() in the
BlackBerry frame loader client. It is called in several places
within WebCore to determine whether a PluginDocument should
be created.

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::shouldAlwaysUsePluginDocument):
(WebCore):
(WebCore::FrameLoaderClientBlackBerry::createPlugin):

• WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

Source/WebKit/win:

Renaming shouldUsePluginDocument() to shouldAlwaysUsePluginDocument()
for clarity.

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::shouldAlwaysUsePluginDocument):

• WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

Source/WebKit2:

Renaming shouldUsePluginDocument() to shouldAlwaysUsePluginDocument()
for clarity.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldAlwaysUsePluginDocument):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

11:47 AM Changeset in webkit [149829] by timothy@apple.com

• 2 edits in trunk/Source/WebCore

Fix an exception when hovering native functions while paused in the debugger.

​https://webkit.org/b/115866
rdar://problem/13681982

Reviewed by Darin Adler and Joseph Pecoraro.

• inspector/InjectedScriptSource.js:

(InjectedScript.prototype.getFunctionDetails): Return an error if the details
is null or undefined.

11:42 AM Changeset in webkit [149828] by Darin Adler

• 2 edits in trunk/Source/WebCore

[Mac] CFError leak under Objective-C garbage collection
​https://bugs.webkit.org/show_bug.cgi?id=115862

Reviewed by Benjamin Poulain.

• platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::nsError): Use adoptCF instead of adoptNS since
the CFError needs a CFRelease, not an -[NSObject release].

11:38 AM Changeset in webkit [149827] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

BlackBerry: fix call to PluginLayerWebKitThread::setHolePunchRect()
​https://bugs.webkit.org/show_bug.cgi?id=114953

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.

data->layer needs a cast in order to call setHolePunchRect().

• plugins/blackberry/NPCallbacksBlackBerry.cpp:

(WebCore::npSetHolePunchHandler):

11:32 AM Changeset in webkit [149826] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update SelectionHandler to match check-webkit-style updates.

• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::shouldExtendSelectionInDirection):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::adjustCaretRects):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
(BlackBerry::WebKit::regionRectListContainsPoint):

• WebKitSupport/SelectionHandler.h:

(SelectionHandler):

11:24 AM Changeset in webkit [149825] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[BlackBerry] Set up logging buffer on start of jsc executable
​https://bugs.webkit.org/show_bug.cgi?id=114688

Patch by Joe Mason <​jmason@blackberry.com> on 2013-05-09
Reviewed by Rob Buis.

Internal PR: 322715
Internally Reviewed By: Jeff Rogers

• jsc.cpp:

(main): call BB::Platform::setupApplicationLogging

11:13 AM Changeset in webkit [149824] by mifenton@rim.com

• 11 edits in trunk/Source/WebCore

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebCore/platform/graphics BlackBerry sources
to match check-webkit-style updates.

Internally reviewed by Jakob Petsovits.

• platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
• platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::readPixelsIMG):
(WebCore::GraphicsContext3D::paintToCanvas):

• platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::updateLayerPosition):

• platform/graphics/blackberry/IntRectBlackBerry.cpp:

(WebCore::IntRect::IntRect):

• platform/graphics/blackberry/LayerCompositingThread.h:

(WTF::::deref):

• platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRenderer::initializeSharedGLObjects):
(WebCore::LayerFilterRenderer::actionsForOperations):
(WebCore::LayerFilterRenderer::applyActions):

• platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawColor):
(WebCore::LayerRenderer::compositeLayersRecursive):

• platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::setFrame):

• platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):

• platform/image-decoders/blackberry/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::JPEGImageDecoder):

11:02 AM Changeset in webkit [149823] by mifenton@rim.com

• 5 edits in trunk/Source/WebCore

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebCore/platform/network/blackberry
to match check-webkit-style updates.

• platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::handleSetCookieHeader):
(WebCore::NetworkJob::sendResponseIfNeeded):
(WebCore::NetworkJob::shouldSendClientData):

• platform/network/blackberry/NetworkJob.h:

(NetworkJob):

• platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

• platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore::isRSSContent):
(WebCore::transcode):

10:59 AM Changeset in webkit [149822] by mifenton@rim.com

• 11 edits in trunk/Source/WebCore

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebCore/platform/blackberry to match check-webkit-style updates.

No functional changes.

• platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
• platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getRawCookies):

• platform/blackberry/CookieMap.h:

(WebCore::CookieMap::count):

• platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::parseOneCookie):

• platform/blackberry/LoggingBlackBerry.cpp:
• platform/blackberry/PageClientBlackBerry.h:

(Platform):
(Graphics):
(WebCore):

• platform/blackberry/ParsedCookie.cpp:

(WebCore::ParsedCookie::appendWebCoreCookie):

• platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintSearchFieldCancelButton):
(WebCore::RenderThemeBlackBerry::paintButton):
(WebCore::RenderThemeBlackBerry::paintSliderThumb):

• platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:

(WebCore::signedPublicKeyAndChallengeString):

• platform/blackberry/ScrollAnimatorBlackBerry.h:

10:40 AM Changeset in webkit [149821] by msaboff@apple.com

• 4 edits
  4 adds in trunk/Source

JSC: There should be a disassembler for ARM Thumb 2
​https://bugs.webkit.org/show_bug.cgi?id=115827

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Added a new disassembler for ARMv7 Thumb2 instructions for use by the JSC debugging
and profiling code. The opcode coverage is currently not complete. It covers all
of the integer instructions JSC currently emits, but only a limited number of
floating point opcodes. Currently that is just the 64 bit vmov and vmsr instructions.

The disassembler is structured as a base opcode class ARMv7DOpcode with sub-classes
for each instruction group. There is a public format method that does the bulk of
the disassembly work. There are two broad sub-classes, ARMv7D16BitOpcode and
ARMv7D32BitOpcode, for the 16 bit and 32 bit opcodes. There are sub-classes under
those two classes for individual and related groups of opcodes. Instructions are
"dispatched" to the right subclass via two arrays of linked lists in the inner classes
OpcodeGroup. There is one such inner class for each ARMv7D16BitOpcode and ARMv7D32BitOpcode.
Each OpcodeGroup has a mask and a pattern that it applies to the instruction to determine
that it matches a particular group. OpcodeGroup uses a static method to reinterpret_cast
the Opcode object to the right base class for the instruction group for formatting.
The cast eliminates the need of allocating an object for each decoded instruction.
Unknown instructions are formatted as ".word 1234" or ".long 12345678" depending whether
the instruction is 16 or 32 bit.

• JavaScriptCore.xcodeproj/project.pbxproj:
• disassembler/ARMv7: Added.
• disassembler/ARMv7/ARMv7DOpcode.cpp: Added.

(ARMv7Disassembler):
(OpcodeGroupInitializer):
(JSC::ARMv7Disassembler::ARMv7DOpcode::init):
(JSC::ARMv7Disassembler::ARMv7DOpcode::startITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::saveITConditionAt):
(JSC::ARMv7Disassembler::ARMv7DOpcode::fetchOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::disassemble):
(JSC::ARMv7Disassembler::ARMv7DOpcode::bufferPrintf):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendInstructionName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendRegisterName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendRegisterList):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendFPRegisterName):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::init):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::doDisassemble):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::defaultFormat):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscBreakpointT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::init):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::doDisassemble):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::defaultFormat):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::appendModifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::appendImmShift):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::appendFPRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegShift::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegParallel::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegMisc::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadRegister::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadUnsignedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate12::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleRegister::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::format):

• disassembler/ARMv7/ARMv7DOpcode.h: Added.

(ARMv7Disassembler):
(ARMv7DOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::ARMv7DOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::is32BitInstruction):
(JSC::ARMv7Disassembler::ARMv7DOpcode::isFPInstruction):
(JSC::ARMv7Disassembler::ARMv7DOpcode::conditionName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::shiftName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::inITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::startingITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::endITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendInstructionNameNoITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendSeparator):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendCharacter):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendString):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendShiftType):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendSignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendUnsignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendPCRelativeOffset):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendShiftAmount):
(ARMv7D16BitOpcode):
(OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::setNext):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::next):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::matches):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::format):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::rm):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::rd):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::opcodeGroupNumber):
(ARMv7DOpcodeAddRegisterT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::rdn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::rm):
(ARMv7DOpcodeAddSPPlusImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::immediate8):
(ARMv7DOpcodeAddSubtract):
(ARMv7DOpcodeAddSubtractT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::rn):
(ARMv7DOpcodeAddSubtractImmediate3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::immediate3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::rn):
(ARMv7DOpcodeAddSubtractImmediate8):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::rdn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::immediate8):
(ARMv7DOpcodeBranchConditionalT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::condition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::offset):
(ARMv7DOpcodeBranchExchangeT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::rm):
(ARMv7DOpcodeBranchT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchT2::immediate11):
(ARMv7DOpcodeCompareImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::immediate8):
(ARMv7DOpcodeCompareRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT1::rn):
(ARMv7DOpcodeCompareRegisterT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::rm):
(ARMv7DOpcodeDataProcessingRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::rdn):
(ARMv7DOpcodeGeneratePCRelativeAddress):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::immediate8):
(ARMv7DOpcodeLoadFromLiteralPool):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::immediate8):
(ARMv7DOpcodeLoadStoreRegisterImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::scale):
(ARMv7DOpcodeLoadStoreRegisterImmediateWordAndByte):
(ARMv7DOpcodeLoadStoreRegisterImmediateHalfWord):
(ARMv7DOpcodeLoadStoreRegisterOffsetT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::opB):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rt):
(ARMv7DOpcodeLoadStoreRegisterSPRelative):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::immediate8):
(ARMv7DOpcodeLogicalImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::immediate5):
(ARMv7DOpcodeMiscAddSubSP):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::immediate7):
(ARMv7DOpcodeMiscByteHalfwordOps):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::op):
(ARMv7DOpcodeMiscBreakpointT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscBreakpointT1::immediate8):
(ARMv7DOpcodeMiscCompareAndBranch):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::immediate6):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::rn):
(ARMv7DOpcodeMiscHint16):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::opA):
(ARMv7DOpcodeMiscIfThenT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::firstCondition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::mask):
(ARMv7DOpcodeMiscPushPop):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::registerMask):
(ARMv7DOpcodeMoveImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::immediate8):
(ARMv7DOpcodeMoveRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::rm):
(ARMv7D32BitOpcode):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::setNext):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::next):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::matches):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::format):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rd):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rm):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rn):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rt):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::opcodeGroupNumber):
(ARMv7DOpcodeBranchRelative):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::j1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::j2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::immediate11):
(ARMv7DOpcodeConditionalBranchT3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::offset):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::condition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::immediate6):
(ARMv7DOpcodeBranchOrBranchLink):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::offset):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::immediate10):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::isBL):
(ARMv7DOpcodeDataProcessingLogicalAndRithmetic):
(ARMv7DOpcodeDataProcessingModifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::immediate12):
(ARMv7DOpcodeDataProcessingShiftedReg):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::type):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::tbBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::tBit):
(ARMv7DOpcodeDataProcessingReg):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingReg::op1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingReg::op2):
(ARMv7DOpcodeDataProcessingRegShift):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegShift::opName):
(ARMv7DOpcodeDataProcessingRegExtend):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::opExtendName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::opExtendAndAddName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::rotate):
(ARMv7DOpcodeDataProcessingRegParallel):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegParallel::opName):
(ARMv7DOpcodeDataProcessingRegMisc):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegMisc::opName):
(ARMv7DOpcodeHint32):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::isDebugHint):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::debugOption):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::op):
(ARMv7DOpcodeFPTransfer):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opH):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opL):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opC):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opB):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::vd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::vn):
(ARMv7DOpcodeDataLoad):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataLoad::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataLoad::op):
(ARMv7DOpcodeLoadRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadRegister::immediate2):
(ARMv7DOpcodeLoadSignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::pBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::uBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::wBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::immediate8):
(ARMv7DOpcodeLoadUnsignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadUnsignedImmediate::immediate12):
(ARMv7DOpcodeLongMultipleDivide):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlalOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlaldOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlsldOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::rdLo):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::rdHi):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::op1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::op2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::nBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::mBit):
(ARMv7DOpcodeDataPushPopSingle):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::op):
(ARMv7DOpcodeDataStoreSingle):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataStoreSingle::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataStoreSingle::op):
(ARMv7DOpcodeStoreSingleImmediate12):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate12::immediate12):
(ARMv7DOpcodeStoreSingleImmediate8):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::pBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::uBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::wBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::immediate8):
(ARMv7DOpcodeStoreSingleRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleRegister::immediate2):
(ARMv7DOpcodeUnmodifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::shBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::bitNumOrSatImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate12):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate16):
(ARMv7DOpcodeVMOVDoublePrecision):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::rt2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::vm):
(ARMv7DOpcodeVMOVSinglePrecision):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::rt2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::vm):
(ARMv7DOpcodeVMSR):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::opL):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::rt):

• disassembler/ARMv7Disassembler.cpp: Added.

(JSC::tryToDisassemble):

Source/WTF:

Added a new disassembler for ARMv7 Thumb2 instructions for use by the JSC debugging
and profiling code. Enabled the disassembler for IOS bulds.

• wtf/Platform.h:

9:54 AM Changeset in webkit [149820] by mifenton@rim.com

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebPage and WebPageClient to match check-webkit-style updates.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::calculateReflowedScrollPosition):
(BlackBerry::WebKit::WebPagePrivate::centerOfVisibleContentsRect):
(BlackBerry::WebKit::WebPage::assignFocus):
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
(BlackBerry::WebKit::WebPage::addVisitedLink):
(BlackBerry::WebKit::WebPagePrivate::findPatternStringForUrl):
(BlackBerry::WebKit::WebPage::notifySwipeEvent):
(BlackBerry::WebKit::WebPage::notifyScreenPowerStateChanged):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerWebKitThread):
(BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):

• Api/WebPageClient.h:
• Api/WebPage_p.h:

9:51 AM Changeset in webkit [149819] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update BackingStore to match check-webkit-style updates.

Internally reviewed by Jakob Petsovits.

• Api/BackingStore.cpp:

(BlackBerry::WebKit::bestDivisor):
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveLeft):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveRight):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveUp):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveDown):
(BlackBerry::WebKit::BackingStorePrivate::canMoveLeft):
(BlackBerry::WebKit::BackingStorePrivate::canMoveRight):
(BlackBerry::WebKit::BackingStorePrivate::canMoveUp):
(BlackBerry::WebKit::BackingStorePrivate::canMoveDown):
(BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
(BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
(BlackBerry::WebKit::BackingStoreGeometry::originOfTile):
(BlackBerry::WebKit::BackingStore::repaint):

• Api/BackingStore_p.h:

(BackingStoreGeometry):

9:36 AM WebKit Team edited by simon.pena@samsung.com

Adding myself (diff)

9:16 AM Changeset in webkit [149818] by mifenton@rim.com

• 8 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update ChromeClientBlackBerry, CredentialManager, FrameLoaderClientBlackBerry,
GeolocationClientBlackBerry and IconDatabaseClientBlackberry to
match check-webkit-style updates.

• WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

• WebCoreSupport/CredentialManager.h:

(CredentialManager):

• WebCoreSupport/CredentialTransformData.cpp:
• WebCoreSupport/FrameLoaderClientBlackBerry.h:

(WebCore::FrameLoaderClientBlackBerry::assignIdentifierToInitialRequest):
(FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveAuthenticationChallenge):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidCancelAuthenticationChallenge):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveContentLength):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailLoading):

• WebCoreSupport/GeolocationClientBlackBerry.cpp:

(GeolocationClientBlackBerry::onLocationUpdate):

• WebCoreSupport/GeolocationClientBlackBerry.h:

(GeolocationClientBlackBerry):

• WebCoreSupport/IconDatabaseClientBlackBerry.cpp:

(WebCore::IconDatabaseClientBlackBerry::initIconDatabase):

9:13 AM Changeset in webkit [149817] by crogers@google.com

• 29 edits in trunk/Source/WebCore

Require use of AudioBus::create() to avoid ref-counting issues
​https://bugs.webkit.org/show_bug.cgi?id=115836

Reviewed by Andreas Kling.

There were a couple of places still embedding raw AudioBus objects as
member variables or local variables causing ref-counting problems
now that AudioBus is ref-counted. Make AudioBus constructor private
to enforce use of AudioBus::create().

Adapted from Blink patch:
​https://chromiumcodereview.appspot.com/14628008/

• Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::LocalAudioInputProvider::LocalAudioInputProvider):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::set):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::provideInput):
(LocalAudioInputProvider):

• Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):

• Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateInternalBus):

• Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateFinalValues):

• Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::setBuffer):

• Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
(WebCore::MediaStreamAudioDestinationNode::process):

• Modules/webaudio/MediaStreamAudioDestinationNode.h:
• Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):

• Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):

• Modules/webaudio/ScriptProcessorNode.h:

(ScriptProcessorNode):

• platform/audio/AudioBus.cpp:

(WebCore::AudioBus::create):
(WebCore):
(WebCore::AudioBus::AudioBus):
(WebCore::AudioBus::createBufferFromRange):
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):

• platform/audio/AudioBus.h:

(AudioBus):

• platform/audio/AudioFIFO.cpp:

(WebCore::AudioFIFO::AudioFIFO):
(WebCore::AudioFIFO::consume):
(WebCore::AudioFIFO::push):

• platform/audio/AudioFIFO.h:

(AudioFIFO):

• platform/audio/AudioPullFIFO.cpp:

(WebCore::AudioPullFIFO::AudioPullFIFO):
(WebCore::AudioPullFIFO::fillBuffer):

• platform/audio/AudioPullFIFO.h:

(AudioPullFIFO):

• platform/audio/AudioResampler.cpp:

(WebCore::AudioResampler::AudioResampler):
(WebCore::AudioResampler::configureChannels):

• platform/audio/MultiChannelResampler.cpp:
• platform/audio/Reverb.cpp:

(WebCore::Reverb::initialize):

• platform/audio/SincResampler.cpp:

(WebCore::SincResampler::consumeSource):
(WebCore):

• platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):

• platform/audio/gstreamer/AudioDestinationGStreamer.h:

(AudioDestinationGStreamer):

• platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

• platform/audio/ios/AudioDestinationIOS.cpp:

(WebCore::AudioDestinationIOS::AudioDestinationIOS):
(WebCore::AudioDestinationIOS::render):

• platform/audio/ios/AudioDestinationIOS.h:

(AudioDestinationIOS):

• platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestinationMac::AudioDestinationMac):
(WebCore::AudioDestinationMac::render):

• platform/audio/mac/AudioDestinationMac.h:

(AudioDestinationMac):

• platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):

9:09 AM Changeset in webkit [149816] by zhajiang@rim.com

• 5 edits in trunk/Source/WebKit/blackberry

Fix some compiler warnings (miscellaneous)
​https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-05-09.
Reviewed by Rob Buis.

Fix the following warnings for BlackBerry:
InRegionScroller.cpp:286:39: warning: suggest parentheses around
assignment used as truth value [-Wparentheses].
InRegionScroller.cpp:349:39: warning: suggest parentheses around
assignment used as truth value [-Wparentheses].
InRegionScroller.cpp:456:82: warning: suggest parentheses around '&&'

within '

' [-Wparentheses].

InRegionScrollableArea.cpp:134:16: warning: suggest explicit braces to
avoid ambiguous 'else' [-Wparentheses].
SelectionHandler.cpp:390:109: warning: suggest parentheses around '&&'

within '

' [-Wparentheses].

SelectionOverlay.cpp:56:47: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare].

• Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
(BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):

• WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):

• WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::draw):

9:02 AM Changeset in webkit [149815] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update ColorPickerClient and PagePopupBlackBerry
to match check-webkit-style updates.

• WebCoreSupport/ColorPickerClient.cpp:

(WebCore::ColorPickerClient::generateHTML):

• WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::setValueAndClosePopupCallback):
(WebCore::PagePopupBlackBerry::installDOMFunction):

8:51 AM Changeset in webkit [149814] by commit-queue@webkit.org

• 9 edits
  4 adds in trunk/Source

[BlackBerry] Upstream the input popups
​https://bugs.webkit.org/show_bug.cgi?id=114608

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.

This patch contains contributions from many members of the
BlackBerry WebKit team, including:

Chris Hutten-Czapski
David Hoon
Jessica Cao
Rob Buis
Tiancheng Jiang

Source/WebCore:

• Resources/blackberry/colorControlBlackBerry.css: Added.

(.color-picker-popup-area):
(.color-picker-content):
(.color-picker-block):
(#color-picker-swatch-block):
(.color-picker-switcher):
(.color-picker-check-mark):
(.color-picker-option):
(.color-picker-button):
(.color-picker-highlight):
(input):
(.color-picker-sharp):
(.color-picker-off):
(.color-picker-inactive-font):
(.color-picker-row):
(.color-picker-hex-style):
(.color-picker-input):
(.color-picker-well):
(.color-picker-input .color-picker-well):
(.color-picker-slider):
(.color-picker-slider-output):
(.color-picker-range):
(.color-picker-range::-webkit-slider-thumb):
(.color-picker-range::-webkit-slider-thumb:active):
(.red-ranger-bg):
(.green-ranger-bg):
(.blue-ranger-bg):
(@media only screen and (height: 768px)):
(@media only screen and (height: 720px)):

• Resources/blackberry/colorControlBlackBerry.js: Added.

(.):

• Resources/blackberry/popupControlBlackBerry.css:

(body):
(.popup-area):
(.popup-header):
(.popup-content):
(.popup-buttons):
(.popup-button):
(@media only screen and (width: 720px) and (height: 720px)):

• Resources/blackberry/selectControlBlackBerry.css:

(.popup-content):
(@media (min-height: 918px)):
(.option):
(@media only screen and (width: 720px) and (height: 720px)):
(.contents):
(.option:active):
(.selected):
(.selected .contents::after):
(.text):
(.disabled):
(.optgroup):
(.optgroup-option):

• Resources/blackberry/selectControlBlackBerry.js:

(.):

• Resources/blackberry/timeControlBlackBerry.css: Added.

(#popup-content-time):
(.column):
(.column:not(:last-child)):
(.cell):
(.yearmonthdate .cell div:last-child):
(.row-highlight-container):
(.row-highlight-filler):
(.row-highlight):
(.tall-bit):
(@media only screen and (width: 720px) and (height: 720px)):

• Resources/blackberry/timeControlBlackBerry.js: Added.

(.):

Source/WebKit/blackberry:

• WebCoreSupport/ColorPickerClient.cpp:

(WebCore):
(WebCore::ColorPickerClient::generateHTML):

• WebCoreSupport/DatePickerClient.cpp:

(WebCore):
(WebCore::DatePickerClient::generateHTML):
(WebCore::DatePickerClient::generateDateLabels):

• WebCoreSupport/DatePickerClient.h:

(DatePickerClient):

• WebCoreSupport/SelectPopupClient.cpp:

(WebCore):
(WebCore::SelectPopupClient::generateHTML):

8:46 AM Changeset in webkit [149813] by rwlbuis@webkit.org

• 16 edits in trunk/Source/WebCore

[BlackBerry] texmap code generates warnings
​https://bugs.webkit.org/show_bug.cgi?id=115815

Patch by Rob Buis <​rbuis@rim.com> on 2013-05-09
Reviewed by Benjamin Poulain.

Add USE(TEXTURE_MAPPER) guards since Source/WebCore/CMakeLists.txt includes
these files unconditionally.

• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
• platform/graphics/texmap/GraphicsLayerTextureMapper.h:
• platform/graphics/texmap/TextureMapper.h:
• platform/graphics/texmap/TextureMapperBackingStore.cpp:
• platform/graphics/texmap/TextureMapperBackingStore.h:
• platform/graphics/texmap/TextureMapperFPSCounter.cpp:
• platform/graphics/texmap/TextureMapperFPSCounter.h:
• platform/graphics/texmap/TextureMapperGL.cpp:
• platform/graphics/texmap/TextureMapperGL.h:
• platform/graphics/texmap/TextureMapperLayer.cpp:
• platform/graphics/texmap/TextureMapperLayer.h:
• platform/graphics/texmap/TextureMapperTile.cpp:
• platform/graphics/texmap/TextureMapperTile.h:
• platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
• platform/graphics/texmap/TextureMapperTiledBackingStore.h:

8:44 AM Changeset in webkit [149812] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

PluginDatabase: add plugin directory for the BlackBerry port.
​https://bugs.webkit.org/show_bug.cgi?id=114943

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.

XP_UNIX is defined for the BlackBerry port, but we don't want to
share the same code here.

• plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):

8:43 AM Changeset in webkit [149811] by mifenton@rim.com

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update DOMSupport to match check-webkit-style updates.

• WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isTextInputElement):
(BlackBerry::WebKit::DOMSupport::isPasswordElement):
(BlackBerry::WebKit::DOMSupport::convertPointToFrame):

8:42 AM Changeset in webkit [149810] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

[BLACKBERRY]fix regression in Webpage
and FrameLoaderClientBlackberry
​https://bugs.webkit.org/show_bug.cgi?id=115843

Patch by Xuefei Ren <​xren@blackberry.com> on 2013-05-09
Reviewed by Rob Buis.

Internally reviewed by Mary Wu.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::loadFile):

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::startDownload):

8:35 AM Changeset in webkit [149809] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update FatFingers to match check-webkit-style updates.

• WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::checkFingerIntersection):
(BlackBerry::WebKit::FatFingers::checkForClickableElement):

• WebKitSupport/FatFingers.h:

(FatFingersResult):

8:26 AM Changeset in webkit [149808] by mifenton@rim.com

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update InRegionScrollableArea, TileIndexHash
and TouchEventHandler to match check-webkit-style updates.

• WebKitSupport/InRegionScrollableArea.cpp:
• WebKitSupport/TileIndexHash.h:
• WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):

8:16 AM Changeset in webkit [149807] by commit-queue@webkit.org

• 8 edits
  2 deletes in trunk/Source/WebCore

Web Inspector: Remove Memory Distribution and Memory Snapshots Panels
​https://bugs.webkit.org/show_bug.cgi?id=115850

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-09
Reviewed by Andreas Kling.

Removed the Memory Instrumentation Code after r148921.

No new tests, no behavior change.

• inspector/compile-front-end.py:
• inspector/front-end/NativeMemorySnapshotView.js: Removed.
• inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):

• inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.ExperimentsSettings):

• inspector/front-end/SettingsScreen.js:
• inspector/front-end/WebKit.qrc:
• inspector/front-end/inspector.css:
• inspector/front-end/inspector.js:

(WebInspector._panelDescriptors):

• inspector/front-end/nativeMemoryProfiler.css: Removed.

8:11 AM Changeset in webkit [149806] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Styles fixes required for InputHandler based on updated
check-webkit-style.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
(BlackBerry::WebKit::InputHandler::firstSpanInString):
(BlackBerry::WebKit::InputHandler::setTextAttributes):

• WebKitSupport/InputHandler.h:

7:26 AM Changeset in webkit [149805] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix after r149796.

• GNUmakefile.am: Add a phony target for the window constructors file and include it among

the dependencies for the non-generated code.

7:03 AM Changeset in webkit [149804] by timothy@apple.com

• 2 edits in trunk/Source/WebKit2

Make dragging off a tab in Safari with a docked Inspector reattach the Inspector.

​https://webkit.org/b/115832
rdar://problem/13605661

Reviewed by Benjamin Poulain.

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformBringToFront):
If the Web Inspector is no longer in the same window as the inspected view,
then we need to reopen the Inspector to get it attached to the right window.

6:50 AM Changeset in webkit [149803] by commit-queue@webkit.org

• 5 edits in trunk/LayoutTests

[CSSRegions] Change fast/regions/webkit-flow-inlines-inside-regions-bounds[-vertical] tests to make them platform independent
​https://bugs.webkit.org/show_bug.cgi?id=115851

Patch by Radu Stavila <​stavila@adobe.com> on 2013-05-09
Reviewed by Antti Koivisto.

Modified tests to make them platform independent by using Ahem and no font smoothing.

• fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.html:
• fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.html:
• fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html:
• fast/regions/webkit-flow-inlines-inside-regions-bounds.html:

6:48 AM Changeset in webkit [149802] by commit-queue@webkit.org

• 10 edits in trunk/LayoutTests

[Qt][EFL][GTK] Failing CSS region tests
​https://bugs.webkit.org/show_bug.cgi?id=115785

Patch by Radu Stavila <​stavila@adobe.com> on 2013-05-09
Reviewed by Antti Koivisto.

Updated tests to overcome platform differences
Unskip fixed CSS regions tests

• fast/regions/webkit-flow-double-pagination-float-push-expected.html:
• fast/regions/webkit-flow-double-pagination-float-push.html:
• fast/regions/webkit-flow-float-pushed-to-last-region-expected.html:
• fast/regions/webkit-flow-float-pushed-to-last-region.html:
• fast/regions/webkit-flow-float-unable-to-push-expected.html:
• fast/regions/webkit-flow-float-unable-to-push.html:
• fast/regions/webkit-flow-floats-inside-regions-bounds-expected.html:
• fast/regions/webkit-flow-floats-inside-regions-bounds.html:
• platform/qt/TestExpectations:

6:12 AM Changeset in webkit [149801] by zarvai@inf.u-szeged.hu

• 9 edits
  10 copies
  36 adds in trunk/LayoutTests

[Qt] Unreviewed gardeing. Updating some png expected results.

• platform/qt-5.0-wk2/compositing/checkerboard-expected.png: Added.
• platform/qt-5.0-wk2/css3/unicode-bidi-isolate-basic-expected.png: Added.
• platform/qt-5.0-wk2/editing/deleting/delete-image-001-expected.png: Added.
• platform/qt-5.0-wk2/editing/inserting/typing-around-image-001-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/caret-rtl-2-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/caret-rtl-2-left-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/caret-rtl-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/extend-by-character-002-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/extend-selection-bidi-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/unrendered-001-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png: Added.
• platform/qt-5.0-wk2/fast/borders/rtl-border-04-expecrted.png: Added.
• platform/qt-5.0-wk2/fast/borders/rtl-border-05-expected.png: Added.
• platform/qt-5.0-wk2/fast/box-shadow/shadow-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/dom/34176-expected.png: Added.
• platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.png: Added.
• platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.png: Added.
• platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png:
• platform/qt-5.0-wk2/fast/forms/listbox-bidi-align-expected.png: Added.
• platform/qt-5.0-wk2/fast/forms/search-rtl-expected.png: Added.
• platform/qt-5.0-wk2/fast/frames/transparent-scrollbar-expected.png: Added.
• platform/qt-5.0-wk2/fast/inline/inline-box-background-expected.png: Added.
• platform/qt-5.0-wk2/fast/inline/inline-box-background-long-image-expected.png: Added.
• platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-x-expected.png: Added.
• platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-y-expected.png: Added.
• platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png:
• platform/qt-5.0-wk2/fast/repaint/absolute-position-moved-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/fast/repaint/add-table-overpaint-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/fast/repaint/backgroundSizeRepaint-expected.png:
• platform/qt-5.0-wk2/fast/repaint/change-transform-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/inline-outline-repaint-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png:
• platform/qt-5.0-wk2/fast/repaint/overflow-into-content-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png.
• platform/qt-5.0-wk2/fast/repaint/stacked-diacritics-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/table-cell-overflow-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png:
• platform/qt-5.0-wk2/fast/repaint/table-row-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
• platform/qt-5.0-wk2/fast/repaint/transform-rotate-and-remove-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
• platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/repaint-on-image-bounds-change-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
• platform/qt-5.0-wk2/svg/custom/use-disappears-after-style-update-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
• platform/qt-5.0-wk2/svg/dom/rect-modify-rx-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/repaint/svgsvgelement-repaint-children-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/svg/text/tspan-dynamic-positioning-expected.png: Added.

6:11 AM Changeset in webkit [149800] by akling@apple.com

• 2 edits in trunk/Source/WebKit/qt

[Qt][WK1]REGRESSION(r149532) tst_qwebelement and tst_qwebframe API tests crash.
<​http://webkit.org/b/115855>

Fix obvious off-by-one mistake.

• Api/qwebelement.cpp:

(QWebElement::styleProperty):

3:05 AM WebKitIDL edited by Christophe Dumez

Add documentation for [NoInterfaceObject] introduced in r149796 (diff)

2:40 AM WebKitIDL edited by Christophe Dumez

Move extended attribute to their correct place (diff)

2:18 AM Changeset in webkit [149799] by kadam@inf.u-szeged.hu

• 1 edit
  1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Added platform specific expected file after r149758.

• platform/qt/fast/js/global-constructors-attributes-expected.txt: Added after r149758.

2:07 AM Changeset in webkit [149798] by mario@webkit.org

• 2 edits in trunk/Tools

Unreviewed. Update Simon Pena email on his behalf.

• Scripts/webkitpy/common/config/contributors.json:

1:14 AM Changeset in webkit [149797] by Christophe Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed build fix for Qt minimal build.

r149796 broke builds that have WEB_SOCKETS flag disabled.

• page/DOMWindow.idl:

12:38 AM Changeset in webkit [149796] by Christophe Dumez

• 215 edits
  4 deletes in trunk

Add support for [NoInterfaceObject] Web IDL extended attribute
​https://bugs.webkit.org/show_bug.cgi?id=115714

Reviewed by Kentaro Hara.

.:

Update GENERATE_BINDINGS macro to take an additional _window_constructors_file
optional argument.

• Source/cmake/WebKitMacros.cmake:

Source/WebCore:

*Constructor attributes on the global DOMWindow object are now automatically
generated for each non-callback interface that is not declared with the
[NoInterfaceObject] extended attribute. It is thus no longer needed for
developers to manually add *Constructor attributes for their new interfaces
unless they wish to register an "extra" constructor for their interface.

This patch does not modify at all the behavior on JS side. To achieve this,
[NoInterfaceObject] extended attribute is added to interfaces that should
not have it according to specification (e.g. History, Location, ...).
This can be improved later as the behavior should not change with this
patch.

No new tests, no behavior change.

• CMakeLists.txt:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.am:
• GNUmakefile.list.am:
• Modules/battery/BatteryManager.idl:
• Modules/encryptedmedia/MediaKeyMessageEvent.idl:
• Modules/encryptedmedia/MediaKeyNeededEvent.idl:
• Modules/encryptedmedia/MediaKeySession.idl:
• Modules/encryptedmedia/MediaKeys.idl:
• Modules/filesystem/DOMFileSystem.idl:
• Modules/filesystem/DOMFileSystemSync.idl:
• Modules/filesystem/DirectoryEntry.idl:
• Modules/filesystem/DirectoryEntrySync.idl:
• Modules/filesystem/DirectoryReader.idl:
• Modules/filesystem/DirectoryReaderSync.idl:
• Modules/filesystem/Entry.idl:
• Modules/filesystem/EntryArray.idl:
• Modules/filesystem/EntryArraySync.idl:
• Modules/filesystem/EntrySync.idl:
• Modules/filesystem/FileEntry.idl:
• Modules/filesystem/FileEntrySync.idl:
• Modules/filesystem/FileWriter.idl:
• Modules/filesystem/FileWriterSync.idl:
• Modules/filesystem/Metadata.idl:
• Modules/gamepad/Gamepad.idl:
• Modules/gamepad/GamepadList.idl:
• Modules/geolocation/Coordinates.idl:
• Modules/geolocation/Geolocation.idl:
• Modules/geolocation/Geoposition.idl:
• Modules/geolocation/PositionError.idl:
• Modules/indexeddb/DOMWindowIndexedDatabase.idl:
• Modules/indexeddb/IDBAny.idl:
• Modules/mediasource/MediaSource.idl:
• Modules/mediasource/SourceBuffer.idl:
• Modules/mediasource/SourceBufferList.idl:
• Modules/mediastream/DOMWindowMediaStream.idl: Removed.
• Modules/mediastream/MediaStream.idl:
• Modules/mediastream/MediaStreamTrack.idl:
• Modules/mediastream/MediaStreamTrackEvent.idl:
• Modules/mediastream/NavigatorUserMediaError.idl:
• Modules/mediastream/RTCDTMFSender.idl:
• Modules/mediastream/RTCDTMFToneChangeEvent.idl:
• Modules/mediastream/RTCDataChannel.idl:
• Modules/mediastream/RTCDataChannelEvent.idl:
• Modules/mediastream/RTCIceCandidateEvent.idl:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCStatsReport.idl:
• Modules/mediastream/RTCStatsResponse.idl:
• Modules/networkinfo/NetworkInfoConnection.idl:
• Modules/notifications/DOMWindowNotifications.idl:
• Modules/notifications/NotificationCenter.idl:
• Modules/quota/StorageInfo.idl:
• Modules/quota/StorageQuota.idl:
• Modules/speech/DOMWindowSpeech.idl: Removed.
• Modules/speech/DOMWindowSpeechSynthesis.idl:
• Modules/speech/SpeechGrammar.idl:
• Modules/speech/SpeechGrammarList.idl:
• Modules/speech/SpeechRecognition.idl:
• Modules/speech/SpeechRecognitionAlternative.idl:
• Modules/speech/SpeechRecognitionError.idl:
• Modules/speech/SpeechRecognitionEvent.idl:
• Modules/speech/SpeechRecognitionResult.idl:
• Modules/speech/SpeechRecognitionResultList.idl:
• Modules/speech/SpeechSynthesis.idl:
• Modules/speech/SpeechSynthesisVoice.idl:
• Modules/webaudio/AnalyserNode.idl:
• Modules/webaudio/AudioBuffer.idl:
• Modules/webaudio/AudioBufferSourceNode.idl:
• Modules/webaudio/AudioContext.idl:
• Modules/webaudio/AudioDestinationNode.idl:
• Modules/webaudio/AudioListener.idl:
• Modules/webaudio/AudioNode.idl:
• Modules/webaudio/AudioParam.idl:
• Modules/webaudio/AudioSourceNode.idl:
• Modules/webaudio/BiquadFilterNode.idl:
• Modules/webaudio/ChannelMergerNode.idl:
• Modules/webaudio/ChannelSplitterNode.idl:
• Modules/webaudio/ConvolverNode.idl:
• Modules/webaudio/DOMWindowWebAudio.idl: Removed.
• Modules/webaudio/DelayNode.idl:
• Modules/webaudio/DynamicsCompressorNode.idl:
• Modules/webaudio/GainNode.idl:
• Modules/webaudio/MediaElementAudioSourceNode.idl:
• Modules/webaudio/MediaStreamAudioDestinationNode.idl:
• Modules/webaudio/MediaStreamAudioSourceNode.idl:
• Modules/webaudio/OfflineAudioContext.idl:
• Modules/webaudio/OscillatorNode.idl:
• Modules/webaudio/PannerNode.idl:
• Modules/webaudio/ScriptProcessorNode.idl:
• Modules/webaudio/WaveShaperNode.idl:
• Modules/webaudio/WaveTable.idl:
• Modules/webdatabase/DOMWindowWebDatabase.idl:
• Modules/webdatabase/Database.idl:
• Modules/webdatabase/DatabaseSync.idl:
• Modules/webdatabase/SQLError.idl:
• Modules/webdatabase/SQLResultSet.idl:
• Modules/webdatabase/SQLResultSetRowList.idl:
• Modules/webdatabase/SQLTransaction.idl:
• Modules/webdatabase/SQLTransactionSync.idl:
• Modules/websockets/DOMWindowWebSocket.idl: Removed.
• Modules/websockets/WebSocket.idl:
• PlatformBlackBerry.cmake:
• UseJSC.cmake:
• WebCore.xcodeproj/project.pbxproj:
• bindings/scripts/IDLAttributes.txt:
• bindings/scripts/IDLParser.pm:

(parseTypedef):

• bindings/scripts/preprocess-idls.pl:

(GenerateConstructorAttribute):
(getFileContents):
(getPartialInterfaceNameFromIDL):
(isCallbackInterfaceFromIDL):
(trim):
(getInterfaceExtendedAttributesFromIDL):

• css/CSSFontFaceLoadEvent.idl:
• css/CSSFontFaceRule.idl:
• css/CSSSupportsRule.idl:
• css/CSSUnknownRule.idl:
• css/DOMWindowCSS.idl:
• css/FontLoader.idl:
• css/MediaQueryList.idl:
• css/MediaQueryListListener.idl:
• css/StyleMedia.idl:
• dom/CustomElementConstructor.idl:
• dom/DOMError.idl:
• dom/DOMNamedFlowCollection.idl:
• dom/DataTransferItem.idl:
• dom/DataTransferItemList.idl:
• dom/EventListener.idl:
• dom/EventTarget.idl:
• dom/NodeIterator.idl:
• dom/ShadowRoot.idl:
• dom/TreeWalker.idl:
• dom/WebKitNamedFlow.idl:
• fileapi/FileException.idl:
• fileapi/FileReaderSync.idl:
• html/HTMLAudioElement.idl:
• html/HTMLDetailsElement.idl:
• html/HTMLOptionElement.idl:
• html/MediaError.idl:
• html/MediaKeyError.idl:
• html/MicroDataItemValue.idl:
• html/RadioNodeList.idl:
• html/ValidityState.idl:
• html/canvas/CanvasRenderingContext.idl:
• html/canvas/DOMPath.idl:
• html/canvas/EXTDrawBuffers.idl:
• html/canvas/EXTTextureFilterAnisotropic.idl:
• html/canvas/OESElementIndexUint.idl:
• html/canvas/OESStandardDerivatives.idl:
• html/canvas/OESTextureFloat.idl:
• html/canvas/OESTextureHalfFloat.idl:
• html/canvas/OESVertexArrayObject.idl:
• html/canvas/WebGLCompressedTextureATC.idl:
• html/canvas/WebGLCompressedTexturePVRTC.idl:
• html/canvas/WebGLCompressedTextureS3TC.idl:
• html/canvas/WebGLContextAttributes.idl:
• html/canvas/WebGLDebugRendererInfo.idl:
• html/canvas/WebGLDebugShaders.idl:
• html/canvas/WebGLDepthTexture.idl:
• html/canvas/WebGLLoseContext.idl:
• html/canvas/WebGLVertexArrayObjectOES.idl:
• html/track/AudioTrack.idl:
• html/track/AudioTrackList.idl:
• html/track/TextTrackRegionList.idl:
• html/track/VideoTrack.idl:
• html/track/VideoTrackList.idl:
• inspector/InjectedScriptHost.idl:
• inspector/InspectorFrontendHost.idl:
• inspector/JavaScriptCallFrame.idl:
• inspector/ScriptProfile.idl:
• inspector/ScriptProfileNode.idl:
• loader/appcache/DOMApplicationCache.idl:
• page/AbstractView.idl:
• page/BarInfo.idl:
• page/Console.idl:
• page/Crypto.idl:
• page/DOMSecurityPolicy.idl:
• page/DOMWindow.idl:
• page/History.idl:
• page/Location.idl:
• page/MemoryInfo.idl:
• page/Navigator.idl:
• page/PagePopupController.idl:
• page/Performance.idl:
• page/PerformanceEntry.idl:
• page/PerformanceEntryList.idl:
• page/PerformanceMark.idl:
• page/PerformanceMeasure.idl:
• page/PerformanceNavigation.idl:
• page/PerformanceResourceTiming.idl:
• page/PerformanceTiming.idl:
• page/Screen.idl:
• page/SpeechInputResult.idl:
• page/SpeechInputResultList.idl:
• page/WorkerNavigator.idl:
• page/make_settings.pl:

(generateInternalSettingsIdlFile):

• svg/ElementTimeControl.idl:
• svg/SVGAnimationElement.idl:
• svg/SVGExternalResourcesRequired.idl:
• svg/SVGFilterPrimitiveStandardAttributes.idl:
• svg/SVGFitToViewBox.idl:
• svg/SVGLangSpace.idl:
• svg/SVGLocatable.idl:
• svg/SVGStyledElement.idl:
• svg/SVGTests.idl:
• svg/SVGTransformable.idl:
• svg/SVGURIReference.idl:
• testing/InternalSettings.idl:
• testing/Internals.idl:
• testing/MallocStatistics.idl:
• testing/TypeConversions.idl:
• workers/AbstractWorker.idl:
• workers/DedicatedWorkerContext.idl:
• workers/SharedWorker.idl:
• workers/SharedWorkerContext.idl:
• workers/WorkerContext.idl:
• workers/WorkerLocation.idl:
• xml/XPathExpression.idl:
• xml/XPathNSResolver.idl:

Tools:

Update BindingsTests.generate_supplemental_dependency() to pass an
additional windowConstructorsFile argument to preprocess-idls.pl.

• Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):

12:05 AM Changeset in webkit [149795] by commit-queue@webkit.org

• 5 edits in trunk

[GTK][AC] Buildfix after r149694
​https://bugs.webkit.org/show_bug.cgi?id=115797

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-05-09
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Some interfaces, such as a return value and parameters of functions are changed.

No new tests since no functionality changed.

• platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::animationHasStepsTimingFunction):
(WebCore::GraphicsLayerClutter::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerClutter::setAnimationEndpoints):
(WebCore::GraphicsLayerClutter::setAnimationKeyframes):

• platform/graphics/clutter/GraphicsLayerClutter.h:

(GraphicsLayerClutter):

Tools:

Add CLUTTER_LIBS for linking TestWebCore.

• TestWebKitAPI/GNUmakefile.am:

May 8, 2013:

11:39 PM Changeset in webkit [149794] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Fix some compiler warnings (miscellaneous)
​https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Rob Buis <​rbuis@rim.com> on 2013-05-08
Reviewed by Brent Fulgham.

Get rid of the following warning for BlackBerry:

NavigatorContentUtils.cpp:60:78: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

by not compiling any of the code to add protocols to the protocol whitelist.

• Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::initProtocolHandlerWhitelist):

11:38 PM Changeset in webkit [149793] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Windows] The function seekFile() is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=115246

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-05-08
Reviewed by Brent Fulgham.

Implemented seekFile() function for Windows.

• platform/win/FileSystemWin.cpp:

(WebCore::seekFile):

11:31 PM Changeset in webkit [149792] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Fix a typo in Settings.js
​https://bugs.webkit.org/show_bug.cgi?id=115849

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08
Reviewed by Joseph Pecoraro.

No new tests, no behavior change.

• inspector/front-end/Settings.js:

(WebInspector.Settings):

10:26 PM Changeset in webkit [149791] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

SecurityOrigin doesn’t need to forward declare or include Document
​https://bugs.webkit.org/show_bug.cgi?id=115847

Reviewed by Alexey Proskuryakov.

Merge ​https://chromium.googlesource.com/chromium/blink/+/fc7a88caa9c41f3471d8994a530643e5225f82fc.

Removed unused Document forward declaration+include from SecurityOrigin.

• page/SecurityOrigin.cpp:
• page/SecurityOrigin.h:

9:58 PM EFLWebKit edited by gyuyoung.kim@samsung.com

Update dependency pkgs (diff)

9:50 PM Changeset in webkit [149790] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Tools

[EFL] Remove unnecessary pkgs in EFL jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=114908

Reviewed by Laszlo Gombos.

p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
handle them using jhbuild. We can reduce build time when using --update-efl.

• efl/jhbuild.modules:

8:52 PM Changeset in webkit [149789] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

BUILD FIX: Don't use adoptCF() with NSDictionary * object

Fixes the following build failure:

In file included from Source/WebCore/platform/network/mac/ResourceErrorMac.mm:27:
In file included from Source/WebCore/platform/network/cf/ResourceError.h:31:
/usr/local/include/wtf/RetainPtr.h:81:13: error: static_assert failed "Don't use adoptCF with Objective-C pointer types, use adoptNS."

static_assert(!std::is_convertible<T, id>::value, "Don't use adoptCF with Objective-C pointer types, use adoptNS.");

/usr/local/include/wtf/RetainPtr.h:274:16: note: in instantiation of member function 'WTF::RetainPtr<NSDictionary *>::RetainPtr' requested here

return RetainPtr<T>(AdoptCF, o);

Source/WebCore/platform/network/mac/ResourceErrorMac.mm:214:44: note: in instantiation of function template specialization 'WTF::adoptCF<NSDictionary *>' requested here

RetainPtr<NSDictionary> userInfo = adoptCF((NSDictionary *) CFErrorCopyUserInfo(error));

1 error generated.

• platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::nsError): Switch from adoptCF() to
adoptNS(). This is in USE(CFNETWORK) code, so it's not
exercised on the Mac.

8:12 PM Changeset in webkit [149788] by Lucas Forschler

• 4 edits in trunk/Source

Versioning.

8:00 PM Changeset in webkit [149787] by Lucas Forschler

• 1 copy in tags/Safari-537.41

New Tag.

7:12 PM Changeset in webkit [149786] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[EFL] Disable SHADOW DOM feature in FeatureList.pm
​https://bugs.webkit.org/show_bug.cgi?id=115834

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08
Reviewed by Gyuyoung Kim.

• Scripts/webkitperl/FeatureList.pm:

6:11 PM Changeset in webkit [149785] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Remove Editor::setSelectionOffsets
​https://bugs.webkit.org/show_bug.cgi?id=115831

Reviewed by Andreas Kling.

Removed the function added in r120985 for Chromium Android port.

• editing/Editor.cpp:
• editing/Editor.h:

6:02 PM Changeset in webkit [149784] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Fix a typo in a comment.

Rubber-stamped by Darin Adler.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

5:49 PM Changeset in webkit [149783] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Remove bogus StorageAreaMap assertions
​https://bugs.webkit.org/show_bug.cgi?id=115838

Reviewed by Sam Weinig.

It is possible for didGetValues, and didClear to be called even if m_hasPendingClear is false so remove the assertions.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::didGetValues):
(WebKit::StorageAreaMap::didClear):

5:24 PM Changeset in webkit [149782] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Get rid of duplicate entry line in TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=115828

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08

• platform/efl/TestExpectations:

5:20 PM Changeset in webkit [149781] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Handle incoming clear operations
​https://bugs.webkit.org/show_bug.cgi?id=115829

Reviewed by Sam Weinig.

Handle clear by building up a new storage map with our pending changes.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::applyChange):

4:51 PM Changeset in webkit [149780] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Potential use-after-free of Frame
​https://bugs.webkit.org/show_bug.cgi?id=115774

Reviewed by Simon Fraser.

Merge ​https://chromium.googlesource.com/chromium/blink/+/c5b4a6db82e8280c7fc55ee3dc3a84c6b026e66e.

• page/Frame.cpp:

(WebCore::Frame::setPrinting):
(WebCore::Frame::setPageAndTextZoomFactors):
(WebCore::Frame::deviceOrPageScaleFactorChanged):

4:43 PM Changeset in webkit [149779] by roger_fong@apple.com

• 5 edits in trunk/Source/WebCore

Unreviewed build fix, AppleWin port.

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::seek):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
(WebCore):

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(MediaPlayerPrivateAVFoundation):

4:38 PM Changeset in webkit [149778] by xingnan.wang@intel.com

• 24 edits in trunk/Source/WebCore

Heap-use-after-free in WebCore::AudioNodeOutput::pull
​https://bugs.webkit.org/show_bug.cgi?id=111362

Reviewed by Chris Rogers.

• Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::createFromAudioFileData):

• Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):

• Modules/webaudio/AudioNodeInput.h:

(AudioNodeInput):

• Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateInternalBus):
(WebCore::AudioNodeOutput::pull):
(WebCore::AudioNodeOutput::bus):

• Modules/webaudio/AudioNodeOutput.h:

(AudioNodeOutput):

• Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):

• Modules/webaudio/OfflineAudioDestinationNode.h:

(OfflineAudioDestinationNode):

• platform/audio/AudioBus.cpp:

(WebCore::AudioBus::createBufferFromRange):
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):

• platform/audio/AudioBus.h:

(AudioBus):

• platform/audio/AudioFileReader.h:

(WebCore):

• platform/audio/AudioResampler.cpp:

(WebCore::AudioResampler::AudioResampler):
(WebCore::AudioResampler::configureChannels):

• platform/audio/AudioResampler.h:

(AudioResampler):

• platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):

• platform/audio/MultiChannelResampler.cpp:
• platform/audio/Reverb.cpp:

(WebCore::Reverb::initialize):

• platform/audio/Reverb.h:

(Reverb):

• platform/audio/efl/AudioBusEfl.cpp:

(WebCore::AudioBus::loadPlatformResource):

• platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(AudioFileReader):
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

• platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource):

• platform/audio/mac/AudioBusMac.mm:

(WebCore::AudioBus::loadPlatformResource):

• platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

• platform/audio/mac/AudioFileReaderMac.h:

(AudioFileReader):

• platform/audio/qt/AudioBusQt.cpp:

(WebCore::AudioBus::loadPlatformResource):

4:31 PM Changeset in webkit [149777] by andersca@apple.com

• 6 edits in trunk/Source/WebKit2

Don't apply changes while we're clearing the database
​https://bugs.webkit.org/show_bug.cgi?id=115826

Reviewed by Darin Adler.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::openDatabase):
Only call didOpenDatabaseWithOrigin if we actually did open the database.

(WebKit::LocalStorageDatabase::updateDatabaseWithChangedItems):
Create the database if needed.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::getValues):
Send back a DidGetValues message.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::StorageAreaMap):
Initialize m_hasPendingClear.

(WebKit::StorageAreaMap::clear):
Set m_hasPendingClear to true.

(WebKit::StorageAreaMap::resetValues):
Set m_hasPendingClear back to false.

(WebKit::StorageAreaMap::loadValuesIfNeeded):
Set m_hasPendingClear to true so we'll ignore any changes that are already part of the returned items.

(WebKit::StorageAreaMap::didGetValues):
Set m_hasPendingClear back to false.

(WebKit::StorageAreaMap::didClear):
Set m_hasPendingClear back to false.

(WebKit::StorageAreaMap::applyChange):
Don't apply the change if m_hasPendingClear is true.

• WebProcess/Storage/StorageAreaMap.messages.in:

Add DidGetValues message.

4:15 PM Changeset in webkit [149776] by Lucas Forschler

• 2 edits in trunk/Tools

Add Scheduler for Mac MtnLion 32bit Release builder.

Unreviewed.

• BuildSlaveSupport/build.webkit.org-config/config.json:

4:08 PM Changeset in webkit [149775] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
​https://bugs.webkit.org/show_bug.cgi?id=115808

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-05-08
Reviewed by Darin Adler.

The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
was left outdated after r127191, when the m_string member was changed
from UString to String. This patch calls the right pretty printer for it.

• gdb/webkit.py:

(JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
WTFImplPrettyPrinter.

3:41 PM Changeset in webkit [149774] by aestes@apple.com

• 5 edits
  2 adds in trunk

[WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
​https://bugs.webkit.org/show_bug.cgi?id=115790

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

NSMutableSet does not support adding or removing nil objects, and
WTF::HashSet does not support adding, removing, or checking for null
WTF::Strings.

For the NSMutableSet case, make sure that we don't try to add or remove
nil NSStrings.

For the WTF::HashSet case, NSURL will return a nil NSString if we ask
it for its scheme when it is invalid, which we will convert to a null
WTF::String. Don't try to check if our HashSet of registered schemes
contains a null String.

• Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::registerScheme): Assert that the scheme
isn't null. We reject null schemes at the WKBrowsingContextController level.
(WebKit::CustomProtocolManager::unregisterScheme): Ditto.
(WebKit::CustomProtocolManager::supportsScheme): If scheme is null, return false.

• UIProcess/API/mac/WKBrowsingContextController.mm:

(+[WKBrowsingContextController registerSchemeForCustomProtocol:]): Do not register a nil scheme.
(+[WKBrowsingContextController unregisterSchemeForCustomProtocol:]): Ditto.

Tools:

Added two API tests:

1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::decidePolicyForNavigationAction):
(CustomProtocolInvalidSchemeTest):
(TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):

3:40 PM Changeset in webkit [149773] by Lucas Forschler

• 2 edits in trunk/Tools

Teach buildbot how to compile 32-bit on Mac.

Reviewed by Ryosuke Niwa.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit.start):
(ExtractTestResultsAndLeaks):

3:34 PM Changeset in webkit [149772] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Apply remote changes to storage maps locally
​https://bugs.webkit.org/show_bug.cgi?id=115825

Reviewed by Beth Dakin.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::resetValues):
Clear the pending values map.

(WebKit::StorageAreaMap::didSetItem):
If we failed to set the item, forget everything we know about this storage map.
Otherwise, remove the pending item.

(WebKit::StorageAreaMap::didRemoveItem):
Remove the pending item.

(WebKit::StorageAreaMap::shouldApplyChangeForKey):
Helper function that returns whether a change for a given key should be applied.

(WebKit::StorageAreaMap::applyChange):
Apply the change. Currently only adds and removes are handled.

(WebKit::StorageAreaMap::dispatchStorageEvent):
Apply the change locally as well if needed.

• WebProcess/Storage/StorageAreaMap.h:

3:26 PM Changeset in webkit [149771] by roger_fong@apple.com

• 2 edits
  1 copy in trunk/WebKitLibraries

Update WebKitLibraries/win to handle different architectures properly.

• win/lib32: Copied from win/lib.
• win/tools/WinTools.make:

3:08 PM Changeset in webkit [149770] by mikhail.pozdnyakov@intel.com

• 2 edits in trunk/Source/WTF

Simplify RetainPtrObjectHashTraits
​https://bugs.webkit.org/show_bug.cgi?id=115822

Reviewed by Benjamin Poulain.

RetainPtrObjectHashTraits is inherited from SimpleClassHashTraits
instead of GenericHashTraits re-using more shared functionality.

• wtf/RetainPtr.h:

(WTF::RetainPtrObjectHashTraits::emptyValue):

3:05 PM Changeset in webkit [149769] by commit-queue@webkit.org

• 26 edits in trunk

[BlackBerry] Fix usage of BlackBerry::Platform::String
​https://bugs.webkit.org/show_bug.cgi?id=115781

Patch by Eli Fidler <​efidler@blackberry.com> on 2013-05-08
Reviewed by Rob Buis.

BlackBerry PRs 304193 and 327181
Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos

We currently have a problem where we're passing UTF-8 encoded data into
the char* constructors of BlackBerry::Platform::String. This means the string
thinks its data is not UTF-8.

Source/WebCore:

• platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::writeURL):
(WebCore::ClipboardBlackBerry::writePlainText):

• platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::getBackingStoreCookies):

• platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::CookieParser):
(WebCore::CookieParser::parseOneCookie):

• platform/blackberry/CursorBlackBerry.cpp:

(WebCore::Cursor::Cursor):

• platform/blackberry/PlatformBlob.cpp:

(WebCore::PlatformBlob::nextDataItem):

• platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:

(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::moveOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::copyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursivelyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readMetadataOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createFileOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::fileExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::directoryExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadataOnMainThread):

• platform/graphics/blackberry/ImageBlackBerry.cpp:

(WebCore::Image::loadPlatformResource):

• platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
(WebCore::toWebMediaStreamSource):
(WebCore::toWebMediaStreamDescriptor):

• platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

• platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):

• platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore::RSSFilterStream::notifyStatusReceived):
(WebCore::RSSFilterStream::notifyHeadersReceived):
(WebCore::RSSFilterStream::convertContentToHtml):
(WebCore::RSSFilterStream::charset):
(WebCore::RSSFilterStream::removeHeader):
(WebCore::RSSFilterStream::updateHeader):
(WebCore::RSSFilterStream::updateRSSHeaders):

• platform/network/blackberry/rss/RSSFilterStream.h:
• platform/text/blackberry/StringBlackBerry.cpp:

(WTF::String::operator BlackBerry::Platform::String):

Source/WebKit/blackberry:

• Api/JavaScriptVariant.cpp:

(BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):

• Api/WebKitTextCodec.cpp:

(BlackBerry::WebKit::base64Encode):

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::textEncoding):
(BlackBerry::WebKit::WebPage::textHasAttribute):
(BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):

• Api/WebPage.h:
• Api/WebSettings.cpp:

(BlackBerry::WebKit::WebSettings::standardSettings):

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):

• WebKitSupport/DefaultTapHighlight.cpp:

(WebKit):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
(BlackBerry::WebKit::DefaultTapHighlight::hide):

Tools:

• DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::dumpHistoryItem):

• DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::setUserStyleSheetLocation):

• DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:

(LoadHTMLStringItem::invoke):

3:02 PM Changeset in webkit [149768] by andersca@apple.com

• 6 edits in trunk/Source

Assert at compile time that we don't pass Objective-C object pointers to adoptCF
​https://bugs.webkit.org/show_bug.cgi?id=115823

Reviewed by Geoffrey Garen.

Source/WebCore:

• platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::TileController):
Use adoptNS for CALayer.

Source/WebKit2:

Fix adoptNS/adoptCF mismatches. For the adopt(leakRef()) case we'd ideally want a static_pointer_cast overload for RetainPtr,
but this will do for now.

• Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::decode):

Source/WTF:

static_assert in adoptCF that the object passed in is not an Objective-C object.

• wtf/RetainPtr.h:

2:56 PM Changeset in webkit [149767] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Tools: add new BlackBerry include dirs.
​https://bugs.webkit.org/show_bug.cgi?id=115514

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-08
Reviewed by Rob Buis.

iType include dirs are missing, and HarfBuzz needs to be fixed.

• Scripts/webkitdirs.pm:

(blackberryCMakeArguments):

1:53 PM Changeset in webkit [149766] by eric.carlson@apple.com

• 4 edits
  2 adds in trunk

TextTrackCue should support empty content
​https://bugs.webkit.org/show_bug.cgi?id=115821

Reviewed by Jer Noble.

Source/WebCore:

Test: media/track/track-cue-empty-text-crash.html

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Don't bother trying to render

cues with no content.

• html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::getCueAsHTML): Return early if there isn't a node tree.
(WebCore::TextTrackCue::createCueRenderingTree): Ditto.
(WebCore::TextTrackCue::determineTextDirection): Ditto.
(WebCore::TextTrackCue::updateDisplayTree): Return early if there isn't a cue rendering tree.

LayoutTests:

• media/track/track-cue-empty-text-crash-expected.txt: Added.
• media/track/track-cue-empty-text-crash.html: Added.

1:48 PM Changeset in webkit [149765] by weinig@apple.com

• 5 edits
  2 adds in trunk/Source/WebKit2

Add SPI to determine if a plugin is sandboxed
​https://bugs.webkit.org/show_bug.cgi?id=115810

Reviewed by Anders Carlsson.

• PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::initializeSandbox):

• Shared/Plugins/mac/PluginSandboxProfile.h: Added.
• Shared/Plugins/mac/PluginSandboxProfile.mm: Added.

(WebKit::pluginSandboxProfileDefaultDirectory):
(WebKit::pluginSandboxProfileDirectories):
(WebKit::pluginSandboxProfileName):
(WebKit::pluginSandboxCommonProfile):
(WebKit::pluginSandboxProfileForDirectory):
(WebKit::pluginSandboxProfile):
(WebKit::pluginHasSandboxProfileForDirectory):
(WebKit::pluginHasSandboxProfile):
Move sandbox code to its own file and refactor to use cocoa. Also adds pluginHasSandboxProfile function
which uses the newly refactored code.

• UIProcess/API/C/mac/WKContextPrivateMac.h:
• UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKPlugInInfoIsSandboxedKey):
(createInfoDictionary):
Add WKPlugInInfoIsSandboxedKey.

• WebKit2.xcodeproj/project.pbxproj:

Add new files.

1:45 PM Changeset in webkit [149764] by roger_fong@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed AppleWin build fix.

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:

(MediaPlayerPrivateAVFoundationCF):
(WebCore::MediaPlayerPrivateAVFoundationCF::currentTrack):

1:33 PM Changeset in webkit [149763] by rwlbuis@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

Fix some compiler warnings (miscellaneous)
​https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Rob Buis <​rbuis@rim.com> on 2013-05-08
Reviewed by Philip Rogers.

Get rid of the following warning for BlackBerry:

BackingStoreClient.cpp:54:21: warning: unused parameter 'parentFrame' [-Wunused-parameter]

by using ASSERT_UNUSED instead of ASSERT.

• WebKitSupport/BackingStoreClient.cpp:

(BlackBerry::WebKit::BackingStoreClient::create):

1:06 PM Changeset in webkit [149762] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Safari unexpectedly quits with invalid message from the web process with message ID 0x323002f (WebPageProxy.DecidePolicyForNavigationAction)
​https://bugs.webkit.org/show_bug.cgi?id=115814
<rdar://problem/12331258>

Reviewed by Andreas Kling.

To ensure that any asynchronous messages are delivered to the UI process before
synchronous messages (except when doing so would lead to a deadlock), Call
setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage on the UI process connections.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

1:02 PM Changeset in webkit [149761] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit2

Coalesce WKView visibleRect changes
​https://bugs.webkit.org/show_bug.cgi?id=115792
<rdar://problem/13776842>

Reviewed by Simon Fraser.

The system can call renewGState much more often than we actually want
to update the WebProcess' notion of the exposed rect. Most importantly,
within an autolayout pass it is called many times, and often sees
[WKView visibleRect] be an intermediate value which will never be
flushed to the screen. We only care about the final value, so we should
wait until AppKit has finished - with a zero-delay timer - to inform the
WebProcess of exposed rect changes.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Add exposedRectChangedTimer.
(WebKit::WebPageProxy::close):
Cancel exposedRectChangedTimer when tearing down the WebPageProxy.

• UIProcess/WebPageProxy.h:

(WebPageProxy):
Add exposedRectChangedTimerFired, the timer itself, and two rects:
the most recent exposed rect from the WKView, and the last one we actually
sent across to the WebProcess.

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::viewExposedRectChanged):
Instead of immediately sending exposed rect changes to the WebProcess,
start a zero-delay timer to do so.
(WebKit::WebPageProxy::exposedRectChangedTimerFired):
Once the zero-delay timer fires, send the new exposed rect to the WebProcess.

12:47 PM Changeset in webkit [149760] by andersca@apple.com

• 2 edits in trunk/Source/WTF

Remove RetainPtr::adoptNS and RetainPtr::adoptCF
​https://bugs.webkit.org/show_bug.cgi?id=115817

Reviewed by Jessie Berlin.

These functions are now unused so remove them. The preferred way to create a RetainPtr with an
adopted reference is to use the adoptNS/adoptCF free functions.

Rewrite the move assignment operators to just call CFRelease explicitly.

• wtf/RetainPtr.h:

12:39 PM Changeset in webkit [149759] by zandobersek@gmail.com

• 12 edits in trunk

[GTK] Plumb the Automake build system for the Battery Status API feature
​https://bugs.webkit.org/show_bug.cgi?id=115718

Reviewed by Martin Robinson.

.:

• Source/autotools/FindDependencies.m4: Check for the upower-glib dependency if the feature is enabled.
• Source/autotools/PrintBuildConfiguration.m4: Print out the feature status.
• Source/autotools/ReadCommandLineArguments.m4: Check for the --enable-battery-status option. The deafult,

when the option is not given, is to disable the feature.

• Source/autotools/SetupWebKitFeatures.m4: Treat the ENABLE_BATTERY_STATUS define as configurable.
• Source/autotools/symbols.filter: Export a couple of symbols that are used in the WebCore internals library.

Source/WebCore:

No new tests - no new functionality. The feature is not enabled yet, though all the relevant tests
pass when it is.

• GNUmakefile.am: Add the Modules/battery directory to the list of search paths for header inclusions.

Include the same directory under the IDL_PATH variable so the IDL files it contains are processed.
List these IDL files using a wildcard under the EXTRA_DIST list.

• GNUmakefile.list.am: Add the build targets for the module source files, IDLs and resulting JS bindings.
• bindings/gobject/GNUmakefile.am: Add the build targets for the GObject DOM bindings.

Tools:

• Scripts/webkitdirs.pm:

(buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
through the --(enable|disable)-battery-status flag passed to configure.

12:28 PM Changeset in webkit [149758] by Christophe Dumez

• 3 edits
  2 adds in trunk/LayoutTests

Add layout test that lists all global constructors
​https://bugs.webkit.org/show_bug.cgi?id=115724

Reviewed by Ryosuke Niwa.

Update fast/js/global-constructors-attributes.html so that it lists all
global constructors instead of just a few.

• fast/js/global-constructors-attributes-expected.txt:
• fast/js/script-tests/global-constructors-attributes.js:

(classNameForObject):
(constructorPropertiesOnWindow):

• platform/efl/fast/js/global-constructors-attributes-expected.txt: Added.
• platform/gtk/fast/js/global-constructors-attributes-expected.txt: Added.

12:26 PM Changeset in webkit [149757] by rniwa@webkit.org

• 2 edits in trunk/Tools

new-run-webkit-websocketserver doesn't work after Chromium removal
​https://bugs.webkit.org/show_bug.cgi?id=115816

Reviewed by Joseph Pecoraro.

Fix the bug by instantiating the correct port object.

• Scripts/new-run-webkit-websocketserver:

(main):

12:19 PM Changeset in webkit [149756] by roger_fong@apple.com

• 3 edits in trunk/LayoutTests

Unreviewed gardening, mac port.
These tests should use testRunner, not layoutTestController.

• fast/js/parse-error-external-script-in-eval.html:
• fast/js/parse-error-external-script-in-new-Function.html:

12:11 PM Changeset in webkit [149755] by roger_fong@apple.com

• 3 edits in trunk/Source/WebCore

Unreviewed. AppleWin VS2010 build fix.

• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:

11:54 AM Changeset in webkit [149754] by Darin Adler

• 4 edits in trunk

REGRESSION(r149700): fast/css-generated-content/close-quote-negative-depth.html
​https://bugs.webkit.org/show_bug.cgi?id=115776

Reviewed by Anders Carlsson.

Source/WebCore:

I changed depth to more closely match what is in the CSS3 specification.
There may be a more optimal way to make it work, but this seems the most straightforward.

• rendering/RenderQuote.cpp:

(WebCore::RenderQuote::RenderQuote): Initialize m_depth to -1 because that depth
is consistent with the empty string that is the initial value of the text. The
real depth will be calculated when the node is attached.
(WebCore::RenderQuote::originalText): Removed the "depth - 1" logic that
used to be done for close quotes. Instead, the updateDepth function now correctly
subtracts one for the close quote itself, not just afterward. Also added an early
exit when the depth is negative; these changes together fix the bug.
(WebCore::RenderQuote::attachQuote): Added a call to updateDepth even for the render
quote head, we now need that to set the depth either to 0 or to -1.
(WebCore::RenderQuote::detachQuote): Removed code to set m_depth to 0; if we are not
resetting the text then m_depth should be left matching the text, otherwise updateDepth
might not do its job correctly if the quote is later re-attached. What matters is that
m_depth and the text are in sync.
(WebCore::RenderQuote::updateDepth): Changed updating logic in two ways. First,
compute the depth in a local variable rather than computing it in a data member
after first saving off the old value of the data member. That's clearer style.
Second, add the code to change negative depths to zero when propagating to the
next quote in the chain, which matches how the standard is written, and decrement
the depth of the close quote itself, not the quote after the close quote.

LayoutTests:

• TestExpectations: Expect success again on this test.

11:52 AM Changeset in webkit [149753] by Lucas Forschler

• 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

Unreviewed. Fix duplicate builddir.

11:46 AM Changeset in webkit [149752] by Lucas Forschler

• 2 edits in trunk/Tools

Configure buildbot for 32bit builder.
​https://bugs.webkit.org/show_bug.cgi?id=115769

Reviewed by Ryosuke Niwa.

• BuildSlaveSupport/build.webkit.org-config/config.json:

11:19 AM Changeset in webkit [149751] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/13776220> 13A451: PluginProcess(2225) deny file-read-data ~/Library/InputManagers
<rdar://problem/13642510> PluginProcess logs sandbox violations initializing TextServices

Reviewed by Anders Carlsson.

• Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: Allow more TextServices and NSInputManager directories.

10:35 AM Changeset in webkit [149750] by bfulgham@webkit.org

• 2 edits in trunk/Tools

Unreviewed. Add my apple.com e-mail address to contributors.

10:16 AM Changeset in webkit [149749] by eric.carlson@apple.com

• 3 edits
  2 adds in trunk

Prevent crash when track is deleted during video element deletion.
​https://bugs.webkit.org/show_bug.cgi?id=106183

Reviewed by Dean Jackson.

Source/WebCore:

Test: media/track/track-remove-crash.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::removedFrom): Set m_inActiveDocument to false so we

do not process text track cues or dispatch related events.

LayoutTests:

• media/track/track-remove-crash-expected.txt: Added.
• media/track/track-remove-crash.html: Added.

10:03 AM Changeset in webkit [149748] by andersca@apple.com

• 1 edit
  1 delete in trunk/Source/WebKit2

Remove BinarySemaphoreWin.cpp.

Rubber-stamped by Beth Dakin.

BinarySemaphoreWin has been moved to WTF, but the original was never removed.

• Platform/CoreIPC/win/BinarySemaphoreWin.cpp: Removed.

9:54 AM Changeset in webkit [149747] by andersca@apple.com

• 1 edit
  1 delete in trunk/Source/WTF

Remove ThreadingNone.cpp

Rubber-stamped by Beth Dakin.

ThreadingNone.cpp is empty and not used anywhere.

• wtf/ThreadingNone.cpp: Removed.

9:52 AM Changeset in webkit [149746] by ddkilzer@apple.com

• 1 edit
  1 delete in trunk/LayoutTests

Remove chromium test results added in r149743

• platform/chromium/fast/js/parse-error-external-script-in-eval-expected.txt: Removed.
• platform/chromium/fast/js/parse-error-external-script-in-new-Function-expected.txt: Removed.

9:46 AM Changeset in webkit [149745] by ddkilzer@apple.com

• 2 edits in trunk/Tools

BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()

• DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(concatenateAttributeAndValue): Switch to appendVector().

9:41 AM Changeset in webkit [149744] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

[Mac] Unreviewed buildfix after r149741.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible):

9:33 AM Changeset in webkit [149743] by ddkilzer@apple.com

• 1 edit
  11 adds in trunk/LayoutTests

Add layout tests for test cases in Bug 5206
<​http://webkit.org/b/5206>

Reviewed by Eric Seidel.

These issues were likely fixed in r89257 for Bug 62613.

• fast/js/parse-error-external-script-in-eval-expected.txt: Added.
• fast/js/parse-error-external-script-in-eval.html: Added.
• fast/js/parse-error-external-script-in-new-Function-expected.txt: Added.

Note that the line number in this result is relative to the line
number of the second argument to the new Function() method.

• fast/js/parse-error-external-script-in-new-Function.html: Added.
• fast/js/resources/parse-error-external-script-in-eval.js: Added.
• fast/js/resources/parse-error-external-script-in-new-Function.js: Added.

• platform/chromium/fast/js/parse-error-external-script-in-eval-expected.txt: Added.
• platform/chromium/fast/js/parse-error-external-script-in-new-Function-expected.txt: Added.

9:17 AM Changeset in webkit [149742] by andersca@apple.com

• 2 edits in trunk/Source/WTF

Remove HashMap::deleteAllKeys
​https://bugs.webkit.org/show_bug.cgi?id=115806

Reviewed by Brent Fulgham.

This function was not used anywhere so let's get rid of it.

• wtf/HashMap.h:

9:06 AM Changeset in webkit [149741] by eric.carlson@apple.com

• 17 edits in trunk

[Mac] Inband text tracks are not in track menu on Lion
​https://bugs.webkit.org/show_bug.cgi?id=115740

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, covered by existing tests.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Remove m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_closedCaptionsVisible

to false immediately, it will be reset to the appropriate value if necessary.

(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.

• html/HTMLMediaElement.h:

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Remove

HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT) requirement. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
AVFOUNDATION_MEDIA_SELECTION_GROUP

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Ditto.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seek): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::trackModeChanged): Ditto.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Ditto.

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h: Ditto.
• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::kind): Don't look at media characteristics,

a legacy CC track is always Captions.

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isClosedCaptions): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::containsOnlyForcedSubtitles): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isMainProgramContent): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isEasyToRead): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label): Use different AVFoundation API on 10.7.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): AVFOUNDATION_TEXT_TRACK_SUPPORT ->

AVFOUNDATION_MEDIA_SELECTION_GROUP.

(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible): Do nothing. AVFOUNDATION_TEXT_TRACK_SUPPORT ->

AVFOUNDATION_MEDIA_SELECTION_GROUP.

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Support legacy CC tracks

only on 10.8. AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP

(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): AVFOUNDATION_TEXT_TRACK_SUPPORT ->

AVFOUNDATION_MEDIA_SELECTION_GROUP

Source/WTF:

• wtf/Platform.h: AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP

LayoutTests:

• platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt:

8:19 AM Changeset in webkit [149740] by sergio@webkit.org

• 3 edits
  2 adds in trunk

Allow blank spaces before colon (:) on CSS variable definition
​https://bugs.webkit.org/show_bug.cgi?id=115802

Reviewed by Darin Adler.

Source/WebCore:

Test: css3/css-variable-definition.html

Modified the grammar to allow blank spaces before the colon on CSS
variable definitions.

• css/CSSGrammar.y.in:

LayoutTests:

New test to check that spaces are allowed before the color on CSS
variable definitions.

• css3/css-variable-definition-expected.html: Added.
• css3/css-variable-definition.html: Added.

8:08 AM Changeset in webkit [149739] by mikhail.pozdnyakov@intel.com

• 2 edits in trunk/Source/WTF

HashTraits<RefPtr<P> >::peek should consider empty value
​https://bugs.webkit.org/show_bug.cgi?id=115799

Reviewed by Darin Adler.

HashTraits<RefPtr<P> >::peek() should consider passing of empty value which is
raw pointer equal to '0', and return it right away instead of converting it to RefPtr
and invoking get().

• wtf/HashTraits.h:

8:07 AM Changeset in webkit [149738] by mikhail.pozdnyakov@intel.com

• 2 edits in trunk/Source/WTF

Avoid unnecessary arguments copying inside GenericHashTraits methods
​https://bugs.webkit.org/show_bug.cgi?id=115733

Reviewed by Darin Adler.

Before the change both WTF::GenericHashTraits::passOut and WTF::GenericHashTraits::passOut
used to return the given argument always by value and that caused implicit extra
copying of the argument. It was OK as long as argument type T was POD, as compiler
could optimize it, but in case T was a class having non-trivial copy constructor the
extra copying of the argument could not have been obviated.

The proposed solution is to provide overloaded functions that accept non-temporary
values and return them by reference thus avoiding extra copying.

The proposed solution made an impact on the size of libjavascriptcore_efl.so (EFL
release build): the size decreased from 6554992 bytes to 6554560 bytes.

• wtf/HashTraits.h:

(WTF::GenericHashTraits::passOut):
(WTF::GenericHashTraits::peek):

7:36 AM Changeset in webkit [149737] by zarvai@inf.u-szeged.hu

• 1 edit
  16 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r149292.
​https://bugs.webkit.org/show_bug.cgi?id=115372

• platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/css-grid-layout/grid-item-change-column-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/css-grid-layout/grid-item-change-row-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/layer-full-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/overflow-flipped-writing-mode-table-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/reflection-table-layout-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-absolute-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-fixed-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-flipped-absolute-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-transformed-absolute-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-transformed-fixed-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/transform-table-layout-expected.txt: Added.
• platform/qt-5.0-wk2/svg/repaint/repaint-webkit-svg-shadow-container-expected.txt: Added.

7:28 AM WebKitGTK/2.0.x edited by kov@webkit.org

Adding a couple reasonably simple GStreamer backend fixes (diff)

6:44 AM Changeset in webkit [149736] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening
​https://bugs.webkit.org/show_bug.cgi?id=115791

Unreviewed EFL gardening

Skip fast/regions/ test cases which are failing after r149668.

Patch by Rijubrata Bhaumik <​rijubrata.bhaumik@intel.com> on 2013-05-08

• platform/efl/TestExpectations:

6:41 AM Changeset in webkit [149735] by kov@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer] Does memory buffering even with preload set to none
​https://bugs.webkit.org/show_bug.cgi?id=115754

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-05-08
Reviewed by Philippe Normand.

Covered by existing tests.

Revision 148840 fixed on-disk buffering being done when preload is set to none,
but memory buffering is still being done. That is because setting the state to
paused causes GStreamer to start loading the media, to gather information. Only
doing that when committing the load avoids that while maintaining the tested
behaviour unchanged.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load): move setting pause state to commitLoad.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): see above.

6:07 AM Changeset in webkit [149734] by akling@apple.com

• 2 edits in trunk/Source/WebCore

SVGStyledElement::getPresentationAttribute() does not need to be virtual.

From Blink r149888 by <​cevans@chromium.org>
<​http://src.chromium.org/viewvc/blink?view=revision&revision=149888>

• svg/SVGStyledElement.h:

6:00 AM Changeset in webkit [149733] by allan.jensen@digia.com

• 2 edits in trunk/Source/WebCore

Crash when loading link to audio file
​https://bugs.webkit.org/show_bug.cgi?id=115794

Reviewed by Jocelyn Turcotte.

Do not access a null pointer frame.

• loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):

5:56 AM Changeset in webkit [149732] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipping some failing fast/region tests.
​https://bugs.webkit.org/show_bug.cgi?id=115785

• platform/qt/TestExpectations:

5:20 AM Changeset in webkit [149731] by abecsi@webkit.org

• 2 edits in trunk/Tools

[Qt][WTR] Fix the build on Mac after r149692

Unreviewed build fix.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dumpDOMAsWebArchive):

4:54 AM Changeset in webkit [149730] by g.czajkowski@samsung.com

• 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip two spelling tests as they started passing after r149366.

• platform/efl-wk2/TestExpectations:

Unskip spelling-exactly-selected-word.html and
spelling-with-punctuation-selection.html

• platform/efl/TestExpectations:

Remove spelling tests from efl/TestExpectations as the failing tests
are already skipped for both efl-wk1 and global wk2.

3:59 AM Changeset in webkit [149729] by Christophe Dumez

• 20 edits in trunk/Source/WebCore

Remove unused [TransferList] extended attribute
​https://bugs.webkit.org/show_bug.cgi?id=115788

Reviewed by Kentaro Hara.

Remove [TransferList] extended attribute and corresponding tests as it has no
effect on the generated JSC bindings.

No new tests, no behavior change.

• bindings/scripts/IDLAttributes.txt:
• bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:

(WebDOMTestSerializedScriptValueInterface):

• bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
• bindings/scripts/test/CPP/WebDOMTestTypedefs.h:

(WebDOMTestTypedefs):

• bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
• bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(JSTestSerializedScriptValueInterfacePrototype):
(JSTestSerializedScriptValueInterfaceConstructor):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestTypedefs.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
• bindings/scripts/test/ObjC/DOMTestTypedefs.h:
• bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
• bindings/scripts/test/TestSerializedScriptValueInterface.idl:
• bindings/scripts/test/TestTypedefs.idl:

3:38 AM Changeset in webkit [149728] by mario@webkit.org

• 3 edits in trunk/Tools

Unreviewed. Added Anton Obzhirov to the list of contributors and myself
to the watchlist for Accessibility.

• Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
• Scripts/webkitpy/common/config/watchlist: Added myself.

3:37 AM WebKitIDL edited by Christophe Dumez

Remove [TransferList] (diff)

3:16 AM Changeset in webkit [149727] by sudarsana.nagineni@linux.intel.com

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip remaining Shadow DOM tests on the EFL port.

• platform/efl/TestExpectations:

2:50 AM Changeset in webkit [149726] by abecsi@webkit.org

• 2 edits in trunk/Tools

[Qt] Build fails with clang
​https://bugs.webkit.org/show_bug.cgi?id=115741

Reviewed by Benjamin Poulain.

Since r149112 std::move is used in AtomicString for compilers that
support rvalue references and this requires a standard library
implementing c++11 move semantics.
We only explicitely require c++11 for WebKit2, but since clang supports
rvalue references the build of subtargets using AtomicString fails because
of missing std::move.
It is safe to add CONFIG += c++11 for the whole project when using clang
since we explicitely disable c++11 for ANGLE that had probems with libc++.

• qmake/mkspecs/features/unix/default_pre.prf:

2:41 AM Changeset in webkit [149725] by Darin Adler

• 3 edits in trunk/Tools

Fix one more place that needed to use adoptCF/NS
​https://bugs.webkit.org/show_bug.cgi?id=115778

Reviewed by Benjamin Poulain.

Not sure why I missed this code last time, but found a bit more code that needs
to switch to the newer style adoptCF/NS.

• WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:

(convertWebResourceDataToString): Use adoptCF.
(convertWebResourceResponseToDictionary): Ditto.
(createXMLStringFromWebArchiveData): Ditto.

• WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:

(createCFURLResponseFromResponseData): Use adoptNS and adoptCF.

2:23 AM Changeset in webkit [149724] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Adding failure expectations for CSS Regions tests

that regressed when converted into reftests in r149668.

1:55 AM Changeset in webkit [149723] by commit-queue@webkit.org

• 7 edits in trunk

Make optional arguments in CanvasRenderingContext2D match the spec.
​https://bugs.webkit.org/show_bug.cgi?id=115723

Patch by Dongseong Hwang <​dongseong.hwang@intel.com> on 2013-05-08
Reviewed by Dean Jackson.

Source/WebCore:

WebKit r98985 set many arguments optional although the canvas spec[1] does not
indicate. So this patch corrects CanvasRenderingContext2D.idl to match the spec.

[1] ​http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas/

Covered by existing tests:

canvas/philip/tests/2d.missingargs.html
fast/canvas/canvas-overloads-strokeRect.html
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html

• html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

When tests use <canvas> API with not enough arguments, TypeError
exception is fired now. So three tests are changed to match the canvas
spec.

• fast/canvas/canvas-overloads-strokeRect-expected.txt:
• fast/canvas/script-tests/canvas-overloads-strokeRect.js:
• platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:

1:54 AM WebKitIDL edited by Christophe Dumez

Rename JSCustomIsReachable to CustomIsReachable and … (diff)

1:50 AM WebKitIDL edited by Christophe Dumez

Remove JSCustomHeader (diff)

1:48 AM WebKitIDL edited by Christophe Dumez

Remove remaining mentions of V8 (diff)

1:45 AM WebKitIDL edited by Christophe Dumez

Remove V8DoNotCheckSignature (diff)

1:45 AM WebKitIDL edited by Christophe Dumez

Remove V8CustomIsReachable (diff)

1:43 AM WebKitIDL edited by Christophe Dumez

Remove [URL] (diff)

1:42 AM WebKitIDL edited by Christophe Dumez

Remove V8GenerateIsReachable and JSGenerateIsReachable (diff)

1:40 AM WebKitIDL edited by Christophe Dumez

Remove V8DependentLifeTime (diff)

1:39 AM WebKitIDL edited by Christophe Dumez

Remove V8CustomIndexedGetter (diff)

1:38 AM WebKitIDL edited by Christophe Dumez

Remove dead section from TOC (diff)

1:36 AM WebKitIDL edited by Christophe Dumez

Remove V8EnabledAtRuntime, V8EnabledPerContext from TOC (diff)

1:35 AM WebKitIDL edited by Christophe Dumez

Remove V8Unforgeable and V8OnProto (diff)

1:33 AM WebKitIDL edited by Christophe Dumez

Remove V8ReadOnly (diff)

1:29 AM WebKitIDL edited by Christophe Dumez

Remove mentions of JSCustom and V8Custom (diff)

1:28 AM Changeset in webkit [149722] by zandobersek@gmail.com

• 2 edits in trunk/Tools

Unreviewed, rolling out r149271.
​http://trac.webkit.org/changeset/149271
​https://bugs.webkit.org/show_bug.cgi?id=115780

The mangled symbols are now enforced through LDFLAGS
(Requested by zdobersek on #webkit).

Patch by Commit Queue <​commit-queue@webkit.org> on 2013-05-08

• BuildSlaveSupport/gtk/daemontools-buildbot.conf:

1:19 AM WebKitIDL edited by Christophe Dumez

Rename V8SkipVTableValidation to SkipVTableValidation (diff)

1:16 AM WebKitIDL edited by Christophe Dumez

Remove mentions of toV8() (diff)

1:14 AM Changeset in webkit [149721] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
​https://bugs.webkit.org/show_bug.cgi?id=115636

Reviewed by Ryosuke Niwa.

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
while Chromium-specific, can't be removed just yet as there's more code that uses it.

1:14 AM WebKitIDL edited by Christophe Dumez

Use more monospace (diff)

1:06 AM Changeset in webkit [149720] by zandobersek@gmail.com

• 6 edits in trunk/Source/WebKit2

[WK2] Make the WebNetworkInfoManager a supplement to the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=115716

Reviewed by Andreas Kling.

WebNetworkInfoManager should inherit from WebProcessSupplement and should be used
as such by the WebProcess. This removes the need for the m_networkInfoManager member
variable in the WebProcess class and brings the WebNetworkInfoManager in line with
other manager classes of which instances are controlled by the WebProcess class.

• WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:

(WebKit::WebNetworkInfoManager::supplementName): Specify the supplement's name.
(WebKit):

• WebProcess/NetworkInfo/WebNetworkInfoManager.h:

(WebKit): Alphabetically reorder the two forwarding declarations.
(WebNetworkInfoManager): Inherit from the WebProcessSupplement interface.

• WebProcess/WebCoreSupport/WebNetworkInfoClient.cpp:

(WebKit::WebNetworkInfoClient::bandwidth): Access the WebNetworkInfoManager as a supplement.
(WebKit::WebNetworkInfoClient::metered): Ditto.
(WebKit::WebNetworkInfoClient::startUpdating): Ditto.
(WebKit::WebNetworkInfoClient::stopUpdating): Ditto.
(WebKit::WebNetworkInfoClient::networkInfoControllerDestroyed): Ditto.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Add the WebNetworkInfoManager instance as a supplement.

• WebProcess/WebProcess.h:

(WebProcess): Remove the m_networkInfoManager member variable and its getter method.

1:02 AM Changeset in webkit [149719] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/efl

[EFL] Correct documentation for ewk_settings APIs
​https://bugs.webkit.org/show_bug.cgi?id=115507

Patch by Jose Lejin PJ <​jose.lejin@gmail.com> on 2013-05-08
Reviewed by Gyuyoung Kim.

Corrected documentation for ewk_settings APIs.

• ewk/ewk_settings.h:

1:01 AM WebKitIDL edited by Christophe Dumez

Use more monospace (diff)

12:58 AM Changeset in webkit [149718] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Remove unused method and de-virtualize others in Element.h
​https://bugs.webkit.org/show_bug.cgi?id=115770

Reviewed by Andreas Kling.

Merge ​https://chromium.googlesource.com/chromium/blink/+/c2c2ff9cb69f46f5cc9d289b2bfbdb8ab5bd3e49

The de-virtualization possibilities were noted whilst "FINALizing" the Node
hierarchy. If a method is successfully marked FINAL but then fails when marked
OVERRIDE as well, the method by definition does not need to be virtual.

• WebCore.exp.in:
• dom/Element.h:

(WebCore::Element::hasAuthorShadowRoot):

12:52 AM WebKitIDL edited by Christophe Dumez

Use more monospace (diff)

12:51 AM Changeset in webkit [149717] by zandobersek@gmail.com

• 6 edits in trunk/Source/WebKit2

[WK2] Make the WebBatteryManager a supplement to the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=115715

Reviewed by Andreas Kling.

WebBatteryManager should inherit from WebProcessSupplement and should be used as such
by the WebProcess. This removes the need for the m_batteryManager member variable in
the WebProcess class and brings the WebBatteryManager in line with other manager classes
of which instances are controlled by the WebProcess class.

• WebProcess/Battery/WebBatteryManager.cpp:

(WebKit::WebBatteryManager::supplementName): Specify the supplement's name.
(WebKit):

• WebProcess/Battery/WebBatteryManager.h:

(WebBatteryManager): Inherit from the WebProcessSupplement interface.

• WebProcess/WebCoreSupport/WebBatteryClient.cpp:

(WebKit::WebBatteryClient::startUpdating): Access the WebBatteryManager as a supplement.
(WebKit::WebBatteryClient::stopUpdating): Ditto.
(WebKit::WebBatteryClient::batteryControllerDestroyed): Ditto.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Add the WebBatteryManager instance as a supplement.

• WebProcess/WebProcess.h:

(WebProcess): Remove the m_batteryManager member variable and its getter method.

12:44 AM WebKitIDL edited by Christophe Dumez

Use more monospace (diff)

12:40 AM Changeset in webkit [149716] by Darin Adler

• 94 edits in trunk

Source/WebCore: Use adoptCF and adoptNS in more places
​https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.

• platform/cf/win/CertificateCFWin.cpp:

(WebCore::copyCertificateToData):

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMinTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeLoaded):
(WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes):
(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged):
(WebCore::AVFWrapper::createAssetForURL):
(WebCore::AVFWrapper::createPlayer):
(WebCore::AVFWrapper::createPlayerItem):
(WebCore::AVFWrapper::setAsset):
(WebCore::AVFWrapper::platformLayer):
(WebCore::AVFWrapper::createAVCFVideoLayer):
(WebCore::AVFWrapper::createImageGenerator):

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::language):

• platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(toCACFTimingFunction):
(PlatformCAAnimation::PlatformCAAnimation):
(PlatformCAAnimation::setFromValue):
(PlatformCAAnimation::setToValue):
(PlatformCAAnimation::setValues):
(PlatformCAAnimation::setKeyTimes):
(PlatformCAAnimation::setTimingFunctions):

• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::setBackgroundColor):
(PlatformCALayer::setBorderColor):

• platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::PlatformCALayerWinInternal):
(PlatformCALayerWinInternal::addTile):

• platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:

(WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost):

• platform/graphics/gstreamer/PlatformVideoWindowMac.mm:

(PlatformVideoWindow::PlatformVideoWindow):

• platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

• platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::getPostScriptName):
(WebCore::FontPlatformData::platformDataInit):

• platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawWindowsBitmap):

• platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::create):

• platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):

• platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::rfc2616DateStringFromTime):
(WebCore::QTCFDictionaryCreateWithDataCallback):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):

• platform/graphics/win/WKCAImageQueue.cpp:

(WebCore::WKCAImageQueue::WKCAImageQueue):

• platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::qcmsOutputDeviceProfile):

• platform/network/cf/AuthenticationCF.cpp:

(WebCore::core):

• platform/network/cf/CookieJarCFNet.cpp:

(WebCore::cookieDomain):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):
(WebCore::filterCookies):
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::certificatePath):

• platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::urlFromPath):
(WebCore::getURL):

• platform/win/LocalizedStringsWin.cpp:

(WebCore::createWebKitBundle):
(WebCore::localizedString):

• platform/win/SearchPopupMenuWin.cpp:

(WebCore::SearchPopupMenuWin::saveRecentSearches):
(WebCore::SearchPopupMenuWin::loadRecentSearches):

• plugins/mac/PluginPackageMac.cpp:

(WebCore::stringListFromResourceId):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):

• plugins/mac/PluginViewMac.mm:

(WebCore::PluginView::platformStart):

• rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::platformFocusRingColor):
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):
Use adoptCF and adoptNS throughout.

Source/WebKit/win: Use adoptCF and adoptNS in more places
​https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.

• CFDictionaryPropertyBag.cpp:

(CFDictionaryPropertyBag::Write):

• WebCache.cpp:

(WebCache::statistics):

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidFailToStartPlugin):

• WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::localizedStringsURL):

• WebDatabaseManager.cpp:

(WebDatabaseManager::dispatchDidModifyDatabase):

• WebDownloadCFNet.cpp:

(WebDownload::init):
(WebDownload::initWithRequest):
(WebDownload::initToResumeWithBundle):
(WebDownload::cancelForResume):
(WebDownload::useCredential):
(WebDownload::didReceiveAuthenticationChallenge):

• WebError.cpp:

(WebError::sslPeerCertificate):

• WebHistory.cpp:

(createUserInfoFromArray):
(createUserInfoFromHistoryItem):
(WebHistory::WebHistory):
(WebHistory::loadFromURL):
(WebHistory::loadHistoryGutsFromURL):
(WebHistory::saveToURL):
(WebHistory::saveHistoryGuts):
(WebHistory::removeAllItems):
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::itemForURL):
(WebHistory::addItemToDateCaches):
(getDayBoundaries):

• WebIconDatabase.cpp:

(postDidAddIconNotification):

• WebLocalizableStrings.cpp:

(cfBundleForStringsBundle):

• WebMutableURLRequest.cpp:

(WebMutableURLRequest::mutableCopy):

• WebPreferences.cpp:

(cfNumber):
(WebPreferences::initializeDefaultSettings):
(WebPreferences::valueForKey):
(WebPreferences::setStringValue):
(WebPreferences::load):
(WebPreferences::migrateWebKitPreferencesToCFPreferences):
(WebPreferences::setPreferenceForTest):

• WebView.cpp:

(WebView::setCacheModel):
(WebView::notifyPreferencesChanged):
Use adoptCF and adoptNS.

Source/WebKit2: Use adoptCF and adoptNS in more places
​https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

• Shared/Downloads/cfnet/DownloadCFNet.cpp:

(WebKit::Download::useCredential):
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::didDecideDestination):
Use adoptCF and adoptNS.

Tools: Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
​https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.

• DumpRenderTree/cf/WebArchiveDumpSupport.cpp:

(convertWebResourceDataToString):
(convertWebResourceResponseToDictionary):
(createXMLStringFromWebArchiveData):

• DumpRenderTree/cg/ImageDiffCG.cpp:

(createImageFromStdin):
(createDifferenceImage):
(main):

• DumpRenderTree/cg/PixelDumpSupportCG.cpp:

(printPNG):
(dumpBitmap):

• DumpRenderTree/cg/PixelDumpSupportCG.h:

(BitmapContext::BitmapContext):

• DumpRenderTree/mac/MockWebNotificationProvider.mm:

(-[MockWebNotificationProvider init]):

• DumpRenderTree/mac/PixelDumpSupportMac.mm:

(createBitmapContext):

• DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::addDisallowedURL):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::localStorageDiskUsageForOrigin):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::copyDecodedHostName):
(TestRunner::copyEncodedHostName):
(TestRunner::queueLoad):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setValueForUser):
(TestRunner::overridePreference):
(TestRunner::setPersistentUserStyleSheetLocation):
(TestRunner::execCommand):
(TestRunner::findString):
(TestRunner::isCommandEnabled):
(TestRunner::addOriginAccessWhitelistEntry):
(TestRunner::removeOriginAccessWhitelistEntry):
(TestRunner::addUserScript):
(TestRunner::addUserStyleSheet):
(TestRunner::evaluateInWebInspector):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::apiTestNewWindowDataLoadBaseURL):
(-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
(TestRunner::authenticateSession):
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):

• DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:

(createCFURLResponseFromResponseData):

• DumpRenderTree/mac/WorkQueueItemMac.mm:

(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(ScriptItem::invoke):

• DumpRenderTree/win/DumpRenderTree.cpp:

(substringFromIndex):
(urlSuitableForTestResult):
(lastPathComponent):
(sharedCFURLCache):

• DumpRenderTree/win/ImageDiffCairo.cpp:

(createImageFromStdin):
(main):

• DumpRenderTree/win/PixelDumpSupportWin.cpp:

(createBitmapContextFromWebView):

• DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setUserStyleSheetLocation):
(TestRunner::setPersistentUserStyleSheetLocation):

• TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/FindMatches.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):

• TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:

(TestWebKitAPI::createWindow):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:

(TestWebKitAPI::AcceptsFirstMouse::runTest):

• TestWebKitAPI/Tests/mac/AttributedString.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/BackForwardList.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:

(TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):

• TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:

(TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):

• TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/InspectorBar.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:

(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):

• TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/SetDocumentURI.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::MIMETypeForWKURLResponse):

• TestWebKitAPI/mac/WebKitAgnosticTest.mm:

(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):

• WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:

(WTR::testPathFromURL):

• WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:

(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):

• WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromImage):
(WTR::dumpBitmap):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

• WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::mouseScrollBy):

• WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::windowSnapshotImage):

• WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::initializeTestPluginDirectory):
Use adoptCF and adoptNS.

12:36 AM WebKitIDL edited by Christophe Dumez

Start using monospace for IDL extended attributes (diff)

12:24 AM WebKitIDL edited by Christophe Dumez

Remove deprecated "in" keyword from IDL examples (diff)

12:05 AM Changeset in webkit [149715] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Add an image only failure expectation to fast/css-generated-content/close-quote-negative-depth.html per
bug 115776 after r149700. r149707 tried to fix its regression but this test is still failing.

• TestExpectations:

12:04 AM WebKitIDL edited by Christophe Dumez

Update documentation for optional and [Default] (diff)

12:03 AM Changeset in webkit [149714] by zandobersek@gmail.com

• 2 edits in trunk

[Automake] Pass --no-demangle to the linker by default to get the mangled symbols
​https://bugs.webkit.org/show_bug.cgi?id=115732

Reviewed by Gustavo Noronha Silva.

• GNUmakefile.am: Pass the --no-demangle option to the linker by default. This is done by appending

the flag to the LDFLAGS variable. While the AM_LDFLAGS variable would be more appropriate, it's not
at all used when linking installable libraries like libwebkitgtk and libwebkit2gtk, so the LDFLAGS
variable is used instead.

12:00 AM Changeset in webkit [149713] by mrowe@apple.com

• 2 edits in trunk/Source/WebKit/mac

<rdar://problem/13633007> WebKit and others fail to build headers due to build root dependency

Reviewed by Sam Weinig.

• Configurations/WebKit.xcconfig: Look for WebCore's headers within the SDK if we're building against one.