Timeline
May 14, 2013:
- 11:42 PM Changeset in webkit [150102] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r147548): Broken comboboxes
https://bugs.webkit.org/show_bug.cgi?id=115475
Reviewed by Gustavo Noronha Silva.
The problem is that r147548 made the popup to be closed when a
blur event is received. Right before showing the popup the input
element is focused, so that after the the popup is shown the focus
event is emitted and the event handler is called again hiding the
popup.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Check
element has lost the focus before closing the popup menu.
- 9:35 PM Changeset in webkit [150101] by
-
- 5 edits in trunk
Printing in 1Password app is broken with screen fonts disabled
https://bugs.webkit.org/show_bug.cgi?id=116133
-and corresponding-
<rdar://problem/13162981>
Reviewed by Anders Carlsson.
Source/WebKit/mac:
Return YES from [WebPreferences screenFontSubstitutionEnabled] for versions of the
1Password app that were linked on or before MountainLion.
- WebView/WebPreferences.mm:
(needsScreenFontsEnabledQuirk):
(-[WebPreferences screenFontSubstitutionEnabled]):
WebKitLibraries:
Need WKExecutableWasLinkedOnOrBeforeMountainLion() for this quirk.
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 9:27 PM Changeset in webkit [150100] by
-
- 7 edits in trunk/Source/WebCore
[Mac] Move setDragImage from ClipboardMac to PasteboardMac
https://bugs.webkit.org/show_bug.cgi?id=116036
Reviewed by Anders Carlsson.
- dom/Clipboard.cpp:
(WebCore::Clipboard::~Clipboard): Stop loading the drag image when
the clipboard object is deallocated. It would be better if there was
a more-well-defined time to stop the load.
(WebCore::Clipboard::setDragImage): Added. Sets up a drag image
based on a CachedImage. This tells the image loader to load the image
and updates the drag image when the image arrives. Copied from the
code in ClipboardMac, but refactored to use a separate loader object.
(WebCore::Clipboard::setDragImageElement): Added. Sets up a drag image
based on an element.
(WebCore::Clipboard::updateDragImage): Added. Common code to update
drag image when a new one is set or when a drag image load completes.
(WebCore::DragImageLoader::create): Added.
(WebCore::DragImageLoader::DragImageLoader): Ditto.
(WebCore::DragImageLoader::startLoading): Ditto.
(WebCore::DragImageLoader::stopLoading): Ditto.
(WebCore::DragImageLoader::imageChanged): Ditto.
- dom/Clipboard.h: Made setDragImage and setDragImageElement non-virtual
for non-legacy. Added updateDragImage and m_dragImageLoader.
- platform/Pasteboard.h: Added setDragImage function.
- platform/mac/ClipboardMac.h: Removed CachedImageClient as a base class
for ClipboardMac. Removed setDragImage and setDragImageElement.
- platform/mac/ClipboardMac.mm: Removed setDragImage and setDragImageElement.
(WebCore::ClipboardMac::~ClipboardMac): Removed code to remove self as
client loading the drag image. This is now in the Clipboard base class.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::setDragImage): Added. Contains code moved here
from ClipboardMac.
- 8:17 PM Changeset in webkit [150099] by
-
- 2 edits in trunk/Source/WebCore
Use ElementTraversal in SelectorDataList::execute
https://bugs.webkit.org/show_bug.cgi?id=116131
Reviewed by Darin Adler.
Use ElementTraversal::firstWithin and ElementTraversal::next to simplify the code.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::execute):
- 7:18 PM Changeset in webkit [150098] by
-
- 2 edits in trunk/Tools
Fix build after r150090.
https://bugs.webkit.org/show_bug.cgi?id=116129
Unreviewed build fix after r150090.
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-05-14
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
- 7:17 PM Changeset in webkit [150097] by
-
- 6 edits in trunk/LayoutTests
[CSS Exclusions] Some layout tests fail to account for inline pixel snapping
https://bugs.webkit.org/show_bug.cgi?id=116115
Reviewed by Dirk Schulze.
Adjust the expected locations of spans to account for the fact that inline layout snaps boxes' logical top
and bottom to pixels, and the fact that line segment layout rounds the logical left and floors the logical
right of segments.
- fast/exclusions/shape-inside/shape-inside-polygon-layout.html: Use the quiet variable!
- fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-expected.txt:
- fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html:
- fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html:
- fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:
- 6:20 PM Changeset in webkit [150096] by
-
- 2 edits in trunk/Tools
[Windows, others] Unreviewed build fix after r150090.
- DumpRenderTree/TestRunner.cpp:
(getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
doesn't exist on other platforms.
- 6:00 PM Changeset in webkit [150095] by
-
- 3 edits in trunk/Tools
[Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
https://bugs.webkit.org/show_bug.cgi?id=115889
Patch by Brent Fulgham <bfulgham@webkit.org> on 2013-05-14
Reviewed by Benjamin Poulain.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
- DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
- 5:27 PM Changeset in webkit [150094] by
-
- 2 edits in trunk/Source/WebKit2
Add a preference that can disable the fake SYSV SHM shim
https://bugs.webkit.org/show_bug.cgi?id=116127
<rdar://problem/13810524>
Patch by Simon Cooper <scooper@apple.com> on 2013-05-14
Reviewed by Alexey Proskuryakov.
- PluginProcess/mac/PluginProcessShim.mm:
(WebKit::shim_disabled):
(WebKit::shim_shmdt):
(WebKit::shim_shmat):
(WebKit::shim_shmget):
(WebKit::shim_shmctl):
- 5:18 PM Changeset in webkit [150093] by
-
- 5 edits in trunk/Source
[wk2] Not updating tiled backing coverage when main frame scrollability changes
https://bugs.webkit.org/show_bug.cgi?id=116123
<rdar://problem/13836559>
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
Add updateMainFrameClipsToExposedRect.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
Remove m_clipsToExposedRect. We don't actually need it.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
Call updateMainFrameClipsToExposedRect so that we can always update
tiled backing coverage and can factor out our calls to setClipsToExposedRect.
(WebKit::TiledCoreAnimationDrawingArea::updateMainFrameClipsToExposedRect):
Factor out setClipsToExposedRect calls to here, and also call
FrameView::adjustTiledBackingCoverage so that the FrameView's tiled
backing is informed to allow overdraw in the UI-process-scrolling case.
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
Use updateMainFrameClipsToExposedRect.
Export FrameView::adjustTiledBackingCoverage.
- WebCore.exp.in:
- 5:15 PM Changeset in webkit [150092] by
-
- 2 edits in trunk/Tools
[Windows] Identify proper run environment for scripts.
https://bugs.webkit.org/show_bug.cgi?id=116114
Reviewed by David Kilzer.
Determine (based on Visual Studio version) which path to use for
executables (bin versus bin32).
- Scripts/webkitdirs.pm:
(determineVisualStudioInstallDir): Added.
(determineVisualStudioVersion): Added.
(determineConfigurationProductDir): Modified to choose proper bin
or bin32 directory.
(visualStudioVersion): Added
(setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
- 3:40 PM Changeset in webkit [150091] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Improve Fatfinger phase.
https://bugs.webkit.org/show_bug.cgi?id=107403
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-14
Reviewed by Rob Buis.
Internally reviewed by Genevieve Mak.
BlackBerry PR 324965.
Cache and reuse intersected nodes as long as hit position has not been
changed.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::findIntersectingRegions):
(BlackBerry::WebKit::FatFingers::getNodesFromRect):
- WebKitSupport/FatFingers.h:
- 3:20 PM Changeset in webkit [150090] by
-
- 15 edits13 adds in trunk
[Mac] Add tests for secure event input
https://bugs.webkit.org/show_bug.cgi?id=116121
Reviewed by Mark Rowe.
- editing/secure-input: Added.
- editing/secure-input/password-input-changed-type-expected.txt: Added.
- editing/secure-input/password-input-changed-type.html: Added.
- editing/secure-input/password-input-focusing-expected.txt: Added.
- editing/secure-input/password-input-focusing-to-different-frame-expected.txt: Added.
- editing/secure-input/password-input-focusing-to-different-frame.html: Added.
- editing/secure-input/password-input-focusing.html: Added.
- editing/secure-input/removed-password-input-expected.txt: Added.
- editing/secure-input/removed-password-input.html: Added.
- editing/secure-input/reset-state-on-navigation-expected.txt: Added.
- editing/secure-input/reset-state-on-navigation.html: Added.
- editing/secure-input/resources: Added.
- editing/secure-input/resources/reset-state-on-navigation-target.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 3:08 PM Changeset in webkit [150089] by
-
- 9 edits1 move2 adds in trunk
[Mac] Add a testing shim for secure event input functions
https://bugs.webkit.org/show_bug.cgi?id=116122
Reviewed by Mark Rowe.
Added a new target with a dynamic library that interposes secure event input functions.
We need this to avoid interfering with user session state.
- Configurations/WebCoreTestShim.xcconfig: Added.
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/DynamicLinkerInterposing.h: Moved from Source/WebKit2/Shared/mac/DyldInterpose.h.
- testing/WebCoreTestShimLibrary.cpp: Added. (shimEnableSecureEventInput): (shimDisableSecureEventInput): (shimIsSecureEventInputEnabled):
- 2:14 PM Changeset in webkit [150088] by
-
- 4 edits in trunk/Source/WebCore
Get rid of Gradient::getColor()
https://bugs.webkit.org/show_bug.cgi?id=116089
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-14
Reviewed by Andreas Kling.
This code is now useless, remove it.
- html/canvas/CanvasGradient.h:
(CanvasGradient):
- platform/graphics/Gradient.cpp:
(WebCore::Gradient::Gradient):
(WebCore::Gradient::hash):
- platform/graphics/Gradient.h:
(Gradient):
- 1:37 PM Changeset in webkit [150087] by
-
- 5 edits2 adds in trunk
Source/WebCore: REGRESSION: united.com has overlapping elements and is broken by flex box changes.
https://bugs.webkit.org/show_bug.cgi?id=115329
<rdar://problem/13690610>
The new flexbox spec says that flex-basis omitted in the flex shorthand defaults to
0 when flex-grow/shrink are set. This has undesirable behavior when objects don't
end up flexing at all, and it's something the spec is going to eventually address.
For now, though, to fix the regression, I'm making a targeted "hack" to deliberately
violate the spec, but to do so as minimally as possible. This hack detects if there
is infinite available space on a line, and if so, it treats a flex-basis of 0 like
auto.
This means that when height is constrained and set by a container, flexing will do
the right thing. Basically any time you end up actually flexing, the spec behavior
should happen. If you're just laying out at intrinsic sizes, though, and no flexing
is going to occur, we ignore a flex-basis of 0 and just use the child's normal size.
Note that widths don't have to be patched because the preferred logical widths
algorithm is broken right now and not checking flex-basis. If it did, we'd have seen
the same bug in the width direction.
This width issue is covered by https://bugs.webkit.org/show_bug.cgi?id=116117
Reviewed by Simon Fraser.
Added fast/flexbox/auto-height-with-flex.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisContentExtent):
Make sure we return LayoutUnit::max when you have infinite free space and not
max - borderPadding.
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
Only clear override size if it was set. Only mark for relayout if we did
an override size clear (i.e., if we were actually flexed). Add a new parameter,
hasInfiniteLineLength, that - if set - causes us to special case flex-basis:0
and treat it like flex-basis:auto.
(WebCore::RenderFlexibleBox::layoutFlexItems):
Define hasInfiniteLineLength and pass it to all the functions that need it.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
Remove the code that marks for layout and does a layout so early. This code
is moving (and changing) to preferredMainAxisContentExtentForChild.
(WebCore::RenderFlexibleBox::computeNextFlexLine):
Computes whether or not we have infinite line length now.
(WebCore::RenderFlexibleBox::freezeViolations):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
Propagate hasInfiniteLineLength through to preferredMainAxisContentExtentForChild.
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
Add hasInfiniteLineLength parameter to a bunch of functions.
LayoutTests: REGRESSION (r147261): Many overlaid elements on united.com's account page
https://bugs.webkit.org/show_bug.cgi?id=116107
<rdar://problem/13690610>
Reviewed by Simon Fraser.
- fast/flexbox/auto-height-with-flex-expected.html: Added.
- fast/flexbox/auto-height-with-flex.html: Added.
- 1:37 PM Changeset in webkit [150086] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Segfault in jsc with simple test program when running with profile dumping enabled
https://bugs.webkit.org/show_bug.cgi?id=116082
It's crashing because CodeBlock::baselineVersion() doesn't know how to handle the case where 'this' is the
baseline version but it hasn't been assigned to the m_blahCodeBlock field in BlahExecutable. The fix is to
check if we're the baseline version in baselineVersion() and return this if so.
Reviewed by Filip Pizlo.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::baselineVersion):
- 1:22 PM Changeset in webkit [150085] by
-
- 4 edits in trunk/Source/WebCore
Assertion failure in GlyphPage::setGlyphDataForIndex: (!glyph fontData == m_fontDataForAllGlyphs) <http://webkit.org/b/116113>
<rdar://problem/13833790>
Reviewed by Dan Bernstein.
If we're filling a full GlyphPage with a SimpleFontData that is actually a composite font reference,
we need to make sure we have per-glyph font data pointers, since it may end up using them.
Added GlyphPage::mayUseMixedFontDataWhenFilling() which can be implemented by the platform to let
GlyphPageTreeNode know that it should allocate a full-sized GlyphPage for mixed font data pointers
in case the font is a composite font reference, or if there are CJK ideographs in the text.
This code can be made smarter, but that's outside the scope of this change.
Fixes heavy asserting on bots running unreleased software.
- platform/graphics/GlyphPage.h:
(GlyphPage):
(WebCore::GlyphPage::mayUseMixedFontDataWhenFilling):
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::shouldUseCoreText):
(WebCore::GlyphPage::mayUseMixedFontDataWhenFilling):
- 1:09 PM Changeset in webkit [150084] by
-
- 4 edits2 adds in trunk
Heap-use-after-free in WebCore::RenderBox::exclusionShapeOutsideInfo
https://bugs.webkit.org/show_bug.cgi?id=115566
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-14
Reviewed by David Hyatt.
Source/WebCore:
When a portion of the render tree is being detached, anonymous blocks
will be combined as their children are deleted. In this process, the
anonymous block later in the tree is merged into the one preceeding it.
It can happen that the later block contains floats that the previous
block did not contain, and thus are not in the floating objects list for
the new block. This can result in the new block containing floats that
are not in it's floating objects list, but are in the floating objects
lists of siblings and parents. This can cause problems when the float
itself is deleted, since the deletion code assumes that if a float is not
in it's containing block's floating objects list, it isn't in any
floating objects list, causing dangling pointers in the floating objects
lists of the siblings and parents. In order to preserve this condition
(removing it has serious performance implications), we need to copy the
floating objects from the old block to the new block. The float's
metrics will likely all be wrong, but since the new block is already
marked for layout, this will get fixed before anything gets displayed.
Test: fast/block/float/float-append-child-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::moveAllChildrenIncludingFloatsTo): Copy
floating objects list in addition to children.
(WebCore::RenderBlock::FloatingObject::clone): Added.
(WebCore::RenderBlock::removeChild): Use new method to copy children.
- rendering/RenderBlock.h:
(RenderBlock): Add method.
LayoutTests:
Cleaned up test from the fuzzer. Will only crash if run under a memory
checking tool like ASAN.
- fast/block/float/float-append-child-crash-expected.txt: Added.
- fast/block/float/float-append-child-crash.html: Added.
- 12:57 PM Changeset in webkit [150083] by
-
- 29 edits3 deletes in trunk
Unreviewed, rolling out r150023.
http://trac.webkit.org/changeset/150023
https://bugs.webkit.org/show_bug.cgi?id=116120
Causes table layout issues (Bug 116118) and crashes on
buildbot waterfall pages. (Requested by ddkilzer on #webkit).
Source/WebCore:
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
- rendering/RenderTableSection.h:
(RenderTableSection):
LayoutTests:
- fast/css/vertical-align-baseline-rowspan-007-expected.html:
- fast/css/vertical-align-baseline-rowspan-007.htm:
- fast/css/vertical-align-baseline-rowspan-008-expected.html:
- fast/table/table-rowspan-height-distribution-in-rows.html: Removed.
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/qt/fast/table/table-rowspan-height-distribution-in-rows-expected.png: Removed.
- platform/qt/fast/table/table-rowspan-height-distribution-in-rows-expected.txt: Removed.
- platform/qt/tables/mozilla/bugs/bug17548-expected.png:
- platform/qt/tables/mozilla/bugs/bug17548-expected.txt:
- platform/qt/tables/mozilla/bugs/bug220536-expected.png:
- platform/qt/tables/mozilla/bugs/bug220536-expected.txt:
- platform/qt/tables/mozilla/bugs/bug7714-expected.png:
- platform/qt/tables/mozilla/bugs/bug7714-expected.txt:
- platform/qt/tables/mozilla/core/bloomberg-expected.png:
- platform/qt/tables/mozilla/core/bloomberg-expected.txt:
- platform/qt/tables/mozilla/other/test6-expected.png:
- platform/qt/tables/mozilla/other/test6-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
- tables/mozilla/core/bloomberg-expected.txt:
- tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- 12:39 PM Changeset in webkit [150082] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Hook up frame render begin/end in PerformanceMonitor
https://bugs.webkit.org/show_bug.cgi?id=116110
Patch by Andrew Lo <anlo@rim.com> on 2013-05-14
Reviewed by Rob Buis.
Internally reviewed by Jeff Rogers, Jonathan Jiang.
Internal PR 299155.
Mark frame render begin & end for BlackBerry performance monitoring
in blitVisibleContents.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- 11:39 AM WebKit Team edited by
- (diff)
- 11:03 AM Changeset in webkit [150081] by
-
- 2 edits in trunk/Source/WebCore
Snapshotted plug-ins shadow tree should reset style inheritance
https://bugs.webkit.org/show_bug.cgi?id=116098
Reset the styles such that only injected user-agent stylesheets affect
the rendering of snapshotted plug-ins' shadow content.
Reviewed by Darin Adler.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
- 10:57 AM Changeset in webkit [150080] by
-
- 4 edits in trunk/Tools
[Windows] Switch to embedded manifest commands for launcher executables.
https://bugs.webkit.org/show_bug.cgi?id=116109
Reviewed by Darin Adler.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
now-unused WinLauncher.exe.manifest file.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
- win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
when building with VS2010 or newer.
- 10:55 AM Changeset in webkit [150079] by
-
- 2 edits in trunk/Source/WebKit2
[Win] REGRESSION(r149944): mmap is not available on Windows
https://bugs.webkit.org/show_bug.cgi?id=116015
Reviewed by Anders Carlsson.
Use fastAlloc/fastFree for platforms other than OS(DARWIN) where
using mmap is not necessary and maybe not available.
- Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::allocBuffer):
(CoreIPC::freeBuffer):
(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
(CoreIPC::ArgumentEncoder::grow):
- 10:55 AM Changeset in webkit [150078] by
-
- 3 edits in trunk/Source/WebCore
[CSSRegions] Improve hit testing for empty regions
https://bugs.webkit.org/show_bug.cgi?id=115534
Reviewed by David Hyatt.
As a better follow up after WebKit bug https://bugs.webkit.org/show_bug.cgi?id=107752,
we can improve the code by not doing hit testing on the render flow thread object when
we are trying to hit test the render flow thread background. In this case, we should just bail out.
No new tests, covered by existing regions tests.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::nodeAtPoint):
(WebCore):
(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
- rendering/RenderFlowThread.h:
- 10:54 AM Changeset in webkit [150077] by
-
- 2 edits in trunk/Tools
[Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
https://bugs.webkit.org/show_bug.cgi?id=116079
Reviewed by David Kilzer.
- Scripts/old-run-webkit-tests:
(setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
- 10:53 AM Changeset in webkit [150076] by
-
- 6 edits in trunk/Source/WebCore
[BlackBerry] Handle network errors when starting a new job
https://bugs.webkit.org/show_bug.cgi?id=116101
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-14
Reviewed by Rob Buis.
Make startJob() return a network status that can be used by the
caller to create a network error.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::initialize): createNetworkStream() should
always return a valid pointer so use an ASSERT instead of an early
return to make sure we have a valid stream.
(WebCore::NetworkJob::startNewJobWithRequest): Only return true if
the network job was started successfully.
- platform/network/blackberry/NetworkJob.h:
(NetworkJob): Make initialize method void instead of bool since it
can't fail.
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob): Return a network error or
StatusSuccess.
- platform/network/blackberry/NetworkManager.h:
(NetworkManager):
- platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::start): Return true if job was started
successfully.
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
Check return value of startJob and fill the ResourceError with the
network status returned to finish the load.
- 10:44 AM Changeset in webkit [150075] by
-
- 2 edits in trunk/Source/WebCore
[Mac] captions menu is not positioned correctly in full-screen
https://bugs.webkit.org/show_bug.cgi?id=116103
Update the positioning properties of the captions menu in full-screen
following the fix for https://webkit.org/b/115968.
Reviewed by Darin Adler.
- css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-closed-captions-container):
Add 50px to the bottom position since we're now positioned relative to the
media element, and use a calc() command to be right-aligned to the captions
icon in the media controller. The max-width and max-height properties follow
the same technique used for the non-full-screen mode.
- 10:40 AM Changeset in webkit [150074] by
-
- 15 edits in trunk
[GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
https://bugs.webkit.org/show_bug.cgi?id=115921
Reviewed by Gustavo Noronha Silva.
.:
- GNUmakefile.am: Add GENSOURCES_PLATFORM, platform_built_sources variables.
Source/Platform:
- GNUmakefile.am: Move the ANGLE include directories under the new platform_cppflags variable,
adding the DerivedSources/Platform directory. Add the generated sources' build targets to libPlatform
under nodist_libPlatform_la_SOURCES. Add platform_cppflags to the list of libPlatformGtk CPPFLAGS.
Add generation rules for the ColorData.cpp and WebKitFontFamilyNames.(cpp|h) source files, now generated
into the DerivedSources/Platform directory.
Source/WebCore:
No new tests - no new functionality.
- GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreSVG, libWebCore,
libWebCorePlatform, libWebCoreGtk. Remove generation rules for ColorData.cpp and WebKitFontFamilyNames.(cpp|h).
- GNUmakefile.list.am: Include the ColorData.cpp and WebKitFontFamilyNames.(cpp|h) build targers under
platform_built_sources.
- bindings/gobject/GNUmakefile.am: Add platform_cppflags to the list of libWebCoreDOM CPPFLAGS.
Source/WebKit/gtk:
- GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libwebkit2gtk, libWebCoreGtk2,
libPlatformGtk2 and WebKitPluginProcess.
Source/WebKit2:
- GNUmakefile.am: Add platform_cppflags to the list of libwebkit2gtk CPPFLAGS.
Tools:
- GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
- TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
- 10:31 AM Changeset in webkit [150073] by
-
- 4 edits in trunk/Source
[GTK] libPlatform, libPlatformGtk must depend on the related GNUmakefiles
https://bugs.webkit.org/show_bug.cgi?id=115937
Reviewed by Martin Robinson.
Source/Platform:
- GNUmakefile.am: Set up an artifical dependency so that libPlatform and libPlatformGtk
libraries take into account any changes in this GNUmakefile.am and the GNUmakefile.list.am
located under Source/WebCore. The latter is included due to all the build targets for the
two libraries being listed there.
Source/WebCore:
No new tests - no new functionality.
- GNUmakefile.am: Fix typos in two libraries' names - Webcore -> WebCore.
- 9:52 AM Changeset in webkit [150072] by
-
- 4 edits2 adds in trunk
Removing Attr can delete a wrong Attribute in ElementData
https://bugs.webkit.org/show_bug.cgi?id=116077
Source/WebCore:
Reviewed by Benjamin Poulain.
Merge https://chromium.googlesource.com/chromium/blink/+/e861452a292e185501e48940305947aa6a4e23c2
after simplifying and renaming functions to be more WebKit style.
The XML parser can produce elements with attributes whose names have
distinct prefixes, but the same expanded name. When one of these
attributes is put up for adoption, it may be its similarly named
sibling that is removed from its owner element. As a result the
original owner hangs onto the adopted attribute, despite the fact that
it is now in a different document. Sometimes it's just hard to let go.
Test: fast/dom/adopt-attribute-crash.svg
- dom/Element.cpp:
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::ElementData::getAttributeItemIndex):
- dom/Element.h:
(ElementData):
(Element):
LayoutTests:
Reviewed by Benjamin Poulain.
Add a regression test by importing
https://chromium.googlesource.com/chromium/blink/+/e861452a292e185501e48940305947aa6a4e23c2
- fast/dom/adopt-attribute-crash-expected.txt: Added.
- fast/dom/adopt-attribute-crash.svg: Added.
- 9:17 AM Changeset in webkit [150071] by
-
- 7 edits in trunk/Source
[BlackBerry] Use requestAnimationFrame for animations
https://bugs.webkit.org/show_bug.cgi?id=115896
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-14
Reviewed by Rob Buis.
Source/WebKit/blackberry:
Make WebPagePrivate a
BlackBerry::Platform::AnimationFrameRateClient and use it to
schedule animations.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
(BlackBerry::WebKit::WebPagePrivate::scheduleAnimation):
(BlackBerry::WebKit::WebPagePrivate::startRefreshAnimationClient):
(BlackBerry::WebKit::WebPagePrivate::stopRefreshAnimationClient):
(BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore):
(WebCore::ChromeClientBlackBerry::scheduleAnimation):
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
Source/WTF:
- wtf/Platform.h: Disable REQUEST_ANIMATION_FRAME_TIMER and
WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for BlackBerry
port.
- 8:59 AM Changeset in webkit [150070] by
-
- 19 edits in trunk/Source/WebCore
Remove ::-webkit-distributed()
https://bugs.webkit.org/show_bug.cgi?id=116106
Reviewed by Andreas Kling.
This experimental Shadow DOM selector code is unused and has no owner.
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded):
(WebCore::CSSParser::rewriteSpecifiersWithElementName):
- css/CSSParser.h:
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::CSSParserSelector):
- css/CSSParserValues.h:
(CSSParserSelector):
- css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::selectorText):
- css/CSSSelector.h:
- css/CSSSelectorList.cpp:
- css/CSSSelectorList.h:
(CSSSelectorList):
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::resetAuthorStyle):
- css/DocumentRuleSets.h:
(DocumentRuleSets):
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchAuthorRules):
- css/ElementRuleCollector.h:
(ElementRuleCollector):
- css/RuleSet.cpp:
(WebCore::RuleSet::addChildRules):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match):
- css/SelectorFilter.cpp:
(WebCore::SelectorFilter::collectIdentifierHashes):
- html/shadow/InsertionPoint.cpp:
- html/shadow/InsertionPoint.h:
- 7:29 AM Changeset in webkit [150069] by
-
- 5 edits in trunk/Source/WebCore
Remove RenderTheme::supportsCalendarPicker
https://bugs.webkit.org/show_bug.cgi?id=116068
Patch by Daker Fernandes Pinheiro <daker.pinheiro@openbossa.org> on 2013-05-14
Reviewed by Benjamin Poulain.
No new tests needed because it doesn't affect behaviour.
This method was never overrided by any platform
and always leaded to the same behaviour.
The code which depended on it was also removed.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility):
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
- page/ChromeClient.h:
(ChromeClient):
- rendering/RenderTheme.h:
- 5:54 AM Changeset in webkit [150068] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][Win] Fix ASSERT(DeleteTimerQueueTimer...)
https://bugs.webkit.org/show_bug.cgi?id=116039
Reviewed by Benjamin Poulain.
According to the documentation, DeleteTimerQueueTimer can be expected to return
false with an ERROR_IO_PENDING error when called from the timer's callback.
- Platform/win/WorkQueueWin.cpp:
(WorkQueue::timerCallback):
- 5:51 AM Changeset in webkit [150067] by
-
- 2 edits in trunk/LayoutTests
Modify checkLayout to receive the log container as an optional parameter
https://bugs.webkit.org/show_bug.cgi?id=112793
Reviewed by Darin Adler.
Add a way to specify the container manually for checkLayout. This is helpful to measure regions for nested
named flows (and probably other cases as well).
- resources/check-layout.js: Added an optional parameter to window.checkLayout.
- 5:49 AM Changeset in webkit [150066] by
-
- 4 edits2 adds in trunk
[GStreamer] cannot seek after video finished
https://bugs.webkit.org/show_bug.cgi?id=114044
Patch by Balazs Kelemen <b.kelemen@sisa.samsung.com> on 2013-04-30
Reviewed by Philippe Normand.
Source/WebCore:
Test: media/video-seek-after-end.html
Reland without wrong assertion. If seek is called after didEnd the pipeline
state will not be in GST_STATE_NULL yet but it is not a problem because we handle that.
Rework the seeking logic to be able to seek after reseting the pipeline.
In addition to solve the actual problem this patch supposed to make seeking
more robust and correct.
The previous implementation tried to hide the complexity of asynchronous operations
on the pipeline. It did not handle the GST_MESSAGE_ASYNC_DONE message from the bus
but instead reported the seek as finished when it saw an asynchronous pending state
(GST_STATE_CHANGE_ASYNC) which could happen way before the seek is really done.
Now we pay attention to the GST_MESSAGE_ASYNC_DONE message to track the status of seeks.
Seeks are not the only operations executed asynchronously, changing the pipeling state is
similar. It means a seek can overlap with onother ongoing asynchronous operation.
This change address this by introducing an invariant for seeks, which is that we only request
a seek if there are no other ongoing asynchronous operations and the pipeline state is either
paused or playing (which is recommended anyway according to GStreamer's documentation).
This way we can be sure that the time when we get the next GST_MESSAGE_ASYNC_DONE message the
seek has been completed.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::toGstClockTime): Factored time conversation into a helper.
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition): The position might not be available
if the pipeline still has a pending state. As a workaround, if we are right after a seek we can
use the seek time. Avoiding this situation would be possible by not allowing any asynchronous
operation to overlap. I believe it would add a lot more complexity so I decided to rather introduce
this workaround. Otherwise those overlapping operations are handled fine by GStreamer.
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Do not reset internal state variables.
This function called when there is an intent to restart playback but it does not actually restart it.
(WebCore::MediaPlayerPrivateGStreamer::currentTime): Just removed a staling newline.
(WebCore::MediaPlayerPrivateGStreamer::seek): Take a look to the pipeline state and act upon that.
If there is an ongoing asynchronous operation make the seek pending, otherwise do it now.
Now we handle overlapping seeks as well because I saw that it can happen in some tests.
Added an early return for live streams as it doesn't makes sense to try seeking in them.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Handle GST_MESSAGE_ASYNC_DONE and some refactoring.
(WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Only handle seeks in the pending case, the rest is
now handled in asyncStateChangeDone.
(WebCore::MediaPlayerPrivateGStreamer::cacheDuration): Do not reset the m_mediaDurationKnown if the pipeline
has an asynchronous pending state because it would fail. It does actually happen when we get a duration message
after restarting the pipeline and it would result in restarting playback from the start. It seems to be a bug
in GStreamer that it sends the duration message too early. Also sanitized this function by merging redundant branches.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
LayoutTests:
- media/video-seek-after-end-expected.txt: Added.
- media/video-seek-after-end.html: Added.
- 5:27 AM Changeset in webkit [150065] by
-
- 3 edits2 adds in trunk
Ellipsis text is placed to wrong position, when the truncated text is fully cut off in RTL direction.
https://bugs.webkit.org/show_bug.cgi?id=115858
Patch by Zalan Bujtas <Alan Bujtas> on 2013-05-14
Reviewed by Darin Adler.
Source/WebCore:
Take text direction into account to calculate ellipsis position in case of
full truncation.
Test: fast/css/text-overflow-ellipsis-full-truncate-rtl.html
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::placeEllipsisBox):
LayoutTests:
- fast/css/text-overflow-ellipsis-full-truncate-rtl-expected.html: Added.
- fast/css/text-overflow-ellipsis-full-truncate-rtl.html: Added.
- 4:37 AM Changeset in webkit [150064] by
-
- 7 edits in trunk/Source/WebKit2
Remove unused "type" field from DictionaryPopupInfo
https://bugs.webkit.org/show_bug.cgi?id=116011
Reviewed by Darin Adler.
It is unused, and furthermore, PDFPlugin sets it incorrectly anyway.
- Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
- Shared/DictionaryPopupInfo.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::showDefinitionForAttributedString):
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::lookUpInDictionary):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::performDictionaryLookupForSelection):
(WebKit::WebPage::performDictionaryLookupForRange):
- 4:32 AM Changeset in webkit [150063] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Make WebPageProxy use deviceScaleFactor() in creationParameters().
https://bugs.webkit.org/show_bug.cgi?id=110218
Reviewed by Darin Adler.
Make the WebPageProxy::creationParameters use the accessor
deviceScaleFactor() instead of using m_intrinsicDeviceScaleFactor
directly. This will restore the custom device scale factor when
reattaching to the WebProcess after a crash.
Moreover, it will enable the Qt and ELF ports to use the
existing C API for overriding the device scale factor instead
of using the WebPageProxy directly or adding new C API to set
the intrinsic device scale factor.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::setDeviceScaleFactor):
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::updatePaintNode):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- 3:12 AM Changeset in webkit [150062] by
-
- 12 edits3 adds2 deletes in trunk/Source
[BlackBerry] Implement platform strategies
https://bugs.webkit.org/show_bug.cgi?id=112162
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-14
Reviewed by Rob Buis.
Source/WebCore:
This is just a refactoring, covered by existing tests.
- CMakeLists.txt: Move PlatformStrategies.cpp from platform
specific makefiles to the global one now that all platforms using
cmake implement platform strategies.
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
- loader/CookieJar.cpp: Remove the preprocessor error that is not
needed anymore.
- loader/blackberry/CookieJarBlackBerry.cpp: Removed.
- platform/network/blackberry/CookieJarBlackBerry.cpp: Added.
(WebCore):
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
- plugins/blackberry/PluginDataBlackBerry.cpp: Removed.
Source/WebKit:
- PlatformBlackBerry.cmake: Add new files to compilation.
Source/WebKit/blackberry:
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize): Initialize platform
strategies.
- WebCoreSupport/PlatformStrategiesBlackBerry.cpp: Added.
(PlatformStrategiesBlackBerry::initialize):
(PlatformStrategiesBlackBerry::PlatformStrategiesBlackBerry):
(PlatformStrategiesBlackBerry::createCookiesStrategy):
(PlatformStrategiesBlackBerry::createDatabaseStrategy):
(PlatformStrategiesBlackBerry::createLoaderStrategy):
(PlatformStrategiesBlackBerry::createPasteboardStrategy):
(PlatformStrategiesBlackBerry::createPluginStrategy):
(PlatformStrategiesBlackBerry::createSharedWorkerStrategy):
(PlatformStrategiesBlackBerry::createStorageStrategy):
(PlatformStrategiesBlackBerry::createVisitedLinkStrategy):
(PlatformStrategiesBlackBerry::cookiesForDOM):
(PlatformStrategiesBlackBerry::setCookiesFromDOM):
(PlatformStrategiesBlackBerry::cookiesEnabled):
(PlatformStrategiesBlackBerry::cookieRequestHeaderFieldValue):
(PlatformStrategiesBlackBerry::getRawCookies):
(PlatformStrategiesBlackBerry::deleteCookie):
(PlatformStrategiesBlackBerry::refreshPlugins):
(PlatformStrategiesBlackBerry::getPluginInfo):
(PlatformStrategiesBlackBerry::isLinkVisited):
(PlatformStrategiesBlackBerry::addVisitedLink):
- WebCoreSupport/PlatformStrategiesBlackBerry.h: Added.
(PlatformStrategiesBlackBerry):
Source/WTF:
- wtf/Platform.h: Add BlackBerry platform to the list of platforms
using platform strategies.
- 2:23 AM Changeset in webkit [150061] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/TestExpectations: Skip test using disabled feature.
- platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Rebaselining after r149869.
- 1:52 AM Changeset in webkit [150060] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash due to an assert in FrameView::doDeferredRepaints
https://bugs.webkit.org/show_bug.cgi?id=115412
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-14
Reviewed by Rob Buis.
PR 115412
The problem is that we are calling
updateLayoutAndStyleIfNeededRecursive() (because of
zoomToInitialScaleOnLoad) from ChomeClient::layoutUpdated()
callback which is not expected. It's expected to be called right
before painting, and not right after painting. Even if a new
layout is not done, updateLayoutAndStyleIfNeededRecursive() calls
flushDeferredRepaints() and it's possible that this is called in
the middle of a beginDeferredRepaints() and endDeferredRepaints()
apparently.
In general only BackingStore should call
updateLayoutAndStyleIfNeededRecursive before painting, and a simple
layout is enough in all other cases like resizing. This patch renames
requestLayoutIfNeeded as updateLayoutAndStyleIfNeededRecursive to
make more obvious what it does, and adds layoutIfNeeded that calls
layout. The former is used by the BackingStore and the latter by
WebPage.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::requestLayoutIfNeeded):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::updateLayoutAndStyleIfNeededRecursive):
(BlackBerry::WebKit::WebPagePrivate::layoutIfNeeded):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::overflowExceedsContentsSize):
(BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- Api/WebPage_p.h:
(WebPagePrivate):
- 1:49 AM Changeset in webkit [150059] by
-
- 37 edits1 move2 adds in trunk/LayoutTests
[EFL] Unreviewed EFL gardening
https://bugs.webkit.org/show_bug.cgi?id=116090
Unreviewed EFL gardening.
Rebaseline after r155023.
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-05-14
- platform/efl/TestExpectations:
- platform/efl/fast/table/007-expected.png:
- platform/efl/fast/table/007-expected.txt:
- platform/efl/fast/table/colspanMinWidth-expected.png:
- platform/efl/fast/table/colspanMinWidth-expected.txt:
- platform/efl/fast/table/spanOverlapRepaint-expected.png:
- platform/efl/fast/table/spanOverlapRepaint-expected.txt:
- platform/efl/fast/table/table-rowspan-height-distribution-in-rows-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug13169-expected.png:
- platform/efl/tables/mozilla/bugs/bug13169-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug133756-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17138-expected.png:
- platform/efl/tables/mozilla/bugs/bug17138-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17548-expected.png:
- platform/efl/tables/mozilla/bugs/bug17548-expected.txt:
- platform/efl/tables/mozilla/bugs/bug220536-expected.png:
- platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
- platform/efl/tables/mozilla/bugs/bug6304-expected.png:
- platform/efl/tables/mozilla/bugs/bug6304-expected.txt:
- platform/efl/tables/mozilla/bugs/bug73321-expected.txt: Renamed from LayoutTests/platform/efl-wk2/tables/mozilla/bugs/bug73321-expected.txt.
- platform/efl/tables/mozilla/bugs/bug7714-expected.txt:
- platform/efl/tables/mozilla/bugs/bug8858-expected.txt:
- platform/efl/tables/mozilla/core/bloomberg-expected.png:
- platform/efl/tables/mozilla/core/bloomberg-expected.txt:
- platform/efl/tables/mozilla/core/cell_heights-expected.txt:
- platform/efl/tables/mozilla/other/test6-expected.png:
- platform/efl/tables/mozilla/other/test6-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
- 1:40 AM Changeset in webkit [150058] by
-
- 2 edits in trunk/LayoutTests
The tests marked with the comment "WebKitTestRunner needs to sanitize file urls in the output"
run successfully with WebKitTestRunner. They should not be skipped.
https://bugs.webkit.org/show_bug.cgi?id=116083
Patch by Alex Christensen <achristensen@apple.com> on 2013-05-14
Reviewed by Darin Adler.
- platform/wk2/TestExpectations:
Unskip tests.
- 1:31 AM Changeset in webkit [150057] by
-
- 4 edits in trunk/Source
[Qt] Fix a crash under ~PingLoader when the QNAM on the page has been destroyed.
https://bugs.webkit.org/show_bug.cgi?id=116035
Reviewed by Simon Hausmann.
Source/WebCore:
Reproduced with arora which does destroy the QNetworkAccessManager in some situations.
The problem is that PingLoader can still be pending meanwhile, holding a ResourceHandle
with a dangling pointer to a QNetworkReply destroyed with the QNetworkAccessManager.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
Set the parent to 0 like we did before the introduction of QNetworkReplyWrapper.
(WebCore::QNetworkReplyWrapper::release):
Source/WebKit/qt:
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::networkReplyParentChanged):
May 13, 2013:
- 11:52 PM Changeset in webkit [150056] by
-
- 2 edits in trunk/Source/WebKit/mac
Make -[WebNavigationData url] the destination of the navigation
https://bugs.webkit.org/show_bug.cgi?id=114904
Reviewed by Dave Kilzer.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::updateGlobalHistory): Initialize the WebNavigationData with the
current URL, not the original request URL.
- 10:42 PM Changeset in webkit [150055] by
-
- 6 edits in trunk/Source/WebCore
[Mac] update in-band caption attributes
https://bugs.webkit.org/show_bug.cgi?id=116057
Reviewed by Dean Jackson.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::updateCueFromCueData): Copy highlight color.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): "highlight" color sets the cue
background, "background" color sets the cue container background.
- html/track/TextTrackCueGeneric.h:
- platform/graphics/InbandTextTrackPrivateClient.h:
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes): Process "highlight" color.
- 9:09 PM Changeset in webkit [150054] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r150049): Fix RetainPtr<> type in PasteboardIOS.mm
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::writeImage): Use RetainPtr<CFStringRef>
instead of RetainPtr<NSString>.
- 9:04 PM Changeset in webkit [150053] by
-
- 13 edits1 delete in trunk/Source/WebCore
Remove platform/graphic's Generator
https://bugs.webkit.org/show_bug.cgi?id=116084
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-13
Reviewed by Darin Adler.
The Generator no longer abstract anything useful, its only
implementation is Gradient.
- GNUmakefile.list.am:
- WebCore.exp.in:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/GeneratedImage.h:
- platform/graphics/Generator.h: Removed.
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
- platform/graphics/GeneratorGeneratedImage.h:
(WebCore::GeneratorGeneratedImage::create):
(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):
(GeneratorGeneratedImage):
- platform/graphics/Gradient.h:
(WebCore):
(Gradient):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::fillRect):
- platform/graphics/GraphicsContext.h:
(WebCore):
(GraphicsContext):
- 8:36 PM Changeset in webkit [150052] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip several tests which already passed and add png expected results.
- platform/efl/TestExpectations:
- platform/efl/editing/selection/doubleclick-crash-expected.png: Added.
- platform/efl/editing/selection/select-missing-image-expected.png: Added.
- 8:20 PM Changeset in webkit [150051] by
-
- 2 edits in trunk/Source/JavaScriptCore
Nightly build's jsc doesn't work without DYLD_FRAMEWORK...
https://bugs.webkit.org/show_bug.cgi?id=79065
Patch by Alvaro Lopez Ortega <alvaro@alobbs.com> on 2013-05-13
Reviewed by Darin Adler.
Fixes the build process so the depencencies of the jsc binary are
modified before its copied to its target directory. In this way
jsc should always use relative reference to the JavaScriptCore
libraries.
- JavaScriptCore.xcodeproj/project.pbxproj: Fixes the commands in
the "Copy Into Framework" target.
- 7:49 PM Changeset in webkit [150050] by
-
- 2 edits in trunk/Source/JavaScriptCore
Objective-C API: scanExternalObjectGraph should not create new JSVirtualMachine wrappers
https://bugs.webkit.org/show_bug.cgi?id=116074
If scanExternalObjectGraph creates a new JSVirtualMachine wrapper during collection, when the
scanExternalObjectGraph call finishes and the autorelease pool is drained we will dealloc the
JSVirtualMachine which will cause us to try to take the API lock for the corresponding VM.
If this happens on a GC thread other than the "main" thread, we will deadlock. The solution
is to just check the VM cache, and if there is no JSVirtualMachine wrapper, return early.
Reviewed by Darin Adler.
- API/JSVirtualMachine.mm:
(scanExternalObjectGraph):
- 7:21 PM Changeset in webkit [150049] by
-
- 4 edits3 adds in trunk/Source/WebCore
Upstream iOS Clipboard and Pasteboard changes
<http://webkit.org/b/116062>
Reviewed by Darin Adler.
- WebCore.xcodeproj/project.pbxproj:
- dom/Clipboard.h:
- platform/Pasteboard.h:
- platform/ios/ClipboardIOS.h: Added.
- platform/ios/ClipboardIOS.mm: Added.
- platform/ios/PasteboardIOS.mm: Added.
- 7:14 PM Changeset in webkit [150048] by
-
- 2 edits in trunk/LayoutTests
compositing/transitions/transform-on-large-layer.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=110099
Reviewed by Darin Adler.
Only set the timeout for test end after the resize event has been
received. This helps slow test bots, and also makes it easier to
tell rendering failures from failures to send resize event.
- compositing/transitions/transform-on-large-layer.html:
- 7:11 PM Changeset in webkit [150047] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Use pageScaleFactor * deviceScaleFactor in requiresTiledLayer() and computePixelAlignment() of GraphicsLayerCA.
https://bugs.webkit.org/show_bug.cgi?id=107359
Patch by Huang Dongsung <luxtella@company100.net> on 2013-05-13
Reviewed by Darin Adler.
Currently GraphicsLayerCA uses pageScaleFactor in requiresTiledLayer() and
computePixelAlignment(), but we must use pageScaleFactor * deviceScaleFactor in
them.
It is because:
- requiresTiledLayer() uses the scale to compute an actual layer size in the device
pixel unit.
- computePixelAlignment() uses the scale to compute an aligned layer position
in the device pixel unit.
No new tests. We can not test about requiresTiledLayer() because it depends on
gpu. computePixelAlignment() is correct now because fortunately Mac uses
only 2 (for retina display) as a deviceScaleFactor.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::requiresTiledLayer):
(WebCore::GraphicsLayerCA::computePixelAlignment):
- 7:00 PM Changeset in webkit [150046] by
-
- 12 edits in trunk
Added testRunner.setPrinting.
https://bugs.webkit.org/show_bug.cgi?id=42693
rdar://problem/8213845
Patch by Alex Christensen <achristensen@apple.com> on 2013-05-13
Reviewed by Darin Adler.
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyRenderTreeExternalRepresentationForPrinting): Added.
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
Added WKBundlePageCopyRenderTreeExternalRepresentationForPrinting declaration.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::renderTreeExternalRepresentationForPrinting): Added.
- WebProcess/WebPage/WebPage.h:
Added renderTreeExternalRepresentationForPrinting declaration.
Tools:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
Added setPrinting JavaScript function.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump):
Dump the external representation for printing if setPrinting has been called.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::isPrinting): Added.
(WTR::TestRunner::setPrinting): Added.
Added and initialized m_isPrinting member boolean.
LayoutTests:
- platform/wk2/TestExpectations:
Unskipped printing tests.
- 5:59 PM Changeset in webkit [150045] by
-
- 27 edits3 moves in trunk
Rename BarInfo to BarProp and remove [NoInterfaceObject]
https://bugs.webkit.org/show_bug.cgi?id=116027
Reviewed by Andreas Kling.
Source/WebCore:
Rename BarInfo to BarProp and remove [NoInterfaceObject] extended attribute from
the IDL interface to match the specification:
http://www.w3.org/html/wg/drafts/html/master/browsers.html#barprop
The new behavior also matches Firefox and Blink.
No new tests, covered by LayoutTests/fast/js/global-constructors-attributes.html.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/gobject/GNUmakefile.am:
- page/BarProp.cpp: Renamed from Source/WebCore/page/BarInfo.cpp.
- page/BarProp.h: Renamed from Source/WebCore/page/BarInfo.h.
- page/BarProp.idl: Renamed from Source/WebCore/page/BarInfo.idl.
- page/DOMWindow.cpp:
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
Rebaseline fast/js/global-constructors-attributes.html now that there is a new
'BarProp' global constructor.
Rebaseline a few other tests now that BarInfo was renamed to BarProp.
- fast/dom/Window/window-lookup-precedence-expected.txt:
- fast/js/global-constructors-attributes-expected.txt:
- fast/loader/window-properties-restored-from-page-cache-expected.txt:
- http/tests/security/cross-frame-access-put-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
- platform/qt/fast/js/global-constructors-attributes-expected.txt:
- 4:17 PM Changeset in webkit [150044] by
-
- 6 edits in trunk/Source
Remove ChromeClient::willPopupMenu
https://bugs.webkit.org/show_bug.cgi?id=116063
Reviewed by Andreas Kling.
Source/WebCore:
Remove ChromeClient::willPopupMenu.
- page/ChromeClient.h:
Source/WebKit/mac:
ChromeClient::willPopupMenu is only called in one place from WebKit, so just move the function to the call site.
- WebCoreSupport/PopupMenuMac.mm:
(PopupMenuMac::show):
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
- 4:16 PM Changeset in webkit [150043] by
-
- 13 edits in trunk/Source/WebCore
Headers and footers should be pinned to the left edge of the window when scrolling
horizontally
https://bugs.webkit.org/show_bug.cgi?id=116061
-and corresponding-
<rdar://problem/13599215>
Reviewed by Simon Fraser.
The scrolling thread will need to know about the header and footer layers in order
the implement this custom scrolling behavior.
These getters will fetch the header or footer layer from the FrameView as
appropriate.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::headerLayerForFrameView):
(WebCore::ScrollingCoordinator::footerLayerForFrameView):
- page/scrolling/ScrollingCoordinator.h:
When we’re scrolling on the main thread, adjust the position of the header and
footer layers here.
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
ScrollingStateScrollingNode now stores GraphicsLayers and PlatformLayers for the
header and footer, just like it already does for the counterScrollingLayer.
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
- page/scrolling/ScrollingStateScrollingNode.h:
(ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::headerLayer):
(WebCore::ScrollingStateScrollingNode::footerLayer):
Setters for the new layers.
- page/scrolling/mac/ScrollingCoordinatorMac.h:
(ScrollingCoordinatorMac):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinatorMac::setHeaderLayerForNode):
(WebCore::ScrollingCoordinatorMac::setFooterLayerForNode):
These setters and getters mirror the existing one for counterScrollingLayer.
- page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
(WebCore::ScrollingStateScrollingNode::headerPlatformLayer):
(WebCore::ScrollingStateScrollingNode::setHeaderLayer):
(WebCore::ScrollingStateScrollingNode::footerPlatformLayer):
(WebCore::ScrollingStateScrollingNode::setFooterLayer):
And the ScrollingTree will store CALayers for the header and footer.
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
(ScrollingTreeScrollingNodeMac):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::updateBeforeChildren):
This is where the magic happens when we are scrolling on the scrolling thread.
Adjust the horizontal position the behave like a fixed object, but keep the
vertical position what it was when layer was created.
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
RenderLayerCompositor must now provide getters for the header and footer.
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::headerLayer):
(WebCore::RenderLayerCompositor::footerLayer):
Set the anchor point for when we adjust the position later on. Also call
frameViewRootLayerDidChange() to get the new layers picked up and sent to the
scrolling tree.
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
- 4:11 PM Changeset in webkit [150042] by
-
- 8 edits in trunk/Source
Improve stringProtoFuncLastIndexOf for the prefix case
https://bugs.webkit.org/show_bug.cgi?id=115952
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncLastIndexOf):
Use the optimized string search when possible.
On Joseph Pecoraro's tests, this gives a ~30% speed improvement.
Source/WTF:
Add an optimized version of StringImpl::startsWith() for JavaScriptCore.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::startsWith):
- wtf/text/StringImpl.h:
(StringImpl):
(WTF::StringImpl::startsWith):
- wtf/text/WTFString.h:
(WTF::String::startsWith):
- 2:53 PM Changeset in webkit [150041] by
-
- 32 edits in trunk/Source
Add support for updating the Web Inspector toolbar height.
https://bugs.webkit.org/show_bug.cgi?id=115996
Reviewed by Joseph Pecoraro and Benjamin Poulain.
Source/WebCore:
- inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::setToolbarHeight):
- inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
- inspector/InspectorFrontendHost.idl:
- testing/Internals.cpp:
Source/WebKit/efl:
- WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorFrontendClientEfl::setToolbarHeight):
- WebCoreSupport/InspectorClientEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorFrontendClient::setToolbarHeight):
- WebCoreSupport/InspectorClientGtk.h:
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::setToolbarHeight):
Source/WebKit/qt:
- WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorFrontendClientQt::setToolbarHeight):
- WebCoreSupport/InspectorClientQt.h:
Source/WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::setToolbarHeight):
- WebCoreSupport/WebInspectorClient.h:
Source/WebKit2:
- UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::setToolbarHeight):
(WebInspectorProxy):
- UIProcess/WebInspectorProxy.messages.in:
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformSetToolbarHeight):
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformSetToolbarHeight):
(WebKit):
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformSetToolbarHeight):
- UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformSetToolbarHeight):
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::setToolbarHeight):
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
(WebInspectorFrontendClient):
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::setToolbarHeight):
- WebProcess/WebPage/WebInspector.h:
- 2:29 PM Changeset in webkit [150040] by
-
- 4 edits2 adds in trunk
toDataURL can return an empty image in some cases
https://bugs.webkit.org/show_bug.cgi?id=115981
<rdar://problem/13760256>
Reviewed by Darin Adler.
Source/WebCore:
In some accelerated rendering cases, calling toDataURL on
an off-screen canvas produced an empty image. The solution
was to force a CGContextFlush before extracting the data
for image generation.
While here, I collected the flushing code from other methods
into a single place. Also we were getting into a situation where
we called flush two times in a row.
Test: fast/canvas/toDataURL-not-empty.html
- platform/graphics/ImageBuffer.h:
(ImageBuffer): Define two new methods flushContext and flushContextIfNecessary.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::context): Call flushContextIfNecessary.
(WebCore::ImageBuffer::flushContextIfNecessary): Moved the 10.7 code in here.
(WebCore::ImageBuffer::flushContext): Calls CGContextFlush.
(WebCore::ImageBuffer::getUnmultipliedImageData): Call new helper.
(WebCore::ImageBuffer::getPremultipliedImageData): Call new helper.
(WebCore::ImageBuffer::toDataURL): Flush the CG context.
LayoutTests:
Make sure that a canvas with content is not the same as one
without content.
- fast/canvas/toDataURL-not-empty-expected.txt: Added.
- fast/canvas/toDataURL-not-empty.html: Added.
- 2:27 PM Changeset in webkit [150039] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark fast/table/crash-split-table-section-no-cell-recalc.html as crashing
on EFL port.
- platform/efl/TestExpectations:
- 2:02 PM Changeset in webkit [150038] by
-
- 2 edits in trunk/Source/WebCore
Regressions in flexbox layout caused by the flexing optimizations.
https://bugs.webkit.org/show_bug.cgi?id=116058
<rdar://problem/13863647>
Reviewed by Beth Dakin.
Roll out the flex-related changes from r149597 so that the layout
algorithm goes back to the way it was. Leave the repainting optimizations
in place though.
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
- 1:43 PM Changeset in webkit [150037] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip several tests that stopped crashing after r150030.
- platform/efl-wk2/TestExpectations:
- 1:39 PM Changeset in webkit [150036] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark fast/css/variables/var-inside-shape.html as failing on EFL after
r150025.
- platform/efl/TestExpectations:
- 1:29 PM Changeset in webkit [150035] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r150014.
http://trac.webkit.org/changeset/150014
https://bugs.webkit.org/show_bug.cgi?id=86410
Broke video playback on WK2 and some webgl tests
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
(MediaPlayerPrivateGStreamerBase):
- 1:07 PM Changeset in webkit [150034] by
-
- 4 edits in trunk/Source
Sometimes NSUndoManager can get into an inconsistent state
https://bugs.webkit.org/show_bug.cgi?id=116050
Reviewed by Enrica Casucci.
Always group undo items to work around a bug in NSUndoManager that manifests
when we call removeAllActionsWithTarget.
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::registerUndoOrRedoStep):
Source/WebKit2:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::registerEditCommand):
- 1:06 PM Changeset in webkit [150033] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark fast/animation/request-animation-frame-too-rapid.html as failing on EFL WK2
due to r150015.
- platform/efl-wk2/TestExpectations:
- 12:37 PM Changeset in webkit [150032] by
-
- 9 edits6 adds2 deletes in trunk/LayoutTests
[CSS Exclusions] Simple shape-outside tests fail when subpixel layout is disabled
https://bugs.webkit.org/show_bug.cgi?id=115767
Reviewed by Dirk Schulze.
The overall goal of this change was to restore the (last) four excluded exclusions ref-tests
by making them work correctly when subpixel layout is disabled. All of the tests were
substantially simplified, as was the supporting javascript code. The original
shape-outside-floats-simple-rounded-rectangle test was replaced by three separate tests
because the original was bigger then then the 800x600 limit and because it unncessarily
combined three indepedent test cases.
- fast/exclusions/resources/rounded-rectangle.js:
(ellipseXIntercept): Return the 1st quadrant X intercept for an ellipse given a first quadrant Y intercept.
(scanConvertRoundedRectangleOutside): Return the line segment intervals that overlap a rounded rectangle.
(genLeftRightRoundedRectFloatShapeOutsideRefTest): Insert a stack of float divs that match the left or right edge of a rounded rectangle.
- fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y-expected.html:
- fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html:
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle-expected.html:
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle.html:
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse-expected.html:
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse.html:
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-001-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-001.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-002-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-002.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-003-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-003.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-expected.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle.html: Removed.
- platform/mac/TestExpectations:
- 12:35 PM Changeset in webkit [150031] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r150022.
http://trac.webkit.org/changeset/150022
https://bugs.webkit.org/show_bug.cgi?id=114044
Causes assertions in media tests
Source/WebCore:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay):
(WebCore::MediaPlayerPrivateGStreamer::currentTime):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
LayoutTests:
- media/video-seek-after-end-expected.txt: Removed.
- media/video-seek-after-end.html: Removed.
- 12:31 PM Changeset in webkit [150030] by
-
- 8 edits in trunk/Source/WebKit2
[WK2] Crash in WebKit::StorageAreaMap::didSetItem()
https://bugs.webkit.org/show_bug.cgi?id=116026
Reviewed by Andreas Kling.
Make sure that we ignore any leftover messages from the UI process after we've reset
the storage map. Achieve this by keeping a seed count in the StorageAreaMap object that's incremented
everytime the map is reset. Associate every storage area change with the seed and ignore any incoming
notification messages from the UI process if the seeds are different.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC):
(CoreIPC::callMemberFunction):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::getValues):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::removeItem):
(WebKit::StorageManager::clear):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- UIProcess/Storage/StorageManager.messages.in:
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::setItem):
(WebKit::StorageAreaMap::removeItem):
(WebKit::StorageAreaMap::clear):
(WebKit::StorageAreaMap::resetValues):
(WebKit::StorageAreaMap::loadValuesIfNeeded):
(WebKit::StorageAreaMap::didGetValues):
(WebKit::StorageAreaMap::didSetItem):
(WebKit::StorageAreaMap::didRemoveItem):
(WebKit::StorageAreaMap::didClear):
(WebKit::StorageAreaMap::applyChange):
- WebProcess/Storage/StorageAreaMap.h:
(StorageAreaMap):
- WebProcess/Storage/StorageAreaMap.messages.in:
- 12:30 PM Changeset in webkit [150029] by
-
- 4 edits2 adds in trunk
Source/WebCore: Floats should not overhang from flex items
https://bugs.webkit.org/show_bug.cgi?id=115925
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-13
Reviewed by David Hyatt.
Allowing floats to overhand from flex items is not only against the
spec, it causes bad bugs. Fix this by having flex items properly avoid
floats.
Test: fast/block/float/float-not-removed-crash2.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::avoidsFloats): Add flex items to avoid floats.
- rendering/RenderBox.h:
(WebCore::RenderBox::isFlexItemIncludingDeprecated): Determine if the current box is a
flex item or deprecated flex item.
LayoutTests: Fix the float logic to not return an anonymous block ancestor
https://bugs.webkit.org/show_bug.cgi?id=115925
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-13
Reviewed by David Hyatt.
Cleaned up fuzzer test. Note that this will only crash when run under
a memory checker like ASAN.
- fast/block/float/float-not-removed-crash2-expected.txt: Added.
- fast/block/float/float-not-removed-crash2.html: Added.
- 12:23 PM Changeset in webkit [150028] by
-
- 2 edits in trunk/Tools
[webkitpy] Make FileInfo.repository_name support SVN version > 1.6
https://bugs.webkit.org/show_bug.cgi?id=116016
Reviewed by Dirk Pranke.
Same fix as in the upstream style checker, but without hg support.
( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
- Scripts/webkitpy/style/checkers/cpp.py:
(FileInfo.repository_name):
- 12:11 PM Changeset in webkit [150027] by
-
- 10 edits1 copy13 adds in trunk
[CSS Regions][CSS Exclusions] Shape-inside on regions should respect region borders and paddings
https://bugs.webkit.org/show_bug.cgi?id=115456
Reviewed by David Hyatt.
I refactored the computation logic of shape-inside on regions by removing access to RenderFlowThread from ExclusionShapeInfo's logicalTopOffset
function, this means all the logic is now existing in RenderBlockLineLayout.cpp. By modifying the logicalTopOffset it turned out that the borders
and padding hadn't worked correctly, since borders and paddings were counted twice in the shape-inside's computation. This patch adds the necessary
modifications to let it respect the borders and padding in the correct way. I created 2 new helper functions to prevent increasing the code size of
the layoutRunsAndFloatsInRange function.
Source/WebCore:
I introduced 7 new tests to test for testing the correct behavior.
Tests: fast/regions/shape-inside/shape-inside-on-first-region-block-content.html
fast/regions/shape-inside/shape-inside-on-first-region-inline-content.html
fast/regions/shape-inside/shape-inside-on-second-region-block-content.html
fast/regions/shape-inside/shape-inside-on-second-region-inline-content.html
fast/regions/shape-inside/shape-inside-on-regions-inline-content.html
fast/regions/shape-inside/shape-inside-with-region-borders.html
fast/regions/shape-inside/shape-inside-with-region-padding.html
- rendering/ExclusionShapeInfo.cpp:
(WebCore): Remove FlowThread logic from logicalTopOffset move definition to header.
- rendering/ExclusionShapeInfo.h:
(WebCore::ExclusionShapeInfo::logicalTopOffset): Moved from cpp.
(WebCore::ExclusionShapeInfo::logicalLeftOffset): Add condition for RenderRegions.
- rendering/RenderBlock.h:
(RenderBlock): Add definition to the new helper members.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Modified the flow thread case to return the appropriate region.
(WebCore::RenderBlock::updateLineBoundariesForExclusions): Added new helper function. Modify the shape-inside on regions
line boundaries and position computation logic.
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded): Added new helper function which handles the flow thread case also.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Modified the code to use the helper functions.
LayoutTests:
- fast/regions/shape-inside/shape-inside-on-additional-regions-expected.html: Modify to not use shape-inside for testing.
- fast/regions/shape-inside/shape-inside-on-additional-regions.html: Fix the shape-inside's dimension.
- fast/regions/shape-inside/shape-inside-on-first-region-block-content-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-first-region-block-content.html: Added.
- fast/regions/shape-inside/shape-inside-on-first-region-inline-content-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-first-region-inline-content.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-expected.html: Match the shape-inside height to the container's height.
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions.html: Match the shape-inside height to the container's height.
- fast/regions/shape-inside/shape-inside-on-second-region-block-content-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-second-region-block-content.html: Added.
- fast/regions/shape-inside/shape-inside-on-second-region-inline-content-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-second-region-inline-content.html: Added.
- fast/regions/shape-inside/shape-inside-with-region-borders-expected.html: Added.
- fast/regions/shape-inside/shape-inside-with-region-borders.html: Added.
- fast/regions/shape-inside/shape-inside-with-region-padding-expected.html: Added.
- fast/regions/shape-inside/shape-inside-with-region-padding.html: Added.
- 12:06 PM Changeset in webkit [150026] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed. AppleWin VS2005 build fix.
- WebKit.vcproj/WebKitExports.def.in:
- 11:37 AM Changeset in webkit [150025] by
-
- 3 edits2 adds in trunk
[css exclusions] Enable CSS Exclusions by default when CSS_EXCLUSIONS is set
https://bugs.webkit.org/show_bug.cgi?id=115919
Reviewed by Dean Jackson.
Source/WebCore:
Change the RuntimeEnabledFeatures::isCSSExclusionsEnabled boolean to default
to true. CSS Exclusions can still be enabled / disabled in platforms by
setting the CSS_EXCLUSIONS compile flag in one of the FeatureDefine files.
Test: fast/exclusions/css-exclusions-enabled.html
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
LayoutTests:
Adding a test to make sure CSS Exclusions can be enabled, and are enabled by
default.
- fast/exclusions/css-exclusions-enabled-expected.txt: Added.
- fast/exclusions/css-exclusions-enabled.html: Added.
- 11:24 AM Changeset in webkit [150024] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][CoordinatedGraphics] Avoid dispensable calls to WebView::updateViewportSize()
https://bugs.webkit.org/show_bug.cgi?id=116045
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-05-13
Reviewed by Darin Adler.
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::setSize):
- 11:16 AM Changeset in webkit [150023] by
-
- 30 edits3 adds in trunk
Cell heights are disproportional when a row-spanning cell contains a block element that determines the height of the rows
https://bugs.webkit.org/show_bug.cgi?id=52185
Patch by Suchit Agrawal <a.suchit@samsung.com> on 2013-05-13
Reviewed by David Hyatt.
Source/WebCore:
Cells heights are not proper when rowspan cell have its own height and rowspan height
is more than the height of the rows present in rowspan.
After calculating logical height of the rows in the table, we are recalculating the height
of the rows present in rowspan. Based on the ratio of row's logical height, we are
distributing rowspan cell height in rows.
Test: fast/table/table-rowspan-height-distribution-in-rows.html
- rendering/RenderTableSection.cpp:
(WebCore):
Update the logical height of the rows based on rowspan cell height.
(WebCore::RenderTableSection::distributeRowSpanHeightToRows):
It calculates logical height of the rows in the table.
(WebCore::RenderTableSection::calcRowLogicalHeight):
Added new private API to distribute rowSpan cell height in rows.
- rendering/RenderTableSection.h:
(RenderTableSection):
LayoutTests:
Test case updated.
- fast/css/vertical-align-baseline-rowspan-007.htm:
Reference Test cases updated.
- fast/css/vertical-align-baseline-rowspan-007-expected.html:
- fast/css/vertical-align-baseline-rowspan-008-expected.html:
Added test cases based on changes in the code and different scenarios for rowspan height
distribution in rows.
- fast/table/table-rowspan-height-distribution-in-rows.html: Added.
- platform/qt/fast/table/table-rowspan-height-distribution-in-rows-expected.png: Added.
- platform/qt/fast/table/table-rowspan-height-distribution-in-rows-expected.txt: Added.
Test cases need to rebaseline in qt, efl, gtk and mac platforms.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
Test case results are updated in qt platform.
- platform/qt/tables/mozilla/bugs/bug17548-expected.png:
- platform/qt/tables/mozilla/bugs/bug17548-expected.txt:
- platform/qt/tables/mozilla/bugs/bug220536-expected.png:
- platform/qt/tables/mozilla/bugs/bug220536-expected.txt:
- platform/qt/tables/mozilla/bugs/bug7714-expected.png:
- platform/qt/tables/mozilla/bugs/bug7714-expected.txt:
- platform/qt/tables/mozilla/core/bloomberg-expected.png:
- platform/qt/tables/mozilla/core/bloomberg-expected.txt:
- platform/qt/tables/mozilla/other/test6-expected.png:
- platform/qt/tables/mozilla/other/test6-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
- tables/mozilla/core/bloomberg-expected.txt:
- tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- 10:07 AM Changeset in webkit [150022] by
-
- 4 edits2 adds in trunk
[GStreamer] cannot seek after video finished
https://bugs.webkit.org/show_bug.cgi?id=114044
Patch by Balazs Kelemen <b.kelemen@sisa.samsung.com> on 2013-04-30
Reviewed by Philippe Normand.
Source/WebCore:
Test: media/video-seek-after-end.html
Rework the seeking logic to be able to seek after reseting the pipeline.
In addition to solve the actual problem this patch supposed to make seeking
more robust and correct.
The previous implementation tried to hide the complexity of asynchronous operations
on the pipeline. It did not handle the GST_MESSAGE_ASYNC_DONE message from the bus
but instead reported the seek as finished when it saw an asynchronous pending state
(GST_STATE_CHANGE_ASYNC) which could happen way before the seek is really done.
Now we pay attention to the GST_MESSAGE_ASYNC_DONE message to track the status of seeks.
Seeks are not the only operations executed asynchronously, changing the pipeling state is
similar. It means a seek can overlap with onother ongoing asynchronous operation.
This change address this by introducing an invariant for seeks, which is that we only request
a seek if there are no other ongoing asynchronous operations and the pipeline state is either
paused or playing (which is recommended anyway according to GStreamer's documentation).
This way we can be sure that the time when we get the next GST_MESSAGE_ASYNC_DONE message the
seek has been completed.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::toGstClockTime): Factored time conversation into a helper.
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition): The position might not be available
if the pipeline still has a pending state. As a workaround, if we are right after a seek we can
use the seek time. Avoiding this situation would be possible by not allowing any asynchronous
operation to overlap. I believe it would add a lot more complexity so I decided to rather introduce
this workaround. Otherwise those overlapping operations are handled fine by GStreamer.
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Do not reset internal state variables.
This function called when there is an intent to restart playback but it does not actually restart it.
(WebCore::MediaPlayerPrivateGStreamer::currentTime): Just removed a staling newline.
(WebCore::MediaPlayerPrivateGStreamer::seek): Take a look to the pipeline state and act upon that.
If there is an ongoing asynchronous operation make the seek pending, otherwise do it now.
Now we handle overlapping seeks as well because I saw that it can happen in some tests.
Added an early return for live streams as it doesn't makes sense to try seeking in them.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Handle GST_MESSAGE_ASYNC_DONE and some refactoring.
(WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Only handle seeks in the pending case, the rest is
now handled in asyncStateChangeDone.
(WebCore::MediaPlayerPrivateGStreamer::cacheDuration): Do not reset the m_mediaDurationKnown if the pipeline
has an asynchronous pending state because it would fail. It does actually happen when we get a duration message
after restarting the pipeline and it would result in restarting playback from the start. It seems to be a bug
in GStreamer that it sends the duration message too early. Also sanitized this function by merging redundant branches.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
LayoutTests:
- media/video-seek-after-end-expected.txt: Added.
- media/video-seek-after-end.html: Added.
- 9:44 AM Changeset in webkit [150021] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix a crash on startup in FrameLoaderClientQt::callPolicyFunction with MSVC
Reviewed by Allan Sandfeld Jensen.
It's not clear why it crashes, but here's my guess by looking at the generated
assembly code:
Since we're using a member function pointer to PolicyChecker, the representation
is not necessarily just a simple pointer and might be a bigger structure used
to handle virtual functions resolution.
For a function taking such a function "pointer" as parameter, the compiler doesn't
seem to have the caller and callee agree on which convention to use if the function
pointer's class is non-virtual and only one of the ends doesn't know about it.
Including the definition of the member function pointer's class fixes the crash.
- WebCoreSupport/FrameLoaderClientQt.cpp:
- 9:19 AM Changeset in webkit [150020] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Notification manager removal should not be tied to termination of web processes
https://bugs.webkit.org/show_bug.cgi?id=116038
<rdar://problem/10968680>
Reviewed by Ryosuke Niwa.
WebNotificationManagerProxy incorrectly removes the manager when web processes close.
Since it is a supplemental on the web context, the manager should only be removed
when the context is destroyed.
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
- UIProcess/Notifications/WebNotificationManagerProxy.h: Remove implementation of
processDidClose().
- 9:19 AM Changeset in webkit [150019] by
-
- 2 edits in trunk/Source/WTF
Unreviewed. Fix Qt Linux MIPS32R2 build after r149879.
Bring back GLIB_CHECK_VERSION for GBytes since Qt Linux MIPS32R2
depends on glib 2.24.2.
- wtf/gobject/GRefPtr.cpp:
(_GBytes):
(WTF::refGPtr):
(WTF::derefGPtr):
- 8:45 AM Changeset in webkit [150018] by
-
- 3 edits2 adds in trunk/Source/WebKit2
[GTK] [WebKit2] Use a template file for generated GObject enum files
https://bugs.webkit.org/show_bug.cgi?id=115867
Reviewed by Carlos Garcia Campos.
- GNUmakefile.am: Use a template file instead of specifying portions of the file on the command-line.
- UIProcess/API/gtk/WebKitEnumTypes.cpp.template: Added.
- UIProcess/API/gtk/WebKitEnumTypes.h.template: Added.
- UIProcess/API/gtk/WebKitFindController.cpp: We can no longer rely on WebKitEnumTypes.h to pull in WebKitWebView.h.
- 8:45 AM Changeset in webkit [150017] by
-
- 1 edit in trunk/Source/WebKit/mac/ChangeLog
Remove accidental unrelated ChangeLog entry from r150016.
- 8:29 AM Changeset in webkit [150016] by
-
- 6 edits in trunk/Source
Source/WebCore: [Mac] Move writeRange/PlainText/URL from ClipboardMac to PasteboardMac
https://bugs.webkit.org/show_bug.cgi?id=116009
Reviewed by Andreas Kling.
- dom/Clipboard.cpp:
(WebCore::Clipboard::writeRange): Added. Moved from ClipboardMac,
but added some FIXMEs.
(WebCore::Clipboard::writePlainText): Ditto.
(WebCore::Clipboard::writeURL): Ditto.
- dom/Clipboard.h: Made writeURL, writeRange, and writePlainText
non-virtual in non-legacy clipboard implementations.
- platform/mac/ClipboardMac.h: Removed writeRange, writeURL, and
writePlainText.
- platform/mac/ClipboardMac.mm: Ditto.
Source/WebKit/mac: [Mac] Layer-backed WebViews draw their background color even when setDrawsBackground:NO was called
https://bugs.webkit.org/show_bug.cgi?id=116014
<rdar://problem/12781227>
Reviewed by Andreas Kling.
- WebView/WebFrame.mm:
(-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Remove calls to setBackgroundColor: and
setDrawsBackground: on the document view. These were added to support a hypothetical document view
that wanted to draw its background like WebHTMLView does, but this was never communicated as a
document view protocol, formal or informal, and it's unlikely that it was ever used. The bug was
caused because there is an -[NSView setDrawsBackground:] method, probably an internal one, and we
were calling it unintentionally on a WebHTMLView.
- 8:29 AM Changeset in webkit [150015] by
-
- 10 edits in trunk/Source
[CoordGfx] requestAnimationFrame performance issues
https://bugs.webkit.org/show_bug.cgi?id=112345
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-05-13
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Removed current requestAnimationFrame logic from CoordinatedGraphics. The new logic
is entirely in WebKit2 CoordinatedLayerTreeHost.
Covered by existing tests in fast/animations.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(CoordinatedGraphicsScene):
Source/WebKit2:
Changed the logic of requestAnimationFrame in Coordinated Graphics.
We don't send any IPC messages for requestAnimationFrame. Instead, we do one of two things:
- If there is already a frame pending in the UI process, do nothing, as the animations would be serviced when the frame is returned to the web process.
- If there is no frame pending, we schedule a flush, making sure that that flush occurs at least 1/60 seconds after the last animation service, so that we don't get an infinite loop of flushes.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::requestAnimationFrame):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in:
- 8:14 AM Changeset in webkit [150014] by
-
- 3 edits in trunk/Source/WebCore
[texmap][GStreamer] Composited Video support
https://bugs.webkit.org/show_bug.cgi?id=86410
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-05-13
Reviewed by Philippe Normand.
Enable the video accelerated compositing using the WebKit's
TextureMapper.
This patch does not use hardware accelerated video decoding. It
provides a generic path for system memory buffers.
No new tests, already covered by existing tests.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): update the
texture content with the new received video buffer.
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint): choose to
use the accelerated compositing or the normal code path
(WebCore::MediaPlayerPrivateGStreamerBase::paint): if accelerated
compositing is used this method is halted.
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper): get
a texture from the pool and draws it if it is already available.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
(MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::platformLayer): returns itself
(WebCore::MediaPlayerPrivateGStreamerBase::supportsAcceleratedRendering):
returns true
- 8:05 AM Changeset in webkit [150013] by
-
- 3 edits in trunk/Source/WebCore
Document: Use a DeferrableOneShotTimer to throw out StyleResolver when unused.
<http://webkit.org/b/115929>
Reviewed by Anders Carlsson.
Nothing exciting here, just replacing a rickety-looking punting mechanism with a proper
DeferrableOneShotTimer. Note that the timeout changes from 60 to 30 seconds because DOST
works by punting a full interval on next timeout.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::didAccessStyleResolver):
(WebCore::Document::styleResolverThrowawayTimerFired):
- dom/Document.h:
(Document):
- 7:59 AM Changeset in webkit [150012] by
-
- 5 edits in trunk/Source/WebKit2
[WK2][CoordinatedGraphics] WKView needs API for handling opacity
https://bugs.webkit.org/show_bug.cgi?id=116032
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-05-13
Reviewed by Kenneth Rohde Christiansen.
Add WKViewSetOpacity and WKViewOpacity APIs and use them in
WebView.cpp.
- UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
(WKViewSetOpacity):
(WKViewOpacity):
- UIProcess/API/C/CoordinatedGraphics/WKView.h:
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::paintToCurrentGLContext):
- UIProcess/CoordinatedGraphics/WebView.h:
(WebKit::WebView::setOpacity):
(WebKit::WebView::opacity):
(WebView):
- 7:55 AM Changeset in webkit [150011] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r149287): FoldingText only shows me half of my text.
<http://webkit.org/b/115956>
<rdar://problem/13831099>
Reviewed by Antti Koivisto.
Check if the FrameView geometry changed post-layout, and send a resize event if needed.
This brings us closer to the original resize event behavior, with the exception that
setFrameRect() still fires an event right away if possible. This means we are still
guarded from FOUC's but frames that layout via [WebHTMLView layoutToMinimumPageWidth]
also get resize events like they used to.
No new tests, because I don't know how to test this.
- page/FrameView.h:
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::sendResizeEventIfNeeded):
Factor out the resize event logic from setFrameRect() so we can call it from both
there and performPostLayoutTasks(). sendResizeEventIfNeeded() only sends an event
if view geometry or zoom factor has changed since last time it was called.
- 7:26 AM Changeset in webkit [150010] by
-
- 10 edits in trunk/Source
Remove unneeded counters from ScopeContentDistribution.
https://bugs.webkit.org/show_bug.cgi?id=116028
Reviewed by Andreas Kling.
They don't do much.
- WebCore.exp.in:
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
- dom/ShadowRoot.h:
No need for registration code anymore.
- html/shadow/ContentDistributor.cpp:
(WebCore::ScopeContentDistribution::ScopeContentDistribution):
Default m_insertionPointListIsValid to true to avoid crawling when there are no InsertionPoints.
(WebCore::ScopeContentDistribution::ensureInsertionPointList):
(WebCore::ScopeContentDistribution::registerInsertionPoint):
(WebCore::ScopeContentDistribution::unregisterInsertionPoint):
- html/shadow/ContentDistributor.h:
Remove distributeNodeChildrenTo, it was only used by the older/younger shadow root code.
- testing/Internals.cpp:
- testing/Internals.h:
- testing/Internals.idl:
- 7:10 AM EFLHistoryApiTutorial edited by
- (diff)
- 7:03 AM Changeset in webkit [150009] by
-
- 2 edits1 delete in trunk/PerformanceTests
Web Inspector: Get rid of native-memory-snapshot in performance test
https://bugs.webkit.org/show_bug.cgi?id=116013
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-13
Reviewed by Andreas Kling.
Remove native-memory-snapshot.html from PerformanceTests.
- inspector/native-memory-snapshot.html: Removed.
- inspector/performance-test.js:
(initialize_TimeTracker.Timer):
(initialize_TimeTracker.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):
- 6:55 AM Changeset in webkit [150008] by
-
- 4 edits in trunk
[GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
https://bugs.webkit.org/show_bug.cgi?id=115918
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
Due to layer violations and circular dependencies the WebKitPluginProcess requires for the
libraries containing the built code of the intertwining Platform and WebCore layers to be
specified multiple times when linking. This can be avoided by packing the two layers' archives
into one big archive, named after the WebCore layer due to no clear boundary between it and the
Platform layer. The big archive can then be specified only once when linking, simplifying the code
and suppressing all the layering violations so they do not cause build problems.
First the libtool libraries that the WebCore layer (as required by the WebKitPluginProcess) depends on
are specified. These are then used as dependencies for the archive creation rule as well as the list
from which the archive file paths are constructed and then used to dump the member files from these archives.
The member files are then added to the big archive. The latter is added to the list of libraries the
WebKitPluginProcess requires to successfully link.
- GNUmakefile.am:
Tools:
Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
when linking, simplifying the code and suppressing all the layering violations so they do not cause build
problems.
First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
These are then used as dependencies for the archive creation rule as well as the list from which the archive
file paths are constructed and then used to dump the member files from these archives. The member files are
then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
successfully link.
- TestWebKitAPI/GNUmakefile.am:
- 6:52 AM Changeset in webkit [150007] by
-
- 11 edits1 delete in trunk
Remove UnusedParam.h
https://bugs.webkit.org/show_bug.cgi?id=116029
Reviewed by Andreas Kling.
Source/WTF:
Remove UnusedParam.h, it's empty now.
- GNUmakefile.list.am:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/UnusedParam.h: Removed.
Tools:
Stop including UnusedParam.h.
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- WebKitTestRunner/qt/TestInvocationQt.cpp:
- 6:14 AM Changeset in webkit [150006] by
-
- 1 copy in releases/WebKitGTK/webkit-2.0.2
Tagging the WebKitGTK+ 2.0.2 release
- 5:30 AM Changeset in webkit [150005] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0
Unreviewed. Update NEWS and Versions.m4 for 2.0.2 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.0.2.
- 4:32 AM Changeset in webkit [150004] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark several test cases as crashing on EFL port.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 4:08 AM Changeset in webkit [150003] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark 2 ref tests as failing on EFL port.
- platform/efl/TestExpectations:
- 4:00 AM Changeset in webkit [150002] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip 2 HTTP tests that time out of EFL port.
- platform/efl/TestExpectations:
- 3:53 AM Changeset in webkit [150001] by
-
- 1 edit6 adds in trunk/LayoutTests
Unreviewed EFL gardening.
Provide EFL baselines for several compositing test cases.
- platform/efl/compositing/backing/no-backing-for-clip-overhang-expected.txt: Added.
- platform/efl/compositing/contents-opaque/hidden-with-visible-child-expected.txt: Added.
- platform/efl/compositing/contents-opaque/hidden-with-visible-text-expected.txt: Added.
- platform/efl/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt: Added.
- 3:50 AM Changeset in webkit [150000] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Remove unused references from projects in Visual Studio
https://bugs.webkit.org/show_bug.cgi?id=116002
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-13
Reviewed by Csaba Osztrogonác.
nativeMemoryProfiler.css and NativeMemorySnapshotView.js were removed in r149807.
No new tests, no behavior change.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 1:53 AM Changeset in webkit [149999] by
-
- 20 edits in trunk
WebProcess consuming very high CPU on linkedin.com
https://bugs.webkit.org/show_bug.cgi?id=115601
Patch by Zalan Bujtas <Alan Bujtas> on 2013-05-13
Reviewed by Andreas Kling.
Disable WEB_TIMING_MINIMAL.
Turn off window.performance and performance.now(). Some JS frameworks expect
additional Web Timing APIs, when performance.now() is available.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- dom/EventTargetFactory.in:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::resetDOMWindowProperties):
(WebCore):
- page/DOMWindow.h:
(DOMWindow):
- page/DOMWindow.idl:
- page/Performance.cpp:
(WebCore::Performance::timing):
- page/Performance.h:
(Performance):
- page/Performance.idl:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
LayoutTests:
- platform/mac/TestExpectations:
- fast/js/global-constructors-attributes-expected.txt:
- 1:37 AM Changeset in webkit [149998] by
-
- 2 edits in trunk/Source/WebKit/mac
[Mac] Layer-backed WebViews draw their background color even when setDrawsBackground:NO was called
https://bugs.webkit.org/show_bug.cgi?id=116014
<rdar://problem/12781227>
Reviewed by Dan Bernstein.
- WebView/WebFrame.mm:
(-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Remove calls to setBackgroundColor: and
setDrawsBackground: on the document view. These were added to support a hypothetical document view
that wanted to draw its background like WebHTMLView does, but this was never communicated as a
document view protocol, formal or informal, and it's unlikely that it was ever used. The bug was
caused because there is an -[NSView setDrawsBackground:] method, probably an internal one, and we
were calling it unintentionally on a WebHTMLView.
- 12:55 AM Changeset in webkit [149997] by
-
- 3 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk
Merge r149666 - [GTK] Initialize WebKitWebPlugin path to prevent double-free
https://bugs.webkit.org/show_bug.cgi?id=115624
Patch by Tomas Popela <tpopela@redhat.com> on 2013-05-07
Reviewed by Carlos Garcia Campos.
Use GOwnPtr for WebKitWebPlugin path to prevent double-free
situations. Also use GOwnPtr for GError in webkit_web_plugin_get_path.
- webkit/webkitwebplugin.cpp:
(webkit_web_plugin_finalize):
(webkit_web_plugin_get_path):
- webkit/webkitwebpluginprivate.h:
- 12:46 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:43 AM Changeset in webkit [149996] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r149735 - [GStreamer] Does memory buffering even with preload set to none
https://bugs.webkit.org/show_bug.cgi?id=115754
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-05-08
Reviewed by Philippe Normand.
Covered by existing tests.
Revision 148840 fixed on-disk buffering being done when preload is set to none,
but memory buffering is still being done. That is because setting the state to
paused causes GStreamer to start loading the media, to gather information. Only
doing that when committing the load avoids that while maintaining the tested
behaviour unchanged.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load): move setting pause state to commitLoad.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): see above.
- 12:33 AM Changeset in webkit [149995] by
-
- 1 edit6 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Added platform specific expected files.
- platform/qt-5.0-wk1/compositing/backing/no-backing-for-clip-overhang-expected.txt: Added after r149969.
- platform/qt-5.0-wk2/compositing/contents-opaque/hidden-with-visible-child-expected.txt: Added after r149915.
- platform/qt-5.0-wk2/compositing/contents-opaque/hidden-with-visible-text-expected.txt: Added after r149915.
- platform/qt-5.0-wk2/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt: Added after r149914.
- platform/qt/compositing/backing/no-backing-for-clip-overhang-expected.txt: Added after r149969.
- 12:20 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:18 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:17 AM Changeset in webkit [149994] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r149494 - Updated WebKitGTK+ Translation for Odia [or] language.
https://bugs.webkit.org/show_bug.cgi?id=115030
Patch by Manoj Kumar Giri <mgiri@redhat.com> on 2013-05-02
Reviewed by Gustavo Noronha Silva.
- or.po: updated translation.
- 12:15 AM Changeset in webkit [149993] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk
Merge r149486 - Segmentation Fault with Romanian locale. Evolution not starting.
https://bugs.webkit.org/show_bug.cgi?id=115484
Reviewed by Darin Adler.
Do not translate the property names that are being passed to the g_param_spec_boolean
method - it is not required and is causing segfaults with various locales.
- webkit/webkitviewportattributes.cpp:
(webkit_viewport_attributes_class_init):
- 12:14 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:11 AM Changeset in webkit [149992] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r149192 - [GTK] Compilation of ProcessLauncherGtk.cpp fails due to unresolved symbols
https://bugs.webkit.org/show_bug.cgi?id=115240
Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-04-26
Reviewed by Martin Robinson.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: Includes sys/socket.h if OS is Linux
- 12:07 AM WebKitGTK/2.0.x edited by
- (diff)
