Timeline
May 23, 2013:
- 11:56 PM Changeset in webkit [150630] by
-
- 2 edits in trunk/Source/JavaScriptCore
CLoop llint backend should not use the d8 register as scratch register
https://bugs.webkit.org/show_bug.cgi?id=116019
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2013-05-23
Reviewed by Csaba Osztrogonác.
- offlineasm/cloop.rb:
- 11:26 PM Changeset in webkit [150629] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
https://bugs.webkit.org/show_bug.cgi?id=115245
Patch by Xiaobo Wang <xiaobwang@blackberry.com> on 2013-05-23
Reviewed by Rob Buis.
PR 330917.
Internally reviewed by Arvid Nilsson.
- Suspend/resumeRootLayerCommit when notified app activation state
change.
- Schedule root layer commit in resumeRootLayerCommit() to explicitly
start root layer commit timer, so that there's a commit even if
BackingStore got disabled/removed.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):
- 11:23 PM Changeset in webkit [150628] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Need to forward the opener frame url to client when creating a new window
https://bugs.webkit.org/show_bug.cgi?id=116566
Patch by Andy Chen <andchen@blackberry.com> on 2013-05-23
Reviewed by Rob Buis.
PR 337935
Internally reviewed by Arvid Nilsson.
When creating a new window, forward the opener frame url to client.
- Api/WebPageClient.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
- 11:20 PM Changeset in webkit [150627] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=116671
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-05-23
Reviewed by Brent Fulgham.
- page/FrameView.h: Added guard for ACCELERATED_COMPOSITING.
- 11:15 PM Changeset in webkit [150626] by
-
- 2 edits in trunk/Tools
Add missing dependencies to deps script.
[GTK] Missing packages in install-dependencies script.
https://bugs.webkit.org/show_bug.cgi?id=116632
Reviewed by Martin Robinson.
- gtk/install-dependencies:
- 11:07 PM Changeset in webkit [150625] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Compositor API change: Don't pass the unused "viewport" parameter.
https://bugs.webkit.org/show_bug.cgi?id=116545
Internal PR 189775
Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-05-23
Reviewed by Rob Buis.
Also change the name of the "documentContents" parameter
to the more descriptive "documentSrcRect".
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositor::render):
- Api/WebPageCompositor.h:
- Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
- 10:14 PM Changeset in webkit [150624] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL][QT] Build break after r150610
https://bugs.webkit.org/show_bug.cgi?id=116699
Patch by Ryuan Choi <ryuan.choi@samsung.com> on 2013-05-23
Reviewed by Csaba Osztrogonác.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin): Initialized pluginProcessSandboxPolicy.
- 7:59 PM Changeset in webkit [150623] by
-
- 1 copy in tags/Safari-537.43.1
New Tag.
- 6:35 PM Changeset in webkit [150622] by
-
- 11 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: rationalize DFG::CapabilityLevel and DFGCapabilities.[h|cpp]
https://bugs.webkit.org/show_bug.cgi?id=116696
Reviewed by Sam Weinig.
Make it so that all capability calculation is funneled through one function, which tells
you everything you wanted to know: can it be inlined, and can it be compiled.
This work will help with https://bugs.webkit.org/show_bug.cgi?id=116557, since now the
JIT has a fairly authoritative answer to the "can it be inlined" question.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::capabilityLevelInternal):
(JSC::EvalCodeBlock::capabilityLevelInternal):
(JSC::FunctionCodeBlock::capabilityLevelInternal):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::capabilityLevel):
(JSC::CodeBlock::capabilityLevelState):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::debugFail):
(DFG):
(JSC::DFG::canInlineResolveOperations):
(JSC::DFG::capabilityLevel):
- dfg/DFGCapabilities.h:
(DFG):
(JSC::DFG::capabilityLevel):
(JSC::DFG::evalCapabilityLevel):
(JSC::DFG::programCapabilityLevel):
(JSC::DFG::functionForCallCapabilityLevel):
(JSC::DFG::functionForConstructCapabilityLevel):
(JSC::DFG::canInlineFunctionForCall):
(JSC::DFG::canInlineFunctionForClosureCall):
(JSC::DFG::canInlineFunctionForConstruct):
- dfg/DFGCommon.h:
(JSC::DFG::canCompile):
(DFG):
(JSC::DFG::canInline):
(JSC::DFG::leastUpperBound):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- tools/CodeProfile.cpp:
(JSC::CodeProfile::sample):
- 6:33 PM Changeset in webkit [150621] by
-
- 2 edits in trunk/Source/WTF
[Windows] Rolling back r150600 as it breaks the VS2010 builds.
- wtf/StackBounds.cpp: Rollback.
- 5:43 PM Changeset in webkit [150620] by
-
- 7 edits in trunk/Source/WebKit2
Shim Flash plug-in to allow its updater to run
https://bugs.webkit.org/show_bug.cgi?id=116692
<rdar://problem/13938510>
Reviewed by Sam Weinig.
- PluginProcess/PluginProcess.h:
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::replacedNSConcreteTask_launch):
(WebKit::initializeCocoaOverrides):
Patch -[NSConcreteTask launch] to call PluginProcess::launchProcess.
(WebKit::PluginProcess::launchProcess):
Send a LaunchProcess message to the UI process.
- UIProcess/Plugins/PluginProcessProxy.cpp:
- UIProcess/Plugins/PluginProcessProxy.h:
Remove PluginProcessProxy::didReceiveMessage.
(PluginProcessProxy):
- UIProcess/Plugins/PluginProcessProxy.messages.in:
Add LaunchProcess message and remove LegacyReceiver attribute.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::isFlashUpdater):
Helper function to determine whether the process is the flash updater.
(WebKit::shouldLaunchProcess):
Return whether we should launch this process.
(WebKit::PluginProcessProxy::launchProcess):
Determine if we should launch this process and then do so.
- 5:41 PM Changeset in webkit [150619] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed change for NRWT support.
- Scripts/webkitpy/port/win.py:
(WinPort.default_child_processes): Added a default implementation
that limits NRWT to a single instance.
- 5:03 PM Changeset in webkit [150618] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Modify WebCore for AppleWin 2010 production build.
- WebCore.vcxproj/WebCoreGenerated.make:
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
- 4:44 PM Changeset in webkit [150617] by
-
- 2 edits in trunk/LayoutTests
[EFL] Rebaseline after r150593
https://bugs.webkit.org/show_bug.cgi?id=116695
Unreviewed gardening.
Moved some editing tests from execCommand into pasteboard.
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-23
- platform/efl/TestExpectations:
- 4:22 PM Changeset in webkit [150616] by
-
- 6 edits in trunk/LayoutTests
Make Math.imul tests run quicker, and fix some other bugs.
Rubber stampted by Oliver Hunt.
Also make tests not call print().
- fast/js/regress/script-tests/cell-argument.js:
- fast/js/regress/script-tests/imul-double-only.js:
(f):
- fast/js/regress/script-tests/imul-int-only.js:
(f):
- fast/js/regress/script-tests/imul-mixed.js:
(f):
- fast/js/regress/script-tests/object-closure-call.js:
- 4:00 PM Changeset in webkit [150615] by
-
- 2 edits in trunk/Tools
Remove meaningless "test_uses_apache" from Python test cases.
https://bugs.webkit.org/show_bug.cgi?id=38756
Patch by Brent Fulgham <Brent Fulgham> on 2013-05-23
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_driver_cmd_line): Remove the meaningless
"test_uses_apache" test case from the Python test infrastructure.
It was hard-coded to true, even though not all ports use
Apache.
- 2:44 PM Changeset in webkit [150614] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150610. <rdar://problem/13975569>
- 2:17 PM Changeset in webkit [150613] by
-
- 3 edits in trunk/Source/WebCore
We need to clear main resource when detaching DocumentLoader from the frame.
https://bugs.webkit.org/show_bug.cgi?id=116680
Normally, when we detach the documentLoader in DocumentLoader::detachFromFrame, main resource is also cleared
in stopLoading(). There is possibility that main resource not being cleared, and this could cause crash later
since docLoader could still receive resource callbacks. To avoid that, we can remove docLoader from main resource's
client set in detachFromFrame.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-05-23
Reviewed by Brady Eidson.
No new tests, this doesn't happen on OS X.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::detachFromFrame):
(WebCore::DocumentLoader::clearMainResource):
- loader/cache/CachedResource.h: make hasClient accessible publicly.
(WebCore::CachedResource::hasClient):
(CachedResource):
- 1:59 PM Changeset in webkit [150612] by
-
- 3 edits in trunk/Tools
[Windows] Update new-run-webkit-tests for Windows port.
https://bugs.webkit.org/show_bug.cgi?id=38756
Patch by Brent Fulgham <bfulgham@webkit.org> on 2013-05-23
Reviewed by Ryosuke Niwa.
- Scripts/new-run-webkit-httpd:
(run): Switch from 'chromium' to 'win'
- Scripts/webkitpy/port/win.py:
(WinPort): Add support methods for lighttpd server.
(WinPort._uses_apache):
(WinPort._path_to_lighttpd):
(WinPort._path_to_lighttpd_modules):
(WinPort._path_to_lighttpd_php):
- 1:56 PM Changeset in webkit [150611] by
-
- 3 edits2 adds in trunk
assertion failed: !node node->isElementNode() in WebCore::RenderBlock::clone https://bugs.webkit.org/show_bug.cgi?id=116614
Patch by Mihai Maerean <Mihai Maerean> on 2013-05-23
Reviewed by David Hyatt.
Source/WebCore:
Add a test for flow threads so they don't end up being cloned in region based multi columns with columns:1 where
the only child has column-span:all.
Test: fast/multicol/newmulticol/direct-child-column-span-all.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
LayoutTests:
- fast/multicol/newmulticol/direct-child-column-span-all-expected.txt: Added.
- fast/multicol/newmulticol/direct-child-column-span-all.html: Added.
- 1:48 PM Changeset in webkit [150610] by
-
- 2 edits in trunk/Source/WebKit2
Don't run all plug-ins unsandboxed
https://bugs.webkit.org/show_bug.cgi?id=116690
<rdar://problem/13975569>
Reviewed by Jessie Berlin.
Remove debugging code.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
- 1:08 PM Changeset in webkit [150609] by
-
- 7 edits in trunk/Source
Crash in convertMainResourceLoadToDownload when downloading file by option-return
https://bugs.webkit.org/show_bug.cgi?id=116451
Reviewed by Andreas Kling.
Source/WebCore:
Handle MainResourceLoader being null here which will happen when loading a cached main resource.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::continueAfterContentPolicy):
Source/WebKit/mac:
If the main resource loader is null, create a new download instead since there's no existing loader to convert.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::convertMainResourceLoadToDownload):
Source/WebKit2:
If the main resource loader is null, create a new download instead since there's no existing loader to convert.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::convertMainResourceLoadToDownload):
- 12:56 PM Changeset in webkit [150608] by
-
- 2 edits in trunk/LayoutTests
Remove a stale test expectation.
- platform/wk2/TestExpectations:
- 12:49 PM Changeset in webkit [150607] by
-
- 2 edits in trunk/LayoutTests
Update Mac test expectations for the bug 85408 as bugs 116398 and 116477 have been merged into it.
- platform/mac/TestExpectations:
- 12:46 PM Changeset in webkit [150606] by
-
- 12 edits in trunk/Source/WebCore
KURL::createCFURL() should return a RetainPtr<CFURLRef>
https://bugs.webkit.org/show_bug.cgi?id=116644
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-23
Reviewed by Andreas Kling.
For consistency with the other createCFType() APIs in WebKit, KURL should
return a RetainPtr<> instead of raw +1 CFURLRef.
No leak were discovered while making this change.
- platform/KURL.h:
- platform/cf/KURLCFNet.cpp:
(WebCore):
(WebCore::createCFURLFromBuffer):
(WebCore::KURL::createCFURL):
(WebCore::KURL::fileSystemPath):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::createAssetForURL):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setURLForRect):
- platform/mac/KURLMac.mm:
(WebCore):
(WebCore::KURL::operator NSURL *):
(WebCore::KURL::createCFURL):
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
- platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
- platform/network/cf/ProxyServerCFNet.cpp:
(WebCore::addProxyServersForURL):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
- platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::cfURLResponse):
- platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
- 12:42 PM Changeset in webkit [150605] by
-
- 2 edits in trunk/LayoutTests
Add back failing test expectations for the bugs 88672 and 89528 after r150558 and r150559 on Lion.
- platform/mac/TestExpectations:
- 12:37 PM Changeset in webkit [150604] by
-
- 2 edits in trunk/LayoutTests
fast/workers/storage/use-same-database-in-page-and-workers.html times out on the lion bots
https://bugs.webkit.org/show_bug.cgi?id=81618
Add back the flaky test failure on Mac.
- platform/mac/TestExpectations:
- 12:19 PM Changeset in webkit [150603] by
-
- 3 edits in trunk/Source/WTF
Use correct stack size on Solaris and OpenBSD
https://bugs.webkit.org/show_bug.cgi?id=114978
Reviewed by Oliver Hunt.
Original patch by David Hill <david@wmol.com>.
Use stack_t.ss_size for getting the size of the stack.
- wtf/Platform.h:
- wtf/StackBounds.cpp:
(WTF):
(WTF::StackBounds::initialize):
- 11:55 AM Changeset in webkit [150602] by
-
- 5 edits2 adds in trunk
The ellipsis in a text overflow should not avoid floats
https://bugs.webkit.org/show_bug.cgi?id=115746
Reviewed by David Hyatt.
Source/WebCore:
When placing an ellipsis for text overflow we shouldn't avoid any floats on the line.
That is to say, if there is a float in the box we overflow we should let our no-wrap text,
including the ellipsis, render inside the float just as we would if overflow was hidden but
a text-overflow rendering had not been specified.
Test: fast/css/text-overflow-ellipsis-behind-floats.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkLinesForTextOverflow):
LayoutTests:
- fast/css/text-overflow-ellipsis-behind-floats-expected.html: Added.
- fast/css/text-overflow-ellipsis-behind-floats.html: Added.
- fast/css/text-overflow-ellipsis-full-truncate-rtl-expected.html:
- fast/css/text-overflow-ellipsis-full-truncate-rtl.html: Change this test to expect the text to cross into the floating input element and render the ellipsis at the left extreme of the element. The previous expected rendering relied on the incorrect premise that an overflow ellipsis should avoid floated elements.
- 11:51 AM Changeset in webkit [150601] by
-
- 15 edits in branches/safari-537.43-branch/Source
Merged r150556. <rdar://problem/13918391>
- 11:51 AM Changeset in webkit [150600] by
-
- 2 edits in trunk/Source/WTF
[WIN] Implement correct detection of stack size
https://bugs.webkit.org/show_bug.cgi?id=116661
Reviewed by Oliver Hunt.
- wtf/StackBounds.cpp:
(WTF):
(WTF::StackBounds::initialize):
- 11:49 AM Changeset in webkit [150599] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13849260> Sandbox violations reading .CFUserTextEncoding
Reviewed by Dan Bernstein.
- WebProcess/com.apple.WebProcess.sb.in: Allow this.
- 11:48 AM Changeset in webkit [150598] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150543. <rdar://problem/13904054>
- 11:44 AM Changeset in webkit [150597] by
-
- 6 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150537. <rdar://problem/13964515>
- 11:30 AM Changeset in webkit [150596] by
-
- 3 edits in trunk/LayoutTests
[Lion] [WK2] compositing/overflow/overflow-compositing-descendant.html
https://bugs.webkit.org/show_bug.cgi?id=116684
Add a timeout/failure test expectation. Also update the expected result since the first frame
of the video must be shown in this test.
- platform/mac-wk2/TestExpectations:
- platform/mac/compositing/overflow/overflow-compositing-descendant-expected.png:
- 11:03 AM Changeset in webkit [150595] by
-
- 2 edits in trunk/Source/WebKit2
Move posix_spawn onto a zero delay timer
https://bugs.webkit.org/show_bug.cgi?id=116682
Reviewed by Anders Carlson.
<rdar://problem/13973468>
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
(ReexecInfo):
- struct to hold info from the XPC message.
(WebKit::reexec):
- moved call to posix_spawn out to this helper.
(WebKit::reexecCallBack):
- calls reexec.
(WebKit::XPCServiceEventHandler):
- removed call to posix_spawn; schedule a call to reexecCallBack.
- 10:52 AM Changeset in webkit [150594] by
-
- 4 edits in trunk/LayoutTests
Fix loader/go-back-cached-main-resource.html test
https://bugs.webkit.org/show_bug.cgi?id=116670
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-05-23
Reviewed by Alexey Proskuryakov.
The page does not get an onload when being restored from page cache. The
test case case is modified to handle pageshow event instead.
- loader/go-back-cached-main-resource.html: Wait for the third
'first-page' message to finish the test.
- loader/resources/first-page.html: Use onpageshow instead of onload.
- loader/resources/other-page.html: Ditto.
- 10:50 AM Changeset in webkit [150593] by
-
- 1 edit13 moves in trunk/LayoutTests
Several editing tests that copy & paste slow down Mac WK2 EWS
https://bugs.webkit.org/show_bug.cgi?id=116681
Reviewed by Anders Carlsson.
Move editing tests that trigger copy and paste from execCommand into pasteboard.
Since NWRT uses a single instance of WebKitTestRunner to run tests in single directory,
this should mitigate the issue for now.
In the long term, we should really mock out the clipboard in WebKitTestRunner.
- editing/execCommand/4128080-2-expected.txt: Removed.
- editing/execCommand/4128080-2.html: Removed.
- editing/execCommand/5939887-expected.txt: Removed.
- editing/execCommand/5939887.html: Removed.
- editing/execCommand/copy-without-selection-expected.txt: Removed.
- editing/execCommand/copy-without-selection.html: Removed.
- editing/execCommand/paste-2.html: Removed.
- editing/pasteboard/copy-cut-paste-events-fired-when-disabled-expected.txt: Copied from LayoutTests/editing/execCommand/5939887-expected.txt.
- editing/pasteboard/copy-cut-paste-events-fired-when-disabled.html: Copied from LayoutTests/editing/execCommand/5939887.html.
- editing/pasteboard/copy-inside-h1-preserves-h1-expected.txt: Copied from LayoutTests/editing/execCommand/4128080-2-expected.txt.
- editing/pasteboard/copy-inside-h1-preserves-h1.html: Copied from LayoutTests/editing/execCommand/4128080-2.html.
- editing/pasteboard/copy-without-selection-expected.txt: Copied from LayoutTests/editing/execCommand/copy-without-selection-expected.txt.
- editing/pasteboard/copy-without-selection.html: Copied from LayoutTests/editing/execCommand/copy-without-selection.html.
- editing/pasteboard/paste-2.html: Copied from LayoutTests/editing/execCommand/paste-2.html.
- platform/gtk/editing/execCommand/paste-2-expected.png: Removed.
- platform/gtk/editing/execCommand/paste-2-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-2-expected.png: Copied from LayoutTests/platform/gtk/editing/execCommand/paste-2-expected.png.
- platform/gtk/editing/pasteboard/paste-2-expected.txt: Copied from LayoutTests/platform/gtk/editing/execCommand/paste-2-expected.txt.
- platform/mac/editing/execCommand/paste-2-expected.png: Removed.
- platform/mac/editing/execCommand/paste-2-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-2-expected.png: Copied from LayoutTests/platform/mac/editing/execCommand/paste-2-expected.png.
- platform/mac/editing/pasteboard/paste-2-expected.txt: Copied from LayoutTests/platform/mac/editing/execCommand/paste-2-expected.txt.
- platform/qt/editing/execCommand/paste-2-expected.png: Removed.
- platform/qt/editing/execCommand/paste-2-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-2-expected.png: Copied from LayoutTests/platform/qt/editing/execCommand/paste-2-expected.png.
- platform/qt/editing/pasteboard/paste-2-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/paste-2-expected.txt.
- 10:49 AM Changeset in webkit [150592] by
-
- 2 edits in trunk/Tools
Make default bug links in buildbot clickable
https://bugs.webkit.org/show_bug.cgi?id=116673
Reviewed by Ryosuke Niwa.
Use changecommentlink of html.WebStatus to make the links clickable.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 10:39 AM WebKit Team edited by
- (diff)
- 10:17 AM Changeset in webkit [150591] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
EWS bubbles need more space
https://bugs.webkit.org/show_bug.cgi?id=116675
Reviewed by Andreas Kling.
- template/en/custom/attachment/list.html.tmpl:
- 9:45 AM Changeset in webkit [150590] by
-
- 13 edits in trunk
Unreviewed, rolling out r150586.
http://trac.webkit.org/changeset/150586
https://bugs.webkit.org/show_bug.cgi?id=116660
Those constructors should be exposed on the WorkerContext, not
the DOMWindow
Source/WebCore:
- fileapi/FileReaderSync.idl:
- workers/WorkerLocation.idl:
LayoutTests:
- fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/constructor-length-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/fast/js/constructor-length-expected.txt:
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/mac/fast/js/constructor-length-expected.txt:
- platform/qt/fast/js/constructor-length-expected.txt:
- platform/qt/fast/js/global-constructors-attributes-expected.txt:
- 9:13 AM Changeset in webkit [150589] by
-
- 2 edits in trunk/LayoutTests
[CSS Regions][Mac] [WK2] Layout Test fast/regions/fixed-pos-elem-in-region.html is flaky on Debug builders
https://bugs.webkit.org/show_bug.cgi?id=114571
Tests seems to be passing now, removed from TestExpectations.
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-23
Reviewed by Anders Carlsson.
- platform/mac-wk2/TestExpectations:
- 9:11 AM Changeset in webkit [150588] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] The web context does not contain any link properties if the context node is an image enclosed by a link node
https://bugs.webkit.org/show_bug.cgi?id=116627
Patch by Ed Baker <edbaker@blackberry.com> on 2013-05-23
Reviewed by Xan Lopez.
PR #341084
If the context node has an image tag and an enclosing link node was detected then add the link properties to the context.
Internally Reviewed by Gen Mak.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
- 8:55 AM Changeset in webkit [150587] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Validate form data before doing direct submission.
https://bugs.webkit.org/show_bug.cgi?id=116674
Reviewed by Xan Lopez.
PR 314202.
Check validation of the input form before triggering direct submission.
Internally Reviewed by Nima Ghanavatian.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::submitForm):
- 8:20 AM Changeset in webkit [150586] by
-
- 13 edits in trunk
Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation
https://bugs.webkit.org/show_bug.cgi?id=116660
Reviewed by Kentaro Hara.
Source/WebCore:
Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation to match their
respective specifications:
- http://dev.w3.org/2006/webapi/FileAPI/#FileReaderSync
- http://dev.w3.org/html5/workers/#workerlocation
No new tests, covered by existing tests.
- fileapi/FileReaderSync.idl:
- workers/WorkerLocation.idl:
LayoutTests:
Rebaseline a couple of test cases now that FileReaderSync and WorkerLocation
attributes are exposed on the global Window object.
- fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/constructor-length-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/fast/js/constructor-length-expected.txt:
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/mac/fast/js/constructor-length-expected.txt:
- platform/qt/fast/js/constructor-length-expected.txt:
- platform/qt/fast/js/global-constructors-attributes-expected.txt:
- 7:14 AM Changeset in webkit [150585] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
https://bugs.webkit.org/show_bug.cgi?id=116603
Patch by Rob Buis <rbuis@rim.com> on 2013-05-23
Reviewed by Xan Lopez.
PR 119789
Internally reviewed by Yong Li.
Provide a domain value for this ResourceError instance. Note that
this does not change behavior.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
- 7:00 AM Changeset in webkit [150584] by
-
- 3 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk2/TestExpectations: Skip some failing test.
- platform/qt-5.0-wk2/fast/forms/select-baseline-expected.png: Rebaselined after r148594.
- platform/qt-5.0-wk2/fast/forms/select-baseline-expected.txt:
- platform/qt-5.0-wk2/fast/images/repaint-subrect-grid-expected.txt: Rebaselined after r149292.
- 6:42 AM TestExpectations edited by
- Link to "Writing Reftests" to explain more on reference tests (diff)
- 6:17 AM Changeset in webkit [150583] by
-
- 2 edits in trunk/Source/WebKit2
[cmake] Fix generating-forwarding-headers rule after r150460
https://bugs.webkit.org/show_bug.cgi?id=116659
Reviewed by Christophe Dumez.
- CMakeLists.txt: Typo fix.
- 5:45 AM Changeset in webkit [150582] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Remote Web Inspector sometimes won't serve any content
https://bugs.webkit.org/show_bug.cgi?id=116225
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-05-23
Reviewed by Gustavo Noronha Silva.
Added an option to use environment variable to set up path to
inspector server files. Implementation is similar to InspectorClientGtk
implementation.
- UIProcess/InspectorServer/WebInspectorServer.h:
(WebInspectorServer):
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath):
(WebKit::WebInspectorServer::inspectorServerFilesPath):
(WebKit):
- 5:30 AM Changeset in webkit [150581] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Use WK2 C API in ewk_view_pagination_mode_set|get
https://bugs.webkit.org/show_bug.cgi?id=116657
Reviewed by Christophe Dumez.
WKPageGet|SetPaginationMode APIs is present in WK2 C APIs. So, we need to use them for
ewk_view_pagination_mode_set|get.
Besides we don't need to use WebCore namespace anymore.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):
- 5:22 AM Changeset in webkit [150580] by
-
- 13 edits in trunk/Source/WebCore
Remove special case for MessagePortArray from bindings generator
https://bugs.webkit.org/show_bug.cgi?id=116653
Reviewed by Kentaro Hara.
Use MessagePort[] instead of MessagePortArray type in the IDL as MessagePortArray
is not defined on IDL side. This allows us to remove the special case for
MessagePortArray from the bindings generator.
No new tests, no behavior change.
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data):
- bindings/scripts/CodeGeneratorJS.pm:
(NativeToJSValue): Remove special case for MessagePortArray.
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
(WebDOMTestSerializedScriptValueInterface):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_get_property):
(webkit_dom_test_serialized_script_value_interface_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::jsTestSerializedScriptValueInterfacePorts):
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
- bindings/scripts/test/TestSerializedScriptValueInterface.idl: Replace MessagePortArray
by MessagePort[].
- dom/MessageEvent.h:
(WebCore::MessageEvent::ports): The method should return a Vector, not a Vector*
as the array on JavaScript side is not nullable.
- dom/MessageEvent.idl: Replace MessagePortArray by MessagePort[].
- 3:32 AM Changeset in webkit [150579] by
-
- 3 edits in trunk/LayoutTests
media/W3C/video/networkState/networkState_during_progress.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=76280
Unreviewed gardening.
Change expectation to the correct output and mark as flaky.
- TestExpectations:
- media/W3C/video/networkState/networkState_during_progress-expected.txt:
- 2:26 AM Changeset in webkit [150578] by
-
- 4 edits in trunk/Source/WebKit2
Support frame instrumentation for coordinated graphics
https://bugs.webkit.org/show_bug.cgi?id=115260
Patch by Roland Takacs <rtakacs@inf.u-szeged.hu> on 2013-05-23
Reviewed by Andreas Kling.
Enabled supportsFrameInstrumentation on ports that use coordinated graphics
by calling didBeginFrame().
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::supportsFrameInstrumentation):
(WebKit):
- WebProcess/WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::syncDisplayState):
- 2:20 AM Changeset in webkit [150577] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/TestExpectations: Remove a test failure that skipped in qt.
- platform/qt/TestExpectations: Unskip now passing test.
- 1:39 AM Changeset in webkit [150576] by
-
- 3 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk2/TestExpectations: Unskip after rebaseline.
- platform/qt/TestExpectations: Skip flaky test.
- platform/qt/plugins/mouse-events-expected.txt: Rebaselining after r150558.
- 12:06 AM Changeset in webkit [150575] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Back, Forward and Stop should be hidden in context menu
https://bugs.webkit.org/show_bug.cgi?id=116615
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-05-23
Reviewed by Christophe Dumez.
Context menu items: Back, Forward, Stop, Reload, should be shown only when
they are able to perform action.
No new tests - no new functionality.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
May 22, 2013:
- 11:32 PM Changeset in webkit [150574] by
-
- 2 edits in trunk/LayoutTests
Updated the bug associated with the failure of media/context-menu-actions.html
from the bug 45021 to the bug 116651 since the former is the bug for which this test was added.
Also skip this test it has been timing out intermittently.
- platform/mac/TestExpectations:
- 11:22 PM Changeset in webkit [150573] by
-
- 2 edits in trunk/LayoutTests
Update Mac test expectation for the bug 82980.
The test is consistently timing out instead of being flaky now.
- platform/mac/TestExpectations:
- 11:20 PM Changeset in webkit [150572] by
-
- 2 edits in trunk/LayoutTests
Add back two Lion test expectations after r150558 and r150559.
- platform/mac/TestExpectations:
- 11:03 PM Changeset in webkit [150571] by
-
- 3 edits in trunk/LayoutTests
Make the test expectation for the bug 116649 specific to WK2
as the test is passing on WK1.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 11:01 PM Changeset in webkit [150570] by
-
- 3 edits in trunk/LayoutTests
Mark media/audio-repaint.html as always failing on Mac.
Also add back a failing test expectation to compositing/rtl/rtl-fixed-overflow-scrolled.html on Mac WK2.
Also add failing test expectation for the bug 116649.
- platform/mac/TestExpectations:
- 10:18 PM Changeset in webkit [150569] by
-
- 3 edits3 adds in trunk
Use uninitialized register in "JIT::emit_op_neq_null" and "emit_op_eq_null"
https://bugs.webkit.org/show_bug.cgi?id=116593
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2013-05-22
Reviewed by Filip Pizlo.
Generated instructions using uninitialized register. It's caused by a mistake of r126494.
Source/JavaScriptCore:
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
LayoutTests:
- fast/js/neq-null-crash-expected.txt: Added.
- fast/js/neq-null-crash.html: Added.
- fast/js/script-tests/neq-null-crash.js: Added.
- 10:07 PM Changeset in webkit [150568] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
Merge http://trac.webkit.org/changeset/149162, since we need it after
we merged some bytecode refactorings.
2013-04-25 Filip Pizlo <fpizlo@apple.com>
DFG doesn't support to_jsnumber
https://bugs.webkit.org/show_bug.cgi?id=115129
Reviewed by Geoffrey Garen.
Based on Oliver's patch. Implements to_jsnumber as Identity(Number:@thingy), and then does
an optimization in Fixup to turn Identity(Number:) into Identity(Int32:) if the predictions
tell us to. Identity is later turned into Phantom.
Also fixed BackPropMask, which appeared to have NodeDoesNotExit included in it. That's
wrong; NodeDoesNotExit is not a backward propagation property.
Also fixed Identity to be marked as CanExit (i.e. not NodeDoesNotExit).
This more than doubles the FPS on ammo.
- dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h: (JSC::DFG::canCompileOpcode):
- dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (FixupPhase): (JSC::DFG::FixupPhase::observeUseKindOnNode): (JSC::DFG::FixupPhase::observeUseKindOnEdge):
- dfg/DFGNodeFlags.h: (DFG):
- dfg/DFGNodeType.h: (DFG):
- dfg/DFGPredictionPropagationPhase.cpp: (JSC::DFG::PredictionPropagationPhase::propagate):
- 10:00 PM Changeset in webkit [150567] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
Fix indentation of CodeBlock.h
Rubber stamped by Mark Hahnenberg.
- bytecode/CodeBlock.h:
- 10:00 PM Changeset in webkit [150566] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indentation of CodeBlock.h
Rubber stampted by Mark Hahnenberg.
- bytecode/CodeBlock.h:
- 9:53 PM Changeset in webkit [150565] by
-
- 22 edits in branches/dfgFourthTier/Source/JavaScriptCore
Rename getJITCode and getJITType to jitCode and jitType.
Rubber stampted by Mark Hahnenberg.
- assembler/RepatchBuffer.h:
(JSC::RepatchBuffer::RepatchBuffer):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::resetStubInternal):
(JSC::CodeBlock::stronglyVisitWeakReferences):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::codeOriginForReturn):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::ProgramCodeBlock::jitCompileImpl):
(JSC::EvalCodeBlock::jitCompileImpl):
(JSC::FunctionCodeBlock::jitCompileImpl):
(JSC::CodeBlock::setOptimizationThresholdBasedOnCompilationResult):
(JSC::CodeBlock::adjustedExitCountThreshold):
(JSC::CodeBlock::tallyFrequentExitSites):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::getCallLinkInfo):
(JSC::CodeBlock::jitCode):
(JSC::CodeBlock::jitCodeWithArityCheck):
(JSC::CodeBlock::jitType):
(JSC::CodeBlock::hasBaselineJITProfiling):
(JSC::CodeBlock::jitCompile):
(JSC::CodeBlock::addFrequentExitSite):
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan):
(JSC::ExecState::isInlineCallFrame):
- dfg/DFGAssemblyHelpers.cpp:
(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::codeLocationForRepatch):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
- dfg/DFGOperations.cpp:
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExit::codeLocationForRepatch):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileFTLOSRExit):
- heap/DFGCodeBlocks.cpp:
(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::clearMarks):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):
(JSC::DFGCodeBlocks::traceMarkedCodeBlocks):
- interpreter/Interpreter.cpp:
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriateImpl):
(JSC::jitCompileFunctionIfAppropriateImpl):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Executable.cpp:
(JSC::jettisonCodeBlock):
(JSC::EvalExecutable::compileOptimized):
(JSC::EvalExecutable::jettisonOptimizedCode):
(JSC::ProgramExecutable::compileOptimized):
(JSC::ProgramExecutable::jettisonOptimizedCode):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::jettisonOptimizedCodeForCall):
(JSC::FunctionExecutable::jettisonOptimizedCodeForConstruct):
- tools/CodeProfile.cpp:
(JSC::CodeProfile::sample):
- 9:26 PM Changeset in webkit [150564] by
-
- 2 edits in trunk/Tools
REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
https://bugs.webkit.org/show_bug.cgi?id=116595
Temporarily skip this test.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
(TestWebKitAPI::TEST):
- 9:15 PM Changeset in webkit [150563] by
-
- 5 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Race between LLInt->Baseline tier-up and DFG reading Baseline profiling data
https://bugs.webkit.org/show_bug.cgi?id=116633
Reviewed by Mark Hahnenberg.
Previously we would check if we had Baseline JIT profiling data by seeing if the
appropriate vector was non-empty. This is horrible if we're doing LLInt->Baseline
tier-up at the same time. This will happen for code we are inlining, if we're
deciding to inline it before the LLInt->Baseline tier-up happened for that code.
This changes things to take advantage of the fact that the very last thing that
LLInt->Baseline tier-up will do (in JITDriver.h) is setJITCode(). We now precede
the actual work in setJITCode() with a store-store fence to ensure that all
stores to modify the CodeBlock happen before setting the JITCode, and we modify
CodeBlock::getJITType() to use load-load fences to ensure that if you see
JITCode::BaselineJIT then you will also see all of those vectors. Then this
changes all of the code that scrapes Baseline JIT profiles to check if
getJITType() returns JITCode::BaselineJIT instead of checking vector sizes.
The outcome is that for the non-racy cases we behave as we did before (we fall
back on LLInt profiling if the tier-up hasn't happened) and for racy cases we
use LLInt profiling conservatively.
Note that for some (but not all!) of the cases where we scrape Baseline JIT
profiling, we would have anyway been holding the CodeBlock::m_lock so we can also
fix those cases by just having setJITCode graph that lock. This patch does that
also, mainly because although we only call setJITCode() from the main thread, in
general it's dangerous to have a pointer to a ref-counted object being modified
in a racy way. So, this patch just does the most conservative thing possible that
does we can afford to do.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::getJITType):
(JSC::CodeBlock::hasBaselineJITProfiling):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::couldTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- 8:41 PM Changeset in webkit [150562] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip 3 more tests which has problem related to ecore library.
- platform/efl/TestExpectations:
- 8:36 PM Changeset in webkit [150561] by
-
- 13 edits4 deletes in trunk/Source
Rolling out r150555. It borked about 30 media tests.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
- html/HTMLMediaElement.h:
- platform/audio/AudioSession.cpp:
(WebCore):
(WebCore::AudioSession::AudioSession):
(WebCore::AudioSession::preferredBufferDuration):
(WebCore::AudioSession::setPreferredBufferDuration):
- platform/audio/AudioSession.h:
- platform/audio/AudioSessionListener.h:
(AudioSessionListener):
- platform/audio/AudioSessionManager.cpp: Removed.
- platform/audio/AudioSessionManager.h: Removed.
- platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestinationIOS::configure):
- platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::preferredBufferDuration):
(WebCore::AudioSession::setPreferredBufferDuration):
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationMac::AudioDestinationMac):
(WebCore::AudioDestinationMac::configure):
- platform/audio/mac/AudioDestinationMac.h:
(AudioDestinationMac):
- platform/audio/mac/AudioSessionMac.cpp: Removed.
- platform/audio/mac/AudioSessionManagerMac.cpp: Removed.
Source/WTF:
- wtf/Platform.h:
- 6:11 PM Changeset in webkit [150560] by
-
- 9 edits in trunk/Source/WebCore
Active DOM object resumption should match reason for suspending
https://bugs.webkit.org/show_bug.cgi?id=116476
Add a reason to the arguments for resuming active DOM object and
scheduled tasks and ensure that it matches the suspend reason before
actually resuming the objects.
Reviewed by Joseph Pecoraro.
No new tests, no change in functionality.
- bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::setJavaScriptPaused): Add matching resume reason
- dom/Document.cpp:
(WebCore::Document::resumeActiveDOMObjects): Check for matching resume reason
(WebCore::Document::resumeScheduledTasks): Check for matching resume reason
- dom/Document.h:
(Document):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects): Check for matching resume reason
- dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
(WebCore::ScriptExecutionContext::reasonForSuspendingActiveDOMObjects): Expose suspend reason to subclasses
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore): Add matching resume reason
- page/Frame.cpp:
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations): Add matching resume reason
- page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): Add matching resume reason
- 6:07 PM Changeset in webkit [150559] by
-
- 2 edits in trunk/LayoutTests
Remove even more stale Mac test expectations. These tests are passing now!
- platform/mac/TestExpectations:
- 5:46 PM Changeset in webkit [150558] by
-
- 5 edits in trunk/LayoutTests
Even more Mac test expectation updates.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/wk2/TestExpectations:
- plugins/mouse-events-expected.txt:
- 5:05 PM Changeset in webkit [150557] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix; cast OSStatus to an int before passing it to printf.
- platform/audio/mac/AudioSessionMac.cpp:
(WebCore::AudioSession::setPreferredBufferSize):
- 5:02 PM Changeset in webkit [150556] by
-
- 15 edits in trunk/Source
Don't snapshot plugins that can't be snapshotted
https://bugs.webkit.org/show_bug.cgi?id=116490
Reviewed by Tim Horton.
Some plugins, such as QuickTime, don't support snapshotting. We're
planning on another way to capture snapshots, but in the meantime make
sure that they don't fail to initialise because they were told to
not use accelerated rendering.
Source/WebCore:
- WebCore.exp.in: Export restartSnapshottedPlugin so that it can be used from WK2.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::restartSimilarPlugIns): Don't set the play state before restarting.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Make sure we indicated that this snapshotted plugin was clicked.
- html/HTMLPlugInImageElement.h: Move restartSnapshottedPlugin from protected to public.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::handleEvent): Don't set play state here. Let the restart functions do it.
Source/WebKit2:
Expose a new message on the plugins so that they can tell the PluginView
if they support snapshotting or not.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::supportsSnapshotting): New method.
- PluginProcess/PluginControllerProxy.h: Ditto.
- PluginProcess/PluginControllerProxy.messages.in: Message signature.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Add supportsSnapshotting.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h: Ditto.
- WebProcess/Plugins/Plugin.h: Ditto - pure virtual here.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::supportsSnapshotting): Send the message to the plugin process and return the results.
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin): If the snapshotting plugin has a layer, make
sure to add it to the tree.
(WebKit::PluginView::isAcceleratedCompositingEnabled): Snapshotting plugins can use
accelerated compositing, just like normal plugins.
(WebKit::PluginView::pluginSnapshotTimerFired): If the plugin doesn't allow snapshotting,
immediately restart it.
- 4:43 PM Changeset in webkit [150555] by
-
- 13 edits3 copies1 add in trunk/Source
Mac: Set the default audio buffer size to a large value for <video> elements.
https://bugs.webkit.org/show_bug.cgi?id=116342
Reviewed by Eric Carlson.
Source/WebCore:
To enable power savings by waking up the audio hardware less often, set the
requested buffer frame size to a large value, such as 4096. Since this results
in approximately 100ms worth of buffer, set the buffer size to a much lower
value when playing WebAudio, which is much more sensitive to latency than video
or audio elements.
Introduce a new class, AudioSessionManager, as well as a helper class,
AudioSessionManagerToken. Audio elements, video elements, and WebAudio destination
nodes will create and retain a token, and release the token in their destructor.
This allows the AudioSessionManager to track how many of what type of audio-
generating objects are in existence.
This requires implementing AudioSession for Mac platforms. Move the implementation
for retrieving the hardware sample rate and setting the buffer duration into
AudioSessionMac from AudioDestinationMac, to be shared with AudioSessionManagerMac.
Change the AudioSession method preferredBufferLength() into preferredBufferSize(),
as the callers really want to specify a buffer size, not a buffer duration. On iOS,
where the available API requires a duration, perform the conversion from duration to
size on behalf of the caller.
- html/HTMLMediaElement.h: Add a AudioSessionManagerToken member.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize the token.
- platform/audio/AudioSession.cpp:
(WebCore::AudioSession::preferredBufferSize): Renamed from preferredBufferLength.
(WebCore::AudioSession::setPreferredBufferSize): Renamed from setPreferredBufferLength.
- platform/audio/AudioSession.h:
- platform/audio/AudioSessionManager.cpp:
(AudioSessionManagerToken::create): Simple factory method.
(AudioSessionManagerToken::AudioSessionManagerToken): Call AudioSessionManager::incrementCount().
(AudioSessionManagerToken::~AudioSessionManagerToken): Call AudioSessionManager::decrementCount().
(AudioSessionManager::sharedManager): Simple singleton method.
(AudioSessionManager::AudioSessionManager): Simple constructor.
(AudioSessionManager::has): Return whether the type is present.
(AudioSessionManager::incrementCount): Increment, then call updateSessionState()
(AudioSessionManager::decrementCount): Decrement, then call updateSessionState()
(AudioSessionManager::updateSessionState): Stub, does nothing.
- platform/audio/AudioSessionManager.h:
- platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestinationIOS::configure): Call setPreferredBufferSize() instead of setPreferredBufferLength()
- platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::preferredBufferSize): Renamed from preferredBufferLength.
(WebCore::AudioSession::setPreferredBufferSize): Renamed from setPreferredBufferLength
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::hardwareSampleRate): Call AudioSession::sampleRate().
(WebCore::AudioDestinationMac::AudioDestinationMac): Create the AudioSessionManagerToken.
(WebCore::AudioDestinationMac::configure): Do not set the buffer size (this is done in AudioSessionManagerMac).
- platform/audio/mac/AudioDestinationMac.h:
- platform/audio/mac/AudioSessionMac.cpp: Added.
(WebCore::defaultDevice): Added, returns the default audio device.
(WebCore::AudioSession::AudioSession): Simple constructor.
(WebCore::AudioSession::~AudioSession): Simple destructor.
(WebCore::AudioSession::category): Stub, unimplemented.
(WebCore::AudioSession::setCategory): Ditto.
(WebCore::AudioSession::categoryOverride): Ditto.
(WebCore::AudioSession::setCategoryOverride): Ditto.
(WebCore::AudioSession::numberOfOutputChannels): Ditto.
(WebCore::AudioSession::setActive): Ditto.
(WebCore::AudioSession::sampleRate): Use the HAL to return the default audio device sample rate.
(WebCore::AudioSession::preferredBufferSize): Return the current HAL setting.
(WebCore::AudioSession::setPreferredBufferSize): Set the buffer size.
- platform/audio/mac/AudioSessionManagerMac.cpp:
(AudioSessionManager::updateSessionState): Set the buffer size depending on what audio outputs are present.
- WebCore.xcodeproj/project.pbxproj: Add the new files to the project.
Source/WTF:
- wtf/Platform.h: Add a WTF_USE_AUDIO_SESSION setting.
- 4:42 PM Changeset in webkit [150554] by
-
- 3 edits2 adds in trunk
[CSS Shaders] valueForCustomFilterTransformParameter should check that renderer is a RenderBox
https://bugs.webkit.org/show_bug.cgi?id=116464
Reviewed by Alexandru Chiculita.
Source/WebCore:
If the renderer is not a RenderBox, we just use a zero size to compute the transform,
like in CSSComputedStyleDeclaration::computedTransform.
Test: css3/filters/custom/custom-filter-crash-inline-computed-style.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForCustomFilterTransformParameter):
LayoutTests:
- css3/filters/custom/custom-filter-crash-inline-computed-style-expected.txt: Added.
- css3/filters/custom/custom-filter-crash-inline-computed-style.html: Added.
- 4:27 PM Changeset in webkit [150553] by
-
- 1 edit1 add in trunk/LayoutTests
Add a missing result after r150551.
- http/tests/inspector/network/network-size-chunked-expected.txt: Added.
- 4:24 PM Changeset in webkit [150552] by
-
- 2 edits1 add in trunk/LayoutTests
Mac test expectation corrections after r150545.
- platform/mac-lion/http/tests/multipart/policy-ignore-crash-expected.txt: Added.
- platform/mac/TestExpectations:
- 3:53 PM Changeset in webkit [150551] by
-
- 4 edits in trunk/LayoutTests
More Mac test expectation cleanups.
- http/tests/inspector/network/network-size-sync-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt:
- 3:27 PM Changeset in webkit [150550] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150495. <rdar://problem/13915556>
- 3:24 PM Changeset in webkit [150549] by
-
- 1 edit2 copies in branches/safari-537.43-branch/LayoutTests
Merged r150492. <rdar://problem/13921879>
- 3:23 PM Changeset in webkit [150548] by
-
- 6 edits2 deletes in branches/safari-537.43-branch
Merged r150490. <rdar://problem/13921879>
- 3:19 PM Changeset in webkit [150547] by
-
- 2 edits in trunk/Source/WebCore
Fix assertion in the getComputedStyle-background-shorthand.html test
https://bugs.webkit.org/show_bug.cgi?id=116639
Reviewed by Ryosuke Niwa.
getComputedStyle-background-shorthand.html was asserting under the newly added
code in willBeRemovedFromTree(). The assertion was caused by too many calls to
FrameView::removeSlowRepaintObject(), which happened because we called it for
RenderTexts, which share style with their parent renderer.
RenderText overrides styleWillChange() to do nothing, so we never
call add/removeSlowRepaintObject() for them. Thus we should also skip this
work in willBeRemovedFromTree() for RenderTexts.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeRemovedFromTree):
- 3:18 PM Changeset in webkit [150546] by
-
- 4 edits in trunk/LayoutTests
REGRESSION: fast/files/workers tests crash
https://bugs.webkit.org/show_bug.cgi?id=45575
Unskip the test since they no longer crash. Also rebaseline two tests as needed.
- fast/files/workers/worker-read-blob-async-expected.txt:
- fast/files/workers/worker-read-blob-sync-expected.txt:
- platform/mac/TestExpectations:
- 3:11 PM Changeset in webkit [150545] by
-
- 4 edits1 copy3 adds in trunk/LayoutTests
Mac test expectation cleanups. Unskip a bunch of tests and rebaseline them as needed.
- accessibility/aria-menubar-menuitems-expected.txt: Added.
- fast/replaced/border-radius-clip-expected.png:
- platform/mac/TestExpectations:
- platform/mac/fast/replaced/border-radius-clip-expected.txt:
- platform/mac/http/tests/multipart/policy-ignore-crash-expected.txt: Copied from LayoutTests/http/tests/multipart/policy-ignore-crash-expected.txt.
- platform/mac/media/video-volume-slider-expected.png: Added.
- platform/mac/media/video-volume-slider-expected.txt: Added.
- 3:08 PM Changeset in webkit [150544] by
-
- 3 edits in trunk/Source/WebCore
Heap-use-after-free in WebCore::RenderLayerModelObject::hasSelfPaintingLayer
https://bugs.webkit.org/show_bug.cgi?id=116626
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-22
Reviewed by David Hyatt.
This is a port of a Blink bug fix by Emil Eklund.
Account for saturated estimated position in RenderBlock::layoutBlockChild.
If the estimated top position is saturated the comparison with oldLogicalTop
might yield a false negative as adding and removing margins, borders etc from
a saturated number might yield incorrect results. If this is the case always
mark for layout.
Minimal test case impractical. See bug for raw fuzzer test case.
- platform/LayoutUnit.h:
(WebCore::LayoutUnit::mightBeSaturated): Add helper method for checking whether
a number might be saturated.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChild): Check if logicalTopEstimate is likely
to be saturated and if so mark for layout.
- 2:25 PM Changeset in webkit [150543] by
-
- 2 edits in trunk/Source/WebKit2
Fix crash when closing a page that's trying to access session storage
https://bugs.webkit.org/show_bug.cgi?id=116634
<rdar://problem/13904054>
Reviewed by Geoffrey Garen.
It is possible for the StorageManager to get messages from a web page that has already been closed by the UI process.
If that happens, just ignore the messages.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::getValues):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::removeItem):
(WebKit::StorageManager::clear):
(WebKit::StorageManager::destroySessionStorageNamespaceInternal):
- 2:22 PM Changeset in webkit [150542] by
-
- 1 edit24 adds20 deletes in trunk/LayoutTests
[CSS Exclusions] property parsing tests should be revised
https://bugs.webkit.org/show_bug.cgi?id=116446
Reviewed by Alexandru Chiculita.
This is just a cleanup of the existing parsing tests. None of the tests have effectively
changed. The cleaned-up version should be simpler, more regular, and shorter:
- Moved all of parsing tests into a fast/exclusions/parsing subdirectory.
- Remove the obsolete "wrap-" prefix from file names.
- Eiminated excessive and needless stringification in many of the test functions.
- Moved common code into parsing-test-utils.js and refactored redundant code.
- fast/exclusions/parsing-wrap-shape-inside-expected.txt: Removed.
- fast/exclusions/parsing-wrap-shape-inside.html: Removed.
- fast/exclusions/parsing-wrap-shape-lengths-expected.txt: Removed.
- fast/exclusions/parsing-wrap-shape-lengths.html: Removed.
- fast/exclusions/parsing-wrap-shape-outside-expected.txt: Removed.
- fast/exclusions/parsing-wrap-shape-outside.html: Removed.
- fast/exclusions/parsing/parsing-shape-inside-expected.txt: Added.
- fast/exclusions/parsing/parsing-shape-inside.html: Added.
- fast/exclusions/parsing/parsing-shape-lengths-expected.txt: Added.
- fast/exclusions/parsing/parsing-shape-lengths.html: Added.
- fast/exclusions/parsing/parsing-shape-margin-expected.txt: Added.
- fast/exclusions/parsing/parsing-shape-margin.html: Added.
- fast/exclusions/parsing/parsing-shape-outside-expected.txt: Added.
- fast/exclusions/parsing/parsing-shape-outside.html: Added.
- fast/exclusions/parsing/parsing-shape-padding-expected.txt: Added.
- fast/exclusions/parsing/parsing-shape-padding.html: Added.
- fast/exclusions/parsing/parsing-wrap-flow-expected.txt: Added.
- fast/exclusions/parsing/parsing-wrap-flow.html: Added.
- fast/exclusions/parsing/parsing-wrap-through-expected.txt: Added.
- fast/exclusions/parsing/parsing-wrap-through.html: Added.
- fast/exclusions/parsing/script-tests/parsing-shape-inside.js: Added.
(string_appeared_here):
- fast/exclusions/parsing/script-tests/parsing-shape-lengths.js: Added.
(getStyleValue):
(testStyleValue):
(testComputedStyleValue):
(testInvalidValue):
- fast/exclusions/parsing/script-tests/parsing-shape-margin.js: Added.
(testShapeSpecifiedProperty):
- fast/exclusions/parsing/script-tests/parsing-shape-outside.js: Added.
(testShapePropertyParsingFailure):
- fast/exclusions/parsing/script-tests/parsing-shape-padding.js: Added.
(testShapeSpecifiedProperty):
- fast/exclusions/parsing/script-tests/parsing-test-utils.js: Added.
(getCSSText):
(getComputedStyleValue):
(getParentAndChildComputedStyles):
(getParentAndChildComputedStylesString):
(getChildComputedStyle):
(testShapeSpecifiedProperty):
(testShapeComputedProperty):
(testNotInheritedShapeChildProperty):
- fast/exclusions/parsing/script-tests/parsing-wrap-flow.js: Added.
- fast/exclusions/parsing/script-tests/parsing-wrap-through.js: Added.
- fast/exclusions/shape-margin-parsing-expected.txt: Removed.
- fast/exclusions/shape-margin-parsing.html: Removed.
- fast/exclusions/shape-padding-parsing-expected.txt: Removed.
- fast/exclusions/shape-padding-parsing.html: Removed.
- fast/exclusions/wrap-flow-parsing-expected.txt: Removed.
- fast/exclusions/wrap-flow-parsing.html: Removed.
- fast/exclusions/wrap-through-parsing-expected.txt: Removed.
- fast/exclusions/wrap-through-parsing.html: Removed.
- 1:58 PM Changeset in webkit [150541] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150486. <rdar://problem/13822856>
- 1:55 PM Changeset in webkit [150540] by
-
- 33 edits1 copy in branches/safari-537.43-branch/Source/WebKit2
Merged r150484. <rdar://problem/13822856>
- 1:52 PM Changeset in webkit [150539] by
-
- 4 edits in trunk/Source/WebCore
Remove CSSPropertySourceData emptyCSSPropertySourceData
https://bugs.webkit.org/show_bug.cgi?id=116517
Reviewed by Darin Adler.
This was added for chromium and does not seem to be used
anywhere anymore.
- css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
- css/CSSPropertySourceData.cpp:
- css/CSSPropertySourceData.h:
- 1:52 PM Changeset in webkit [150538] by
-
- 4 edits in branches/safari-537.43-branch/Source
Versioning.
- 1:50 PM Changeset in webkit [150537] by
-
- 6 edits in trunk/Source/WebKit2
Crashes in NetworkProcess due to incorrect private browsing session tracking
https://bugs.webkit.org/show_bug.cgi?id=116628
Reviewed by Brady Eidson.
The current API for private browsing makes it extremely difficult to track sessions.
Private browsing is enabled via WKPreferences, but the session is shared, so it
has to be maintained while there is any chance that any page group anywhere still
needs it.
This patch fixes some of the issues, but ultimately, I think that we'll just need
to deprecate and replace the API.
- NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::storageSession): There are valid scenarios where privateBrowsingEnabled is true, but there is no private browsing session. Handle that without crashing, although this unfortunately means that it will be harder to spot logic errors when using a wrong session. (WebKit::NetworkConnectionToWebProcess::registerBlobURL): Removed an obsolete FIXME.
- NetworkProcess/mac/RemoteNetworkingContext.h: Changed privateBrowsingSession() to return a pointer, as no caller could know when it was safe to call it.
- NetworkProcess/mac/RemoteNetworkingContext.mm: (WebKit::RemoteNetworkingContext::storageSession): Handle the case where private browsing session is unexpectedly missing without crashing. (WebKit::RemoteNetworkingContext::privateBrowsingSession): Changed to return a pointer.
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureNetworkProcess): Actually initialize privateBrowsingEnabled creation parameter. It would be very difficult to figure out 100% reliably whether NetworkProcess needs a private browsing session with the current API, but for existing clients, looking at m_privateBrowsingEnterCount is good enough. Certainly better than not initializing.
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setPrivateBrowsingEnabled): Added a FIXME.
- 1:42 PM Changeset in webkit [150536] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: It should be possible to use more than one compiler thread
https://bugs.webkit.org/show_bug.cgi?id=116630
Reviewed by Mark Hahnenberg.
This gives us the ability to use more compiler threads, but doesn't actually
enable the functionality because it isn't a speed-up on any benchmark. It can
even be a slow-down. This also adds the ability to disable concurrent
compilation if we're on a uniprocessor machine, and adds more logging to the
worklist code to allow us to investigate how many threads are active. It
appears that even on the most compiler-heavy benchmarks, we never have enough
work for more than 4 threads, and even then the 4 threads are all active for
a short time.
Something that having more threads does accomplish is that it shakes out bugs.
This patch fixes a bug with Watchpoint not being thread-safe ref-counted,
which enabling 7 compilation threads did catch.
As it stands, this patch is performance-neutral and just fixes bugs and adds
some options.
- bytecode/Watchpoint.h:
- dfg/DFGCommon.h:
(JSC::DFG::enableConcurrentJIT):
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::Worklist):
(JSC::DFG::Worklist::~Worklist):
(JSC::DFG::Worklist::finishCreation):
(JSC::DFG::Worklist::create):
(JSC::DFG::Worklist::enqueue):
(JSC::DFG::Worklist::waitUntilAllPlansForVMAreReady):
(JSC::DFG::Worklist::dump):
(JSC::DFG::Worklist::runThread):
(JSC::DFG::initializeGlobalWorklistOnce):
- dfg/DFGWorklist.h:
- runtime/Options.cpp:
(JSC::computeNumberOfWorkerThreads):
(JSC):
(JSC::computeNumberOfGCMarkers):
- runtime/Options.h:
(JSC):
- 1:30 PM Changeset in webkit [150535] by
-
- 2 edits in trunk/Source/WebCore
Buildfix for !ENABLE(FULLSCREEN_API) platforms.
Rubber-stamped by Ryosuke Niwa.
- rendering/RenderInline.cpp: Missing #if guard added.
(WebCore::RenderInline::splitInlines):
- 1:11 PM Changeset in webkit [150534] by
-
- 2 edits in trunk/Source/WebCore
Fix a typo in 150469.
- editing/Editor.cpp:
(WebCore::dispatchEditableContentChangedEvents):
- 1:09 PM Changeset in webkit [150533] by
-
- 20 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL shouldn't use the LLVM global context, and should instead create its own context for each compilation
https://bugs.webkit.org/show_bug.cgi?id=116631
Reviewed by Mark Hahnenberg.
In the future we might want to share contexts for multiple compilations, but for
now using one context per compilation is a progression over just constantly using
the global context.
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThread):
(DFG):
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPlan.h:
- ftl/FTLAbbreviatedTypes.h:
(FTL):
- ftl/FTLAbbreviations.h:
(JSC::FTL::voidType):
(JSC::FTL::int1Type):
(JSC::FTL::int8Type):
(JSC::FTL::int32Type):
(JSC::FTL::int64Type):
(JSC::FTL::intPtrType):
(JSC::FTL::doubleType):
(JSC::FTL::structType):
(JSC::FTL::mdKindID):
(JSC::FTL::mdString):
(JSC::FTL::mdNode):
(JSC::FTL::appendBasicBlock):
(JSC::FTL::insertBasicBlock):
- ftl/FTLAbstractHeap.cpp:
(JSC::FTL::AbstractHeap::tbaaMetadataSlow):
(JSC::FTL::IndexedAbstractHeap::IndexedAbstractHeap):
(JSC::FTL::NumberedAbstractHeap::NumberedAbstractHeap):
(JSC::FTL::AbsoluteAbstractHeap::AbsoluteAbstractHeap):
- ftl/FTLAbstractHeap.h:
(IndexedAbstractHeap):
(NumberedAbstractHeap):
(AbsoluteAbstractHeap):
- ftl/FTLAbstractHeapRepository.cpp:
(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
- ftl/FTLAbstractHeapRepository.h:
(AbstractHeapRepository):
- ftl/FTLCommonValues.cpp:
(JSC::FTL::CommonValues::CommonValues):
- ftl/FTLCommonValues.h:
(CommonValues):
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateCodeSection):
- ftl/FTLIntrinsicRepository.cpp:
(JSC::FTL::IntrinsicRepository::IntrinsicRepository):
- ftl/FTLIntrinsicRepository.h:
(FTL):
(IntrinsicRepository):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
- ftl/FTLOutput.cpp:
(JSC::FTL::Output::Output):
- ftl/FTLOutput.h:
(Output):
(JSC::FTL::Output::newBlock):
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
(JSC::FTL::State::~State):
(FTL):
- ftl/FTLState.h:
(State):
- runtime/Options.h:
(JSC):
- 12:48 PM Changeset in webkit [150532] by
-
- 3 edits in trunk/Source/WebKit2
[wk2] Should be able to make tiled WKViews clip to the view's exposed rect without using autolayout
https://bugs.webkit.org/show_bug.cgi?id=116625
<rdar://problem/13962816>
Reviewed by Anders Carlsson.
The two modes are not dependent; it should be possible to enable
clips-to-exposed-rect without using autolayout. This enables apps to
make very large tiled WKViews that don't create tiles for the whole
area of the view (and also disables scrolling, since that is currently
incompatible with clipping to the exposed rect).
- UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView forceAsyncDrawingAreaSizeUpdate:]):
Rename _expandsToFitContentViaAutoLayout to _clipsToVisibleRect for accuracy.
(-[WKView setMinimumWidthForAutoLayout:]):
Factor clips-to-sisible-rect toggle out into setShouldClipToVisibleRect.
(-[WKView shouldClipToVisibleRect]):
(-[WKView setShouldClipToVisibleRect:]):
Allow setting clips-to-visible-rect without autolayout.
- UIProcess/API/mac/WKViewPrivate.h:
Add shouldClipToVisibleRect property.
- 12:21 PM Changeset in webkit [150531] by
-
- 3 edits2 adds in trunk
REGRESSION: ASSERTION FAILED: obj->isRenderInline() obj == this, Bad cast in WebCore::RenderBlock::createLineBoxes https://bugs.webkit.org/show_bug.cgi?id=110622
Reviewed by David Hyatt.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/998ad358eed702b873dd54697b3fa3f952e0feb7
Inserting an element before the fullscreened element could crash if it caused a containing inline to be split,
since the splitting logic doesn't expect the fullscreened element to be wrapped in a RenderFullScreen. This patch changes
inline splitting to be aware of RenderFullScreen.
Test: fullscreen/full-screen-inline-split-crash.html
- rendering/RenderInline.cpp:
(WebCore::RenderInline::splitInlines):
LayoutTests:
Add a regression test.
- fullscreen/full-screen-inline-split-crash-expected.txt: Added.
- fullscreen/full-screen-inline-split-crash.html: Added.
- 12:06 PM Changeset in webkit [150530] by
-
- 5 edits in trunk/Source
Fix issues with focus rings on search fields
https://bugs.webkit.org/show_bug.cgi?id=116591
Source/WebCore:
Reviewed by Darin Adler.
On a future OS, the rect returned by _focusRingVisibleRect should
be in the coordinate system of the that NSView, not the base
coordinate system, so fix the code that sets and reads the global
focusRingClipRect variable accordingly.
- platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
- platform/mac/ThemeMac.mm:
(-[WebCoreFlippedView _focusRingVisibleRect]):
Source/WebKit/mac:
Reviewed by Darin Adler.
In WebKit1, focus rings didn't render correctly on some OSes until
some other control drew a focus ring, which changes internal AppKit state
on the focused view. Fix by overriding an internal AppKit method to always
disable AppKit's "automatic" focus ring drawing.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _automaticFocusRingDisabled]):
- 12:06 PM Changeset in webkit [150529] by
-
- 3 edits6 adds in trunk
New Flickr doesn't get fast scrolling but should
https://bugs.webkit.org/show_bug.cgi?id=116514
Source/WebCore:
Reviewed by Darin Adler.
RenderObject increments and decrements a counter of slow repaint objects on
FrameView when it sees style changes related to background-attachment:fixed.
However, it omitted to decrement the count when a renderer with a fixed background
was destroyed.
This caused Flickr to never fall into fast scrolling mode, since it toggled
display:none on an element with a fixed background during loading, then removed
the fixed background.
Did some minor cleanup of #ENABLE(FAST_MOBILE_SCROLLING) crap.
Tests: platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html
platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html
platform/mac-wk2/tiled-drawing/slow-scrolling.html
- rendering/RenderObject.cpp:
(WebCore::shouldRepaintFixedBackgroundsOnScroll):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::willBeRemovedFromTree):
LayoutTests:
Reviewed by Darin Adler.
slow-scrolling-hidden-background-toggle.html actually tests this patch. The other
two tests were added because there appear to be no tests for basic internals.mainThreadScrollingReasons()
functionality.
- platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html: Added.
- platform/mac-wk2/tiled-drawing/slow-scrolling-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html: Added.
- platform/mac-wk2/tiled-drawing/slow-scrolling.html: Added.
- 12:01 PM Changeset in webkit [150528] by
-
- 1 copy in branches/safari-537.43-branch
New Branch.
- 11:59 AM Changeset in webkit [150527] by
-
- 9 edits2 adds in trunk
Need to Remove Anonymous Wrappers When All Children Become Inline
https://bugs.webkit.org/show_bug.cgi?id=115687
Reviewed by David Hyatt.
Source/WebCore:
Remove a simple subset of anonymous wrappers, i.e. anonymous blocks without continuations,
when a block becoming float or positioned removes the need for them.
Test: fast/block/remove-anonymous-wrappers-when-element-changes-to-float-or-positioned.html
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderObject.cpp:
(WebCore):
(WebCore::RenderObject::removeAnonymousWrappersFromLineIfNecessary):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::styleDidChange):
- rendering/RenderObject.h:
(RenderObject):
LayoutTests:
- fast/block/remove-anonymous-wrappers-when-element-changes-to-float-or-positioned-expected.txt: Added.
- fast/block/remove-anonymous-wrappers-when-element-changes-to-float-or-positioned.html: Added.
- platform/qt/fast/block/float/float-not-removed-from-next-sibling2-expected.txt:
- platform/qt/fast/dynamic/002-expected.txt:
- 11:47 AM Changeset in webkit [150526] by
-
- 3 edits in branches/dfgFourthTier/WebKitLibraries
Updated LLVM drops to include MCJIT memory management APIs.
Rubber stamped by Mark Hahnenberg.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 11:38 AM Changeset in webkit [150525] by
-
- 18 edits in trunk/Source/WebCore
[css] Update ETextDecorations enum to TextDecorations
https://bugs.webkit.org/show_bug.cgi?id=116581
Reviewed by Andreas Kling.
Currently, ETextDecorations enum uses a C-like coding style for its
enumeration values, as well as a 'E' prefix that surely had some meaning
in the past, but not nowadays.
No behavior changes, covered by existing tests.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::hasPlainText):
(WebCore::AccessibilityRenderObject::hasUnderline):
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getAttributeSetForAccessibilityObject):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(AXAttributeStringSetStyle):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(AXAttributeStringSetStyle):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationFlagsToCSSValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator TextDecoration):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyTextDecoration::createHandler):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
- platform/mac/HTMLConverter.mm:
(+[WebHTMLConverter editingAttributedStringFromRange:]):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):
- rendering/InlineTextBox.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::getTextDecorationColors):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
(WebCore::operator|):
(WebCore::operator|=):
- rendering/style/StyleVisualData.h:
(StyleVisualData):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paint):
(WebCore::positionOffsetForDecoration):
(WebCore::thicknessForDecoration):
(WebCore::findRenderObjectDefininingTextDecoration):
(WebCore::SVGInlineTextBox::paintDecoration):
(WebCore::SVGInlineTextBox::paintDecorationWithStyle):
- rendering/svg/SVGInlineTextBox.h:
- 11:30 AM Changeset in webkit [150524] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Allow multiple log levels in media player
https://bugs.webkit.org/show_bug.cgi?id=116618
Patch by Lori Anderson <lori@rkymtnhi.com> on 2013-05-22
Reviewed by Philippe Normand.
No new tests, just changing logging.
- platform/graphics/gstreamer/GStreamerUtilities.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load):
(WebCore::MediaPlayerPrivateGStreamer::pause):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
- 11:23 AM WebKit Team edited by
- added self (diff)
- 11:13 AM Changeset in webkit [150523] by
-
- 2 edits in trunk/Tools
Unreviewed. Added myself to contributors.json.
- Scripts/webkitpy/common/config/contributors.json:
Added myself.
- 11:06 AM Changeset in webkit [150522] by
-
- 2 edits in trunk/Source/WebCore
The LayoutMilestones didLayout callback sometimes fires with a milestone value of 0
https://bugs.webkit.org/show_bug.cgi?id=116623
Reviewed by Geoffrey Garen.
Make sure we have actually achieved some milestones before calling didLayout().
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
- 10:09 AM Changeset in webkit [150521] by
-
- 10 edits in trunk/Source/WebKit2
Remove unused private browsing override support
<rdar://problem/11969491>
Rubber-stamped by Sam Weinig.
Private browsing override is unused, and it complicates tracking of private
browsing sessions in UI process (in fact, it doesn't plug into this tracking at all,
so we would just assert if we used the API).
- 10:01 AM Changeset in webkit [150520] by
-
- 9 edits in branches/dfgFourthTier/Source/JavaScriptCore
FTL should force LLVM to use our own JIT memory allocator, and we shouldn't have to keep around an LLVMExecutionEngineRef to keep code alive
https://bugs.webkit.org/show_bug.cgi?id=113619
Reviewed by Geoffrey Garen.
This uses new API that I've exposed, which allows for memory manager callbacks
from within LLVM. LLVM may allocate multiple independent chunks of memory for
a module, and we track all of those in a Vector in FTL::JITCode.
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateCodeSection):
(FTL):
(JSC::FTL::mmAllocateDataSection):
(JSC::FTL::mmApplyPermissions):
(JSC::FTL::mmDestroy):
(JSC::FTL::compile):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::JITCode):
(JSC::FTL::JITCode::~JITCode):
(JSC::FTL::JITCode::addHandle):
(FTL):
(JSC::FTL::JITCode::initializeCode):
- ftl/FTLJITCode.h:
(JITCode):
(JSC::FTL::JITCode::handles):
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::~JITFinalizer):
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLJITFinalizer.h:
(JSC::FTL::JITFinalizer::initializeEntrypointLinkBuffer):
(JITFinalizer):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
- ftl/FTLState.h:
(State):
- 9:42 AM Changeset in webkit [150519] by
-
- 5 edits1 delete in trunk/Source/JavaScriptCore
[sh4] Remove MacroAssemblerSH4.cpp file.
https://bugs.webkit.org/show_bug.cgi?id=116596.
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-22
Reviewed by Geoffrey Garen.
Move linkCall and repatchCall implementations from MacroAssemblerSH4.cpp
to MacroAssemblerSH4.h and remove MacroAssemblerSH4.cpp, as it is done
for other architectures.
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- assembler/MacroAssemblerSH4.cpp: Removed.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::linkCall):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::repatchCall):
- 9:22 AM Changeset in webkit [150518] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Reimplement atk_text_get_text_*_offset for CHAR boundary
https://bugs.webkit.org/show_bug.cgi?id=114870
Reviewed by Martin Robinson.
Re-implement this functions without using GailTextUtil nor Pango.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetChar): New function.
(webkitAccessibleTextGetTextForOffset): Call the new function for CHAR.
- 9:18 AM Changeset in webkit [150517] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening. Skipping failing printing tests after r150046.
https://bugs.webkit.org/show_bug.cgi?id=116617
- platform/qt-5.0-wk2/TestExpectations:
- 9:11 AM Changeset in webkit [150516] by
-
- 4 edits in trunk/Source/WebCore
[Mac] Captions menu isn't internationalized, doesn't use rtl layout for rtl languages
https://bugs.webkit.org/show_bug.cgi?id=116605
Reviewed by Eric Carlson.
Ensure that rtl languages are properly recognized by the captions menu such that text
layout and alignment is natural.
- css/mediaControls.css:
(::-webkit-media-controls):
Remove the forced "direction: ltr" property which was forcing all layout to be
left-to-right.
- css/mediaControlsQuickTime.css:
(video::-webkit-media-controls-closed-captions-track-list):
Remove the forced "text-align: left" property which was forcing all caption
titles to be left-aligned.
(video::-webkit-media-controls-closed-captions-track-list h3):
Use "-webkit-margin-start" instead of "padding-left" to position the heading
such that it adds the margin on the left for ltr languages and on the right
for rtl languages.
(video::-webkit-media-controls-closed-captions-track-list li):
Set "position: relative" such that the ::before pseudo-class can use "position: absolute"
to position itself relative to the caption title rather than the list element.
(video::-webkit-media-controls-closed-captions-track-list li.selected::before):
(video::-webkit-media-controls-closed-captions-track-list li.selected:hover::before):
Make the checkmarks a ::before pseudo-class rather than a background-image such that
we may control its positioning using the internationlization-friendly "-webkit-margin-start"
property.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsContainerElement::create):
Set the "dir" attribute to "auto" such that rtl languages are correctly handled. This
means that the first string displayed within the captions container, currently the
"Subtitles" <h3> element, defines the direction for the whole container. It is therefore
crucial that this string is properly localized in rtl languages as falling back to
english would mean the entire caption container is using ltr.
- 7:16 AM Changeset in webkit [150515] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Add sub menus to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=114728
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-05-22
Reviewed by Christophe Dumez.
Elementary Ctxpopup widget API does not provide support for submenu item.
To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
Elementary Menu widget.
- MiniBrowser/efl/main.c:
(_Browser_Window):
(on_window_resize):
(window_free):
(context_menu_item_selected_cb):
(context_menu_populate):
(on_context_menu_show):
(on_context_menu_hide):
(window_create):
- 7:15 AM Changeset in webkit [150514] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests after r150065 and r150498.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22
- platform/qt/TestExpectations:
- 6:45 AM Changeset in webkit [150513] by
-
- 2 edits in trunk/Source/WebCore
WebCore fails to compile with -Werror=maybe-uninitialized on GCC 4.8.0
https://bugs.webkit.org/show_bug.cgi?id=116340
Reviewed by Christophe Dumez.
No new tests, just a simple build fix.
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem): Init frame variable.
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): Init frame variable.
- 6:36 AM Changeset in webkit [150512] by
-
- 5 edits in trunk/LayoutTests
[CSSRegions] Remove platform-specific differences from offsetLeft/offsetTop tests
https://bugs.webkit.org/show_bug.cgi?id=116607
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-22
Reviewed by Antti Koivisto.
- fast/regions/offsetLeft-offsetTop-in-multiple-regions-expected.txt:
- fast/regions/offsetLeft-offsetTop-in-multiple-regions.html:
- fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl.html:
- fast/regions/offsetLeft-offsetTop-inlines-region-in-element.html:
- 5:49 AM Changeset in webkit [150511] by
-
- 2 edits in trunk/Tools
[EFL] Add command line option to MiniBrowser to set cookies policy.
https://bugs.webkit.org/show_bug.cgi?id=115028
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-05-22
Reviewed by Christophe Dumez.
Add command line option to MiniBrowser EFL to set cookies policy:
-p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
- MiniBrowser/efl/main.c:
(elm_main):
- 5:47 AM WebKitGTK/2.0.x edited by
- Proposed changes for 2.0.3 (diff)
- 5:20 AM Changeset in webkit [150510] by
-
- 1 edit1 add1 delete in trunk/LayoutTests
[Qt] Unreviewed gardening, updating expected files after r150508.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22
- platform/qt-5.0-wk2/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
- platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Removed.
- 5:04 AM Changeset in webkit [150509] by
-
- 15 edits in trunk/Source/WebCore
Have IDL interface names match their global constructor
https://bugs.webkit.org/show_bug.cgi?id=116520
Reviewed by Kentaro Hara.
Have IDL interface names match their global constructor name on DOMWindow.idl
using [InterfaceName] extended attribute. This affects in particular webkit
prefixed constructors. This is mandated by Web IDL specification:
http://dev.w3.org/2006/webapi/WebIDL/#es-interfaces
As a consequence, we can now get rid of [NoInterfaceObject] extended attribute
for those interfaces and have their global constructors automatically generated
by the bindings generator.
No new tests, no behavior change for layout tests.
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBuffer.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/speech/SpeechGrammar.idl:
- Modules/speech/SpeechGrammarList.idl:
- Modules/speech/SpeechRecognition.idl:
- Modules/speech/SpeechRecognitionError.idl:
- Modules/speech/SpeechRecognitionEvent.idl:
- Modules/webaudio/OfflineAudioContext.idl:
- Modules/webaudio/PannerNode.idl:
- dom/ShadowRoot.idl:
- page/DOMWindow.idl:
- 4:42 AM Changeset in webkit [150508] by
-
- 15 edits10 adds1 delete in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskipping some tests.
https://bugs.webkit.org/show_bug.cgi?id=26830
https://bugs.webkit.org/show_bug.cgi?id=99870
https://bugs.webkit.org/show_bug.cgi?id=108429
https://bugs.webkit.org/show_bug.cgi?id=23166
https://bugs.webkit.org/show_bug.cgi?id=98523
https://bugs.webkit.org/show_bug.cgi?id=110654
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22
- platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
- platform/qt/TestExpectations:
- platform/qt/css2.1/20110323/replaced-elements-001-expected.png:
- platform/qt/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/qt/css3/flexbox/button-expected.png: Added.
- platform/qt/css3/flexbox/button-expected.txt: Added.
- platform/qt/fast/css/background-clip-radius-values-expected.png: Added.
- platform/qt/fast/css/background-clip-radius-values-expected.txt: Added.
- platform/qt/fast/images/repaint-subrect-grid-expected.txt: Added.
- platform/qt/fast/multicol/single-line-expected.png: Added.
- platform/qt/fast/multicol/single-line-expected.txt: Added.
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png:
- platform/qt/svg/custom/foreign-object-skew-expected.txt:
- platform/qt/svg/custom/js-late-pattern-creation-expected.png:
- platform/qt/svg/custom/pattern-scaling-expected.png: Added.
- platform/qt/svg/custom/pattern-scaling-expected.txt: Added.
- platform/qt/svg/custom/pattern-skew-transformed-expected.png:
- platform/qt/svg/custom/pattern-skew-transformed-expected.txt: Added.
- platform/qt/svg/custom/pattern-with-transformation-expected.png:
- platform/qt/svg/custom/text-ctm-expected.png:
- platform/qt/svg/custom/text-ctm-expected.txt:
- platform/qt/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
- platform/qt/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
- platform/qt/tables/mozilla/bugs/bug92647-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
- 2:37 AM Changeset in webkit [150507] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Change Ewk_Context_Menu_Item's parent menu to raw pointer
https://bugs.webkit.org/show_bug.cgi?id=116549
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-05-22
Reviewed by Christophe Dumez.
A context menu item should have only a pointer to parent menu instead
of owning parent menu.
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(EwkContextMenuItem::EwkContextMenuItem):
- UIProcess/API/efl/ewk_context_menu_item_private.h:
(EwkContextMenuItem::create):
(EwkContextMenuItem::parentMenu):
(EwkContextMenuItem):
- 2:25 AM Changeset in webkit [150506] by
-
- 27 edits1 copy40 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskipping some tests.
https://bugs.webkit.org/show_bug.cgi?id=105437
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.txt: Added.
- platform/qt/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Copied from LayoutTests/platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.png.
- platform/qt/svg/filters/feImage-animated-transform-on-target-rect-expected.txt: Added.
- platform/qt/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
- platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
- platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
- platform/qt/svg/filters/feImage-late-indirect-update-expected.png:
- platform/qt/svg/filters/feImage-late-indirect-update-expected.txt: Added.
- platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.png:
- platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-position-expected.png:
- platform/qt/svg/filters/feImage-position-expected.txt: Added.
- platform/qt/svg/filters/feImage-preserveAspectratio-expected.png:
- platform/qt/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
- platform/qt/svg/filters/feImage-reference-invalidation-expected.png:
- platform/qt/svg/filters/feImage-reference-invalidation-expected.txt: Added.
- platform/qt/svg/filters/feImage-subregions-expected.png:
- platform/qt/svg/filters/feImage-subregions-expected.txt: Added.
- platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
- platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.txt: Added.
- platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
- platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-add-to-document-expected.png:
- platform/qt/svg/filters/feImage-target-add-to-document-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-attribute-change-expected.png:
- platform/qt/svg/filters/feImage-target-attribute-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
- platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
- platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-changes-id-expected.png:
- platform/qt/svg/filters/feImage-target-changes-id-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-id-change-expected.png:
- platform/qt/svg/filters/feImage-target-id-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-inline-style-change-expected.png:
- platform/qt/svg/filters/feImage-target-inline-style-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-property-change-expected.png:
- platform/qt/svg/filters/feImage-target-property-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-reappend-to-document-expected.png:
- platform/qt/svg/filters/feImage-target-reappend-to-document-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-remove-from-document-expected.png:
- platform/qt/svg/filters/feImage-target-remove-from-document-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-style-change-expected.png:
- platform/qt/svg/filters/feImage-target-style-change-expected.txt: Added.
- 12:24 AM Changeset in webkit [150505] by
-
- 2 edits in trunk/LayoutTests
[EFL] accessibility/label-for-control-hittest.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112029
Unreviewed EFL gardening.
accessibility/label-for-control-hittest.html passes after r150439.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-05-22
- platform/efl-wk2/TestExpectations:
- 12:07 AM Changeset in webkit [150504] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Unreviewed buildfix after r150484.
- UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
