⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 24, 2013:

9:20 PM Changeset in webkit [150681] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][GTK] Build fix after r150669
https://bugs.webkit.org/show_bug.cgi?id=116751

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-24
Reviewed by Christophe Dumez.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::getEditorCommandsForKeyEvent):

9:01 PM Changeset in webkit [150680] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove obsolete Page forward declaration from InspectorClientEfl.h
https://bugs.webkit.org/show_bug.cgi?id=116752

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-24
Reviewed by Christophe Dumez.

  • WebCoreSupport/InspectorClientEfl.h:
7:44 PM CommitterTips edited by Seokju Kwon
It is generated automatically from ​contributors.json after r150662. (diff)
7:19 PM Changeset in webkit [150679] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[EFL] Build fix after r150669
https://bugs.webkit.org/show_bug.cgi?id=116750

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-24
Reviewed by Anders Carlsson.

  • CMakeLists.txt:
  • WebProcess/Battery/WebBatteryManager.cpp:

(WebKit::WebBatteryManager::registerWebPage):
(WebKit::WebBatteryManager::unregisterWebPage):

  • WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:

(WebKit::WebNetworkInfoManager::registerWebPage):
(WebKit::WebNetworkInfoManager::unregisterWebPage):
(WebKit::WebNetworkInfoManager::bandwidth):
(WebKit::WebNetworkInfoManager::metered):

  • WebProcess/WebCoreSupport/WebVibrationClient.cpp:

(WebKit::WebVibrationClient::vibrate):
(WebKit::WebVibrationClient::cancelVibration):

  • WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestManager::didReceiveURIRequestData):
(WebKit::WebSoupRequestManager::send):

6:28 PM Changeset in webkit [150678] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

Unreviewed change to get Windows bots green. Disable a number
of crashes and failures. Crashes are tracked under
https://bugs.webkit.org/show_bug.cgi?id=116562, failures under
https://bugs.webkit.org/show_bug.cgi?id=116564.

  • platform/win/TestExpectations:
6:18 PM Changeset in webkit [150677] by Brent Fulgham
  • 2 edits in trunk/Tools

Unreviewed build fix. Don't use new NRWT logic needed
by Windows yet. Activate (and fix test) when we cut over.

  • Scripts/webkitpy/port/driver.py:

(Driver._setup_environ_for_driver):
(Driver._start):

6:12 PM Changeset in webkit [150676] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Inline TCMalloc_Central_FreeList's RemoveRange and FetchFromSpansSafe
https://bugs.webkit.org/show_bug.cgi?id=116700

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-24
Reviewed by Darin Adler.

The two functions only have one call site each.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_Central_FreeList::RemoveRange):
(WTF::TCMalloc_Central_FreeList::FetchFromSpansSafe):

6:02 PM Changeset in webkit [150675] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r150664.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

5:59 PM Changeset in webkit [150674] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source

Versioning.

5:56 PM Changeset in webkit [150673] by Lucas Forschler
  • 1 copy in tags/Safari-537.43.2

New Tag.

5:49 PM Changeset in webkit [150672] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Fixing invalid block recovery in some declaration list.
https://bugs.webkit.org/show_bug.cgi?id=115159

Patch by Sergio Villar Senin <svillar@igalia.com> on 2013-05-24
Reviewed by Darin Adler.

From Blink r148889 by <serya@chromium.org>

Source/WebCore:

Improves the detection of some invalid block declarations inside a
declaration list. This allows the parser not to completely discard
a whole declaration list that contains an invalid block. In
particular grammar failed in tests 8, 12, 13, 15, 16 and 17 in the
new test added by this change.

Test: fast/css/parsing-invalid-block-recovery.html

  • css/CSSGrammar.y.in:

LayoutTests:

  • fast/css/parsing-invalid-block-recovery-expected.txt: Added.
  • fast/css/parsing-invalid-block-recovery.html: Added.
5:48 PM Changeset in webkit [150671] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

DidFirstFlushForHeaderLayer can be called too soon on pages that redirect
https://bugs.webkit.org/show_bug.cgi?id=116749
-and corresponding-
<rdar://problem/13886753>

Reviewed by Simon Fraser.

Only start m_paintRelatedMilestonesTimer if we have actually painted.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

5:19 PM Changeset in webkit [150670] by Brent Fulgham
  • 11 edits in trunk

[Windows] Expose database storage and cache locations via preferences.
https://bugs.webkit.org/show_bug.cgi?id=116729

Reviewed by Tim Horton.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Export

three symbols needed to implement the feature.

Source/WebKit/win:

  • WebDatabaseManager.cpp: Update to check preferences for the

desired location of the database store.
(databasesDirectory): Added.
(WebKitInitializeWebDatabasesIfNecessary): Use new databasesDirectory
method to determine what system path to use for file storage.

  • WebKit.vcproj/WebKitExports.def.in: Export three symbols

needed to implement the feature.

  • WebView.cpp: Update to check preferences for the desired location

of the various caches used by WebKit.
(WebView::setCacheModel): Update to check preferences for URL cache
storage.
(WebKitSetApplicationCachePathIfNecessary): Update to check
preferences for ccache storage.

Tools:

Update DumpRenderTree to use CFPreferences to control where WebKit
stores its local databases, URL caches, etc.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(libraryPathForDumpRenderTree): Added.
(dllLauncherEntryPoint): Set up DRT-specific cache locations.

  • Scripts/webkitpy/port/base.py:

(Port._driver_tempdir): Added (to allow port-specific overload).
(Port._driver_tempdir_for_environment): Ditto

  • Scripts/webkitpy/port/driver.py:

(Driver._setup_environ_for_driver): Use new overload to set
environment variable.
(Driver._start): Use new overload for temp directory location.

  • Scripts/webkitpy/port/win.py:

(WinPort._driver_tempdir_for_environment): New overload to supply
Windows path to DumpRenderTree environment (while still using
cygwin paths for internal operations.

5:17 PM Changeset in webkit [150669] by andersca@apple.com
  • 40 edits
    1 copy in trunk/Source/WebKit2

MessageSender shouldn't be a class template
https://bugs.webkit.org/show_bug.cgi?id=116743

Reviewed by Andreas Kling.

Change MessageSender to be a proper abstract base class. Subclasses of MessageSender must
implement messageSenderConnection() as well as messageSenderDestinationID().

This reduces code size and will allow us to be more flexible with MessageSender in the future.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
(WebKit::NetworkResourceLoader::messageSenderConnection):
(WebKit):
(WebKit::NetworkResourceLoader::messageSenderDestinationID):

  • NetworkProcess/NetworkResourceLoader.h:

(NetworkResourceLoader):

  • NetworkProcess/mac/DiskCacheMonitor.h:

(DiskCacheMonitor):

  • NetworkProcess/mac/DiskCacheMonitor.mm:

(WebKit::DiskCacheMonitor::messageSenderConnection):
(WebKit::DiskCacheMonitor::messageSenderDestinationID):
(WebKit):

  • Platform/CoreIPC/MessageSender.h:

(CoreIPC):
(MessageSender):
(CoreIPC::MessageSender::send):
(CoreIPC::MessageSender::sendSync):

  • Shared/ChildProcess.cpp:

(WebKit::ChildProcess::messageSenderConnection):
(WebKit):
(WebKit::ChildProcess::messageSenderDestinationID):

  • Shared/ChildProcess.h:

(ChildProcess):

  • Shared/Downloads/Download.cpp:

(WebKit::Download::messageSenderConnection):
(WebKit):
(WebKit::Download::messageSenderDestinationID):

  • Shared/Downloads/Download.h:

(Download):

  • Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::initialize):

  • Shared/WebConnection.h:

(WebConnection):

  • Shared/mac/SecItemShim.cpp:

(WebKit::sendSecItemRequest):

  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::hasValidConnection):
(WebKit::WebConnectionToWebProcess::messageSenderConnection):
(WebKit::WebConnectionToWebProcess::messageSenderDestinationID):

  • UIProcess/WebConnectionToWebProcess.h:

(WebConnectionToWebProcess):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:

(WebKit::WebIconDatabaseProxy::retainIconForPageURL):
(WebKit::WebIconDatabaseProxy::releaseIconForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
(WebKit::WebIconDatabaseProxy::loadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::setIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::messageSenderConnection):
(WebKit::WebResourceLoader::messageSenderDestinationID):

  • WebProcess/Network/WebResourceLoader.h:

(WebResourceLoader):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::writeItemsToPasteboard):

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):

  • WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::~StorageAreaMap):
(WebKit::StorageAreaMap::setItem):
(WebKit::StorageAreaMap::removeItem):
(WebKit::StorageAreaMap::clear):
(WebKit::StorageAreaMap::loadValuesIfNeeded):

  • WebProcess/WebConnectionToUIProcess.cpp:

(WebKit::WebConnectionToUIProcess::hasValidConnection):
(WebKit::WebConnectionToUIProcess::messageSenderConnection):
(WebKit::WebConnectionToUIProcess::messageSenderDestinationID):

  • WebProcess/WebConnectionToUIProcess.h:

(WebConnectionToUIProcess):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::windowRect):
(WebKit::WebChromeClient::focusedFrameChanged):
(WebKit::WebChromeClient::createWindow):
(WebKit::WebChromeClient::toolbarsVisible):
(WebKit::WebChromeClient::statusbarVisible):
(WebKit::WebChromeClient::menubarVisible):
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::shouldInterruptJavaScript):
(WebKit::WebChromeClient::exceededDatabaseQuota):

  • WebProcess/WebCoreSupport/WebColorChooser.cpp:

(WebKit::WebColorChooser::WebColorChooser):
(WebKit::WebColorChooser::setSelectedColor):
(WebKit::WebColorChooser::endChooser):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveIcon):
(WebKit::WebFrameLoaderClient::updateGlobalHistory):
(WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebKit::WebFrameLoaderClient::setTitle):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::populatePluginCache):
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::copy):
(WebKit::WebPlatformStrategies::changeCount):
(WebKit::WebPlatformStrategies::uniqueName):
(WebKit::WebPlatformStrategies::color):
(WebKit::WebPlatformStrategies::url):
(WebKit::WebPlatformStrategies::addTypes):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setPathnamesForType):
(WebKit::WebPlatformStrategies::setStringForType):

  • WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::show):
(WebKit::WebPopupMenu::hide):

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:

(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::sendDidReceiveEvent):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::updateBackForwardItem):
(WebKit::WebBackForwardListProxy::itemAtIndex):
(WebKit::WebBackForwardListProxy::backListCount):
(WebKit::WebBackForwardListProxy::forwardListCount):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::didClose):
(WebKit::WebInspector::bringToFront):
(WebKit::WebInspector::inspectedURLChanged):
(WebKit::WebInspector::save):
(WebKit::WebInspector::append):
(WebKit::WebInspector::attachBottom):
(WebKit::WebInspector::attachRight):
(WebKit::WebInspector::detach):
(WebKit::WebInspector::setAttachedWindowHeight):
(WebKit::WebInspector::setAttachedWindowWidth):
(WebKit::WebInspector::setToolbarHeight):
(WebKit::WebInspector::updateDockingAvailability):
(WebKit::WebInspector::sendMessageToRemoteFrontend):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::messageSenderConnection):
(WebKit):
(WebKit::WebPage::messageSenderDestinationID):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::executeKeypressCommandsInternal):
(WebKit::WebPage::handleEditingKeyboardEvent):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensureNetworkProcessConnection):
(WebKit::WebProcess::shouldTerminate):

4:52 PM Changeset in webkit [150668] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit/mac

Remove using namespace std from Mac WebKit1
https://bugs.webkit.org/show_bug.cgi?id=116747

Reviewed by Sam Weinig.

Use explicit std:: qualifiers instead.

  • History/BinaryPropertyList.cpp:

(IntegerArray::deletedValueSize):
(BinaryPropertyListPlan::invalidObjectReference):
(bytesNeeded):

  • History/WebHistory.mm:

(-[WebHistoryPrivate orderedLastVisitedDays]):
(WebHistoryWriter::WebHistoryWriter):

  • History/WebHistoryItem.mm:

(-[WebHistoryItem initFromDictionaryRepresentation:]):

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::instantiatePlugin):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::wheelEvent):
(WebKit::NetscapePluginInstanceProxy::print):
(WebKit::NetscapePluginInstanceProxy::snapshot):
(WebKit::NetscapePluginInstanceProxy::loadURL):
(WebKit::NetscapePluginInstanceProxy::createBindingsInstance):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::invoke):
(WebKit::ProxyInstance::supportsInvokeDefaultMethod):
(WebKit::ProxyInstance::supportsConstruct):
(WebKit::ProxyInstance::getPropertyNames):
(WebKit::ProxyInstance::methodNamed):
(WebKit::ProxyInstance::fieldNamed):
(WebKit::ProxyInstance::fieldValue):
(WebKit::ProxyInstance::setFieldValue):

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage supportsExtension:]):
(-[WebBasePluginPackage MIMETypeForExtension:]):

  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::deliverData):

  • Plugins/WebNetscapePluginView.mm:

(PluginTimer::start):
(-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):

  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebFrame.mm:
  • WebView/WebHTMLView.mm:

(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):

  • WebView/WebTextCompletionController.mm:

(-[WebTextCompletionController _placePopupWindow:]):

4:46 PM Changeset in webkit [150667] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
4:37 PM Changeset in webkit [150666] by timothy_horton@apple.com
  • 6 edits in trunk/Source

Animated GIFs don't repaint after TiledCoreAnimationDrawingArea un-suspends painting
https://bugs.webkit.org/show_bug.cgi?id=116744
<rdar://problem/13973514>

Reviewed by Simon Fraser.

  • WebCore.exp.in: Export FrameView::resumeAnimatingImages.
  • page/FrameView.cpp:

(WebCore::FrameView::setIsInWindow):
(WebCore::FrameView::resumeAnimatingImages):
Factor the code to restart animated images out of frameView::setIsInWindow.

  • page/FrameView.h:

(FrameView):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::resumePainting):
Force WebCore to repaint animated images when painting is resumed.

4:30 PM Changeset in webkit [150665] by andersca@apple.com
  • 7 edits
    4 moves in trunk/Source

Move history property list writer to WebKit
https://bugs.webkit.org/show_bug.cgi?id=116746

Reviewed by Tim Horton.

Source/WebCore:

Remove files from the Xcode project and remove symbols that now live in WebKit.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

Add files to the Xcode project.

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Move WebCore history files to WebKit since they're only used by WebKit now.

  • History/BinaryPropertyList.cpp: Renamed from Source/WebCore/platform/cf/BinaryPropertyList.cpp.
  • History/BinaryPropertyList.h: Renamed from Source/WebCore/platform/cf/BinaryPropertyList.h.
  • History/HistoryPropertyList.cpp: Renamed from Source/WebCore/history/cf/HistoryPropertyList.cpp.
  • History/HistoryPropertyList.h: Renamed from Source/WebCore/history/cf/HistoryPropertyList.h.
  • History/WebHistory.mm:
4:15 PM Changeset in webkit [150664] by Christophe Dumez
  • 10 edits
    3 adds in trunk

Global constructors exposed in worker environment have wrong attributes
https://bugs.webkit.org/show_bug.cgi?id=116708

Reviewed by Geoffrey Garen.

Source/WebCore:

Fix JSC bindings generator so that Global constructors exposed in worker environment
have the following attributes:
{ Writable: true, Enumerable: false, Configurable: true }

This is now consistent with global constructors on DOMWindow and with the Web IDL
specification:
http://dev.w3.org/2006/webapi/WebIDL/#es-interfaces

Test: fast/js/global-constructors-attributes-worker.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributesHashTable):

LayoutTests:

Add fast/js/global-constructors-attributes-worker.html test case to check the
global constructors attributers in the worker environment.

  • fast/js/global-constructors-attributes-expected.txt:
  • fast/js/global-constructors-attributes-worker-expected.txt: Added.
  • fast/js/global-constructors-attributes-worker.html: Added.
  • fast/js/global-constructors-attributes.html:
  • fast/js/script-tests/global-constructors-attributes.js: Make sure script usable

in a Worker and stop reporting the "constructor" property as a global constructor.

  • platform/efl/fast/js/global-constructors-attributes-expected.txt:
  • platform/efl/fast/js/global-constructors-attributes-worker-expected.txt: Added.
  • platform/gtk/fast/js/global-constructors-attributes-expected.txt:
  • platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
  • platform/qt/fast/js/global-constructors-attributes-expected.txt:
3:57 PM Changeset in webkit [150663] by Christophe Dumez
  • 34 edits
    1 delete in trunk

Remove custom code for webkitAudioContext global constructor getter
https://bugs.webkit.org/show_bug.cgi?id=116530

Reviewed by Geoffrey Garen.

Source/WebCore:

Get rid of custom code for webkitAudioContext global constructor getter. The
global DOMWindow attribute is now automatically generated by leveraging support
for [EnabledAtRuntime] extended attribute and the existing methods in
RuntimeEnabledFeatures class.

No new tests, no behavior change.

  • GNUmakefile.list.am: Remove JSDOMWindowWebAudioCustom.*.
  • Modules/webaudio/AudioContext.idl:

Remove [NoInterfaceObject] extended attribute so that the global constructor is
automatically generated instead of automatically added. Add [EnabledAtRuntime]
extended attribute since this global constructor can be disabled at runtime and
so that we can getter rid of the [CustomGetter] for the corresponding global
constructor. Use [InterfaceName] extended attribute so that the interface name
matches the global constructor on DOMWindow (webkitAudioContext).

  • Target.pri: Remove JSDOMWindowWebAudioCustom.*.
  • UseJSC.cmake: Remove JSDOMWindowWebAudioCustom.*.
  • WebCore.exp.in: Export additional symbol.
  • WebCore.order: Export additional symbol.
  • WebCore.vcproj/WebCore.vcproj: Remove JSDOMWindowWebAudioCustom.*.
  • WebCore.vcxproj/WebCore.vcxproj: Remove JSDOMWindowWebAudioCustom.*.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Remove JSDOMWindowWebAudioCustom.*.
  • WebCore.xcodeproj/project.pbxproj: Remove JSDOMWindowWebAudioCustom.*.
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebAudioEnabled):

  • bindings/js/JSBindingsAllInOne.cpp: Remove JSDOMWindowWebAudioCustom.*.
  • bindings/js/JSDOMWindowWebAudioCustom.cpp: Removed. We no longer need any custom code for

the WebAudio global constructor getter because we use [EnabledAtRuntime] support in the
bindings generator now.

  • page/DOMWindow.idl: Remove global constructor for AudioContext as it is now automatically

generated.

  • page/Settings.in: Remove webAudioEnabled setting as we use the existing setting

in RuntimeEnabledFeatures now.

Source/WebKit/efl:

Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setWebAudioEnabled):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

  • ewk/ewk_view.h: Remove public API to toggle Web Audio support as it is no longer

a view specific feature.

Source/WebKit/gtk:

Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Source/WebKit/mac:

Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

Source/WebKit/win:

Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

Use RuntimeEnabledFeatures instead of WebCore Settings to toggle Web Audio support.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
WebAudio feature instead of public ewk_view API since that API was
removed.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::overridePreference):

3:49 PM WebKit Team edited by Bem Jones-Bey
Update to point to new location. (diff)
3:34 PM Changeset in webkit [150662] by commit-queue@webkit.org
  • 4 edits in trunk

Make team.html have each contributor's area of expertise
https://bugs.webkit.org/show_bug.cgi?id=116737

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-24
Reviewed by Benjamin Poulain.

Tools:

  • Scripts/webkitpy/common/config/contributors.json:

Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team

Changed formatting of the file because the lines are getting way to
long, and I generated this, so it's easier if the formatting of the
file is regular.

Websites/webkit.org:

  • team.html:

Update to use the new expertise field in contributors.json.

3:27 PM Changeset in webkit [150661] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL boolify should support ObjectOrOtherUse
https://bugs.webkit.org/show_bug.cgi?id=116741

Reviewed by Geoffrey Garen.

Just reusing what was already there in equalNullOrUndefined(). Note that we will
sometimes generate some redundant IR - like having some spurious bitNot's in
places - but it's safe to assume that LLVM will simplify those, and that it won't
be the longest pole in the tent for compile times.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEqConstant):
(JSC::FTL::LowerDFGToLLVM::boolify):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):

3:05 PM Changeset in webkit [150660] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit/win

Remove unused code to read/write history
https://bugs.webkit.org/show_bug.cgi?id=116738

Reviewed by Brent Fulgham.

  • Interfaces/IWebHistory.idl:

Replace loadFromURL and saveToURL with unused1/unused2.

  • Interfaces/IWebHistoryPrivate.idl:

Replace data with unused1.

  • WebHistory.cpp:

Remove history loading/saving code.

(WebHistory::unused1):
(WebHistory::unused2):
Add implementations.

  • WebHistory.h:

(WebHistory):

3:00 PM Changeset in webkit [150659] by fpizlo@apple.com
  • 7 edits
    3 adds in trunk

We broke !(0/0)
https://bugs.webkit.org/show_bug.cgi?id=116736

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createLogicalNot):

  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::pureToBoolean):

Source/WTF:

  • wtf/MathExtras.h:

(isNotZeroAndOrdered):
(isZeroOrUnordered):

LayoutTests:

  • fast/js/constant-fold-not-nan.html: Added.
  • fast/js/constant-fold-not-nan-expected.txt: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/constant-fold-not-nan.js: Added.
2:45 PM Changeset in webkit [150658] by fpizlo@apple.com
  • 4 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support LogicalNot and Branch on Int32 and Number
https://bugs.webkit.org/show_bug.cgi?id=116739

Reviewed by Gavin Barraclough.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):
(JSC::FTL::LowerDFGToLLVM::compileBranch):
(JSC::FTL::LowerDFGToLLVM::boolify):
(LowerDFGToLLVM):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::isZero32):
(JSC::FTL::Output::notZero32):

2:06 PM Changeset in webkit [150657] by fpizlo@apple.com
  • 11 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: add heuristics to reduce the likelihood of a trivially inlineable function being independently compiled by the concurrent JIT
https://bugs.webkit.org/show_bug.cgi?id=116557

Reviewed by Geoffrey Garen.

This introduces a fairly comprehensive mechanism for preventing trivially inlineable
functions from being compiled independently of all of the things into which they end
up being inlined.

The trick is CodeBlock::m_shouldAlwaysBeInlined, or SABI for short (that's what the
debug logging calls it). A SABI function is one that we currently believe should
never be DFG optimized because it should always be inlined into the functions that
call it. SABI follows "innocent until proven guilty": all functions start out SABI
and have SABI set to false if we see proof that that function may be called in some
possibly non-inlineable way. So long as a function is SABI, it will not tier up to
the DFG: cti_optimize will perpetually postpone its optimization. Because SABI has
such a severe effect, we make the burden of proof of guilt quite low. SABI gets
cleared if any of the following happen:

  • You get called from native code (either through CallData or CachedCall).


  • You get called from an eval, since eval code takes a long time to get DFG optimized.


  • You get called from global code, since often global code doesn't tier-up since it's run-once.


  • You get called recursively, where recursion is detected by a stack walk of depth Options::maximumInliningDepth().


  • You get called through an unlinked virtual call.


  • You get called from DFG code, since if the caller was already DFG optimized and didn't inline you then obviously, you might not get inlined.


  • You've tiered up to the baseline JIT and you get called from the interpreter. The idea here is that this kind of ensures that you stay SABI only if you're called no more frequently than any of your callers.


  • You get called from a code block that isn't a DFG candidate.


  • You aren't an inlining candidate.


Most of the heuristics for SABI are in CodeBlock::noticeIncomingCall().

This is neutral on SunSpider and V8Spider, and appears to be a slight speed-up on
V8v7, which was previously adversely affected by concurrent compilation. I also
confirmed that for example on V8/richards, it dramatically reduces the number of
code blocks that get DFG compiled. It is a speed-up on those V8v7 benchmarks that
saw regressions from concurrent compilation.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpAssumingJITType):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::linkIncomingCall):
(JSC):
(JSC::CodeBlock::noticeIncomingCall):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::mightInlineFunction):
(DFG):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThread):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkFor):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):
(JSC::JIT::linkFor):

  • jit/JIT.h:

(JIT):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC::lazyLinkFor):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::setUpCall):

1:26 PM Changeset in webkit [150656] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[AC] Needs to be guarded by USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=116712

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-24
Reviewed by Andreas Kling.

renderView is used when ACCELERATED_COMPOSITING is enabled.
So, this patch allows it to be guarded by USE(ACCELERATED_COMPOSITING).

No new tests, no behavior change.

  • page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):

1:07 PM Changeset in webkit [150655] by sergio@webkit.org
  • 3 edits in trunk/LayoutTests

REGRESSION (r150215): broke a test case in inspector/console/console-css-warnings.html
https://bugs.webkit.org/show_bug.cgi?id=116731

Reviewed by Ryosuke Niwa.

The mentioned revision removed a layering violation added just to
support some IE7 hack. That was removed but the test case
supporting it was left untouched, remove it.

  • inspector/console/console-css-warnings-expected.txt:
  • inspector/console/console-css-warnings.html:
12:43 PM Changeset in webkit [150654] by g.czajkowski@samsung.com
  • 6 edits in trunk/LayoutTests

[WK2] Spelling tests gardening
https://bugs.webkit.org/show_bug.cgi?id=116718

Unreviewed gardening.

The most spelling tests are skipped for wk2 platforms and they have deprecated comments.
Move the tests from global wk2/TestExpectations to the ports' TestExpectations as
the core spellchecking implementation is delivered for wk2.
This change will allow to run spelling tests easier and using [ Pass ] keyword
in TestExpectations won't be needed.

  • platform/efl-wk2/TestExpectations:
  • platform/gtk-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/wk2/TestExpectations:
12:41 PM Changeset in webkit [150653] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Add more lines to the context during Dictionary lookups
https://bugs.webkit.org/show_bug.cgi?id=115256

Patch by Thomas Deniau <deniau@apple.com> on 2013-05-24
Reviewed by Ryosuke Niwa.

Source/WebCore:

No new tests - no new functionality.

  • WebCore.exp.in: Export a few methods in VisibleUnits needed to be able

to call previousLinePosition(), nextLinePosition(), startOfLine() and
endOfLine() in WebPageMac.mm when determining the context while looking
up a dictionary definition. These symbols used to be exported for iOS
only, export them on the desktop too.

Source/WebKit2:

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation):
Instead of using the current paragraph as the context (which stops at
line breaks), get a few lines before and after the point, so that the
context contains at least four lines in each direction.
This way the Dictionary will be able to look up things that extend past
the current line.

12:07 PM Changeset in webkit [150652] by andersca@apple.com
  • 18 edits
    17 deletes in trunk

Remove PagePopup code
https://bugs.webkit.org/show_bug.cgi?id=116732

Reviewed by Andreas Kling.

.:

  • Source/cmakeconfig.h.cmake:

Remove ENABLE_PAGE_POPUP.

Source/WebCore:

Remove all page popup code.

  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContextFeatures.cpp:
  • dom/ContextFeatures.h:
  • loader/EmptyClients.h:
  • page/ChromeClient.h:
  • page/DOMWindowPagePopup.cpp: Removed.
  • page/DOMWindowPagePopup.h: Removed.
  • page/DOMWindowPagePopup.idl: Removed.
  • page/PagePopup.h: Removed.
  • page/PagePopupClient.cpp: Removed.
  • page/PagePopupClient.h: Removed.
  • page/PagePopupController.cpp: Removed.
  • page/PagePopupController.h: Removed.
  • page/PagePopupController.idl: Removed.
  • page/PagePopupDriver.h: Removed.
  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore):

  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:
  • testing/MockPagePopupDriver.cpp: Removed.
  • testing/MockPagePopupDriver.h: Removed.

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Remove PAGE_POPUP.

Source/WTF:

Remove ENABLE_PAGE_POPUP.

  • wtf/FeatureDefines.h:

LayoutTests:

Remove tests that relied on the mock page popup driver.

  • fast/forms/date/no-page-popup-controller-expected.txt: Removed.
  • fast/forms/date/no-page-popup-controller.html: Removed.
  • fast/forms/resources/picker-common.js: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings.html: Removed.
11:54 AM Changeset in webkit [150651] by jer.noble@apple.com
  • 13 edits
    3 copies
    1 add in trunk/Source

Mac: Set the default audio buffer size to a large value for <video> elements.
https://bugs.webkit.org/show_bug.cgi?id=116342

Source/WebCore:

Reviewed by Eric Carlson.
Roll-in rubber stamped by Eric Carlson.

To enable power savings by waking up the audio hardware less often, set the
requested buffer frame size to a large value, such as 4096. Since this results
in approximately 100ms worth of buffer, set the buffer size to a much lower
value when playing WebAudio, which is much more sensitive to latency than video
or audio elements.

Introduce a new class, AudioSessionManager, as well as a helper class,
AudioSessionManagerToken. Audio elements, video elements, and WebAudio destination
nodes will create and retain a token, and release the token in their destructor.
This allows the AudioSessionManager to track how many of what type of audio-
generating objects are in existence.

This requires implementing AudioSession for Mac platforms. Move the implementation
for retrieving the hardware sample rate and setting the buffer duration into
AudioSessionMac from AudioDestinationMac, to be shared with AudioSessionManagerMac.

Change the AudioSession method preferredBufferLength() into preferredBufferSize(),
as the callers really want to specify a buffer size, not a buffer duration. On iOS,
where the available API requires a duration, perform the conversion from duration to
size on behalf of the caller.

However, since the original version of this patch caused media test
failures on the Mac ML and Lion bots, only enable the buffer size
change for OS X > ML.

  • html/HTMLMediaElement.h: Add a AudioSessionManagerToken member.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize the token.

  • platform/audio/AudioSession.cpp:

(WebCore::AudioSession::preferredBufferSize): Renamed from preferredBufferLength.
(WebCore::AudioSession::setPreferredBufferSize): Renamed from setPreferredBufferLength.

  • platform/audio/AudioSession.h:
  • platform/audio/AudioSessionManager.cpp:

(AudioSessionManagerToken::create): Simple factory method.
(AudioSessionManagerToken::AudioSessionManagerToken): Call AudioSessionManager::incrementCount().
(AudioSessionManagerToken::~AudioSessionManagerToken): Call AudioSessionManager::decrementCount().
(AudioSessionManager::sharedManager): Simple singleton method.
(AudioSessionManager::AudioSessionManager): Simple constructor.
(AudioSessionManager::has): Return whether the type is present.
(AudioSessionManager::incrementCount): Increment, then call updateSessionState()
(AudioSessionManager::decrementCount): Decrement, then call updateSessionState()
(AudioSessionManager::updateSessionState): Stub, does nothing.

  • platform/audio/AudioSessionManager.h:
  • platform/audio/ios/AudioDestinationIOS.cpp:

(WebCore::AudioDestinationIOS::configure): Call setPreferredBufferSize() instead of setPreferredBufferLength()

  • platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::preferredBufferSize): Renamed from preferredBufferLength.
(WebCore::AudioSession::setPreferredBufferSize): Renamed from setPreferredBufferLength

  • platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestination::hardwareSampleRate): Call AudioSession::sampleRate().
(WebCore::AudioDestinationMac::AudioDestinationMac): Create the AudioSessionManagerToken.
(WebCore::AudioDestinationMac::configure): Do not set the buffer size (this is done in AudioSessionManagerMac).

  • platform/audio/mac/AudioDestinationMac.h:
  • platform/audio/mac/AudioSessionMac.cpp: Added.

(WebCore::defaultDevice): Added, returns the default audio device.
(WebCore::AudioSession::AudioSession): Simple constructor.
(WebCore::AudioSession::~AudioSession): Simple destructor.
(WebCore::AudioSession::category): Stub, unimplemented.
(WebCore::AudioSession::setCategory): Ditto.
(WebCore::AudioSession::categoryOverride): Ditto.
(WebCore::AudioSession::setCategoryOverride): Ditto.
(WebCore::AudioSession::numberOfOutputChannels): Ditto.
(WebCore::AudioSession::setActive): Ditto.
(WebCore::AudioSession::sampleRate): Use the HAL to return the default audio device sample rate.
(WebCore::AudioSession::preferredBufferSize): Return the current HAL setting.
(WebCore::AudioSession::setPreferredBufferSize): Set the buffer size.

  • platform/audio/mac/AudioSessionManagerMac.cpp:

(AudioSessionManager::updateSessionState): Set the buffer size depending on what audio outputs are present.

  • WebCore.xcodeproj/project.pbxproj: Add the new files to the project.

Source/WTF:

Reviewed by Eric Carlson.

  • wtf/Platform.h: Add a WTF_USE_AUDIO_SESSION setting.
11:46 AM Changeset in webkit [150650] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebCore

Merged r150631. <rdar://problem/13963712>

11:42 AM Changeset in webkit [150649] by Lucas Forschler
  • 7 edits in branches/safari-537.43-branch/Source/WebKit2

Merged r150620. <rdar://problem/13938510>

11:09 AM Changeset in webkit [150648] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Intermittent crash when typing in Address Bar
https://bugs.webkit.org/show_bug.cgi?id=116728
<rdar://problem/13976781>

Reviewed by Sam Weinig.

If a web process connection has been removed from the storage manager because we disconnected it
since there were no more active pages associated with the web process, we'll fail to find it here
so just return early instead of crashing.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::destroyStorageMap):

11:01 AM Changeset in webkit [150647] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source

Versioning.

10:28 AM Changeset in webkit [150646] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Path: upstream the missing bits from the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=116658

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-24
Reviewed by Xan Lopez.

PathBlackBerry was upstreamed a while ago (r144612) but a few bits
were missing from the cross-platform code.

  • platform/graphics/Path.cpp:

(WebCore::Path::addPathForRoundedRect):

  • platform/graphics/Path.h:

(Graphics):
(Path):

10:16 AM Changeset in webkit [150645] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Improve loader/go-back-cached-main-resource.html test
https://bugs.webkit.org/show_bug.cgi?id=116709

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-05-24
Reviewed by Alexey Proskuryakov.

It is only needed to register the listeners on the initial load as they
are already present when restoring from page cache. Modified the test to
use event.persisted property to know if we are handling the first load
in order to register the listeners only once.

  • loader/resources/first-page.html: Rename registerListeners() function

to a more accurate name didShowPage() and use event.persisted to
register the listeners only in the first load.

  • loader/resources/other-page.html: Ditto.
9:50 AM WebKit Team edited by kbalazs@webkit.org
(diff)
9:46 AM Changeset in webkit [150644] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[sh4] Optimize LLINT generated code and fix few bugs in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=116716

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-24
Reviewed by Geoffrey Garen.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::mul32): Cosmetic changes.
(JSC::MacroAssemblerSH4::convertInt32ToDouble): Absolute address was not dereferenced.
(JSC::MacroAssemblerSH4::branch32): Absolute address was not dereferenced.
(JSC::MacroAssemblerSH4::revertJumpReplacementToBranchPtrWithPatch): Use all 32 bits of pointer for revertJump call.

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::revertJump): Use changePCrelativeAddress to patch the whole pointer.
(JSC::SH4Assembler::linkJump): Cosmetic change.

  • offlineasm/sh4.rb: Optimize LLINT generated code.
9:34 AM Changeset in webkit [150643] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

WebProcess is crashing on http://achicu.github.io/css-presentation when direct pattern compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=115135

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-05-24
Reviewed by Antti Koivisto.

Source/WebCore:

Issue is invoked when there is a visibility:hidden layer with a non-compositable
background image (e.g. a radial gradient).
The layer is treated as a no-contents layer because of its visibility, however
updateDirectlyCompositedBackgroundImage() later mistakenly treats it as a layer
with direct background-image compositing.

Fixed by returning early from updating directly composited contents for layers
with hidden contents.

Test: compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateDirectlyCompositedContents):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::paintsChildren):
(WebCore::RenderLayerBacking::isDirectlyCompositedImage):

LayoutTests:

Added a ref-test that makes sure that a layer with a hidden radial gradient does not
cause the web process to crash.

  • compositing/patterns/direct-pattern-compositing-hidden-radial-gradient-expected.html: Added.
  • compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html: Added.
9:18 AM Changeset in webkit [150642] by robert@webkit.org
  • 2 edits in trunk/Source/WebCore

Refactor shouldAddBorderPaddingMargin()
https://bugs.webkit.org/show_bug.cgi?id=98803

Reviewed by Ryosuke Niwa.

Make this helper function less clever-stupid in its misguided sacrifice of intelligibility
for the sake of concision.

No new tests, refactoring.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::shouldAddBorderPaddingMargin):
(WebCore::inlineLogicalWidth):

8:51 AM Changeset in webkit [150641] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix bad type warning in InputHandler log.
https://bugs.webkit.org/show_bug.cgi?id=116720

Reviewed by Carlos Garcia Campos.

Fix warning in inputLog string.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::handleKeyboardInput):

7:48 AM Changeset in webkit [150640] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Update WTF::Vector pretty printers
https://bugs.webkit.org/show_bug.cgi?id=116719

Patch by Simon Pena <simon.pena@samsung.com> on 2013-05-24
Reviewed by Anders Carlsson.

After r148891, WTF::Vector pretty printers were left outdated, as
the WTF::Vector was made to extend a VectorBuffer, instead of keeping
one as a member. This patch updates the pretty printers so they work
again.

  • gdb/webkit.py:

(WTFVectorPrinter.children):
(WTFVectorPrinter.to_string):

7:20 AM Changeset in webkit [150639] by zarvai@inf.u-szeged.hu
  • 14 edits
    13 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Update qt-5.0-wk2 expected pictures after r150506.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-24

  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/qt-5.0-wk2/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
  • platform/qt-5.0-wk2/svg/filters/feImage-late-indirect-update-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-reference-invalidation-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-target-add-to-document-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-target-attribute-change-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-target-changes-id-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-target-id-change-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-target-inline-style-change-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-target-property-change-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-target-remove-from-document-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-target-style-change-expected.png: Added.
6:25 AM Changeset in webkit [150638] by kadam@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing tests.

  • platform/qt-5.0-wk2/TestExpectations: Move http/tests/security/cross-frame-access-put.html to qt/TestExpectations.
  • platform/qt/TestExpectations: Skip fast/frames/detach-frame-during-focus.html after r146523.
5:47 AM Changeset in webkit [150637] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Respect tabindex when using form controls.
https://bugs.webkit.org/show_bug.cgi?id=116676

Reviewed by Xan Lopez.

PR 337419.

Update form control navigation tracking to take tabindex
order into account when calculating next and previous nodes.

The order to follow is tab index 1 - N, followed by all items
without a tab index or tab index 0 in rendering order to match
with standard desktop behavior.

Internally Reviewed by Genevieve Mak and Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::updateFormState):

5:23 AM WebKitGTK/TrackingMemoryErrors edited by kbalazs@webkit.org
(diff)
1:41 AM Changeset in webkit [150636] by sfalken@apple.com
  • 2 edits in trunk/Tools

Update prepareConsistentTestingEnvironment to use a non-deprecated API.
https://bugs.webkit.org/show_bug.cgi?id=116710

Reviewed by Mark Rowe.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.

1:05 AM Changeset in webkit [150635] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] DRT - crashed on GraphicsContext3D::makeContextCurrent
https://bugs.webkit.org/show_bug.cgi?id=116654

Patch by Xiaobo Wang <xiaobwang@blackberry.com> on 2013-05-24
Reviewed by Carlos Garcia Campos.

PR 331552.
Internally reviewed and amended by Arvid Nilsson.

No new tests, this patch is to fix DRT crashes in fast/canvas/webgl.
The instance of GraphicsContext3D has already been destroyed but
WebGLLayerWebKitThread is not aware of that. This is because compositor
layer of the WebGL graphics context was referenced outside the context.
So when destructing GraphicsContext3D the compositing layer was not
destructed.
Fix by setting m_webGLContext to 0 when destructing GrapthicsContext3D
after releasing the compositor layer, so that it won't be de-referenced
again later.

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::~GraphicsContext3D):

  • platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:

(WebCore::WebGLLayerWebKitThread::~WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::webGLContextDestroyed):
(WebCore):

  • platform/graphics/blackberry/WebGLLayerWebKitThread.h:

(WebGLLayerWebKitThread):

12:32 AM Changeset in webkit [150634] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove SKIA leftovers from WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=116656

Patch by Jeff Rogers <jrogers@rim.com> on 2013-05-24
Reviewed by Rob Buis.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):

12:12 AM Changeset in webkit [150633] by akling@apple.com
  • 6 edits in trunk/Source

Typing in Safari's unified field causes unnecessary web content repaints.
<http://webkit.org/b/116703>

Reviewed by Andy Estes.

Source/WebCore:

Break out an alternate version of Page::markAllMatchesForText() that only counts the number of times
a string occurs in the page, but doesn't try to mark the occurrences.
This allows Safari to count matches for the 'Find "foo" on This Page' functionality in the unified
location bar without causing tile repaints.

  • WebCore.exp.in:
  • page/Page.h:
  • page/Page.cpp:

(WebCore::Page::findMatchesForText):
(WebCore::Page::markAllMatchesForText):
(WebCore::Page::countFindMatches):

Renamed markAllMatchesForText() to findMatchesForText() and gave it a boolean parameter to control whether
matches should be marked or not. countFindMatches() is the new helper that doesn't mark.

Source/WebKit2:

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::countStringMatches):

Call WebCore::Page::countMatchesForText() instead of markAllMatchesForText(). If the search string
is found inside the page content, the renderer containing that text will no longer be repainted.

12:05 AM Changeset in webkit [150632] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Add back a failing test expectation on fast/canvas/webgl/object-deletion-behaviour.html
after r150558 on Lion Debug WK1.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
12:02 AM Changeset in webkit [150631] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=116702
REGRESSION (r150399): Scrollbar missing for all overflow scroll
-and corresponding-
<rdar://problem/13963712>

Reviewed by Simon Fraser.

This was a silly copy-paste error.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollbarAnimationsAreSuppressed):

May 23, 2013:

11:56 PM Changeset in webkit [150630] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

CLoop llint backend should not use the d8 register as scratch register
https://bugs.webkit.org/show_bug.cgi?id=116019

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2013-05-23
Reviewed by Csaba Osztrogonác.

  • offlineasm/cloop.rb:
11:26 PM Changeset in webkit [150629] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
https://bugs.webkit.org/show_bug.cgi?id=115245

Patch by Xiaobo Wang <xiaobwang@blackberry.com> on 2013-05-23
Reviewed by Rob Buis.

PR 330917.
Internally reviewed by Arvid Nilsson.

  1. Suspend/resumeRootLayerCommit when notified app activation state

change.

  1. Schedule root layer commit in resumeRootLayerCommit() to explicitly

start root layer commit timer, so that there's a commit even if
BackingStore got disabled/removed.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):

11:23 PM Changeset in webkit [150628] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Need to forward the opener frame url to client when creating a new window
https://bugs.webkit.org/show_bug.cgi?id=116566

Patch by Andy Chen <andchen@blackberry.com> on 2013-05-23
Reviewed by Rob Buis.

PR 337935
Internally reviewed by Arvid Nilsson.
When creating a new window, forward the opener frame url to client.

  • Api/WebPageClient.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::createWindow):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):

11:20 PM Changeset in webkit [150627] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=116671

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-05-23
Reviewed by Brent Fulgham.

  • page/FrameView.h: Added guard for ACCELERATED_COMPOSITING.
11:15 PM Changeset in webkit [150626] by lauro.neto@openbossa.org
  • 2 edits in trunk/Tools

Add missing dependencies to deps script.

[GTK] Missing packages in install-dependencies script.
https://bugs.webkit.org/show_bug.cgi?id=116632

Reviewed by Martin Robinson.

  • gtk/install-dependencies:
11:07 PM Changeset in webkit [150625] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Compositor API change: Don't pass the unused "viewport" parameter.
https://bugs.webkit.org/show_bug.cgi?id=116545
Internal PR 189775

Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-05-23
Reviewed by Rob Buis.

Also change the name of the "documentContents" parameter
to the more descriptive "documentSrcRect".

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositor::render):

  • Api/WebPageCompositor.h:
  • Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

10:14 PM Changeset in webkit [150624] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL][QT] Build break after r150610
https://bugs.webkit.org/show_bug.cgi?id=116699

Patch by Ryuan Choi <ryuan.choi@samsung.com> on 2013-05-23
Reviewed by Csaba Osztrogonác.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin): Initialized pluginProcessSandboxPolicy.

7:59 PM Changeset in webkit [150623] by Lucas Forschler
  • 1 copy in tags/Safari-537.43.1

New Tag.

6:35 PM Changeset in webkit [150622] by fpizlo@apple.com
  • 11 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: rationalize DFG::CapabilityLevel and DFGCapabilities.[h|cpp]
https://bugs.webkit.org/show_bug.cgi?id=116696

Reviewed by Sam Weinig.

Make it so that all capability calculation is funneled through one function, which tells
you everything you wanted to know: can it be inlined, and can it be compiled.

This work will help with https://bugs.webkit.org/show_bug.cgi?id=116557, since now the
JIT has a fairly authoritative answer to the "can it be inlined" question.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::capabilityLevelInternal):
(JSC::EvalCodeBlock::capabilityLevelInternal):
(JSC::FunctionCodeBlock::capabilityLevelInternal):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::capabilityLevel):
(JSC::CodeBlock::capabilityLevelState):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::debugFail):
(DFG):
(JSC::DFG::canInlineResolveOperations):
(JSC::DFG::capabilityLevel):

  • dfg/DFGCapabilities.h:

(DFG):
(JSC::DFG::capabilityLevel):
(JSC::DFG::evalCapabilityLevel):
(JSC::DFG::programCapabilityLevel):
(JSC::DFG::functionForCallCapabilityLevel):
(JSC::DFG::functionForConstructCapabilityLevel):
(JSC::DFG::canInlineFunctionForCall):
(JSC::DFG::canInlineFunctionForClosureCall):
(JSC::DFG::canInlineFunctionForConstruct):

  • dfg/DFGCommon.h:

(JSC::DFG::canCompile):
(DFG):
(JSC::DFG::canInline):
(JSC::DFG::leastUpperBound):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

  • tools/CodeProfile.cpp:

(JSC::CodeProfile::sample):

6:33 PM Changeset in webkit [150621] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

[Windows] Rolling back r150600 as it breaks the VS2010 builds.

  • wtf/StackBounds.cpp: Rollback.
5:43 PM Changeset in webkit [150620] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Shim Flash plug-in to allow its updater to run
https://bugs.webkit.org/show_bug.cgi?id=116692
<rdar://problem/13938510>

Reviewed by Sam Weinig.

  • PluginProcess/PluginProcess.h:
  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::replacedNSConcreteTask_launch):
(WebKit::initializeCocoaOverrides):
Patch -[NSConcreteTask launch] to call PluginProcess::launchProcess.

(WebKit::PluginProcess::launchProcess):
Send a LaunchProcess message to the UI process.

  • UIProcess/Plugins/PluginProcessProxy.cpp:
  • UIProcess/Plugins/PluginProcessProxy.h:

Remove PluginProcessProxy::didReceiveMessage.

(PluginProcessProxy):

  • UIProcess/Plugins/PluginProcessProxy.messages.in:

Add LaunchProcess message and remove LegacyReceiver attribute.

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::isFlashUpdater):
Helper function to determine whether the process is the flash updater.

(WebKit::shouldLaunchProcess):
Return whether we should launch this process.

(WebKit::PluginProcessProxy::launchProcess):
Determine if we should launch this process and then do so.

5:41 PM Changeset in webkit [150619] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed change for NRWT support.

  • Scripts/webkitpy/port/win.py:

(WinPort.default_child_processes): Added a default implementation
that limits NRWT to a single instance.

5:03 PM Changeset in webkit [150618] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed. Modify WebCore for AppleWin 2010 production build.

  • WebCore.vcxproj/WebCoreGenerated.make:

(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
4:44 PM Changeset in webkit [150617] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Rebaseline after r150593
https://bugs.webkit.org/show_bug.cgi?id=116695

Unreviewed gardening.

Moved some editing tests from execCommand into pasteboard.

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-23

  • platform/efl/TestExpectations:
4:22 PM Changeset in webkit [150616] by fpizlo@apple.com
  • 6 edits in trunk/LayoutTests

Make Math.imul tests run quicker, and fix some other bugs.

Rubber stampted by Oliver Hunt.

Also make tests not call print().

  • fast/js/regress/script-tests/cell-argument.js:
  • fast/js/regress/script-tests/imul-double-only.js:

(f):

  • fast/js/regress/script-tests/imul-int-only.js:

(f):

  • fast/js/regress/script-tests/imul-mixed.js:

(f):

  • fast/js/regress/script-tests/object-closure-call.js:
4:00 PM Changeset in webkit [150615] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Remove meaningless "test_uses_apache" from Python test cases.
https://bugs.webkit.org/show_bug.cgi?id=38756

Patch by Brent Fulgham <Brent Fulgham> on 2013-05-23
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/port/port_testcase.py:

(PortTestCase.test_driver_cmd_line): Remove the meaningless
"test_uses_apache" test case from the Python test infrastructure.
It was hard-coded to true, even though not all ports use
Apache.

2:44 PM Changeset in webkit [150614] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebKit2

Merged r150610. <rdar://problem/13975569>

2:17 PM Changeset in webkit [150613] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

We need to clear main resource when detaching DocumentLoader from the frame.
https://bugs.webkit.org/show_bug.cgi?id=116680

Normally, when we detach the documentLoader in DocumentLoader::detachFromFrame, main resource is also cleared
in stopLoading(). There is possibility that main resource not being cleared, and this could cause crash later
since docLoader could still receive resource callbacks. To avoid that, we can remove docLoader from main resource's
client set in detachFromFrame.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-05-23
Reviewed by Brady Eidson.

No new tests, this doesn't happen on OS X.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::detachFromFrame):
(WebCore::DocumentLoader::clearMainResource):

  • loader/cache/CachedResource.h: make hasClient accessible publicly.

(WebCore::CachedResource::hasClient):
(CachedResource):

1:59 PM Changeset in webkit [150612] by Brent Fulgham
  • 3 edits in trunk/Tools

[Windows] Update new-run-webkit-tests for Windows port.
https://bugs.webkit.org/show_bug.cgi?id=38756

Patch by Brent Fulgham <bfulgham@webkit.org> on 2013-05-23
Reviewed by Ryosuke Niwa.

  • Scripts/new-run-webkit-httpd:

(run): Switch from 'chromium' to 'win'

  • Scripts/webkitpy/port/win.py:

(WinPort): Add support methods for lighttpd server.
(WinPort._uses_apache):
(WinPort._path_to_lighttpd):
(WinPort._path_to_lighttpd_modules):
(WinPort._path_to_lighttpd_php):

1:56 PM Changeset in webkit [150611] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk
assertion failed: !node
node->isElementNode() in WebCore::RenderBlock::clone

https://bugs.webkit.org/show_bug.cgi?id=116614

Patch by Mihai Maerean <Mihai Maerean> on 2013-05-23
Reviewed by David Hyatt.

Source/WebCore:

Add a test for flow threads so they don't end up being cloned in region based multi columns with columns:1 where
the only child has column-span:all.

Test: fast/multicol/newmulticol/direct-child-column-span-all.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

LayoutTests:

  • fast/multicol/newmulticol/direct-child-column-span-all-expected.txt: Added.
  • fast/multicol/newmulticol/direct-child-column-span-all.html: Added.
1:48 PM Changeset in webkit [150610] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Don't run all plug-ins unsandboxed
https://bugs.webkit.org/show_bug.cgi?id=116690
<rdar://problem/13975569>

Reviewed by Jessie Berlin.

Remove debugging code.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin):

1:08 PM Changeset in webkit [150609] by andersca@apple.com
  • 7 edits in trunk/Source

Crash in convertMainResourceLoadToDownload when downloading file by option-return
https://bugs.webkit.org/show_bug.cgi?id=116451

Reviewed by Andreas Kling.

Source/WebCore:

Handle MainResourceLoader being null here which will happen when loading a cached main resource.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::continueAfterContentPolicy):

Source/WebKit/mac:

If the main resource loader is null, create a new download instead since there's no existing loader to convert.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::convertMainResourceLoadToDownload):

Source/WebKit2:

If the main resource loader is null, create a new download instead since there's no existing loader to convert.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::convertMainResourceLoadToDownload):

12:56 PM Changeset in webkit [150608] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove a stale test expectation.

  • platform/wk2/TestExpectations:
12:49 PM Changeset in webkit [150607] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Update Mac test expectations for the bug 85408 as bugs 116398 and 116477 have been merged into it.

  • platform/mac/TestExpectations:
12:46 PM Changeset in webkit [150606] by benjamin@webkit.org
  • 12 edits in trunk/Source/WebCore

KURL::createCFURL() should return a RetainPtr<CFURLRef>
https://bugs.webkit.org/show_bug.cgi?id=116644

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-23
Reviewed by Andreas Kling.

For consistency with the other createCFType() APIs in WebKit, KURL should
return a RetainPtr<> instead of raw +1 CFURLRef.

No leak were discovered while making this change.

  • platform/KURL.h:
  • platform/cf/KURLCFNet.cpp:

(WebCore):
(WebCore::createCFURLFromBuffer):
(WebCore::KURL::createCFURL):
(WebCore::KURL::fileSystemPath):

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::createAssetForURL):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setURLForRect):

  • platform/mac/KURLMac.mm:

(WebCore):
(WebCore::KURL::operator NSURL *):
(WebCore::KURL::createCFURL):

  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):

  • platform/network/cf/DNSCFNet.cpp:

(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):

  • platform/network/cf/ProxyServerCFNet.cpp:

(WebCore::addProxyServersForURL):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::cfURLResponse):

  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):

12:42 PM Changeset in webkit [150605] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add back failing test expectations for the bugs 88672 and 89528 after r150558 and r150559 on Lion.

  • platform/mac/TestExpectations:
12:37 PM Changeset in webkit [150604] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

fast/workers/storage/use-same-database-in-page-and-workers.html times out on the lion bots
https://bugs.webkit.org/show_bug.cgi?id=81618

Add back the flaky test failure on Mac.

  • platform/mac/TestExpectations:
12:19 PM Changeset in webkit [150603] by Patrick Gansterer
  • 3 edits in trunk/Source/WTF

Use correct stack size on Solaris and OpenBSD
https://bugs.webkit.org/show_bug.cgi?id=114978

Reviewed by Oliver Hunt.

Original patch by David Hill <david@wmol.com>.

Use stack_t.ss_size for getting the size of the stack.

  • wtf/Platform.h:
  • wtf/StackBounds.cpp:

(WTF):
(WTF::StackBounds::initialize):

11:55 AM Changeset in webkit [150602] by robert@webkit.org
  • 5 edits
    2 adds in trunk

The ellipsis in a text overflow should not avoid floats
https://bugs.webkit.org/show_bug.cgi?id=115746

Reviewed by David Hyatt.

Source/WebCore:

When placing an ellipsis for text overflow we shouldn't avoid any floats on the line.
That is to say, if there is a float in the box we overflow we should let our no-wrap text,
including the ellipsis, render inside the float just as we would if overflow was hidden but
a text-overflow rendering had not been specified.

Test: fast/css/text-overflow-ellipsis-behind-floats.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::checkLinesForTextOverflow):

LayoutTests:

  • fast/css/text-overflow-ellipsis-behind-floats-expected.html: Added.
  • fast/css/text-overflow-ellipsis-behind-floats.html: Added.
  • fast/css/text-overflow-ellipsis-full-truncate-rtl-expected.html:
  • fast/css/text-overflow-ellipsis-full-truncate-rtl.html: Change this test to expect the text to cross into the floating input element and render the ellipsis at the left extreme of the element. The previous expected rendering relied on the incorrect premise that an overflow ellipsis should avoid floated elements.
11:51 AM Changeset in webkit [150601] by Lucas Forschler
  • 15 edits in branches/safari-537.43-branch/Source

Merged r150556. <rdar://problem/13918391>

11:51 AM Changeset in webkit [150600] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

[WIN] Implement correct detection of stack size
https://bugs.webkit.org/show_bug.cgi?id=116661

Reviewed by Oliver Hunt.

  • wtf/StackBounds.cpp:

(WTF):
(WTF::StackBounds::initialize):

11:49 AM Changeset in webkit [150599] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13849260> Sandbox violations reading .CFUserTextEncoding

Reviewed by Dan Bernstein.

  • WebProcess/com.apple.WebProcess.sb.in: Allow this.
11:48 AM Changeset in webkit [150598] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebKit2

Merged r150543. <rdar://problem/13904054>

11:44 AM Changeset in webkit [150597] by Lucas Forschler
  • 6 edits in branches/safari-537.43-branch/Source/WebKit2

Merged r150537. <rdar://problem/13964515>

11:30 AM Changeset in webkit [150596] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

[Lion] [WK2] compositing/overflow/overflow-compositing-descendant.html
https://bugs.webkit.org/show_bug.cgi?id=116684

Add a timeout/failure test expectation. Also update the expected result since the first frame
of the video must be shown in this test.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/compositing/overflow/overflow-compositing-descendant-expected.png:
11:03 AM Changeset in webkit [150595] by barraclough@apple.com
  • 2 edits in trunk/Source/WebKit2

Move posix_spawn onto a zero delay timer
https://bugs.webkit.org/show_bug.cgi?id=116682

Reviewed by Anders Carlson.

<rdar://problem/13973468>

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:

(ReexecInfo):

  • struct to hold info from the XPC message.

(WebKit::reexec):

  • moved call to posix_spawn out to this helper.

(WebKit::reexecCallBack):

  • calls reexec.

(WebKit::XPCServiceEventHandler):

  • removed call to posix_spawn; schedule a call to reexecCallBack.
10:52 AM Changeset in webkit [150594] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Fix loader/go-back-cached-main-resource.html test
https://bugs.webkit.org/show_bug.cgi?id=116670

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-05-23
Reviewed by Alexey Proskuryakov.

The page does not get an onload when being restored from page cache. The
test case case is modified to handle pageshow event instead.

  • loader/go-back-cached-main-resource.html: Wait for the third

'first-page' message to finish the test.

  • loader/resources/first-page.html: Use onpageshow instead of onload.
  • loader/resources/other-page.html: Ditto.
10:50 AM Changeset in webkit [150593] by rniwa@webkit.org
  • 1 edit
    13 moves in trunk/LayoutTests

Several editing tests that copy & paste slow down Mac WK2 EWS
https://bugs.webkit.org/show_bug.cgi?id=116681

Reviewed by Anders Carlsson.

Move editing tests that trigger copy and paste from execCommand into pasteboard.
Since NWRT uses a single instance of WebKitTestRunner to run tests in single directory,
this should mitigate the issue for now.

In the long term, we should really mock out the clipboard in WebKitTestRunner.

  • editing/execCommand/4128080-2-expected.txt: Removed.
  • editing/execCommand/4128080-2.html: Removed.
  • editing/execCommand/5939887-expected.txt: Removed.
  • editing/execCommand/5939887.html: Removed.
  • editing/execCommand/copy-without-selection-expected.txt: Removed.
  • editing/execCommand/copy-without-selection.html: Removed.
  • editing/execCommand/paste-2.html: Removed.
  • editing/pasteboard/copy-cut-paste-events-fired-when-disabled-expected.txt: Copied from LayoutTests/editing/execCommand/5939887-expected.txt.
  • editing/pasteboard/copy-cut-paste-events-fired-when-disabled.html: Copied from LayoutTests/editing/execCommand/5939887.html.
  • editing/pasteboard/copy-inside-h1-preserves-h1-expected.txt: Copied from LayoutTests/editing/execCommand/4128080-2-expected.txt.
  • editing/pasteboard/copy-inside-h1-preserves-h1.html: Copied from LayoutTests/editing/execCommand/4128080-2.html.
  • editing/pasteboard/copy-without-selection-expected.txt: Copied from LayoutTests/editing/execCommand/copy-without-selection-expected.txt.
  • editing/pasteboard/copy-without-selection.html: Copied from LayoutTests/editing/execCommand/copy-without-selection.html.
  • editing/pasteboard/paste-2.html: Copied from LayoutTests/editing/execCommand/paste-2.html.
  • platform/gtk/editing/execCommand/paste-2-expected.png: Removed.
  • platform/gtk/editing/execCommand/paste-2-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-2-expected.png: Copied from LayoutTests/platform/gtk/editing/execCommand/paste-2-expected.png.
  • platform/gtk/editing/pasteboard/paste-2-expected.txt: Copied from LayoutTests/platform/gtk/editing/execCommand/paste-2-expected.txt.
  • platform/mac/editing/execCommand/paste-2-expected.png: Removed.
  • platform/mac/editing/execCommand/paste-2-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-2-expected.png: Copied from LayoutTests/platform/mac/editing/execCommand/paste-2-expected.png.
  • platform/mac/editing/pasteboard/paste-2-expected.txt: Copied from LayoutTests/platform/mac/editing/execCommand/paste-2-expected.txt.
  • platform/qt/editing/execCommand/paste-2-expected.png: Removed.
  • platform/qt/editing/execCommand/paste-2-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-2-expected.png: Copied from LayoutTests/platform/qt/editing/execCommand/paste-2-expected.png.
  • platform/qt/editing/pasteboard/paste-2-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/paste-2-expected.txt.
10:49 AM Changeset in webkit [150592] by Patrick Gansterer
  • 2 edits in trunk/Tools

Make default bug links in buildbot clickable
https://bugs.webkit.org/show_bug.cgi?id=116673

Reviewed by Ryosuke Niwa.

Use changecommentlink of html.WebStatus to make the links clickable.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
10:39 AM WebKit Team edited by levin@chromium.org
(diff)
10:17 AM Changeset in webkit [150591] by Patrick Gansterer
  • 2 edits in trunk/Websites/bugs.webkit.org

EWS bubbles need more space
https://bugs.webkit.org/show_bug.cgi?id=116675

Reviewed by Andreas Kling.

  • template/en/custom/attachment/list.html.tmpl:
9:45 AM Changeset in webkit [150590] by Christophe Dumez
  • 13 edits in trunk

Unreviewed, rolling out r150586.
http://trac.webkit.org/changeset/150586
https://bugs.webkit.org/show_bug.cgi?id=116660

Those constructors should be exposed on the WorkerContext, not
the DOMWindow

Source/WebCore:

  • fileapi/FileReaderSync.idl:
  • workers/WorkerLocation.idl:

LayoutTests:

  • fast/js/global-constructors-attributes-expected.txt:
  • platform/efl/fast/js/constructor-length-expected.txt:
  • platform/efl/fast/js/global-constructors-attributes-expected.txt:
  • platform/gtk/fast/js/constructor-length-expected.txt:
  • platform/gtk/fast/js/global-constructors-attributes-expected.txt:
  • platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
  • platform/mac/fast/js/constructor-length-expected.txt:
  • platform/qt/fast/js/constructor-length-expected.txt:
  • platform/qt/fast/js/global-constructors-attributes-expected.txt:
9:13 AM Changeset in webkit [150589] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[CSS Regions][Mac] [WK2] Layout Test fast/regions/fixed-pos-elem-in-region.html is flaky on Debug builders
https://bugs.webkit.org/show_bug.cgi?id=114571

Tests seems to be passing now, removed from TestExpectations.

Patch by Radu Stavila <stavila@adobe.com> on 2013-05-23
Reviewed by Anders Carlsson.

  • platform/mac-wk2/TestExpectations:
9:11 AM Changeset in webkit [150588] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] The web context does not contain any link properties if the context node is an image enclosed by a link node
https://bugs.webkit.org/show_bug.cgi?id=116627

Patch by Ed Baker <edbaker@blackberry.com> on 2013-05-23
Reviewed by Xan Lopez.

PR #341084

If the context node has an image tag and an enclosing link node was detected then add the link properties to the context.

Internally Reviewed by Gen Mak.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

8:55 AM Changeset in webkit [150587] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Validate form data before doing direct submission.
https://bugs.webkit.org/show_bug.cgi?id=116674

Reviewed by Xan Lopez.

PR 314202.

Check validation of the input form before triggering direct submission.

Internally Reviewed by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::submitForm):

8:20 AM Changeset in webkit [150586] by Christophe Dumez
  • 13 edits in trunk

Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation
https://bugs.webkit.org/show_bug.cgi?id=116660

Reviewed by Kentaro Hara.

Source/WebCore:

Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation to match their
respective specifications:

No new tests, covered by existing tests.

  • fileapi/FileReaderSync.idl:
  • workers/WorkerLocation.idl:

LayoutTests:

Rebaseline a couple of test cases now that FileReaderSync and WorkerLocation
attributes are exposed on the global Window object.

  • fast/js/global-constructors-attributes-expected.txt:
  • platform/efl/fast/js/constructor-length-expected.txt:
  • platform/efl/fast/js/global-constructors-attributes-expected.txt:
  • platform/gtk/fast/js/constructor-length-expected.txt:
  • platform/gtk/fast/js/global-constructors-attributes-expected.txt:
  • platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
  • platform/mac/fast/js/constructor-length-expected.txt:
  • platform/qt/fast/js/constructor-length-expected.txt:
  • platform/qt/fast/js/global-constructors-attributes-expected.txt:
7:14 AM Changeset in webkit [150585] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
https://bugs.webkit.org/show_bug.cgi?id=116603

Patch by Rob Buis <rbuis@rim.com> on 2013-05-23
Reviewed by Xan Lopez.

PR 119789
Internally reviewed by Yong Li.

Provide a domain value for this ResourceError instance. Note that
this does not change behavior.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):

7:00 AM Changeset in webkit [150584] by zarvai@inf.u-szeged.hu
  • 3 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/TestExpectations: Skip some failing test.
  • platform/qt-5.0-wk2/fast/forms/select-baseline-expected.png: Rebaselined after r148594.
  • platform/qt-5.0-wk2/fast/forms/select-baseline-expected.txt:
  • platform/qt-5.0-wk2/fast/images/repaint-subrect-grid-expected.txt: Rebaselined after r149292.
6:42 AM TestExpectations edited by simon.pena@samsung.com
Link to "Writing Reftests" to explain more on reference tests (diff)
6:17 AM Changeset in webkit [150583] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[cmake] Fix generating-forwarding-headers rule after r150460
https://bugs.webkit.org/show_bug.cgi?id=116659

Reviewed by Christophe Dumez.

  • CMakeLists.txt: Typo fix.
5:45 AM Changeset in webkit [150582] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK] Remote Web Inspector sometimes won't serve any content
https://bugs.webkit.org/show_bug.cgi?id=116225

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-05-23
Reviewed by Gustavo Noronha Silva.

Added an option to use environment variable to set up path to
inspector server files. Implementation is similar to InspectorClientGtk
implementation.

  • UIProcess/InspectorServer/WebInspectorServer.h:

(WebInspectorServer):

  • UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath):
(WebKit::WebInspectorServer::inspectorServerFilesPath):
(WebKit):

5:30 AM Changeset in webkit [150581] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Use WK2 C API in ewk_view_pagination_mode_set|get
https://bugs.webkit.org/show_bug.cgi?id=116657

Reviewed by Christophe Dumez.

WKPageGet|SetPaginationMode APIs is present in WK2 C APIs. So, we need to use them for
ewk_view_pagination_mode_set|get.

Besides we don't need to use WebCore namespace anymore.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):

5:22 AM Changeset in webkit [150580] by Christophe Dumez
  • 13 edits in trunk/Source/WebCore

Remove special case for MessagePortArray from bindings generator
https://bugs.webkit.org/show_bug.cgi?id=116653

Reviewed by Kentaro Hara.

Use MessagePort[] instead of MessagePortArray type in the IDL as MessagePortArray
is not defined on IDL side. This allows us to remove the special case for
MessagePortArray from the bindings generator.

No new tests, no behavior change.

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):

  • bindings/scripts/CodeGeneratorJS.pm:

(NativeToJSValue): Remove special case for MessagePortArray.

  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:

(WebDOMTestSerializedScriptValueInterface):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(webkit_dom_test_serialized_script_value_interface_get_property):
(webkit_dom_test_serialized_script_value_interface_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::jsTestSerializedScriptValueInterfacePorts):

  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
  • bindings/scripts/test/TestSerializedScriptValueInterface.idl: Replace MessagePortArray

by MessagePort[].

  • dom/MessageEvent.h:

(WebCore::MessageEvent::ports): The method should return a Vector, not a Vector*
as the array on JavaScript side is not nullable.

  • dom/MessageEvent.idl: Replace MessagePortArray by MessagePort[].
3:32 AM Changeset in webkit [150579] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

media/W3C/video/networkState/networkState_during_progress.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=76280

Unreviewed gardening.

Change expectation to the correct output and mark as flaky.

  • TestExpectations:
  • media/W3C/video/networkState/networkState_during_progress-expected.txt:
2:26 AM Changeset in webkit [150578] by kadam@inf.u-szeged.hu
  • 4 edits in trunk/Source/WebKit2

Support frame instrumentation for coordinated graphics
https://bugs.webkit.org/show_bug.cgi?id=115260

Patch by Roland Takacs <rtakacs@inf.u-szeged.hu> on 2013-05-23
Reviewed by Andreas Kling.

Enabled supportsFrameInstrumentation on ports that use coordinated graphics
by calling didBeginFrame().

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::supportsFrameInstrumentation):
(WebKit):

  • WebProcess/WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::syncDisplayState):

2:20 AM Changeset in webkit [150577] by zarvai@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk1/TestExpectations: Remove a test failure that skipped in qt.
  • platform/qt/TestExpectations: Unskip now passing test.
1:39 AM Changeset in webkit [150576] by zarvai@inf.u-szeged.hu
  • 3 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/TestExpectations: Unskip after rebaseline.
  • platform/qt/TestExpectations: Skip flaky test.
  • platform/qt/plugins/mouse-events-expected.txt: Rebaselining after r150558.
12:06 AM Changeset in webkit [150575] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Back, Forward and Stop should be hidden in context menu
https://bugs.webkit.org/show_bug.cgi?id=116615

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-05-23
Reviewed by Christophe Dumez.

Context menu items: Back, Forward, Stop, Reload, should be shown only when
they are able to perform action.

No new tests - no new functionality.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

Note: See TracTimeline for information about the timeline view.