Timeline
May 25, 2013:
- 10:05 PM Changeset in webkit [150709] by
-
- 14 edits in trunk/Source/WebCore
Move Node::isFocusable() to Element.
<http://webkit.org/b/116777>
Reviewed by Anders Carlsson.
Nodes cannot be focusable, so move isFocusable() from Node to Element.
- dom/Node.cpp:
- dom/Node.h:
- dom/Element.h:
- dom/Element.cpp:
(WebCore::Element::isFocusable):
Moved here from Node.
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
Check that the underlying node is an Element before asking if it's focusable.
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
Renamed the 'anchorNode' variable to 'anchorElement' because reasons.
- html/HTMLAreaElement.h:
- html/HTMLFormControlElement.h:
- html/HTMLLabelElement.h:
- html/HTMLOptionElement.h:
- svg/SVGAElement.h:
Sprinkle OVERRIDE.
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::setMessage):
Update a comment to refer to Element::isFocusable() instead of Node.
- 9:42 PM Changeset in webkit [150708] by
-
- 2 edits in trunk/Websites/webkit.org
Broken link to committers list on contributing web page
https://bugs.webkit.org/show_bug.cgi?id=116722
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-25
Reviewed by Andreas Kling.
- coding/contributing.html:
Changed broken link to point to the team page instead.
- 9:33 PM Changeset in webkit [150707] by
-
- 9 edits in trunk/Source/WebCore
Move Node::tabIndex() to Element.
<http://webkit.org/b/116772>
Reviewed by Ryosuke Niwa.
Since only Elements are keyboard-focusable, it doesn't make sense for Node to have a tabIndex().
- dom/Element.h:
- dom/Node.cpp:
- dom/Node.h:
A Node can't have a tab index, so move tabIndex() to Element.
- page/FocusController.h:
- page/FocusController.cpp:
(WebCore::adjustedTabIndex):
(WebCore::FocusController::findElementWithExactTabIndex):
(WebCore::nextElementWithGreaterTabIndex):
(WebCore::previousElementWithLowerTabIndex):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):
Make this code deal in Element* when doing tab index stuff. FocusController needs
more Node->Element cleanup, but let's do that separately.
- html/HTMLAnchorElement.h:
- html/HTMLElement.h:
- html/HTMLFormControlElement.h:
Sprinkle OVERRIDE.
- 9:31 PM Changeset in webkit [150706] by
-
- 2 edits in trunk/Tools
Revert another erroneous change.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):
- 9:13 PM Changeset in webkit [150705] by
-
- 2 edits in trunk/Tools
Revert an erroneous change.
- Scripts/webkitpy/tool/commands/sheriffbot.py:
(SheriffBot):
- 8:39 PM Changeset in webkit [150704] by
-
- 4 edits in trunk/Tools
Some build fixes for WKR and webkitbot.
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help):
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(Agent):
(Agent.init):
(Agent.name):
(NewCommitBot):
(NewCommitBot.begin_work_queue):
(NewCommitBot.next_work_item):
- Scripts/webkitpy/tool/commands/sheriffbot.py:
(SheriffBot):
- 8:35 PM Changeset in webkit [150703] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support ArithDiv
https://bugs.webkit.org/show_bug.cgi?id=116771
Reviewed by Oliver Hunt.
- ftl/FTLAbbreviations.h:
(JSC::FTL::buildDiv):
(JSC::FTL::buildRem):
(JSC::FTL::buildFDiv):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLCommonValues.cpp:
(JSC::FTL::CommonValues::CommonValues):
- ftl/FTLCommonValues.h:
(CommonValues):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithDiv):
(LowerDFGToLLVM):
- ftl/FTLOutput.h:
(JSC::FTL::Output::div):
(JSC::FTL::Output::rem):
(JSC::FTL::Output::doubleDiv):
- 8:29 PM Changeset in webkit [150702] by
-
- 2 edits in trunk/Source/WebCore
Don't instantiate ChildNodeLists just to get a child count.
<http://webkit.org/b/116776>
Reviewed by Ryosuke Niwa.
Use ContainerNode::childNodeCount() instead of Node::childNodes()->length().
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
- 7:57 PM Changeset in webkit [150701] by
-
- 3 edits in trunk/Tools
Teach webkitbot and WKR how to respond to yt?
https://bugs.webkit.org/show_bug.cgi?id=116775
Reviewed by Andreas Kling.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Hi): Fixed the usage string.
(Hi.execute): Made it more generic so that it works in WKR.
(YouThere): Added.
(YouThere.execute): Added.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
- 7:48 PM Changeset in webkit [150700] by
-
- 7 edits in trunk/Source
PluginDocument::pluginNode() should be pluginElement() instead.
<http://webkit.org/b/116774>
Reviewed by Anders Carlsson.
Source/WebCore:
Make PluginDocument hand out a HTMLPlugInElement* instead of a Node*.
- dom/Document.cpp:
(WebCore::eventTargetNodeForDocument):
- html/PluginDocument.h:
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
(WebCore::PluginDocument::pluginWidget):
(WebCore::PluginDocument::setPluginElement):
(WebCore::PluginDocument::detach):
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::focusedPluginViewForFrame):
- 7:27 PM Changeset in webkit [150699] by
-
- 7 edits in trunk/Source
Remove Document::getFocusableNodes().
<http://webkit.org/b/116773>
Reviewed by Joseph Pecoraro.
Source/WebCore:
This was added in r42191 and there are no remaining clients of the API.
- dom/Document.cpp:
- dom/Document.h:
- WebCore.exp.in:
Source/WebKit/mac:
Remove the private _focusableNodes API on DOMDocument, it has no clients.
- DOM/WebDOMOperations.mm:
- DOM/WebDOMOperationsPrivate.h:
- 7:22 PM Changeset in webkit [150698] by
-
- 2 edits in trunk/Tools
Try to fix the EFL build.
- DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::setPageVisibility):
- 7:22 PM Changeset in webkit [150697] by
-
- 9 edits in trunk/Source/WebCore
Move Node::focusDelegate() to Element.
<http://webkit.org/b/116768>
Reviewed by Anders Carlsson.
Only Element can be a focus delegate (it's currently only ever HTMLInputElement actually)
so move Node::focusDelegate() to Element. Sprinkled isElementNode() checks as needed.
- dom/Node.cpp:
- dom/Node.h:
- dom/Element.h:
- dom/Element.cpp:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::focusDelegate):
- html/shadow/SliderThumbElement.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isFocused):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSliderThumb):
- 5:51 PM Changeset in webkit [150696] by
-
- 2 edits in trunk/Source/WebCore
Path: clean up addPathForRoundedRect()
https://bugs.webkit.org/show_bug.cgi?id=116765
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-25
Reviewed by Andreas Kling.
Reorganize code that is a bit redundant.
No new tests, no behavior change.
- platform/graphics/Path.cpp:
(WebCore::Path::addPathForRoundedRect):
- 4:56 PM Changeset in webkit [150695] by
-
- 35 edits in trunk
Unprefix Page Visibility API
https://bugs.webkit.org/show_bug.cgi?id=102340
Source/WebCore:
Reviewed by Tim Horton.
Remove prefixes from the document properties, and the visibilitychanged event.
Rename the "preview" state to "unloaded". The "unloaded" state is never
reached yet (see https://bugs.webkit.org/show_bug.cgi?id=116769).
Add some comments to places where we should update the visibility state
when going in and out of the page cache, but cannot safely do so yet.
Tested by existing Page Visibility tests.
- dom/Document.cpp:
(WebCore::Document::pageVisibilityState):
(WebCore::Document::visibilityState):
(WebCore::Document::hidden):
(WebCore::Document::dispatchVisibilityStateChangeEvent):
- dom/Document.h:
- dom/Document.idl:
- dom/EventNames.h:
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
- page/Page.cpp:
(WebCore::Page::setVisibilityState):
- page/PageVisibilityState.cpp:
(WebCore::pageVisibilityStateString):
- page/PageVisibilityState.h:
Source/WebKit/efl:
Reviewed by Tim Horton.
Rename "preview" state to "unloaded" state.
- WebCoreSupport/AssertMatchingEnums.cpp:
- ewk/ewk_view.h:
Source/WebKit/mac:
Reviewed by Tim Horton.
Renaming of the "preview" state to "unloaded".
- WebView/WebView.mm:
- WebView/WebViewPrivate.h:
Source/WebKit2:
Reviewed by Tim Horton.
Renaming of the "preview" state to "unloaded".
- Shared/API/c/WKPageVisibilityTypes.h:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toPageVisibilityState):
Tools:
Reviewed by Tim Horton.
Rename "preview" state to "unloaded" state, and adjust the tests
to test for it.
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setPageVisibility):
- TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
(TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
(TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
(TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
(TestWebKitAPI::didRunStep4InStateUnloaded):
- TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
- TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setPageVisibility):
LayoutTests:
Reviewed by Tim Horton.
Remove prefixes, adjust to state name changes.
- fast/events/page-visibility-iframe-delete-test.html:
- fast/events/page-visibility-iframe-move-test-expected.txt:
- fast/events/page-visibility-iframe-move-test.html:
- fast/events/page-visibility-iframe-propagation-test-expected.txt:
- fast/events/page-visibility-iframe-propagation-test.html:
- fast/events/page-visibility-null-view-expected.txt:
- fast/events/page-visibility-null-view.html:
- fast/events/page-visibility-transition-test-expected.txt:
- fast/events/page-visibility-transition-test.html:
- 4:31 PM Changeset in webkit [150694] by
-
- 4 edits9 adds in trunk
We broke (-231/-1)|0 in the DFG
https://bugs.webkit.org/show_bug.cgi?id=116767
Source/JavaScriptCore:
Reviewed by Andreas Kling.
The bug is that we were assuming that in the -231 case, we already had -231
in the result register. This was a wrong assumption.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForX86):
LayoutTests:
Reviewed by Andreas Kling.
- fast/js/dfg-div-by-neg1-and-then-or-zero-interesting-reg-alloc-expected.txt: Added.
- fast/js/dfg-div-by-neg1-and-then-or-zero-interesting-reg-alloc.html: Added.
- fast/js/dfg-div-by-zero-and-then-or-zero-interesting-reg-alloc-expected.txt: Added.
- fast/js/dfg-div-by-zero-and-then-or-zero-interesting-reg-alloc.html: Added.
- fast/js/dfg-div-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc-expected.txt: Added.
- fast/js/dfg-div-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-div-by-neg1-and-then-or-zero-interesting-reg-alloc.js: Added.
(foo):
- fast/js/script-tests/dfg-div-by-zero-and-then-or-zero-interesting-reg-alloc.js: Added.
(foo):
- fast/js/script-tests/dfg-div-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc.js: Added.
(foo):
- 4:13 PM Changeset in webkit [150693] by
-
- 2 edits in trunk/LayoutTests
Updated expected results after r150688.
Reviewed by Andreas Kling.
- http/tests/globalhistory/history-delegate-basic-refresh-redirect-expected.txt: Now shows
the URL that performed the client redirect, as expected.
- 4:09 PM Changeset in webkit [150692] by
-
- 21 edits in trunk/Source
Move Node::isMouseFocusable() to Element.
<http://webkit.org/b/116762>
Reviewed by Anders Carlsson.
Source/WebCore:
Node::isMouseFocusable() would just return isFocusable(), which is never true for a non-Element
since Node::supportsFocus() always returns false. So move it to Element!
- dom/Node.h:
- dom/Node.cpp:
- dom/Element.h:
- dom/Element.cpp:
(WebCore::Element::isMouseFocusable):
Moved here from Node.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setFocusedNodeIfNeeded):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
Walk up the parent chain with parentOrShadowHostElement() instead of parentOrShadowHostNode().
Removed a misleading no-op hunk about mouse-focusable ShadowRoots, since ShadowRoots are not
Elements and thus cannot be mouse-focusable.
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):
Check that the Node is an Element before asking if it's mouse-focusable.
- html/HTMLAnchorElement.h:
- html/HTMLAreaElement.h:
- html/HTMLFormControlElement.h:
- html/HTMLInputElement.h:
- html/HTMLMediaElement.h:
- html/HTMLSelectElement.h:
- html/HTMLTextAreaElement.h:
- html/shadow/ClearButtonElement.h:
- html/shadow/TextControlInnerElements.h:
- svg/SVGAElement.h:
- svg/SVGStyledElement.h:
Sprinkle OVERRIDE.
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::highlightPotentialActivation):
Check that the potentially activated Node is an Element before asking if it's mouse-focusable.
- 2:34 PM Changeset in webkit [150691] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION: WebProcess is terminated when all Safari windows are closed.
<rdar://problem/13990901>
<http://webkit.org/b/116766>
Reviewed by Alexey Proskuryakov.
When closing the last page, only disconnect the web process if we're using a network process.
Otherwise there might be session state in the web process getting lost.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::removeWebPage):
- 1:17 PM Changeset in webkit [150690] by
-
- 10 edits in branches/dfgFourthTier/Source
Remove Interpreter::retrieveLastCaller().
https://bugs.webkit.org/show_bug.cgi?id=116753.
Reviewed by Geoffrey Garen.
This is part of the refactoring effort to get rid of functions walking
the JS stack in their own way.
- API/JSContextRef.cpp:
(JSContextCreateBacktrace):
- interpreter/CallFrame.cpp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
- interpreter/Interpreter.h:
(StackFrame):
(JSC::StackFrame::StackFrame):
(Interpreter):
- jsc.cpp:
(functionJSCStack):
- profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::addParentForConsoleStart):
../WebCore:
No new tests.
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
- 11:35 AM Changeset in webkit [150689] by
-
- 2 edits in trunk/Source/WebKit2
WebFrameProxy::didFailLoad clears frame title for no apparent reason
https://bugs.webkit.org/show_bug.cgi?id=116655
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-05-25
Reviewed by Alexey Proskuryakov.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didFailLoad):
- 10:57 AM Changeset in webkit [150688] by
-
- 3 edits in trunk/Source/WebKit/mac
<rdar://problem/13924889> -webView:didPerformClientRedirectFromURL:toURL:inFrame: should be given the redirecting URL as the “from” URL
https://bugs.webkit.org/show_bug.cgi?id=116733
Reviewed by Adele Peterson.
By the time the history controller calls updateGlobalHistoryRedirectLinks(), the document
loader already reflects the destination URL. In order to be able to provide the immediate
source URL to the delegate, we make WebFrame track a URL and provisional URL, updating them
in response to FrameLoader callbacks in exactly the same way WebFrameProxy maintains its
m_url and m_provisionalURL member variables.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): Update
provisionalURL.
(WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): Update url.
(WebFrameLoaderClient::dispatchDidPushStateWithinPage): Ditto.
(WebFrameLoaderClient::dispatchDidReplaceStateWithinPage): Ditto.
(WebFrameLoaderClient::dispatchDidPopStateWithinPage): Ditto.
(WebFrameLoaderClient::dispatchDidStartProvisionalLoad): Update provisionalURL.
(WebFrameLoaderClient::dispatchDidCommitLoad): Update URL and provisionalURL.
(WebFrameLoaderClient::dispatchDidFailProvisionalLoad): Clear provisionalURL.
(WebFrameLoaderClient::dispatchDidFailLoad): Added an assertion.
(WebFrameLoaderClient::dispatchDidFinishLoad): Ditto.
(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Pass the last committed URL as the
source, rather than clientRedirectSourceForHistory().
- WebView/WebFrameInternal.h: Added url and provisionalURL ivars to WebFramePrivate.
- 5:02 AM Changeset in webkit [150687] by
-
- 16 edits in trunk/Source/WebCore
Move Node::isKeyboardFocusable() to Element.
<http://webkit.org/b/116761>
Reviewed by Antti Koivisto.
Only Elements can be keyboard-focusable. Move the base isKeyboardFocusable() implementation to Element
and sprinkle OVERRIDE on subclass overrides.
FocusController gets some temporary type checks that will go away as that code moves to dealing in
Elements instead of Node.
- dom/Node.h:
- dom/Node.cpp:
- dom/Element.h:
- dom/Element.cpp:
(WebCore::Element::isKeyboardFocusable):
Move isKeyboardFocusable() from Node to Element.
- page/FocusController.cpp:
(WebCore::isNonFocusableShadowHost):
(WebCore::isFocusableShadowHost):
(WebCore::shouldVisit):
(WebCore::FocusController::advanceFocusInDocumentOrder):
Check that the inspected Node is an Element before querying isKeyboardFocusable().
- html/HTMLAnchorElement.h:
- html/HTMLAreaElement.h:
- html/HTMLFormControlElement.h:
- html/HTMLFrameOwnerElement.h:
- html/HTMLInputElement.h:
- html/HTMLPlugInElement.h:
- html/HTMLSelectElement.h:
- html/HTMLTextAreaElement.h:
- svg/SVGAElement.h:
- svg/SVGStyledElement.h:
Sprinkle OVERRIDE.
- 3:27 AM Changeset in webkit [150686] by
-
- 10 edits in trunk/Source/WebCore
Begin moving "focus" state logic from Node to Element.
<http://webkit.org/b/116760>
Reviewed by Antti Koivisto.
Only Elements can be focused, so merge the "focus" state logic from Node and ContainerNode
and move it into Element. There's a lot more iceberg under this tip, but we'll be starting
with setFocus(bool) and focused().
- dom/Node.h:
- dom/ContainerNode.cpp:
- dom/ContainerNode.h:
- dom/Element.cpp:
(WebCore::Element::isUserActionElementFocused):
(WebCore::Element::setFocus):
- dom/Element.h:
(WebCore::Element::focused):
- dom/Node.cpp:
Move focused() and setFocus(bool) from Node/ContainerNode to Element.
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
Check if the inspected Node is an Element before asking if it's focused.
- 2:51 AM Changeset in webkit [150685] by
-
- 3 edits2 adds in trunk
Direct pattern compositing breaks when no-repeat is set on a large layer
https://bugs.webkit.org/show_bug.cgi?id=116140
Source/WebCore:
Reviewed by Antti Koivisto.
In some cases the directly composited background color logic overrides the layer's
contentsRect, which results in wrong rendering of tiled images.
This patch makes sure that the background image is applied after the solid color,
which ensures the correct contentsRect.
Test: compositing/patterns/direct-pattern-compositing-contain-no-repeat.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents):
LayoutTests:
Added a ref-test to make sure that direct pattern compositing works well with no-repeat
in a particular geometry.
Reviewed by Antti Koivisto.
- compositing/patterns/direct-pattern-compositing-contain-no-repeat-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-contain-no-repeat.html: Added.
- 2:16 AM Changeset in webkit [150684] by
-
- 14 edits in trunk/Source/WebCore
Move "hover" state logic from Node to Element.
<http://webkit.org/b/116757>
Reviewed by Antti Koivisto.
Resolve a 7 year old FIXME by merging the "hover" state logic from Node and ContainerNode
and moving it all to Element instead.
- dom/Node.cpp:
(WebCore::Node::detach):
- dom/Element.cpp:
(WebCore::Element::detach):
Move Document::hoveredNodeDetached() call from Node::detach() to Element::detach().
(WebCore::Element::isUserActionElementHovered):
(WebCore::Element::setHovered):
- dom/Element.h:
(WebCore::Element::hovered):
Moved here from Node/ContainerNode.
- dom/UserActionElementSet.h:
(WebCore::UserActionElementSet::setHovered):
(WebCore::UserActionElementSet::setFlags):
Make setHovered() take an Element* instead of a Node*. I'd like to do this will all
of these methods eventually, so added a setFlags() helper with the tighter type.
- html/HTMLLabelElement.h:
- html/shadow/SpinButtonElement.h:
Sprinkle OVERRIDE on setHovered() overrides.
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isHovered):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isHovered):
Check if the inspected Node is an element before asking if it's hovered.
- 2:08 AM Changeset in webkit [150683] by
-
- 6 edits in trunk/Source/WebCore
Document::formController() should return a reference.
<http://webkit.org/b/116758>
Reviewed by Antti Koivisto.
The formController() is created on demand, so return a reference instead.
- dom/Document.h:
- dom/Document.cpp:
(WebCore::Document::formController):
(WebCore::Document::setStateForNewFormElements):
- html/HTMLFormControlElementWithState.cpp:
(WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::didMoveToNewDocument):
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::~HTMLFormElement):
(WebCore::HTMLFormElement::finishParsingChildren):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement):
(WebCore::HTMLInputElement::didMoveToNewDocument):
(WebCore::HTMLInputElement::checkedRadioButtons):
- 1:29 AM Changeset in webkit [150682] by
-
- 2 edits in trunk/Source/WebCore
Reducing CSS code duplication in declaration list error recovery
https://bugs.webkit.org/show_bug.cgi?id=115157
Reviewed by Andreas Kling.
From Blink r148974 by <serya@chromium.org>
Refactor "invalid_block_list error | /* empty */" in a new
decl_list_recovery rule that allows to remove 4 redundant rules.
No new test required as we're just refactoring code, no new behaviour.
- css/CSSGrammar.y.in:
May 24, 2013:
- 9:20 PM Changeset in webkit [150681] by
-
- 4 edits in trunk/Source/WebKit2
[Qt][GTK] Build fix after r150669
https://bugs.webkit.org/show_bug.cgi?id=116751
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-24
Reviewed by Christophe Dumez.
- GNUmakefile.list.am:
- Target.pri:
- WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(WebKit::WebEditorClient::getEditorCommandsForKeyEvent):
- 9:01 PM Changeset in webkit [150680] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Remove obsolete Page forward declaration from InspectorClientEfl.h
https://bugs.webkit.org/show_bug.cgi?id=116752
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-24
Reviewed by Christophe Dumez.
- WebCoreSupport/InspectorClientEfl.h:
- 7:44 PM CommitterTips edited by
- It is generated automatically from contributors.json after r150662. (diff)
- 7:19 PM Changeset in webkit [150679] by
-
- 6 edits in trunk/Source/WebKit2
[EFL] Build fix after r150669
https://bugs.webkit.org/show_bug.cgi?id=116750
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-24
Reviewed by Anders Carlsson.
- CMakeLists.txt:
- WebProcess/Battery/WebBatteryManager.cpp:
(WebKit::WebBatteryManager::registerWebPage):
(WebKit::WebBatteryManager::unregisterWebPage):
- WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:
(WebKit::WebNetworkInfoManager::registerWebPage):
(WebKit::WebNetworkInfoManager::unregisterWebPage):
(WebKit::WebNetworkInfoManager::bandwidth):
(WebKit::WebNetworkInfoManager::metered):
- WebProcess/WebCoreSupport/WebVibrationClient.cpp:
(WebKit::WebVibrationClient::vibrate):
(WebKit::WebVibrationClient::cancelVibration):
- WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestManager::didReceiveURIRequestData):
(WebKit::WebSoupRequestManager::send):
- 6:28 PM Changeset in webkit [150678] by
-
- 2 edits in trunk/LayoutTests
Unreviewed change to get Windows bots green. Disable a number
of crashes and failures. Crashes are tracked under
https://bugs.webkit.org/show_bug.cgi?id=116562, failures under
https://bugs.webkit.org/show_bug.cgi?id=116564.
- platform/win/TestExpectations:
- 6:18 PM Changeset in webkit [150677] by
-
- 2 edits in trunk/Tools
Unreviewed build fix. Don't use new NRWT logic needed
by Windows yet. Activate (and fix test) when we cut over.
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver):
(Driver._start):
- 6:12 PM Changeset in webkit [150676] by
-
- 2 edits in trunk/Source/WTF
Inline TCMalloc_Central_FreeList's RemoveRange and FetchFromSpansSafe
https://bugs.webkit.org/show_bug.cgi?id=116700
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-24
Reviewed by Darin Adler.
The two functions only have one call site each.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_Central_FreeList::RemoveRange):
(WTF::TCMalloc_Central_FreeList::FetchFromSpansSafe):
- 6:02 PM Changeset in webkit [150675] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r150664.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
- 5:59 PM Changeset in webkit [150674] by
-
- 4 edits in branches/safari-537.43-branch/Source
Versioning.
- 5:56 PM Changeset in webkit [150673] by
-
- 1 copy in tags/Safari-537.43.2
New Tag.
- 5:49 PM Changeset in webkit [150672] by
-
- 3 edits2 adds in trunk
Fixing invalid block recovery in some declaration list.
https://bugs.webkit.org/show_bug.cgi?id=115159
Patch by Sergio Villar Senin <svillar@igalia.com> on 2013-05-24
Reviewed by Darin Adler.
From Blink r148889 by <serya@chromium.org>
Source/WebCore:
Improves the detection of some invalid block declarations inside a
declaration list. This allows the parser not to completely discard
a whole declaration list that contains an invalid block. In
particular grammar failed in tests 8, 12, 13, 15, 16 and 17 in the
new test added by this change.
Test: fast/css/parsing-invalid-block-recovery.html
- css/CSSGrammar.y.in:
LayoutTests:
- fast/css/parsing-invalid-block-recovery-expected.txt: Added.
- fast/css/parsing-invalid-block-recovery.html: Added.
- 5:48 PM Changeset in webkit [150671] by
-
- 2 edits in trunk/Source/WebCore
DidFirstFlushForHeaderLayer can be called too soon on pages that redirect
https://bugs.webkit.org/show_bug.cgi?id=116749
-and corresponding-
<rdar://problem/13886753>
Reviewed by Simon Fraser.
Only start m_paintRelatedMilestonesTimer if we have actually painted.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
- 5:19 PM Changeset in webkit [150670] by
-
- 11 edits in trunk
[Windows] Expose database storage and cache locations via preferences.
https://bugs.webkit.org/show_bug.cgi?id=116729
Reviewed by Tim Horton.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Export
three symbols needed to implement the feature.
Source/WebKit/win:
- WebDatabaseManager.cpp: Update to check preferences for the
desired location of the database store.
(databasesDirectory): Added.
(WebKitInitializeWebDatabasesIfNecessary): Use new databasesDirectory
method to determine what system path to use for file storage.
- WebKit.vcproj/WebKitExports.def.in: Export three symbols
needed to implement the feature.
- WebView.cpp: Update to check preferences for the desired location
of the various caches used by WebKit.
(WebView::setCacheModel): Update to check preferences for URL cache
storage.
(WebKitSetApplicationCachePathIfNecessary): Update to check
preferences for ccache storage.
Tools:
Update DumpRenderTree to use CFPreferences to control where WebKit
stores its local databases, URL caches, etc.
- DumpRenderTree/win/DumpRenderTree.cpp:
(libraryPathForDumpRenderTree): Added.
(dllLauncherEntryPoint): Set up DRT-specific cache locations.
- Scripts/webkitpy/port/base.py:
(Port._driver_tempdir): Added (to allow port-specific overload).
(Port._driver_tempdir_for_environment): Ditto
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver): Use new overload to set
environment variable.
(Driver._start): Use new overload for temp directory location.
- Scripts/webkitpy/port/win.py:
(WinPort._driver_tempdir_for_environment): New overload to supply
Windows path to DumpRenderTree environment (while still using
cygwin paths for internal operations.
- 5:17 PM Changeset in webkit [150669] by
-
- 40 edits1 copy in trunk/Source/WebKit2
MessageSender shouldn't be a class template
https://bugs.webkit.org/show_bug.cgi?id=116743
Reviewed by Andreas Kling.
Change MessageSender to be a proper abstract base class. Subclasses of MessageSender must
implement messageSenderConnection() as well as messageSenderDestinationID().
This reduces code size and will allow us to be more flexible with MessageSender in the future.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
(WebKit::NetworkResourceLoader::messageSenderConnection):
(WebKit):
(WebKit::NetworkResourceLoader::messageSenderDestinationID):
- NetworkProcess/NetworkResourceLoader.h:
(NetworkResourceLoader):
- NetworkProcess/mac/DiskCacheMonitor.h:
(DiskCacheMonitor):
- NetworkProcess/mac/DiskCacheMonitor.mm:
(WebKit::DiskCacheMonitor::messageSenderConnection):
(WebKit::DiskCacheMonitor::messageSenderDestinationID):
(WebKit):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC):
(MessageSender):
(CoreIPC::MessageSender::send):
(CoreIPC::MessageSender::sendSync):
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::messageSenderConnection):
(WebKit):
(WebKit::ChildProcess::messageSenderDestinationID):
- Shared/ChildProcess.h:
(ChildProcess):
- Shared/Downloads/Download.cpp:
(WebKit::Download::messageSenderConnection):
(WebKit):
(WebKit::Download::messageSenderDestinationID):
- Shared/Downloads/Download.h:
(Download):
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::initialize):
- Shared/WebConnection.h:
(WebConnection):
- Shared/mac/SecItemShim.cpp:
(WebKit::sendSecItemRequest):
- UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::hasValidConnection):
(WebKit::WebConnectionToWebProcess::messageSenderConnection):
(WebKit::WebConnectionToWebProcess::messageSenderDestinationID):
- UIProcess/WebConnectionToWebProcess.h:
(WebConnectionToWebProcess):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
- WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::retainIconForPageURL):
(WebKit::WebIconDatabaseProxy::releaseIconForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
(WebKit::WebIconDatabaseProxy::loadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::setIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::messageSenderConnection):
(WebKit::WebResourceLoader::messageSenderDestinationID):
- WebProcess/Network/WebResourceLoader.h:
(WebResourceLoader):
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::writeItemsToPasteboard):
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::~StorageAreaMap):
(WebKit::StorageAreaMap::setItem):
(WebKit::StorageAreaMap::removeItem):
(WebKit::StorageAreaMap::clear):
(WebKit::StorageAreaMap::loadValuesIfNeeded):
- WebProcess/WebConnectionToUIProcess.cpp:
(WebKit::WebConnectionToUIProcess::hasValidConnection):
(WebKit::WebConnectionToUIProcess::messageSenderConnection):
(WebKit::WebConnectionToUIProcess::messageSenderDestinationID):
- WebProcess/WebConnectionToUIProcess.h:
(WebConnectionToUIProcess):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowRect):
(WebKit::WebChromeClient::focusedFrameChanged):
(WebKit::WebChromeClient::createWindow):
(WebKit::WebChromeClient::toolbarsVisible):
(WebKit::WebChromeClient::statusbarVisible):
(WebKit::WebChromeClient::menubarVisible):
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::shouldInterruptJavaScript):
(WebKit::WebChromeClient::exceededDatabaseQuota):
- WebProcess/WebCoreSupport/WebColorChooser.cpp:
(WebKit::WebColorChooser::WebColorChooser):
(WebKit::WebColorChooser::setSelectedColor):
(WebKit::WebColorChooser::endChooser):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveIcon):
(WebKit::WebFrameLoaderClient::updateGlobalHistory):
(WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebKit::WebFrameLoaderClient::setTitle):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::populatePluginCache):
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::copy):
(WebKit::WebPlatformStrategies::changeCount):
(WebKit::WebPlatformStrategies::uniqueName):
(WebKit::WebPlatformStrategies::color):
(WebKit::WebPlatformStrategies::url):
(WebKit::WebPlatformStrategies::addTypes):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setPathnamesForType):
(WebKit::WebPlatformStrategies::setStringForType):
- WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::show):
(WebKit::WebPopupMenu::hide):
- WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::sendDidReceiveEvent):
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::updateBackForwardItem):
(WebKit::WebBackForwardListProxy::itemAtIndex):
(WebKit::WebBackForwardListProxy::backListCount):
(WebKit::WebBackForwardListProxy::forwardListCount):
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::didClose):
(WebKit::WebInspector::bringToFront):
(WebKit::WebInspector::inspectedURLChanged):
(WebKit::WebInspector::save):
(WebKit::WebInspector::append):
(WebKit::WebInspector::attachBottom):
(WebKit::WebInspector::attachRight):
(WebKit::WebInspector::detach):
(WebKit::WebInspector::setAttachedWindowHeight):
(WebKit::WebInspector::setAttachedWindowWidth):
(WebKit::WebInspector::setToolbarHeight):
(WebKit::WebInspector::updateDockingAvailability):
(WebKit::WebInspector::sendMessageToRemoteFrontend):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::messageSenderConnection):
(WebKit):
(WebKit::WebPage::messageSenderDestinationID):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::executeKeypressCommandsInternal):
(WebKit::WebPage::handleEditingKeyboardEvent):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureNetworkProcessConnection):
(WebKit::WebProcess::shouldTerminate):
- 4:52 PM Changeset in webkit [150668] by
-
- 15 edits in trunk/Source/WebKit/mac
Remove using namespace std from Mac WebKit1
https://bugs.webkit.org/show_bug.cgi?id=116747
Reviewed by Sam Weinig.
Use explicit std:: qualifiers instead.
- History/BinaryPropertyList.cpp:
(IntegerArray::deletedValueSize):
(BinaryPropertyListPlan::invalidObjectReference):
(bytesNeeded):
- History/WebHistory.mm:
(-[WebHistoryPrivate orderedLastVisitedDays]):
(WebHistoryWriter::WebHistoryWriter):
- History/WebHistoryItem.mm:
(-[WebHistoryItem initFromDictionaryRepresentation:]):
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
- Plugins/Hosted/NetscapePluginHostProxy.mm:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::wheelEvent):
(WebKit::NetscapePluginInstanceProxy::print):
(WebKit::NetscapePluginInstanceProxy::snapshot):
(WebKit::NetscapePluginInstanceProxy::loadURL):
(WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::invoke):
(WebKit::ProxyInstance::supportsInvokeDefaultMethod):
(WebKit::ProxyInstance::supportsConstruct):
(WebKit::ProxyInstance::getPropertyNames):
(WebKit::ProxyInstance::methodNamed):
(WebKit::ProxyInstance::fieldNamed):
(WebKit::ProxyInstance::fieldValue):
(WebKit::ProxyInstance::setFieldValue):
- Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage supportsExtension:]):
(-[WebBasePluginPackage MIMETypeForExtension:]):
- Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::deliverData):
- Plugins/WebNetscapePluginView.mm:
(PluginTimer::start):
(-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebFrame.mm:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
- WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _placePopupWindow:]):
- 4:46 PM Changeset in webkit [150667] by
-
- 4 edits in trunk/Source/WebCore
Fix Windows build.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 4:37 PM Changeset in webkit [150666] by
-
- 6 edits in trunk/Source
Animated GIFs don't repaint after TiledCoreAnimationDrawingArea un-suspends painting
https://bugs.webkit.org/show_bug.cgi?id=116744
<rdar://problem/13973514>
Reviewed by Simon Fraser.
- WebCore.exp.in: Export FrameView::resumeAnimatingImages.
- page/FrameView.cpp:
(WebCore::FrameView::setIsInWindow):
(WebCore::FrameView::resumeAnimatingImages):
Factor the code to restart animated images out of frameView::setIsInWindow.
- page/FrameView.h:
(FrameView):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::resumePainting):
Force WebCore to repaint animated images when painting is resumed.
- 4:30 PM Changeset in webkit [150665] by
-
- 7 edits4 moves in trunk/Source
Move history property list writer to WebKit
https://bugs.webkit.org/show_bug.cgi?id=116746
Reviewed by Tim Horton.
Source/WebCore:
Remove files from the Xcode project and remove symbols that now live in WebKit.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
Add files to the Xcode project.
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Move WebCore history files to WebKit since they're only used by WebKit now.
- History/BinaryPropertyList.cpp: Renamed from Source/WebCore/platform/cf/BinaryPropertyList.cpp.
- History/BinaryPropertyList.h: Renamed from Source/WebCore/platform/cf/BinaryPropertyList.h.
- History/HistoryPropertyList.cpp: Renamed from Source/WebCore/history/cf/HistoryPropertyList.cpp.
- History/HistoryPropertyList.h: Renamed from Source/WebCore/history/cf/HistoryPropertyList.h.
- History/WebHistory.mm:
- 4:15 PM Changeset in webkit [150664] by
-
- 10 edits3 adds in trunk
Global constructors exposed in worker environment have wrong attributes
https://bugs.webkit.org/show_bug.cgi?id=116708
Reviewed by Geoffrey Garen.
Source/WebCore:
Fix JSC bindings generator so that Global constructors exposed in worker environment
have the following attributes:
{ Writable: true, Enumerable: false, Configurable: true }
This is now consistent with global constructors on DOMWindow and with the Web IDL
specification:
http://dev.w3.org/2006/webapi/WebIDL/#es-interfaces
Test: fast/js/global-constructors-attributes-worker.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributesHashTable):
LayoutTests:
Add fast/js/global-constructors-attributes-worker.html test case to check the
global constructors attributers in the worker environment.
- fast/js/global-constructors-attributes-expected.txt:
- fast/js/global-constructors-attributes-worker-expected.txt: Added.
- fast/js/global-constructors-attributes-worker.html: Added.
- fast/js/global-constructors-attributes.html:
- fast/js/script-tests/global-constructors-attributes.js: Make sure script usable
in a Worker and stop reporting the "constructor" property as a global constructor.
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-worker-expected.txt: Added.
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/qt/fast/js/global-constructors-attributes-expected.txt:
- 3:57 PM Changeset in webkit [150663] by
-
- 34 edits1 delete in trunk
Remove custom code for webkitAudioContext global constructor getter
https://bugs.webkit.org/show_bug.cgi?id=116530
Reviewed by Geoffrey Garen.
Source/WebCore:
Get rid of custom code for webkitAudioContext global constructor getter. The
global DOMWindow attribute is now automatically generated by leveraging support
for [EnabledAtRuntime] extended attribute and the existing methods in
RuntimeEnabledFeatures class.
No new tests, no behavior change.
- GNUmakefile.list.am: Remove JSDOMWindowWebAudioCustom.*.
- Modules/webaudio/AudioContext.idl:
Remove [NoInterfaceObject] extended attribute so that the global constructor is
automatically generated instead of automatically added. Add [EnabledAtRuntime]
extended attribute since this global constructor can be disabled at runtime and
so that we can getter rid of the [CustomGetter] for the corresponding global
constructor. Use [InterfaceName] extended attribute so that the interface name
matches the global constructor on DOMWindow (webkitAudioContext).
- Target.pri: Remove JSDOMWindowWebAudioCustom.*.
- UseJSC.cmake: Remove JSDOMWindowWebAudioCustom.*.
- WebCore.exp.in: Export additional symbol.
- WebCore.order: Export additional symbol.
- WebCore.vcproj/WebCore.vcproj: Remove JSDOMWindowWebAudioCustom.*.
- WebCore.vcxproj/WebCore.vcxproj: Remove JSDOMWindowWebAudioCustom.*.
- WebCore.vcxproj/WebCore.vcxproj.filters: Remove JSDOMWindowWebAudioCustom.*.
- WebCore.xcodeproj/project.pbxproj: Remove JSDOMWindowWebAudioCustom.*.
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebAudioEnabled):
- bindings/js/JSBindingsAllInOne.cpp: Remove JSDOMWindowWebAudioCustom.*.
- bindings/js/JSDOMWindowWebAudioCustom.cpp: Removed. We no longer need any custom code for
the WebAudio global constructor getter because we use [EnabledAtRuntime] support in the
bindings generator now.
- page/DOMWindow.idl: Remove global constructor for AudioContext as it is now automatically
generated.
- page/Settings.in: Remove webAudioEnabled setting as we use the existing setting
in RuntimeEnabledFeatures now.
Source/WebKit/efl:
Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setWebAudioEnabled):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
- ewk/ewk_view.h: Remove public API to toggle Web Audio support as it is no longer
a view specific feature.
Source/WebKit/gtk:
Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
Source/WebKit/mac:
Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/qt:
Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
Source/WebKit/win:
Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Source/WebKit2:
Use RuntimeEnabledFeatures instead of WebCore Settings to toggle Web Audio support.
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
WebAudio feature instead of public ewk_view API since that API was
removed.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::overridePreference):
- 3:49 PM WebKit Team edited by
- Update to point to new location. (diff)
- 3:34 PM Changeset in webkit [150662] by
-
- 4 edits in trunk
Make team.html have each contributor's area of expertise
https://bugs.webkit.org/show_bug.cgi?id=116737
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-24
Reviewed by Benjamin Poulain.
Tools:
- Scripts/webkitpy/common/config/contributors.json:
Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
Changed formatting of the file because the lines are getting way to
long, and I generated this, so it's easier if the formatting of the
file is regular.
Websites/webkit.org:
- team.html:
Update to use the new expertise field in contributors.json.
- 3:27 PM Changeset in webkit [150661] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL boolify should support ObjectOrOtherUse
https://bugs.webkit.org/show_bug.cgi?id=116741
Reviewed by Geoffrey Garen.
Just reusing what was already there in equalNullOrUndefined(). Note that we will
sometimes generate some redundant IR - like having some spurious bitNot's in
places - but it's safe to assume that LLVM will simplify those, and that it won't
be the longest pole in the tent for compile times.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEqConstant):
(JSC::FTL::LowerDFGToLLVM::boolify):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
- 3:05 PM Changeset in webkit [150660] by
-
- 5 edits in trunk/Source/WebKit/win
Remove unused code to read/write history
https://bugs.webkit.org/show_bug.cgi?id=116738
Reviewed by Brent Fulgham.
- Interfaces/IWebHistory.idl:
Replace loadFromURL and saveToURL with unused1/unused2.
- Interfaces/IWebHistoryPrivate.idl:
Replace data with unused1.
- WebHistory.cpp:
Remove history loading/saving code.
(WebHistory::unused1):
(WebHistory::unused2):
Add implementations.
- WebHistory.h:
(WebHistory):
- 3:00 PM Changeset in webkit [150659] by
-
- 7 edits3 adds in trunk
We broke !(0/0)
https://bugs.webkit.org/show_bug.cgi?id=116736
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createLogicalNot):
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::pureToBoolean):
Source/WTF:
- wtf/MathExtras.h:
(isNotZeroAndOrdered):
(isZeroOrUnordered):
LayoutTests:
- fast/js/constant-fold-not-nan.html: Added.
- fast/js/constant-fold-not-nan-expected.txt: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/constant-fold-not-nan.js: Added.
- 2:45 PM Changeset in webkit [150658] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support LogicalNot and Branch on Int32 and Number
https://bugs.webkit.org/show_bug.cgi?id=116739
Reviewed by Gavin Barraclough.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):
(JSC::FTL::LowerDFGToLLVM::compileBranch):
(JSC::FTL::LowerDFGToLLVM::boolify):
(LowerDFGToLLVM):
- ftl/FTLOutput.h:
(JSC::FTL::Output::isZero32):
(JSC::FTL::Output::notZero32):
- 2:06 PM Changeset in webkit [150657] by
-
- 11 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: add heuristics to reduce the likelihood of a trivially inlineable function being independently compiled by the concurrent JIT
https://bugs.webkit.org/show_bug.cgi?id=116557
Reviewed by Geoffrey Garen.
This introduces a fairly comprehensive mechanism for preventing trivially inlineable
functions from being compiled independently of all of the things into which they end
up being inlined.
The trick is CodeBlock::m_shouldAlwaysBeInlined, or SABI for short (that's what the
debug logging calls it). A SABI function is one that we currently believe should
never be DFG optimized because it should always be inlined into the functions that
call it. SABI follows "innocent until proven guilty": all functions start out SABI
and have SABI set to false if we see proof that that function may be called in some
possibly non-inlineable way. So long as a function is SABI, it will not tier up to
the DFG: cti_optimize will perpetually postpone its optimization. Because SABI has
such a severe effect, we make the burden of proof of guilt quite low. SABI gets
cleared if any of the following happen:
- You get called from native code (either through CallData or CachedCall).
- You get called from an eval, since eval code takes a long time to get DFG optimized.
- You get called from global code, since often global code doesn't tier-up since it's run-once.
- You get called recursively, where recursion is detected by a stack walk of depth Options::maximumInliningDepth().
- You get called through an unlinked virtual call.
- You get called from DFG code, since if the caller was already DFG optimized and didn't inline you then obviously, you might not get inlined.
- You've tiered up to the baseline JIT and you get called from the interpreter. The idea here is that this kind of ensures that you stay SABI only if you're called no more frequently than any of your callers.
- You get called from a code block that isn't a DFG candidate.
- You aren't an inlining candidate.
Most of the heuristics for SABI are in CodeBlock::noticeIncomingCall().
This is neutral on SunSpider and V8Spider, and appears to be a slight speed-up on
V8v7, which was previously adversely affected by concurrent compilation. I also
confirmed that for example on V8/richards, it dramatically reduces the number of
code blocks that get DFG compiled. It is a speed-up on those V8v7 benchmarks that
saw regressions from concurrent compilation.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::linkIncomingCall):
(JSC):
(JSC::CodeBlock::noticeIncomingCall):
- bytecode/CodeBlock.h:
(CodeBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::mightInlineFunction):
(DFG):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThread):
- dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkFor):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::linkFor):
- jit/JIT.h:
(JIT):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::lazyLinkFor):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall):
- 1:26 PM Changeset in webkit [150656] by
-
- 2 edits in trunk/Source/WebCore
[AC] Needs to be guarded by USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=116712
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-24
Reviewed by Andreas Kling.
renderView is used when ACCELERATED_COMPOSITING is enabled.
So, this patch allows it to be guarded by USE(ACCELERATED_COMPOSITING).
No new tests, no behavior change.
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
- 1:07 PM Changeset in webkit [150655] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r150215): broke a test case in inspector/console/console-css-warnings.html
https://bugs.webkit.org/show_bug.cgi?id=116731
Reviewed by Ryosuke Niwa.
The mentioned revision removed a layering violation added just to
support some IE7 hack. That was removed but the test case
supporting it was left untouched, remove it.
- inspector/console/console-css-warnings-expected.txt:
- inspector/console/console-css-warnings.html:
- 12:43 PM Changeset in webkit [150654] by
-
- 6 edits in trunk/LayoutTests
[WK2] Spelling tests gardening
https://bugs.webkit.org/show_bug.cgi?id=116718
Unreviewed gardening.
The most spelling tests are skipped for wk2 platforms and they have deprecated comments.
Move the tests from global wk2/TestExpectations to the ports' TestExpectations as
the core spellchecking implementation is delivered for wk2.
This change will allow to run spelling tests easier and using [ Pass ] keyword
in TestExpectations won't be needed.
- platform/efl-wk2/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/qt-5.0-wk2/TestExpectations:
- platform/wk2/TestExpectations:
- 12:41 PM Changeset in webkit [150653] by
-
- 4 edits in trunk/Source
Add more lines to the context during Dictionary lookups
https://bugs.webkit.org/show_bug.cgi?id=115256
Patch by Thomas Deniau <deniau@apple.com> on 2013-05-24
Reviewed by Ryosuke Niwa.
Source/WebCore:
No new tests - no new functionality.
- WebCore.exp.in: Export a few methods in VisibleUnits needed to be able
to call previousLinePosition(), nextLinePosition(), startOfLine() and
endOfLine() in WebPageMac.mm when determining the context while looking
up a dictionary definition. These symbols used to be exported for iOS
only, export them on the desktop too.
Source/WebKit2:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
Instead of using the current paragraph as the context (which stops at
line breaks), get a few lines before and after the point, so that the
context contains at least four lines in each direction.
This way the Dictionary will be able to look up things that extend past
the current line.
- 12:07 PM Changeset in webkit [150652] by
-
- 18 edits17 deletes in trunk
Remove PagePopup code
https://bugs.webkit.org/show_bug.cgi?id=116732
Reviewed by Andreas Kling.
.:
- Source/cmakeconfig.h.cmake:
Remove ENABLE_PAGE_POPUP.
Source/WebCore:
Remove all page popup code.
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- dom/ContextFeatures.cpp:
- dom/ContextFeatures.h:
- loader/EmptyClients.h:
- page/ChromeClient.h:
- page/DOMWindowPagePopup.cpp: Removed.
- page/DOMWindowPagePopup.h: Removed.
- page/DOMWindowPagePopup.idl: Removed.
- page/PagePopup.h: Removed.
- page/PagePopupClient.cpp: Removed.
- page/PagePopupClient.h: Removed.
- page/PagePopupController.cpp: Removed.
- page/PagePopupController.h: Removed.
- page/PagePopupController.idl: Removed.
- page/PagePopupDriver.h: Removed.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore):
- testing/Internals.h:
(WebCore):
(Internals):
- testing/Internals.idl:
- testing/MockPagePopupDriver.cpp: Removed.
- testing/MockPagePopupDriver.h: Removed.
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
Remove PAGE_POPUP.
Source/WTF:
Remove ENABLE_PAGE_POPUP.
- wtf/FeatureDefines.h:
LayoutTests:
Remove tests that relied on the mock page popup driver.
- fast/forms/date/no-page-popup-controller-expected.txt: Removed.
- fast/forms/date/no-page-popup-controller.html: Removed.
- fast/forms/resources/picker-common.js: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings.html: Removed.
- 11:54 AM Changeset in webkit [150651] by
-
- 13 edits3 copies1 add in trunk/Source
Mac: Set the default audio buffer size to a large value for <video> elements.
https://bugs.webkit.org/show_bug.cgi?id=116342
Source/WebCore:
Reviewed by Eric Carlson.
Roll-in rubber stamped by Eric Carlson.
To enable power savings by waking up the audio hardware less often, set the
requested buffer frame size to a large value, such as 4096. Since this results
in approximately 100ms worth of buffer, set the buffer size to a much lower
value when playing WebAudio, which is much more sensitive to latency than video
or audio elements.
Introduce a new class, AudioSessionManager, as well as a helper class,
AudioSessionManagerToken. Audio elements, video elements, and WebAudio destination
nodes will create and retain a token, and release the token in their destructor.
This allows the AudioSessionManager to track how many of what type of audio-
generating objects are in existence.
This requires implementing AudioSession for Mac platforms. Move the implementation
for retrieving the hardware sample rate and setting the buffer duration into
AudioSessionMac from AudioDestinationMac, to be shared with AudioSessionManagerMac.
Change the AudioSession method preferredBufferLength() into preferredBufferSize(),
as the callers really want to specify a buffer size, not a buffer duration. On iOS,
where the available API requires a duration, perform the conversion from duration to
size on behalf of the caller.
However, since the original version of this patch caused media test
failures on the Mac ML and Lion bots, only enable the buffer size
change for OS X > ML.
- html/HTMLMediaElement.h: Add a AudioSessionManagerToken member.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize the token.
- platform/audio/AudioSession.cpp:
(WebCore::AudioSession::preferredBufferSize): Renamed from preferredBufferLength.
(WebCore::AudioSession::setPreferredBufferSize): Renamed from setPreferredBufferLength.
- platform/audio/AudioSession.h:
- platform/audio/AudioSessionManager.cpp:
(AudioSessionManagerToken::create): Simple factory method.
(AudioSessionManagerToken::AudioSessionManagerToken): Call AudioSessionManager::incrementCount().
(AudioSessionManagerToken::~AudioSessionManagerToken): Call AudioSessionManager::decrementCount().
(AudioSessionManager::sharedManager): Simple singleton method.
(AudioSessionManager::AudioSessionManager): Simple constructor.
(AudioSessionManager::has): Return whether the type is present.
(AudioSessionManager::incrementCount): Increment, then call updateSessionState()
(AudioSessionManager::decrementCount): Decrement, then call updateSessionState()
(AudioSessionManager::updateSessionState): Stub, does nothing.
- platform/audio/AudioSessionManager.h:
- platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestinationIOS::configure): Call setPreferredBufferSize() instead of setPreferredBufferLength()
- platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::preferredBufferSize): Renamed from preferredBufferLength.
(WebCore::AudioSession::setPreferredBufferSize): Renamed from setPreferredBufferLength
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::hardwareSampleRate): Call AudioSession::sampleRate().
(WebCore::AudioDestinationMac::AudioDestinationMac): Create the AudioSessionManagerToken.
(WebCore::AudioDestinationMac::configure): Do not set the buffer size (this is done in AudioSessionManagerMac).
- platform/audio/mac/AudioDestinationMac.h:
- platform/audio/mac/AudioSessionMac.cpp: Added.
(WebCore::defaultDevice): Added, returns the default audio device.
(WebCore::AudioSession::AudioSession): Simple constructor.
(WebCore::AudioSession::~AudioSession): Simple destructor.
(WebCore::AudioSession::category): Stub, unimplemented.
(WebCore::AudioSession::setCategory): Ditto.
(WebCore::AudioSession::categoryOverride): Ditto.
(WebCore::AudioSession::setCategoryOverride): Ditto.
(WebCore::AudioSession::numberOfOutputChannels): Ditto.
(WebCore::AudioSession::setActive): Ditto.
(WebCore::AudioSession::sampleRate): Use the HAL to return the default audio device sample rate.
(WebCore::AudioSession::preferredBufferSize): Return the current HAL setting.
(WebCore::AudioSession::setPreferredBufferSize): Set the buffer size.
- platform/audio/mac/AudioSessionManagerMac.cpp:
(AudioSessionManager::updateSessionState): Set the buffer size depending on what audio outputs are present.
- WebCore.xcodeproj/project.pbxproj: Add the new files to the project.
Source/WTF:
Reviewed by Eric Carlson.
- wtf/Platform.h: Add a WTF_USE_AUDIO_SESSION setting.
- 11:46 AM Changeset in webkit [150650] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebCore
Merged r150631. <rdar://problem/13963712>
- 11:42 AM Changeset in webkit [150649] by
-
- 7 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150620. <rdar://problem/13938510>
- 11:09 AM Changeset in webkit [150648] by
-
- 2 edits in trunk/Source/WebKit2
Intermittent crash when typing in Address Bar
https://bugs.webkit.org/show_bug.cgi?id=116728
<rdar://problem/13976781>
Reviewed by Sam Weinig.
If a web process connection has been removed from the storage manager because we disconnected it
since there were no more active pages associated with the web process, we'll fail to find it here
so just return early instead of crashing.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::destroyStorageMap):
- 11:01 AM Changeset in webkit [150647] by
-
- 4 edits in branches/safari-537.43-branch/Source
Versioning.
- 10:28 AM Changeset in webkit [150646] by
-
- 3 edits in trunk/Source/WebCore
Path: upstream the missing bits from the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=116658
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-24
Reviewed by Xan Lopez.
PathBlackBerry was upstreamed a while ago (r144612) but a few bits
were missing from the cross-platform code.
- platform/graphics/Path.cpp:
(WebCore::Path::addPathForRoundedRect):
- platform/graphics/Path.h:
(Graphics):
(Path):
- 10:16 AM Changeset in webkit [150645] by
-
- 3 edits in trunk/LayoutTests
Improve loader/go-back-cached-main-resource.html test
https://bugs.webkit.org/show_bug.cgi?id=116709
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-05-24
Reviewed by Alexey Proskuryakov.
It is only needed to register the listeners on the initial load as they
are already present when restoring from page cache. Modified the test to
use event.persisted property to know if we are handling the first load
in order to register the listeners only once.
- loader/resources/first-page.html: Rename registerListeners() function
to a more accurate name didShowPage() and use event.persisted to
register the listeners only in the first load.
- loader/resources/other-page.html: Ditto.
- 9:50 AM WebKit Team edited by
- (diff)
- 9:46 AM Changeset in webkit [150644] by
-
- 4 edits in trunk/Source/JavaScriptCore
[sh4] Optimize LLINT generated code and fix few bugs in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=116716
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-24
Reviewed by Geoffrey Garen.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::mul32): Cosmetic changes.
(JSC::MacroAssemblerSH4::convertInt32ToDouble): Absolute address was not dereferenced.
(JSC::MacroAssemblerSH4::branch32): Absolute address was not dereferenced.
(JSC::MacroAssemblerSH4::revertJumpReplacementToBranchPtrWithPatch): Use all 32 bits of pointer for revertJump call.
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::revertJump): Use changePCrelativeAddress to patch the whole pointer.
(JSC::SH4Assembler::linkJump): Cosmetic change.
- offlineasm/sh4.rb: Optimize LLINT generated code.
- 9:34 AM Changeset in webkit [150643] by
-
- 3 edits2 adds in trunk
WebProcess is crashing on http://achicu.github.io/css-presentation when direct pattern compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=115135
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-05-24
Reviewed by Antti Koivisto.
Source/WebCore:
Issue is invoked when there is a visibility:hidden layer with a non-compositable
background image (e.g. a radial gradient).
The layer is treated as a no-contents layer because of its visibility, however
updateDirectlyCompositedBackgroundImage() later mistakenly treats it as a layer
with direct background-image compositing.
Fixed by returning early from updating directly composited contents for layers
with hidden contents.
Test: compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::paintsChildren):
(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
LayoutTests:
Added a ref-test that makes sure that a layer with a hidden radial gradient does not
cause the web process to crash.
- compositing/patterns/direct-pattern-compositing-hidden-radial-gradient-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html: Added.
- 9:18 AM Changeset in webkit [150642] by
-
- 2 edits in trunk/Source/WebCore
Refactor shouldAddBorderPaddingMargin()
https://bugs.webkit.org/show_bug.cgi?id=98803
Reviewed by Ryosuke Niwa.
Make this helper function less clever-stupid in its misguided sacrifice of intelligibility
for the sake of concision.
No new tests, refactoring.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::shouldAddBorderPaddingMargin):
(WebCore::inlineLogicalWidth):
- 8:51 AM Changeset in webkit [150641] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix bad type warning in InputHandler log.
https://bugs.webkit.org/show_bug.cgi?id=116720
Reviewed by Carlos Garcia Campos.
Fix warning in inputLog string.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
- 7:48 AM Changeset in webkit [150640] by
-
- 2 edits in trunk/Tools
Update WTF::Vector pretty printers
https://bugs.webkit.org/show_bug.cgi?id=116719
Patch by Simon Pena <simon.pena@samsung.com> on 2013-05-24
Reviewed by Anders Carlsson.
After r148891, WTF::Vector pretty printers were left outdated, as
the WTF::Vector was made to extend a VectorBuffer, instead of keeping
one as a member. This patch updates the pretty printers so they work
again.
- gdb/webkit.py:
(WTFVectorPrinter.children):
(WTFVectorPrinter.to_string):
- 7:20 AM Changeset in webkit [150639] by
-
- 14 edits13 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Update qt-5.0-wk2 expected pictures after r150506.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-24
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/qt-5.0-wk2/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
- platform/qt-5.0-wk2/svg/filters/feImage-late-indirect-update-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-reference-invalidation-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-add-to-document-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-attribute-change-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-changes-id-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-id-change-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-inline-style-change-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-property-change-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-remove-from-document-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-style-change-expected.png: Added.
- 6:25 AM Changeset in webkit [150638] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests.
- platform/qt-5.0-wk2/TestExpectations: Move http/tests/security/cross-frame-access-put.html to qt/TestExpectations.
- platform/qt/TestExpectations: Skip fast/frames/detach-frame-during-focus.html after r146523.
- 5:47 AM Changeset in webkit [150637] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Respect tabindex when using form controls.
https://bugs.webkit.org/show_bug.cgi?id=116676
Reviewed by Xan Lopez.
PR 337419.
Update form control navigation tracking to take tabindex
order into account when calculating next and previous nodes.
The order to follow is tab index 1 - N, followed by all items
without a tab index or tab index 0 in rendering order to match
with standard desktop behavior.
Internally Reviewed by Genevieve Mak and Nima Ghanavatian.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState):
- 5:23 AM WebKitGTK/TrackingMemoryErrors edited by
- (diff)
- 1:41 AM Changeset in webkit [150636] by
-
- 2 edits in trunk/Tools
Update prepareConsistentTestingEnvironment to use a non-deprecated API.
https://bugs.webkit.org/show_bug.cgi?id=116710
Reviewed by Mark Rowe.
- DumpRenderTree/mac/DumpRenderTree.mm:
(prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
- 1:05 AM Changeset in webkit [150635] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] DRT - crashed on GraphicsContext3D::makeContextCurrent
https://bugs.webkit.org/show_bug.cgi?id=116654
Patch by Xiaobo Wang <xiaobwang@blackberry.com> on 2013-05-24
Reviewed by Carlos Garcia Campos.
PR 331552.
Internally reviewed and amended by Arvid Nilsson.
No new tests, this patch is to fix DRT crashes in fast/canvas/webgl.
The instance of GraphicsContext3D has already been destroyed but
WebGLLayerWebKitThread is not aware of that. This is because compositor
layer of the WebGL graphics context was referenced outside the context.
So when destructing GraphicsContext3D the compositing layer was not
destructed.
Fix by setting m_webGLContext to 0 when destructing GrapthicsContext3D
after releasing the compositor layer, so that it won't be de-referenced
again later.
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
- platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:
(WebCore::WebGLLayerWebKitThread::~WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::webGLContextDestroyed):
(WebCore):
- platform/graphics/blackberry/WebGLLayerWebKitThread.h:
(WebGLLayerWebKitThread):
- 12:32 AM Changeset in webkit [150634] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove SKIA leftovers from WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=116656
Patch by Jeff Rogers <jrogers@rim.com> on 2013-05-24
Reviewed by Rob Buis.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
- 12:12 AM Changeset in webkit [150633] by
-
- 6 edits in trunk/Source
Typing in Safari's unified field causes unnecessary web content repaints.
<http://webkit.org/b/116703>
Reviewed by Andy Estes.
Source/WebCore:
Break out an alternate version of Page::markAllMatchesForText() that only counts the number of times
a string occurs in the page, but doesn't try to mark the occurrences.
This allows Safari to count matches for the 'Find "foo" on This Page' functionality in the unified
location bar without causing tile repaints.
- WebCore.exp.in:
- page/Page.h:
- page/Page.cpp:
(WebCore::Page::findMatchesForText):
(WebCore::Page::markAllMatchesForText):
(WebCore::Page::countFindMatches):
Renamed markAllMatchesForText() to findMatchesForText() and gave it a boolean parameter to control whether
matches should be marked or not. countFindMatches() is the new helper that doesn't mark.
Source/WebKit2:
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::countStringMatches):
Call WebCore::Page::countMatchesForText() instead of markAllMatchesForText(). If the search string
is found inside the page content, the renderer containing that text will no longer be repainted.
- 12:05 AM Changeset in webkit [150632] by
-
- 3 edits in trunk/LayoutTests
Add back a failing test expectation on fast/canvas/webgl/object-deletion-behaviour.html
after r150558 on Lion Debug WK1.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 12:02 AM Changeset in webkit [150631] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=116702
REGRESSION (r150399): Scrollbar missing for all overflow scroll
-and corresponding-
<rdar://problem/13963712>
Reviewed by Simon Fraser.
This was a silly copy-paste error.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollbarAnimationsAreSuppressed):
