⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 3, 2013:

11:27 PM Changeset in webkit [151157] by mark.lam@apple.com
  • 3 edits in branches/dfgFourthTier

Merged from ​http://svn.webkit.org/repository/webkit/trunk

------------------------------------------------------------------------
r148820 | ​mark.lam@apple.com | 2013-04-21 02:04:09 -0700 (Sun, 21 Apr 2013) | 11 lines
Refactor identical inline functions in JSVALUE64 and JSVALUE32_64 sections
out into the common section.

​https://bugs.webkit.org/show_bug.cgi?id=114910.
------------------------------------------------------------------------

11:03 PM Changeset in webkit [151156] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unable to play videos in Safari using QuickTime plug-in until I've played those videos in Chrome first
​https://bugs.webkit.org/show_bug.cgi?id=117174
<rdar://problem/13711687>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-03
Reviewed by Alexey Proskuryakov.

Pull in fixes that allow https connections within the plugin
environment.

  • Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
10:37 PM Changeset in webkit [151155] by mark.lam@apple.com
  • 53 edits
    4 copies
    1 delete in branches/dfgFourthTier

Source/JavaScriptCore: Merged from ​http://svn.webkit.org/repository/webkit/trunk

------------------------------------------------------------------------
r148639 | ​mark.lam@apple.com | 2013-04-17 15:37:45 -0700 (Wed, 17 Apr 2013) | 127 lines
Add LLINT and baseline JIT support for timing out scripts.

​https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------
r148641 | ​mark.lam@apple.com | 2013-04-17 15:57:33 -0700 (Wed, 17 Apr 2013) | 10 lines
Fix broken build. Replaced a static const with a #define.

​https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------
r148655 | ​mark.lam@apple.com | 2013-04-17 20:17:44 -0700 (Wed, 17 Apr 2013) | 10 lines
Avoid using a branch range that is too far for some CPU architectures.

​https://bugs.webkit.org/show_bug.cgi?id=114782.
------------------------------------------------------------------------
r148709 | ​mark.lam@apple.com | 2013-04-18 15:45:25 -0700 (Thu, 18 Apr 2013) | 11 lines
Interpreter entry points should throw the TerminatedExecutionException from the caller frame.

​https://bugs.webkit.org/show_bug.cgi?id=114816.
------------------------------------------------------------------------
r148893 | ​mark.lam@apple.com | 2013-04-22 10:37:29 -0700 (Mon, 22 Apr 2013) | 30 lines
Change baseline JIT watchdog timer check to use the proper fast slow path
infrastructure.

​https://bugs.webkit.org/show_bug.cgi?id=114963.
------------------------------------------------------------------------
r148899 | ​mark.lam@apple.com | 2013-04-22 11:40:58 -0700 (Mon, 22 Apr 2013) | 20 lines
Fix broken 32-bit build to green the bots.

​https://bugs.webkit.org/show_bug.cgi?id=114968.
------------------------------------------------------------------------
r148942 | ​mark.lam@apple.com | 2013-04-22 21:47:08 -0700 (Mon, 22 Apr 2013) | 11 lines
Fix a typo in MacroAssemblerARMv7.h.

​https://bugs.webkit.org/show_bug.cgi?id=115011.
------------------------------------------------------------------------
r148989 | ​mark.lam@apple.com | 2013-04-23 13:54:34 -0700 (Tue, 23 Apr 2013) | 21 lines
Simplify the baseline JIT loop hint call site.

​https://bugs.webkit.org/show_bug.cgi?id=115052.
------------------------------------------------------------------------
r149089 | ​mark.lam@apple.com | 2013-04-24 19:59:51 -0700 (Wed, 24 Apr 2013) | 40 lines
Add watchdog timer polling for the DFG.

​https://bugs.webkit.org/show_bug.cgi?id=115134.
------------------------------------------------------------------------
r149420 | ​mark.lam@apple.com | 2013-04-30 19:38:19 -0700 (Tue, 30 Apr 2013) | 17 lines
JSContextGroupSetExecutionTimeLimit() should not pass a callback to the
VM watchdog if its client did not pass one in.

​https://bugs.webkit.org/show_bug.cgi?id=115461.
------------------------------------------------------------------------
r150449 | ​mark.lam@apple.com | 2013-05-21 09:44:01 -0700 (Tue, 21 May 2013) | 8 lines
Added missing assert condition for PositiveOrZero in ARM branch32().

​https://bugs.webkit.org/show_bug.cgi?id=116538.
------------------------------------------------------------------------

Source/WebCore: Merged from ​http://svn.webkit.org/repository/webkit/trunk

------------------------------------------------------------------------
r148639 | ​mark.lam@apple.com | 2013-04-17 15:37:45 -0700 (Wed, 17 Apr 2013) | 127 lines
Add LLINT and baseline JIT support for timing out scripts.

​https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------

Source/WTF: Merged from ​http://svn.webkit.org/repository/webkit/trunk

------------------------------------------------------------------------
r148639 | ​mark.lam@apple.com | 2013-04-17 15:37:45 -0700 (Wed, 17 Apr 2013) | 127 lines
Added currentCPUTime() and currentCPUTimeMS().

​https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------

10:09 PM Changeset in webkit [151154] by kangil.han@samsung.com
  • 2 edits in trunk/Source/WebCore

Remove unused arithmetic operation in RenderListItem
​https://bugs.webkit.org/show_bug.cgi?id=117175

Reviewed by Brent Fulgham.

Variable 'markerLogicalLeft' is reassigned a value before the old one has been used.

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):

10:01 PM Changeset in webkit [151153] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

validate-committer-lists script is now outdated and does not work
​https://bugs.webkit.org/show_bug.cgi?id=115860

Patch by Simon Pena <​simon.pena@samsung.com> on 2013-06-03
Reviewed by Brent Fulgham.

The script validate-committer-lists was outdated, still using the deprecated log
system and having the old addresses for the mailing lists, as well as still referring
to committers.py, after this was renamed to contributors.json. This patch fixes that
so it can be used again.

  • Scripts/validate-committer-lists: Replace calls to log and error with the

new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
to committers.py, which should be contributors.json.
(CommitterListFromMailingList):
(CommitterListFromMailingList.check_for_emails_missing_from_list):
(CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
(CommitterListFromGit._fill_in_emails_for_old_logins):
(CommitterListFromGit.print_committers_missing_from_committer_list):

9:51 PM Changeset in webkit [151152] by dpranke@chromium.org
  • 1 edit
    1 add in trunk/Tools

add a script to dump the tests run most recently by a given worker
​https://bugs.webkit.org/show_bug.cgi?id=116571

Reviewed by Brent Fulgham.

The tests_run*.txt results files in layout-test-results/ were removed
in r137356, in favor of collecting more data about how the tests were
run and compressing it and storing it in stats.json. However, it was
nice to just be able to look at a flat text file.

This script will extract the tests run by a given worker from a
given stats.json file, and should help to address that.

  • Scripts/dump-webkit-tests-run: Added.

(main):
(convert_trie_to_flat_paths):

9:02 PM Changeset in webkit [151151] by Brent Fulgham
  • 10 edits in trunk/Tools

[Windows] NRWT is not putting crash logs in proper place
​https://bugs.webkit.org/show_bug.cgi?id=117098

Reviewed by Ryosuke Niwa.

Provide windows-specific overloads for various Port features needed to create and capture
crash logs. This change makes it possible to view crash logs (when created) as part of the
summary report at the end of the NRWT run.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.find_newest_log): Add support for win32 crash logs
(CrashLogs._find_newest_log_win): Added

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(make_mock_crash_report_win): Added
(CrashLogsTest.test_find_log_win): Added.

  • Scripts/webkitpy/common/system/executive.py:

(Executive.running_pids): Add support for Cygwin win32 crash logs

  • Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.init):

  • Scripts/webkitpy/common/system/filesystem_unittest.py:

(RealFileSystemTest.test_read_and_write_file): Add tests for
malformed ascii/utf8 handling (i.e., Windows log files)

  • Scripts/webkitpy/port/base.py:

(Port.find_system_pid): Added

  • Scripts/webkitpy/port/server_process.py:

(ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs

  • Scripts/webkitpy/port/win.py:

(WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
for user to hit enter.
(WinPort._get_crash_log): Added
(WinPort.look_for_new_crash_logs): Added
(WinPort.find_system_pid): Added

  • Scripts/webkitpy/port/win_unittest.py:

(WinPortTest.test_get_crash_log): Added test

9:00 PM Changeset in webkit [151150] by mark.lam@apple.com
  • 44 edits
    2 deletes in branches/dfgFourthTier

Merged from ​http://svn.webkit.org/repository/webkit/trunk

------------------------------------------------------------------------
r148119 | ​ggaren@apple.com | 2013-04-10 11:51:47 -0700 (Wed, 10 Apr 2013) | 106 lines
Removed bitrotted TimeoutChecker code

Source/JavaScriptCore:
​https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------

Source/WebCore:
​https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------

Source/WebKit/blackberry:
​https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------

Source/WebKit/mac:
​https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------

Source/WebKit/qt:
​https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------

Source/WebKit2:
​https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------

8:20 PM Changeset in webkit [151149] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source/JavaScriptCore

[EFL] Implement GCActivityCallback
​https://bugs.webkit.org/show_bug.cgi?id=95923

Patch by Hojong Han <​hojong.han@samsung.com> on 2013-06-03
Reviewed by Geoffrey Garen.

Implements the activity triggered garbage collector.
Additional GCs can be triggered by platfrom timer.
It has sort of compaction effect not to make JSC heap grow fast
so that memory usage becomes lower than usual.

  • PlatformEfl.cmake: Added.
  • heap/HeapTimer.cpp:

(JSC):
(JSC::HeapTimer::HeapTimer):
(JSC::HeapTimer::~HeapTimer):
(JSC::HeapTimer::add):
(JSC::HeapTimer::stop):
(JSC::HeapTimer::timerEvent):

  • heap/HeapTimer.h:

(HeapTimer):

  • jsc.cpp:

(main):

  • runtime/GCActivityCallback.cpp:

(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::scheduleTimer):
(JSC::DefaultGCActivityCallback::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):

  • runtime/GCActivityCallback.h:

(GCActivityCallback):
(JSC::GCActivityCallback::GCActivityCallback):
(DefaultGCActivityCallback):

7:57 PM Changeset in webkit [151148] by mark.lam@apple.com
  • 20 edits in branches/dfgFourthTier

Merged from ​http://svn.webkit.org/repository/webkit/trunk

r147858 | ​oliver@apple.com | 2013-04-06 15:47:56 -0700 (Sat, 06 Apr 2013) | 62 lines
Unify the many and varied stack trace mechanisms, and make the result sane.

Source/JavaScriptCore:

​https://bugs.webkit.org/show_bug.cgi?id=114072

Source/WebCore:

​https://bugs.webkit.org/show_bug.cgi?id=114072

Tools:

​https://bugs.webkit.org/show_bug.cgi?id=114072

6:44 PM Changeset in webkit [151147] by roger_fong@apple.com
  • 6 edits
    2 moves in trunk

Unreviewed. Some AppleWin VS2010 house cleaning.

  • WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd:
  • WebKit.vcxproj/WebKit/WebKitPreBuild.cmd:
  • win/tools32/scripts/auto-version.sh: Replaced with win/tools32/scripts/auto-version2010.sh.
  • win/tools32/scripts/auto-version2010.sh: Removed.
  • win/tools32/scripts/feature-defines.sh: Replaced with win/tools32/scripts/feature-defines2010.sh.
  • win/tools32/scripts/feature-defines2010.sh: Removed.
  • WebCore.vcxproj/build-generated-files.sh:
6:16 PM Changeset in webkit [151146] by roger_fong@apple.com
  • 9 edits
    1 add in trunk

clearLayoutOverflow should never be called before calling layer()->updateScrollInfoAfterLayout().
​https://bugs.webkit.org/show_bug.cgi?id=116689.

Reviewed by Ojan Vafai.

Make sure that clearLayoutOverflow only gets called after layer()->updateScrollInfoAfterLayout().
Also move clearLayoutOverflow to RenderBlock so we can keep all the delayed scroll update logic together.

Test: fast/flexbox/clear-overflow-before-scroll-update.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layout): Remove call to clearLayoutOverflow.
(WebCore::RenderBlock::finishDelayUpdateScrollInfo): Add call to clearLayoutOverflow.
(WebCore::RenderBlock::updateScrollInfoAfterLayout): Ditto.

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:

(WebCore::RenderBox::layoutOverflowRect): Remove from layoutOverflowRect.
(RenderBox):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock): This should call updateScrollInfoAfterLayout() intead of directly calling layer()->updateScrollInfoAfterLayout().

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock): Ditto.

6:09 PM Changeset in webkit [151145] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
​https://bugs.webkit.org/show_bug.cgi?id=116726

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2013-06-03
Reviewed by Gyuyoung Kim.

.:

Bump required version of ATK to 2.8.0 in EFL CMake's build.

  • Source/cmake/FindATK.cmake: Adds macro to check required version
  • Source/cmake/OptionsEfl.cmake: Specifies required version of ATK to be 2.8.0

Tools:

Current version of ATK in efl-ews environment is 2.4.0 and is taken from
the platform (it is not listed in jhbuild moduleset). That version is
old-ish and contain deprecated symbols and missing API, that are blocking
patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
moduleset, which is the same version the gtk port uses.

See bug ​https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
why this is needed.

  • efl/jhbuild.modules: Adds ATK module as dependency
5:11 PM Changeset in webkit [151144] by fpizlo@apple.com
  • 6 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: all cached put_by_id transitions, even ones that weren't inlined by the DFG, should be propagated by the GC
​https://bugs.webkit.org/show_bug.cgi?id=117170

Reviewed by Mark Hahnenberg.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::propagateTransitions):
(JSC):
(JSC::CodeBlock::determineLiveness):
(JSC::CodeBlock::visitWeakReferences):
(JSC::CodeBlock::finalizeUnconditionally):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecode/PolymorphicPutByIdList.h:

(JSC):
(PutByIdAccess):
(PolymorphicPutByIdList):

  • bytecode/StructureStubInfo.h:

(StructureStubInfo):

  • jit/JITCode.h:

(JSC::JITCode::couldBeInterpreted):
(JITCode):

4:42 PM Changeset in webkit [151143] by mark.lam@apple.com
  • 15 edits in branches/dfgFourthTier

Source/JavaScriptCore: Merged from ​http://svn.webkit.org/repository/webkit/trunk

r146505 | ​mark.lam@apple.com | 2013-03-21 13:06:26 -0700 (Thu, 21 Mar 2013) | 21 lines
Fix lexer charPosition computation when "rewind"ing the lexer.

​https://bugs.webkit.org/show_bug.cgi?id=112952.

r146552 | ​mark.lam@apple.com | 2013-03-21 18:56:17 -0700 (Thu, 21 Mar 2013) | 50 lines
Fix O(n2) op_debug bytecode charPosition to column computation.

​https://bugs.webkit.org/show_bug.cgi?id=112957.

Source/WTF: Merged from ​http://svn.webkit.org/repository/webkit/trunk

r146552 | ​mark.lam@apple.com | 2013-03-21 18:56:17 -0700 (Thu, 21 Mar 2013) | 50 lines
Introducing String::findNextLineStart().

​https://bugs.webkit.org/show_bug.cgi?id=112957.

3:52 PM Changeset in webkit [151142] by Lucas Forschler
  • 2 edits in tags/Safari-537.43.57/Source/WebKit2

Merged r151035. <rdar://problem/14050413>

3:47 PM Changeset in webkit [151141] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[harfbuzz] WebKit fails to build with MinGW compiler because of invalid cast in HarfBuzzShaper.cpp
​https://bugs.webkit.org/show_bug.cgi?id=108373

Patch by Paweł Forysiuk <​tuxator@o2.pl> on 2013-06-03
Reviewed by Darin Adler.

Fix building on platforms where UChar is defined as wchar_t.

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):

3:45 PM Changeset in webkit [151140] by rniwa@webkit.org
  • 33 edits
    2 adds in trunk

REGRESSION: Undoing autocorrection doesn't prevent a future autocorrection
​https://bugs.webkit.org/show_bug.cgi?id=117165

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by SpellingCorrectionCommand returning true in callsAppliedEditingInDoApply, which prevented
the command from being registered to the undo manager. This behavior was introduced in r148306 because TypingCommand
registeres itself to the undo manager in appliedEditing.

Fixed the bug by reverting both r122176 and r148306 and implementing a better fix for the bug 90487.
Instead of using InsertTextCommand, simply don't specify ReplaceSelectionCommand::PreventNesting so that the command
doesn't try to break out of a blockquote.

Also fix a bug in ReplaceSelectionCommand::completeHTMLReplacement uncovered by this change. We were only merging
text nodes at the beginning of the replaced content but not at the end. Call mergeTextNodesAroundPosition for the
second time to fix whitespace at the end of the replaced content.

Test: platform/mac/editing/spelling/autocorrection-respets-undo.html

  • editing/CompositeEditCommand.cpp: Explictily check isTypingCommand now that callsAppliedEditingInDoApply has been

removed from SpellingCorrectionCommand and TypingCommand and SpellingCorrectionCommand were only classes that
returned true in callsAppliedEditingInDoApply. See r148306 that introduced this function.
(WebCore::CompositeEditCommand::apply):

  • editing/CompositeEditCommand.h: Removed callsAppliedEditingInDoApply.
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):

  • editing/SpellingCorrectionCommand.cpp: Removed callsAppliedEditingInDoApply, which was the culprit of this bug,

so that CompositeEditCommand::apply correctly registers this command with the undo manager.
(WebCore::SpellingCorrectionCommand::doApply): Use ReplaceSelectionCommand instead of TypingCommand as noted above.

  • editing/SpellingCorrectionCommand.h:
  • editing/TypingCommand.cpp: Deleted callsAppliedEditingInDoApply.
  • editing/TypingCommand.h:

LayoutTests:

Add a regression test and rebaseline other tests as ReplaceSelectionCommand now merges text nodes at
the end of replaced text.

  • editing/deleting/merge-paragraph-from-address-expected.txt:
  • editing/deleting/merge-paragraph-from-h6-expected.txt:
  • editing/deleting/merge-paragraph-from-listing-expected.txt:
  • editing/deleting/paste-with-transparent-background-color-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/pasteboard/copy-image-with-alt-text-expected.txt:
  • editing/pasteboard/merge-end-4-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-unrendered-select-expected.txt:
  • editing/pasteboard/smart-paste-003-trailing-whitespace-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/mac/editing/pasteboard/4944770-2-expected.txt:
  • platform/mac/editing/pasteboard/8145-2-expected.txt:
  • platform/mac/editing/pasteboard/paste-line-endings-006-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-008-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • platform/mac/editing/pasteboard/paste-xml-expected.txt:
  • platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
  • platform/mac/editing/spelling/autocorrection-blockquote-crash.html: Added more asssertions to ensure that

the autocorrected text is in the blockquote. r122176 modified the test description saying that this test
already checks this condition but it never did so explicitly; it assumed that the autocorrected text was
inside a blockquote as long as it started at a certain offset in the text node.

  • platform/mac/editing/spelling/autocorrection-respets-undo-expected.txt: Added.
  • platform/mac/editing/spelling/autocorrection-respets-undo.html: Added.
  • platform/mac/editing/spelling/autocorrection-with-multi-line-text-expected.txt:
3:32 PM Changeset in webkit [151139] by Lucas Forschler
  • 4 edits in tags/Safari-537.43.57/Source

Versioning.

3:29 PM Changeset in webkit [151138] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Reduce indentation in Widget::paint in WidgetMac.mm
​https://bugs.webkit.org/show_bug.cgi?id=117171

Reviewed by Darin Adler.

Use an early return for the common case to reduce indentation in the complex case.

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

3:29 PM Changeset in webkit [151137] by Lucas Forschler
  • 1 copy in tags/Safari-537.43.57

New Tag.

3:28 PM Changeset in webkit [151136] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. AppleWin VS2010 build fix.

  • WebCore.vcxproj/migrate-scripts.sh:
3:25 PM Changeset in webkit [151135] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Respect PKG_CONFIG env variable when generating gtk-doc
​https://bugs.webkit.org/show_bug.cgi?id=117168

Patch by Erik van Pienbroek <​epienbro@fedoraproject.org> on 2013-06-03
Reviewed by Martin Robinson.

The tool generate-gtkdoc internally calls pkg-config.
When cross-compiling it shouldn't use pkg-config, but
it should use the pkg-config which was detected by
the ./configure script (for example this can be
i686-w64-mingw32-pkg-config when cross-compiling)

  • GNUmakefile.am:
  • gtk/gtkdoc.py:

(PkgConfigGTKDoc.init):

3:23 PM Changeset in webkit [151134] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed build fix.

  • TestWebKitAPI/win/main.cpp: Embed proper manifest information to

allow VS2010 builds to use VS2005 runtime libraries as needed.

3:13 PM Changeset in webkit [151133] by roger_fong@apple.com
  • 7 edits
    98 deletes in trunk

Nuke VS2005 files from the tree.
<rdar://problem/14042021>.

Rubberstamped by Brent Fulgham.

3:06 PM Changeset in webkit [151132] by marcelo.lira@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[WK2] REGRESSION(r150798): scrolling coordinator is not being enabled when WebPage is set to use fixed layout
​https://bugs.webkit.org/show_bug.cgi?id=117163

Reviewed by Darin Adler.

Moved call to WebPage::settings()->setScrollingCoordinatorEnabled()
from CoordinatedLayerTreeHost constructor to WebPage::setUseFixedLayout().
The scrolling coordinator must be enabled or disabled following the
WebPage's use of fixed layout.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setUseFixedLayout):

2:51 PM Changeset in webkit [151131] by Chris Fleizach
  • 7 edits in trunk

AX: WebKit should join substrings on single space when concatenating the accessible name of an element
​https://bugs.webkit.org/show_bug.cgi?id=117100

Reviewed by Darin Adler.

Source/WebCore:

When concatenating text from underneath an element append spaces between objects and trim whitespace.

Modified existing tests reflect the new behavior.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::textUnderElement):

LayoutTests:

  • accessibility/text-role-with-aria-hidden-inside-expected.txt:
  • accessibility/text-role-with-aria-hidden-inside.html:
  • platform/mac/accessibility/internal-link-anchors2-expected.txt:
  • platform/mac/accessibility/table-with-aria-role-expected.txt:
2:49 PM Changeset in webkit [151130] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/LayoutTests

Unreviewed, unbreak all of the tests.

Printing "Some tests failed" is great for the silentTestPass mode, but breaks all previous
expected-to-fail tests. Changed it so we only print this helpful message if we're in
silentTestPass mode.

  • fast/js/resources/js-test-pre.js:

(isSuccessfullyParsed):

2:47 PM Changeset in webkit [151129] by anlo@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Expose show debug borders setting through BlackBerry::WebKit::WebPage
​https://bugs.webkit.org/show_bug.cgi?id=117167

Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

Add WebKit::WebPage API for setting whether to show accelerated compositing
debug borders.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setShowDebugBorders):
(WebKit):

  • Api/WebPage.h:
2:41 PM Changeset in webkit [151128] by mark.lam@apple.com
  • 5 edits in branches/dfgFourthTier

Merged from ​http://svn.webkit.org/repository/webkit/trunk

r147798 | ​fpizlo@apple.com | 2013-04-05 14:34:15 -0700 (Fri, 05 Apr 2013) | 14 lines
If CallFrame::trueCallFrame() knows that it's about to read garbage instead of a valid
CodeOrigin/InlineCallFrame, then it should give up and return 0 and all callers should
be robust against this

​https://bugs.webkit.org/show_bug.cgi?id=114062

2:23 PM Changeset in webkit [151127] by mark.lam@apple.com
  • 5 edits
    3 copies in branches/dfgFourthTier

Source/JavaScriptCore: Merged from ​http://svn.webkit.org/repository/webkit/trunk

r147670 | ​oliver@apple.com | 2013-04-04 14:25:26 -0700 (Thu, 04 Apr 2013) | 42 lines
Exception stack unwinding doesn't handle inline callframes correctly
​https://bugs.webkit.org/show_bug.cgi?id=113952

r147690 | Christophe Dumez | 2013-04-04 17:44:28 -0700 (Thu, 04 Apr 2013) | 7 lines
Unreviewed EFL build fix.
We had undefined reference to `JSC::CodeOrigin::maximumBytecodeIndex'.

LayoutTests: Merged from ​http://svn.webkit.org/repository/webkit/trunk

r147670 | ​oliver@apple.com | 2013-04-04 14:25:26 -0700 (Thu, 04 Apr 2013) | 42 lines
Exception stack unwinding doesn't handle inline callframes correctly
​https://bugs.webkit.org/show_bug.cgi?id=113952

2:03 PM Changeset in webkit [151126] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

Remove XMLMIMETypeRegExp
​https://bugs.webkit.org/show_bug.cgi?id=116861

Reviewed by Alexey Proskuryakov.

Remove the XMLMIMETypeRegExp class. It contained a regular expression that was used
for checking for valid XML MIME types in DOMImplementation::isXMLMIMEType. The thread-global
instance was stored in ThreadGlobalData.

The class is removed, with DOMImplementation::isXMLMIMEType now testing that the given MIME type
is of proper form and contains only valid characters.

No new tests - no change in functionality.

  • dom/DOMImplementation.cpp:

(WebCore::isValidXMLMIMETypeChar): A helper method that returns true only for characters that
are acceptable in a valid XML MIME type (apart from the forward slash).
(WebCore::DOMImplementation::isXMLMIMEType): Instead of using a regular expression, determine
whether the given string is a valid non-standard XML mime type by checking for the '+xml' ending,
proper forward slash position, and that no invalid characters are used in the string.

  • dom/DOMImplementation.h:
  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData): The OwnPtr<XMLMIMETypeRegExp> member variable is being removed.
(WebCore::ThreadGlobalData::destroy): Ditto.

  • platform/ThreadGlobalData.h:

(WebCore): No need for the XMLMIMETypeRegExp forward declaration.
(ThreadGlobalData): Remove the OwnPtr<XMLMIMETypeRegExp> member variable.

1:52 PM Changeset in webkit [151125] by commit-queue@webkit.org
  • 7 edits in trunk

[GTK] Use drawErrorUnderline() instead of Pango API for highlighting misspelled words
​https://bugs.webkit.org/show_bug.cgi?id=115406

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2013-06-03
Reviewed by Martin Robinson.

Source/WebCore:

Replace pango API for drawing underline error on misspelled words, in favor of
drawErrorUnderline() method, removing the platform #ifdef check. As this was the
only usage of Pango in GraphicsContextCairo, it no longer includes pango.h.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLineForDocumentMarker): Removes
pango_cairo_show_error_underline() in favor of drawErrorUnderline().

  • platform/graphics/cairo/DrawErrorUnderline.h:

(drawErrorUnderline): Fills the cairo path at the end of the drawing.

LayoutTests:

Update PNG expectations for some spell checking tests to pass pixel hash comparison.
The images are not visually modified.

  • platform/gtk/editing/spelling/inline-spelling-markers-hidpi-expected.png: Rebaseline

image to pass pixel hash

  • platform/gtk/editing/spelling/inline_spelling_markers-expected.png: Rebasline

image to pass pixel hash

  • platform/gtk/editing/spelling/spelling-expected.png: Rebasline

image to pass pixel hash

12:41 PM Changeset in webkit [151124] by Chris Fleizach
  • 8 edits in trunk/Tools

AX: MathML multiscripts not exposed in Accessibility
​https://bugs.webkit.org/show_bug.cgi?id=115069

Reviewed by Tim Horton.

Add methods to help output components of math multiscripts for accessibility.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(mathPostscriptsDescriptionCallback):
(mathPrescriptsDescriptionCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(convertMathMultiscriptPairsToString):
(AccessibilityUIElement::mathPostscriptsDescription):
(AccessibilityUIElement::mathPrescriptsDescription):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::_convertMathMultiscriptPairsToString):
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):

12:35 PM Changeset in webkit [151123] by Chris Fleizach
  • 10 edits
    2 adds in trunk

AX: MathML multiscripts not exposed in Accessibility
​https://bugs.webkit.org/show_bug.cgi?id=115069

Reviewed by Tim Horton.

Source/WebCore:

Math multiscript tags allow for an arbitrary number of prescripts and postscripts
around a base object.

This MathML tag currently is not supported in the render tree, but that doesn't need to
stop it from being exposed through accessibility, as a base object with an array of postscripts
and an array of prescripts.

Test: platform/mac/accessibility/mathml-multiscript.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isMathMultiscript):
(AccessibilityObject):
(WebCore::AccessibilityObject::mathPrescripts):
(WebCore::AccessibilityObject::mathPostscripts):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isMathMultiscript):
(WebCore::AccessibilityRenderObject::isIgnoredElementWithinMathTree):
(WebCore::AccessibilityRenderObject::mathBaseObject):
(WebCore::AccessibilityRenderObject::mathPrescripts):
(WebCore::AccessibilityRenderObject::mathPostscripts):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSubscriptKey]):
(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSuperscriptKey]):
(-[WebAccessibilityObjectWrapper accessibilityMathPostscripts]):
(-[WebAccessibilityObjectWrapper accessibilityMathPrescripts]):
(-[WebAccessibilityObjectWrapper accessibilityMathOverObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathType]):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.h:
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(convertMathPairsToNSArray):
(-[WebAccessibilityObjectWrapperBase accessibilityPlatformMathSubscriptKey]):
(-[WebAccessibilityObjectWrapperBase accessibilityPlatformMathSuperscriptKey]):
(-[WebAccessibilityObjectWrapperBase accessibilityMathPostscriptPairs]):
(-[WebAccessibilityObjectWrapperBase accessibilityMathPrescriptPairs]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSubscriptKey]):
(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSuperscriptKey]):

  • mathml/mathtags.in:

LayoutTests:

  • platform/mac/accessibility/mathml-multiscript-expected.txt: Added.
  • platform/mac/accessibility/mathml-multiscript.html: Added.
12:19 PM Changeset in webkit [151122] by zandobersek@gmail.com
  • 5 edits
    2 adds in trunk/LayoutTests

[Layout Tests] Update testharness scripts, add WebIDLParser.js and idlharness.js
​https://bugs.webkit.org/show_bug.cgi?id=116983

Reviewed by Sam Weinig.

Update the testharness scripts that are used by the W3C tests that are located under LayoutTests/http/tests/w3c. Also add the
WebIDLParser.js and idlharness.js scripts that will be used by tests imported in the future. The files are being updated or impoted
off the 06cab30bcee2 changeset in the ​http://w3c-test.org/resources repository.

No test is affected by this update, though some tests will require rebaselining due to the baselines containing stack traces of which
line numbers will change due to the updated scripts.

  • http/tests/w3c/README: List the currently-imported directories, noting from where they originate, at which changeset were

they imported and what files can or should be modified. Also note what script should be used to import/update the files, if available.

  • http/tests/w3c/resources/WebIDLParser.js: Added. Will be used by future tests imported from the W3C test suites.
  • http/tests/w3c/resources/idlharness.js: Ditto.
  • http/tests/w3c/resources/testharness.css: Updated.
  • http/tests/w3c/resources/testharness.js: Updated.
  • http/tests/w3c/resources/testharnessreport.js: Updated. Removed the default completion callback and readded

the completion callback that was in use until now.

11:33 AM Changeset in webkit [151121] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK1][CSS Regions] New test fast/regions/hover-on-child-parent-different-regions.html fails
​https://bugs.webkit.org/show_bug.cgi?id=117035

Forced relayout to ensure the hover event has propagated before checking the results.

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-03
Reviewed by Alexandru Chiculita.

  • fast/regions/hover-on-child-parent-different-regions.html:
11:31 AM Changeset in webkit [151120] by andersca@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Add radar number to ChangeLog.

11:30 AM Changeset in webkit [151119] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Send mouse events to the banner for as long as the mouse button is down
​https://bugs.webkit.org/show_bug.cgi?id=117161

Reviewed by Beth Dakin.

Keep track of whether the mouse was pressed in a banner and keep sending mouse events to it,
even if they are outside the banner's bounds for as long as the mouse is down.

  • WebProcess/WebPage/PageBanner.h:
  • WebProcess/WebPage/mac/PageBannerMac.mm:

(WebKit::PageBanner::PageBanner):
(WebKit::PageBanner::mouseEvent):

10:57 AM Changeset in webkit [151118] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Selection handles are not cleared when displaying error pages.
​https://bugs.webkit.org/show_bug.cgi?id=117158

Reviewed by Carlos Garcia Campos.

PR 342159.

Add explicit cancel of selection state when loading an error page
as it is not always cleared.

Internally Reviewed by Nima Ghanavatian.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):

10:31 AM Changeset in webkit [151117] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: node->parentNode(), Heap-use-after-free in WebCore::RenderBox::exclusionShapeOutsideInfo
​https://bugs.webkit.org/show_bug.cgi?id=117155

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-03
Reviewed by David Hyatt.

Source/WebCore:

Ported from a Blink patch by ​kenrb@chromium.org:

Clear floats on RenderBlocks that haven't had layout

WebKit revision 150084 creates a condition where a RenderBlock
can have a populated floating object list even when it has not
previously had layout. Since clearing of floats is optimized
to not search through parts of the tree that have not had layout,
references to floating objects were not being cleared in some cases.

This patch causes markAllDescendantsWithFloatsForLayout() to proceed
in the above case, in order to clear floats for a RenderBlock that has
not had layout.

Test: fast/block/float/float-list-changed-before-layout-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):

LayoutTests:

Test for crash. Note that this will only crash when run under a memory
checking tool like ASAN.

  • fast/block/float/float-list-changed-before-layout-crash-expected.txt: Added.
  • fast/block/float/float-list-changed-before-layout-crash.html: Added.
10:21 AM Changeset in webkit [151116] by commit-queue@webkit.org
  • 4 edits
    6 adds in trunk

[CSS Shapes] inset-rectangle support for shape-outside
​https://bugs.webkit.org/show_bug.cgi?id=116641

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-03
Reviewed by Alexandru Chiculita.

Source/WebCore:

Implement support for using inset-rectangles in a shape-outside.

Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle.html

fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle.html

  • rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape): An inset-rectangle is

simply a rectangle with the dimensions calculated differently. So
just use ExclusionRectangle after converting the dimensions.

  • rendering/ExclusionShapeOutsideInfo.cpp:

(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Enable inset

rectangles for shape-outside.

LayoutTests:

Add tests for inset-rectangles.

  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-percentage-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-percentage.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle.html: Added.
10:17 AM Changeset in webkit [151115] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] ROI details are not always cleared when using back navigation.
​https://bugs.webkit.org/show_bug.cgi?id=117159

Reviewed by Carlos Garcia Campos.

PR 328557.

Secondary change to ensure when restoreViewState is triggered
ROI is reset.

Internally Reviewed by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::restoreViewState):

8:45 AM Changeset in webkit [151114] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Slider UX updates.
​https://bugs.webkit.org/show_bug.cgi?id=117148

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-06-03
Reviewed by Rob Buis.

BlackBerry PR 342328
Internally Reviewed by Jeff Rogers.

Change image and reduce handle size when it is disabled.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintSliderTrack):
(WebCore::RenderThemeBlackBerry::paintSliderThumb):

7:45 AM Changeset in webkit [151113] by zarvai@inf.u-szeged.hu
  • 2 edits
    17 adds in trunk/LayoutTests

[Qt] [WK2] Unreviewed gardening. Unskipping passing tests and generate new test expectations where needed.

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-06-03

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/video-opacity-overlay-expected.txt: Added.
  • platform/qt-5.0-wk2/editing/spelling/grammar-markers-expected.png: Added.
  • platform/qt-5.0-wk2/editing/spelling/grammar-markers-expected.txt: Added.
  • platform/qt-5.0-wk2/editing/spelling/grammar-markers-hidpi-expected.png: Added.
  • platform/qt-5.0-wk2/editing/spelling/grammar-markers-hidpi-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
7:26 AM Changeset in webkit [151112] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] accessibility/placeholder.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=112031

Unreviewed EFL gardening.

accessibility/placeholder.html passes after r151103.

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-06-03

  • platform/efl-wk2/TestExpectations:
6:58 AM Changeset in webkit [151111] by commit-queue@webkit.org
  • 11 edits in trunk

Unreviewed, rolling out r151109.
​http://trac.webkit.org/changeset/151109
​https://bugs.webkit.org/show_bug.cgi?id=117145

"Plugins in WK2 aren't implemented yet." (Requested by
jturcotte on #webkit).

Source/WebCore:

  • platform/FileSystem.h:
  • platform/qt/FileSystemQt.cpp:

(WebCore::unloadModule):

  • plugins/mac/PluginPackageMac.cpp:

(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):

  • plugins/mac/PluginViewMac.mm:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::windowResizerRect):

Tools:

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/unix/default_pre.prf:
6:37 AM Changeset in webkit [151110] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION (r143070): Overflow:scroll content does not get clipped properly when the parent box has CSS3 filter on.
​https://bugs.webkit.org/show_bug.cgi?id=116859

Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-03
Reviewed by Simon Fraser.

Apply proper clipping for overflow:scroll, when parent dictates
full repaint to ensure correct CSS3 filter effect.

When a particular layer has 'pixel moving' CSS3 filter(drop shadow, blur), it sets clipToDirtyRect
to false to force no clipping on itself and on the child layers too.
No clipping makes overflow:scroll behave like overflow:display, because
overflow::scroll gets clipped at RenderLayer level (as opposed to overflow::hidden).
This patch makes sure that both full repaint and clipping are ensured.

Source/WebCore:

Tests: css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-parent.html

css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

LayoutTests:

  • css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-expected.html: Added.
  • css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-parent-expected.html: Added.
  • css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-parent.html: Added.
  • css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html: Added.
6:13 AM Changeset in webkit [151109] by jocelyn.turcotte@digia.com
  • 11 edits in trunk

[Qt] Re-enable plugins on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=116622

Reviewed by Tor Arne Vestbø.

Source/WebCore:

  • platform/FileSystem.h:
  • platform/qt/FileSystemQt.cpp:

(WebCore::unloadModule):

  • Q_WS_* aren't defined since Qt5, use Q_OS_MACX instead.
  • plugins/mac/PluginPackageMac.cpp:

(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):

  • createCFString now does the adoption itself.
  • plugins/mac/PluginViewMac.mm:
    • Add missing include.

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::windowResizerRect):

  • Add missing parenthese.

Tools:

Plugins on Mac were only enabled if !embedded but the later was set if
QPA is enabled, which is the default since Qt 5.0.

Remove references to 'embedded' and fix various build issues,
PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
months.

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/unix/default_pre.prf:
6:12 AM Changeset in webkit [151108] by kangil.han@samsung.com
  • 2 edits in trunk/LayoutTests

[EFL] Remove obsolete test case from TestExpectations

Unreviewed EFL gardening.

xmlviewer/extensions-api.html case has been removed since r151080.

  • platform/efl/TestExpectations:
6:12 AM Changeset in webkit [151107] by jocelyn.turcotte@digia.com
  • 4 edits in trunk/Source/WebCore

[Qt][Mac] Allow drawing plugins with QWindow by always using an intermediate bitmap.
​https://bugs.webkit.org/show_bug.cgi?id=116620

Reviewed by Tor Arne Vestbø.

The isolation of QWidget along with QPA in Qt5 is abstracting away the native CGContext
of a QWidget and we would need to create a non-public API to be able to achieve it.
Instead of adding complexity to this rarely touched code, always draw into an
intermediate bitmap that we then paint into our QPainter afterward.

  • Use CGBitmapContextCreate to allocate a buffer directly instead of creating a QPixmap and extract an CGContextRef out of it.
  • Get rid of the "if (platformPluginWidget())" code path since we don't paint directly into the QWidget's backing store anymore.
  • Always use m_contextRef to draw the plugin instead of alternating between direct and indirect drawing.
  • plugins/PluginView.cpp:

(WebCore::PluginView::PluginView):

  • plugins/PluginView.h:
  • plugins/mac/PluginViewMac.mm:

(WebCore::createBitmapContext):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::invalidateRect):

6:12 AM Changeset in webkit [151106] by jocelyn.turcotte@digia.com
  • 4 edits in trunk/Source/WebCore

[Qt][Mac] Remove Carbon and QuickDraw support for plugins.
​https://bugs.webkit.org/show_bug.cgi?id=116619

Reviewed by Tor Arne Vestbø.

They are only enabled for 32bit builds of QtWebKit and are rarely tested.
Other browsers support them through a 32bit host process.
PluginViewMac.mm is only used by Qt since the Wx port was removed.

  • Only support the Cocoa event model
  • Only support the CoreGraphics drawing model
  • Remove all NP_NO_CARBON and NP_NO_QUICKDRAW blocks in PluginViewMac.mm
  • plugins/PluginView.cpp:

(WebCore::PluginView::setValue):
(WebCore::PluginView::PluginView):

  • plugins/PluginView.h:
  • plugins/mac/PluginViewMac.mm:

(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleWheelEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::handleKeyboardEvent):

6:07 AM Changeset in webkit [151105] by zarvai@inf.u-szeged.hu
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk1/TestExpectations: Unskip after r151104.
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations: Skip crashing test.
5:52 AM Changeset in webkit [151104] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt][WK1][CSS Regions] New test fast/regions/hover-on-child-parent-different-regions.html fails
​https://bugs.webkit.org/show_bug.cgi?id=117035

Used waitUntilDone() to ensure correct results.

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-03
Reviewed by Antti Koivisto.

  • fast/regions/hover-on-child-parent-different-regions-expected.txt:
  • fast/regions/hover-on-child-parent-different-regions.html:
5:40 AM Changeset in webkit [151103] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK][WK2] accessibility/placeholder.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=106344

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-06-03
Reviewed by Gyuyoung Kim.

Tools:

Adds support for retrieving attribute value.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::coreAttributeToAtkAttribute):
(WTR::AccessibilityUIElement::stringAttributeValue):

LayoutTests:

Unskipping failing test. It's been fixed.

  • platform/gtk-wk2/TestExpectations:
5:38 AM Changeset in webkit [151102] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Unreviewed WinCE build fix after r150833.

  • wtf/DateMath.cpp:

(WTF::calculateDSTOffset):

4:47 AM Changeset in webkit [151101] by commit-queue@webkit.org
  • 4 edits in trunk

'onended' event is not received in AudioBufferSourceNode and OscillatorNode.
​https://bugs.webkit.org/show_bug.cgi?id=117132.

Patch by Praveen R Jadhav <​praveen.j@samsung.com> on 2013-06-03
Reviewed by Christophe Dumez.

Source/WebCore:

The listener argument is a PassRefPtr which becomes NULL after the call to
setAttributeEventListener() in setOnended(). This causes the m_hasEndedListener
boolean to be incorrectly initialized. This patch reverses the two statements so
that the m_hasEndedListener is updated before the call to setAttributeEventListener().

No new tests, already covered by existing tests.

  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::setOnended):

LayoutTests:

Unskip webaudio test cases that were failing due to the 'onended' event not being fired.

  • platform/efl/TestExpectations:
3:30 AM Changeset in webkit [151100] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL]<select> element's text is clipped when a height is specified along with CSS line-height.
​https://bugs.webkit.org/show_bug.cgi?id=114862

Patch by Rashmi Kulakarni <​rashmi.vijay@samsung.com> on 2013-06-03
Reviewed by Gyuyoung Kim.

Source/WebCore:

Fix <select> element getting clipped when element height becomes less than the line-height.
Set minimum height for <select> element.

No new tests, no behavior change.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):

LayoutTests:

Rebaselined the test case fast/forms/001.html.

  • platform/efl/fast/forms/001-expected.png:
  • platform/efl/fast/forms/001-expected.txt:
1:58 AM Changeset in webkit [151099] by charles.wei@torchmobile.com.cn
  • 5 edits
    4 adds in trunk

Source/WebCore: Webkit crashes while loading content from Application Cache.
​https://bugs.webkit.org/show_bug.cgi?id=116814

Reviewed by Darin Adler.

With the refacor for 112722, which removes MainResourceLoader and moves the functionality to DocumentLoader,
the processing of appcache for main resource error (because of network error) was moved DocumentLoader::
mainReceivedError(), which was trigged by ResourceHandle::didFail->SubResourceLoader::didFail, which already
in a Finishing state after notifying the DocumentLoader of the load failure.

Before patch for 112722, the appcache for main resource error was in MainResourceLoader::didFail(),
which will start processing the potential fallback before notifying DocumentLoader and moving the the state
of the resource loader to finishing state.

So we should move maybeLoadFallbackForMainError out of DocumentLoader::mainReceivedError, and move it to
ApplicationCacheHost::maybeLoadFallbackForError, if the resource that has error is the main resource.

Test: http/tests/appcache/main-resource-fallback-for-network-error-crash.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::mainReceivedError):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::maybeLoadFallbackForError):

  • loader/appcache/ApplicationCacheHost.h:

LayoutTests: Webkit crashes while loading content from Application Cache.
​https://bugs.webkit.org/show_bug.cgi?id=116814

Reviewed by Darin Adler.

  • http/tests/appcache/main-resource-fallback-for-network-error-crash-expected.txt: Added.
  • http/tests/appcache/main-resource-fallback-for-network-error-crash.html: Added.
  • http/tests/appcache/resources/main-resource-fallback-for-network-error-crash.manifest: Added.
  • http/tests/appcache/resources/success-and-notify-done.html: Added.
1:34 AM Changeset in webkit [151098] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Process launcher uses system() for wrapping the WebProcess when using WEB_PROCESS_CMD_PREFIX
​https://bugs.webkit.org/show_bug.cgi?id=105156

Patch by Sergio Correia <Sergio Correia> on 2013-06-03
Reviewed by Christophe Dumez.

When using WEB_PROCESS_CMD_PREFIX - which allows us for instance to analyze
WebProcess under tools like valgrind or gdb -, the ProcessLauncher would
spawn the new process using system(), which would, among other things, keep
an extra UIProcess waiting and executing the shell.

This patch handles the normal case and the case where we have something to
prefix WebProcess (i.e., by using WEB_PROCESS_CMD_PREFIX in a debug build)
the same way, through a call to execvp().

To achieve this a function was introduced to create an array with the given
arguments to the full command to be executed, to be used by execvp(). We use
a Vector<OwnArrayPtr<char>>, so that we can take advantage of the destructor
of OwnArrayPtr to handle the memory deallocation when it goes out of scope.

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::createArgsArray): This function creates the array to be used by
execvp(), out of the Strings given as arguments.
(WebKit::ProcessLauncher::launchProcess): Rework the logic to accomodate
both the cases with and without WEB_PROCESS_CMD_PREFIX. The execl() call
was replaced with an execvp() call, since now we should deal with having
a variable number of arguments (WEB_PROCESS_CMD_PREFIX) as well.

1:02 AM Changeset in webkit [151097] by Christophe Dumez
  • 5 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline 2 printing test cases on EFL port.

  • platform/efl/printing/compositing-layer-printing-expected.png:
  • platform/efl/printing/compositing-layer-printing-expected.txt:
  • platform/efl/printing/page-rule-in-media-query-expected.png:
  • platform/efl/printing/page-rule-in-media-query-expected.txt:
12:48 AM Changeset in webkit [151096] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip 2 webaudio tests that are failing due to the onended event not getting
fired.

  • platform/efl/TestExpectations:
12:44 AM Changeset in webkit [151095] by Christophe Dumez
  • 11 edits
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline several test cases on EFL.

  • platform/efl-wk2/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • platform/efl-wk2/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
  • platform/efl-wk2/fast/dynamic/002-expected.txt:
  • platform/efl/fast/block/float/float-not-removed-from-next-sibling2-expected.png:
  • platform/efl/fast/block/float/float-not-removed-from-next-sibling2-expected.txt:
  • platform/efl/fast/dynamic/002-expected.png:
  • platform/efl/fast/table/007-expected.png:
  • platform/efl/fast/table/007-expected.txt:
  • platform/efl/fast/table/colspanMinWidth-expected.png:
  • platform/efl/fast/table/colspanMinWidth-expected.txt:
  • platform/efl/fast/table/spanOverlapRepaint-expected.png:
  • platform/efl/fast/table/spanOverlapRepaint-expected.txt:
12:14 AM Changeset in webkit [151094] by Christophe Dumez
  • 37 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline several mozilla tables layout tests for EFL port.

  • platform/efl/tables/mozilla/bugs/bug13169-expected.png:
  • platform/efl/tables/mozilla/bugs/bug13169-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug133756-1-expected.png:
  • platform/efl/tables/mozilla/bugs/bug133756-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug133756-2-expected.png:
  • platform/efl/tables/mozilla/bugs/bug133756-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug17138-expected.png:
  • platform/efl/tables/mozilla/bugs/bug17138-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug17548-expected.png:
  • platform/efl/tables/mozilla/bugs/bug17548-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug220536-expected.png:
  • platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug6304-expected.png:
  • platform/efl/tables/mozilla/bugs/bug6304-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug73321-expected.png:
  • platform/efl/tables/mozilla/bugs/bug73321-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug7714-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug8858-expected.png:
  • platform/efl/tables/mozilla/bugs/bug8858-expected.txt:
  • platform/efl/tables/mozilla/core/bloomberg-expected.png:
  • platform/efl/tables/mozilla/core/bloomberg-expected.txt:
  • platform/efl/tables/mozilla/core/cell_heights-expected.png:
  • platform/efl/tables/mozilla/core/cell_heights-expected.txt:
  • platform/efl/tables/mozilla/other/test6-expected.png:
  • platform/efl/tables/mozilla/other/test6-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
12:09 AM Changeset in webkit [151093] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WTF

[WTF] Add OwnArrayPtr vectortraits template
​https://bugs.webkit.org/show_bug.cgi?id=117131

Reviewed by Darin Adler.

To support Vector<OwnArrayPtr<P>>, which will be used by EFL port.

  • wtf/VectorTraits.h:

Jun 2, 2013:

10:32 PM Changeset in webkit [151092] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL Gardening.

  • platform/efl-wk2/TestExpectations: Unskipping some of webgl passing tests.
9:53 PM Changeset in webkit [151091] by commit-queue@webkit.org
  • 11 edits
    2 deletes in trunk/Source

[Qt] Move Qt port off legacy clipboard
​https://bugs.webkit.org/show_bug.cgi?id=116416

Patch by Arunprasad Rajkumar <​arurajku@cisco.com> on 2013-06-02
Reviewed by Darin Adler.

Source/WebCore:

No change in behavior, no new tests added.

  • Target.pri: Removed ClipboardQt.h and EditorQt.cpp from compilation.
  • dom/Clipboard.h:
  • editing/qt/EditorQt.cpp: Removed.
  • page/qt/EventHandlerQt.cpp: Use Clipboard::createForDragAndDrop().

(WebCore::EventHandler::createDraggingClipboard):

  • platform/Pasteboard.h:

(WebCore::Pasteboard::clipboardData): Expose writable QMimeData* to outside, so that it is accessible
from DragClientQt.cpp and WebDragClientQt.cpp.
(WebCore::Pasteboard::invalidateWritableData):
(WebCore::Pasteboard::isForDragAndDrop):
(WebCore::Pasteboard::isForCopyAndPaste):

  • platform/qt/ClipboardQt.cpp:

(WebCore::Clipboard::createDragImage):
(WebCore::Clipboard::declareAndWriteDragImage):

  • platform/qt/ClipboardQt.h: Removed.
  • platform/qt/PasteboardQt.cpp: Moved required methods from ClipboardQt.cpp.

(WebCore::isTextMimeType):
(WebCore::isHtmlMimeType):
(WebCore::Pasteboard::create):
(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createPrivate):
(WebCore::Pasteboard::createForDragAndDrop):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::~Pasteboard):
(WebCore::Pasteboard::generalPasteboard):
(WebCore::Pasteboard::isSelectionMode):
(WebCore::Pasteboard::setSelectionMode):
(WebCore::Pasteboard::readData):
(WebCore::Pasteboard::hasData):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::writeString):
(WebCore::Pasteboard::types):
(WebCore::Pasteboard::readFilenames):
(WebCore::Pasteboard::setDragImage):
(WebCore::Pasteboard::writePasteboard):

Source/WebKit/qt:

  • WebCoreSupport/DragClientQt.cpp:

(WebCore::DragClientQt::startDrag):

Source/WebKit2:

  • WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:

(WebKit::WebDragClient::startDrag):

9:14 PM Changeset in webkit [151090] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source

Versioning.

9:13 PM Changeset in webkit [151089] by Lucas Forschler
  • 1 copy in tags/Safari-537.43.7

New Tag.

6:43 PM Changeset in webkit [151088] by beidson@apple.com
  • 3 edits
    3 adds in trunk

Going "back" to a cached page from a page with a main resource error breaks scrolling, amongst other issues.
<rdar://problem/13751844> and ​https://bugs.webkit.org/show_bug.cgi?id=117112

Reviewed by Alexey Proskuryakov.

Source/WebCore:

If a main resource load ends in error, the Document's parser is never cleared out.

If you then return to a CachedPage, we run the Document->clearParser() step for the
old page and that incorrectly dispatches didFinishLoad for the previous page load
in the middle of the load for the cached page.

The parser should never be needed after a load completes (even if it fails) and
holding on to the parser after the page load failed but before a new navigation is
actually using unnecessary resources.

So we should just clear the parser right when the main resource fails.

Test: http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoading): After canceling the main resource load, also clear the parser.

LayoutTests:

  • http/tests/loading/resources/resource-that-goes-back-while-still-loading.php: Added.
  • http/tests/loading/unfinished-load-back-to-cached-page-callbacks-expected.txt: Added.
  • http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html: Added.
4:34 PM Changeset in webkit [151087] by sfalken@apple.com
  • 1 edit in branches/safari-537.43-branch/Source/WebCore/ChangeLog

Fix typo in ChangeLog

4:33 PM Changeset in webkit [151086] by sfalken@apple.com
  • 6 edits in branches/safari-537.43-branch/Source/WebCore

Rollout r151084

2:32 PM Changeset in webkit [151085] by weinig@apple.com
  • 6 edits in branches/safari-537.43-branch/Source/WebCore

Merged r151076. <rdar://problem/14042030>

1:37 PM Changeset in webkit [151084] by ap@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

The empty directory did not get deleted by commit queue, deleting manually.

  • xmlviewer: Removed.
  • xmlviewer/resources: Removed.
12:08 PM Changeset in webkit [151083] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[CMake] Unreviewed buildfix after r148896 and r150940.

  • CMakeLists.txt:
10:29 AM Changeset in webkit [151082] by fpizlo@apple.com
  • 6 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Get rid of StructureStubInfo::bytecodeIndex
​https://bugs.webkit.org/show_bug.cgi?id=117127

Reviewed by Mark Hahnenberg.

StructureStubInfo already has a CodeOrigin field, which also has a bytecodeIndex.
It makes sense to just always use the CodeOrigin.

  • bytecode/StructureStubInfo.h:

(StructureStubInfo):
(JSC::getStructureStubInfoBytecodeIndex):

  • jit/JIT.cpp:

(JSC::PropertyStubCompilationInfo::copyToStubInfo):

  • jit/JIT.h:

(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

1:33 AM Changeset in webkit [151081] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][CoordinatedGraphics]: Use a properly initialized WebPage when creating a PageClient
​https://bugs.webkit.org/show_bug.cgi?id=117116

Patch by Sergio Correia <Sergio Correia> on 2013-06-02
Reviewed by Tim Horton.

Valgrind reported a "conditional jump or move depends on uninitialised value"
at WebPageProxy constructor, when checking the m_isVisible variable inside
the ENABLE(PAGE_VISIBILITY_API) guard.

The issue was tracked down to the WebView constructor, which was creating a
WebKit::PageClient* making use of `this' before having initialized all of its
attributes.

The solution was to move the initialization of the `page' member to inside the
constructor itself - out of the initialization list -, where we can guarantee
all the relevant stuff has already been properly initialized.

Here's the relevant valgrind trace for reference:

Conditional jump or move depends on uninitialised value(s)

at 0x65A35A4: WebKit::WebPageProxy::WebPageProxy(WebKit::PageClient*,

WTF::PassRefPtr<WebKit::WebProcessProxy>,
WebKit::WebPageGroup*, unsigned long) (WebPageProxy.cpp:322)

by 0x65A2BA2: WebKit::WebPageProxy::create(WebKit::PageClient*,

WTF::PassRefPtr<WebKit::WebProcessProxy>,
WebKit::WebPageGroup*, unsigned long) (WebPageProxy.cpp:233)

by 0x65E94BB: WebKit::WebProcessProxy::createWebPage(WebKit::PageClient*,

WebKit::WebContext*, WebKit::WebPageGroup*)
(WebProcessProxy.cpp:172)

by 0x6570957: WebKit::WebContext::createWebPage(WebKit::PageClient*,

WebKit::WebPageGroup*, WebKit::WebPageProxy*)
(WebContext.cpp:735)

by 0x67673E3: WebKit::WebView::WebView(WebKit::WebContext*,

WebKit::WebPageGroup*) (WebView.cpp:52)

by 0x6775F18: WebKit::WebViewEfl::WebViewEfl(WebKit::WebContext*,

WebKit::WebPageGroup*) (WebViewEfl.cpp:54)

by 0x6775EB4: WebKit::WebView::create(WebKit::WebContext*,

WebKit::WebPageGroup*) (WebViewEfl.cpp:49)

by 0x673E13D: WKViewCreate (WKView.cpp:33)
by 0x6763ECE: EWKViewCreate (ewk_view.cpp:92)

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):

1:14 AM Changeset in webkit [151080] by ap@apple.com
  • 4 edits
    2 adds
    3 deletes in trunk

Unstyled XML viewer crashes when XML contains an element with id="tree"
​https://bugs.webkit.org/show_bug.cgi?id=117117
<rdar://problem/13727267>

Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/xmlviewer/dumpAsText/existing-tree-element-crash.xml

  • xml/XMLViewer.css: Removed the rule to hide source document, as we no longer

keep it in the tree.

  • xml/XMLViewer.js:

(prepareWebKitXMLViewer): Make sourceXML a detached tree, as otherwise it can
have ID conflicts with elements we add.
(sourceXMLLoaded): Removed some commented out code. Removed code that was checking
whether an extension took over XML display, as it makes no sense to duplicate this
functionality in an extension.

LayoutTests:

  • http/tests/xmlviewer/dumpAsText/existing-tree-element-crash-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/existing-tree-element-crash.xml: Added.
  • xmlviewer: Removed.
  • xmlviewer/extensions-api-expected.txt: Removed.
  • xmlviewer/extensions-api.html: Removed.
  • xmlviewer/resources: Removed.
  • xmlviewer/resources/sample.xml: Removed.

The "API" no longer exists.

Note: See TracTimeline for information about the timeline view.